blob: da59e2884130cbfc8b128b5be6b222ca10da82b8 [file] [log] [blame]
Randy Dunlap98766fb2005-11-21 21:32:31 -08001Document about softnet driver issues
Linus Torvalds1da177e2005-04-16 15:20:36 -07002
3Transmit path guidelines:
4
Ben Hutchingse34fac12012-04-05 14:40:25 +000051) The ndo_start_xmit method must not return NETDEV_TX_BUSY under
6 any normal circumstances. It is considered a hard error unless
Linus Torvalds1da177e2005-04-16 15:20:36 -07007 there is no way your device can tell ahead of time when it's
8 transmit function will become busy.
9
10 Instead it must maintain the queue properly. For example,
11 for a driver implementing scatter-gather this means:
12
Ben Hutchingse34fac12012-04-05 14:40:25 +000013 static netdev_tx_t drv_hard_start_xmit(struct sk_buff *skb,
14 struct net_device *dev)
Linus Torvalds1da177e2005-04-16 15:20:36 -070015 {
Wang Chenb74ca3a2008-12-08 01:14:16 -080016 struct drv *dp = netdev_priv(dev);
Linus Torvalds1da177e2005-04-16 15:20:36 -070017
18 lock_tx(dp);
19 ...
20 /* This is a hard error log it. */
21 if (TX_BUFFS_AVAIL(dp) <= (skb_shinfo(skb)->nr_frags + 1)) {
22 netif_stop_queue(dev);
23 unlock_tx(dp);
24 printk(KERN_ERR PFX "%s: BUG! Tx Ring full when queue awake!\n",
25 dev->name);
Ben Hutchingse34fac12012-04-05 14:40:25 +000026 return NETDEV_TX_BUSY;
Linus Torvalds1da177e2005-04-16 15:20:36 -070027 }
28
29 ... queue packet to card ...
30 ... update tx consumer index ...
31
32 if (TX_BUFFS_AVAIL(dp) <= (MAX_SKB_FRAGS + 1))
33 netif_stop_queue(dev);
34
35 ...
36 unlock_tx(dp);
37 ...
Ben Hutchingse34fac12012-04-05 14:40:25 +000038 return NETDEV_TX_OK;
Linus Torvalds1da177e2005-04-16 15:20:36 -070039 }
40
Matt LaPlanted6bc8ac2006-10-03 22:54:15 +020041 And then at the end of your TX reclamation event handling:
Linus Torvalds1da177e2005-04-16 15:20:36 -070042
43 if (netif_queue_stopped(dp->dev) &&
44 TX_BUFFS_AVAIL(dp) > (MAX_SKB_FRAGS + 1))
45 netif_wake_queue(dp->dev);
46
47 For a non-scatter-gather supporting card, the three tests simply become:
48
49 /* This is a hard error log it. */
50 if (TX_BUFFS_AVAIL(dp) <= 0)
51
52 and:
53
54 if (TX_BUFFS_AVAIL(dp) == 0)
55
56 and:
57
58 if (netif_queue_stopped(dp->dev) &&
59 TX_BUFFS_AVAIL(dp) > 0)
60 netif_wake_queue(dp->dev);
61
Ben Hutchingsde7aca12012-04-05 14:40:06 +0000622) An ndo_start_xmit method must not modify the shared parts of a
Matti Linnanvuorice3ba132008-01-15 06:25:27 -080063 cloned SKB.
64
Ben Hutchingse34fac12012-04-05 14:40:25 +0000653) Do not forget that once you return NETDEV_TX_OK from your
66 ndo_start_xmit method, it is your driver's responsibility to free
67 up the SKB and in some finite amount of time.
Linus Torvalds1da177e2005-04-16 15:20:36 -070068
69 For example, this means that it is not allowed for your TX
70 mitigation scheme to let TX packets "hang out" in the TX
71 ring unreclaimed forever if no new TX packets are sent.
72 This error can deadlock sockets waiting for send buffer room
73 to be freed up.
74
Ben Hutchingse34fac12012-04-05 14:40:25 +000075 If you return NETDEV_TX_BUSY from the ndo_start_xmit method, you
76 must not keep any reference to that SKB and you must not attempt
77 to free it up.
Linus Torvalds1da177e2005-04-16 15:20:36 -070078
79Probing guidelines:
80
811) Any hardware layer address you obtain for your device should
82 be verified. For example, for ethernet check it with
83 linux/etherdevice.h:is_valid_ether_addr()
84
85Close/stop guidelines:
86
Ben Hutchingsb3cf6542012-04-05 14:39:47 +0000871) After the ndo_stop routine has been called, the hardware must
Linus Torvalds1da177e2005-04-16 15:20:36 -070088 not receive or transmit any data. All in flight packets must
89 be aborted. If necessary, poll or wait for completion of
90 any reset commands.
91
Ben Hutchingsb3cf6542012-04-05 14:39:47 +0000922) The ndo_stop routine will be called by unregister_netdevice
Linus Torvalds1da177e2005-04-16 15:20:36 -070093 if device is still UP.