blob: deff1b64a08c36ef4857590e9913717488953014 [file] [log] [blame]
Linus Torvalds1da177e2005-04-16 15:20:36 -07001/*
2 * linux/mm/madvise.c
3 *
4 * Copyright (C) 1999 Linus Torvalds
5 * Copyright (C) 2002 Christoph Hellwig
6 */
7
8#include <linux/mman.h>
9#include <linux/pagemap.h>
10#include <linux/syscalls.h>
Prasanna Meda05b74382005-06-21 17:14:37 -070011#include <linux/mempolicy.h>
Andi Kleenafcf9382009-12-16 12:20:00 +010012#include <linux/page-isolation.h>
Linus Torvalds1da177e2005-04-16 15:20:36 -070013#include <linux/hugetlb.h>
Hugh Dickins3f31d072012-05-29 15:06:40 -070014#include <linux/falloc.h>
Alexey Dobriyane8edc6e2007-05-21 01:22:52 +040015#include <linux/sched.h>
Hugh Dickinsf8af4da2009-09-21 17:01:57 -070016#include <linux/ksm.h>
Hugh Dickins3f31d072012-05-29 15:06:40 -070017#include <linux/fs.h>
Linus Torvalds1da177e2005-04-16 15:20:36 -070018
19/*
Nick Piggin0a27a142007-05-06 14:49:53 -070020 * Any behaviour which results in changes to the vma->vm_flags needs to
21 * take mmap_sem for writing. Others, which simply traverse vmas, need
22 * to only take it for reading.
23 */
24static int madvise_need_mmap_write(int behavior)
25{
26 switch (behavior) {
27 case MADV_REMOVE:
28 case MADV_WILLNEED:
29 case MADV_DONTNEED:
30 return 0;
31 default:
32 /* be safe, default to 1. list exceptions explicitly */
33 return 1;
34 }
35}
36
37/*
Linus Torvalds1da177e2005-04-16 15:20:36 -070038 * We can potentially split a vm area into separate
39 * areas, each area with its own behavior.
40 */
Prasanna Meda05b74382005-06-21 17:14:37 -070041static long madvise_behavior(struct vm_area_struct * vma,
42 struct vm_area_struct **prev,
43 unsigned long start, unsigned long end, int behavior)
Linus Torvalds1da177e2005-04-16 15:20:36 -070044{
45 struct mm_struct * mm = vma->vm_mm;
46 int error = 0;
Prasanna Meda05b74382005-06-21 17:14:37 -070047 pgoff_t pgoff;
Hugh Dickins3866ea92009-09-21 17:01:52 -070048 unsigned long new_flags = vma->vm_flags;
Prasanna Medae798c6e2005-06-21 17:14:36 -070049
50 switch (behavior) {
Michael S. Tsirkinf8225662006-02-14 13:53:08 -080051 case MADV_NORMAL:
52 new_flags = new_flags & ~VM_RAND_READ & ~VM_SEQ_READ;
53 break;
Prasanna Medae798c6e2005-06-21 17:14:36 -070054 case MADV_SEQUENTIAL:
Michael S. Tsirkinf8225662006-02-14 13:53:08 -080055 new_flags = (new_flags & ~VM_RAND_READ) | VM_SEQ_READ;
Prasanna Medae798c6e2005-06-21 17:14:36 -070056 break;
57 case MADV_RANDOM:
Michael S. Tsirkinf8225662006-02-14 13:53:08 -080058 new_flags = (new_flags & ~VM_SEQ_READ) | VM_RAND_READ;
Prasanna Medae798c6e2005-06-21 17:14:36 -070059 break;
Michael S. Tsirkinf8225662006-02-14 13:53:08 -080060 case MADV_DONTFORK:
61 new_flags |= VM_DONTCOPY;
62 break;
63 case MADV_DOFORK:
Hugh Dickins3866ea92009-09-21 17:01:52 -070064 if (vma->vm_flags & VM_IO) {
65 error = -EINVAL;
66 goto out;
67 }
Michael S. Tsirkinf8225662006-02-14 13:53:08 -080068 new_flags &= ~VM_DONTCOPY;
Prasanna Medae798c6e2005-06-21 17:14:36 -070069 break;
Jason Baronaccb61f2012-03-23 15:02:51 -070070 case MADV_DONTDUMP:
71 new_flags |= VM_NODUMP;
72 break;
73 case MADV_DODUMP:
74 new_flags &= ~VM_NODUMP;
75 break;
Hugh Dickinsf8af4da2009-09-21 17:01:57 -070076 case MADV_MERGEABLE:
77 case MADV_UNMERGEABLE:
78 error = ksm_madvise(vma, start, end, behavior, &new_flags);
79 if (error)
80 goto out;
81 break;
Andrea Arcangeli0af4e982011-01-13 15:46:55 -080082 case MADV_HUGEPAGE:
Andrea Arcangelia664b2d2011-01-13 15:47:17 -080083 case MADV_NOHUGEPAGE:
Andrea Arcangeli60ab3242011-01-13 15:47:18 -080084 error = hugepage_madvise(vma, &new_flags, behavior);
Andrea Arcangeli0af4e982011-01-13 15:46:55 -080085 if (error)
86 goto out;
87 break;
Prasanna Medae798c6e2005-06-21 17:14:36 -070088 }
89
Prasanna Meda05b74382005-06-21 17:14:37 -070090 if (new_flags == vma->vm_flags) {
91 *prev = vma;
Hugh Dickins836d5ff2005-09-03 15:54:53 -070092 goto out;
Prasanna Meda05b74382005-06-21 17:14:37 -070093 }
94
95 pgoff = vma->vm_pgoff + ((start - vma->vm_start) >> PAGE_SHIFT);
96 *prev = vma_merge(mm, *prev, start, end, new_flags, vma->anon_vma,
97 vma->vm_file, pgoff, vma_policy(vma));
98 if (*prev) {
99 vma = *prev;
100 goto success;
101 }
102
103 *prev = vma;
Linus Torvalds1da177e2005-04-16 15:20:36 -0700104
105 if (start != vma->vm_start) {
106 error = split_vma(mm, vma, start, 1);
107 if (error)
108 goto out;
109 }
110
111 if (end != vma->vm_end) {
112 error = split_vma(mm, vma, end, 0);
113 if (error)
114 goto out;
115 }
116
Hugh Dickins836d5ff2005-09-03 15:54:53 -0700117success:
Linus Torvalds1da177e2005-04-16 15:20:36 -0700118 /*
119 * vm_flags is protected by the mmap_sem held in write mode.
120 */
Prasanna Medae798c6e2005-06-21 17:14:36 -0700121 vma->vm_flags = new_flags;
Linus Torvalds1da177e2005-04-16 15:20:36 -0700122
123out:
124 if (error == -ENOMEM)
125 error = -EAGAIN;
126 return error;
127}
128
129/*
130 * Schedule all required I/O operations. Do not wait for completion.
131 */
132static long madvise_willneed(struct vm_area_struct * vma,
Prasanna Meda05b74382005-06-21 17:14:37 -0700133 struct vm_area_struct ** prev,
Linus Torvalds1da177e2005-04-16 15:20:36 -0700134 unsigned long start, unsigned long end)
135{
136 struct file *file = vma->vm_file;
137
Suzuki1bef4002005-10-11 08:29:06 -0700138 if (!file)
139 return -EBADF;
140
Nick Piggin70688e42008-04-28 02:13:02 -0700141 if (file->f_mapping->a_ops->get_xip_mem) {
Carsten Ottefe77ba62005-06-23 22:05:29 -0700142 /* no bad return value, but ignore advice */
143 return 0;
144 }
145
Prasanna Meda05b74382005-06-21 17:14:37 -0700146 *prev = vma;
Linus Torvalds1da177e2005-04-16 15:20:36 -0700147 start = ((start - vma->vm_start) >> PAGE_SHIFT) + vma->vm_pgoff;
148 if (end > vma->vm_end)
149 end = vma->vm_end;
150 end = ((end - vma->vm_start) >> PAGE_SHIFT) + vma->vm_pgoff;
151
Wu Fengguangf7e839d2009-06-16 15:31:20 -0700152 force_page_cache_readahead(file->f_mapping, file, start, end - start);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700153 return 0;
154}
155
156/*
157 * Application no longer needs these pages. If the pages are dirty,
158 * it's OK to just throw them away. The app will be more careful about
159 * data it wants to keep. Be sure to free swap resources too. The
Fernando Luis Vazquez Cao7e6cbea2008-07-29 22:33:39 -0700160 * zap_page_range call sets things up for shrink_active_list to actually free
Linus Torvalds1da177e2005-04-16 15:20:36 -0700161 * these pages later if no one else has touched them in the meantime,
162 * although we could add these pages to a global reuse list for
Fernando Luis Vazquez Cao7e6cbea2008-07-29 22:33:39 -0700163 * shrink_active_list to pick up before reclaiming other pages.
Linus Torvalds1da177e2005-04-16 15:20:36 -0700164 *
165 * NB: This interface discards data rather than pushes it out to swap,
166 * as some implementations do. This has performance implications for
167 * applications like large transactional databases which want to discard
168 * pages in anonymous maps after committing to backing store the data
169 * that was kept in them. There is no reason to write this data out to
170 * the swap area if the application is discarding it.
171 *
172 * An interface that causes the system to free clean pages and flush
173 * dirty pages is already available as msync(MS_INVALIDATE).
174 */
175static long madvise_dontneed(struct vm_area_struct * vma,
Prasanna Meda05b74382005-06-21 17:14:37 -0700176 struct vm_area_struct ** prev,
Linus Torvalds1da177e2005-04-16 15:20:36 -0700177 unsigned long start, unsigned long end)
178{
Prasanna Meda05b74382005-06-21 17:14:37 -0700179 *prev = vma;
Linus Torvalds6aab3412005-11-28 14:34:23 -0800180 if (vma->vm_flags & (VM_LOCKED|VM_HUGETLB|VM_PFNMAP))
Linus Torvalds1da177e2005-04-16 15:20:36 -0700181 return -EINVAL;
182
183 if (unlikely(vma->vm_flags & VM_NONLINEAR)) {
184 struct zap_details details = {
185 .nonlinear_vma = vma,
186 .last_index = ULONG_MAX,
187 };
188 zap_page_range(vma, start, end - start, &details);
189 } else
190 zap_page_range(vma, start, end - start, NULL);
191 return 0;
192}
193
Badari Pulavartyf6b3ec22006-01-06 00:10:38 -0800194/*
195 * Application wants to free up the pages and associated backing store.
196 * This is effectively punching a hole into the middle of a file.
197 *
198 * NOTE: Currently, only shmfs/tmpfs is supported for this operation.
199 * Other filesystems return -ENOSYS.
200 */
201static long madvise_remove(struct vm_area_struct *vma,
Nick Piggin00e9fa22007-03-16 13:38:10 -0800202 struct vm_area_struct **prev,
Badari Pulavartyf6b3ec22006-01-06 00:10:38 -0800203 unsigned long start, unsigned long end)
204{
Hugh Dickins3f31d072012-05-29 15:06:40 -0700205 loff_t offset;
Hugh Dickins90ed52e2007-03-29 01:20:38 -0700206 int error;
Badari Pulavartyf6b3ec22006-01-06 00:10:38 -0800207
Hugh Dickins90ed52e2007-03-29 01:20:38 -0700208 *prev = NULL; /* tell sys_madvise we drop mmap_sem */
Nick Piggin00e9fa22007-03-16 13:38:10 -0800209
Badari Pulavartyf6b3ec22006-01-06 00:10:38 -0800210 if (vma->vm_flags & (VM_LOCKED|VM_NONLINEAR|VM_HUGETLB))
211 return -EINVAL;
212
213 if (!vma->vm_file || !vma->vm_file->f_mapping
214 || !vma->vm_file->f_mapping->host) {
215 return -EINVAL;
216 }
217
Hugh Dickins69cf0fa2006-04-17 22:46:32 +0100218 if ((vma->vm_flags & (VM_SHARED|VM_WRITE)) != (VM_SHARED|VM_WRITE))
219 return -EACCES;
220
Badari Pulavartyf6b3ec22006-01-06 00:10:38 -0800221 offset = (loff_t)(start - vma->vm_start)
222 + ((loff_t)vma->vm_pgoff << PAGE_SHIFT);
Hugh Dickins90ed52e2007-03-29 01:20:38 -0700223
Hugh Dickins3f31d072012-05-29 15:06:40 -0700224 /* filesystem's fallocate may need to take i_mutex */
Nick Piggin0a27a142007-05-06 14:49:53 -0700225 up_read(&current->mm->mmap_sem);
Hugh Dickins3f31d072012-05-29 15:06:40 -0700226 error = do_fallocate(vma->vm_file,
227 FALLOC_FL_PUNCH_HOLE | FALLOC_FL_KEEP_SIZE,
228 offset, end - start);
Nick Piggin0a27a142007-05-06 14:49:53 -0700229 down_read(&current->mm->mmap_sem);
Hugh Dickins90ed52e2007-03-29 01:20:38 -0700230 return error;
Badari Pulavartyf6b3ec22006-01-06 00:10:38 -0800231}
232
Andi Kleen9893e492009-09-16 11:50:17 +0200233#ifdef CONFIG_MEMORY_FAILURE
234/*
235 * Error injection support for memory error handling.
236 */
Andi Kleenafcf9382009-12-16 12:20:00 +0100237static int madvise_hwpoison(int bhv, unsigned long start, unsigned long end)
Andi Kleen9893e492009-09-16 11:50:17 +0200238{
239 int ret = 0;
240
241 if (!capable(CAP_SYS_ADMIN))
242 return -EPERM;
243 for (; start < end; start += PAGE_SIZE) {
244 struct page *p;
Andi Kleend15f1072009-12-16 12:20:00 +0100245 int ret = get_user_pages_fast(start, 1, 0, &p);
Andi Kleen9893e492009-09-16 11:50:17 +0200246 if (ret != 1)
247 return ret;
Andi Kleenafcf9382009-12-16 12:20:00 +0100248 if (bhv == MADV_SOFT_OFFLINE) {
249 printk(KERN_INFO "Soft offlining page %lx at %lx\n",
250 page_to_pfn(p), start);
251 ret = soft_offline_page(p, MF_COUNT_INCREASED);
252 if (ret)
253 break;
254 continue;
255 }
Andi Kleen9893e492009-09-16 11:50:17 +0200256 printk(KERN_INFO "Injecting memory failure for page %lx at %lx\n",
257 page_to_pfn(p), start);
258 /* Ignore return value for now */
Tony Luckcd42f4a2011-12-15 10:48:12 -0800259 memory_failure(page_to_pfn(p), 0, MF_COUNT_INCREASED);
Andi Kleen9893e492009-09-16 11:50:17 +0200260 }
261 return ret;
262}
263#endif
264
suzuki165cd402005-07-27 11:43:59 -0700265static long
266madvise_vma(struct vm_area_struct *vma, struct vm_area_struct **prev,
267 unsigned long start, unsigned long end, int behavior)
Linus Torvalds1da177e2005-04-16 15:20:36 -0700268{
Linus Torvalds1da177e2005-04-16 15:20:36 -0700269 switch (behavior) {
Badari Pulavartyf6b3ec22006-01-06 00:10:38 -0800270 case MADV_REMOVE:
Hugh Dickins3866ea92009-09-21 17:01:52 -0700271 return madvise_remove(vma, prev, start, end);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700272 case MADV_WILLNEED:
Hugh Dickins3866ea92009-09-21 17:01:52 -0700273 return madvise_willneed(vma, prev, start, end);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700274 case MADV_DONTNEED:
Hugh Dickins3866ea92009-09-21 17:01:52 -0700275 return madvise_dontneed(vma, prev, start, end);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700276 default:
Hugh Dickins3866ea92009-09-21 17:01:52 -0700277 return madvise_behavior(vma, prev, start, end, behavior);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700278 }
Linus Torvalds1da177e2005-04-16 15:20:36 -0700279}
280
Nick Piggin75927af2009-06-16 15:32:38 -0700281static int
282madvise_behavior_valid(int behavior)
283{
284 switch (behavior) {
285 case MADV_DOFORK:
286 case MADV_DONTFORK:
287 case MADV_NORMAL:
288 case MADV_SEQUENTIAL:
289 case MADV_RANDOM:
290 case MADV_REMOVE:
291 case MADV_WILLNEED:
292 case MADV_DONTNEED:
Hugh Dickinsf8af4da2009-09-21 17:01:57 -0700293#ifdef CONFIG_KSM
294 case MADV_MERGEABLE:
295 case MADV_UNMERGEABLE:
296#endif
Andrea Arcangeli0af4e982011-01-13 15:46:55 -0800297#ifdef CONFIG_TRANSPARENT_HUGEPAGE
298 case MADV_HUGEPAGE:
Andrea Arcangelia664b2d2011-01-13 15:47:17 -0800299 case MADV_NOHUGEPAGE:
Andrea Arcangeli0af4e982011-01-13 15:46:55 -0800300#endif
Jason Baronaccb61f2012-03-23 15:02:51 -0700301 case MADV_DONTDUMP:
302 case MADV_DODUMP:
Nick Piggin75927af2009-06-16 15:32:38 -0700303 return 1;
304
305 default:
306 return 0;
307 }
308}
Hugh Dickins3866ea92009-09-21 17:01:52 -0700309
Linus Torvalds1da177e2005-04-16 15:20:36 -0700310/*
311 * The madvise(2) system call.
312 *
313 * Applications can use madvise() to advise the kernel how it should
314 * handle paging I/O in this VM area. The idea is to help the kernel
315 * use appropriate read-ahead and caching techniques. The information
316 * provided is advisory only, and can be safely disregarded by the
317 * kernel without affecting the correct operation of the application.
318 *
319 * behavior values:
320 * MADV_NORMAL - the default behavior is to read clusters. This
321 * results in some read-ahead and read-behind.
322 * MADV_RANDOM - the system should read the minimum amount of data
323 * on any access, since it is unlikely that the appli-
324 * cation will need more than what it asks for.
325 * MADV_SEQUENTIAL - pages in the given range will probably be accessed
326 * once, so they can be aggressively read ahead, and
327 * can be freed soon after they are accessed.
328 * MADV_WILLNEED - the application is notifying the system to read
329 * some pages ahead.
330 * MADV_DONTNEED - the application is finished with the given range,
331 * so the kernel can free resources associated with it.
Badari Pulavartyf6b3ec22006-01-06 00:10:38 -0800332 * MADV_REMOVE - the application wants to free up the given range of
333 * pages and associated backing store.
Hugh Dickins3866ea92009-09-21 17:01:52 -0700334 * MADV_DONTFORK - omit this area from child's address space when forking:
335 * typically, to avoid COWing pages pinned by get_user_pages().
336 * MADV_DOFORK - cancel MADV_DONTFORK: no longer omit this area when forking.
Hugh Dickinsf8af4da2009-09-21 17:01:57 -0700337 * MADV_MERGEABLE - the application recommends that KSM try to merge pages in
338 * this area with pages of identical content from other such areas.
339 * MADV_UNMERGEABLE- cancel MADV_MERGEABLE: no longer merge pages with others.
Linus Torvalds1da177e2005-04-16 15:20:36 -0700340 *
341 * return values:
342 * zero - success
343 * -EINVAL - start + len < 0, start is not page-aligned,
344 * "behavior" is not a valid value, or application
345 * is attempting to release locked or shared pages.
346 * -ENOMEM - addresses in the specified range are not currently
347 * mapped, or are outside the AS of the process.
348 * -EIO - an I/O error occurred while paging in data.
349 * -EBADF - map exists, but area maps something that isn't a file.
350 * -EAGAIN - a kernel resource was temporarily unavailable.
351 */
Heiko Carstens3480b252009-01-14 14:14:16 +0100352SYSCALL_DEFINE3(madvise, unsigned long, start, size_t, len_in, int, behavior)
Linus Torvalds1da177e2005-04-16 15:20:36 -0700353{
Prasanna Meda05b74382005-06-21 17:14:37 -0700354 unsigned long end, tmp;
355 struct vm_area_struct * vma, *prev;
Linus Torvalds1da177e2005-04-16 15:20:36 -0700356 int unmapped_error = 0;
357 int error = -EINVAL;
Jason Baronf7977792007-07-15 23:38:21 -0700358 int write;
Linus Torvalds1da177e2005-04-16 15:20:36 -0700359 size_t len;
360
Andi Kleen9893e492009-09-16 11:50:17 +0200361#ifdef CONFIG_MEMORY_FAILURE
Andi Kleenafcf9382009-12-16 12:20:00 +0100362 if (behavior == MADV_HWPOISON || behavior == MADV_SOFT_OFFLINE)
363 return madvise_hwpoison(behavior, start, start+len_in);
Andi Kleen9893e492009-09-16 11:50:17 +0200364#endif
Nick Piggin75927af2009-06-16 15:32:38 -0700365 if (!madvise_behavior_valid(behavior))
366 return error;
367
Jason Baronf7977792007-07-15 23:38:21 -0700368 write = madvise_need_mmap_write(behavior);
369 if (write)
Nick Piggin0a27a142007-05-06 14:49:53 -0700370 down_write(&current->mm->mmap_sem);
371 else
372 down_read(&current->mm->mmap_sem);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700373
374 if (start & ~PAGE_MASK)
375 goto out;
376 len = (len_in + ~PAGE_MASK) & PAGE_MASK;
377
378 /* Check to see whether len was rounded up from small -ve to zero */
379 if (len_in && !len)
380 goto out;
381
382 end = start + len;
383 if (end < start)
384 goto out;
385
386 error = 0;
387 if (end == start)
388 goto out;
389
390 /*
391 * If the interval [start,end) covers some unmapped address
392 * ranges, just ignore them, but return -ENOMEM at the end.
Prasanna Meda05b74382005-06-21 17:14:37 -0700393 * - different from the way of handling in mlock etc.
Linus Torvalds1da177e2005-04-16 15:20:36 -0700394 */
Prasanna Meda05b74382005-06-21 17:14:37 -0700395 vma = find_vma_prev(current->mm, start, &prev);
Hugh Dickins836d5ff2005-09-03 15:54:53 -0700396 if (vma && start > vma->vm_start)
397 prev = vma;
398
Linus Torvalds1da177e2005-04-16 15:20:36 -0700399 for (;;) {
400 /* Still start < end. */
401 error = -ENOMEM;
402 if (!vma)
403 goto out;
404
Prasanna Meda05b74382005-06-21 17:14:37 -0700405 /* Here start < (end|vma->vm_end). */
Linus Torvalds1da177e2005-04-16 15:20:36 -0700406 if (start < vma->vm_start) {
407 unmapped_error = -ENOMEM;
408 start = vma->vm_start;
Prasanna Meda05b74382005-06-21 17:14:37 -0700409 if (start >= end)
410 goto out;
Linus Torvalds1da177e2005-04-16 15:20:36 -0700411 }
412
Prasanna Meda05b74382005-06-21 17:14:37 -0700413 /* Here vma->vm_start <= start < (end|vma->vm_end) */
414 tmp = vma->vm_end;
415 if (end < tmp)
416 tmp = end;
Linus Torvalds1da177e2005-04-16 15:20:36 -0700417
Prasanna Meda05b74382005-06-21 17:14:37 -0700418 /* Here vma->vm_start <= start < tmp <= (end|vma->vm_end). */
419 error = madvise_vma(vma, &prev, start, tmp, behavior);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700420 if (error)
421 goto out;
Prasanna Meda05b74382005-06-21 17:14:37 -0700422 start = tmp;
Hugh Dickins90ed52e2007-03-29 01:20:38 -0700423 if (prev && start < prev->vm_end)
Prasanna Meda05b74382005-06-21 17:14:37 -0700424 start = prev->vm_end;
425 error = unmapped_error;
426 if (start >= end)
427 goto out;
Hugh Dickins90ed52e2007-03-29 01:20:38 -0700428 if (prev)
429 vma = prev->vm_next;
430 else /* madvise_remove dropped mmap_sem */
431 vma = find_vma(current->mm, start);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700432 }
Linus Torvalds1da177e2005-04-16 15:20:36 -0700433out:
Jason Baronf7977792007-07-15 23:38:21 -0700434 if (write)
Nick Piggin0a27a142007-05-06 14:49:53 -0700435 up_write(&current->mm->mmap_sem);
436 else
437 up_read(&current->mm->mmap_sem);
438
Linus Torvalds1da177e2005-04-16 15:20:36 -0700439 return error;
440}