Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2014 Red Hat |
| 3 | * Author: Rob Clark <robdclark@gmail.com> |
| 4 | * |
| 5 | * This program is free software; you can redistribute it and/or modify it |
| 6 | * under the terms of the GNU General Public License version 2 as published by |
| 7 | * the Free Software Foundation. |
| 8 | * |
| 9 | * This program is distributed in the hope that it will be useful, but WITHOUT |
| 10 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
| 11 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for |
| 12 | * more details. |
| 13 | * |
| 14 | * You should have received a copy of the GNU General Public License along with |
| 15 | * this program. If not, see <http://www.gnu.org/licenses/>. |
| 16 | */ |
| 17 | |
| 18 | #include "msm_drv.h" |
| 19 | #include "msm_kms.h" |
| 20 | #include "msm_gem.h" |
Rob Clark | fde5de6 | 2016-03-15 15:35:08 -0400 | [diff] [blame] | 21 | #include "msm_fence.h" |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 22 | |
| 23 | struct msm_commit { |
Rob Clark | 0b776d4 | 2015-01-30 17:04:45 -0500 | [diff] [blame] | 24 | struct drm_device *dev; |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 25 | struct drm_atomic_state *state; |
Rob Clark | ba00c3f | 2016-03-16 18:18:17 -0400 | [diff] [blame] | 26 | struct work_struct work; |
Rob Clark | f86afec | 2014-11-25 12:41:18 -0500 | [diff] [blame] | 27 | uint32_t crtc_mask; |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 28 | }; |
| 29 | |
Rob Clark | ba00c3f | 2016-03-16 18:18:17 -0400 | [diff] [blame] | 30 | static void commit_worker(struct work_struct *work); |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 31 | |
Rob Clark | f86afec | 2014-11-25 12:41:18 -0500 | [diff] [blame] | 32 | /* block until specified crtcs are no longer pending update, and |
| 33 | * atomically mark them as pending update |
| 34 | */ |
| 35 | static int start_atomic(struct msm_drm_private *priv, uint32_t crtc_mask) |
| 36 | { |
| 37 | int ret; |
| 38 | |
| 39 | spin_lock(&priv->pending_crtcs_event.lock); |
| 40 | ret = wait_event_interruptible_locked(priv->pending_crtcs_event, |
| 41 | !(priv->pending_crtcs & crtc_mask)); |
| 42 | if (ret == 0) { |
| 43 | DBG("start: %08x", crtc_mask); |
| 44 | priv->pending_crtcs |= crtc_mask; |
| 45 | } |
| 46 | spin_unlock(&priv->pending_crtcs_event.lock); |
| 47 | |
| 48 | return ret; |
| 49 | } |
| 50 | |
| 51 | /* clear specified crtcs (no longer pending update) |
| 52 | */ |
| 53 | static void end_atomic(struct msm_drm_private *priv, uint32_t crtc_mask) |
| 54 | { |
| 55 | spin_lock(&priv->pending_crtcs_event.lock); |
| 56 | DBG("end: %08x", crtc_mask); |
| 57 | priv->pending_crtcs &= ~crtc_mask; |
| 58 | wake_up_all_locked(&priv->pending_crtcs_event); |
| 59 | spin_unlock(&priv->pending_crtcs_event.lock); |
| 60 | } |
| 61 | |
Rob Clark | 0b776d4 | 2015-01-30 17:04:45 -0500 | [diff] [blame] | 62 | static struct msm_commit *commit_init(struct drm_atomic_state *state) |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 63 | { |
| 64 | struct msm_commit *c = kzalloc(sizeof(*c), GFP_KERNEL); |
| 65 | |
| 66 | if (!c) |
| 67 | return NULL; |
| 68 | |
Rob Clark | 0b776d4 | 2015-01-30 17:04:45 -0500 | [diff] [blame] | 69 | c->dev = state->dev; |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 70 | c->state = state; |
Rob Clark | 0b776d4 | 2015-01-30 17:04:45 -0500 | [diff] [blame] | 71 | |
Rob Clark | ba00c3f | 2016-03-16 18:18:17 -0400 | [diff] [blame] | 72 | INIT_WORK(&c->work, commit_worker); |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 73 | |
| 74 | return c; |
| 75 | } |
| 76 | |
Rob Clark | 0b776d4 | 2015-01-30 17:04:45 -0500 | [diff] [blame] | 77 | static void commit_destroy(struct msm_commit *c) |
| 78 | { |
| 79 | end_atomic(c->dev->dev_private, c->crtc_mask); |
| 80 | kfree(c); |
| 81 | } |
| 82 | |
Hai Li | 0a5c9aa | 2015-04-28 19:35:37 -0400 | [diff] [blame] | 83 | static void msm_atomic_wait_for_commit_done(struct drm_device *dev, |
| 84 | struct drm_atomic_state *old_state) |
| 85 | { |
| 86 | struct drm_crtc *crtc; |
Daniel Vetter | 8d76b79 | 2016-06-02 15:41:53 +0200 | [diff] [blame] | 87 | struct drm_crtc_state *crtc_state; |
Hai Li | 0a5c9aa | 2015-04-28 19:35:37 -0400 | [diff] [blame] | 88 | struct msm_drm_private *priv = old_state->dev->dev_private; |
| 89 | struct msm_kms *kms = priv->kms; |
Hai Li | 0a5c9aa | 2015-04-28 19:35:37 -0400 | [diff] [blame] | 90 | int i; |
| 91 | |
Daniel Vetter | 8d76b79 | 2016-06-02 15:41:53 +0200 | [diff] [blame] | 92 | for_each_crtc_in_state(old_state, crtc, crtc_state, i) { |
Hai Li | 0a5c9aa | 2015-04-28 19:35:37 -0400 | [diff] [blame] | 93 | if (!crtc->state->enable) |
| 94 | continue; |
| 95 | |
| 96 | /* Legacy cursor ioctls are completely unsynced, and userspace |
| 97 | * relies on that (by doing tons of cursor updates). */ |
| 98 | if (old_state->legacy_cursor_update) |
| 99 | continue; |
| 100 | |
| 101 | kms->funcs->wait_for_crtc_commit_done(kms, crtc); |
| 102 | } |
| 103 | } |
| 104 | |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 105 | /* The (potentially) asynchronous part of the commit. At this point |
| 106 | * nothing can fail short of armageddon. |
| 107 | */ |
Rob Clark | ba00c3f | 2016-03-16 18:18:17 -0400 | [diff] [blame] | 108 | static void complete_commit(struct msm_commit *c, bool async) |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 109 | { |
| 110 | struct drm_atomic_state *state = c->state; |
| 111 | struct drm_device *dev = state->dev; |
Rob Clark | 0b776d4 | 2015-01-30 17:04:45 -0500 | [diff] [blame] | 112 | struct msm_drm_private *priv = dev->dev_private; |
| 113 | struct msm_kms *kms = priv->kms; |
| 114 | |
Gustavo Padovan | f6ce410 | 2016-09-12 16:08:11 -0300 | [diff] [blame] | 115 | drm_atomic_helper_wait_for_fences(dev, state, false); |
Rob Clark | ba00c3f | 2016-03-16 18:18:17 -0400 | [diff] [blame] | 116 | |
Rob Clark | 0b776d4 | 2015-01-30 17:04:45 -0500 | [diff] [blame] | 117 | kms->funcs->prepare_commit(kms, state); |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 118 | |
Daniel Vetter | 1af434a | 2015-02-22 12:24:19 +0100 | [diff] [blame] | 119 | drm_atomic_helper_commit_modeset_disables(dev, state); |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 120 | |
Liu Ying | 2b58e98 | 2016-08-29 17:12:03 +0800 | [diff] [blame] | 121 | drm_atomic_helper_commit_planes(dev, state, 0); |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 122 | |
Daniel Vetter | 1af434a | 2015-02-22 12:24:19 +0100 | [diff] [blame] | 123 | drm_atomic_helper_commit_modeset_enables(dev, state); |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 124 | |
Rob Clark | f86afec | 2014-11-25 12:41:18 -0500 | [diff] [blame] | 125 | /* NOTE: _wait_for_vblanks() only waits for vblank on |
| 126 | * enabled CRTCs. So we end up faulting when disabling |
| 127 | * due to (potentially) unref'ing the outgoing fb's |
| 128 | * before the vblank when the disable has latched. |
| 129 | * |
| 130 | * But if it did wait on disabled (or newly disabled) |
| 131 | * CRTCs, that would be racy (ie. we could have missed |
| 132 | * the irq. We need some way to poll for pipe shut |
| 133 | * down. Or just live with occasionally hitting the |
| 134 | * timeout in the CRTC disable path (which really should |
| 135 | * not be critical path) |
| 136 | */ |
| 137 | |
Hai Li | 0a5c9aa | 2015-04-28 19:35:37 -0400 | [diff] [blame] | 138 | msm_atomic_wait_for_commit_done(dev, state); |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 139 | |
| 140 | drm_atomic_helper_cleanup_planes(dev, state); |
| 141 | |
Rob Clark | 0b776d4 | 2015-01-30 17:04:45 -0500 | [diff] [blame] | 142 | kms->funcs->complete_commit(kms, state); |
| 143 | |
Chris Wilson | 0853695 | 2016-10-14 13:18:18 +0100 | [diff] [blame] | 144 | drm_atomic_state_put(state); |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 145 | |
Rob Clark | 0b776d4 | 2015-01-30 17:04:45 -0500 | [diff] [blame] | 146 | commit_destroy(c); |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 147 | } |
| 148 | |
Rob Clark | ba00c3f | 2016-03-16 18:18:17 -0400 | [diff] [blame] | 149 | static void commit_worker(struct work_struct *work) |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 150 | { |
Rob Clark | ba00c3f | 2016-03-16 18:18:17 -0400 | [diff] [blame] | 151 | complete_commit(container_of(work, struct msm_commit, work), true); |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 152 | } |
| 153 | |
Archit Taneja | 3b6acf1 | 2017-01-16 11:46:17 +0530 | [diff] [blame^] | 154 | /* |
| 155 | * this func is identical to the drm_atomic_helper_check, but we keep this |
| 156 | * because we might eventually need to have a more finegrained check |
| 157 | * sequence without using the atomic helpers. |
| 158 | * |
| 159 | * In the past, we first called drm_atomic_helper_check_planes, and then |
| 160 | * drm_atomic_helper_check_modeset. We needed this because the MDP5 plane's |
| 161 | * ->atomic_check could update ->mode_changed for pixel format changes. |
| 162 | * This, however isn't needed now because if there is a pixel format change, |
| 163 | * we just assign a new hwpipe for it with a new SMP allocation. We might |
| 164 | * eventually hit a condition where we would need to do a full modeset if |
| 165 | * we run out of planes. There, we'd probably need to set mode_changed. |
| 166 | */ |
Daniel Vetter | b4274fb | 2014-11-26 17:02:18 +0100 | [diff] [blame] | 167 | int msm_atomic_check(struct drm_device *dev, |
| 168 | struct drm_atomic_state *state) |
| 169 | { |
| 170 | int ret; |
| 171 | |
Archit Taneja | 3b6acf1 | 2017-01-16 11:46:17 +0530 | [diff] [blame^] | 172 | ret = drm_atomic_helper_check_modeset(dev, state); |
Daniel Vetter | b4274fb | 2014-11-26 17:02:18 +0100 | [diff] [blame] | 173 | if (ret) |
| 174 | return ret; |
| 175 | |
Archit Taneja | 3b6acf1 | 2017-01-16 11:46:17 +0530 | [diff] [blame^] | 176 | ret = drm_atomic_helper_check_planes(dev, state); |
Daniel Vetter | b4274fb | 2014-11-26 17:02:18 +0100 | [diff] [blame] | 177 | if (ret) |
| 178 | return ret; |
| 179 | |
| 180 | return ret; |
| 181 | } |
| 182 | |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 183 | /** |
| 184 | * drm_atomic_helper_commit - commit validated state object |
| 185 | * @dev: DRM device |
| 186 | * @state: the driver state object |
Maarten Lankhorst | a3ccfb9 | 2016-04-26 16:11:38 +0200 | [diff] [blame] | 187 | * @nonblock: nonblocking commit |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 188 | * |
| 189 | * This function commits a with drm_atomic_helper_check() pre-validated state |
Maarten Lankhorst | a3ccfb9 | 2016-04-26 16:11:38 +0200 | [diff] [blame] | 190 | * object. This can still fail when e.g. the framebuffer reservation fails. |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 191 | * |
| 192 | * RETURNS |
| 193 | * Zero for success or -errno. |
| 194 | */ |
| 195 | int msm_atomic_commit(struct drm_device *dev, |
Maarten Lankhorst | a3ccfb9 | 2016-04-26 16:11:38 +0200 | [diff] [blame] | 196 | struct drm_atomic_state *state, bool nonblock) |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 197 | { |
Rob Clark | ca762a8 | 2016-03-15 17:22:13 -0400 | [diff] [blame] | 198 | struct msm_drm_private *priv = dev->dev_private; |
Rob Clark | f86afec | 2014-11-25 12:41:18 -0500 | [diff] [blame] | 199 | struct msm_commit *c; |
Daniel Vetter | 8d76b79 | 2016-06-02 15:41:53 +0200 | [diff] [blame] | 200 | struct drm_crtc *crtc; |
| 201 | struct drm_crtc_state *crtc_state; |
| 202 | struct drm_plane *plane; |
| 203 | struct drm_plane_state *plane_state; |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 204 | int i, ret; |
| 205 | |
| 206 | ret = drm_atomic_helper_prepare_planes(dev, state); |
| 207 | if (ret) |
| 208 | return ret; |
| 209 | |
Rob Clark | 0b776d4 | 2015-01-30 17:04:45 -0500 | [diff] [blame] | 210 | c = commit_init(state); |
Laurent Pinchart | f65c18c | 2015-05-27 14:39:46 +0300 | [diff] [blame] | 211 | if (!c) { |
| 212 | ret = -ENOMEM; |
| 213 | goto error; |
| 214 | } |
Rob Clark | f86afec | 2014-11-25 12:41:18 -0500 | [diff] [blame] | 215 | |
| 216 | /* |
| 217 | * Figure out what crtcs we have: |
| 218 | */ |
Daniel Vetter | 8d76b79 | 2016-06-02 15:41:53 +0200 | [diff] [blame] | 219 | for_each_crtc_in_state(state, crtc, crtc_state, i) |
| 220 | c->crtc_mask |= drm_crtc_mask(crtc); |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 221 | |
| 222 | /* |
Rob Clark | b6295f9 | 2016-03-15 18:26:28 -0400 | [diff] [blame] | 223 | * Figure out what fence to wait for: |
| 224 | */ |
Daniel Vetter | 8d76b79 | 2016-06-02 15:41:53 +0200 | [diff] [blame] | 225 | for_each_plane_in_state(state, plane, plane_state, i) { |
| 226 | if ((plane->state->fb != plane_state->fb) && plane_state->fb) { |
| 227 | struct drm_gem_object *obj = msm_framebuffer_bo(plane_state->fb, 0); |
Rob Clark | b6295f9 | 2016-03-15 18:26:28 -0400 | [diff] [blame] | 228 | struct msm_gem_object *msm_obj = to_msm_bo(obj); |
Gustavo Padovan | 5d58698 | 2016-11-07 19:03:32 +0900 | [diff] [blame] | 229 | struct dma_fence *fence = reservation_object_get_excl_rcu(msm_obj->resv); |
Rob Clark | b6295f9 | 2016-03-15 18:26:28 -0400 | [diff] [blame] | 230 | |
Gustavo Padovan | 5d58698 | 2016-11-07 19:03:32 +0900 | [diff] [blame] | 231 | drm_atomic_set_fence_for_plane(plane_state, fence); |
Rob Clark | b6295f9 | 2016-03-15 18:26:28 -0400 | [diff] [blame] | 232 | } |
| 233 | } |
| 234 | |
| 235 | /* |
Rob Clark | f86afec | 2014-11-25 12:41:18 -0500 | [diff] [blame] | 236 | * Wait for pending updates on any of the same crtc's and then |
| 237 | * mark our set of crtc's as busy: |
| 238 | */ |
| 239 | ret = start_atomic(dev->dev_private, c->crtc_mask); |
Laurent Pinchart | 5b2e2b6 | 2015-02-23 00:58:03 +0200 | [diff] [blame] | 240 | if (ret) { |
| 241 | kfree(c); |
Laurent Pinchart | f65c18c | 2015-05-27 14:39:46 +0300 | [diff] [blame] | 242 | goto error; |
Laurent Pinchart | 5b2e2b6 | 2015-02-23 00:58:03 +0200 | [diff] [blame] | 243 | } |
Rob Clark | f86afec | 2014-11-25 12:41:18 -0500 | [diff] [blame] | 244 | |
| 245 | /* |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 246 | * This is the point of no return - everything below never fails except |
| 247 | * when the hw goes bonghits. Which means we can commit the new state on |
| 248 | * the software side now. |
| 249 | */ |
| 250 | |
Daniel Vetter | 5e84c26 | 2016-06-10 00:06:32 +0200 | [diff] [blame] | 251 | drm_atomic_helper_swap_state(state, true); |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 252 | |
Rob Clark | 870d738 | 2016-11-04 13:51:42 -0400 | [diff] [blame] | 253 | /* swap driver private state while still holding state_lock */ |
| 254 | if (to_kms_state(state)->state) |
| 255 | priv->kms->funcs->swap_state(priv->kms, state); |
| 256 | |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 257 | /* |
| 258 | * Everything below can be run asynchronously without the need to grab |
| 259 | * any modeset locks at all under one conditions: It must be guaranteed |
| 260 | * that the asynchronous work has either been cancelled (if the driver |
| 261 | * supports it, which at least requires that the framebuffers get |
| 262 | * cleaned up with drm_atomic_helper_cleanup_planes()) or completed |
| 263 | * before the new state gets committed on the software side with |
| 264 | * drm_atomic_helper_swap_state(). |
| 265 | * |
| 266 | * This scheme allows new atomic state updates to be prepared and |
| 267 | * checked in parallel to the asynchronous completion of the previous |
| 268 | * update. Which is important since compositors need to figure out the |
| 269 | * composition of the next frame right after having submitted the |
| 270 | * current layout. |
| 271 | */ |
| 272 | |
Chris Wilson | 0853695 | 2016-10-14 13:18:18 +0100 | [diff] [blame] | 273 | drm_atomic_state_get(state); |
Rob Clark | ba00c3f | 2016-03-16 18:18:17 -0400 | [diff] [blame] | 274 | if (nonblock) { |
| 275 | queue_work(priv->atomic_wq, &c->work); |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 276 | return 0; |
| 277 | } |
| 278 | |
Rob Clark | ba00c3f | 2016-03-16 18:18:17 -0400 | [diff] [blame] | 279 | complete_commit(c, false); |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 280 | |
| 281 | return 0; |
Laurent Pinchart | f65c18c | 2015-05-27 14:39:46 +0300 | [diff] [blame] | 282 | |
| 283 | error: |
| 284 | drm_atomic_helper_cleanup_planes(dev, state); |
| 285 | return ret; |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 286 | } |
Rob Clark | 870d738 | 2016-11-04 13:51:42 -0400 | [diff] [blame] | 287 | |
| 288 | struct drm_atomic_state *msm_atomic_state_alloc(struct drm_device *dev) |
| 289 | { |
| 290 | struct msm_kms_state *state = kzalloc(sizeof(*state), GFP_KERNEL); |
| 291 | |
| 292 | if (!state || drm_atomic_state_init(dev, &state->base) < 0) { |
| 293 | kfree(state); |
| 294 | return NULL; |
| 295 | } |
| 296 | |
| 297 | return &state->base; |
| 298 | } |
| 299 | |
| 300 | void msm_atomic_state_clear(struct drm_atomic_state *s) |
| 301 | { |
| 302 | struct msm_kms_state *state = to_kms_state(s); |
| 303 | drm_atomic_state_default_clear(&state->base); |
| 304 | kfree(state->state); |
| 305 | state->state = NULL; |
| 306 | } |
| 307 | |
| 308 | void msm_atomic_state_free(struct drm_atomic_state *state) |
| 309 | { |
| 310 | kfree(to_kms_state(state)->state); |
| 311 | drm_atomic_state_default_release(state); |
| 312 | kfree(state); |
| 313 | } |