Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2014 Red Hat |
| 3 | * Author: Rob Clark <robdclark@gmail.com> |
| 4 | * |
| 5 | * This program is free software; you can redistribute it and/or modify it |
| 6 | * under the terms of the GNU General Public License version 2 as published by |
| 7 | * the Free Software Foundation. |
| 8 | * |
| 9 | * This program is distributed in the hope that it will be useful, but WITHOUT |
| 10 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
| 11 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for |
| 12 | * more details. |
| 13 | * |
| 14 | * You should have received a copy of the GNU General Public License along with |
| 15 | * this program. If not, see <http://www.gnu.org/licenses/>. |
| 16 | */ |
| 17 | |
| 18 | #include "msm_drv.h" |
| 19 | #include "msm_kms.h" |
| 20 | #include "msm_gem.h" |
Rob Clark | fde5de6 | 2016-03-15 15:35:08 -0400 | [diff] [blame] | 21 | #include "msm_fence.h" |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 22 | |
| 23 | struct msm_commit { |
Rob Clark | 0b776d4 | 2015-01-30 17:04:45 -0500 | [diff] [blame] | 24 | struct drm_device *dev; |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 25 | struct drm_atomic_state *state; |
Rob Clark | ba00c3f | 2016-03-16 18:18:17 -0400 | [diff] [blame] | 26 | struct work_struct work; |
Rob Clark | f86afec | 2014-11-25 12:41:18 -0500 | [diff] [blame] | 27 | uint32_t crtc_mask; |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 28 | }; |
| 29 | |
Rob Clark | ba00c3f | 2016-03-16 18:18:17 -0400 | [diff] [blame] | 30 | static void commit_worker(struct work_struct *work); |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 31 | |
Rob Clark | f86afec | 2014-11-25 12:41:18 -0500 | [diff] [blame] | 32 | /* block until specified crtcs are no longer pending update, and |
| 33 | * atomically mark them as pending update |
| 34 | */ |
| 35 | static int start_atomic(struct msm_drm_private *priv, uint32_t crtc_mask) |
| 36 | { |
| 37 | int ret; |
| 38 | |
| 39 | spin_lock(&priv->pending_crtcs_event.lock); |
| 40 | ret = wait_event_interruptible_locked(priv->pending_crtcs_event, |
| 41 | !(priv->pending_crtcs & crtc_mask)); |
| 42 | if (ret == 0) { |
| 43 | DBG("start: %08x", crtc_mask); |
| 44 | priv->pending_crtcs |= crtc_mask; |
| 45 | } |
| 46 | spin_unlock(&priv->pending_crtcs_event.lock); |
| 47 | |
| 48 | return ret; |
| 49 | } |
| 50 | |
| 51 | /* clear specified crtcs (no longer pending update) |
| 52 | */ |
| 53 | static void end_atomic(struct msm_drm_private *priv, uint32_t crtc_mask) |
| 54 | { |
| 55 | spin_lock(&priv->pending_crtcs_event.lock); |
| 56 | DBG("end: %08x", crtc_mask); |
| 57 | priv->pending_crtcs &= ~crtc_mask; |
| 58 | wake_up_all_locked(&priv->pending_crtcs_event); |
| 59 | spin_unlock(&priv->pending_crtcs_event.lock); |
| 60 | } |
| 61 | |
Rob Clark | 0b776d4 | 2015-01-30 17:04:45 -0500 | [diff] [blame] | 62 | static struct msm_commit *commit_init(struct drm_atomic_state *state) |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 63 | { |
| 64 | struct msm_commit *c = kzalloc(sizeof(*c), GFP_KERNEL); |
| 65 | |
| 66 | if (!c) |
| 67 | return NULL; |
| 68 | |
Rob Clark | 0b776d4 | 2015-01-30 17:04:45 -0500 | [diff] [blame] | 69 | c->dev = state->dev; |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 70 | c->state = state; |
Rob Clark | 0b776d4 | 2015-01-30 17:04:45 -0500 | [diff] [blame] | 71 | |
Rob Clark | ba00c3f | 2016-03-16 18:18:17 -0400 | [diff] [blame] | 72 | INIT_WORK(&c->work, commit_worker); |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 73 | |
| 74 | return c; |
| 75 | } |
| 76 | |
Rob Clark | 0b776d4 | 2015-01-30 17:04:45 -0500 | [diff] [blame] | 77 | static void commit_destroy(struct msm_commit *c) |
| 78 | { |
| 79 | end_atomic(c->dev->dev_private, c->crtc_mask); |
| 80 | kfree(c); |
| 81 | } |
| 82 | |
Hai Li | 0a5c9aa | 2015-04-28 19:35:37 -0400 | [diff] [blame] | 83 | static void msm_atomic_wait_for_commit_done(struct drm_device *dev, |
| 84 | struct drm_atomic_state *old_state) |
| 85 | { |
| 86 | struct drm_crtc *crtc; |
Maarten Lankhorst | d742966 | 2017-07-19 16:39:18 +0200 | [diff] [blame] | 87 | struct drm_crtc_state *new_crtc_state; |
Hai Li | 0a5c9aa | 2015-04-28 19:35:37 -0400 | [diff] [blame] | 88 | struct msm_drm_private *priv = old_state->dev->dev_private; |
| 89 | struct msm_kms *kms = priv->kms; |
Hai Li | 0a5c9aa | 2015-04-28 19:35:37 -0400 | [diff] [blame] | 90 | int i; |
| 91 | |
Maarten Lankhorst | d742966 | 2017-07-19 16:39:18 +0200 | [diff] [blame] | 92 | for_each_new_crtc_in_state(old_state, crtc, new_crtc_state, i) { |
| 93 | if (!new_crtc_state->active) |
Hai Li | 0a5c9aa | 2015-04-28 19:35:37 -0400 | [diff] [blame] | 94 | continue; |
| 95 | |
Hai Li | 0a5c9aa | 2015-04-28 19:35:37 -0400 | [diff] [blame] | 96 | kms->funcs->wait_for_crtc_commit_done(kms, crtc); |
| 97 | } |
| 98 | } |
| 99 | |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 100 | /* The (potentially) asynchronous part of the commit. At this point |
| 101 | * nothing can fail short of armageddon. |
| 102 | */ |
Rob Clark | ba00c3f | 2016-03-16 18:18:17 -0400 | [diff] [blame] | 103 | static void complete_commit(struct msm_commit *c, bool async) |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 104 | { |
| 105 | struct drm_atomic_state *state = c->state; |
| 106 | struct drm_device *dev = state->dev; |
Rob Clark | 0b776d4 | 2015-01-30 17:04:45 -0500 | [diff] [blame] | 107 | struct msm_drm_private *priv = dev->dev_private; |
| 108 | struct msm_kms *kms = priv->kms; |
| 109 | |
Gustavo Padovan | f6ce410 | 2016-09-12 16:08:11 -0300 | [diff] [blame] | 110 | drm_atomic_helper_wait_for_fences(dev, state, false); |
Rob Clark | ba00c3f | 2016-03-16 18:18:17 -0400 | [diff] [blame] | 111 | |
Rob Clark | 0b776d4 | 2015-01-30 17:04:45 -0500 | [diff] [blame] | 112 | kms->funcs->prepare_commit(kms, state); |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 113 | |
Daniel Vetter | 1af434a | 2015-02-22 12:24:19 +0100 | [diff] [blame] | 114 | drm_atomic_helper_commit_modeset_disables(dev, state); |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 115 | |
Liu Ying | 2b58e98 | 2016-08-29 17:12:03 +0800 | [diff] [blame] | 116 | drm_atomic_helper_commit_planes(dev, state, 0); |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 117 | |
Daniel Vetter | 1af434a | 2015-02-22 12:24:19 +0100 | [diff] [blame] | 118 | drm_atomic_helper_commit_modeset_enables(dev, state); |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 119 | |
Rob Clark | f86afec | 2014-11-25 12:41:18 -0500 | [diff] [blame] | 120 | /* NOTE: _wait_for_vblanks() only waits for vblank on |
| 121 | * enabled CRTCs. So we end up faulting when disabling |
| 122 | * due to (potentially) unref'ing the outgoing fb's |
| 123 | * before the vblank when the disable has latched. |
| 124 | * |
| 125 | * But if it did wait on disabled (or newly disabled) |
| 126 | * CRTCs, that would be racy (ie. we could have missed |
| 127 | * the irq. We need some way to poll for pipe shut |
| 128 | * down. Or just live with occasionally hitting the |
| 129 | * timeout in the CRTC disable path (which really should |
| 130 | * not be critical path) |
| 131 | */ |
| 132 | |
Hai Li | 0a5c9aa | 2015-04-28 19:35:37 -0400 | [diff] [blame] | 133 | msm_atomic_wait_for_commit_done(dev, state); |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 134 | |
| 135 | drm_atomic_helper_cleanup_planes(dev, state); |
| 136 | |
Rob Clark | 0b776d4 | 2015-01-30 17:04:45 -0500 | [diff] [blame] | 137 | kms->funcs->complete_commit(kms, state); |
| 138 | |
Chris Wilson | 0853695 | 2016-10-14 13:18:18 +0100 | [diff] [blame] | 139 | drm_atomic_state_put(state); |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 140 | |
Rob Clark | 0b776d4 | 2015-01-30 17:04:45 -0500 | [diff] [blame] | 141 | commit_destroy(c); |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 142 | } |
| 143 | |
Rob Clark | ba00c3f | 2016-03-16 18:18:17 -0400 | [diff] [blame] | 144 | static void commit_worker(struct work_struct *work) |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 145 | { |
Rob Clark | ba00c3f | 2016-03-16 18:18:17 -0400 | [diff] [blame] | 146 | complete_commit(container_of(work, struct msm_commit, work), true); |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 147 | } |
| 148 | |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 149 | /** |
| 150 | * drm_atomic_helper_commit - commit validated state object |
| 151 | * @dev: DRM device |
| 152 | * @state: the driver state object |
Maarten Lankhorst | a3ccfb9 | 2016-04-26 16:11:38 +0200 | [diff] [blame] | 153 | * @nonblock: nonblocking commit |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 154 | * |
| 155 | * This function commits a with drm_atomic_helper_check() pre-validated state |
Maarten Lankhorst | a3ccfb9 | 2016-04-26 16:11:38 +0200 | [diff] [blame] | 156 | * object. This can still fail when e.g. the framebuffer reservation fails. |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 157 | * |
| 158 | * RETURNS |
| 159 | * Zero for success or -errno. |
| 160 | */ |
| 161 | int msm_atomic_commit(struct drm_device *dev, |
Maarten Lankhorst | a3ccfb9 | 2016-04-26 16:11:38 +0200 | [diff] [blame] | 162 | struct drm_atomic_state *state, bool nonblock) |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 163 | { |
Rob Clark | ca762a8 | 2016-03-15 17:22:13 -0400 | [diff] [blame] | 164 | struct msm_drm_private *priv = dev->dev_private; |
Rob Clark | f86afec | 2014-11-25 12:41:18 -0500 | [diff] [blame] | 165 | struct msm_commit *c; |
Daniel Vetter | 8d76b79 | 2016-06-02 15:41:53 +0200 | [diff] [blame] | 166 | struct drm_crtc *crtc; |
| 167 | struct drm_crtc_state *crtc_state; |
| 168 | struct drm_plane *plane; |
Maarten Lankhorst | d742966 | 2017-07-19 16:39:18 +0200 | [diff] [blame] | 169 | struct drm_plane_state *old_plane_state, *new_plane_state; |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 170 | int i, ret; |
| 171 | |
| 172 | ret = drm_atomic_helper_prepare_planes(dev, state); |
| 173 | if (ret) |
| 174 | return ret; |
| 175 | |
Gustavo Padovan | 224a4c9 | 2017-06-30 15:03:20 -0300 | [diff] [blame] | 176 | /* |
| 177 | * Note that plane->atomic_async_check() should fail if we need |
| 178 | * to re-assign hwpipe or anything that touches global atomic |
| 179 | * state, so we'll never go down the async update path in those |
| 180 | * cases. |
| 181 | */ |
| 182 | if (state->async_update) { |
| 183 | drm_atomic_helper_async_commit(dev, state); |
| 184 | drm_atomic_helper_cleanup_planes(dev, state); |
| 185 | return 0; |
| 186 | } |
| 187 | |
Rob Clark | 0b776d4 | 2015-01-30 17:04:45 -0500 | [diff] [blame] | 188 | c = commit_init(state); |
Laurent Pinchart | f65c18c | 2015-05-27 14:39:46 +0300 | [diff] [blame] | 189 | if (!c) { |
| 190 | ret = -ENOMEM; |
| 191 | goto error; |
| 192 | } |
Rob Clark | f86afec | 2014-11-25 12:41:18 -0500 | [diff] [blame] | 193 | |
| 194 | /* |
| 195 | * Figure out what crtcs we have: |
| 196 | */ |
Maarten Lankhorst | d742966 | 2017-07-19 16:39:18 +0200 | [diff] [blame] | 197 | for_each_new_crtc_in_state(state, crtc, crtc_state, i) |
Daniel Vetter | 8d76b79 | 2016-06-02 15:41:53 +0200 | [diff] [blame] | 198 | c->crtc_mask |= drm_crtc_mask(crtc); |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 199 | |
| 200 | /* |
Rob Clark | b6295f9 | 2016-03-15 18:26:28 -0400 | [diff] [blame] | 201 | * Figure out what fence to wait for: |
| 202 | */ |
Maarten Lankhorst | d742966 | 2017-07-19 16:39:18 +0200 | [diff] [blame] | 203 | for_each_oldnew_plane_in_state(state, plane, old_plane_state, new_plane_state, i) { |
| 204 | if ((new_plane_state->fb != old_plane_state->fb) && new_plane_state->fb) { |
| 205 | struct drm_gem_object *obj = msm_framebuffer_bo(new_plane_state->fb, 0); |
Rob Clark | b6295f9 | 2016-03-15 18:26:28 -0400 | [diff] [blame] | 206 | struct msm_gem_object *msm_obj = to_msm_bo(obj); |
Gustavo Padovan | 5d58698 | 2016-11-07 19:03:32 +0900 | [diff] [blame] | 207 | struct dma_fence *fence = reservation_object_get_excl_rcu(msm_obj->resv); |
Rob Clark | b6295f9 | 2016-03-15 18:26:28 -0400 | [diff] [blame] | 208 | |
Maarten Lankhorst | d742966 | 2017-07-19 16:39:18 +0200 | [diff] [blame] | 209 | drm_atomic_set_fence_for_plane(new_plane_state, fence); |
Rob Clark | b6295f9 | 2016-03-15 18:26:28 -0400 | [diff] [blame] | 210 | } |
| 211 | } |
| 212 | |
| 213 | /* |
Rob Clark | f86afec | 2014-11-25 12:41:18 -0500 | [diff] [blame] | 214 | * Wait for pending updates on any of the same crtc's and then |
| 215 | * mark our set of crtc's as busy: |
| 216 | */ |
| 217 | ret = start_atomic(dev->dev_private, c->crtc_mask); |
Maarten Lankhorst | 771f14c | 2017-07-11 16:33:09 +0200 | [diff] [blame] | 218 | if (ret) |
| 219 | goto err_free; |
| 220 | |
| 221 | BUG_ON(drm_atomic_helper_swap_state(state, false) < 0); |
Rob Clark | f86afec | 2014-11-25 12:41:18 -0500 | [diff] [blame] | 222 | |
| 223 | /* |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 224 | * This is the point of no return - everything below never fails except |
| 225 | * when the hw goes bonghits. Which means we can commit the new state on |
| 226 | * the software side now. |
Maarten Lankhorst | 771f14c | 2017-07-11 16:33:09 +0200 | [diff] [blame] | 227 | * |
| 228 | * swap driver private state while still holding state_lock |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 229 | */ |
Rob Clark | 870d738 | 2016-11-04 13:51:42 -0400 | [diff] [blame] | 230 | if (to_kms_state(state)->state) |
| 231 | priv->kms->funcs->swap_state(priv->kms, state); |
| 232 | |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 233 | /* |
| 234 | * Everything below can be run asynchronously without the need to grab |
| 235 | * any modeset locks at all under one conditions: It must be guaranteed |
| 236 | * that the asynchronous work has either been cancelled (if the driver |
| 237 | * supports it, which at least requires that the framebuffers get |
| 238 | * cleaned up with drm_atomic_helper_cleanup_planes()) or completed |
| 239 | * before the new state gets committed on the software side with |
| 240 | * drm_atomic_helper_swap_state(). |
| 241 | * |
| 242 | * This scheme allows new atomic state updates to be prepared and |
| 243 | * checked in parallel to the asynchronous completion of the previous |
| 244 | * update. Which is important since compositors need to figure out the |
| 245 | * composition of the next frame right after having submitted the |
| 246 | * current layout. |
| 247 | */ |
| 248 | |
Chris Wilson | 0853695 | 2016-10-14 13:18:18 +0100 | [diff] [blame] | 249 | drm_atomic_state_get(state); |
Rob Clark | ba00c3f | 2016-03-16 18:18:17 -0400 | [diff] [blame] | 250 | if (nonblock) { |
| 251 | queue_work(priv->atomic_wq, &c->work); |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 252 | return 0; |
| 253 | } |
| 254 | |
Rob Clark | ba00c3f | 2016-03-16 18:18:17 -0400 | [diff] [blame] | 255 | complete_commit(c, false); |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 256 | |
| 257 | return 0; |
Laurent Pinchart | f65c18c | 2015-05-27 14:39:46 +0300 | [diff] [blame] | 258 | |
Maarten Lankhorst | 771f14c | 2017-07-11 16:33:09 +0200 | [diff] [blame] | 259 | err_free: |
| 260 | kfree(c); |
Laurent Pinchart | f65c18c | 2015-05-27 14:39:46 +0300 | [diff] [blame] | 261 | error: |
| 262 | drm_atomic_helper_cleanup_planes(dev, state); |
| 263 | return ret; |
Rob Clark | cf3a7e4 | 2014-11-08 13:21:06 -0500 | [diff] [blame] | 264 | } |
Rob Clark | 870d738 | 2016-11-04 13:51:42 -0400 | [diff] [blame] | 265 | |
| 266 | struct drm_atomic_state *msm_atomic_state_alloc(struct drm_device *dev) |
| 267 | { |
| 268 | struct msm_kms_state *state = kzalloc(sizeof(*state), GFP_KERNEL); |
| 269 | |
| 270 | if (!state || drm_atomic_state_init(dev, &state->base) < 0) { |
| 271 | kfree(state); |
| 272 | return NULL; |
| 273 | } |
| 274 | |
| 275 | return &state->base; |
| 276 | } |
| 277 | |
| 278 | void msm_atomic_state_clear(struct drm_atomic_state *s) |
| 279 | { |
| 280 | struct msm_kms_state *state = to_kms_state(s); |
| 281 | drm_atomic_state_default_clear(&state->base); |
| 282 | kfree(state->state); |
| 283 | state->state = NULL; |
| 284 | } |
| 285 | |
| 286 | void msm_atomic_state_free(struct drm_atomic_state *state) |
| 287 | { |
| 288 | kfree(to_kms_state(state)->state); |
| 289 | drm_atomic_state_default_release(state); |
| 290 | kfree(state); |
| 291 | } |