Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1 | /* |
| 2 | * Copyright © 2008,2010 Intel Corporation |
| 3 | * |
| 4 | * Permission is hereby granted, free of charge, to any person obtaining a |
| 5 | * copy of this software and associated documentation files (the "Software"), |
| 6 | * to deal in the Software without restriction, including without limitation |
| 7 | * the rights to use, copy, modify, merge, publish, distribute, sublicense, |
| 8 | * and/or sell copies of the Software, and to permit persons to whom the |
| 9 | * Software is furnished to do so, subject to the following conditions: |
| 10 | * |
| 11 | * The above copyright notice and this permission notice (including the next |
| 12 | * paragraph) shall be included in all copies or substantial portions of the |
| 13 | * Software. |
| 14 | * |
| 15 | * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR |
| 16 | * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, |
| 17 | * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL |
| 18 | * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER |
| 19 | * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING |
| 20 | * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS |
| 21 | * IN THE SOFTWARE. |
| 22 | * |
| 23 | * Authors: |
| 24 | * Eric Anholt <eric@anholt.net> |
| 25 | * Chris Wilson <chris@chris-wilson.co.uk> |
| 26 | * |
| 27 | */ |
| 28 | |
| 29 | #include "drmP.h" |
| 30 | #include "drm.h" |
| 31 | #include "i915_drm.h" |
| 32 | #include "i915_drv.h" |
| 33 | #include "i915_trace.h" |
| 34 | #include "intel_drv.h" |
Eugeni Dodonov | f45b555 | 2011-12-09 17:16:37 -0800 | [diff] [blame] | 35 | #include <linux/dma_remapping.h> |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 36 | |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 37 | struct eb_objects { |
| 38 | int and; |
| 39 | struct hlist_head buckets[0]; |
| 40 | }; |
| 41 | |
| 42 | static struct eb_objects * |
| 43 | eb_create(int size) |
| 44 | { |
| 45 | struct eb_objects *eb; |
| 46 | int count = PAGE_SIZE / sizeof(struct hlist_head) / 2; |
Chris Wilson | 41783ee | 2012-09-18 10:04:02 +0100 | [diff] [blame] | 47 | BUILD_BUG_ON(!is_power_of_2(PAGE_SIZE / sizeof(struct hlist_head))); |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 48 | while (count > size) |
| 49 | count >>= 1; |
| 50 | eb = kzalloc(count*sizeof(struct hlist_head) + |
| 51 | sizeof(struct eb_objects), |
| 52 | GFP_KERNEL); |
| 53 | if (eb == NULL) |
| 54 | return eb; |
| 55 | |
| 56 | eb->and = count - 1; |
| 57 | return eb; |
| 58 | } |
| 59 | |
| 60 | static void |
| 61 | eb_reset(struct eb_objects *eb) |
| 62 | { |
| 63 | memset(eb->buckets, 0, (eb->and+1)*sizeof(struct hlist_head)); |
| 64 | } |
| 65 | |
| 66 | static void |
| 67 | eb_add_object(struct eb_objects *eb, struct drm_i915_gem_object *obj) |
| 68 | { |
| 69 | hlist_add_head(&obj->exec_node, |
| 70 | &eb->buckets[obj->exec_handle & eb->and]); |
| 71 | } |
| 72 | |
| 73 | static struct drm_i915_gem_object * |
| 74 | eb_get_object(struct eb_objects *eb, unsigned long handle) |
| 75 | { |
| 76 | struct hlist_head *head; |
| 77 | struct hlist_node *node; |
| 78 | struct drm_i915_gem_object *obj; |
| 79 | |
| 80 | head = &eb->buckets[handle & eb->and]; |
| 81 | hlist_for_each(node, head) { |
| 82 | obj = hlist_entry(node, struct drm_i915_gem_object, exec_node); |
| 83 | if (obj->exec_handle == handle) |
| 84 | return obj; |
| 85 | } |
| 86 | |
| 87 | return NULL; |
| 88 | } |
| 89 | |
| 90 | static void |
| 91 | eb_destroy(struct eb_objects *eb) |
| 92 | { |
| 93 | kfree(eb); |
| 94 | } |
| 95 | |
Chris Wilson | dabdfe0 | 2012-03-26 10:10:27 +0200 | [diff] [blame] | 96 | static inline int use_cpu_reloc(struct drm_i915_gem_object *obj) |
| 97 | { |
| 98 | return (obj->base.write_domain == I915_GEM_DOMAIN_CPU || |
Chris Wilson | 504c726 | 2012-08-23 13:12:52 +0100 | [diff] [blame] | 99 | !obj->map_and_fenceable || |
Chris Wilson | dabdfe0 | 2012-03-26 10:10:27 +0200 | [diff] [blame] | 100 | obj->cache_level != I915_CACHE_NONE); |
| 101 | } |
| 102 | |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 103 | static int |
| 104 | i915_gem_execbuffer_relocate_entry(struct drm_i915_gem_object *obj, |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 105 | struct eb_objects *eb, |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 106 | struct drm_i915_gem_relocation_entry *reloc) |
| 107 | { |
| 108 | struct drm_device *dev = obj->base.dev; |
| 109 | struct drm_gem_object *target_obj; |
Daniel Vetter | 149c840 | 2012-02-15 23:50:23 +0100 | [diff] [blame] | 110 | struct drm_i915_gem_object *target_i915_obj; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 111 | uint32_t target_offset; |
| 112 | int ret = -EINVAL; |
| 113 | |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 114 | /* we've already hold a reference to all valid objects */ |
| 115 | target_obj = &eb_get_object(eb, reloc->target_handle)->base; |
| 116 | if (unlikely(target_obj == NULL)) |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 117 | return -ENOENT; |
| 118 | |
Daniel Vetter | 149c840 | 2012-02-15 23:50:23 +0100 | [diff] [blame] | 119 | target_i915_obj = to_intel_bo(target_obj); |
| 120 | target_offset = target_i915_obj->gtt_offset; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 121 | |
Eric Anholt | e844b99 | 2012-07-31 15:35:01 -0700 | [diff] [blame] | 122 | /* Sandybridge PPGTT errata: We need a global gtt mapping for MI and |
| 123 | * pipe_control writes because the gpu doesn't properly redirect them |
| 124 | * through the ppgtt for non_secure batchbuffers. */ |
| 125 | if (unlikely(IS_GEN6(dev) && |
| 126 | reloc->write_domain == I915_GEM_DOMAIN_INSTRUCTION && |
| 127 | !target_i915_obj->has_global_gtt_mapping)) { |
| 128 | i915_gem_gtt_bind_object(target_i915_obj, |
| 129 | target_i915_obj->cache_level); |
| 130 | } |
| 131 | |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 132 | /* The target buffer should have appeared before us in the |
| 133 | * exec_object list, so it should have a GTT space bound by now. |
| 134 | */ |
Chris Wilson | b8f7ab1 | 2010-12-08 10:43:06 +0000 | [diff] [blame] | 135 | if (unlikely(target_offset == 0)) { |
Daniel Vetter | ff24019 | 2012-01-31 21:08:14 +0100 | [diff] [blame] | 136 | DRM_DEBUG("No GTT space found for object %d\n", |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 137 | reloc->target_handle); |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 138 | return ret; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 139 | } |
| 140 | |
| 141 | /* Validate that the target is in a valid r/w GPU domain */ |
Chris Wilson | b8f7ab1 | 2010-12-08 10:43:06 +0000 | [diff] [blame] | 142 | if (unlikely(reloc->write_domain & (reloc->write_domain - 1))) { |
Daniel Vetter | ff24019 | 2012-01-31 21:08:14 +0100 | [diff] [blame] | 143 | DRM_DEBUG("reloc with multiple write domains: " |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 144 | "obj %p target %d offset %d " |
| 145 | "read %08x write %08x", |
| 146 | obj, reloc->target_handle, |
| 147 | (int) reloc->offset, |
| 148 | reloc->read_domains, |
| 149 | reloc->write_domain); |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 150 | return ret; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 151 | } |
Daniel Vetter | 4ca4a25 | 2011-12-14 13:57:27 +0100 | [diff] [blame] | 152 | if (unlikely((reloc->write_domain | reloc->read_domains) |
| 153 | & ~I915_GEM_GPU_DOMAINS)) { |
Daniel Vetter | ff24019 | 2012-01-31 21:08:14 +0100 | [diff] [blame] | 154 | DRM_DEBUG("reloc with read/write non-GPU domains: " |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 155 | "obj %p target %d offset %d " |
| 156 | "read %08x write %08x", |
| 157 | obj, reloc->target_handle, |
| 158 | (int) reloc->offset, |
| 159 | reloc->read_domains, |
| 160 | reloc->write_domain); |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 161 | return ret; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 162 | } |
Chris Wilson | b8f7ab1 | 2010-12-08 10:43:06 +0000 | [diff] [blame] | 163 | if (unlikely(reloc->write_domain && target_obj->pending_write_domain && |
| 164 | reloc->write_domain != target_obj->pending_write_domain)) { |
Daniel Vetter | ff24019 | 2012-01-31 21:08:14 +0100 | [diff] [blame] | 165 | DRM_DEBUG("Write domain conflict: " |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 166 | "obj %p target %d offset %d " |
| 167 | "new %08x old %08x\n", |
| 168 | obj, reloc->target_handle, |
| 169 | (int) reloc->offset, |
| 170 | reloc->write_domain, |
| 171 | target_obj->pending_write_domain); |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 172 | return ret; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 173 | } |
| 174 | |
| 175 | target_obj->pending_read_domains |= reloc->read_domains; |
| 176 | target_obj->pending_write_domain |= reloc->write_domain; |
| 177 | |
| 178 | /* If the relocation already has the right value in it, no |
| 179 | * more work needs to be done. |
| 180 | */ |
| 181 | if (target_offset == reloc->presumed_offset) |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 182 | return 0; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 183 | |
| 184 | /* Check that the relocation address is valid... */ |
Chris Wilson | b8f7ab1 | 2010-12-08 10:43:06 +0000 | [diff] [blame] | 185 | if (unlikely(reloc->offset > obj->base.size - 4)) { |
Daniel Vetter | ff24019 | 2012-01-31 21:08:14 +0100 | [diff] [blame] | 186 | DRM_DEBUG("Relocation beyond object bounds: " |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 187 | "obj %p target %d offset %d size %d.\n", |
| 188 | obj, reloc->target_handle, |
| 189 | (int) reloc->offset, |
| 190 | (int) obj->base.size); |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 191 | return ret; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 192 | } |
Chris Wilson | b8f7ab1 | 2010-12-08 10:43:06 +0000 | [diff] [blame] | 193 | if (unlikely(reloc->offset & 3)) { |
Daniel Vetter | ff24019 | 2012-01-31 21:08:14 +0100 | [diff] [blame] | 194 | DRM_DEBUG("Relocation not 4-byte aligned: " |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 195 | "obj %p target %d offset %d.\n", |
| 196 | obj, reloc->target_handle, |
| 197 | (int) reloc->offset); |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 198 | return ret; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 199 | } |
| 200 | |
Chris Wilson | dabdfe0 | 2012-03-26 10:10:27 +0200 | [diff] [blame] | 201 | /* We can't wait for rendering with pagefaults disabled */ |
| 202 | if (obj->active && in_atomic()) |
| 203 | return -EFAULT; |
| 204 | |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 205 | reloc->delta += target_offset; |
Chris Wilson | dabdfe0 | 2012-03-26 10:10:27 +0200 | [diff] [blame] | 206 | if (use_cpu_reloc(obj)) { |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 207 | uint32_t page_offset = reloc->offset & ~PAGE_MASK; |
| 208 | char *vaddr; |
| 209 | |
Chris Wilson | dabdfe0 | 2012-03-26 10:10:27 +0200 | [diff] [blame] | 210 | ret = i915_gem_object_set_to_cpu_domain(obj, 1); |
| 211 | if (ret) |
| 212 | return ret; |
| 213 | |
Chris Wilson | 9da3da6 | 2012-06-01 15:20:22 +0100 | [diff] [blame] | 214 | vaddr = kmap_atomic(i915_gem_object_get_page(obj, |
| 215 | reloc->offset >> PAGE_SHIFT)); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 216 | *(uint32_t *)(vaddr + page_offset) = reloc->delta; |
| 217 | kunmap_atomic(vaddr); |
| 218 | } else { |
| 219 | struct drm_i915_private *dev_priv = dev->dev_private; |
| 220 | uint32_t __iomem *reloc_entry; |
| 221 | void __iomem *reloc_page; |
| 222 | |
Chris Wilson | 7b09638 | 2012-04-14 09:55:51 +0100 | [diff] [blame] | 223 | ret = i915_gem_object_set_to_gtt_domain(obj, true); |
| 224 | if (ret) |
| 225 | return ret; |
| 226 | |
| 227 | ret = i915_gem_object_put_fence(obj); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 228 | if (ret) |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 229 | return ret; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 230 | |
| 231 | /* Map the page containing the relocation we're going to perform. */ |
| 232 | reloc->offset += obj->gtt_offset; |
| 233 | reloc_page = io_mapping_map_atomic_wc(dev_priv->mm.gtt_mapping, |
| 234 | reloc->offset & PAGE_MASK); |
| 235 | reloc_entry = (uint32_t __iomem *) |
| 236 | (reloc_page + (reloc->offset & ~PAGE_MASK)); |
| 237 | iowrite32(reloc->delta, reloc_entry); |
| 238 | io_mapping_unmap_atomic(reloc_page); |
| 239 | } |
| 240 | |
| 241 | /* and update the user's relocation entry */ |
| 242 | reloc->presumed_offset = target_offset; |
| 243 | |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 244 | return 0; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 245 | } |
| 246 | |
| 247 | static int |
| 248 | i915_gem_execbuffer_relocate_object(struct drm_i915_gem_object *obj, |
Chris Wilson | 6fe4f14 | 2011-01-10 17:35:37 +0000 | [diff] [blame] | 249 | struct eb_objects *eb) |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 250 | { |
Chris Wilson | 1d83f44 | 2012-03-24 20:12:53 +0000 | [diff] [blame] | 251 | #define N_RELOC(x) ((x) / sizeof(struct drm_i915_gem_relocation_entry)) |
| 252 | struct drm_i915_gem_relocation_entry stack_reloc[N_RELOC(512)]; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 253 | struct drm_i915_gem_relocation_entry __user *user_relocs; |
Chris Wilson | 6fe4f14 | 2011-01-10 17:35:37 +0000 | [diff] [blame] | 254 | struct drm_i915_gem_exec_object2 *entry = obj->exec_entry; |
Chris Wilson | 1d83f44 | 2012-03-24 20:12:53 +0000 | [diff] [blame] | 255 | int remain, ret; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 256 | |
| 257 | user_relocs = (void __user *)(uintptr_t)entry->relocs_ptr; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 258 | |
Chris Wilson | 1d83f44 | 2012-03-24 20:12:53 +0000 | [diff] [blame] | 259 | remain = entry->relocation_count; |
| 260 | while (remain) { |
| 261 | struct drm_i915_gem_relocation_entry *r = stack_reloc; |
| 262 | int count = remain; |
| 263 | if (count > ARRAY_SIZE(stack_reloc)) |
| 264 | count = ARRAY_SIZE(stack_reloc); |
| 265 | remain -= count; |
| 266 | |
| 267 | if (__copy_from_user_inatomic(r, user_relocs, count*sizeof(r[0]))) |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 268 | return -EFAULT; |
| 269 | |
Chris Wilson | 1d83f44 | 2012-03-24 20:12:53 +0000 | [diff] [blame] | 270 | do { |
| 271 | u64 offset = r->presumed_offset; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 272 | |
Chris Wilson | 1d83f44 | 2012-03-24 20:12:53 +0000 | [diff] [blame] | 273 | ret = i915_gem_execbuffer_relocate_entry(obj, eb, r); |
| 274 | if (ret) |
| 275 | return ret; |
| 276 | |
| 277 | if (r->presumed_offset != offset && |
| 278 | __copy_to_user_inatomic(&user_relocs->presumed_offset, |
| 279 | &r->presumed_offset, |
| 280 | sizeof(r->presumed_offset))) { |
| 281 | return -EFAULT; |
| 282 | } |
| 283 | |
| 284 | user_relocs++; |
| 285 | r++; |
| 286 | } while (--count); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 287 | } |
| 288 | |
| 289 | return 0; |
Chris Wilson | 1d83f44 | 2012-03-24 20:12:53 +0000 | [diff] [blame] | 290 | #undef N_RELOC |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 291 | } |
| 292 | |
| 293 | static int |
| 294 | i915_gem_execbuffer_relocate_object_slow(struct drm_i915_gem_object *obj, |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 295 | struct eb_objects *eb, |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 296 | struct drm_i915_gem_relocation_entry *relocs) |
| 297 | { |
Chris Wilson | 6fe4f14 | 2011-01-10 17:35:37 +0000 | [diff] [blame] | 298 | const struct drm_i915_gem_exec_object2 *entry = obj->exec_entry; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 299 | int i, ret; |
| 300 | |
| 301 | for (i = 0; i < entry->relocation_count; i++) { |
Chris Wilson | 6fe4f14 | 2011-01-10 17:35:37 +0000 | [diff] [blame] | 302 | ret = i915_gem_execbuffer_relocate_entry(obj, eb, &relocs[i]); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 303 | if (ret) |
| 304 | return ret; |
| 305 | } |
| 306 | |
| 307 | return 0; |
| 308 | } |
| 309 | |
| 310 | static int |
| 311 | i915_gem_execbuffer_relocate(struct drm_device *dev, |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 312 | struct eb_objects *eb, |
Chris Wilson | 6fe4f14 | 2011-01-10 17:35:37 +0000 | [diff] [blame] | 313 | struct list_head *objects) |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 314 | { |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 315 | struct drm_i915_gem_object *obj; |
Chris Wilson | d4aeee7 | 2011-03-14 15:11:24 +0000 | [diff] [blame] | 316 | int ret = 0; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 317 | |
Chris Wilson | d4aeee7 | 2011-03-14 15:11:24 +0000 | [diff] [blame] | 318 | /* This is the fast path and we cannot handle a pagefault whilst |
| 319 | * holding the struct mutex lest the user pass in the relocations |
| 320 | * contained within a mmaped bo. For in such a case we, the page |
| 321 | * fault handler would call i915_gem_fault() and we would try to |
| 322 | * acquire the struct mutex again. Obviously this is bad and so |
| 323 | * lockdep complains vehemently. |
| 324 | */ |
| 325 | pagefault_disable(); |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 326 | list_for_each_entry(obj, objects, exec_list) { |
Chris Wilson | 6fe4f14 | 2011-01-10 17:35:37 +0000 | [diff] [blame] | 327 | ret = i915_gem_execbuffer_relocate_object(obj, eb); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 328 | if (ret) |
Chris Wilson | d4aeee7 | 2011-03-14 15:11:24 +0000 | [diff] [blame] | 329 | break; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 330 | } |
Chris Wilson | d4aeee7 | 2011-03-14 15:11:24 +0000 | [diff] [blame] | 331 | pagefault_enable(); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 332 | |
Chris Wilson | d4aeee7 | 2011-03-14 15:11:24 +0000 | [diff] [blame] | 333 | return ret; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 334 | } |
| 335 | |
Chris Wilson | 7788a76 | 2012-08-24 19:18:18 +0100 | [diff] [blame] | 336 | #define __EXEC_OBJECT_HAS_PIN (1<<31) |
| 337 | #define __EXEC_OBJECT_HAS_FENCE (1<<30) |
Chris Wilson | 1690e1e | 2011-12-14 13:57:08 +0100 | [diff] [blame] | 338 | |
| 339 | static int |
Chris Wilson | dabdfe0 | 2012-03-26 10:10:27 +0200 | [diff] [blame] | 340 | need_reloc_mappable(struct drm_i915_gem_object *obj) |
| 341 | { |
| 342 | struct drm_i915_gem_exec_object2 *entry = obj->exec_entry; |
| 343 | return entry->relocation_count && !use_cpu_reloc(obj); |
| 344 | } |
| 345 | |
| 346 | static int |
Chris Wilson | 7788a76 | 2012-08-24 19:18:18 +0100 | [diff] [blame] | 347 | i915_gem_execbuffer_reserve_object(struct drm_i915_gem_object *obj, |
| 348 | struct intel_ring_buffer *ring) |
Chris Wilson | 1690e1e | 2011-12-14 13:57:08 +0100 | [diff] [blame] | 349 | { |
Chris Wilson | 7788a76 | 2012-08-24 19:18:18 +0100 | [diff] [blame] | 350 | struct drm_i915_private *dev_priv = obj->base.dev->dev_private; |
Chris Wilson | 1690e1e | 2011-12-14 13:57:08 +0100 | [diff] [blame] | 351 | struct drm_i915_gem_exec_object2 *entry = obj->exec_entry; |
| 352 | bool has_fenced_gpu_access = INTEL_INFO(ring->dev)->gen < 4; |
| 353 | bool need_fence, need_mappable; |
| 354 | int ret; |
| 355 | |
| 356 | need_fence = |
| 357 | has_fenced_gpu_access && |
| 358 | entry->flags & EXEC_OBJECT_NEEDS_FENCE && |
| 359 | obj->tiling_mode != I915_TILING_NONE; |
Chris Wilson | dabdfe0 | 2012-03-26 10:10:27 +0200 | [diff] [blame] | 360 | need_mappable = need_fence || need_reloc_mappable(obj); |
Chris Wilson | 1690e1e | 2011-12-14 13:57:08 +0100 | [diff] [blame] | 361 | |
Chris Wilson | 86a1ee2 | 2012-08-11 15:41:04 +0100 | [diff] [blame] | 362 | ret = i915_gem_object_pin(obj, entry->alignment, need_mappable, false); |
Chris Wilson | 1690e1e | 2011-12-14 13:57:08 +0100 | [diff] [blame] | 363 | if (ret) |
| 364 | return ret; |
| 365 | |
Chris Wilson | 7788a76 | 2012-08-24 19:18:18 +0100 | [diff] [blame] | 366 | entry->flags |= __EXEC_OBJECT_HAS_PIN; |
| 367 | |
Chris Wilson | 1690e1e | 2011-12-14 13:57:08 +0100 | [diff] [blame] | 368 | if (has_fenced_gpu_access) { |
| 369 | if (entry->flags & EXEC_OBJECT_NEEDS_FENCE) { |
Chris Wilson | 06d9813 | 2012-04-17 15:31:24 +0100 | [diff] [blame] | 370 | ret = i915_gem_object_get_fence(obj); |
Chris Wilson | 9a5a53b | 2012-03-22 15:10:00 +0000 | [diff] [blame] | 371 | if (ret) |
Chris Wilson | 7788a76 | 2012-08-24 19:18:18 +0100 | [diff] [blame] | 372 | return ret; |
Chris Wilson | 1690e1e | 2011-12-14 13:57:08 +0100 | [diff] [blame] | 373 | |
Chris Wilson | 9a5a53b | 2012-03-22 15:10:00 +0000 | [diff] [blame] | 374 | if (i915_gem_object_pin_fence(obj)) |
Chris Wilson | 1690e1e | 2011-12-14 13:57:08 +0100 | [diff] [blame] | 375 | entry->flags |= __EXEC_OBJECT_HAS_FENCE; |
Chris Wilson | 9a5a53b | 2012-03-22 15:10:00 +0000 | [diff] [blame] | 376 | |
Chris Wilson | 7dd4906 | 2012-03-21 10:48:18 +0000 | [diff] [blame] | 377 | obj->pending_fenced_gpu_access = true; |
Chris Wilson | 1690e1e | 2011-12-14 13:57:08 +0100 | [diff] [blame] | 378 | } |
Chris Wilson | 1690e1e | 2011-12-14 13:57:08 +0100 | [diff] [blame] | 379 | } |
| 380 | |
Chris Wilson | 7788a76 | 2012-08-24 19:18:18 +0100 | [diff] [blame] | 381 | /* Ensure ppgtt mapping exists if needed */ |
| 382 | if (dev_priv->mm.aliasing_ppgtt && !obj->has_aliasing_ppgtt_mapping) { |
| 383 | i915_ppgtt_bind_object(dev_priv->mm.aliasing_ppgtt, |
| 384 | obj, obj->cache_level); |
| 385 | |
| 386 | obj->has_aliasing_ppgtt_mapping = 1; |
| 387 | } |
| 388 | |
Chris Wilson | 1690e1e | 2011-12-14 13:57:08 +0100 | [diff] [blame] | 389 | entry->offset = obj->gtt_offset; |
| 390 | return 0; |
Chris Wilson | 7788a76 | 2012-08-24 19:18:18 +0100 | [diff] [blame] | 391 | } |
Chris Wilson | 1690e1e | 2011-12-14 13:57:08 +0100 | [diff] [blame] | 392 | |
Chris Wilson | 7788a76 | 2012-08-24 19:18:18 +0100 | [diff] [blame] | 393 | static void |
| 394 | i915_gem_execbuffer_unreserve_object(struct drm_i915_gem_object *obj) |
| 395 | { |
| 396 | struct drm_i915_gem_exec_object2 *entry; |
| 397 | |
| 398 | if (!obj->gtt_space) |
| 399 | return; |
| 400 | |
| 401 | entry = obj->exec_entry; |
| 402 | |
| 403 | if (entry->flags & __EXEC_OBJECT_HAS_FENCE) |
| 404 | i915_gem_object_unpin_fence(obj); |
| 405 | |
| 406 | if (entry->flags & __EXEC_OBJECT_HAS_PIN) |
| 407 | i915_gem_object_unpin(obj); |
| 408 | |
| 409 | entry->flags &= ~(__EXEC_OBJECT_HAS_FENCE | __EXEC_OBJECT_HAS_PIN); |
Chris Wilson | 1690e1e | 2011-12-14 13:57:08 +0100 | [diff] [blame] | 410 | } |
| 411 | |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 412 | static int |
Chris Wilson | d9e86c0 | 2010-11-10 16:40:20 +0000 | [diff] [blame] | 413 | i915_gem_execbuffer_reserve(struct intel_ring_buffer *ring, |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 414 | struct drm_file *file, |
Chris Wilson | 6fe4f14 | 2011-01-10 17:35:37 +0000 | [diff] [blame] | 415 | struct list_head *objects) |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 416 | { |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 417 | struct drm_i915_gem_object *obj; |
Chris Wilson | 6fe4f14 | 2011-01-10 17:35:37 +0000 | [diff] [blame] | 418 | struct list_head ordered_objects; |
Chris Wilson | 7788a76 | 2012-08-24 19:18:18 +0100 | [diff] [blame] | 419 | bool has_fenced_gpu_access = INTEL_INFO(ring->dev)->gen < 4; |
| 420 | int retry; |
Chris Wilson | 6fe4f14 | 2011-01-10 17:35:37 +0000 | [diff] [blame] | 421 | |
| 422 | INIT_LIST_HEAD(&ordered_objects); |
| 423 | while (!list_empty(objects)) { |
| 424 | struct drm_i915_gem_exec_object2 *entry; |
| 425 | bool need_fence, need_mappable; |
| 426 | |
| 427 | obj = list_first_entry(objects, |
| 428 | struct drm_i915_gem_object, |
| 429 | exec_list); |
| 430 | entry = obj->exec_entry; |
| 431 | |
| 432 | need_fence = |
| 433 | has_fenced_gpu_access && |
| 434 | entry->flags & EXEC_OBJECT_NEEDS_FENCE && |
| 435 | obj->tiling_mode != I915_TILING_NONE; |
Chris Wilson | dabdfe0 | 2012-03-26 10:10:27 +0200 | [diff] [blame] | 436 | need_mappable = need_fence || need_reloc_mappable(obj); |
Chris Wilson | 6fe4f14 | 2011-01-10 17:35:37 +0000 | [diff] [blame] | 437 | |
| 438 | if (need_mappable) |
| 439 | list_move(&obj->exec_list, &ordered_objects); |
| 440 | else |
| 441 | list_move_tail(&obj->exec_list, &ordered_objects); |
Chris Wilson | 595dad7 | 2011-01-13 11:03:48 +0000 | [diff] [blame] | 442 | |
| 443 | obj->base.pending_read_domains = 0; |
| 444 | obj->base.pending_write_domain = 0; |
Chris Wilson | 016fd0c | 2012-07-20 12:41:07 +0100 | [diff] [blame] | 445 | obj->pending_fenced_gpu_access = false; |
Chris Wilson | 6fe4f14 | 2011-01-10 17:35:37 +0000 | [diff] [blame] | 446 | } |
| 447 | list_splice(&ordered_objects, objects); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 448 | |
| 449 | /* Attempt to pin all of the buffers into the GTT. |
| 450 | * This is done in 3 phases: |
| 451 | * |
| 452 | * 1a. Unbind all objects that do not match the GTT constraints for |
| 453 | * the execbuffer (fenceable, mappable, alignment etc). |
| 454 | * 1b. Increment pin count for already bound objects. |
| 455 | * 2. Bind new objects. |
| 456 | * 3. Decrement pin count. |
| 457 | * |
Chris Wilson | 7788a76 | 2012-08-24 19:18:18 +0100 | [diff] [blame] | 458 | * This avoid unnecessary unbinding of later objects in order to make |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 459 | * room for the earlier objects *unless* we need to defragment. |
| 460 | */ |
| 461 | retry = 0; |
| 462 | do { |
Chris Wilson | 7788a76 | 2012-08-24 19:18:18 +0100 | [diff] [blame] | 463 | int ret = 0; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 464 | |
| 465 | /* Unbind any ill-fitting objects or pin. */ |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 466 | list_for_each_entry(obj, objects, exec_list) { |
Chris Wilson | 6fe4f14 | 2011-01-10 17:35:37 +0000 | [diff] [blame] | 467 | struct drm_i915_gem_exec_object2 *entry = obj->exec_entry; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 468 | bool need_fence, need_mappable; |
Chris Wilson | 1690e1e | 2011-12-14 13:57:08 +0100 | [diff] [blame] | 469 | |
Chris Wilson | 6fe4f14 | 2011-01-10 17:35:37 +0000 | [diff] [blame] | 470 | if (!obj->gtt_space) |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 471 | continue; |
| 472 | |
| 473 | need_fence = |
Chris Wilson | 9b3826b | 2010-12-05 17:11:54 +0000 | [diff] [blame] | 474 | has_fenced_gpu_access && |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 475 | entry->flags & EXEC_OBJECT_NEEDS_FENCE && |
| 476 | obj->tiling_mode != I915_TILING_NONE; |
Chris Wilson | dabdfe0 | 2012-03-26 10:10:27 +0200 | [diff] [blame] | 477 | need_mappable = need_fence || need_reloc_mappable(obj); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 478 | |
| 479 | if ((entry->alignment && obj->gtt_offset & (entry->alignment - 1)) || |
| 480 | (need_mappable && !obj->map_and_fenceable)) |
| 481 | ret = i915_gem_object_unbind(obj); |
| 482 | else |
Chris Wilson | 7788a76 | 2012-08-24 19:18:18 +0100 | [diff] [blame] | 483 | ret = i915_gem_execbuffer_reserve_object(obj, ring); |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 484 | if (ret) |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 485 | goto err; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 486 | } |
| 487 | |
| 488 | /* Bind fresh objects */ |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 489 | list_for_each_entry(obj, objects, exec_list) { |
Chris Wilson | 1690e1e | 2011-12-14 13:57:08 +0100 | [diff] [blame] | 490 | if (obj->gtt_space) |
| 491 | continue; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 492 | |
Chris Wilson | 7788a76 | 2012-08-24 19:18:18 +0100 | [diff] [blame] | 493 | ret = i915_gem_execbuffer_reserve_object(obj, ring); |
| 494 | if (ret) |
| 495 | goto err; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 496 | } |
| 497 | |
Chris Wilson | 7788a76 | 2012-08-24 19:18:18 +0100 | [diff] [blame] | 498 | err: /* Decrement pin count for bound objects */ |
| 499 | list_for_each_entry(obj, objects, exec_list) |
| 500 | i915_gem_execbuffer_unreserve_object(obj); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 501 | |
Chris Wilson | 6c085a7 | 2012-08-20 11:40:46 +0200 | [diff] [blame] | 502 | if (ret != -ENOSPC || retry++) |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 503 | return ret; |
| 504 | |
Chris Wilson | 6c085a7 | 2012-08-20 11:40:46 +0200 | [diff] [blame] | 505 | ret = i915_gem_evict_everything(ring->dev); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 506 | if (ret) |
| 507 | return ret; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 508 | } while (1); |
| 509 | } |
| 510 | |
| 511 | static int |
| 512 | i915_gem_execbuffer_relocate_slow(struct drm_device *dev, |
| 513 | struct drm_file *file, |
Chris Wilson | d9e86c0 | 2010-11-10 16:40:20 +0000 | [diff] [blame] | 514 | struct intel_ring_buffer *ring, |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 515 | struct list_head *objects, |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 516 | struct eb_objects *eb, |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 517 | struct drm_i915_gem_exec_object2 *exec, |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 518 | int count) |
| 519 | { |
| 520 | struct drm_i915_gem_relocation_entry *reloc; |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 521 | struct drm_i915_gem_object *obj; |
Chris Wilson | dd6864a | 2011-01-12 23:49:13 +0000 | [diff] [blame] | 522 | int *reloc_offset; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 523 | int i, total, ret; |
| 524 | |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 525 | /* We may process another execbuffer during the unlock... */ |
Chris Wilson | 36cf174 | 2011-01-10 12:09:12 +0000 | [diff] [blame] | 526 | while (!list_empty(objects)) { |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 527 | obj = list_first_entry(objects, |
| 528 | struct drm_i915_gem_object, |
| 529 | exec_list); |
| 530 | list_del_init(&obj->exec_list); |
| 531 | drm_gem_object_unreference(&obj->base); |
| 532 | } |
| 533 | |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 534 | mutex_unlock(&dev->struct_mutex); |
| 535 | |
| 536 | total = 0; |
| 537 | for (i = 0; i < count; i++) |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 538 | total += exec[i].relocation_count; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 539 | |
Chris Wilson | dd6864a | 2011-01-12 23:49:13 +0000 | [diff] [blame] | 540 | reloc_offset = drm_malloc_ab(count, sizeof(*reloc_offset)); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 541 | reloc = drm_malloc_ab(total, sizeof(*reloc)); |
Chris Wilson | dd6864a | 2011-01-12 23:49:13 +0000 | [diff] [blame] | 542 | if (reloc == NULL || reloc_offset == NULL) { |
| 543 | drm_free_large(reloc); |
| 544 | drm_free_large(reloc_offset); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 545 | mutex_lock(&dev->struct_mutex); |
| 546 | return -ENOMEM; |
| 547 | } |
| 548 | |
| 549 | total = 0; |
| 550 | for (i = 0; i < count; i++) { |
| 551 | struct drm_i915_gem_relocation_entry __user *user_relocs; |
| 552 | |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 553 | user_relocs = (void __user *)(uintptr_t)exec[i].relocs_ptr; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 554 | |
| 555 | if (copy_from_user(reloc+total, user_relocs, |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 556 | exec[i].relocation_count * sizeof(*reloc))) { |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 557 | ret = -EFAULT; |
| 558 | mutex_lock(&dev->struct_mutex); |
| 559 | goto err; |
| 560 | } |
| 561 | |
Chris Wilson | dd6864a | 2011-01-12 23:49:13 +0000 | [diff] [blame] | 562 | reloc_offset[i] = total; |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 563 | total += exec[i].relocation_count; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 564 | } |
| 565 | |
| 566 | ret = i915_mutex_lock_interruptible(dev); |
| 567 | if (ret) { |
| 568 | mutex_lock(&dev->struct_mutex); |
| 569 | goto err; |
| 570 | } |
| 571 | |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 572 | /* reacquire the objects */ |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 573 | eb_reset(eb); |
| 574 | for (i = 0; i < count; i++) { |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 575 | obj = to_intel_bo(drm_gem_object_lookup(dev, file, |
| 576 | exec[i].handle)); |
Chris Wilson | c872522 | 2011-02-19 11:31:06 +0000 | [diff] [blame] | 577 | if (&obj->base == NULL) { |
Daniel Vetter | ff24019 | 2012-01-31 21:08:14 +0100 | [diff] [blame] | 578 | DRM_DEBUG("Invalid object handle %d at index %d\n", |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 579 | exec[i].handle, i); |
| 580 | ret = -ENOENT; |
| 581 | goto err; |
| 582 | } |
| 583 | |
| 584 | list_add_tail(&obj->exec_list, objects); |
| 585 | obj->exec_handle = exec[i].handle; |
Chris Wilson | 6fe4f14 | 2011-01-10 17:35:37 +0000 | [diff] [blame] | 586 | obj->exec_entry = &exec[i]; |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 587 | eb_add_object(eb, obj); |
| 588 | } |
| 589 | |
Chris Wilson | 6fe4f14 | 2011-01-10 17:35:37 +0000 | [diff] [blame] | 590 | ret = i915_gem_execbuffer_reserve(ring, file, objects); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 591 | if (ret) |
| 592 | goto err; |
| 593 | |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 594 | list_for_each_entry(obj, objects, exec_list) { |
Chris Wilson | dd6864a | 2011-01-12 23:49:13 +0000 | [diff] [blame] | 595 | int offset = obj->exec_entry - exec; |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 596 | ret = i915_gem_execbuffer_relocate_object_slow(obj, eb, |
Chris Wilson | dd6864a | 2011-01-12 23:49:13 +0000 | [diff] [blame] | 597 | reloc + reloc_offset[offset]); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 598 | if (ret) |
| 599 | goto err; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 600 | } |
| 601 | |
| 602 | /* Leave the user relocations as are, this is the painfully slow path, |
| 603 | * and we want to avoid the complication of dropping the lock whilst |
| 604 | * having buffers reserved in the aperture and so causing spurious |
| 605 | * ENOSPC for random operations. |
| 606 | */ |
| 607 | |
| 608 | err: |
| 609 | drm_free_large(reloc); |
Chris Wilson | dd6864a | 2011-01-12 23:49:13 +0000 | [diff] [blame] | 610 | drm_free_large(reloc_offset); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 611 | return ret; |
| 612 | } |
| 613 | |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 614 | static int |
Chris Wilson | c59a333 | 2011-03-06 13:51:29 +0000 | [diff] [blame] | 615 | i915_gem_execbuffer_wait_for_flips(struct intel_ring_buffer *ring, u32 flips) |
| 616 | { |
| 617 | u32 plane, flip_mask; |
| 618 | int ret; |
| 619 | |
| 620 | /* Check for any pending flips. As we only maintain a flip queue depth |
| 621 | * of 1, we can simply insert a WAIT for the next display flip prior |
| 622 | * to executing the batch and avoid stalling the CPU. |
| 623 | */ |
| 624 | |
| 625 | for (plane = 0; flips >> plane; plane++) { |
| 626 | if (((flips >> plane) & 1) == 0) |
| 627 | continue; |
| 628 | |
| 629 | if (plane) |
| 630 | flip_mask = MI_WAIT_FOR_PLANE_B_FLIP; |
| 631 | else |
| 632 | flip_mask = MI_WAIT_FOR_PLANE_A_FLIP; |
| 633 | |
| 634 | ret = intel_ring_begin(ring, 2); |
| 635 | if (ret) |
| 636 | return ret; |
| 637 | |
| 638 | intel_ring_emit(ring, MI_WAIT_FOR_EVENT | flip_mask); |
| 639 | intel_ring_emit(ring, MI_NOOP); |
| 640 | intel_ring_advance(ring); |
| 641 | } |
| 642 | |
| 643 | return 0; |
| 644 | } |
| 645 | |
Chris Wilson | c59a333 | 2011-03-06 13:51:29 +0000 | [diff] [blame] | 646 | static int |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 647 | i915_gem_execbuffer_move_to_gpu(struct intel_ring_buffer *ring, |
| 648 | struct list_head *objects) |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 649 | { |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 650 | struct drm_i915_gem_object *obj; |
Daniel Vetter | 6ac42f4 | 2012-07-21 12:25:01 +0200 | [diff] [blame] | 651 | uint32_t flush_domains = 0; |
| 652 | uint32_t flips = 0; |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 653 | int ret; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 654 | |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 655 | list_for_each_entry(obj, objects, exec_list) { |
Ben Widawsky | 2911a35 | 2012-04-05 14:47:36 -0700 | [diff] [blame] | 656 | ret = i915_gem_object_sync(obj, ring); |
Chris Wilson | 1ec14ad | 2010-12-04 11:30:53 +0000 | [diff] [blame] | 657 | if (ret) |
| 658 | return ret; |
Daniel Vetter | 6ac42f4 | 2012-07-21 12:25:01 +0200 | [diff] [blame] | 659 | |
| 660 | if (obj->base.write_domain & I915_GEM_DOMAIN_CPU) |
| 661 | i915_gem_clflush_object(obj); |
| 662 | |
| 663 | if (obj->base.pending_write_domain) |
| 664 | flips |= atomic_read(&obj->pending_flip); |
| 665 | |
| 666 | flush_domains |= obj->base.write_domain; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 667 | } |
| 668 | |
Daniel Vetter | 6ac42f4 | 2012-07-21 12:25:01 +0200 | [diff] [blame] | 669 | if (flips) { |
| 670 | ret = i915_gem_execbuffer_wait_for_flips(ring, flips); |
| 671 | if (ret) |
| 672 | return ret; |
| 673 | } |
| 674 | |
| 675 | if (flush_domains & I915_GEM_DOMAIN_CPU) |
| 676 | intel_gtt_chipset_flush(); |
| 677 | |
| 678 | if (flush_domains & I915_GEM_DOMAIN_GTT) |
| 679 | wmb(); |
| 680 | |
Chris Wilson | 09cf7c9 | 2012-07-13 14:14:08 +0100 | [diff] [blame] | 681 | /* Unconditionally invalidate gpu caches and ensure that we do flush |
| 682 | * any residual writes from the previous batch. |
| 683 | */ |
Chris Wilson | a7b9761 | 2012-07-20 12:41:08 +0100 | [diff] [blame] | 684 | return intel_ring_invalidate_all_caches(ring); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 685 | } |
| 686 | |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 687 | static bool |
| 688 | i915_gem_check_execbuffer(struct drm_i915_gem_execbuffer2 *exec) |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 689 | { |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 690 | return ((exec->batch_start_offset | exec->batch_len) & 0x7) == 0; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 691 | } |
| 692 | |
| 693 | static int |
| 694 | validate_exec_list(struct drm_i915_gem_exec_object2 *exec, |
| 695 | int count) |
| 696 | { |
| 697 | int i; |
| 698 | |
| 699 | for (i = 0; i < count; i++) { |
| 700 | char __user *ptr = (char __user *)(uintptr_t)exec[i].relocs_ptr; |
| 701 | int length; /* limited by fault_in_pages_readable() */ |
| 702 | |
| 703 | /* First check for malicious input causing overflow */ |
| 704 | if (exec[i].relocation_count > |
| 705 | INT_MAX / sizeof(struct drm_i915_gem_relocation_entry)) |
| 706 | return -EINVAL; |
| 707 | |
| 708 | length = exec[i].relocation_count * |
| 709 | sizeof(struct drm_i915_gem_relocation_entry); |
| 710 | if (!access_ok(VERIFY_READ, ptr, length)) |
| 711 | return -EFAULT; |
| 712 | |
| 713 | /* we may also need to update the presumed offsets */ |
| 714 | if (!access_ok(VERIFY_WRITE, ptr, length)) |
| 715 | return -EFAULT; |
| 716 | |
Daniel Vetter | f56f821 | 2012-03-25 19:47:41 +0200 | [diff] [blame] | 717 | if (fault_in_multipages_readable(ptr, length)) |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 718 | return -EFAULT; |
| 719 | } |
| 720 | |
| 721 | return 0; |
| 722 | } |
| 723 | |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 724 | static void |
| 725 | i915_gem_execbuffer_move_to_active(struct list_head *objects, |
Chris Wilson | 1ec14ad | 2010-12-04 11:30:53 +0000 | [diff] [blame] | 726 | struct intel_ring_buffer *ring, |
| 727 | u32 seqno) |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 728 | { |
| 729 | struct drm_i915_gem_object *obj; |
| 730 | |
| 731 | list_for_each_entry(obj, objects, exec_list) { |
Chris Wilson | 69c2fc8 | 2012-07-20 12:41:03 +0100 | [diff] [blame] | 732 | u32 old_read = obj->base.read_domains; |
| 733 | u32 old_write = obj->base.write_domain; |
Chris Wilson | db53a30 | 2011-02-03 11:57:46 +0000 | [diff] [blame] | 734 | |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 735 | obj->base.read_domains = obj->base.pending_read_domains; |
| 736 | obj->base.write_domain = obj->base.pending_write_domain; |
| 737 | obj->fenced_gpu_access = obj->pending_fenced_gpu_access; |
| 738 | |
Chris Wilson | 1ec14ad | 2010-12-04 11:30:53 +0000 | [diff] [blame] | 739 | i915_gem_object_move_to_active(obj, ring, seqno); |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 740 | if (obj->base.write_domain) { |
| 741 | obj->dirty = 1; |
Chris Wilson | 0201f1e | 2012-07-20 12:41:01 +0100 | [diff] [blame] | 742 | obj->last_write_seqno = seqno; |
Chris Wilson | acb87df | 2012-05-03 15:47:57 +0100 | [diff] [blame] | 743 | if (obj->pin_count) /* check for potential scanout */ |
Chris Wilson | f047e39 | 2012-07-21 12:31:41 +0100 | [diff] [blame] | 744 | intel_mark_fb_busy(obj); |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 745 | } |
| 746 | |
Chris Wilson | db53a30 | 2011-02-03 11:57:46 +0000 | [diff] [blame] | 747 | trace_i915_gem_object_change_domain(obj, old_read, old_write); |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 748 | } |
| 749 | } |
| 750 | |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 751 | static void |
| 752 | i915_gem_execbuffer_retire_commands(struct drm_device *dev, |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 753 | struct drm_file *file, |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 754 | struct intel_ring_buffer *ring) |
| 755 | { |
Daniel Vetter | cc889e0 | 2012-06-13 20:45:19 +0200 | [diff] [blame] | 756 | /* Unconditionally force add_request to emit a full flush. */ |
| 757 | ring->gpu_caches_dirty = true; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 758 | |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 759 | /* Add a breadcrumb for the completion of the batch buffer */ |
Chris Wilson | 3bb73ab | 2012-07-20 12:40:59 +0100 | [diff] [blame] | 760 | (void)i915_add_request(ring, file, NULL); |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 761 | } |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 762 | |
| 763 | static int |
Eric Anholt | ae662d3 | 2012-01-03 09:23:29 -0800 | [diff] [blame] | 764 | i915_reset_gen7_sol_offsets(struct drm_device *dev, |
| 765 | struct intel_ring_buffer *ring) |
| 766 | { |
| 767 | drm_i915_private_t *dev_priv = dev->dev_private; |
| 768 | int ret, i; |
| 769 | |
| 770 | if (!IS_GEN7(dev) || ring != &dev_priv->ring[RCS]) |
| 771 | return 0; |
| 772 | |
| 773 | ret = intel_ring_begin(ring, 4 * 3); |
| 774 | if (ret) |
| 775 | return ret; |
| 776 | |
| 777 | for (i = 0; i < 4; i++) { |
| 778 | intel_ring_emit(ring, MI_LOAD_REGISTER_IMM(1)); |
| 779 | intel_ring_emit(ring, GEN7_SO_WRITE_OFFSET(i)); |
| 780 | intel_ring_emit(ring, 0); |
| 781 | } |
| 782 | |
| 783 | intel_ring_advance(ring); |
| 784 | |
| 785 | return 0; |
| 786 | } |
| 787 | |
| 788 | static int |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 789 | i915_gem_do_execbuffer(struct drm_device *dev, void *data, |
| 790 | struct drm_file *file, |
| 791 | struct drm_i915_gem_execbuffer2 *args, |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 792 | struct drm_i915_gem_exec_object2 *exec) |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 793 | { |
| 794 | drm_i915_private_t *dev_priv = dev->dev_private; |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 795 | struct list_head objects; |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 796 | struct eb_objects *eb; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 797 | struct drm_i915_gem_object *batch_obj; |
| 798 | struct drm_clip_rect *cliprects = NULL; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 799 | struct intel_ring_buffer *ring; |
Ben Widawsky | 6e0a69d | 2012-06-04 14:42:55 -0700 | [diff] [blame] | 800 | u32 ctx_id = i915_execbuffer2_get_context_id(*args); |
Chris Wilson | c4e7a41 | 2010-11-30 14:10:25 +0000 | [diff] [blame] | 801 | u32 exec_start, exec_len; |
Chris Wilson | 1ec14ad | 2010-12-04 11:30:53 +0000 | [diff] [blame] | 802 | u32 seqno; |
Ben Widawsky | 84f9f93 | 2011-12-12 19:21:58 -0800 | [diff] [blame] | 803 | u32 mask; |
Chris Wilson | d7d4eed | 2012-10-17 12:09:54 +0100 | [diff] [blame^] | 804 | u32 flags; |
Chris Wilson | 72bfa19 | 2010-12-19 11:42:05 +0000 | [diff] [blame] | 805 | int ret, mode, i; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 806 | |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 807 | if (!i915_gem_check_execbuffer(args)) { |
Daniel Vetter | ff24019 | 2012-01-31 21:08:14 +0100 | [diff] [blame] | 808 | DRM_DEBUG("execbuf with invalid offset/length\n"); |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 809 | return -EINVAL; |
| 810 | } |
| 811 | |
| 812 | ret = validate_exec_list(exec, args->buffer_count); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 813 | if (ret) |
| 814 | return ret; |
| 815 | |
Chris Wilson | d7d4eed | 2012-10-17 12:09:54 +0100 | [diff] [blame^] | 816 | flags = 0; |
| 817 | if (args->flags & I915_EXEC_SECURE) { |
| 818 | if (!file->is_master || !capable(CAP_SYS_ADMIN)) |
| 819 | return -EPERM; |
| 820 | |
| 821 | flags |= I915_DISPATCH_SECURE; |
| 822 | } |
| 823 | |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 824 | switch (args->flags & I915_EXEC_RING_MASK) { |
| 825 | case I915_EXEC_DEFAULT: |
| 826 | case I915_EXEC_RENDER: |
Chris Wilson | 1ec14ad | 2010-12-04 11:30:53 +0000 | [diff] [blame] | 827 | ring = &dev_priv->ring[RCS]; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 828 | break; |
| 829 | case I915_EXEC_BSD: |
Chris Wilson | 1ec14ad | 2010-12-04 11:30:53 +0000 | [diff] [blame] | 830 | ring = &dev_priv->ring[VCS]; |
Ben Widawsky | 6e0a69d | 2012-06-04 14:42:55 -0700 | [diff] [blame] | 831 | if (ctx_id != 0) { |
| 832 | DRM_DEBUG("Ring %s doesn't support contexts\n", |
| 833 | ring->name); |
| 834 | return -EPERM; |
| 835 | } |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 836 | break; |
| 837 | case I915_EXEC_BLT: |
Chris Wilson | 1ec14ad | 2010-12-04 11:30:53 +0000 | [diff] [blame] | 838 | ring = &dev_priv->ring[BCS]; |
Ben Widawsky | 6e0a69d | 2012-06-04 14:42:55 -0700 | [diff] [blame] | 839 | if (ctx_id != 0) { |
| 840 | DRM_DEBUG("Ring %s doesn't support contexts\n", |
| 841 | ring->name); |
| 842 | return -EPERM; |
| 843 | } |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 844 | break; |
| 845 | default: |
Daniel Vetter | ff24019 | 2012-01-31 21:08:14 +0100 | [diff] [blame] | 846 | DRM_DEBUG("execbuf with unknown ring: %d\n", |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 847 | (int)(args->flags & I915_EXEC_RING_MASK)); |
| 848 | return -EINVAL; |
| 849 | } |
Chris Wilson | a15817c | 2012-05-11 14:29:31 +0100 | [diff] [blame] | 850 | if (!intel_ring_initialized(ring)) { |
| 851 | DRM_DEBUG("execbuf with invalid ring: %d\n", |
| 852 | (int)(args->flags & I915_EXEC_RING_MASK)); |
| 853 | return -EINVAL; |
| 854 | } |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 855 | |
Chris Wilson | 72bfa19 | 2010-12-19 11:42:05 +0000 | [diff] [blame] | 856 | mode = args->flags & I915_EXEC_CONSTANTS_MASK; |
Ben Widawsky | 84f9f93 | 2011-12-12 19:21:58 -0800 | [diff] [blame] | 857 | mask = I915_EXEC_CONSTANTS_MASK; |
Chris Wilson | 72bfa19 | 2010-12-19 11:42:05 +0000 | [diff] [blame] | 858 | switch (mode) { |
| 859 | case I915_EXEC_CONSTANTS_REL_GENERAL: |
| 860 | case I915_EXEC_CONSTANTS_ABSOLUTE: |
| 861 | case I915_EXEC_CONSTANTS_REL_SURFACE: |
| 862 | if (ring == &dev_priv->ring[RCS] && |
| 863 | mode != dev_priv->relative_constants_mode) { |
| 864 | if (INTEL_INFO(dev)->gen < 4) |
| 865 | return -EINVAL; |
| 866 | |
| 867 | if (INTEL_INFO(dev)->gen > 5 && |
| 868 | mode == I915_EXEC_CONSTANTS_REL_SURFACE) |
| 869 | return -EINVAL; |
Ben Widawsky | 84f9f93 | 2011-12-12 19:21:58 -0800 | [diff] [blame] | 870 | |
| 871 | /* The HW changed the meaning on this bit on gen6 */ |
| 872 | if (INTEL_INFO(dev)->gen >= 6) |
| 873 | mask &= ~I915_EXEC_CONSTANTS_REL_SURFACE; |
Chris Wilson | 72bfa19 | 2010-12-19 11:42:05 +0000 | [diff] [blame] | 874 | } |
| 875 | break; |
| 876 | default: |
Daniel Vetter | ff24019 | 2012-01-31 21:08:14 +0100 | [diff] [blame] | 877 | DRM_DEBUG("execbuf with unknown constants: %d\n", mode); |
Chris Wilson | 72bfa19 | 2010-12-19 11:42:05 +0000 | [diff] [blame] | 878 | return -EINVAL; |
| 879 | } |
| 880 | |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 881 | if (args->buffer_count < 1) { |
Daniel Vetter | ff24019 | 2012-01-31 21:08:14 +0100 | [diff] [blame] | 882 | DRM_DEBUG("execbuf with %d buffers\n", args->buffer_count); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 883 | return -EINVAL; |
| 884 | } |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 885 | |
| 886 | if (args->num_cliprects != 0) { |
Chris Wilson | 1ec14ad | 2010-12-04 11:30:53 +0000 | [diff] [blame] | 887 | if (ring != &dev_priv->ring[RCS]) { |
Daniel Vetter | ff24019 | 2012-01-31 21:08:14 +0100 | [diff] [blame] | 888 | DRM_DEBUG("clip rectangles are only valid with the render ring\n"); |
Chris Wilson | c4e7a41 | 2010-11-30 14:10:25 +0000 | [diff] [blame] | 889 | return -EINVAL; |
| 890 | } |
| 891 | |
Daniel Vetter | 6ebebc9 | 2012-04-26 23:28:11 +0200 | [diff] [blame] | 892 | if (INTEL_INFO(dev)->gen >= 5) { |
| 893 | DRM_DEBUG("clip rectangles are only valid on pre-gen5\n"); |
| 894 | return -EINVAL; |
| 895 | } |
| 896 | |
Xi Wang | 44afb3a | 2012-04-23 04:06:42 -0400 | [diff] [blame] | 897 | if (args->num_cliprects > UINT_MAX / sizeof(*cliprects)) { |
| 898 | DRM_DEBUG("execbuf with %u cliprects\n", |
| 899 | args->num_cliprects); |
| 900 | return -EINVAL; |
| 901 | } |
Daniel Vetter | 5e13a0c | 2012-05-08 13:39:59 +0200 | [diff] [blame] | 902 | |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 903 | cliprects = kmalloc(args->num_cliprects * sizeof(*cliprects), |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 904 | GFP_KERNEL); |
| 905 | if (cliprects == NULL) { |
| 906 | ret = -ENOMEM; |
| 907 | goto pre_mutex_err; |
| 908 | } |
| 909 | |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 910 | if (copy_from_user(cliprects, |
| 911 | (struct drm_clip_rect __user *)(uintptr_t) |
| 912 | args->cliprects_ptr, |
| 913 | sizeof(*cliprects)*args->num_cliprects)) { |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 914 | ret = -EFAULT; |
| 915 | goto pre_mutex_err; |
| 916 | } |
| 917 | } |
| 918 | |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 919 | ret = i915_mutex_lock_interruptible(dev); |
| 920 | if (ret) |
| 921 | goto pre_mutex_err; |
| 922 | |
| 923 | if (dev_priv->mm.suspended) { |
| 924 | mutex_unlock(&dev->struct_mutex); |
| 925 | ret = -EBUSY; |
| 926 | goto pre_mutex_err; |
| 927 | } |
| 928 | |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 929 | eb = eb_create(args->buffer_count); |
| 930 | if (eb == NULL) { |
| 931 | mutex_unlock(&dev->struct_mutex); |
| 932 | ret = -ENOMEM; |
| 933 | goto pre_mutex_err; |
| 934 | } |
| 935 | |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 936 | /* Look up object handles */ |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 937 | INIT_LIST_HEAD(&objects); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 938 | for (i = 0; i < args->buffer_count; i++) { |
| 939 | struct drm_i915_gem_object *obj; |
| 940 | |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 941 | obj = to_intel_bo(drm_gem_object_lookup(dev, file, |
| 942 | exec[i].handle)); |
Chris Wilson | c872522 | 2011-02-19 11:31:06 +0000 | [diff] [blame] | 943 | if (&obj->base == NULL) { |
Daniel Vetter | ff24019 | 2012-01-31 21:08:14 +0100 | [diff] [blame] | 944 | DRM_DEBUG("Invalid object handle %d at index %d\n", |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 945 | exec[i].handle, i); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 946 | /* prevent error path from reading uninitialized data */ |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 947 | ret = -ENOENT; |
| 948 | goto err; |
| 949 | } |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 950 | |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 951 | if (!list_empty(&obj->exec_list)) { |
Daniel Vetter | ff24019 | 2012-01-31 21:08:14 +0100 | [diff] [blame] | 952 | DRM_DEBUG("Object %p [handle %d, index %d] appears more than once in object list\n", |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 953 | obj, exec[i].handle, i); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 954 | ret = -EINVAL; |
| 955 | goto err; |
| 956 | } |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 957 | |
| 958 | list_add_tail(&obj->exec_list, &objects); |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 959 | obj->exec_handle = exec[i].handle; |
Chris Wilson | 6fe4f14 | 2011-01-10 17:35:37 +0000 | [diff] [blame] | 960 | obj->exec_entry = &exec[i]; |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 961 | eb_add_object(eb, obj); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 962 | } |
| 963 | |
Chris Wilson | 6fe4f14 | 2011-01-10 17:35:37 +0000 | [diff] [blame] | 964 | /* take note of the batch buffer before we might reorder the lists */ |
| 965 | batch_obj = list_entry(objects.prev, |
| 966 | struct drm_i915_gem_object, |
| 967 | exec_list); |
| 968 | |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 969 | /* Move the objects en-masse into the GTT, evicting if necessary. */ |
Chris Wilson | 6fe4f14 | 2011-01-10 17:35:37 +0000 | [diff] [blame] | 970 | ret = i915_gem_execbuffer_reserve(ring, file, &objects); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 971 | if (ret) |
| 972 | goto err; |
| 973 | |
| 974 | /* The objects are in their final locations, apply the relocations. */ |
Chris Wilson | 6fe4f14 | 2011-01-10 17:35:37 +0000 | [diff] [blame] | 975 | ret = i915_gem_execbuffer_relocate(dev, eb, &objects); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 976 | if (ret) { |
| 977 | if (ret == -EFAULT) { |
Chris Wilson | d9e86c0 | 2010-11-10 16:40:20 +0000 | [diff] [blame] | 978 | ret = i915_gem_execbuffer_relocate_slow(dev, file, ring, |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 979 | &objects, eb, |
| 980 | exec, |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 981 | args->buffer_count); |
| 982 | BUG_ON(!mutex_is_locked(&dev->struct_mutex)); |
| 983 | } |
| 984 | if (ret) |
| 985 | goto err; |
| 986 | } |
| 987 | |
| 988 | /* Set the pending read domains for the batch buffer to COMMAND */ |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 989 | if (batch_obj->base.pending_write_domain) { |
Daniel Vetter | ff24019 | 2012-01-31 21:08:14 +0100 | [diff] [blame] | 990 | DRM_DEBUG("Attempting to use self-modifying batch buffer\n"); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 991 | ret = -EINVAL; |
| 992 | goto err; |
| 993 | } |
| 994 | batch_obj->base.pending_read_domains |= I915_GEM_DOMAIN_COMMAND; |
| 995 | |
Chris Wilson | d7d4eed | 2012-10-17 12:09:54 +0100 | [diff] [blame^] | 996 | /* snb/ivb/vlv conflate the "batch in ppgtt" bit with the "non-secure |
| 997 | * batch" bit. Hence we need to pin secure batches into the global gtt. |
| 998 | * hsw should have this fixed, but let's be paranoid and do it |
| 999 | * unconditionally for now. */ |
| 1000 | if (flags & I915_DISPATCH_SECURE && !batch_obj->has_global_gtt_mapping) |
| 1001 | i915_gem_gtt_bind_object(batch_obj, batch_obj->cache_level); |
| 1002 | |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 1003 | ret = i915_gem_execbuffer_move_to_gpu(ring, &objects); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1004 | if (ret) |
| 1005 | goto err; |
| 1006 | |
Chris Wilson | db53a30 | 2011-02-03 11:57:46 +0000 | [diff] [blame] | 1007 | seqno = i915_gem_next_request_seqno(ring); |
Chris Wilson | 076e2c0 | 2011-01-21 10:07:18 +0000 | [diff] [blame] | 1008 | for (i = 0; i < ARRAY_SIZE(ring->sync_seqno); i++) { |
Chris Wilson | 1ec14ad | 2010-12-04 11:30:53 +0000 | [diff] [blame] | 1009 | if (seqno < ring->sync_seqno[i]) { |
| 1010 | /* The GPU can not handle its semaphore value wrapping, |
| 1011 | * so every billion or so execbuffers, we need to stall |
| 1012 | * the GPU in order to reset the counters. |
| 1013 | */ |
Ben Widawsky | b2da9fe | 2012-04-26 16:02:58 -0700 | [diff] [blame] | 1014 | ret = i915_gpu_idle(dev); |
Chris Wilson | 1ec14ad | 2010-12-04 11:30:53 +0000 | [diff] [blame] | 1015 | if (ret) |
| 1016 | goto err; |
Ben Widawsky | b2da9fe | 2012-04-26 16:02:58 -0700 | [diff] [blame] | 1017 | i915_gem_retire_requests(dev); |
Chris Wilson | 1ec14ad | 2010-12-04 11:30:53 +0000 | [diff] [blame] | 1018 | |
| 1019 | BUG_ON(ring->sync_seqno[i]); |
| 1020 | } |
| 1021 | } |
| 1022 | |
Eric Anholt | 0da5cec | 2012-07-23 12:33:55 -0700 | [diff] [blame] | 1023 | ret = i915_switch_context(ring, file, ctx_id); |
| 1024 | if (ret) |
| 1025 | goto err; |
| 1026 | |
Ben Widawsky | e2971bd | 2011-12-12 19:21:57 -0800 | [diff] [blame] | 1027 | if (ring == &dev_priv->ring[RCS] && |
| 1028 | mode != dev_priv->relative_constants_mode) { |
| 1029 | ret = intel_ring_begin(ring, 4); |
| 1030 | if (ret) |
| 1031 | goto err; |
| 1032 | |
| 1033 | intel_ring_emit(ring, MI_NOOP); |
| 1034 | intel_ring_emit(ring, MI_LOAD_REGISTER_IMM(1)); |
| 1035 | intel_ring_emit(ring, INSTPM); |
Ben Widawsky | 84f9f93 | 2011-12-12 19:21:58 -0800 | [diff] [blame] | 1036 | intel_ring_emit(ring, mask << 16 | mode); |
Ben Widawsky | e2971bd | 2011-12-12 19:21:57 -0800 | [diff] [blame] | 1037 | intel_ring_advance(ring); |
| 1038 | |
| 1039 | dev_priv->relative_constants_mode = mode; |
| 1040 | } |
| 1041 | |
Eric Anholt | ae662d3 | 2012-01-03 09:23:29 -0800 | [diff] [blame] | 1042 | if (args->flags & I915_EXEC_GEN7_SOL_RESET) { |
| 1043 | ret = i915_reset_gen7_sol_offsets(dev, ring); |
| 1044 | if (ret) |
| 1045 | goto err; |
| 1046 | } |
| 1047 | |
Chris Wilson | d7d4eed | 2012-10-17 12:09:54 +0100 | [diff] [blame^] | 1048 | trace_i915_gem_ring_dispatch(ring, seqno, flags); |
Chris Wilson | db53a30 | 2011-02-03 11:57:46 +0000 | [diff] [blame] | 1049 | |
Chris Wilson | c4e7a41 | 2010-11-30 14:10:25 +0000 | [diff] [blame] | 1050 | exec_start = batch_obj->gtt_offset + args->batch_start_offset; |
| 1051 | exec_len = args->batch_len; |
| 1052 | if (cliprects) { |
| 1053 | for (i = 0; i < args->num_cliprects; i++) { |
| 1054 | ret = i915_emit_box(dev, &cliprects[i], |
| 1055 | args->DR1, args->DR4); |
| 1056 | if (ret) |
| 1057 | goto err; |
| 1058 | |
| 1059 | ret = ring->dispatch_execbuffer(ring, |
Chris Wilson | d7d4eed | 2012-10-17 12:09:54 +0100 | [diff] [blame^] | 1060 | exec_start, exec_len, |
| 1061 | flags); |
Chris Wilson | c4e7a41 | 2010-11-30 14:10:25 +0000 | [diff] [blame] | 1062 | if (ret) |
| 1063 | goto err; |
| 1064 | } |
| 1065 | } else { |
Chris Wilson | d7d4eed | 2012-10-17 12:09:54 +0100 | [diff] [blame^] | 1066 | ret = ring->dispatch_execbuffer(ring, |
| 1067 | exec_start, exec_len, |
| 1068 | flags); |
Chris Wilson | c4e7a41 | 2010-11-30 14:10:25 +0000 | [diff] [blame] | 1069 | if (ret) |
| 1070 | goto err; |
| 1071 | } |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1072 | |
Chris Wilson | 1ec14ad | 2010-12-04 11:30:53 +0000 | [diff] [blame] | 1073 | i915_gem_execbuffer_move_to_active(&objects, ring, seqno); |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 1074 | i915_gem_execbuffer_retire_commands(dev, file, ring); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1075 | |
| 1076 | err: |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 1077 | eb_destroy(eb); |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 1078 | while (!list_empty(&objects)) { |
| 1079 | struct drm_i915_gem_object *obj; |
| 1080 | |
| 1081 | obj = list_first_entry(&objects, |
| 1082 | struct drm_i915_gem_object, |
| 1083 | exec_list); |
| 1084 | list_del_init(&obj->exec_list); |
| 1085 | drm_gem_object_unreference(&obj->base); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1086 | } |
| 1087 | |
| 1088 | mutex_unlock(&dev->struct_mutex); |
| 1089 | |
| 1090 | pre_mutex_err: |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1091 | kfree(cliprects); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1092 | return ret; |
| 1093 | } |
| 1094 | |
| 1095 | /* |
| 1096 | * Legacy execbuffer just creates an exec2 list from the original exec object |
| 1097 | * list array and passes it to the real function. |
| 1098 | */ |
| 1099 | int |
| 1100 | i915_gem_execbuffer(struct drm_device *dev, void *data, |
| 1101 | struct drm_file *file) |
| 1102 | { |
| 1103 | struct drm_i915_gem_execbuffer *args = data; |
| 1104 | struct drm_i915_gem_execbuffer2 exec2; |
| 1105 | struct drm_i915_gem_exec_object *exec_list = NULL; |
| 1106 | struct drm_i915_gem_exec_object2 *exec2_list = NULL; |
| 1107 | int ret, i; |
| 1108 | |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1109 | if (args->buffer_count < 1) { |
Daniel Vetter | ff24019 | 2012-01-31 21:08:14 +0100 | [diff] [blame] | 1110 | DRM_DEBUG("execbuf with %d buffers\n", args->buffer_count); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1111 | return -EINVAL; |
| 1112 | } |
| 1113 | |
| 1114 | /* Copy in the exec list from userland */ |
| 1115 | exec_list = drm_malloc_ab(sizeof(*exec_list), args->buffer_count); |
| 1116 | exec2_list = drm_malloc_ab(sizeof(*exec2_list), args->buffer_count); |
| 1117 | if (exec_list == NULL || exec2_list == NULL) { |
Daniel Vetter | ff24019 | 2012-01-31 21:08:14 +0100 | [diff] [blame] | 1118 | DRM_DEBUG("Failed to allocate exec list for %d buffers\n", |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1119 | args->buffer_count); |
| 1120 | drm_free_large(exec_list); |
| 1121 | drm_free_large(exec2_list); |
| 1122 | return -ENOMEM; |
| 1123 | } |
| 1124 | ret = copy_from_user(exec_list, |
Chris Wilson | ba7a645 | 2012-09-14 11:46:00 +0100 | [diff] [blame] | 1125 | (void __user *)(uintptr_t)args->buffers_ptr, |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1126 | sizeof(*exec_list) * args->buffer_count); |
| 1127 | if (ret != 0) { |
Daniel Vetter | ff24019 | 2012-01-31 21:08:14 +0100 | [diff] [blame] | 1128 | DRM_DEBUG("copy %d exec entries failed %d\n", |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1129 | args->buffer_count, ret); |
| 1130 | drm_free_large(exec_list); |
| 1131 | drm_free_large(exec2_list); |
| 1132 | return -EFAULT; |
| 1133 | } |
| 1134 | |
| 1135 | for (i = 0; i < args->buffer_count; i++) { |
| 1136 | exec2_list[i].handle = exec_list[i].handle; |
| 1137 | exec2_list[i].relocation_count = exec_list[i].relocation_count; |
| 1138 | exec2_list[i].relocs_ptr = exec_list[i].relocs_ptr; |
| 1139 | exec2_list[i].alignment = exec_list[i].alignment; |
| 1140 | exec2_list[i].offset = exec_list[i].offset; |
| 1141 | if (INTEL_INFO(dev)->gen < 4) |
| 1142 | exec2_list[i].flags = EXEC_OBJECT_NEEDS_FENCE; |
| 1143 | else |
| 1144 | exec2_list[i].flags = 0; |
| 1145 | } |
| 1146 | |
| 1147 | exec2.buffers_ptr = args->buffers_ptr; |
| 1148 | exec2.buffer_count = args->buffer_count; |
| 1149 | exec2.batch_start_offset = args->batch_start_offset; |
| 1150 | exec2.batch_len = args->batch_len; |
| 1151 | exec2.DR1 = args->DR1; |
| 1152 | exec2.DR4 = args->DR4; |
| 1153 | exec2.num_cliprects = args->num_cliprects; |
| 1154 | exec2.cliprects_ptr = args->cliprects_ptr; |
| 1155 | exec2.flags = I915_EXEC_RENDER; |
Ben Widawsky | 6e0a69d | 2012-06-04 14:42:55 -0700 | [diff] [blame] | 1156 | i915_execbuffer2_set_context_id(exec2, 0); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1157 | |
| 1158 | ret = i915_gem_do_execbuffer(dev, data, file, &exec2, exec2_list); |
| 1159 | if (!ret) { |
| 1160 | /* Copy the new buffer offsets back to the user's exec list. */ |
| 1161 | for (i = 0; i < args->buffer_count; i++) |
| 1162 | exec_list[i].offset = exec2_list[i].offset; |
| 1163 | /* ... and back out to userspace */ |
Chris Wilson | ba7a645 | 2012-09-14 11:46:00 +0100 | [diff] [blame] | 1164 | ret = copy_to_user((void __user *)(uintptr_t)args->buffers_ptr, |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1165 | exec_list, |
| 1166 | sizeof(*exec_list) * args->buffer_count); |
| 1167 | if (ret) { |
| 1168 | ret = -EFAULT; |
Daniel Vetter | ff24019 | 2012-01-31 21:08:14 +0100 | [diff] [blame] | 1169 | DRM_DEBUG("failed to copy %d exec entries " |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1170 | "back to user (%d)\n", |
| 1171 | args->buffer_count, ret); |
| 1172 | } |
| 1173 | } |
| 1174 | |
| 1175 | drm_free_large(exec_list); |
| 1176 | drm_free_large(exec2_list); |
| 1177 | return ret; |
| 1178 | } |
| 1179 | |
| 1180 | int |
| 1181 | i915_gem_execbuffer2(struct drm_device *dev, void *data, |
| 1182 | struct drm_file *file) |
| 1183 | { |
| 1184 | struct drm_i915_gem_execbuffer2 *args = data; |
| 1185 | struct drm_i915_gem_exec_object2 *exec2_list = NULL; |
| 1186 | int ret; |
| 1187 | |
Xi Wang | ed8cd3b | 2012-04-23 04:06:41 -0400 | [diff] [blame] | 1188 | if (args->buffer_count < 1 || |
| 1189 | args->buffer_count > UINT_MAX / sizeof(*exec2_list)) { |
Daniel Vetter | ff24019 | 2012-01-31 21:08:14 +0100 | [diff] [blame] | 1190 | DRM_DEBUG("execbuf2 with %d buffers\n", args->buffer_count); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1191 | return -EINVAL; |
| 1192 | } |
| 1193 | |
Chris Wilson | 8408c28 | 2011-02-21 12:54:48 +0000 | [diff] [blame] | 1194 | exec2_list = kmalloc(sizeof(*exec2_list)*args->buffer_count, |
| 1195 | GFP_KERNEL | __GFP_NOWARN | __GFP_NORETRY); |
| 1196 | if (exec2_list == NULL) |
| 1197 | exec2_list = drm_malloc_ab(sizeof(*exec2_list), |
| 1198 | args->buffer_count); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1199 | if (exec2_list == NULL) { |
Daniel Vetter | ff24019 | 2012-01-31 21:08:14 +0100 | [diff] [blame] | 1200 | DRM_DEBUG("Failed to allocate exec list for %d buffers\n", |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1201 | args->buffer_count); |
| 1202 | return -ENOMEM; |
| 1203 | } |
| 1204 | ret = copy_from_user(exec2_list, |
| 1205 | (struct drm_i915_relocation_entry __user *) |
| 1206 | (uintptr_t) args->buffers_ptr, |
| 1207 | sizeof(*exec2_list) * args->buffer_count); |
| 1208 | if (ret != 0) { |
Daniel Vetter | ff24019 | 2012-01-31 21:08:14 +0100 | [diff] [blame] | 1209 | DRM_DEBUG("copy %d exec entries failed %d\n", |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1210 | args->buffer_count, ret); |
| 1211 | drm_free_large(exec2_list); |
| 1212 | return -EFAULT; |
| 1213 | } |
| 1214 | |
| 1215 | ret = i915_gem_do_execbuffer(dev, data, file, args, exec2_list); |
| 1216 | if (!ret) { |
| 1217 | /* Copy the new buffer offsets back to the user's exec list. */ |
Chris Wilson | ba7a645 | 2012-09-14 11:46:00 +0100 | [diff] [blame] | 1218 | ret = copy_to_user((void __user *)(uintptr_t)args->buffers_ptr, |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1219 | exec2_list, |
| 1220 | sizeof(*exec2_list) * args->buffer_count); |
| 1221 | if (ret) { |
| 1222 | ret = -EFAULT; |
Daniel Vetter | ff24019 | 2012-01-31 21:08:14 +0100 | [diff] [blame] | 1223 | DRM_DEBUG("failed to copy %d exec entries " |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1224 | "back to user (%d)\n", |
| 1225 | args->buffer_count, ret); |
| 1226 | } |
| 1227 | } |
| 1228 | |
| 1229 | drm_free_large(exec2_list); |
| 1230 | return ret; |
| 1231 | } |