blob: 9c2477c7b65b1a4a3ba55cff2a310859d30660b3 [file] [log] [blame]
Rob Clarkbb5c2d92012-01-16 12:51:16 -06001/*
Rob Clark8bb0daf2013-02-11 12:43:09 -05002 * drivers/gpu/drm/omapdrm/omap_plane.c
Rob Clarkbb5c2d92012-01-16 12:51:16 -06003 *
4 * Copyright (C) 2011 Texas Instruments
5 * Author: Rob Clark <rob.clark@linaro.org>
6 *
7 * This program is free software; you can redistribute it and/or modify it
8 * under the terms of the GNU General Public License version 2 as published by
9 * the Free Software Foundation.
10 *
11 * This program is distributed in the hope that it will be useful, but WITHOUT
12 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
13 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
14 * more details.
15 *
16 * You should have received a copy of the GNU General Public License along with
17 * this program. If not, see <http://www.gnu.org/licenses/>.
18 */
19
Tomi Valkeinenc423bc82015-06-16 14:54:51 +030020#include <drm/drm_atomic.h>
Laurent Pinchart69a12262015-03-05 21:38:16 +020021#include <drm/drm_atomic_helper.h>
Laurent Pinchartde8e4102015-03-05 13:39:56 +020022#include <drm/drm_plane_helper.h>
Laurent Pinchart69a12262015-03-05 21:38:16 +020023
Rob Clark3c810c62012-08-15 15:18:01 -050024#include "omap_dmm_tiler.h"
Laurent Pinchart2d278f52015-03-05 21:31:37 +020025#include "omap_drv.h"
Rob Clarkbb5c2d92012-01-16 12:51:16 -060026
Rob Clarkbb5c2d92012-01-16 12:51:16 -060027/*
28 * plane funcs
29 */
30
31#define to_omap_plane(x) container_of(x, struct omap_plane, base)
32
33struct omap_plane {
34 struct drm_plane base;
Jyri Sarha694c99c2017-03-24 16:47:54 +020035 enum omap_plane_id id;
Rob Clarkf5f94542012-12-04 13:59:12 -060036 const char *name;
Rob Clarkbb5c2d92012-01-16 12:51:16 -060037
Rob Clarka890e662012-03-05 10:48:31 -060038 uint32_t nformats;
39 uint32_t formats[32];
40};
Rob Clarkbb5c2d92012-01-16 12:51:16 -060041
Laurent Pinchartafc34932015-03-06 18:35:16 +020042struct omap_plane_state {
43 struct drm_plane_state base;
Laurent Pinchartafc34932015-03-06 18:35:16 +020044};
45
46static inline struct omap_plane_state *
47to_omap_plane_state(struct drm_plane_state *state)
Rob Clarkbb5c2d92012-01-16 12:51:16 -060048{
Laurent Pinchartafc34932015-03-06 18:35:16 +020049 return container_of(state, struct omap_plane_state, base);
50}
51
Tomi Valkeinen11ffd032015-05-29 11:05:37 +030052static int omap_plane_prepare_fb(struct drm_plane *plane,
Chris Wilson18320402016-08-18 19:00:16 +010053 struct drm_plane_state *new_state)
Tomi Valkeinen11ffd032015-05-29 11:05:37 +030054{
Maarten Lankhorst844f9112015-09-02 10:42:40 +020055 if (!new_state->fb)
56 return 0;
57
58 return omap_framebuffer_pin(new_state->fb);
Tomi Valkeinen11ffd032015-05-29 11:05:37 +030059}
60
61static void omap_plane_cleanup_fb(struct drm_plane *plane,
Chris Wilson18320402016-08-18 19:00:16 +010062 struct drm_plane_state *old_state)
Tomi Valkeinen11ffd032015-05-29 11:05:37 +030063{
Maarten Lankhorst844f9112015-09-02 10:42:40 +020064 if (old_state->fb)
65 omap_framebuffer_unpin(old_state->fb);
Tomi Valkeinen11ffd032015-05-29 11:05:37 +030066}
67
68static void omap_plane_atomic_update(struct drm_plane *plane,
69 struct drm_plane_state *old_state)
Laurent Pinchartafc34932015-03-06 18:35:16 +020070{
Tomi Valkeinen9f759222015-11-05 18:39:52 +020071 struct omap_drm_private *priv = plane->dev->dev_private;
Laurent Pinchartedc72552015-03-06 19:18:56 +020072 struct omap_plane *omap_plane = to_omap_plane(plane);
73 struct drm_plane_state *state = plane->state;
Laurent Pinchartfb730c92015-03-06 19:00:18 +020074 struct omap_overlay_info info;
75 struct omap_drm_window win;
Rob Clark9a0774e2012-01-16 12:51:17 -060076 int ret;
Rob Clarkbb5c2d92012-01-16 12:51:16 -060077
Laurent Pinchartedc72552015-03-06 19:18:56 +020078 DBG("%s, crtc=%p fb=%p", omap_plane->name, state->crtc, state->fb);
Rob Clarkf5f94542012-12-04 13:59:12 -060079
Laurent Pinchartfb730c92015-03-06 19:00:18 +020080 memset(&info, 0, sizeof(info));
81 info.rotation_type = OMAP_DSS_ROT_DMA;
82 info.rotation = OMAP_DSS_ROT_0;
83 info.global_alpha = 0xff;
84 info.mirror = 0;
Laurent Pinchartba527c12017-05-09 01:27:12 +030085 info.zorder = state->zpos;
Laurent Pinchartfb730c92015-03-06 19:00:18 +020086
87 memset(&win, 0, sizeof(win));
88 win.rotation = state->rotation;
89 win.crtc_x = state->crtc_x;
90 win.crtc_y = state->crtc_y;
91 win.crtc_w = state->crtc_w;
92 win.crtc_h = state->crtc_h;
93
94 /*
95 * src values are in Q16 fixed point, convert to integer.
96 * omap_framebuffer_update_scanout() takes adjusted src.
97 */
98 win.src_x = state->src_x >> 16;
99 win.src_y = state->src_y >> 16;
100
Ville Syrjäläbd2ef252016-09-26 19:30:46 +0300101 if (drm_rotation_90_or_270(state->rotation)) {
Laurent Pinchartfb730c92015-03-06 19:00:18 +0200102 win.src_w = state->src_h >> 16;
103 win.src_h = state->src_w >> 16;
Ville Syrjäläbd2ef252016-09-26 19:30:46 +0300104 } else {
Laurent Pinchartfb730c92015-03-06 19:00:18 +0200105 win.src_w = state->src_w >> 16;
106 win.src_h = state->src_h >> 16;
Laurent Pinchartfb730c92015-03-06 19:00:18 +0200107 }
Laurent Pinchartafc34932015-03-06 18:35:16 +0200108
Rob Clarkf5f94542012-12-04 13:59:12 -0600109 /* update scanout: */
Laurent Pinchartfb730c92015-03-06 19:00:18 +0200110 omap_framebuffer_update_scanout(state->fb, &win, &info);
Rob Clark9a0774e2012-01-16 12:51:17 -0600111
Laurent Pinchartfb730c92015-03-06 19:00:18 +0200112 DBG("%dx%d -> %dx%d (%d)", info.width, info.height,
113 info.out_width, info.out_height,
114 info.screen_width);
115 DBG("%d,%d %pad %pad", info.pos_x, info.pos_y,
116 &info.paddr, &info.p_uv_addr);
Rob Clarkf5f94542012-12-04 13:59:12 -0600117
Tomi Valkeinen9f759222015-11-05 18:39:52 +0200118 priv->dispc_ops->ovl_set_channel_out(omap_plane->id,
Laurent Pinchartafc34932015-03-06 18:35:16 +0200119 omap_crtc_channel(state->crtc));
Tomi Valkeinen2dd38872014-10-03 15:14:08 +0000120
Rob Clarkf5f94542012-12-04 13:59:12 -0600121 /* and finally, update omapdss: */
Tomi Valkeinenbe2d68c2016-08-29 13:15:02 +0300122 ret = priv->dispc_ops->ovl_setup(omap_plane->id, &info,
Laurent Pinchartafc34932015-03-06 18:35:16 +0200123 omap_crtc_timings(state->crtc), false);
Tomi Valkeinencfb73f22016-06-10 12:44:31 +0300124 if (ret) {
125 dev_err(plane->dev->dev, "Failed to setup plane %s\n",
126 omap_plane->name);
Tomi Valkeinen9f759222015-11-05 18:39:52 +0200127 priv->dispc_ops->ovl_enable(omap_plane->id, false);
Tomi Valkeinend9157df2015-05-29 11:03:15 +0300128 return;
Tomi Valkeinen794a65f2015-05-29 11:06:07 +0300129 }
Rob Clarkf5f94542012-12-04 13:59:12 -0600130
Tomi Valkeinen9f759222015-11-05 18:39:52 +0200131 priv->dispc_ops->ovl_enable(omap_plane->id, true);
Laurent Pinchartde8e4102015-03-05 13:39:56 +0200132}
133
Laurent Pinchartde8e4102015-03-05 13:39:56 +0200134static void omap_plane_atomic_disable(struct drm_plane *plane,
135 struct drm_plane_state *old_state)
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600136{
Tomi Valkeinen9f759222015-11-05 18:39:52 +0200137 struct omap_drm_private *priv = plane->dev->dev_private;
Rob Clark3c810c62012-08-15 15:18:01 -0500138 struct omap_plane *omap_plane = to_omap_plane(plane);
Laurent Pinchart2debab92015-01-12 22:38:16 +0200139
Robert Fossc2c446a2017-05-19 16:50:17 -0400140 plane->state->rotation = DRM_MODE_ROTATE_0;
Laurent Pinchartba527c12017-05-09 01:27:12 +0300141 plane->state->zpos = plane->type == DRM_PLANE_TYPE_PRIMARY
Laurent Pinchartafc34932015-03-06 18:35:16 +0200142 ? 0 : omap_plane->id;
Laurent Pinchart82e588552015-01-12 23:56:57 +0200143
Tomi Valkeinen9f759222015-11-05 18:39:52 +0200144 priv->dispc_ops->ovl_enable(omap_plane->id, false);
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600145}
146
Tomi Valkeinenc423bc82015-06-16 14:54:51 +0300147static int omap_plane_atomic_check(struct drm_plane *plane,
148 struct drm_plane_state *state)
149{
150 struct drm_crtc_state *crtc_state;
151
Tomi Valkeinen70dd2a62016-06-10 12:50:53 +0300152 if (!state->fb)
Tomi Valkeinenc423bc82015-06-16 14:54:51 +0300153 return 0;
154
Tomi Valkeinen70dd2a62016-06-10 12:50:53 +0300155 /* crtc should only be NULL when disabling (i.e., !state->fb) */
156 if (WARN_ON(!state->crtc))
157 return 0;
158
159 crtc_state = drm_atomic_get_existing_crtc_state(state->state, state->crtc);
160 /* we should have a crtc state if the plane is attached to a crtc */
161 if (WARN_ON(!crtc_state))
162 return 0;
Tomi Valkeinenc423bc82015-06-16 14:54:51 +0300163
Tomi Valkeinenaaf76422016-06-10 12:50:39 +0300164 if (!crtc_state->enable)
165 return 0;
166
Tomi Valkeinenc423bc82015-06-16 14:54:51 +0300167 if (state->crtc_x < 0 || state->crtc_y < 0)
168 return -EINVAL;
169
170 if (state->crtc_x + state->crtc_w > crtc_state->adjusted_mode.hdisplay)
171 return -EINVAL;
172
173 if (state->crtc_y + state->crtc_h > crtc_state->adjusted_mode.vdisplay)
174 return -EINVAL;
175
Robert Fossc2c446a2017-05-19 16:50:17 -0400176 if (state->rotation != DRM_MODE_ROTATE_0 &&
Tomi Valkeinen70dd2a62016-06-10 12:50:53 +0300177 !omap_framebuffer_supports_rotation(state->fb))
178 return -EINVAL;
Tomi Valkeinenbfeece52015-08-27 13:09:22 +0300179
Tomi Valkeinenc423bc82015-06-16 14:54:51 +0300180 return 0;
181}
182
Laurent Pinchartde8e4102015-03-05 13:39:56 +0200183static const struct drm_plane_helper_funcs omap_plane_helper_funcs = {
184 .prepare_fb = omap_plane_prepare_fb,
185 .cleanup_fb = omap_plane_cleanup_fb,
Tomi Valkeinenc423bc82015-06-16 14:54:51 +0300186 .atomic_check = omap_plane_atomic_check,
Laurent Pinchartde8e4102015-03-05 13:39:56 +0200187 .atomic_update = omap_plane_atomic_update,
188 .atomic_disable = omap_plane_atomic_disable,
189};
190
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600191static void omap_plane_destroy(struct drm_plane *plane)
192{
193 struct omap_plane *omap_plane = to_omap_plane(plane);
Rob Clarkf5f94542012-12-04 13:59:12 -0600194
195 DBG("%s", omap_plane->name);
196
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600197 drm_plane_cleanup(plane);
Rob Clarkf5f94542012-12-04 13:59:12 -0600198
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600199 kfree(omap_plane);
200}
201
Rob Clark3c810c62012-08-15 15:18:01 -0500202/* helper to install properties which are common to planes and crtcs */
203void omap_plane_install_properties(struct drm_plane *plane,
204 struct drm_mode_object *obj)
205{
206 struct drm_device *dev = plane->dev;
207 struct omap_drm_private *priv = dev->dev_private;
Rob Clark3c810c62012-08-15 15:18:01 -0500208
Rob Clarkc2a6a552012-10-25 17:14:13 -0500209 if (priv->has_dmm) {
Ville Syrjälä0da88db2016-09-26 19:30:52 +0300210 if (!plane->rotation_property)
211 drm_plane_create_rotation_property(plane,
Robert Fossc2c446a2017-05-19 16:50:17 -0400212 DRM_MODE_ROTATE_0,
213 DRM_MODE_ROTATE_0 | DRM_MODE_ROTATE_90 |
214 DRM_MODE_ROTATE_180 | DRM_MODE_ROTATE_270 |
215 DRM_MODE_REFLECT_X | DRM_MODE_REFLECT_Y);
Laurent Pincharte2cd09b2015-03-06 17:16:43 +0200216
Ville Syrjälä0da88db2016-09-26 19:30:52 +0300217 /* Attach the rotation property also to the crtc object */
218 if (plane->rotation_property && obj != &plane->base)
219 drm_object_attach_property(obj, plane->rotation_property,
Robert Fossc2c446a2017-05-19 16:50:17 -0400220 DRM_MODE_ROTATE_0);
Rob Clark3c810c62012-08-15 15:18:01 -0500221 }
Andre Renaud8451b5a2012-08-15 15:18:02 -0500222
Laurent Pincharte2cd09b2015-03-06 17:16:43 +0200223 drm_object_attach_property(obj, priv->zorder_prop, 0);
Rob Clark3c810c62012-08-15 15:18:01 -0500224}
225
Laurent Pinchartafc34932015-03-06 18:35:16 +0200226static struct drm_plane_state *
227omap_plane_atomic_duplicate_state(struct drm_plane *plane)
Rob Clark3c810c62012-08-15 15:18:01 -0500228{
Laurent Pinchartafc34932015-03-06 18:35:16 +0200229 struct omap_plane_state *state;
230 struct omap_plane_state *copy;
231
232 if (WARN_ON(!plane->state))
233 return NULL;
234
235 state = to_omap_plane_state(plane->state);
236 copy = kmemdup(state, sizeof(*state), GFP_KERNEL);
237 if (copy == NULL)
238 return NULL;
239
240 __drm_atomic_helper_plane_duplicate_state(plane, &copy->base);
241
242 return &copy->base;
243}
244
245static void omap_plane_atomic_destroy_state(struct drm_plane *plane,
246 struct drm_plane_state *state)
247{
Daniel Vetter2f701692016-05-09 16:34:10 +0200248 __drm_atomic_helper_plane_destroy_state(state);
Laurent Pinchartafc34932015-03-06 18:35:16 +0200249 kfree(to_omap_plane_state(state));
250}
251
Tomi Valkeinene07323c2015-12-15 11:33:23 +0200252static void omap_plane_reset(struct drm_plane *plane)
253{
254 struct omap_plane *omap_plane = to_omap_plane(plane);
255 struct omap_plane_state *omap_state;
256
Laurent Pinchartf8ef29e2015-12-14 22:39:29 +0200257 if (plane->state) {
258 omap_plane_atomic_destroy_state(plane, plane->state);
259 plane->state = NULL;
260 }
Tomi Valkeinene07323c2015-12-15 11:33:23 +0200261
262 omap_state = kzalloc(sizeof(*omap_state), GFP_KERNEL);
263 if (omap_state == NULL)
264 return;
265
266 /*
Laurent Pinchartba527c12017-05-09 01:27:12 +0300267 * Set the zpos default depending on whether we are a primary or overlay
Tomi Valkeinene07323c2015-12-15 11:33:23 +0200268 * plane.
269 */
Laurent Pinchartba527c12017-05-09 01:27:12 +0300270 omap_state->base.zpos = plane->type == DRM_PLANE_TYPE_PRIMARY
271 ? 0 : omap_plane->id;
Robert Fossc2c446a2017-05-19 16:50:17 -0400272 omap_state->base.rotation = DRM_MODE_ROTATE_0;
Tomi Valkeinene07323c2015-12-15 11:33:23 +0200273
274 plane->state = &omap_state->base;
275 plane->state->plane = plane;
276}
277
Laurent Pinchartafc34932015-03-06 18:35:16 +0200278static int omap_plane_atomic_set_property(struct drm_plane *plane,
279 struct drm_plane_state *state,
280 struct drm_property *property,
281 uint64_t val)
282{
Rob Clark3c810c62012-08-15 15:18:01 -0500283 struct omap_drm_private *priv = plane->dev->dev_private;
Rob Clark3c810c62012-08-15 15:18:01 -0500284
Laurent Pinchartafc34932015-03-06 18:35:16 +0200285 if (property == priv->zorder_prop)
Laurent Pinchartba527c12017-05-09 01:27:12 +0300286 state->zpos = val;
Laurent Pinchartafc34932015-03-06 18:35:16 +0200287 else
Laurent Pincharta42133a2015-01-17 19:09:26 +0200288 return -EINVAL;
Rob Clark3c810c62012-08-15 15:18:01 -0500289
Laurent Pinchartafc34932015-03-06 18:35:16 +0200290 return 0;
291}
Laurent Pincharta42133a2015-01-17 19:09:26 +0200292
Laurent Pinchartafc34932015-03-06 18:35:16 +0200293static int omap_plane_atomic_get_property(struct drm_plane *plane,
294 const struct drm_plane_state *state,
295 struct drm_property *property,
296 uint64_t *val)
297{
298 struct omap_drm_private *priv = plane->dev->dev_private;
Laurent Pincharta42133a2015-01-17 19:09:26 +0200299
Laurent Pinchartafc34932015-03-06 18:35:16 +0200300 if (property == priv->zorder_prop)
Laurent Pinchartba527c12017-05-09 01:27:12 +0300301 *val = state->zpos;
Laurent Pinchartafc34932015-03-06 18:35:16 +0200302 else
303 return -EINVAL;
304
305 return 0;
Rob Clark3c810c62012-08-15 15:18:01 -0500306}
307
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600308static const struct drm_plane_funcs omap_plane_funcs = {
Laurent Pinchartcef77d42015-03-05 21:50:00 +0200309 .update_plane = drm_atomic_helper_update_plane,
310 .disable_plane = drm_atomic_helper_disable_plane,
Laurent Pinchartafc34932015-03-06 18:35:16 +0200311 .reset = omap_plane_reset,
Laurent Pinchart222025e2015-01-11 00:02:07 +0200312 .destroy = omap_plane_destroy,
Laurent Pinchartafc34932015-03-06 18:35:16 +0200313 .set_property = drm_atomic_helper_plane_set_property,
314 .atomic_duplicate_state = omap_plane_atomic_duplicate_state,
315 .atomic_destroy_state = omap_plane_atomic_destroy_state,
316 .atomic_set_property = omap_plane_atomic_set_property,
317 .atomic_get_property = omap_plane_atomic_get_property,
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600318};
319
Jyri Sarhae8e13b12017-03-24 16:47:55 +0200320static const char *plane_id_to_name[] = {
Laurent Pinchart222025e2015-01-11 00:02:07 +0200321 [OMAP_DSS_GFX] = "gfx",
322 [OMAP_DSS_VIDEO1] = "vid1",
323 [OMAP_DSS_VIDEO2] = "vid2",
324 [OMAP_DSS_VIDEO3] = "vid3",
Rob Clarkf5f94542012-12-04 13:59:12 -0600325};
326
Jyri Sarhae8e13b12017-03-24 16:47:55 +0200327static const enum omap_plane_id plane_idx_to_id[] = {
328 OMAP_DSS_GFX,
329 OMAP_DSS_VIDEO1,
330 OMAP_DSS_VIDEO2,
331 OMAP_DSS_VIDEO3,
332};
333
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600334/* initialize plane */
335struct drm_plane *omap_plane_init(struct drm_device *dev,
Jyri Sarhae8e13b12017-03-24 16:47:55 +0200336 int idx, enum drm_plane_type type,
Tomi Valkeinene43f2c32016-12-02 16:07:11 +0200337 u32 possible_crtcs)
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600338{
Tomi Valkeinen9f759222015-11-05 18:39:52 +0200339 struct omap_drm_private *priv = dev->dev_private;
Laurent Pinchartef6b0e02015-01-11 00:11:18 +0200340 struct drm_plane *plane;
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600341 struct omap_plane *omap_plane;
Jyri Sarhae8e13b12017-03-24 16:47:55 +0200342 enum omap_plane_id id;
Laurent Pinchartef6b0e02015-01-11 00:11:18 +0200343 int ret;
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600344
Jyri Sarhae8e13b12017-03-24 16:47:55 +0200345 if (WARN_ON(idx >= ARRAY_SIZE(plane_idx_to_id)))
346 return ERR_PTR(-EINVAL);
347
348 id = plane_idx_to_id[idx];
349
350 DBG("%s: type=%d", plane_id_to_name[id], type);
Rob Clarkb33f34d2012-03-05 10:48:35 -0600351
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600352 omap_plane = kzalloc(sizeof(*omap_plane), GFP_KERNEL);
Joe Perches78110bb2013-02-11 09:41:29 -0800353 if (!omap_plane)
Laurent Pinchartfb9a35f2015-01-11 16:30:44 +0200354 return ERR_PTR(-ENOMEM);
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600355
Rob Clarka890e662012-03-05 10:48:31 -0600356 omap_plane->nformats = omap_framebuffer_get_formats(
357 omap_plane->formats, ARRAY_SIZE(omap_plane->formats),
Tomi Valkeinen9f759222015-11-05 18:39:52 +0200358 priv->dispc_ops->ovl_get_color_modes(id));
Rob Clarkf5f94542012-12-04 13:59:12 -0600359 omap_plane->id = id;
Jyri Sarhae8e13b12017-03-24 16:47:55 +0200360 omap_plane->name = plane_id_to_name[id];
Rob Clarkf5f94542012-12-04 13:59:12 -0600361
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600362 plane = &omap_plane->base;
363
Tomi Valkeinene43f2c32016-12-02 16:07:11 +0200364 ret = drm_universal_plane_init(dev, plane, possible_crtcs,
Laurent Pinchartef6b0e02015-01-11 00:11:18 +0200365 &omap_plane_funcs, omap_plane->formats,
Ville Syrjäläb0b3b792015-12-09 16:19:55 +0200366 omap_plane->nformats, type, NULL);
Laurent Pinchartef6b0e02015-01-11 00:11:18 +0200367 if (ret < 0)
368 goto error;
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600369
Laurent Pinchartde8e4102015-03-05 13:39:56 +0200370 drm_plane_helper_add(plane, &omap_plane_helper_funcs);
371
Rob Clark3c810c62012-08-15 15:18:01 -0500372 omap_plane_install_properties(plane, &plane->base);
373
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600374 return plane;
Laurent Pinchartef6b0e02015-01-11 00:11:18 +0200375
376error:
Jyri Sarhae8e13b12017-03-24 16:47:55 +0200377 dev_err(dev->dev, "%s(): could not create plane: %s\n",
378 __func__, plane_id_to_name[id]);
379
Laurent Pinchartef6b0e02015-01-11 00:11:18 +0200380 kfree(omap_plane);
381 return NULL;
Rob Clarkbb5c2d92012-01-16 12:51:16 -0600382}