blob: 90b7d7f3c81b08d6a0e0eec96a0ec44ff8fa4cb5 [file] [log] [blame]
Richard Zhaod142d6b2012-09-12 14:58:05 +03001/*
2 * Copyright 2012 Freescale Semiconductor, Inc.
3 *
4 * The code contained herein is licensed under the GNU General Public
5 * License. You may obtain a copy of the GNU General Public License
6 * Version 2 or later at the following locations:
7 *
8 * http://www.opensource.org/licenses/gpl-license.html
9 * http://www.gnu.org/copyleft/gpl.html
10 */
11
12#include <linux/module.h>
13#include <linux/of_platform.h>
Richard Zhaod142d6b2012-09-12 14:58:05 +030014#include <linux/err.h>
15#include <linux/io.h>
Michael Grzeschika0685332013-03-30 12:54:01 +020016#include <linux/delay.h>
Richard Zhaod142d6b2012-09-12 14:58:05 +030017
Alexander Shishkin8e229782013-06-24 14:46:36 +030018#include "ci_hdrc_imx.h"
Richard Zhaod142d6b2012-09-12 14:58:05 +030019
Michael Grzeschika0685332013-03-30 12:54:01 +020020#define MX25_USB_PHY_CTRL_OFFSET 0x08
21#define MX25_BM_EXTERNAL_VBUS_DIVIDER BIT(23)
22
Denis Carikli72ee92d2014-04-23 15:56:36 +080023#define MX25_EHCI_INTERFACE_SINGLE_UNI (2 << 0)
24#define MX25_EHCI_INTERFACE_DIFF_UNI (0 << 0)
25#define MX25_EHCI_INTERFACE_MASK (0xf)
26
27#define MX25_OTG_SIC_SHIFT 29
28#define MX25_OTG_SIC_MASK (0x3 << MX25_OTG_SIC_SHIFT)
29#define MX25_OTG_PM_BIT BIT(24)
30#define MX25_OTG_PP_BIT BIT(11)
31#define MX25_OTG_OCPOL_BIT BIT(3)
32
33#define MX25_H1_SIC_SHIFT 21
34#define MX25_H1_SIC_MASK (0x3 << MX25_H1_SIC_SHIFT)
35#define MX25_H1_PP_BIT BIT(18)
36#define MX25_H1_PM_BIT BIT(16)
37#define MX25_H1_IPPUE_UP_BIT BIT(7)
38#define MX25_H1_IPPUE_DOWN_BIT BIT(6)
39#define MX25_H1_TLL_BIT BIT(5)
40#define MX25_H1_USBTE_BIT BIT(4)
41#define MX25_H1_OCPOL_BIT BIT(2)
42
Alexander Shiyan9f90e112013-12-06 16:35:14 +080043#define MX27_H1_PM_BIT BIT(8)
44#define MX27_H2_PM_BIT BIT(16)
45#define MX27_OTG_PM_BIT BIT(24)
46
Michael Grzeschikf0c910b2013-03-30 12:54:00 +020047#define MX53_USB_OTG_PHY_CTRL_0_OFFSET 0x08
Fabio Estevam33f92a82014-05-04 09:24:39 +080048#define MX53_USB_OTG_PHY_CTRL_1_OFFSET 0x0c
Michael Grzeschikf0c910b2013-03-30 12:54:00 +020049#define MX53_USB_UH2_CTRL_OFFSET 0x14
50#define MX53_USB_UH3_CTRL_OFFSET 0x18
51#define MX53_BM_OVER_CUR_DIS_H1 BIT(5)
52#define MX53_BM_OVER_CUR_DIS_OTG BIT(8)
53#define MX53_BM_OVER_CUR_DIS_UHx BIT(30)
Fabio Estevam33f92a82014-05-04 09:24:39 +080054#define MX53_USB_PHYCTRL1_PLLDIV_MASK 0x3
55#define MX53_USB_PLL_DIV_24_MHZ 0x01
Michael Grzeschikf0c910b2013-03-30 12:54:00 +020056
Marc Kleine-Buddee6091082013-03-30 12:53:59 +020057#define MX6_BM_OVER_CUR_DIS BIT(7)
Peter Chenf636cec2015-02-11 12:44:46 +080058#define MX6_BM_WAKEUP_ENABLE BIT(10)
59#define MX6_BM_ID_WAKEUP BIT(16)
60#define MX6_BM_VBUS_WAKEUP BIT(17)
61#define MX6_BM_WAKEUP_INTR BIT(31)
Richard Zhaod142d6b2012-09-12 14:58:05 +030062
Stefan Agnerf40017e2014-09-22 08:14:15 +080063#define VF610_OVER_CUR_DIS BIT(7)
64
Sascha Hauer05986ba2013-08-14 12:44:16 +030065struct usbmisc_ops {
66 /* It's called once when probe a usb device */
67 int (*init)(struct imx_usbmisc_data *data);
68 /* It's called once after adding a usb device */
69 int (*post)(struct imx_usbmisc_data *data);
Peter Chenf636cec2015-02-11 12:44:46 +080070 /* It's called when we need to enable/disable usb wakeup */
71 int (*set_wakeup)(struct imx_usbmisc_data *data, bool enabled);
Sascha Hauer05986ba2013-08-14 12:44:16 +030072};
73
Michael Grzeschika7bc2fd2013-03-30 12:53:56 +020074struct imx_usbmisc {
Richard Zhaod142d6b2012-09-12 14:58:05 +030075 void __iomem *base;
76 spinlock_t lock;
Marc Kleine-Buddee6091082013-03-30 12:53:59 +020077 const struct usbmisc_ops *ops;
Richard Zhaod142d6b2012-09-12 14:58:05 +030078};
79
Denis Carikli72ee92d2014-04-23 15:56:36 +080080static int usbmisc_imx25_init(struct imx_usbmisc_data *data)
81{
Stefan Agnerf40017e2014-09-22 08:14:15 +080082 struct imx_usbmisc *usbmisc = dev_get_drvdata(data->dev);
Denis Carikli72ee92d2014-04-23 15:56:36 +080083 unsigned long flags;
84 u32 val = 0;
85
86 if (data->index > 1)
87 return -EINVAL;
88
89 spin_lock_irqsave(&usbmisc->lock, flags);
90 switch (data->index) {
91 case 0:
92 val = readl(usbmisc->base);
93 val &= ~(MX25_OTG_SIC_MASK | MX25_OTG_PP_BIT);
94 val |= (MX25_EHCI_INTERFACE_DIFF_UNI & MX25_EHCI_INTERFACE_MASK) << MX25_OTG_SIC_SHIFT;
95 val |= (MX25_OTG_PM_BIT | MX25_OTG_OCPOL_BIT);
96 writel(val, usbmisc->base);
97 break;
98 case 1:
99 val = readl(usbmisc->base);
100 val &= ~(MX25_H1_SIC_MASK | MX25_H1_PP_BIT | MX25_H1_IPPUE_UP_BIT);
101 val |= (MX25_EHCI_INTERFACE_SINGLE_UNI & MX25_EHCI_INTERFACE_MASK) << MX25_H1_SIC_SHIFT;
102 val |= (MX25_H1_PM_BIT | MX25_H1_OCPOL_BIT | MX25_H1_TLL_BIT |
103 MX25_H1_USBTE_BIT | MX25_H1_IPPUE_DOWN_BIT);
104
105 writel(val, usbmisc->base);
106
107 break;
108 }
109 spin_unlock_irqrestore(&usbmisc->lock, flags);
110
111 return 0;
112}
113
Sascha Hauer05986ba2013-08-14 12:44:16 +0300114static int usbmisc_imx25_post(struct imx_usbmisc_data *data)
Richard Zhaod142d6b2012-09-12 14:58:05 +0300115{
Stefan Agnerf40017e2014-09-22 08:14:15 +0800116 struct imx_usbmisc *usbmisc = dev_get_drvdata(data->dev);
Michael Grzeschika0685332013-03-30 12:54:01 +0200117 void __iomem *reg;
118 unsigned long flags;
119 u32 val;
120
Sascha Hauer05986ba2013-08-14 12:44:16 +0300121 if (data->index > 2)
122 return -EINVAL;
Michael Grzeschika0685332013-03-30 12:54:01 +0200123
Sascha Hauer05986ba2013-08-14 12:44:16 +0300124 if (data->evdo) {
Michael Grzeschika0685332013-03-30 12:54:01 +0200125 spin_lock_irqsave(&usbmisc->lock, flags);
Fabio Estevam8d1dc4d2014-11-26 13:44:25 +0800126 reg = usbmisc->base + MX25_USB_PHY_CTRL_OFFSET;
Michael Grzeschika0685332013-03-30 12:54:01 +0200127 val = readl(reg);
128 writel(val | MX25_BM_EXTERNAL_VBUS_DIVIDER, reg);
129 spin_unlock_irqrestore(&usbmisc->lock, flags);
130 usleep_range(5000, 10000); /* needed to stabilize voltage */
131 }
132
133 return 0;
134}
135
Alexander Shiyan9f90e112013-12-06 16:35:14 +0800136static int usbmisc_imx27_init(struct imx_usbmisc_data *data)
137{
Stefan Agnerf40017e2014-09-22 08:14:15 +0800138 struct imx_usbmisc *usbmisc = dev_get_drvdata(data->dev);
Alexander Shiyan9f90e112013-12-06 16:35:14 +0800139 unsigned long flags;
140 u32 val;
141
142 switch (data->index) {
143 case 0:
144 val = MX27_OTG_PM_BIT;
145 break;
146 case 1:
147 val = MX27_H1_PM_BIT;
148 break;
149 case 2:
150 val = MX27_H2_PM_BIT;
151 break;
152 default:
153 return -EINVAL;
154 };
155
156 spin_lock_irqsave(&usbmisc->lock, flags);
157 if (data->disable_oc)
158 val = readl(usbmisc->base) | val;
159 else
160 val = readl(usbmisc->base) & ~val;
161 writel(val, usbmisc->base);
162 spin_unlock_irqrestore(&usbmisc->lock, flags);
163
164 return 0;
165}
166
Sascha Hauer05986ba2013-08-14 12:44:16 +0300167static int usbmisc_imx53_init(struct imx_usbmisc_data *data)
Michael Grzeschikf0c910b2013-03-30 12:54:00 +0200168{
Stefan Agnerf40017e2014-09-22 08:14:15 +0800169 struct imx_usbmisc *usbmisc = dev_get_drvdata(data->dev);
Michael Grzeschikf0c910b2013-03-30 12:54:00 +0200170 void __iomem *reg = NULL;
171 unsigned long flags;
172 u32 val = 0;
173
Sascha Hauer05986ba2013-08-14 12:44:16 +0300174 if (data->index > 3)
175 return -EINVAL;
Michael Grzeschikf0c910b2013-03-30 12:54:00 +0200176
Fabio Estevam33f92a82014-05-04 09:24:39 +0800177 /* Select a 24 MHz reference clock for the PHY */
Fabio Estevam4a1d6cf2014-11-26 13:44:26 +0800178 val = readl(usbmisc->base + MX53_USB_OTG_PHY_CTRL_1_OFFSET);
Fabio Estevam33f92a82014-05-04 09:24:39 +0800179 val &= ~MX53_USB_PHYCTRL1_PLLDIV_MASK;
180 val |= MX53_USB_PLL_DIV_24_MHZ;
181 writel(val, usbmisc->base + MX53_USB_OTG_PHY_CTRL_1_OFFSET);
182
Sascha Hauer05986ba2013-08-14 12:44:16 +0300183 if (data->disable_oc) {
Michael Grzeschikf0c910b2013-03-30 12:54:00 +0200184 spin_lock_irqsave(&usbmisc->lock, flags);
Sascha Hauer05986ba2013-08-14 12:44:16 +0300185 switch (data->index) {
Michael Grzeschikf0c910b2013-03-30 12:54:00 +0200186 case 0:
187 reg = usbmisc->base + MX53_USB_OTG_PHY_CTRL_0_OFFSET;
188 val = readl(reg) | MX53_BM_OVER_CUR_DIS_OTG;
189 break;
190 case 1:
191 reg = usbmisc->base + MX53_USB_OTG_PHY_CTRL_0_OFFSET;
192 val = readl(reg) | MX53_BM_OVER_CUR_DIS_H1;
193 break;
194 case 2:
195 reg = usbmisc->base + MX53_USB_UH2_CTRL_OFFSET;
196 val = readl(reg) | MX53_BM_OVER_CUR_DIS_UHx;
197 break;
198 case 3:
199 reg = usbmisc->base + MX53_USB_UH3_CTRL_OFFSET;
200 val = readl(reg) | MX53_BM_OVER_CUR_DIS_UHx;
201 break;
202 }
203 if (reg && val)
204 writel(val, reg);
205 spin_unlock_irqrestore(&usbmisc->lock, flags);
206 }
207
208 return 0;
209}
210
Peter Chenf636cec2015-02-11 12:44:46 +0800211static int usbmisc_imx6q_set_wakeup
212 (struct imx_usbmisc_data *data, bool enabled)
213{
214 struct imx_usbmisc *usbmisc = dev_get_drvdata(data->dev);
215 unsigned long flags;
216 u32 val;
217 u32 wakeup_setting = (MX6_BM_WAKEUP_ENABLE |
218 MX6_BM_VBUS_WAKEUP | MX6_BM_ID_WAKEUP);
219 int ret = 0;
220
221 if (data->index > 3)
222 return -EINVAL;
223
224 spin_lock_irqsave(&usbmisc->lock, flags);
225 val = readl(usbmisc->base + data->index * 4);
226 if (enabled) {
227 val |= wakeup_setting;
228 writel(val, usbmisc->base + data->index * 4);
229 } else {
230 if (val & MX6_BM_WAKEUP_INTR)
231 pr_debug("wakeup int at ci_hdrc.%d\n", data->index);
232 val &= ~wakeup_setting;
233 writel(val, usbmisc->base + data->index * 4);
234 }
235 spin_unlock_irqrestore(&usbmisc->lock, flags);
236
237 return ret;
238}
239
Sascha Hauer05986ba2013-08-14 12:44:16 +0300240static int usbmisc_imx6q_init(struct imx_usbmisc_data *data)
Richard Zhaod142d6b2012-09-12 14:58:05 +0300241{
Stefan Agnerf40017e2014-09-22 08:14:15 +0800242 struct imx_usbmisc *usbmisc = dev_get_drvdata(data->dev);
Richard Zhaod142d6b2012-09-12 14:58:05 +0300243 unsigned long flags;
244 u32 reg;
245
Sascha Hauer05986ba2013-08-14 12:44:16 +0300246 if (data->index > 3)
247 return -EINVAL;
Richard Zhaod142d6b2012-09-12 14:58:05 +0300248
Sascha Hauer05986ba2013-08-14 12:44:16 +0300249 if (data->disable_oc) {
Richard Zhaod142d6b2012-09-12 14:58:05 +0300250 spin_lock_irqsave(&usbmisc->lock, flags);
Sascha Hauer05986ba2013-08-14 12:44:16 +0300251 reg = readl(usbmisc->base + data->index * 4);
Marc Kleine-Buddee6091082013-03-30 12:53:59 +0200252 writel(reg | MX6_BM_OVER_CUR_DIS,
Sascha Hauer05986ba2013-08-14 12:44:16 +0300253 usbmisc->base + data->index * 4);
Richard Zhaod142d6b2012-09-12 14:58:05 +0300254 spin_unlock_irqrestore(&usbmisc->lock, flags);
255 }
256
Peter Chenf636cec2015-02-11 12:44:46 +0800257 usbmisc_imx6q_set_wakeup(data, false);
258
Richard Zhaod142d6b2012-09-12 14:58:05 +0300259 return 0;
260}
261
Stefan Agnerf40017e2014-09-22 08:14:15 +0800262static int usbmisc_vf610_init(struct imx_usbmisc_data *data)
263{
264 struct imx_usbmisc *usbmisc = dev_get_drvdata(data->dev);
265 u32 reg;
266
267 /*
268 * Vybrid only has one misc register set, but in two different
269 * areas. These is reflected in two instances of this driver.
270 */
271 if (data->index >= 1)
272 return -EINVAL;
273
274 if (data->disable_oc) {
275 reg = readl(usbmisc->base);
276 writel(reg | VF610_OVER_CUR_DIS, usbmisc->base);
277 }
278
279 return 0;
280}
281
Michael Grzeschika0685332013-03-30 12:54:01 +0200282static const struct usbmisc_ops imx25_usbmisc_ops = {
Denis Carikli72ee92d2014-04-23 15:56:36 +0800283 .init = usbmisc_imx25_init,
Michael Grzeschika0685332013-03-30 12:54:01 +0200284 .post = usbmisc_imx25_post,
285};
286
Alexander Shiyan9f90e112013-12-06 16:35:14 +0800287static const struct usbmisc_ops imx27_usbmisc_ops = {
288 .init = usbmisc_imx27_init,
289};
290
Michael Grzeschikf0c910b2013-03-30 12:54:00 +0200291static const struct usbmisc_ops imx53_usbmisc_ops = {
292 .init = usbmisc_imx53_init,
293};
294
Richard Zhaod142d6b2012-09-12 14:58:05 +0300295static const struct usbmisc_ops imx6q_usbmisc_ops = {
Peter Chenf636cec2015-02-11 12:44:46 +0800296 .set_wakeup = usbmisc_imx6q_set_wakeup,
Richard Zhaod142d6b2012-09-12 14:58:05 +0300297 .init = usbmisc_imx6q_init,
298};
299
Stefan Agnerf40017e2014-09-22 08:14:15 +0800300static const struct usbmisc_ops vf610_usbmisc_ops = {
301 .init = usbmisc_vf610_init,
302};
303
Sascha Hauer05986ba2013-08-14 12:44:16 +0300304int imx_usbmisc_init(struct imx_usbmisc_data *data)
305{
Peter Chena4cf1b12015-02-11 12:44:44 +0800306 struct imx_usbmisc *usbmisc;
Stefan Agnerf40017e2014-09-22 08:14:15 +0800307
Peter Chena4cf1b12015-02-11 12:44:44 +0800308 if (!data)
309 return 0;
310
311 usbmisc = dev_get_drvdata(data->dev);
Sascha Hauer05986ba2013-08-14 12:44:16 +0300312 if (!usbmisc->ops->init)
313 return 0;
314 return usbmisc->ops->init(data);
315}
316EXPORT_SYMBOL_GPL(imx_usbmisc_init);
317
318int imx_usbmisc_init_post(struct imx_usbmisc_data *data)
319{
Peter Chena4cf1b12015-02-11 12:44:44 +0800320 struct imx_usbmisc *usbmisc;
Stefan Agnerf40017e2014-09-22 08:14:15 +0800321
Peter Chena4cf1b12015-02-11 12:44:44 +0800322 if (!data)
323 return 0;
324
325 usbmisc = dev_get_drvdata(data->dev);
Sascha Hauer05986ba2013-08-14 12:44:16 +0300326 if (!usbmisc->ops->post)
327 return 0;
328 return usbmisc->ops->post(data);
329}
330EXPORT_SYMBOL_GPL(imx_usbmisc_init_post);
331
Peter Chenf636cec2015-02-11 12:44:46 +0800332int imx_usbmisc_set_wakeup(struct imx_usbmisc_data *data, bool enabled)
333{
334 struct imx_usbmisc *usbmisc;
335
336 if (!data)
337 return 0;
338
339 usbmisc = dev_get_drvdata(data->dev);
340 if (!usbmisc->ops->set_wakeup)
341 return 0;
342 return usbmisc->ops->set_wakeup(data, enabled);
343}
344EXPORT_SYMBOL_GPL(imx_usbmisc_set_wakeup);
345
Michael Grzeschika7bc2fd2013-03-30 12:53:56 +0200346static const struct of_device_id usbmisc_imx_dt_ids[] = {
Marc Kleine-Buddee6091082013-03-30 12:53:59 +0200347 {
Michael Grzeschika0685332013-03-30 12:54:01 +0200348 .compatible = "fsl,imx25-usbmisc",
349 .data = &imx25_usbmisc_ops,
350 },
351 {
Denis Carikli72ee92d2014-04-23 15:56:36 +0800352 .compatible = "fsl,imx35-usbmisc",
353 .data = &imx25_usbmisc_ops,
354 },
355 {
Alexander Shiyan9f90e112013-12-06 16:35:14 +0800356 .compatible = "fsl,imx27-usbmisc",
357 .data = &imx27_usbmisc_ops,
358 },
359 {
Alexander Shiyanc4962e02013-12-06 16:35:15 +0800360 .compatible = "fsl,imx51-usbmisc",
361 .data = &imx53_usbmisc_ops,
362 },
363 {
Michael Grzeschikf0c910b2013-03-30 12:54:00 +0200364 .compatible = "fsl,imx53-usbmisc",
365 .data = &imx53_usbmisc_ops,
366 },
367 {
Marc Kleine-Buddee6091082013-03-30 12:53:59 +0200368 .compatible = "fsl,imx6q-usbmisc",
369 .data = &imx6q_usbmisc_ops,
370 },
Stefan Agnerf40017e2014-09-22 08:14:15 +0800371 {
372 .compatible = "fsl,vf610-usbmisc",
373 .data = &vf610_usbmisc_ops,
374 },
Richard Zhaod142d6b2012-09-12 14:58:05 +0300375 { /* sentinel */ }
376};
Arnaud Patard (Rtp)269b83d2013-06-20 23:33:25 +0200377MODULE_DEVICE_TABLE(of, usbmisc_imx_dt_ids);
Richard Zhaod142d6b2012-09-12 14:58:05 +0300378
Michael Grzeschika7bc2fd2013-03-30 12:53:56 +0200379static int usbmisc_imx_probe(struct platform_device *pdev)
Richard Zhaod142d6b2012-09-12 14:58:05 +0300380{
381 struct resource *res;
Michael Grzeschika7bc2fd2013-03-30 12:53:56 +0200382 struct imx_usbmisc *data;
Marc Kleine-Buddee6091082013-03-30 12:53:59 +0200383 struct of_device_id *tmp_dev;
Richard Zhaod142d6b2012-09-12 14:58:05 +0300384
Richard Zhaod142d6b2012-09-12 14:58:05 +0300385 data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
386 if (!data)
387 return -ENOMEM;
388
389 spin_lock_init(&data->lock);
390
391 res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
Thierry Reding148e1132013-01-21 11:09:22 +0100392 data->base = devm_ioremap_resource(&pdev->dev, res);
393 if (IS_ERR(data->base))
394 return PTR_ERR(data->base);
Richard Zhaod142d6b2012-09-12 14:58:05 +0300395
Marc Kleine-Buddee6091082013-03-30 12:53:59 +0200396 tmp_dev = (struct of_device_id *)
397 of_match_device(usbmisc_imx_dt_ids, &pdev->dev);
398 data->ops = (const struct usbmisc_ops *)tmp_dev->data;
Stefan Agnerf40017e2014-09-22 08:14:15 +0800399 platform_set_drvdata(pdev, data);
Richard Zhaod142d6b2012-09-12 14:58:05 +0300400
Richard Zhaod142d6b2012-09-12 14:58:05 +0300401 return 0;
402}
403
Michael Grzeschika7bc2fd2013-03-30 12:53:56 +0200404static int usbmisc_imx_remove(struct platform_device *pdev)
Richard Zhaod142d6b2012-09-12 14:58:05 +0300405{
Richard Zhaod142d6b2012-09-12 14:58:05 +0300406 return 0;
407}
408
Michael Grzeschika7bc2fd2013-03-30 12:53:56 +0200409static struct platform_driver usbmisc_imx_driver = {
410 .probe = usbmisc_imx_probe,
411 .remove = usbmisc_imx_remove,
Richard Zhaod142d6b2012-09-12 14:58:05 +0300412 .driver = {
Michael Grzeschika7bc2fd2013-03-30 12:53:56 +0200413 .name = "usbmisc_imx",
Michael Grzeschika7bc2fd2013-03-30 12:53:56 +0200414 .of_match_table = usbmisc_imx_dt_ids,
Richard Zhaod142d6b2012-09-12 14:58:05 +0300415 },
416};
417
Philipp Zabel0404ae02013-06-13 17:59:59 +0300418module_platform_driver(usbmisc_imx_driver);
Richard Zhaod142d6b2012-09-12 14:58:05 +0300419
Michael Grzeschika7bc2fd2013-03-30 12:53:56 +0200420MODULE_ALIAS("platform:usbmisc-imx");
Richard Zhaod142d6b2012-09-12 14:58:05 +0300421MODULE_LICENSE("GPL v2");
Michael Grzeschika7bc2fd2013-03-30 12:53:56 +0200422MODULE_DESCRIPTION("driver for imx usb non-core registers");
Richard Zhaod142d6b2012-09-12 14:58:05 +0300423MODULE_AUTHOR("Richard Zhao <richard.zhao@freescale.com>");