blob: e57125bef1078f5615bcdd637dacea07a38e08c0 [file] [log] [blame]
Mathieu Chartierf9c6fc62015-10-07 11:44:05 -07001/*
2 * Copyright (C) 2015 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include "oat_file_manager.h"
18
19#include <memory>
20#include <queue>
21#include <vector>
22
23#include "base/logging.h"
24#include "base/stl_util.h"
Mathieu Chartier32ce2ad2016-03-04 14:58:03 -080025#include "base/systrace.h"
Mathieu Chartierfbc31082016-01-24 11:59:56 -080026#include "class_linker.h"
Mathieu Chartier80b37b72015-10-12 18:13:39 -070027#include "dex_file-inl.h"
Mathieu Chartier61d2b2d2016-02-04 13:31:46 -080028#include "gc/scoped_gc_critical_section.h"
Mathieu Chartierf9c6fc62015-10-07 11:44:05 -070029#include "gc/space/image_space.h"
Mathieu Chartierfbc31082016-01-24 11:59:56 -080030#include "handle_scope-inl.h"
31#include "mirror/class_loader.h"
Mathieu Chartierf9c6fc62015-10-07 11:44:05 -070032#include "oat_file_assistant.h"
Mathieu Chartierfbc31082016-01-24 11:59:56 -080033#include "scoped_thread_state_change.h"
Mathieu Chartierf9c6fc62015-10-07 11:44:05 -070034#include "thread-inl.h"
Mathieu Chartiera9d82fe2016-01-25 20:06:11 -080035#include "thread_list.h"
Mathieu Chartierf9c6fc62015-10-07 11:44:05 -070036
37namespace art {
38
39// For b/21333911.
Mathieu Chartier80b37b72015-10-12 18:13:39 -070040// Only enabled for debug builds to prevent bit rot. There are too many performance regressions for
41// normal builds.
42static constexpr bool kDuplicateClassesCheck = kIsDebugBuild;
Mathieu Chartierf9c6fc62015-10-07 11:44:05 -070043
Mathieu Chartierfbc31082016-01-24 11:59:56 -080044// If true, then we attempt to load the application image if it exists.
45static constexpr bool kEnableAppImage = true;
46
Mathieu Chartierf9c6fc62015-10-07 11:44:05 -070047const OatFile* OatFileManager::RegisterOatFile(std::unique_ptr<const OatFile> oat_file) {
Mathieu Chartiere58991b2015-10-13 07:59:34 -070048 WriterMutexLock mu(Thread::Current(), *Locks::oat_file_manager_lock_);
Mathieu Chartierf9c6fc62015-10-07 11:44:05 -070049 DCHECK(oat_file != nullptr);
50 if (kIsDebugBuild) {
Mathieu Chartiere58991b2015-10-13 07:59:34 -070051 CHECK(oat_files_.find(oat_file) == oat_files_.end());
Mathieu Chartierf9c6fc62015-10-07 11:44:05 -070052 for (const std::unique_ptr<const OatFile>& existing : oat_files_) {
53 CHECK_NE(oat_file.get(), existing.get()) << oat_file->GetLocation();
54 // Check that we don't have an oat file with the same address. Copies of the same oat file
55 // should be loaded at different addresses.
56 CHECK_NE(oat_file->Begin(), existing->Begin()) << "Oat file already mapped at that location";
57 }
58 }
59 have_non_pic_oat_file_ = have_non_pic_oat_file_ || !oat_file->IsPic();
Mathieu Chartiere58991b2015-10-13 07:59:34 -070060 const OatFile* ret = oat_file.get();
61 oat_files_.insert(std::move(oat_file));
62 return ret;
63}
64
65void OatFileManager::UnRegisterAndDeleteOatFile(const OatFile* oat_file) {
66 WriterMutexLock mu(Thread::Current(), *Locks::oat_file_manager_lock_);
67 DCHECK(oat_file != nullptr);
68 std::unique_ptr<const OatFile> compare(oat_file);
69 auto it = oat_files_.find(compare);
70 CHECK(it != oat_files_.end());
71 oat_files_.erase(it);
72 compare.release();
Mathieu Chartierf9c6fc62015-10-07 11:44:05 -070073}
74
75const OatFile* OatFileManager::FindOpenedOatFileFromOatLocation(const std::string& oat_location)
76 const {
77 ReaderMutexLock mu(Thread::Current(), *Locks::oat_file_manager_lock_);
Mathieu Chartiere58991b2015-10-13 07:59:34 -070078 return FindOpenedOatFileFromOatLocationLocked(oat_location);
79}
80
81const OatFile* OatFileManager::FindOpenedOatFileFromOatLocationLocked(
82 const std::string& oat_location) const {
Mathieu Chartierf9c6fc62015-10-07 11:44:05 -070083 for (const std::unique_ptr<const OatFile>& oat_file : oat_files_) {
84 if (oat_file->GetLocation() == oat_location) {
85 return oat_file.get();
86 }
87 }
88 return nullptr;
89}
90
Jeff Haodcdc85b2015-12-04 14:06:18 -080091std::vector<const OatFile*> OatFileManager::GetBootOatFiles() const {
92 std::vector<const OatFile*> oat_files;
93 std::vector<gc::space::ImageSpace*> image_spaces =
94 Runtime::Current()->GetHeap()->GetBootImageSpaces();
95 for (gc::space::ImageSpace* image_space : image_spaces) {
96 oat_files.push_back(image_space->GetOatFile());
97 }
98 return oat_files;
Mathieu Chartierf9c6fc62015-10-07 11:44:05 -070099}
100
101const OatFile* OatFileManager::GetPrimaryOatFile() const {
102 ReaderMutexLock mu(Thread::Current(), *Locks::oat_file_manager_lock_);
Jeff Haodcdc85b2015-12-04 14:06:18 -0800103 std::vector<const OatFile*> boot_oat_files = GetBootOatFiles();
104 if (!boot_oat_files.empty()) {
Mathieu Chartierf9c6fc62015-10-07 11:44:05 -0700105 for (const std::unique_ptr<const OatFile>& oat_file : oat_files_) {
Jeff Haodcdc85b2015-12-04 14:06:18 -0800106 if (std::find(boot_oat_files.begin(), boot_oat_files.end(), oat_file.get()) ==
107 boot_oat_files.end()) {
Mathieu Chartierf9c6fc62015-10-07 11:44:05 -0700108 return oat_file.get();
109 }
110 }
111 }
112 return nullptr;
113}
114
115OatFileManager::~OatFileManager() {
Mathieu Chartiere58991b2015-10-13 07:59:34 -0700116 // Explicitly clear oat_files_ since the OatFile destructor calls back into OatFileManager for
117 // UnRegisterOatFileLocation.
118 oat_files_.clear();
Mathieu Chartierf9c6fc62015-10-07 11:44:05 -0700119}
120
Jeff Haodcdc85b2015-12-04 14:06:18 -0800121std::vector<const OatFile*> OatFileManager::RegisterImageOatFiles(
122 std::vector<gc::space::ImageSpace*> spaces) {
123 std::vector<const OatFile*> oat_files;
124 for (gc::space::ImageSpace* space : spaces) {
125 oat_files.push_back(RegisterOatFile(space->ReleaseOatFile()));
126 }
127 return oat_files;
Mathieu Chartierf9c6fc62015-10-07 11:44:05 -0700128}
129
130class DexFileAndClassPair : ValueObject {
131 public:
132 DexFileAndClassPair(const DexFile* dex_file, size_t current_class_index, bool from_loaded_oat)
133 : cached_descriptor_(GetClassDescriptor(dex_file, current_class_index)),
134 dex_file_(dex_file),
135 current_class_index_(current_class_index),
136 from_loaded_oat_(from_loaded_oat) {}
137
Mathieu Chartier80b37b72015-10-12 18:13:39 -0700138 DexFileAndClassPair(const DexFileAndClassPair& rhs) = default;
Mathieu Chartierf9c6fc62015-10-07 11:44:05 -0700139
Mathieu Chartier80b37b72015-10-12 18:13:39 -0700140 DexFileAndClassPair& operator=(const DexFileAndClassPair& rhs) = default;
Mathieu Chartierf9c6fc62015-10-07 11:44:05 -0700141
142 const char* GetCachedDescriptor() const {
143 return cached_descriptor_;
144 }
145
146 bool operator<(const DexFileAndClassPair& rhs) const {
147 const int cmp = strcmp(cached_descriptor_, rhs.cached_descriptor_);
148 if (cmp != 0) {
149 // Note that the order must be reversed. We want to iterate over the classes in dex files.
150 // They are sorted lexicographically. Thus, the priority-queue must be a min-queue.
151 return cmp > 0;
152 }
153 return dex_file_ < rhs.dex_file_;
154 }
155
156 bool DexFileHasMoreClasses() const {
157 return current_class_index_ + 1 < dex_file_->NumClassDefs();
158 }
159
160 void Next() {
161 ++current_class_index_;
Mathieu Chartier80b37b72015-10-12 18:13:39 -0700162 cached_descriptor_ = GetClassDescriptor(dex_file_.get(), current_class_index_);
Mathieu Chartierf9c6fc62015-10-07 11:44:05 -0700163 }
164
165 size_t GetCurrentClassIndex() const {
166 return current_class_index_;
167 }
168
169 bool FromLoadedOat() const {
170 return from_loaded_oat_;
171 }
172
173 const DexFile* GetDexFile() const {
174 return dex_file_.get();
175 }
176
177 private:
178 static const char* GetClassDescriptor(const DexFile* dex_file, size_t index) {
179 DCHECK(IsUint<16>(index));
180 const DexFile::ClassDef& class_def = dex_file->GetClassDef(static_cast<uint16_t>(index));
181 return dex_file->StringByTypeIdx(class_def.class_idx_);
182 }
183
184 const char* cached_descriptor_;
Mathieu Chartier80b37b72015-10-12 18:13:39 -0700185 std::shared_ptr<const DexFile> dex_file_;
Mathieu Chartierf9c6fc62015-10-07 11:44:05 -0700186 size_t current_class_index_;
187 bool from_loaded_oat_; // We only need to compare mismatches between what we load now
188 // and what was loaded before. Any old duplicates must have been
189 // OK, and any new "internal" duplicates are as well (they must
190 // be from multidex, which resolves correctly).
191};
192
193static void AddDexFilesFromOat(const OatFile* oat_file,
194 bool already_loaded,
195 /*out*/std::priority_queue<DexFileAndClassPair>* heap) {
196 for (const OatDexFile* oat_dex_file : oat_file->GetOatDexFiles()) {
197 std::string error;
198 std::unique_ptr<const DexFile> dex_file = oat_dex_file->OpenDexFile(&error);
199 if (dex_file == nullptr) {
200 LOG(WARNING) << "Could not create dex file from oat file: " << error;
201 } else if (dex_file->NumClassDefs() > 0U) {
202 heap->emplace(dex_file.release(), /*current_class_index*/0U, already_loaded);
203 }
204 }
205}
206
207static void AddNext(/*inout*/DexFileAndClassPair* original,
208 /*inout*/std::priority_queue<DexFileAndClassPair>* heap) {
209 if (original->DexFileHasMoreClasses()) {
210 original->Next();
211 heap->push(std::move(*original));
212 }
213}
214
215// Check for class-def collisions in dex files.
216//
217// This works by maintaining a heap with one class from each dex file, sorted by the class
218// descriptor. Then a dex-file/class pair is continually removed from the heap and compared
219// against the following top element. If the descriptor is the same, it is now checked whether
220// the two elements agree on whether their dex file was from an already-loaded oat-file or the
221// new oat file. Any disagreement indicates a collision.
222bool OatFileManager::HasCollisions(const OatFile* oat_file,
223 std::string* error_msg /*out*/) const {
224 DCHECK(oat_file != nullptr);
225 DCHECK(error_msg != nullptr);
226 if (!kDuplicateClassesCheck) {
227 return false;
228 }
229
230 // Dex files are registered late - once a class is actually being loaded. We have to compare
231 // against the open oat files. Take the oat_file_manager_lock_ that protects oat_files_ accesses.
232 ReaderMutexLock mu(Thread::Current(), *Locks::oat_file_manager_lock_);
233
234 std::priority_queue<DexFileAndClassPair> queue;
235
236 // Add dex files from already loaded oat files, but skip boot.
Jeff Haodcdc85b2015-12-04 14:06:18 -0800237 std::vector<const OatFile*> boot_oat_files = GetBootOatFiles();
Mathieu Chartier80b37b72015-10-12 18:13:39 -0700238 // The same OatFile can be loaded multiple times at different addresses. In this case, we don't
239 // need to check both against each other since they would have resolved the same way at compile
240 // time.
241 std::unordered_set<std::string> unique_locations;
Mathieu Chartierf9c6fc62015-10-07 11:44:05 -0700242 for (const std::unique_ptr<const OatFile>& loaded_oat_file : oat_files_) {
Mathieu Chartier80b37b72015-10-12 18:13:39 -0700243 DCHECK_NE(loaded_oat_file.get(), oat_file);
244 const std::string& location = loaded_oat_file->GetLocation();
Jeff Haodcdc85b2015-12-04 14:06:18 -0800245 if (std::find(boot_oat_files.begin(), boot_oat_files.end(), loaded_oat_file.get()) ==
246 boot_oat_files.end() && location != oat_file->GetLocation() &&
Mathieu Chartier80b37b72015-10-12 18:13:39 -0700247 unique_locations.find(location) == unique_locations.end()) {
248 unique_locations.insert(location);
Mathieu Chartierf9c6fc62015-10-07 11:44:05 -0700249 AddDexFilesFromOat(loaded_oat_file.get(), /*already_loaded*/true, &queue);
250 }
251 }
252
253 if (queue.empty()) {
254 // No other oat files, return early.
255 return false;
256 }
257
258 // Add dex files from the oat file to check.
259 AddDexFilesFromOat(oat_file, /*already_loaded*/false, &queue);
260
261 // Now drain the queue.
262 while (!queue.empty()) {
263 // Modifying the top element is only safe if we pop right after.
Mathieu Chartier80b37b72015-10-12 18:13:39 -0700264 DexFileAndClassPair compare_pop(queue.top());
Mathieu Chartierf9c6fc62015-10-07 11:44:05 -0700265 queue.pop();
266
267 // Compare against the following elements.
268 while (!queue.empty()) {
Mathieu Chartier80b37b72015-10-12 18:13:39 -0700269 DexFileAndClassPair top(queue.top());
Mathieu Chartierf9c6fc62015-10-07 11:44:05 -0700270
271 if (strcmp(compare_pop.GetCachedDescriptor(), top.GetCachedDescriptor()) == 0) {
272 // Same descriptor. Check whether it's crossing old-oat-files to new-oat-files.
273 if (compare_pop.FromLoadedOat() != top.FromLoadedOat()) {
274 *error_msg =
275 StringPrintf("Found duplicated class when checking oat files: '%s' in %s and %s",
276 compare_pop.GetCachedDescriptor(),
277 compare_pop.GetDexFile()->GetLocation().c_str(),
278 top.GetDexFile()->GetLocation().c_str());
279 return true;
280 }
Mathieu Chartierf9c6fc62015-10-07 11:44:05 -0700281 queue.pop();
282 AddNext(&top, &queue);
283 } else {
284 // Something else. Done here.
285 break;
286 }
287 }
288 AddNext(&compare_pop, &queue);
289 }
290
291 return false;
292}
293
294std::vector<std::unique_ptr<const DexFile>> OatFileManager::OpenDexFilesFromOat(
295 const char* dex_location,
296 const char* oat_location,
Mathieu Chartierfbc31082016-01-24 11:59:56 -0800297 jobject class_loader,
298 jobjectArray dex_elements,
Mathieu Chartiere58991b2015-10-13 07:59:34 -0700299 const OatFile** out_oat_file,
Mathieu Chartierf9c6fc62015-10-07 11:44:05 -0700300 std::vector<std::string>* error_msgs) {
Mathieu Chartier32ce2ad2016-03-04 14:58:03 -0800301 ScopedTrace trace(__FUNCTION__);
Mathieu Chartierf9c6fc62015-10-07 11:44:05 -0700302 CHECK(dex_location != nullptr);
303 CHECK(error_msgs != nullptr);
304
305 // Verify we aren't holding the mutator lock, which could starve GC if we
306 // have to generate or relocate an oat file.
Mathieu Chartierfbc31082016-01-24 11:59:56 -0800307 Thread* const self = Thread::Current();
308 Locks::mutator_lock_->AssertNotHeld(self);
309 Runtime* const runtime = Runtime::Current();
Calin Juravleb077e152016-02-18 18:47:37 +0000310
311 int target_compilation_type_mask = OatFileAssistant::kFullCompilation
312 | OatFileAssistant::kProfileGuideCompilation
313 | OatFileAssistant::kExtractOnly;
Mathieu Chartierf9c6fc62015-10-07 11:44:05 -0700314 OatFileAssistant oat_file_assistant(dex_location,
315 oat_location,
Calin Juravleb077e152016-02-18 18:47:37 +0000316 target_compilation_type_mask,
Mathieu Chartierf9c6fc62015-10-07 11:44:05 -0700317 kRuntimeISA,
Mathieu Chartierfbc31082016-01-24 11:59:56 -0800318 !runtime->IsAotCompiler());
Mathieu Chartierf9c6fc62015-10-07 11:44:05 -0700319
320 // Lock the target oat location to avoid races generating and loading the
321 // oat file.
322 std::string error_msg;
323 if (!oat_file_assistant.Lock(/*out*/&error_msg)) {
324 // Don't worry too much if this fails. If it does fail, it's unlikely we
325 // can generate an oat file anyway.
326 VLOG(class_linker) << "OatFileAssistant::Lock: " << error_msg;
327 }
328
329 const OatFile* source_oat_file = nullptr;
330
Nicolas Geoffraye722d292015-12-15 11:51:37 +0000331 // Update the oat file on disk if we can. This may fail, but that's okay.
332 // Best effort is all that matters here.
333 if (!oat_file_assistant.MakeUpToDate(/*out*/&error_msg)) {
Nicolas Geoffraya28267f2015-12-16 12:34:50 +0000334 LOG(INFO) << error_msg;
Mathieu Chartierf9c6fc62015-10-07 11:44:05 -0700335 }
336
337 // Get the oat file on disk.
338 std::unique_ptr<const OatFile> oat_file(oat_file_assistant.GetBestOatFile().release());
Mathieu Chartierfbc31082016-01-24 11:59:56 -0800339
Mathieu Chartierf9c6fc62015-10-07 11:44:05 -0700340 if (oat_file != nullptr) {
341 // Take the file only if it has no collisions, or we must take it because of preopting.
342 bool accept_oat_file = !HasCollisions(oat_file.get(), /*out*/ &error_msg);
343 if (!accept_oat_file) {
344 // Failed the collision check. Print warning.
345 if (Runtime::Current()->IsDexFileFallbackEnabled()) {
346 LOG(WARNING) << "Found duplicate classes, falling back to interpreter mode for "
347 << dex_location;
348 } else {
349 LOG(WARNING) << "Found duplicate classes, dex-file-fallback disabled, will be failing to "
350 " load classes for " << dex_location;
351 }
352 LOG(WARNING) << error_msg;
353
354 // However, if the app was part of /system and preopted, there is no original dex file
355 // available. In that case grudgingly accept the oat file.
356 if (!DexFile::MaybeDex(dex_location)) {
357 accept_oat_file = true;
358 LOG(WARNING) << "Dex location " << dex_location << " does not seem to include dex file. "
359 << "Allow oat file use. This is potentially dangerous.";
360 }
361 }
362
363 if (accept_oat_file) {
364 VLOG(class_linker) << "Registering " << oat_file->GetLocation();
365 source_oat_file = RegisterOatFile(std::move(oat_file));
Mathieu Chartiere58991b2015-10-13 07:59:34 -0700366 *out_oat_file = source_oat_file;
Mathieu Chartierf9c6fc62015-10-07 11:44:05 -0700367 }
368 }
369
370 std::vector<std::unique_ptr<const DexFile>> dex_files;
371
372 // Load the dex files from the oat file.
373 if (source_oat_file != nullptr) {
Mathieu Chartierfbc31082016-01-24 11:59:56 -0800374 bool added_image_space = false;
375 if (source_oat_file->IsExecutable()) {
376 std::unique_ptr<gc::space::ImageSpace> image_space(
377 kEnableAppImage ? oat_file_assistant.OpenImageSpace(source_oat_file) : nullptr);
378 if (image_space != nullptr) {
379 ScopedObjectAccess soa(self);
380 StackHandleScope<1> hs(self);
381 Handle<mirror::ClassLoader> h_loader(
382 hs.NewHandle(soa.Decode<mirror::ClassLoader*>(class_loader)));
383 // Can not load app image without class loader.
384 if (h_loader.Get() != nullptr) {
385 std::string temp_error_msg;
386 // Add image space has a race condition since other threads could be reading from the
387 // spaces array.
Mathieu Chartiera9d82fe2016-01-25 20:06:11 -0800388 {
389 ScopedThreadSuspension sts(self, kSuspended);
Mathieu Chartier61d2b2d2016-02-04 13:31:46 -0800390 gc::ScopedGCCriticalSection gcs(self,
391 gc::kGcCauseAddRemoveAppImageSpace,
392 gc::kCollectorTypeAddRemoveAppImageSpace);
Mathieu Chartiera9d82fe2016-01-25 20:06:11 -0800393 ScopedSuspendAll ssa("Add image space");
394 runtime->GetHeap()->AddSpace(image_space.get());
395 }
Mathieu Chartier32ce2ad2016-03-04 14:58:03 -0800396 {
397 ScopedTrace trace2(StringPrintf("Adding image space for location %s", dex_location));
398 added_image_space = runtime->GetClassLinker()->AddImageSpace(image_space.get(),
399 h_loader,
400 dex_elements,
401 dex_location,
402 /*out*/&dex_files,
403 /*out*/&temp_error_msg);
404 }
Mathieu Chartiera6e81ed2016-02-25 13:52:10 -0800405 if (added_image_space) {
Mathieu Chartierbd064ea2016-02-11 16:27:18 -0800406 // Successfully added image space to heap, release the map so that it does not get
407 // freed.
408 image_space.release();
409 } else {
Mathieu Chartierfbc31082016-01-24 11:59:56 -0800410 LOG(INFO) << "Failed to add image file " << temp_error_msg;
411 dex_files.clear();
Mathieu Chartiera9d82fe2016-01-25 20:06:11 -0800412 {
413 ScopedThreadSuspension sts(self, kSuspended);
Mathieu Chartier61d2b2d2016-02-04 13:31:46 -0800414 gc::ScopedGCCriticalSection gcs(self,
415 gc::kGcCauseAddRemoveAppImageSpace,
416 gc::kCollectorTypeAddRemoveAppImageSpace);
Mathieu Chartiera9d82fe2016-01-25 20:06:11 -0800417 ScopedSuspendAll ssa("Remove image space");
418 runtime->GetHeap()->RemoveSpace(image_space.get());
419 }
Mathieu Chartierfbc31082016-01-24 11:59:56 -0800420 // Non-fatal, don't update error_msg.
421 }
Mathieu Chartierfbc31082016-01-24 11:59:56 -0800422 }
423 }
424 }
425 if (!added_image_space) {
426 DCHECK(dex_files.empty());
427 dex_files = oat_file_assistant.LoadDexFiles(*source_oat_file, dex_location);
428 }
Mathieu Chartierf9c6fc62015-10-07 11:44:05 -0700429 if (dex_files.empty()) {
430 error_msgs->push_back("Failed to open dex files from " + source_oat_file->GetLocation());
431 }
432 }
433
434 // Fall back to running out of the original dex file if we couldn't load any
435 // dex_files from the oat file.
436 if (dex_files.empty()) {
437 if (oat_file_assistant.HasOriginalDexFiles()) {
438 if (Runtime::Current()->IsDexFileFallbackEnabled()) {
439 if (!DexFile::Open(dex_location, dex_location, /*out*/ &error_msg, &dex_files)) {
440 LOG(WARNING) << error_msg;
441 error_msgs->push_back("Failed to open dex files from " + std::string(dex_location));
442 }
443 } else {
444 error_msgs->push_back("Fallback mode disabled, skipping dex files.");
445 }
446 } else {
447 error_msgs->push_back("No original dex files found for dex location "
448 + std::string(dex_location));
449 }
450 }
Calin Juravlec90bc922016-02-24 10:13:09 +0000451
452 // TODO(calin): Consider optimizing this knowing that is useless to record the
453 // use of fully compiled apks.
454 Runtime::Current()->NotifyDexLoaded(dex_location);
Mathieu Chartierf9c6fc62015-10-07 11:44:05 -0700455 return dex_files;
456}
457
Mathieu Chartiere58991b2015-10-13 07:59:34 -0700458bool OatFileManager::RegisterOatFileLocation(const std::string& oat_location) {
459 WriterMutexLock mu(Thread::Current(), *Locks::oat_file_count_lock_);
460 auto it = oat_file_count_.find(oat_location);
461 if (it != oat_file_count_.end()) {
462 ++it->second;
463 return false;
464 }
465 oat_file_count_.insert(std::pair<std::string, size_t>(oat_location, 1u));
466 return true;
467}
468
469void OatFileManager::UnRegisterOatFileLocation(const std::string& oat_location) {
470 WriterMutexLock mu(Thread::Current(), *Locks::oat_file_count_lock_);
471 auto it = oat_file_count_.find(oat_location);
472 if (it != oat_file_count_.end()) {
473 --it->second;
474 if (it->second == 0) {
475 oat_file_count_.erase(it);
476 }
477 }
478}
479
Mathieu Chartierf9c6fc62015-10-07 11:44:05 -0700480} // namespace art