blob: 86154ededa5747e4995c3dcff7a7d61618e73cec [file] [log] [blame]
Brian Carlstrom59848da2011-07-23 20:35:19 -07001#!/usr/bin/python2.4
2#
3# Copyright (c) 2009 Google Inc. All rights reserved.
4#
5# Redistribution and use in source and binary forms, with or without
6# modification, are permitted provided that the following conditions are
7# met:
8#
9# * Redistributions of source code must retain the above copyright
10# notice, this list of conditions and the following disclaimer.
11# * Redistributions in binary form must reproduce the above
12# copyright notice, this list of conditions and the following disclaimer
13# in the documentation and/or other materials provided with the
14# distribution.
15# * Neither the name of Google Inc. nor the names of its
16# contributors may be used to endorse or promote products derived from
17# this software without specific prior written permission.
18#
19# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
20# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
21# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
22# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
23# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
24# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
25# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
26# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
27# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
28# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
29# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
30
31# Here are some issues that I've had people identify in my code during reviews,
32# that I think are possible to flag automatically in a lint tool. If these were
33# caught by lint, it would save time both for myself and that of my reviewers.
34# Most likely, some of these are beyond the scope of the current lint framework,
35# but I think it is valuable to retain these wish-list items even if they cannot
36# be immediately implemented.
37#
38# Suggestions
39# -----------
40# - Check for no 'explicit' for multi-arg ctor
41# - Check for boolean assign RHS in parens
42# - Check for ctor initializer-list colon position and spacing
43# - Check that if there's a ctor, there should be a dtor
44# - Check accessors that return non-pointer member variables are
45# declared const
46# - Check accessors that return non-const pointer member vars are
47# *not* declared const
48# - Check for using public includes for testing
49# - Check for spaces between brackets in one-line inline method
50# - Check for no assert()
51# - Check for spaces surrounding operators
52# - Check for 0 in pointer context (should be NULL)
53# - Check for 0 in char context (should be '\0')
54# - Check for camel-case method name conventions for methods
55# that are not simple inline getters and setters
56# - Check that base classes have virtual destructors
57# put " // namespace" after } that closes a namespace, with
58# namespace's name after 'namespace' if it is named.
59# - Do not indent namespace contents
60# - Avoid inlining non-trivial constructors in header files
61# include base/basictypes.h if DISALLOW_EVIL_CONSTRUCTORS is used
62# - Check for old-school (void) cast for call-sites of functions
63# ignored return value
64# - Check gUnit usage of anonymous namespace
65# - Check for class declaration order (typedefs, consts, enums,
66# ctor(s?), dtor, friend declarations, methods, member vars)
67#
68
69"""Does google-lint on c++ files.
70
71The goal of this script is to identify places in the code that *may*
72be in non-compliance with google style. It does not attempt to fix
73up these problems -- the point is to educate. It does also not
74attempt to find all problems, or to ensure that everything it does
75find is legitimately a problem.
76
77In particular, we can get very confused by /* and // inside strings!
78We do a small hack, which is to ignore //'s with "'s after them on the
79same line, but it is far from perfect (in either direction).
80"""
81
82import codecs
83import getopt
84import math # for log
85import os
86import re
87import sre_compile
88import string
89import sys
90import unicodedata
91
92
93_USAGE = """
94Syntax: cpplint.py [--verbose=#] [--output=vs7] [--filter=-x,+y,...]
95 [--counting=total|toplevel|detailed]
96 <file> [file] ...
97
98 The style guidelines this tries to follow are those in
99 http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml
100
101 Every problem is given a confidence score from 1-5, with 5 meaning we are
102 certain of the problem, and 1 meaning it could be a legitimate construct.
103 This will miss some errors, and is not a substitute for a code review.
104
105 To suppress false-positive errors of a certain category, add a
106 'NOLINT(category)' comment to the line. NOLINT or NOLINT(*)
107 suppresses errors of all categories on that line.
108
109 The files passed in will be linted; at least one file must be provided.
110 Linted extensions are .cc, .cpp, and .h. Other file types will be ignored.
111
112 Flags:
113
114 output=vs7
115 By default, the output is formatted to ease emacs parsing. Visual Studio
116 compatible output (vs7) may also be used. Other formats are unsupported.
117
118 verbose=#
119 Specify a number 0-5 to restrict errors to certain verbosity levels.
120
121 filter=-x,+y,...
122 Specify a comma-separated list of category-filters to apply: only
123 error messages whose category names pass the filters will be printed.
124 (Category names are printed with the message and look like
125 "[whitespace/indent]".) Filters are evaluated left to right.
126 "-FOO" and "FOO" means "do not print categories that start with FOO".
127 "+FOO" means "do print categories that start with FOO".
128
129 Examples: --filter=-whitespace,+whitespace/braces
130 --filter=whitespace,runtime/printf,+runtime/printf_format
131 --filter=-,+build/include_what_you_use
132
133 To see a list of all the categories used in cpplint, pass no arg:
134 --filter=
135
136 counting=total|toplevel|detailed
137 The total number of errors found is always printed. If
138 'toplevel' is provided, then the count of errors in each of
139 the top-level categories like 'build' and 'whitespace' will
140 also be printed. If 'detailed' is provided, then a count
141 is provided for each category like 'build/class'.
142"""
143
144# We categorize each error message we print. Here are the categories.
145# We want an explicit list so we can list them all in cpplint --filter=.
146# If you add a new error message with a new category, add it to the list
147# here! cpplint_unittest.py should tell you if you forget to do this.
148# \ used for clearer layout -- pylint: disable-msg=C6013
149_ERROR_CATEGORIES = [
150 'build/class',
151 'build/deprecated',
152 'build/endif_comment',
153 'build/forward_decl',
154 'build/header_guard',
155 'build/include',
156 'build/include_alpha',
157 'build/include_order',
158 'build/include_what_you_use',
159 'build/namespaces',
160 'build/printf_format',
161 'build/storage_class',
162 'legal/copyright',
163 'readability/braces',
164 'readability/casting',
165 'readability/check',
166 'readability/constructors',
167 'readability/fn_size',
168 'readability/function',
169 'readability/multiline_comment',
170 'readability/multiline_string',
171 'readability/nolint',
172 'readability/streams',
173 'readability/todo',
174 'readability/utf8',
175 'runtime/arrays',
176 'runtime/casting',
177 'runtime/explicit',
178 'runtime/int',
179 'runtime/init',
180 'runtime/invalid_increment',
181 'runtime/member_string_references',
182 'runtime/memset',
183 'runtime/operator',
184 'runtime/printf',
185 'runtime/printf_format',
186 'runtime/references',
187 'runtime/rtti',
188 'runtime/sizeof',
189 'runtime/string',
190 'runtime/threadsafe_fn',
191 'runtime/virtual',
192 'whitespace/blank_line',
193 'whitespace/braces',
194 'whitespace/comma',
195 'whitespace/comments',
196 'whitespace/end_of_line',
197 'whitespace/ending_newline',
198 'whitespace/indent',
199 'whitespace/labels',
200 'whitespace/line_length',
201 'whitespace/newline',
202 'whitespace/operators',
203 'whitespace/parens',
204 'whitespace/semicolon',
205 'whitespace/tab',
206 'whitespace/todo'
207 ]
208
209# The default state of the category filter. This is overrided by the --filter=
210# flag. By default all errors are on, so only add here categories that should be
211# off by default (i.e., categories that must be enabled by the --filter= flags).
212# All entries here should start with a '-' or '+', as in the --filter= flag.
213_DEFAULT_FILTERS = [ '-build/include_alpha' ]
214
215# We used to check for high-bit characters, but after much discussion we
216# decided those were OK, as long as they were in UTF-8 and didn't represent
217# hard-coded international strings, which belong in a seperate i18n file.
218
219# Headers that we consider STL headers.
220_STL_HEADERS = frozenset([
221 'algobase.h', 'algorithm', 'alloc.h', 'bitset', 'deque', 'exception',
222 'function.h', 'functional', 'hash_map', 'hash_map.h', 'hash_set',
223 'hash_set.h', 'iterator', 'list', 'list.h', 'map', 'memory', 'new',
224 'pair.h', 'pthread_alloc', 'queue', 'set', 'set.h', 'sstream', 'stack',
225 'stl_alloc.h', 'stl_relops.h', 'type_traits.h',
226 'utility', 'vector', 'vector.h',
227 ])
228
229
230# Non-STL C++ system headers.
231_CPP_HEADERS = frozenset([
232 'algo.h', 'builtinbuf.h', 'bvector.h', 'cassert', 'cctype',
233 'cerrno', 'cfloat', 'ciso646', 'climits', 'clocale', 'cmath',
234 'complex', 'complex.h', 'csetjmp', 'csignal', 'cstdarg', 'cstddef',
235 'cstdio', 'cstdlib', 'cstring', 'ctime', 'cwchar', 'cwctype',
236 'defalloc.h', 'deque.h', 'editbuf.h', 'exception', 'fstream',
237 'fstream.h', 'hashtable.h', 'heap.h', 'indstream.h', 'iomanip',
238 'iomanip.h', 'ios', 'iosfwd', 'iostream', 'iostream.h', 'istream.h',
239 'iterator.h', 'limits', 'map.h', 'multimap.h', 'multiset.h',
240 'numeric', 'ostream.h', 'parsestream.h', 'pfstream.h', 'PlotFile.h',
241 'procbuf.h', 'pthread_alloc.h', 'rope', 'rope.h', 'ropeimpl.h',
242 'SFile.h', 'slist', 'slist.h', 'stack.h', 'stdexcept',
243 'stdiostream.h', 'streambuf.h', 'stream.h', 'strfile.h', 'string',
244 'strstream', 'strstream.h', 'tempbuf.h', 'tree.h', 'typeinfo', 'valarray',
245 ])
246
247
248# Assertion macros. These are defined in base/logging.h and
249# testing/base/gunit.h. Note that the _M versions need to come first
250# for substring matching to work.
251_CHECK_MACROS = [
252 'DCHECK', 'CHECK',
253 'EXPECT_TRUE_M', 'EXPECT_TRUE',
254 'ASSERT_TRUE_M', 'ASSERT_TRUE',
255 'EXPECT_FALSE_M', 'EXPECT_FALSE',
256 'ASSERT_FALSE_M', 'ASSERT_FALSE',
257 ]
258
259# Replacement macros for CHECK/DCHECK/EXPECT_TRUE/EXPECT_FALSE
260_CHECK_REPLACEMENT = dict([(m, {}) for m in _CHECK_MACROS])
261
262for op, replacement in [('==', 'EQ'), ('!=', 'NE'),
263 ('>=', 'GE'), ('>', 'GT'),
264 ('<=', 'LE'), ('<', 'LT')]:
265 _CHECK_REPLACEMENT['DCHECK'][op] = 'DCHECK_%s' % replacement
266 _CHECK_REPLACEMENT['CHECK'][op] = 'CHECK_%s' % replacement
267 _CHECK_REPLACEMENT['EXPECT_TRUE'][op] = 'EXPECT_%s' % replacement
268 _CHECK_REPLACEMENT['ASSERT_TRUE'][op] = 'ASSERT_%s' % replacement
269 _CHECK_REPLACEMENT['EXPECT_TRUE_M'][op] = 'EXPECT_%s_M' % replacement
270 _CHECK_REPLACEMENT['ASSERT_TRUE_M'][op] = 'ASSERT_%s_M' % replacement
271
272for op, inv_replacement in [('==', 'NE'), ('!=', 'EQ'),
273 ('>=', 'LT'), ('>', 'LE'),
274 ('<=', 'GT'), ('<', 'GE')]:
275 _CHECK_REPLACEMENT['EXPECT_FALSE'][op] = 'EXPECT_%s' % inv_replacement
276 _CHECK_REPLACEMENT['ASSERT_FALSE'][op] = 'ASSERT_%s' % inv_replacement
277 _CHECK_REPLACEMENT['EXPECT_FALSE_M'][op] = 'EXPECT_%s_M' % inv_replacement
278 _CHECK_REPLACEMENT['ASSERT_FALSE_M'][op] = 'ASSERT_%s_M' % inv_replacement
279
280
281# These constants define types of headers for use with
282# _IncludeState.CheckNextIncludeOrder().
283_C_SYS_HEADER = 1
284_CPP_SYS_HEADER = 2
285_LIKELY_MY_HEADER = 3
286_POSSIBLE_MY_HEADER = 4
287_OTHER_HEADER = 5
288
289
290_regexp_compile_cache = {}
291
292# Finds occurrences of NOLINT or NOLINT(...).
293_RE_SUPPRESSION = re.compile(r'\bNOLINT\b(\([^)]*\))?')
294
295# {str, set(int)}: a map from error categories to sets of linenumbers
296# on which those errors are expected and should be suppressed.
297_error_suppressions = {}
298
299def ParseNolintSuppressions(filename, raw_line, linenum, error):
300 """Updates the global list of error-suppressions.
301
302 Parses any NOLINT comments on the current line, updating the global
303 error_suppressions store. Reports an error if the NOLINT comment
304 was malformed.
305
306 Args:
307 filename: str, the name of the input file.
308 raw_line: str, the line of input text, with comments.
309 linenum: int, the number of the current line.
310 error: function, an error handler.
311 """
312 # FIXME(adonovan): "NOLINT(" is misparsed as NOLINT(*).
313 m = _RE_SUPPRESSION.search(raw_line)
314 if m:
315 category = m.group(1)
316 if category in (None, '(*)'): # => "suppress all"
317 _error_suppressions.setdefault(None, set()).add(linenum)
318 else:
319 if category.startswith('(') and category.endswith(')'):
320 category = category[1:-1]
321 if category in _ERROR_CATEGORIES:
322 _error_suppressions.setdefault(category, set()).add(linenum)
323 else:
324 error(filename, linenum, 'readability/nolint', 5,
325 'Unknown NOLINT error category: %s' % category)
326
327
328def ResetNolintSuppressions():
329 "Resets the set of NOLINT suppressions to empty."
330 _error_suppressions.clear()
331
332
333def IsErrorSuppressedByNolint(category, linenum):
334 """Returns true if the specified error category is suppressed on this line.
335
336 Consults the global error_suppressions map populated by
337 ParseNolintSuppressions/ResetNolintSuppressions.
338
339 Args:
340 category: str, the category of the error.
341 linenum: int, the current line number.
342 Returns:
343 bool, True iff the error should be suppressed due to a NOLINT comment.
344 """
345 return (linenum in _error_suppressions.get(category, set()) or
346 linenum in _error_suppressions.get(None, set()))
347
348def Match(pattern, s):
349 """Matches the string with the pattern, caching the compiled regexp."""
350 # The regexp compilation caching is inlined in both Match and Search for
351 # performance reasons; factoring it out into a separate function turns out
352 # to be noticeably expensive.
353 if not pattern in _regexp_compile_cache:
354 _regexp_compile_cache[pattern] = sre_compile.compile(pattern)
355 return _regexp_compile_cache[pattern].match(s)
356
357
358def Search(pattern, s):
359 """Searches the string for the pattern, caching the compiled regexp."""
360 if not pattern in _regexp_compile_cache:
361 _regexp_compile_cache[pattern] = sre_compile.compile(pattern)
362 return _regexp_compile_cache[pattern].search(s)
363
364
365class _IncludeState(dict):
366 """Tracks line numbers for includes, and the order in which includes appear.
367
368 As a dict, an _IncludeState object serves as a mapping between include
369 filename and line number on which that file was included.
370
371 Call CheckNextIncludeOrder() once for each header in the file, passing
372 in the type constants defined above. Calls in an illegal order will
373 raise an _IncludeError with an appropriate error message.
374
375 """
376 # self._section will move monotonically through this set. If it ever
377 # needs to move backwards, CheckNextIncludeOrder will raise an error.
378 _INITIAL_SECTION = 0
379 _MY_H_SECTION = 1
380 _C_SECTION = 2
381 _CPP_SECTION = 3
382 _OTHER_H_SECTION = 4
383
384 _TYPE_NAMES = {
385 _C_SYS_HEADER: 'C system header',
386 _CPP_SYS_HEADER: 'C++ system header',
387 _LIKELY_MY_HEADER: 'header this file implements',
388 _POSSIBLE_MY_HEADER: 'header this file may implement',
389 _OTHER_HEADER: 'other header',
390 }
391 _SECTION_NAMES = {
392 _INITIAL_SECTION: "... nothing. (This can't be an error.)",
393 _MY_H_SECTION: 'a header this file implements',
394 _C_SECTION: 'C system header',
395 _CPP_SECTION: 'C++ system header',
396 _OTHER_H_SECTION: 'other header',
397 }
398
399 def __init__(self):
400 dict.__init__(self)
401 # The name of the current section.
402 self._section = self._INITIAL_SECTION
403 # The path of last found header.
404 self._last_header = ''
405
406 def CanonicalizeAlphabeticalOrder(self, header_path):
407 """Returns a path canonicalized for alphabetical comparisson.
408
409 - replaces "-" with "_" so they both cmp the same.
410 - removes '-inl' since we don't require them to be after the main header.
411 - lowercase everything, just in case.
412
413 Args:
414 header_path: Path to be canonicalized.
415
416 Returns:
417 Canonicalized path.
418 """
419 return header_path.replace('-inl.h', '.h').replace('-', '_').lower()
420
421 def IsInAlphabeticalOrder(self, header_path):
422 """Check if a header is in alphabetical order with the previous header.
423
424 Args:
425 header_path: Header to be checked.
426
427 Returns:
428 Returns true if the header is in alphabetical order.
429 """
430 canonical_header = self.CanonicalizeAlphabeticalOrder(header_path)
431 if self._last_header > canonical_header:
432 return False
433 self._last_header = canonical_header
434 return True
435
436 def CheckNextIncludeOrder(self, header_type):
437 """Returns a non-empty error message if the next header is out of order.
438
439 This function also updates the internal state to be ready to check
440 the next include.
441
442 Args:
443 header_type: One of the _XXX_HEADER constants defined above.
444
445 Returns:
446 The empty string if the header is in the right order, or an
447 error message describing what's wrong.
448
449 """
450 error_message = ('Found %s after %s' %
451 (self._TYPE_NAMES[header_type],
452 self._SECTION_NAMES[self._section]))
453
454 last_section = self._section
455
456 if header_type == _C_SYS_HEADER:
457 if self._section <= self._C_SECTION:
458 self._section = self._C_SECTION
459 else:
460 self._last_header = ''
461 return error_message
462 elif header_type == _CPP_SYS_HEADER:
463 if self._section <= self._CPP_SECTION:
464 self._section = self._CPP_SECTION
465 else:
466 self._last_header = ''
467 return error_message
468 elif header_type == _LIKELY_MY_HEADER:
469 if self._section <= self._MY_H_SECTION:
470 self._section = self._MY_H_SECTION
471 else:
472 self._section = self._OTHER_H_SECTION
473 elif header_type == _POSSIBLE_MY_HEADER:
474 if self._section <= self._MY_H_SECTION:
475 self._section = self._MY_H_SECTION
476 else:
477 # This will always be the fallback because we're not sure
478 # enough that the header is associated with this file.
479 self._section = self._OTHER_H_SECTION
480 else:
481 assert header_type == _OTHER_HEADER
482 self._section = self._OTHER_H_SECTION
483
484 if last_section != self._section:
485 self._last_header = ''
486
487 return ''
488
489
490class _CppLintState(object):
491 """Maintains module-wide state.."""
492
493 def __init__(self):
494 self.verbose_level = 1 # global setting.
495 self.error_count = 0 # global count of reported errors
496 # filters to apply when emitting error messages
497 self.filters = _DEFAULT_FILTERS[:]
498 self.counting = 'total' # In what way are we counting errors?
499 self.errors_by_category = {} # string to int dict storing error counts
500
501 # output format:
502 # "emacs" - format that emacs can parse (default)
503 # "vs7" - format that Microsoft Visual Studio 7 can parse
504 self.output_format = 'emacs'
505
506 def SetOutputFormat(self, output_format):
507 """Sets the output format for errors."""
508 self.output_format = output_format
509
510 def SetVerboseLevel(self, level):
511 """Sets the module's verbosity, and returns the previous setting."""
512 last_verbose_level = self.verbose_level
513 self.verbose_level = level
514 return last_verbose_level
515
516 def SetCountingStyle(self, counting_style):
517 """Sets the module's counting options."""
518 self.counting = counting_style
519
520 def SetFilters(self, filters):
521 """Sets the error-message filters.
522
523 These filters are applied when deciding whether to emit a given
524 error message.
525
526 Args:
527 filters: A string of comma-separated filters (eg "+whitespace/indent").
528 Each filter should start with + or -; else we die.
529
530 Raises:
531 ValueError: The comma-separated filters did not all start with '+' or '-'.
532 E.g. "-,+whitespace,-whitespace/indent,whitespace/badfilter"
533 """
534 # Default filters always have less priority than the flag ones.
535 self.filters = _DEFAULT_FILTERS[:]
536 for filt in filters.split(','):
537 clean_filt = filt.strip()
538 if clean_filt:
539 self.filters.append(clean_filt)
540 for filt in self.filters:
541 if not (filt.startswith('+') or filt.startswith('-')):
542 raise ValueError('Every filter in --filters must start with + or -'
543 ' (%s does not)' % filt)
544
545 def ResetErrorCounts(self):
546 """Sets the module's error statistic back to zero."""
547 self.error_count = 0
548 self.errors_by_category = {}
549
550 def IncrementErrorCount(self, category):
551 """Bumps the module's error statistic."""
552 self.error_count += 1
553 if self.counting in ('toplevel', 'detailed'):
554 if self.counting != 'detailed':
555 category = category.split('/')[0]
556 if category not in self.errors_by_category:
557 self.errors_by_category[category] = 0
558 self.errors_by_category[category] += 1
559
560 def PrintErrorCounts(self):
561 """Print a summary of errors by category, and the total."""
562 for category, count in self.errors_by_category.iteritems():
563 sys.stderr.write('Category \'%s\' errors found: %d\n' %
564 (category, count))
565 sys.stderr.write('Total errors found: %d\n' % self.error_count)
566
567_cpplint_state = _CppLintState()
568
569
570def _OutputFormat():
571 """Gets the module's output format."""
572 return _cpplint_state.output_format
573
574
575def _SetOutputFormat(output_format):
576 """Sets the module's output format."""
577 _cpplint_state.SetOutputFormat(output_format)
578
579
580def _VerboseLevel():
581 """Returns the module's verbosity setting."""
582 return _cpplint_state.verbose_level
583
584
585def _SetVerboseLevel(level):
586 """Sets the module's verbosity, and returns the previous setting."""
587 return _cpplint_state.SetVerboseLevel(level)
588
589
590def _SetCountingStyle(level):
591 """Sets the module's counting options."""
592 _cpplint_state.SetCountingStyle(level)
593
594
595def _Filters():
596 """Returns the module's list of output filters, as a list."""
597 return _cpplint_state.filters
598
599
600def _SetFilters(filters):
601 """Sets the module's error-message filters.
602
603 These filters are applied when deciding whether to emit a given
604 error message.
605
606 Args:
607 filters: A string of comma-separated filters (eg "whitespace/indent").
608 Each filter should start with + or -; else we die.
609 """
610 _cpplint_state.SetFilters(filters)
611
612
613class _FunctionState(object):
614 """Tracks current function name and the number of lines in its body."""
615
616 _NORMAL_TRIGGER = 250 # for --v=0, 500 for --v=1, etc.
617 _TEST_TRIGGER = 400 # about 50% more than _NORMAL_TRIGGER.
618
619 def __init__(self):
620 self.in_a_function = False
621 self.lines_in_function = 0
622 self.current_function = ''
623
624 def Begin(self, function_name):
625 """Start analyzing function body.
626
627 Args:
628 function_name: The name of the function being tracked.
629 """
630 self.in_a_function = True
631 self.lines_in_function = 0
632 self.current_function = function_name
633
634 def Count(self):
635 """Count line in current function body."""
636 if self.in_a_function:
637 self.lines_in_function += 1
638
639 def Check(self, error, filename, linenum):
640 """Report if too many lines in function body.
641
642 Args:
643 error: The function to call with any errors found.
644 filename: The name of the current file.
645 linenum: The number of the line to check.
646 """
647 if Match(r'T(EST|est)', self.current_function):
648 base_trigger = self._TEST_TRIGGER
649 else:
650 base_trigger = self._NORMAL_TRIGGER
651 trigger = base_trigger * 2**_VerboseLevel()
652
653 if self.lines_in_function > trigger:
654 error_level = int(math.log(self.lines_in_function / base_trigger, 2))
655 # 50 => 0, 100 => 1, 200 => 2, 400 => 3, 800 => 4, 1600 => 5, ...
656 if error_level > 5:
657 error_level = 5
658 error(filename, linenum, 'readability/fn_size', error_level,
659 'Small and focused functions are preferred:'
660 ' %s has %d non-comment lines'
661 ' (error triggered by exceeding %d lines).' % (
662 self.current_function, self.lines_in_function, trigger))
663
664 def End(self):
665 """Stop analizing function body."""
666 self.in_a_function = False
667
668
669class _IncludeError(Exception):
670 """Indicates a problem with the include order in a file."""
671 pass
672
673
674class FileInfo:
675 """Provides utility functions for filenames.
676
677 FileInfo provides easy access to the components of a file's path
678 relative to the project root.
679 """
680
681 def __init__(self, filename):
682 self._filename = filename
683
684 def FullName(self):
685 """Make Windows paths like Unix."""
686 return os.path.abspath(self._filename).replace('\\', '/')
687
688 def RepositoryName(self):
689 """FullName after removing the local path to the repository.
690
691 If we have a real absolute path name here we can try to do something smart:
692 detecting the root of the checkout and truncating /path/to/checkout from
693 the name so that we get header guards that don't include things like
694 "C:\Documents and Settings\..." or "/home/username/..." in them and thus
695 people on different computers who have checked the source out to different
696 locations won't see bogus errors.
697 """
698 fullname = self.FullName()
699
700 if os.path.exists(fullname):
701 project_dir = os.path.dirname(fullname)
702
703 if os.path.exists(os.path.join(project_dir, ".svn")):
704 # If there's a .svn file in the current directory, we recursively look
705 # up the directory tree for the top of the SVN checkout
706 root_dir = project_dir
707 one_up_dir = os.path.dirname(root_dir)
708 while os.path.exists(os.path.join(one_up_dir, ".svn")):
709 root_dir = os.path.dirname(root_dir)
710 one_up_dir = os.path.dirname(one_up_dir)
711
712 prefix = os.path.commonprefix([root_dir, project_dir])
713 return fullname[len(prefix) + 1:]
714
715 # Not SVN? Try to find a git or hg top level directory by searching up
716 # from the current path.
717 root_dir = os.path.dirname(fullname)
718 while (root_dir != os.path.dirname(root_dir) and
719 not os.path.exists(os.path.join(root_dir, ".git")) and
720 not os.path.exists(os.path.join(root_dir, ".hg"))):
721 root_dir = os.path.dirname(root_dir)
722
723 if (os.path.exists(os.path.join(root_dir, ".git")) or
724 os.path.exists(os.path.join(root_dir, ".hg"))):
725 prefix = os.path.commonprefix([root_dir, project_dir])
726 return fullname[len(prefix) + 1:]
727
728 # Don't know what to do; header guard warnings may be wrong...
729 return fullname
730
731 def Split(self):
732 """Splits the file into the directory, basename, and extension.
733
734 For 'chrome/browser/browser.cc', Split() would
735 return ('chrome/browser', 'browser', '.cc')
736
737 Returns:
738 A tuple of (directory, basename, extension).
739 """
740
741 googlename = self.RepositoryName()
742 project, rest = os.path.split(googlename)
743 return (project,) + os.path.splitext(rest)
744
745 def BaseName(self):
746 """File base name - text after the final slash, before the final period."""
747 return self.Split()[1]
748
749 def Extension(self):
750 """File extension - text following the final period."""
751 return self.Split()[2]
752
753 def NoExtension(self):
754 """File has no source file extension."""
755 return '/'.join(self.Split()[0:2])
756
757 def IsSource(self):
758 """File has a source file extension."""
759 return self.Extension()[1:] in ('c', 'cc', 'cpp', 'cxx')
760
761
762def _ShouldPrintError(category, confidence, linenum):
763 """Returns true iff confidence >= verbose, category passes
764 filter and is not NOLINT-suppressed."""
765
766 # There are three ways we might decide not to print an error message:
767 # a "NOLINT(category)" comment appears in the source,
768 # the verbosity level isn't high enough, or the filters filter it out.
769 if IsErrorSuppressedByNolint(category, linenum):
770 return False
771 if confidence < _cpplint_state.verbose_level:
772 return False
773
774 is_filtered = False
775 for one_filter in _Filters():
776 if one_filter.startswith('-'):
777 if category.startswith(one_filter[1:]):
778 is_filtered = True
779 elif one_filter.startswith('+'):
780 if category.startswith(one_filter[1:]):
781 is_filtered = False
782 else:
783 assert False # should have been checked for in SetFilter.
784 if is_filtered:
785 return False
786
787 return True
788
789
790def Error(filename, linenum, category, confidence, message):
791 """Logs the fact we've found a lint error.
792
793 We log where the error was found, and also our confidence in the error,
794 that is, how certain we are this is a legitimate style regression, and
795 not a misidentification or a use that's sometimes justified.
796
797 False positives can be suppressed by the use of
798 "cpplint(category)" comments on the offending line. These are
799 parsed into _error_suppressions.
800
801 Args:
802 filename: The name of the file containing the error.
803 linenum: The number of the line containing the error.
804 category: A string used to describe the "category" this bug
805 falls under: "whitespace", say, or "runtime". Categories
806 may have a hierarchy separated by slashes: "whitespace/indent".
807 confidence: A number from 1-5 representing a confidence score for
808 the error, with 5 meaning that we are certain of the problem,
809 and 1 meaning that it could be a legitimate construct.
810 message: The error message.
811 """
812 if _ShouldPrintError(category, confidence, linenum):
813 _cpplint_state.IncrementErrorCount(category)
814 if _cpplint_state.output_format == 'vs7':
815 sys.stderr.write('%s(%s): %s [%s] [%d]\n' % (
816 filename, linenum, message, category, confidence))
817 else:
818 sys.stderr.write('%s:%s: %s [%s] [%d]\n' % (
819 filename, linenum, message, category, confidence))
820
821
822# Matches standard C++ escape esequences per 2.13.2.3 of the C++ standard.
823_RE_PATTERN_CLEANSE_LINE_ESCAPES = re.compile(
824 r'\\([abfnrtv?"\\\']|\d+|x[0-9a-fA-F]+)')
825# Matches strings. Escape codes should already be removed by ESCAPES.
826_RE_PATTERN_CLEANSE_LINE_DOUBLE_QUOTES = re.compile(r'"[^"]*"')
827# Matches characters. Escape codes should already be removed by ESCAPES.
828_RE_PATTERN_CLEANSE_LINE_SINGLE_QUOTES = re.compile(r"'.'")
829# Matches multi-line C++ comments.
830# This RE is a little bit more complicated than one might expect, because we
831# have to take care of space removals tools so we can handle comments inside
832# statements better.
833# The current rule is: We only clear spaces from both sides when we're at the
834# end of the line. Otherwise, we try to remove spaces from the right side,
835# if this doesn't work we try on left side but only if there's a non-character
836# on the right.
837_RE_PATTERN_CLEANSE_LINE_C_COMMENTS = re.compile(
838 r"""(\s*/\*.*\*/\s*$|
839 /\*.*\*/\s+|
840 \s+/\*.*\*/(?=\W)|
841 /\*.*\*/)""", re.VERBOSE)
842
843
844def IsCppString(line):
845 """Does line terminate so, that the next symbol is in string constant.
846
847 This function does not consider single-line nor multi-line comments.
848
849 Args:
850 line: is a partial line of code starting from the 0..n.
851
852 Returns:
853 True, if next character appended to 'line' is inside a
854 string constant.
855 """
856
857 line = line.replace(r'\\', 'XX') # after this, \\" does not match to \"
858 return ((line.count('"') - line.count(r'\"') - line.count("'\"'")) & 1) == 1
859
860
861def FindNextMultiLineCommentStart(lines, lineix):
862 """Find the beginning marker for a multiline comment."""
863 while lineix < len(lines):
864 if lines[lineix].strip().startswith('/*'):
865 # Only return this marker if the comment goes beyond this line
866 if lines[lineix].strip().find('*/', 2) < 0:
867 return lineix
868 lineix += 1
869 return len(lines)
870
871
872def FindNextMultiLineCommentEnd(lines, lineix):
873 """We are inside a comment, find the end marker."""
874 while lineix < len(lines):
875 if lines[lineix].strip().endswith('*/'):
876 return lineix
877 lineix += 1
878 return len(lines)
879
880
881def RemoveMultiLineCommentsFromRange(lines, begin, end):
882 """Clears a range of lines for multi-line comments."""
883 # Having // dummy comments makes the lines non-empty, so we will not get
884 # unnecessary blank line warnings later in the code.
885 for i in range(begin, end):
886 lines[i] = '// dummy'
887
888
889def RemoveMultiLineComments(filename, lines, error):
890 """Removes multiline (c-style) comments from lines."""
891 lineix = 0
892 while lineix < len(lines):
893 lineix_begin = FindNextMultiLineCommentStart(lines, lineix)
894 if lineix_begin >= len(lines):
895 return
896 lineix_end = FindNextMultiLineCommentEnd(lines, lineix_begin)
897 if lineix_end >= len(lines):
898 error(filename, lineix_begin + 1, 'readability/multiline_comment', 5,
899 'Could not find end of multi-line comment')
900 return
901 RemoveMultiLineCommentsFromRange(lines, lineix_begin, lineix_end + 1)
902 lineix = lineix_end + 1
903
904
905def CleanseComments(line):
906 """Removes //-comments and single-line C-style /* */ comments.
907
908 Args:
909 line: A line of C++ source.
910
911 Returns:
912 The line with single-line comments removed.
913 """
914 commentpos = line.find('//')
915 if commentpos != -1 and not IsCppString(line[:commentpos]):
916 line = line[:commentpos]
917 # get rid of /* ... */
918 return _RE_PATTERN_CLEANSE_LINE_C_COMMENTS.sub('', line)
919
920
921class CleansedLines(object):
922 """Holds 3 copies of all lines with different preprocessing applied to them.
923
924 1) elided member contains lines without strings and comments,
925 2) lines member contains lines without comments, and
926 3) raw member contains all the lines without processing.
927 All these three members are of <type 'list'>, and of the same length.
928 """
929
930 def __init__(self, lines):
931 self.elided = []
932 self.lines = []
933 self.raw_lines = lines
934 self.num_lines = len(lines)
935 for linenum in range(len(lines)):
936 self.lines.append(CleanseComments(lines[linenum]))
937 elided = self._CollapseStrings(lines[linenum])
938 self.elided.append(CleanseComments(elided))
939
940 def NumLines(self):
941 """Returns the number of lines represented."""
942 return self.num_lines
943
944 @staticmethod
945 def _CollapseStrings(elided):
946 """Collapses strings and chars on a line to simple "" or '' blocks.
947
948 We nix strings first so we're not fooled by text like '"http://"'
949
950 Args:
951 elided: The line being processed.
952
953 Returns:
954 The line with collapsed strings.
955 """
956 if not _RE_PATTERN_INCLUDE.match(elided):
957 # Remove escaped characters first to make quote/single quote collapsing
958 # basic. Things that look like escaped characters shouldn't occur
959 # outside of strings and chars.
960 elided = _RE_PATTERN_CLEANSE_LINE_ESCAPES.sub('', elided)
961 elided = _RE_PATTERN_CLEANSE_LINE_SINGLE_QUOTES.sub("''", elided)
962 elided = _RE_PATTERN_CLEANSE_LINE_DOUBLE_QUOTES.sub('""', elided)
963 return elided
964
965
966def CloseExpression(clean_lines, linenum, pos):
967 """If input points to ( or { or [, finds the position that closes it.
968
969 If lines[linenum][pos] points to a '(' or '{' or '[', finds the the
970 linenum/pos that correspond to the closing of the expression.
971
972 Args:
973 clean_lines: A CleansedLines instance containing the file.
974 linenum: The number of the line to check.
975 pos: A position on the line.
976
977 Returns:
978 A tuple (line, linenum, pos) pointer *past* the closing brace, or
979 (line, len(lines), -1) if we never find a close. Note we ignore
980 strings and comments when matching; and the line we return is the
981 'cleansed' line at linenum.
982 """
983
984 line = clean_lines.elided[linenum]
985 startchar = line[pos]
986 if startchar not in '({[':
987 return (line, clean_lines.NumLines(), -1)
988 if startchar == '(': endchar = ')'
989 if startchar == '[': endchar = ']'
990 if startchar == '{': endchar = '}'
991
992 num_open = line.count(startchar) - line.count(endchar)
993 while linenum < clean_lines.NumLines() and num_open > 0:
994 linenum += 1
995 line = clean_lines.elided[linenum]
996 num_open += line.count(startchar) - line.count(endchar)
997 # OK, now find the endchar that actually got us back to even
998 endpos = len(line)
999 while num_open >= 0:
1000 endpos = line.rfind(')', 0, endpos)
1001 num_open -= 1 # chopped off another )
1002 return (line, linenum, endpos + 1)
1003
1004
1005def CheckForCopyright(filename, lines, error):
1006 """Logs an error if no Copyright message appears at the top of the file."""
1007
1008 # We'll say it should occur by line 10. Don't forget there's a
1009 # dummy line at the front.
1010 for line in xrange(1, min(len(lines), 11)):
1011 if re.search(r'Copyright', lines[line], re.I): break
1012 else: # means no copyright line was found
1013 error(filename, 0, 'legal/copyright', 5,
1014 'No copyright message found. '
1015 'You should have a line: "Copyright [year] <Copyright Owner>"')
1016
1017
1018def GetHeaderGuardCPPVariable(filename):
1019 """Returns the CPP variable that should be used as a header guard.
1020
1021 Args:
1022 filename: The name of a C++ header file.
1023
1024 Returns:
1025 The CPP variable that should be used as a header guard in the
1026 named file.
1027
1028 """
1029
1030 # Restores original filename in case that cpplint is invoked from Emacs's
1031 # flymake.
1032 filename = re.sub(r'_flymake\.h$', '.h', filename)
1033
1034 fileinfo = FileInfo(filename)
1035 return re.sub(r'[-./\s]', '_', fileinfo.RepositoryName()).upper() + '_'
1036
1037
1038def CheckForHeaderGuard(filename, lines, error):
1039 """Checks that the file contains a header guard.
1040
1041 Logs an error if no #ifndef header guard is present. For other
1042 headers, checks that the full pathname is used.
1043
1044 Args:
1045 filename: The name of the C++ header file.
1046 lines: An array of strings, each representing a line of the file.
1047 error: The function to call with any errors found.
1048 """
1049
1050 cppvar = GetHeaderGuardCPPVariable(filename)
1051
1052 ifndef = None
1053 ifndef_linenum = 0
1054 define = None
1055 endif = None
1056 endif_linenum = 0
1057 for linenum, line in enumerate(lines):
1058 linesplit = line.split()
1059 if len(linesplit) >= 2:
1060 # find the first occurrence of #ifndef and #define, save arg
1061 if not ifndef and linesplit[0] == '#ifndef':
1062 # set ifndef to the header guard presented on the #ifndef line.
1063 ifndef = linesplit[1]
1064 ifndef_linenum = linenum
1065 if not define and linesplit[0] == '#define':
1066 define = linesplit[1]
1067 # find the last occurrence of #endif, save entire line
1068 if line.startswith('#endif'):
1069 endif = line
1070 endif_linenum = linenum
1071
1072 if not ifndef or not define or ifndef != define:
1073 error(filename, 0, 'build/header_guard', 5,
1074 'No #ifndef header guard found, suggested CPP variable is: %s' %
1075 cppvar)
1076 return
1077
1078 # The guard should be PATH_FILE_H_, but we also allow PATH_FILE_H__
1079 # for backward compatibility.
1080 if ifndef != cppvar:
1081 error_level = 0
1082 if ifndef != cppvar + '_':
1083 error_level = 5
1084
1085 ParseNolintSuppressions(filename, lines[ifndef_linenum], ifndef_linenum,
1086 error)
1087 error(filename, ifndef_linenum, 'build/header_guard', error_level,
1088 '#ifndef header guard has wrong style, please use: %s' % cppvar)
1089
1090 if endif != ('#endif // %s' % cppvar):
1091 error_level = 0
1092 if endif != ('#endif // %s' % (cppvar + '_')):
1093 error_level = 5
1094
1095 ParseNolintSuppressions(filename, lines[endif_linenum], endif_linenum,
1096 error)
1097 error(filename, endif_linenum, 'build/header_guard', error_level,
1098 '#endif line should be "#endif // %s"' % cppvar)
1099
1100
1101def CheckForUnicodeReplacementCharacters(filename, lines, error):
1102 """Logs an error for each line containing Unicode replacement characters.
1103
1104 These indicate that either the file contained invalid UTF-8 (likely)
1105 or Unicode replacement characters (which it shouldn't). Note that
1106 it's possible for this to throw off line numbering if the invalid
1107 UTF-8 occurred adjacent to a newline.
1108
1109 Args:
1110 filename: The name of the current file.
1111 lines: An array of strings, each representing a line of the file.
1112 error: The function to call with any errors found.
1113 """
1114 for linenum, line in enumerate(lines):
1115 if u'\ufffd' in line:
1116 error(filename, linenum, 'readability/utf8', 5,
1117 'Line contains invalid UTF-8 (or Unicode replacement character).')
1118
1119
1120def CheckForNewlineAtEOF(filename, lines, error):
1121 """Logs an error if there is no newline char at the end of the file.
1122
1123 Args:
1124 filename: The name of the current file.
1125 lines: An array of strings, each representing a line of the file.
1126 error: The function to call with any errors found.
1127 """
1128
1129 # The array lines() was created by adding two newlines to the
1130 # original file (go figure), then splitting on \n.
1131 # To verify that the file ends in \n, we just have to make sure the
1132 # last-but-two element of lines() exists and is empty.
1133 if len(lines) < 3 or lines[-2]:
1134 error(filename, len(lines) - 2, 'whitespace/ending_newline', 5,
1135 'Could not find a newline character at the end of the file.')
1136
1137
1138def CheckForMultilineCommentsAndStrings(filename, clean_lines, linenum, error):
1139 """Logs an error if we see /* ... */ or "..." that extend past one line.
1140
1141 /* ... */ comments are legit inside macros, for one line.
1142 Otherwise, we prefer // comments, so it's ok to warn about the
1143 other. Likewise, it's ok for strings to extend across multiple
1144 lines, as long as a line continuation character (backslash)
1145 terminates each line. Although not currently prohibited by the C++
1146 style guide, it's ugly and unnecessary. We don't do well with either
1147 in this lint program, so we warn about both.
1148
1149 Args:
1150 filename: The name of the current file.
1151 clean_lines: A CleansedLines instance containing the file.
1152 linenum: The number of the line to check.
1153 error: The function to call with any errors found.
1154 """
1155 line = clean_lines.elided[linenum]
1156
1157 # Remove all \\ (escaped backslashes) from the line. They are OK, and the
1158 # second (escaped) slash may trigger later \" detection erroneously.
1159 line = line.replace('\\\\', '')
1160
1161 if line.count('/*') > line.count('*/'):
1162 error(filename, linenum, 'readability/multiline_comment', 5,
1163 'Complex multi-line /*...*/-style comment found. '
1164 'Lint may give bogus warnings. '
1165 'Consider replacing these with //-style comments, '
1166 'with #if 0...#endif, '
1167 'or with more clearly structured multi-line comments.')
1168
1169 if (line.count('"') - line.count('\\"')) % 2:
1170 error(filename, linenum, 'readability/multiline_string', 5,
1171 'Multi-line string ("...") found. This lint script doesn\'t '
1172 'do well with such strings, and may give bogus warnings. They\'re '
1173 'ugly and unnecessary, and you should use concatenation instead".')
1174
1175
1176threading_list = (
1177 ('asctime(', 'asctime_r('),
1178 ('ctime(', 'ctime_r('),
1179 ('getgrgid(', 'getgrgid_r('),
1180 ('getgrnam(', 'getgrnam_r('),
1181 ('getlogin(', 'getlogin_r('),
1182 ('getpwnam(', 'getpwnam_r('),
1183 ('getpwuid(', 'getpwuid_r('),
1184 ('gmtime(', 'gmtime_r('),
1185 ('localtime(', 'localtime_r('),
1186 ('rand(', 'rand_r('),
1187 ('readdir(', 'readdir_r('),
1188 ('strtok(', 'strtok_r('),
1189 ('ttyname(', 'ttyname_r('),
1190 )
1191
1192
1193def CheckPosixThreading(filename, clean_lines, linenum, error):
1194 """Checks for calls to thread-unsafe functions.
1195
1196 Much code has been originally written without consideration of
1197 multi-threading. Also, engineers are relying on their old experience;
1198 they have learned posix before threading extensions were added. These
1199 tests guide the engineers to use thread-safe functions (when using
1200 posix directly).
1201
1202 Args:
1203 filename: The name of the current file.
1204 clean_lines: A CleansedLines instance containing the file.
1205 linenum: The number of the line to check.
1206 error: The function to call with any errors found.
1207 """
1208 line = clean_lines.elided[linenum]
1209 for single_thread_function, multithread_safe_function in threading_list:
1210 ix = line.find(single_thread_function)
1211 # Comparisons made explicit for clarity -- pylint: disable-msg=C6403
1212 if ix >= 0 and (ix == 0 or (not line[ix - 1].isalnum() and
1213 line[ix - 1] not in ('_', '.', '>'))):
1214 error(filename, linenum, 'runtime/threadsafe_fn', 2,
1215 'Consider using ' + multithread_safe_function +
1216 '...) instead of ' + single_thread_function +
1217 '...) for improved thread safety.')
1218
1219
1220# Matches invalid increment: *count++, which moves pointer instead of
1221# incrementing a value.
1222_RE_PATTERN_INVALID_INCREMENT = re.compile(
1223 r'^\s*\*\w+(\+\+|--);')
1224
1225
1226def CheckInvalidIncrement(filename, clean_lines, linenum, error):
1227 """Checks for invalid increment *count++.
1228
1229 For example following function:
1230 void increment_counter(int* count) {
1231 *count++;
1232 }
1233 is invalid, because it effectively does count++, moving pointer, and should
1234 be replaced with ++*count, (*count)++ or *count += 1.
1235
1236 Args:
1237 filename: The name of the current file.
1238 clean_lines: A CleansedLines instance containing the file.
1239 linenum: The number of the line to check.
1240 error: The function to call with any errors found.
1241 """
1242 line = clean_lines.elided[linenum]
1243 if _RE_PATTERN_INVALID_INCREMENT.match(line):
1244 error(filename, linenum, 'runtime/invalid_increment', 5,
1245 'Changing pointer instead of value (or unused value of operator*).')
1246
1247
1248class _ClassInfo(object):
1249 """Stores information about a class."""
1250
1251 def __init__(self, name, linenum):
1252 self.name = name
1253 self.linenum = linenum
1254 self.seen_open_brace = False
1255 self.is_derived = False
1256 self.virtual_method_linenumber = None
1257 self.has_virtual_destructor = False
1258 self.brace_depth = 0
1259
1260
1261class _ClassState(object):
1262 """Holds the current state of the parse relating to class declarations.
1263
1264 It maintains a stack of _ClassInfos representing the parser's guess
1265 as to the current nesting of class declarations. The innermost class
1266 is at the top (back) of the stack. Typically, the stack will either
1267 be empty or have exactly one entry.
1268 """
1269
1270 def __init__(self):
1271 self.classinfo_stack = []
1272
1273 def CheckFinished(self, filename, error):
1274 """Checks that all classes have been completely parsed.
1275
1276 Call this when all lines in a file have been processed.
1277 Args:
1278 filename: The name of the current file.
1279 error: The function to call with any errors found.
1280 """
1281 if self.classinfo_stack:
1282 # Note: This test can result in false positives if #ifdef constructs
1283 # get in the way of brace matching. See the testBuildClass test in
1284 # cpplint_unittest.py for an example of this.
1285 error(filename, self.classinfo_stack[0].linenum, 'build/class', 5,
1286 'Failed to find complete declaration of class %s' %
1287 self.classinfo_stack[0].name)
1288
1289
1290def CheckForNonStandardConstructs(filename, clean_lines, linenum,
1291 class_state, error):
1292 """Logs an error if we see certain non-ANSI constructs ignored by gcc-2.
1293
1294 Complain about several constructs which gcc-2 accepts, but which are
1295 not standard C++. Warning about these in lint is one way to ease the
1296 transition to new compilers.
1297 - put storage class first (e.g. "static const" instead of "const static").
1298 - "%lld" instead of %qd" in printf-type functions.
1299 - "%1$d" is non-standard in printf-type functions.
1300 - "\%" is an undefined character escape sequence.
1301 - text after #endif is not allowed.
1302 - invalid inner-style forward declaration.
1303 - >? and <? operators, and their >?= and <?= cousins.
1304 - classes with virtual methods need virtual destructors (compiler warning
1305 available, but not turned on yet.)
1306
1307 Additionally, check for constructor/destructor style violations and reference
1308 members, as it is very convenient to do so while checking for
1309 gcc-2 compliance.
1310
1311 Args:
1312 filename: The name of the current file.
1313 clean_lines: A CleansedLines instance containing the file.
1314 linenum: The number of the line to check.
1315 class_state: A _ClassState instance which maintains information about
1316 the current stack of nested class declarations being parsed.
1317 error: A callable to which errors are reported, which takes 4 arguments:
1318 filename, line number, error level, and message
1319 """
1320
1321 # Remove comments from the line, but leave in strings for now.
1322 line = clean_lines.lines[linenum]
1323
1324 if Search(r'printf\s*\(.*".*%[-+ ]?\d*q', line):
1325 error(filename, linenum, 'runtime/printf_format', 3,
1326 '%q in format strings is deprecated. Use %ll instead.')
1327
1328 if Search(r'printf\s*\(.*".*%\d+\$', line):
1329 error(filename, linenum, 'runtime/printf_format', 2,
1330 '%N$ formats are unconventional. Try rewriting to avoid them.')
1331
1332 # Remove escaped backslashes before looking for undefined escapes.
1333 line = line.replace('\\\\', '')
1334
1335 if Search(r'("|\').*\\(%|\[|\(|{)', line):
1336 error(filename, linenum, 'build/printf_format', 3,
1337 '%, [, (, and { are undefined character escapes. Unescape them.')
1338
1339 # For the rest, work with both comments and strings removed.
1340 line = clean_lines.elided[linenum]
1341
1342 if Search(r'\b(const|volatile|void|char|short|int|long'
1343 r'|float|double|signed|unsigned'
1344 r'|schar|u?int8|u?int16|u?int32|u?int64)'
1345 r'\s+(auto|register|static|extern|typedef)\b',
1346 line):
1347 error(filename, linenum, 'build/storage_class', 5,
1348 'Storage class (static, extern, typedef, etc) should be first.')
1349
1350 if Match(r'\s*#\s*endif\s*[^/\s]+', line):
1351 error(filename, linenum, 'build/endif_comment', 5,
1352 'Uncommented text after #endif is non-standard. Use a comment.')
1353
1354 if Match(r'\s*class\s+(\w+\s*::\s*)+\w+\s*;', line):
1355 error(filename, linenum, 'build/forward_decl', 5,
1356 'Inner-style forward declarations are invalid. Remove this line.')
1357
1358 if Search(r'(\w+|[+-]?\d+(\.\d*)?)\s*(<|>)\?=?\s*(\w+|[+-]?\d+)(\.\d*)?',
1359 line):
1360 error(filename, linenum, 'build/deprecated', 3,
1361 '>? and <? (max and min) operators are non-standard and deprecated.')
1362
1363 if Search(r'^\s*const\s*string\s*&\s*\w+\s*;', line):
1364 # TODO(unknown): Could it be expanded safely to arbitrary references,
1365 # without triggering too many false positives? The first
1366 # attempt triggered 5 warnings for mostly benign code in the regtest, hence
1367 # the restriction.
1368 # Here's the original regexp, for the reference:
1369 # type_name = r'\w+((\s*::\s*\w+)|(\s*<\s*\w+?\s*>))?'
1370 # r'\s*const\s*' + type_name + '\s*&\s*\w+\s*;'
1371 error(filename, linenum, 'runtime/member_string_references', 2,
1372 'const string& members are dangerous. It is much better to use '
1373 'alternatives, such as pointers or simple constants.')
1374
1375 # Track class entry and exit, and attempt to find cases within the
1376 # class declaration that don't meet the C++ style
1377 # guidelines. Tracking is very dependent on the code matching Google
1378 # style guidelines, but it seems to perform well enough in testing
1379 # to be a worthwhile addition to the checks.
1380 classinfo_stack = class_state.classinfo_stack
1381 # Look for a class declaration
1382 class_decl_match = Match(
1383 r'\s*(template\s*<[\w\s<>,:]*>\s*)?(class|struct)\s+(\w+(::\w+)*)', line)
1384 if class_decl_match:
1385 classinfo_stack.append(_ClassInfo(class_decl_match.group(3), linenum))
1386
1387 # Everything else in this function uses the top of the stack if it's
1388 # not empty.
1389 if not classinfo_stack:
1390 return
1391
1392 classinfo = classinfo_stack[-1]
1393
1394 # If the opening brace hasn't been seen look for it and also
1395 # parent class declarations.
1396 if not classinfo.seen_open_brace:
1397 # If the line has a ';' in it, assume it's a forward declaration or
1398 # a single-line class declaration, which we won't process.
1399 if line.find(';') != -1:
1400 classinfo_stack.pop()
1401 return
1402 classinfo.seen_open_brace = (line.find('{') != -1)
1403 # Look for a bare ':'
1404 if Search('(^|[^:]):($|[^:])', line):
1405 classinfo.is_derived = True
1406 if not classinfo.seen_open_brace:
1407 return # Everything else in this function is for after open brace
1408
1409 # The class may have been declared with namespace or classname qualifiers.
1410 # The constructor and destructor will not have those qualifiers.
1411 base_classname = classinfo.name.split('::')[-1]
1412
1413 # Look for single-argument constructors that aren't marked explicit.
1414 # Technically a valid construct, but against style.
1415 args = Match(r'(?<!explicit)\s+%s\s*\(([^,()]+)\)'
1416 % re.escape(base_classname),
1417 line)
1418 if (args and
1419 args.group(1) != 'void' and
1420 not Match(r'(const\s+)?%s\s*&' % re.escape(base_classname),
1421 args.group(1).strip())):
1422 error(filename, linenum, 'runtime/explicit', 5,
1423 'Single-argument constructors should be marked explicit.')
1424
1425 # Look for methods declared virtual.
1426 if Search(r'\bvirtual\b', line):
1427 classinfo.virtual_method_linenumber = linenum
1428 # Only look for a destructor declaration on the same line. It would
1429 # be extremely unlikely for the destructor declaration to occupy
1430 # more than one line.
1431 if Search(r'~%s\s*\(' % base_classname, line):
1432 classinfo.has_virtual_destructor = True
1433
1434 # Look for class end.
1435 brace_depth = classinfo.brace_depth
1436 brace_depth = brace_depth + line.count('{') - line.count('}')
1437 if brace_depth <= 0:
1438 classinfo = classinfo_stack.pop()
1439 # Try to detect missing virtual destructor declarations.
1440 # For now, only warn if a non-derived class with virtual methods lacks
1441 # a virtual destructor. This is to make it less likely that people will
1442 # declare derived virtual destructors without declaring the base
1443 # destructor virtual.
1444 if ((classinfo.virtual_method_linenumber is not None) and
1445 (not classinfo.has_virtual_destructor) and
1446 (not classinfo.is_derived)): # Only warn for base classes
1447 error(filename, classinfo.linenum, 'runtime/virtual', 4,
1448 'The class %s probably needs a virtual destructor due to '
1449 'having virtual method(s), one declared at line %d.'
1450 % (classinfo.name, classinfo.virtual_method_linenumber))
1451 else:
1452 classinfo.brace_depth = brace_depth
1453
1454
1455def CheckSpacingForFunctionCall(filename, line, linenum, error):
1456 """Checks for the correctness of various spacing around function calls.
1457
1458 Args:
1459 filename: The name of the current file.
1460 line: The text of the line to check.
1461 linenum: The number of the line to check.
1462 error: The function to call with any errors found.
1463 """
1464
1465 # Since function calls often occur inside if/for/while/switch
1466 # expressions - which have their own, more liberal conventions - we
1467 # first see if we should be looking inside such an expression for a
1468 # function call, to which we can apply more strict standards.
1469 fncall = line # if there's no control flow construct, look at whole line
1470 for pattern in (r'\bif\s*\((.*)\)\s*{',
1471 r'\bfor\s*\((.*)\)\s*{',
1472 r'\bwhile\s*\((.*)\)\s*[{;]',
1473 r'\bswitch\s*\((.*)\)\s*{'):
1474 match = Search(pattern, line)
1475 if match:
1476 fncall = match.group(1) # look inside the parens for function calls
1477 break
1478
1479 # Except in if/for/while/switch, there should never be space
1480 # immediately inside parens (eg "f( 3, 4 )"). We make an exception
1481 # for nested parens ( (a+b) + c ). Likewise, there should never be
1482 # a space before a ( when it's a function argument. I assume it's a
1483 # function argument when the char before the whitespace is legal in
1484 # a function name (alnum + _) and we're not starting a macro. Also ignore
1485 # pointers and references to arrays and functions coz they're too tricky:
1486 # we use a very simple way to recognize these:
1487 # " (something)(maybe-something)" or
1488 # " (something)(maybe-something," or
1489 # " (something)[something]"
1490 # Note that we assume the contents of [] to be short enough that
1491 # they'll never need to wrap.
1492 if ( # Ignore control structures.
1493 not Search(r'\b(if|for|while|switch|return|delete)\b', fncall) and
1494 # Ignore pointers/references to functions.
1495 not Search(r' \([^)]+\)\([^)]*(\)|,$)', fncall) and
1496 # Ignore pointers/references to arrays.
1497 not Search(r' \([^)]+\)\[[^\]]+\]', fncall)):
1498 if Search(r'\w\s*\(\s(?!\s*\\$)', fncall): # a ( used for a fn call
1499 error(filename, linenum, 'whitespace/parens', 4,
1500 'Extra space after ( in function call')
1501 elif Search(r'\(\s+(?!(\s*\\)|\()', fncall):
1502 error(filename, linenum, 'whitespace/parens', 2,
1503 'Extra space after (')
1504 if (Search(r'\w\s+\(', fncall) and
1505 not Search(r'#\s*define|typedef', fncall)):
1506 error(filename, linenum, 'whitespace/parens', 4,
1507 'Extra space before ( in function call')
1508 # If the ) is followed only by a newline or a { + newline, assume it's
1509 # part of a control statement (if/while/etc), and don't complain
1510 if Search(r'[^)]\s+\)\s*[^{\s]', fncall):
1511 error(filename, linenum, 'whitespace/parens', 2,
1512 'Extra space before )')
1513
1514
1515def IsBlankLine(line):
1516 """Returns true if the given line is blank.
1517
1518 We consider a line to be blank if the line is empty or consists of
1519 only white spaces.
1520
1521 Args:
1522 line: A line of a string.
1523
1524 Returns:
1525 True, if the given line is blank.
1526 """
1527 return not line or line.isspace()
1528
1529
1530def CheckForFunctionLengths(filename, clean_lines, linenum,
1531 function_state, error):
1532 """Reports for long function bodies.
1533
1534 For an overview why this is done, see:
1535 http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Write_Short_Functions
1536
1537 Uses a simplistic algorithm assuming other style guidelines
1538 (especially spacing) are followed.
1539 Only checks unindented functions, so class members are unchecked.
1540 Trivial bodies are unchecked, so constructors with huge initializer lists
1541 may be missed.
1542 Blank/comment lines are not counted so as to avoid encouraging the removal
1543 of vertical space and commments just to get through a lint check.
1544 NOLINT *on the last line of a function* disables this check.
1545
1546 Args:
1547 filename: The name of the current file.
1548 clean_lines: A CleansedLines instance containing the file.
1549 linenum: The number of the line to check.
1550 function_state: Current function name and lines in body so far.
1551 error: The function to call with any errors found.
1552 """
1553 lines = clean_lines.lines
1554 line = lines[linenum]
1555 raw = clean_lines.raw_lines
1556 raw_line = raw[linenum]
1557 joined_line = ''
1558
1559 starting_func = False
1560 regexp = r'(\w(\w|::|\*|\&|\s)*)\(' # decls * & space::name( ...
1561 match_result = Match(regexp, line)
1562 if match_result:
1563 # If the name is all caps and underscores, figure it's a macro and
1564 # ignore it, unless it's TEST or TEST_F.
1565 function_name = match_result.group(1).split()[-1]
1566 if function_name == 'TEST' or function_name == 'TEST_F' or (
1567 not Match(r'[A-Z_]+$', function_name)):
1568 starting_func = True
1569
1570 if starting_func:
1571 body_found = False
1572 for start_linenum in xrange(linenum, clean_lines.NumLines()):
1573 start_line = lines[start_linenum]
1574 joined_line += ' ' + start_line.lstrip()
1575 if Search(r'(;|})', start_line): # Declarations and trivial functions
1576 body_found = True
1577 break # ... ignore
1578 elif Search(r'{', start_line):
1579 body_found = True
1580 function = Search(r'((\w|:)*)\(', line).group(1)
1581 if Match(r'TEST', function): # Handle TEST... macros
1582 parameter_regexp = Search(r'(\(.*\))', joined_line)
1583 if parameter_regexp: # Ignore bad syntax
1584 function += parameter_regexp.group(1)
1585 else:
1586 function += '()'
1587 function_state.Begin(function)
1588 break
1589 if not body_found:
1590 # No body for the function (or evidence of a non-function) was found.
1591 error(filename, linenum, 'readability/fn_size', 5,
1592 'Lint failed to find start of function body.')
1593 elif Match(r'^\}\s*$', line): # function end
1594 function_state.Check(error, filename, linenum)
1595 function_state.End()
1596 elif not Match(r'^\s*$', line):
1597 function_state.Count() # Count non-blank/non-comment lines.
1598
1599
1600_RE_PATTERN_TODO = re.compile(r'^//(\s*)TODO(\(.+?\))?:?(\s|$)?')
1601
1602
1603def CheckComment(comment, filename, linenum, error):
1604 """Checks for common mistakes in TODO comments.
1605
1606 Args:
1607 comment: The text of the comment from the line in question.
1608 filename: The name of the current file.
1609 linenum: The number of the line to check.
1610 error: The function to call with any errors found.
1611 """
1612 match = _RE_PATTERN_TODO.match(comment)
1613 if match:
1614 # One whitespace is correct; zero whitespace is handled elsewhere.
1615 leading_whitespace = match.group(1)
1616 if len(leading_whitespace) > 1:
1617 error(filename, linenum, 'whitespace/todo', 2,
1618 'Too many spaces before TODO')
1619
1620 username = match.group(2)
1621 if not username:
1622 error(filename, linenum, 'readability/todo', 2,
1623 'Missing username in TODO; it should look like '
1624 '"// TODO(my_username): Stuff."')
1625
1626 middle_whitespace = match.group(3)
1627 # Comparisons made explicit for correctness -- pylint: disable-msg=C6403
1628 if middle_whitespace != ' ' and middle_whitespace != '':
1629 error(filename, linenum, 'whitespace/todo', 2,
1630 'TODO(my_username) should be followed by a space')
1631
1632
1633def CheckSpacing(filename, clean_lines, linenum, error):
1634 """Checks for the correctness of various spacing issues in the code.
1635
1636 Things we check for: spaces around operators, spaces after
1637 if/for/while/switch, no spaces around parens in function calls, two
1638 spaces between code and comment, don't start a block with a blank
1639 line, don't end a function with a blank line, don't have too many
1640 blank lines in a row.
1641
1642 Args:
1643 filename: The name of the current file.
1644 clean_lines: A CleansedLines instance containing the file.
1645 linenum: The number of the line to check.
1646 error: The function to call with any errors found.
1647 """
1648
1649 raw = clean_lines.raw_lines
1650 line = raw[linenum]
1651
1652 # Before nixing comments, check if the line is blank for no good
1653 # reason. This includes the first line after a block is opened, and
1654 # blank lines at the end of a function (ie, right before a line like '}'
1655 if IsBlankLine(line):
1656 elided = clean_lines.elided
1657 prev_line = elided[linenum - 1]
1658 prevbrace = prev_line.rfind('{')
1659 # TODO(unknown): Don't complain if line before blank line, and line after,
1660 # both start with alnums and are indented the same amount.
1661 # This ignores whitespace at the start of a namespace block
1662 # because those are not usually indented.
1663 if (prevbrace != -1 and prev_line[prevbrace:].find('}') == -1
1664 and prev_line[:prevbrace].find('namespace') == -1):
1665 # OK, we have a blank line at the start of a code block. Before we
1666 # complain, we check if it is an exception to the rule: The previous
1667 # non-empty line has the paramters of a function header that are indented
1668 # 4 spaces (because they did not fit in a 80 column line when placed on
1669 # the same line as the function name). We also check for the case where
1670 # the previous line is indented 6 spaces, which may happen when the
1671 # initializers of a constructor do not fit into a 80 column line.
1672 exception = False
1673 if Match(r' {6}\w', prev_line): # Initializer list?
1674 # We are looking for the opening column of initializer list, which
1675 # should be indented 4 spaces to cause 6 space indentation afterwards.
1676 search_position = linenum-2
1677 while (search_position >= 0
1678 and Match(r' {6}\w', elided[search_position])):
1679 search_position -= 1
1680 exception = (search_position >= 0
1681 and elided[search_position][:5] == ' :')
1682 else:
1683 # Search for the function arguments or an initializer list. We use a
1684 # simple heuristic here: If the line is indented 4 spaces; and we have a
1685 # closing paren, without the opening paren, followed by an opening brace
1686 # or colon (for initializer lists) we assume that it is the last line of
1687 # a function header. If we have a colon indented 4 spaces, it is an
1688 # initializer list.
1689 exception = (Match(r' {4}\w[^\(]*\)\s*(const\s*)?(\{\s*$|:)',
1690 prev_line)
1691 or Match(r' {4}:', prev_line))
1692
1693 if not exception:
1694 error(filename, linenum, 'whitespace/blank_line', 2,
1695 'Blank line at the start of a code block. Is this needed?')
1696 # This doesn't ignore whitespace at the end of a namespace block
1697 # because that is too hard without pairing open/close braces;
1698 # however, a special exception is made for namespace closing
1699 # brackets which have a comment containing "namespace".
1700 #
1701 # Also, ignore blank lines at the end of a block in a long if-else
1702 # chain, like this:
1703 # if (condition1) {
1704 # // Something followed by a blank line
1705 #
1706 # } else if (condition2) {
1707 # // Something else
1708 # }
1709 if linenum + 1 < clean_lines.NumLines():
1710 next_line = raw[linenum + 1]
1711 if (next_line
1712 and Match(r'\s*}', next_line)
1713 and next_line.find('namespace') == -1
1714 and next_line.find('} else ') == -1):
1715 error(filename, linenum, 'whitespace/blank_line', 3,
1716 'Blank line at the end of a code block. Is this needed?')
1717
1718 # Next, we complain if there's a comment too near the text
1719 commentpos = line.find('//')
1720 if commentpos != -1:
1721 # Check if the // may be in quotes. If so, ignore it
1722 # Comparisons made explicit for clarity -- pylint: disable-msg=C6403
1723 if (line.count('"', 0, commentpos) -
1724 line.count('\\"', 0, commentpos)) % 2 == 0: # not in quotes
1725 # Allow one space for new scopes, two spaces otherwise:
1726 if (not Match(r'^\s*{ //', line) and
1727 ((commentpos >= 1 and
1728 line[commentpos-1] not in string.whitespace) or
1729 (commentpos >= 2 and
1730 line[commentpos-2] not in string.whitespace))):
1731 error(filename, linenum, 'whitespace/comments', 2,
1732 'At least two spaces is best between code and comments')
1733 # There should always be a space between the // and the comment
1734 commentend = commentpos + 2
1735 if commentend < len(line) and not line[commentend] == ' ':
1736 # but some lines are exceptions -- e.g. if they're big
1737 # comment delimiters like:
1738 # //----------------------------------------------------------
1739 # or are an empty C++ style Doxygen comment, like:
1740 # ///
1741 # or they begin with multiple slashes followed by a space:
1742 # //////// Header comment
1743 match = (Search(r'[=/-]{4,}\s*$', line[commentend:]) or
1744 Search(r'^/$', line[commentend:]) or
1745 Search(r'^/+ ', line[commentend:]))
1746 if not match:
1747 error(filename, linenum, 'whitespace/comments', 4,
1748 'Should have a space between // and comment')
1749 CheckComment(line[commentpos:], filename, linenum, error)
1750
1751 line = clean_lines.elided[linenum] # get rid of comments and strings
1752
1753 # Don't try to do spacing checks for operator methods
1754 line = re.sub(r'operator(==|!=|<|<<|<=|>=|>>|>)\(', 'operator\(', line)
1755
1756 # We allow no-spaces around = within an if: "if ( (a=Foo()) == 0 )".
1757 # Otherwise not. Note we only check for non-spaces on *both* sides;
1758 # sometimes people put non-spaces on one side when aligning ='s among
1759 # many lines (not that this is behavior that I approve of...)
1760 if Search(r'[\w.]=[\w.]', line) and not Search(r'\b(if|while) ', line):
1761 error(filename, linenum, 'whitespace/operators', 4,
1762 'Missing spaces around =')
1763
1764 # It's ok not to have spaces around binary operators like + - * /, but if
1765 # there's too little whitespace, we get concerned. It's hard to tell,
1766 # though, so we punt on this one for now. TODO.
1767
1768 # You should always have whitespace around binary operators.
1769 # Alas, we can't test < or > because they're legitimately used sans spaces
1770 # (a->b, vector<int> a). The only time we can tell is a < with no >, and
1771 # only if it's not template params list spilling into the next line.
1772 match = Search(r'[^<>=!\s](==|!=|<=|>=)[^<>=!\s]', line)
1773 if not match:
1774 # Note that while it seems that the '<[^<]*' term in the following
1775 # regexp could be simplified to '<.*', which would indeed match
1776 # the same class of strings, the [^<] means that searching for the
1777 # regexp takes linear rather than quadratic time.
1778 if not Search(r'<[^<]*,\s*$', line): # template params spill
1779 match = Search(r'[^<>=!\s](<)[^<>=!\s]([^>]|->)*$', line)
1780 if match:
1781 error(filename, linenum, 'whitespace/operators', 3,
1782 'Missing spaces around %s' % match.group(1))
1783 # We allow no-spaces around << and >> when used like this: 10<<20, but
1784 # not otherwise (particularly, not when used as streams)
1785 match = Search(r'[^0-9\s](<<|>>)[^0-9\s]', line)
1786 if match:
1787 error(filename, linenum, 'whitespace/operators', 3,
1788 'Missing spaces around %s' % match.group(1))
1789
1790 # There shouldn't be space around unary operators
1791 match = Search(r'(!\s|~\s|[\s]--[\s;]|[\s]\+\+[\s;])', line)
1792 if match:
1793 error(filename, linenum, 'whitespace/operators', 4,
1794 'Extra space for operator %s' % match.group(1))
1795
1796 # A pet peeve of mine: no spaces after an if, while, switch, or for
1797 match = Search(r' (if\(|for\(|while\(|switch\()', line)
1798 if match:
1799 error(filename, linenum, 'whitespace/parens', 5,
1800 'Missing space before ( in %s' % match.group(1))
1801
1802 # For if/for/while/switch, the left and right parens should be
1803 # consistent about how many spaces are inside the parens, and
1804 # there should either be zero or one spaces inside the parens.
1805 # We don't want: "if ( foo)" or "if ( foo )".
1806 # Exception: "for ( ; foo; bar)" and "for (foo; bar; )" are allowed.
1807 match = Search(r'\b(if|for|while|switch)\s*'
1808 r'\(([ ]*)(.).*[^ ]+([ ]*)\)\s*{\s*$',
1809 line)
1810 if match:
1811 if len(match.group(2)) != len(match.group(4)):
1812 if not (match.group(3) == ';' and
1813 len(match.group(2)) == 1 + len(match.group(4)) or
1814 not match.group(2) and Search(r'\bfor\s*\(.*; \)', line)):
1815 error(filename, linenum, 'whitespace/parens', 5,
1816 'Mismatching spaces inside () in %s' % match.group(1))
1817 if not len(match.group(2)) in [0, 1]:
1818 error(filename, linenum, 'whitespace/parens', 5,
1819 'Should have zero or one spaces inside ( and ) in %s' %
1820 match.group(1))
1821
1822 # You should always have a space after a comma (either as fn arg or operator)
1823 if Search(r',[^\s]', line):
1824 error(filename, linenum, 'whitespace/comma', 3,
1825 'Missing space after ,')
1826
1827 # Next we will look for issues with function calls.
1828 CheckSpacingForFunctionCall(filename, line, linenum, error)
1829
1830 # Except after an opening paren, you should have spaces before your braces.
1831 # And since you should never have braces at the beginning of a line, this is
1832 # an easy test.
1833 if Search(r'[^ (]{', line):
1834 error(filename, linenum, 'whitespace/braces', 5,
1835 'Missing space before {')
1836
1837 # Make sure '} else {' has spaces.
1838 if Search(r'}else', line):
1839 error(filename, linenum, 'whitespace/braces', 5,
1840 'Missing space before else')
1841
1842 # You shouldn't have spaces before your brackets, except maybe after
1843 # 'delete []' or 'new char * []'.
1844 if Search(r'\w\s+\[', line) and not Search(r'delete\s+\[', line):
1845 error(filename, linenum, 'whitespace/braces', 5,
1846 'Extra space before [')
1847
1848 # You shouldn't have a space before a semicolon at the end of the line.
1849 # There's a special case for "for" since the style guide allows space before
1850 # the semicolon there.
1851 if Search(r':\s*;\s*$', line):
1852 error(filename, linenum, 'whitespace/semicolon', 5,
1853 'Semicolon defining empty statement. Use { } instead.')
1854 elif Search(r'^\s*;\s*$', line):
1855 error(filename, linenum, 'whitespace/semicolon', 5,
1856 'Line contains only semicolon. If this should be an empty statement, '
1857 'use { } instead.')
1858 elif (Search(r'\s+;\s*$', line) and
1859 not Search(r'\bfor\b', line)):
1860 error(filename, linenum, 'whitespace/semicolon', 5,
1861 'Extra space before last semicolon. If this should be an empty '
1862 'statement, use { } instead.')
1863
1864
1865def GetPreviousNonBlankLine(clean_lines, linenum):
1866 """Return the most recent non-blank line and its line number.
1867
1868 Args:
1869 clean_lines: A CleansedLines instance containing the file contents.
1870 linenum: The number of the line to check.
1871
1872 Returns:
1873 A tuple with two elements. The first element is the contents of the last
1874 non-blank line before the current line, or the empty string if this is the
1875 first non-blank line. The second is the line number of that line, or -1
1876 if this is the first non-blank line.
1877 """
1878
1879 prevlinenum = linenum - 1
1880 while prevlinenum >= 0:
1881 prevline = clean_lines.elided[prevlinenum]
1882 if not IsBlankLine(prevline): # if not a blank line...
1883 return (prevline, prevlinenum)
1884 prevlinenum -= 1
1885 return ('', -1)
1886
1887
1888def CheckBraces(filename, clean_lines, linenum, error):
1889 """Looks for misplaced braces (e.g. at the end of line).
1890
1891 Args:
1892 filename: The name of the current file.
1893 clean_lines: A CleansedLines instance containing the file.
1894 linenum: The number of the line to check.
1895 error: The function to call with any errors found.
1896 """
1897
1898 line = clean_lines.elided[linenum] # get rid of comments and strings
1899
1900 if Match(r'\s*{\s*$', line):
1901 # We allow an open brace to start a line in the case where someone
1902 # is using braces in a block to explicitly create a new scope,
1903 # which is commonly used to control the lifetime of
1904 # stack-allocated variables. We don't detect this perfectly: we
1905 # just don't complain if the last non-whitespace character on the
1906 # previous non-blank line is ';', ':', '{', or '}'.
1907 prevline = GetPreviousNonBlankLine(clean_lines, linenum)[0]
1908 if not Search(r'[;:}{]\s*$', prevline):
1909 error(filename, linenum, 'whitespace/braces', 4,
1910 '{ should almost always be at the end of the previous line')
1911
1912 # An else clause should be on the same line as the preceding closing brace.
1913 if Match(r'\s*else\s*', line):
1914 prevline = GetPreviousNonBlankLine(clean_lines, linenum)[0]
1915 if Match(r'\s*}\s*$', prevline):
1916 error(filename, linenum, 'whitespace/newline', 4,
1917 'An else should appear on the same line as the preceding }')
1918
1919 # If braces come on one side of an else, they should be on both.
1920 # However, we have to worry about "else if" that spans multiple lines!
1921 if Search(r'}\s*else[^{]*$', line) or Match(r'[^}]*else\s*{', line):
1922 if Search(r'}\s*else if([^{]*)$', line): # could be multi-line if
1923 # find the ( after the if
1924 pos = line.find('else if')
1925 pos = line.find('(', pos)
1926 if pos > 0:
1927 (endline, _, endpos) = CloseExpression(clean_lines, linenum, pos)
1928 if endline[endpos:].find('{') == -1: # must be brace after if
1929 error(filename, linenum, 'readability/braces', 5,
1930 'If an else has a brace on one side, it should have it on both')
1931 else: # common case: else not followed by a multi-line if
1932 error(filename, linenum, 'readability/braces', 5,
1933 'If an else has a brace on one side, it should have it on both')
1934
1935 # Likewise, an else should never have the else clause on the same line
1936 if Search(r'\belse [^\s{]', line) and not Search(r'\belse if\b', line):
1937 error(filename, linenum, 'whitespace/newline', 4,
1938 'Else clause should never be on same line as else (use 2 lines)')
1939
1940 # In the same way, a do/while should never be on one line
1941 if Match(r'\s*do [^\s{]', line):
1942 error(filename, linenum, 'whitespace/newline', 4,
1943 'do/while clauses should not be on a single line')
1944
1945 # Braces shouldn't be followed by a ; unless they're defining a struct
1946 # or initializing an array.
1947 # We can't tell in general, but we can for some common cases.
1948 prevlinenum = linenum
1949 while True:
1950 (prevline, prevlinenum) = GetPreviousNonBlankLine(clean_lines, prevlinenum)
1951 if Match(r'\s+{.*}\s*;', line) and not prevline.count(';'):
1952 line = prevline + line
1953 else:
1954 break
1955 if (Search(r'{.*}\s*;', line) and
1956 line.count('{') == line.count('}') and
1957 not Search(r'struct|class|enum|\s*=\s*{', line)):
1958 error(filename, linenum, 'readability/braces', 4,
1959 "You don't need a ; after a }")
1960
1961
1962def ReplaceableCheck(operator, macro, line):
1963 """Determine whether a basic CHECK can be replaced with a more specific one.
1964
1965 For example suggest using CHECK_EQ instead of CHECK(a == b) and
1966 similarly for CHECK_GE, CHECK_GT, CHECK_LE, CHECK_LT, CHECK_NE.
1967
1968 Args:
1969 operator: The C++ operator used in the CHECK.
1970 macro: The CHECK or EXPECT macro being called.
1971 line: The current source line.
1972
1973 Returns:
1974 True if the CHECK can be replaced with a more specific one.
1975 """
1976
1977 # This matches decimal and hex integers, strings, and chars (in that order).
1978 match_constant = r'([-+]?(\d+|0[xX][0-9a-fA-F]+)[lLuU]{0,3}|".*"|\'.*\')'
1979
1980 # Expression to match two sides of the operator with something that
1981 # looks like a literal, since CHECK(x == iterator) won't compile.
1982 # This means we can't catch all the cases where a more specific
1983 # CHECK is possible, but it's less annoying than dealing with
1984 # extraneous warnings.
1985 match_this = (r'\s*' + macro + r'\((\s*' +
1986 match_constant + r'\s*' + operator + r'[^<>].*|'
1987 r'.*[^<>]' + operator + r'\s*' + match_constant +
1988 r'\s*\))')
1989
1990 # Don't complain about CHECK(x == NULL) or similar because
1991 # CHECK_EQ(x, NULL) won't compile (requires a cast).
1992 # Also, don't complain about more complex boolean expressions
1993 # involving && or || such as CHECK(a == b || c == d).
1994 return Match(match_this, line) and not Search(r'NULL|&&|\|\|', line)
1995
1996
1997def CheckCheck(filename, clean_lines, linenum, error):
1998 """Checks the use of CHECK and EXPECT macros.
1999
2000 Args:
2001 filename: The name of the current file.
2002 clean_lines: A CleansedLines instance containing the file.
2003 linenum: The number of the line to check.
2004 error: The function to call with any errors found.
2005 """
2006
2007 # Decide the set of replacement macros that should be suggested
2008 raw_lines = clean_lines.raw_lines
2009 current_macro = ''
2010 for macro in _CHECK_MACROS:
2011 if raw_lines[linenum].find(macro) >= 0:
2012 current_macro = macro
2013 break
2014 if not current_macro:
2015 # Don't waste time here if line doesn't contain 'CHECK' or 'EXPECT'
2016 return
2017
2018 line = clean_lines.elided[linenum] # get rid of comments and strings
2019
2020 # Encourage replacing plain CHECKs with CHECK_EQ/CHECK_NE/etc.
2021 for operator in ['==', '!=', '>=', '>', '<=', '<']:
2022 if ReplaceableCheck(operator, current_macro, line):
2023 error(filename, linenum, 'readability/check', 2,
2024 'Consider using %s instead of %s(a %s b)' % (
2025 _CHECK_REPLACEMENT[current_macro][operator],
2026 current_macro, operator))
2027 break
2028
2029
2030def GetLineWidth(line):
2031 """Determines the width of the line in column positions.
2032
2033 Args:
2034 line: A string, which may be a Unicode string.
2035
2036 Returns:
2037 The width of the line in column positions, accounting for Unicode
2038 combining characters and wide characters.
2039 """
2040 if isinstance(line, unicode):
2041 width = 0
2042 for c in unicodedata.normalize('NFC', line):
2043 if unicodedata.east_asian_width(c) in ('W', 'F'):
2044 width += 2
2045 elif not unicodedata.combining(c):
2046 width += 1
2047 return width
2048 else:
2049 return len(line)
2050
2051
2052def CheckStyle(filename, clean_lines, linenum, file_extension, error):
2053 """Checks rules from the 'C++ style rules' section of cppguide.html.
2054
2055 Most of these rules are hard to test (naming, comment style), but we
2056 do what we can. In particular we check for 2-space indents, line lengths,
2057 tab usage, spaces inside code, etc.
2058
2059 Args:
2060 filename: The name of the current file.
2061 clean_lines: A CleansedLines instance containing the file.
2062 linenum: The number of the line to check.
2063 file_extension: The extension (without the dot) of the filename.
2064 error: The function to call with any errors found.
2065 """
2066
2067 raw_lines = clean_lines.raw_lines
2068 line = raw_lines[linenum]
2069
2070 if line.find('\t') != -1:
2071 error(filename, linenum, 'whitespace/tab', 1,
2072 'Tab found; better to use spaces')
2073
2074 # One or three blank spaces at the beginning of the line is weird; it's
2075 # hard to reconcile that with 2-space indents.
2076 # NOTE: here are the conditions rob pike used for his tests. Mine aren't
2077 # as sophisticated, but it may be worth becoming so: RLENGTH==initial_spaces
2078 # if(RLENGTH > 20) complain = 0;
2079 # if(match($0, " +(error|private|public|protected):")) complain = 0;
2080 # if(match(prev, "&& *$")) complain = 0;
2081 # if(match(prev, "\\|\\| *$")) complain = 0;
2082 # if(match(prev, "[\",=><] *$")) complain = 0;
2083 # if(match($0, " <<")) complain = 0;
2084 # if(match(prev, " +for \\(")) complain = 0;
2085 # if(prevodd && match(prevprev, " +for \\(")) complain = 0;
2086 initial_spaces = 0
2087 cleansed_line = clean_lines.elided[linenum]
2088 while initial_spaces < len(line) and line[initial_spaces] == ' ':
2089 initial_spaces += 1
2090 if line and line[-1].isspace():
2091 error(filename, linenum, 'whitespace/end_of_line', 4,
2092 'Line ends in whitespace. Consider deleting these extra spaces.')
2093 # There are certain situations we allow one space, notably for labels
2094 elif ((initial_spaces == 1 or initial_spaces == 3) and
2095 not Match(r'\s*\w+\s*:\s*$', cleansed_line)):
2096 error(filename, linenum, 'whitespace/indent', 3,
2097 'Weird number of spaces at line-start. '
2098 'Are you using a 2-space indent?')
2099 # Labels should always be indented at least one space.
2100 elif not initial_spaces and line[:2] != '//' and Search(r'[^:]:\s*$',
2101 line):
2102 error(filename, linenum, 'whitespace/labels', 4,
2103 'Labels should always be indented at least one space. '
2104 'If this is a member-initializer list in a constructor or '
2105 'the base class list in a class definition, the colon should '
2106 'be on the following line.')
2107
2108
2109 # Check if the line is a header guard.
2110 is_header_guard = False
2111 if file_extension == 'h':
2112 cppvar = GetHeaderGuardCPPVariable(filename)
2113 if (line.startswith('#ifndef %s' % cppvar) or
2114 line.startswith('#define %s' % cppvar) or
2115 line.startswith('#endif // %s' % cppvar)):
2116 is_header_guard = True
2117 # #include lines and header guards can be long, since there's no clean way to
2118 # split them.
2119 #
2120 # URLs can be long too. It's possible to split these, but it makes them
2121 # harder to cut&paste.
2122 if (not line.startswith('#include') and not is_header_guard and
2123 not Match(r'^\s*//.*http(s?)://\S*$', line)):
2124 line_width = GetLineWidth(line)
2125 if line_width > 100:
2126 error(filename, linenum, 'whitespace/line_length', 4,
2127 'Lines should very rarely be longer than 100 characters')
2128 elif line_width > 80:
2129 error(filename, linenum, 'whitespace/line_length', 2,
2130 'Lines should be <= 80 characters long')
2131
2132 if (cleansed_line.count(';') > 1 and
2133 # for loops are allowed two ;'s (and may run over two lines).
2134 cleansed_line.find('for') == -1 and
2135 (GetPreviousNonBlankLine(clean_lines, linenum)[0].find('for') == -1 or
2136 GetPreviousNonBlankLine(clean_lines, linenum)[0].find(';') != -1) and
2137 # It's ok to have many commands in a switch case that fits in 1 line
2138 not ((cleansed_line.find('case ') != -1 or
2139 cleansed_line.find('default:') != -1) and
2140 cleansed_line.find('break;') != -1)):
2141 error(filename, linenum, 'whitespace/newline', 4,
2142 'More than one command on the same line')
2143
2144 # Some more style checks
2145 CheckBraces(filename, clean_lines, linenum, error)
2146 CheckSpacing(filename, clean_lines, linenum, error)
2147 CheckCheck(filename, clean_lines, linenum, error)
2148
2149
2150_RE_PATTERN_INCLUDE_NEW_STYLE = re.compile(r'#include +"[^/]+\.h"')
2151_RE_PATTERN_INCLUDE = re.compile(r'^\s*#\s*include\s*([<"])([^>"]*)[>"].*$')
2152# Matches the first component of a filename delimited by -s and _s. That is:
2153# _RE_FIRST_COMPONENT.match('foo').group(0) == 'foo'
2154# _RE_FIRST_COMPONENT.match('foo.cc').group(0) == 'foo'
2155# _RE_FIRST_COMPONENT.match('foo-bar_baz.cc').group(0) == 'foo'
2156# _RE_FIRST_COMPONENT.match('foo_bar-baz.cc').group(0) == 'foo'
2157_RE_FIRST_COMPONENT = re.compile(r'^[^-_.]+')
2158
2159
2160def _DropCommonSuffixes(filename):
2161 """Drops common suffixes like _test.cc or -inl.h from filename.
2162
2163 For example:
2164 >>> _DropCommonSuffixes('foo/foo-inl.h')
2165 'foo/foo'
2166 >>> _DropCommonSuffixes('foo/bar/foo.cc')
2167 'foo/bar/foo'
2168 >>> _DropCommonSuffixes('foo/foo_internal.h')
2169 'foo/foo'
2170 >>> _DropCommonSuffixes('foo/foo_unusualinternal.h')
2171 'foo/foo_unusualinternal'
2172
2173 Args:
2174 filename: The input filename.
2175
2176 Returns:
2177 The filename with the common suffix removed.
2178 """
2179 for suffix in ('test.cc', 'regtest.cc', 'unittest.cc',
2180 'inl.h', 'impl.h', 'internal.h'):
2181 if (filename.endswith(suffix) and len(filename) > len(suffix) and
2182 filename[-len(suffix) - 1] in ('-', '_')):
2183 return filename[:-len(suffix) - 1]
2184 return os.path.splitext(filename)[0]
2185
2186
2187def _IsTestFilename(filename):
2188 """Determines if the given filename has a suffix that identifies it as a test.
2189
2190 Args:
2191 filename: The input filename.
2192
2193 Returns:
2194 True if 'filename' looks like a test, False otherwise.
2195 """
2196 if (filename.endswith('_test.cc') or
2197 filename.endswith('_unittest.cc') or
2198 filename.endswith('_regtest.cc')):
2199 return True
2200 else:
2201 return False
2202
2203
2204def _ClassifyInclude(fileinfo, include, is_system):
2205 """Figures out what kind of header 'include' is.
2206
2207 Args:
2208 fileinfo: The current file cpplint is running over. A FileInfo instance.
2209 include: The path to a #included file.
2210 is_system: True if the #include used <> rather than "".
2211
2212 Returns:
2213 One of the _XXX_HEADER constants.
2214
2215 For example:
2216 >>> _ClassifyInclude(FileInfo('foo/foo.cc'), 'stdio.h', True)
2217 _C_SYS_HEADER
2218 >>> _ClassifyInclude(FileInfo('foo/foo.cc'), 'string', True)
2219 _CPP_SYS_HEADER
2220 >>> _ClassifyInclude(FileInfo('foo/foo.cc'), 'foo/foo.h', False)
2221 _LIKELY_MY_HEADER
2222 >>> _ClassifyInclude(FileInfo('foo/foo_unknown_extension.cc'),
2223 ... 'bar/foo_other_ext.h', False)
2224 _POSSIBLE_MY_HEADER
2225 >>> _ClassifyInclude(FileInfo('foo/foo.cc'), 'foo/bar.h', False)
2226 _OTHER_HEADER
2227 """
2228 # This is a list of all standard c++ header files, except
2229 # those already checked for above.
2230 is_stl_h = include in _STL_HEADERS
2231 is_cpp_h = is_stl_h or include in _CPP_HEADERS
2232
2233 if is_system:
2234 if is_cpp_h:
2235 return _CPP_SYS_HEADER
2236 else:
2237 return _C_SYS_HEADER
2238
2239 # If the target file and the include we're checking share a
2240 # basename when we drop common extensions, and the include
2241 # lives in . , then it's likely to be owned by the target file.
2242 target_dir, target_base = (
2243 os.path.split(_DropCommonSuffixes(fileinfo.RepositoryName())))
2244 include_dir, include_base = os.path.split(_DropCommonSuffixes(include))
2245 if target_base == include_base and (
2246 include_dir == target_dir or
2247 include_dir == os.path.normpath(target_dir + '/../public')):
2248 return _LIKELY_MY_HEADER
2249
2250 # If the target and include share some initial basename
2251 # component, it's possible the target is implementing the
2252 # include, so it's allowed to be first, but we'll never
2253 # complain if it's not there.
2254 target_first_component = _RE_FIRST_COMPONENT.match(target_base)
2255 include_first_component = _RE_FIRST_COMPONENT.match(include_base)
2256 if (target_first_component and include_first_component and
2257 target_first_component.group(0) ==
2258 include_first_component.group(0)):
2259 return _POSSIBLE_MY_HEADER
2260
2261 return _OTHER_HEADER
2262
2263
2264
2265def CheckIncludeLine(filename, clean_lines, linenum, include_state, error):
2266 """Check rules that are applicable to #include lines.
2267
2268 Strings on #include lines are NOT removed from elided line, to make
2269 certain tasks easier. However, to prevent false positives, checks
2270 applicable to #include lines in CheckLanguage must be put here.
2271
2272 Args:
2273 filename: The name of the current file.
2274 clean_lines: A CleansedLines instance containing the file.
2275 linenum: The number of the line to check.
2276 include_state: An _IncludeState instance in which the headers are inserted.
2277 error: The function to call with any errors found.
2278 """
2279 fileinfo = FileInfo(filename)
2280
2281 line = clean_lines.lines[linenum]
2282
2283 # "include" should use the new style "foo/bar.h" instead of just "bar.h"
2284 if _RE_PATTERN_INCLUDE_NEW_STYLE.search(line):
2285 error(filename, linenum, 'build/include', 4,
2286 'Include the directory when naming .h files')
2287
2288 # we shouldn't include a file more than once. actually, there are a
2289 # handful of instances where doing so is okay, but in general it's
2290 # not.
2291 match = _RE_PATTERN_INCLUDE.search(line)
2292 if match:
2293 include = match.group(2)
2294 is_system = (match.group(1) == '<')
2295 if include in include_state:
2296 error(filename, linenum, 'build/include', 4,
2297 '"%s" already included at %s:%s' %
2298 (include, filename, include_state[include]))
2299 else:
2300 include_state[include] = linenum
2301
2302 # We want to ensure that headers appear in the right order:
2303 # 1) for foo.cc, foo.h (preferred location)
2304 # 2) c system files
2305 # 3) cpp system files
2306 # 4) for foo.cc, foo.h (deprecated location)
2307 # 5) other google headers
2308 #
2309 # We classify each include statement as one of those 5 types
2310 # using a number of techniques. The include_state object keeps
2311 # track of the highest type seen, and complains if we see a
2312 # lower type after that.
2313 error_message = include_state.CheckNextIncludeOrder(
2314 _ClassifyInclude(fileinfo, include, is_system))
2315 if error_message:
2316 error(filename, linenum, 'build/include_order', 4,
2317 '%s. Should be: %s.h, c system, c++ system, other.' %
2318 (error_message, fileinfo.BaseName()))
2319 if not include_state.IsInAlphabeticalOrder(include):
2320 error(filename, linenum, 'build/include_alpha', 4,
2321 'Include "%s" not in alphabetical order' % include)
2322
2323 # Look for any of the stream classes that are part of standard C++.
2324 match = _RE_PATTERN_INCLUDE.match(line)
2325 if match:
2326 include = match.group(2)
2327 if Match(r'(f|ind|io|i|o|parse|pf|stdio|str|)?stream$', include):
2328 # Many unit tests use cout, so we exempt them.
2329 if not _IsTestFilename(filename):
2330 error(filename, linenum, 'readability/streams', 3,
2331 'Streams are highly discouraged.')
2332
2333def CheckLanguage(filename, clean_lines, linenum, file_extension, include_state,
2334 error):
2335 """Checks rules from the 'C++ language rules' section of cppguide.html.
2336
2337 Some of these rules are hard to test (function overloading, using
2338 uint32 inappropriately), but we do the best we can.
2339
2340 Args:
2341 filename: The name of the current file.
2342 clean_lines: A CleansedLines instance containing the file.
2343 linenum: The number of the line to check.
2344 file_extension: The extension (without the dot) of the filename.
2345 include_state: An _IncludeState instance in which the headers are inserted.
2346 error: The function to call with any errors found.
2347 """
2348 # If the line is empty or consists of entirely a comment, no need to
2349 # check it.
2350 line = clean_lines.elided[linenum]
2351 if not line:
2352 return
2353
2354 match = _RE_PATTERN_INCLUDE.search(line)
2355 if match:
2356 CheckIncludeLine(filename, clean_lines, linenum, include_state, error)
2357 return
2358
2359 # Create an extended_line, which is the concatenation of the current and
2360 # next lines, for more effective checking of code that may span more than one
2361 # line.
2362 if linenum + 1 < clean_lines.NumLines():
2363 extended_line = line + clean_lines.elided[linenum + 1]
2364 else:
2365 extended_line = line
2366
2367 # Make Windows paths like Unix.
2368 fullname = os.path.abspath(filename).replace('\\', '/')
2369
2370 # TODO(unknown): figure out if they're using default arguments in fn proto.
2371
2372 # Check for non-const references in functions. This is tricky because &
2373 # is also used to take the address of something. We allow <> for templates,
2374 # (ignoring whatever is between the braces) and : for classes.
2375 # These are complicated re's. They try to capture the following:
2376 # paren (for fn-prototype start), typename, &, varname. For the const
2377 # version, we're willing for const to be before typename or after
2378 # Don't check the implemention on same line.
2379 fnline = line.split('{', 1)[0]
2380 if (len(re.findall(r'\([^()]*\b(?:[\w:]|<[^()]*>)+(\s?&|&\s?)\w+', fnline)) >
2381 len(re.findall(r'\([^()]*\bconst\s+(?:typename\s+)?(?:struct\s+)?'
2382 r'(?:[\w:]|<[^()]*>)+(\s?&|&\s?)\w+', fnline)) +
2383 len(re.findall(r'\([^()]*\b(?:[\w:]|<[^()]*>)+\s+const(\s?&|&\s?)[\w]+',
2384 fnline))):
2385
2386 # We allow non-const references in a few standard places, like functions
2387 # called "swap()" or iostream operators like "<<" or ">>".
2388 if not Search(
2389 r'(swap|Swap|operator[<>][<>])\s*\(\s*(?:[\w:]|<.*>)+\s*&',
2390 fnline):
2391 error(filename, linenum, 'runtime/references', 2,
2392 'Is this a non-const reference? '
2393 'If so, make const or use a pointer.')
2394
2395 # Check to see if they're using an conversion function cast.
2396 # I just try to capture the most common basic types, though there are more.
2397 # Parameterless conversion functions, such as bool(), are allowed as they are
2398 # probably a member operator declaration or default constructor.
2399 match = Search(
2400 r'(\bnew\s+)?\b' # Grab 'new' operator, if it's there
2401 r'(int|float|double|bool|char|int32|uint32|int64|uint64)\([^)]', line)
2402 if match:
2403 # gMock methods are defined using some variant of MOCK_METHODx(name, type)
2404 # where type may be float(), int(string), etc. Without context they are
2405 # virtually indistinguishable from int(x) casts.
2406 if (match.group(1) is None and # If new operator, then this isn't a cast
2407 not Match(r'^\s*MOCK_(CONST_)?METHOD\d+(_T)?\(', line)):
2408 error(filename, linenum, 'readability/casting', 4,
2409 'Using deprecated casting style. '
2410 'Use static_cast<%s>(...) instead' %
2411 match.group(2))
2412
2413 CheckCStyleCast(filename, linenum, line, clean_lines.raw_lines[linenum],
2414 'static_cast',
2415 r'\((int|float|double|bool|char|u?int(16|32|64))\)',
2416 error)
2417 # This doesn't catch all cases. Consider (const char * const)"hello".
2418 CheckCStyleCast(filename, linenum, line, clean_lines.raw_lines[linenum],
2419 'reinterpret_cast', r'\((\w+\s?\*+\s?)\)', error)
2420
2421 # In addition, we look for people taking the address of a cast. This
2422 # is dangerous -- casts can assign to temporaries, so the pointer doesn't
2423 # point where you think.
2424 if Search(
2425 r'(&\([^)]+\)[\w(])|(&(static|dynamic|reinterpret)_cast\b)', line):
2426 error(filename, linenum, 'runtime/casting', 4,
2427 ('Are you taking an address of a cast? '
2428 'This is dangerous: could be a temp var. '
2429 'Take the address before doing the cast, rather than after'))
2430
2431 # Check for people declaring static/global STL strings at the top level.
2432 # This is dangerous because the C++ language does not guarantee that
2433 # globals with constructors are initialized before the first access.
2434 match = Match(
2435 r'((?:|static +)(?:|const +))string +([a-zA-Z0-9_:]+)\b(.*)',
2436 line)
2437 # Make sure it's not a function.
2438 # Function template specialization looks like: "string foo<Type>(...".
2439 # Class template definitions look like: "string Foo<Type>::Method(...".
2440 if match and not Match(r'\s*(<.*>)?(::[a-zA-Z0-9_]+)?\s*\(([^"]|$)',
2441 match.group(3)):
2442 error(filename, linenum, 'runtime/string', 4,
2443 'For a static/global string constant, use a C style string instead: '
2444 '"%schar %s[]".' %
2445 (match.group(1), match.group(2)))
2446
2447 # Check that we're not using RTTI outside of testing code.
2448 if Search(r'\bdynamic_cast<', line) and not _IsTestFilename(filename):
2449 error(filename, linenum, 'runtime/rtti', 5,
2450 'Do not use dynamic_cast<>. If you need to cast within a class '
2451 "hierarchy, use static_cast<> to upcast. Google doesn't support "
2452 'RTTI.')
2453
2454 if Search(r'\b([A-Za-z0-9_]*_)\(\1\)', line):
2455 error(filename, linenum, 'runtime/init', 4,
2456 'You seem to be initializing a member variable with itself.')
2457
2458 if file_extension == 'h':
2459 # TODO(unknown): check that 1-arg constructors are explicit.
2460 # How to tell it's a constructor?
2461 # (handled in CheckForNonStandardConstructs for now)
2462 # TODO(unknown): check that classes have DISALLOW_EVIL_CONSTRUCTORS
2463 # (level 1 error)
2464 pass
2465
2466 # Check if people are using the verboten C basic types. The only exception
2467 # we regularly allow is "unsigned short port" for port.
2468 if Search(r'\bshort port\b', line):
2469 if not Search(r'\bunsigned short port\b', line):
2470 error(filename, linenum, 'runtime/int', 4,
2471 'Use "unsigned short" for ports, not "short"')
2472 else:
2473 match = Search(r'\b(short|long(?! +double)|long long)\b', line)
2474 if match:
2475 error(filename, linenum, 'runtime/int', 4,
2476 'Use int16/int64/etc, rather than the C type %s' % match.group(1))
2477
2478 # When snprintf is used, the second argument shouldn't be a literal.
2479 match = Search(r'snprintf\s*\(([^,]*),\s*([0-9]*)\s*,', line)
2480 if match and match.group(2) != '0':
2481 # If 2nd arg is zero, snprintf is used to calculate size.
2482 error(filename, linenum, 'runtime/printf', 3,
2483 'If you can, use sizeof(%s) instead of %s as the 2nd arg '
2484 'to snprintf.' % (match.group(1), match.group(2)))
2485
2486 # Check if some verboten C functions are being used.
2487 if Search(r'\bsprintf\b', line):
2488 error(filename, linenum, 'runtime/printf', 5,
2489 'Never use sprintf. Use snprintf instead.')
2490 match = Search(r'\b(strcpy|strcat)\b', line)
2491 if match:
2492 error(filename, linenum, 'runtime/printf', 4,
2493 'Almost always, snprintf is better than %s' % match.group(1))
2494
2495 if Search(r'\bsscanf\b', line):
2496 error(filename, linenum, 'runtime/printf', 1,
2497 'sscanf can be ok, but is slow and can overflow buffers.')
2498
2499 # Check if some verboten operator overloading is going on
2500 # TODO(unknown): catch out-of-line unary operator&:
2501 # class X {};
2502 # int operator&(const X& x) { return 42; } // unary operator&
2503 # The trick is it's hard to tell apart from binary operator&:
2504 # class Y { int operator&(const Y& x) { return 23; } }; // binary operator&
2505 if Search(r'\boperator\s*&\s*\(\s*\)', line):
2506 error(filename, linenum, 'runtime/operator', 4,
2507 'Unary operator& is dangerous. Do not use it.')
2508
2509 # Check for suspicious usage of "if" like
2510 # } if (a == b) {
2511 if Search(r'\}\s*if\s*\(', line):
2512 error(filename, linenum, 'readability/braces', 4,
2513 'Did you mean "else if"? If not, start a new line for "if".')
2514
2515 # Check for potential format string bugs like printf(foo).
2516 # We constrain the pattern not to pick things like DocidForPrintf(foo).
2517 # Not perfect but it can catch printf(foo.c_str()) and printf(foo->c_str())
2518 match = re.search(r'\b((?:string)?printf)\s*\(([\w.\->()]+)\)', line, re.I)
2519 if match:
2520 error(filename, linenum, 'runtime/printf', 4,
2521 'Potential format string bug. Do %s("%%s", %s) instead.'
2522 % (match.group(1), match.group(2)))
2523
2524 # Check for potential memset bugs like memset(buf, sizeof(buf), 0).
2525 match = Search(r'memset\s*\(([^,]*),\s*([^,]*),\s*0\s*\)', line)
2526 if match and not Match(r"^''|-?[0-9]+|0x[0-9A-Fa-f]$", match.group(2)):
2527 error(filename, linenum, 'runtime/memset', 4,
2528 'Did you mean "memset(%s, 0, %s)"?'
2529 % (match.group(1), match.group(2)))
2530
2531 if Search(r'\busing namespace\b', line):
2532 error(filename, linenum, 'build/namespaces', 5,
2533 'Do not use namespace using-directives. '
2534 'Use using-declarations instead.')
2535
2536 # Detect variable-length arrays.
2537 match = Match(r'\s*(.+::)?(\w+) [a-z]\w*\[(.+)];', line)
2538 if (match and match.group(2) != 'return' and match.group(2) != 'delete' and
2539 match.group(3).find(']') == -1):
2540 # Split the size using space and arithmetic operators as delimiters.
2541 # If any of the resulting tokens are not compile time constants then
2542 # report the error.
2543 tokens = re.split(r'\s|\+|\-|\*|\/|<<|>>]', match.group(3))
2544 is_const = True
2545 skip_next = False
2546 for tok in tokens:
2547 if skip_next:
2548 skip_next = False
2549 continue
2550
2551 if Search(r'sizeof\(.+\)', tok): continue
2552 if Search(r'arraysize\(\w+\)', tok): continue
2553
2554 tok = tok.lstrip('(')
2555 tok = tok.rstrip(')')
2556 if not tok: continue
2557 if Match(r'\d+', tok): continue
2558 if Match(r'0[xX][0-9a-fA-F]+', tok): continue
2559 if Match(r'k[A-Z0-9]\w*', tok): continue
2560 if Match(r'(.+::)?k[A-Z0-9]\w*', tok): continue
2561 if Match(r'(.+::)?[A-Z][A-Z0-9_]*', tok): continue
2562 # A catch all for tricky sizeof cases, including 'sizeof expression',
2563 # 'sizeof(*type)', 'sizeof(const type)', 'sizeof(struct StructName)'
2564 # requires skipping the next token becasue we split on ' ' and '*'.
2565 if tok.startswith('sizeof'):
2566 skip_next = True
2567 continue
2568 is_const = False
2569 break
2570 if not is_const:
2571 error(filename, linenum, 'runtime/arrays', 1,
2572 'Do not use variable-length arrays. Use an appropriately named '
2573 "('k' followed by CamelCase) compile-time constant for the size.")
2574
2575 # If DISALLOW_EVIL_CONSTRUCTORS, DISALLOW_COPY_AND_ASSIGN, or
2576 # DISALLOW_IMPLICIT_CONSTRUCTORS is present, then it should be the last thing
2577 # in the class declaration.
2578 match = Match(
2579 (r'\s*'
2580 r'(DISALLOW_(EVIL_CONSTRUCTORS|COPY_AND_ASSIGN|IMPLICIT_CONSTRUCTORS))'
2581 r'\(.*\);$'),
2582 line)
2583 if match and linenum + 1 < clean_lines.NumLines():
2584 next_line = clean_lines.elided[linenum + 1]
2585 if not Search(r'^\s*};', next_line):
2586 error(filename, linenum, 'readability/constructors', 3,
2587 match.group(1) + ' should be the last thing in the class')
2588
2589 # Check for use of unnamed namespaces in header files. Registration
2590 # macros are typically OK, so we allow use of "namespace {" on lines
2591 # that end with backslashes.
2592 if (file_extension == 'h'
2593 and Search(r'\bnamespace\s*{', line)
2594 and line[-1] != '\\'):
2595 error(filename, linenum, 'build/namespaces', 4,
2596 'Do not use unnamed namespaces in header files. See '
2597 'http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Namespaces'
2598 ' for more information.')
2599
2600
2601def CheckCStyleCast(filename, linenum, line, raw_line, cast_type, pattern,
2602 error):
2603 """Checks for a C-style cast by looking for the pattern.
2604
2605 This also handles sizeof(type) warnings, due to similarity of content.
2606
2607 Args:
2608 filename: The name of the current file.
2609 linenum: The number of the line to check.
2610 line: The line of code to check.
2611 raw_line: The raw line of code to check, with comments.
2612 cast_type: The string for the C++ cast to recommend. This is either
2613 reinterpret_cast or static_cast, depending.
2614 pattern: The regular expression used to find C-style casts.
2615 error: The function to call with any errors found.
2616 """
2617 match = Search(pattern, line)
2618 if not match:
2619 return
2620
2621 # e.g., sizeof(int)
2622 sizeof_match = Match(r'.*sizeof\s*$', line[0:match.start(1) - 1])
2623 if sizeof_match:
2624 error(filename, linenum, 'runtime/sizeof', 1,
2625 'Using sizeof(type). Use sizeof(varname) instead if possible')
2626 return
2627
2628 remainder = line[match.end(0):]
2629
2630 # The close paren is for function pointers as arguments to a function.
2631 # eg, void foo(void (*bar)(int));
2632 # The semicolon check is a more basic function check; also possibly a
2633 # function pointer typedef.
2634 # eg, void foo(int); or void foo(int) const;
2635 # The equals check is for function pointer assignment.
2636 # eg, void *(*foo)(int) = ...
2637 #
2638 # Right now, this will only catch cases where there's a single argument, and
2639 # it's unnamed. It should probably be expanded to check for multiple
2640 # arguments with some unnamed.
2641 function_match = Match(r'\s*(\)|=|(const)?\s*(;|\{|throw\(\)))', remainder)
2642 if function_match:
2643 if (not function_match.group(3) or
2644 function_match.group(3) == ';' or
2645 raw_line.find('/*') < 0):
2646 error(filename, linenum, 'readability/function', 3,
2647 'All parameters should be named in a function')
2648 return
2649
2650 # At this point, all that should be left is actual casts.
2651 error(filename, linenum, 'readability/casting', 4,
2652 'Using C-style cast. Use %s<%s>(...) instead' %
2653 (cast_type, match.group(1)))
2654
2655
2656_HEADERS_CONTAINING_TEMPLATES = (
2657 ('<deque>', ('deque',)),
2658 ('<functional>', ('unary_function', 'binary_function',
2659 'plus', 'minus', 'multiplies', 'divides', 'modulus',
2660 'negate',
2661 'equal_to', 'not_equal_to', 'greater', 'less',
2662 'greater_equal', 'less_equal',
2663 'logical_and', 'logical_or', 'logical_not',
2664 'unary_negate', 'not1', 'binary_negate', 'not2',
2665 'bind1st', 'bind2nd',
2666 'pointer_to_unary_function',
2667 'pointer_to_binary_function',
2668 'ptr_fun',
2669 'mem_fun_t', 'mem_fun', 'mem_fun1_t', 'mem_fun1_ref_t',
2670 'mem_fun_ref_t',
2671 'const_mem_fun_t', 'const_mem_fun1_t',
2672 'const_mem_fun_ref_t', 'const_mem_fun1_ref_t',
2673 'mem_fun_ref',
2674 )),
2675 ('<limits>', ('numeric_limits',)),
2676 ('<list>', ('list',)),
2677 ('<map>', ('map', 'multimap',)),
2678 ('<memory>', ('allocator',)),
2679 ('<queue>', ('queue', 'priority_queue',)),
2680 ('<set>', ('set', 'multiset',)),
2681 ('<stack>', ('stack',)),
2682 ('<string>', ('char_traits', 'basic_string',)),
2683 ('<utility>', ('pair',)),
2684 ('<vector>', ('vector',)),
2685
2686 # gcc extensions.
2687 # Note: std::hash is their hash, ::hash is our hash
2688 ('<hash_map>', ('hash_map', 'hash_multimap',)),
2689 ('<hash_set>', ('hash_set', 'hash_multiset',)),
2690 ('<slist>', ('slist',)),
2691 )
2692
2693_HEADERS_ACCEPTED_BUT_NOT_PROMOTED = {
2694 # We can trust with reasonable confidence that map gives us pair<>, too.
2695 'pair<>': ('map', 'multimap', 'hash_map', 'hash_multimap')
2696}
2697
2698_RE_PATTERN_STRING = re.compile(r'\bstring\b')
2699
2700_re_pattern_algorithm_header = []
2701for _template in ('copy', 'max', 'min', 'min_element', 'sort', 'swap',
2702 'transform'):
2703 # Match max<type>(..., ...), max(..., ...), but not foo->max, foo.max or
2704 # type::max().
2705 _re_pattern_algorithm_header.append(
2706 (re.compile(r'[^>.]\b' + _template + r'(<.*?>)?\([^\)]'),
2707 _template,
2708 '<algorithm>'))
2709
2710_re_pattern_templates = []
2711for _header, _templates in _HEADERS_CONTAINING_TEMPLATES:
2712 for _template in _templates:
2713 _re_pattern_templates.append(
2714 (re.compile(r'(\<|\b)' + _template + r'\s*\<'),
2715 _template + '<>',
2716 _header))
2717
2718
2719def FilesBelongToSameModule(filename_cc, filename_h):
2720 """Check if these two filenames belong to the same module.
2721
2722 The concept of a 'module' here is a as follows:
2723 foo.h, foo-inl.h, foo.cc, foo_test.cc and foo_unittest.cc belong to the
2724 same 'module' if they are in the same directory.
2725 some/path/public/xyzzy and some/path/internal/xyzzy are also considered
2726 to belong to the same module here.
2727
2728 If the filename_cc contains a longer path than the filename_h, for example,
2729 '/absolute/path/to/base/sysinfo.cc', and this file would include
2730 'base/sysinfo.h', this function also produces the prefix needed to open the
2731 header. This is used by the caller of this function to more robustly open the
2732 header file. We don't have access to the real include paths in this context,
2733 so we need this guesswork here.
2734
2735 Known bugs: tools/base/bar.cc and base/bar.h belong to the same module
2736 according to this implementation. Because of this, this function gives
2737 some false positives. This should be sufficiently rare in practice.
2738
2739 Args:
2740 filename_cc: is the path for the .cc file
2741 filename_h: is the path for the header path
2742
2743 Returns:
2744 Tuple with a bool and a string:
2745 bool: True if filename_cc and filename_h belong to the same module.
2746 string: the additional prefix needed to open the header file.
2747 """
2748
2749 if not filename_cc.endswith('.cc'):
2750 return (False, '')
2751 filename_cc = filename_cc[:-len('.cc')]
2752 if filename_cc.endswith('_unittest'):
2753 filename_cc = filename_cc[:-len('_unittest')]
2754 elif filename_cc.endswith('_test'):
2755 filename_cc = filename_cc[:-len('_test')]
2756 filename_cc = filename_cc.replace('/public/', '/')
2757 filename_cc = filename_cc.replace('/internal/', '/')
2758
2759 if not filename_h.endswith('.h'):
2760 return (False, '')
2761 filename_h = filename_h[:-len('.h')]
2762 if filename_h.endswith('-inl'):
2763 filename_h = filename_h[:-len('-inl')]
2764 filename_h = filename_h.replace('/public/', '/')
2765 filename_h = filename_h.replace('/internal/', '/')
2766
2767 files_belong_to_same_module = filename_cc.endswith(filename_h)
2768 common_path = ''
2769 if files_belong_to_same_module:
2770 common_path = filename_cc[:-len(filename_h)]
2771 return files_belong_to_same_module, common_path
2772
2773
2774def UpdateIncludeState(filename, include_state, io=codecs):
2775 """Fill up the include_state with new includes found from the file.
2776
2777 Args:
2778 filename: the name of the header to read.
2779 include_state: an _IncludeState instance in which the headers are inserted.
2780 io: The io factory to use to read the file. Provided for testability.
2781
2782 Returns:
2783 True if a header was succesfully added. False otherwise.
2784 """
2785 headerfile = None
2786 try:
2787 headerfile = io.open(filename, 'r', 'utf8', 'replace')
2788 except IOError:
2789 return False
2790 linenum = 0
2791 for line in headerfile:
2792 linenum += 1
2793 clean_line = CleanseComments(line)
2794 match = _RE_PATTERN_INCLUDE.search(clean_line)
2795 if match:
2796 include = match.group(2)
2797 # The value formatting is cute, but not really used right now.
2798 # What matters here is that the key is in include_state.
2799 include_state.setdefault(include, '%s:%d' % (filename, linenum))
2800 return True
2801
2802
2803def CheckForIncludeWhatYouUse(filename, clean_lines, include_state, error,
2804 io=codecs):
2805 """Reports for missing stl includes.
2806
2807 This function will output warnings to make sure you are including the headers
2808 necessary for the stl containers and functions that you use. We only give one
2809 reason to include a header. For example, if you use both equal_to<> and
2810 less<> in a .h file, only one (the latter in the file) of these will be
2811 reported as a reason to include the <functional>.
2812
2813 Args:
2814 filename: The name of the current file.
2815 clean_lines: A CleansedLines instance containing the file.
2816 include_state: An _IncludeState instance.
2817 error: The function to call with any errors found.
2818 io: The IO factory to use to read the header file. Provided for unittest
2819 injection.
2820 """
2821 required = {} # A map of header name to linenumber and the template entity.
2822 # Example of required: { '<functional>': (1219, 'less<>') }
2823
2824 for linenum in xrange(clean_lines.NumLines()):
2825 line = clean_lines.elided[linenum]
2826 if not line or line[0] == '#':
2827 continue
2828
2829 # String is special -- it is a non-templatized type in STL.
2830 m = _RE_PATTERN_STRING.search(line)
2831 if m:
2832 # Don't warn about strings in non-STL namespaces:
2833 # (We check only the first match per line; good enough.)
2834 prefix = line[:m.start()]
2835 if prefix.endswith('std::') or not prefix.endswith('::'):
2836 required['<string>'] = (linenum, 'string')
2837
2838 for pattern, template, header in _re_pattern_algorithm_header:
2839 if pattern.search(line):
2840 required[header] = (linenum, template)
2841
2842 # The following function is just a speed up, no semantics are changed.
2843 if not '<' in line: # Reduces the cpu time usage by skipping lines.
2844 continue
2845
2846 for pattern, template, header in _re_pattern_templates:
2847 if pattern.search(line):
2848 required[header] = (linenum, template)
2849
2850 # The policy is that if you #include something in foo.h you don't need to
2851 # include it again in foo.cc. Here, we will look at possible includes.
2852 # Let's copy the include_state so it is only messed up within this function.
2853 include_state = include_state.copy()
2854
2855 # Did we find the header for this file (if any) and succesfully load it?
2856 header_found = False
2857
2858 # Use the absolute path so that matching works properly.
2859 abs_filename = os.path.abspath(filename)
2860
2861 # For Emacs's flymake.
2862 # If cpplint is invoked from Emacs's flymake, a temporary file is generated
2863 # by flymake and that file name might end with '_flymake.cc'. In that case,
2864 # restore original file name here so that the corresponding header file can be
2865 # found.
2866 # e.g. If the file name is 'foo_flymake.cc', we should search for 'foo.h'
2867 # instead of 'foo_flymake.h'
2868 abs_filename = re.sub(r'_flymake\.cc$', '.cc', abs_filename)
2869
2870 # include_state is modified during iteration, so we iterate over a copy of
2871 # the keys.
2872 for header in include_state.keys(): #NOLINT
2873 (same_module, common_path) = FilesBelongToSameModule(abs_filename, header)
2874 fullpath = common_path + header
2875 if same_module and UpdateIncludeState(fullpath, include_state, io):
2876 header_found = True
2877
2878 # If we can't find the header file for a .cc, assume it's because we don't
2879 # know where to look. In that case we'll give up as we're not sure they
2880 # didn't include it in the .h file.
2881 # TODO(unknown): Do a better job of finding .h files so we are confident that
2882 # not having the .h file means there isn't one.
2883 if filename.endswith('.cc') and not header_found:
2884 return
2885
2886 # All the lines have been processed, report the errors found.
2887 for required_header_unstripped in required:
2888 template = required[required_header_unstripped][1]
2889 if template in _HEADERS_ACCEPTED_BUT_NOT_PROMOTED:
2890 headers = _HEADERS_ACCEPTED_BUT_NOT_PROMOTED[template]
2891 if [True for header in headers if header in include_state]:
2892 continue
2893 if required_header_unstripped.strip('<>"') not in include_state:
2894 error(filename, required[required_header_unstripped][0],
2895 'build/include_what_you_use', 4,
2896 'Add #include ' + required_header_unstripped + ' for ' + template)
2897
2898
2899def ProcessLine(filename, file_extension,
2900 clean_lines, line, include_state, function_state,
2901 class_state, error):
2902 """Processes a single line in the file.
2903
2904 Args:
2905 filename: Filename of the file that is being processed.
2906 file_extension: The extension (dot not included) of the file.
2907 clean_lines: An array of strings, each representing a line of the file,
2908 with comments stripped.
2909 line: Number of line being processed.
2910 include_state: An _IncludeState instance in which the headers are inserted.
2911 function_state: A _FunctionState instance which counts function lines, etc.
2912 class_state: A _ClassState instance which maintains information about
2913 the current stack of nested class declarations being parsed.
2914 error: A callable to which errors are reported, which takes 4 arguments:
2915 filename, line number, error level, and message
2916
2917 """
2918 raw_lines = clean_lines.raw_lines
2919 ParseNolintSuppressions(filename, raw_lines[line], line, error)
2920 CheckForFunctionLengths(filename, clean_lines, line, function_state, error)
2921 CheckForMultilineCommentsAndStrings(filename, clean_lines, line, error)
2922 CheckStyle(filename, clean_lines, line, file_extension, error)
2923 CheckLanguage(filename, clean_lines, line, file_extension, include_state,
2924 error)
2925 CheckForNonStandardConstructs(filename, clean_lines, line,
2926 class_state, error)
2927 CheckPosixThreading(filename, clean_lines, line, error)
2928 CheckInvalidIncrement(filename, clean_lines, line, error)
2929
2930
2931def ProcessFileData(filename, file_extension, lines, error):
2932 """Performs lint checks and reports any errors to the given error function.
2933
2934 Args:
2935 filename: Filename of the file that is being processed.
2936 file_extension: The extension (dot not included) of the file.
2937 lines: An array of strings, each representing a line of the file, with the
2938 last element being empty if the file is termined with a newline.
2939 error: A callable to which errors are reported, which takes 4 arguments:
2940 """
2941 lines = (['// marker so line numbers and indices both start at 1'] + lines +
2942 ['// marker so line numbers end in a known way'])
2943
2944 include_state = _IncludeState()
2945 function_state = _FunctionState()
2946 class_state = _ClassState()
2947
2948 ResetNolintSuppressions()
2949
2950 CheckForCopyright(filename, lines, error)
2951
2952 if file_extension == 'h':
2953 CheckForHeaderGuard(filename, lines, error)
2954
2955 RemoveMultiLineComments(filename, lines, error)
2956 clean_lines = CleansedLines(lines)
2957 for line in xrange(clean_lines.NumLines()):
2958 ProcessLine(filename, file_extension, clean_lines, line,
2959 include_state, function_state, class_state, error)
2960 class_state.CheckFinished(filename, error)
2961
2962 CheckForIncludeWhatYouUse(filename, clean_lines, include_state, error)
2963
2964 # We check here rather than inside ProcessLine so that we see raw
2965 # lines rather than "cleaned" lines.
2966 CheckForUnicodeReplacementCharacters(filename, lines, error)
2967
2968 CheckForNewlineAtEOF(filename, lines, error)
2969
2970def ProcessFile(filename, vlevel):
2971 """Does google-lint on a single file.
2972
2973 Args:
2974 filename: The name of the file to parse.
2975
2976 vlevel: The level of errors to report. Every error of confidence
2977 >= verbose_level will be reported. 0 is a good default.
2978 """
2979
2980 _SetVerboseLevel(vlevel)
2981
2982 try:
2983 # Support the UNIX convention of using "-" for stdin. Note that
2984 # we are not opening the file with universal newline support
2985 # (which codecs doesn't support anyway), so the resulting lines do
2986 # contain trailing '\r' characters if we are reading a file that
2987 # has CRLF endings.
2988 # If after the split a trailing '\r' is present, it is removed
2989 # below. If it is not expected to be present (i.e. os.linesep !=
2990 # '\r\n' as in Windows), a warning is issued below if this file
2991 # is processed.
2992
2993 if filename == '-':
2994 lines = codecs.StreamReaderWriter(sys.stdin,
2995 codecs.getreader('utf8'),
2996 codecs.getwriter('utf8'),
2997 'replace').read().split('\n')
2998 else:
2999 lines = codecs.open(filename, 'r', 'utf8', 'replace').read().split('\n')
3000
3001 carriage_return_found = False
3002 # Remove trailing '\r'.
3003 for linenum in range(len(lines)):
3004 if lines[linenum].endswith('\r'):
3005 lines[linenum] = lines[linenum].rstrip('\r')
3006 carriage_return_found = True
3007
3008 except IOError:
3009 sys.stderr.write(
3010 "Skipping input '%s': Can't open for reading\n" % filename)
3011 return
3012
3013 # Note, if no dot is found, this will give the entire filename as the ext.
3014 file_extension = filename[filename.rfind('.') + 1:]
3015
3016 # When reading from stdin, the extension is unknown, so no cpplint tests
3017 # should rely on the extension.
3018 if (filename != '-' and file_extension != 'cc' and file_extension != 'h'
3019 and file_extension != 'cpp'):
3020 sys.stderr.write('Ignoring %s; not a .cc or .h file\n' % filename)
3021 else:
3022 ProcessFileData(filename, file_extension, lines, Error)
3023 if carriage_return_found and os.linesep != '\r\n':
3024 # Use 0 for linenum since outputing only one error for potentially
3025 # several lines.
3026 Error(filename, 0, 'whitespace/newline', 1,
3027 'One or more unexpected \\r (^M) found;'
3028 'better to use only a \\n')
3029
3030 sys.stderr.write('Done processing %s\n' % filename)
3031
3032
3033def PrintUsage(message):
3034 """Prints a brief usage string and exits, optionally with an error message.
3035
3036 Args:
3037 message: The optional error message.
3038 """
3039 sys.stderr.write(_USAGE)
3040 if message:
3041 sys.exit('\nFATAL ERROR: ' + message)
3042 else:
3043 sys.exit(1)
3044
3045
3046def PrintCategories():
3047 """Prints a list of all the error-categories used by error messages.
3048
3049 These are the categories used to filter messages via --filter.
3050 """
3051 sys.stderr.write(''.join(' %s\n' % cat for cat in _ERROR_CATEGORIES))
3052 sys.exit(0)
3053
3054
3055def ParseArguments(args):
3056 """Parses the command line arguments.
3057
3058 This may set the output format and verbosity level as side-effects.
3059
3060 Args:
3061 args: The command line arguments:
3062
3063 Returns:
3064 The list of filenames to lint.
3065 """
3066 try:
3067 (opts, filenames) = getopt.getopt(args, '', ['help', 'output=', 'verbose=',
3068 'counting=',
3069 'filter='])
3070 except getopt.GetoptError:
3071 PrintUsage('Invalid arguments.')
3072
3073 verbosity = _VerboseLevel()
3074 output_format = _OutputFormat()
3075 filters = ''
3076 counting_style = ''
3077
3078 for (opt, val) in opts:
3079 if opt == '--help':
3080 PrintUsage(None)
3081 elif opt == '--output':
3082 if not val in ('emacs', 'vs7'):
3083 PrintUsage('The only allowed output formats are emacs and vs7.')
3084 output_format = val
3085 elif opt == '--verbose':
3086 verbosity = int(val)
3087 elif opt == '--filter':
3088 filters = val
3089 if not filters:
3090 PrintCategories()
3091 elif opt == '--counting':
3092 if val not in ('total', 'toplevel', 'detailed'):
3093 PrintUsage('Valid counting options are total, toplevel, and detailed')
3094 counting_style = val
3095
3096 if not filenames:
3097 PrintUsage('No files were specified.')
3098
3099 _SetOutputFormat(output_format)
3100 _SetVerboseLevel(verbosity)
3101 _SetFilters(filters)
3102 _SetCountingStyle(counting_style)
3103
3104 return filenames
3105
3106
3107def main():
3108 filenames = ParseArguments(sys.argv[1:])
3109
3110 # Change stderr to write with replacement characters so we don't die
3111 # if we try to print something containing non-ASCII characters.
3112 sys.stderr = codecs.StreamReaderWriter(sys.stderr,
3113 codecs.getreader('utf8'),
3114 codecs.getwriter('utf8'),
3115 'replace')
3116
3117 _cpplint_state.ResetErrorCounts()
3118 for filename in filenames:
3119 ProcessFile(filename, _cpplint_state.verbose_level)
3120 _cpplint_state.PrintErrorCounts()
3121
3122 sys.exit(_cpplint_state.error_count > 0)
3123
3124
3125if __name__ == '__main__':
3126 main()