blob: 9d528077252f1b0ae3b494e8b71d99149d6b817c [file] [log] [blame]
buzbee311ca162013-02-28 15:56:43 -08001/*
2 * Copyright (C) 2011 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Ian Rogerse77493c2014-08-20 15:08:45 -070017#include "base/bit_vector-inl.h"
buzbee311ca162013-02-28 15:56:43 -080018#include "compiler_internals.h"
Ian Rogers6a3c1fc2014-10-31 00:33:20 -070019#include "dataflow_iterator-inl.h"
Vladimir Marko95a05972014-05-30 10:01:32 +010020#include "global_value_numbering.h"
buzbee311ca162013-02-28 15:56:43 -080021#include "local_value_numbering.h"
Vladimir Markoaf6925b2014-10-31 16:37:32 +000022#include "mir_field_info.h"
Ian Rogers6a3c1fc2014-10-31 00:33:20 -070023#include "quick/dex_file_method_inliner.h"
24#include "quick/dex_file_to_method_inliner_map.h"
Andreas Gampe53c913b2014-08-12 23:19:23 -070025#include "stack.h"
Vladimir Marko69f08ba2014-04-11 12:28:11 +010026#include "utils/scoped_arena_containers.h"
buzbee311ca162013-02-28 15:56:43 -080027
28namespace art {
29
Brian Carlstrom2ce745c2013-07-17 17:44:30 -070030static unsigned int Predecessors(BasicBlock* bb) {
Vladimir Markoe39c54e2014-09-22 14:50:02 +010031 return bb->predecessors.size();
buzbee311ca162013-02-28 15:56:43 -080032}
33
34/* Setup a constant value for opcodes thare have the DF_SETS_CONST attribute */
Razvan A Lupusorud04d3092014-08-04 12:30:20 -070035void MIRGraph::SetConstant(int32_t ssa_reg, int32_t value) {
buzbee862a7602013-04-05 10:58:54 -070036 is_constant_v_->SetBit(ssa_reg);
buzbee311ca162013-02-28 15:56:43 -080037 constant_values_[ssa_reg] = value;
38}
39
Razvan A Lupusorud04d3092014-08-04 12:30:20 -070040void MIRGraph::SetConstantWide(int32_t ssa_reg, int64_t value) {
buzbee862a7602013-04-05 10:58:54 -070041 is_constant_v_->SetBit(ssa_reg);
Serguei Katkov597da1f2014-07-15 17:25:46 +070042 is_constant_v_->SetBit(ssa_reg + 1);
buzbee311ca162013-02-28 15:56:43 -080043 constant_values_[ssa_reg] = Low32Bits(value);
44 constant_values_[ssa_reg + 1] = High32Bits(value);
45}
46
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -080047void MIRGraph::DoConstantPropagation(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -080048 MIR* mir;
buzbee311ca162013-02-28 15:56:43 -080049
50 for (mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Alexei Zavjalov9d894662014-04-21 20:45:24 +070051 // Skip pass if BB has MIR without SSA representation.
Jean Christophe Beylercc794c32014-05-02 09:34:13 -070052 if (mir->ssa_rep == nullptr) {
Alexei Zavjalov9d894662014-04-21 20:45:24 +070053 return;
54 }
55
Jean Christophe Beylercc794c32014-05-02 09:34:13 -070056 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee311ca162013-02-28 15:56:43 -080057
Ian Rogers29a26482014-05-02 15:27:29 -070058 MIR::DecodedInstruction* d_insn = &mir->dalvikInsn;
buzbee311ca162013-02-28 15:56:43 -080059
60 if (!(df_attributes & DF_HAS_DEFS)) continue;
61
62 /* Handle instructions that set up constants directly */
63 if (df_attributes & DF_SETS_CONST) {
64 if (df_attributes & DF_DA) {
65 int32_t vB = static_cast<int32_t>(d_insn->vB);
66 switch (d_insn->opcode) {
67 case Instruction::CONST_4:
68 case Instruction::CONST_16:
69 case Instruction::CONST:
70 SetConstant(mir->ssa_rep->defs[0], vB);
71 break;
72 case Instruction::CONST_HIGH16:
73 SetConstant(mir->ssa_rep->defs[0], vB << 16);
74 break;
75 case Instruction::CONST_WIDE_16:
76 case Instruction::CONST_WIDE_32:
77 SetConstantWide(mir->ssa_rep->defs[0], static_cast<int64_t>(vB));
78 break;
79 case Instruction::CONST_WIDE:
Brian Carlstromb1eba212013-07-17 18:07:19 -070080 SetConstantWide(mir->ssa_rep->defs[0], d_insn->vB_wide);
buzbee311ca162013-02-28 15:56:43 -080081 break;
82 case Instruction::CONST_WIDE_HIGH16:
83 SetConstantWide(mir->ssa_rep->defs[0], static_cast<int64_t>(vB) << 48);
84 break;
85 default:
86 break;
87 }
88 }
89 /* Handle instructions that set up constants directly */
90 } else if (df_attributes & DF_IS_MOVE) {
91 int i;
92
93 for (i = 0; i < mir->ssa_rep->num_uses; i++) {
buzbee862a7602013-04-05 10:58:54 -070094 if (!is_constant_v_->IsBitSet(mir->ssa_rep->uses[i])) break;
buzbee311ca162013-02-28 15:56:43 -080095 }
96 /* Move a register holding a constant to another register */
97 if (i == mir->ssa_rep->num_uses) {
98 SetConstant(mir->ssa_rep->defs[0], constant_values_[mir->ssa_rep->uses[0]]);
99 if (df_attributes & DF_A_WIDE) {
100 SetConstant(mir->ssa_rep->defs[1], constant_values_[mir->ssa_rep->uses[1]]);
101 }
102 }
103 }
104 }
105 /* TODO: implement code to handle arithmetic operations */
buzbee311ca162013-02-28 15:56:43 -0800106}
107
buzbee311ca162013-02-28 15:56:43 -0800108/* Advance to next strictly dominated MIR node in an extended basic block */
buzbee0d829482013-10-11 15:24:55 -0700109MIR* MIRGraph::AdvanceMIR(BasicBlock** p_bb, MIR* mir) {
buzbee311ca162013-02-28 15:56:43 -0800110 BasicBlock* bb = *p_bb;
111 if (mir != NULL) {
112 mir = mir->next;
113 if (mir == NULL) {
buzbee0d829482013-10-11 15:24:55 -0700114 bb = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800115 if ((bb == NULL) || Predecessors(bb) != 1) {
116 mir = NULL;
117 } else {
118 *p_bb = bb;
119 mir = bb->first_mir_insn;
120 }
121 }
122 }
123 return mir;
124}
125
126/*
127 * To be used at an invoke mir. If the logically next mir node represents
128 * a move-result, return it. Else, return NULL. If a move-result exists,
129 * it is required to immediately follow the invoke with no intervening
130 * opcodes or incoming arcs. However, if the result of the invoke is not
131 * used, a move-result may not be present.
132 */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700133MIR* MIRGraph::FindMoveResult(BasicBlock* bb, MIR* mir) {
buzbee311ca162013-02-28 15:56:43 -0800134 BasicBlock* tbb = bb;
135 mir = AdvanceMIR(&tbb, mir);
136 while (mir != NULL) {
buzbee311ca162013-02-28 15:56:43 -0800137 if ((mir->dalvikInsn.opcode == Instruction::MOVE_RESULT) ||
138 (mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_OBJECT) ||
139 (mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_WIDE)) {
140 break;
141 }
142 // Keep going if pseudo op, otherwise terminate
Jean Christophe Beyler2ab40eb2014-06-02 09:03:14 -0700143 if (MIR::DecodedInstruction::IsPseudoMirOp(mir->dalvikInsn.opcode)) {
buzbee311ca162013-02-28 15:56:43 -0800144 mir = AdvanceMIR(&tbb, mir);
buzbee35ba7f32014-05-31 08:59:01 -0700145 } else {
146 mir = NULL;
buzbee311ca162013-02-28 15:56:43 -0800147 }
148 }
149 return mir;
150}
151
buzbee0d829482013-10-11 15:24:55 -0700152BasicBlock* MIRGraph::NextDominatedBlock(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800153 if (bb->block_type == kDead) {
154 return NULL;
155 }
156 DCHECK((bb->block_type == kEntryBlock) || (bb->block_type == kDalvikByteCode)
157 || (bb->block_type == kExitBlock));
buzbee0d829482013-10-11 15:24:55 -0700158 BasicBlock* bb_taken = GetBasicBlock(bb->taken);
159 BasicBlock* bb_fall_through = GetBasicBlock(bb->fall_through);
buzbee1da1e2f2013-11-15 13:37:01 -0800160 if (((bb_fall_through == NULL) && (bb_taken != NULL)) &&
buzbee0d829482013-10-11 15:24:55 -0700161 ((bb_taken->block_type == kDalvikByteCode) || (bb_taken->block_type == kExitBlock))) {
buzbeecbcfaf32013-08-19 07:37:40 -0700162 // Follow simple unconditional branches.
buzbee0d829482013-10-11 15:24:55 -0700163 bb = bb_taken;
buzbeecbcfaf32013-08-19 07:37:40 -0700164 } else {
165 // Follow simple fallthrough
buzbee0d829482013-10-11 15:24:55 -0700166 bb = (bb_taken != NULL) ? NULL : bb_fall_through;
buzbeecbcfaf32013-08-19 07:37:40 -0700167 }
buzbee311ca162013-02-28 15:56:43 -0800168 if (bb == NULL || (Predecessors(bb) != 1)) {
169 return NULL;
170 }
171 DCHECK((bb->block_type == kDalvikByteCode) || (bb->block_type == kExitBlock));
172 return bb;
173}
174
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700175static MIR* FindPhi(BasicBlock* bb, int ssa_name) {
buzbee311ca162013-02-28 15:56:43 -0800176 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
177 if (static_cast<int>(mir->dalvikInsn.opcode) == kMirOpPhi) {
178 for (int i = 0; i < mir->ssa_rep->num_uses; i++) {
179 if (mir->ssa_rep->uses[i] == ssa_name) {
180 return mir;
181 }
182 }
183 }
184 }
185 return NULL;
186}
187
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700188static SelectInstructionKind SelectKind(MIR* mir) {
Chao-ying Fu8ac41af2014-10-01 16:53:04 -0700189 // Work with the case when mir is nullptr.
190 if (mir == nullptr) {
191 return kSelectNone;
192 }
buzbee311ca162013-02-28 15:56:43 -0800193 switch (mir->dalvikInsn.opcode) {
194 case Instruction::MOVE:
195 case Instruction::MOVE_OBJECT:
196 case Instruction::MOVE_16:
197 case Instruction::MOVE_OBJECT_16:
198 case Instruction::MOVE_FROM16:
199 case Instruction::MOVE_OBJECT_FROM16:
200 return kSelectMove;
Brian Carlstrom6f485c62013-07-18 15:35:35 -0700201 case Instruction::CONST:
202 case Instruction::CONST_4:
203 case Instruction::CONST_16:
buzbee311ca162013-02-28 15:56:43 -0800204 return kSelectConst;
Brian Carlstrom6f485c62013-07-18 15:35:35 -0700205 case Instruction::GOTO:
206 case Instruction::GOTO_16:
207 case Instruction::GOTO_32:
buzbee311ca162013-02-28 15:56:43 -0800208 return kSelectGoto;
Brian Carlstrom02c8cc62013-07-18 15:54:44 -0700209 default:
210 return kSelectNone;
buzbee311ca162013-02-28 15:56:43 -0800211 }
buzbee311ca162013-02-28 15:56:43 -0800212}
213
Vladimir Markoa1a70742014-03-03 10:28:05 +0000214static constexpr ConditionCode kIfCcZConditionCodes[] = {
215 kCondEq, kCondNe, kCondLt, kCondGe, kCondGt, kCondLe
216};
217
Andreas Gampe785d2f22014-11-03 22:57:30 -0800218static_assert(arraysize(kIfCcZConditionCodes) == Instruction::IF_LEZ - Instruction::IF_EQZ + 1,
219 "if_ccz_ccodes_size1");
Vladimir Markoa1a70742014-03-03 10:28:05 +0000220
Vladimir Markoa1a70742014-03-03 10:28:05 +0000221static constexpr ConditionCode ConditionCodeForIfCcZ(Instruction::Code opcode) {
222 return kIfCcZConditionCodes[opcode - Instruction::IF_EQZ];
223}
224
Andreas Gampe785d2f22014-11-03 22:57:30 -0800225static_assert(ConditionCodeForIfCcZ(Instruction::IF_EQZ) == kCondEq, "if_eqz ccode");
226static_assert(ConditionCodeForIfCcZ(Instruction::IF_NEZ) == kCondNe, "if_nez ccode");
227static_assert(ConditionCodeForIfCcZ(Instruction::IF_LTZ) == kCondLt, "if_ltz ccode");
228static_assert(ConditionCodeForIfCcZ(Instruction::IF_GEZ) == kCondGe, "if_gez ccode");
229static_assert(ConditionCodeForIfCcZ(Instruction::IF_GTZ) == kCondGt, "if_gtz ccode");
230static_assert(ConditionCodeForIfCcZ(Instruction::IF_LEZ) == kCondLe, "if_lez ccode");
Vladimir Markoa1a70742014-03-03 10:28:05 +0000231
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700232int MIRGraph::GetSSAUseCount(int s_reg) {
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100233 DCHECK_LT(static_cast<size_t>(s_reg), ssa_subscripts_.size());
234 return raw_use_counts_[s_reg];
buzbee311ca162013-02-28 15:56:43 -0800235}
236
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700237size_t MIRGraph::GetNumBytesForSpecialTemps() const {
238 // This logic is written with assumption that Method* is only special temp.
239 DCHECK_EQ(max_available_special_compiler_temps_, 1u);
240 return sizeof(StackReference<mirror::ArtMethod>);
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800241}
242
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700243size_t MIRGraph::GetNumAvailableVRTemps() {
244 // First take into account all temps reserved for backend.
245 if (max_available_non_special_compiler_temps_ < reserved_temps_for_backend_) {
246 return 0;
247 }
248
249 // Calculate remaining ME temps available.
250 size_t remaining_me_temps = max_available_non_special_compiler_temps_ - reserved_temps_for_backend_;
251
252 if (num_non_special_compiler_temps_ >= remaining_me_temps) {
253 return 0;
254 } else {
255 return remaining_me_temps - num_non_special_compiler_temps_;
256 }
257}
Bill Buzbee00e1ec62014-02-27 23:44:13 +0000258
259// FIXME - will probably need to revisit all uses of this, as type not defined.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800260static const RegLocation temp_loc = {kLocCompilerTemp,
buzbee091cc402014-03-31 10:14:40 -0700261 0, 1 /*defined*/, 0, 0, 0, 0, 0, 1 /*home*/,
Bill Buzbee00e1ec62014-02-27 23:44:13 +0000262 RegStorage(), INVALID_SREG, INVALID_SREG};
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800263
264CompilerTemp* MIRGraph::GetNewCompilerTemp(CompilerTempType ct_type, bool wide) {
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700265 // Once the compiler temps have been committed, new ones cannot be requested anymore.
266 DCHECK_EQ(compiler_temps_committed_, false);
267 // Make sure that reserved for BE set is sane.
268 DCHECK_LE(reserved_temps_for_backend_, max_available_non_special_compiler_temps_);
269
270 bool verbose = cu_->verbose;
271 const char* ct_type_str = nullptr;
272
273 if (verbose) {
274 switch (ct_type) {
275 case kCompilerTempBackend:
276 ct_type_str = "backend";
277 break;
278 case kCompilerTempSpecialMethodPtr:
279 ct_type_str = "method*";
280 break;
281 case kCompilerTempVR:
282 ct_type_str = "VR";
283 break;
284 default:
285 ct_type_str = "unknown";
286 break;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800287 }
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700288 LOG(INFO) << "CompilerTemps: A compiler temp of type " << ct_type_str << " that is "
289 << (wide ? "wide is being requested." : "not wide is being requested.");
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800290 }
291
292 CompilerTemp *compiler_temp = static_cast<CompilerTemp *>(arena_->Alloc(sizeof(CompilerTemp),
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000293 kArenaAllocRegAlloc));
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800294
295 // Create the type of temp requested. Special temps need special handling because
296 // they have a specific virtual register assignment.
297 if (ct_type == kCompilerTempSpecialMethodPtr) {
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700298 // This has a special location on stack which is 32-bit or 64-bit depending
299 // on mode. However, we don't want to overlap with non-special section
300 // and thus even for 64-bit, we allow only a non-wide temp to be requested.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800301 DCHECK_EQ(wide, false);
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800302
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700303 // The vreg is always the first special temp for method ptr.
304 compiler_temp->v_reg = GetFirstSpecialTempVR();
305
306 } else if (ct_type == kCompilerTempBackend) {
307 requested_backend_temp_ = true;
308
309 // Make sure that we are not exceeding temps reserved for BE.
310 // Since VR temps cannot be requested once the BE temps are requested, we
311 // allow reservation of VR temps as well for BE. We
312 size_t available_temps = reserved_temps_for_backend_ + GetNumAvailableVRTemps();
313 if (available_temps <= 0 || (available_temps <= 1 && wide)) {
314 if (verbose) {
315 LOG(INFO) << "CompilerTemps: Not enough temp(s) of type " << ct_type_str << " are available.";
316 }
317 return nullptr;
318 }
319
320 // Update the remaining reserved temps since we have now used them.
321 // Note that the code below is actually subtracting to remove them from reserve
322 // once they have been claimed. It is careful to not go below zero.
323 if (reserved_temps_for_backend_ >= 1) {
324 reserved_temps_for_backend_--;
325 }
326 if (wide && reserved_temps_for_backend_ >= 1) {
327 reserved_temps_for_backend_--;
328 }
329
330 // The new non-special compiler temp must receive a unique v_reg.
331 compiler_temp->v_reg = GetFirstNonSpecialTempVR() + num_non_special_compiler_temps_;
332 num_non_special_compiler_temps_++;
333 } else if (ct_type == kCompilerTempVR) {
334 // Once we start giving out BE temps, we don't allow anymore ME temps to be requested.
335 // This is done in order to prevent problems with ssa since these structures are allocated
336 // and managed by the ME.
337 DCHECK_EQ(requested_backend_temp_, false);
338
339 // There is a limit to the number of non-special temps so check to make sure it wasn't exceeded.
340 size_t available_temps = GetNumAvailableVRTemps();
341 if (available_temps <= 0 || (available_temps <= 1 && wide)) {
342 if (verbose) {
343 LOG(INFO) << "CompilerTemps: Not enough temp(s) of type " << ct_type_str << " are available.";
344 }
345 return nullptr;
346 }
347
348 // The new non-special compiler temp must receive a unique v_reg.
349 compiler_temp->v_reg = GetFirstNonSpecialTempVR() + num_non_special_compiler_temps_;
350 num_non_special_compiler_temps_++;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800351 } else {
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700352 UNIMPLEMENTED(FATAL) << "No handling for compiler temp type " << ct_type_str << ".";
353 }
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800354
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700355 // We allocate an sreg as well to make developer life easier.
356 // However, if this is requested from an ME pass that will recalculate ssa afterwards,
357 // this sreg is no longer valid. The caller should be aware of this.
358 compiler_temp->s_reg_low = AddNewSReg(compiler_temp->v_reg);
359
360 if (verbose) {
361 LOG(INFO) << "CompilerTemps: New temp of type " << ct_type_str << " with v" << compiler_temp->v_reg
362 << " and s" << compiler_temp->s_reg_low << " has been created.";
363 }
364
365 if (wide) {
366 // Only non-special temps are handled as wide for now.
367 // Note that the number of non special temps is incremented below.
368 DCHECK(ct_type == kCompilerTempBackend || ct_type == kCompilerTempVR);
369
370 // Ensure that the two registers are consecutive.
371 int ssa_reg_low = compiler_temp->s_reg_low;
372 int ssa_reg_high = AddNewSReg(compiler_temp->v_reg + 1);
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800373 num_non_special_compiler_temps_++;
374
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700375 if (verbose) {
376 LOG(INFO) << "CompilerTemps: The wide part of temp of type " << ct_type_str << " is v"
377 << compiler_temp->v_reg + 1 << " and s" << ssa_reg_high << ".";
378 }
Chao-ying Fu54d36b62014-05-22 17:25:02 -0700379
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700380 if (reg_location_ != nullptr) {
381 reg_location_[ssa_reg_high] = temp_loc;
382 reg_location_[ssa_reg_high].high_word = true;
383 reg_location_[ssa_reg_high].s_reg_low = ssa_reg_low;
384 reg_location_[ssa_reg_high].wide = true;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800385 }
386 }
387
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700388 // If the register locations have already been allocated, add the information
389 // about the temp. We will not overflow because they have been initialized
390 // to support the maximum number of temps. For ME temps that have multiple
391 // ssa versions, the structures below will be expanded on the post pass cleanup.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800392 if (reg_location_ != nullptr) {
393 int ssa_reg_low = compiler_temp->s_reg_low;
394 reg_location_[ssa_reg_low] = temp_loc;
395 reg_location_[ssa_reg_low].s_reg_low = ssa_reg_low;
396 reg_location_[ssa_reg_low].wide = wide;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800397 }
398
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800399 return compiler_temp;
400}
buzbee311ca162013-02-28 15:56:43 -0800401
402/* Do some MIR-level extended basic block optimizations */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700403bool MIRGraph::BasicBlockOpt(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800404 if (bb->block_type == kDead) {
405 return true;
406 }
Vladimir Marko415ac882014-09-30 18:09:14 +0100407 bool use_lvn = bb->use_lvn && (cu_->disable_opt & (1u << kLocalValueNumbering)) == 0u;
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100408 std::unique_ptr<ScopedArenaAllocator> allocator;
Vladimir Marko95a05972014-05-30 10:01:32 +0100409 std::unique_ptr<GlobalValueNumbering> global_valnum;
Ian Rogers700a4022014-05-19 16:49:03 -0700410 std::unique_ptr<LocalValueNumbering> local_valnum;
buzbee1da1e2f2013-11-15 13:37:01 -0800411 if (use_lvn) {
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100412 allocator.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Vladimir Marko415ac882014-09-30 18:09:14 +0100413 global_valnum.reset(new (allocator.get()) GlobalValueNumbering(cu_, allocator.get(),
414 GlobalValueNumbering::kModeLvn));
Vladimir Markob19955d2014-07-29 12:04:10 +0100415 local_valnum.reset(new (allocator.get()) LocalValueNumbering(global_valnum.get(), bb->id,
416 allocator.get()));
buzbee1da1e2f2013-11-15 13:37:01 -0800417 }
buzbee311ca162013-02-28 15:56:43 -0800418 while (bb != NULL) {
419 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
420 // TUNING: use the returned value number for CSE.
buzbee1da1e2f2013-11-15 13:37:01 -0800421 if (use_lvn) {
422 local_valnum->GetValueNumber(mir);
423 }
buzbee311ca162013-02-28 15:56:43 -0800424 // Look for interesting opcodes, skip otherwise
425 Instruction::Code opcode = mir->dalvikInsn.opcode;
426 switch (opcode) {
427 case Instruction::CMPL_FLOAT:
428 case Instruction::CMPL_DOUBLE:
429 case Instruction::CMPG_FLOAT:
430 case Instruction::CMPG_DOUBLE:
431 case Instruction::CMP_LONG:
buzbee1fd33462013-03-25 13:40:45 -0700432 if ((cu_->disable_opt & (1 << kBranchFusing)) != 0) {
buzbee311ca162013-02-28 15:56:43 -0800433 // Bitcode doesn't allow this optimization.
434 break;
435 }
436 if (mir->next != NULL) {
437 MIR* mir_next = mir->next;
buzbee311ca162013-02-28 15:56:43 -0800438 // Make sure result of cmp is used by next insn and nowhere else
Jean Christophe Beylerc26efa82014-06-01 11:39:39 -0700439 if (IsInstructionIfCcZ(mir_next->dalvikInsn.opcode) &&
buzbee311ca162013-02-28 15:56:43 -0800440 (mir->ssa_rep->defs[0] == mir_next->ssa_rep->uses[0]) &&
441 (GetSSAUseCount(mir->ssa_rep->defs[0]) == 1)) {
Vladimir Markoa1a70742014-03-03 10:28:05 +0000442 mir_next->meta.ccode = ConditionCodeForIfCcZ(mir_next->dalvikInsn.opcode);
Brian Carlstromdf629502013-07-17 22:39:56 -0700443 switch (opcode) {
buzbee311ca162013-02-28 15:56:43 -0800444 case Instruction::CMPL_FLOAT:
445 mir_next->dalvikInsn.opcode =
446 static_cast<Instruction::Code>(kMirOpFusedCmplFloat);
447 break;
448 case Instruction::CMPL_DOUBLE:
449 mir_next->dalvikInsn.opcode =
450 static_cast<Instruction::Code>(kMirOpFusedCmplDouble);
451 break;
452 case Instruction::CMPG_FLOAT:
453 mir_next->dalvikInsn.opcode =
454 static_cast<Instruction::Code>(kMirOpFusedCmpgFloat);
455 break;
456 case Instruction::CMPG_DOUBLE:
457 mir_next->dalvikInsn.opcode =
458 static_cast<Instruction::Code>(kMirOpFusedCmpgDouble);
459 break;
460 case Instruction::CMP_LONG:
461 mir_next->dalvikInsn.opcode =
462 static_cast<Instruction::Code>(kMirOpFusedCmpLong);
463 break;
464 default: LOG(ERROR) << "Unexpected opcode: " << opcode;
465 }
466 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
Jean Christophe Beylerc26efa82014-06-01 11:39:39 -0700467 // Copy the SSA information that is relevant.
buzbee311ca162013-02-28 15:56:43 -0800468 mir_next->ssa_rep->num_uses = mir->ssa_rep->num_uses;
469 mir_next->ssa_rep->uses = mir->ssa_rep->uses;
470 mir_next->ssa_rep->fp_use = mir->ssa_rep->fp_use;
471 mir_next->ssa_rep->num_defs = 0;
472 mir->ssa_rep->num_uses = 0;
473 mir->ssa_rep->num_defs = 0;
Jean Christophe Beylerc26efa82014-06-01 11:39:39 -0700474 // Copy in the decoded instruction information for potential SSA re-creation.
475 mir_next->dalvikInsn.vA = mir->dalvikInsn.vB;
476 mir_next->dalvikInsn.vB = mir->dalvikInsn.vC;
buzbee311ca162013-02-28 15:56:43 -0800477 }
478 }
479 break;
480 case Instruction::GOTO:
481 case Instruction::GOTO_16:
482 case Instruction::GOTO_32:
483 case Instruction::IF_EQ:
484 case Instruction::IF_NE:
485 case Instruction::IF_LT:
486 case Instruction::IF_GE:
487 case Instruction::IF_GT:
488 case Instruction::IF_LE:
489 case Instruction::IF_EQZ:
490 case Instruction::IF_NEZ:
491 case Instruction::IF_LTZ:
492 case Instruction::IF_GEZ:
493 case Instruction::IF_GTZ:
494 case Instruction::IF_LEZ:
buzbeecbcfaf32013-08-19 07:37:40 -0700495 // If we've got a backwards branch to return, no need to suspend check.
buzbee0d829482013-10-11 15:24:55 -0700496 if ((IsBackedge(bb, bb->taken) && GetBasicBlock(bb->taken)->dominates_return) ||
497 (IsBackedge(bb, bb->fall_through) &&
498 GetBasicBlock(bb->fall_through)->dominates_return)) {
buzbee311ca162013-02-28 15:56:43 -0800499 mir->optimization_flags |= MIR_IGNORE_SUSPEND_CHECK;
500 if (cu_->verbose) {
buzbee0d829482013-10-11 15:24:55 -0700501 LOG(INFO) << "Suppressed suspend check on branch to return at 0x" << std::hex
502 << mir->offset;
buzbee311ca162013-02-28 15:56:43 -0800503 }
504 }
505 break;
506 default:
507 break;
508 }
509 // Is this the select pattern?
Razvan A Lupusorue27b3bf2014-01-23 09:41:45 -0800510 // TODO: flesh out support for Mips. NOTE: llvm's select op doesn't quite work here.
buzbee311ca162013-02-28 15:56:43 -0800511 // TUNING: expand to support IF_xx compare & branches
Nicolas Geoffrayb34f69a2014-03-07 15:28:39 +0000512 if (!cu_->compiler->IsPortable() &&
Serban Constantinescu05e27ff2014-05-28 13:21:45 +0100513 (cu_->instruction_set == kArm64 || cu_->instruction_set == kThumb2 ||
514 cu_->instruction_set == kX86 || cu_->instruction_set == kX86_64) &&
Vladimir Markoa1a70742014-03-03 10:28:05 +0000515 IsInstructionIfCcZ(mir->dalvikInsn.opcode)) {
buzbee0d829482013-10-11 15:24:55 -0700516 BasicBlock* ft = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800517 DCHECK(ft != NULL);
buzbee0d829482013-10-11 15:24:55 -0700518 BasicBlock* ft_ft = GetBasicBlock(ft->fall_through);
519 BasicBlock* ft_tk = GetBasicBlock(ft->taken);
buzbee311ca162013-02-28 15:56:43 -0800520
buzbee0d829482013-10-11 15:24:55 -0700521 BasicBlock* tk = GetBasicBlock(bb->taken);
buzbee311ca162013-02-28 15:56:43 -0800522 DCHECK(tk != NULL);
buzbee0d829482013-10-11 15:24:55 -0700523 BasicBlock* tk_ft = GetBasicBlock(tk->fall_through);
524 BasicBlock* tk_tk = GetBasicBlock(tk->taken);
buzbee311ca162013-02-28 15:56:43 -0800525
526 /*
527 * In the select pattern, the taken edge goes to a block that unconditionally
528 * transfers to the rejoin block and the fall_though edge goes to a block that
529 * unconditionally falls through to the rejoin block.
530 */
531 if ((tk_ft == NULL) && (ft_tk == NULL) && (tk_tk == ft_ft) &&
532 (Predecessors(tk) == 1) && (Predecessors(ft) == 1)) {
533 /*
534 * Okay - we have the basic diamond shape. At the very least, we can eliminate the
535 * suspend check on the taken-taken branch back to the join point.
536 */
537 if (SelectKind(tk->last_mir_insn) == kSelectGoto) {
538 tk->last_mir_insn->optimization_flags |= (MIR_IGNORE_SUSPEND_CHECK);
539 }
Serban Constantinescu05e27ff2014-05-28 13:21:45 +0100540
541 // TODO: Add logic for LONG.
buzbee311ca162013-02-28 15:56:43 -0800542 // Are the block bodies something we can handle?
543 if ((ft->first_mir_insn == ft->last_mir_insn) &&
544 (tk->first_mir_insn != tk->last_mir_insn) &&
545 (tk->first_mir_insn->next == tk->last_mir_insn) &&
546 ((SelectKind(ft->first_mir_insn) == kSelectMove) ||
547 (SelectKind(ft->first_mir_insn) == kSelectConst)) &&
548 (SelectKind(ft->first_mir_insn) == SelectKind(tk->first_mir_insn)) &&
549 (SelectKind(tk->last_mir_insn) == kSelectGoto)) {
550 // Almost there. Are the instructions targeting the same vreg?
551 MIR* if_true = tk->first_mir_insn;
552 MIR* if_false = ft->first_mir_insn;
553 // It's possible that the target of the select isn't used - skip those (rare) cases.
554 MIR* phi = FindPhi(tk_tk, if_true->ssa_rep->defs[0]);
555 if ((phi != NULL) && (if_true->dalvikInsn.vA == if_false->dalvikInsn.vA)) {
556 /*
557 * We'll convert the IF_EQZ/IF_NEZ to a SELECT. We need to find the
558 * Phi node in the merge block and delete it (while using the SSA name
559 * of the merge as the target of the SELECT. Delete both taken and
560 * fallthrough blocks, and set fallthrough to merge block.
561 * NOTE: not updating other dataflow info (no longer used at this point).
562 * If this changes, need to update i_dom, etc. here (and in CombineBlocks).
563 */
Vladimir Markoa1a70742014-03-03 10:28:05 +0000564 mir->meta.ccode = ConditionCodeForIfCcZ(mir->dalvikInsn.opcode);
buzbee311ca162013-02-28 15:56:43 -0800565 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpSelect);
566 bool const_form = (SelectKind(if_true) == kSelectConst);
567 if ((SelectKind(if_true) == kSelectMove)) {
568 if (IsConst(if_true->ssa_rep->uses[0]) &&
569 IsConst(if_false->ssa_rep->uses[0])) {
570 const_form = true;
571 if_true->dalvikInsn.vB = ConstantValue(if_true->ssa_rep->uses[0]);
572 if_false->dalvikInsn.vB = ConstantValue(if_false->ssa_rep->uses[0]);
573 }
574 }
575 if (const_form) {
Razvan A Lupusorue27b3bf2014-01-23 09:41:45 -0800576 /*
577 * TODO: If both constants are the same value, then instead of generating
578 * a select, we should simply generate a const bytecode. This should be
579 * considered after inlining which can lead to CFG of this form.
580 */
buzbee311ca162013-02-28 15:56:43 -0800581 // "true" set val in vB
582 mir->dalvikInsn.vB = if_true->dalvikInsn.vB;
583 // "false" set val in vC
584 mir->dalvikInsn.vC = if_false->dalvikInsn.vB;
585 } else {
586 DCHECK_EQ(SelectKind(if_true), kSelectMove);
587 DCHECK_EQ(SelectKind(if_false), kSelectMove);
buzbee862a7602013-04-05 10:58:54 -0700588 int* src_ssa =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000589 static_cast<int*>(arena_->Alloc(sizeof(int) * 3, kArenaAllocDFInfo));
buzbee311ca162013-02-28 15:56:43 -0800590 src_ssa[0] = mir->ssa_rep->uses[0];
591 src_ssa[1] = if_true->ssa_rep->uses[0];
592 src_ssa[2] = if_false->ssa_rep->uses[0];
593 mir->ssa_rep->uses = src_ssa;
594 mir->ssa_rep->num_uses = 3;
595 }
596 mir->ssa_rep->num_defs = 1;
buzbee862a7602013-04-05 10:58:54 -0700597 mir->ssa_rep->defs =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000598 static_cast<int*>(arena_->Alloc(sizeof(int) * 1, kArenaAllocDFInfo));
buzbee862a7602013-04-05 10:58:54 -0700599 mir->ssa_rep->fp_def =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000600 static_cast<bool*>(arena_->Alloc(sizeof(bool) * 1, kArenaAllocDFInfo));
buzbee311ca162013-02-28 15:56:43 -0800601 mir->ssa_rep->fp_def[0] = if_true->ssa_rep->fp_def[0];
buzbee817e45a2013-05-30 18:59:12 -0700602 // Match type of uses to def.
603 mir->ssa_rep->fp_use =
Mathieu Chartierf6c4b3b2013-08-24 16:11:37 -0700604 static_cast<bool*>(arena_->Alloc(sizeof(bool) * mir->ssa_rep->num_uses,
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000605 kArenaAllocDFInfo));
buzbee817e45a2013-05-30 18:59:12 -0700606 for (int i = 0; i < mir->ssa_rep->num_uses; i++) {
607 mir->ssa_rep->fp_use[i] = mir->ssa_rep->fp_def[0];
608 }
buzbee311ca162013-02-28 15:56:43 -0800609 /*
610 * There is usually a Phi node in the join block for our two cases. If the
611 * Phi node only contains our two cases as input, we will use the result
612 * SSA name of the Phi node as our select result and delete the Phi. If
613 * the Phi node has more than two operands, we will arbitrarily use the SSA
614 * name of the "true" path, delete the SSA name of the "false" path from the
615 * Phi node (and fix up the incoming arc list).
616 */
617 if (phi->ssa_rep->num_uses == 2) {
618 mir->ssa_rep->defs[0] = phi->ssa_rep->defs[0];
619 phi->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
620 } else {
621 int dead_def = if_false->ssa_rep->defs[0];
622 int live_def = if_true->ssa_rep->defs[0];
623 mir->ssa_rep->defs[0] = live_def;
buzbee0d829482013-10-11 15:24:55 -0700624 BasicBlockId* incoming = phi->meta.phi_incoming;
buzbee311ca162013-02-28 15:56:43 -0800625 for (int i = 0; i < phi->ssa_rep->num_uses; i++) {
626 if (phi->ssa_rep->uses[i] == live_def) {
627 incoming[i] = bb->id;
628 }
629 }
630 for (int i = 0; i < phi->ssa_rep->num_uses; i++) {
631 if (phi->ssa_rep->uses[i] == dead_def) {
632 int last_slot = phi->ssa_rep->num_uses - 1;
633 phi->ssa_rep->uses[i] = phi->ssa_rep->uses[last_slot];
634 incoming[i] = incoming[last_slot];
635 }
636 }
637 }
638 phi->ssa_rep->num_uses--;
buzbee0d829482013-10-11 15:24:55 -0700639 bb->taken = NullBasicBlockId;
buzbee311ca162013-02-28 15:56:43 -0800640 tk->block_type = kDead;
641 for (MIR* tmir = ft->first_mir_insn; tmir != NULL; tmir = tmir->next) {
642 tmir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
643 }
644 }
645 }
646 }
647 }
648 }
buzbee1da1e2f2013-11-15 13:37:01 -0800649 bb = ((cu_->disable_opt & (1 << kSuppressExceptionEdges)) != 0) ? NextDominatedBlock(bb) : NULL;
buzbee311ca162013-02-28 15:56:43 -0800650 }
Vladimir Marko95a05972014-05-30 10:01:32 +0100651 if (use_lvn && UNLIKELY(!global_valnum->Good())) {
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100652 LOG(WARNING) << "LVN overflow in " << PrettyMethod(cu_->method_idx, *cu_->dex_file);
653 }
buzbee311ca162013-02-28 15:56:43 -0800654
buzbee311ca162013-02-28 15:56:43 -0800655 return true;
656}
657
buzbee311ca162013-02-28 15:56:43 -0800658/* Collect stats on number of checks removed */
Ian Rogers6a3c1fc2014-10-31 00:33:20 -0700659void MIRGraph::CountChecks(class BasicBlock* bb) {
buzbee862a7602013-04-05 10:58:54 -0700660 if (bb->data_flow_info != NULL) {
661 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
662 if (mir->ssa_rep == NULL) {
663 continue;
buzbee311ca162013-02-28 15:56:43 -0800664 }
Jean Christophe Beylercc794c32014-05-02 09:34:13 -0700665 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee862a7602013-04-05 10:58:54 -0700666 if (df_attributes & DF_HAS_NULL_CHKS) {
667 checkstats_->null_checks++;
668 if (mir->optimization_flags & MIR_IGNORE_NULL_CHECK) {
669 checkstats_->null_checks_eliminated++;
670 }
671 }
672 if (df_attributes & DF_HAS_RANGE_CHKS) {
673 checkstats_->range_checks++;
674 if (mir->optimization_flags & MIR_IGNORE_RANGE_CHECK) {
675 checkstats_->range_checks_eliminated++;
676 }
buzbee311ca162013-02-28 15:56:43 -0800677 }
678 }
679 }
buzbee311ca162013-02-28 15:56:43 -0800680}
681
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700682/* Try to make common case the fallthrough path. */
buzbee0d829482013-10-11 15:24:55 -0700683bool MIRGraph::LayoutBlocks(BasicBlock* bb) {
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700684 // TODO: For now, just looking for direct throws. Consider generalizing for profile feedback.
buzbee311ca162013-02-28 15:56:43 -0800685 if (!bb->explicit_throw) {
686 return false;
687 }
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700688
689 // If we visited it, we are done.
690 if (bb->visited) {
691 return false;
692 }
693 bb->visited = true;
694
buzbee311ca162013-02-28 15:56:43 -0800695 BasicBlock* walker = bb;
696 while (true) {
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700697 // Check termination conditions.
buzbee311ca162013-02-28 15:56:43 -0800698 if ((walker->block_type == kEntryBlock) || (Predecessors(walker) != 1)) {
699 break;
700 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100701 DCHECK(!walker->predecessors.empty());
702 BasicBlock* prev = GetBasicBlock(walker->predecessors[0]);
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700703
704 // If we visited the predecessor, we are done.
705 if (prev->visited) {
706 return false;
707 }
708 prev->visited = true;
709
buzbee311ca162013-02-28 15:56:43 -0800710 if (prev->conditional_branch) {
buzbee0d829482013-10-11 15:24:55 -0700711 if (GetBasicBlock(prev->fall_through) == walker) {
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700712 // Already done - return.
buzbee311ca162013-02-28 15:56:43 -0800713 break;
714 }
buzbee0d829482013-10-11 15:24:55 -0700715 DCHECK_EQ(walker, GetBasicBlock(prev->taken));
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700716 // Got one. Flip it and exit.
buzbee311ca162013-02-28 15:56:43 -0800717 Instruction::Code opcode = prev->last_mir_insn->dalvikInsn.opcode;
718 switch (opcode) {
719 case Instruction::IF_EQ: opcode = Instruction::IF_NE; break;
720 case Instruction::IF_NE: opcode = Instruction::IF_EQ; break;
721 case Instruction::IF_LT: opcode = Instruction::IF_GE; break;
722 case Instruction::IF_GE: opcode = Instruction::IF_LT; break;
723 case Instruction::IF_GT: opcode = Instruction::IF_LE; break;
724 case Instruction::IF_LE: opcode = Instruction::IF_GT; break;
725 case Instruction::IF_EQZ: opcode = Instruction::IF_NEZ; break;
726 case Instruction::IF_NEZ: opcode = Instruction::IF_EQZ; break;
727 case Instruction::IF_LTZ: opcode = Instruction::IF_GEZ; break;
728 case Instruction::IF_GEZ: opcode = Instruction::IF_LTZ; break;
729 case Instruction::IF_GTZ: opcode = Instruction::IF_LEZ; break;
730 case Instruction::IF_LEZ: opcode = Instruction::IF_GTZ; break;
731 default: LOG(FATAL) << "Unexpected opcode " << opcode;
732 }
733 prev->last_mir_insn->dalvikInsn.opcode = opcode;
buzbee0d829482013-10-11 15:24:55 -0700734 BasicBlockId t_bb = prev->taken;
buzbee311ca162013-02-28 15:56:43 -0800735 prev->taken = prev->fall_through;
736 prev->fall_through = t_bb;
737 break;
738 }
739 walker = prev;
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700740
741 if (walker->visited) {
742 break;
743 }
buzbee311ca162013-02-28 15:56:43 -0800744 }
745 return false;
746}
747
748/* Combine any basic blocks terminated by instructions that we now know can't throw */
Ian Rogers6a3c1fc2014-10-31 00:33:20 -0700749void MIRGraph::CombineBlocks(class BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800750 // Loop here to allow combining a sequence of blocks
Vladimir Marko312eb252014-10-07 15:01:57 +0100751 while ((bb->block_type == kDalvikByteCode) &&
752 (bb->last_mir_insn != nullptr) &&
753 (static_cast<int>(bb->last_mir_insn->dalvikInsn.opcode) == kMirOpCheck)) {
754 MIR* mir = bb->last_mir_insn;
755 DCHECK(bb->first_mir_insn != nullptr);
756
757 // Grab the attributes from the paired opcode.
758 MIR* throw_insn = mir->meta.throw_insn;
759 uint64_t df_attributes = GetDataFlowAttributes(throw_insn);
760
761 // Don't combine if the throw_insn can still throw NPE.
762 if ((df_attributes & DF_HAS_NULL_CHKS) != 0 &&
763 (throw_insn->optimization_flags & MIR_IGNORE_NULL_CHECK) == 0) {
764 break;
765 }
766 // Now whitelist specific instructions.
767 bool ok = false;
768 if ((df_attributes & DF_IFIELD) != 0) {
769 // Combine only if fast, otherwise weird things can happen.
770 const MirIFieldLoweringInfo& field_info = GetIFieldLoweringInfo(throw_insn);
Serguei Katkov08794a92014-11-06 13:56:13 +0600771 ok = (df_attributes & DF_DA) ? field_info.FastGet() : field_info.FastPut();
Vladimir Marko312eb252014-10-07 15:01:57 +0100772 } else if ((df_attributes & DF_SFIELD) != 0) {
773 // Combine only if fast, otherwise weird things can happen.
774 const MirSFieldLoweringInfo& field_info = GetSFieldLoweringInfo(throw_insn);
Serguei Katkov08794a92014-11-06 13:56:13 +0600775 bool fast = ((df_attributes & DF_DA) ? field_info.FastGet() : field_info.FastPut());
Vladimir Marko312eb252014-10-07 15:01:57 +0100776 // Don't combine if the SGET/SPUT can call <clinit>().
Vladimir Marko66c6d7b2014-10-16 15:41:48 +0100777 bool clinit = !field_info.IsClassInitialized() &&
778 (throw_insn->optimization_flags & MIR_CLASS_IS_INITIALIZED) == 0;
Vladimir Marko312eb252014-10-07 15:01:57 +0100779 ok = fast && !clinit;
780 } else if ((df_attributes & DF_HAS_RANGE_CHKS) != 0) {
781 // Only AGET/APUT have range checks. We have processed the AGET/APUT null check above.
782 DCHECK_NE(throw_insn->optimization_flags & MIR_IGNORE_NULL_CHECK, 0);
783 ok = ((throw_insn->optimization_flags & MIR_IGNORE_RANGE_CHECK) != 0);
784 } else if ((throw_insn->dalvikInsn.FlagsOf() & Instruction::kThrow) == 0) {
785 // We can encounter a non-throwing insn here thanks to inlining or other optimizations.
786 ok = true;
787 } else if (throw_insn->dalvikInsn.opcode == Instruction::ARRAY_LENGTH ||
788 throw_insn->dalvikInsn.opcode == Instruction::FILL_ARRAY_DATA ||
789 static_cast<int>(throw_insn->dalvikInsn.opcode) == kMirOpNullCheck) {
790 // No more checks for these (null check was processed above).
791 ok = true;
792 }
793 if (!ok) {
buzbee311ca162013-02-28 15:56:43 -0800794 break;
795 }
796
buzbee311ca162013-02-28 15:56:43 -0800797 // OK - got one. Combine
buzbee0d829482013-10-11 15:24:55 -0700798 BasicBlock* bb_next = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800799 DCHECK(!bb_next->catch_entry);
Vladimir Marko312eb252014-10-07 15:01:57 +0100800 DCHECK_EQ(bb_next->predecessors.size(), 1u);
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -0700801
802 // Now move instructions from bb_next to bb. Start off with doing a sanity check
803 // that kMirOpCheck's throw instruction is first one in the bb_next.
buzbee311ca162013-02-28 15:56:43 -0800804 DCHECK_EQ(bb_next->first_mir_insn, throw_insn);
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -0700805 // Now move all instructions (throw instruction to last one) from bb_next to bb.
806 MIR* last_to_move = bb_next->last_mir_insn;
807 bb_next->RemoveMIRList(throw_insn, last_to_move);
808 bb->InsertMIRListAfter(bb->last_mir_insn, throw_insn, last_to_move);
809 // The kMirOpCheck instruction is not needed anymore.
810 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
811 bb->RemoveMIR(mir);
812
Vladimir Marko312eb252014-10-07 15:01:57 +0100813 // Before we overwrite successors, remove their predecessor links to bb.
814 bb_next->ErasePredecessor(bb->id);
815 if (bb->taken != NullBasicBlockId) {
816 DCHECK_EQ(bb->successor_block_list_type, kNotUsed);
817 BasicBlock* bb_taken = GetBasicBlock(bb->taken);
818 // bb->taken will be overwritten below.
819 DCHECK_EQ(bb_taken->block_type, kExceptionHandling);
820 DCHECK_EQ(bb_taken->predecessors.size(), 1u);
821 DCHECK_EQ(bb_taken->predecessors[0], bb->id);
822 bb_taken->predecessors.clear();
823 bb_taken->block_type = kDead;
824 DCHECK(bb_taken->data_flow_info == nullptr);
825 } else {
826 DCHECK_EQ(bb->successor_block_list_type, kCatch);
827 for (SuccessorBlockInfo* succ_info : bb->successor_blocks) {
828 if (succ_info->block != NullBasicBlockId) {
829 BasicBlock* succ_bb = GetBasicBlock(succ_info->block);
830 DCHECK(succ_bb->catch_entry);
831 succ_bb->ErasePredecessor(bb->id);
832 if (succ_bb->predecessors.empty()) {
833 succ_bb->KillUnreachable(this);
834 }
835 }
836 }
837 }
buzbee311ca162013-02-28 15:56:43 -0800838 // Use the successor info from the next block
buzbee0d829482013-10-11 15:24:55 -0700839 bb->successor_block_list_type = bb_next->successor_block_list_type;
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100840 bb->successor_blocks.swap(bb_next->successor_blocks); // Swap instead of copying.
Vladimir Marko312eb252014-10-07 15:01:57 +0100841 bb_next->successor_block_list_type = kNotUsed;
buzbee311ca162013-02-28 15:56:43 -0800842 // Use the ending block linkage from the next block
843 bb->fall_through = bb_next->fall_through;
Vladimir Marko312eb252014-10-07 15:01:57 +0100844 bb_next->fall_through = NullBasicBlockId;
buzbee311ca162013-02-28 15:56:43 -0800845 bb->taken = bb_next->taken;
Vladimir Marko312eb252014-10-07 15:01:57 +0100846 bb_next->taken = NullBasicBlockId;
buzbee311ca162013-02-28 15:56:43 -0800847 /*
Junmo Parkf1770fd2014-08-12 09:34:54 +0900848 * If lower-half of pair of blocks to combine contained
849 * a return or a conditional branch or an explicit throw,
850 * move the flag to the newly combined block.
buzbee311ca162013-02-28 15:56:43 -0800851 */
852 bb->terminated_by_return = bb_next->terminated_by_return;
Junmo Parkf1770fd2014-08-12 09:34:54 +0900853 bb->conditional_branch = bb_next->conditional_branch;
854 bb->explicit_throw = bb_next->explicit_throw;
Vladimir Marko312eb252014-10-07 15:01:57 +0100855 // Merge the use_lvn flag.
856 bb->use_lvn |= bb_next->use_lvn;
857
858 // Kill the unused block.
859 bb_next->data_flow_info = nullptr;
buzbee311ca162013-02-28 15:56:43 -0800860
861 /*
862 * NOTE: we aren't updating all dataflow info here. Should either make sure this pass
863 * happens after uses of i_dominated, dom_frontier or update the dataflow info here.
Vladimir Marko312eb252014-10-07 15:01:57 +0100864 * NOTE: GVN uses bb->data_flow_info->live_in_v which is unaffected by the block merge.
buzbee311ca162013-02-28 15:56:43 -0800865 */
866
Vladimir Marko312eb252014-10-07 15:01:57 +0100867 // Kill bb_next and remap now-dead id to parent.
buzbee311ca162013-02-28 15:56:43 -0800868 bb_next->block_type = kDead;
Vladimir Marko312eb252014-10-07 15:01:57 +0100869 bb_next->data_flow_info = nullptr; // Must be null for dead blocks. (Relied on by the GVN.)
buzbee1fd33462013-03-25 13:40:45 -0700870 block_id_map_.Overwrite(bb_next->id, bb->id);
Vladimir Marko312eb252014-10-07 15:01:57 +0100871 // Update predecessors in children.
872 ChildBlockIterator iter(bb, this);
873 for (BasicBlock* child = iter.Next(); child != nullptr; child = iter.Next()) {
874 child->UpdatePredecessor(bb_next->id, bb->id);
875 }
876
877 // DFS orders are not up to date anymore.
878 dfs_orders_up_to_date_ = false;
buzbee311ca162013-02-28 15:56:43 -0800879
880 // Now, loop back and see if we can keep going
881 }
buzbee311ca162013-02-28 15:56:43 -0800882}
883
Vladimir Marko67c72b82014-10-09 12:26:10 +0100884bool MIRGraph::EliminateNullChecksGate() {
885 if ((cu_->disable_opt & (1 << kNullCheckElimination)) != 0 ||
886 (merged_df_flags_ & DF_HAS_NULL_CHKS) == 0) {
887 return false;
Vladimir Markobfea9c22014-01-17 17:49:33 +0000888 }
Vladimir Marko67c72b82014-10-09 12:26:10 +0100889
Vladimir Marko67c72b82014-10-09 12:26:10 +0100890 DCHECK(temp_scoped_alloc_.get() == nullptr);
891 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -0700892 temp_.nce.num_vregs = GetNumOfCodeAndTempVRs();
Vladimir Markof585e542014-11-21 13:41:32 +0000893 temp_.nce.work_vregs_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
894 temp_scoped_alloc_.get(), temp_.nce.num_vregs, false, kBitMapNullCheck);
895 temp_.nce.ending_vregs_to_check_matrix = static_cast<ArenaBitVector**>(
Vladimir Marko5229cf12014-10-09 14:57:59 +0100896 temp_scoped_alloc_->Alloc(sizeof(ArenaBitVector*) * GetNumBlocks(), kArenaAllocMisc));
Vladimir Markof585e542014-11-21 13:41:32 +0000897 std::fill_n(temp_.nce.ending_vregs_to_check_matrix, GetNumBlocks(), nullptr);
Yevgeny Rouban423b1372014-10-15 17:32:25 +0700898
899 // reset MIR_MARK
900 AllNodesIterator iter(this);
901 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
902 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
903 mir->optimization_flags &= ~MIR_MARK;
904 }
905 }
906
Vladimir Marko67c72b82014-10-09 12:26:10 +0100907 return true;
Vladimir Markobfea9c22014-01-17 17:49:33 +0000908}
909
buzbee1da1e2f2013-11-15 13:37:01 -0800910/*
Vladimir Marko67c72b82014-10-09 12:26:10 +0100911 * Eliminate unnecessary null checks for a basic block.
buzbee1da1e2f2013-11-15 13:37:01 -0800912 */
Vladimir Marko67c72b82014-10-09 12:26:10 +0100913bool MIRGraph::EliminateNullChecks(BasicBlock* bb) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100914 if (bb->block_type != kDalvikByteCode && bb->block_type != kEntryBlock) {
915 // Ignore the kExitBlock as well.
916 DCHECK(bb->first_mir_insn == nullptr);
917 return false;
918 }
buzbee311ca162013-02-28 15:56:43 -0800919
Vladimir Markof585e542014-11-21 13:41:32 +0000920 ArenaBitVector* vregs_to_check = temp_.nce.work_vregs_to_check;
Vladimir Marko67c72b82014-10-09 12:26:10 +0100921 /*
922 * Set initial state. Catch blocks don't need any special treatment.
923 */
924 if (bb->block_type == kEntryBlock) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100925 vregs_to_check->ClearAllBits();
Vladimir Marko67c72b82014-10-09 12:26:10 +0100926 // Assume all ins are objects.
927 for (uint16_t in_reg = GetFirstInVR();
928 in_reg < GetNumOfCodeVRs(); in_reg++) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100929 vregs_to_check->SetBit(in_reg);
Vladimir Marko67c72b82014-10-09 12:26:10 +0100930 }
931 if ((cu_->access_flags & kAccStatic) == 0) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100932 // If non-static method, mark "this" as non-null.
Vladimir Marko67c72b82014-10-09 12:26:10 +0100933 int this_reg = GetFirstInVR();
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100934 vregs_to_check->ClearBit(this_reg);
Vladimir Marko67c72b82014-10-09 12:26:10 +0100935 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100936 } else {
937 DCHECK_EQ(bb->block_type, kDalvikByteCode);
938 // Starting state is union of all incoming arcs.
939 bool copied_first = false;
940 for (BasicBlockId pred_id : bb->predecessors) {
Vladimir Markof585e542014-11-21 13:41:32 +0000941 if (temp_.nce.ending_vregs_to_check_matrix[pred_id] == nullptr) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100942 continue;
943 }
944 BasicBlock* pred_bb = GetBasicBlock(pred_id);
945 DCHECK(pred_bb != nullptr);
946 MIR* null_check_insn = nullptr;
947 if (pred_bb->block_type == kDalvikByteCode) {
948 // Check to see if predecessor had an explicit null-check.
949 MIR* last_insn = pred_bb->last_mir_insn;
950 if (last_insn != nullptr) {
951 Instruction::Code last_opcode = last_insn->dalvikInsn.opcode;
952 if ((last_opcode == Instruction::IF_EQZ && pred_bb->fall_through == bb->id) ||
953 (last_opcode == Instruction::IF_NEZ && pred_bb->taken == bb->id)) {
954 // Remember the null check insn if there's no other predecessor requiring null check.
955 if (!copied_first || !vregs_to_check->IsBitSet(last_insn->dalvikInsn.vA)) {
956 null_check_insn = last_insn;
957 }
buzbee1da1e2f2013-11-15 13:37:01 -0800958 }
Ian Rogers22fd6a02013-06-13 15:06:54 -0700959 }
960 }
Vladimir Marko67c72b82014-10-09 12:26:10 +0100961 if (!copied_first) {
962 copied_first = true;
Vladimir Markof585e542014-11-21 13:41:32 +0000963 vregs_to_check->Copy(temp_.nce.ending_vregs_to_check_matrix[pred_id]);
Vladimir Marko67c72b82014-10-09 12:26:10 +0100964 } else {
Vladimir Markof585e542014-11-21 13:41:32 +0000965 vregs_to_check->Union(temp_.nce.ending_vregs_to_check_matrix[pred_id]);
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100966 }
967 if (null_check_insn != nullptr) {
968 vregs_to_check->ClearBit(null_check_insn->dalvikInsn.vA);
Vladimir Marko67c72b82014-10-09 12:26:10 +0100969 }
970 }
971 DCHECK(copied_first); // At least one predecessor must have been processed before this bb.
buzbee311ca162013-02-28 15:56:43 -0800972 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100973 // At this point, vregs_to_check shows which sregs have an object definition with
Vladimir Marko67c72b82014-10-09 12:26:10 +0100974 // no intervening uses.
buzbee311ca162013-02-28 15:56:43 -0800975
976 // Walk through the instruction in the block, updating as necessary
977 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Jean Christophe Beylercc794c32014-05-02 09:34:13 -0700978 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee311ca162013-02-28 15:56:43 -0800979
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -0700980 if ((df_attributes & DF_NULL_TRANSFER_N) != 0u) {
981 // The algorithm was written in a phi agnostic way.
982 continue;
983 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100984
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000985 // Might need a null check?
986 if (df_attributes & DF_HAS_NULL_CHKS) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100987 int src_vreg;
988 if (df_attributes & DF_NULL_CHK_OUT0) {
989 DCHECK_NE(df_attributes & DF_IS_INVOKE, 0u);
990 src_vreg = mir->dalvikInsn.vC;
991 } else if (df_attributes & DF_NULL_CHK_B) {
992 DCHECK_NE(df_attributes & DF_REF_B, 0u);
993 src_vreg = mir->dalvikInsn.vB;
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000994 } else {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100995 DCHECK_NE(df_attributes & DF_NULL_CHK_A, 0u);
996 DCHECK_NE(df_attributes & DF_REF_A, 0u);
997 src_vreg = mir->dalvikInsn.vA;
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000998 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100999 if (!vregs_to_check->IsBitSet(src_vreg)) {
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001000 // Eliminate the null check.
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001001 mir->optimization_flags |= MIR_MARK;
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001002 } else {
1003 // Do the null check.
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001004 mir->optimization_flags &= ~MIR_MARK;
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001005 // Mark src_vreg as null-checked.
1006 vregs_to_check->ClearBit(src_vreg);
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001007 }
1008 }
1009
1010 if ((df_attributes & DF_A_WIDE) ||
1011 (df_attributes & (DF_REF_A | DF_SETS_CONST | DF_NULL_TRANSFER)) == 0) {
1012 continue;
1013 }
1014
1015 /*
1016 * First, mark all object definitions as requiring null check.
1017 * Note: we can't tell if a CONST definition might be used as an object, so treat
1018 * them all as object definitions.
1019 */
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001020 if ((df_attributes & (DF_DA | DF_REF_A)) == (DF_DA | DF_REF_A) ||
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001021 (df_attributes & DF_SETS_CONST)) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001022 vregs_to_check->SetBit(mir->dalvikInsn.vA);
buzbee4db179d2013-10-23 12:16:39 -07001023 }
1024
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001025 // Then, remove mark from all object definitions we know are non-null.
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001026 if (df_attributes & DF_NON_NULL_DST) {
1027 // Mark target of NEW* as non-null
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001028 DCHECK_NE(df_attributes & DF_REF_A, 0u);
1029 vregs_to_check->ClearBit(mir->dalvikInsn.vA);
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001030 }
1031
buzbee311ca162013-02-28 15:56:43 -08001032 // Mark non-null returns from invoke-style NEW*
1033 if (df_attributes & DF_NON_NULL_RET) {
1034 MIR* next_mir = mir->next;
1035 // Next should be an MOVE_RESULT_OBJECT
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001036 if (UNLIKELY(next_mir == nullptr)) {
1037 // The MethodVerifier makes sure there's no MOVE_RESULT at the catch entry or branch
1038 // target, so the MOVE_RESULT cannot be broken away into another block.
1039 LOG(WARNING) << "Unexpected end of block following new";
1040 } else if (UNLIKELY(next_mir->dalvikInsn.opcode != Instruction::MOVE_RESULT_OBJECT)) {
1041 LOG(WARNING) << "Unexpected opcode following new: " << next_mir->dalvikInsn.opcode;
buzbee311ca162013-02-28 15:56:43 -08001042 } else {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001043 // Mark as null checked.
1044 vregs_to_check->ClearBit(next_mir->dalvikInsn.vA);
buzbee311ca162013-02-28 15:56:43 -08001045 }
1046 }
1047
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001048 // Propagate null check state on register copies.
1049 if (df_attributes & DF_NULL_TRANSFER_0) {
1050 DCHECK_EQ(df_attributes | ~(DF_DA | DF_REF_A | DF_UB | DF_REF_B), static_cast<uint64_t>(-1));
1051 if (vregs_to_check->IsBitSet(mir->dalvikInsn.vB)) {
1052 vregs_to_check->SetBit(mir->dalvikInsn.vA);
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001053 } else {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001054 vregs_to_check->ClearBit(mir->dalvikInsn.vA);
buzbee311ca162013-02-28 15:56:43 -08001055 }
1056 }
buzbee311ca162013-02-28 15:56:43 -08001057 }
1058
1059 // Did anything change?
Vladimir Markobfea9c22014-01-17 17:49:33 +00001060 bool nce_changed = false;
Vladimir Markof585e542014-11-21 13:41:32 +00001061 ArenaBitVector* old_ending_ssa_regs_to_check = temp_.nce.ending_vregs_to_check_matrix[bb->id];
Vladimir Marko5229cf12014-10-09 14:57:59 +01001062 if (old_ending_ssa_regs_to_check == nullptr) {
Vladimir Marko67c72b82014-10-09 12:26:10 +01001063 DCHECK(temp_scoped_alloc_.get() != nullptr);
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001064 nce_changed = vregs_to_check->GetHighestBitSet() != -1;
Vladimir Markof585e542014-11-21 13:41:32 +00001065 temp_.nce.ending_vregs_to_check_matrix[bb->id] = vregs_to_check;
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001066 // Create a new vregs_to_check for next BB.
Vladimir Markof585e542014-11-21 13:41:32 +00001067 temp_.nce.work_vregs_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
1068 temp_scoped_alloc_.get(), temp_.nce.num_vregs, false, kBitMapNullCheck);
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001069 } else if (!vregs_to_check->SameBitsSet(old_ending_ssa_regs_to_check)) {
Vladimir Marko67c72b82014-10-09 12:26:10 +01001070 nce_changed = true;
Vladimir Markof585e542014-11-21 13:41:32 +00001071 temp_.nce.ending_vregs_to_check_matrix[bb->id] = vregs_to_check;
1072 temp_.nce.work_vregs_to_check = old_ending_ssa_regs_to_check; // Reuse for next BB.
buzbee311ca162013-02-28 15:56:43 -08001073 }
Vladimir Marko67c72b82014-10-09 12:26:10 +01001074 return nce_changed;
buzbee311ca162013-02-28 15:56:43 -08001075}
1076
Vladimir Marko67c72b82014-10-09 12:26:10 +01001077void MIRGraph::EliminateNullChecksEnd() {
1078 // Clean up temporaries.
Vladimir Markof585e542014-11-21 13:41:32 +00001079 temp_.nce.num_vregs = 0u;
1080 temp_.nce.work_vregs_to_check = nullptr;
1081 temp_.nce.ending_vregs_to_check_matrix = nullptr;
Vladimir Marko67c72b82014-10-09 12:26:10 +01001082 DCHECK(temp_scoped_alloc_.get() != nullptr);
1083 temp_scoped_alloc_.reset();
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001084
1085 // converge MIR_MARK with MIR_IGNORE_NULL_CHECK
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001086 AllNodesIterator iter(this);
1087 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
1088 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001089 constexpr int kMarkToIgnoreNullCheckShift = kMIRMark - kMIRIgnoreNullCheck;
Andreas Gampe785d2f22014-11-03 22:57:30 -08001090 static_assert(kMarkToIgnoreNullCheckShift > 0, "Not a valid right-shift");
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001091 uint16_t mirMarkAdjustedToIgnoreNullCheck =
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001092 (mir->optimization_flags & MIR_MARK) >> kMarkToIgnoreNullCheckShift;
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001093 mir->optimization_flags |= mirMarkAdjustedToIgnoreNullCheck;
1094 }
1095 }
Vladimir Marko67c72b82014-10-09 12:26:10 +01001096}
1097
1098/*
1099 * Perform type and size inference for a basic block.
1100 */
1101bool MIRGraph::InferTypes(BasicBlock* bb) {
1102 if (bb->data_flow_info == nullptr) return false;
1103
1104 bool infer_changed = false;
1105 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
1106 if (mir->ssa_rep == NULL) {
1107 continue;
1108 }
1109
1110 // Propagate type info.
1111 infer_changed = InferTypeAndSize(bb, mir, infer_changed);
1112 }
1113
1114 return infer_changed;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001115}
1116
1117bool MIRGraph::EliminateClassInitChecksGate() {
1118 if ((cu_->disable_opt & (1 << kClassInitCheckElimination)) != 0 ||
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001119 (merged_df_flags_ & DF_CLINIT) == 0) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001120 return false;
1121 }
1122
Vladimir Markobfea9c22014-01-17 17:49:33 +00001123 DCHECK(temp_scoped_alloc_.get() == nullptr);
1124 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
1125
1126 // Each insn we use here has at least 2 code units, offset/2 will be a unique index.
Razvan A Lupusoru75035972014-09-11 15:24:59 -07001127 const size_t end = (GetNumDalvikInsns() + 1u) / 2u;
Vladimir Markof585e542014-11-21 13:41:32 +00001128 temp_.cice.indexes = static_cast<uint16_t*>(
1129 temp_scoped_alloc_->Alloc(end * sizeof(*temp_.cice.indexes), kArenaAllocGrowableArray));
1130 std::fill_n(temp_.cice.indexes, end, 0xffffu);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001131
1132 uint32_t unique_class_count = 0u;
1133 {
1134 // Get unique_class_count and store indexes in temp_insn_data_ using a map on a nested
1135 // ScopedArenaAllocator.
1136
1137 // Embed the map value in the entry to save space.
1138 struct MapEntry {
1139 // Map key: the class identified by the declaring dex file and type index.
1140 const DexFile* declaring_dex_file;
1141 uint16_t declaring_class_idx;
1142 // Map value: index into bit vectors of classes requiring initialization checks.
1143 uint16_t index;
1144 };
1145 struct MapEntryComparator {
1146 bool operator()(const MapEntry& lhs, const MapEntry& rhs) const {
1147 if (lhs.declaring_class_idx != rhs.declaring_class_idx) {
1148 return lhs.declaring_class_idx < rhs.declaring_class_idx;
1149 }
1150 return lhs.declaring_dex_file < rhs.declaring_dex_file;
1151 }
1152 };
1153
Vladimir Markobfea9c22014-01-17 17:49:33 +00001154 ScopedArenaAllocator allocator(&cu_->arena_stack);
Vladimir Marko69f08ba2014-04-11 12:28:11 +01001155 ScopedArenaSet<MapEntry, MapEntryComparator> class_to_index_map(MapEntryComparator(),
1156 allocator.Adapter());
Vladimir Markobfea9c22014-01-17 17:49:33 +00001157
1158 // First, find all SGET/SPUTs that may need class initialization checks, record INVOKE_STATICs.
1159 AllNodesIterator iter(this);
1160 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001161 if (bb->block_type == kDalvikByteCode) {
1162 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001163 if (IsInstructionSGetOrSPut(mir->dalvikInsn.opcode)) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001164 const MirSFieldLoweringInfo& field_info = GetSFieldLoweringInfo(mir);
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001165 if (!field_info.IsReferrersClass()) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001166 DCHECK_LT(class_to_index_map.size(), 0xffffu);
1167 MapEntry entry = {
1168 // Treat unresolved fields as if each had its own class.
1169 field_info.IsResolved() ? field_info.DeclaringDexFile()
1170 : nullptr,
1171 field_info.IsResolved() ? field_info.DeclaringClassIndex()
1172 : field_info.FieldIndex(),
1173 static_cast<uint16_t>(class_to_index_map.size())
1174 };
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001175 uint16_t index = class_to_index_map.insert(entry).first->index;
Vladimir Markof585e542014-11-21 13:41:32 +00001176 // Using offset/2 for index into temp_.cice.indexes.
1177 temp_.cice.indexes[mir->offset / 2u] = index;
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001178 }
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001179 } else if (IsInstructionInvokeStatic(mir->dalvikInsn.opcode)) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001180 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(mir);
1181 DCHECK(method_info.IsStatic());
1182 if (method_info.FastPath() && !method_info.IsReferrersClass()) {
1183 MapEntry entry = {
1184 method_info.DeclaringDexFile(),
1185 method_info.DeclaringClassIndex(),
1186 static_cast<uint16_t>(class_to_index_map.size())
1187 };
1188 uint16_t index = class_to_index_map.insert(entry).first->index;
Vladimir Markof585e542014-11-21 13:41:32 +00001189 // Using offset/2 for index into temp_.cice.indexes.
1190 temp_.cice.indexes[mir->offset / 2u] = index;
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001191 }
Vladimir Markobfea9c22014-01-17 17:49:33 +00001192 }
Vladimir Markobfea9c22014-01-17 17:49:33 +00001193 }
1194 }
1195 }
1196 unique_class_count = static_cast<uint32_t>(class_to_index_map.size());
1197 }
1198
1199 if (unique_class_count == 0u) {
1200 // All SGET/SPUTs refer to initialized classes. Nothing to do.
Vladimir Markof585e542014-11-21 13:41:32 +00001201 temp_.cice.indexes = nullptr;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001202 temp_scoped_alloc_.reset();
1203 return false;
1204 }
1205
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001206 // 2 bits for each class: is class initialized, is class in dex cache.
Vladimir Markof585e542014-11-21 13:41:32 +00001207 temp_.cice.num_class_bits = 2u * unique_class_count;
1208 temp_.cice.work_classes_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
1209 temp_scoped_alloc_.get(), temp_.cice.num_class_bits, false, kBitMapClInitCheck);
1210 temp_.cice.ending_classes_to_check_matrix = static_cast<ArenaBitVector**>(
Vladimir Marko5229cf12014-10-09 14:57:59 +01001211 temp_scoped_alloc_->Alloc(sizeof(ArenaBitVector*) * GetNumBlocks(), kArenaAllocMisc));
Vladimir Markof585e542014-11-21 13:41:32 +00001212 std::fill_n(temp_.cice.ending_classes_to_check_matrix, GetNumBlocks(), nullptr);
1213 DCHECK_GT(temp_.cice.num_class_bits, 0u);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001214 return true;
1215}
1216
1217/*
1218 * Eliminate unnecessary class initialization checks for a basic block.
1219 */
1220bool MIRGraph::EliminateClassInitChecks(BasicBlock* bb) {
1221 DCHECK_EQ((cu_->disable_opt & (1 << kClassInitCheckElimination)), 0u);
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001222 if (bb->block_type != kDalvikByteCode && bb->block_type != kEntryBlock) {
1223 // Ignore the kExitBlock as well.
1224 DCHECK(bb->first_mir_insn == nullptr);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001225 return false;
1226 }
1227
1228 /*
Vladimir Marko0a810d22014-07-11 14:44:36 +01001229 * Set initial state. Catch blocks don't need any special treatment.
Vladimir Markobfea9c22014-01-17 17:49:33 +00001230 */
Vladimir Markof585e542014-11-21 13:41:32 +00001231 ArenaBitVector* classes_to_check = temp_.cice.work_classes_to_check;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001232 DCHECK(classes_to_check != nullptr);
Vladimir Marko0a810d22014-07-11 14:44:36 +01001233 if (bb->block_type == kEntryBlock) {
Vladimir Markof585e542014-11-21 13:41:32 +00001234 classes_to_check->SetInitialBits(temp_.cice.num_class_bits);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001235 } else {
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001236 // Starting state is union of all incoming arcs.
1237 bool copied_first = false;
1238 for (BasicBlockId pred_id : bb->predecessors) {
Vladimir Markof585e542014-11-21 13:41:32 +00001239 if (temp_.cice.ending_classes_to_check_matrix[pred_id] == nullptr) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001240 continue;
1241 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001242 if (!copied_first) {
1243 copied_first = true;
Vladimir Markof585e542014-11-21 13:41:32 +00001244 classes_to_check->Copy(temp_.cice.ending_classes_to_check_matrix[pred_id]);
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001245 } else {
Vladimir Markof585e542014-11-21 13:41:32 +00001246 classes_to_check->Union(temp_.cice.ending_classes_to_check_matrix[pred_id]);
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001247 }
Vladimir Markobfea9c22014-01-17 17:49:33 +00001248 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001249 DCHECK(copied_first); // At least one predecessor must have been processed before this bb.
Vladimir Markobfea9c22014-01-17 17:49:33 +00001250 }
1251 // At this point, classes_to_check shows which classes need clinit checks.
1252
1253 // Walk through the instruction in the block, updating as necessary
1254 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
Vladimir Markof585e542014-11-21 13:41:32 +00001255 uint16_t index = temp_.cice.indexes[mir->offset / 2u];
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001256 if (index != 0xffffu) {
1257 bool check_initialization = false;
1258 bool check_dex_cache = false;
1259
1260 // NOTE: index != 0xffff does not guarantee that this is an SGET/SPUT/INVOKE_STATIC.
1261 // Dex instructions with width 1 can have the same offset/2.
1262
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001263 if (IsInstructionSGetOrSPut(mir->dalvikInsn.opcode)) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001264 check_initialization = true;
1265 check_dex_cache = true;
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001266 } else if (IsInstructionInvokeStatic(mir->dalvikInsn.opcode)) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001267 check_initialization = true;
1268 // NOTE: INVOKE_STATIC doesn't guarantee that the type will be in the dex cache.
1269 }
1270
1271 if (check_dex_cache) {
1272 uint32_t check_dex_cache_index = 2u * index + 1u;
1273 if (!classes_to_check->IsBitSet(check_dex_cache_index)) {
1274 // Eliminate the class init check.
1275 mir->optimization_flags |= MIR_CLASS_IS_IN_DEX_CACHE;
1276 } else {
1277 // Do the class init check.
1278 mir->optimization_flags &= ~MIR_CLASS_IS_IN_DEX_CACHE;
1279 }
1280 classes_to_check->ClearBit(check_dex_cache_index);
1281 }
1282 if (check_initialization) {
1283 uint32_t check_clinit_index = 2u * index;
1284 if (!classes_to_check->IsBitSet(check_clinit_index)) {
1285 // Eliminate the class init check.
1286 mir->optimization_flags |= MIR_CLASS_IS_INITIALIZED;
1287 } else {
1288 // Do the class init check.
1289 mir->optimization_flags &= ~MIR_CLASS_IS_INITIALIZED;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001290 }
1291 // Mark the class as initialized.
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001292 classes_to_check->ClearBit(check_clinit_index);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001293 }
1294 }
1295 }
1296
1297 // Did anything change?
1298 bool changed = false;
Vladimir Markof585e542014-11-21 13:41:32 +00001299 ArenaBitVector* old_ending_classes_to_check = temp_.cice.ending_classes_to_check_matrix[bb->id];
Vladimir Marko5229cf12014-10-09 14:57:59 +01001300 if (old_ending_classes_to_check == nullptr) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001301 DCHECK(temp_scoped_alloc_.get() != nullptr);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001302 changed = classes_to_check->GetHighestBitSet() != -1;
Vladimir Markof585e542014-11-21 13:41:32 +00001303 temp_.cice.ending_classes_to_check_matrix[bb->id] = classes_to_check;
Vladimir Marko5229cf12014-10-09 14:57:59 +01001304 // Create a new classes_to_check for next BB.
Vladimir Markof585e542014-11-21 13:41:32 +00001305 temp_.cice.work_classes_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
1306 temp_scoped_alloc_.get(), temp_.cice.num_class_bits, false, kBitMapClInitCheck);
Vladimir Marko5229cf12014-10-09 14:57:59 +01001307 } else if (!classes_to_check->Equal(old_ending_classes_to_check)) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001308 changed = true;
Vladimir Markof585e542014-11-21 13:41:32 +00001309 temp_.cice.ending_classes_to_check_matrix[bb->id] = classes_to_check;
1310 temp_.cice.work_classes_to_check = old_ending_classes_to_check; // Reuse for next BB.
Vladimir Markobfea9c22014-01-17 17:49:33 +00001311 }
1312 return changed;
1313}
1314
1315void MIRGraph::EliminateClassInitChecksEnd() {
1316 // Clean up temporaries.
Vladimir Markof585e542014-11-21 13:41:32 +00001317 temp_.cice.num_class_bits = 0u;
1318 temp_.cice.work_classes_to_check = nullptr;
1319 temp_.cice.ending_classes_to_check_matrix = nullptr;
1320 DCHECK(temp_.cice.indexes != nullptr);
1321 temp_.cice.indexes = nullptr;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001322 DCHECK(temp_scoped_alloc_.get() != nullptr);
1323 temp_scoped_alloc_.reset();
1324}
1325
Vladimir Marko95a05972014-05-30 10:01:32 +01001326bool MIRGraph::ApplyGlobalValueNumberingGate() {
Vladimir Marko415ac882014-09-30 18:09:14 +01001327 if (GlobalValueNumbering::Skip(cu_)) {
Vladimir Marko95a05972014-05-30 10:01:32 +01001328 return false;
1329 }
1330
1331 DCHECK(temp_scoped_alloc_ == nullptr);
1332 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001333 temp_.gvn.ifield_ids_ =
1334 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), ifield_lowering_infos_);
1335 temp_.gvn.sfield_ids_ =
1336 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), sfield_lowering_infos_);
Vladimir Markof585e542014-11-21 13:41:32 +00001337 DCHECK(temp_.gvn.gvn == nullptr);
1338 temp_.gvn.gvn = new (temp_scoped_alloc_.get()) GlobalValueNumbering(
1339 cu_, temp_scoped_alloc_.get(), GlobalValueNumbering::kModeGvn);
Vladimir Marko95a05972014-05-30 10:01:32 +01001340 return true;
1341}
1342
1343bool MIRGraph::ApplyGlobalValueNumbering(BasicBlock* bb) {
Vladimir Markof585e542014-11-21 13:41:32 +00001344 DCHECK(temp_.gvn.gvn != nullptr);
1345 LocalValueNumbering* lvn = temp_.gvn.gvn->PrepareBasicBlock(bb);
Vladimir Marko95a05972014-05-30 10:01:32 +01001346 if (lvn != nullptr) {
1347 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1348 lvn->GetValueNumber(mir);
1349 }
1350 }
Vladimir Markof585e542014-11-21 13:41:32 +00001351 bool change = (lvn != nullptr) && temp_.gvn.gvn->FinishBasicBlock(bb);
Vladimir Marko95a05972014-05-30 10:01:32 +01001352 return change;
1353}
1354
1355void MIRGraph::ApplyGlobalValueNumberingEnd() {
1356 // Perform modifications.
Vladimir Markof585e542014-11-21 13:41:32 +00001357 DCHECK(temp_.gvn.gvn != nullptr);
1358 if (temp_.gvn.gvn->Good()) {
Vladimir Marko415ac882014-09-30 18:09:14 +01001359 if (max_nested_loops_ != 0u) {
Vladimir Markof585e542014-11-21 13:41:32 +00001360 temp_.gvn.gvn->StartPostProcessing();
Vladimir Marko415ac882014-09-30 18:09:14 +01001361 TopologicalSortIterator iter(this);
1362 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
1363 ScopedArenaAllocator allocator(&cu_->arena_stack); // Reclaim memory after each LVN.
Vladimir Markof585e542014-11-21 13:41:32 +00001364 LocalValueNumbering* lvn = temp_.gvn.gvn->PrepareBasicBlock(bb, &allocator);
Vladimir Marko415ac882014-09-30 18:09:14 +01001365 if (lvn != nullptr) {
1366 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1367 lvn->GetValueNumber(mir);
1368 }
Vladimir Markof585e542014-11-21 13:41:32 +00001369 bool change = temp_.gvn.gvn->FinishBasicBlock(bb);
Vladimir Marko415ac882014-09-30 18:09:14 +01001370 DCHECK(!change) << PrettyMethod(cu_->method_idx, *cu_->dex_file);
Vladimir Marko95a05972014-05-30 10:01:32 +01001371 }
Vladimir Marko95a05972014-05-30 10:01:32 +01001372 }
1373 }
Vladimir Marko415ac882014-09-30 18:09:14 +01001374 // GVN was successful, running the LVN would be useless.
1375 cu_->disable_opt |= (1u << kLocalValueNumbering);
Vladimir Marko95a05972014-05-30 10:01:32 +01001376 } else {
1377 LOG(WARNING) << "GVN failed for " << PrettyMethod(cu_->method_idx, *cu_->dex_file);
1378 }
1379
Vladimir Markof585e542014-11-21 13:41:32 +00001380 delete temp_.gvn.gvn;
1381 temp_.gvn.gvn = nullptr;
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001382 temp_.gvn.ifield_ids_ = nullptr;
1383 temp_.gvn.sfield_ids_ = nullptr;
Vladimir Marko95a05972014-05-30 10:01:32 +01001384 DCHECK(temp_scoped_alloc_ != nullptr);
1385 temp_scoped_alloc_.reset();
1386}
1387
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001388void MIRGraph::ComputeInlineIFieldLoweringInfo(uint16_t field_idx, MIR* invoke, MIR* iget_or_iput) {
1389 uint32_t method_index = invoke->meta.method_lowering_info;
Vladimir Markof585e542014-11-21 13:41:32 +00001390 if (temp_.smi.processed_indexes->IsBitSet(method_index)) {
1391 iget_or_iput->meta.ifield_lowering_info = temp_.smi.lowering_infos[method_index];
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001392 DCHECK_EQ(field_idx, GetIFieldLoweringInfo(iget_or_iput).FieldIndex());
1393 return;
1394 }
1395
1396 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(invoke);
1397 MethodReference target = method_info.GetTargetMethod();
1398 DexCompilationUnit inlined_unit(
1399 cu_, cu_->class_loader, cu_->class_linker, *target.dex_file,
1400 nullptr /* code_item not used */, 0u /* class_def_idx not used */, target.dex_method_index,
1401 0u /* access_flags not used */, nullptr /* verified_method not used */);
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001402 DexMemAccessType type = IGetOrIPutMemAccessType(iget_or_iput->dalvikInsn.opcode);
1403 MirIFieldLoweringInfo inlined_field_info(field_idx, type);
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001404 MirIFieldLoweringInfo::Resolve(cu_->compiler_driver, &inlined_unit, &inlined_field_info, 1u);
1405 DCHECK(inlined_field_info.IsResolved());
1406
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001407 uint32_t field_info_index = ifield_lowering_infos_.size();
1408 ifield_lowering_infos_.push_back(inlined_field_info);
Vladimir Markof585e542014-11-21 13:41:32 +00001409 temp_.smi.processed_indexes->SetBit(method_index);
1410 temp_.smi.lowering_infos[method_index] = field_info_index;
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001411 iget_or_iput->meta.ifield_lowering_info = field_info_index;
1412}
1413
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001414bool MIRGraph::InlineSpecialMethodsGate() {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001415 if ((cu_->disable_opt & (1 << kSuppressMethodInlining)) != 0 ||
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001416 method_lowering_infos_.size() == 0u) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001417 return false;
1418 }
1419 if (cu_->compiler_driver->GetMethodInlinerMap() == nullptr) {
1420 // This isn't the Quick compiler.
1421 return false;
1422 }
1423 return true;
1424}
1425
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001426void MIRGraph::InlineSpecialMethodsStart() {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001427 // Prepare for inlining getters/setters. Since we're inlining at most 1 IGET/IPUT from
1428 // each INVOKE, we can index the data by the MIR::meta::method_lowering_info index.
1429
1430 DCHECK(temp_scoped_alloc_.get() == nullptr);
1431 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Vladimir Markof585e542014-11-21 13:41:32 +00001432 temp_.smi.num_indexes = method_lowering_infos_.size();
1433 temp_.smi.processed_indexes = new (temp_scoped_alloc_.get()) ArenaBitVector(
1434 temp_scoped_alloc_.get(), temp_.smi.num_indexes, false, kBitMapMisc);
1435 temp_.smi.processed_indexes->ClearAllBits();
1436 temp_.smi.lowering_infos = static_cast<uint16_t*>(temp_scoped_alloc_->Alloc(
1437 temp_.smi.num_indexes * sizeof(*temp_.smi.lowering_infos), kArenaAllocGrowableArray));
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001438}
1439
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001440void MIRGraph::InlineSpecialMethods(BasicBlock* bb) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001441 if (bb->block_type != kDalvikByteCode) {
1442 return;
1443 }
1444 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Jean Christophe Beyler2ab40eb2014-06-02 09:03:14 -07001445 if (MIR::DecodedInstruction::IsPseudoMirOp(mir->dalvikInsn.opcode)) {
buzbee35ba7f32014-05-31 08:59:01 -07001446 continue;
1447 }
Jean Christophe Beylerfb0ea2d2014-07-29 13:20:42 -07001448 if (!(mir->dalvikInsn.FlagsOf() & Instruction::kInvoke)) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001449 continue;
1450 }
1451 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(mir);
1452 if (!method_info.FastPath()) {
1453 continue;
1454 }
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001455
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001456 InvokeType sharp_type = method_info.GetSharpType();
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001457 if ((sharp_type != kDirect) && (sharp_type != kStatic)) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001458 continue;
1459 }
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001460
1461 if (sharp_type == kStatic) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001462 bool needs_clinit = !method_info.IsClassInitialized() &&
1463 ((mir->optimization_flags & MIR_CLASS_IS_INITIALIZED) == 0);
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001464 if (needs_clinit) {
1465 continue;
1466 }
1467 }
1468
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001469 DCHECK(cu_->compiler_driver->GetMethodInlinerMap() != nullptr);
1470 MethodReference target = method_info.GetTargetMethod();
1471 if (cu_->compiler_driver->GetMethodInlinerMap()->GetMethodInliner(target.dex_file)
1472 ->GenInline(this, bb, mir, target.dex_method_index)) {
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001473 if (cu_->verbose || cu_->print_pass) {
1474 LOG(INFO) << "SpecialMethodInliner: Inlined " << method_info.GetInvokeType() << " ("
1475 << sharp_type << ") call to \"" << PrettyMethod(target.dex_method_index, *target.dex_file)
1476 << "\" from \"" << PrettyMethod(cu_->method_idx, *cu_->dex_file)
1477 << "\" @0x" << std::hex << mir->offset;
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001478 }
1479 }
1480 }
1481}
1482
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001483void MIRGraph::InlineSpecialMethodsEnd() {
Vladimir Markof585e542014-11-21 13:41:32 +00001484 // Clean up temporaries.
1485 DCHECK(temp_.smi.lowering_infos != nullptr);
1486 temp_.smi.lowering_infos = nullptr;
1487 temp_.smi.num_indexes = 0u;
1488 DCHECK(temp_.smi.processed_indexes != nullptr);
1489 temp_.smi.processed_indexes = nullptr;
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001490 DCHECK(temp_scoped_alloc_.get() != nullptr);
1491 temp_scoped_alloc_.reset();
1492}
1493
Brian Carlstrom2ce745c2013-07-17 17:44:30 -07001494void MIRGraph::DumpCheckStats() {
buzbee311ca162013-02-28 15:56:43 -08001495 Checkstats* stats =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +00001496 static_cast<Checkstats*>(arena_->Alloc(sizeof(Checkstats), kArenaAllocDFInfo));
buzbee1fd33462013-03-25 13:40:45 -07001497 checkstats_ = stats;
buzbee56c71782013-09-05 17:13:19 -07001498 AllNodesIterator iter(this);
buzbee311ca162013-02-28 15:56:43 -08001499 for (BasicBlock* bb = iter.Next(); bb != NULL; bb = iter.Next()) {
1500 CountChecks(bb);
1501 }
1502 if (stats->null_checks > 0) {
1503 float eliminated = static_cast<float>(stats->null_checks_eliminated);
1504 float checks = static_cast<float>(stats->null_checks);
1505 LOG(INFO) << "Null Checks: " << PrettyMethod(cu_->method_idx, *cu_->dex_file) << " "
1506 << stats->null_checks_eliminated << " of " << stats->null_checks << " -> "
1507 << (eliminated/checks) * 100.0 << "%";
1508 }
1509 if (stats->range_checks > 0) {
1510 float eliminated = static_cast<float>(stats->range_checks_eliminated);
1511 float checks = static_cast<float>(stats->range_checks);
1512 LOG(INFO) << "Range Checks: " << PrettyMethod(cu_->method_idx, *cu_->dex_file) << " "
1513 << stats->range_checks_eliminated << " of " << stats->range_checks << " -> "
1514 << (eliminated/checks) * 100.0 << "%";
1515 }
1516}
1517
Ian Rogers6a3c1fc2014-10-31 00:33:20 -07001518bool MIRGraph::BuildExtendedBBList(class BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -08001519 if (bb->visited) return false;
1520 if (!((bb->block_type == kEntryBlock) || (bb->block_type == kDalvikByteCode)
1521 || (bb->block_type == kExitBlock))) {
1522 // Ignore special blocks
1523 bb->visited = true;
1524 return false;
1525 }
1526 // Must be head of extended basic block.
1527 BasicBlock* start_bb = bb;
buzbee0d829482013-10-11 15:24:55 -07001528 extended_basic_blocks_.push_back(bb->id);
buzbee311ca162013-02-28 15:56:43 -08001529 bool terminated_by_return = false;
buzbee1da1e2f2013-11-15 13:37:01 -08001530 bool do_local_value_numbering = false;
buzbee311ca162013-02-28 15:56:43 -08001531 // Visit blocks strictly dominated by this head.
1532 while (bb != NULL) {
1533 bb->visited = true;
1534 terminated_by_return |= bb->terminated_by_return;
buzbee1da1e2f2013-11-15 13:37:01 -08001535 do_local_value_numbering |= bb->use_lvn;
buzbee311ca162013-02-28 15:56:43 -08001536 bb = NextDominatedBlock(bb);
1537 }
buzbee1da1e2f2013-11-15 13:37:01 -08001538 if (terminated_by_return || do_local_value_numbering) {
1539 // Do lvn for all blocks in this extended set.
buzbee311ca162013-02-28 15:56:43 -08001540 bb = start_bb;
1541 while (bb != NULL) {
buzbee1da1e2f2013-11-15 13:37:01 -08001542 bb->use_lvn = do_local_value_numbering;
1543 bb->dominates_return = terminated_by_return;
buzbee311ca162013-02-28 15:56:43 -08001544 bb = NextDominatedBlock(bb);
1545 }
1546 }
Brian Carlstrom7934ac22013-07-26 10:54:15 -07001547 return false; // Not iterative - return value will be ignored
buzbee311ca162013-02-28 15:56:43 -08001548}
1549
Brian Carlstrom2ce745c2013-07-17 17:44:30 -07001550void MIRGraph::BasicBlockOptimization() {
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001551 if ((cu_->disable_opt & (1 << kLocalValueNumbering)) == 0) {
1552 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
1553 temp_.gvn.ifield_ids_ =
1554 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), ifield_lowering_infos_);
1555 temp_.gvn.sfield_ids_ =
1556 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), sfield_lowering_infos_);
1557 }
1558
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -08001559 if ((cu_->disable_opt & (1 << kSuppressExceptionEdges)) != 0) {
1560 ClearAllVisitedFlags();
1561 PreOrderDfsIterator iter2(this);
1562 for (BasicBlock* bb = iter2.Next(); bb != NULL; bb = iter2.Next()) {
1563 BuildExtendedBBList(bb);
buzbee311ca162013-02-28 15:56:43 -08001564 }
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -08001565 // Perform extended basic block optimizations.
1566 for (unsigned int i = 0; i < extended_basic_blocks_.size(); i++) {
1567 BasicBlockOpt(GetBasicBlock(extended_basic_blocks_[i]));
1568 }
1569 } else {
1570 PreOrderDfsIterator iter(this);
1571 for (BasicBlock* bb = iter.Next(); bb != NULL; bb = iter.Next()) {
1572 BasicBlockOpt(bb);
1573 }
buzbee311ca162013-02-28 15:56:43 -08001574 }
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001575
1576 // Clean up after LVN.
1577 temp_.gvn.ifield_ids_ = nullptr;
1578 temp_.gvn.sfield_ids_ = nullptr;
1579 temp_scoped_alloc_.reset();
buzbee311ca162013-02-28 15:56:43 -08001580}
1581
1582} // namespace art