Elliott Hughes | 8daa092 | 2011-09-11 13:46:25 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2011 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
| 17 | #include "mutex.h" |
| 18 | |
| 19 | #include <errno.h> |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 20 | #include <sys/time.h> |
Elliott Hughes | 8daa092 | 2011-09-11 13:46:25 -0700 | [diff] [blame] | 21 | |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 22 | #include "atomic.h" |
Elliott Hughes | 07ed66b | 2012-12-12 18:34:25 -0800 | [diff] [blame] | 23 | #include "base/logging.h" |
Ian Rogers | 693ff61 | 2013-02-01 10:56:12 -0800 | [diff] [blame] | 24 | #include "mutex-inl.h" |
Elliott Hughes | 6b35575 | 2012-01-13 16:49:08 -0800 | [diff] [blame] | 25 | #include "runtime.h" |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 26 | #include "scoped_thread_state_change.h" |
Ian Rogers | 04d7aa9 | 2013-03-16 14:29:17 -0700 | [diff] [blame] | 27 | #include "thread-inl.h" |
Elliott Hughes | ffb465f | 2012-03-01 18:46:05 -0800 | [diff] [blame] | 28 | #include "utils.h" |
Elliott Hughes | 8daa092 | 2011-09-11 13:46:25 -0700 | [diff] [blame] | 29 | |
| 30 | namespace art { |
| 31 | |
Ian Rogers | 719d1a3 | 2014-03-06 12:13:39 -0800 | [diff] [blame] | 32 | Mutex* Locks::abort_lock_ = nullptr; |
Andreas Gampe | 7424081 | 2014-04-17 10:35:09 -0700 | [diff] [blame] | 33 | Mutex* Locks::allocated_monitor_ids_lock_ = nullptr; |
Chao-ying Fu | 9e36931 | 2014-05-21 11:20:52 -0700 | [diff] [blame] | 34 | Mutex* Locks::allocated_thread_ids_lock_ = nullptr; |
Ian Rogers | 719d1a3 | 2014-03-06 12:13:39 -0800 | [diff] [blame] | 35 | Mutex* Locks::breakpoint_lock_ = nullptr; |
Ian Rogers | 719d1a3 | 2014-03-06 12:13:39 -0800 | [diff] [blame] | 36 | ReaderWriterMutex* Locks::classlinker_classes_lock_ = nullptr; |
| 37 | ReaderWriterMutex* Locks::heap_bitmap_lock_ = nullptr; |
| 38 | Mutex* Locks::logging_lock_ = nullptr; |
Hiroshi Yamauchi | 3eed93d | 2014-06-04 11:43:59 -0700 | [diff] [blame] | 39 | Mutex* Locks::mem_maps_lock_ = nullptr; |
Chao-ying Fu | 9e36931 | 2014-05-21 11:20:52 -0700 | [diff] [blame] | 40 | Mutex* Locks::modify_ldt_lock_ = nullptr; |
Ian Rogers | 719d1a3 | 2014-03-06 12:13:39 -0800 | [diff] [blame] | 41 | ReaderWriterMutex* Locks::mutator_lock_ = nullptr; |
| 42 | Mutex* Locks::runtime_shutdown_lock_ = nullptr; |
| 43 | Mutex* Locks::thread_list_lock_ = nullptr; |
| 44 | Mutex* Locks::thread_suspend_count_lock_ = nullptr; |
| 45 | Mutex* Locks::trace_lock_ = nullptr; |
| 46 | Mutex* Locks::profiler_lock_ = nullptr; |
| 47 | Mutex* Locks::unexpected_signal_lock_ = nullptr; |
| 48 | Mutex* Locks::intern_table_lock_ = nullptr; |
| 49 | |
| 50 | struct AllMutexData { |
| 51 | // A guard for all_mutexes_ that's not a mutex (Mutexes must CAS to acquire and busy wait). |
| 52 | Atomic<const BaseMutex*> all_mutexes_guard; |
| 53 | // All created mutexes guarded by all_mutexes_guard_. |
| 54 | std::set<BaseMutex*>* all_mutexes; |
| 55 | AllMutexData() : all_mutexes(NULL) {} |
| 56 | }; |
| 57 | static struct AllMutexData gAllMutexData[kAllMutexDataSize]; |
| 58 | |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 59 | #if ART_USE_FUTEXES |
| 60 | static bool ComputeRelativeTimeSpec(timespec* result_ts, const timespec& lhs, const timespec& rhs) { |
Brian Carlstrom | fb6996f | 2013-07-18 18:21:14 -0700 | [diff] [blame] | 61 | const int32_t one_sec = 1000 * 1000 * 1000; // one second in nanoseconds. |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 62 | result_ts->tv_sec = lhs.tv_sec - rhs.tv_sec; |
| 63 | result_ts->tv_nsec = lhs.tv_nsec - rhs.tv_nsec; |
| 64 | if (result_ts->tv_nsec < 0) { |
| 65 | result_ts->tv_sec--; |
| 66 | result_ts->tv_nsec += one_sec; |
| 67 | } else if (result_ts->tv_nsec > one_sec) { |
| 68 | result_ts->tv_sec++; |
| 69 | result_ts->tv_nsec -= one_sec; |
| 70 | } |
| 71 | return result_ts->tv_sec < 0; |
| 72 | } |
| 73 | #endif |
| 74 | |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 75 | class ScopedAllMutexesLock { |
| 76 | public: |
Brian Carlstrom | 93ba893 | 2013-07-17 21:31:49 -0700 | [diff] [blame] | 77 | explicit ScopedAllMutexesLock(const BaseMutex* mutex) : mutex_(mutex) { |
Ian Rogers | 3e5cf30 | 2014-05-20 16:40:37 -0700 | [diff] [blame] | 78 | while (!gAllMutexData->all_mutexes_guard.CompareExchangeWeakAcquire(0, mutex)) { |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 79 | NanoSleep(100); |
| 80 | } |
| 81 | } |
| 82 | ~ScopedAllMutexesLock() { |
Ian Rogers | 3e5cf30 | 2014-05-20 16:40:37 -0700 | [diff] [blame] | 83 | while (!gAllMutexData->all_mutexes_guard.CompareExchangeWeakRelease(mutex_, 0)) { |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 84 | NanoSleep(100); |
| 85 | } |
| 86 | } |
| 87 | private: |
| 88 | const BaseMutex* const mutex_; |
| 89 | }; |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 90 | |
| 91 | BaseMutex::BaseMutex(const char* name, LockLevel level) : level_(level), name_(name) { |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 92 | if (kLogLockContentions) { |
| 93 | ScopedAllMutexesLock mu(this); |
Ian Rogers | d9c4fc9 | 2013-10-01 19:45:43 -0700 | [diff] [blame] | 94 | std::set<BaseMutex*>** all_mutexes_ptr = &gAllMutexData->all_mutexes; |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 95 | if (*all_mutexes_ptr == NULL) { |
| 96 | // We leak the global set of all mutexes to avoid ordering issues in global variable |
| 97 | // construction/destruction. |
| 98 | *all_mutexes_ptr = new std::set<BaseMutex*>(); |
| 99 | } |
| 100 | (*all_mutexes_ptr)->insert(this); |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 101 | } |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 102 | } |
| 103 | |
| 104 | BaseMutex::~BaseMutex() { |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 105 | if (kLogLockContentions) { |
| 106 | ScopedAllMutexesLock mu(this); |
Ian Rogers | d9c4fc9 | 2013-10-01 19:45:43 -0700 | [diff] [blame] | 107 | gAllMutexData->all_mutexes->erase(this); |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 108 | } |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 109 | } |
| 110 | |
| 111 | void BaseMutex::DumpAll(std::ostream& os) { |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 112 | if (kLogLockContentions) { |
| 113 | os << "Mutex logging:\n"; |
| 114 | ScopedAllMutexesLock mu(reinterpret_cast<const BaseMutex*>(-1)); |
Ian Rogers | d9c4fc9 | 2013-10-01 19:45:43 -0700 | [diff] [blame] | 115 | std::set<BaseMutex*>* all_mutexes = gAllMutexData->all_mutexes; |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 116 | if (all_mutexes == NULL) { |
| 117 | // No mutexes have been created yet during at startup. |
| 118 | return; |
| 119 | } |
| 120 | typedef std::set<BaseMutex*>::const_iterator It; |
Ian Rogers | d9c4fc9 | 2013-10-01 19:45:43 -0700 | [diff] [blame] | 121 | os << "(Contended)\n"; |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 122 | for (It it = all_mutexes->begin(); it != all_mutexes->end(); ++it) { |
| 123 | BaseMutex* mutex = *it; |
| 124 | if (mutex->HasEverContended()) { |
| 125 | mutex->Dump(os); |
| 126 | os << "\n"; |
| 127 | } |
| 128 | } |
| 129 | os << "(Never contented)\n"; |
| 130 | for (It it = all_mutexes->begin(); it != all_mutexes->end(); ++it) { |
| 131 | BaseMutex* mutex = *it; |
| 132 | if (!mutex->HasEverContended()) { |
| 133 | mutex->Dump(os); |
| 134 | os << "\n"; |
| 135 | } |
| 136 | } |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 137 | } |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 138 | } |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 139 | |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 140 | void BaseMutex::CheckSafeToWait(Thread* self) { |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 141 | if (self == NULL) { |
| 142 | CheckUnattachedThread(level_); |
| 143 | return; |
| 144 | } |
Ian Rogers | 25fd14b | 2012-09-05 10:56:38 -0700 | [diff] [blame] | 145 | if (kDebugLocking) { |
Ian Rogers | d9c4fc9 | 2013-10-01 19:45:43 -0700 | [diff] [blame] | 146 | CHECK(self->GetHeldMutex(level_) == this || level_ == kMonitorLock) |
| 147 | << "Waiting on unacquired mutex: " << name_; |
Ian Rogers | 25fd14b | 2012-09-05 10:56:38 -0700 | [diff] [blame] | 148 | bool bad_mutexes_held = false; |
Elliott Hughes | 0f82716 | 2013-02-26 12:12:58 -0800 | [diff] [blame] | 149 | for (int i = kLockLevelCount - 1; i >= 0; --i) { |
Ian Rogers | 25fd14b | 2012-09-05 10:56:38 -0700 | [diff] [blame] | 150 | if (i != level_) { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 151 | BaseMutex* held_mutex = self->GetHeldMutex(static_cast<LockLevel>(i)); |
Ian Rogers | 25fd14b | 2012-09-05 10:56:38 -0700 | [diff] [blame] | 152 | if (held_mutex != NULL) { |
Elliott Hughes | 0f82716 | 2013-02-26 12:12:58 -0800 | [diff] [blame] | 153 | LOG(ERROR) << "Holding \"" << held_mutex->name_ << "\" " |
| 154 | << "(level " << LockLevel(i) << ") while performing wait on " |
| 155 | << "\"" << name_ << "\" (level " << level_ << ")"; |
Ian Rogers | 25fd14b | 2012-09-05 10:56:38 -0700 | [diff] [blame] | 156 | bad_mutexes_held = true; |
| 157 | } |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 158 | } |
| 159 | } |
Ian Rogers | 25fd14b | 2012-09-05 10:56:38 -0700 | [diff] [blame] | 160 | CHECK(!bad_mutexes_held); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 161 | } |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 162 | } |
| 163 | |
Ian Rogers | 37f3c96 | 2014-07-17 11:25:30 -0700 | [diff] [blame^] | 164 | void BaseMutex::ContentionLogData::AddToWaitTime(uint64_t value) { |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 165 | if (kLogLockContentions) { |
| 166 | // Atomically add value to wait_time. |
Ian Rogers | 37f3c96 | 2014-07-17 11:25:30 -0700 | [diff] [blame^] | 167 | wait_time.FetchAndAddSequentiallyConsistent(value); |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 168 | } |
| 169 | } |
| 170 | |
Brian Carlstrom | 0de7985 | 2013-07-25 22:29:58 -0700 | [diff] [blame] | 171 | void BaseMutex::RecordContention(uint64_t blocked_tid, |
| 172 | uint64_t owner_tid, |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 173 | uint64_t nano_time_blocked) { |
| 174 | if (kLogLockContentions) { |
Ian Rogers | 3e5cf30 | 2014-05-20 16:40:37 -0700 | [diff] [blame] | 175 | ContentionLogData* data = contention_log_data_; |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 176 | ++(data->contention_count); |
| 177 | data->AddToWaitTime(nano_time_blocked); |
| 178 | ContentionLogEntry* log = data->contention_log; |
| 179 | // This code is intentionally racy as it is only used for diagnostics. |
Ian Rogers | 3e5cf30 | 2014-05-20 16:40:37 -0700 | [diff] [blame] | 180 | uint32_t slot = data->cur_content_log_entry.LoadRelaxed(); |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 181 | if (log[slot].blocked_tid == blocked_tid && |
| 182 | log[slot].owner_tid == blocked_tid) { |
| 183 | ++log[slot].count; |
| 184 | } else { |
| 185 | uint32_t new_slot; |
| 186 | do { |
Ian Rogers | 3e5cf30 | 2014-05-20 16:40:37 -0700 | [diff] [blame] | 187 | slot = data->cur_content_log_entry.LoadRelaxed(); |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 188 | new_slot = (slot + 1) % kContentionLogSize; |
Ian Rogers | 3e5cf30 | 2014-05-20 16:40:37 -0700 | [diff] [blame] | 189 | } while (!data->cur_content_log_entry.CompareExchangeWeakRelaxed(slot, new_slot)); |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 190 | log[new_slot].blocked_tid = blocked_tid; |
| 191 | log[new_slot].owner_tid = owner_tid; |
Ian Rogers | 3e5cf30 | 2014-05-20 16:40:37 -0700 | [diff] [blame] | 192 | log[new_slot].count.StoreRelaxed(1); |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 193 | } |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 194 | } |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 195 | } |
| 196 | |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 197 | void BaseMutex::DumpContention(std::ostream& os) const { |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 198 | if (kLogLockContentions) { |
Ian Rogers | 3e5cf30 | 2014-05-20 16:40:37 -0700 | [diff] [blame] | 199 | const ContentionLogData* data = contention_log_data_; |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 200 | const ContentionLogEntry* log = data->contention_log; |
Ian Rogers | 37f3c96 | 2014-07-17 11:25:30 -0700 | [diff] [blame^] | 201 | uint64_t wait_time = data->wait_time.LoadRelaxed(); |
Ian Rogers | 3e5cf30 | 2014-05-20 16:40:37 -0700 | [diff] [blame] | 202 | uint32_t contention_count = data->contention_count.LoadRelaxed(); |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 203 | if (contention_count == 0) { |
| 204 | os << "never contended"; |
| 205 | } else { |
| 206 | os << "contended " << contention_count |
Mathieu Chartier | 73d1e17 | 2014-04-11 17:53:48 -0700 | [diff] [blame] | 207 | << " total wait of contender " << PrettyDuration(wait_time) |
| 208 | << " average " << PrettyDuration(wait_time / contention_count); |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 209 | SafeMap<uint64_t, size_t> most_common_blocker; |
| 210 | SafeMap<uint64_t, size_t> most_common_blocked; |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 211 | for (size_t i = 0; i < kContentionLogSize; ++i) { |
| 212 | uint64_t blocked_tid = log[i].blocked_tid; |
| 213 | uint64_t owner_tid = log[i].owner_tid; |
Ian Rogers | 3e5cf30 | 2014-05-20 16:40:37 -0700 | [diff] [blame] | 214 | uint32_t count = log[i].count.LoadRelaxed(); |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 215 | if (count > 0) { |
Mathieu Chartier | 73d1e17 | 2014-04-11 17:53:48 -0700 | [diff] [blame] | 216 | auto it = most_common_blocked.find(blocked_tid); |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 217 | if (it != most_common_blocked.end()) { |
| 218 | most_common_blocked.Overwrite(blocked_tid, it->second + count); |
| 219 | } else { |
| 220 | most_common_blocked.Put(blocked_tid, count); |
| 221 | } |
| 222 | it = most_common_blocker.find(owner_tid); |
| 223 | if (it != most_common_blocker.end()) { |
| 224 | most_common_blocker.Overwrite(owner_tid, it->second + count); |
| 225 | } else { |
| 226 | most_common_blocker.Put(owner_tid, count); |
| 227 | } |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 228 | } |
| 229 | } |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 230 | uint64_t max_tid = 0; |
| 231 | size_t max_tid_count = 0; |
Mathieu Chartier | 73d1e17 | 2014-04-11 17:53:48 -0700 | [diff] [blame] | 232 | for (const auto& pair : most_common_blocked) { |
| 233 | if (pair.second > max_tid_count) { |
| 234 | max_tid = pair.first; |
| 235 | max_tid_count = pair.second; |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 236 | } |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 237 | } |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 238 | if (max_tid != 0) { |
| 239 | os << " sample shows most blocked tid=" << max_tid; |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 240 | } |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 241 | max_tid = 0; |
| 242 | max_tid_count = 0; |
Mathieu Chartier | 73d1e17 | 2014-04-11 17:53:48 -0700 | [diff] [blame] | 243 | for (const auto& pair : most_common_blocker) { |
| 244 | if (pair.second > max_tid_count) { |
| 245 | max_tid = pair.first; |
| 246 | max_tid_count = pair.second; |
Hiroshi Yamauchi | 1afde13 | 2013-08-06 17:09:30 -0700 | [diff] [blame] | 247 | } |
| 248 | } |
| 249 | if (max_tid != 0) { |
| 250 | os << " sample shows tid=" << max_tid << " owning during this time"; |
| 251 | } |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 252 | } |
| 253 | } |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 254 | } |
| 255 | |
| 256 | |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 257 | Mutex::Mutex(const char* name, LockLevel level, bool recursive) |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 258 | : BaseMutex(name, level), recursive_(recursive), recursion_count_(0) { |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 259 | #if ART_USE_FUTEXES |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 260 | DCHECK_EQ(0, state_.LoadRelaxed()); |
Ian Rogers | 3e5cf30 | 2014-05-20 16:40:37 -0700 | [diff] [blame] | 261 | DCHECK_EQ(0, num_contenders_.LoadRelaxed()); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 262 | #else |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 263 | CHECK_MUTEX_CALL(pthread_mutex_init, (&mutex_, nullptr)); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 264 | #endif |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 265 | exclusive_owner_ = 0; |
Elliott Hughes | 8daa092 | 2011-09-11 13:46:25 -0700 | [diff] [blame] | 266 | } |
| 267 | |
| 268 | Mutex::~Mutex() { |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 269 | #if ART_USE_FUTEXES |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 270 | if (state_.LoadRelaxed() != 0) { |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 271 | Runtime* runtime = Runtime::Current(); |
Mathieu Chartier | 590fee9 | 2013-09-13 13:46:47 -0700 | [diff] [blame] | 272 | bool shutting_down = runtime == nullptr || runtime->IsShuttingDown(Thread::Current()); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 273 | LOG(shutting_down ? WARNING : FATAL) << "destroying mutex with owner: " << exclusive_owner_; |
| 274 | } else { |
| 275 | CHECK_EQ(exclusive_owner_, 0U) << "unexpectedly found an owner on unlocked mutex " << name_; |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 276 | CHECK_EQ(num_contenders_.LoadSequentiallyConsistent(), 0) |
Ian Rogers | 3e5cf30 | 2014-05-20 16:40:37 -0700 | [diff] [blame] | 277 | << "unexpectedly found a contender on mutex " << name_; |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 278 | } |
| 279 | #else |
Elliott Hughes | e62934d | 2012-04-09 11:24:29 -0700 | [diff] [blame] | 280 | // We can't use CHECK_MUTEX_CALL here because on shutdown a suspended daemon thread |
| 281 | // may still be using locks. |
Elliott Hughes | 6b35575 | 2012-01-13 16:49:08 -0800 | [diff] [blame] | 282 | int rc = pthread_mutex_destroy(&mutex_); |
| 283 | if (rc != 0) { |
| 284 | errno = rc; |
Elliott Hughes | b3bd5f0 | 2012-03-08 21:05:27 -0800 | [diff] [blame] | 285 | // TODO: should we just not log at all if shutting down? this could be the logging mutex! |
Ian Rogers | 50b35e2 | 2012-10-04 10:09:15 -0700 | [diff] [blame] | 286 | MutexLock mu(Thread::Current(), *Locks::runtime_shutdown_lock_); |
Ian Rogers | 120f1c7 | 2012-09-28 17:17:10 -0700 | [diff] [blame] | 287 | Runtime* runtime = Runtime::Current(); |
Mathieu Chartier | 34e8293 | 2013-11-12 18:22:47 -0800 | [diff] [blame] | 288 | bool shutting_down = (runtime == NULL) || runtime->IsShuttingDownLocked(); |
Elliott Hughes | 6b35575 | 2012-01-13 16:49:08 -0800 | [diff] [blame] | 289 | PLOG(shutting_down ? WARNING : FATAL) << "pthread_mutex_destroy failed for " << name_; |
| 290 | } |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 291 | #endif |
Elliott Hughes | 8daa092 | 2011-09-11 13:46:25 -0700 | [diff] [blame] | 292 | } |
| 293 | |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 294 | void Mutex::ExclusiveLock(Thread* self) { |
Ian Rogers | 01ae580 | 2012-09-28 16:14:01 -0700 | [diff] [blame] | 295 | DCHECK(self == NULL || self == Thread::Current()); |
Ian Rogers | 25fd14b | 2012-09-05 10:56:38 -0700 | [diff] [blame] | 296 | if (kDebugLocking && !recursive_) { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 297 | AssertNotHeld(self); |
Ian Rogers | 25fd14b | 2012-09-05 10:56:38 -0700 | [diff] [blame] | 298 | } |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 299 | if (!recursive_ || !IsExclusiveHeld(self)) { |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 300 | #if ART_USE_FUTEXES |
| 301 | bool done = false; |
| 302 | do { |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 303 | int32_t cur_state = state_.LoadRelaxed(); |
Hiroshi Yamauchi | 967a0ad | 2013-09-10 16:24:21 -0700 | [diff] [blame] | 304 | if (LIKELY(cur_state == 0)) { |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 305 | // Change state from 0 to 1 and impose load/store ordering appropriate for lock acquisition. |
| 306 | done = state_.CompareExchangeWeakAcquire(0 /* cur_state */, 1 /* new state */); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 307 | } else { |
| 308 | // Failed to acquire, hang up. |
Hiroshi Yamauchi | b373308 | 2013-08-12 17:28:49 -0700 | [diff] [blame] | 309 | ScopedContentionRecorder scr(this, SafeGetTid(self), GetExclusiveOwnerTid()); |
Ian Rogers | b122a4b | 2013-11-19 18:00:50 -0800 | [diff] [blame] | 310 | num_contenders_++; |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 311 | if (futex(state_.Address(), FUTEX_WAIT, 1, NULL, NULL, 0) != 0) { |
Brian Carlstrom | 0de7985 | 2013-07-25 22:29:58 -0700 | [diff] [blame] | 312 | // EAGAIN and EINTR both indicate a spurious failure, try again from the beginning. |
| 313 | // We don't use TEMP_FAILURE_RETRY so we can intentionally retry to acquire the lock. |
| 314 | if ((errno != EAGAIN) && (errno != EINTR)) { |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 315 | PLOG(FATAL) << "futex wait failed for " << name_; |
| 316 | } |
| 317 | } |
Ian Rogers | b122a4b | 2013-11-19 18:00:50 -0800 | [diff] [blame] | 318 | num_contenders_--; |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 319 | } |
Brian Carlstrom | df62950 | 2013-07-17 22:39:56 -0700 | [diff] [blame] | 320 | } while (!done); |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 321 | DCHECK_EQ(state_.LoadRelaxed(), 1); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 322 | #else |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 323 | CHECK_MUTEX_CALL(pthread_mutex_lock, (&mutex_)); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 324 | #endif |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 325 | DCHECK_EQ(exclusive_owner_, 0U); |
| 326 | exclusive_owner_ = SafeGetTid(self); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 327 | RegisterAsLocked(self); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 328 | } |
| 329 | recursion_count_++; |
Ian Rogers | 25fd14b | 2012-09-05 10:56:38 -0700 | [diff] [blame] | 330 | if (kDebugLocking) { |
| 331 | CHECK(recursion_count_ == 1 || recursive_) << "Unexpected recursion count on mutex: " |
| 332 | << name_ << " " << recursion_count_; |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 333 | AssertHeld(self); |
Ian Rogers | 25fd14b | 2012-09-05 10:56:38 -0700 | [diff] [blame] | 334 | } |
Elliott Hughes | 8daa092 | 2011-09-11 13:46:25 -0700 | [diff] [blame] | 335 | } |
| 336 | |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 337 | bool Mutex::ExclusiveTryLock(Thread* self) { |
Ian Rogers | 01ae580 | 2012-09-28 16:14:01 -0700 | [diff] [blame] | 338 | DCHECK(self == NULL || self == Thread::Current()); |
Ian Rogers | 25fd14b | 2012-09-05 10:56:38 -0700 | [diff] [blame] | 339 | if (kDebugLocking && !recursive_) { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 340 | AssertNotHeld(self); |
Ian Rogers | 25fd14b | 2012-09-05 10:56:38 -0700 | [diff] [blame] | 341 | } |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 342 | if (!recursive_ || !IsExclusiveHeld(self)) { |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 343 | #if ART_USE_FUTEXES |
| 344 | bool done = false; |
| 345 | do { |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 346 | int32_t cur_state = state_.LoadRelaxed(); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 347 | if (cur_state == 0) { |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 348 | // Change state from 0 to 1 and impose load/store ordering appropriate for lock acquisition. |
| 349 | done = state_.CompareExchangeWeakAcquire(0 /* cur_state */, 1 /* new state */); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 350 | } else { |
| 351 | return false; |
| 352 | } |
Brian Carlstrom | df62950 | 2013-07-17 22:39:56 -0700 | [diff] [blame] | 353 | } while (!done); |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 354 | DCHECK_EQ(state_.LoadRelaxed(), 1); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 355 | #else |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 356 | int result = pthread_mutex_trylock(&mutex_); |
| 357 | if (result == EBUSY) { |
| 358 | return false; |
| 359 | } |
| 360 | if (result != 0) { |
| 361 | errno = result; |
| 362 | PLOG(FATAL) << "pthread_mutex_trylock failed for " << name_; |
| 363 | } |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 364 | #endif |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 365 | DCHECK_EQ(exclusive_owner_, 0U); |
| 366 | exclusive_owner_ = SafeGetTid(self); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 367 | RegisterAsLocked(self); |
Elliott Hughes | 8daa092 | 2011-09-11 13:46:25 -0700 | [diff] [blame] | 368 | } |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 369 | recursion_count_++; |
Ian Rogers | 25fd14b | 2012-09-05 10:56:38 -0700 | [diff] [blame] | 370 | if (kDebugLocking) { |
| 371 | CHECK(recursion_count_ == 1 || recursive_) << "Unexpected recursion count on mutex: " |
| 372 | << name_ << " " << recursion_count_; |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 373 | AssertHeld(self); |
Ian Rogers | 25fd14b | 2012-09-05 10:56:38 -0700 | [diff] [blame] | 374 | } |
Elliott Hughes | 8daa092 | 2011-09-11 13:46:25 -0700 | [diff] [blame] | 375 | return true; |
| 376 | } |
| 377 | |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 378 | void Mutex::ExclusiveUnlock(Thread* self) { |
Ian Rogers | 01ae580 | 2012-09-28 16:14:01 -0700 | [diff] [blame] | 379 | DCHECK(self == NULL || self == Thread::Current()); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 380 | AssertHeld(self); |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 381 | DCHECK_NE(exclusive_owner_, 0U); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 382 | recursion_count_--; |
| 383 | if (!recursive_ || recursion_count_ == 0) { |
Ian Rogers | 25fd14b | 2012-09-05 10:56:38 -0700 | [diff] [blame] | 384 | if (kDebugLocking) { |
| 385 | CHECK(recursion_count_ == 0 || recursive_) << "Unexpected recursion count on mutex: " |
| 386 | << name_ << " " << recursion_count_; |
| 387 | } |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 388 | RegisterAsUnlocked(self); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 389 | #if ART_USE_FUTEXES |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 390 | bool done = false; |
| 391 | do { |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 392 | int32_t cur_state = state_.LoadRelaxed(); |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 393 | if (LIKELY(cur_state == 1)) { |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 394 | // We're no longer the owner. |
| 395 | exclusive_owner_ = 0; |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 396 | // Change state to 0 and impose load/store ordering appropriate for lock release. |
| 397 | // Note, the relaxed loads below musn't reorder before the CompareExchange. |
| 398 | // TODO: the ordering here is non-trivial as state is split across 3 fields, fix by placing |
| 399 | // a status bit into the state on contention. |
| 400 | done = state_.CompareExchangeWeakSequentiallyConsistent(cur_state, 0 /* new state */); |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 401 | if (LIKELY(done)) { // Spurious fail? |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 402 | // Wake a contender. |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 403 | if (UNLIKELY(num_contenders_.LoadRelaxed() > 0)) { |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 404 | futex(state_.Address(), FUTEX_WAKE, 1, NULL, NULL, 0); |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 405 | } |
| 406 | } |
| 407 | } else { |
| 408 | // Logging acquires the logging lock, avoid infinite recursion in that case. |
| 409 | if (this != Locks::logging_lock_) { |
| 410 | LOG(FATAL) << "Unexpected state_ in unlock " << cur_state << " for " << name_; |
| 411 | } else { |
| 412 | LogMessageData data(__FILE__, __LINE__, INTERNAL_FATAL, -1); |
| 413 | LogMessage::LogLine(data, StringPrintf("Unexpected state_ %d in unlock for %s", |
| 414 | cur_state, name_).c_str()); |
| 415 | _exit(1); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 416 | } |
| 417 | } |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 418 | } while (!done); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 419 | #else |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 420 | exclusive_owner_ = 0; |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 421 | CHECK_MUTEX_CALL(pthread_mutex_unlock, (&mutex_)); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 422 | #endif |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 423 | } |
Elliott Hughes | 8daa092 | 2011-09-11 13:46:25 -0700 | [diff] [blame] | 424 | } |
| 425 | |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 426 | void Mutex::Dump(std::ostream& os) const { |
| 427 | os << (recursive_ ? "recursive " : "non-recursive ") |
| 428 | << name_ |
| 429 | << " level=" << static_cast<int>(level_) |
| 430 | << " rec=" << recursion_count_ |
| 431 | << " owner=" << GetExclusiveOwnerTid() << " "; |
| 432 | DumpContention(os); |
Ian Rogers | 01ae580 | 2012-09-28 16:14:01 -0700 | [diff] [blame] | 433 | } |
| 434 | |
| 435 | std::ostream& operator<<(std::ostream& os, const Mutex& mu) { |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 436 | mu.Dump(os); |
| 437 | return os; |
Ian Rogers | 01ae580 | 2012-09-28 16:14:01 -0700 | [diff] [blame] | 438 | } |
| 439 | |
Brian Carlstrom | 02c8cc6 | 2013-07-18 15:54:44 -0700 | [diff] [blame] | 440 | ReaderWriterMutex::ReaderWriterMutex(const char* name, LockLevel level) |
| 441 | : BaseMutex(name, level) |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 442 | #if ART_USE_FUTEXES |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 443 | , state_(0), num_pending_readers_(0), num_pending_writers_(0) |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 444 | #endif |
Brian Carlstrom | 7934ac2 | 2013-07-26 10:54:15 -0700 | [diff] [blame] | 445 | { // NOLINT(whitespace/braces) |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 446 | #if !ART_USE_FUTEXES |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 447 | CHECK_MUTEX_CALL(pthread_rwlock_init, (&rwlock_, nullptr)); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 448 | #endif |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 449 | exclusive_owner_ = 0; |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 450 | } |
| 451 | |
| 452 | ReaderWriterMutex::~ReaderWriterMutex() { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 453 | #if ART_USE_FUTEXES |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 454 | CHECK_EQ(state_.LoadRelaxed(), 0); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 455 | CHECK_EQ(exclusive_owner_, 0U); |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 456 | CHECK_EQ(num_pending_readers_.LoadRelaxed(), 0); |
Ian Rogers | 3e5cf30 | 2014-05-20 16:40:37 -0700 | [diff] [blame] | 457 | CHECK_EQ(num_pending_writers_.LoadRelaxed(), 0); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 458 | #else |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 459 | // We can't use CHECK_MUTEX_CALL here because on shutdown a suspended daemon thread |
| 460 | // may still be using locks. |
| 461 | int rc = pthread_rwlock_destroy(&rwlock_); |
| 462 | if (rc != 0) { |
| 463 | errno = rc; |
| 464 | // TODO: should we just not log at all if shutting down? this could be the logging mutex! |
Ian Rogers | 50b35e2 | 2012-10-04 10:09:15 -0700 | [diff] [blame] | 465 | MutexLock mu(Thread::Current(), *Locks::runtime_shutdown_lock_); |
Ian Rogers | 120f1c7 | 2012-09-28 17:17:10 -0700 | [diff] [blame] | 466 | Runtime* runtime = Runtime::Current(); |
Mathieu Chartier | 34e8293 | 2013-11-12 18:22:47 -0800 | [diff] [blame] | 467 | bool shutting_down = runtime == NULL || runtime->IsShuttingDownLocked(); |
Ian Rogers | 120f1c7 | 2012-09-28 17:17:10 -0700 | [diff] [blame] | 468 | PLOG(shutting_down ? WARNING : FATAL) << "pthread_rwlock_destroy failed for " << name_; |
Brian Carlstrom | cd74c4b | 2012-01-23 13:21:00 -0800 | [diff] [blame] | 469 | } |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 470 | #endif |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 471 | } |
| 472 | |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 473 | void ReaderWriterMutex::ExclusiveLock(Thread* self) { |
Ian Rogers | 01ae580 | 2012-09-28 16:14:01 -0700 | [diff] [blame] | 474 | DCHECK(self == NULL || self == Thread::Current()); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 475 | AssertNotExclusiveHeld(self); |
| 476 | #if ART_USE_FUTEXES |
| 477 | bool done = false; |
| 478 | do { |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 479 | int32_t cur_state = state_.LoadRelaxed(); |
Hiroshi Yamauchi | 967a0ad | 2013-09-10 16:24:21 -0700 | [diff] [blame] | 480 | if (LIKELY(cur_state == 0)) { |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 481 | // Change state from 0 to -1 and impose load/store ordering appropriate for lock acquisition. |
| 482 | done = state_.CompareExchangeWeakAcquire(0 /* cur_state*/, -1 /* new state */); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 483 | } else { |
| 484 | // Failed to acquire, hang up. |
Hiroshi Yamauchi | b373308 | 2013-08-12 17:28:49 -0700 | [diff] [blame] | 485 | ScopedContentionRecorder scr(this, SafeGetTid(self), GetExclusiveOwnerTid()); |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 486 | ++num_pending_writers_; |
| 487 | if (futex(state_.Address(), FUTEX_WAIT, cur_state, NULL, NULL, 0) != 0) { |
Brian Carlstrom | 0de7985 | 2013-07-25 22:29:58 -0700 | [diff] [blame] | 488 | // EAGAIN and EINTR both indicate a spurious failure, try again from the beginning. |
| 489 | // We don't use TEMP_FAILURE_RETRY so we can intentionally retry to acquire the lock. |
| 490 | if ((errno != EAGAIN) && (errno != EINTR)) { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 491 | PLOG(FATAL) << "futex wait failed for " << name_; |
| 492 | } |
| 493 | } |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 494 | --num_pending_writers_; |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 495 | } |
Brian Carlstrom | df62950 | 2013-07-17 22:39:56 -0700 | [diff] [blame] | 496 | } while (!done); |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 497 | DCHECK_EQ(state_.LoadRelaxed(), -1); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 498 | #else |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 499 | CHECK_MUTEX_CALL(pthread_rwlock_wrlock, (&rwlock_)); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 500 | #endif |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 501 | DCHECK_EQ(exclusive_owner_, 0U); |
| 502 | exclusive_owner_ = SafeGetTid(self); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 503 | RegisterAsLocked(self); |
| 504 | AssertExclusiveHeld(self); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 505 | } |
| 506 | |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 507 | void ReaderWriterMutex::ExclusiveUnlock(Thread* self) { |
Ian Rogers | 01ae580 | 2012-09-28 16:14:01 -0700 | [diff] [blame] | 508 | DCHECK(self == NULL || self == Thread::Current()); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 509 | AssertExclusiveHeld(self); |
| 510 | RegisterAsUnlocked(self); |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 511 | DCHECK_NE(exclusive_owner_, 0U); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 512 | #if ART_USE_FUTEXES |
| 513 | bool done = false; |
| 514 | do { |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 515 | int32_t cur_state = state_.LoadRelaxed(); |
Hiroshi Yamauchi | 967a0ad | 2013-09-10 16:24:21 -0700 | [diff] [blame] | 516 | if (LIKELY(cur_state == -1)) { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 517 | // We're no longer the owner. |
| 518 | exclusive_owner_ = 0; |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 519 | // Change state from -1 to 0 and impose load/store ordering appropriate for lock release. |
| 520 | // Note, the relaxed loads below musn't reorder before the CompareExchange. |
| 521 | // TODO: the ordering here is non-trivial as state is split across 3 fields, fix by placing |
| 522 | // a status bit into the state on contention. |
| 523 | done = state_.CompareExchangeWeakSequentiallyConsistent(-1 /* cur_state*/, 0 /* new state */); |
| 524 | if (LIKELY(done)) { // Weak CAS may fail spuriously. |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 525 | // Wake any waiters. |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 526 | if (UNLIKELY(num_pending_readers_.LoadRelaxed() > 0 || |
| 527 | num_pending_writers_.LoadRelaxed() > 0)) { |
| 528 | futex(state_.Address(), FUTEX_WAKE, -1, NULL, NULL, 0); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 529 | } |
| 530 | } |
| 531 | } else { |
| 532 | LOG(FATAL) << "Unexpected state_:" << cur_state << " for " << name_; |
| 533 | } |
Brian Carlstrom | df62950 | 2013-07-17 22:39:56 -0700 | [diff] [blame] | 534 | } while (!done); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 535 | #else |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 536 | exclusive_owner_ = 0; |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 537 | CHECK_MUTEX_CALL(pthread_rwlock_unlock, (&rwlock_)); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 538 | #endif |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 539 | } |
| 540 | |
Ian Rogers | 66aee5c | 2012-08-15 17:17:47 -0700 | [diff] [blame] | 541 | #if HAVE_TIMED_RWLOCK |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 542 | bool ReaderWriterMutex::ExclusiveLockWithTimeout(Thread* self, int64_t ms, int32_t ns) { |
Ian Rogers | 01ae580 | 2012-09-28 16:14:01 -0700 | [diff] [blame] | 543 | DCHECK(self == NULL || self == Thread::Current()); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 544 | #if ART_USE_FUTEXES |
| 545 | bool done = false; |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 546 | timespec end_abs_ts; |
Ian Rogers | 5bd97c4 | 2012-11-27 02:38:26 -0800 | [diff] [blame] | 547 | InitTimeSpec(true, CLOCK_REALTIME, ms, ns, &end_abs_ts); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 548 | do { |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 549 | int32_t cur_state = state_.LoadRelaxed(); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 550 | if (cur_state == 0) { |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 551 | // Change state from 0 to -1 and impose load/store ordering appropriate for lock acquisition. |
| 552 | done = state_.CompareExchangeWeakAcquire(0 /* cur_state */, -1 /* new state */); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 553 | } else { |
| 554 | // Failed to acquire, hang up. |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 555 | timespec now_abs_ts; |
Ian Rogers | 5bd97c4 | 2012-11-27 02:38:26 -0800 | [diff] [blame] | 556 | InitTimeSpec(true, CLOCK_REALTIME, 0, 0, &now_abs_ts); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 557 | timespec rel_ts; |
| 558 | if (ComputeRelativeTimeSpec(&rel_ts, end_abs_ts, now_abs_ts)) { |
| 559 | return false; // Timed out. |
| 560 | } |
Hiroshi Yamauchi | b373308 | 2013-08-12 17:28:49 -0700 | [diff] [blame] | 561 | ScopedContentionRecorder scr(this, SafeGetTid(self), GetExclusiveOwnerTid()); |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 562 | ++num_pending_writers_; |
| 563 | if (futex(state_.Address(), FUTEX_WAIT, cur_state, &rel_ts, NULL, 0) != 0) { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 564 | if (errno == ETIMEDOUT) { |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 565 | --num_pending_writers_; |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 566 | return false; // Timed out. |
Brian Carlstrom | 0de7985 | 2013-07-25 22:29:58 -0700 | [diff] [blame] | 567 | } else if ((errno != EAGAIN) && (errno != EINTR)) { |
| 568 | // EAGAIN and EINTR both indicate a spurious failure, |
| 569 | // recompute the relative time out from now and try again. |
| 570 | // We don't use TEMP_FAILURE_RETRY so we can recompute rel_ts; |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 571 | PLOG(FATAL) << "timed futex wait failed for " << name_; |
| 572 | } |
| 573 | } |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 574 | --num_pending_writers_; |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 575 | } |
Brian Carlstrom | df62950 | 2013-07-17 22:39:56 -0700 | [diff] [blame] | 576 | } while (!done); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 577 | #else |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 578 | timespec ts; |
Brian Carlstrom | bcc2926 | 2012-11-02 11:36:03 -0700 | [diff] [blame] | 579 | InitTimeSpec(true, CLOCK_REALTIME, ms, ns, &ts); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 580 | int result = pthread_rwlock_timedwrlock(&rwlock_, &ts); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 581 | if (result == ETIMEDOUT) { |
| 582 | return false; |
| 583 | } |
| 584 | if (result != 0) { |
| 585 | errno = result; |
Ian Rogers | a5acfd3 | 2012-08-15 11:50:10 -0700 | [diff] [blame] | 586 | PLOG(FATAL) << "pthread_rwlock_timedwrlock failed for " << name_; |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 587 | } |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 588 | #endif |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 589 | exclusive_owner_ = SafeGetTid(self); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 590 | RegisterAsLocked(self); |
| 591 | AssertSharedHeld(self); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 592 | return true; |
| 593 | } |
Ian Rogers | 66aee5c | 2012-08-15 17:17:47 -0700 | [diff] [blame] | 594 | #endif |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 595 | |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 596 | bool ReaderWriterMutex::SharedTryLock(Thread* self) { |
Ian Rogers | 01ae580 | 2012-09-28 16:14:01 -0700 | [diff] [blame] | 597 | DCHECK(self == NULL || self == Thread::Current()); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 598 | #if ART_USE_FUTEXES |
| 599 | bool done = false; |
| 600 | do { |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 601 | int32_t cur_state = state_.LoadRelaxed(); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 602 | if (cur_state >= 0) { |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 603 | // Add as an extra reader and impose load/store ordering appropriate for lock acquisition. |
| 604 | done = state_.CompareExchangeWeakAcquire(cur_state, cur_state + 1); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 605 | } else { |
| 606 | // Owner holds it exclusively. |
| 607 | return false; |
| 608 | } |
Brian Carlstrom | df62950 | 2013-07-17 22:39:56 -0700 | [diff] [blame] | 609 | } while (!done); |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 610 | #else |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 611 | int result = pthread_rwlock_tryrdlock(&rwlock_); |
| 612 | if (result == EBUSY) { |
| 613 | return false; |
| 614 | } |
| 615 | if (result != 0) { |
| 616 | errno = result; |
| 617 | PLOG(FATAL) << "pthread_mutex_trylock failed for " << name_; |
| 618 | } |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 619 | #endif |
| 620 | RegisterAsLocked(self); |
| 621 | AssertSharedHeld(self); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 622 | return true; |
| 623 | } |
| 624 | |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 625 | bool ReaderWriterMutex::IsSharedHeld(const Thread* self) const { |
Ian Rogers | 01ae580 | 2012-09-28 16:14:01 -0700 | [diff] [blame] | 626 | DCHECK(self == NULL || self == Thread::Current()); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 627 | bool result; |
| 628 | if (UNLIKELY(self == NULL)) { // Handle unattached threads. |
Ian Rogers | 01ae580 | 2012-09-28 16:14:01 -0700 | [diff] [blame] | 629 | result = IsExclusiveHeld(self); // TODO: a better best effort here. |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 630 | } else { |
| 631 | result = (self->GetHeldMutex(level_) == this); |
| 632 | } |
| 633 | return result; |
| 634 | } |
| 635 | |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 636 | void ReaderWriterMutex::Dump(std::ostream& os) const { |
| 637 | os << name_ |
| 638 | << " level=" << static_cast<int>(level_) |
| 639 | << " owner=" << GetExclusiveOwnerTid() << " "; |
| 640 | DumpContention(os); |
Ian Rogers | 01ae580 | 2012-09-28 16:14:01 -0700 | [diff] [blame] | 641 | } |
| 642 | |
| 643 | std::ostream& operator<<(std::ostream& os, const ReaderWriterMutex& mu) { |
Ian Rogers | 56edc43 | 2013-01-18 16:51:51 -0800 | [diff] [blame] | 644 | mu.Dump(os); |
| 645 | return os; |
Ian Rogers | 01ae580 | 2012-09-28 16:14:01 -0700 | [diff] [blame] | 646 | } |
| 647 | |
Ian Rogers | 23055dc | 2013-04-18 16:29:16 -0700 | [diff] [blame] | 648 | ConditionVariable::ConditionVariable(const char* name, Mutex& guard) |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 649 | : name_(name), guard_(guard) { |
| 650 | #if ART_USE_FUTEXES |
Ian Rogers | 3e5cf30 | 2014-05-20 16:40:37 -0700 | [diff] [blame] | 651 | DCHECK_EQ(0, sequence_.LoadRelaxed()); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 652 | num_waiters_ = 0; |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 653 | #else |
Narayan Kamath | 51b7102 | 2014-03-04 11:57:09 +0000 | [diff] [blame] | 654 | pthread_condattr_t cond_attrs; |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 655 | CHECK_MUTEX_CALL(pthread_condattr_init, (&cond_attrs)); |
Narayan Kamath | 51b7102 | 2014-03-04 11:57:09 +0000 | [diff] [blame] | 656 | #if !defined(__APPLE__) |
| 657 | // Apple doesn't have CLOCK_MONOTONIC or pthread_condattr_setclock. |
| 658 | CHECK_MUTEX_CALL(pthread_condattr_setclock(&cond_attrs, CLOCK_MONOTONIC)); |
| 659 | #endif |
| 660 | CHECK_MUTEX_CALL(pthread_cond_init, (&cond_, &cond_attrs)); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 661 | #endif |
Elliott Hughes | 5f79133 | 2011-09-15 17:45:30 -0700 | [diff] [blame] | 662 | } |
| 663 | |
| 664 | ConditionVariable::~ConditionVariable() { |
Ian Rogers | 5bd97c4 | 2012-11-27 02:38:26 -0800 | [diff] [blame] | 665 | #if ART_USE_FUTEXES |
| 666 | if (num_waiters_!= 0) { |
Ian Rogers | 5bd97c4 | 2012-11-27 02:38:26 -0800 | [diff] [blame] | 667 | Runtime* runtime = Runtime::Current(); |
Mathieu Chartier | 590fee9 | 2013-09-13 13:46:47 -0700 | [diff] [blame] | 668 | bool shutting_down = runtime == nullptr || runtime->IsShuttingDown(Thread::Current()); |
Ian Rogers | d45f201 | 2012-11-28 11:46:23 -0800 | [diff] [blame] | 669 | LOG(shutting_down ? WARNING : FATAL) << "ConditionVariable::~ConditionVariable for " << name_ |
| 670 | << " called with " << num_waiters_ << " waiters."; |
Ian Rogers | 5bd97c4 | 2012-11-27 02:38:26 -0800 | [diff] [blame] | 671 | } |
| 672 | #else |
Elliott Hughes | e62934d | 2012-04-09 11:24:29 -0700 | [diff] [blame] | 673 | // We can't use CHECK_MUTEX_CALL here because on shutdown a suspended daemon thread |
| 674 | // may still be using condition variables. |
| 675 | int rc = pthread_cond_destroy(&cond_); |
| 676 | if (rc != 0) { |
| 677 | errno = rc; |
Ian Rogers | 50b35e2 | 2012-10-04 10:09:15 -0700 | [diff] [blame] | 678 | MutexLock mu(Thread::Current(), *Locks::runtime_shutdown_lock_); |
Ian Rogers | 120f1c7 | 2012-09-28 17:17:10 -0700 | [diff] [blame] | 679 | Runtime* runtime = Runtime::Current(); |
Mathieu Chartier | 34e8293 | 2013-11-12 18:22:47 -0800 | [diff] [blame] | 680 | bool shutting_down = (runtime == NULL) || runtime->IsShuttingDownLocked(); |
Elliott Hughes | e62934d | 2012-04-09 11:24:29 -0700 | [diff] [blame] | 681 | PLOG(shutting_down ? WARNING : FATAL) << "pthread_cond_destroy failed for " << name_; |
| 682 | } |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 683 | #endif |
Elliott Hughes | 5f79133 | 2011-09-15 17:45:30 -0700 | [diff] [blame] | 684 | } |
| 685 | |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 686 | void ConditionVariable::Broadcast(Thread* self) { |
| 687 | DCHECK(self == NULL || self == Thread::Current()); |
| 688 | // TODO: enable below, there's a race in thread creation that causes false failures currently. |
| 689 | // guard_.AssertExclusiveHeld(self); |
Mathieu Chartier | e46cd75 | 2012-10-31 16:56:18 -0700 | [diff] [blame] | 690 | DCHECK_EQ(guard_.GetExclusiveOwnerTid(), SafeGetTid(self)); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 691 | #if ART_USE_FUTEXES |
Ian Rogers | d45f201 | 2012-11-28 11:46:23 -0800 | [diff] [blame] | 692 | if (num_waiters_ > 0) { |
Ian Rogers | b122a4b | 2013-11-19 18:00:50 -0800 | [diff] [blame] | 693 | sequence_++; // Indicate the broadcast occurred. |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 694 | bool done = false; |
| 695 | do { |
Ian Rogers | 3e5cf30 | 2014-05-20 16:40:37 -0700 | [diff] [blame] | 696 | int32_t cur_sequence = sequence_.LoadRelaxed(); |
Ian Rogers | d45f201 | 2012-11-28 11:46:23 -0800 | [diff] [blame] | 697 | // Requeue waiters onto mutex. The waiter holds the contender count on the mutex high ensuring |
| 698 | // mutex unlocks will awaken the requeued waiter thread. |
Ian Rogers | b122a4b | 2013-11-19 18:00:50 -0800 | [diff] [blame] | 699 | done = futex(sequence_.Address(), FUTEX_CMP_REQUEUE, 0, |
Ian Rogers | 5bd97c4 | 2012-11-27 02:38:26 -0800 | [diff] [blame] | 700 | reinterpret_cast<const timespec*>(std::numeric_limits<int32_t>::max()), |
Ian Rogers | c719069 | 2014-07-08 23:50:26 -0700 | [diff] [blame] | 701 | guard_.state_.Address(), cur_sequence) != -1; |
Ian Rogers | 5bd97c4 | 2012-11-27 02:38:26 -0800 | [diff] [blame] | 702 | if (!done) { |
| 703 | if (errno != EAGAIN) { |
| 704 | PLOG(FATAL) << "futex cmp requeue failed for " << name_; |
| 705 | } |
Ian Rogers | 5bd97c4 | 2012-11-27 02:38:26 -0800 | [diff] [blame] | 706 | } |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 707 | } while (!done); |
| 708 | } |
| 709 | #else |
Elliott Hughes | 5f79133 | 2011-09-15 17:45:30 -0700 | [diff] [blame] | 710 | CHECK_MUTEX_CALL(pthread_cond_broadcast, (&cond_)); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 711 | #endif |
Elliott Hughes | 5f79133 | 2011-09-15 17:45:30 -0700 | [diff] [blame] | 712 | } |
| 713 | |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 714 | void ConditionVariable::Signal(Thread* self) { |
| 715 | DCHECK(self == NULL || self == Thread::Current()); |
| 716 | guard_.AssertExclusiveHeld(self); |
| 717 | #if ART_USE_FUTEXES |
Ian Rogers | d45f201 | 2012-11-28 11:46:23 -0800 | [diff] [blame] | 718 | if (num_waiters_ > 0) { |
Ian Rogers | b122a4b | 2013-11-19 18:00:50 -0800 | [diff] [blame] | 719 | sequence_++; // Indicate a signal occurred. |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 720 | // Futex wake 1 waiter who will then come and in contend on mutex. It'd be nice to requeue them |
| 721 | // to avoid this, however, requeueing can only move all waiters. |
Ian Rogers | b122a4b | 2013-11-19 18:00:50 -0800 | [diff] [blame] | 722 | int num_woken = futex(sequence_.Address(), FUTEX_WAKE, 1, NULL, NULL, 0); |
Ian Rogers | d45f201 | 2012-11-28 11:46:23 -0800 | [diff] [blame] | 723 | // Check something was woken or else we changed sequence_ before they had chance to wait. |
Ian Rogers | 5bd97c4 | 2012-11-27 02:38:26 -0800 | [diff] [blame] | 724 | CHECK((num_woken == 0) || (num_woken == 1)); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 725 | } |
| 726 | #else |
Elliott Hughes | 5f79133 | 2011-09-15 17:45:30 -0700 | [diff] [blame] | 727 | CHECK_MUTEX_CALL(pthread_cond_signal, (&cond_)); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 728 | #endif |
Elliott Hughes | 5f79133 | 2011-09-15 17:45:30 -0700 | [diff] [blame] | 729 | } |
| 730 | |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 731 | void ConditionVariable::Wait(Thread* self) { |
Ian Rogers | 1d54e73 | 2013-05-02 21:10:01 -0700 | [diff] [blame] | 732 | guard_.CheckSafeToWait(self); |
| 733 | WaitHoldingLocks(self); |
| 734 | } |
| 735 | |
| 736 | void ConditionVariable::WaitHoldingLocks(Thread* self) { |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 737 | DCHECK(self == NULL || self == Thread::Current()); |
| 738 | guard_.AssertExclusiveHeld(self); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 739 | unsigned int old_recursion_count = guard_.recursion_count_; |
| 740 | #if ART_USE_FUTEXES |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 741 | num_waiters_++; |
Ian Rogers | d45f201 | 2012-11-28 11:46:23 -0800 | [diff] [blame] | 742 | // Ensure the Mutex is contended so that requeued threads are awoken. |
Ian Rogers | b122a4b | 2013-11-19 18:00:50 -0800 | [diff] [blame] | 743 | guard_.num_contenders_++; |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 744 | guard_.recursion_count_ = 1; |
Ian Rogers | 3e5cf30 | 2014-05-20 16:40:37 -0700 | [diff] [blame] | 745 | int32_t cur_sequence = sequence_.LoadRelaxed(); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 746 | guard_.ExclusiveUnlock(self); |
Ian Rogers | b122a4b | 2013-11-19 18:00:50 -0800 | [diff] [blame] | 747 | if (futex(sequence_.Address(), FUTEX_WAIT, cur_sequence, NULL, NULL, 0) != 0) { |
Ian Rogers | d45f201 | 2012-11-28 11:46:23 -0800 | [diff] [blame] | 748 | // Futex failed, check it is an expected error. |
| 749 | // EAGAIN == EWOULDBLK, so we let the caller try again. |
| 750 | // EINTR implies a signal was sent to this thread. |
| 751 | if ((errno != EINTR) && (errno != EAGAIN)) { |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 752 | PLOG(FATAL) << "futex wait failed for " << name_; |
| 753 | } |
| 754 | } |
| 755 | guard_.ExclusiveLock(self); |
Ian Rogers | d45f201 | 2012-11-28 11:46:23 -0800 | [diff] [blame] | 756 | CHECK_GE(num_waiters_, 0); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 757 | num_waiters_--; |
Ian Rogers | d45f201 | 2012-11-28 11:46:23 -0800 | [diff] [blame] | 758 | // We awoke and so no longer require awakes from the guard_'s unlock. |
Ian Rogers | 3e5cf30 | 2014-05-20 16:40:37 -0700 | [diff] [blame] | 759 | CHECK_GE(guard_.num_contenders_.LoadRelaxed(), 0); |
Ian Rogers | b122a4b | 2013-11-19 18:00:50 -0800 | [diff] [blame] | 760 | guard_.num_contenders_--; |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 761 | #else |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 762 | uint64_t old_owner = guard_.exclusive_owner_; |
| 763 | guard_.exclusive_owner_ = 0; |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 764 | guard_.recursion_count_ = 0; |
| 765 | CHECK_MUTEX_CALL(pthread_cond_wait, (&cond_, &guard_.mutex_)); |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 766 | guard_.exclusive_owner_ = old_owner; |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 767 | #endif |
| 768 | guard_.recursion_count_ = old_recursion_count; |
Elliott Hughes | 5f79133 | 2011-09-15 17:45:30 -0700 | [diff] [blame] | 769 | } |
| 770 | |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 771 | void ConditionVariable::TimedWait(Thread* self, int64_t ms, int32_t ns) { |
| 772 | DCHECK(self == NULL || self == Thread::Current()); |
| 773 | guard_.AssertExclusiveHeld(self); |
Ian Rogers | 1d54e73 | 2013-05-02 21:10:01 -0700 | [diff] [blame] | 774 | guard_.CheckSafeToWait(self); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 775 | unsigned int old_recursion_count = guard_.recursion_count_; |
| 776 | #if ART_USE_FUTEXES |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 777 | timespec rel_ts; |
Ian Rogers | 5bd97c4 | 2012-11-27 02:38:26 -0800 | [diff] [blame] | 778 | InitTimeSpec(false, CLOCK_REALTIME, ms, ns, &rel_ts); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 779 | num_waiters_++; |
Ian Rogers | d45f201 | 2012-11-28 11:46:23 -0800 | [diff] [blame] | 780 | // Ensure the Mutex is contended so that requeued threads are awoken. |
Ian Rogers | b122a4b | 2013-11-19 18:00:50 -0800 | [diff] [blame] | 781 | guard_.num_contenders_++; |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 782 | guard_.recursion_count_ = 1; |
Ian Rogers | 3e5cf30 | 2014-05-20 16:40:37 -0700 | [diff] [blame] | 783 | int32_t cur_sequence = sequence_.LoadRelaxed(); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 784 | guard_.ExclusiveUnlock(self); |
Ian Rogers | b122a4b | 2013-11-19 18:00:50 -0800 | [diff] [blame] | 785 | if (futex(sequence_.Address(), FUTEX_WAIT, cur_sequence, &rel_ts, NULL, 0) != 0) { |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 786 | if (errno == ETIMEDOUT) { |
Ian Rogers | d45f201 | 2012-11-28 11:46:23 -0800 | [diff] [blame] | 787 | // Timed out we're done. |
Brian Carlstrom | 0de7985 | 2013-07-25 22:29:58 -0700 | [diff] [blame] | 788 | } else if ((errno == EAGAIN) || (errno == EINTR)) { |
Ian Rogers | d45f201 | 2012-11-28 11:46:23 -0800 | [diff] [blame] | 789 | // A signal or ConditionVariable::Signal/Broadcast has come in. |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 790 | } else { |
| 791 | PLOG(FATAL) << "timed futex wait failed for " << name_; |
| 792 | } |
| 793 | } |
| 794 | guard_.ExclusiveLock(self); |
Ian Rogers | d45f201 | 2012-11-28 11:46:23 -0800 | [diff] [blame] | 795 | CHECK_GE(num_waiters_, 0); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 796 | num_waiters_--; |
Ian Rogers | d45f201 | 2012-11-28 11:46:23 -0800 | [diff] [blame] | 797 | // We awoke and so no longer require awakes from the guard_'s unlock. |
Ian Rogers | 3e5cf30 | 2014-05-20 16:40:37 -0700 | [diff] [blame] | 798 | CHECK_GE(guard_.num_contenders_.LoadRelaxed(), 0); |
Ian Rogers | b122a4b | 2013-11-19 18:00:50 -0800 | [diff] [blame] | 799 | guard_.num_contenders_--; |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 800 | #else |
Narayan Kamath | 51b7102 | 2014-03-04 11:57:09 +0000 | [diff] [blame] | 801 | #if !defined(__APPLE__) |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 802 | int clock = CLOCK_MONOTONIC; |
Elliott Hughes | 5f79133 | 2011-09-15 17:45:30 -0700 | [diff] [blame] | 803 | #else |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 804 | int clock = CLOCK_REALTIME; |
Elliott Hughes | 5f79133 | 2011-09-15 17:45:30 -0700 | [diff] [blame] | 805 | #endif |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 806 | uint64_t old_owner = guard_.exclusive_owner_; |
| 807 | guard_.exclusive_owner_ = 0; |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 808 | guard_.recursion_count_ = 0; |
| 809 | timespec ts; |
Brian Carlstrom | bcc2926 | 2012-11-02 11:36:03 -0700 | [diff] [blame] | 810 | InitTimeSpec(true, clock, ms, ns, &ts); |
Narayan Kamath | 51b7102 | 2014-03-04 11:57:09 +0000 | [diff] [blame] | 811 | int rc = TEMP_FAILURE_RETRY(pthread_cond_timedwait(&cond_, &guard_.mutex_, &ts)); |
Elliott Hughes | 5f79133 | 2011-09-15 17:45:30 -0700 | [diff] [blame] | 812 | if (rc != 0 && rc != ETIMEDOUT) { |
| 813 | errno = rc; |
| 814 | PLOG(FATAL) << "TimedWait failed for " << name_; |
| 815 | } |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 816 | guard_.exclusive_owner_ = old_owner; |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 817 | #endif |
| 818 | guard_.recursion_count_ = old_recursion_count; |
Elliott Hughes | 5f79133 | 2011-09-15 17:45:30 -0700 | [diff] [blame] | 819 | } |
| 820 | |
Ian Rogers | 719d1a3 | 2014-03-06 12:13:39 -0800 | [diff] [blame] | 821 | void Locks::Init() { |
| 822 | if (logging_lock_ != nullptr) { |
| 823 | // Already initialized. |
Nicolas Geoffray | 7f0a6d6 | 2014-05-26 14:01:46 +0100 | [diff] [blame] | 824 | if (kRuntimeISA == kX86 || kRuntimeISA == kX86_64) { |
Chao-ying Fu | 9e36931 | 2014-05-21 11:20:52 -0700 | [diff] [blame] | 825 | DCHECK(modify_ldt_lock_ != nullptr); |
| 826 | } else { |
| 827 | DCHECK(modify_ldt_lock_ == nullptr); |
| 828 | } |
Ian Rogers | 719d1a3 | 2014-03-06 12:13:39 -0800 | [diff] [blame] | 829 | DCHECK(abort_lock_ != nullptr); |
Andreas Gampe | 7424081 | 2014-04-17 10:35:09 -0700 | [diff] [blame] | 830 | DCHECK(allocated_monitor_ids_lock_ != nullptr); |
Chao-ying Fu | 9e36931 | 2014-05-21 11:20:52 -0700 | [diff] [blame] | 831 | DCHECK(allocated_thread_ids_lock_ != nullptr); |
Ian Rogers | 719d1a3 | 2014-03-06 12:13:39 -0800 | [diff] [blame] | 832 | DCHECK(breakpoint_lock_ != nullptr); |
Ian Rogers | 719d1a3 | 2014-03-06 12:13:39 -0800 | [diff] [blame] | 833 | DCHECK(classlinker_classes_lock_ != nullptr); |
| 834 | DCHECK(heap_bitmap_lock_ != nullptr); |
| 835 | DCHECK(logging_lock_ != nullptr); |
| 836 | DCHECK(mutator_lock_ != nullptr); |
| 837 | DCHECK(thread_list_lock_ != nullptr); |
| 838 | DCHECK(thread_suspend_count_lock_ != nullptr); |
| 839 | DCHECK(trace_lock_ != nullptr); |
| 840 | DCHECK(profiler_lock_ != nullptr); |
| 841 | DCHECK(unexpected_signal_lock_ != nullptr); |
| 842 | DCHECK(intern_table_lock_ != nullptr); |
| 843 | } else { |
Chao-ying Fu | 9e36931 | 2014-05-21 11:20:52 -0700 | [diff] [blame] | 844 | // Create global locks in level order from highest lock level to lowest. |
| 845 | LockLevel current_lock_level = kMutatorLock; |
| 846 | DCHECK(mutator_lock_ == nullptr); |
| 847 | mutator_lock_ = new ReaderWriterMutex("mutator lock", current_lock_level); |
Ian Rogers | 719d1a3 | 2014-03-06 12:13:39 -0800 | [diff] [blame] | 848 | |
Chao-ying Fu | 9e36931 | 2014-05-21 11:20:52 -0700 | [diff] [blame] | 849 | #define UPDATE_CURRENT_LOCK_LEVEL(new_level) \ |
| 850 | DCHECK_LT(new_level, current_lock_level); \ |
| 851 | current_lock_level = new_level; |
| 852 | |
| 853 | UPDATE_CURRENT_LOCK_LEVEL(kHeapBitmapLock); |
| 854 | DCHECK(heap_bitmap_lock_ == nullptr); |
| 855 | heap_bitmap_lock_ = new ReaderWriterMutex("heap bitmap lock", current_lock_level); |
| 856 | |
| 857 | UPDATE_CURRENT_LOCK_LEVEL(kRuntimeShutdownLock); |
| 858 | DCHECK(runtime_shutdown_lock_ == nullptr); |
| 859 | runtime_shutdown_lock_ = new Mutex("runtime shutdown lock", current_lock_level); |
| 860 | |
| 861 | UPDATE_CURRENT_LOCK_LEVEL(kProfilerLock); |
| 862 | DCHECK(profiler_lock_ == nullptr); |
| 863 | profiler_lock_ = new Mutex("profiler lock", current_lock_level); |
| 864 | |
| 865 | UPDATE_CURRENT_LOCK_LEVEL(kTraceLock); |
| 866 | DCHECK(trace_lock_ == nullptr); |
| 867 | trace_lock_ = new Mutex("trace lock", current_lock_level); |
| 868 | |
| 869 | UPDATE_CURRENT_LOCK_LEVEL(kThreadListLock); |
| 870 | DCHECK(thread_list_lock_ == nullptr); |
| 871 | thread_list_lock_ = new Mutex("thread list lock", current_lock_level); |
| 872 | |
| 873 | UPDATE_CURRENT_LOCK_LEVEL(kBreakpointLock); |
Ian Rogers | 719d1a3 | 2014-03-06 12:13:39 -0800 | [diff] [blame] | 874 | DCHECK(breakpoint_lock_ == nullptr); |
Chao-ying Fu | 9e36931 | 2014-05-21 11:20:52 -0700 | [diff] [blame] | 875 | breakpoint_lock_ = new Mutex("breakpoint lock", current_lock_level); |
| 876 | |
| 877 | UPDATE_CURRENT_LOCK_LEVEL(kClassLinkerClassesLock); |
Ian Rogers | 719d1a3 | 2014-03-06 12:13:39 -0800 | [diff] [blame] | 878 | DCHECK(classlinker_classes_lock_ == nullptr); |
| 879 | classlinker_classes_lock_ = new ReaderWriterMutex("ClassLinker classes lock", |
Chao-ying Fu | 9e36931 | 2014-05-21 11:20:52 -0700 | [diff] [blame] | 880 | current_lock_level); |
| 881 | |
Andreas Gampe | 7424081 | 2014-04-17 10:35:09 -0700 | [diff] [blame] | 882 | UPDATE_CURRENT_LOCK_LEVEL(kMonitorPoolLock); |
| 883 | DCHECK(allocated_monitor_ids_lock_ == nullptr); |
| 884 | allocated_monitor_ids_lock_ = new Mutex("allocated monitor ids lock", current_lock_level); |
| 885 | |
Chao-ying Fu | 9e36931 | 2014-05-21 11:20:52 -0700 | [diff] [blame] | 886 | UPDATE_CURRENT_LOCK_LEVEL(kAllocatedThreadIdsLock); |
| 887 | DCHECK(allocated_thread_ids_lock_ == nullptr); |
| 888 | allocated_thread_ids_lock_ = new Mutex("allocated thread ids lock", current_lock_level); |
| 889 | |
Nicolas Geoffray | 7f0a6d6 | 2014-05-26 14:01:46 +0100 | [diff] [blame] | 890 | if (kRuntimeISA == kX86 || kRuntimeISA == kX86_64) { |
Chao-ying Fu | 9e36931 | 2014-05-21 11:20:52 -0700 | [diff] [blame] | 891 | UPDATE_CURRENT_LOCK_LEVEL(kModifyLdtLock); |
| 892 | DCHECK(modify_ldt_lock_ == nullptr); |
| 893 | modify_ldt_lock_ = new Mutex("modify_ldt lock", current_lock_level); |
| 894 | } |
| 895 | |
| 896 | UPDATE_CURRENT_LOCK_LEVEL(kInternTableLock); |
Ian Rogers | 719d1a3 | 2014-03-06 12:13:39 -0800 | [diff] [blame] | 897 | DCHECK(intern_table_lock_ == nullptr); |
Chao-ying Fu | 9e36931 | 2014-05-21 11:20:52 -0700 | [diff] [blame] | 898 | intern_table_lock_ = new Mutex("InternTable lock", current_lock_level); |
| 899 | |
| 900 | |
| 901 | UPDATE_CURRENT_LOCK_LEVEL(kAbortLock); |
| 902 | DCHECK(abort_lock_ == nullptr); |
| 903 | abort_lock_ = new Mutex("abort lock", current_lock_level, true); |
| 904 | |
| 905 | UPDATE_CURRENT_LOCK_LEVEL(kThreadSuspendCountLock); |
| 906 | DCHECK(thread_suspend_count_lock_ == nullptr); |
| 907 | thread_suspend_count_lock_ = new Mutex("thread suspend count lock", current_lock_level); |
| 908 | |
| 909 | UPDATE_CURRENT_LOCK_LEVEL(kUnexpectedSignalLock); |
| 910 | DCHECK(unexpected_signal_lock_ == nullptr); |
| 911 | unexpected_signal_lock_ = new Mutex("unexpected signal lock", current_lock_level, true); |
| 912 | |
Hiroshi Yamauchi | 3eed93d | 2014-06-04 11:43:59 -0700 | [diff] [blame] | 913 | UPDATE_CURRENT_LOCK_LEVEL(kMemMapsLock); |
| 914 | DCHECK(mem_maps_lock_ == nullptr); |
| 915 | mem_maps_lock_ = new Mutex("mem maps lock", current_lock_level); |
| 916 | |
Chao-ying Fu | 9e36931 | 2014-05-21 11:20:52 -0700 | [diff] [blame] | 917 | UPDATE_CURRENT_LOCK_LEVEL(kLoggingLock); |
| 918 | DCHECK(logging_lock_ == nullptr); |
| 919 | logging_lock_ = new Mutex("logging lock", current_lock_level, true); |
| 920 | |
| 921 | #undef UPDATE_CURRENT_LOCK_LEVEL |
Ian Rogers | 719d1a3 | 2014-03-06 12:13:39 -0800 | [diff] [blame] | 922 | } |
| 923 | } |
| 924 | |
| 925 | |
Elliott Hughes | e62934d | 2012-04-09 11:24:29 -0700 | [diff] [blame] | 926 | } // namespace art |