Brian Carlstrom | 27ec961 | 2011-09-19 20:20:38 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2008 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
| 17 | #include "mem_map.h" |
| 18 | |
Evgenii Stepanov | 1e13374 | 2015-05-20 12:30:59 -0700 | [diff] [blame] | 19 | #include "base/memory_tool.h" |
Christopher Ferris | 943af7d | 2014-01-16 12:41:46 -0800 | [diff] [blame] | 20 | #include <backtrace/BacktraceMap.h> |
Ian Rogers | c7dd295 | 2014-10-21 23:31:19 -0700 | [diff] [blame] | 21 | #include <inttypes.h> |
Josh Gao | 0389cd5 | 2015-09-16 16:27:00 -0700 | [diff] [blame] | 22 | #include <stdlib.h> |
Ian Rogers | c7dd295 | 2014-10-21 23:31:19 -0700 | [diff] [blame] | 23 | |
Ian Rogers | 700a402 | 2014-05-19 16:49:03 -0700 | [diff] [blame] | 24 | #include <memory> |
Ian Rogers | c7dd295 | 2014-10-21 23:31:19 -0700 | [diff] [blame] | 25 | #include <sstream> |
Elliott Hughes | ecd3a6f | 2012-06-06 18:16:37 -0700 | [diff] [blame] | 26 | |
Elliott Hughes | e222ee0 | 2012-12-13 14:41:43 -0800 | [diff] [blame] | 27 | #include "base/stringprintf.h" |
Andreas Gampe | 43e10b0 | 2016-07-15 17:17:34 -0700 | [diff] [blame] | 28 | #include "base/unix_file/fd_file.h" |
| 29 | #include "os.h" |
Ian Rogers | c7dd295 | 2014-10-21 23:31:19 -0700 | [diff] [blame] | 30 | #include "thread-inl.h" |
Elliott Hughes | e222ee0 | 2012-12-13 14:41:43 -0800 | [diff] [blame] | 31 | #include "utils.h" |
| 32 | |
Elliott Hughes | 6c9c06d | 2011-11-07 16:43:47 -0800 | [diff] [blame] | 33 | #include <cutils/ashmem.h> |
Nicolas Geoffray | a25dce9 | 2016-01-12 16:41:10 +0000 | [diff] [blame] | 34 | |
Ian Rogers | 997f0f9 | 2014-06-21 22:58:05 -0700 | [diff] [blame] | 35 | #ifndef ANDROID_OS |
| 36 | #include <sys/resource.h> |
| 37 | #endif |
Elliott Hughes | 6c9c06d | 2011-11-07 16:43:47 -0800 | [diff] [blame] | 38 | |
Ian Rogers | d6b6865 | 2014-06-23 14:07:03 -0700 | [diff] [blame] | 39 | #ifndef MAP_ANONYMOUS |
| 40 | #define MAP_ANONYMOUS MAP_ANON |
| 41 | #endif |
| 42 | |
Brian Carlstrom | 27ec961 | 2011-09-19 20:20:38 -0700 | [diff] [blame] | 43 | namespace art { |
| 44 | |
Christopher Ferris | 943af7d | 2014-01-16 12:41:46 -0800 | [diff] [blame] | 45 | static std::ostream& operator<<( |
| 46 | std::ostream& os, |
| 47 | std::pair<BacktraceMap::const_iterator, BacktraceMap::const_iterator> iters) { |
| 48 | for (BacktraceMap::const_iterator it = iters.first; it != iters.second; ++it) { |
| 49 | os << StringPrintf("0x%08x-0x%08x %c%c%c %s\n", |
| 50 | static_cast<uint32_t>(it->start), |
| 51 | static_cast<uint32_t>(it->end), |
| 52 | (it->flags & PROT_READ) ? 'r' : '-', |
| 53 | (it->flags & PROT_WRITE) ? 'w' : '-', |
| 54 | (it->flags & PROT_EXEC) ? 'x' : '-', it->name.c_str()); |
Elliott Hughes | ecd3a6f | 2012-06-06 18:16:37 -0700 | [diff] [blame] | 55 | } |
| 56 | return os; |
Brian Carlstrom | 27ec961 | 2011-09-19 20:20:38 -0700 | [diff] [blame] | 57 | } |
| 58 | |
Mathieu Chartier | bad0267 | 2014-08-25 13:08:22 -0700 | [diff] [blame] | 59 | std::ostream& operator<<(std::ostream& os, const MemMap::Maps& mem_maps) { |
Hiroshi Yamauchi | 3eed93d | 2014-06-04 11:43:59 -0700 | [diff] [blame] | 60 | os << "MemMap:" << std::endl; |
| 61 | for (auto it = mem_maps.begin(); it != mem_maps.end(); ++it) { |
| 62 | void* base = it->first; |
| 63 | MemMap* map = it->second; |
| 64 | CHECK_EQ(base, map->BaseBegin()); |
| 65 | os << *map << std::endl; |
| 66 | } |
| 67 | return os; |
| 68 | } |
| 69 | |
Mathieu Chartier | 6e88ef6 | 2014-10-14 15:01:24 -0700 | [diff] [blame] | 70 | MemMap::Maps* MemMap::maps_ = nullptr; |
Hiroshi Yamauchi | 3eed93d | 2014-06-04 11:43:59 -0700 | [diff] [blame] | 71 | |
Ian Rogers | c3ccc10 | 2014-06-25 11:52:14 -0700 | [diff] [blame] | 72 | #if USE_ART_LOW_4G_ALLOCATOR |
Andreas Gampe | d8f26db | 2014-05-19 17:01:13 -0700 | [diff] [blame] | 73 | // Handling mem_map in 32b address range for 64b architectures that do not support MAP_32BIT. |
| 74 | |
| 75 | // The regular start of memory allocations. The first 64KB is protected by SELinux. |
Andreas Gampe | 6bd621a | 2014-05-16 17:28:58 -0700 | [diff] [blame] | 76 | static constexpr uintptr_t LOW_MEM_START = 64 * KB; |
Andreas Gampe | 7104cbf | 2014-03-21 11:44:43 -0700 | [diff] [blame] | 77 | |
Andreas Gampe | d8f26db | 2014-05-19 17:01:13 -0700 | [diff] [blame] | 78 | // Generate random starting position. |
| 79 | // To not interfere with image position, take the image's address and only place it below. Current |
| 80 | // formula (sketch): |
| 81 | // |
| 82 | // ART_BASE_ADDR = 0001XXXXXXXXXXXXXXX |
| 83 | // ---------------------------------------- |
| 84 | // = 0000111111111111111 |
| 85 | // & ~(kPageSize - 1) =~0000000000000001111 |
| 86 | // ---------------------------------------- |
| 87 | // mask = 0000111111111110000 |
| 88 | // & random data = YYYYYYYYYYYYYYYYYYY |
| 89 | // ----------------------------------- |
| 90 | // tmp = 0000YYYYYYYYYYY0000 |
| 91 | // + LOW_MEM_START = 0000000000001000000 |
| 92 | // -------------------------------------- |
| 93 | // start |
| 94 | // |
Josh Gao | 0389cd5 | 2015-09-16 16:27:00 -0700 | [diff] [blame] | 95 | // arc4random as an entropy source is exposed in Bionic, but not in glibc. When we |
Andreas Gampe | d8f26db | 2014-05-19 17:01:13 -0700 | [diff] [blame] | 96 | // do not have Bionic, simply start with LOW_MEM_START. |
| 97 | |
| 98 | // Function is standalone so it can be tested somewhat in mem_map_test.cc. |
| 99 | #ifdef __BIONIC__ |
| 100 | uintptr_t CreateStartPos(uint64_t input) { |
| 101 | CHECK_NE(0, ART_BASE_ADDRESS); |
| 102 | |
| 103 | // Start with all bits below highest bit in ART_BASE_ADDRESS. |
| 104 | constexpr size_t leading_zeros = CLZ(static_cast<uint32_t>(ART_BASE_ADDRESS)); |
| 105 | constexpr uintptr_t mask_ones = (1 << (31 - leading_zeros)) - 1; |
| 106 | |
| 107 | // Lowest (usually 12) bits are not used, as aligned by page size. |
| 108 | constexpr uintptr_t mask = mask_ones & ~(kPageSize - 1); |
| 109 | |
| 110 | // Mask input data. |
| 111 | return (input & mask) + LOW_MEM_START; |
| 112 | } |
| 113 | #endif |
| 114 | |
| 115 | static uintptr_t GenerateNextMemPos() { |
| 116 | #ifdef __BIONIC__ |
Josh Gao | 0389cd5 | 2015-09-16 16:27:00 -0700 | [diff] [blame] | 117 | uint64_t random_data; |
| 118 | arc4random_buf(&random_data, sizeof(random_data)); |
| 119 | return CreateStartPos(random_data); |
Andreas Gampe | d8f26db | 2014-05-19 17:01:13 -0700 | [diff] [blame] | 120 | #else |
Josh Gao | 0389cd5 | 2015-09-16 16:27:00 -0700 | [diff] [blame] | 121 | // No arc4random on host, see above. |
Andreas Gampe | d8f26db | 2014-05-19 17:01:13 -0700 | [diff] [blame] | 122 | return LOW_MEM_START; |
| 123 | #endif |
| 124 | } |
| 125 | |
| 126 | // Initialize linear scan to random position. |
| 127 | uintptr_t MemMap::next_mem_pos_ = GenerateNextMemPos(); |
Stuart Monteith | 8dba5aa | 2014-03-12 12:44:01 +0000 | [diff] [blame] | 128 | #endif |
| 129 | |
Mathieu Chartier | 24a0fc8 | 2015-10-13 16:38:52 -0700 | [diff] [blame] | 130 | // Return true if the address range is contained in a single memory map by either reading |
| 131 | // the maps_ variable or the /proc/self/map entry. |
Mathieu Chartier | e58991b | 2015-10-13 07:59:34 -0700 | [diff] [blame] | 132 | bool MemMap::ContainedWithinExistingMap(uint8_t* ptr, size_t size, std::string* error_msg) { |
Vladimir Marko | 5c42c29 | 2015-02-25 12:02:49 +0000 | [diff] [blame] | 133 | uintptr_t begin = reinterpret_cast<uintptr_t>(ptr); |
| 134 | uintptr_t end = begin + size; |
Mathieu Chartier | e58991b | 2015-10-13 07:59:34 -0700 | [diff] [blame] | 135 | |
Mathieu Chartier | 24a0fc8 | 2015-10-13 16:38:52 -0700 | [diff] [blame] | 136 | // There is a suspicion that BacktraceMap::Create is occasionally missing maps. TODO: Investigate |
| 137 | // further. |
Mathieu Chartier | e58991b | 2015-10-13 07:59:34 -0700 | [diff] [blame] | 138 | { |
| 139 | MutexLock mu(Thread::Current(), *Locks::mem_maps_lock_); |
Mathieu Chartier | 24a0fc8 | 2015-10-13 16:38:52 -0700 | [diff] [blame] | 140 | for (auto& pair : *maps_) { |
Mathieu Chartier | e58991b | 2015-10-13 07:59:34 -0700 | [diff] [blame] | 141 | MemMap* const map = pair.second; |
| 142 | if (begin >= reinterpret_cast<uintptr_t>(map->Begin()) && |
| 143 | end <= reinterpret_cast<uintptr_t>(map->End())) { |
| 144 | return true; |
| 145 | } |
| 146 | } |
| 147 | } |
| 148 | |
Jim_Guo | a62a588 | 2014-04-28 11:11:57 +0800 | [diff] [blame] | 149 | std::unique_ptr<BacktraceMap> map(BacktraceMap::Create(getpid(), true)); |
Mathieu Chartier | ebe2dfc | 2015-11-24 13:47:52 -0800 | [diff] [blame] | 150 | if (map == nullptr) { |
| 151 | if (error_msg != nullptr) { |
| 152 | *error_msg = StringPrintf("Failed to build process map"); |
| 153 | } |
Jim_Guo | a62a588 | 2014-04-28 11:11:57 +0800 | [diff] [blame] | 154 | return false; |
| 155 | } |
Christopher Ferris | 56f8b56 | 2016-06-16 23:19:36 -0700 | [diff] [blame] | 156 | |
| 157 | ScopedBacktraceMapIteratorLock lock(map.get()); |
Jim_Guo | a62a588 | 2014-04-28 11:11:57 +0800 | [diff] [blame] | 158 | for (BacktraceMap::const_iterator it = map->begin(); it != map->end(); ++it) { |
| 159 | if ((begin >= it->start && begin < it->end) // start of new within old |
| 160 | && (end > it->start && end <= it->end)) { // end of new within old |
| 161 | return true; |
| 162 | } |
| 163 | } |
Mathieu Chartier | ebe2dfc | 2015-11-24 13:47:52 -0800 | [diff] [blame] | 164 | if (error_msg != nullptr) { |
| 165 | PrintFileToLog("/proc/self/maps", LogSeverity::ERROR); |
| 166 | *error_msg = StringPrintf("Requested region 0x%08" PRIxPTR "-0x%08" PRIxPTR " does not overlap " |
| 167 | "any existing map. See process maps in the log.", begin, end); |
| 168 | } |
Jim_Guo | a62a588 | 2014-04-28 11:11:57 +0800 | [diff] [blame] | 169 | return false; |
| 170 | } |
| 171 | |
| 172 | // Return true if the address range does not conflict with any /proc/self/maps entry. |
| 173 | static bool CheckNonOverlapping(uintptr_t begin, |
| 174 | uintptr_t end, |
| 175 | std::string* error_msg) { |
| 176 | std::unique_ptr<BacktraceMap> map(BacktraceMap::Create(getpid(), true)); |
Christopher Ferris | 836572a | 2014-08-05 15:43:13 -0700 | [diff] [blame] | 177 | if (map.get() == nullptr) { |
Jim_Guo | a62a588 | 2014-04-28 11:11:57 +0800 | [diff] [blame] | 178 | *error_msg = StringPrintf("Failed to build process map"); |
| 179 | return false; |
| 180 | } |
Christopher Ferris | 56f8b56 | 2016-06-16 23:19:36 -0700 | [diff] [blame] | 181 | ScopedBacktraceMapIteratorLock(map.get()); |
Jim_Guo | a62a588 | 2014-04-28 11:11:57 +0800 | [diff] [blame] | 182 | for (BacktraceMap::const_iterator it = map->begin(); it != map->end(); ++it) { |
| 183 | if ((begin >= it->start && begin < it->end) // start of new within old |
| 184 | || (end > it->start && end < it->end) // end of new within old |
| 185 | || (begin <= it->start && end > it->end)) { // start/end of new includes all of old |
| 186 | std::ostringstream map_info; |
| 187 | map_info << std::make_pair(it, map->end()); |
| 188 | *error_msg = StringPrintf("Requested region 0x%08" PRIxPTR "-0x%08" PRIxPTR " overlaps with " |
| 189 | "existing map 0x%08" PRIxPTR "-0x%08" PRIxPTR " (%s)\n%s", |
| 190 | begin, end, |
| 191 | static_cast<uintptr_t>(it->start), static_cast<uintptr_t>(it->end), |
| 192 | it->name.c_str(), |
| 193 | map_info.str().c_str()); |
| 194 | return false; |
| 195 | } |
| 196 | } |
| 197 | return true; |
| 198 | } |
| 199 | |
| 200 | // CheckMapRequest to validate a non-MAP_FAILED mmap result based on |
| 201 | // the expected value, calling munmap if validation fails, giving the |
| 202 | // reason in error_msg. |
| 203 | // |
Mathieu Chartier | 2cebb24 | 2015-04-21 16:50:40 -0700 | [diff] [blame] | 204 | // If the expected_ptr is null, nothing is checked beyond the fact |
Jim_Guo | a62a588 | 2014-04-28 11:11:57 +0800 | [diff] [blame] | 205 | // that the actual_ptr is not MAP_FAILED. However, if expected_ptr is |
| 206 | // non-null, we check that pointer is the actual_ptr == expected_ptr, |
| 207 | // and if not, report in error_msg what the conflict mapping was if |
| 208 | // found, or a generic error in other cases. |
Ian Rogers | 1373595 | 2014-10-08 12:43:28 -0700 | [diff] [blame] | 209 | static bool CheckMapRequest(uint8_t* expected_ptr, void* actual_ptr, size_t byte_count, |
Jim_Guo | a62a588 | 2014-04-28 11:11:57 +0800 | [diff] [blame] | 210 | std::string* error_msg) { |
Hiroshi Yamauchi | 4fb5df8 | 2014-03-13 15:10:27 -0700 | [diff] [blame] | 211 | // Handled first by caller for more specific error messages. |
| 212 | CHECK(actual_ptr != MAP_FAILED); |
| 213 | |
| 214 | if (expected_ptr == nullptr) { |
| 215 | return true; |
Brian Carlstrom | 27ec961 | 2011-09-19 20:20:38 -0700 | [diff] [blame] | 216 | } |
Elliott Hughes | ecd3a6f | 2012-06-06 18:16:37 -0700 | [diff] [blame] | 217 | |
Jim_Guo | a62a588 | 2014-04-28 11:11:57 +0800 | [diff] [blame] | 218 | uintptr_t actual = reinterpret_cast<uintptr_t>(actual_ptr); |
| 219 | uintptr_t expected = reinterpret_cast<uintptr_t>(expected_ptr); |
| 220 | uintptr_t limit = expected + byte_count; |
| 221 | |
Hiroshi Yamauchi | 4fb5df8 | 2014-03-13 15:10:27 -0700 | [diff] [blame] | 222 | if (expected_ptr == actual_ptr) { |
| 223 | return true; |
| 224 | } |
| 225 | |
| 226 | // We asked for an address but didn't get what we wanted, all paths below here should fail. |
| 227 | int result = munmap(actual_ptr, byte_count); |
| 228 | if (result == -1) { |
| 229 | PLOG(WARNING) << StringPrintf("munmap(%p, %zd) failed", actual_ptr, byte_count); |
| 230 | } |
| 231 | |
Mathieu Chartier | ebe2dfc | 2015-11-24 13:47:52 -0800 | [diff] [blame] | 232 | if (error_msg != nullptr) { |
Mathieu Chartier | 83723ae | 2016-02-24 10:09:23 -0800 | [diff] [blame] | 233 | // We call this here so that we can try and generate a full error |
| 234 | // message with the overlapping mapping. There's no guarantee that |
| 235 | // that there will be an overlap though, since |
| 236 | // - The kernel is not *required* to honor expected_ptr unless MAP_FIXED is |
| 237 | // true, even if there is no overlap |
| 238 | // - There might have been an overlap at the point of mmap, but the |
| 239 | // overlapping region has since been unmapped. |
| 240 | std::string error_detail; |
| 241 | CheckNonOverlapping(expected, limit, &error_detail); |
Mathieu Chartier | ebe2dfc | 2015-11-24 13:47:52 -0800 | [diff] [blame] | 242 | std::ostringstream os; |
| 243 | os << StringPrintf("Failed to mmap at expected address, mapped at " |
| 244 | "0x%08" PRIxPTR " instead of 0x%08" PRIxPTR, |
| 245 | actual, expected); |
| 246 | if (!error_detail.empty()) { |
| 247 | os << " : " << error_detail; |
| 248 | } |
| 249 | *error_msg = os.str(); |
Christopher Ferris | 943af7d | 2014-01-16 12:41:46 -0800 | [diff] [blame] | 250 | } |
Hiroshi Yamauchi | 4fb5df8 | 2014-03-13 15:10:27 -0700 | [diff] [blame] | 251 | return false; |
Brian Carlstrom | 27ec961 | 2011-09-19 20:20:38 -0700 | [diff] [blame] | 252 | } |
| 253 | |
Mathieu Chartier | 38c8221 | 2015-06-04 16:22:41 -0700 | [diff] [blame] | 254 | #if USE_ART_LOW_4G_ALLOCATOR |
Mathieu Chartier | 42bddce | 2015-11-09 15:16:56 -0800 | [diff] [blame] | 255 | static inline void* TryMemMapLow4GB(void* ptr, |
| 256 | size_t page_aligned_byte_count, |
| 257 | int prot, |
| 258 | int flags, |
| 259 | int fd, |
| 260 | off_t offset) { |
| 261 | void* actual = mmap(ptr, page_aligned_byte_count, prot, flags, fd, offset); |
Mathieu Chartier | 38c8221 | 2015-06-04 16:22:41 -0700 | [diff] [blame] | 262 | if (actual != MAP_FAILED) { |
| 263 | // Since we didn't use MAP_FIXED the kernel may have mapped it somewhere not in the low |
| 264 | // 4GB. If this is the case, unmap and retry. |
| 265 | if (reinterpret_cast<uintptr_t>(actual) + page_aligned_byte_count >= 4 * GB) { |
| 266 | munmap(actual, page_aligned_byte_count); |
| 267 | actual = MAP_FAILED; |
| 268 | } |
| 269 | } |
| 270 | return actual; |
| 271 | } |
| 272 | #endif |
| 273 | |
Mathieu Chartier | 42bddce | 2015-11-09 15:16:56 -0800 | [diff] [blame] | 274 | MemMap* MemMap::MapAnonymous(const char* name, |
| 275 | uint8_t* expected_ptr, |
| 276 | size_t byte_count, |
| 277 | int prot, |
| 278 | bool low_4gb, |
| 279 | bool reuse, |
Nicolas Geoffray | a25dce9 | 2016-01-12 16:41:10 +0000 | [diff] [blame] | 280 | std::string* error_msg, |
| 281 | bool use_ashmem) { |
Ian Rogers | 6a3c1fc | 2014-10-31 00:33:20 -0700 | [diff] [blame] | 282 | #ifndef __LP64__ |
| 283 | UNUSED(low_4gb); |
| 284 | #endif |
Brian Carlstrom | 9004cb6 | 2013-07-26 15:48:31 -0700 | [diff] [blame] | 285 | if (byte_count == 0) { |
Jim_Guo | a62a588 | 2014-04-28 11:11:57 +0800 | [diff] [blame] | 286 | return new MemMap(name, nullptr, 0, nullptr, 0, prot, false); |
Brian Carlstrom | 9004cb6 | 2013-07-26 15:48:31 -0700 | [diff] [blame] | 287 | } |
Elliott Hughes | ecd3a6f | 2012-06-06 18:16:37 -0700 | [diff] [blame] | 288 | size_t page_aligned_byte_count = RoundUp(byte_count, kPageSize); |
Elliott Hughes | 6c9c06d | 2011-11-07 16:43:47 -0800 | [diff] [blame] | 289 | |
Elliott Hughes | 6c9c06d | 2011-11-07 16:43:47 -0800 | [diff] [blame] | 290 | int flags = MAP_PRIVATE | MAP_ANONYMOUS; |
Vladimir Marko | 5c42c29 | 2015-02-25 12:02:49 +0000 | [diff] [blame] | 291 | if (reuse) { |
| 292 | // reuse means it is okay that it overlaps an existing page mapping. |
| 293 | // Only use this if you actually made the page reservation yourself. |
| 294 | CHECK(expected_ptr != nullptr); |
| 295 | |
Vladimir Marko | b550582 | 2015-05-08 11:10:16 +0100 | [diff] [blame] | 296 | DCHECK(ContainedWithinExistingMap(expected_ptr, byte_count, error_msg)) << *error_msg; |
Vladimir Marko | 5c42c29 | 2015-02-25 12:02:49 +0000 | [diff] [blame] | 297 | flags |= MAP_FIXED; |
| 298 | } |
| 299 | |
Andreas Gampe | 43e10b0 | 2016-07-15 17:17:34 -0700 | [diff] [blame] | 300 | File fd; |
Ian Rogers | 997f0f9 | 2014-06-21 22:58:05 -0700 | [diff] [blame] | 301 | |
Nicolas Geoffray | a25dce9 | 2016-01-12 16:41:10 +0000 | [diff] [blame] | 302 | if (use_ashmem) { |
| 303 | if (!kIsTargetBuild) { |
Bilyan Borisov | 3071f80 | 2016-03-31 17:15:53 +0100 | [diff] [blame] | 304 | // When not on Android (either host or assuming a linux target) ashmem is faked using |
| 305 | // files in /tmp. Ensure that such files won't fail due to ulimit restrictions. If they |
| 306 | // will then use a regular mmap. |
Nicolas Geoffray | a25dce9 | 2016-01-12 16:41:10 +0000 | [diff] [blame] | 307 | struct rlimit rlimit_fsize; |
| 308 | CHECK_EQ(getrlimit(RLIMIT_FSIZE, &rlimit_fsize), 0); |
| 309 | use_ashmem = (rlimit_fsize.rlim_cur == RLIM_INFINITY) || |
| 310 | (page_aligned_byte_count < rlimit_fsize.rlim_cur); |
| 311 | } |
| 312 | } |
| 313 | |
Ian Rogers | 997f0f9 | 2014-06-21 22:58:05 -0700 | [diff] [blame] | 314 | if (use_ashmem) { |
| 315 | // android_os_Debug.cpp read_mapinfo assumes all ashmem regions associated with the VM are |
| 316 | // prefixed "dalvik-". |
| 317 | std::string debug_friendly_name("dalvik-"); |
| 318 | debug_friendly_name += name; |
Andreas Gampe | 43e10b0 | 2016-07-15 17:17:34 -0700 | [diff] [blame] | 319 | fd.Reset(ashmem_create_region(debug_friendly_name.c_str(), page_aligned_byte_count), |
| 320 | /* check_usage */ false); |
| 321 | if (fd.Fd() == -1) { |
Ian Rogers | 997f0f9 | 2014-06-21 22:58:05 -0700 | [diff] [blame] | 322 | *error_msg = StringPrintf("ashmem_create_region failed for '%s': %s", name, strerror(errno)); |
| 323 | return nullptr; |
| 324 | } |
Vladimir Marko | 5c42c29 | 2015-02-25 12:02:49 +0000 | [diff] [blame] | 325 | flags &= ~MAP_ANONYMOUS; |
Ian Rogers | 997f0f9 | 2014-06-21 22:58:05 -0700 | [diff] [blame] | 326 | } |
Stuart Monteith | 8dba5aa | 2014-03-12 12:44:01 +0000 | [diff] [blame] | 327 | |
Brian Carlstrom | aa94cf3 | 2014-03-23 23:47:25 -0700 | [diff] [blame] | 328 | // We need to store and potentially set an error number for pretty printing of errors |
| 329 | int saved_errno = 0; |
| 330 | |
Mathieu Chartier | 42bddce | 2015-11-09 15:16:56 -0800 | [diff] [blame] | 331 | void* actual = MapInternal(expected_ptr, |
| 332 | page_aligned_byte_count, |
| 333 | prot, |
| 334 | flags, |
Andreas Gampe | 43e10b0 | 2016-07-15 17:17:34 -0700 | [diff] [blame] | 335 | fd.Fd(), |
Mathieu Chartier | 42bddce | 2015-11-09 15:16:56 -0800 | [diff] [blame] | 336 | 0, |
| 337 | low_4gb); |
Brian Carlstrom | aa94cf3 | 2014-03-23 23:47:25 -0700 | [diff] [blame] | 338 | saved_errno = errno; |
Stuart Monteith | 8dba5aa | 2014-03-12 12:44:01 +0000 | [diff] [blame] | 339 | |
Brian Carlstrom | 27ec961 | 2011-09-19 20:20:38 -0700 | [diff] [blame] | 340 | if (actual == MAP_FAILED) { |
Mathieu Chartier | 83723ae | 2016-02-24 10:09:23 -0800 | [diff] [blame] | 341 | if (error_msg != nullptr) { |
Andreas Gampe | 7fa5578 | 2016-06-15 17:45:01 -0700 | [diff] [blame] | 342 | if (kIsDebugBuild || VLOG_IS_ON(oat)) { |
| 343 | PrintFileToLog("/proc/self/maps", LogSeverity::WARNING); |
| 344 | } |
Brian Carlstrom | aa94cf3 | 2014-03-23 23:47:25 -0700 | [diff] [blame] | 345 | |
Mathieu Chartier | 83723ae | 2016-02-24 10:09:23 -0800 | [diff] [blame] | 346 | *error_msg = StringPrintf("Failed anonymous mmap(%p, %zd, 0x%x, 0x%x, %d, 0): %s. " |
| 347 | "See process maps in the log.", |
| 348 | expected_ptr, |
| 349 | page_aligned_byte_count, |
| 350 | prot, |
| 351 | flags, |
Andreas Gampe | 43e10b0 | 2016-07-15 17:17:34 -0700 | [diff] [blame] | 352 | fd.Fd(), |
Mathieu Chartier | 83723ae | 2016-02-24 10:09:23 -0800 | [diff] [blame] | 353 | strerror(saved_errno)); |
| 354 | } |
Ian Rogers | 8d31bbd | 2013-10-13 10:44:14 -0700 | [diff] [blame] | 355 | return nullptr; |
Brian Carlstrom | 27ec961 | 2011-09-19 20:20:38 -0700 | [diff] [blame] | 356 | } |
Hiroshi Yamauchi | 4fb5df8 | 2014-03-13 15:10:27 -0700 | [diff] [blame] | 357 | std::ostringstream check_map_request_error_msg; |
Jim_Guo | a62a588 | 2014-04-28 11:11:57 +0800 | [diff] [blame] | 358 | if (!CheckMapRequest(expected_ptr, actual, page_aligned_byte_count, error_msg)) { |
Hiroshi Yamauchi | 4fb5df8 | 2014-03-13 15:10:27 -0700 | [diff] [blame] | 359 | return nullptr; |
| 360 | } |
Ian Rogers | 1373595 | 2014-10-08 12:43:28 -0700 | [diff] [blame] | 361 | return new MemMap(name, reinterpret_cast<uint8_t*>(actual), byte_count, actual, |
Mathieu Chartier | 01d4b50 | 2015-06-12 17:32:31 -0700 | [diff] [blame] | 362 | page_aligned_byte_count, prot, reuse); |
Brian Carlstrom | 27ec961 | 2011-09-19 20:20:38 -0700 | [diff] [blame] | 363 | } |
| 364 | |
David Srbecky | 1baabf0 | 2015-06-16 17:12:34 +0000 | [diff] [blame] | 365 | MemMap* MemMap::MapDummy(const char* name, uint8_t* addr, size_t byte_count) { |
| 366 | if (byte_count == 0) { |
| 367 | return new MemMap(name, nullptr, 0, nullptr, 0, 0, false); |
| 368 | } |
| 369 | const size_t page_aligned_byte_count = RoundUp(byte_count, kPageSize); |
| 370 | return new MemMap(name, addr, byte_count, addr, page_aligned_byte_count, 0, true /* reuse */); |
| 371 | } |
| 372 | |
Mathieu Chartier | 42bddce | 2015-11-09 15:16:56 -0800 | [diff] [blame] | 373 | MemMap* MemMap::MapFileAtAddress(uint8_t* expected_ptr, |
| 374 | size_t byte_count, |
| 375 | int prot, |
| 376 | int flags, |
| 377 | int fd, |
| 378 | off_t start, |
| 379 | bool low_4gb, |
| 380 | bool reuse, |
| 381 | const char* filename, |
Ian Rogers | 8d31bbd | 2013-10-13 10:44:14 -0700 | [diff] [blame] | 382 | std::string* error_msg) { |
Brian Carlstrom | 27ec961 | 2011-09-19 20:20:38 -0700 | [diff] [blame] | 383 | CHECK_NE(0, prot); |
| 384 | CHECK_NE(0, flags & (MAP_SHARED | MAP_PRIVATE)); |
Narayan Kamath | b89c3da | 2014-08-21 17:38:09 +0100 | [diff] [blame] | 385 | |
| 386 | // Note that we do not allow MAP_FIXED unless reuse == true, i.e we |
| 387 | // expect his mapping to be contained within an existing map. |
Hiroshi Yamauchi | 4fb5df8 | 2014-03-13 15:10:27 -0700 | [diff] [blame] | 388 | if (reuse) { |
| 389 | // reuse means it is okay that it overlaps an existing page mapping. |
| 390 | // Only use this if you actually made the page reservation yourself. |
Jim_Guo | a62a588 | 2014-04-28 11:11:57 +0800 | [diff] [blame] | 391 | CHECK(expected_ptr != nullptr); |
Narayan Kamath | b89c3da | 2014-08-21 17:38:09 +0100 | [diff] [blame] | 392 | |
Mathieu Chartier | ebe2dfc | 2015-11-24 13:47:52 -0800 | [diff] [blame] | 393 | DCHECK(ContainedWithinExistingMap(expected_ptr, byte_count, error_msg)) |
| 394 | << ((error_msg != nullptr) ? *error_msg : std::string()); |
Hiroshi Yamauchi | 4fb5df8 | 2014-03-13 15:10:27 -0700 | [diff] [blame] | 395 | flags |= MAP_FIXED; |
| 396 | } else { |
| 397 | CHECK_EQ(0, flags & MAP_FIXED); |
Narayan Kamath | b89c3da | 2014-08-21 17:38:09 +0100 | [diff] [blame] | 398 | // Don't bother checking for an overlapping region here. We'll |
| 399 | // check this if required after the fact inside CheckMapRequest. |
Hiroshi Yamauchi | 4fb5df8 | 2014-03-13 15:10:27 -0700 | [diff] [blame] | 400 | } |
| 401 | |
Brian Carlstrom | 9004cb6 | 2013-07-26 15:48:31 -0700 | [diff] [blame] | 402 | if (byte_count == 0) { |
Jim_Guo | a62a588 | 2014-04-28 11:11:57 +0800 | [diff] [blame] | 403 | return new MemMap(filename, nullptr, 0, nullptr, 0, prot, false); |
Brian Carlstrom | 9004cb6 | 2013-07-26 15:48:31 -0700 | [diff] [blame] | 404 | } |
Ian Rogers | f8adc60 | 2013-04-18 17:06:19 -0700 | [diff] [blame] | 405 | // Adjust 'offset' to be page-aligned as required by mmap. |
Brian Carlstrom | 27ec961 | 2011-09-19 20:20:38 -0700 | [diff] [blame] | 406 | int page_offset = start % kPageSize; |
| 407 | off_t page_aligned_offset = start - page_offset; |
Ian Rogers | f8adc60 | 2013-04-18 17:06:19 -0700 | [diff] [blame] | 408 | // Adjust 'byte_count' to be page-aligned as we will map this anyway. |
Elliott Hughes | ecd3a6f | 2012-06-06 18:16:37 -0700 | [diff] [blame] | 409 | size_t page_aligned_byte_count = RoundUp(byte_count + page_offset, kPageSize); |
Jim_Guo | a62a588 | 2014-04-28 11:11:57 +0800 | [diff] [blame] | 410 | // The 'expected_ptr' is modified (if specified, ie non-null) to be page aligned to the file but |
| 411 | // not necessarily to virtual memory. mmap will page align 'expected' for us. |
Mathieu Chartier | 2cebb24 | 2015-04-21 16:50:40 -0700 | [diff] [blame] | 412 | uint8_t* page_aligned_expected = |
| 413 | (expected_ptr == nullptr) ? nullptr : (expected_ptr - page_offset); |
Hiroshi Yamauchi | 4fb5df8 | 2014-03-13 15:10:27 -0700 | [diff] [blame] | 414 | |
Evgenii Stepanov | 1e13374 | 2015-05-20 12:30:59 -0700 | [diff] [blame] | 415 | size_t redzone_size = 0; |
| 416 | if (RUNNING_ON_MEMORY_TOOL && kMemoryToolAddsRedzones && expected_ptr == nullptr) { |
| 417 | redzone_size = kPageSize; |
| 418 | page_aligned_byte_count += redzone_size; |
| 419 | } |
| 420 | |
Mathieu Chartier | 42bddce | 2015-11-09 15:16:56 -0800 | [diff] [blame] | 421 | uint8_t* actual = reinterpret_cast<uint8_t*>(MapInternal(page_aligned_expected, |
| 422 | page_aligned_byte_count, |
| 423 | prot, |
| 424 | flags, |
| 425 | fd, |
| 426 | page_aligned_offset, |
| 427 | low_4gb)); |
Brian Carlstrom | 27ec961 | 2011-09-19 20:20:38 -0700 | [diff] [blame] | 428 | if (actual == MAP_FAILED) { |
Mathieu Chartier | ebe2dfc | 2015-11-24 13:47:52 -0800 | [diff] [blame] | 429 | if (error_msg != nullptr) { |
| 430 | auto saved_errno = errno; |
Brian Carlstrom | aa94cf3 | 2014-03-23 23:47:25 -0700 | [diff] [blame] | 431 | |
Andreas Gampe | 7ec0904 | 2016-04-01 17:20:49 -0700 | [diff] [blame] | 432 | if (kIsDebugBuild || VLOG_IS_ON(oat)) { |
| 433 | PrintFileToLog("/proc/self/maps", LogSeverity::WARNING); |
| 434 | } |
Brian Carlstrom | aa94cf3 | 2014-03-23 23:47:25 -0700 | [diff] [blame] | 435 | |
Mathieu Chartier | ebe2dfc | 2015-11-24 13:47:52 -0800 | [diff] [blame] | 436 | *error_msg = StringPrintf("mmap(%p, %zd, 0x%x, 0x%x, %d, %" PRId64 |
| 437 | ") of file '%s' failed: %s. See process maps in the log.", |
| 438 | page_aligned_expected, page_aligned_byte_count, prot, flags, fd, |
| 439 | static_cast<int64_t>(page_aligned_offset), filename, |
| 440 | strerror(saved_errno)); |
| 441 | } |
Hiroshi Yamauchi | 4fb5df8 | 2014-03-13 15:10:27 -0700 | [diff] [blame] | 442 | return nullptr; |
| 443 | } |
| 444 | std::ostringstream check_map_request_error_msg; |
Jim_Guo | a62a588 | 2014-04-28 11:11:57 +0800 | [diff] [blame] | 445 | if (!CheckMapRequest(expected_ptr, actual, page_aligned_byte_count, error_msg)) { |
Hiroshi Yamauchi | 4fb5df8 | 2014-03-13 15:10:27 -0700 | [diff] [blame] | 446 | return nullptr; |
Brian Carlstrom | 27ec961 | 2011-09-19 20:20:38 -0700 | [diff] [blame] | 447 | } |
Evgenii Stepanov | 1e13374 | 2015-05-20 12:30:59 -0700 | [diff] [blame] | 448 | if (redzone_size != 0) { |
| 449 | const uint8_t *real_start = actual + page_offset; |
| 450 | const uint8_t *real_end = actual + page_offset + byte_count; |
| 451 | const uint8_t *mapping_end = actual + page_aligned_byte_count; |
| 452 | |
| 453 | MEMORY_TOOL_MAKE_NOACCESS(actual, real_start - actual); |
| 454 | MEMORY_TOOL_MAKE_NOACCESS(real_end, mapping_end - real_end); |
| 455 | page_aligned_byte_count -= redzone_size; |
| 456 | } |
| 457 | |
Brian Carlstrom | 0d6adac | 2014-02-05 17:39:16 -0800 | [diff] [blame] | 458 | return new MemMap(filename, actual + page_offset, byte_count, actual, page_aligned_byte_count, |
Evgenii Stepanov | 1e13374 | 2015-05-20 12:30:59 -0700 | [diff] [blame] | 459 | prot, reuse, redzone_size); |
Brian Carlstrom | 27ec961 | 2011-09-19 20:20:38 -0700 | [diff] [blame] | 460 | } |
| 461 | |
| 462 | MemMap::~MemMap() { |
Hiroshi Yamauchi | 4fb5df8 | 2014-03-13 15:10:27 -0700 | [diff] [blame] | 463 | if (base_begin_ == nullptr && base_size_ == 0) { |
Brian Carlstrom | 27ec961 | 2011-09-19 20:20:38 -0700 | [diff] [blame] | 464 | return; |
| 465 | } |
Evgenii Stepanov | 1e13374 | 2015-05-20 12:30:59 -0700 | [diff] [blame] | 466 | |
| 467 | // Unlike Valgrind, AddressSanitizer requires that all manually poisoned memory is unpoisoned |
| 468 | // before it is returned to the system. |
| 469 | if (redzone_size_ != 0) { |
| 470 | MEMORY_TOOL_MAKE_UNDEFINED( |
| 471 | reinterpret_cast<char*>(base_begin_) + base_size_ - redzone_size_, |
| 472 | redzone_size_); |
| 473 | } |
| 474 | |
Jim_Guo | a62a588 | 2014-04-28 11:11:57 +0800 | [diff] [blame] | 475 | if (!reuse_) { |
Evgenii Stepanov | 1e13374 | 2015-05-20 12:30:59 -0700 | [diff] [blame] | 476 | MEMORY_TOOL_MAKE_UNDEFINED(base_begin_, base_size_); |
Jim_Guo | a62a588 | 2014-04-28 11:11:57 +0800 | [diff] [blame] | 477 | int result = munmap(base_begin_, base_size_); |
| 478 | if (result == -1) { |
| 479 | PLOG(FATAL) << "munmap failed"; |
| 480 | } |
Brian Carlstrom | 27ec961 | 2011-09-19 20:20:38 -0700 | [diff] [blame] | 481 | } |
Hiroshi Yamauchi | 3eed93d | 2014-06-04 11:43:59 -0700 | [diff] [blame] | 482 | |
| 483 | // Remove it from maps_. |
| 484 | MutexLock mu(Thread::Current(), *Locks::mem_maps_lock_); |
| 485 | bool found = false; |
Mathieu Chartier | 6e88ef6 | 2014-10-14 15:01:24 -0700 | [diff] [blame] | 486 | DCHECK(maps_ != nullptr); |
| 487 | for (auto it = maps_->lower_bound(base_begin_), end = maps_->end(); |
Hiroshi Yamauchi | 3eed93d | 2014-06-04 11:43:59 -0700 | [diff] [blame] | 488 | it != end && it->first == base_begin_; ++it) { |
| 489 | if (it->second == this) { |
| 490 | found = true; |
Mathieu Chartier | 6e88ef6 | 2014-10-14 15:01:24 -0700 | [diff] [blame] | 491 | maps_->erase(it); |
Hiroshi Yamauchi | 3eed93d | 2014-06-04 11:43:59 -0700 | [diff] [blame] | 492 | break; |
| 493 | } |
| 494 | } |
| 495 | CHECK(found) << "MemMap not found"; |
Brian Carlstrom | 27ec961 | 2011-09-19 20:20:38 -0700 | [diff] [blame] | 496 | } |
| 497 | |
Ian Rogers | 1373595 | 2014-10-08 12:43:28 -0700 | [diff] [blame] | 498 | MemMap::MemMap(const std::string& name, uint8_t* begin, size_t size, void* base_begin, |
Evgenii Stepanov | 1e13374 | 2015-05-20 12:30:59 -0700 | [diff] [blame] | 499 | size_t base_size, int prot, bool reuse, size_t redzone_size) |
Mathieu Chartier | 1c23e1e | 2012-10-12 14:14:11 -0700 | [diff] [blame] | 500 | : name_(name), begin_(begin), size_(size), base_begin_(base_begin), base_size_(base_size), |
Evgenii Stepanov | 1e13374 | 2015-05-20 12:30:59 -0700 | [diff] [blame] | 501 | prot_(prot), reuse_(reuse), redzone_size_(redzone_size) { |
Brian Carlstrom | 9004cb6 | 2013-07-26 15:48:31 -0700 | [diff] [blame] | 502 | if (size_ == 0) { |
Hiroshi Yamauchi | 4fb5df8 | 2014-03-13 15:10:27 -0700 | [diff] [blame] | 503 | CHECK(begin_ == nullptr); |
| 504 | CHECK(base_begin_ == nullptr); |
Brian Carlstrom | 9004cb6 | 2013-07-26 15:48:31 -0700 | [diff] [blame] | 505 | CHECK_EQ(base_size_, 0U); |
| 506 | } else { |
Hiroshi Yamauchi | 4fb5df8 | 2014-03-13 15:10:27 -0700 | [diff] [blame] | 507 | CHECK(begin_ != nullptr); |
| 508 | CHECK(base_begin_ != nullptr); |
Brian Carlstrom | 9004cb6 | 2013-07-26 15:48:31 -0700 | [diff] [blame] | 509 | CHECK_NE(base_size_, 0U); |
Hiroshi Yamauchi | 3eed93d | 2014-06-04 11:43:59 -0700 | [diff] [blame] | 510 | |
| 511 | // Add it to maps_. |
| 512 | MutexLock mu(Thread::Current(), *Locks::mem_maps_lock_); |
Mathieu Chartier | 6e88ef6 | 2014-10-14 15:01:24 -0700 | [diff] [blame] | 513 | DCHECK(maps_ != nullptr); |
| 514 | maps_->insert(std::make_pair(base_begin_, this)); |
Brian Carlstrom | 9004cb6 | 2013-07-26 15:48:31 -0700 | [diff] [blame] | 515 | } |
Andreas Gampe | c8ccf68 | 2014-09-29 20:07:43 -0700 | [diff] [blame] | 516 | } |
Brian Carlstrom | 27ec961 | 2011-09-19 20:20:38 -0700 | [diff] [blame] | 517 | |
Ian Rogers | 1373595 | 2014-10-08 12:43:28 -0700 | [diff] [blame] | 518 | MemMap* MemMap::RemapAtEnd(uint8_t* new_end, const char* tail_name, int tail_prot, |
Nicolas Geoffray | a25dce9 | 2016-01-12 16:41:10 +0000 | [diff] [blame] | 519 | std::string* error_msg, bool use_ashmem) { |
Mathieu Chartier | cc236d7 | 2012-07-20 10:29:05 -0700 | [diff] [blame] | 520 | DCHECK_GE(new_end, Begin()); |
| 521 | DCHECK_LE(new_end, End()); |
Ian Rogers | 1373595 | 2014-10-08 12:43:28 -0700 | [diff] [blame] | 522 | DCHECK_LE(begin_ + size_, reinterpret_cast<uint8_t*>(base_begin_) + base_size_); |
Roland Levillain | 14d9057 | 2015-07-16 10:52:26 +0100 | [diff] [blame] | 523 | DCHECK_ALIGNED(begin_, kPageSize); |
| 524 | DCHECK_ALIGNED(base_begin_, kPageSize); |
| 525 | DCHECK_ALIGNED(reinterpret_cast<uint8_t*>(base_begin_) + base_size_, kPageSize); |
| 526 | DCHECK_ALIGNED(new_end, kPageSize); |
Ian Rogers | 1373595 | 2014-10-08 12:43:28 -0700 | [diff] [blame] | 527 | uint8_t* old_end = begin_ + size_; |
| 528 | uint8_t* old_base_end = reinterpret_cast<uint8_t*>(base_begin_) + base_size_; |
| 529 | uint8_t* new_base_end = new_end; |
Hiroshi Yamauchi | fd7e7f1 | 2013-10-22 14:17:48 -0700 | [diff] [blame] | 530 | DCHECK_LE(new_base_end, old_base_end); |
| 531 | if (new_base_end == old_base_end) { |
Jim_Guo | a62a588 | 2014-04-28 11:11:57 +0800 | [diff] [blame] | 532 | return new MemMap(tail_name, nullptr, 0, nullptr, 0, tail_prot, false); |
Hiroshi Yamauchi | fd7e7f1 | 2013-10-22 14:17:48 -0700 | [diff] [blame] | 533 | } |
Ian Rogers | 1373595 | 2014-10-08 12:43:28 -0700 | [diff] [blame] | 534 | size_ = new_end - reinterpret_cast<uint8_t*>(begin_); |
| 535 | base_size_ = new_base_end - reinterpret_cast<uint8_t*>(base_begin_); |
| 536 | DCHECK_LE(begin_ + size_, reinterpret_cast<uint8_t*>(base_begin_) + base_size_); |
Hiroshi Yamauchi | fd7e7f1 | 2013-10-22 14:17:48 -0700 | [diff] [blame] | 537 | size_t tail_size = old_end - new_end; |
Ian Rogers | 1373595 | 2014-10-08 12:43:28 -0700 | [diff] [blame] | 538 | uint8_t* tail_base_begin = new_base_end; |
Hiroshi Yamauchi | fd7e7f1 | 2013-10-22 14:17:48 -0700 | [diff] [blame] | 539 | size_t tail_base_size = old_base_end - new_base_end; |
| 540 | DCHECK_EQ(tail_base_begin + tail_base_size, old_base_end); |
Roland Levillain | 14d9057 | 2015-07-16 10:52:26 +0100 | [diff] [blame] | 541 | DCHECK_ALIGNED(tail_base_size, kPageSize); |
Hiroshi Yamauchi | fd7e7f1 | 2013-10-22 14:17:48 -0700 | [diff] [blame] | 542 | |
Nicolas Geoffray | a25dce9 | 2016-01-12 16:41:10 +0000 | [diff] [blame] | 543 | int int_fd = -1; |
Hiroshi Yamauchi | fd7e7f1 | 2013-10-22 14:17:48 -0700 | [diff] [blame] | 544 | int flags = MAP_PRIVATE | MAP_ANONYMOUS; |
Nicolas Geoffray | a25dce9 | 2016-01-12 16:41:10 +0000 | [diff] [blame] | 545 | if (use_ashmem) { |
| 546 | // android_os_Debug.cpp read_mapinfo assumes all ashmem regions associated with the VM are |
| 547 | // prefixed "dalvik-". |
| 548 | std::string debug_friendly_name("dalvik-"); |
| 549 | debug_friendly_name += tail_name; |
| 550 | int_fd = ashmem_create_region(debug_friendly_name.c_str(), tail_base_size); |
| 551 | flags = MAP_PRIVATE | MAP_FIXED; |
| 552 | if (int_fd == -1) { |
| 553 | *error_msg = StringPrintf("ashmem_create_region failed for '%s': %s", |
| 554 | tail_name, strerror(errno)); |
| 555 | return nullptr; |
| 556 | } |
| 557 | } |
Andreas Gampe | 43e10b0 | 2016-07-15 17:17:34 -0700 | [diff] [blame] | 558 | File fd(int_fd, /* check_usage */ false); |
Evgenii Stepanov | 1e13374 | 2015-05-20 12:30:59 -0700 | [diff] [blame] | 559 | |
| 560 | MEMORY_TOOL_MAKE_UNDEFINED(tail_base_begin, tail_base_size); |
Hiroshi Yamauchi | fd7e7f1 | 2013-10-22 14:17:48 -0700 | [diff] [blame] | 561 | // Unmap/map the tail region. |
| 562 | int result = munmap(tail_base_begin, tail_base_size); |
| 563 | if (result == -1) { |
Andreas Gampe | a6dfdae | 2015-02-24 15:50:19 -0800 | [diff] [blame] | 564 | PrintFileToLog("/proc/self/maps", LogSeverity::WARNING); |
| 565 | *error_msg = StringPrintf("munmap(%p, %zd) failed for '%s'. See process maps in the log.", |
| 566 | tail_base_begin, tail_base_size, name_.c_str()); |
Hiroshi Yamauchi | fd7e7f1 | 2013-10-22 14:17:48 -0700 | [diff] [blame] | 567 | return nullptr; |
| 568 | } |
| 569 | // Don't cause memory allocation between the munmap and the mmap |
| 570 | // calls. Otherwise, libc (or something else) might take this memory |
| 571 | // region. Note this isn't perfect as there's no way to prevent |
| 572 | // other threads to try to take this memory region here. |
Ian Rogers | 1373595 | 2014-10-08 12:43:28 -0700 | [diff] [blame] | 573 | uint8_t* actual = reinterpret_cast<uint8_t*>(mmap(tail_base_begin, tail_base_size, tail_prot, |
Andreas Gampe | 43e10b0 | 2016-07-15 17:17:34 -0700 | [diff] [blame] | 574 | flags, fd.Fd(), 0)); |
Hiroshi Yamauchi | fd7e7f1 | 2013-10-22 14:17:48 -0700 | [diff] [blame] | 575 | if (actual == MAP_FAILED) { |
Andreas Gampe | a6dfdae | 2015-02-24 15:50:19 -0800 | [diff] [blame] | 576 | PrintFileToLog("/proc/self/maps", LogSeverity::WARNING); |
| 577 | *error_msg = StringPrintf("anonymous mmap(%p, %zd, 0x%x, 0x%x, %d, 0) failed. See process " |
| 578 | "maps in the log.", tail_base_begin, tail_base_size, tail_prot, flags, |
Andreas Gampe | 43e10b0 | 2016-07-15 17:17:34 -0700 | [diff] [blame] | 579 | fd.Fd()); |
Hiroshi Yamauchi | fd7e7f1 | 2013-10-22 14:17:48 -0700 | [diff] [blame] | 580 | return nullptr; |
| 581 | } |
Jim_Guo | a62a588 | 2014-04-28 11:11:57 +0800 | [diff] [blame] | 582 | return new MemMap(tail_name, actual, tail_size, actual, tail_base_size, tail_prot, false); |
Mathieu Chartier | cc236d7 | 2012-07-20 10:29:05 -0700 | [diff] [blame] | 583 | } |
Logan Chien | d88fa26 | 2012-06-06 15:23:32 +0800 | [diff] [blame] | 584 | |
Ian Rogers | c5f1773 | 2014-06-05 20:48:42 -0700 | [diff] [blame] | 585 | void MemMap::MadviseDontNeedAndZero() { |
| 586 | if (base_begin_ != nullptr || base_size_ != 0) { |
| 587 | if (!kMadviseZeroes) { |
| 588 | memset(base_begin_, 0, base_size_); |
| 589 | } |
| 590 | int result = madvise(base_begin_, base_size_, MADV_DONTNEED); |
| 591 | if (result == -1) { |
| 592 | PLOG(WARNING) << "madvise failed"; |
| 593 | } |
| 594 | } |
| 595 | } |
| 596 | |
Vladimir Marko | 9bdf108 | 2016-01-21 12:15:52 +0000 | [diff] [blame] | 597 | bool MemMap::Sync() { |
Hiroshi Yamauchi | 29ab360 | 2016-03-08 15:17:21 -0800 | [diff] [blame] | 598 | bool result; |
| 599 | if (redzone_size_ != 0) { |
| 600 | // To avoid valgrind errors, temporarily lift the lower-end noaccess protection before passing |
| 601 | // it to msync() as it only accepts page-aligned base address, and exclude the higher-end |
| 602 | // noaccess protection from the msync range. b/27552451. |
| 603 | uint8_t* base_begin = reinterpret_cast<uint8_t*>(base_begin_); |
| 604 | MEMORY_TOOL_MAKE_DEFINED(base_begin, begin_ - base_begin); |
| 605 | result = msync(BaseBegin(), End() - base_begin, MS_SYNC) == 0; |
| 606 | MEMORY_TOOL_MAKE_NOACCESS(base_begin, begin_ - base_begin); |
| 607 | } else { |
| 608 | result = msync(BaseBegin(), BaseSize(), MS_SYNC) == 0; |
| 609 | } |
| 610 | return result; |
Vladimir Marko | 9bdf108 | 2016-01-21 12:15:52 +0000 | [diff] [blame] | 611 | } |
| 612 | |
Logan Chien | d88fa26 | 2012-06-06 15:23:32 +0800 | [diff] [blame] | 613 | bool MemMap::Protect(int prot) { |
Hiroshi Yamauchi | 4fb5df8 | 2014-03-13 15:10:27 -0700 | [diff] [blame] | 614 | if (base_begin_ == nullptr && base_size_ == 0) { |
Ian Rogers | 1c849e5 | 2012-06-28 14:00:33 -0700 | [diff] [blame] | 615 | prot_ = prot; |
Logan Chien | d88fa26 | 2012-06-06 15:23:32 +0800 | [diff] [blame] | 616 | return true; |
| 617 | } |
| 618 | |
| 619 | if (mprotect(base_begin_, base_size_, prot) == 0) { |
Ian Rogers | 1c849e5 | 2012-06-28 14:00:33 -0700 | [diff] [blame] | 620 | prot_ = prot; |
Logan Chien | d88fa26 | 2012-06-06 15:23:32 +0800 | [diff] [blame] | 621 | return true; |
| 622 | } |
| 623 | |
Shih-wei Liao | a060ed9 | 2012-06-07 09:25:28 -0700 | [diff] [blame] | 624 | PLOG(ERROR) << "mprotect(" << reinterpret_cast<void*>(base_begin_) << ", " << base_size_ << ", " |
| 625 | << prot << ") failed"; |
Logan Chien | d88fa26 | 2012-06-06 15:23:32 +0800 | [diff] [blame] | 626 | return false; |
| 627 | } |
| 628 | |
Hiroshi Yamauchi | 3eed93d | 2014-06-04 11:43:59 -0700 | [diff] [blame] | 629 | bool MemMap::CheckNoGaps(MemMap* begin_map, MemMap* end_map) { |
| 630 | MutexLock mu(Thread::Current(), *Locks::mem_maps_lock_); |
| 631 | CHECK(begin_map != nullptr); |
| 632 | CHECK(end_map != nullptr); |
| 633 | CHECK(HasMemMap(begin_map)); |
| 634 | CHECK(HasMemMap(end_map)); |
| 635 | CHECK_LE(begin_map->BaseBegin(), end_map->BaseBegin()); |
| 636 | MemMap* map = begin_map; |
| 637 | while (map->BaseBegin() != end_map->BaseBegin()) { |
| 638 | MemMap* next_map = GetLargestMemMapAt(map->BaseEnd()); |
| 639 | if (next_map == nullptr) { |
| 640 | // Found a gap. |
| 641 | return false; |
| 642 | } |
| 643 | map = next_map; |
| 644 | } |
| 645 | return true; |
| 646 | } |
| 647 | |
Vladimir Marko | 17a924a | 2015-05-08 15:17:32 +0100 | [diff] [blame] | 648 | void MemMap::DumpMaps(std::ostream& os, bool terse) { |
Hiroshi Yamauchi | 3eed93d | 2014-06-04 11:43:59 -0700 | [diff] [blame] | 649 | MutexLock mu(Thread::Current(), *Locks::mem_maps_lock_); |
Vladimir Marko | 17a924a | 2015-05-08 15:17:32 +0100 | [diff] [blame] | 650 | DumpMapsLocked(os, terse); |
Hiroshi Yamauchi | 3eed93d | 2014-06-04 11:43:59 -0700 | [diff] [blame] | 651 | } |
| 652 | |
Vladimir Marko | 17a924a | 2015-05-08 15:17:32 +0100 | [diff] [blame] | 653 | void MemMap::DumpMapsLocked(std::ostream& os, bool terse) { |
| 654 | const auto& mem_maps = *maps_; |
| 655 | if (!terse) { |
| 656 | os << mem_maps; |
| 657 | return; |
| 658 | } |
| 659 | |
| 660 | // Terse output example: |
| 661 | // [MemMap: 0x409be000+0x20P~0x11dP+0x20P~0x61cP+0x20P prot=0x3 LinearAlloc] |
| 662 | // [MemMap: 0x451d6000+0x6bP(3) prot=0x3 large object space allocation] |
| 663 | // The details: |
| 664 | // "+0x20P" means 0x20 pages taken by a single mapping, |
| 665 | // "~0x11dP" means a gap of 0x11d pages, |
| 666 | // "+0x6bP(3)" means 3 mappings one after another, together taking 0x6b pages. |
| 667 | os << "MemMap:" << std::endl; |
| 668 | for (auto it = mem_maps.begin(), maps_end = mem_maps.end(); it != maps_end;) { |
| 669 | MemMap* map = it->second; |
| 670 | void* base = it->first; |
| 671 | CHECK_EQ(base, map->BaseBegin()); |
| 672 | os << "[MemMap: " << base; |
| 673 | ++it; |
| 674 | // Merge consecutive maps with the same protect flags and name. |
| 675 | constexpr size_t kMaxGaps = 9; |
| 676 | size_t num_gaps = 0; |
| 677 | size_t num = 1u; |
| 678 | size_t size = map->BaseSize(); |
Roland Levillain | 14d9057 | 2015-07-16 10:52:26 +0100 | [diff] [blame] | 679 | CHECK_ALIGNED(size, kPageSize); |
Vladimir Marko | 17a924a | 2015-05-08 15:17:32 +0100 | [diff] [blame] | 680 | void* end = map->BaseEnd(); |
| 681 | while (it != maps_end && |
| 682 | it->second->GetProtect() == map->GetProtect() && |
| 683 | it->second->GetName() == map->GetName() && |
| 684 | (it->second->BaseBegin() == end || num_gaps < kMaxGaps)) { |
| 685 | if (it->second->BaseBegin() != end) { |
| 686 | ++num_gaps; |
| 687 | os << "+0x" << std::hex << (size / kPageSize) << "P"; |
| 688 | if (num != 1u) { |
| 689 | os << "(" << std::dec << num << ")"; |
| 690 | } |
| 691 | size_t gap = |
| 692 | reinterpret_cast<uintptr_t>(it->second->BaseBegin()) - reinterpret_cast<uintptr_t>(end); |
Roland Levillain | 14d9057 | 2015-07-16 10:52:26 +0100 | [diff] [blame] | 693 | CHECK_ALIGNED(gap, kPageSize); |
Vladimir Marko | 17a924a | 2015-05-08 15:17:32 +0100 | [diff] [blame] | 694 | os << "~0x" << std::hex << (gap / kPageSize) << "P"; |
| 695 | num = 0u; |
| 696 | size = 0u; |
| 697 | } |
Roland Levillain | 14d9057 | 2015-07-16 10:52:26 +0100 | [diff] [blame] | 698 | CHECK_ALIGNED(it->second->BaseSize(), kPageSize); |
Vladimir Marko | 17a924a | 2015-05-08 15:17:32 +0100 | [diff] [blame] | 699 | ++num; |
| 700 | size += it->second->BaseSize(); |
| 701 | end = it->second->BaseEnd(); |
| 702 | ++it; |
| 703 | } |
| 704 | os << "+0x" << std::hex << (size / kPageSize) << "P"; |
| 705 | if (num != 1u) { |
| 706 | os << "(" << std::dec << num << ")"; |
| 707 | } |
| 708 | os << " prot=0x" << std::hex << map->GetProtect() << " " << map->GetName() << "]" << std::endl; |
| 709 | } |
Hiroshi Yamauchi | 3eed93d | 2014-06-04 11:43:59 -0700 | [diff] [blame] | 710 | } |
| 711 | |
| 712 | bool MemMap::HasMemMap(MemMap* map) { |
| 713 | void* base_begin = map->BaseBegin(); |
Mathieu Chartier | 6e88ef6 | 2014-10-14 15:01:24 -0700 | [diff] [blame] | 714 | for (auto it = maps_->lower_bound(base_begin), end = maps_->end(); |
Hiroshi Yamauchi | 3eed93d | 2014-06-04 11:43:59 -0700 | [diff] [blame] | 715 | it != end && it->first == base_begin; ++it) { |
| 716 | if (it->second == map) { |
| 717 | return true; |
| 718 | } |
| 719 | } |
| 720 | return false; |
| 721 | } |
| 722 | |
| 723 | MemMap* MemMap::GetLargestMemMapAt(void* address) { |
| 724 | size_t largest_size = 0; |
| 725 | MemMap* largest_map = nullptr; |
Mathieu Chartier | 6e88ef6 | 2014-10-14 15:01:24 -0700 | [diff] [blame] | 726 | DCHECK(maps_ != nullptr); |
| 727 | for (auto it = maps_->lower_bound(address), end = maps_->end(); |
Hiroshi Yamauchi | 3eed93d | 2014-06-04 11:43:59 -0700 | [diff] [blame] | 728 | it != end && it->first == address; ++it) { |
| 729 | MemMap* map = it->second; |
| 730 | CHECK(map != nullptr); |
| 731 | if (largest_size < map->BaseSize()) { |
| 732 | largest_size = map->BaseSize(); |
| 733 | largest_map = map; |
| 734 | } |
| 735 | } |
| 736 | return largest_map; |
| 737 | } |
| 738 | |
Mathieu Chartier | 6e88ef6 | 2014-10-14 15:01:24 -0700 | [diff] [blame] | 739 | void MemMap::Init() { |
| 740 | MutexLock mu(Thread::Current(), *Locks::mem_maps_lock_); |
| 741 | if (maps_ == nullptr) { |
| 742 | // dex2oat calls MemMap::Init twice since its needed before the runtime is created. |
| 743 | maps_ = new Maps; |
| 744 | } |
| 745 | } |
| 746 | |
| 747 | void MemMap::Shutdown() { |
| 748 | MutexLock mu(Thread::Current(), *Locks::mem_maps_lock_); |
| 749 | delete maps_; |
| 750 | maps_ = nullptr; |
| 751 | } |
| 752 | |
Mathieu Chartier | 379d09f | 2015-01-08 11:28:13 -0800 | [diff] [blame] | 753 | void MemMap::SetSize(size_t new_size) { |
| 754 | if (new_size == base_size_) { |
| 755 | return; |
| 756 | } |
| 757 | CHECK_ALIGNED(new_size, kPageSize); |
| 758 | CHECK_EQ(base_size_, size_) << "Unsupported"; |
| 759 | CHECK_LE(new_size, base_size_); |
Evgenii Stepanov | 1e13374 | 2015-05-20 12:30:59 -0700 | [diff] [blame] | 760 | MEMORY_TOOL_MAKE_UNDEFINED( |
| 761 | reinterpret_cast<void*>(reinterpret_cast<uintptr_t>(BaseBegin()) + |
| 762 | new_size), |
| 763 | base_size_ - new_size); |
Mathieu Chartier | 379d09f | 2015-01-08 11:28:13 -0800 | [diff] [blame] | 764 | CHECK_EQ(munmap(reinterpret_cast<void*>(reinterpret_cast<uintptr_t>(BaseBegin()) + new_size), |
| 765 | base_size_ - new_size), 0) << new_size << " " << base_size_; |
| 766 | base_size_ = new_size; |
| 767 | size_ = new_size; |
| 768 | } |
| 769 | |
Mathieu Chartier | 42bddce | 2015-11-09 15:16:56 -0800 | [diff] [blame] | 770 | void* MemMap::MapInternal(void* addr, |
| 771 | size_t length, |
| 772 | int prot, |
| 773 | int flags, |
| 774 | int fd, |
| 775 | off_t offset, |
| 776 | bool low_4gb) { |
| 777 | #ifdef __LP64__ |
Mathieu Chartier | 42bddce | 2015-11-09 15:16:56 -0800 | [diff] [blame] | 778 | // When requesting low_4g memory and having an expectation, the requested range should fit into |
| 779 | // 4GB. |
| 780 | if (low_4gb && ( |
| 781 | // Start out of bounds. |
| 782 | (reinterpret_cast<uintptr_t>(addr) >> 32) != 0 || |
| 783 | // End out of bounds. For simplicity, this will fail for the last page of memory. |
| 784 | ((reinterpret_cast<uintptr_t>(addr) + length) >> 32) != 0)) { |
| 785 | LOG(ERROR) << "The requested address space (" << addr << ", " |
| 786 | << reinterpret_cast<void*>(reinterpret_cast<uintptr_t>(addr) + length) |
| 787 | << ") cannot fit in low_4gb"; |
| 788 | return MAP_FAILED; |
| 789 | } |
| 790 | #else |
| 791 | UNUSED(low_4gb); |
| 792 | #endif |
| 793 | DCHECK_ALIGNED(length, kPageSize); |
| 794 | if (low_4gb) { |
| 795 | DCHECK_EQ(flags & MAP_FIXED, 0); |
| 796 | } |
| 797 | // TODO: |
| 798 | // A page allocator would be a useful abstraction here, as |
| 799 | // 1) It is doubtful that MAP_32BIT on x86_64 is doing the right job for us |
| 800 | void* actual = MAP_FAILED; |
| 801 | #if USE_ART_LOW_4G_ALLOCATOR |
| 802 | // MAP_32BIT only available on x86_64. |
| 803 | if (low_4gb && addr == nullptr) { |
| 804 | bool first_run = true; |
| 805 | |
| 806 | MutexLock mu(Thread::Current(), *Locks::mem_maps_lock_); |
| 807 | for (uintptr_t ptr = next_mem_pos_; ptr < 4 * GB; ptr += kPageSize) { |
| 808 | // Use maps_ as an optimization to skip over large maps. |
| 809 | // Find the first map which is address > ptr. |
| 810 | auto it = maps_->upper_bound(reinterpret_cast<void*>(ptr)); |
| 811 | if (it != maps_->begin()) { |
| 812 | auto before_it = it; |
| 813 | --before_it; |
| 814 | // Start at the end of the map before the upper bound. |
| 815 | ptr = std::max(ptr, reinterpret_cast<uintptr_t>(before_it->second->BaseEnd())); |
| 816 | CHECK_ALIGNED(ptr, kPageSize); |
| 817 | } |
| 818 | while (it != maps_->end()) { |
| 819 | // How much space do we have until the next map? |
| 820 | size_t delta = reinterpret_cast<uintptr_t>(it->first) - ptr; |
| 821 | // If the space may be sufficient, break out of the loop. |
| 822 | if (delta >= length) { |
| 823 | break; |
| 824 | } |
| 825 | // Otherwise, skip to the end of the map. |
| 826 | ptr = reinterpret_cast<uintptr_t>(it->second->BaseEnd()); |
| 827 | CHECK_ALIGNED(ptr, kPageSize); |
| 828 | ++it; |
| 829 | } |
| 830 | |
| 831 | // Try to see if we get lucky with this address since none of the ART maps overlap. |
| 832 | actual = TryMemMapLow4GB(reinterpret_cast<void*>(ptr), length, prot, flags, fd, offset); |
| 833 | if (actual != MAP_FAILED) { |
| 834 | next_mem_pos_ = reinterpret_cast<uintptr_t>(actual) + length; |
| 835 | return actual; |
| 836 | } |
| 837 | |
| 838 | if (4U * GB - ptr < length) { |
| 839 | // Not enough memory until 4GB. |
| 840 | if (first_run) { |
| 841 | // Try another time from the bottom; |
| 842 | ptr = LOW_MEM_START - kPageSize; |
| 843 | first_run = false; |
| 844 | continue; |
| 845 | } else { |
| 846 | // Second try failed. |
| 847 | break; |
| 848 | } |
| 849 | } |
| 850 | |
| 851 | uintptr_t tail_ptr; |
| 852 | |
| 853 | // Check pages are free. |
| 854 | bool safe = true; |
| 855 | for (tail_ptr = ptr; tail_ptr < ptr + length; tail_ptr += kPageSize) { |
| 856 | if (msync(reinterpret_cast<void*>(tail_ptr), kPageSize, 0) == 0) { |
| 857 | safe = false; |
| 858 | break; |
| 859 | } else { |
| 860 | DCHECK_EQ(errno, ENOMEM); |
| 861 | } |
| 862 | } |
| 863 | |
| 864 | next_mem_pos_ = tail_ptr; // update early, as we break out when we found and mapped a region |
| 865 | |
| 866 | if (safe == true) { |
| 867 | actual = TryMemMapLow4GB(reinterpret_cast<void*>(ptr), length, prot, flags, fd, offset); |
| 868 | if (actual != MAP_FAILED) { |
| 869 | return actual; |
| 870 | } |
| 871 | } else { |
| 872 | // Skip over last page. |
| 873 | ptr = tail_ptr; |
| 874 | } |
| 875 | } |
| 876 | |
| 877 | if (actual == MAP_FAILED) { |
| 878 | LOG(ERROR) << "Could not find contiguous low-memory space."; |
| 879 | errno = ENOMEM; |
| 880 | } |
| 881 | } else { |
| 882 | actual = mmap(addr, length, prot, flags, fd, offset); |
| 883 | } |
| 884 | |
| 885 | #else |
| 886 | #if defined(__LP64__) |
| 887 | if (low_4gb && addr == nullptr) { |
| 888 | flags |= MAP_32BIT; |
| 889 | } |
| 890 | #endif |
| 891 | actual = mmap(addr, length, prot, flags, fd, offset); |
| 892 | #endif |
| 893 | return actual; |
| 894 | } |
| 895 | |
Brian Carlstrom | 0d6adac | 2014-02-05 17:39:16 -0800 | [diff] [blame] | 896 | std::ostream& operator<<(std::ostream& os, const MemMap& mem_map) { |
Hiroshi Yamauchi | 3eed93d | 2014-06-04 11:43:59 -0700 | [diff] [blame] | 897 | os << StringPrintf("[MemMap: %p-%p prot=0x%x %s]", |
| 898 | mem_map.BaseBegin(), mem_map.BaseEnd(), mem_map.GetProtect(), |
| 899 | mem_map.GetName().c_str()); |
Brian Carlstrom | 0d6adac | 2014-02-05 17:39:16 -0800 | [diff] [blame] | 900 | return os; |
| 901 | } |
| 902 | |
Hiroshi Yamauchi | 6edb9ae | 2016-02-08 14:18:21 -0800 | [diff] [blame] | 903 | void MemMap::TryReadable() { |
| 904 | if (base_begin_ == nullptr && base_size_ == 0) { |
| 905 | return; |
| 906 | } |
| 907 | CHECK_NE(prot_ & PROT_READ, 0); |
| 908 | volatile uint8_t* begin = reinterpret_cast<volatile uint8_t*>(base_begin_); |
| 909 | volatile uint8_t* end = begin + base_size_; |
| 910 | DCHECK(IsAligned<kPageSize>(begin)); |
| 911 | DCHECK(IsAligned<kPageSize>(end)); |
| 912 | // Read the first byte of each page. Use volatile to prevent the compiler from optimizing away the |
| 913 | // reads. |
| 914 | for (volatile uint8_t* ptr = begin; ptr < end; ptr += kPageSize) { |
| 915 | // This read could fault if protection wasn't set correctly. |
| 916 | uint8_t value = *ptr; |
| 917 | UNUSED(value); |
| 918 | } |
| 919 | } |
| 920 | |
Brian Carlstrom | 27ec961 | 2011-09-19 20:20:38 -0700 | [diff] [blame] | 921 | } // namespace art |