Elliott Hughes | 8daa092 | 2011-09-11 13:46:25 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2011 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
| 17 | #include "thread_list.h" |
| 18 | |
Elliott Hughes | abbe07d | 2012-06-05 17:42:23 -0700 | [diff] [blame] | 19 | #include <dirent.h> |
| 20 | #include <sys/types.h> |
Elliott Hughes | 038a806 | 2011-09-18 14:12:41 -0700 | [diff] [blame] | 21 | #include <unistd.h> |
| 22 | |
Elliott Hughes | 475fc23 | 2011-10-25 15:00:35 -0700 | [diff] [blame] | 23 | #include "debugger.h" |
Ian Rogers | 66aee5c | 2012-08-15 17:17:47 -0700 | [diff] [blame] | 24 | #include "mutex.h" |
Mathieu Chartier | 7664f5c | 2012-06-08 18:15:32 -0700 | [diff] [blame] | 25 | #include "timing_logger.h" |
Elliott Hughes | abbe07d | 2012-06-05 17:42:23 -0700 | [diff] [blame] | 26 | #include "utils.h" |
Elliott Hughes | 475fc23 | 2011-10-25 15:00:35 -0700 | [diff] [blame] | 27 | |
Elliott Hughes | 8daa092 | 2011-09-11 13:46:25 -0700 | [diff] [blame] | 28 | namespace art { |
| 29 | |
Elliott Hughes | 4dd9b4d | 2011-12-12 18:29:24 -0800 | [diff] [blame] | 30 | ThreadList::ThreadList() |
Elliott Hughes | e52e49b | 2012-04-02 16:05:44 -0700 | [diff] [blame] | 31 | : allocated_ids_lock_("allocated thread ids lock"), |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 32 | suspend_all_count_(0), debug_suspend_all_count_(0), |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 33 | thread_exit_cond_("thread exit condition variable", *Locks::thread_list_lock_) { |
Elliott Hughes | 8daa092 | 2011-09-11 13:46:25 -0700 | [diff] [blame] | 34 | } |
| 35 | |
| 36 | ThreadList::~ThreadList() { |
Elliott Hughes | e52e49b | 2012-04-02 16:05:44 -0700 | [diff] [blame] | 37 | // Detach the current thread if necessary. If we failed to start, there might not be any threads. |
Elliott Hughes | 6a14433 | 2012-04-03 13:07:11 -0700 | [diff] [blame] | 38 | // We need to detach the current thread here in case there's another thread waiting to join with |
| 39 | // us. |
Elliott Hughes | 8daa092 | 2011-09-11 13:46:25 -0700 | [diff] [blame] | 40 | if (Contains(Thread::Current())) { |
| 41 | Runtime::Current()->DetachCurrentThread(); |
| 42 | } |
Elliott Hughes | 6a14433 | 2012-04-03 13:07:11 -0700 | [diff] [blame] | 43 | |
| 44 | WaitForOtherNonDaemonThreadsToExit(); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 45 | // TODO: there's an unaddressed race here where a thread may attach during shutdown, see |
| 46 | // Thread::Init. |
Elliott Hughes | 6a14433 | 2012-04-03 13:07:11 -0700 | [diff] [blame] | 47 | SuspendAllDaemonThreads(); |
Elliott Hughes | 8daa092 | 2011-09-11 13:46:25 -0700 | [diff] [blame] | 48 | } |
| 49 | |
| 50 | bool ThreadList::Contains(Thread* thread) { |
| 51 | return find(list_.begin(), list_.end(), thread) != list_.end(); |
| 52 | } |
| 53 | |
Elliott Hughes | abbe07d | 2012-06-05 17:42:23 -0700 | [diff] [blame] | 54 | bool ThreadList::Contains(pid_t tid) { |
| 55 | for (It it = list_.begin(), end = list_.end(); it != end; ++it) { |
| 56 | if ((*it)->tid_ == tid) { |
| 57 | return true; |
| 58 | } |
| 59 | } |
| 60 | return false; |
| 61 | } |
| 62 | |
Brian Carlstrom | 24a3c2e | 2011-10-17 18:07:52 -0700 | [diff] [blame] | 63 | pid_t ThreadList::GetLockOwner() { |
Ian Rogers | b726dcb | 2012-09-05 08:57:23 -0700 | [diff] [blame] | 64 | return Locks::thread_list_lock_->GetExclusiveOwnerTid(); |
Elliott Hughes | accd83d | 2011-10-17 14:25:58 -0700 | [diff] [blame] | 65 | } |
| 66 | |
Elliott Hughes | c967f78 | 2012-04-16 10:23:15 -0700 | [diff] [blame] | 67 | void ThreadList::DumpForSigQuit(std::ostream& os) { |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 68 | { |
Ian Rogers | 50b35e2 | 2012-10-04 10:09:15 -0700 | [diff] [blame] | 69 | MutexLock mu(Thread::Current(), *Locks::thread_list_lock_); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 70 | DumpLocked(os); |
| 71 | } |
Elliott Hughes | abbe07d | 2012-06-05 17:42:23 -0700 | [diff] [blame] | 72 | DumpUnattachedThreads(os); |
| 73 | } |
| 74 | |
| 75 | static void DumpUnattachedThread(std::ostream& os, pid_t tid) { |
| 76 | Thread::DumpState(os, NULL, tid); |
| 77 | DumpKernelStack(os, tid, " kernel: ", false); |
Brian Carlstrom | ed8b723 | 2012-06-27 17:54:47 -0700 | [diff] [blame] | 78 | // TODO: Reenable this when the native code in system_server can handle it. |
| 79 | // Currently "adb shell kill -3 `pid system_server`" will cause it to exit. |
| 80 | if (false) { |
| 81 | DumpNativeStack(os, tid, " native: ", false); |
| 82 | } |
Elliott Hughes | abbe07d | 2012-06-05 17:42:23 -0700 | [diff] [blame] | 83 | os << "\n"; |
| 84 | } |
| 85 | |
| 86 | void ThreadList::DumpUnattachedThreads(std::ostream& os) { |
| 87 | DIR* d = opendir("/proc/self/task"); |
| 88 | if (!d) { |
| 89 | return; |
| 90 | } |
| 91 | |
Ian Rogers | 50b35e2 | 2012-10-04 10:09:15 -0700 | [diff] [blame] | 92 | Thread* self = Thread::Current(); |
Elliott Hughes | 4696b5b | 2012-10-30 10:35:10 -0700 | [diff] [blame] | 93 | dirent* e; |
| 94 | while ((e = readdir(d)) != NULL) { |
Elliott Hughes | abbe07d | 2012-06-05 17:42:23 -0700 | [diff] [blame] | 95 | char* end; |
Elliott Hughes | 4696b5b | 2012-10-30 10:35:10 -0700 | [diff] [blame] | 96 | pid_t tid = strtol(e->d_name, &end, 10); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 97 | if (!*end) { |
| 98 | bool contains; |
| 99 | { |
Ian Rogers | 50b35e2 | 2012-10-04 10:09:15 -0700 | [diff] [blame] | 100 | MutexLock mu(self, *Locks::thread_list_lock_); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 101 | contains = Contains(tid); |
| 102 | } |
| 103 | if (!contains) { |
| 104 | DumpUnattachedThread(os, tid); |
| 105 | } |
Elliott Hughes | abbe07d | 2012-06-05 17:42:23 -0700 | [diff] [blame] | 106 | } |
| 107 | } |
| 108 | closedir(d); |
Elliott Hughes | ff73806 | 2012-02-03 15:00:42 -0800 | [diff] [blame] | 109 | } |
| 110 | |
| 111 | void ThreadList::DumpLocked(std::ostream& os) { |
Elliott Hughes | 8daa092 | 2011-09-11 13:46:25 -0700 | [diff] [blame] | 112 | os << "DALVIK THREADS (" << list_.size() << "):\n"; |
Elliott Hughes | 8daa092 | 2011-09-11 13:46:25 -0700 | [diff] [blame] | 113 | for (It it = list_.begin(), end = list_.end(); it != end; ++it) { |
| 114 | (*it)->Dump(os); |
| 115 | os << "\n"; |
| 116 | } |
| 117 | } |
| 118 | |
Ian Rogers | 50b35e2 | 2012-10-04 10:09:15 -0700 | [diff] [blame] | 119 | void ThreadList::AssertThreadsAreSuspended(Thread* self, Thread* ignore1, Thread* ignore2) { |
| 120 | MutexLock mu(self, *Locks::thread_list_lock_); |
| 121 | MutexLock mu2(self, *Locks::thread_suspend_count_lock_); |
Elliott Hughes | 8d768a9 | 2011-09-14 16:35:25 -0700 | [diff] [blame] | 122 | for (It it = list_.begin(), end = list_.end(); it != end; ++it) { |
| 123 | Thread* thread = *it; |
Ian Rogers | 01ae580 | 2012-09-28 16:14:01 -0700 | [diff] [blame] | 124 | if (thread != ignore1 || thread == ignore2) { |
| 125 | CHECK(thread->IsSuspended()) |
| 126 | << "\nUnsuspended thread: <<" << *thread << "\n" |
| 127 | << "self: <<" << *Thread::Current(); |
| 128 | } |
Elliott Hughes | 8d768a9 | 2011-09-14 16:35:25 -0700 | [diff] [blame] | 129 | } |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 130 | } |
| 131 | |
Ian Rogers | 66aee5c | 2012-08-15 17:17:47 -0700 | [diff] [blame] | 132 | #if HAVE_TIMED_RWLOCK |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 133 | // Attempt to rectify locks so that we dump thread list with required locks before exiting. |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 134 | static void UnsafeLogFatalForThreadSuspendAllTimeout(Thread* self) NO_THREAD_SAFETY_ANALYSIS { |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 135 | Runtime* runtime = Runtime::Current(); |
| 136 | std::ostringstream ss; |
| 137 | ss << "Thread suspend timeout\n"; |
| 138 | runtime->DumpLockHolders(ss); |
| 139 | ss << "\n"; |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 140 | Locks::mutator_lock_->SharedTryLock(self); |
| 141 | if (!Locks::mutator_lock_->IsSharedHeld(self)) { |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 142 | LOG(WARNING) << "Dumping thread list without holding mutator_lock_"; |
| 143 | } |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 144 | Locks::thread_list_lock_->TryLock(self); |
| 145 | if (!Locks::thread_list_lock_->IsExclusiveHeld(self)) { |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 146 | LOG(WARNING) << "Dumping thread list without holding thread_list_lock_"; |
| 147 | } |
| 148 | runtime->GetThreadList()->DumpLocked(ss); |
| 149 | LOG(FATAL) << ss.str(); |
| 150 | } |
Ian Rogers | 66aee5c | 2012-08-15 17:17:47 -0700 | [diff] [blame] | 151 | #endif |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 152 | |
Mathieu Chartier | 0e4627e | 2012-10-23 16:13:36 -0700 | [diff] [blame] | 153 | size_t ThreadList::RunCheckpoint(Closure* checkpoint_function) { |
Mathieu Chartier | 858f1c5 | 2012-10-17 17:45:55 -0700 | [diff] [blame] | 154 | Thread* self = Thread::Current(); |
| 155 | if (kIsDebugBuild) { |
| 156 | Locks::mutator_lock_->AssertNotHeld(self); |
| 157 | Locks::thread_list_lock_->AssertNotHeld(self); |
| 158 | Locks::thread_suspend_count_lock_->AssertNotHeld(self); |
| 159 | CHECK_NE(self->GetState(), kRunnable); |
| 160 | } |
| 161 | |
| 162 | std::vector<Thread*> suspended_count_modified_threads; |
| 163 | size_t count = 0; |
| 164 | { |
| 165 | // Call a checkpoint function for each thread, threads which are suspend get their checkpoint |
| 166 | // manually called. |
| 167 | MutexLock mu(self, *Locks::thread_list_lock_); |
| 168 | // TODO: C++0x auto. |
| 169 | for (It it = list_.begin(), end = list_.end(); it != end; ++it) { |
| 170 | Thread* thread = *it; |
| 171 | if (thread != self) { |
| 172 | for (;;) { |
| 173 | if (thread->RequestCheckpoint(checkpoint_function)) { |
| 174 | // This thread will run it's checkpoint some time in the near future. |
| 175 | count++; |
| 176 | break; |
| 177 | } else { |
| 178 | // We are probably suspended, try to make sure that we stay suspended. |
| 179 | MutexLock mu2(self, *Locks::thread_suspend_count_lock_); |
| 180 | // The thread switched back to runnable. |
| 181 | if (thread->GetState() == kRunnable) { |
| 182 | continue; |
| 183 | } |
| 184 | thread->ModifySuspendCount(self, +1, false); |
| 185 | suspended_count_modified_threads.push_back(thread); |
| 186 | break; |
| 187 | } |
| 188 | } |
| 189 | } |
| 190 | } |
| 191 | } |
| 192 | |
| 193 | // Run the checkpoint on ourself while we wait for threads to suspend. |
| 194 | checkpoint_function->Run(self); |
| 195 | |
| 196 | // Run the checkpoint on the suspended threads. |
| 197 | for (size_t i = 0; i < suspended_count_modified_threads.size(); ++i) { |
| 198 | Thread* thread = suspended_count_modified_threads[i]; |
| 199 | if (!thread->IsSuspended()) { |
| 200 | // Wait until the thread is suspended. |
| 201 | uint64_t start = NanoTime(); |
| 202 | do { |
| 203 | // Sleep for 100us. |
| 204 | usleep(100); |
| 205 | } while (!thread->IsSuspended()); |
| 206 | uint64_t end = NanoTime(); |
| 207 | // Shouldn't need to wait for longer than 1 millisecond. |
| 208 | const uint64_t threshold = 1; |
| 209 | if (NsToMs(end - start) > threshold) { |
Brian Carlstrom | bcc2926 | 2012-11-02 11:36:03 -0700 | [diff] [blame^] | 210 | LOG(INFO) << "Warning: waited longer than " << threshold << " ms for thread suspend" |
Mathieu Chartier | 858f1c5 | 2012-10-17 17:45:55 -0700 | [diff] [blame] | 211 | << std::endl; |
| 212 | } |
| 213 | } |
| 214 | // We know for sure that the thread is suspended at this point. |
| 215 | thread->RunCheckpointFunction(); |
| 216 | { |
| 217 | MutexLock mu2(self, *Locks::thread_suspend_count_lock_); |
| 218 | thread->ModifySuspendCount(self, -1, false); |
| 219 | } |
| 220 | } |
| 221 | |
| 222 | // Add one for self. |
| 223 | return count + suspended_count_modified_threads.size() + 1; |
| 224 | } |
| 225 | |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 226 | void ThreadList::SuspendAll() { |
| 227 | Thread* self = Thread::Current(); |
| 228 | |
| 229 | VLOG(threads) << *self << " SuspendAll starting..."; |
| 230 | |
| 231 | if (kIsDebugBuild) { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 232 | Locks::mutator_lock_->AssertNotHeld(self); |
| 233 | Locks::thread_list_lock_->AssertNotHeld(self); |
| 234 | Locks::thread_suspend_count_lock_->AssertNotHeld(self); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 235 | CHECK_NE(self->GetState(), kRunnable); |
| 236 | } |
| 237 | { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 238 | MutexLock mu(self, *Locks::thread_list_lock_); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 239 | { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 240 | MutexLock mu2(self, *Locks::thread_suspend_count_lock_); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 241 | // Update global suspend all state for attaching threads. |
| 242 | ++suspend_all_count_; |
| 243 | // Increment everybody's suspend count (except our own). |
| 244 | for (It it = list_.begin(), end = list_.end(); it != end; ++it) { |
| 245 | Thread* thread = *it; |
| 246 | if (thread == self) { |
| 247 | continue; |
| 248 | } |
| 249 | VLOG(threads) << "requesting thread suspend: " << *thread; |
Ian Rogers | 01ae580 | 2012-09-28 16:14:01 -0700 | [diff] [blame] | 250 | thread->ModifySuspendCount(self, +1, false); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 251 | } |
| 252 | } |
| 253 | } |
| 254 | |
Ian Rogers | 66aee5c | 2012-08-15 17:17:47 -0700 | [diff] [blame] | 255 | // Block on the mutator lock until all Runnable threads release their share of access. |
| 256 | #if HAVE_TIMED_RWLOCK |
| 257 | // Timeout if we wait more than 30 seconds. |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 258 | if (UNLIKELY(!Locks::mutator_lock_->ExclusiveLockWithTimeout(self, 30 * 1000, 0))) { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 259 | UnsafeLogFatalForThreadSuspendAllTimeout(self); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 260 | } |
Ian Rogers | 66aee5c | 2012-08-15 17:17:47 -0700 | [diff] [blame] | 261 | #else |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 262 | Locks::mutator_lock_->ExclusiveLock(self); |
Ian Rogers | 66aee5c | 2012-08-15 17:17:47 -0700 | [diff] [blame] | 263 | #endif |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 264 | |
| 265 | // Debug check that all threads are suspended. |
Ian Rogers | 50b35e2 | 2012-10-04 10:09:15 -0700 | [diff] [blame] | 266 | AssertThreadsAreSuspended(self, self); |
Elliott Hughes | 8d768a9 | 2011-09-14 16:35:25 -0700 | [diff] [blame] | 267 | |
Elliott Hughes | 4dd9b4d | 2011-12-12 18:29:24 -0800 | [diff] [blame] | 268 | VLOG(threads) << *self << " SuspendAll complete"; |
Elliott Hughes | 8d768a9 | 2011-09-14 16:35:25 -0700 | [diff] [blame] | 269 | } |
| 270 | |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 271 | void ThreadList::ResumeAll() { |
| 272 | Thread* self = Thread::Current(); |
| 273 | |
| 274 | VLOG(threads) << *self << " ResumeAll starting"; |
Ian Rogers | 01ae580 | 2012-09-28 16:14:01 -0700 | [diff] [blame] | 275 | |
| 276 | // Debug check that all threads are suspended. |
Ian Rogers | 50b35e2 | 2012-10-04 10:09:15 -0700 | [diff] [blame] | 277 | AssertThreadsAreSuspended(self, self); |
Ian Rogers | 01ae580 | 2012-09-28 16:14:01 -0700 | [diff] [blame] | 278 | |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 279 | Locks::mutator_lock_->ExclusiveUnlock(self); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 280 | { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 281 | MutexLock mu(self, *Locks::thread_list_lock_); |
| 282 | MutexLock mu2(self, *Locks::thread_suspend_count_lock_); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 283 | // Update global suspend all state for attaching threads. |
| 284 | --suspend_all_count_; |
| 285 | // Decrement the suspend counts for all threads. |
| 286 | for (It it = list_.begin(), end = list_.end(); it != end; ++it) { |
| 287 | Thread* thread = *it; |
| 288 | if (thread == self) { |
| 289 | continue; |
| 290 | } |
Ian Rogers | 01ae580 | 2012-09-28 16:14:01 -0700 | [diff] [blame] | 291 | thread->ModifySuspendCount(self, -1, false); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 292 | } |
| 293 | |
| 294 | // Broadcast a notification to all suspended threads, some or all of |
| 295 | // which may choose to wake up. No need to wait for them. |
| 296 | VLOG(threads) << *self << " ResumeAll waking others"; |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 297 | Thread::resume_cond_->Broadcast(self); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 298 | } |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 299 | VLOG(threads) << *self << " ResumeAll complete"; |
| 300 | } |
| 301 | |
| 302 | void ThreadList::Resume(Thread* thread, bool for_debugger) { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 303 | Thread* self = Thread::Current(); |
| 304 | DCHECK_NE(thread, self); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 305 | VLOG(threads) << "Resume(" << *thread << ") starting..." << (for_debugger ? " (debugger)" : ""); |
Elliott Hughes | 01158d7 | 2011-09-19 19:47:10 -0700 | [diff] [blame] | 306 | |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 307 | { |
| 308 | // To check Contains. |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 309 | MutexLock mu(self, *Locks::thread_list_lock_); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 310 | // To check IsSuspended. |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 311 | MutexLock mu2(self, *Locks::thread_suspend_count_lock_); |
| 312 | DCHECK(thread->IsSuspended()); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 313 | if (!Contains(thread)) { |
| 314 | return; |
| 315 | } |
Ian Rogers | 01ae580 | 2012-09-28 16:14:01 -0700 | [diff] [blame] | 316 | thread->ModifySuspendCount(self, -1, for_debugger); |
Elliott Hughes | 01158d7 | 2011-09-19 19:47:10 -0700 | [diff] [blame] | 317 | } |
| 318 | |
| 319 | { |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 320 | VLOG(threads) << "Resume(" << *thread << ") waking others"; |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 321 | MutexLock mu(self, *Locks::thread_suspend_count_lock_); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 322 | Thread::resume_cond_->Broadcast(self); |
Elliott Hughes | 01158d7 | 2011-09-19 19:47:10 -0700 | [diff] [blame] | 323 | } |
| 324 | |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 325 | VLOG(threads) << "Resume(" << *thread << ") complete"; |
| 326 | } |
Elliott Hughes | 01158d7 | 2011-09-19 19:47:10 -0700 | [diff] [blame] | 327 | |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 328 | void ThreadList::SuspendAllForDebugger() { |
| 329 | Thread* self = Thread::Current(); |
| 330 | Thread* debug_thread = Dbg::GetDebugThread(); |
| 331 | |
| 332 | VLOG(threads) << *self << " SuspendAllForDebugger starting..."; |
| 333 | |
| 334 | { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 335 | MutexLock mu(self, *Locks::thread_list_lock_); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 336 | { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 337 | MutexLock mu(self, *Locks::thread_suspend_count_lock_); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 338 | // Update global suspend all state for attaching threads. |
| 339 | ++suspend_all_count_; |
| 340 | ++debug_suspend_all_count_; |
| 341 | // Increment everybody's suspend count (except our own). |
| 342 | for (It it = list_.begin(), end = list_.end(); it != end; ++it) { |
| 343 | Thread* thread = *it; |
| 344 | if (thread == self || thread == debug_thread) { |
| 345 | continue; |
| 346 | } |
| 347 | VLOG(threads) << "requesting thread suspend: " << *thread; |
Ian Rogers | 01ae580 | 2012-09-28 16:14:01 -0700 | [diff] [blame] | 348 | thread->ModifySuspendCount(self, +1, true); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 349 | } |
| 350 | } |
| 351 | } |
| 352 | |
Ian Rogers | 66aee5c | 2012-08-15 17:17:47 -0700 | [diff] [blame] | 353 | // Block on the mutator lock until all Runnable threads release their share of access then |
| 354 | // immediately unlock again. |
| 355 | #if HAVE_TIMED_RWLOCK |
| 356 | // Timeout if we wait more than 30 seconds. |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 357 | if (!Locks::mutator_lock_->ExclusiveLockWithTimeout(self, 30 * 1000, 0)) { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 358 | UnsafeLogFatalForThreadSuspendAllTimeout(self); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 359 | } else { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 360 | Locks::mutator_lock_->ExclusiveUnlock(self); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 361 | } |
Ian Rogers | 66aee5c | 2012-08-15 17:17:47 -0700 | [diff] [blame] | 362 | #else |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 363 | Locks::mutator_lock_->ExclusiveLock(self); |
| 364 | Locks::mutator_lock_->ExclusiveUnlock(self); |
Ian Rogers | 66aee5c | 2012-08-15 17:17:47 -0700 | [diff] [blame] | 365 | #endif |
Ian Rogers | 50b35e2 | 2012-10-04 10:09:15 -0700 | [diff] [blame] | 366 | AssertThreadsAreSuspended(self, self, debug_thread); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 367 | |
| 368 | VLOG(threads) << *self << " SuspendAll complete"; |
Elliott Hughes | 01158d7 | 2011-09-19 19:47:10 -0700 | [diff] [blame] | 369 | } |
| 370 | |
Elliott Hughes | 475fc23 | 2011-10-25 15:00:35 -0700 | [diff] [blame] | 371 | void ThreadList::SuspendSelfForDebugger() { |
| 372 | Thread* self = Thread::Current(); |
Elliott Hughes | 01158d7 | 2011-09-19 19:47:10 -0700 | [diff] [blame] | 373 | |
Elliott Hughes | 475fc23 | 2011-10-25 15:00:35 -0700 | [diff] [blame] | 374 | // The debugger thread must not suspend itself due to debugger activity! |
| 375 | Thread* debug_thread = Dbg::GetDebugThread(); |
| 376 | CHECK(debug_thread != NULL); |
| 377 | CHECK(self != debug_thread); |
| 378 | |
| 379 | // Collisions with other suspends aren't really interesting. We want |
| 380 | // to ensure that we're the only one fiddling with the suspend count |
| 381 | // though. |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 382 | MutexLock mu(self, *Locks::thread_suspend_count_lock_); |
Ian Rogers | 01ae580 | 2012-09-28 16:14:01 -0700 | [diff] [blame] | 383 | self->ModifySuspendCount(self, +1, true); |
Elliott Hughes | 475fc23 | 2011-10-25 15:00:35 -0700 | [diff] [blame] | 384 | |
| 385 | // Suspend ourselves. |
| 386 | CHECK_GT(self->suspend_count_, 0); |
Elliott Hughes | 34e0696 | 2012-04-09 13:55:55 -0700 | [diff] [blame] | 387 | self->SetState(kSuspended); |
Elliott Hughes | 1f729aa | 2012-03-02 13:55:41 -0800 | [diff] [blame] | 388 | VLOG(threads) << *self << " self-suspending (debugger)"; |
Elliott Hughes | 475fc23 | 2011-10-25 15:00:35 -0700 | [diff] [blame] | 389 | |
| 390 | // Tell JDWP that we've completed suspension. The JDWP thread can't |
| 391 | // tell us to resume before we're fully asleep because we hold the |
| 392 | // suspend count lock. |
| 393 | Dbg::ClearWaitForEventThread(); |
| 394 | |
| 395 | while (self->suspend_count_ != 0) { |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 396 | Thread::resume_cond_->Wait(self); |
Elliott Hughes | 475fc23 | 2011-10-25 15:00:35 -0700 | [diff] [blame] | 397 | if (self->suspend_count_ != 0) { |
| 398 | // The condition was signaled but we're still suspended. This |
| 399 | // can happen if the debugger lets go while a SIGQUIT thread |
| 400 | // dump event is pending (assuming SignalCatcher was resumed for |
| 401 | // just long enough to try to grab the thread-suspend lock). |
| 402 | LOG(DEBUG) << *self << " still suspended after undo " |
| 403 | << "(suspend count=" << self->suspend_count_ << ")"; |
| 404 | } |
| 405 | } |
| 406 | CHECK_EQ(self->suspend_count_, 0); |
Elliott Hughes | 34e0696 | 2012-04-09 13:55:55 -0700 | [diff] [blame] | 407 | self->SetState(kRunnable); |
Elliott Hughes | 1f729aa | 2012-03-02 13:55:41 -0800 | [diff] [blame] | 408 | VLOG(threads) << *self << " self-reviving (debugger)"; |
Elliott Hughes | 475fc23 | 2011-10-25 15:00:35 -0700 | [diff] [blame] | 409 | } |
| 410 | |
Elliott Hughes | 234ab15 | 2011-10-26 14:02:26 -0700 | [diff] [blame] | 411 | void ThreadList::UndoDebuggerSuspensions() { |
| 412 | Thread* self = Thread::Current(); |
| 413 | |
Elliott Hughes | 4dd9b4d | 2011-12-12 18:29:24 -0800 | [diff] [blame] | 414 | VLOG(threads) << *self << " UndoDebuggerSuspensions starting"; |
Elliott Hughes | 234ab15 | 2011-10-26 14:02:26 -0700 | [diff] [blame] | 415 | |
| 416 | { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 417 | MutexLock mu(self, *Locks::thread_list_lock_); |
| 418 | MutexLock mu2(self, *Locks::thread_suspend_count_lock_); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 419 | // Update global suspend all state for attaching threads. |
| 420 | suspend_all_count_ -= debug_suspend_all_count_; |
| 421 | debug_suspend_all_count_ = 0; |
| 422 | // Update running threads. |
Elliott Hughes | 234ab15 | 2011-10-26 14:02:26 -0700 | [diff] [blame] | 423 | for (It it = list_.begin(), end = list_.end(); it != end; ++it) { |
| 424 | Thread* thread = *it; |
| 425 | if (thread == self || thread->debug_suspend_count_ == 0) { |
| 426 | continue; |
| 427 | } |
Ian Rogers | 01ae580 | 2012-09-28 16:14:01 -0700 | [diff] [blame] | 428 | thread->ModifySuspendCount(self, -thread->debug_suspend_count_, true); |
Elliott Hughes | 234ab15 | 2011-10-26 14:02:26 -0700 | [diff] [blame] | 429 | } |
| 430 | } |
| 431 | |
| 432 | { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 433 | MutexLock mu(self, *Locks::thread_suspend_count_lock_); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 434 | Thread::resume_cond_->Broadcast(self); |
Elliott Hughes | 234ab15 | 2011-10-26 14:02:26 -0700 | [diff] [blame] | 435 | } |
| 436 | |
Elliott Hughes | 4dd9b4d | 2011-12-12 18:29:24 -0800 | [diff] [blame] | 437 | VLOG(threads) << "UndoDebuggerSuspensions(" << *self << ") complete"; |
Elliott Hughes | 234ab15 | 2011-10-26 14:02:26 -0700 | [diff] [blame] | 438 | } |
| 439 | |
Elliott Hughes | e52e49b | 2012-04-02 16:05:44 -0700 | [diff] [blame] | 440 | void ThreadList::WaitForOtherNonDaemonThreadsToExit() { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 441 | Thread* self = Thread::Current(); |
| 442 | Locks::mutator_lock_->AssertNotHeld(self); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 443 | bool all_threads_are_daemons; |
| 444 | do { |
Ian Rogers | 120f1c7 | 2012-09-28 17:17:10 -0700 | [diff] [blame] | 445 | { |
| 446 | // No more threads can be born after we start to shutdown. |
| 447 | MutexLock mu(self, *Locks::runtime_shutdown_lock_); |
| 448 | CHECK(Runtime::Current()->IsShuttingDown()); |
| 449 | CHECK_EQ(Runtime::Current()->NumberOfThreadsBeingBorn(), 0U); |
| 450 | } |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 451 | all_threads_are_daemons = true; |
Ian Rogers | 120f1c7 | 2012-09-28 17:17:10 -0700 | [diff] [blame] | 452 | MutexLock mu(self, *Locks::thread_list_lock_); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 453 | for (It it = list_.begin(), end = list_.end(); it != end; ++it) { |
| 454 | // TODO: there's a race here with thread exit that's being worked around by checking if the |
| 455 | // thread has a peer. |
| 456 | Thread* thread = *it; |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 457 | if (thread != self && thread->HasPeer() && !thread->IsDaemon()) { |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 458 | all_threads_are_daemons = false; |
| 459 | break; |
| 460 | } |
| 461 | } |
| 462 | if (!all_threads_are_daemons) { |
| 463 | // Wait for another thread to exit before re-checking. |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 464 | thread_exit_cond_.Wait(self); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 465 | } |
| 466 | } while(!all_threads_are_daemons); |
Elliott Hughes | 038a806 | 2011-09-18 14:12:41 -0700 | [diff] [blame] | 467 | } |
| 468 | |
| 469 | void ThreadList::SuspendAllDaemonThreads() { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 470 | Thread* self = Thread::Current(); |
| 471 | MutexLock mu(self, *Locks::thread_list_lock_); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 472 | { // Tell all the daemons it's time to suspend. |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 473 | MutexLock mu2(self, *Locks::thread_suspend_count_lock_); |
Elliott Hughes | 038a806 | 2011-09-18 14:12:41 -0700 | [diff] [blame] | 474 | for (It it = list_.begin(), end = list_.end(); it != end; ++it) { |
| 475 | Thread* thread = *it; |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 476 | // This is only run after all non-daemon threads have exited, so the remainder should all be |
| 477 | // daemons. |
Ian Rogers | 7e76286 | 2012-10-22 15:45:08 -0700 | [diff] [blame] | 478 | CHECK(thread->IsDaemon()) << *thread; |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 479 | if (thread != self) { |
Ian Rogers | 01ae580 | 2012-09-28 16:14:01 -0700 | [diff] [blame] | 480 | thread->ModifySuspendCount(self, +1, false); |
Elliott Hughes | e52e49b | 2012-04-02 16:05:44 -0700 | [diff] [blame] | 481 | } |
Elliott Hughes | 038a806 | 2011-09-18 14:12:41 -0700 | [diff] [blame] | 482 | } |
| 483 | } |
Elliott Hughes | 038a806 | 2011-09-18 14:12:41 -0700 | [diff] [blame] | 484 | // Give the threads a chance to suspend, complaining if they're slow. |
| 485 | bool have_complained = false; |
| 486 | for (int i = 0; i < 10; ++i) { |
| 487 | usleep(200 * 1000); |
| 488 | bool all_suspended = true; |
| 489 | for (It it = list_.begin(), end = list_.end(); it != end; ++it) { |
| 490 | Thread* thread = *it; |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 491 | if (thread != self && thread->GetState() == kRunnable) { |
Elliott Hughes | 038a806 | 2011-09-18 14:12:41 -0700 | [diff] [blame] | 492 | if (!have_complained) { |
| 493 | LOG(WARNING) << "daemon thread not yet suspended: " << *thread; |
| 494 | have_complained = true; |
| 495 | } |
| 496 | all_suspended = false; |
| 497 | } |
| 498 | } |
| 499 | if (all_suspended) { |
| 500 | return; |
| 501 | } |
| 502 | } |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 503 | LOG(ERROR) << "suspend all daemons failed"; |
| 504 | } |
| 505 | void ThreadList::Register(Thread* self) { |
| 506 | DCHECK_EQ(self, Thread::Current()); |
| 507 | |
| 508 | if (VLOG_IS_ON(threads)) { |
| 509 | std::ostringstream oss; |
| 510 | self->ShortDump(oss); // We don't hold the mutator_lock_ yet and so cannot call Dump. |
| 511 | LOG(INFO) << "ThreadList::Register() " << *self << "\n" << oss; |
| 512 | } |
| 513 | |
| 514 | // Atomically add self to the thread list and make its thread_suspend_count_ reflect ongoing |
| 515 | // SuspendAll requests. |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 516 | MutexLock mu(self, *Locks::thread_list_lock_); |
| 517 | MutexLock mu2(self, *Locks::thread_suspend_count_lock_); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 518 | self->suspend_count_ = suspend_all_count_; |
| 519 | self->debug_suspend_count_ = debug_suspend_all_count_; |
Ian Rogers | 01ae580 | 2012-09-28 16:14:01 -0700 | [diff] [blame] | 520 | if (self->suspend_count_ > 0) { |
| 521 | self->AtomicSetFlag(kSuspendRequest); |
| 522 | } |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 523 | CHECK(!Contains(self)); |
| 524 | list_.push_back(self); |
| 525 | } |
| 526 | |
| 527 | void ThreadList::Unregister(Thread* self) { |
| 528 | DCHECK_EQ(self, Thread::Current()); |
| 529 | |
| 530 | VLOG(threads) << "ThreadList::Unregister() " << *self; |
| 531 | |
| 532 | // Any time-consuming destruction, plus anything that can call back into managed code or |
| 533 | // suspend and so on, must happen at this point, and not in ~Thread. |
| 534 | self->Destroy(); |
| 535 | |
| 536 | { |
| 537 | // Remove this thread from the list. |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 538 | MutexLock mu(self, *Locks::thread_list_lock_); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 539 | CHECK(Contains(self)); |
| 540 | list_.remove(self); |
| 541 | } |
| 542 | |
| 543 | // Delete the Thread* and release the thin lock id. |
| 544 | uint32_t thin_lock_id = self->thin_lock_id_; |
| 545 | ReleaseThreadId(thin_lock_id); |
| 546 | delete self; |
| 547 | |
| 548 | // Clear the TLS data, so that the underlying native thread is recognizably detached. |
| 549 | // (It may wish to reattach later.) |
| 550 | CHECK_PTHREAD_CALL(pthread_setspecific, (Thread::pthread_key_self_, NULL), "detach self"); |
| 551 | |
| 552 | // Signal that a thread just detached. |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 553 | MutexLock mu(NULL, *Locks::thread_list_lock_); |
Ian Rogers | c604d73 | 2012-10-14 16:09:54 -0700 | [diff] [blame] | 554 | thread_exit_cond_.Signal(NULL); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 555 | } |
| 556 | |
| 557 | void ThreadList::ForEach(void (*callback)(Thread*, void*), void* context) { |
| 558 | for (It it = list_.begin(), end = list_.end(); it != end; ++it) { |
| 559 | callback(*it, context); |
| 560 | } |
| 561 | } |
| 562 | |
| 563 | void ThreadList::VisitRoots(Heap::RootVisitor* visitor, void* arg) const { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 564 | MutexLock mu(Thread::Current(), *Locks::thread_list_lock_); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 565 | for (It it = list_.begin(), end = list_.end(); it != end; ++it) { |
| 566 | (*it)->VisitRoots(visitor, arg); |
| 567 | } |
Elliott Hughes | 038a806 | 2011-09-18 14:12:41 -0700 | [diff] [blame] | 568 | } |
| 569 | |
Mathieu Chartier | 6f1c949 | 2012-10-15 12:08:41 -0700 | [diff] [blame] | 570 | void ThreadList::VerifyRoots(Heap::VerifyRootVisitor* visitor, void* arg) const { |
| 571 | MutexLock mu(Thread::Current(), *Locks::thread_list_lock_); |
| 572 | for (It it = list_.begin(), end = list_.end(); it != end; ++it) { |
| 573 | (*it)->VerifyRoots(visitor, arg); |
| 574 | } |
| 575 | } |
| 576 | |
Elliott Hughes | 8daa092 | 2011-09-11 13:46:25 -0700 | [diff] [blame] | 577 | uint32_t ThreadList::AllocThreadId() { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 578 | MutexLock mu(Thread::Current(), allocated_ids_lock_); |
Elliott Hughes | 8daa092 | 2011-09-11 13:46:25 -0700 | [diff] [blame] | 579 | for (size_t i = 0; i < allocated_ids_.size(); ++i) { |
| 580 | if (!allocated_ids_[i]) { |
| 581 | allocated_ids_.set(i); |
| 582 | return i + 1; // Zero is reserved to mean "invalid". |
| 583 | } |
| 584 | } |
| 585 | LOG(FATAL) << "Out of internal thread ids"; |
| 586 | return 0; |
| 587 | } |
| 588 | |
| 589 | void ThreadList::ReleaseThreadId(uint32_t id) { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 590 | MutexLock mu(Thread::Current(), allocated_ids_lock_); |
Elliott Hughes | 8daa092 | 2011-09-11 13:46:25 -0700 | [diff] [blame] | 591 | --id; // Zero is reserved to mean "invalid". |
| 592 | DCHECK(allocated_ids_[id]) << id; |
| 593 | allocated_ids_.reset(id); |
| 594 | } |
| 595 | |
| 596 | } // namespace art |