blob: da5a938fd3c9a59cdaebb08b09fa0fceb0790daf [file] [log] [blame]
Elliott Hughes08b82a92012-04-05 12:13:56 -07001#!/usr/bin/python
Brian Carlstrom59848da2011-07-23 20:35:19 -07002#
3# Copyright (c) 2009 Google Inc. All rights reserved.
4#
5# Redistribution and use in source and binary forms, with or without
6# modification, are permitted provided that the following conditions are
7# met:
8#
9# * Redistributions of source code must retain the above copyright
10# notice, this list of conditions and the following disclaimer.
11# * Redistributions in binary form must reproduce the above
12# copyright notice, this list of conditions and the following disclaimer
13# in the documentation and/or other materials provided with the
14# distribution.
15# * Neither the name of Google Inc. nor the names of its
16# contributors may be used to endorse or promote products derived from
17# this software without specific prior written permission.
18#
19# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
20# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
21# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
22# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
23# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
24# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
25# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
26# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
27# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
28# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
29# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
30
31# Here are some issues that I've had people identify in my code during reviews,
32# that I think are possible to flag automatically in a lint tool. If these were
33# caught by lint, it would save time both for myself and that of my reviewers.
34# Most likely, some of these are beyond the scope of the current lint framework,
35# but I think it is valuable to retain these wish-list items even if they cannot
36# be immediately implemented.
37#
38# Suggestions
39# -----------
40# - Check for no 'explicit' for multi-arg ctor
41# - Check for boolean assign RHS in parens
42# - Check for ctor initializer-list colon position and spacing
43# - Check that if there's a ctor, there should be a dtor
44# - Check accessors that return non-pointer member variables are
45# declared const
46# - Check accessors that return non-const pointer member vars are
47# *not* declared const
48# - Check for using public includes for testing
49# - Check for spaces between brackets in one-line inline method
50# - Check for no assert()
51# - Check for spaces surrounding operators
52# - Check for 0 in pointer context (should be NULL)
53# - Check for 0 in char context (should be '\0')
54# - Check for camel-case method name conventions for methods
55# that are not simple inline getters and setters
56# - Check that base classes have virtual destructors
57# put " // namespace" after } that closes a namespace, with
58# namespace's name after 'namespace' if it is named.
59# - Do not indent namespace contents
60# - Avoid inlining non-trivial constructors in header files
61# include base/basictypes.h if DISALLOW_EVIL_CONSTRUCTORS is used
62# - Check for old-school (void) cast for call-sites of functions
63# ignored return value
64# - Check gUnit usage of anonymous namespace
65# - Check for class declaration order (typedefs, consts, enums,
66# ctor(s?), dtor, friend declarations, methods, member vars)
67#
68
69"""Does google-lint on c++ files.
70
71The goal of this script is to identify places in the code that *may*
72be in non-compliance with google style. It does not attempt to fix
73up these problems -- the point is to educate. It does also not
74attempt to find all problems, or to ensure that everything it does
75find is legitimately a problem.
76
77In particular, we can get very confused by /* and // inside strings!
78We do a small hack, which is to ignore //'s with "'s after them on the
79same line, but it is far from perfect (in either direction).
80"""
81
82import codecs
83import getopt
84import math # for log
85import os
86import re
87import sre_compile
88import string
89import sys
90import unicodedata
91
92
93_USAGE = """
94Syntax: cpplint.py [--verbose=#] [--output=vs7] [--filter=-x,+y,...]
95 [--counting=total|toplevel|detailed]
96 <file> [file] ...
97
98 The style guidelines this tries to follow are those in
99 http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml
100
101 Every problem is given a confidence score from 1-5, with 5 meaning we are
102 certain of the problem, and 1 meaning it could be a legitimate construct.
103 This will miss some errors, and is not a substitute for a code review.
104
105 To suppress false-positive errors of a certain category, add a
106 'NOLINT(category)' comment to the line. NOLINT or NOLINT(*)
107 suppresses errors of all categories on that line.
108
109 The files passed in will be linted; at least one file must be provided.
110 Linted extensions are .cc, .cpp, and .h. Other file types will be ignored.
111
112 Flags:
113
114 output=vs7
115 By default, the output is formatted to ease emacs parsing. Visual Studio
116 compatible output (vs7) may also be used. Other formats are unsupported.
117
118 verbose=#
119 Specify a number 0-5 to restrict errors to certain verbosity levels.
120
121 filter=-x,+y,...
122 Specify a comma-separated list of category-filters to apply: only
123 error messages whose category names pass the filters will be printed.
124 (Category names are printed with the message and look like
125 "[whitespace/indent]".) Filters are evaluated left to right.
126 "-FOO" and "FOO" means "do not print categories that start with FOO".
127 "+FOO" means "do print categories that start with FOO".
128
129 Examples: --filter=-whitespace,+whitespace/braces
130 --filter=whitespace,runtime/printf,+runtime/printf_format
131 --filter=-,+build/include_what_you_use
132
133 To see a list of all the categories used in cpplint, pass no arg:
134 --filter=
135
136 counting=total|toplevel|detailed
137 The total number of errors found is always printed. If
138 'toplevel' is provided, then the count of errors in each of
139 the top-level categories like 'build' and 'whitespace' will
140 also be printed. If 'detailed' is provided, then a count
141 is provided for each category like 'build/class'.
142"""
143
144# We categorize each error message we print. Here are the categories.
145# We want an explicit list so we can list them all in cpplint --filter=.
146# If you add a new error message with a new category, add it to the list
147# here! cpplint_unittest.py should tell you if you forget to do this.
148# \ used for clearer layout -- pylint: disable-msg=C6013
149_ERROR_CATEGORIES = [
150 'build/class',
151 'build/deprecated',
152 'build/endif_comment',
Elliott Hughesdb385702012-06-21 10:41:20 -0700153 'build/explicit_make_pair',
Brian Carlstrom59848da2011-07-23 20:35:19 -0700154 'build/forward_decl',
155 'build/header_guard',
156 'build/include',
157 'build/include_alpha',
158 'build/include_order',
159 'build/include_what_you_use',
160 'build/namespaces',
161 'build/printf_format',
162 'build/storage_class',
163 'legal/copyright',
164 'readability/braces',
165 'readability/casting',
166 'readability/check',
167 'readability/constructors',
168 'readability/fn_size',
169 'readability/function',
170 'readability/multiline_comment',
171 'readability/multiline_string',
172 'readability/nolint',
173 'readability/streams',
174 'readability/todo',
175 'readability/utf8',
176 'runtime/arrays',
177 'runtime/casting',
178 'runtime/explicit',
179 'runtime/int',
180 'runtime/init',
181 'runtime/invalid_increment',
182 'runtime/member_string_references',
183 'runtime/memset',
184 'runtime/operator',
185 'runtime/printf',
186 'runtime/printf_format',
187 'runtime/references',
188 'runtime/rtti',
189 'runtime/sizeof',
190 'runtime/string',
191 'runtime/threadsafe_fn',
192 'runtime/virtual',
193 'whitespace/blank_line',
194 'whitespace/braces',
195 'whitespace/comma',
196 'whitespace/comments',
197 'whitespace/end_of_line',
198 'whitespace/ending_newline',
199 'whitespace/indent',
200 'whitespace/labels',
201 'whitespace/line_length',
202 'whitespace/newline',
203 'whitespace/operators',
204 'whitespace/parens',
205 'whitespace/semicolon',
206 'whitespace/tab',
207 'whitespace/todo'
208 ]
209
210# The default state of the category filter. This is overrided by the --filter=
211# flag. By default all errors are on, so only add here categories that should be
212# off by default (i.e., categories that must be enabled by the --filter= flags).
213# All entries here should start with a '-' or '+', as in the --filter= flag.
Elliott Hughesdb385702012-06-21 10:41:20 -0700214_DEFAULT_FILTERS = ['-build/include_alpha']
Brian Carlstrom59848da2011-07-23 20:35:19 -0700215
216# We used to check for high-bit characters, but after much discussion we
217# decided those were OK, as long as they were in UTF-8 and didn't represent
Elliott Hughesdb385702012-06-21 10:41:20 -0700218# hard-coded international strings, which belong in a separate i18n file.
Brian Carlstrom59848da2011-07-23 20:35:19 -0700219
220# Headers that we consider STL headers.
221_STL_HEADERS = frozenset([
222 'algobase.h', 'algorithm', 'alloc.h', 'bitset', 'deque', 'exception',
223 'function.h', 'functional', 'hash_map', 'hash_map.h', 'hash_set',
224 'hash_set.h', 'iterator', 'list', 'list.h', 'map', 'memory', 'new',
225 'pair.h', 'pthread_alloc', 'queue', 'set', 'set.h', 'sstream', 'stack',
226 'stl_alloc.h', 'stl_relops.h', 'type_traits.h',
227 'utility', 'vector', 'vector.h',
228 ])
229
230
231# Non-STL C++ system headers.
232_CPP_HEADERS = frozenset([
233 'algo.h', 'builtinbuf.h', 'bvector.h', 'cassert', 'cctype',
234 'cerrno', 'cfloat', 'ciso646', 'climits', 'clocale', 'cmath',
235 'complex', 'complex.h', 'csetjmp', 'csignal', 'cstdarg', 'cstddef',
236 'cstdio', 'cstdlib', 'cstring', 'ctime', 'cwchar', 'cwctype',
237 'defalloc.h', 'deque.h', 'editbuf.h', 'exception', 'fstream',
238 'fstream.h', 'hashtable.h', 'heap.h', 'indstream.h', 'iomanip',
Elliott Hughesdb385702012-06-21 10:41:20 -0700239 'iomanip.h', 'ios', 'iosfwd', 'iostream', 'iostream.h', 'istream',
240 'istream.h', 'iterator.h', 'limits', 'map.h', 'multimap.h', 'multiset.h',
241 'numeric', 'ostream', 'ostream.h', 'parsestream.h', 'pfstream.h',
242 'PlotFile.h', 'procbuf.h', 'pthread_alloc.h', 'rope', 'rope.h',
243 'ropeimpl.h', 'SFile.h', 'slist', 'slist.h', 'stack.h', 'stdexcept',
Brian Carlstrom59848da2011-07-23 20:35:19 -0700244 'stdiostream.h', 'streambuf.h', 'stream.h', 'strfile.h', 'string',
245 'strstream', 'strstream.h', 'tempbuf.h', 'tree.h', 'typeinfo', 'valarray',
246 ])
247
248
249# Assertion macros. These are defined in base/logging.h and
250# testing/base/gunit.h. Note that the _M versions need to come first
251# for substring matching to work.
252_CHECK_MACROS = [
253 'DCHECK', 'CHECK',
254 'EXPECT_TRUE_M', 'EXPECT_TRUE',
255 'ASSERT_TRUE_M', 'ASSERT_TRUE',
256 'EXPECT_FALSE_M', 'EXPECT_FALSE',
257 'ASSERT_FALSE_M', 'ASSERT_FALSE',
258 ]
259
260# Replacement macros for CHECK/DCHECK/EXPECT_TRUE/EXPECT_FALSE
261_CHECK_REPLACEMENT = dict([(m, {}) for m in _CHECK_MACROS])
262
263for op, replacement in [('==', 'EQ'), ('!=', 'NE'),
264 ('>=', 'GE'), ('>', 'GT'),
265 ('<=', 'LE'), ('<', 'LT')]:
266 _CHECK_REPLACEMENT['DCHECK'][op] = 'DCHECK_%s' % replacement
267 _CHECK_REPLACEMENT['CHECK'][op] = 'CHECK_%s' % replacement
268 _CHECK_REPLACEMENT['EXPECT_TRUE'][op] = 'EXPECT_%s' % replacement
269 _CHECK_REPLACEMENT['ASSERT_TRUE'][op] = 'ASSERT_%s' % replacement
270 _CHECK_REPLACEMENT['EXPECT_TRUE_M'][op] = 'EXPECT_%s_M' % replacement
271 _CHECK_REPLACEMENT['ASSERT_TRUE_M'][op] = 'ASSERT_%s_M' % replacement
272
273for op, inv_replacement in [('==', 'NE'), ('!=', 'EQ'),
274 ('>=', 'LT'), ('>', 'LE'),
275 ('<=', 'GT'), ('<', 'GE')]:
276 _CHECK_REPLACEMENT['EXPECT_FALSE'][op] = 'EXPECT_%s' % inv_replacement
277 _CHECK_REPLACEMENT['ASSERT_FALSE'][op] = 'ASSERT_%s' % inv_replacement
278 _CHECK_REPLACEMENT['EXPECT_FALSE_M'][op] = 'EXPECT_%s_M' % inv_replacement
279 _CHECK_REPLACEMENT['ASSERT_FALSE_M'][op] = 'ASSERT_%s_M' % inv_replacement
280
281
282# These constants define types of headers for use with
283# _IncludeState.CheckNextIncludeOrder().
284_C_SYS_HEADER = 1
285_CPP_SYS_HEADER = 2
286_LIKELY_MY_HEADER = 3
287_POSSIBLE_MY_HEADER = 4
288_OTHER_HEADER = 5
289
290
291_regexp_compile_cache = {}
292
293# Finds occurrences of NOLINT or NOLINT(...).
294_RE_SUPPRESSION = re.compile(r'\bNOLINT\b(\([^)]*\))?')
295
296# {str, set(int)}: a map from error categories to sets of linenumbers
297# on which those errors are expected and should be suppressed.
298_error_suppressions = {}
299
300def ParseNolintSuppressions(filename, raw_line, linenum, error):
301 """Updates the global list of error-suppressions.
302
303 Parses any NOLINT comments on the current line, updating the global
304 error_suppressions store. Reports an error if the NOLINT comment
305 was malformed.
306
307 Args:
308 filename: str, the name of the input file.
309 raw_line: str, the line of input text, with comments.
310 linenum: int, the number of the current line.
311 error: function, an error handler.
312 """
313 # FIXME(adonovan): "NOLINT(" is misparsed as NOLINT(*).
Elliott Hughesdb385702012-06-21 10:41:20 -0700314 matched = _RE_SUPPRESSION.search(raw_line)
315 if matched:
316 category = matched.group(1)
Brian Carlstrom59848da2011-07-23 20:35:19 -0700317 if category in (None, '(*)'): # => "suppress all"
318 _error_suppressions.setdefault(None, set()).add(linenum)
319 else:
320 if category.startswith('(') and category.endswith(')'):
321 category = category[1:-1]
322 if category in _ERROR_CATEGORIES:
323 _error_suppressions.setdefault(category, set()).add(linenum)
324 else:
325 error(filename, linenum, 'readability/nolint', 5,
Elliott Hughesdb385702012-06-21 10:41:20 -0700326 'Unknown NOLINT error category: %s' % category)
Brian Carlstrom59848da2011-07-23 20:35:19 -0700327
328
329def ResetNolintSuppressions():
330 "Resets the set of NOLINT suppressions to empty."
331 _error_suppressions.clear()
332
333
334def IsErrorSuppressedByNolint(category, linenum):
335 """Returns true if the specified error category is suppressed on this line.
336
337 Consults the global error_suppressions map populated by
338 ParseNolintSuppressions/ResetNolintSuppressions.
339
340 Args:
341 category: str, the category of the error.
342 linenum: int, the current line number.
343 Returns:
344 bool, True iff the error should be suppressed due to a NOLINT comment.
345 """
346 return (linenum in _error_suppressions.get(category, set()) or
347 linenum in _error_suppressions.get(None, set()))
348
349def Match(pattern, s):
350 """Matches the string with the pattern, caching the compiled regexp."""
351 # The regexp compilation caching is inlined in both Match and Search for
352 # performance reasons; factoring it out into a separate function turns out
353 # to be noticeably expensive.
354 if not pattern in _regexp_compile_cache:
355 _regexp_compile_cache[pattern] = sre_compile.compile(pattern)
356 return _regexp_compile_cache[pattern].match(s)
357
358
359def Search(pattern, s):
360 """Searches the string for the pattern, caching the compiled regexp."""
361 if not pattern in _regexp_compile_cache:
362 _regexp_compile_cache[pattern] = sre_compile.compile(pattern)
363 return _regexp_compile_cache[pattern].search(s)
364
365
366class _IncludeState(dict):
367 """Tracks line numbers for includes, and the order in which includes appear.
368
369 As a dict, an _IncludeState object serves as a mapping between include
370 filename and line number on which that file was included.
371
372 Call CheckNextIncludeOrder() once for each header in the file, passing
373 in the type constants defined above. Calls in an illegal order will
374 raise an _IncludeError with an appropriate error message.
375
376 """
377 # self._section will move monotonically through this set. If it ever
378 # needs to move backwards, CheckNextIncludeOrder will raise an error.
379 _INITIAL_SECTION = 0
380 _MY_H_SECTION = 1
381 _C_SECTION = 2
382 _CPP_SECTION = 3
383 _OTHER_H_SECTION = 4
384
385 _TYPE_NAMES = {
386 _C_SYS_HEADER: 'C system header',
387 _CPP_SYS_HEADER: 'C++ system header',
388 _LIKELY_MY_HEADER: 'header this file implements',
389 _POSSIBLE_MY_HEADER: 'header this file may implement',
390 _OTHER_HEADER: 'other header',
391 }
392 _SECTION_NAMES = {
393 _INITIAL_SECTION: "... nothing. (This can't be an error.)",
394 _MY_H_SECTION: 'a header this file implements',
395 _C_SECTION: 'C system header',
396 _CPP_SECTION: 'C++ system header',
397 _OTHER_H_SECTION: 'other header',
398 }
399
400 def __init__(self):
401 dict.__init__(self)
402 # The name of the current section.
403 self._section = self._INITIAL_SECTION
404 # The path of last found header.
405 self._last_header = ''
406
407 def CanonicalizeAlphabeticalOrder(self, header_path):
Elliott Hughesdb385702012-06-21 10:41:20 -0700408 """Returns a path canonicalized for alphabetical comparison.
Brian Carlstrom59848da2011-07-23 20:35:19 -0700409
410 - replaces "-" with "_" so they both cmp the same.
411 - removes '-inl' since we don't require them to be after the main header.
412 - lowercase everything, just in case.
413
414 Args:
415 header_path: Path to be canonicalized.
416
417 Returns:
418 Canonicalized path.
419 """
420 return header_path.replace('-inl.h', '.h').replace('-', '_').lower()
421
422 def IsInAlphabeticalOrder(self, header_path):
423 """Check if a header is in alphabetical order with the previous header.
424
425 Args:
426 header_path: Header to be checked.
427
428 Returns:
429 Returns true if the header is in alphabetical order.
430 """
431 canonical_header = self.CanonicalizeAlphabeticalOrder(header_path)
432 if self._last_header > canonical_header:
433 return False
434 self._last_header = canonical_header
435 return True
436
437 def CheckNextIncludeOrder(self, header_type):
438 """Returns a non-empty error message if the next header is out of order.
439
440 This function also updates the internal state to be ready to check
441 the next include.
442
443 Args:
444 header_type: One of the _XXX_HEADER constants defined above.
445
446 Returns:
447 The empty string if the header is in the right order, or an
448 error message describing what's wrong.
449
450 """
451 error_message = ('Found %s after %s' %
452 (self._TYPE_NAMES[header_type],
453 self._SECTION_NAMES[self._section]))
454
455 last_section = self._section
456
457 if header_type == _C_SYS_HEADER:
458 if self._section <= self._C_SECTION:
459 self._section = self._C_SECTION
460 else:
461 self._last_header = ''
462 return error_message
463 elif header_type == _CPP_SYS_HEADER:
464 if self._section <= self._CPP_SECTION:
465 self._section = self._CPP_SECTION
466 else:
467 self._last_header = ''
468 return error_message
469 elif header_type == _LIKELY_MY_HEADER:
470 if self._section <= self._MY_H_SECTION:
471 self._section = self._MY_H_SECTION
472 else:
473 self._section = self._OTHER_H_SECTION
474 elif header_type == _POSSIBLE_MY_HEADER:
475 if self._section <= self._MY_H_SECTION:
476 self._section = self._MY_H_SECTION
477 else:
478 # This will always be the fallback because we're not sure
479 # enough that the header is associated with this file.
480 self._section = self._OTHER_H_SECTION
481 else:
482 assert header_type == _OTHER_HEADER
483 self._section = self._OTHER_H_SECTION
484
485 if last_section != self._section:
486 self._last_header = ''
487
488 return ''
489
490
491class _CppLintState(object):
492 """Maintains module-wide state.."""
493
494 def __init__(self):
495 self.verbose_level = 1 # global setting.
496 self.error_count = 0 # global count of reported errors
497 # filters to apply when emitting error messages
498 self.filters = _DEFAULT_FILTERS[:]
499 self.counting = 'total' # In what way are we counting errors?
500 self.errors_by_category = {} # string to int dict storing error counts
501
502 # output format:
503 # "emacs" - format that emacs can parse (default)
504 # "vs7" - format that Microsoft Visual Studio 7 can parse
505 self.output_format = 'emacs'
506
507 def SetOutputFormat(self, output_format):
508 """Sets the output format for errors."""
509 self.output_format = output_format
510
511 def SetVerboseLevel(self, level):
512 """Sets the module's verbosity, and returns the previous setting."""
513 last_verbose_level = self.verbose_level
514 self.verbose_level = level
515 return last_verbose_level
516
517 def SetCountingStyle(self, counting_style):
518 """Sets the module's counting options."""
519 self.counting = counting_style
520
521 def SetFilters(self, filters):
522 """Sets the error-message filters.
523
524 These filters are applied when deciding whether to emit a given
525 error message.
526
527 Args:
528 filters: A string of comma-separated filters (eg "+whitespace/indent").
529 Each filter should start with + or -; else we die.
530
531 Raises:
532 ValueError: The comma-separated filters did not all start with '+' or '-'.
533 E.g. "-,+whitespace,-whitespace/indent,whitespace/badfilter"
534 """
535 # Default filters always have less priority than the flag ones.
536 self.filters = _DEFAULT_FILTERS[:]
537 for filt in filters.split(','):
538 clean_filt = filt.strip()
539 if clean_filt:
540 self.filters.append(clean_filt)
541 for filt in self.filters:
542 if not (filt.startswith('+') or filt.startswith('-')):
543 raise ValueError('Every filter in --filters must start with + or -'
544 ' (%s does not)' % filt)
545
546 def ResetErrorCounts(self):
547 """Sets the module's error statistic back to zero."""
548 self.error_count = 0
549 self.errors_by_category = {}
550
551 def IncrementErrorCount(self, category):
552 """Bumps the module's error statistic."""
553 self.error_count += 1
554 if self.counting in ('toplevel', 'detailed'):
555 if self.counting != 'detailed':
556 category = category.split('/')[0]
557 if category not in self.errors_by_category:
558 self.errors_by_category[category] = 0
559 self.errors_by_category[category] += 1
560
561 def PrintErrorCounts(self):
562 """Print a summary of errors by category, and the total."""
563 for category, count in self.errors_by_category.iteritems():
564 sys.stderr.write('Category \'%s\' errors found: %d\n' %
565 (category, count))
566 sys.stderr.write('Total errors found: %d\n' % self.error_count)
567
568_cpplint_state = _CppLintState()
569
570
571def _OutputFormat():
572 """Gets the module's output format."""
573 return _cpplint_state.output_format
574
575
576def _SetOutputFormat(output_format):
577 """Sets the module's output format."""
578 _cpplint_state.SetOutputFormat(output_format)
579
580
581def _VerboseLevel():
582 """Returns the module's verbosity setting."""
583 return _cpplint_state.verbose_level
584
585
586def _SetVerboseLevel(level):
587 """Sets the module's verbosity, and returns the previous setting."""
588 return _cpplint_state.SetVerboseLevel(level)
589
590
591def _SetCountingStyle(level):
592 """Sets the module's counting options."""
593 _cpplint_state.SetCountingStyle(level)
594
595
596def _Filters():
597 """Returns the module's list of output filters, as a list."""
598 return _cpplint_state.filters
599
600
601def _SetFilters(filters):
602 """Sets the module's error-message filters.
603
604 These filters are applied when deciding whether to emit a given
605 error message.
606
607 Args:
608 filters: A string of comma-separated filters (eg "whitespace/indent").
609 Each filter should start with + or -; else we die.
610 """
611 _cpplint_state.SetFilters(filters)
612
613
614class _FunctionState(object):
615 """Tracks current function name and the number of lines in its body."""
616
617 _NORMAL_TRIGGER = 250 # for --v=0, 500 for --v=1, etc.
618 _TEST_TRIGGER = 400 # about 50% more than _NORMAL_TRIGGER.
619
620 def __init__(self):
621 self.in_a_function = False
622 self.lines_in_function = 0
623 self.current_function = ''
624
625 def Begin(self, function_name):
626 """Start analyzing function body.
627
628 Args:
629 function_name: The name of the function being tracked.
630 """
631 self.in_a_function = True
632 self.lines_in_function = 0
633 self.current_function = function_name
634
635 def Count(self):
636 """Count line in current function body."""
637 if self.in_a_function:
638 self.lines_in_function += 1
639
640 def Check(self, error, filename, linenum):
641 """Report if too many lines in function body.
642
643 Args:
644 error: The function to call with any errors found.
645 filename: The name of the current file.
646 linenum: The number of the line to check.
647 """
648 if Match(r'T(EST|est)', self.current_function):
649 base_trigger = self._TEST_TRIGGER
650 else:
651 base_trigger = self._NORMAL_TRIGGER
652 trigger = base_trigger * 2**_VerboseLevel()
653
654 if self.lines_in_function > trigger:
655 error_level = int(math.log(self.lines_in_function / base_trigger, 2))
656 # 50 => 0, 100 => 1, 200 => 2, 400 => 3, 800 => 4, 1600 => 5, ...
657 if error_level > 5:
658 error_level = 5
659 error(filename, linenum, 'readability/fn_size', error_level,
660 'Small and focused functions are preferred:'
661 ' %s has %d non-comment lines'
662 ' (error triggered by exceeding %d lines).' % (
663 self.current_function, self.lines_in_function, trigger))
664
665 def End(self):
Elliott Hughesdb385702012-06-21 10:41:20 -0700666 """Stop analyzing function body."""
Brian Carlstrom59848da2011-07-23 20:35:19 -0700667 self.in_a_function = False
668
669
670class _IncludeError(Exception):
671 """Indicates a problem with the include order in a file."""
672 pass
673
674
675class FileInfo:
676 """Provides utility functions for filenames.
677
678 FileInfo provides easy access to the components of a file's path
679 relative to the project root.
680 """
681
682 def __init__(self, filename):
683 self._filename = filename
684
685 def FullName(self):
686 """Make Windows paths like Unix."""
687 return os.path.abspath(self._filename).replace('\\', '/')
688
689 def RepositoryName(self):
690 """FullName after removing the local path to the repository.
691
692 If we have a real absolute path name here we can try to do something smart:
693 detecting the root of the checkout and truncating /path/to/checkout from
694 the name so that we get header guards that don't include things like
695 "C:\Documents and Settings\..." or "/home/username/..." in them and thus
696 people on different computers who have checked the source out to different
697 locations won't see bogus errors.
698 """
699 fullname = self.FullName()
700
701 if os.path.exists(fullname):
702 project_dir = os.path.dirname(fullname)
703
704 if os.path.exists(os.path.join(project_dir, ".svn")):
705 # If there's a .svn file in the current directory, we recursively look
706 # up the directory tree for the top of the SVN checkout
707 root_dir = project_dir
708 one_up_dir = os.path.dirname(root_dir)
709 while os.path.exists(os.path.join(one_up_dir, ".svn")):
710 root_dir = os.path.dirname(root_dir)
711 one_up_dir = os.path.dirname(one_up_dir)
712
713 prefix = os.path.commonprefix([root_dir, project_dir])
714 return fullname[len(prefix) + 1:]
715
Elliott Hughesdb385702012-06-21 10:41:20 -0700716 # Not SVN <= 1.6? Try to find a git, hg, or svn top level directory by
717 # searching up from the current path.
Brian Carlstrom59848da2011-07-23 20:35:19 -0700718 root_dir = os.path.dirname(fullname)
719 while (root_dir != os.path.dirname(root_dir) and
720 not os.path.exists(os.path.join(root_dir, ".git")) and
Elliott Hughesdb385702012-06-21 10:41:20 -0700721 not os.path.exists(os.path.join(root_dir, ".hg")) and
722 not os.path.exists(os.path.join(root_dir, ".svn"))):
Brian Carlstrom59848da2011-07-23 20:35:19 -0700723 root_dir = os.path.dirname(root_dir)
724
725 if (os.path.exists(os.path.join(root_dir, ".git")) or
Elliott Hughesdb385702012-06-21 10:41:20 -0700726 os.path.exists(os.path.join(root_dir, ".hg")) or
727 os.path.exists(os.path.join(root_dir, ".svn"))):
Brian Carlstrom59848da2011-07-23 20:35:19 -0700728 prefix = os.path.commonprefix([root_dir, project_dir])
Brian Carlstromfc0e3212013-07-17 14:40:12 -0700729 # BEGIN android-changed
730 # return fullname[len(prefix) + 1:]
731 return "art/" + fullname[len(prefix) + 1:]
732 # END android-changed
733
Brian Carlstrom59848da2011-07-23 20:35:19 -0700734
735 # Don't know what to do; header guard warnings may be wrong...
736 return fullname
737
738 def Split(self):
739 """Splits the file into the directory, basename, and extension.
740
741 For 'chrome/browser/browser.cc', Split() would
742 return ('chrome/browser', 'browser', '.cc')
743
744 Returns:
745 A tuple of (directory, basename, extension).
746 """
747
748 googlename = self.RepositoryName()
749 project, rest = os.path.split(googlename)
750 return (project,) + os.path.splitext(rest)
751
752 def BaseName(self):
753 """File base name - text after the final slash, before the final period."""
754 return self.Split()[1]
755
756 def Extension(self):
757 """File extension - text following the final period."""
758 return self.Split()[2]
759
760 def NoExtension(self):
761 """File has no source file extension."""
762 return '/'.join(self.Split()[0:2])
763
764 def IsSource(self):
765 """File has a source file extension."""
766 return self.Extension()[1:] in ('c', 'cc', 'cpp', 'cxx')
767
768
769def _ShouldPrintError(category, confidence, linenum):
Elliott Hughesdb385702012-06-21 10:41:20 -0700770 """If confidence >= verbose, category passes filter and is not suppressed."""
Brian Carlstrom59848da2011-07-23 20:35:19 -0700771
772 # There are three ways we might decide not to print an error message:
773 # a "NOLINT(category)" comment appears in the source,
774 # the verbosity level isn't high enough, or the filters filter it out.
775 if IsErrorSuppressedByNolint(category, linenum):
776 return False
777 if confidence < _cpplint_state.verbose_level:
778 return False
779
780 is_filtered = False
781 for one_filter in _Filters():
782 if one_filter.startswith('-'):
783 if category.startswith(one_filter[1:]):
784 is_filtered = True
785 elif one_filter.startswith('+'):
786 if category.startswith(one_filter[1:]):
787 is_filtered = False
788 else:
789 assert False # should have been checked for in SetFilter.
790 if is_filtered:
791 return False
792
793 return True
794
795
796def Error(filename, linenum, category, confidence, message):
797 """Logs the fact we've found a lint error.
798
799 We log where the error was found, and also our confidence in the error,
800 that is, how certain we are this is a legitimate style regression, and
801 not a misidentification or a use that's sometimes justified.
802
803 False positives can be suppressed by the use of
804 "cpplint(category)" comments on the offending line. These are
805 parsed into _error_suppressions.
806
807 Args:
808 filename: The name of the file containing the error.
809 linenum: The number of the line containing the error.
810 category: A string used to describe the "category" this bug
811 falls under: "whitespace", say, or "runtime". Categories
812 may have a hierarchy separated by slashes: "whitespace/indent".
813 confidence: A number from 1-5 representing a confidence score for
814 the error, with 5 meaning that we are certain of the problem,
815 and 1 meaning that it could be a legitimate construct.
816 message: The error message.
817 """
818 if _ShouldPrintError(category, confidence, linenum):
819 _cpplint_state.IncrementErrorCount(category)
820 if _cpplint_state.output_format == 'vs7':
821 sys.stderr.write('%s(%s): %s [%s] [%d]\n' % (
822 filename, linenum, message, category, confidence))
823 else:
824 sys.stderr.write('%s:%s: %s [%s] [%d]\n' % (
825 filename, linenum, message, category, confidence))
826
827
828# Matches standard C++ escape esequences per 2.13.2.3 of the C++ standard.
829_RE_PATTERN_CLEANSE_LINE_ESCAPES = re.compile(
830 r'\\([abfnrtv?"\\\']|\d+|x[0-9a-fA-F]+)')
831# Matches strings. Escape codes should already be removed by ESCAPES.
832_RE_PATTERN_CLEANSE_LINE_DOUBLE_QUOTES = re.compile(r'"[^"]*"')
833# Matches characters. Escape codes should already be removed by ESCAPES.
834_RE_PATTERN_CLEANSE_LINE_SINGLE_QUOTES = re.compile(r"'.'")
835# Matches multi-line C++ comments.
836# This RE is a little bit more complicated than one might expect, because we
837# have to take care of space removals tools so we can handle comments inside
838# statements better.
839# The current rule is: We only clear spaces from both sides when we're at the
840# end of the line. Otherwise, we try to remove spaces from the right side,
841# if this doesn't work we try on left side but only if there's a non-character
842# on the right.
843_RE_PATTERN_CLEANSE_LINE_C_COMMENTS = re.compile(
844 r"""(\s*/\*.*\*/\s*$|
845 /\*.*\*/\s+|
846 \s+/\*.*\*/(?=\W)|
847 /\*.*\*/)""", re.VERBOSE)
848
849
850def IsCppString(line):
851 """Does line terminate so, that the next symbol is in string constant.
852
853 This function does not consider single-line nor multi-line comments.
854
855 Args:
856 line: is a partial line of code starting from the 0..n.
857
858 Returns:
859 True, if next character appended to 'line' is inside a
860 string constant.
861 """
862
863 line = line.replace(r'\\', 'XX') # after this, \\" does not match to \"
864 return ((line.count('"') - line.count(r'\"') - line.count("'\"'")) & 1) == 1
865
866
867def FindNextMultiLineCommentStart(lines, lineix):
868 """Find the beginning marker for a multiline comment."""
869 while lineix < len(lines):
870 if lines[lineix].strip().startswith('/*'):
871 # Only return this marker if the comment goes beyond this line
872 if lines[lineix].strip().find('*/', 2) < 0:
873 return lineix
874 lineix += 1
875 return len(lines)
876
877
878def FindNextMultiLineCommentEnd(lines, lineix):
879 """We are inside a comment, find the end marker."""
880 while lineix < len(lines):
881 if lines[lineix].strip().endswith('*/'):
882 return lineix
883 lineix += 1
884 return len(lines)
885
886
887def RemoveMultiLineCommentsFromRange(lines, begin, end):
888 """Clears a range of lines for multi-line comments."""
889 # Having // dummy comments makes the lines non-empty, so we will not get
890 # unnecessary blank line warnings later in the code.
891 for i in range(begin, end):
892 lines[i] = '// dummy'
893
894
895def RemoveMultiLineComments(filename, lines, error):
896 """Removes multiline (c-style) comments from lines."""
897 lineix = 0
898 while lineix < len(lines):
899 lineix_begin = FindNextMultiLineCommentStart(lines, lineix)
900 if lineix_begin >= len(lines):
901 return
902 lineix_end = FindNextMultiLineCommentEnd(lines, lineix_begin)
903 if lineix_end >= len(lines):
904 error(filename, lineix_begin + 1, 'readability/multiline_comment', 5,
905 'Could not find end of multi-line comment')
906 return
907 RemoveMultiLineCommentsFromRange(lines, lineix_begin, lineix_end + 1)
908 lineix = lineix_end + 1
909
910
911def CleanseComments(line):
912 """Removes //-comments and single-line C-style /* */ comments.
913
914 Args:
915 line: A line of C++ source.
916
917 Returns:
918 The line with single-line comments removed.
919 """
920 commentpos = line.find('//')
921 if commentpos != -1 and not IsCppString(line[:commentpos]):
Elliott Hughesdb385702012-06-21 10:41:20 -0700922 line = line[:commentpos].rstrip()
Brian Carlstrom59848da2011-07-23 20:35:19 -0700923 # get rid of /* ... */
924 return _RE_PATTERN_CLEANSE_LINE_C_COMMENTS.sub('', line)
925
926
927class CleansedLines(object):
928 """Holds 3 copies of all lines with different preprocessing applied to them.
929
930 1) elided member contains lines without strings and comments,
931 2) lines member contains lines without comments, and
932 3) raw member contains all the lines without processing.
933 All these three members are of <type 'list'>, and of the same length.
934 """
935
936 def __init__(self, lines):
937 self.elided = []
938 self.lines = []
939 self.raw_lines = lines
940 self.num_lines = len(lines)
941 for linenum in range(len(lines)):
942 self.lines.append(CleanseComments(lines[linenum]))
943 elided = self._CollapseStrings(lines[linenum])
944 self.elided.append(CleanseComments(elided))
945
946 def NumLines(self):
947 """Returns the number of lines represented."""
948 return self.num_lines
949
950 @staticmethod
951 def _CollapseStrings(elided):
952 """Collapses strings and chars on a line to simple "" or '' blocks.
953
954 We nix strings first so we're not fooled by text like '"http://"'
955
956 Args:
957 elided: The line being processed.
958
959 Returns:
960 The line with collapsed strings.
961 """
962 if not _RE_PATTERN_INCLUDE.match(elided):
963 # Remove escaped characters first to make quote/single quote collapsing
964 # basic. Things that look like escaped characters shouldn't occur
965 # outside of strings and chars.
966 elided = _RE_PATTERN_CLEANSE_LINE_ESCAPES.sub('', elided)
967 elided = _RE_PATTERN_CLEANSE_LINE_SINGLE_QUOTES.sub("''", elided)
968 elided = _RE_PATTERN_CLEANSE_LINE_DOUBLE_QUOTES.sub('""', elided)
969 return elided
970
971
972def CloseExpression(clean_lines, linenum, pos):
973 """If input points to ( or { or [, finds the position that closes it.
974
Elliott Hughesdb385702012-06-21 10:41:20 -0700975 If lines[linenum][pos] points to a '(' or '{' or '[', finds the
Brian Carlstrom59848da2011-07-23 20:35:19 -0700976 linenum/pos that correspond to the closing of the expression.
977
978 Args:
979 clean_lines: A CleansedLines instance containing the file.
980 linenum: The number of the line to check.
981 pos: A position on the line.
982
983 Returns:
984 A tuple (line, linenum, pos) pointer *past* the closing brace, or
985 (line, len(lines), -1) if we never find a close. Note we ignore
986 strings and comments when matching; and the line we return is the
987 'cleansed' line at linenum.
988 """
989
990 line = clean_lines.elided[linenum]
991 startchar = line[pos]
992 if startchar not in '({[':
993 return (line, clean_lines.NumLines(), -1)
994 if startchar == '(': endchar = ')'
995 if startchar == '[': endchar = ']'
996 if startchar == '{': endchar = '}'
997
998 num_open = line.count(startchar) - line.count(endchar)
999 while linenum < clean_lines.NumLines() and num_open > 0:
1000 linenum += 1
1001 line = clean_lines.elided[linenum]
1002 num_open += line.count(startchar) - line.count(endchar)
1003 # OK, now find the endchar that actually got us back to even
1004 endpos = len(line)
1005 while num_open >= 0:
1006 endpos = line.rfind(')', 0, endpos)
1007 num_open -= 1 # chopped off another )
1008 return (line, linenum, endpos + 1)
1009
1010
1011def CheckForCopyright(filename, lines, error):
1012 """Logs an error if no Copyright message appears at the top of the file."""
1013
1014 # We'll say it should occur by line 10. Don't forget there's a
1015 # dummy line at the front.
1016 for line in xrange(1, min(len(lines), 11)):
1017 if re.search(r'Copyright', lines[line], re.I): break
1018 else: # means no copyright line was found
1019 error(filename, 0, 'legal/copyright', 5,
1020 'No copyright message found. '
1021 'You should have a line: "Copyright [year] <Copyright Owner>"')
1022
1023
1024def GetHeaderGuardCPPVariable(filename):
1025 """Returns the CPP variable that should be used as a header guard.
1026
1027 Args:
1028 filename: The name of a C++ header file.
1029
1030 Returns:
1031 The CPP variable that should be used as a header guard in the
1032 named file.
1033
1034 """
1035
1036 # Restores original filename in case that cpplint is invoked from Emacs's
1037 # flymake.
1038 filename = re.sub(r'_flymake\.h$', '.h', filename)
Brian Carlstrom59848da2011-07-23 20:35:19 -07001039 fileinfo = FileInfo(filename)
1040 return re.sub(r'[-./\s]', '_', fileinfo.RepositoryName()).upper() + '_'
1041
1042
1043def CheckForHeaderGuard(filename, lines, error):
1044 """Checks that the file contains a header guard.
1045
1046 Logs an error if no #ifndef header guard is present. For other
1047 headers, checks that the full pathname is used.
1048
1049 Args:
1050 filename: The name of the C++ header file.
1051 lines: An array of strings, each representing a line of the file.
1052 error: The function to call with any errors found.
1053 """
1054
1055 cppvar = GetHeaderGuardCPPVariable(filename)
1056
1057 ifndef = None
1058 ifndef_linenum = 0
1059 define = None
1060 endif = None
1061 endif_linenum = 0
1062 for linenum, line in enumerate(lines):
1063 linesplit = line.split()
1064 if len(linesplit) >= 2:
1065 # find the first occurrence of #ifndef and #define, save arg
1066 if not ifndef and linesplit[0] == '#ifndef':
1067 # set ifndef to the header guard presented on the #ifndef line.
1068 ifndef = linesplit[1]
1069 ifndef_linenum = linenum
1070 if not define and linesplit[0] == '#define':
1071 define = linesplit[1]
1072 # find the last occurrence of #endif, save entire line
1073 if line.startswith('#endif'):
1074 endif = line
1075 endif_linenum = linenum
1076
Elliott Hughesdb385702012-06-21 10:41:20 -07001077 if not ifndef:
Brian Carlstrom59848da2011-07-23 20:35:19 -07001078 error(filename, 0, 'build/header_guard', 5,
1079 'No #ifndef header guard found, suggested CPP variable is: %s' %
1080 cppvar)
1081 return
1082
Elliott Hughesdb385702012-06-21 10:41:20 -07001083 if not define:
1084 error(filename, 0, 'build/header_guard', 5,
1085 'No #define header guard found, suggested CPP variable is: %s' %
1086 cppvar)
1087 return
1088
Brian Carlstrom59848da2011-07-23 20:35:19 -07001089 # The guard should be PATH_FILE_H_, but we also allow PATH_FILE_H__
1090 # for backward compatibility.
1091 if ifndef != cppvar:
1092 error_level = 0
1093 if ifndef != cppvar + '_':
1094 error_level = 5
1095
1096 ParseNolintSuppressions(filename, lines[ifndef_linenum], ifndef_linenum,
1097 error)
1098 error(filename, ifndef_linenum, 'build/header_guard', error_level,
1099 '#ifndef header guard has wrong style, please use: %s' % cppvar)
1100
Elliott Hughesdb385702012-06-21 10:41:20 -07001101 if define != ifndef:
1102 error(filename, 0, 'build/header_guard', 5,
1103 '#ifndef and #define don\'t match, suggested CPP variable is: %s' %
1104 cppvar)
1105 return
1106
Brian Carlstrom59848da2011-07-23 20:35:19 -07001107 if endif != ('#endif // %s' % cppvar):
1108 error_level = 0
1109 if endif != ('#endif // %s' % (cppvar + '_')):
1110 error_level = 5
1111
1112 ParseNolintSuppressions(filename, lines[endif_linenum], endif_linenum,
1113 error)
1114 error(filename, endif_linenum, 'build/header_guard', error_level,
1115 '#endif line should be "#endif // %s"' % cppvar)
1116
1117
1118def CheckForUnicodeReplacementCharacters(filename, lines, error):
1119 """Logs an error for each line containing Unicode replacement characters.
1120
1121 These indicate that either the file contained invalid UTF-8 (likely)
1122 or Unicode replacement characters (which it shouldn't). Note that
1123 it's possible for this to throw off line numbering if the invalid
1124 UTF-8 occurred adjacent to a newline.
1125
1126 Args:
1127 filename: The name of the current file.
1128 lines: An array of strings, each representing a line of the file.
1129 error: The function to call with any errors found.
1130 """
1131 for linenum, line in enumerate(lines):
1132 if u'\ufffd' in line:
1133 error(filename, linenum, 'readability/utf8', 5,
1134 'Line contains invalid UTF-8 (or Unicode replacement character).')
1135
1136
1137def CheckForNewlineAtEOF(filename, lines, error):
1138 """Logs an error if there is no newline char at the end of the file.
1139
1140 Args:
1141 filename: The name of the current file.
1142 lines: An array of strings, each representing a line of the file.
1143 error: The function to call with any errors found.
1144 """
1145
1146 # The array lines() was created by adding two newlines to the
1147 # original file (go figure), then splitting on \n.
1148 # To verify that the file ends in \n, we just have to make sure the
1149 # last-but-two element of lines() exists and is empty.
1150 if len(lines) < 3 or lines[-2]:
1151 error(filename, len(lines) - 2, 'whitespace/ending_newline', 5,
1152 'Could not find a newline character at the end of the file.')
1153
1154
1155def CheckForMultilineCommentsAndStrings(filename, clean_lines, linenum, error):
1156 """Logs an error if we see /* ... */ or "..." that extend past one line.
1157
1158 /* ... */ comments are legit inside macros, for one line.
1159 Otherwise, we prefer // comments, so it's ok to warn about the
1160 other. Likewise, it's ok for strings to extend across multiple
1161 lines, as long as a line continuation character (backslash)
1162 terminates each line. Although not currently prohibited by the C++
1163 style guide, it's ugly and unnecessary. We don't do well with either
1164 in this lint program, so we warn about both.
1165
1166 Args:
1167 filename: The name of the current file.
1168 clean_lines: A CleansedLines instance containing the file.
1169 linenum: The number of the line to check.
1170 error: The function to call with any errors found.
1171 """
1172 line = clean_lines.elided[linenum]
1173
1174 # Remove all \\ (escaped backslashes) from the line. They are OK, and the
1175 # second (escaped) slash may trigger later \" detection erroneously.
1176 line = line.replace('\\\\', '')
1177
1178 if line.count('/*') > line.count('*/'):
1179 error(filename, linenum, 'readability/multiline_comment', 5,
1180 'Complex multi-line /*...*/-style comment found. '
1181 'Lint may give bogus warnings. '
1182 'Consider replacing these with //-style comments, '
1183 'with #if 0...#endif, '
1184 'or with more clearly structured multi-line comments.')
1185
1186 if (line.count('"') - line.count('\\"')) % 2:
1187 error(filename, linenum, 'readability/multiline_string', 5,
1188 'Multi-line string ("...") found. This lint script doesn\'t '
1189 'do well with such strings, and may give bogus warnings. They\'re '
1190 'ugly and unnecessary, and you should use concatenation instead".')
1191
1192
1193threading_list = (
1194 ('asctime(', 'asctime_r('),
1195 ('ctime(', 'ctime_r('),
1196 ('getgrgid(', 'getgrgid_r('),
1197 ('getgrnam(', 'getgrnam_r('),
1198 ('getlogin(', 'getlogin_r('),
1199 ('getpwnam(', 'getpwnam_r('),
1200 ('getpwuid(', 'getpwuid_r('),
1201 ('gmtime(', 'gmtime_r('),
1202 ('localtime(', 'localtime_r('),
1203 ('rand(', 'rand_r('),
1204 ('readdir(', 'readdir_r('),
1205 ('strtok(', 'strtok_r('),
1206 ('ttyname(', 'ttyname_r('),
1207 )
1208
1209
1210def CheckPosixThreading(filename, clean_lines, linenum, error):
1211 """Checks for calls to thread-unsafe functions.
1212
1213 Much code has been originally written without consideration of
1214 multi-threading. Also, engineers are relying on their old experience;
1215 they have learned posix before threading extensions were added. These
1216 tests guide the engineers to use thread-safe functions (when using
1217 posix directly).
1218
1219 Args:
1220 filename: The name of the current file.
1221 clean_lines: A CleansedLines instance containing the file.
1222 linenum: The number of the line to check.
1223 error: The function to call with any errors found.
1224 """
1225 line = clean_lines.elided[linenum]
1226 for single_thread_function, multithread_safe_function in threading_list:
1227 ix = line.find(single_thread_function)
1228 # Comparisons made explicit for clarity -- pylint: disable-msg=C6403
1229 if ix >= 0 and (ix == 0 or (not line[ix - 1].isalnum() and
1230 line[ix - 1] not in ('_', '.', '>'))):
1231 error(filename, linenum, 'runtime/threadsafe_fn', 2,
1232 'Consider using ' + multithread_safe_function +
1233 '...) instead of ' + single_thread_function +
1234 '...) for improved thread safety.')
1235
1236
1237# Matches invalid increment: *count++, which moves pointer instead of
1238# incrementing a value.
1239_RE_PATTERN_INVALID_INCREMENT = re.compile(
1240 r'^\s*\*\w+(\+\+|--);')
1241
1242
1243def CheckInvalidIncrement(filename, clean_lines, linenum, error):
1244 """Checks for invalid increment *count++.
1245
1246 For example following function:
1247 void increment_counter(int* count) {
1248 *count++;
1249 }
1250 is invalid, because it effectively does count++, moving pointer, and should
1251 be replaced with ++*count, (*count)++ or *count += 1.
1252
1253 Args:
1254 filename: The name of the current file.
1255 clean_lines: A CleansedLines instance containing the file.
1256 linenum: The number of the line to check.
1257 error: The function to call with any errors found.
1258 """
1259 line = clean_lines.elided[linenum]
1260 if _RE_PATTERN_INVALID_INCREMENT.match(line):
1261 error(filename, linenum, 'runtime/invalid_increment', 5,
1262 'Changing pointer instead of value (or unused value of operator*).')
1263
1264
1265class _ClassInfo(object):
1266 """Stores information about a class."""
1267
Elliott Hughesdb385702012-06-21 10:41:20 -07001268 def __init__(self, name, clean_lines, linenum):
Brian Carlstrom59848da2011-07-23 20:35:19 -07001269 self.name = name
1270 self.linenum = linenum
1271 self.seen_open_brace = False
1272 self.is_derived = False
1273 self.virtual_method_linenumber = None
1274 self.has_virtual_destructor = False
1275 self.brace_depth = 0
1276
Elliott Hughesdb385702012-06-21 10:41:20 -07001277 # Try to find the end of the class. This will be confused by things like:
1278 # class A {
1279 # } *x = { ...
1280 #
1281 # But it's still good enough for CheckSectionSpacing.
1282 self.last_line = 0
1283 depth = 0
1284 for i in range(linenum, clean_lines.NumLines()):
1285 line = clean_lines.lines[i]
1286 depth += line.count('{') - line.count('}')
1287 if not depth:
1288 self.last_line = i
1289 break
1290
Brian Carlstrom59848da2011-07-23 20:35:19 -07001291
1292class _ClassState(object):
1293 """Holds the current state of the parse relating to class declarations.
1294
1295 It maintains a stack of _ClassInfos representing the parser's guess
1296 as to the current nesting of class declarations. The innermost class
1297 is at the top (back) of the stack. Typically, the stack will either
1298 be empty or have exactly one entry.
1299 """
1300
1301 def __init__(self):
1302 self.classinfo_stack = []
1303
1304 def CheckFinished(self, filename, error):
1305 """Checks that all classes have been completely parsed.
1306
1307 Call this when all lines in a file have been processed.
1308 Args:
1309 filename: The name of the current file.
1310 error: The function to call with any errors found.
1311 """
1312 if self.classinfo_stack:
1313 # Note: This test can result in false positives if #ifdef constructs
1314 # get in the way of brace matching. See the testBuildClass test in
1315 # cpplint_unittest.py for an example of this.
1316 error(filename, self.classinfo_stack[0].linenum, 'build/class', 5,
1317 'Failed to find complete declaration of class %s' %
1318 self.classinfo_stack[0].name)
1319
1320
1321def CheckForNonStandardConstructs(filename, clean_lines, linenum,
1322 class_state, error):
1323 """Logs an error if we see certain non-ANSI constructs ignored by gcc-2.
1324
1325 Complain about several constructs which gcc-2 accepts, but which are
1326 not standard C++. Warning about these in lint is one way to ease the
1327 transition to new compilers.
1328 - put storage class first (e.g. "static const" instead of "const static").
1329 - "%lld" instead of %qd" in printf-type functions.
1330 - "%1$d" is non-standard in printf-type functions.
1331 - "\%" is an undefined character escape sequence.
1332 - text after #endif is not allowed.
1333 - invalid inner-style forward declaration.
1334 - >? and <? operators, and their >?= and <?= cousins.
1335 - classes with virtual methods need virtual destructors (compiler warning
1336 available, but not turned on yet.)
1337
1338 Additionally, check for constructor/destructor style violations and reference
1339 members, as it is very convenient to do so while checking for
1340 gcc-2 compliance.
1341
1342 Args:
1343 filename: The name of the current file.
1344 clean_lines: A CleansedLines instance containing the file.
1345 linenum: The number of the line to check.
1346 class_state: A _ClassState instance which maintains information about
1347 the current stack of nested class declarations being parsed.
1348 error: A callable to which errors are reported, which takes 4 arguments:
1349 filename, line number, error level, and message
1350 """
1351
1352 # Remove comments from the line, but leave in strings for now.
1353 line = clean_lines.lines[linenum]
1354
1355 if Search(r'printf\s*\(.*".*%[-+ ]?\d*q', line):
1356 error(filename, linenum, 'runtime/printf_format', 3,
1357 '%q in format strings is deprecated. Use %ll instead.')
1358
1359 if Search(r'printf\s*\(.*".*%\d+\$', line):
1360 error(filename, linenum, 'runtime/printf_format', 2,
1361 '%N$ formats are unconventional. Try rewriting to avoid them.')
1362
1363 # Remove escaped backslashes before looking for undefined escapes.
1364 line = line.replace('\\\\', '')
1365
1366 if Search(r'("|\').*\\(%|\[|\(|{)', line):
1367 error(filename, linenum, 'build/printf_format', 3,
1368 '%, [, (, and { are undefined character escapes. Unescape them.')
1369
1370 # For the rest, work with both comments and strings removed.
1371 line = clean_lines.elided[linenum]
1372
1373 if Search(r'\b(const|volatile|void|char|short|int|long'
1374 r'|float|double|signed|unsigned'
1375 r'|schar|u?int8|u?int16|u?int32|u?int64)'
1376 r'\s+(auto|register|static|extern|typedef)\b',
1377 line):
1378 error(filename, linenum, 'build/storage_class', 5,
1379 'Storage class (static, extern, typedef, etc) should be first.')
1380
1381 if Match(r'\s*#\s*endif\s*[^/\s]+', line):
1382 error(filename, linenum, 'build/endif_comment', 5,
1383 'Uncommented text after #endif is non-standard. Use a comment.')
1384
1385 if Match(r'\s*class\s+(\w+\s*::\s*)+\w+\s*;', line):
1386 error(filename, linenum, 'build/forward_decl', 5,
1387 'Inner-style forward declarations are invalid. Remove this line.')
1388
1389 if Search(r'(\w+|[+-]?\d+(\.\d*)?)\s*(<|>)\?=?\s*(\w+|[+-]?\d+)(\.\d*)?',
1390 line):
1391 error(filename, linenum, 'build/deprecated', 3,
1392 '>? and <? (max and min) operators are non-standard and deprecated.')
1393
1394 if Search(r'^\s*const\s*string\s*&\s*\w+\s*;', line):
1395 # TODO(unknown): Could it be expanded safely to arbitrary references,
1396 # without triggering too many false positives? The first
1397 # attempt triggered 5 warnings for mostly benign code in the regtest, hence
1398 # the restriction.
1399 # Here's the original regexp, for the reference:
1400 # type_name = r'\w+((\s*::\s*\w+)|(\s*<\s*\w+?\s*>))?'
1401 # r'\s*const\s*' + type_name + '\s*&\s*\w+\s*;'
1402 error(filename, linenum, 'runtime/member_string_references', 2,
1403 'const string& members are dangerous. It is much better to use '
1404 'alternatives, such as pointers or simple constants.')
1405
1406 # Track class entry and exit, and attempt to find cases within the
1407 # class declaration that don't meet the C++ style
1408 # guidelines. Tracking is very dependent on the code matching Google
1409 # style guidelines, but it seems to perform well enough in testing
1410 # to be a worthwhile addition to the checks.
1411 classinfo_stack = class_state.classinfo_stack
Elliott Hughesdb385702012-06-21 10:41:20 -07001412 # Look for a class declaration. The regexp accounts for decorated classes
1413 # such as in:
1414 # class LOCKABLE API Object {
1415 # };
Brian Carlstrom59848da2011-07-23 20:35:19 -07001416 class_decl_match = Match(
Elliott Hughesdb385702012-06-21 10:41:20 -07001417 r'\s*(template\s*<[\w\s<>,:]*>\s*)?'
1418 '(class|struct)\s+([A-Z_]+\s+)*(\w+(::\w+)*)', line)
Brian Carlstrom59848da2011-07-23 20:35:19 -07001419 if class_decl_match:
Elliott Hughesdb385702012-06-21 10:41:20 -07001420 classinfo_stack.append(_ClassInfo(
1421 class_decl_match.group(4), clean_lines, linenum))
Brian Carlstrom59848da2011-07-23 20:35:19 -07001422
1423 # Everything else in this function uses the top of the stack if it's
1424 # not empty.
1425 if not classinfo_stack:
1426 return
1427
1428 classinfo = classinfo_stack[-1]
1429
1430 # If the opening brace hasn't been seen look for it and also
1431 # parent class declarations.
1432 if not classinfo.seen_open_brace:
1433 # If the line has a ';' in it, assume it's a forward declaration or
1434 # a single-line class declaration, which we won't process.
1435 if line.find(';') != -1:
1436 classinfo_stack.pop()
1437 return
1438 classinfo.seen_open_brace = (line.find('{') != -1)
1439 # Look for a bare ':'
1440 if Search('(^|[^:]):($|[^:])', line):
1441 classinfo.is_derived = True
1442 if not classinfo.seen_open_brace:
1443 return # Everything else in this function is for after open brace
1444
1445 # The class may have been declared with namespace or classname qualifiers.
1446 # The constructor and destructor will not have those qualifiers.
1447 base_classname = classinfo.name.split('::')[-1]
1448
1449 # Look for single-argument constructors that aren't marked explicit.
1450 # Technically a valid construct, but against style.
Elliott Hughesdb385702012-06-21 10:41:20 -07001451 args = Match(r'\s+(?:inline\s+)?%s\s*\(([^,()]+)\)'
Brian Carlstrom59848da2011-07-23 20:35:19 -07001452 % re.escape(base_classname),
1453 line)
1454 if (args and
1455 args.group(1) != 'void' and
Elliott Hughesdb385702012-06-21 10:41:20 -07001456 not Match(r'(const\s+)?%s\s*(?:<\w+>\s*)?&' % re.escape(base_classname),
Brian Carlstrom59848da2011-07-23 20:35:19 -07001457 args.group(1).strip())):
1458 error(filename, linenum, 'runtime/explicit', 5,
1459 'Single-argument constructors should be marked explicit.')
1460
1461 # Look for methods declared virtual.
1462 if Search(r'\bvirtual\b', line):
1463 classinfo.virtual_method_linenumber = linenum
1464 # Only look for a destructor declaration on the same line. It would
1465 # be extremely unlikely for the destructor declaration to occupy
1466 # more than one line.
1467 if Search(r'~%s\s*\(' % base_classname, line):
1468 classinfo.has_virtual_destructor = True
1469
1470 # Look for class end.
1471 brace_depth = classinfo.brace_depth
1472 brace_depth = brace_depth + line.count('{') - line.count('}')
1473 if brace_depth <= 0:
1474 classinfo = classinfo_stack.pop()
1475 # Try to detect missing virtual destructor declarations.
1476 # For now, only warn if a non-derived class with virtual methods lacks
1477 # a virtual destructor. This is to make it less likely that people will
1478 # declare derived virtual destructors without declaring the base
1479 # destructor virtual.
1480 if ((classinfo.virtual_method_linenumber is not None) and
1481 (not classinfo.has_virtual_destructor) and
1482 (not classinfo.is_derived)): # Only warn for base classes
1483 error(filename, classinfo.linenum, 'runtime/virtual', 4,
1484 'The class %s probably needs a virtual destructor due to '
1485 'having virtual method(s), one declared at line %d.'
1486 % (classinfo.name, classinfo.virtual_method_linenumber))
1487 else:
1488 classinfo.brace_depth = brace_depth
1489
1490
1491def CheckSpacingForFunctionCall(filename, line, linenum, error):
1492 """Checks for the correctness of various spacing around function calls.
1493
1494 Args:
1495 filename: The name of the current file.
1496 line: The text of the line to check.
1497 linenum: The number of the line to check.
1498 error: The function to call with any errors found.
1499 """
1500
1501 # Since function calls often occur inside if/for/while/switch
1502 # expressions - which have their own, more liberal conventions - we
1503 # first see if we should be looking inside such an expression for a
1504 # function call, to which we can apply more strict standards.
1505 fncall = line # if there's no control flow construct, look at whole line
1506 for pattern in (r'\bif\s*\((.*)\)\s*{',
1507 r'\bfor\s*\((.*)\)\s*{',
1508 r'\bwhile\s*\((.*)\)\s*[{;]',
1509 r'\bswitch\s*\((.*)\)\s*{'):
1510 match = Search(pattern, line)
1511 if match:
1512 fncall = match.group(1) # look inside the parens for function calls
1513 break
1514
1515 # Except in if/for/while/switch, there should never be space
1516 # immediately inside parens (eg "f( 3, 4 )"). We make an exception
1517 # for nested parens ( (a+b) + c ). Likewise, there should never be
1518 # a space before a ( when it's a function argument. I assume it's a
1519 # function argument when the char before the whitespace is legal in
1520 # a function name (alnum + _) and we're not starting a macro. Also ignore
1521 # pointers and references to arrays and functions coz they're too tricky:
1522 # we use a very simple way to recognize these:
1523 # " (something)(maybe-something)" or
1524 # " (something)(maybe-something," or
1525 # " (something)[something]"
1526 # Note that we assume the contents of [] to be short enough that
1527 # they'll never need to wrap.
1528 if ( # Ignore control structures.
Brian Carlstromdf629502013-07-17 22:39:56 -07001529 # BEGIN android-changed
1530 # not Search(r'\b(if|for|while|switch|return|delete)\b', fncall) and
1531 not Search(r'\b(if|for|while|switch|return|delete|new)\b', fncall) and
1532 # END android-changed
Brian Carlstrom59848da2011-07-23 20:35:19 -07001533 # Ignore pointers/references to functions.
1534 not Search(r' \([^)]+\)\([^)]*(\)|,$)', fncall) and
1535 # Ignore pointers/references to arrays.
1536 not Search(r' \([^)]+\)\[[^\]]+\]', fncall)):
1537 if Search(r'\w\s*\(\s(?!\s*\\$)', fncall): # a ( used for a fn call
1538 error(filename, linenum, 'whitespace/parens', 4,
1539 'Extra space after ( in function call')
1540 elif Search(r'\(\s+(?!(\s*\\)|\()', fncall):
1541 error(filename, linenum, 'whitespace/parens', 2,
1542 'Extra space after (')
1543 if (Search(r'\w\s+\(', fncall) and
1544 not Search(r'#\s*define|typedef', fncall)):
1545 error(filename, linenum, 'whitespace/parens', 4,
1546 'Extra space before ( in function call')
1547 # If the ) is followed only by a newline or a { + newline, assume it's
1548 # part of a control statement (if/while/etc), and don't complain
1549 if Search(r'[^)]\s+\)\s*[^{\s]', fncall):
Elliott Hughesdb385702012-06-21 10:41:20 -07001550 # If the closing parenthesis is preceded by only whitespaces,
1551 # try to give a more descriptive error message.
1552 if Search(r'^\s+\)', fncall):
1553 error(filename, linenum, 'whitespace/parens', 2,
1554 'Closing ) should be moved to the previous line')
1555 else:
1556 error(filename, linenum, 'whitespace/parens', 2,
1557 'Extra space before )')
Brian Carlstrom59848da2011-07-23 20:35:19 -07001558
1559
1560def IsBlankLine(line):
1561 """Returns true if the given line is blank.
1562
1563 We consider a line to be blank if the line is empty or consists of
1564 only white spaces.
1565
1566 Args:
1567 line: A line of a string.
1568
1569 Returns:
1570 True, if the given line is blank.
1571 """
1572 return not line or line.isspace()
1573
1574
1575def CheckForFunctionLengths(filename, clean_lines, linenum,
1576 function_state, error):
1577 """Reports for long function bodies.
1578
1579 For an overview why this is done, see:
1580 http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Write_Short_Functions
1581
1582 Uses a simplistic algorithm assuming other style guidelines
1583 (especially spacing) are followed.
1584 Only checks unindented functions, so class members are unchecked.
1585 Trivial bodies are unchecked, so constructors with huge initializer lists
1586 may be missed.
1587 Blank/comment lines are not counted so as to avoid encouraging the removal
Elliott Hughesdb385702012-06-21 10:41:20 -07001588 of vertical space and comments just to get through a lint check.
Brian Carlstrom59848da2011-07-23 20:35:19 -07001589 NOLINT *on the last line of a function* disables this check.
1590
1591 Args:
1592 filename: The name of the current file.
1593 clean_lines: A CleansedLines instance containing the file.
1594 linenum: The number of the line to check.
1595 function_state: Current function name and lines in body so far.
1596 error: The function to call with any errors found.
1597 """
1598 lines = clean_lines.lines
1599 line = lines[linenum]
1600 raw = clean_lines.raw_lines
1601 raw_line = raw[linenum]
1602 joined_line = ''
1603
1604 starting_func = False
1605 regexp = r'(\w(\w|::|\*|\&|\s)*)\(' # decls * & space::name( ...
1606 match_result = Match(regexp, line)
1607 if match_result:
1608 # If the name is all caps and underscores, figure it's a macro and
1609 # ignore it, unless it's TEST or TEST_F.
1610 function_name = match_result.group(1).split()[-1]
1611 if function_name == 'TEST' or function_name == 'TEST_F' or (
1612 not Match(r'[A-Z_]+$', function_name)):
1613 starting_func = True
1614
1615 if starting_func:
1616 body_found = False
1617 for start_linenum in xrange(linenum, clean_lines.NumLines()):
1618 start_line = lines[start_linenum]
1619 joined_line += ' ' + start_line.lstrip()
1620 if Search(r'(;|})', start_line): # Declarations and trivial functions
1621 body_found = True
1622 break # ... ignore
1623 elif Search(r'{', start_line):
1624 body_found = True
1625 function = Search(r'((\w|:)*)\(', line).group(1)
1626 if Match(r'TEST', function): # Handle TEST... macros
1627 parameter_regexp = Search(r'(\(.*\))', joined_line)
1628 if parameter_regexp: # Ignore bad syntax
1629 function += parameter_regexp.group(1)
1630 else:
1631 function += '()'
1632 function_state.Begin(function)
1633 break
1634 if not body_found:
1635 # No body for the function (or evidence of a non-function) was found.
1636 error(filename, linenum, 'readability/fn_size', 5,
1637 'Lint failed to find start of function body.')
1638 elif Match(r'^\}\s*$', line): # function end
1639 function_state.Check(error, filename, linenum)
1640 function_state.End()
1641 elif not Match(r'^\s*$', line):
1642 function_state.Count() # Count non-blank/non-comment lines.
1643
1644
1645_RE_PATTERN_TODO = re.compile(r'^//(\s*)TODO(\(.+?\))?:?(\s|$)?')
1646
1647
1648def CheckComment(comment, filename, linenum, error):
1649 """Checks for common mistakes in TODO comments.
1650
1651 Args:
1652 comment: The text of the comment from the line in question.
1653 filename: The name of the current file.
1654 linenum: The number of the line to check.
1655 error: The function to call with any errors found.
1656 """
1657 match = _RE_PATTERN_TODO.match(comment)
1658 if match:
1659 # One whitespace is correct; zero whitespace is handled elsewhere.
1660 leading_whitespace = match.group(1)
1661 if len(leading_whitespace) > 1:
1662 error(filename, linenum, 'whitespace/todo', 2,
1663 'Too many spaces before TODO')
1664
1665 username = match.group(2)
1666 if not username:
1667 error(filename, linenum, 'readability/todo', 2,
1668 'Missing username in TODO; it should look like '
1669 '"// TODO(my_username): Stuff."')
1670
1671 middle_whitespace = match.group(3)
1672 # Comparisons made explicit for correctness -- pylint: disable-msg=C6403
1673 if middle_whitespace != ' ' and middle_whitespace != '':
1674 error(filename, linenum, 'whitespace/todo', 2,
1675 'TODO(my_username) should be followed by a space')
1676
1677
1678def CheckSpacing(filename, clean_lines, linenum, error):
1679 """Checks for the correctness of various spacing issues in the code.
1680
1681 Things we check for: spaces around operators, spaces after
1682 if/for/while/switch, no spaces around parens in function calls, two
1683 spaces between code and comment, don't start a block with a blank
Elliott Hughesdb385702012-06-21 10:41:20 -07001684 line, don't end a function with a blank line, don't add a blank line
1685 after public/protected/private, don't have too many blank lines in a row.
Brian Carlstrom59848da2011-07-23 20:35:19 -07001686
1687 Args:
1688 filename: The name of the current file.
1689 clean_lines: A CleansedLines instance containing the file.
1690 linenum: The number of the line to check.
1691 error: The function to call with any errors found.
1692 """
1693
1694 raw = clean_lines.raw_lines
1695 line = raw[linenum]
1696
1697 # Before nixing comments, check if the line is blank for no good
1698 # reason. This includes the first line after a block is opened, and
1699 # blank lines at the end of a function (ie, right before a line like '}'
1700 if IsBlankLine(line):
1701 elided = clean_lines.elided
1702 prev_line = elided[linenum - 1]
1703 prevbrace = prev_line.rfind('{')
1704 # TODO(unknown): Don't complain if line before blank line, and line after,
1705 # both start with alnums and are indented the same amount.
1706 # This ignores whitespace at the start of a namespace block
1707 # because those are not usually indented.
1708 if (prevbrace != -1 and prev_line[prevbrace:].find('}') == -1
1709 and prev_line[:prevbrace].find('namespace') == -1):
1710 # OK, we have a blank line at the start of a code block. Before we
1711 # complain, we check if it is an exception to the rule: The previous
Elliott Hughesdb385702012-06-21 10:41:20 -07001712 # non-empty line has the parameters of a function header that are indented
Brian Carlstrom59848da2011-07-23 20:35:19 -07001713 # 4 spaces (because they did not fit in a 80 column line when placed on
1714 # the same line as the function name). We also check for the case where
1715 # the previous line is indented 6 spaces, which may happen when the
1716 # initializers of a constructor do not fit into a 80 column line.
1717 exception = False
1718 if Match(r' {6}\w', prev_line): # Initializer list?
1719 # We are looking for the opening column of initializer list, which
1720 # should be indented 4 spaces to cause 6 space indentation afterwards.
1721 search_position = linenum-2
1722 while (search_position >= 0
1723 and Match(r' {6}\w', elided[search_position])):
1724 search_position -= 1
1725 exception = (search_position >= 0
1726 and elided[search_position][:5] == ' :')
1727 else:
1728 # Search for the function arguments or an initializer list. We use a
1729 # simple heuristic here: If the line is indented 4 spaces; and we have a
1730 # closing paren, without the opening paren, followed by an opening brace
1731 # or colon (for initializer lists) we assume that it is the last line of
1732 # a function header. If we have a colon indented 4 spaces, it is an
1733 # initializer list.
1734 exception = (Match(r' {4}\w[^\(]*\)\s*(const\s*)?(\{\s*$|:)',
1735 prev_line)
1736 or Match(r' {4}:', prev_line))
1737
1738 if not exception:
1739 error(filename, linenum, 'whitespace/blank_line', 2,
1740 'Blank line at the start of a code block. Is this needed?')
1741 # This doesn't ignore whitespace at the end of a namespace block
1742 # because that is too hard without pairing open/close braces;
1743 # however, a special exception is made for namespace closing
1744 # brackets which have a comment containing "namespace".
1745 #
1746 # Also, ignore blank lines at the end of a block in a long if-else
1747 # chain, like this:
1748 # if (condition1) {
1749 # // Something followed by a blank line
1750 #
1751 # } else if (condition2) {
1752 # // Something else
1753 # }
1754 if linenum + 1 < clean_lines.NumLines():
1755 next_line = raw[linenum + 1]
1756 if (next_line
1757 and Match(r'\s*}', next_line)
1758 and next_line.find('namespace') == -1
1759 and next_line.find('} else ') == -1):
1760 error(filename, linenum, 'whitespace/blank_line', 3,
1761 'Blank line at the end of a code block. Is this needed?')
1762
Elliott Hughesdb385702012-06-21 10:41:20 -07001763 matched = Match(r'\s*(public|protected|private):', prev_line)
1764 if matched:
1765 error(filename, linenum, 'whitespace/blank_line', 3,
1766 'Do not leave a blank line after "%s:"' % matched.group(1))
1767
Brian Carlstrom59848da2011-07-23 20:35:19 -07001768 # Next, we complain if there's a comment too near the text
1769 commentpos = line.find('//')
1770 if commentpos != -1:
1771 # Check if the // may be in quotes. If so, ignore it
1772 # Comparisons made explicit for clarity -- pylint: disable-msg=C6403
1773 if (line.count('"', 0, commentpos) -
1774 line.count('\\"', 0, commentpos)) % 2 == 0: # not in quotes
1775 # Allow one space for new scopes, two spaces otherwise:
1776 if (not Match(r'^\s*{ //', line) and
1777 ((commentpos >= 1 and
1778 line[commentpos-1] not in string.whitespace) or
1779 (commentpos >= 2 and
1780 line[commentpos-2] not in string.whitespace))):
1781 error(filename, linenum, 'whitespace/comments', 2,
1782 'At least two spaces is best between code and comments')
1783 # There should always be a space between the // and the comment
1784 commentend = commentpos + 2
1785 if commentend < len(line) and not line[commentend] == ' ':
1786 # but some lines are exceptions -- e.g. if they're big
1787 # comment delimiters like:
1788 # //----------------------------------------------------------
1789 # or are an empty C++ style Doxygen comment, like:
1790 # ///
1791 # or they begin with multiple slashes followed by a space:
1792 # //////// Header comment
1793 match = (Search(r'[=/-]{4,}\s*$', line[commentend:]) or
1794 Search(r'^/$', line[commentend:]) or
1795 Search(r'^/+ ', line[commentend:]))
1796 if not match:
1797 error(filename, linenum, 'whitespace/comments', 4,
1798 'Should have a space between // and comment')
1799 CheckComment(line[commentpos:], filename, linenum, error)
1800
1801 line = clean_lines.elided[linenum] # get rid of comments and strings
1802
1803 # Don't try to do spacing checks for operator methods
1804 line = re.sub(r'operator(==|!=|<|<<|<=|>=|>>|>)\(', 'operator\(', line)
1805
1806 # We allow no-spaces around = within an if: "if ( (a=Foo()) == 0 )".
1807 # Otherwise not. Note we only check for non-spaces on *both* sides;
1808 # sometimes people put non-spaces on one side when aligning ='s among
1809 # many lines (not that this is behavior that I approve of...)
1810 if Search(r'[\w.]=[\w.]', line) and not Search(r'\b(if|while) ', line):
1811 error(filename, linenum, 'whitespace/operators', 4,
1812 'Missing spaces around =')
1813
1814 # It's ok not to have spaces around binary operators like + - * /, but if
1815 # there's too little whitespace, we get concerned. It's hard to tell,
1816 # though, so we punt on this one for now. TODO.
1817
1818 # You should always have whitespace around binary operators.
1819 # Alas, we can't test < or > because they're legitimately used sans spaces
1820 # (a->b, vector<int> a). The only time we can tell is a < with no >, and
1821 # only if it's not template params list spilling into the next line.
1822 match = Search(r'[^<>=!\s](==|!=|<=|>=)[^<>=!\s]', line)
1823 if not match:
1824 # Note that while it seems that the '<[^<]*' term in the following
1825 # regexp could be simplified to '<.*', which would indeed match
1826 # the same class of strings, the [^<] means that searching for the
1827 # regexp takes linear rather than quadratic time.
1828 if not Search(r'<[^<]*,\s*$', line): # template params spill
1829 match = Search(r'[^<>=!\s](<)[^<>=!\s]([^>]|->)*$', line)
1830 if match:
1831 error(filename, linenum, 'whitespace/operators', 3,
1832 'Missing spaces around %s' % match.group(1))
1833 # We allow no-spaces around << and >> when used like this: 10<<20, but
1834 # not otherwise (particularly, not when used as streams)
1835 match = Search(r'[^0-9\s](<<|>>)[^0-9\s]', line)
1836 if match:
1837 error(filename, linenum, 'whitespace/operators', 3,
1838 'Missing spaces around %s' % match.group(1))
1839
1840 # There shouldn't be space around unary operators
1841 match = Search(r'(!\s|~\s|[\s]--[\s;]|[\s]\+\+[\s;])', line)
1842 if match:
1843 error(filename, linenum, 'whitespace/operators', 4,
1844 'Extra space for operator %s' % match.group(1))
1845
1846 # A pet peeve of mine: no spaces after an if, while, switch, or for
1847 match = Search(r' (if\(|for\(|while\(|switch\()', line)
1848 if match:
1849 error(filename, linenum, 'whitespace/parens', 5,
1850 'Missing space before ( in %s' % match.group(1))
1851
1852 # For if/for/while/switch, the left and right parens should be
1853 # consistent about how many spaces are inside the parens, and
1854 # there should either be zero or one spaces inside the parens.
1855 # We don't want: "if ( foo)" or "if ( foo )".
1856 # Exception: "for ( ; foo; bar)" and "for (foo; bar; )" are allowed.
1857 match = Search(r'\b(if|for|while|switch)\s*'
1858 r'\(([ ]*)(.).*[^ ]+([ ]*)\)\s*{\s*$',
1859 line)
1860 if match:
1861 if len(match.group(2)) != len(match.group(4)):
1862 if not (match.group(3) == ';' and
1863 len(match.group(2)) == 1 + len(match.group(4)) or
1864 not match.group(2) and Search(r'\bfor\s*\(.*; \)', line)):
1865 error(filename, linenum, 'whitespace/parens', 5,
1866 'Mismatching spaces inside () in %s' % match.group(1))
1867 if not len(match.group(2)) in [0, 1]:
1868 error(filename, linenum, 'whitespace/parens', 5,
1869 'Should have zero or one spaces inside ( and ) in %s' %
1870 match.group(1))
1871
1872 # You should always have a space after a comma (either as fn arg or operator)
1873 if Search(r',[^\s]', line):
1874 error(filename, linenum, 'whitespace/comma', 3,
1875 'Missing space after ,')
1876
Elliott Hughesdb385702012-06-21 10:41:20 -07001877 # You should always have a space after a semicolon
1878 # except for few corner cases
1879 # TODO(unknown): clarify if 'if (1) { return 1;}' is requires one more
1880 # space after ;
1881 if Search(r';[^\s};\\)/]', line):
1882 error(filename, linenum, 'whitespace/semicolon', 3,
1883 'Missing space after ;')
1884
Brian Carlstrom59848da2011-07-23 20:35:19 -07001885 # Next we will look for issues with function calls.
1886 CheckSpacingForFunctionCall(filename, line, linenum, error)
1887
Elliott Hughesdb385702012-06-21 10:41:20 -07001888 # Except after an opening paren, or after another opening brace (in case of
1889 # an initializer list, for instance), you should have spaces before your
1890 # braces. And since you should never have braces at the beginning of a line,
1891 # this is an easy test.
1892 if Search(r'[^ ({]{', line):
Brian Carlstrom59848da2011-07-23 20:35:19 -07001893 error(filename, linenum, 'whitespace/braces', 5,
1894 'Missing space before {')
1895
1896 # Make sure '} else {' has spaces.
1897 if Search(r'}else', line):
1898 error(filename, linenum, 'whitespace/braces', 5,
1899 'Missing space before else')
1900
1901 # You shouldn't have spaces before your brackets, except maybe after
1902 # 'delete []' or 'new char * []'.
1903 if Search(r'\w\s+\[', line) and not Search(r'delete\s+\[', line):
1904 error(filename, linenum, 'whitespace/braces', 5,
1905 'Extra space before [')
1906
1907 # You shouldn't have a space before a semicolon at the end of the line.
1908 # There's a special case for "for" since the style guide allows space before
1909 # the semicolon there.
1910 if Search(r':\s*;\s*$', line):
1911 error(filename, linenum, 'whitespace/semicolon', 5,
1912 'Semicolon defining empty statement. Use { } instead.')
1913 elif Search(r'^\s*;\s*$', line):
1914 error(filename, linenum, 'whitespace/semicolon', 5,
1915 'Line contains only semicolon. If this should be an empty statement, '
1916 'use { } instead.')
1917 elif (Search(r'\s+;\s*$', line) and
1918 not Search(r'\bfor\b', line)):
1919 error(filename, linenum, 'whitespace/semicolon', 5,
1920 'Extra space before last semicolon. If this should be an empty '
1921 'statement, use { } instead.')
1922
1923
Elliott Hughesdb385702012-06-21 10:41:20 -07001924def CheckSectionSpacing(filename, clean_lines, class_info, linenum, error):
1925 """Checks for additional blank line issues related to sections.
1926
1927 Currently the only thing checked here is blank line before protected/private.
1928
1929 Args:
1930 filename: The name of the current file.
1931 clean_lines: A CleansedLines instance containing the file.
1932 class_info: A _ClassInfo objects.
1933 linenum: The number of the line to check.
1934 error: The function to call with any errors found.
1935 """
1936 # Skip checks if the class is small, where small means 25 lines or less.
1937 # 25 lines seems like a good cutoff since that's the usual height of
1938 # terminals, and any class that can't fit in one screen can't really
1939 # be considered "small".
1940 #
1941 # Also skip checks if we are on the first line. This accounts for
1942 # classes that look like
1943 # class Foo { public: ... };
1944 #
1945 # If we didn't find the end of the class, last_line would be zero,
1946 # and the check will be skipped by the first condition.
1947 if (class_info.last_line - class_info.linenum <= 24 or
1948 linenum <= class_info.linenum):
1949 return
1950
1951 matched = Match(r'\s*(public|protected|private):', clean_lines.lines[linenum])
1952 if matched:
1953 # Issue warning if the line before public/protected/private was
1954 # not a blank line, but don't do this if the previous line contains
1955 # "class" or "struct". This can happen two ways:
1956 # - We are at the beginning of the class.
1957 # - We are forward-declaring an inner class that is semantically
1958 # private, but needed to be public for implementation reasons.
1959 prev_line = clean_lines.lines[linenum - 1]
1960 if (not IsBlankLine(prev_line) and
1961 not Search(r'\b(class|struct)\b', prev_line)):
1962 # Try a bit harder to find the beginning of the class. This is to
1963 # account for multi-line base-specifier lists, e.g.:
1964 # class Derived
1965 # : public Base {
1966 end_class_head = class_info.linenum
1967 for i in range(class_info.linenum, linenum):
1968 if Search(r'\{\s*$', clean_lines.lines[i]):
1969 end_class_head = i
1970 break
1971 if end_class_head < linenum - 1:
1972 error(filename, linenum, 'whitespace/blank_line', 3,
1973 '"%s:" should be preceded by a blank line' % matched.group(1))
1974
1975
Brian Carlstrom59848da2011-07-23 20:35:19 -07001976def GetPreviousNonBlankLine(clean_lines, linenum):
1977 """Return the most recent non-blank line and its line number.
1978
1979 Args:
1980 clean_lines: A CleansedLines instance containing the file contents.
1981 linenum: The number of the line to check.
1982
1983 Returns:
1984 A tuple with two elements. The first element is the contents of the last
1985 non-blank line before the current line, or the empty string if this is the
1986 first non-blank line. The second is the line number of that line, or -1
1987 if this is the first non-blank line.
1988 """
1989
1990 prevlinenum = linenum - 1
1991 while prevlinenum >= 0:
1992 prevline = clean_lines.elided[prevlinenum]
1993 if not IsBlankLine(prevline): # if not a blank line...
1994 return (prevline, prevlinenum)
1995 prevlinenum -= 1
1996 return ('', -1)
1997
1998
1999def CheckBraces(filename, clean_lines, linenum, error):
2000 """Looks for misplaced braces (e.g. at the end of line).
2001
2002 Args:
2003 filename: The name of the current file.
2004 clean_lines: A CleansedLines instance containing the file.
2005 linenum: The number of the line to check.
2006 error: The function to call with any errors found.
2007 """
2008
2009 line = clean_lines.elided[linenum] # get rid of comments and strings
2010
2011 if Match(r'\s*{\s*$', line):
2012 # We allow an open brace to start a line in the case where someone
2013 # is using braces in a block to explicitly create a new scope,
2014 # which is commonly used to control the lifetime of
2015 # stack-allocated variables. We don't detect this perfectly: we
2016 # just don't complain if the last non-whitespace character on the
2017 # previous non-blank line is ';', ':', '{', or '}'.
2018 prevline = GetPreviousNonBlankLine(clean_lines, linenum)[0]
2019 if not Search(r'[;:}{]\s*$', prevline):
2020 error(filename, linenum, 'whitespace/braces', 4,
2021 '{ should almost always be at the end of the previous line')
2022
2023 # An else clause should be on the same line as the preceding closing brace.
2024 if Match(r'\s*else\s*', line):
2025 prevline = GetPreviousNonBlankLine(clean_lines, linenum)[0]
2026 if Match(r'\s*}\s*$', prevline):
2027 error(filename, linenum, 'whitespace/newline', 4,
2028 'An else should appear on the same line as the preceding }')
2029
2030 # If braces come on one side of an else, they should be on both.
2031 # However, we have to worry about "else if" that spans multiple lines!
2032 if Search(r'}\s*else[^{]*$', line) or Match(r'[^}]*else\s*{', line):
2033 if Search(r'}\s*else if([^{]*)$', line): # could be multi-line if
2034 # find the ( after the if
2035 pos = line.find('else if')
2036 pos = line.find('(', pos)
2037 if pos > 0:
2038 (endline, _, endpos) = CloseExpression(clean_lines, linenum, pos)
2039 if endline[endpos:].find('{') == -1: # must be brace after if
2040 error(filename, linenum, 'readability/braces', 5,
2041 'If an else has a brace on one side, it should have it on both')
2042 else: # common case: else not followed by a multi-line if
2043 error(filename, linenum, 'readability/braces', 5,
2044 'If an else has a brace on one side, it should have it on both')
2045
2046 # Likewise, an else should never have the else clause on the same line
2047 if Search(r'\belse [^\s{]', line) and not Search(r'\belse if\b', line):
2048 error(filename, linenum, 'whitespace/newline', 4,
2049 'Else clause should never be on same line as else (use 2 lines)')
2050
2051 # In the same way, a do/while should never be on one line
2052 if Match(r'\s*do [^\s{]', line):
2053 error(filename, linenum, 'whitespace/newline', 4,
2054 'do/while clauses should not be on a single line')
2055
2056 # Braces shouldn't be followed by a ; unless they're defining a struct
2057 # or initializing an array.
2058 # We can't tell in general, but we can for some common cases.
2059 prevlinenum = linenum
2060 while True:
2061 (prevline, prevlinenum) = GetPreviousNonBlankLine(clean_lines, prevlinenum)
2062 if Match(r'\s+{.*}\s*;', line) and not prevline.count(';'):
2063 line = prevline + line
2064 else:
2065 break
2066 if (Search(r'{.*}\s*;', line) and
2067 line.count('{') == line.count('}') and
2068 not Search(r'struct|class|enum|\s*=\s*{', line)):
2069 error(filename, linenum, 'readability/braces', 4,
2070 "You don't need a ; after a }")
2071
2072
2073def ReplaceableCheck(operator, macro, line):
2074 """Determine whether a basic CHECK can be replaced with a more specific one.
2075
2076 For example suggest using CHECK_EQ instead of CHECK(a == b) and
2077 similarly for CHECK_GE, CHECK_GT, CHECK_LE, CHECK_LT, CHECK_NE.
2078
2079 Args:
2080 operator: The C++ operator used in the CHECK.
2081 macro: The CHECK or EXPECT macro being called.
2082 line: The current source line.
2083
2084 Returns:
2085 True if the CHECK can be replaced with a more specific one.
2086 """
2087
2088 # This matches decimal and hex integers, strings, and chars (in that order).
2089 match_constant = r'([-+]?(\d+|0[xX][0-9a-fA-F]+)[lLuU]{0,3}|".*"|\'.*\')'
2090
2091 # Expression to match two sides of the operator with something that
2092 # looks like a literal, since CHECK(x == iterator) won't compile.
2093 # This means we can't catch all the cases where a more specific
2094 # CHECK is possible, but it's less annoying than dealing with
2095 # extraneous warnings.
2096 match_this = (r'\s*' + macro + r'\((\s*' +
2097 match_constant + r'\s*' + operator + r'[^<>].*|'
2098 r'.*[^<>]' + operator + r'\s*' + match_constant +
2099 r'\s*\))')
2100
2101 # Don't complain about CHECK(x == NULL) or similar because
2102 # CHECK_EQ(x, NULL) won't compile (requires a cast).
2103 # Also, don't complain about more complex boolean expressions
2104 # involving && or || such as CHECK(a == b || c == d).
2105 return Match(match_this, line) and not Search(r'NULL|&&|\|\|', line)
2106
2107
2108def CheckCheck(filename, clean_lines, linenum, error):
2109 """Checks the use of CHECK and EXPECT macros.
2110
2111 Args:
2112 filename: The name of the current file.
2113 clean_lines: A CleansedLines instance containing the file.
2114 linenum: The number of the line to check.
2115 error: The function to call with any errors found.
2116 """
2117
2118 # Decide the set of replacement macros that should be suggested
2119 raw_lines = clean_lines.raw_lines
2120 current_macro = ''
2121 for macro in _CHECK_MACROS:
2122 if raw_lines[linenum].find(macro) >= 0:
2123 current_macro = macro
2124 break
2125 if not current_macro:
2126 # Don't waste time here if line doesn't contain 'CHECK' or 'EXPECT'
2127 return
2128
2129 line = clean_lines.elided[linenum] # get rid of comments and strings
2130
2131 # Encourage replacing plain CHECKs with CHECK_EQ/CHECK_NE/etc.
2132 for operator in ['==', '!=', '>=', '>', '<=', '<']:
2133 if ReplaceableCheck(operator, current_macro, line):
2134 error(filename, linenum, 'readability/check', 2,
2135 'Consider using %s instead of %s(a %s b)' % (
2136 _CHECK_REPLACEMENT[current_macro][operator],
2137 current_macro, operator))
2138 break
2139
2140
2141def GetLineWidth(line):
2142 """Determines the width of the line in column positions.
2143
2144 Args:
2145 line: A string, which may be a Unicode string.
2146
2147 Returns:
2148 The width of the line in column positions, accounting for Unicode
2149 combining characters and wide characters.
2150 """
2151 if isinstance(line, unicode):
2152 width = 0
Elliott Hughesdb385702012-06-21 10:41:20 -07002153 for uc in unicodedata.normalize('NFC', line):
2154 if unicodedata.east_asian_width(uc) in ('W', 'F'):
Brian Carlstrom59848da2011-07-23 20:35:19 -07002155 width += 2
Elliott Hughesdb385702012-06-21 10:41:20 -07002156 elif not unicodedata.combining(uc):
Brian Carlstrom59848da2011-07-23 20:35:19 -07002157 width += 1
2158 return width
2159 else:
2160 return len(line)
2161
2162
Elliott Hughesdb385702012-06-21 10:41:20 -07002163def CheckStyle(filename, clean_lines, linenum, file_extension, class_state,
2164 error):
Brian Carlstrom59848da2011-07-23 20:35:19 -07002165 """Checks rules from the 'C++ style rules' section of cppguide.html.
2166
2167 Most of these rules are hard to test (naming, comment style), but we
2168 do what we can. In particular we check for 2-space indents, line lengths,
2169 tab usage, spaces inside code, etc.
2170
2171 Args:
2172 filename: The name of the current file.
2173 clean_lines: A CleansedLines instance containing the file.
2174 linenum: The number of the line to check.
2175 file_extension: The extension (without the dot) of the filename.
2176 error: The function to call with any errors found.
2177 """
2178
2179 raw_lines = clean_lines.raw_lines
2180 line = raw_lines[linenum]
2181
2182 if line.find('\t') != -1:
2183 error(filename, linenum, 'whitespace/tab', 1,
2184 'Tab found; better to use spaces')
2185
2186 # One or three blank spaces at the beginning of the line is weird; it's
2187 # hard to reconcile that with 2-space indents.
2188 # NOTE: here are the conditions rob pike used for his tests. Mine aren't
2189 # as sophisticated, but it may be worth becoming so: RLENGTH==initial_spaces
2190 # if(RLENGTH > 20) complain = 0;
2191 # if(match($0, " +(error|private|public|protected):")) complain = 0;
2192 # if(match(prev, "&& *$")) complain = 0;
2193 # if(match(prev, "\\|\\| *$")) complain = 0;
2194 # if(match(prev, "[\",=><] *$")) complain = 0;
2195 # if(match($0, " <<")) complain = 0;
2196 # if(match(prev, " +for \\(")) complain = 0;
2197 # if(prevodd && match(prevprev, " +for \\(")) complain = 0;
2198 initial_spaces = 0
2199 cleansed_line = clean_lines.elided[linenum]
2200 while initial_spaces < len(line) and line[initial_spaces] == ' ':
2201 initial_spaces += 1
2202 if line and line[-1].isspace():
2203 error(filename, linenum, 'whitespace/end_of_line', 4,
2204 'Line ends in whitespace. Consider deleting these extra spaces.')
2205 # There are certain situations we allow one space, notably for labels
2206 elif ((initial_spaces == 1 or initial_spaces == 3) and
2207 not Match(r'\s*\w+\s*:\s*$', cleansed_line)):
2208 error(filename, linenum, 'whitespace/indent', 3,
2209 'Weird number of spaces at line-start. '
2210 'Are you using a 2-space indent?')
2211 # Labels should always be indented at least one space.
2212 elif not initial_spaces and line[:2] != '//' and Search(r'[^:]:\s*$',
2213 line):
2214 error(filename, linenum, 'whitespace/labels', 4,
2215 'Labels should always be indented at least one space. '
2216 'If this is a member-initializer list in a constructor or '
2217 'the base class list in a class definition, the colon should '
2218 'be on the following line.')
2219
2220
2221 # Check if the line is a header guard.
2222 is_header_guard = False
2223 if file_extension == 'h':
2224 cppvar = GetHeaderGuardCPPVariable(filename)
2225 if (line.startswith('#ifndef %s' % cppvar) or
2226 line.startswith('#define %s' % cppvar) or
2227 line.startswith('#endif // %s' % cppvar)):
2228 is_header_guard = True
2229 # #include lines and header guards can be long, since there's no clean way to
2230 # split them.
2231 #
2232 # URLs can be long too. It's possible to split these, but it makes them
2233 # harder to cut&paste.
Elliott Hughesdb385702012-06-21 10:41:20 -07002234 #
2235 # The "$Id:...$" comment may also get very long without it being the
2236 # developers fault.
Brian Carlstrom59848da2011-07-23 20:35:19 -07002237 if (not line.startswith('#include') and not is_header_guard and
Elliott Hughesdb385702012-06-21 10:41:20 -07002238 not Match(r'^\s*//.*http(s?)://\S*$', line) and
2239 not Match(r'^// \$Id:.*#[0-9]+ \$$', line)):
Brian Carlstrom59848da2011-07-23 20:35:19 -07002240 line_width = GetLineWidth(line)
2241 if line_width > 100:
2242 error(filename, linenum, 'whitespace/line_length', 4,
2243 'Lines should very rarely be longer than 100 characters')
2244 elif line_width > 80:
2245 error(filename, linenum, 'whitespace/line_length', 2,
2246 'Lines should be <= 80 characters long')
2247
2248 if (cleansed_line.count(';') > 1 and
2249 # for loops are allowed two ;'s (and may run over two lines).
2250 cleansed_line.find('for') == -1 and
2251 (GetPreviousNonBlankLine(clean_lines, linenum)[0].find('for') == -1 or
2252 GetPreviousNonBlankLine(clean_lines, linenum)[0].find(';') != -1) and
2253 # It's ok to have many commands in a switch case that fits in 1 line
2254 not ((cleansed_line.find('case ') != -1 or
2255 cleansed_line.find('default:') != -1) and
2256 cleansed_line.find('break;') != -1)):
2257 error(filename, linenum, 'whitespace/newline', 4,
2258 'More than one command on the same line')
2259
2260 # Some more style checks
2261 CheckBraces(filename, clean_lines, linenum, error)
2262 CheckSpacing(filename, clean_lines, linenum, error)
2263 CheckCheck(filename, clean_lines, linenum, error)
Elliott Hughesdb385702012-06-21 10:41:20 -07002264 if class_state and class_state.classinfo_stack:
2265 CheckSectionSpacing(filename, clean_lines,
2266 class_state.classinfo_stack[-1], linenum, error)
Brian Carlstrom59848da2011-07-23 20:35:19 -07002267
2268
2269_RE_PATTERN_INCLUDE_NEW_STYLE = re.compile(r'#include +"[^/]+\.h"')
2270_RE_PATTERN_INCLUDE = re.compile(r'^\s*#\s*include\s*([<"])([^>"]*)[>"].*$')
2271# Matches the first component of a filename delimited by -s and _s. That is:
2272# _RE_FIRST_COMPONENT.match('foo').group(0) == 'foo'
2273# _RE_FIRST_COMPONENT.match('foo.cc').group(0) == 'foo'
2274# _RE_FIRST_COMPONENT.match('foo-bar_baz.cc').group(0) == 'foo'
2275# _RE_FIRST_COMPONENT.match('foo_bar-baz.cc').group(0) == 'foo'
2276_RE_FIRST_COMPONENT = re.compile(r'^[^-_.]+')
2277
2278
2279def _DropCommonSuffixes(filename):
2280 """Drops common suffixes like _test.cc or -inl.h from filename.
2281
2282 For example:
2283 >>> _DropCommonSuffixes('foo/foo-inl.h')
2284 'foo/foo'
2285 >>> _DropCommonSuffixes('foo/bar/foo.cc')
2286 'foo/bar/foo'
2287 >>> _DropCommonSuffixes('foo/foo_internal.h')
2288 'foo/foo'
2289 >>> _DropCommonSuffixes('foo/foo_unusualinternal.h')
2290 'foo/foo_unusualinternal'
2291
2292 Args:
2293 filename: The input filename.
2294
2295 Returns:
2296 The filename with the common suffix removed.
2297 """
2298 for suffix in ('test.cc', 'regtest.cc', 'unittest.cc',
2299 'inl.h', 'impl.h', 'internal.h'):
2300 if (filename.endswith(suffix) and len(filename) > len(suffix) and
2301 filename[-len(suffix) - 1] in ('-', '_')):
2302 return filename[:-len(suffix) - 1]
2303 return os.path.splitext(filename)[0]
2304
2305
2306def _IsTestFilename(filename):
2307 """Determines if the given filename has a suffix that identifies it as a test.
2308
2309 Args:
2310 filename: The input filename.
2311
2312 Returns:
2313 True if 'filename' looks like a test, False otherwise.
2314 """
2315 if (filename.endswith('_test.cc') or
2316 filename.endswith('_unittest.cc') or
2317 filename.endswith('_regtest.cc')):
2318 return True
2319 else:
2320 return False
2321
2322
2323def _ClassifyInclude(fileinfo, include, is_system):
2324 """Figures out what kind of header 'include' is.
2325
2326 Args:
2327 fileinfo: The current file cpplint is running over. A FileInfo instance.
2328 include: The path to a #included file.
2329 is_system: True if the #include used <> rather than "".
2330
2331 Returns:
2332 One of the _XXX_HEADER constants.
2333
2334 For example:
2335 >>> _ClassifyInclude(FileInfo('foo/foo.cc'), 'stdio.h', True)
2336 _C_SYS_HEADER
2337 >>> _ClassifyInclude(FileInfo('foo/foo.cc'), 'string', True)
2338 _CPP_SYS_HEADER
2339 >>> _ClassifyInclude(FileInfo('foo/foo.cc'), 'foo/foo.h', False)
2340 _LIKELY_MY_HEADER
2341 >>> _ClassifyInclude(FileInfo('foo/foo_unknown_extension.cc'),
2342 ... 'bar/foo_other_ext.h', False)
2343 _POSSIBLE_MY_HEADER
2344 >>> _ClassifyInclude(FileInfo('foo/foo.cc'), 'foo/bar.h', False)
2345 _OTHER_HEADER
2346 """
2347 # This is a list of all standard c++ header files, except
2348 # those already checked for above.
2349 is_stl_h = include in _STL_HEADERS
2350 is_cpp_h = is_stl_h or include in _CPP_HEADERS
2351
2352 if is_system:
2353 if is_cpp_h:
2354 return _CPP_SYS_HEADER
2355 else:
2356 return _C_SYS_HEADER
2357
2358 # If the target file and the include we're checking share a
2359 # basename when we drop common extensions, and the include
2360 # lives in . , then it's likely to be owned by the target file.
2361 target_dir, target_base = (
2362 os.path.split(_DropCommonSuffixes(fileinfo.RepositoryName())))
2363 include_dir, include_base = os.path.split(_DropCommonSuffixes(include))
2364 if target_base == include_base and (
2365 include_dir == target_dir or
2366 include_dir == os.path.normpath(target_dir + '/../public')):
2367 return _LIKELY_MY_HEADER
2368
2369 # If the target and include share some initial basename
2370 # component, it's possible the target is implementing the
2371 # include, so it's allowed to be first, but we'll never
2372 # complain if it's not there.
2373 target_first_component = _RE_FIRST_COMPONENT.match(target_base)
2374 include_first_component = _RE_FIRST_COMPONENT.match(include_base)
2375 if (target_first_component and include_first_component and
2376 target_first_component.group(0) ==
2377 include_first_component.group(0)):
2378 return _POSSIBLE_MY_HEADER
2379
2380 return _OTHER_HEADER
2381
2382
2383
2384def CheckIncludeLine(filename, clean_lines, linenum, include_state, error):
2385 """Check rules that are applicable to #include lines.
2386
2387 Strings on #include lines are NOT removed from elided line, to make
2388 certain tasks easier. However, to prevent false positives, checks
2389 applicable to #include lines in CheckLanguage must be put here.
2390
2391 Args:
2392 filename: The name of the current file.
2393 clean_lines: A CleansedLines instance containing the file.
2394 linenum: The number of the line to check.
2395 include_state: An _IncludeState instance in which the headers are inserted.
2396 error: The function to call with any errors found.
2397 """
2398 fileinfo = FileInfo(filename)
2399
2400 line = clean_lines.lines[linenum]
2401
2402 # "include" should use the new style "foo/bar.h" instead of just "bar.h"
2403 if _RE_PATTERN_INCLUDE_NEW_STYLE.search(line):
2404 error(filename, linenum, 'build/include', 4,
2405 'Include the directory when naming .h files')
2406
2407 # we shouldn't include a file more than once. actually, there are a
2408 # handful of instances where doing so is okay, but in general it's
2409 # not.
2410 match = _RE_PATTERN_INCLUDE.search(line)
2411 if match:
2412 include = match.group(2)
2413 is_system = (match.group(1) == '<')
2414 if include in include_state:
2415 error(filename, linenum, 'build/include', 4,
2416 '"%s" already included at %s:%s' %
2417 (include, filename, include_state[include]))
2418 else:
2419 include_state[include] = linenum
2420
2421 # We want to ensure that headers appear in the right order:
2422 # 1) for foo.cc, foo.h (preferred location)
2423 # 2) c system files
2424 # 3) cpp system files
2425 # 4) for foo.cc, foo.h (deprecated location)
2426 # 5) other google headers
2427 #
2428 # We classify each include statement as one of those 5 types
2429 # using a number of techniques. The include_state object keeps
2430 # track of the highest type seen, and complains if we see a
2431 # lower type after that.
2432 error_message = include_state.CheckNextIncludeOrder(
2433 _ClassifyInclude(fileinfo, include, is_system))
2434 if error_message:
2435 error(filename, linenum, 'build/include_order', 4,
2436 '%s. Should be: %s.h, c system, c++ system, other.' %
2437 (error_message, fileinfo.BaseName()))
2438 if not include_state.IsInAlphabeticalOrder(include):
2439 error(filename, linenum, 'build/include_alpha', 4,
2440 'Include "%s" not in alphabetical order' % include)
2441
2442 # Look for any of the stream classes that are part of standard C++.
2443 match = _RE_PATTERN_INCLUDE.match(line)
2444 if match:
2445 include = match.group(2)
2446 if Match(r'(f|ind|io|i|o|parse|pf|stdio|str|)?stream$', include):
2447 # Many unit tests use cout, so we exempt them.
2448 if not _IsTestFilename(filename):
2449 error(filename, linenum, 'readability/streams', 3,
2450 'Streams are highly discouraged.')
2451
Elliott Hughesdb385702012-06-21 10:41:20 -07002452
2453def _GetTextInside(text, start_pattern):
2454 """Retrieves all the text between matching open and close parentheses.
2455
2456 Given a string of lines and a regular expression string, retrieve all the text
2457 following the expression and between opening punctuation symbols like
2458 (, [, or {, and the matching close-punctuation symbol. This properly nested
2459 occurrences of the punctuations, so for the text like
2460 printf(a(), b(c()));
2461 a call to _GetTextInside(text, r'printf\(') will return 'a(), b(c())'.
2462 start_pattern must match string having an open punctuation symbol at the end.
2463
2464 Args:
2465 text: The lines to extract text. Its comments and strings must be elided.
2466 It can be single line and can span multiple lines.
2467 start_pattern: The regexp string indicating where to start extracting
2468 the text.
2469 Returns:
2470 The extracted text.
2471 None if either the opening string or ending punctuation could not be found.
2472 """
2473 # TODO(sugawarayu): Audit cpplint.py to see what places could be profitably
2474 # rewritten to use _GetTextInside (and use inferior regexp matching today).
2475
2476 # Give opening punctuations to get the matching close-punctuations.
2477 matching_punctuation = {'(': ')', '{': '}', '[': ']'}
2478 closing_punctuation = set(matching_punctuation.itervalues())
2479
2480 # Find the position to start extracting text.
2481 match = re.search(start_pattern, text, re.M)
2482 if not match: # start_pattern not found in text.
2483 return None
2484 start_position = match.end(0)
2485
2486 assert start_position > 0, (
2487 'start_pattern must ends with an opening punctuation.')
2488 assert text[start_position - 1] in matching_punctuation, (
2489 'start_pattern must ends with an opening punctuation.')
2490 # Stack of closing punctuations we expect to have in text after position.
2491 punctuation_stack = [matching_punctuation[text[start_position - 1]]]
2492 position = start_position
2493 while punctuation_stack and position < len(text):
2494 if text[position] == punctuation_stack[-1]:
2495 punctuation_stack.pop()
2496 elif text[position] in closing_punctuation:
2497 # A closing punctuation without matching opening punctuations.
2498 return None
2499 elif text[position] in matching_punctuation:
2500 punctuation_stack.append(matching_punctuation[text[position]])
2501 position += 1
2502 if punctuation_stack:
2503 # Opening punctuations left without matching close-punctuations.
2504 return None
2505 # punctuations match.
2506 return text[start_position:position - 1]
2507
2508
Brian Carlstrom59848da2011-07-23 20:35:19 -07002509def CheckLanguage(filename, clean_lines, linenum, file_extension, include_state,
2510 error):
2511 """Checks rules from the 'C++ language rules' section of cppguide.html.
2512
2513 Some of these rules are hard to test (function overloading, using
2514 uint32 inappropriately), but we do the best we can.
2515
2516 Args:
2517 filename: The name of the current file.
2518 clean_lines: A CleansedLines instance containing the file.
2519 linenum: The number of the line to check.
2520 file_extension: The extension (without the dot) of the filename.
2521 include_state: An _IncludeState instance in which the headers are inserted.
2522 error: The function to call with any errors found.
2523 """
2524 # If the line is empty or consists of entirely a comment, no need to
2525 # check it.
2526 line = clean_lines.elided[linenum]
2527 if not line:
2528 return
2529
2530 match = _RE_PATTERN_INCLUDE.search(line)
2531 if match:
2532 CheckIncludeLine(filename, clean_lines, linenum, include_state, error)
2533 return
2534
2535 # Create an extended_line, which is the concatenation of the current and
2536 # next lines, for more effective checking of code that may span more than one
2537 # line.
2538 if linenum + 1 < clean_lines.NumLines():
2539 extended_line = line + clean_lines.elided[linenum + 1]
2540 else:
2541 extended_line = line
2542
2543 # Make Windows paths like Unix.
2544 fullname = os.path.abspath(filename).replace('\\', '/')
2545
2546 # TODO(unknown): figure out if they're using default arguments in fn proto.
2547
2548 # Check for non-const references in functions. This is tricky because &
2549 # is also used to take the address of something. We allow <> for templates,
2550 # (ignoring whatever is between the braces) and : for classes.
2551 # These are complicated re's. They try to capture the following:
2552 # paren (for fn-prototype start), typename, &, varname. For the const
2553 # version, we're willing for const to be before typename or after
Elliott Hughesdb385702012-06-21 10:41:20 -07002554 # Don't check the implementation on same line.
Brian Carlstrom59848da2011-07-23 20:35:19 -07002555 fnline = line.split('{', 1)[0]
2556 if (len(re.findall(r'\([^()]*\b(?:[\w:]|<[^()]*>)+(\s?&|&\s?)\w+', fnline)) >
2557 len(re.findall(r'\([^()]*\bconst\s+(?:typename\s+)?(?:struct\s+)?'
2558 r'(?:[\w:]|<[^()]*>)+(\s?&|&\s?)\w+', fnline)) +
2559 len(re.findall(r'\([^()]*\b(?:[\w:]|<[^()]*>)+\s+const(\s?&|&\s?)[\w]+',
2560 fnline))):
2561
2562 # We allow non-const references in a few standard places, like functions
2563 # called "swap()" or iostream operators like "<<" or ">>".
2564 if not Search(
2565 r'(swap|Swap|operator[<>][<>])\s*\(\s*(?:[\w:]|<.*>)+\s*&',
2566 fnline):
2567 error(filename, linenum, 'runtime/references', 2,
2568 'Is this a non-const reference? '
2569 'If so, make const or use a pointer.')
2570
2571 # Check to see if they're using an conversion function cast.
2572 # I just try to capture the most common basic types, though there are more.
2573 # Parameterless conversion functions, such as bool(), are allowed as they are
2574 # probably a member operator declaration or default constructor.
2575 match = Search(
2576 r'(\bnew\s+)?\b' # Grab 'new' operator, if it's there
Elliott Hughes08fc03a2012-06-26 17:34:00 -07002577 r'(int|float|double|bool|char|u?int(8|16|32|64)_t)\([^)]', line) # TODO(enh): upstream change to handle all stdint types.
Brian Carlstrom59848da2011-07-23 20:35:19 -07002578 if match:
2579 # gMock methods are defined using some variant of MOCK_METHODx(name, type)
2580 # where type may be float(), int(string), etc. Without context they are
Elliott Hughesdb385702012-06-21 10:41:20 -07002581 # virtually indistinguishable from int(x) casts. Likewise, gMock's
2582 # MockCallback takes a template parameter of the form return_type(arg_type),
2583 # which looks much like the cast we're trying to detect.
Brian Carlstrom59848da2011-07-23 20:35:19 -07002584 if (match.group(1) is None and # If new operator, then this isn't a cast
Elliott Hughesdb385702012-06-21 10:41:20 -07002585 not (Match(r'^\s*MOCK_(CONST_)?METHOD\d+(_T)?\(', line) or
2586 Match(r'^\s*MockCallback<.*>', line))):
Brian Carlstrom59848da2011-07-23 20:35:19 -07002587 error(filename, linenum, 'readability/casting', 4,
2588 'Using deprecated casting style. '
2589 'Use static_cast<%s>(...) instead' %
2590 match.group(2))
2591
2592 CheckCStyleCast(filename, linenum, line, clean_lines.raw_lines[linenum],
2593 'static_cast',
Elliott Hughes08fc03a2012-06-26 17:34:00 -07002594 r'\((int|float|double|bool|char|u?int(8|16|32|64))\)', error) # TODO(enh): upstream change to handle all stdint types.
Elliott Hughesdb385702012-06-21 10:41:20 -07002595
2596 # This doesn't catch all cases. Consider (const char * const)"hello".
2597 #
2598 # (char *) "foo" should always be a const_cast (reinterpret_cast won't
2599 # compile).
2600 if CheckCStyleCast(filename, linenum, line, clean_lines.raw_lines[linenum],
2601 'const_cast', r'\((char\s?\*+\s?)\)\s*"', error):
2602 pass
2603 else:
2604 # Check pointer casts for other than string constants
2605 CheckCStyleCast(filename, linenum, line, clean_lines.raw_lines[linenum],
2606 'reinterpret_cast', r'\((\w+\s?\*+\s?)\)', error)
Brian Carlstrom59848da2011-07-23 20:35:19 -07002607
2608 # In addition, we look for people taking the address of a cast. This
2609 # is dangerous -- casts can assign to temporaries, so the pointer doesn't
2610 # point where you think.
2611 if Search(
2612 r'(&\([^)]+\)[\w(])|(&(static|dynamic|reinterpret)_cast\b)', line):
2613 error(filename, linenum, 'runtime/casting', 4,
2614 ('Are you taking an address of a cast? '
2615 'This is dangerous: could be a temp var. '
2616 'Take the address before doing the cast, rather than after'))
2617
2618 # Check for people declaring static/global STL strings at the top level.
2619 # This is dangerous because the C++ language does not guarantee that
2620 # globals with constructors are initialized before the first access.
2621 match = Match(
2622 r'((?:|static +)(?:|const +))string +([a-zA-Z0-9_:]+)\b(.*)',
2623 line)
2624 # Make sure it's not a function.
2625 # Function template specialization looks like: "string foo<Type>(...".
2626 # Class template definitions look like: "string Foo<Type>::Method(...".
2627 if match and not Match(r'\s*(<.*>)?(::[a-zA-Z0-9_]+)?\s*\(([^"]|$)',
2628 match.group(3)):
2629 error(filename, linenum, 'runtime/string', 4,
2630 'For a static/global string constant, use a C style string instead: '
2631 '"%schar %s[]".' %
2632 (match.group(1), match.group(2)))
2633
2634 # Check that we're not using RTTI outside of testing code.
2635 if Search(r'\bdynamic_cast<', line) and not _IsTestFilename(filename):
2636 error(filename, linenum, 'runtime/rtti', 5,
2637 'Do not use dynamic_cast<>. If you need to cast within a class '
2638 "hierarchy, use static_cast<> to upcast. Google doesn't support "
2639 'RTTI.')
2640
2641 if Search(r'\b([A-Za-z0-9_]*_)\(\1\)', line):
2642 error(filename, linenum, 'runtime/init', 4,
2643 'You seem to be initializing a member variable with itself.')
2644
2645 if file_extension == 'h':
2646 # TODO(unknown): check that 1-arg constructors are explicit.
2647 # How to tell it's a constructor?
2648 # (handled in CheckForNonStandardConstructs for now)
2649 # TODO(unknown): check that classes have DISALLOW_EVIL_CONSTRUCTORS
2650 # (level 1 error)
2651 pass
2652
2653 # Check if people are using the verboten C basic types. The only exception
2654 # we regularly allow is "unsigned short port" for port.
2655 if Search(r'\bshort port\b', line):
2656 if not Search(r'\bunsigned short port\b', line):
2657 error(filename, linenum, 'runtime/int', 4,
2658 'Use "unsigned short" for ports, not "short"')
2659 else:
2660 match = Search(r'\b(short|long(?! +double)|long long)\b', line)
2661 if match:
2662 error(filename, linenum, 'runtime/int', 4,
2663 'Use int16/int64/etc, rather than the C type %s' % match.group(1))
2664
2665 # When snprintf is used, the second argument shouldn't be a literal.
2666 match = Search(r'snprintf\s*\(([^,]*),\s*([0-9]*)\s*,', line)
2667 if match and match.group(2) != '0':
2668 # If 2nd arg is zero, snprintf is used to calculate size.
2669 error(filename, linenum, 'runtime/printf', 3,
2670 'If you can, use sizeof(%s) instead of %s as the 2nd arg '
2671 'to snprintf.' % (match.group(1), match.group(2)))
2672
2673 # Check if some verboten C functions are being used.
2674 if Search(r'\bsprintf\b', line):
2675 error(filename, linenum, 'runtime/printf', 5,
2676 'Never use sprintf. Use snprintf instead.')
2677 match = Search(r'\b(strcpy|strcat)\b', line)
2678 if match:
2679 error(filename, linenum, 'runtime/printf', 4,
2680 'Almost always, snprintf is better than %s' % match.group(1))
2681
2682 if Search(r'\bsscanf\b', line):
2683 error(filename, linenum, 'runtime/printf', 1,
2684 'sscanf can be ok, but is slow and can overflow buffers.')
2685
2686 # Check if some verboten operator overloading is going on
2687 # TODO(unknown): catch out-of-line unary operator&:
2688 # class X {};
2689 # int operator&(const X& x) { return 42; } // unary operator&
2690 # The trick is it's hard to tell apart from binary operator&:
2691 # class Y { int operator&(const Y& x) { return 23; } }; // binary operator&
2692 if Search(r'\boperator\s*&\s*\(\s*\)', line):
2693 error(filename, linenum, 'runtime/operator', 4,
2694 'Unary operator& is dangerous. Do not use it.')
2695
2696 # Check for suspicious usage of "if" like
2697 # } if (a == b) {
2698 if Search(r'\}\s*if\s*\(', line):
2699 error(filename, linenum, 'readability/braces', 4,
2700 'Did you mean "else if"? If not, start a new line for "if".')
2701
2702 # Check for potential format string bugs like printf(foo).
2703 # We constrain the pattern not to pick things like DocidForPrintf(foo).
2704 # Not perfect but it can catch printf(foo.c_str()) and printf(foo->c_str())
Elliott Hughesdb385702012-06-21 10:41:20 -07002705 # TODO(sugawarayu): Catch the following case. Need to change the calling
2706 # convention of the whole function to process multiple line to handle it.
2707 # printf(
2708 # boy_this_is_a_really_long_variable_that_cannot_fit_on_the_prev_line);
2709 printf_args = _GetTextInside(line, r'(?i)\b(string)?printf\s*\(')
2710 if printf_args:
2711 match = Match(r'([\w.\->()]+)$', printf_args)
2712 if match:
2713 function_name = re.search(r'\b((?:string)?printf)\s*\(',
2714 line, re.I).group(1)
2715 error(filename, linenum, 'runtime/printf', 4,
2716 'Potential format string bug. Do %s("%%s", %s) instead.'
2717 % (function_name, match.group(1)))
Brian Carlstrom59848da2011-07-23 20:35:19 -07002718
2719 # Check for potential memset bugs like memset(buf, sizeof(buf), 0).
2720 match = Search(r'memset\s*\(([^,]*),\s*([^,]*),\s*0\s*\)', line)
2721 if match and not Match(r"^''|-?[0-9]+|0x[0-9A-Fa-f]$", match.group(2)):
2722 error(filename, linenum, 'runtime/memset', 4,
2723 'Did you mean "memset(%s, 0, %s)"?'
2724 % (match.group(1), match.group(2)))
2725
2726 if Search(r'\busing namespace\b', line):
2727 error(filename, linenum, 'build/namespaces', 5,
2728 'Do not use namespace using-directives. '
2729 'Use using-declarations instead.')
2730
2731 # Detect variable-length arrays.
2732 match = Match(r'\s*(.+::)?(\w+) [a-z]\w*\[(.+)];', line)
2733 if (match and match.group(2) != 'return' and match.group(2) != 'delete' and
2734 match.group(3).find(']') == -1):
2735 # Split the size using space and arithmetic operators as delimiters.
2736 # If any of the resulting tokens are not compile time constants then
2737 # report the error.
2738 tokens = re.split(r'\s|\+|\-|\*|\/|<<|>>]', match.group(3))
2739 is_const = True
2740 skip_next = False
2741 for tok in tokens:
2742 if skip_next:
2743 skip_next = False
2744 continue
2745
2746 if Search(r'sizeof\(.+\)', tok): continue
2747 if Search(r'arraysize\(\w+\)', tok): continue
2748
2749 tok = tok.lstrip('(')
2750 tok = tok.rstrip(')')
2751 if not tok: continue
2752 if Match(r'\d+', tok): continue
2753 if Match(r'0[xX][0-9a-fA-F]+', tok): continue
2754 if Match(r'k[A-Z0-9]\w*', tok): continue
2755 if Match(r'(.+::)?k[A-Z0-9]\w*', tok): continue
2756 if Match(r'(.+::)?[A-Z][A-Z0-9_]*', tok): continue
2757 # A catch all for tricky sizeof cases, including 'sizeof expression',
2758 # 'sizeof(*type)', 'sizeof(const type)', 'sizeof(struct StructName)'
Elliott Hughesdb385702012-06-21 10:41:20 -07002759 # requires skipping the next token because we split on ' ' and '*'.
Brian Carlstrom59848da2011-07-23 20:35:19 -07002760 if tok.startswith('sizeof'):
2761 skip_next = True
2762 continue
2763 is_const = False
2764 break
2765 if not is_const:
2766 error(filename, linenum, 'runtime/arrays', 1,
2767 'Do not use variable-length arrays. Use an appropriately named '
2768 "('k' followed by CamelCase) compile-time constant for the size.")
2769
2770 # If DISALLOW_EVIL_CONSTRUCTORS, DISALLOW_COPY_AND_ASSIGN, or
2771 # DISALLOW_IMPLICIT_CONSTRUCTORS is present, then it should be the last thing
2772 # in the class declaration.
2773 match = Match(
2774 (r'\s*'
2775 r'(DISALLOW_(EVIL_CONSTRUCTORS|COPY_AND_ASSIGN|IMPLICIT_CONSTRUCTORS))'
2776 r'\(.*\);$'),
2777 line)
2778 if match and linenum + 1 < clean_lines.NumLines():
2779 next_line = clean_lines.elided[linenum + 1]
Elliott Hughesdb385702012-06-21 10:41:20 -07002780 # We allow some, but not all, declarations of variables to be present
2781 # in the statement that defines the class. The [\w\*,\s]* fragment of
2782 # the regular expression below allows users to declare instances of
2783 # the class or pointers to instances, but not less common types such
2784 # as function pointers or arrays. It's a tradeoff between allowing
2785 # reasonable code and avoiding trying to parse more C++ using regexps.
2786 if not Search(r'^\s*}[\w\*,\s]*;', next_line):
Brian Carlstrom59848da2011-07-23 20:35:19 -07002787 error(filename, linenum, 'readability/constructors', 3,
2788 match.group(1) + ' should be the last thing in the class')
2789
2790 # Check for use of unnamed namespaces in header files. Registration
2791 # macros are typically OK, so we allow use of "namespace {" on lines
2792 # that end with backslashes.
2793 if (file_extension == 'h'
2794 and Search(r'\bnamespace\s*{', line)
2795 and line[-1] != '\\'):
2796 error(filename, linenum, 'build/namespaces', 4,
2797 'Do not use unnamed namespaces in header files. See '
2798 'http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Namespaces'
2799 ' for more information.')
2800
2801
2802def CheckCStyleCast(filename, linenum, line, raw_line, cast_type, pattern,
2803 error):
2804 """Checks for a C-style cast by looking for the pattern.
2805
2806 This also handles sizeof(type) warnings, due to similarity of content.
2807
2808 Args:
2809 filename: The name of the current file.
2810 linenum: The number of the line to check.
2811 line: The line of code to check.
2812 raw_line: The raw line of code to check, with comments.
2813 cast_type: The string for the C++ cast to recommend. This is either
Elliott Hughesdb385702012-06-21 10:41:20 -07002814 reinterpret_cast, static_cast, or const_cast, depending.
Brian Carlstrom59848da2011-07-23 20:35:19 -07002815 pattern: The regular expression used to find C-style casts.
2816 error: The function to call with any errors found.
Elliott Hughesdb385702012-06-21 10:41:20 -07002817
2818 Returns:
2819 True if an error was emitted.
2820 False otherwise.
Brian Carlstrom59848da2011-07-23 20:35:19 -07002821 """
2822 match = Search(pattern, line)
2823 if not match:
Elliott Hughesdb385702012-06-21 10:41:20 -07002824 return False
Brian Carlstrom59848da2011-07-23 20:35:19 -07002825
2826 # e.g., sizeof(int)
2827 sizeof_match = Match(r'.*sizeof\s*$', line[0:match.start(1) - 1])
2828 if sizeof_match:
2829 error(filename, linenum, 'runtime/sizeof', 1,
2830 'Using sizeof(type). Use sizeof(varname) instead if possible')
Elliott Hughesdb385702012-06-21 10:41:20 -07002831 return True
Brian Carlstrom59848da2011-07-23 20:35:19 -07002832
2833 remainder = line[match.end(0):]
2834
2835 # The close paren is for function pointers as arguments to a function.
2836 # eg, void foo(void (*bar)(int));
2837 # The semicolon check is a more basic function check; also possibly a
2838 # function pointer typedef.
2839 # eg, void foo(int); or void foo(int) const;
2840 # The equals check is for function pointer assignment.
2841 # eg, void *(*foo)(int) = ...
Elliott Hughesdb385702012-06-21 10:41:20 -07002842 # The > is for MockCallback<...> ...
Brian Carlstrom59848da2011-07-23 20:35:19 -07002843 #
2844 # Right now, this will only catch cases where there's a single argument, and
2845 # it's unnamed. It should probably be expanded to check for multiple
2846 # arguments with some unnamed.
Elliott Hughesdb385702012-06-21 10:41:20 -07002847 function_match = Match(r'\s*(\)|=|(const)?\s*(;|\{|throw\(\)|>))', remainder)
Brian Carlstrom59848da2011-07-23 20:35:19 -07002848 if function_match:
2849 if (not function_match.group(3) or
2850 function_match.group(3) == ';' or
Elliott Hughesdb385702012-06-21 10:41:20 -07002851 ('MockCallback<' not in raw_line and
2852 '/*' not in raw_line)):
Brian Carlstrom59848da2011-07-23 20:35:19 -07002853 error(filename, linenum, 'readability/function', 3,
2854 'All parameters should be named in a function')
Elliott Hughesdb385702012-06-21 10:41:20 -07002855 return True
Brian Carlstrom59848da2011-07-23 20:35:19 -07002856
2857 # At this point, all that should be left is actual casts.
2858 error(filename, linenum, 'readability/casting', 4,
2859 'Using C-style cast. Use %s<%s>(...) instead' %
2860 (cast_type, match.group(1)))
2861
Elliott Hughesdb385702012-06-21 10:41:20 -07002862 return True
2863
Brian Carlstrom59848da2011-07-23 20:35:19 -07002864
2865_HEADERS_CONTAINING_TEMPLATES = (
2866 ('<deque>', ('deque',)),
2867 ('<functional>', ('unary_function', 'binary_function',
2868 'plus', 'minus', 'multiplies', 'divides', 'modulus',
2869 'negate',
2870 'equal_to', 'not_equal_to', 'greater', 'less',
2871 'greater_equal', 'less_equal',
2872 'logical_and', 'logical_or', 'logical_not',
2873 'unary_negate', 'not1', 'binary_negate', 'not2',
2874 'bind1st', 'bind2nd',
2875 'pointer_to_unary_function',
2876 'pointer_to_binary_function',
2877 'ptr_fun',
2878 'mem_fun_t', 'mem_fun', 'mem_fun1_t', 'mem_fun1_ref_t',
2879 'mem_fun_ref_t',
2880 'const_mem_fun_t', 'const_mem_fun1_t',
2881 'const_mem_fun_ref_t', 'const_mem_fun1_ref_t',
2882 'mem_fun_ref',
2883 )),
2884 ('<limits>', ('numeric_limits',)),
2885 ('<list>', ('list',)),
2886 ('<map>', ('map', 'multimap',)),
2887 ('<memory>', ('allocator',)),
2888 ('<queue>', ('queue', 'priority_queue',)),
2889 ('<set>', ('set', 'multiset',)),
2890 ('<stack>', ('stack',)),
2891 ('<string>', ('char_traits', 'basic_string',)),
2892 ('<utility>', ('pair',)),
2893 ('<vector>', ('vector',)),
2894
2895 # gcc extensions.
2896 # Note: std::hash is their hash, ::hash is our hash
2897 ('<hash_map>', ('hash_map', 'hash_multimap',)),
2898 ('<hash_set>', ('hash_set', 'hash_multiset',)),
2899 ('<slist>', ('slist',)),
2900 )
2901
Brian Carlstrom59848da2011-07-23 20:35:19 -07002902_RE_PATTERN_STRING = re.compile(r'\bstring\b')
2903
2904_re_pattern_algorithm_header = []
2905for _template in ('copy', 'max', 'min', 'min_element', 'sort', 'swap',
2906 'transform'):
2907 # Match max<type>(..., ...), max(..., ...), but not foo->max, foo.max or
2908 # type::max().
2909 _re_pattern_algorithm_header.append(
2910 (re.compile(r'[^>.]\b' + _template + r'(<.*?>)?\([^\)]'),
2911 _template,
2912 '<algorithm>'))
2913
2914_re_pattern_templates = []
2915for _header, _templates in _HEADERS_CONTAINING_TEMPLATES:
2916 for _template in _templates:
2917 _re_pattern_templates.append(
2918 (re.compile(r'(\<|\b)' + _template + r'\s*\<'),
2919 _template + '<>',
2920 _header))
2921
2922
2923def FilesBelongToSameModule(filename_cc, filename_h):
2924 """Check if these two filenames belong to the same module.
2925
2926 The concept of a 'module' here is a as follows:
2927 foo.h, foo-inl.h, foo.cc, foo_test.cc and foo_unittest.cc belong to the
2928 same 'module' if they are in the same directory.
2929 some/path/public/xyzzy and some/path/internal/xyzzy are also considered
2930 to belong to the same module here.
2931
2932 If the filename_cc contains a longer path than the filename_h, for example,
2933 '/absolute/path/to/base/sysinfo.cc', and this file would include
2934 'base/sysinfo.h', this function also produces the prefix needed to open the
2935 header. This is used by the caller of this function to more robustly open the
2936 header file. We don't have access to the real include paths in this context,
2937 so we need this guesswork here.
2938
2939 Known bugs: tools/base/bar.cc and base/bar.h belong to the same module
2940 according to this implementation. Because of this, this function gives
2941 some false positives. This should be sufficiently rare in practice.
2942
2943 Args:
2944 filename_cc: is the path for the .cc file
2945 filename_h: is the path for the header path
2946
2947 Returns:
2948 Tuple with a bool and a string:
2949 bool: True if filename_cc and filename_h belong to the same module.
2950 string: the additional prefix needed to open the header file.
2951 """
2952
2953 if not filename_cc.endswith('.cc'):
2954 return (False, '')
2955 filename_cc = filename_cc[:-len('.cc')]
2956 if filename_cc.endswith('_unittest'):
2957 filename_cc = filename_cc[:-len('_unittest')]
2958 elif filename_cc.endswith('_test'):
2959 filename_cc = filename_cc[:-len('_test')]
2960 filename_cc = filename_cc.replace('/public/', '/')
2961 filename_cc = filename_cc.replace('/internal/', '/')
2962
2963 if not filename_h.endswith('.h'):
2964 return (False, '')
2965 filename_h = filename_h[:-len('.h')]
2966 if filename_h.endswith('-inl'):
2967 filename_h = filename_h[:-len('-inl')]
2968 filename_h = filename_h.replace('/public/', '/')
2969 filename_h = filename_h.replace('/internal/', '/')
2970
2971 files_belong_to_same_module = filename_cc.endswith(filename_h)
2972 common_path = ''
2973 if files_belong_to_same_module:
2974 common_path = filename_cc[:-len(filename_h)]
2975 return files_belong_to_same_module, common_path
2976
2977
2978def UpdateIncludeState(filename, include_state, io=codecs):
2979 """Fill up the include_state with new includes found from the file.
2980
2981 Args:
2982 filename: the name of the header to read.
2983 include_state: an _IncludeState instance in which the headers are inserted.
2984 io: The io factory to use to read the file. Provided for testability.
2985
2986 Returns:
2987 True if a header was succesfully added. False otherwise.
2988 """
2989 headerfile = None
2990 try:
2991 headerfile = io.open(filename, 'r', 'utf8', 'replace')
2992 except IOError:
2993 return False
2994 linenum = 0
2995 for line in headerfile:
2996 linenum += 1
2997 clean_line = CleanseComments(line)
2998 match = _RE_PATTERN_INCLUDE.search(clean_line)
2999 if match:
3000 include = match.group(2)
3001 # The value formatting is cute, but not really used right now.
3002 # What matters here is that the key is in include_state.
3003 include_state.setdefault(include, '%s:%d' % (filename, linenum))
3004 return True
3005
3006
3007def CheckForIncludeWhatYouUse(filename, clean_lines, include_state, error,
3008 io=codecs):
3009 """Reports for missing stl includes.
3010
3011 This function will output warnings to make sure you are including the headers
3012 necessary for the stl containers and functions that you use. We only give one
3013 reason to include a header. For example, if you use both equal_to<> and
3014 less<> in a .h file, only one (the latter in the file) of these will be
3015 reported as a reason to include the <functional>.
3016
3017 Args:
3018 filename: The name of the current file.
3019 clean_lines: A CleansedLines instance containing the file.
3020 include_state: An _IncludeState instance.
3021 error: The function to call with any errors found.
3022 io: The IO factory to use to read the header file. Provided for unittest
3023 injection.
3024 """
3025 required = {} # A map of header name to linenumber and the template entity.
3026 # Example of required: { '<functional>': (1219, 'less<>') }
3027
3028 for linenum in xrange(clean_lines.NumLines()):
3029 line = clean_lines.elided[linenum]
3030 if not line or line[0] == '#':
3031 continue
3032
3033 # String is special -- it is a non-templatized type in STL.
Elliott Hughesdb385702012-06-21 10:41:20 -07003034 matched = _RE_PATTERN_STRING.search(line)
3035 if matched:
Brian Carlstrom59848da2011-07-23 20:35:19 -07003036 # Don't warn about strings in non-STL namespaces:
3037 # (We check only the first match per line; good enough.)
Elliott Hughesdb385702012-06-21 10:41:20 -07003038 prefix = line[:matched.start()]
Brian Carlstrom59848da2011-07-23 20:35:19 -07003039 if prefix.endswith('std::') or not prefix.endswith('::'):
3040 required['<string>'] = (linenum, 'string')
3041
3042 for pattern, template, header in _re_pattern_algorithm_header:
3043 if pattern.search(line):
3044 required[header] = (linenum, template)
3045
3046 # The following function is just a speed up, no semantics are changed.
3047 if not '<' in line: # Reduces the cpu time usage by skipping lines.
3048 continue
3049
3050 for pattern, template, header in _re_pattern_templates:
3051 if pattern.search(line):
3052 required[header] = (linenum, template)
3053
3054 # The policy is that if you #include something in foo.h you don't need to
3055 # include it again in foo.cc. Here, we will look at possible includes.
3056 # Let's copy the include_state so it is only messed up within this function.
3057 include_state = include_state.copy()
3058
3059 # Did we find the header for this file (if any) and succesfully load it?
3060 header_found = False
3061
3062 # Use the absolute path so that matching works properly.
Elliott Hughesdb385702012-06-21 10:41:20 -07003063 abs_filename = FileInfo(filename).FullName()
Brian Carlstrom59848da2011-07-23 20:35:19 -07003064
3065 # For Emacs's flymake.
3066 # If cpplint is invoked from Emacs's flymake, a temporary file is generated
3067 # by flymake and that file name might end with '_flymake.cc'. In that case,
3068 # restore original file name here so that the corresponding header file can be
3069 # found.
3070 # e.g. If the file name is 'foo_flymake.cc', we should search for 'foo.h'
3071 # instead of 'foo_flymake.h'
3072 abs_filename = re.sub(r'_flymake\.cc$', '.cc', abs_filename)
3073
3074 # include_state is modified during iteration, so we iterate over a copy of
3075 # the keys.
Elliott Hughesdb385702012-06-21 10:41:20 -07003076 header_keys = include_state.keys()
3077 for header in header_keys:
Brian Carlstrom59848da2011-07-23 20:35:19 -07003078 (same_module, common_path) = FilesBelongToSameModule(abs_filename, header)
3079 fullpath = common_path + header
3080 if same_module and UpdateIncludeState(fullpath, include_state, io):
3081 header_found = True
3082
3083 # If we can't find the header file for a .cc, assume it's because we don't
3084 # know where to look. In that case we'll give up as we're not sure they
3085 # didn't include it in the .h file.
3086 # TODO(unknown): Do a better job of finding .h files so we are confident that
3087 # not having the .h file means there isn't one.
3088 if filename.endswith('.cc') and not header_found:
3089 return
3090
3091 # All the lines have been processed, report the errors found.
3092 for required_header_unstripped in required:
3093 template = required[required_header_unstripped][1]
Brian Carlstrom59848da2011-07-23 20:35:19 -07003094 if required_header_unstripped.strip('<>"') not in include_state:
3095 error(filename, required[required_header_unstripped][0],
3096 'build/include_what_you_use', 4,
3097 'Add #include ' + required_header_unstripped + ' for ' + template)
3098
3099
Elliott Hughesdb385702012-06-21 10:41:20 -07003100_RE_PATTERN_EXPLICIT_MAKEPAIR = re.compile(r'\bmake_pair\s*<')
3101
3102
3103def CheckMakePairUsesDeduction(filename, clean_lines, linenum, error):
3104 """Check that make_pair's template arguments are deduced.
3105
3106 G++ 4.6 in C++0x mode fails badly if make_pair's template arguments are
3107 specified explicitly, and such use isn't intended in any case.
3108
3109 Args:
3110 filename: The name of the current file.
3111 clean_lines: A CleansedLines instance containing the file.
3112 linenum: The number of the line to check.
3113 error: The function to call with any errors found.
3114 """
3115 raw = clean_lines.raw_lines
3116 line = raw[linenum]
3117 match = _RE_PATTERN_EXPLICIT_MAKEPAIR.search(line)
3118 if match:
3119 error(filename, linenum, 'build/explicit_make_pair',
3120 4, # 4 = high confidence
3121 'Omit template arguments from make_pair OR use pair directly OR'
3122 ' if appropriate, construct a pair directly')
3123
3124
Brian Carlstrom59848da2011-07-23 20:35:19 -07003125def ProcessLine(filename, file_extension,
3126 clean_lines, line, include_state, function_state,
Elliott Hughesdb385702012-06-21 10:41:20 -07003127 class_state, error, extra_check_functions=[]):
Brian Carlstrom59848da2011-07-23 20:35:19 -07003128 """Processes a single line in the file.
3129
3130 Args:
3131 filename: Filename of the file that is being processed.
3132 file_extension: The extension (dot not included) of the file.
3133 clean_lines: An array of strings, each representing a line of the file,
3134 with comments stripped.
3135 line: Number of line being processed.
3136 include_state: An _IncludeState instance in which the headers are inserted.
3137 function_state: A _FunctionState instance which counts function lines, etc.
3138 class_state: A _ClassState instance which maintains information about
3139 the current stack of nested class declarations being parsed.
3140 error: A callable to which errors are reported, which takes 4 arguments:
3141 filename, line number, error level, and message
Elliott Hughesdb385702012-06-21 10:41:20 -07003142 extra_check_functions: An array of additional check functions that will be
3143 run on each source line. Each function takes 4
3144 arguments: filename, clean_lines, line, error
Brian Carlstrom59848da2011-07-23 20:35:19 -07003145 """
3146 raw_lines = clean_lines.raw_lines
3147 ParseNolintSuppressions(filename, raw_lines[line], line, error)
3148 CheckForFunctionLengths(filename, clean_lines, line, function_state, error)
3149 CheckForMultilineCommentsAndStrings(filename, clean_lines, line, error)
Elliott Hughesdb385702012-06-21 10:41:20 -07003150 CheckStyle(filename, clean_lines, line, file_extension, class_state, error)
Brian Carlstrom59848da2011-07-23 20:35:19 -07003151 CheckLanguage(filename, clean_lines, line, file_extension, include_state,
3152 error)
3153 CheckForNonStandardConstructs(filename, clean_lines, line,
3154 class_state, error)
3155 CheckPosixThreading(filename, clean_lines, line, error)
3156 CheckInvalidIncrement(filename, clean_lines, line, error)
Elliott Hughesdb385702012-06-21 10:41:20 -07003157 CheckMakePairUsesDeduction(filename, clean_lines, line, error)
3158 for check_fn in extra_check_functions:
3159 check_fn(filename, clean_lines, line, error)
Brian Carlstrom59848da2011-07-23 20:35:19 -07003160
Elliott Hughesdb385702012-06-21 10:41:20 -07003161def ProcessFileData(filename, file_extension, lines, error,
3162 extra_check_functions=[]):
Brian Carlstrom59848da2011-07-23 20:35:19 -07003163 """Performs lint checks and reports any errors to the given error function.
3164
3165 Args:
3166 filename: Filename of the file that is being processed.
3167 file_extension: The extension (dot not included) of the file.
3168 lines: An array of strings, each representing a line of the file, with the
Elliott Hughesdb385702012-06-21 10:41:20 -07003169 last element being empty if the file is terminated with a newline.
Brian Carlstrom59848da2011-07-23 20:35:19 -07003170 error: A callable to which errors are reported, which takes 4 arguments:
Elliott Hughesdb385702012-06-21 10:41:20 -07003171 filename, line number, error level, and message
3172 extra_check_functions: An array of additional check functions that will be
3173 run on each source line. Each function takes 4
3174 arguments: filename, clean_lines, line, error
Brian Carlstrom59848da2011-07-23 20:35:19 -07003175 """
3176 lines = (['// marker so line numbers and indices both start at 1'] + lines +
3177 ['// marker so line numbers end in a known way'])
3178
3179 include_state = _IncludeState()
3180 function_state = _FunctionState()
3181 class_state = _ClassState()
3182
3183 ResetNolintSuppressions()
3184
3185 CheckForCopyright(filename, lines, error)
3186
3187 if file_extension == 'h':
3188 CheckForHeaderGuard(filename, lines, error)
3189
3190 RemoveMultiLineComments(filename, lines, error)
3191 clean_lines = CleansedLines(lines)
3192 for line in xrange(clean_lines.NumLines()):
3193 ProcessLine(filename, file_extension, clean_lines, line,
Elliott Hughesdb385702012-06-21 10:41:20 -07003194 include_state, function_state, class_state, error,
3195 extra_check_functions)
Brian Carlstrom59848da2011-07-23 20:35:19 -07003196 class_state.CheckFinished(filename, error)
3197
3198 CheckForIncludeWhatYouUse(filename, clean_lines, include_state, error)
3199
3200 # We check here rather than inside ProcessLine so that we see raw
3201 # lines rather than "cleaned" lines.
3202 CheckForUnicodeReplacementCharacters(filename, lines, error)
3203
3204 CheckForNewlineAtEOF(filename, lines, error)
3205
Elliott Hughesdb385702012-06-21 10:41:20 -07003206def ProcessFile(filename, vlevel, extra_check_functions=[]):
Brian Carlstrom59848da2011-07-23 20:35:19 -07003207 """Does google-lint on a single file.
3208
3209 Args:
3210 filename: The name of the file to parse.
3211
3212 vlevel: The level of errors to report. Every error of confidence
3213 >= verbose_level will be reported. 0 is a good default.
Elliott Hughesdb385702012-06-21 10:41:20 -07003214
3215 extra_check_functions: An array of additional check functions that will be
3216 run on each source line. Each function takes 4
3217 arguments: filename, clean_lines, line, error
Brian Carlstrom59848da2011-07-23 20:35:19 -07003218 """
3219
3220 _SetVerboseLevel(vlevel)
3221
3222 try:
3223 # Support the UNIX convention of using "-" for stdin. Note that
3224 # we are not opening the file with universal newline support
3225 # (which codecs doesn't support anyway), so the resulting lines do
3226 # contain trailing '\r' characters if we are reading a file that
3227 # has CRLF endings.
3228 # If after the split a trailing '\r' is present, it is removed
3229 # below. If it is not expected to be present (i.e. os.linesep !=
3230 # '\r\n' as in Windows), a warning is issued below if this file
3231 # is processed.
3232
3233 if filename == '-':
3234 lines = codecs.StreamReaderWriter(sys.stdin,
3235 codecs.getreader('utf8'),
3236 codecs.getwriter('utf8'),
3237 'replace').read().split('\n')
3238 else:
3239 lines = codecs.open(filename, 'r', 'utf8', 'replace').read().split('\n')
3240
3241 carriage_return_found = False
3242 # Remove trailing '\r'.
3243 for linenum in range(len(lines)):
3244 if lines[linenum].endswith('\r'):
3245 lines[linenum] = lines[linenum].rstrip('\r')
3246 carriage_return_found = True
3247
3248 except IOError:
3249 sys.stderr.write(
3250 "Skipping input '%s': Can't open for reading\n" % filename)
3251 return
3252
3253 # Note, if no dot is found, this will give the entire filename as the ext.
3254 file_extension = filename[filename.rfind('.') + 1:]
3255
3256 # When reading from stdin, the extension is unknown, so no cpplint tests
3257 # should rely on the extension.
3258 if (filename != '-' and file_extension != 'cc' and file_extension != 'h'
3259 and file_extension != 'cpp'):
3260 sys.stderr.write('Ignoring %s; not a .cc or .h file\n' % filename)
3261 else:
Elliott Hughesdb385702012-06-21 10:41:20 -07003262 ProcessFileData(filename, file_extension, lines, Error,
3263 extra_check_functions)
Brian Carlstrom59848da2011-07-23 20:35:19 -07003264 if carriage_return_found and os.linesep != '\r\n':
Elliott Hughesdb385702012-06-21 10:41:20 -07003265 # Use 0 for linenum since outputting only one error for potentially
Brian Carlstrom59848da2011-07-23 20:35:19 -07003266 # several lines.
3267 Error(filename, 0, 'whitespace/newline', 1,
3268 'One or more unexpected \\r (^M) found;'
3269 'better to use only a \\n')
3270
3271 sys.stderr.write('Done processing %s\n' % filename)
3272
3273
3274def PrintUsage(message):
3275 """Prints a brief usage string and exits, optionally with an error message.
3276
3277 Args:
3278 message: The optional error message.
3279 """
3280 sys.stderr.write(_USAGE)
3281 if message:
3282 sys.exit('\nFATAL ERROR: ' + message)
3283 else:
3284 sys.exit(1)
3285
3286
3287def PrintCategories():
3288 """Prints a list of all the error-categories used by error messages.
3289
3290 These are the categories used to filter messages via --filter.
3291 """
3292 sys.stderr.write(''.join(' %s\n' % cat for cat in _ERROR_CATEGORIES))
3293 sys.exit(0)
3294
3295
3296def ParseArguments(args):
3297 """Parses the command line arguments.
3298
3299 This may set the output format and verbosity level as side-effects.
3300
3301 Args:
3302 args: The command line arguments:
3303
3304 Returns:
3305 The list of filenames to lint.
3306 """
3307 try:
3308 (opts, filenames) = getopt.getopt(args, '', ['help', 'output=', 'verbose=',
Elliott Hughes08fc03a2012-06-26 17:34:00 -07003309 'stdout', # TODO(enh): added --stdout
Brian Carlstrom59848da2011-07-23 20:35:19 -07003310 'counting=',
3311 'filter='])
3312 except getopt.GetoptError:
3313 PrintUsage('Invalid arguments.')
3314
3315 verbosity = _VerboseLevel()
3316 output_format = _OutputFormat()
Elliott Hughes08fc03a2012-06-26 17:34:00 -07003317 output_stream = sys.stderr # TODO(enh): added --stdout
Brian Carlstrom59848da2011-07-23 20:35:19 -07003318 filters = ''
3319 counting_style = ''
3320
3321 for (opt, val) in opts:
3322 if opt == '--help':
3323 PrintUsage(None)
Elliott Hughes08fc03a2012-06-26 17:34:00 -07003324 elif opt == '--stdout': # TODO(enh): added --stdout
3325 output_stream = sys.stdout # TODO(enh): added --stdout
Brian Carlstrom59848da2011-07-23 20:35:19 -07003326 elif opt == '--output':
3327 if not val in ('emacs', 'vs7'):
3328 PrintUsage('The only allowed output formats are emacs and vs7.')
3329 output_format = val
3330 elif opt == '--verbose':
3331 verbosity = int(val)
3332 elif opt == '--filter':
3333 filters = val
3334 if not filters:
3335 PrintCategories()
3336 elif opt == '--counting':
3337 if val not in ('total', 'toplevel', 'detailed'):
3338 PrintUsage('Valid counting options are total, toplevel, and detailed')
3339 counting_style = val
3340
3341 if not filenames:
3342 PrintUsage('No files were specified.')
3343
3344 _SetOutputFormat(output_format)
3345 _SetVerboseLevel(verbosity)
3346 _SetFilters(filters)
3347 _SetCountingStyle(counting_style)
3348
Elliott Hughes08fc03a2012-06-26 17:34:00 -07003349 sys.stderr = output_stream # TODO(enh): added --stdout
3350
Brian Carlstrom59848da2011-07-23 20:35:19 -07003351 return filenames
3352
3353
3354def main():
3355 filenames = ParseArguments(sys.argv[1:])
3356
3357 # Change stderr to write with replacement characters so we don't die
3358 # if we try to print something containing non-ASCII characters.
3359 sys.stderr = codecs.StreamReaderWriter(sys.stderr,
3360 codecs.getreader('utf8'),
3361 codecs.getwriter('utf8'),
3362 'replace')
3363
3364 _cpplint_state.ResetErrorCounts()
3365 for filename in filenames:
3366 ProcessFile(filename, _cpplint_state.verbose_level)
3367 _cpplint_state.PrintErrorCounts()
3368
3369 sys.exit(_cpplint_state.error_count > 0)
3370
3371
3372if __name__ == '__main__':
3373 main()