Shinichiro Hamaji | 0439a3e | 2015-04-01 02:01:05 +0900 | [diff] [blame] | 1 | package main |
| 2 | |
| 3 | import ( |
| 4 | "reflect" |
| 5 | "testing" |
| 6 | ) |
| 7 | |
Shinichiro Hamaji | 7825b65 | 2015-06-04 13:47:14 +0900 | [diff] [blame] | 8 | func parseExprForTest(e string) Value { |
| 9 | v, _, err := parseExpr([]byte(e), nil) |
| 10 | if err != nil { |
| 11 | panic(err) |
| 12 | } |
| 13 | return v |
| 14 | } |
| 15 | |
Shinichiro Hamaji | 0439a3e | 2015-04-01 02:01:05 +0900 | [diff] [blame] | 16 | func TestRuleParser(t *testing.T) { |
| 17 | for _, tc := range []struct { |
Fumitoshi Ukai | 953ce6f | 2015-04-04 00:38:53 +0900 | [diff] [blame] | 18 | in string |
| 19 | want Rule |
| 20 | assign *AssignAST |
| 21 | err string |
| 22 | }{ |
Shinichiro Hamaji | 0439a3e | 2015-04-01 02:01:05 +0900 | [diff] [blame] | 23 | { |
Fumitoshi Ukai | 953ce6f | 2015-04-04 00:38:53 +0900 | [diff] [blame] | 24 | in: "foo: bar", |
Shinichiro Hamaji | 0439a3e | 2015-04-01 02:01:05 +0900 | [diff] [blame] | 25 | want: Rule{ |
| 26 | outputs: []string{"foo"}, |
| 27 | inputs: []string{"bar"}, |
| 28 | }, |
| 29 | }, |
| 30 | { |
Fumitoshi Ukai | 953ce6f | 2015-04-04 00:38:53 +0900 | [diff] [blame] | 31 | in: "foo: bar baz", |
Shinichiro Hamaji | 0439a3e | 2015-04-01 02:01:05 +0900 | [diff] [blame] | 32 | want: Rule{ |
| 33 | outputs: []string{"foo"}, |
| 34 | inputs: []string{"bar", "baz"}, |
| 35 | }, |
| 36 | }, |
Shinichiro Hamaji | 21a9b5f | 2015-04-01 02:42:59 +0900 | [diff] [blame] | 37 | { |
Fumitoshi Ukai | 953ce6f | 2015-04-04 00:38:53 +0900 | [diff] [blame] | 38 | in: "foo:: bar", |
Shinichiro Hamaji | 21a9b5f | 2015-04-01 02:42:59 +0900 | [diff] [blame] | 39 | want: Rule{ |
Fumitoshi Ukai | 953ce6f | 2015-04-04 00:38:53 +0900 | [diff] [blame] | 40 | outputs: []string{"foo"}, |
| 41 | inputs: []string{"bar"}, |
Shinichiro Hamaji | 21a9b5f | 2015-04-01 02:42:59 +0900 | [diff] [blame] | 42 | isDoubleColon: true, |
| 43 | }, |
| 44 | }, |
| 45 | { |
| 46 | in: "foo", |
| 47 | err: "*** missing separator.", |
| 48 | }, |
| 49 | { |
Fumitoshi Ukai | 953ce6f | 2015-04-04 00:38:53 +0900 | [diff] [blame] | 50 | in: "%.o: %.c", |
Shinichiro Hamaji | 21a9b5f | 2015-04-01 02:42:59 +0900 | [diff] [blame] | 51 | want: Rule{ |
Fumitoshi Ukai | 935de96 | 2015-04-28 17:08:20 +0900 | [diff] [blame] | 52 | outputPatterns: []pattern{pattern{suffix: ".o"}}, |
Shinichiro Hamaji | 21a9b5f | 2015-04-01 02:42:59 +0900 | [diff] [blame] | 53 | inputs: []string{"%.c"}, |
| 54 | }, |
| 55 | }, |
| 56 | { |
| 57 | in: "foo %.o: %.c", |
| 58 | err: "*** mixed implicit and normal rules: deprecated syntax", |
| 59 | }, |
| 60 | { |
Fumitoshi Ukai | 953ce6f | 2015-04-04 00:38:53 +0900 | [diff] [blame] | 61 | in: "foo.o: %.o: %.c %.h", |
Shinichiro Hamaji | 21a9b5f | 2015-04-01 02:42:59 +0900 | [diff] [blame] | 62 | want: Rule{ |
| 63 | outputs: []string{"foo.o"}, |
Fumitoshi Ukai | 935de96 | 2015-04-28 17:08:20 +0900 | [diff] [blame] | 64 | outputPatterns: []pattern{pattern{suffix: ".o"}}, |
Shinichiro Hamaji | 21a9b5f | 2015-04-01 02:42:59 +0900 | [diff] [blame] | 65 | inputs: []string{"%.c", "%.h"}, |
| 66 | }, |
| 67 | }, |
| 68 | { |
| 69 | in: "%.x: %.y: %.z", |
| 70 | err: "*** mixed implicit and normal rules: deprecated syntax", |
| 71 | }, |
| 72 | { |
| 73 | in: "foo.o: : %.c", |
| 74 | err: "*** missing target pattern.", |
| 75 | }, |
| 76 | { |
| 77 | in: "foo.o: %.o %.o: %.c", |
| 78 | err: "*** multiple target patterns.", |
| 79 | }, |
| 80 | { |
| 81 | in: "foo.o: foo.o: %.c", |
| 82 | err: "*** target pattern contains no '%'.", |
| 83 | }, |
Shinichiro Hamaji | 5c53b57 | 2015-04-02 05:36:42 +0900 | [diff] [blame] | 84 | { |
Fumitoshi Ukai | 953ce6f | 2015-04-04 00:38:53 +0900 | [diff] [blame] | 85 | in: "foo: bar | baz", |
Shinichiro Hamaji | 5c53b57 | 2015-04-02 05:36:42 +0900 | [diff] [blame] | 86 | want: Rule{ |
| 87 | outputs: []string{"foo"}, |
| 88 | inputs: []string{"bar"}, |
| 89 | orderOnlyInputs: []string{"baz"}, |
| 90 | }, |
| 91 | }, |
Fumitoshi Ukai | 953ce6f | 2015-04-04 00:38:53 +0900 | [diff] [blame] | 92 | { |
| 93 | in: "foo: CFLAGS = -g", |
| 94 | want: Rule{ |
| 95 | outputs: []string{"foo"}, |
| 96 | }, |
| 97 | assign: &AssignAST{ |
Shinichiro Hamaji | 7825b65 | 2015-06-04 13:47:14 +0900 | [diff] [blame] | 98 | lhs: parseExprForTest("CFLAGS"), |
| 99 | rhs: parseExprForTest("-g"), |
Fumitoshi Ukai | 953ce6f | 2015-04-04 00:38:53 +0900 | [diff] [blame] | 100 | op: "=", |
| 101 | }, |
| 102 | }, |
Fumitoshi Ukai | 3ef5fcc | 2015-04-06 17:21:43 +0900 | [diff] [blame] | 103 | { |
| 104 | in: "foo: CFLAGS=-g", |
| 105 | want: Rule{ |
| 106 | outputs: []string{"foo"}, |
| 107 | }, |
| 108 | assign: &AssignAST{ |
Shinichiro Hamaji | 7825b65 | 2015-06-04 13:47:14 +0900 | [diff] [blame] | 109 | lhs: parseExprForTest("CFLAGS"), |
| 110 | rhs: parseExprForTest("-g"), |
Fumitoshi Ukai | 3ef5fcc | 2015-04-06 17:21:43 +0900 | [diff] [blame] | 111 | op: "=", |
| 112 | }, |
| 113 | }, |
| 114 | { |
| 115 | in: "foo: CFLAGS := -g", |
| 116 | want: Rule{ |
| 117 | outputs: []string{"foo"}, |
| 118 | }, |
| 119 | assign: &AssignAST{ |
Shinichiro Hamaji | 7825b65 | 2015-06-04 13:47:14 +0900 | [diff] [blame] | 120 | lhs: parseExprForTest("CFLAGS"), |
| 121 | rhs: parseExprForTest("-g"), |
Fumitoshi Ukai | 3ef5fcc | 2015-04-06 17:21:43 +0900 | [diff] [blame] | 122 | op: ":=", |
| 123 | }, |
| 124 | }, |
Shinichiro Hamaji | a485d2f | 2015-04-16 14:03:24 +0900 | [diff] [blame] | 125 | { |
| 126 | in: "%.o: CFLAGS := -g", |
| 127 | want: Rule{ |
Fumitoshi Ukai | 935de96 | 2015-04-28 17:08:20 +0900 | [diff] [blame] | 128 | outputPatterns: []pattern{pattern{suffix: ".o"}}, |
Shinichiro Hamaji | a485d2f | 2015-04-16 14:03:24 +0900 | [diff] [blame] | 129 | }, |
| 130 | assign: &AssignAST{ |
Shinichiro Hamaji | 7825b65 | 2015-06-04 13:47:14 +0900 | [diff] [blame] | 131 | lhs: parseExprForTest("CFLAGS"), |
| 132 | rhs: parseExprForTest("-g"), |
Shinichiro Hamaji | a485d2f | 2015-04-16 14:03:24 +0900 | [diff] [blame] | 133 | op: ":=", |
| 134 | }, |
| 135 | }, |
Shinichiro Hamaji | 21a9b5f | 2015-04-01 02:42:59 +0900 | [diff] [blame] | 136 | /* TODO |
| 137 | { |
| 138 | in: "foo.o: %.c: %.c", |
| 139 | err: "*** target 'foo.o' doesn't match the target pattern", |
| 140 | }, |
| 141 | */ |
Shinichiro Hamaji | 0439a3e | 2015-04-01 02:01:05 +0900 | [diff] [blame] | 142 | } { |
| 143 | got := &Rule{} |
Fumitoshi Ukai | 0b9e813 | 2015-04-30 10:20:18 +0900 | [diff] [blame] | 144 | assign, err := got.parse([]byte(tc.in)) |
Fumitoshi Ukai | 953ce6f | 2015-04-04 00:38:53 +0900 | [diff] [blame] | 145 | if tc.err != "" { |
| 146 | if err == nil { |
| 147 | t.Errorf(`r.parse(%q)=_, <nil>, want _, %q`, tc.in, tc.err) |
| 148 | continue |
| 149 | } |
| 150 | if got, want := err.Error(), tc.err; got != want { |
| 151 | t.Errorf(`r.parse(%q)=_, %s, want %s`, tc.in, got, want) |
| 152 | } |
| 153 | continue |
Shinichiro Hamaji | 21a9b5f | 2015-04-01 02:42:59 +0900 | [diff] [blame] | 154 | } |
Fumitoshi Ukai | 953ce6f | 2015-04-04 00:38:53 +0900 | [diff] [blame] | 155 | if err != nil { |
| 156 | t.Errorf(`r.parse(%q)=_, %v; want nil error`, tc.in, err) |
| 157 | continue |
| 158 | } |
| 159 | if !reflect.DeepEqual(*got, tc.want) { |
Fumitoshi Ukai | 36c510b | 2015-06-08 10:21:13 +0900 | [diff] [blame^] | 160 | t.Errorf(`r.parse(%q); r=%#v, want %#v`, tc.in, *got, tc.want) |
Shinichiro Hamaji | 0439a3e | 2015-04-01 02:01:05 +0900 | [diff] [blame] | 161 | } |
Fumitoshi Ukai | 953ce6f | 2015-04-04 00:38:53 +0900 | [diff] [blame] | 162 | if tc.assign != nil { |
| 163 | if assign == nil { |
Fumitoshi Ukai | 3ef5fcc | 2015-04-06 17:21:43 +0900 | [diff] [blame] | 164 | t.Errorf(`r.parse(%q)=<nil>; want=%#v`, tc.in, tc.assign) |
Fumitoshi Ukai | 953ce6f | 2015-04-04 00:38:53 +0900 | [diff] [blame] | 165 | continue |
| 166 | } |
| 167 | if got, want := assign, tc.assign; !reflect.DeepEqual(got, want) { |
Fumitoshi Ukai | 3ef5fcc | 2015-04-06 17:21:43 +0900 | [diff] [blame] | 168 | t.Errorf(`r.parse(%q)=%#v; want=%#v`, tc.in, got, want) |
Fumitoshi Ukai | 953ce6f | 2015-04-04 00:38:53 +0900 | [diff] [blame] | 169 | } |
| 170 | continue |
| 171 | } |
| 172 | if assign != nil { |
| 173 | t.Errorf(`r.parse(%q)=%v; want=<nil>`, tc.in, assign) |
| 174 | } |
Shinichiro Hamaji | 0439a3e | 2015-04-01 02:01:05 +0900 | [diff] [blame] | 175 | } |
| 176 | } |