Vulkan: Mark some Resource APIs are protected.
This clarifies what is supposed to be called from outside the class to
what should be called internally. The read/write dependency management
is accessible publically. The command buffer access however is private
and should be only used within the class.
Bug: angleproject:2539
Change-Id: Ic25b589d4009de62633d13546be596ecafd0b175
Reviewed-on: https://chromium-review.googlesource.com/1066555
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Luc Ferron <lucferron@chromium.org>
Reviewed-by: Frank Henigman <fjhenigman@chromium.org>
diff --git a/src/libANGLE/renderer/vulkan/CommandGraph.h b/src/libANGLE/renderer/vulkan/CommandGraph.h
index 93a54d7..d8f3501 100644
--- a/src/libANGLE/renderer/vulkan/CommandGraph.h
+++ b/src/libANGLE/renderer/vulkan/CommandGraph.h
@@ -33,6 +33,13 @@
Serial getQueueSerial() const;
+ // Sets up dependency relations. 'this' resource is the resource being written to.
+ void addWriteDependency(CommandGraphResource *writingResource);
+
+ // Sets up dependency relations. 'this' resource is the resource being read.
+ void addReadDependency(CommandGraphResource *readingResource);
+
+ protected:
// Allocates a write node via getNewWriteNode and returns a started command buffer.
// The started command buffer will render outside of a RenderPass.
Error beginWriteResource(RendererVk *renderer, CommandBuffer **commandBufferOut);
@@ -64,12 +71,6 @@
// Called when 'this' object changes, but we'd like to start a new command buffer later.
void onResourceChanged(RendererVk *renderer);
- // Sets up dependency relations. 'this' resource is the resource being written to.
- void addWriteDependency(CommandGraphResource *writingResource);
-
- // Sets up dependency relations. 'this' resource is the resource being read.
- void addReadDependency(CommandGraphResource *readingResource);
-
private:
void onWriteImpl(CommandGraphNode *writingNode, Serial currentSerial);