Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1 | // |
Geoff Lang | cec3590 | 2014-04-16 10:52:36 -0400 | [diff] [blame] | 2 | // Copyright (c) 2013-2014 The ANGLE Project Authors. All rights reserved. |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 3 | // Use of this source code is governed by a BSD-style license that can be |
| 4 | // found in the LICENSE file. |
| 5 | // |
| 6 | |
| 7 | // validationES3.cpp: Validation functions for OpenGL ES 3.0 entry point parameters |
| 8 | |
Geoff Lang | 2b5420c | 2014-11-19 14:20:15 -0500 | [diff] [blame] | 9 | #include "libANGLE/validationES3.h" |
Jamie Madill | e2e406c | 2016-06-02 13:04:10 -0400 | [diff] [blame] | 10 | |
Geoff Lang | 2b5420c | 2014-11-19 14:20:15 -0500 | [diff] [blame] | 11 | #include "libANGLE/validationES.h" |
| 12 | #include "libANGLE/Context.h" |
| 13 | #include "libANGLE/Texture.h" |
| 14 | #include "libANGLE/Framebuffer.h" |
| 15 | #include "libANGLE/Renderbuffer.h" |
| 16 | #include "libANGLE/formatutils.h" |
| 17 | #include "libANGLE/FramebufferAttachment.h" |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 18 | |
| 19 | #include "common/mathutil.h" |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 20 | #include "common/utilities.h" |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 21 | |
Jamie Madill | e2e406c | 2016-06-02 13:04:10 -0400 | [diff] [blame] | 22 | using namespace angle; |
| 23 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 24 | namespace gl |
| 25 | { |
| 26 | |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 27 | struct ES3FormatCombination |
| 28 | { |
| 29 | GLenum internalFormat; |
| 30 | GLenum format; |
| 31 | GLenum type; |
| 32 | }; |
| 33 | |
| 34 | bool operator<(const ES3FormatCombination& a, const ES3FormatCombination& b) |
| 35 | { |
| 36 | return memcmp(&a, &b, sizeof(ES3FormatCombination)) < 0; |
| 37 | } |
| 38 | |
| 39 | typedef std::set<ES3FormatCombination> ES3FormatCombinationSet; |
| 40 | |
| 41 | static inline void InsertES3FormatCombo(ES3FormatCombinationSet *set, GLenum internalFormat, GLenum format, GLenum type) |
| 42 | { |
| 43 | ES3FormatCombination info; |
| 44 | info.internalFormat = internalFormat; |
| 45 | info.format = format; |
| 46 | info.type = type; |
| 47 | set->insert(info); |
| 48 | } |
| 49 | |
| 50 | ES3FormatCombinationSet BuildES3FormatSet() |
| 51 | { |
| 52 | ES3FormatCombinationSet set; |
| 53 | |
| 54 | // Format combinations from ES 3.0.1 spec, table 3.2 |
| 55 | |
| 56 | // | Internal format | Format | Type | |
| 57 | // | | | | |
| 58 | InsertES3FormatCombo(&set, GL_RGBA8, GL_RGBA, GL_UNSIGNED_BYTE ); |
| 59 | InsertES3FormatCombo(&set, GL_RGB5_A1, GL_RGBA, GL_UNSIGNED_BYTE ); |
| 60 | InsertES3FormatCombo(&set, GL_RGBA4, GL_RGBA, GL_UNSIGNED_BYTE ); |
| 61 | InsertES3FormatCombo(&set, GL_SRGB8_ALPHA8, GL_RGBA, GL_UNSIGNED_BYTE ); |
| 62 | InsertES3FormatCombo(&set, GL_RGBA8_SNORM, GL_RGBA, GL_BYTE ); |
| 63 | InsertES3FormatCombo(&set, GL_RGBA4, GL_RGBA, GL_UNSIGNED_SHORT_4_4_4_4 ); |
| 64 | InsertES3FormatCombo(&set, GL_RGB10_A2, GL_RGBA, GL_UNSIGNED_INT_2_10_10_10_REV ); |
| 65 | InsertES3FormatCombo(&set, GL_RGB5_A1, GL_RGBA, GL_UNSIGNED_INT_2_10_10_10_REV ); |
| 66 | InsertES3FormatCombo(&set, GL_RGB5_A1, GL_RGBA, GL_UNSIGNED_SHORT_5_5_5_1 ); |
| 67 | InsertES3FormatCombo(&set, GL_RGBA16F, GL_RGBA, GL_HALF_FLOAT ); |
| 68 | InsertES3FormatCombo(&set, GL_RGBA16F, GL_RGBA, GL_HALF_FLOAT_OES ); |
| 69 | InsertES3FormatCombo(&set, GL_RGBA32F, GL_RGBA, GL_FLOAT ); |
| 70 | InsertES3FormatCombo(&set, GL_RGBA16F, GL_RGBA, GL_FLOAT ); |
| 71 | InsertES3FormatCombo(&set, GL_RGBA8UI, GL_RGBA_INTEGER, GL_UNSIGNED_BYTE ); |
| 72 | InsertES3FormatCombo(&set, GL_RGBA8I, GL_RGBA_INTEGER, GL_BYTE ); |
| 73 | InsertES3FormatCombo(&set, GL_RGBA16UI, GL_RGBA_INTEGER, GL_UNSIGNED_SHORT ); |
| 74 | InsertES3FormatCombo(&set, GL_RGBA16I, GL_RGBA_INTEGER, GL_SHORT ); |
| 75 | InsertES3FormatCombo(&set, GL_RGBA32UI, GL_RGBA_INTEGER, GL_UNSIGNED_INT ); |
| 76 | InsertES3FormatCombo(&set, GL_RGBA32I, GL_RGBA_INTEGER, GL_INT ); |
| 77 | InsertES3FormatCombo(&set, GL_RGB10_A2UI, GL_RGBA_INTEGER, GL_UNSIGNED_INT_2_10_10_10_REV ); |
| 78 | InsertES3FormatCombo(&set, GL_RGB8, GL_RGB, GL_UNSIGNED_BYTE ); |
| 79 | InsertES3FormatCombo(&set, GL_RGB565, GL_RGB, GL_UNSIGNED_BYTE ); |
| 80 | InsertES3FormatCombo(&set, GL_SRGB8, GL_RGB, GL_UNSIGNED_BYTE ); |
| 81 | InsertES3FormatCombo(&set, GL_RGB8_SNORM, GL_RGB, GL_BYTE ); |
| 82 | InsertES3FormatCombo(&set, GL_RGB565, GL_RGB, GL_UNSIGNED_SHORT_5_6_5 ); |
| 83 | InsertES3FormatCombo(&set, GL_R11F_G11F_B10F, GL_RGB, GL_UNSIGNED_INT_10F_11F_11F_REV ); |
| 84 | InsertES3FormatCombo(&set, GL_RGB9_E5, GL_RGB, GL_UNSIGNED_INT_5_9_9_9_REV ); |
| 85 | InsertES3FormatCombo(&set, GL_RGB16F, GL_RGB, GL_HALF_FLOAT ); |
| 86 | InsertES3FormatCombo(&set, GL_RGB16F, GL_RGB, GL_HALF_FLOAT_OES ); |
| 87 | InsertES3FormatCombo(&set, GL_R11F_G11F_B10F, GL_RGB, GL_HALF_FLOAT ); |
| 88 | InsertES3FormatCombo(&set, GL_R11F_G11F_B10F, GL_RGB, GL_HALF_FLOAT_OES ); |
| 89 | InsertES3FormatCombo(&set, GL_RGB9_E5, GL_RGB, GL_HALF_FLOAT ); |
| 90 | InsertES3FormatCombo(&set, GL_RGB9_E5, GL_RGB, GL_HALF_FLOAT_OES ); |
| 91 | InsertES3FormatCombo(&set, GL_RGB32F, GL_RGB, GL_FLOAT ); |
| 92 | InsertES3FormatCombo(&set, GL_RGB16F, GL_RGB, GL_FLOAT ); |
| 93 | InsertES3FormatCombo(&set, GL_R11F_G11F_B10F, GL_RGB, GL_FLOAT ); |
| 94 | InsertES3FormatCombo(&set, GL_RGB9_E5, GL_RGB, GL_FLOAT ); |
| 95 | InsertES3FormatCombo(&set, GL_RGB8UI, GL_RGB_INTEGER, GL_UNSIGNED_BYTE ); |
| 96 | InsertES3FormatCombo(&set, GL_RGB8I, GL_RGB_INTEGER, GL_BYTE ); |
| 97 | InsertES3FormatCombo(&set, GL_RGB16UI, GL_RGB_INTEGER, GL_UNSIGNED_SHORT ); |
| 98 | InsertES3FormatCombo(&set, GL_RGB16I, GL_RGB_INTEGER, GL_SHORT ); |
| 99 | InsertES3FormatCombo(&set, GL_RGB32UI, GL_RGB_INTEGER, GL_UNSIGNED_INT ); |
| 100 | InsertES3FormatCombo(&set, GL_RGB32I, GL_RGB_INTEGER, GL_INT ); |
| 101 | InsertES3FormatCombo(&set, GL_RG8, GL_RG, GL_UNSIGNED_BYTE ); |
| 102 | InsertES3FormatCombo(&set, GL_RG8_SNORM, GL_RG, GL_BYTE ); |
| 103 | InsertES3FormatCombo(&set, GL_RG16F, GL_RG, GL_HALF_FLOAT ); |
| 104 | InsertES3FormatCombo(&set, GL_RG16F, GL_RG, GL_HALF_FLOAT_OES ); |
| 105 | InsertES3FormatCombo(&set, GL_RG32F, GL_RG, GL_FLOAT ); |
| 106 | InsertES3FormatCombo(&set, GL_RG16F, GL_RG, GL_FLOAT ); |
| 107 | InsertES3FormatCombo(&set, GL_RG8UI, GL_RG_INTEGER, GL_UNSIGNED_BYTE ); |
| 108 | InsertES3FormatCombo(&set, GL_RG8I, GL_RG_INTEGER, GL_BYTE ); |
| 109 | InsertES3FormatCombo(&set, GL_RG16UI, GL_RG_INTEGER, GL_UNSIGNED_SHORT ); |
| 110 | InsertES3FormatCombo(&set, GL_RG16I, GL_RG_INTEGER, GL_SHORT ); |
| 111 | InsertES3FormatCombo(&set, GL_RG32UI, GL_RG_INTEGER, GL_UNSIGNED_INT ); |
| 112 | InsertES3FormatCombo(&set, GL_RG32I, GL_RG_INTEGER, GL_INT ); |
| 113 | InsertES3FormatCombo(&set, GL_R8, GL_RED, GL_UNSIGNED_BYTE ); |
| 114 | InsertES3FormatCombo(&set, GL_R8_SNORM, GL_RED, GL_BYTE ); |
| 115 | InsertES3FormatCombo(&set, GL_R16F, GL_RED, GL_HALF_FLOAT ); |
| 116 | InsertES3FormatCombo(&set, GL_R16F, GL_RED, GL_HALF_FLOAT_OES ); |
| 117 | InsertES3FormatCombo(&set, GL_R32F, GL_RED, GL_FLOAT ); |
| 118 | InsertES3FormatCombo(&set, GL_R16F, GL_RED, GL_FLOAT ); |
| 119 | InsertES3FormatCombo(&set, GL_R8UI, GL_RED_INTEGER, GL_UNSIGNED_BYTE ); |
| 120 | InsertES3FormatCombo(&set, GL_R8I, GL_RED_INTEGER, GL_BYTE ); |
| 121 | InsertES3FormatCombo(&set, GL_R16UI, GL_RED_INTEGER, GL_UNSIGNED_SHORT ); |
| 122 | InsertES3FormatCombo(&set, GL_R16I, GL_RED_INTEGER, GL_SHORT ); |
| 123 | InsertES3FormatCombo(&set, GL_R32UI, GL_RED_INTEGER, GL_UNSIGNED_INT ); |
| 124 | InsertES3FormatCombo(&set, GL_R32I, GL_RED_INTEGER, GL_INT ); |
| 125 | |
| 126 | // Unsized formats |
| 127 | InsertES3FormatCombo(&set, GL_RGBA, GL_RGBA, GL_UNSIGNED_BYTE ); |
| 128 | InsertES3FormatCombo(&set, GL_RGBA, GL_RGBA, GL_UNSIGNED_SHORT_4_4_4_4 ); |
| 129 | InsertES3FormatCombo(&set, GL_RGBA, GL_RGBA, GL_UNSIGNED_SHORT_5_5_5_1 ); |
| 130 | InsertES3FormatCombo(&set, GL_RGB, GL_RGB, GL_UNSIGNED_BYTE ); |
| 131 | InsertES3FormatCombo(&set, GL_RGB, GL_RGB, GL_UNSIGNED_SHORT_5_6_5 ); |
| 132 | InsertES3FormatCombo(&set, GL_LUMINANCE_ALPHA, GL_LUMINANCE_ALPHA, GL_UNSIGNED_BYTE ); |
| 133 | InsertES3FormatCombo(&set, GL_LUMINANCE, GL_LUMINANCE, GL_UNSIGNED_BYTE ); |
| 134 | InsertES3FormatCombo(&set, GL_ALPHA, GL_ALPHA, GL_UNSIGNED_BYTE ); |
| 135 | InsertES3FormatCombo(&set, GL_SRGB_ALPHA_EXT, GL_SRGB_ALPHA_EXT, GL_UNSIGNED_BYTE ); |
| 136 | InsertES3FormatCombo(&set, GL_SRGB_EXT, GL_SRGB_EXT, GL_UNSIGNED_BYTE ); |
Jamie Madill | 689325c | 2015-07-20 14:36:53 -0400 | [diff] [blame] | 137 | InsertES3FormatCombo(&set, GL_RG, GL_RG, GL_UNSIGNED_BYTE ); |
| 138 | InsertES3FormatCombo(&set, GL_RG, GL_RG, GL_FLOAT ); |
| 139 | InsertES3FormatCombo(&set, GL_RG, GL_RG, GL_HALF_FLOAT ); |
| 140 | InsertES3FormatCombo(&set, GL_RG, GL_RG, GL_HALF_FLOAT_OES ); |
| 141 | InsertES3FormatCombo(&set, GL_RED, GL_RED, GL_UNSIGNED_BYTE ); |
| 142 | InsertES3FormatCombo(&set, GL_RED, GL_RED, GL_FLOAT ); |
| 143 | InsertES3FormatCombo(&set, GL_RED, GL_RED, GL_HALF_FLOAT ); |
| 144 | InsertES3FormatCombo(&set, GL_RED, GL_RED, GL_HALF_FLOAT_OES ); |
| 145 | InsertES3FormatCombo(&set, GL_DEPTH_STENCIL, GL_DEPTH_STENCIL, GL_UNSIGNED_INT_24_8 ); |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 146 | |
| 147 | // Depth stencil formats |
| 148 | InsertES3FormatCombo(&set, GL_DEPTH_COMPONENT16, GL_DEPTH_COMPONENT, GL_UNSIGNED_SHORT ); |
| 149 | InsertES3FormatCombo(&set, GL_DEPTH_COMPONENT24, GL_DEPTH_COMPONENT, GL_UNSIGNED_INT ); |
| 150 | InsertES3FormatCombo(&set, GL_DEPTH_COMPONENT16, GL_DEPTH_COMPONENT, GL_UNSIGNED_INT ); |
| 151 | InsertES3FormatCombo(&set, GL_DEPTH_COMPONENT32F, GL_DEPTH_COMPONENT, GL_FLOAT ); |
| 152 | InsertES3FormatCombo(&set, GL_DEPTH24_STENCIL8, GL_DEPTH_STENCIL, GL_UNSIGNED_INT_24_8 ); |
| 153 | InsertES3FormatCombo(&set, GL_DEPTH32F_STENCIL8, GL_DEPTH_STENCIL, GL_FLOAT_32_UNSIGNED_INT_24_8_REV); |
| 154 | |
| 155 | // From GL_EXT_sRGB |
| 156 | InsertES3FormatCombo(&set, GL_SRGB8_ALPHA8_EXT, GL_SRGB_ALPHA_EXT, GL_UNSIGNED_BYTE ); |
| 157 | InsertES3FormatCombo(&set, GL_SRGB8, GL_SRGB_EXT, GL_UNSIGNED_BYTE ); |
| 158 | |
| 159 | // From GL_OES_texture_float |
Jeff Muizelaar | bb1a5be | 2015-12-02 12:03:46 -0500 | [diff] [blame] | 160 | InsertES3FormatCombo(&set, GL_RGBA, GL_RGBA, GL_FLOAT ); |
| 161 | InsertES3FormatCombo(&set, GL_RGB, GL_RGB, GL_FLOAT ); |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 162 | InsertES3FormatCombo(&set, GL_LUMINANCE_ALPHA, GL_LUMINANCE_ALPHA, GL_FLOAT ); |
| 163 | InsertES3FormatCombo(&set, GL_LUMINANCE, GL_LUMINANCE, GL_FLOAT ); |
| 164 | InsertES3FormatCombo(&set, GL_ALPHA, GL_ALPHA, GL_FLOAT ); |
| 165 | |
| 166 | // From GL_OES_texture_half_float |
| 167 | InsertES3FormatCombo(&set, GL_LUMINANCE_ALPHA, GL_LUMINANCE_ALPHA, GL_HALF_FLOAT ); |
| 168 | InsertES3FormatCombo(&set, GL_LUMINANCE_ALPHA, GL_LUMINANCE_ALPHA, GL_HALF_FLOAT_OES ); |
| 169 | InsertES3FormatCombo(&set, GL_LUMINANCE, GL_LUMINANCE, GL_HALF_FLOAT ); |
| 170 | InsertES3FormatCombo(&set, GL_LUMINANCE, GL_LUMINANCE, GL_HALF_FLOAT_OES ); |
| 171 | InsertES3FormatCombo(&set, GL_ALPHA, GL_ALPHA, GL_HALF_FLOAT ); |
| 172 | InsertES3FormatCombo(&set, GL_ALPHA, GL_ALPHA, GL_HALF_FLOAT_OES ); |
| 173 | |
| 174 | // From GL_EXT_texture_format_BGRA8888 |
| 175 | InsertES3FormatCombo(&set, GL_BGRA_EXT, GL_BGRA_EXT, GL_UNSIGNED_BYTE ); |
| 176 | |
| 177 | // From GL_EXT_texture_storage |
| 178 | // | Internal format | Format | Type | |
| 179 | // | | | | |
| 180 | InsertES3FormatCombo(&set, GL_ALPHA8_EXT, GL_ALPHA, GL_UNSIGNED_BYTE ); |
| 181 | InsertES3FormatCombo(&set, GL_LUMINANCE8_EXT, GL_LUMINANCE, GL_UNSIGNED_BYTE ); |
| 182 | InsertES3FormatCombo(&set, GL_LUMINANCE8_ALPHA8_EXT, GL_LUMINANCE_ALPHA, GL_UNSIGNED_BYTE ); |
| 183 | InsertES3FormatCombo(&set, GL_ALPHA32F_EXT, GL_ALPHA, GL_FLOAT ); |
| 184 | InsertES3FormatCombo(&set, GL_LUMINANCE32F_EXT, GL_LUMINANCE, GL_FLOAT ); |
| 185 | InsertES3FormatCombo(&set, GL_LUMINANCE_ALPHA32F_EXT, GL_LUMINANCE_ALPHA, GL_FLOAT ); |
| 186 | InsertES3FormatCombo(&set, GL_ALPHA16F_EXT, GL_ALPHA, GL_HALF_FLOAT ); |
| 187 | InsertES3FormatCombo(&set, GL_ALPHA16F_EXT, GL_ALPHA, GL_HALF_FLOAT_OES ); |
| 188 | InsertES3FormatCombo(&set, GL_LUMINANCE16F_EXT, GL_LUMINANCE, GL_HALF_FLOAT ); |
| 189 | InsertES3FormatCombo(&set, GL_LUMINANCE16F_EXT, GL_LUMINANCE, GL_HALF_FLOAT_OES ); |
| 190 | InsertES3FormatCombo(&set, GL_LUMINANCE_ALPHA16F_EXT, GL_LUMINANCE_ALPHA, GL_HALF_FLOAT ); |
| 191 | InsertES3FormatCombo(&set, GL_LUMINANCE_ALPHA16F_EXT, GL_LUMINANCE_ALPHA, GL_HALF_FLOAT_OES ); |
| 192 | |
| 193 | // From GL_EXT_texture_storage and GL_EXT_texture_format_BGRA8888 |
| 194 | InsertES3FormatCombo(&set, GL_BGRA8_EXT, GL_BGRA_EXT, GL_UNSIGNED_BYTE ); |
| 195 | InsertES3FormatCombo(&set, GL_BGRA4_ANGLEX, GL_BGRA_EXT, GL_UNSIGNED_SHORT_4_4_4_4_REV_EXT); |
| 196 | InsertES3FormatCombo(&set, GL_BGRA4_ANGLEX, GL_BGRA_EXT, GL_UNSIGNED_BYTE ); |
| 197 | InsertES3FormatCombo(&set, GL_BGR5_A1_ANGLEX, GL_BGRA_EXT, GL_UNSIGNED_SHORT_1_5_5_5_REV_EXT); |
| 198 | InsertES3FormatCombo(&set, GL_BGR5_A1_ANGLEX, GL_BGRA_EXT, GL_UNSIGNED_BYTE ); |
| 199 | |
| 200 | // From GL_ANGLE_depth_texture |
| 201 | InsertES3FormatCombo(&set, GL_DEPTH_COMPONENT32_OES, GL_DEPTH_COMPONENT, GL_UNSIGNED_INT_24_8_OES ); |
| 202 | |
Vincent Lang | 25ab451 | 2016-05-13 18:13:59 +0200 | [diff] [blame] | 203 | // From GL_EXT_texture_norm16 |
| 204 | InsertES3FormatCombo(&set, GL_R16_EXT, GL_RED, GL_UNSIGNED_SHORT); |
| 205 | InsertES3FormatCombo(&set, GL_RG16_EXT, GL_RG, GL_UNSIGNED_SHORT); |
| 206 | InsertES3FormatCombo(&set, GL_RGB16_EXT, GL_RGB, GL_UNSIGNED_SHORT); |
| 207 | InsertES3FormatCombo(&set, GL_RGBA16_EXT, GL_RGBA, GL_UNSIGNED_SHORT); |
| 208 | InsertES3FormatCombo(&set, GL_R16_SNORM_EXT, GL_RED, GL_SHORT); |
| 209 | InsertES3FormatCombo(&set, GL_RG16_SNORM_EXT, GL_RG, GL_SHORT); |
| 210 | InsertES3FormatCombo(&set, GL_RGB16_SNORM_EXT, GL_RGB, GL_SHORT); |
| 211 | InsertES3FormatCombo(&set, GL_RGBA16_SNORM_EXT, GL_RGBA, GL_SHORT); |
| 212 | |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 213 | return set; |
| 214 | } |
| 215 | |
| 216 | static bool ValidateTexImageFormatCombination(gl::Context *context, GLenum internalFormat, GLenum format, GLenum type) |
| 217 | { |
Ian Ewell | fc7cf8e | 2016-01-20 15:57:46 -0500 | [diff] [blame] | 218 | // For historical reasons, glTexImage2D and glTexImage3D pass in their internal format as a |
| 219 | // GLint instead of a GLenum. Therefor an invalid internal format gives a GL_INVALID_VALUE |
| 220 | // error instead of a GL_INVALID_ENUM error. As this validation function is only called in |
| 221 | // the validation codepaths for glTexImage2D/3D, we record a GL_INVALID_VALUE error. |
Geoff Lang | baadf23 | 2014-08-04 13:58:02 -0400 | [diff] [blame] | 222 | const gl::InternalFormat &formatInfo = gl::GetInternalFormatInfo(internalFormat); |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 223 | if (!formatInfo.textureSupport(context->getClientMajorVersion(), context->getExtensions())) |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 224 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 225 | context->handleError(Error(GL_INVALID_VALUE)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 226 | return false; |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 227 | } |
| 228 | |
| 229 | // The type and format are valid if any supported internal format has that type and format |
| 230 | bool formatSupported = false; |
| 231 | bool typeSupported = false; |
| 232 | |
| 233 | static const ES3FormatCombinationSet es3FormatSet = BuildES3FormatSet(); |
| 234 | for (ES3FormatCombinationSet::const_iterator i = es3FormatSet.begin(); i != es3FormatSet.end(); i++) |
| 235 | { |
| 236 | if (i->format == format || i->type == type) |
| 237 | { |
| 238 | const gl::InternalFormat &info = gl::GetInternalFormatInfo(i->internalFormat); |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 239 | bool supported = |
| 240 | info.textureSupport(context->getClientMajorVersion(), context->getExtensions()); |
Geoff Lang | baadf23 | 2014-08-04 13:58:02 -0400 | [diff] [blame] | 241 | if (supported && i->type == type) |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 242 | { |
| 243 | typeSupported = true; |
| 244 | } |
Geoff Lang | baadf23 | 2014-08-04 13:58:02 -0400 | [diff] [blame] | 245 | if (supported && i->format == format) |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 246 | { |
| 247 | formatSupported = true; |
| 248 | } |
Geoff Lang | baadf23 | 2014-08-04 13:58:02 -0400 | [diff] [blame] | 249 | |
| 250 | // Early-out if both type and format are supported now |
| 251 | if (typeSupported && formatSupported) |
| 252 | { |
| 253 | break; |
| 254 | } |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 255 | } |
| 256 | } |
| 257 | |
| 258 | if (!typeSupported || !formatSupported) |
| 259 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 260 | context->handleError(Error(GL_INVALID_ENUM)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 261 | return false; |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 262 | } |
| 263 | |
| 264 | // Check if this is a valid format combination to load texture data |
| 265 | ES3FormatCombination searchFormat; |
| 266 | searchFormat.internalFormat = internalFormat; |
| 267 | searchFormat.format = format; |
| 268 | searchFormat.type = type; |
| 269 | |
| 270 | if (es3FormatSet.find(searchFormat) == es3FormatSet.end()) |
| 271 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 272 | context->handleError(Error(GL_INVALID_OPERATION)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 273 | return false; |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 274 | } |
| 275 | |
| 276 | return true; |
| 277 | } |
| 278 | |
Ian Ewell | fc7cf8e | 2016-01-20 15:57:46 -0500 | [diff] [blame] | 279 | bool ValidateES3TexImageParametersBase(Context *context, |
| 280 | GLenum target, |
| 281 | GLint level, |
| 282 | GLenum internalformat, |
| 283 | bool isCompressed, |
| 284 | bool isSubImage, |
| 285 | GLint xoffset, |
| 286 | GLint yoffset, |
| 287 | GLint zoffset, |
| 288 | GLsizei width, |
| 289 | GLsizei height, |
| 290 | GLsizei depth, |
| 291 | GLint border, |
| 292 | GLenum format, |
| 293 | GLenum type, |
| 294 | const GLvoid *pixels) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 295 | { |
| 296 | // Validate image size |
Austin Kinross | 08528e1 | 2015-10-07 16:24:40 -0700 | [diff] [blame] | 297 | if (!ValidImageSizeParameters(context, target, level, width, height, depth, isSubImage)) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 298 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 299 | context->handleError(Error(GL_INVALID_VALUE)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 300 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 301 | } |
| 302 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 303 | // Verify zero border |
| 304 | if (border != 0) |
| 305 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 306 | context->handleError(Error(GL_INVALID_VALUE)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 307 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 308 | } |
| 309 | |
Jamie Madill | 6f38f82 | 2014-06-06 17:12:20 -0400 | [diff] [blame] | 310 | if (xoffset < 0 || yoffset < 0 || zoffset < 0 || |
| 311 | std::numeric_limits<GLsizei>::max() - xoffset < width || |
| 312 | std::numeric_limits<GLsizei>::max() - yoffset < height || |
| 313 | std::numeric_limits<GLsizei>::max() - zoffset < depth) |
| 314 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 315 | context->handleError(Error(GL_INVALID_VALUE)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 316 | return false; |
Jamie Madill | 6f38f82 | 2014-06-06 17:12:20 -0400 | [diff] [blame] | 317 | } |
| 318 | |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 319 | const gl::Caps &caps = context->getCaps(); |
| 320 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 321 | switch (target) |
| 322 | { |
| 323 | case GL_TEXTURE_2D: |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 324 | if (static_cast<GLuint>(width) > (caps.max2DTextureSize >> level) || |
| 325 | static_cast<GLuint>(height) > (caps.max2DTextureSize >> level)) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 326 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 327 | context->handleError(Error(GL_INVALID_VALUE)); |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 328 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 329 | } |
| 330 | break; |
| 331 | |
| 332 | case GL_TEXTURE_CUBE_MAP_POSITIVE_X: |
| 333 | case GL_TEXTURE_CUBE_MAP_NEGATIVE_X: |
| 334 | case GL_TEXTURE_CUBE_MAP_POSITIVE_Y: |
| 335 | case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y: |
| 336 | case GL_TEXTURE_CUBE_MAP_POSITIVE_Z: |
| 337 | case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z: |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 338 | if (!isSubImage && width != height) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 339 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 340 | context->handleError(Error(GL_INVALID_VALUE)); |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 341 | return false; |
| 342 | } |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 343 | |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 344 | if (static_cast<GLuint>(width) > (caps.maxCubeMapTextureSize >> level)) |
| 345 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 346 | context->handleError(Error(GL_INVALID_VALUE)); |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 347 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 348 | } |
| 349 | break; |
| 350 | |
| 351 | case GL_TEXTURE_3D: |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 352 | if (static_cast<GLuint>(width) > (caps.max3DTextureSize >> level) || |
| 353 | static_cast<GLuint>(height) > (caps.max3DTextureSize >> level) || |
| 354 | static_cast<GLuint>(depth) > (caps.max3DTextureSize >> level)) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 355 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 356 | context->handleError(Error(GL_INVALID_VALUE)); |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 357 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 358 | } |
| 359 | break; |
| 360 | |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 361 | case GL_TEXTURE_2D_ARRAY: |
| 362 | if (static_cast<GLuint>(width) > (caps.max2DTextureSize >> level) || |
| 363 | static_cast<GLuint>(height) > (caps.max2DTextureSize >> level) || |
Geoff Lang | b92c133 | 2015-09-04 12:54:55 -0400 | [diff] [blame] | 364 | static_cast<GLuint>(depth) > caps.maxArrayTextureLayers) |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 365 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 366 | context->handleError(Error(GL_INVALID_VALUE)); |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 367 | return false; |
| 368 | } |
| 369 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 370 | |
| 371 | default: |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 372 | context->handleError(Error(GL_INVALID_ENUM)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 373 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 374 | } |
| 375 | |
Geoff Lang | 691e58c | 2014-12-19 17:03:25 -0500 | [diff] [blame] | 376 | gl::Texture *texture = context->getTargetTexture(IsCubeMapTextureTarget(target) ? GL_TEXTURE_CUBE_MAP : target); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 377 | if (!texture) |
| 378 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 379 | context->handleError(Error(GL_INVALID_OPERATION)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 380 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 381 | } |
| 382 | |
Geoff Lang | 69cce58 | 2015-09-17 13:20:36 -0400 | [diff] [blame] | 383 | if (texture->getImmutableFormat() && !isSubImage) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 384 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 385 | context->handleError(Error(GL_INVALID_OPERATION)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 386 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 387 | } |
| 388 | |
| 389 | // Validate texture formats |
Jamie Madill | a3944d4 | 2016-07-22 22:13:26 -0400 | [diff] [blame^] | 390 | GLenum actualInternalFormat = |
| 391 | isSubImage ? texture->getFormat(target, level).asSized() : internalformat; |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 392 | const gl::InternalFormat &actualFormatInfo = gl::GetInternalFormatInfo(actualInternalFormat); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 393 | if (isCompressed) |
| 394 | { |
tmartino | 7c10269 | 2015-10-02 16:43:40 -0400 | [diff] [blame] | 395 | if (!actualFormatInfo.compressed) |
Geoff Lang | d4f180b | 2013-09-24 13:57:44 -0400 | [diff] [blame] | 396 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 397 | context->handleError(Error( |
tmartino | 7c10269 | 2015-10-02 16:43:40 -0400 | [diff] [blame] | 398 | GL_INVALID_ENUM, "internalformat is not a supported compressed internal format.")); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 399 | return false; |
Geoff Lang | d4f180b | 2013-09-24 13:57:44 -0400 | [diff] [blame] | 400 | } |
| 401 | |
tmartino | 7c10269 | 2015-10-02 16:43:40 -0400 | [diff] [blame] | 402 | if (!ValidCompressedImageSize(context, actualInternalFormat, width, height)) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 403 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 404 | context->handleError(Error(GL_INVALID_OPERATION)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 405 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 406 | } |
| 407 | |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 408 | if (!actualFormatInfo.textureSupport(context->getClientMajorVersion(), |
| 409 | context->getExtensions())) |
Geoff Lang | 839ce0b | 2015-10-23 13:13:12 -0400 | [diff] [blame] | 410 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 411 | context->handleError(Error(GL_INVALID_ENUM)); |
Geoff Lang | 839ce0b | 2015-10-23 13:13:12 -0400 | [diff] [blame] | 412 | return false; |
| 413 | } |
| 414 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 415 | if (target == GL_TEXTURE_3D) |
| 416 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 417 | context->handleError(Error(GL_INVALID_OPERATION)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 418 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 419 | } |
| 420 | } |
| 421 | else |
| 422 | { |
Geoff Lang | baadf23 | 2014-08-04 13:58:02 -0400 | [diff] [blame] | 423 | if (!ValidateTexImageFormatCombination(context, actualInternalFormat, format, type)) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 424 | { |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 425 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 426 | } |
| 427 | |
| 428 | if (target == GL_TEXTURE_3D && (format == GL_DEPTH_COMPONENT || format == GL_DEPTH_STENCIL)) |
| 429 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 430 | context->handleError(Error(GL_INVALID_OPERATION)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 431 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 432 | } |
| 433 | } |
| 434 | |
| 435 | // Validate sub image parameters |
| 436 | if (isSubImage) |
| 437 | { |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 438 | if (isCompressed != actualFormatInfo.compressed) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 439 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 440 | context->handleError(Error(GL_INVALID_OPERATION)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 441 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 442 | } |
| 443 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 444 | if (width == 0 || height == 0 || depth == 0) |
| 445 | { |
| 446 | return false; |
| 447 | } |
| 448 | |
| 449 | if (xoffset < 0 || yoffset < 0 || zoffset < 0) |
| 450 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 451 | context->handleError(Error(GL_INVALID_VALUE)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 452 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 453 | } |
| 454 | |
| 455 | if (std::numeric_limits<GLsizei>::max() - xoffset < width || |
| 456 | std::numeric_limits<GLsizei>::max() - yoffset < height || |
| 457 | std::numeric_limits<GLsizei>::max() - zoffset < depth) |
| 458 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 459 | context->handleError(Error(GL_INVALID_VALUE)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 460 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 461 | } |
| 462 | |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 463 | if (static_cast<size_t>(xoffset + width) > texture->getWidth(target, level) || |
| 464 | static_cast<size_t>(yoffset + height) > texture->getHeight(target, level) || |
| 465 | static_cast<size_t>(zoffset + depth) > texture->getDepth(target, level)) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 466 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 467 | context->handleError(Error(GL_INVALID_VALUE)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 468 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 469 | } |
| 470 | } |
| 471 | |
Jamie Madill | efb2a6f | 2013-09-24 10:22:42 -0400 | [diff] [blame] | 472 | // Check for pixel unpack buffer related API errors |
Jamie Madill | dfde6ab | 2016-06-09 07:07:18 -0700 | [diff] [blame] | 473 | gl::Buffer *pixelUnpackBuffer = context->getGLState().getTargetBuffer(GL_PIXEL_UNPACK_BUFFER); |
Jamie Madill | efb2a6f | 2013-09-24 10:22:42 -0400 | [diff] [blame] | 474 | if (pixelUnpackBuffer != NULL) |
| 475 | { |
| 476 | // ...the data would be unpacked from the buffer object such that the memory reads required |
| 477 | // would exceed the data store size. |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 478 | GLenum sizedFormat = GetSizedInternalFormat(actualInternalFormat, type); |
Jamie Madill | c751d1e | 2014-10-21 17:46:29 -0400 | [diff] [blame] | 479 | const gl::InternalFormat &formatInfo = gl::GetInternalFormatInfo(sizedFormat); |
Jamie Madill | 4b4cdff | 2016-06-06 13:53:38 -0700 | [diff] [blame] | 480 | const gl::Extents size(width, height, depth); |
Jamie Madill | dfde6ab | 2016-06-09 07:07:18 -0700 | [diff] [blame] | 481 | const auto &unpack = context->getGLState().getUnpackState(); |
Jamie Madill | 4b4cdff | 2016-06-06 13:53:38 -0700 | [diff] [blame] | 482 | |
| 483 | auto copyBytesOrErr = formatInfo.computeUnpackSize(type, size, unpack); |
Jamie Madill | e2e406c | 2016-06-02 13:04:10 -0400 | [diff] [blame] | 484 | if (copyBytesOrErr.isError()) |
| 485 | { |
| 486 | context->handleError(copyBytesOrErr.getError()); |
| 487 | return false; |
| 488 | } |
| 489 | CheckedNumeric<size_t> checkedCopyBytes(copyBytesOrErr.getResult()); |
| 490 | CheckedNumeric<size_t> checkedOffset(reinterpret_cast<size_t>(pixels)); |
| 491 | checkedCopyBytes += checkedOffset; |
Jamie Madill | efb2a6f | 2013-09-24 10:22:42 -0400 | [diff] [blame] | 492 | |
Olli Etuaho | 989cac3 | 2016-06-08 16:18:49 -0700 | [diff] [blame] | 493 | auto rowPitchOrErr = |
| 494 | formatInfo.computeRowPitch(type, width, unpack.alignment, unpack.rowLength); |
| 495 | if (rowPitchOrErr.isError()) |
| 496 | { |
| 497 | context->handleError(rowPitchOrErr.getError()); |
| 498 | return false; |
| 499 | } |
| 500 | auto depthPitchOrErr = formatInfo.computeDepthPitch(type, width, height, unpack.alignment, |
| 501 | unpack.rowLength, unpack.imageHeight); |
| 502 | if (depthPitchOrErr.isError()) |
| 503 | { |
| 504 | context->handleError(depthPitchOrErr.getError()); |
| 505 | return false; |
| 506 | } |
| 507 | |
| 508 | bool targetIs3D = target == GL_TEXTURE_3D || target == GL_TEXTURE_2D_ARRAY; |
| 509 | auto skipBytesOrErr = formatInfo.computeSkipBytes( |
| 510 | rowPitchOrErr.getResult(), depthPitchOrErr.getResult(), unpack.skipImages, |
| 511 | unpack.skipRows, unpack.skipPixels, targetIs3D); |
| 512 | if (skipBytesOrErr.isError()) |
| 513 | { |
| 514 | context->handleError(skipBytesOrErr.getError()); |
| 515 | return false; |
| 516 | } |
| 517 | checkedCopyBytes += skipBytesOrErr.getResult(); |
| 518 | |
Jamie Madill | e2e406c | 2016-06-02 13:04:10 -0400 | [diff] [blame] | 519 | if (!checkedCopyBytes.IsValid() || |
| 520 | (checkedCopyBytes.ValueOrDie() > static_cast<size_t>(pixelUnpackBuffer->getSize()))) |
Jamie Madill | efb2a6f | 2013-09-24 10:22:42 -0400 | [diff] [blame] | 521 | { |
| 522 | // Overflow past the end of the buffer |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 523 | context->handleError(Error(GL_INVALID_OPERATION)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 524 | return false; |
Jamie Madill | efb2a6f | 2013-09-24 10:22:42 -0400 | [diff] [blame] | 525 | } |
| 526 | |
| 527 | // ...data is not evenly divisible into the number of bytes needed to store in memory a datum |
| 528 | // indicated by type. |
Jamie Madill | c751d1e | 2014-10-21 17:46:29 -0400 | [diff] [blame] | 529 | if (!isCompressed) |
Jamie Madill | efb2a6f | 2013-09-24 10:22:42 -0400 | [diff] [blame] | 530 | { |
Jamie Madill | c751d1e | 2014-10-21 17:46:29 -0400 | [diff] [blame] | 531 | size_t dataBytesPerPixel = static_cast<size_t>(gl::GetTypeInfo(type).bytes); |
| 532 | |
Jamie Madill | e2e406c | 2016-06-02 13:04:10 -0400 | [diff] [blame] | 533 | if ((checkedOffset.ValueOrDie() % dataBytesPerPixel) != 0) |
Jamie Madill | c751d1e | 2014-10-21 17:46:29 -0400 | [diff] [blame] | 534 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 535 | context->handleError(Error(GL_INVALID_OPERATION)); |
Jamie Madill | c751d1e | 2014-10-21 17:46:29 -0400 | [diff] [blame] | 536 | return false; |
| 537 | } |
Jamie Madill | efb2a6f | 2013-09-24 10:22:42 -0400 | [diff] [blame] | 538 | } |
| 539 | |
Jamie Madill | 7a5f738 | 2014-03-05 15:01:24 -0500 | [diff] [blame] | 540 | // ...the buffer object's data store is currently mapped. |
Brandon Jones | d38f926 | 2014-06-18 16:26:45 -0700 | [diff] [blame] | 541 | if (pixelUnpackBuffer->isMapped()) |
Jamie Madill | 7a5f738 | 2014-03-05 15:01:24 -0500 | [diff] [blame] | 542 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 543 | context->handleError(Error(GL_INVALID_OPERATION)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 544 | return false; |
Jamie Madill | 7a5f738 | 2014-03-05 15:01:24 -0500 | [diff] [blame] | 545 | } |
Jamie Madill | efb2a6f | 2013-09-24 10:22:42 -0400 | [diff] [blame] | 546 | } |
| 547 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 548 | return true; |
| 549 | } |
| 550 | |
Ian Ewell | fc7cf8e | 2016-01-20 15:57:46 -0500 | [diff] [blame] | 551 | bool ValidateES3TexImage2DParameters(Context *context, |
| 552 | GLenum target, |
| 553 | GLint level, |
| 554 | GLenum internalformat, |
| 555 | bool isCompressed, |
| 556 | bool isSubImage, |
| 557 | GLint xoffset, |
| 558 | GLint yoffset, |
| 559 | GLint zoffset, |
| 560 | GLsizei width, |
| 561 | GLsizei height, |
| 562 | GLsizei depth, |
| 563 | GLint border, |
| 564 | GLenum format, |
| 565 | GLenum type, |
| 566 | const GLvoid *pixels) |
| 567 | { |
| 568 | if (!ValidTexture2DDestinationTarget(context, target)) |
| 569 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 570 | context->handleError(Error(GL_INVALID_ENUM)); |
Ian Ewell | fc7cf8e | 2016-01-20 15:57:46 -0500 | [diff] [blame] | 571 | return false; |
| 572 | } |
| 573 | |
| 574 | return ValidateES3TexImageParametersBase(context, target, level, internalformat, isCompressed, |
| 575 | isSubImage, xoffset, yoffset, zoffset, width, height, |
| 576 | depth, border, format, type, pixels); |
| 577 | } |
| 578 | |
| 579 | bool ValidateES3TexImage3DParameters(Context *context, |
| 580 | GLenum target, |
| 581 | GLint level, |
| 582 | GLenum internalformat, |
| 583 | bool isCompressed, |
| 584 | bool isSubImage, |
| 585 | GLint xoffset, |
| 586 | GLint yoffset, |
| 587 | GLint zoffset, |
| 588 | GLsizei width, |
| 589 | GLsizei height, |
| 590 | GLsizei depth, |
| 591 | GLint border, |
| 592 | GLenum format, |
| 593 | GLenum type, |
| 594 | const GLvoid *pixels) |
| 595 | { |
| 596 | if (!ValidTexture3DDestinationTarget(context, target)) |
| 597 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 598 | context->handleError(Error(GL_INVALID_ENUM)); |
Ian Ewell | fc7cf8e | 2016-01-20 15:57:46 -0500 | [diff] [blame] | 599 | return false; |
| 600 | } |
| 601 | |
| 602 | return ValidateES3TexImageParametersBase(context, target, level, internalformat, isCompressed, |
| 603 | isSubImage, xoffset, yoffset, zoffset, width, height, |
| 604 | depth, border, format, type, pixels); |
| 605 | } |
| 606 | |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 607 | struct EffectiveInternalFormatInfo |
| 608 | { |
| 609 | GLenum mEffectiveFormat; |
| 610 | GLenum mDestFormat; |
| 611 | GLuint mMinRedBits; |
| 612 | GLuint mMaxRedBits; |
| 613 | GLuint mMinGreenBits; |
| 614 | GLuint mMaxGreenBits; |
| 615 | GLuint mMinBlueBits; |
| 616 | GLuint mMaxBlueBits; |
| 617 | GLuint mMinAlphaBits; |
| 618 | GLuint mMaxAlphaBits; |
| 619 | |
| 620 | EffectiveInternalFormatInfo(GLenum effectiveFormat, GLenum destFormat, GLuint minRedBits, GLuint maxRedBits, |
| 621 | GLuint minGreenBits, GLuint maxGreenBits, GLuint minBlueBits, GLuint maxBlueBits, |
| 622 | GLuint minAlphaBits, GLuint maxAlphaBits) |
| 623 | : mEffectiveFormat(effectiveFormat), mDestFormat(destFormat), mMinRedBits(minRedBits), |
| 624 | mMaxRedBits(maxRedBits), mMinGreenBits(minGreenBits), mMaxGreenBits(maxGreenBits), |
| 625 | mMinBlueBits(minBlueBits), mMaxBlueBits(maxBlueBits), mMinAlphaBits(minAlphaBits), |
| 626 | mMaxAlphaBits(maxAlphaBits) {}; |
| 627 | }; |
| 628 | |
| 629 | typedef std::vector<EffectiveInternalFormatInfo> EffectiveInternalFormatList; |
| 630 | |
| 631 | static EffectiveInternalFormatList BuildSizedEffectiveInternalFormatList() |
| 632 | { |
| 633 | EffectiveInternalFormatList list; |
| 634 | |
| 635 | // OpenGL ES 3.0.3 Specification, Table 3.17, pg 141: Effective internal format coresponding to destination internal format and |
| 636 | // linear source buffer component sizes. |
| 637 | // | Source channel min/max sizes | |
| 638 | // Effective Internal Format | N/A | R | G | B | A | |
| 639 | list.push_back(EffectiveInternalFormatInfo(GL_ALPHA8_EXT, GL_NONE, 0, 0, 0, 0, 0, 0, 1, 8)); |
| 640 | list.push_back(EffectiveInternalFormatInfo(GL_R8, GL_NONE, 1, 8, 0, 0, 0, 0, 0, 0)); |
| 641 | list.push_back(EffectiveInternalFormatInfo(GL_RG8, GL_NONE, 1, 8, 1, 8, 0, 0, 0, 0)); |
| 642 | list.push_back(EffectiveInternalFormatInfo(GL_RGB565, GL_NONE, 1, 5, 1, 6, 1, 5, 0, 0)); |
| 643 | list.push_back(EffectiveInternalFormatInfo(GL_RGB8, GL_NONE, 6, 8, 7, 8, 6, 8, 0, 0)); |
| 644 | list.push_back(EffectiveInternalFormatInfo(GL_RGBA4, GL_NONE, 1, 4, 1, 4, 1, 4, 1, 4)); |
| 645 | list.push_back(EffectiveInternalFormatInfo(GL_RGB5_A1, GL_NONE, 5, 5, 5, 5, 5, 5, 1, 1)); |
| 646 | list.push_back(EffectiveInternalFormatInfo(GL_RGBA8, GL_NONE, 5, 8, 5, 8, 5, 8, 2, 8)); |
| 647 | list.push_back(EffectiveInternalFormatInfo(GL_RGB10_A2, GL_NONE, 9, 10, 9, 10, 9, 10, 2, 2)); |
| 648 | |
| 649 | return list; |
| 650 | } |
| 651 | |
| 652 | static EffectiveInternalFormatList BuildUnsizedEffectiveInternalFormatList() |
| 653 | { |
| 654 | EffectiveInternalFormatList list; |
| 655 | |
| 656 | // OpenGL ES 3.0.3 Specification, Table 3.17, pg 141: Effective internal format coresponding to destination internal format and |
| 657 | // linear source buffer component sizes. |
| 658 | // | Source channel min/max sizes | |
| 659 | // Effective Internal Format | Dest Format | R | G | B | A | |
| 660 | list.push_back(EffectiveInternalFormatInfo(GL_ALPHA8_EXT, GL_ALPHA, 0, UINT_MAX, 0, UINT_MAX, 0, UINT_MAX, 1, 8)); |
| 661 | list.push_back(EffectiveInternalFormatInfo(GL_LUMINANCE8_EXT, GL_LUMINANCE, 1, 8, 0, UINT_MAX, 0, UINT_MAX, 0, UINT_MAX)); |
| 662 | list.push_back(EffectiveInternalFormatInfo(GL_LUMINANCE8_ALPHA8_EXT, GL_LUMINANCE_ALPHA, 1, 8, 0, UINT_MAX, 0, UINT_MAX, 1, 8)); |
| 663 | list.push_back(EffectiveInternalFormatInfo(GL_RGB565, GL_RGB, 1, 5, 1, 6, 1, 5, 0, UINT_MAX)); |
| 664 | list.push_back(EffectiveInternalFormatInfo(GL_RGB8, GL_RGB, 6, 8, 7, 8, 6, 8, 0, UINT_MAX)); |
| 665 | list.push_back(EffectiveInternalFormatInfo(GL_RGBA4, GL_RGBA, 1, 4, 1, 4, 1, 4, 1, 4)); |
| 666 | list.push_back(EffectiveInternalFormatInfo(GL_RGB5_A1, GL_RGBA, 5, 5, 5, 5, 5, 5, 1, 1)); |
| 667 | list.push_back(EffectiveInternalFormatInfo(GL_RGBA8, GL_RGBA, 5, 8, 5, 8, 5, 8, 5, 8)); |
| 668 | |
| 669 | return list; |
| 670 | } |
| 671 | |
| 672 | static bool GetEffectiveInternalFormat(const InternalFormat &srcFormat, const InternalFormat &destFormat, |
| 673 | GLenum *outEffectiveFormat) |
| 674 | { |
| 675 | const EffectiveInternalFormatList *list = NULL; |
| 676 | GLenum targetFormat = GL_NONE; |
| 677 | |
| 678 | if (destFormat.pixelBytes > 0) |
| 679 | { |
| 680 | static const EffectiveInternalFormatList sizedList = BuildSizedEffectiveInternalFormatList(); |
| 681 | list = &sizedList; |
| 682 | } |
| 683 | else |
| 684 | { |
| 685 | static const EffectiveInternalFormatList unsizedList = BuildUnsizedEffectiveInternalFormatList(); |
| 686 | list = &unsizedList; |
| 687 | targetFormat = destFormat.format; |
| 688 | } |
| 689 | |
| 690 | for (size_t curFormat = 0; curFormat < list->size(); ++curFormat) |
| 691 | { |
| 692 | const EffectiveInternalFormatInfo& formatInfo = list->at(curFormat); |
| 693 | if ((formatInfo.mDestFormat == targetFormat) && |
| 694 | (formatInfo.mMinRedBits <= srcFormat.redBits && formatInfo.mMaxRedBits >= srcFormat.redBits) && |
| 695 | (formatInfo.mMinGreenBits <= srcFormat.greenBits && formatInfo.mMaxGreenBits >= srcFormat.greenBits) && |
| 696 | (formatInfo.mMinBlueBits <= srcFormat.blueBits && formatInfo.mMaxBlueBits >= srcFormat.blueBits) && |
| 697 | (formatInfo.mMinAlphaBits <= srcFormat.alphaBits && formatInfo.mMaxAlphaBits >= srcFormat.alphaBits)) |
| 698 | { |
| 699 | *outEffectiveFormat = formatInfo.mEffectiveFormat; |
| 700 | return true; |
| 701 | } |
| 702 | } |
| 703 | |
| 704 | return false; |
| 705 | } |
| 706 | |
| 707 | struct CopyConversion |
| 708 | { |
| 709 | GLenum mTextureFormat; |
| 710 | GLenum mFramebufferFormat; |
| 711 | |
| 712 | CopyConversion(GLenum textureFormat, GLenum framebufferFormat) |
| 713 | : mTextureFormat(textureFormat), mFramebufferFormat(framebufferFormat) { } |
| 714 | |
| 715 | bool operator<(const CopyConversion& other) const |
| 716 | { |
| 717 | return memcmp(this, &other, sizeof(CopyConversion)) < 0; |
| 718 | } |
| 719 | }; |
| 720 | |
| 721 | typedef std::set<CopyConversion> CopyConversionSet; |
| 722 | |
| 723 | static CopyConversionSet BuildValidES3CopyTexImageCombinations() |
| 724 | { |
| 725 | CopyConversionSet set; |
| 726 | |
| 727 | // From ES 3.0.1 spec, table 3.15 |
| 728 | set.insert(CopyConversion(GL_ALPHA, GL_RGBA)); |
| 729 | set.insert(CopyConversion(GL_LUMINANCE, GL_RED)); |
| 730 | set.insert(CopyConversion(GL_LUMINANCE, GL_RG)); |
| 731 | set.insert(CopyConversion(GL_LUMINANCE, GL_RGB)); |
| 732 | set.insert(CopyConversion(GL_LUMINANCE, GL_RGBA)); |
| 733 | set.insert(CopyConversion(GL_LUMINANCE_ALPHA, GL_RGBA)); |
| 734 | set.insert(CopyConversion(GL_RED, GL_RED)); |
| 735 | set.insert(CopyConversion(GL_RED, GL_RG)); |
| 736 | set.insert(CopyConversion(GL_RED, GL_RGB)); |
| 737 | set.insert(CopyConversion(GL_RED, GL_RGBA)); |
| 738 | set.insert(CopyConversion(GL_RG, GL_RG)); |
| 739 | set.insert(CopyConversion(GL_RG, GL_RGB)); |
| 740 | set.insert(CopyConversion(GL_RG, GL_RGBA)); |
| 741 | set.insert(CopyConversion(GL_RGB, GL_RGB)); |
| 742 | set.insert(CopyConversion(GL_RGB, GL_RGBA)); |
| 743 | set.insert(CopyConversion(GL_RGBA, GL_RGBA)); |
| 744 | |
| 745 | // Necessary for ANGLE back-buffers |
| 746 | set.insert(CopyConversion(GL_ALPHA, GL_BGRA_EXT)); |
| 747 | set.insert(CopyConversion(GL_LUMINANCE, GL_BGRA_EXT)); |
| 748 | set.insert(CopyConversion(GL_LUMINANCE_ALPHA, GL_BGRA_EXT)); |
| 749 | set.insert(CopyConversion(GL_RED, GL_BGRA_EXT)); |
| 750 | set.insert(CopyConversion(GL_RG, GL_BGRA_EXT)); |
| 751 | set.insert(CopyConversion(GL_RGB, GL_BGRA_EXT)); |
| 752 | set.insert(CopyConversion(GL_RGBA, GL_BGRA_EXT)); |
| 753 | |
| 754 | set.insert(CopyConversion(GL_RED_INTEGER, GL_RED_INTEGER)); |
| 755 | set.insert(CopyConversion(GL_RED_INTEGER, GL_RG_INTEGER)); |
| 756 | set.insert(CopyConversion(GL_RED_INTEGER, GL_RGB_INTEGER)); |
| 757 | set.insert(CopyConversion(GL_RED_INTEGER, GL_RGBA_INTEGER)); |
| 758 | set.insert(CopyConversion(GL_RG_INTEGER, GL_RG_INTEGER)); |
| 759 | set.insert(CopyConversion(GL_RG_INTEGER, GL_RGB_INTEGER)); |
| 760 | set.insert(CopyConversion(GL_RG_INTEGER, GL_RGBA_INTEGER)); |
| 761 | set.insert(CopyConversion(GL_RGB_INTEGER, GL_RGB_INTEGER)); |
| 762 | set.insert(CopyConversion(GL_RGB_INTEGER, GL_RGBA_INTEGER)); |
| 763 | set.insert(CopyConversion(GL_RGBA_INTEGER, GL_RGBA_INTEGER)); |
| 764 | |
| 765 | return set; |
| 766 | } |
| 767 | |
Corentin Wallez | 7628768 | 2016-04-25 09:23:38 -0400 | [diff] [blame] | 768 | static bool EqualOrFirstZero(GLuint first, GLuint second) |
| 769 | { |
| 770 | return first == 0 || first == second; |
| 771 | } |
| 772 | |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 773 | static bool IsValidES3CopyTexImageCombination(GLenum textureInternalFormat, GLenum frameBufferInternalFormat, GLuint readBufferHandle) |
| 774 | { |
| 775 | const InternalFormat &textureInternalFormatInfo = GetInternalFormatInfo(textureInternalFormat); |
| 776 | const InternalFormat &framebufferInternalFormatInfo = GetInternalFormatInfo(frameBufferInternalFormat); |
| 777 | |
| 778 | static const CopyConversionSet conversionSet = BuildValidES3CopyTexImageCombinations(); |
| 779 | if (conversionSet.find(CopyConversion(textureInternalFormatInfo.format, framebufferInternalFormatInfo.format)) != conversionSet.end()) |
| 780 | { |
| 781 | // Section 3.8.5 of the GLES 3.0.3 spec states that source and destination formats |
| 782 | // must both be signed, unsigned, or fixed point and both source and destinations |
| 783 | // must be either both SRGB or both not SRGB. EXT_color_buffer_float adds allowed |
| 784 | // conversion between fixed and floating point. |
| 785 | |
| 786 | if ((textureInternalFormatInfo.colorEncoding == GL_SRGB) != (framebufferInternalFormatInfo.colorEncoding == GL_SRGB)) |
| 787 | { |
| 788 | return false; |
| 789 | } |
| 790 | |
| 791 | if (((textureInternalFormatInfo.componentType == GL_INT) != (framebufferInternalFormatInfo.componentType == GL_INT )) || |
| 792 | ((textureInternalFormatInfo.componentType == GL_UNSIGNED_INT) != (framebufferInternalFormatInfo.componentType == GL_UNSIGNED_INT))) |
| 793 | { |
| 794 | return false; |
| 795 | } |
| 796 | |
| 797 | if ((textureInternalFormatInfo.componentType == GL_UNSIGNED_NORMALIZED || |
| 798 | textureInternalFormatInfo.componentType == GL_SIGNED_NORMALIZED || |
| 799 | textureInternalFormatInfo.componentType == GL_FLOAT) && |
| 800 | !(framebufferInternalFormatInfo.componentType == GL_UNSIGNED_NORMALIZED || |
| 801 | framebufferInternalFormatInfo.componentType == GL_SIGNED_NORMALIZED || |
| 802 | framebufferInternalFormatInfo.componentType == GL_FLOAT)) |
| 803 | { |
| 804 | return false; |
| 805 | } |
| 806 | |
| 807 | // GLES specification 3.0.3, sec 3.8.5, pg 139-140: |
| 808 | // The effective internal format of the source buffer is determined with the following rules applied in order: |
| 809 | // * If the source buffer is a texture or renderbuffer that was created with a sized internal format then the |
| 810 | // effective internal format is the source buffer's sized internal format. |
| 811 | // * If the source buffer is a texture that was created with an unsized base internal format, then the |
| 812 | // effective internal format is the source image array's effective internal format, as specified by table |
| 813 | // 3.12, which is determined from the <format> and <type> that were used when the source image array was |
| 814 | // specified by TexImage*. |
| 815 | // * Otherwise the effective internal format is determined by the row in table 3.17 or 3.18 where |
| 816 | // Destination Internal Format matches internalformat and where the [source channel sizes] are consistent |
| 817 | // with the values of the source buffer's [channel sizes]. Table 3.17 is used if the |
| 818 | // FRAMEBUFFER_ATTACHMENT_ENCODING is LINEAR and table 3.18 is used if the FRAMEBUFFER_ATTACHMENT_ENCODING |
| 819 | // is SRGB. |
| 820 | const InternalFormat *sourceEffectiveFormat = NULL; |
| 821 | if (readBufferHandle != 0) |
| 822 | { |
| 823 | // Not the default framebuffer, therefore the read buffer must be a user-created texture or renderbuffer |
| 824 | if (framebufferInternalFormatInfo.pixelBytes > 0) |
| 825 | { |
| 826 | sourceEffectiveFormat = &framebufferInternalFormatInfo; |
| 827 | } |
| 828 | else |
| 829 | { |
| 830 | // Renderbuffers cannot be created with an unsized internal format, so this must be an unsized-format |
| 831 | // texture. We can use the same table we use when creating textures to get its effective sized format. |
Geoff Lang | 051dbc7 | 2015-01-05 15:48:58 -0500 | [diff] [blame] | 832 | GLenum sizedInternalFormat = GetSizedInternalFormat(framebufferInternalFormatInfo.format, framebufferInternalFormatInfo.type); |
| 833 | sourceEffectiveFormat = &GetInternalFormatInfo(sizedInternalFormat); |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 834 | } |
| 835 | } |
| 836 | else |
| 837 | { |
| 838 | // The effective internal format must be derived from the source framebuffer's channel sizes. |
| 839 | // This is done in GetEffectiveInternalFormat for linear buffers (table 3.17) |
| 840 | if (framebufferInternalFormatInfo.colorEncoding == GL_LINEAR) |
| 841 | { |
| 842 | GLenum effectiveFormat; |
| 843 | if (GetEffectiveInternalFormat(framebufferInternalFormatInfo, textureInternalFormatInfo, &effectiveFormat)) |
| 844 | { |
| 845 | sourceEffectiveFormat = &GetInternalFormatInfo(effectiveFormat); |
| 846 | } |
| 847 | else |
| 848 | { |
| 849 | return false; |
| 850 | } |
| 851 | } |
| 852 | else if (framebufferInternalFormatInfo.colorEncoding == GL_SRGB) |
| 853 | { |
| 854 | // SRGB buffers can only be copied to sized format destinations according to table 3.18 |
| 855 | if ((textureInternalFormatInfo.pixelBytes > 0) && |
| 856 | (framebufferInternalFormatInfo.redBits >= 1 && framebufferInternalFormatInfo.redBits <= 8) && |
| 857 | (framebufferInternalFormatInfo.greenBits >= 1 && framebufferInternalFormatInfo.greenBits <= 8) && |
| 858 | (framebufferInternalFormatInfo.blueBits >= 1 && framebufferInternalFormatInfo.blueBits <= 8) && |
| 859 | (framebufferInternalFormatInfo.alphaBits >= 1 && framebufferInternalFormatInfo.alphaBits <= 8)) |
| 860 | { |
| 861 | sourceEffectiveFormat = &GetInternalFormatInfo(GL_SRGB8_ALPHA8); |
| 862 | } |
| 863 | else |
| 864 | { |
| 865 | return false; |
| 866 | } |
| 867 | } |
| 868 | else |
| 869 | { |
| 870 | UNREACHABLE(); |
| 871 | return false; |
| 872 | } |
| 873 | } |
| 874 | |
| 875 | if (textureInternalFormatInfo.pixelBytes > 0) |
| 876 | { |
Corentin Wallez | 7628768 | 2016-04-25 09:23:38 -0400 | [diff] [blame] | 877 | // Section 3.8.5 of the GLES 3.0.3 spec, pg 139, requires that, if the destination |
| 878 | // format is sized, component sizes of the source and destination formats must exactly |
| 879 | // match if the destination format exists. |
| 880 | if (!EqualOrFirstZero(textureInternalFormatInfo.redBits, |
| 881 | sourceEffectiveFormat->redBits) || |
| 882 | !EqualOrFirstZero(textureInternalFormatInfo.greenBits, |
| 883 | sourceEffectiveFormat->greenBits) || |
| 884 | !EqualOrFirstZero(textureInternalFormatInfo.blueBits, |
| 885 | sourceEffectiveFormat->blueBits) || |
| 886 | !EqualOrFirstZero(textureInternalFormatInfo.alphaBits, |
| 887 | sourceEffectiveFormat->alphaBits)) |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 888 | { |
| 889 | return false; |
| 890 | } |
| 891 | } |
| 892 | |
| 893 | |
| 894 | return true; // A conversion function exists, and no rule in the specification has precluded conversion |
| 895 | // between these formats. |
| 896 | } |
| 897 | |
| 898 | return false; |
| 899 | } |
| 900 | |
Ian Ewell | fc7cf8e | 2016-01-20 15:57:46 -0500 | [diff] [blame] | 901 | bool ValidateES3CopyTexImageParametersBase(ValidationContext *context, |
| 902 | GLenum target, |
| 903 | GLint level, |
| 904 | GLenum internalformat, |
| 905 | bool isSubImage, |
| 906 | GLint xoffset, |
| 907 | GLint yoffset, |
| 908 | GLint zoffset, |
| 909 | GLint x, |
| 910 | GLint y, |
| 911 | GLsizei width, |
| 912 | GLsizei height, |
| 913 | GLint border) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 914 | { |
Jamie Madill | a3944d4 | 2016-07-22 22:13:26 -0400 | [diff] [blame^] | 915 | GLenum textureInternalFormat = GL_NONE; |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 916 | if (!ValidateCopyTexImageParametersBase(context, target, level, internalformat, isSubImage, |
Jamie Madill | 6f38f82 | 2014-06-06 17:12:20 -0400 | [diff] [blame] | 917 | xoffset, yoffset, zoffset, x, y, width, height, |
| 918 | border, &textureInternalFormat)) |
Shannon Woods | 4dfed83 | 2014-03-17 20:03:39 -0400 | [diff] [blame] | 919 | { |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 920 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 921 | } |
Jamie Madill | a3944d4 | 2016-07-22 22:13:26 -0400 | [diff] [blame^] | 922 | ASSERT(textureInternalFormat != GL_NONE || !isSubImage); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 923 | |
Jamie Madill | 51f40ec | 2016-06-15 14:06:00 -0400 | [diff] [blame] | 924 | const auto &state = context->getGLState(); |
| 925 | gl::Framebuffer *framebuffer = state.getReadFramebuffer(); |
| 926 | GLuint readFramebufferID = framebuffer->id(); |
Jamie Madill | 3c7fa22 | 2014-06-05 13:08:51 -0400 | [diff] [blame] | 927 | |
Jamie Madill | dfde6ab | 2016-06-09 07:07:18 -0700 | [diff] [blame] | 928 | if (framebuffer->checkStatus(context->getContextState()) != GL_FRAMEBUFFER_COMPLETE) |
Jamie Madill | 3c7fa22 | 2014-06-05 13:08:51 -0400 | [diff] [blame] | 929 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 930 | context->handleError(Error(GL_INVALID_FRAMEBUFFER_OPERATION)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 931 | return false; |
Jamie Madill | 3c7fa22 | 2014-06-05 13:08:51 -0400 | [diff] [blame] | 932 | } |
| 933 | |
Jamie Madill | dfde6ab | 2016-06-09 07:07:18 -0700 | [diff] [blame] | 934 | if (readFramebufferID != 0 && framebuffer->getSamples(context->getContextState()) != 0) |
Jamie Madill | 3c7fa22 | 2014-06-05 13:08:51 -0400 | [diff] [blame] | 935 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 936 | context->handleError(Error(GL_INVALID_OPERATION)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 937 | return false; |
Jamie Madill | 3c7fa22 | 2014-06-05 13:08:51 -0400 | [diff] [blame] | 938 | } |
| 939 | |
Jamie Madill | b6bda4a | 2015-04-20 12:53:26 -0400 | [diff] [blame] | 940 | const gl::FramebufferAttachment *source = framebuffer->getReadColorbuffer(); |
Jamie Madill | a3944d4 | 2016-07-22 22:13:26 -0400 | [diff] [blame^] | 941 | GLenum colorbufferInternalFormat = source->getFormat().asSized(); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 942 | |
| 943 | if (isSubImage) |
| 944 | { |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 945 | if (!IsValidES3CopyTexImageCombination(textureInternalFormat, colorbufferInternalFormat, |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 946 | readFramebufferID)) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 947 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 948 | context->handleError(Error(GL_INVALID_OPERATION)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 949 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 950 | } |
| 951 | } |
Shannon Woods | 4d161ba | 2014-03-17 18:13:30 -0400 | [diff] [blame] | 952 | else |
| 953 | { |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 954 | if (!gl::IsValidES3CopyTexImageCombination(internalformat, colorbufferInternalFormat, |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 955 | readFramebufferID)) |
Shannon Woods | 4d161ba | 2014-03-17 18:13:30 -0400 | [diff] [blame] | 956 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 957 | context->handleError(Error(GL_INVALID_OPERATION)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 958 | return false; |
Shannon Woods | 4d161ba | 2014-03-17 18:13:30 -0400 | [diff] [blame] | 959 | } |
| 960 | } |
| 961 | |
Geoff Lang | 784a8fd | 2013-09-24 12:33:16 -0400 | [diff] [blame] | 962 | // If width or height is zero, it is a no-op. Return false without setting an error. |
| 963 | return (width > 0 && height > 0); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 964 | } |
| 965 | |
Ian Ewell | fc7cf8e | 2016-01-20 15:57:46 -0500 | [diff] [blame] | 966 | bool ValidateES3CopyTexImage2DParameters(ValidationContext *context, |
| 967 | GLenum target, |
| 968 | GLint level, |
| 969 | GLenum internalformat, |
| 970 | bool isSubImage, |
| 971 | GLint xoffset, |
| 972 | GLint yoffset, |
| 973 | GLint zoffset, |
| 974 | GLint x, |
| 975 | GLint y, |
| 976 | GLsizei width, |
| 977 | GLsizei height, |
| 978 | GLint border) |
| 979 | { |
| 980 | if (!ValidTexture2DDestinationTarget(context, target)) |
| 981 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 982 | context->handleError(Error(GL_INVALID_ENUM)); |
Ian Ewell | fc7cf8e | 2016-01-20 15:57:46 -0500 | [diff] [blame] | 983 | return false; |
| 984 | } |
| 985 | |
| 986 | return ValidateES3CopyTexImageParametersBase(context, target, level, internalformat, isSubImage, |
| 987 | xoffset, yoffset, zoffset, x, y, width, height, |
| 988 | border); |
| 989 | } |
| 990 | |
| 991 | bool ValidateES3CopyTexImage3DParameters(ValidationContext *context, |
| 992 | GLenum target, |
| 993 | GLint level, |
| 994 | GLenum internalformat, |
| 995 | bool isSubImage, |
| 996 | GLint xoffset, |
| 997 | GLint yoffset, |
| 998 | GLint zoffset, |
| 999 | GLint x, |
| 1000 | GLint y, |
| 1001 | GLsizei width, |
| 1002 | GLsizei height, |
| 1003 | GLint border) |
| 1004 | { |
| 1005 | if (!ValidTexture3DDestinationTarget(context, target)) |
| 1006 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1007 | context->handleError(Error(GL_INVALID_ENUM)); |
Ian Ewell | fc7cf8e | 2016-01-20 15:57:46 -0500 | [diff] [blame] | 1008 | return false; |
| 1009 | } |
| 1010 | |
| 1011 | return ValidateES3CopyTexImageParametersBase(context, target, level, internalformat, isSubImage, |
| 1012 | xoffset, yoffset, zoffset, x, y, width, height, |
| 1013 | border); |
| 1014 | } |
| 1015 | |
| 1016 | bool ValidateES3TexStorageParametersBase(Context *context, |
| 1017 | GLenum target, |
| 1018 | GLsizei levels, |
| 1019 | GLenum internalformat, |
| 1020 | GLsizei width, |
| 1021 | GLsizei height, |
| 1022 | GLsizei depth) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1023 | { |
| 1024 | if (width < 1 || height < 1 || depth < 1 || levels < 1) |
| 1025 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1026 | context->handleError(Error(GL_INVALID_VALUE)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1027 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1028 | } |
| 1029 | |
Geoff Lang | b92c133 | 2015-09-04 12:54:55 -0400 | [diff] [blame] | 1030 | GLsizei maxDim = std::max(width, height); |
| 1031 | if (target != GL_TEXTURE_2D_ARRAY) |
| 1032 | { |
| 1033 | maxDim = std::max(maxDim, depth); |
| 1034 | } |
| 1035 | |
| 1036 | if (levels > gl::log2(maxDim) + 1) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1037 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1038 | context->handleError(Error(GL_INVALID_OPERATION)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1039 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1040 | } |
| 1041 | |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 1042 | const gl::Caps &caps = context->getCaps(); |
| 1043 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1044 | switch (target) |
| 1045 | { |
| 1046 | case GL_TEXTURE_2D: |
| 1047 | { |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 1048 | if (static_cast<GLuint>(width) > caps.max2DTextureSize || |
| 1049 | static_cast<GLuint>(height) > caps.max2DTextureSize) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1050 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1051 | context->handleError(Error(GL_INVALID_VALUE)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1052 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1053 | } |
| 1054 | } |
| 1055 | break; |
| 1056 | |
Geoff Lang | 01c21d2 | 2013-09-24 11:52:16 -0400 | [diff] [blame] | 1057 | case GL_TEXTURE_CUBE_MAP: |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1058 | { |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1059 | if (width != height) |
| 1060 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1061 | context->handleError(Error(GL_INVALID_VALUE)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1062 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1063 | } |
| 1064 | |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 1065 | if (static_cast<GLuint>(width) > caps.maxCubeMapTextureSize) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1066 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1067 | context->handleError(Error(GL_INVALID_VALUE)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1068 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1069 | } |
| 1070 | } |
| 1071 | break; |
| 1072 | |
| 1073 | case GL_TEXTURE_3D: |
| 1074 | { |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 1075 | if (static_cast<GLuint>(width) > caps.max3DTextureSize || |
| 1076 | static_cast<GLuint>(height) > caps.max3DTextureSize || |
| 1077 | static_cast<GLuint>(depth) > caps.max3DTextureSize) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1078 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1079 | context->handleError(Error(GL_INVALID_VALUE)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1080 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1081 | } |
| 1082 | } |
| 1083 | break; |
| 1084 | |
| 1085 | case GL_TEXTURE_2D_ARRAY: |
| 1086 | { |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 1087 | if (static_cast<GLuint>(width) > caps.max2DTextureSize || |
| 1088 | static_cast<GLuint>(height) > caps.max2DTextureSize || |
| 1089 | static_cast<GLuint>(depth) > caps.maxArrayTextureLayers) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1090 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1091 | context->handleError(Error(GL_INVALID_VALUE)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1092 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1093 | } |
| 1094 | } |
| 1095 | break; |
| 1096 | |
| 1097 | default: |
Ian Ewell | fc7cf8e | 2016-01-20 15:57:46 -0500 | [diff] [blame] | 1098 | UNREACHABLE(); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1099 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1100 | } |
| 1101 | |
Geoff Lang | 691e58c | 2014-12-19 17:03:25 -0500 | [diff] [blame] | 1102 | gl::Texture *texture = context->getTargetTexture(target); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1103 | if (!texture || texture->id() == 0) |
| 1104 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1105 | context->handleError(Error(GL_INVALID_OPERATION)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1106 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1107 | } |
| 1108 | |
Geoff Lang | 69cce58 | 2015-09-17 13:20:36 -0400 | [diff] [blame] | 1109 | if (texture->getImmutableFormat()) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1110 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1111 | context->handleError(Error(GL_INVALID_OPERATION)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1112 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1113 | } |
| 1114 | |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 1115 | const gl::InternalFormat &formatInfo = gl::GetInternalFormatInfo(internalformat); |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1116 | if (!formatInfo.textureSupport(context->getClientMajorVersion(), context->getExtensions())) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1117 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1118 | context->handleError(Error(GL_INVALID_ENUM)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1119 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1120 | } |
| 1121 | |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 1122 | if (formatInfo.pixelBytes == 0) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1123 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1124 | context->handleError(Error(GL_INVALID_ENUM)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1125 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1126 | } |
| 1127 | |
| 1128 | return true; |
| 1129 | } |
| 1130 | |
Ian Ewell | fc7cf8e | 2016-01-20 15:57:46 -0500 | [diff] [blame] | 1131 | bool ValidateES3TexStorage2DParameters(Context *context, |
| 1132 | GLenum target, |
| 1133 | GLsizei levels, |
| 1134 | GLenum internalformat, |
| 1135 | GLsizei width, |
| 1136 | GLsizei height, |
| 1137 | GLsizei depth) |
| 1138 | { |
| 1139 | if (!ValidTexture2DTarget(context, target)) |
| 1140 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1141 | context->handleError(Error(GL_INVALID_ENUM)); |
Ian Ewell | fc7cf8e | 2016-01-20 15:57:46 -0500 | [diff] [blame] | 1142 | return false; |
| 1143 | } |
| 1144 | |
| 1145 | return ValidateES3TexStorageParametersBase(context, target, levels, internalformat, width, |
| 1146 | height, depth); |
| 1147 | } |
| 1148 | |
| 1149 | bool ValidateES3TexStorage3DParameters(Context *context, |
| 1150 | GLenum target, |
| 1151 | GLsizei levels, |
| 1152 | GLenum internalformat, |
| 1153 | GLsizei width, |
| 1154 | GLsizei height, |
| 1155 | GLsizei depth) |
| 1156 | { |
| 1157 | if (!ValidTexture3DTarget(context, target)) |
| 1158 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1159 | context->handleError(Error(GL_INVALID_ENUM)); |
Ian Ewell | fc7cf8e | 2016-01-20 15:57:46 -0500 | [diff] [blame] | 1160 | return false; |
| 1161 | } |
| 1162 | |
| 1163 | return ValidateES3TexStorageParametersBase(context, target, levels, internalformat, width, |
| 1164 | height, depth); |
| 1165 | } |
| 1166 | |
Ian Ewell | 3ffd78b | 2016-01-22 16:09:42 -0500 | [diff] [blame] | 1167 | bool ValidateBeginQuery(gl::Context *context, GLenum target, GLuint id) |
| 1168 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1169 | if (context->getClientMajorVersion() < 3) |
Ian Ewell | 3ffd78b | 2016-01-22 16:09:42 -0500 | [diff] [blame] | 1170 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1171 | context->handleError(Error(GL_INVALID_OPERATION, "GLES version < 3.0")); |
Ian Ewell | 3ffd78b | 2016-01-22 16:09:42 -0500 | [diff] [blame] | 1172 | return false; |
| 1173 | } |
| 1174 | |
| 1175 | return ValidateBeginQueryBase(context, target, id); |
| 1176 | } |
| 1177 | |
| 1178 | bool ValidateEndQuery(gl::Context *context, GLenum target) |
| 1179 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1180 | if (context->getClientMajorVersion() < 3) |
Ian Ewell | 3ffd78b | 2016-01-22 16:09:42 -0500 | [diff] [blame] | 1181 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1182 | context->handleError(Error(GL_INVALID_OPERATION, "GLES version < 3.0")); |
Ian Ewell | 3ffd78b | 2016-01-22 16:09:42 -0500 | [diff] [blame] | 1183 | return false; |
| 1184 | } |
| 1185 | |
| 1186 | return ValidateEndQueryBase(context, target); |
| 1187 | } |
| 1188 | |
| 1189 | bool ValidateGetQueryiv(Context *context, GLenum target, GLenum pname, GLint *params) |
| 1190 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1191 | if (context->getClientMajorVersion() < 3) |
Ian Ewell | 3ffd78b | 2016-01-22 16:09:42 -0500 | [diff] [blame] | 1192 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1193 | context->handleError(Error(GL_INVALID_OPERATION, "GLES version < 3.0")); |
Ian Ewell | 3ffd78b | 2016-01-22 16:09:42 -0500 | [diff] [blame] | 1194 | return false; |
| 1195 | } |
| 1196 | |
| 1197 | return ValidateGetQueryivBase(context, target, pname); |
| 1198 | } |
| 1199 | |
| 1200 | bool ValidateGetQueryObjectuiv(Context *context, GLuint id, GLenum pname, GLuint *params) |
| 1201 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1202 | if (context->getClientMajorVersion() < 3) |
Ian Ewell | 3ffd78b | 2016-01-22 16:09:42 -0500 | [diff] [blame] | 1203 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1204 | context->handleError(Error(GL_INVALID_OPERATION, "GLES version < 3.0")); |
Ian Ewell | 3ffd78b | 2016-01-22 16:09:42 -0500 | [diff] [blame] | 1205 | return false; |
| 1206 | } |
| 1207 | |
| 1208 | return ValidateGetQueryObjectValueBase(context, id, pname); |
| 1209 | } |
| 1210 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1211 | bool ValidateFramebufferTextureLayer(Context *context, GLenum target, GLenum attachment, |
Jamie Madill | 570f7c8 | 2014-07-03 10:38:54 -0400 | [diff] [blame] | 1212 | GLuint texture, GLint level, GLint layer) |
| 1213 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1214 | if (context->getClientMajorVersion() < 3) |
Jamie Madill | 570f7c8 | 2014-07-03 10:38:54 -0400 | [diff] [blame] | 1215 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1216 | context->handleError(Error(GL_INVALID_OPERATION)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1217 | return false; |
Jamie Madill | 570f7c8 | 2014-07-03 10:38:54 -0400 | [diff] [blame] | 1218 | } |
| 1219 | |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1220 | if (layer < 0) |
| 1221 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1222 | context->handleError(Error(GL_INVALID_VALUE)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1223 | return false; |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1224 | } |
| 1225 | |
| 1226 | if (!ValidateFramebufferTextureBase(context, target, attachment, texture, level)) |
| 1227 | { |
| 1228 | return false; |
| 1229 | } |
| 1230 | |
| 1231 | const gl::Caps &caps = context->getCaps(); |
| 1232 | if (texture != 0) |
| 1233 | { |
| 1234 | gl::Texture *tex = context->getTexture(texture); |
| 1235 | ASSERT(tex); |
| 1236 | |
| 1237 | switch (tex->getTarget()) |
| 1238 | { |
| 1239 | case GL_TEXTURE_2D_ARRAY: |
| 1240 | { |
| 1241 | if (level > gl::log2(caps.max2DTextureSize)) |
| 1242 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1243 | context->handleError(Error(GL_INVALID_VALUE)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1244 | return false; |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1245 | } |
| 1246 | |
| 1247 | if (static_cast<GLuint>(layer) >= caps.maxArrayTextureLayers) |
| 1248 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1249 | context->handleError(Error(GL_INVALID_VALUE)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1250 | return false; |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1251 | } |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1252 | } |
| 1253 | break; |
| 1254 | |
| 1255 | case GL_TEXTURE_3D: |
| 1256 | { |
| 1257 | if (level > gl::log2(caps.max3DTextureSize)) |
| 1258 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1259 | context->handleError(Error(GL_INVALID_VALUE)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1260 | return false; |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1261 | } |
| 1262 | |
| 1263 | if (static_cast<GLuint>(layer) >= caps.max3DTextureSize) |
| 1264 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1265 | context->handleError(Error(GL_INVALID_VALUE)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1266 | return false; |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1267 | } |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1268 | } |
| 1269 | break; |
| 1270 | |
| 1271 | default: |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1272 | context->handleError(Error(GL_INVALID_OPERATION)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1273 | return false; |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1274 | } |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 1275 | |
Jamie Madill | a3944d4 | 2016-07-22 22:13:26 -0400 | [diff] [blame^] | 1276 | const auto &format = tex->getFormat(tex->getTarget(), level); |
| 1277 | if (format.info->compressed) |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 1278 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1279 | context->handleError(Error(GL_INVALID_OPERATION)); |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 1280 | return false; |
| 1281 | } |
Jamie Madill | 55ec3b1 | 2014-07-03 10:38:57 -0400 | [diff] [blame] | 1282 | } |
| 1283 | |
| 1284 | return true; |
Jamie Madill | 570f7c8 | 2014-07-03 10:38:54 -0400 | [diff] [blame] | 1285 | } |
| 1286 | |
Jamie Madill | dfde6ab | 2016-06-09 07:07:18 -0700 | [diff] [blame] | 1287 | bool ValidES3ReadFormatType(ValidationContext *context, |
| 1288 | GLenum internalFormat, |
| 1289 | GLenum format, |
| 1290 | GLenum type) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1291 | { |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 1292 | const gl::InternalFormat &internalFormatInfo = gl::GetInternalFormatInfo(internalFormat); |
| 1293 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1294 | switch (format) |
| 1295 | { |
| 1296 | case GL_RGBA: |
| 1297 | switch (type) |
| 1298 | { |
| 1299 | case GL_UNSIGNED_BYTE: |
| 1300 | break; |
Vincent Lang | 25ab451 | 2016-05-13 18:13:59 +0200 | [diff] [blame] | 1301 | case GL_UNSIGNED_SHORT: |
| 1302 | if (internalFormatInfo.componentType != GL_UNSIGNED_NORMALIZED && |
| 1303 | internalFormatInfo.type != GL_UNSIGNED_SHORT) |
| 1304 | { |
| 1305 | return false; |
| 1306 | } |
| 1307 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1308 | case GL_UNSIGNED_INT_2_10_10_10_REV: |
| 1309 | if (internalFormat != GL_RGB10_A2) |
| 1310 | { |
| 1311 | return false; |
| 1312 | } |
| 1313 | break; |
Geoff Lang | 1ec57f8 | 2013-10-16 11:43:23 -0400 | [diff] [blame] | 1314 | case GL_FLOAT: |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 1315 | if (internalFormatInfo.componentType != GL_FLOAT) |
Geoff Lang | 1ec57f8 | 2013-10-16 11:43:23 -0400 | [diff] [blame] | 1316 | { |
| 1317 | return false; |
| 1318 | } |
| 1319 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1320 | default: |
| 1321 | return false; |
| 1322 | } |
| 1323 | break; |
| 1324 | case GL_RGBA_INTEGER: |
| 1325 | switch (type) |
| 1326 | { |
| 1327 | case GL_INT: |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 1328 | if (internalFormatInfo.componentType != GL_INT) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1329 | { |
| 1330 | return false; |
| 1331 | } |
| 1332 | break; |
| 1333 | case GL_UNSIGNED_INT: |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 1334 | if (internalFormatInfo.componentType != GL_UNSIGNED_INT) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1335 | { |
| 1336 | return false; |
| 1337 | } |
| 1338 | break; |
| 1339 | default: |
| 1340 | return false; |
| 1341 | } |
| 1342 | break; |
| 1343 | case GL_BGRA_EXT: |
| 1344 | switch (type) |
| 1345 | { |
| 1346 | case GL_UNSIGNED_BYTE: |
| 1347 | case GL_UNSIGNED_SHORT_4_4_4_4_REV_EXT: |
| 1348 | case GL_UNSIGNED_SHORT_1_5_5_5_REV_EXT: |
| 1349 | break; |
| 1350 | default: |
| 1351 | return false; |
| 1352 | } |
| 1353 | break; |
Geoff Lang | bdc9b2f | 2014-04-16 14:41:54 -0400 | [diff] [blame] | 1354 | case GL_RG_EXT: |
| 1355 | case GL_RED_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 1356 | if (!context->getExtensions().textureRG) |
Geoff Lang | bdc9b2f | 2014-04-16 14:41:54 -0400 | [diff] [blame] | 1357 | { |
| 1358 | return false; |
| 1359 | } |
| 1360 | switch (type) |
| 1361 | { |
| 1362 | case GL_UNSIGNED_BYTE: |
| 1363 | break; |
Vincent Lang | 25ab451 | 2016-05-13 18:13:59 +0200 | [diff] [blame] | 1364 | case GL_UNSIGNED_SHORT: |
| 1365 | if (internalFormatInfo.componentType != GL_UNSIGNED_NORMALIZED && |
| 1366 | internalFormatInfo.type != GL_UNSIGNED_SHORT) |
| 1367 | { |
| 1368 | return false; |
| 1369 | } |
| 1370 | break; |
Geoff Lang | bdc9b2f | 2014-04-16 14:41:54 -0400 | [diff] [blame] | 1371 | default: |
| 1372 | return false; |
| 1373 | } |
| 1374 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1375 | default: |
| 1376 | return false; |
| 1377 | } |
| 1378 | return true; |
| 1379 | } |
| 1380 | |
Corentin Wallez | e090264 | 2014-11-04 12:32:15 -0800 | [diff] [blame] | 1381 | bool ValidateES3RenderbufferStorageParameters(gl::Context *context, GLenum target, GLsizei samples, |
| 1382 | GLenum internalformat, GLsizei width, GLsizei height) |
| 1383 | { |
| 1384 | if (!ValidateRenderbufferStorageParametersBase(context, target, samples, internalformat, width, height)) |
| 1385 | { |
| 1386 | return false; |
| 1387 | } |
| 1388 | |
| 1389 | //The ES3 spec(section 4.4.2) states that the internal format must be sized and not an integer format if samples is greater than zero. |
| 1390 | const gl::InternalFormat &formatInfo = gl::GetInternalFormatInfo(internalformat); |
| 1391 | if ((formatInfo.componentType == GL_UNSIGNED_INT || formatInfo.componentType == GL_INT) && samples > 0) |
| 1392 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1393 | context->handleError(Error(GL_INVALID_OPERATION)); |
Corentin Wallez | e090264 | 2014-11-04 12:32:15 -0800 | [diff] [blame] | 1394 | return false; |
| 1395 | } |
| 1396 | |
| 1397 | // The behavior is different than the ANGLE version, which would generate a GL_OUT_OF_MEMORY. |
| 1398 | const TextureCaps &formatCaps = context->getTextureCaps().get(internalformat); |
| 1399 | if (static_cast<GLuint>(samples) > formatCaps.getMaxSamples()) |
| 1400 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1401 | context->handleError( |
Olli Etuaho | 84c9f59 | 2016-03-09 14:37:25 +0200 | [diff] [blame] | 1402 | Error(GL_INVALID_OPERATION, |
| 1403 | "Samples must not be greater than maximum supported value for the format.")); |
Corentin Wallez | e090264 | 2014-11-04 12:32:15 -0800 | [diff] [blame] | 1404 | return false; |
| 1405 | } |
| 1406 | |
| 1407 | return true; |
| 1408 | } |
| 1409 | |
Austin Kinross | 0833263 | 2015-05-05 13:35:47 -0700 | [diff] [blame] | 1410 | bool ValidateInvalidateFramebuffer(Context *context, GLenum target, GLsizei numAttachments, |
| 1411 | const GLenum *attachments) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1412 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1413 | if (context->getClientMajorVersion() < 3) |
Austin Kinross | 0833263 | 2015-05-05 13:35:47 -0700 | [diff] [blame] | 1414 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1415 | context->handleError( |
| 1416 | Error(GL_INVALID_OPERATION, "Operation only supported on ES 3.0 and above")); |
Austin Kinross | 0833263 | 2015-05-05 13:35:47 -0700 | [diff] [blame] | 1417 | return false; |
| 1418 | } |
| 1419 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1420 | bool defaultFramebuffer = false; |
| 1421 | |
| 1422 | switch (target) |
| 1423 | { |
| 1424 | case GL_DRAW_FRAMEBUFFER: |
| 1425 | case GL_FRAMEBUFFER: |
Jamie Madill | dfde6ab | 2016-06-09 07:07:18 -0700 | [diff] [blame] | 1426 | defaultFramebuffer = context->getGLState().getDrawFramebuffer()->id() == 0; |
| 1427 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1428 | case GL_READ_FRAMEBUFFER: |
Jamie Madill | dfde6ab | 2016-06-09 07:07:18 -0700 | [diff] [blame] | 1429 | defaultFramebuffer = context->getGLState().getReadFramebuffer()->id() == 0; |
| 1430 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1431 | default: |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1432 | context->handleError(Error(GL_INVALID_ENUM, "Invalid framebuffer target")); |
Austin Kinross | 0833263 | 2015-05-05 13:35:47 -0700 | [diff] [blame] | 1433 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1434 | } |
| 1435 | |
Austin Kinross | 0833263 | 2015-05-05 13:35:47 -0700 | [diff] [blame] | 1436 | return ValidateDiscardFramebufferBase(context, target, numAttachments, attachments, defaultFramebuffer); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1437 | } |
| 1438 | |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1439 | bool ValidateClearBuffer(ValidationContext *context) |
Jamie Madill | 13f7d7d | 2014-06-20 13:21:27 -0400 | [diff] [blame] | 1440 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1441 | if (context->getClientMajorVersion() < 3) |
Jamie Madill | 13f7d7d | 2014-06-20 13:21:27 -0400 | [diff] [blame] | 1442 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1443 | context->handleError(Error(GL_INVALID_OPERATION)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1444 | return false; |
Jamie Madill | 13f7d7d | 2014-06-20 13:21:27 -0400 | [diff] [blame] | 1445 | } |
| 1446 | |
Jamie Madill | 51f40ec | 2016-06-15 14:06:00 -0400 | [diff] [blame] | 1447 | if (context->getGLState().getDrawFramebuffer()->checkStatus(context->getContextState()) != |
| 1448 | GL_FRAMEBUFFER_COMPLETE) |
Jamie Madill | 13f7d7d | 2014-06-20 13:21:27 -0400 | [diff] [blame] | 1449 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1450 | context->handleError(Error(GL_INVALID_FRAMEBUFFER_OPERATION)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1451 | return false; |
Jamie Madill | 13f7d7d | 2014-06-20 13:21:27 -0400 | [diff] [blame] | 1452 | } |
| 1453 | |
| 1454 | return true; |
| 1455 | } |
| 1456 | |
Olli Etuaho | 71dfb36 | 2016-03-10 14:04:27 +0200 | [diff] [blame] | 1457 | bool ValidateDrawRangeElements(Context *context, |
| 1458 | GLenum mode, |
| 1459 | GLuint start, |
| 1460 | GLuint end, |
| 1461 | GLsizei count, |
| 1462 | GLenum type, |
| 1463 | const GLvoid *indices, |
| 1464 | IndexRange *indexRange) |
| 1465 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1466 | if (context->getClientMajorVersion() < 3) |
Olli Etuaho | 71dfb36 | 2016-03-10 14:04:27 +0200 | [diff] [blame] | 1467 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1468 | context->handleError(Error(GL_INVALID_OPERATION, "Context does not support GLES3.")); |
Olli Etuaho | 71dfb36 | 2016-03-10 14:04:27 +0200 | [diff] [blame] | 1469 | return false; |
| 1470 | } |
| 1471 | |
| 1472 | if (end < start) |
| 1473 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1474 | context->handleError(Error(GL_INVALID_VALUE, "end < start")); |
Olli Etuaho | 71dfb36 | 2016-03-10 14:04:27 +0200 | [diff] [blame] | 1475 | return false; |
| 1476 | } |
| 1477 | |
| 1478 | if (!ValidateDrawElements(context, mode, count, type, indices, 0, indexRange)) |
| 1479 | { |
| 1480 | return false; |
| 1481 | } |
| 1482 | |
| 1483 | if (indexRange->end > end || indexRange->start < start) |
| 1484 | { |
| 1485 | // GL spec says that behavior in this case is undefined - generating an error is fine. |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1486 | context->handleError( |
Olli Etuaho | 71dfb36 | 2016-03-10 14:04:27 +0200 | [diff] [blame] | 1487 | Error(GL_INVALID_OPERATION, "Indices are out of the start, end range.")); |
| 1488 | return false; |
| 1489 | } |
| 1490 | return true; |
| 1491 | } |
| 1492 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1493 | bool ValidateGetUniformuiv(Context *context, GLuint program, GLint location, GLuint* params) |
Jamie Madill | 0063c51 | 2014-08-25 15:47:53 -0400 | [diff] [blame] | 1494 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1495 | if (context->getClientMajorVersion() < 3) |
Jamie Madill | 0063c51 | 2014-08-25 15:47:53 -0400 | [diff] [blame] | 1496 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1497 | context->handleError(Error(GL_INVALID_OPERATION)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 1498 | return false; |
Jamie Madill | 0063c51 | 2014-08-25 15:47:53 -0400 | [diff] [blame] | 1499 | } |
| 1500 | |
Jamie Madill | 78f4180 | 2014-08-25 15:47:55 -0400 | [diff] [blame] | 1501 | return ValidateGetUniformBase(context, program, location); |
Jamie Madill | 0063c51 | 2014-08-25 15:47:53 -0400 | [diff] [blame] | 1502 | } |
| 1503 | |
Jamie Madill | b885e57 | 2015-02-03 16:16:04 -0500 | [diff] [blame] | 1504 | bool ValidateReadBuffer(Context *context, GLenum src) |
| 1505 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1506 | if (context->getClientMajorVersion() < 3) |
Jamie Madill | b885e57 | 2015-02-03 16:16:04 -0500 | [diff] [blame] | 1507 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1508 | context->handleError(Error(GL_INVALID_OPERATION)); |
Jamie Madill | b885e57 | 2015-02-03 16:16:04 -0500 | [diff] [blame] | 1509 | return false; |
| 1510 | } |
| 1511 | |
Jamie Madill | dfde6ab | 2016-06-09 07:07:18 -0700 | [diff] [blame] | 1512 | const Framebuffer *readFBO = context->getGLState().getReadFramebuffer(); |
Jamie Madill | b885e57 | 2015-02-03 16:16:04 -0500 | [diff] [blame] | 1513 | |
| 1514 | if (readFBO == nullptr) |
| 1515 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1516 | context->handleError(gl::Error(GL_INVALID_OPERATION, "No active read framebuffer.")); |
Jamie Madill | b885e57 | 2015-02-03 16:16:04 -0500 | [diff] [blame] | 1517 | return false; |
| 1518 | } |
| 1519 | |
| 1520 | if (src == GL_NONE) |
| 1521 | { |
| 1522 | return true; |
| 1523 | } |
| 1524 | |
Olli Etuaho | 84c9f59 | 2016-03-09 14:37:25 +0200 | [diff] [blame] | 1525 | if (src != GL_BACK && (src < GL_COLOR_ATTACHMENT0 || src > GL_COLOR_ATTACHMENT31)) |
Jamie Madill | b885e57 | 2015-02-03 16:16:04 -0500 | [diff] [blame] | 1526 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1527 | context->handleError(gl::Error(GL_INVALID_ENUM, "Unknown enum for 'src' in ReadBuffer")); |
Jamie Madill | b885e57 | 2015-02-03 16:16:04 -0500 | [diff] [blame] | 1528 | return false; |
| 1529 | } |
| 1530 | |
| 1531 | if (readFBO->id() == 0) |
| 1532 | { |
| 1533 | if (src != GL_BACK) |
| 1534 | { |
| 1535 | const char *errorMsg = "'src' must be GL_NONE or GL_BACK when reading from the default framebuffer."; |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1536 | context->handleError(gl::Error(GL_INVALID_OPERATION, errorMsg)); |
Jamie Madill | b885e57 | 2015-02-03 16:16:04 -0500 | [diff] [blame] | 1537 | return false; |
| 1538 | } |
| 1539 | } |
| 1540 | else |
| 1541 | { |
| 1542 | GLuint drawBuffer = static_cast<GLuint>(src - GL_COLOR_ATTACHMENT0); |
| 1543 | |
| 1544 | if (drawBuffer >= context->getCaps().maxDrawBuffers) |
| 1545 | { |
| 1546 | const char *errorMsg = "'src' is greater than MAX_DRAW_BUFFERS."; |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1547 | context->handleError(gl::Error(GL_INVALID_OPERATION, errorMsg)); |
Jamie Madill | b885e57 | 2015-02-03 16:16:04 -0500 | [diff] [blame] | 1548 | return false; |
| 1549 | } |
| 1550 | } |
| 1551 | |
| 1552 | return true; |
| 1553 | } |
| 1554 | |
Jamie Madill | 86af3d2 | 2015-07-21 15:14:07 -0400 | [diff] [blame] | 1555 | bool ValidateCompressedTexImage3D(Context *context, |
| 1556 | GLenum target, |
| 1557 | GLint level, |
| 1558 | GLenum internalformat, |
| 1559 | GLsizei width, |
| 1560 | GLsizei height, |
| 1561 | GLsizei depth, |
| 1562 | GLint border, |
| 1563 | GLsizei imageSize, |
| 1564 | const GLvoid *data) |
| 1565 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1566 | if (context->getClientMajorVersion() < 3) |
Jamie Madill | 86af3d2 | 2015-07-21 15:14:07 -0400 | [diff] [blame] | 1567 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1568 | context->handleError(Error(GL_INVALID_OPERATION)); |
Jamie Madill | 86af3d2 | 2015-07-21 15:14:07 -0400 | [diff] [blame] | 1569 | return false; |
| 1570 | } |
| 1571 | |
Jamie Madill | 4b4cdff | 2016-06-06 13:53:38 -0700 | [diff] [blame] | 1572 | if (!ValidTextureTarget(context, target)) |
| 1573 | { |
| 1574 | context->handleError(Error(GL_INVALID_ENUM)); |
| 1575 | return false; |
| 1576 | } |
| 1577 | |
Jamie Madill | e2e406c | 2016-06-02 13:04:10 -0400 | [diff] [blame] | 1578 | // Validate image size |
| 1579 | if (!ValidImageSizeParameters(context, target, level, width, height, depth, false)) |
| 1580 | { |
| 1581 | context->handleError(Error(GL_INVALID_VALUE)); |
| 1582 | return false; |
| 1583 | } |
| 1584 | |
Jamie Madill | 86af3d2 | 2015-07-21 15:14:07 -0400 | [diff] [blame] | 1585 | const InternalFormat &formatInfo = GetInternalFormatInfo(internalformat); |
Jamie Madill | 4b4cdff | 2016-06-06 13:53:38 -0700 | [diff] [blame] | 1586 | if (!formatInfo.compressed) |
| 1587 | { |
| 1588 | context->handleError(Error(GL_INVALID_ENUM, "Not a valid compressed texture format")); |
| 1589 | return false; |
| 1590 | } |
| 1591 | |
Jamie Madill | 513558d | 2016-06-02 13:04:11 -0400 | [diff] [blame] | 1592 | auto blockSizeOrErr = |
Jamie Madill | 4b4cdff | 2016-06-06 13:53:38 -0700 | [diff] [blame] | 1593 | formatInfo.computeCompressedImageSize(GL_UNSIGNED_BYTE, gl::Extents(width, height, depth)); |
Jamie Madill | e2e406c | 2016-06-02 13:04:10 -0400 | [diff] [blame] | 1594 | if (blockSizeOrErr.isError()) |
| 1595 | { |
Jamie Madill | 513558d | 2016-06-02 13:04:11 -0400 | [diff] [blame] | 1596 | context->handleError(Error(GL_INVALID_VALUE)); |
Jamie Madill | e2e406c | 2016-06-02 13:04:10 -0400 | [diff] [blame] | 1597 | return false; |
| 1598 | } |
| 1599 | if (imageSize < 0 || static_cast<GLuint>(imageSize) != blockSizeOrErr.getResult()) |
Jamie Madill | 86af3d2 | 2015-07-21 15:14:07 -0400 | [diff] [blame] | 1600 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1601 | context->handleError(Error(GL_INVALID_VALUE)); |
Jamie Madill | 86af3d2 | 2015-07-21 15:14:07 -0400 | [diff] [blame] | 1602 | return false; |
| 1603 | } |
| 1604 | |
| 1605 | // 3D texture target validation |
| 1606 | if (target != GL_TEXTURE_3D && target != GL_TEXTURE_2D_ARRAY) |
| 1607 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1608 | context->handleError( |
Jamie Madill | 86af3d2 | 2015-07-21 15:14:07 -0400 | [diff] [blame] | 1609 | Error(GL_INVALID_ENUM, "Must specify a valid 3D texture destination target")); |
| 1610 | return false; |
| 1611 | } |
| 1612 | |
| 1613 | // validateES3TexImageFormat sets the error code if there is an error |
Ian Ewell | fc7cf8e | 2016-01-20 15:57:46 -0500 | [diff] [blame] | 1614 | if (!ValidateES3TexImage3DParameters(context, target, level, internalformat, true, false, 0, 0, |
| 1615 | 0, width, height, depth, border, GL_NONE, GL_NONE, data)) |
Jamie Madill | 86af3d2 | 2015-07-21 15:14:07 -0400 | [diff] [blame] | 1616 | { |
| 1617 | return false; |
| 1618 | } |
| 1619 | |
| 1620 | return true; |
| 1621 | } |
Austin Kinross | bc781f3 | 2015-10-26 09:27:38 -0700 | [diff] [blame] | 1622 | |
| 1623 | bool ValidateBindVertexArray(Context *context, GLuint array) |
| 1624 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1625 | if (context->getClientMajorVersion() < 3) |
Austin Kinross | bc781f3 | 2015-10-26 09:27:38 -0700 | [diff] [blame] | 1626 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1627 | context->handleError(Error(GL_INVALID_OPERATION)); |
Austin Kinross | bc781f3 | 2015-10-26 09:27:38 -0700 | [diff] [blame] | 1628 | return false; |
| 1629 | } |
| 1630 | |
| 1631 | return ValidateBindVertexArrayBase(context, array); |
| 1632 | } |
| 1633 | |
Austin Kinross | bc781f3 | 2015-10-26 09:27:38 -0700 | [diff] [blame] | 1634 | bool ValidateIsVertexArray(Context *context) |
| 1635 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1636 | if (context->getClientMajorVersion() < 3) |
Austin Kinross | bc781f3 | 2015-10-26 09:27:38 -0700 | [diff] [blame] | 1637 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1638 | context->handleError(Error(GL_INVALID_OPERATION)); |
Austin Kinross | bc781f3 | 2015-10-26 09:27:38 -0700 | [diff] [blame] | 1639 | return false; |
| 1640 | } |
| 1641 | |
| 1642 | return true; |
| 1643 | } |
Geoff Lang | c562975 | 2015-12-07 16:29:04 -0500 | [diff] [blame] | 1644 | |
| 1645 | bool ValidateProgramBinary(Context *context, |
| 1646 | GLuint program, |
| 1647 | GLenum binaryFormat, |
| 1648 | const void *binary, |
| 1649 | GLint length) |
| 1650 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1651 | if (context->getClientMajorVersion() < 3) |
Geoff Lang | c562975 | 2015-12-07 16:29:04 -0500 | [diff] [blame] | 1652 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1653 | context->handleError(Error(GL_INVALID_OPERATION)); |
Geoff Lang | c562975 | 2015-12-07 16:29:04 -0500 | [diff] [blame] | 1654 | return false; |
| 1655 | } |
| 1656 | |
| 1657 | return ValidateProgramBinaryBase(context, program, binaryFormat, binary, length); |
| 1658 | } |
| 1659 | |
| 1660 | bool ValidateGetProgramBinary(Context *context, |
| 1661 | GLuint program, |
| 1662 | GLsizei bufSize, |
| 1663 | GLsizei *length, |
| 1664 | GLenum *binaryFormat, |
| 1665 | void *binary) |
| 1666 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1667 | if (context->getClientMajorVersion() < 3) |
Geoff Lang | c562975 | 2015-12-07 16:29:04 -0500 | [diff] [blame] | 1668 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1669 | context->handleError(Error(GL_INVALID_OPERATION)); |
Geoff Lang | c562975 | 2015-12-07 16:29:04 -0500 | [diff] [blame] | 1670 | return false; |
| 1671 | } |
| 1672 | |
| 1673 | return ValidateGetProgramBinaryBase(context, program, bufSize, length, binaryFormat, binary); |
| 1674 | } |
| 1675 | |
Olli Etuaho | f0fee07 | 2016-03-30 15:11:58 +0300 | [diff] [blame] | 1676 | bool ValidateProgramParameteri(Context *context, GLuint program, GLenum pname, GLint value) |
Geoff Lang | c562975 | 2015-12-07 16:29:04 -0500 | [diff] [blame] | 1677 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1678 | if (context->getClientMajorVersion() < 3) |
Geoff Lang | c562975 | 2015-12-07 16:29:04 -0500 | [diff] [blame] | 1679 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1680 | context->handleError(Error(GL_INVALID_OPERATION, "Context does not support GLES3.")); |
Geoff Lang | c562975 | 2015-12-07 16:29:04 -0500 | [diff] [blame] | 1681 | return false; |
| 1682 | } |
| 1683 | |
| 1684 | if (GetValidProgram(context, program) == nullptr) |
| 1685 | { |
| 1686 | return false; |
| 1687 | } |
| 1688 | |
| 1689 | switch (pname) |
| 1690 | { |
| 1691 | case GL_PROGRAM_BINARY_RETRIEVABLE_HINT: |
Olli Etuaho | f0fee07 | 2016-03-30 15:11:58 +0300 | [diff] [blame] | 1692 | if (value != GL_FALSE && value != GL_TRUE) |
| 1693 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1694 | context->handleError(Error( |
Olli Etuaho | f0fee07 | 2016-03-30 15:11:58 +0300 | [diff] [blame] | 1695 | GL_INVALID_VALUE, "Invalid value, expected GL_FALSE or GL_TRUE: %i", value)); |
| 1696 | return false; |
| 1697 | } |
Geoff Lang | c562975 | 2015-12-07 16:29:04 -0500 | [diff] [blame] | 1698 | break; |
| 1699 | |
| 1700 | default: |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1701 | context->handleError(Error(GL_INVALID_ENUM, "Invalid pname: 0x%X", pname)); |
Geoff Lang | c562975 | 2015-12-07 16:29:04 -0500 | [diff] [blame] | 1702 | return false; |
| 1703 | } |
| 1704 | |
| 1705 | return true; |
| 1706 | } |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1707 | |
| 1708 | bool ValidateBlitFramebuffer(Context *context, |
| 1709 | GLint srcX0, |
| 1710 | GLint srcY0, |
| 1711 | GLint srcX1, |
| 1712 | GLint srcY1, |
| 1713 | GLint dstX0, |
| 1714 | GLint dstY0, |
| 1715 | GLint dstX1, |
| 1716 | GLint dstY1, |
| 1717 | GLbitfield mask, |
| 1718 | GLenum filter) |
| 1719 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1720 | if (context->getClientMajorVersion() < 3) |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1721 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1722 | context->handleError(Error(GL_INVALID_OPERATION)); |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1723 | return false; |
| 1724 | } |
| 1725 | |
| 1726 | return ValidateBlitFramebufferParameters(context, srcX0, srcY0, srcX1, srcY1, dstX0, dstY0, |
| 1727 | dstX1, dstY1, mask, filter); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1728 | } |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1729 | |
| 1730 | bool ValidateClearBufferiv(ValidationContext *context, |
| 1731 | GLenum buffer, |
| 1732 | GLint drawbuffer, |
| 1733 | const GLint *value) |
| 1734 | { |
| 1735 | switch (buffer) |
| 1736 | { |
| 1737 | case GL_COLOR: |
| 1738 | if (drawbuffer < 0 || |
| 1739 | static_cast<GLuint>(drawbuffer) >= context->getCaps().maxDrawBuffers) |
| 1740 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1741 | context->handleError(Error(GL_INVALID_VALUE)); |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1742 | return false; |
| 1743 | } |
| 1744 | break; |
| 1745 | |
| 1746 | case GL_STENCIL: |
| 1747 | if (drawbuffer != 0) |
| 1748 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1749 | context->handleError(Error(GL_INVALID_VALUE)); |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1750 | return false; |
| 1751 | } |
| 1752 | break; |
| 1753 | |
| 1754 | default: |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1755 | context->handleError(Error(GL_INVALID_ENUM)); |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1756 | return false; |
| 1757 | } |
| 1758 | |
| 1759 | return ValidateClearBuffer(context); |
| 1760 | } |
| 1761 | |
| 1762 | bool ValidateClearBufferuiv(ValidationContext *context, |
| 1763 | GLenum buffer, |
| 1764 | GLint drawbuffer, |
| 1765 | const GLuint *value) |
| 1766 | { |
| 1767 | switch (buffer) |
| 1768 | { |
| 1769 | case GL_COLOR: |
| 1770 | if (drawbuffer < 0 || |
| 1771 | static_cast<GLuint>(drawbuffer) >= context->getCaps().maxDrawBuffers) |
| 1772 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1773 | context->handleError(Error(GL_INVALID_VALUE)); |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1774 | return false; |
| 1775 | } |
| 1776 | break; |
| 1777 | |
| 1778 | default: |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1779 | context->handleError(Error(GL_INVALID_ENUM)); |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1780 | return false; |
| 1781 | } |
| 1782 | |
| 1783 | return ValidateClearBuffer(context); |
| 1784 | } |
| 1785 | |
| 1786 | bool ValidateClearBufferfv(ValidationContext *context, |
| 1787 | GLenum buffer, |
| 1788 | GLint drawbuffer, |
| 1789 | const GLfloat *value) |
| 1790 | { |
| 1791 | switch (buffer) |
| 1792 | { |
| 1793 | case GL_COLOR: |
| 1794 | if (drawbuffer < 0 || |
| 1795 | static_cast<GLuint>(drawbuffer) >= context->getCaps().maxDrawBuffers) |
| 1796 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1797 | context->handleError(Error(GL_INVALID_VALUE)); |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1798 | return false; |
| 1799 | } |
| 1800 | break; |
| 1801 | |
| 1802 | case GL_DEPTH: |
| 1803 | if (drawbuffer != 0) |
| 1804 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1805 | context->handleError(Error(GL_INVALID_VALUE)); |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1806 | return false; |
| 1807 | } |
| 1808 | break; |
| 1809 | |
| 1810 | default: |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1811 | context->handleError(Error(GL_INVALID_ENUM)); |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1812 | return false; |
| 1813 | } |
| 1814 | |
| 1815 | return ValidateClearBuffer(context); |
| 1816 | } |
| 1817 | |
| 1818 | bool ValidateClearBufferfi(ValidationContext *context, |
| 1819 | GLenum buffer, |
| 1820 | GLint drawbuffer, |
| 1821 | GLfloat depth, |
| 1822 | GLint stencil) |
| 1823 | { |
| 1824 | switch (buffer) |
| 1825 | { |
| 1826 | case GL_DEPTH_STENCIL: |
| 1827 | if (drawbuffer != 0) |
| 1828 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1829 | context->handleError(Error(GL_INVALID_VALUE)); |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1830 | return false; |
| 1831 | } |
| 1832 | break; |
| 1833 | |
| 1834 | default: |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1835 | context->handleError(Error(GL_INVALID_ENUM)); |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1836 | return false; |
| 1837 | } |
| 1838 | |
| 1839 | return ValidateClearBuffer(context); |
| 1840 | } |
| 1841 | |
| 1842 | bool ValidateDrawBuffers(ValidationContext *context, GLsizei n, const GLenum *bufs) |
| 1843 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1844 | if (context->getClientMajorVersion() < 3) |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1845 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1846 | context->handleError(Error(GL_INVALID_OPERATION, "Context does not support GLES3.")); |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1847 | return false; |
| 1848 | } |
| 1849 | |
| 1850 | return ValidateDrawBuffersBase(context, n, bufs); |
| 1851 | } |
| 1852 | |
| 1853 | bool ValidateCopyTexSubImage3D(Context *context, |
| 1854 | GLenum target, |
| 1855 | GLint level, |
| 1856 | GLint xoffset, |
| 1857 | GLint yoffset, |
| 1858 | GLint zoffset, |
| 1859 | GLint x, |
| 1860 | GLint y, |
| 1861 | GLsizei width, |
| 1862 | GLsizei height) |
| 1863 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1864 | if (context->getClientMajorVersion() < 3) |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1865 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1866 | context->handleError(Error(GL_INVALID_OPERATION)); |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1867 | return false; |
| 1868 | } |
| 1869 | |
Ian Ewell | fc7cf8e | 2016-01-20 15:57:46 -0500 | [diff] [blame] | 1870 | return ValidateES3CopyTexImage3DParameters(context, target, level, GL_NONE, true, xoffset, |
| 1871 | yoffset, zoffset, x, y, width, height, 0); |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 1872 | } |
| 1873 | |
Jamie Madill | 73a8496 | 2016-02-12 09:27:23 -0500 | [diff] [blame] | 1874 | bool ValidateTexImage3D(Context *context, |
| 1875 | GLenum target, |
| 1876 | GLint level, |
| 1877 | GLint internalformat, |
| 1878 | GLsizei width, |
| 1879 | GLsizei height, |
| 1880 | GLsizei depth, |
| 1881 | GLint border, |
| 1882 | GLenum format, |
| 1883 | GLenum type, |
| 1884 | const GLvoid *pixels) |
| 1885 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1886 | if (context->getClientMajorVersion() < 3) |
Jamie Madill | 73a8496 | 2016-02-12 09:27:23 -0500 | [diff] [blame] | 1887 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1888 | context->handleError(Error(GL_INVALID_OPERATION)); |
Jamie Madill | 73a8496 | 2016-02-12 09:27:23 -0500 | [diff] [blame] | 1889 | return false; |
| 1890 | } |
| 1891 | |
| 1892 | return ValidateES3TexImage3DParameters(context, target, level, internalformat, false, false, 0, |
| 1893 | 0, 0, width, height, depth, border, format, type, |
| 1894 | pixels); |
| 1895 | } |
| 1896 | |
| 1897 | bool ValidateTexSubImage3D(Context *context, |
| 1898 | GLenum target, |
| 1899 | GLint level, |
| 1900 | GLint xoffset, |
| 1901 | GLint yoffset, |
| 1902 | GLint zoffset, |
| 1903 | GLsizei width, |
| 1904 | GLsizei height, |
| 1905 | GLsizei depth, |
| 1906 | GLenum format, |
| 1907 | GLenum type, |
| 1908 | const GLvoid *pixels) |
| 1909 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1910 | if (context->getClientMajorVersion() < 3) |
Jamie Madill | 73a8496 | 2016-02-12 09:27:23 -0500 | [diff] [blame] | 1911 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1912 | context->handleError(Error(GL_INVALID_OPERATION)); |
Jamie Madill | 73a8496 | 2016-02-12 09:27:23 -0500 | [diff] [blame] | 1913 | return false; |
| 1914 | } |
| 1915 | |
| 1916 | return ValidateES3TexImage3DParameters(context, target, level, GL_NONE, false, true, xoffset, |
| 1917 | yoffset, zoffset, width, height, depth, 0, format, type, |
| 1918 | pixels); |
| 1919 | } |
| 1920 | |
| 1921 | bool ValidateCompressedTexSubImage3D(Context *context, |
| 1922 | GLenum target, |
| 1923 | GLint level, |
| 1924 | GLint xoffset, |
| 1925 | GLint yoffset, |
| 1926 | GLint zoffset, |
| 1927 | GLsizei width, |
| 1928 | GLsizei height, |
| 1929 | GLsizei depth, |
| 1930 | GLenum format, |
| 1931 | GLsizei imageSize, |
| 1932 | const GLvoid *data) |
| 1933 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 1934 | if (context->getClientMajorVersion() < 3) |
Jamie Madill | 73a8496 | 2016-02-12 09:27:23 -0500 | [diff] [blame] | 1935 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1936 | context->handleError(Error(GL_INVALID_OPERATION)); |
Jamie Madill | 73a8496 | 2016-02-12 09:27:23 -0500 | [diff] [blame] | 1937 | return false; |
| 1938 | } |
| 1939 | |
| 1940 | const InternalFormat &formatInfo = GetInternalFormatInfo(format); |
Jamie Madill | 513558d | 2016-06-02 13:04:11 -0400 | [diff] [blame] | 1941 | auto blockSizeOrErr = |
Jamie Madill | 4b4cdff | 2016-06-06 13:53:38 -0700 | [diff] [blame] | 1942 | formatInfo.computeCompressedImageSize(GL_UNSIGNED_BYTE, gl::Extents(width, height, depth)); |
Jamie Madill | e2e406c | 2016-06-02 13:04:10 -0400 | [diff] [blame] | 1943 | if (blockSizeOrErr.isError()) |
| 1944 | { |
| 1945 | context->handleError(blockSizeOrErr.getError()); |
| 1946 | return false; |
| 1947 | } |
| 1948 | if (imageSize < 0 || static_cast<GLuint>(imageSize) != blockSizeOrErr.getResult()) |
Jamie Madill | 73a8496 | 2016-02-12 09:27:23 -0500 | [diff] [blame] | 1949 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1950 | context->handleError(Error(GL_INVALID_VALUE)); |
Jamie Madill | 73a8496 | 2016-02-12 09:27:23 -0500 | [diff] [blame] | 1951 | return false; |
| 1952 | } |
| 1953 | |
| 1954 | if (!data) |
| 1955 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 1956 | context->handleError(Error(GL_INVALID_VALUE)); |
Jamie Madill | 73a8496 | 2016-02-12 09:27:23 -0500 | [diff] [blame] | 1957 | return false; |
| 1958 | } |
| 1959 | |
| 1960 | return ValidateES3TexImage3DParameters(context, target, level, GL_NONE, true, true, 0, 0, 0, |
| 1961 | width, height, depth, 0, GL_NONE, GL_NONE, data); |
| 1962 | } |
| 1963 | |
Olli Etuaho | 41997e7 | 2016-03-10 13:38:39 +0200 | [diff] [blame] | 1964 | bool ValidateGenQueries(Context *context, GLint n, GLuint *) |
| 1965 | { |
| 1966 | return ValidateGenOrDeleteES3(context, n); |
| 1967 | } |
| 1968 | |
| 1969 | bool ValidateDeleteQueries(Context *context, GLint n, const GLuint *) |
| 1970 | { |
| 1971 | return ValidateGenOrDeleteES3(context, n); |
| 1972 | } |
| 1973 | |
| 1974 | bool ValidateGenSamplers(Context *context, GLint count, GLuint *) |
| 1975 | { |
| 1976 | return ValidateGenOrDeleteCountES3(context, count); |
| 1977 | } |
| 1978 | |
| 1979 | bool ValidateDeleteSamplers(Context *context, GLint count, const GLuint *) |
| 1980 | { |
| 1981 | return ValidateGenOrDeleteCountES3(context, count); |
| 1982 | } |
| 1983 | |
| 1984 | bool ValidateGenTransformFeedbacks(Context *context, GLint n, GLuint *) |
| 1985 | { |
| 1986 | return ValidateGenOrDeleteES3(context, n); |
| 1987 | } |
| 1988 | |
| 1989 | bool ValidateDeleteTransformFeedbacks(Context *context, GLint n, const GLuint *ids) |
| 1990 | { |
| 1991 | if (!ValidateGenOrDeleteES3(context, n)) |
| 1992 | { |
| 1993 | return false; |
| 1994 | } |
| 1995 | for (GLint i = 0; i < n; ++i) |
| 1996 | { |
| 1997 | auto *transformFeedback = context->getTransformFeedback(ids[i]); |
| 1998 | if (transformFeedback != nullptr && transformFeedback->isActive()) |
| 1999 | { |
| 2000 | // ES 3.0.4 section 2.15.1 page 86 |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 2001 | context->handleError( |
Olli Etuaho | 41997e7 | 2016-03-10 13:38:39 +0200 | [diff] [blame] | 2002 | Error(GL_INVALID_OPERATION, "Attempt to delete active transform feedback.")); |
| 2003 | return false; |
| 2004 | } |
| 2005 | } |
| 2006 | return true; |
| 2007 | } |
| 2008 | |
| 2009 | bool ValidateGenVertexArrays(Context *context, GLint n, GLuint *) |
| 2010 | { |
| 2011 | return ValidateGenOrDeleteES3(context, n); |
| 2012 | } |
| 2013 | |
| 2014 | bool ValidateDeleteVertexArrays(Context *context, GLint n, const GLuint *) |
| 2015 | { |
| 2016 | return ValidateGenOrDeleteES3(context, n); |
| 2017 | } |
| 2018 | |
| 2019 | bool ValidateGenOrDeleteES3(Context *context, GLint n) |
| 2020 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 2021 | if (context->getClientMajorVersion() < 3) |
Olli Etuaho | 41997e7 | 2016-03-10 13:38:39 +0200 | [diff] [blame] | 2022 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 2023 | context->handleError(Error(GL_INVALID_OPERATION, "Context does not support GLES3.")); |
Olli Etuaho | 41997e7 | 2016-03-10 13:38:39 +0200 | [diff] [blame] | 2024 | return false; |
| 2025 | } |
| 2026 | return ValidateGenOrDelete(context, n); |
| 2027 | } |
| 2028 | |
| 2029 | bool ValidateGenOrDeleteCountES3(Context *context, GLint count) |
| 2030 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 2031 | if (context->getClientMajorVersion() < 3) |
Olli Etuaho | 41997e7 | 2016-03-10 13:38:39 +0200 | [diff] [blame] | 2032 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 2033 | context->handleError(Error(GL_INVALID_OPERATION, "Context does not support GLES3.")); |
Olli Etuaho | 41997e7 | 2016-03-10 13:38:39 +0200 | [diff] [blame] | 2034 | return false; |
| 2035 | } |
| 2036 | if (count < 0) |
| 2037 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 2038 | context->handleError(Error(GL_INVALID_VALUE, "count < 0")); |
Olli Etuaho | 41997e7 | 2016-03-10 13:38:39 +0200 | [diff] [blame] | 2039 | return false; |
| 2040 | } |
| 2041 | return true; |
| 2042 | } |
| 2043 | |
Olli Etuaho | c3e55a4 | 2016-03-09 16:29:18 +0200 | [diff] [blame] | 2044 | bool ValidateBeginTransformFeedback(Context *context, GLenum primitiveMode) |
| 2045 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 2046 | if (context->getClientMajorVersion() < 3) |
Olli Etuaho | c3e55a4 | 2016-03-09 16:29:18 +0200 | [diff] [blame] | 2047 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 2048 | context->handleError(Error(GL_INVALID_OPERATION, "Context does not support GLES3.")); |
Olli Etuaho | c3e55a4 | 2016-03-09 16:29:18 +0200 | [diff] [blame] | 2049 | return false; |
| 2050 | } |
| 2051 | switch (primitiveMode) |
| 2052 | { |
| 2053 | case GL_TRIANGLES: |
| 2054 | case GL_LINES: |
| 2055 | case GL_POINTS: |
| 2056 | break; |
| 2057 | |
| 2058 | default: |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 2059 | context->handleError(Error(GL_INVALID_ENUM, "Invalid primitive mode.")); |
Olli Etuaho | c3e55a4 | 2016-03-09 16:29:18 +0200 | [diff] [blame] | 2060 | return false; |
| 2061 | } |
| 2062 | |
Jamie Madill | dfde6ab | 2016-06-09 07:07:18 -0700 | [diff] [blame] | 2063 | TransformFeedback *transformFeedback = context->getGLState().getCurrentTransformFeedback(); |
Olli Etuaho | c3e55a4 | 2016-03-09 16:29:18 +0200 | [diff] [blame] | 2064 | ASSERT(transformFeedback != nullptr); |
| 2065 | |
| 2066 | if (transformFeedback->isActive()) |
| 2067 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 2068 | context->handleError(Error(GL_INVALID_OPERATION, "Transform feedback is already active.")); |
Olli Etuaho | c3e55a4 | 2016-03-09 16:29:18 +0200 | [diff] [blame] | 2069 | return false; |
| 2070 | } |
| 2071 | return true; |
| 2072 | } |
| 2073 | |
Olli Etuaho | 3747791 | 2016-03-30 14:54:40 +0300 | [diff] [blame] | 2074 | bool ValidateSamplerParameteri(Context *context, GLuint sampler, GLenum pname, GLint param) |
| 2075 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 2076 | if (context->getClientMajorVersion() < 3) |
Olli Etuaho | 3747791 | 2016-03-30 14:54:40 +0300 | [diff] [blame] | 2077 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 2078 | context->handleError(Error(GL_INVALID_OPERATION, "Context does not support GLES3.")); |
Olli Etuaho | 3747791 | 2016-03-30 14:54:40 +0300 | [diff] [blame] | 2079 | return false; |
| 2080 | } |
| 2081 | |
| 2082 | if (!context->isSampler(sampler)) |
| 2083 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 2084 | context->handleError(Error(GL_INVALID_OPERATION)); |
Olli Etuaho | 3747791 | 2016-03-30 14:54:40 +0300 | [diff] [blame] | 2085 | return false; |
| 2086 | } |
| 2087 | |
| 2088 | if (!ValidateSamplerObjectParameter(context, pname)) |
| 2089 | { |
| 2090 | return false; |
| 2091 | } |
| 2092 | |
Ian Ewell | bda7559 | 2016-04-18 17:25:54 -0400 | [diff] [blame] | 2093 | if (!ValidateTexParamParameters(context, GL_TEXTURE_2D, pname, param)) |
Olli Etuaho | 3747791 | 2016-03-30 14:54:40 +0300 | [diff] [blame] | 2094 | { |
| 2095 | return false; |
| 2096 | } |
| 2097 | return true; |
| 2098 | } |
| 2099 | |
| 2100 | bool ValidateSamplerParameterf(Context *context, GLuint sampler, GLenum pname, GLfloat param) |
| 2101 | { |
| 2102 | // The only float parameters are MIN_LOD and MAX_LOD. For these any value is permissible, so |
| 2103 | // ValidateSamplerParameteri can be used for validation here. |
| 2104 | return ValidateSamplerParameteri(context, sampler, pname, static_cast<GLint>(param)); |
| 2105 | } |
| 2106 | |
Olli Etuaho | 4f66748 | 2016-03-30 15:56:35 +0300 | [diff] [blame] | 2107 | bool ValidateGetBufferPointerv(Context *context, GLenum target, GLenum pname, GLvoid **params) |
| 2108 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 2109 | if (context->getClientMajorVersion() < 3) |
Olli Etuaho | 4f66748 | 2016-03-30 15:56:35 +0300 | [diff] [blame] | 2110 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 2111 | context->handleError(Error(GL_INVALID_OPERATION, "Context does not support GLES3.")); |
Olli Etuaho | 4f66748 | 2016-03-30 15:56:35 +0300 | [diff] [blame] | 2112 | return false; |
| 2113 | } |
| 2114 | |
| 2115 | return ValidateGetBufferPointervBase(context, target, pname, params); |
| 2116 | } |
| 2117 | |
| 2118 | bool ValidateUnmapBuffer(Context *context, GLenum target) |
| 2119 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 2120 | if (context->getClientMajorVersion() < 3) |
Olli Etuaho | 4f66748 | 2016-03-30 15:56:35 +0300 | [diff] [blame] | 2121 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 2122 | context->handleError(Error(GL_INVALID_OPERATION)); |
Olli Etuaho | 4f66748 | 2016-03-30 15:56:35 +0300 | [diff] [blame] | 2123 | return false; |
| 2124 | } |
| 2125 | |
| 2126 | return ValidateUnmapBufferBase(context, target); |
| 2127 | } |
| 2128 | |
| 2129 | bool ValidateMapBufferRange(Context *context, |
| 2130 | GLenum target, |
| 2131 | GLintptr offset, |
| 2132 | GLsizeiptr length, |
| 2133 | GLbitfield access) |
| 2134 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 2135 | if (context->getClientMajorVersion() < 3) |
Olli Etuaho | 4f66748 | 2016-03-30 15:56:35 +0300 | [diff] [blame] | 2136 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 2137 | context->handleError(Error(GL_INVALID_OPERATION, "Context does not support GLES3.")); |
Olli Etuaho | 4f66748 | 2016-03-30 15:56:35 +0300 | [diff] [blame] | 2138 | return false; |
| 2139 | } |
| 2140 | |
| 2141 | return ValidateMapBufferRangeBase(context, target, offset, length, access); |
| 2142 | } |
| 2143 | |
| 2144 | bool ValidateFlushMappedBufferRange(Context *context, |
| 2145 | GLenum target, |
| 2146 | GLintptr offset, |
| 2147 | GLsizeiptr length) |
| 2148 | { |
Martin Radev | 1be913c | 2016-07-11 17:59:16 +0300 | [diff] [blame] | 2149 | if (context->getClientMajorVersion() < 3) |
Olli Etuaho | 4f66748 | 2016-03-30 15:56:35 +0300 | [diff] [blame] | 2150 | { |
Jamie Madill | 437fa65 | 2016-05-03 15:13:24 -0400 | [diff] [blame] | 2151 | context->handleError(Error(GL_INVALID_OPERATION, "Context does not support GLES3.")); |
Olli Etuaho | 4f66748 | 2016-03-30 15:56:35 +0300 | [diff] [blame] | 2152 | return false; |
| 2153 | } |
| 2154 | |
| 2155 | return ValidateFlushMappedBufferRangeBase(context, target, offset, length); |
| 2156 | } |
| 2157 | |
Jamie Madill | c29968b | 2016-01-20 11:17:23 -0500 | [diff] [blame] | 2158 | } // namespace gl |