Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 1 | // |
| 2 | // Copyright (c) 2002-2015 The ANGLE Project Authors. All rights reserved. |
| 3 | // Use of this source code is governed by a BSD-style license that can be |
| 4 | // found in the LICENSE file. |
| 5 | // |
| 6 | // RemoveDynamicIndexing is an AST traverser to remove dynamic indexing of vectors and matrices, |
| 7 | // replacing them with calls to functions that choose which component to return or write. |
| 8 | // |
| 9 | |
| 10 | #include "compiler/translator/RemoveDynamicIndexing.h" |
| 11 | |
| 12 | #include "compiler/translator/InfoSink.h" |
Jamie Madill | 666f65a | 2016-08-26 01:34:37 +0000 | [diff] [blame] | 13 | #include "compiler/translator/IntermNodePatternMatcher.h" |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame^] | 14 | #include "compiler/translator/IntermNode_util.h" |
Olli Etuaho | cccf2b0 | 2017-07-05 14:50:54 +0300 | [diff] [blame] | 15 | #include "compiler/translator/IntermTraverse.h" |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 16 | #include "compiler/translator/SymbolTable.h" |
| 17 | |
Jamie Madill | 45bcc78 | 2016-11-07 13:58:48 -0500 | [diff] [blame] | 18 | namespace sh |
| 19 | { |
| 20 | |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 21 | namespace |
| 22 | { |
| 23 | |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 24 | std::string GetIndexFunctionName(const TType &type, bool write) |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 25 | { |
| 26 | TInfoSinkBase nameSink; |
| 27 | nameSink << "dyn_index_"; |
| 28 | if (write) |
| 29 | { |
| 30 | nameSink << "write_"; |
| 31 | } |
| 32 | if (type.isMatrix()) |
| 33 | { |
| 34 | nameSink << "mat" << type.getCols() << "x" << type.getRows(); |
| 35 | } |
| 36 | else |
| 37 | { |
| 38 | switch (type.getBasicType()) |
| 39 | { |
| 40 | case EbtInt: |
| 41 | nameSink << "ivec"; |
| 42 | break; |
| 43 | case EbtBool: |
| 44 | nameSink << "bvec"; |
| 45 | break; |
| 46 | case EbtUInt: |
| 47 | nameSink << "uvec"; |
| 48 | break; |
| 49 | case EbtFloat: |
| 50 | nameSink << "vec"; |
| 51 | break; |
| 52 | default: |
| 53 | UNREACHABLE(); |
| 54 | } |
| 55 | nameSink << type.getNominalSize(); |
| 56 | } |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 57 | return nameSink.str(); |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 58 | } |
| 59 | |
| 60 | TIntermSymbol *CreateBaseSymbol(const TType &type, TQualifier qualifier) |
| 61 | { |
| 62 | TIntermSymbol *symbol = new TIntermSymbol(0, "base", type); |
| 63 | symbol->setInternal(true); |
| 64 | symbol->getTypePointer()->setQualifier(qualifier); |
| 65 | return symbol; |
| 66 | } |
| 67 | |
| 68 | TIntermSymbol *CreateIndexSymbol() |
| 69 | { |
| 70 | TIntermSymbol *symbol = new TIntermSymbol(0, "index", TType(EbtInt, EbpHigh)); |
| 71 | symbol->setInternal(true); |
| 72 | symbol->getTypePointer()->setQualifier(EvqIn); |
| 73 | return symbol; |
| 74 | } |
| 75 | |
| 76 | TIntermSymbol *CreateValueSymbol(const TType &type) |
| 77 | { |
| 78 | TIntermSymbol *symbol = new TIntermSymbol(0, "value", type); |
| 79 | symbol->setInternal(true); |
| 80 | symbol->getTypePointer()->setQualifier(EvqIn); |
| 81 | return symbol; |
| 82 | } |
| 83 | |
| 84 | TIntermConstantUnion *CreateIntConstantNode(int i) |
| 85 | { |
| 86 | TConstantUnion *constant = new TConstantUnion(); |
| 87 | constant->setIConst(i); |
| 88 | return new TIntermConstantUnion(constant, TType(EbtInt, EbpHigh)); |
| 89 | } |
| 90 | |
| 91 | TIntermBinary *CreateIndexDirectBaseSymbolNode(const TType &indexedType, |
| 92 | const TType &fieldType, |
| 93 | const int index, |
| 94 | TQualifier baseQualifier) |
| 95 | { |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 96 | TIntermSymbol *baseSymbol = CreateBaseSymbol(indexedType, baseQualifier); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 97 | TIntermBinary *indexNode = |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame^] | 98 | new TIntermBinary(EOpIndexDirect, baseSymbol, CreateIndexNode(index)); |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 99 | return indexNode; |
| 100 | } |
| 101 | |
| 102 | TIntermBinary *CreateAssignValueSymbolNode(TIntermTyped *targetNode, const TType &assignedValueType) |
| 103 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 104 | return new TIntermBinary(EOpAssign, targetNode, CreateValueSymbol(assignedValueType)); |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 105 | } |
| 106 | |
| 107 | TIntermTyped *EnsureSignedInt(TIntermTyped *node) |
| 108 | { |
| 109 | if (node->getBasicType() == EbtInt) |
| 110 | return node; |
| 111 | |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 112 | TIntermSequence *arguments = new TIntermSequence(); |
| 113 | arguments->push_back(node); |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 114 | return TIntermAggregate::CreateConstructor(TType(EbtInt), arguments); |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 115 | } |
| 116 | |
| 117 | TType GetFieldType(const TType &indexedType) |
| 118 | { |
| 119 | if (indexedType.isMatrix()) |
| 120 | { |
| 121 | TType fieldType = TType(indexedType.getBasicType(), indexedType.getPrecision()); |
| 122 | fieldType.setPrimarySize(static_cast<unsigned char>(indexedType.getRows())); |
| 123 | return fieldType; |
| 124 | } |
| 125 | else |
| 126 | { |
| 127 | return TType(indexedType.getBasicType(), indexedType.getPrecision()); |
| 128 | } |
| 129 | } |
| 130 | |
| 131 | // Generate a read or write function for one field in a vector/matrix. |
| 132 | // Out-of-range indices are clamped. This is consistent with how ANGLE handles out-of-range |
| 133 | // indices in other places. |
| 134 | // Note that indices can be either int or uint. We create only int versions of the functions, |
| 135 | // and convert uint indices to int at the call site. |
| 136 | // read function example: |
| 137 | // float dyn_index_vec2(in vec2 base, in int index) |
| 138 | // { |
| 139 | // switch(index) |
| 140 | // { |
| 141 | // case (0): |
| 142 | // return base[0]; |
| 143 | // case (1): |
| 144 | // return base[1]; |
| 145 | // default: |
| 146 | // break; |
| 147 | // } |
| 148 | // if (index < 0) |
| 149 | // return base[0]; |
| 150 | // return base[1]; |
| 151 | // } |
| 152 | // write function example: |
| 153 | // void dyn_index_write_vec2(inout vec2 base, in int index, in float value) |
| 154 | // { |
| 155 | // switch(index) |
| 156 | // { |
| 157 | // case (0): |
| 158 | // base[0] = value; |
| 159 | // return; |
| 160 | // case (1): |
| 161 | // base[1] = value; |
| 162 | // return; |
| 163 | // default: |
| 164 | // break; |
| 165 | // } |
| 166 | // if (index < 0) |
| 167 | // { |
| 168 | // base[0] = value; |
| 169 | // return; |
| 170 | // } |
| 171 | // base[1] = value; |
| 172 | // } |
| 173 | // Note that else is not used in above functions to avoid the RewriteElseBlocks transformation. |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 174 | TIntermFunctionDefinition *GetIndexFunctionDefinition(TType type, |
| 175 | bool write, |
| 176 | const TSymbolUniqueId &functionId) |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 177 | { |
| 178 | ASSERT(!type.isArray()); |
| 179 | // Conservatively use highp here, even if the indexed type is not highp. That way the code can't |
| 180 | // end up using mediump version of an indexing function for a highp value, if both mediump and |
| 181 | // highp values are being indexed in the shader. For HLSL precision doesn't matter, but in |
| 182 | // principle this code could be used with multiple backends. |
| 183 | type.setPrecision(EbpHigh); |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 184 | |
| 185 | TType fieldType = GetFieldType(type); |
Jamie Madill | d7b1ab5 | 2016-12-12 14:42:19 -0500 | [diff] [blame] | 186 | int numCases = 0; |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 187 | if (type.isMatrix()) |
| 188 | { |
| 189 | numCases = type.getCols(); |
| 190 | } |
| 191 | else |
| 192 | { |
| 193 | numCases = type.getNominalSize(); |
| 194 | } |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 195 | |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 196 | TType returnType(EbtVoid); |
| 197 | if (!write) |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 198 | { |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 199 | returnType = fieldType; |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 200 | } |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 201 | |
| 202 | std::string functionName = GetIndexFunctionName(type, write); |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame^] | 203 | TIntermFunctionPrototype *prototypeNode = |
| 204 | CreateInternalFunctionPrototypeNode(returnType, functionName.c_str(), functionId); |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 205 | |
Jamie Madill | d7b1ab5 | 2016-12-12 14:42:19 -0500 | [diff] [blame] | 206 | TQualifier baseQualifier = EvqInOut; |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 207 | if (!write) |
| 208 | baseQualifier = EvqIn; |
| 209 | TIntermSymbol *baseParam = CreateBaseSymbol(type, baseQualifier); |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 210 | prototypeNode->getSequence()->push_back(baseParam); |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 211 | TIntermSymbol *indexParam = CreateIndexSymbol(); |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 212 | prototypeNode->getSequence()->push_back(indexParam); |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 213 | if (write) |
| 214 | { |
| 215 | TIntermSymbol *valueParam = CreateValueSymbol(fieldType); |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 216 | prototypeNode->getSequence()->push_back(valueParam); |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 217 | } |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 218 | |
Olli Etuaho | 6d40bbd | 2016-09-30 13:49:38 +0100 | [diff] [blame] | 219 | TIntermBlock *statementList = new TIntermBlock(); |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 220 | for (int i = 0; i < numCases; ++i) |
| 221 | { |
| 222 | TIntermCase *caseNode = new TIntermCase(CreateIntConstantNode(i)); |
| 223 | statementList->getSequence()->push_back(caseNode); |
| 224 | |
| 225 | TIntermBinary *indexNode = |
| 226 | CreateIndexDirectBaseSymbolNode(type, fieldType, i, baseQualifier); |
| 227 | if (write) |
| 228 | { |
| 229 | TIntermBinary *assignNode = CreateAssignValueSymbolNode(indexNode, fieldType); |
| 230 | statementList->getSequence()->push_back(assignNode); |
| 231 | TIntermBranch *returnNode = new TIntermBranch(EOpReturn, nullptr); |
| 232 | statementList->getSequence()->push_back(returnNode); |
| 233 | } |
| 234 | else |
| 235 | { |
| 236 | TIntermBranch *returnNode = new TIntermBranch(EOpReturn, indexNode); |
| 237 | statementList->getSequence()->push_back(returnNode); |
| 238 | } |
| 239 | } |
| 240 | |
| 241 | // Default case |
| 242 | TIntermCase *defaultNode = new TIntermCase(nullptr); |
| 243 | statementList->getSequence()->push_back(defaultNode); |
| 244 | TIntermBranch *breakNode = new TIntermBranch(EOpBreak, nullptr); |
| 245 | statementList->getSequence()->push_back(breakNode); |
| 246 | |
| 247 | TIntermSwitch *switchNode = new TIntermSwitch(CreateIndexSymbol(), statementList); |
| 248 | |
Olli Etuaho | 6d40bbd | 2016-09-30 13:49:38 +0100 | [diff] [blame] | 249 | TIntermBlock *bodyNode = new TIntermBlock(); |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 250 | bodyNode->getSequence()->push_back(switchNode); |
| 251 | |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 252 | TIntermBinary *cond = |
| 253 | new TIntermBinary(EOpLessThan, CreateIndexSymbol(), CreateIntConstantNode(0)); |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 254 | cond->setType(TType(EbtBool, EbpUndefined)); |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 255 | |
| 256 | // Two blocks: one accesses (either reads or writes) the first element and returns, |
| 257 | // the other accesses the last element. |
Olli Etuaho | 6d40bbd | 2016-09-30 13:49:38 +0100 | [diff] [blame] | 258 | TIntermBlock *useFirstBlock = new TIntermBlock(); |
| 259 | TIntermBlock *useLastBlock = new TIntermBlock(); |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 260 | TIntermBinary *indexFirstNode = |
| 261 | CreateIndexDirectBaseSymbolNode(type, fieldType, 0, baseQualifier); |
| 262 | TIntermBinary *indexLastNode = |
| 263 | CreateIndexDirectBaseSymbolNode(type, fieldType, numCases - 1, baseQualifier); |
| 264 | if (write) |
| 265 | { |
| 266 | TIntermBinary *assignFirstNode = CreateAssignValueSymbolNode(indexFirstNode, fieldType); |
| 267 | useFirstBlock->getSequence()->push_back(assignFirstNode); |
| 268 | TIntermBranch *returnNode = new TIntermBranch(EOpReturn, nullptr); |
| 269 | useFirstBlock->getSequence()->push_back(returnNode); |
| 270 | |
| 271 | TIntermBinary *assignLastNode = CreateAssignValueSymbolNode(indexLastNode, fieldType); |
| 272 | useLastBlock->getSequence()->push_back(assignLastNode); |
| 273 | } |
| 274 | else |
| 275 | { |
| 276 | TIntermBranch *returnFirstNode = new TIntermBranch(EOpReturn, indexFirstNode); |
| 277 | useFirstBlock->getSequence()->push_back(returnFirstNode); |
| 278 | |
| 279 | TIntermBranch *returnLastNode = new TIntermBranch(EOpReturn, indexLastNode); |
| 280 | useLastBlock->getSequence()->push_back(returnLastNode); |
| 281 | } |
Olli Etuaho | 5796127 | 2016-09-14 13:57:46 +0300 | [diff] [blame] | 282 | TIntermIfElse *ifNode = new TIntermIfElse(cond, useFirstBlock, nullptr); |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 283 | bodyNode->getSequence()->push_back(ifNode); |
| 284 | bodyNode->getSequence()->push_back(useLastBlock); |
| 285 | |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 286 | TIntermFunctionDefinition *indexingFunction = |
| 287 | new TIntermFunctionDefinition(prototypeNode, bodyNode); |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 288 | return indexingFunction; |
| 289 | } |
| 290 | |
| 291 | class RemoveDynamicIndexingTraverser : public TLValueTrackingTraverser |
| 292 | { |
| 293 | public: |
| 294 | RemoveDynamicIndexingTraverser(const TSymbolTable &symbolTable, int shaderVersion); |
| 295 | |
| 296 | bool visitBinary(Visit visit, TIntermBinary *node) override; |
| 297 | |
| 298 | void insertHelperDefinitions(TIntermNode *root); |
| 299 | |
| 300 | void nextIteration(); |
| 301 | |
| 302 | bool usedTreeInsertion() const { return mUsedTreeInsertion; } |
| 303 | |
| 304 | protected: |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 305 | // Maps of types that are indexed to the indexing function ids used for them. Note that these |
| 306 | // can not store multiple variants of the same type with different precisions - only one |
| 307 | // precision gets stored. |
| 308 | std::map<TType, TSymbolUniqueId> mIndexedVecAndMatrixTypes; |
| 309 | std::map<TType, TSymbolUniqueId> mWrittenVecAndMatrixTypes; |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 310 | |
| 311 | bool mUsedTreeInsertion; |
| 312 | |
| 313 | // When true, the traverser will remove side effects from any indexing expression. |
| 314 | // This is done so that in code like |
| 315 | // V[j++][i]++. |
| 316 | // where V is an array of vectors, j++ will only be evaluated once. |
| 317 | bool mRemoveIndexSideEffectsInSubtree; |
| 318 | }; |
| 319 | |
| 320 | RemoveDynamicIndexingTraverser::RemoveDynamicIndexingTraverser(const TSymbolTable &symbolTable, |
| 321 | int shaderVersion) |
| 322 | : TLValueTrackingTraverser(true, false, false, symbolTable, shaderVersion), |
| 323 | mUsedTreeInsertion(false), |
| 324 | mRemoveIndexSideEffectsInSubtree(false) |
| 325 | { |
| 326 | } |
| 327 | |
| 328 | void RemoveDynamicIndexingTraverser::insertHelperDefinitions(TIntermNode *root) |
| 329 | { |
Olli Etuaho | 6d40bbd | 2016-09-30 13:49:38 +0100 | [diff] [blame] | 330 | TIntermBlock *rootBlock = root->getAsBlock(); |
| 331 | ASSERT(rootBlock != nullptr); |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 332 | TIntermSequence insertions; |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 333 | for (auto &type : mIndexedVecAndMatrixTypes) |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 334 | { |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 335 | insertions.push_back(GetIndexFunctionDefinition(type.first, false, type.second)); |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 336 | } |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 337 | for (auto &type : mWrittenVecAndMatrixTypes) |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 338 | { |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 339 | insertions.push_back(GetIndexFunctionDefinition(type.first, true, type.second)); |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 340 | } |
Olli Etuaho | 6d40bbd | 2016-09-30 13:49:38 +0100 | [diff] [blame] | 341 | mInsertions.push_back(NodeInsertMultipleEntry(rootBlock, 0, insertions, TIntermSequence())); |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 342 | } |
| 343 | |
| 344 | // Create a call to dyn_index_*() based on an indirect indexing op node |
| 345 | TIntermAggregate *CreateIndexFunctionCall(TIntermBinary *node, |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 346 | TIntermTyped *index, |
| 347 | const TSymbolUniqueId &functionId) |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 348 | { |
| 349 | ASSERT(node->getOp() == EOpIndexIndirect); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 350 | TIntermSequence *arguments = new TIntermSequence(); |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 351 | arguments->push_back(node->getLeft()); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 352 | arguments->push_back(index); |
| 353 | |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 354 | TType fieldType = GetFieldType(node->getLeft()->getType()); |
| 355 | std::string functionName = GetIndexFunctionName(node->getLeft()->getType(), false); |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame^] | 356 | TIntermAggregate *indexingCall = |
| 357 | CreateInternalFunctionCallNode(fieldType, functionName.c_str(), functionId, arguments); |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 358 | indexingCall->setLine(node->getLine()); |
Olli Etuaho | a22aa4e | 2017-05-24 18:17:23 +0300 | [diff] [blame] | 359 | indexingCall->getFunctionSymbolInfo()->setKnownToNotHaveSideEffects(true); |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 360 | return indexingCall; |
| 361 | } |
| 362 | |
| 363 | TIntermAggregate *CreateIndexedWriteFunctionCall(TIntermBinary *node, |
| 364 | TIntermTyped *index, |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 365 | TIntermTyped *writtenValue, |
| 366 | const TSymbolUniqueId &functionId) |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 367 | { |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 368 | ASSERT(node->getOp() == EOpIndexIndirect); |
| 369 | TIntermSequence *arguments = new TIntermSequence(); |
| 370 | // Deep copy the child nodes so that two pointers to the same node don't end up in the tree. |
| 371 | arguments->push_back(node->getLeft()->deepCopy()); |
| 372 | arguments->push_back(index->deepCopy()); |
| 373 | arguments->push_back(writtenValue); |
| 374 | |
| 375 | std::string functionName = GetIndexFunctionName(node->getLeft()->getType(), true); |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame^] | 376 | TIntermAggregate *indexedWriteCall = |
| 377 | CreateInternalFunctionCallNode(TType(EbtVoid), functionName.c_str(), functionId, arguments); |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 378 | indexedWriteCall->setLine(node->getLine()); |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 379 | return indexedWriteCall; |
| 380 | } |
| 381 | |
| 382 | bool RemoveDynamicIndexingTraverser::visitBinary(Visit visit, TIntermBinary *node) |
| 383 | { |
| 384 | if (mUsedTreeInsertion) |
| 385 | return false; |
| 386 | |
| 387 | if (node->getOp() == EOpIndexIndirect) |
| 388 | { |
| 389 | if (mRemoveIndexSideEffectsInSubtree) |
| 390 | { |
| 391 | ASSERT(node->getRight()->hasSideEffects()); |
| 392 | // In case we're just removing index side effects, convert |
| 393 | // v_expr[index_expr] |
| 394 | // to this: |
| 395 | // int s0 = index_expr; v_expr[s0]; |
| 396 | // Now v_expr[s0] can be safely executed several times without unintended side effects. |
| 397 | |
| 398 | // Init the temp variable holding the index |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 399 | TIntermDeclaration *initIndex = createTempInitDeclaration(node->getRight()); |
Jamie Madill | 1048e43 | 2016-07-23 18:51:28 -0400 | [diff] [blame] | 400 | insertStatementInParentBlock(initIndex); |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 401 | mUsedTreeInsertion = true; |
| 402 | |
| 403 | // Replace the index with the temp variable |
| 404 | TIntermSymbol *tempIndex = createTempSymbol(node->getRight()->getType()); |
Jamie Madill | 03d863c | 2016-07-27 18:15:53 -0400 | [diff] [blame] | 405 | queueReplacementWithParent(node, node->getRight(), tempIndex, OriginalNode::IS_DROPPED); |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 406 | } |
Jamie Madill | 666f65a | 2016-08-26 01:34:37 +0000 | [diff] [blame] | 407 | else if (IntermNodePatternMatcher::IsDynamicIndexingOfVectorOrMatrix(node)) |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 408 | { |
| 409 | bool write = isLValueRequiredHere(); |
| 410 | |
Jamie Madill | 666f65a | 2016-08-26 01:34:37 +0000 | [diff] [blame] | 411 | #if defined(ANGLE_ENABLE_ASSERTS) |
| 412 | // Make sure that IntermNodePatternMatcher is consistent with the slightly differently |
| 413 | // implemented checks in this traverser. |
| 414 | IntermNodePatternMatcher matcher( |
| 415 | IntermNodePatternMatcher::kDynamicIndexingOfVectorOrMatrixInLValue); |
| 416 | ASSERT(matcher.match(node, getParentNode(), isLValueRequiredHere()) == write); |
| 417 | #endif |
| 418 | |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 419 | const TType &type = node->getLeft()->getType(); |
| 420 | TSymbolUniqueId indexingFunctionId; |
| 421 | if (mIndexedVecAndMatrixTypes.find(type) == mIndexedVecAndMatrixTypes.end()) |
| 422 | { |
| 423 | mIndexedVecAndMatrixTypes[type] = indexingFunctionId; |
| 424 | } |
| 425 | else |
| 426 | { |
| 427 | indexingFunctionId = mIndexedVecAndMatrixTypes[type]; |
| 428 | } |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 429 | |
| 430 | if (write) |
| 431 | { |
| 432 | // Convert: |
| 433 | // v_expr[index_expr]++; |
| 434 | // to this: |
| 435 | // int s0 = index_expr; float s1 = dyn_index(v_expr, s0); s1++; |
| 436 | // dyn_index_write(v_expr, s0, s1); |
| 437 | // This works even if index_expr has some side effects. |
| 438 | if (node->getLeft()->hasSideEffects()) |
| 439 | { |
| 440 | // If v_expr has side effects, those need to be removed before proceeding. |
| 441 | // Otherwise the side effects of v_expr would be evaluated twice. |
| 442 | // The only case where an l-value can have side effects is when it is |
| 443 | // indexing. For example, it can be V[j++] where V is an array of vectors. |
| 444 | mRemoveIndexSideEffectsInSubtree = true; |
| 445 | return true; |
| 446 | } |
Olli Etuaho | 8f6eb2a | 2017-01-12 17:04:58 +0000 | [diff] [blame] | 447 | |
| 448 | TIntermBinary *leftBinary = node->getLeft()->getAsBinaryNode(); |
| 449 | if (leftBinary != nullptr && |
| 450 | IntermNodePatternMatcher::IsDynamicIndexingOfVectorOrMatrix(leftBinary)) |
| 451 | { |
| 452 | // This is a case like: |
| 453 | // mat2 m; |
| 454 | // m[a][b]++; |
| 455 | // Process the child node m[a] first. |
| 456 | return true; |
| 457 | } |
| 458 | |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 459 | // TODO(oetuaho@nvidia.com): This is not optimal if the expression using the value |
| 460 | // only writes it and doesn't need the previous value. http://anglebug.com/1116 |
| 461 | |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 462 | TSymbolUniqueId indexedWriteFunctionId; |
| 463 | if (mWrittenVecAndMatrixTypes.find(type) == mWrittenVecAndMatrixTypes.end()) |
| 464 | { |
| 465 | mWrittenVecAndMatrixTypes[type] = indexedWriteFunctionId; |
| 466 | } |
| 467 | else |
| 468 | { |
| 469 | indexedWriteFunctionId = mWrittenVecAndMatrixTypes[type]; |
| 470 | } |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 471 | TType fieldType = GetFieldType(type); |
| 472 | |
| 473 | TIntermSequence insertionsBefore; |
| 474 | TIntermSequence insertionsAfter; |
| 475 | |
| 476 | // Store the index in a temporary signed int variable. |
| 477 | TIntermTyped *indexInitializer = EnsureSignedInt(node->getRight()); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 478 | TIntermDeclaration *initIndex = createTempInitDeclaration(indexInitializer); |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 479 | initIndex->setLine(node->getLine()); |
| 480 | insertionsBefore.push_back(initIndex); |
| 481 | |
Olli Etuaho | 4dd06d5 | 2017-07-05 12:41:06 +0300 | [diff] [blame] | 482 | // Create a node for referring to the index after the nextTemporaryId() call |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 483 | // below. |
| 484 | TIntermSymbol *tempIndex = createTempSymbol(indexInitializer->getType()); |
| 485 | |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 486 | TIntermAggregate *indexingCall = |
| 487 | CreateIndexFunctionCall(node, tempIndex, indexingFunctionId); |
| 488 | |
Olli Etuaho | 4dd06d5 | 2017-07-05 12:41:06 +0300 | [diff] [blame] | 489 | nextTemporaryId(); // From now on, creating temporary symbols that refer to the |
| 490 | // field value. |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 491 | insertionsBefore.push_back(createTempInitDeclaration(indexingCall)); |
| 492 | |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 493 | TIntermAggregate *indexedWriteCall = CreateIndexedWriteFunctionCall( |
| 494 | node, tempIndex, createTempSymbol(fieldType), indexedWriteFunctionId); |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 495 | insertionsAfter.push_back(indexedWriteCall); |
| 496 | insertStatementsInParentBlock(insertionsBefore, insertionsAfter); |
Olli Etuaho | ea39a22 | 2017-07-06 12:47:59 +0300 | [diff] [blame] | 497 | queueReplacement(createTempSymbol(fieldType), OriginalNode::IS_DROPPED); |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 498 | mUsedTreeInsertion = true; |
| 499 | } |
| 500 | else |
| 501 | { |
| 502 | // The indexed value is not being written, so we can simply convert |
| 503 | // v_expr[index_expr] |
| 504 | // into |
| 505 | // dyn_index(v_expr, index_expr) |
| 506 | // If the index_expr is unsigned, we'll convert it to signed. |
| 507 | ASSERT(!mRemoveIndexSideEffectsInSubtree); |
| 508 | TIntermAggregate *indexingCall = CreateIndexFunctionCall( |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 509 | node, EnsureSignedInt(node->getRight()), indexingFunctionId); |
Olli Etuaho | ea39a22 | 2017-07-06 12:47:59 +0300 | [diff] [blame] | 510 | queueReplacement(indexingCall, OriginalNode::IS_DROPPED); |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 511 | } |
| 512 | } |
| 513 | } |
| 514 | return !mUsedTreeInsertion; |
| 515 | } |
| 516 | |
| 517 | void RemoveDynamicIndexingTraverser::nextIteration() |
| 518 | { |
| 519 | mUsedTreeInsertion = false; |
| 520 | mRemoveIndexSideEffectsInSubtree = false; |
Olli Etuaho | 4dd06d5 | 2017-07-05 12:41:06 +0300 | [diff] [blame] | 521 | nextTemporaryId(); |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 522 | } |
| 523 | |
| 524 | } // namespace |
| 525 | |
| 526 | void RemoveDynamicIndexing(TIntermNode *root, |
Olli Etuaho | 4dd06d5 | 2017-07-05 12:41:06 +0300 | [diff] [blame] | 527 | TSymbolUniqueId *temporaryId, |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 528 | const TSymbolTable &symbolTable, |
| 529 | int shaderVersion) |
| 530 | { |
| 531 | RemoveDynamicIndexingTraverser traverser(symbolTable, shaderVersion); |
Olli Etuaho | 4dd06d5 | 2017-07-05 12:41:06 +0300 | [diff] [blame] | 532 | ASSERT(temporaryId != nullptr); |
| 533 | traverser.useTemporaryId(temporaryId); |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 534 | do |
| 535 | { |
| 536 | traverser.nextIteration(); |
| 537 | root->traverse(&traverser); |
| 538 | traverser.updateTree(); |
| 539 | } while (traverser.usedTreeInsertion()); |
Olli Etuaho | 1ecd14b | 2017-01-26 13:54:15 -0800 | [diff] [blame] | 540 | // TOOD(oetuaho@nvidia.com): It might be nicer to add the helper definitions also in the middle |
| 541 | // of traversal. Now the tree ends up in an inconsistent state in the middle, since there are |
| 542 | // function call nodes with no corresponding definition nodes. This needs special handling in |
| 543 | // TIntermLValueTrackingTraverser, and creates intricacies that are not easily apparent from a |
| 544 | // superficial reading of the code. |
Olli Etuaho | 5d91dda | 2015-06-18 15:47:46 +0300 | [diff] [blame] | 545 | traverser.insertHelperDefinitions(root); |
| 546 | traverser.updateTree(); |
| 547 | } |
Jamie Madill | 45bcc78 | 2016-11-07 13:58:48 -0500 | [diff] [blame] | 548 | |
| 549 | } // namespace sh |