blob: 2d3a039e139e05e4615a3b273a8032611b96d54d [file] [log] [blame]
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001//
Geoff Langcec35902014-04-16 10:52:36 -04002// Copyright (c) 2013-2014 The ANGLE Project Authors. All rights reserved.
Geoff Lange8ebe7f2013-08-05 15:03:13 -04003// Use of this source code is governed by a BSD-style license that can be
4// found in the LICENSE file.
5//
6
7// validationES3.cpp: Validation functions for OpenGL ES 3.0 entry point parameters
8
9#include "libGLESv2/validationES3.h"
Geoff Langce635692013-09-24 13:56:32 -040010#include "libGLESv2/validationES.h"
Geoff Lange8ebe7f2013-08-05 15:03:13 -040011#include "libGLESv2/Context.h"
12#include "libGLESv2/Texture.h"
13#include "libGLESv2/Framebuffer.h"
14#include "libGLESv2/Renderbuffer.h"
15#include "libGLESv2/formatutils.h"
16#include "libGLESv2/main.h"
Jamie Madille261b442014-06-25 12:42:21 -040017#include "libGLESv2/FramebufferAttachment.h"
Geoff Lange8ebe7f2013-08-05 15:03:13 -040018
19#include "common/mathutil.h"
20
21namespace gl
22{
23
Geoff Lang5d601382014-07-22 15:14:06 -040024struct ES3FormatCombination
25{
26 GLenum internalFormat;
27 GLenum format;
28 GLenum type;
29};
30
31bool operator<(const ES3FormatCombination& a, const ES3FormatCombination& b)
32{
33 return memcmp(&a, &b, sizeof(ES3FormatCombination)) < 0;
34}
35
36typedef std::set<ES3FormatCombination> ES3FormatCombinationSet;
37
38static inline void InsertES3FormatCombo(ES3FormatCombinationSet *set, GLenum internalFormat, GLenum format, GLenum type)
39{
40 ES3FormatCombination info;
41 info.internalFormat = internalFormat;
42 info.format = format;
43 info.type = type;
44 set->insert(info);
45}
46
47ES3FormatCombinationSet BuildES3FormatSet()
48{
49 ES3FormatCombinationSet set;
50
51 // Format combinations from ES 3.0.1 spec, table 3.2
52
53 // | Internal format | Format | Type |
54 // | | | |
55 InsertES3FormatCombo(&set, GL_RGBA8, GL_RGBA, GL_UNSIGNED_BYTE );
56 InsertES3FormatCombo(&set, GL_RGB5_A1, GL_RGBA, GL_UNSIGNED_BYTE );
57 InsertES3FormatCombo(&set, GL_RGBA4, GL_RGBA, GL_UNSIGNED_BYTE );
58 InsertES3FormatCombo(&set, GL_SRGB8_ALPHA8, GL_RGBA, GL_UNSIGNED_BYTE );
59 InsertES3FormatCombo(&set, GL_RGBA8_SNORM, GL_RGBA, GL_BYTE );
60 InsertES3FormatCombo(&set, GL_RGBA4, GL_RGBA, GL_UNSIGNED_SHORT_4_4_4_4 );
61 InsertES3FormatCombo(&set, GL_RGB10_A2, GL_RGBA, GL_UNSIGNED_INT_2_10_10_10_REV );
62 InsertES3FormatCombo(&set, GL_RGB5_A1, GL_RGBA, GL_UNSIGNED_INT_2_10_10_10_REV );
63 InsertES3FormatCombo(&set, GL_RGB5_A1, GL_RGBA, GL_UNSIGNED_SHORT_5_5_5_1 );
64 InsertES3FormatCombo(&set, GL_RGBA16F, GL_RGBA, GL_HALF_FLOAT );
65 InsertES3FormatCombo(&set, GL_RGBA16F, GL_RGBA, GL_HALF_FLOAT_OES );
66 InsertES3FormatCombo(&set, GL_RGBA32F, GL_RGBA, GL_FLOAT );
67 InsertES3FormatCombo(&set, GL_RGBA16F, GL_RGBA, GL_FLOAT );
68 InsertES3FormatCombo(&set, GL_RGBA8UI, GL_RGBA_INTEGER, GL_UNSIGNED_BYTE );
69 InsertES3FormatCombo(&set, GL_RGBA8I, GL_RGBA_INTEGER, GL_BYTE );
70 InsertES3FormatCombo(&set, GL_RGBA16UI, GL_RGBA_INTEGER, GL_UNSIGNED_SHORT );
71 InsertES3FormatCombo(&set, GL_RGBA16I, GL_RGBA_INTEGER, GL_SHORT );
72 InsertES3FormatCombo(&set, GL_RGBA32UI, GL_RGBA_INTEGER, GL_UNSIGNED_INT );
73 InsertES3FormatCombo(&set, GL_RGBA32I, GL_RGBA_INTEGER, GL_INT );
74 InsertES3FormatCombo(&set, GL_RGB10_A2UI, GL_RGBA_INTEGER, GL_UNSIGNED_INT_2_10_10_10_REV );
75 InsertES3FormatCombo(&set, GL_RGB8, GL_RGB, GL_UNSIGNED_BYTE );
76 InsertES3FormatCombo(&set, GL_RGB565, GL_RGB, GL_UNSIGNED_BYTE );
77 InsertES3FormatCombo(&set, GL_SRGB8, GL_RGB, GL_UNSIGNED_BYTE );
78 InsertES3FormatCombo(&set, GL_RGB8_SNORM, GL_RGB, GL_BYTE );
79 InsertES3FormatCombo(&set, GL_RGB565, GL_RGB, GL_UNSIGNED_SHORT_5_6_5 );
80 InsertES3FormatCombo(&set, GL_R11F_G11F_B10F, GL_RGB, GL_UNSIGNED_INT_10F_11F_11F_REV );
81 InsertES3FormatCombo(&set, GL_RGB9_E5, GL_RGB, GL_UNSIGNED_INT_5_9_9_9_REV );
82 InsertES3FormatCombo(&set, GL_RGB16F, GL_RGB, GL_HALF_FLOAT );
83 InsertES3FormatCombo(&set, GL_RGB16F, GL_RGB, GL_HALF_FLOAT_OES );
84 InsertES3FormatCombo(&set, GL_R11F_G11F_B10F, GL_RGB, GL_HALF_FLOAT );
85 InsertES3FormatCombo(&set, GL_R11F_G11F_B10F, GL_RGB, GL_HALF_FLOAT_OES );
86 InsertES3FormatCombo(&set, GL_RGB9_E5, GL_RGB, GL_HALF_FLOAT );
87 InsertES3FormatCombo(&set, GL_RGB9_E5, GL_RGB, GL_HALF_FLOAT_OES );
88 InsertES3FormatCombo(&set, GL_RGB32F, GL_RGB, GL_FLOAT );
89 InsertES3FormatCombo(&set, GL_RGB16F, GL_RGB, GL_FLOAT );
90 InsertES3FormatCombo(&set, GL_R11F_G11F_B10F, GL_RGB, GL_FLOAT );
91 InsertES3FormatCombo(&set, GL_RGB9_E5, GL_RGB, GL_FLOAT );
92 InsertES3FormatCombo(&set, GL_RGB8UI, GL_RGB_INTEGER, GL_UNSIGNED_BYTE );
93 InsertES3FormatCombo(&set, GL_RGB8I, GL_RGB_INTEGER, GL_BYTE );
94 InsertES3FormatCombo(&set, GL_RGB16UI, GL_RGB_INTEGER, GL_UNSIGNED_SHORT );
95 InsertES3FormatCombo(&set, GL_RGB16I, GL_RGB_INTEGER, GL_SHORT );
96 InsertES3FormatCombo(&set, GL_RGB32UI, GL_RGB_INTEGER, GL_UNSIGNED_INT );
97 InsertES3FormatCombo(&set, GL_RGB32I, GL_RGB_INTEGER, GL_INT );
98 InsertES3FormatCombo(&set, GL_RG8, GL_RG, GL_UNSIGNED_BYTE );
99 InsertES3FormatCombo(&set, GL_RG8_SNORM, GL_RG, GL_BYTE );
100 InsertES3FormatCombo(&set, GL_RG16F, GL_RG, GL_HALF_FLOAT );
101 InsertES3FormatCombo(&set, GL_RG16F, GL_RG, GL_HALF_FLOAT_OES );
102 InsertES3FormatCombo(&set, GL_RG32F, GL_RG, GL_FLOAT );
103 InsertES3FormatCombo(&set, GL_RG16F, GL_RG, GL_FLOAT );
104 InsertES3FormatCombo(&set, GL_RG8UI, GL_RG_INTEGER, GL_UNSIGNED_BYTE );
105 InsertES3FormatCombo(&set, GL_RG8I, GL_RG_INTEGER, GL_BYTE );
106 InsertES3FormatCombo(&set, GL_RG16UI, GL_RG_INTEGER, GL_UNSIGNED_SHORT );
107 InsertES3FormatCombo(&set, GL_RG16I, GL_RG_INTEGER, GL_SHORT );
108 InsertES3FormatCombo(&set, GL_RG32UI, GL_RG_INTEGER, GL_UNSIGNED_INT );
109 InsertES3FormatCombo(&set, GL_RG32I, GL_RG_INTEGER, GL_INT );
110 InsertES3FormatCombo(&set, GL_R8, GL_RED, GL_UNSIGNED_BYTE );
111 InsertES3FormatCombo(&set, GL_R8_SNORM, GL_RED, GL_BYTE );
112 InsertES3FormatCombo(&set, GL_R16F, GL_RED, GL_HALF_FLOAT );
113 InsertES3FormatCombo(&set, GL_R16F, GL_RED, GL_HALF_FLOAT_OES );
114 InsertES3FormatCombo(&set, GL_R32F, GL_RED, GL_FLOAT );
115 InsertES3FormatCombo(&set, GL_R16F, GL_RED, GL_FLOAT );
116 InsertES3FormatCombo(&set, GL_R8UI, GL_RED_INTEGER, GL_UNSIGNED_BYTE );
117 InsertES3FormatCombo(&set, GL_R8I, GL_RED_INTEGER, GL_BYTE );
118 InsertES3FormatCombo(&set, GL_R16UI, GL_RED_INTEGER, GL_UNSIGNED_SHORT );
119 InsertES3FormatCombo(&set, GL_R16I, GL_RED_INTEGER, GL_SHORT );
120 InsertES3FormatCombo(&set, GL_R32UI, GL_RED_INTEGER, GL_UNSIGNED_INT );
121 InsertES3FormatCombo(&set, GL_R32I, GL_RED_INTEGER, GL_INT );
122
123 // Unsized formats
124 InsertES3FormatCombo(&set, GL_RGBA, GL_RGBA, GL_UNSIGNED_BYTE );
125 InsertES3FormatCombo(&set, GL_RGBA, GL_RGBA, GL_UNSIGNED_SHORT_4_4_4_4 );
126 InsertES3FormatCombo(&set, GL_RGBA, GL_RGBA, GL_UNSIGNED_SHORT_5_5_5_1 );
127 InsertES3FormatCombo(&set, GL_RGB, GL_RGB, GL_UNSIGNED_BYTE );
128 InsertES3FormatCombo(&set, GL_RGB, GL_RGB, GL_UNSIGNED_SHORT_5_6_5 );
129 InsertES3FormatCombo(&set, GL_LUMINANCE_ALPHA, GL_LUMINANCE_ALPHA, GL_UNSIGNED_BYTE );
130 InsertES3FormatCombo(&set, GL_LUMINANCE, GL_LUMINANCE, GL_UNSIGNED_BYTE );
131 InsertES3FormatCombo(&set, GL_ALPHA, GL_ALPHA, GL_UNSIGNED_BYTE );
132 InsertES3FormatCombo(&set, GL_SRGB_ALPHA_EXT, GL_SRGB_ALPHA_EXT, GL_UNSIGNED_BYTE );
133 InsertES3FormatCombo(&set, GL_SRGB_EXT, GL_SRGB_EXT, GL_UNSIGNED_BYTE );
134
135 // Depth stencil formats
136 InsertES3FormatCombo(&set, GL_DEPTH_COMPONENT16, GL_DEPTH_COMPONENT, GL_UNSIGNED_SHORT );
137 InsertES3FormatCombo(&set, GL_DEPTH_COMPONENT24, GL_DEPTH_COMPONENT, GL_UNSIGNED_INT );
138 InsertES3FormatCombo(&set, GL_DEPTH_COMPONENT16, GL_DEPTH_COMPONENT, GL_UNSIGNED_INT );
139 InsertES3FormatCombo(&set, GL_DEPTH_COMPONENT32F, GL_DEPTH_COMPONENT, GL_FLOAT );
140 InsertES3FormatCombo(&set, GL_DEPTH24_STENCIL8, GL_DEPTH_STENCIL, GL_UNSIGNED_INT_24_8 );
141 InsertES3FormatCombo(&set, GL_DEPTH32F_STENCIL8, GL_DEPTH_STENCIL, GL_FLOAT_32_UNSIGNED_INT_24_8_REV);
142
143 // From GL_EXT_sRGB
144 InsertES3FormatCombo(&set, GL_SRGB8_ALPHA8_EXT, GL_SRGB_ALPHA_EXT, GL_UNSIGNED_BYTE );
145 InsertES3FormatCombo(&set, GL_SRGB8, GL_SRGB_EXT, GL_UNSIGNED_BYTE );
146
147 // From GL_OES_texture_float
148 InsertES3FormatCombo(&set, GL_LUMINANCE_ALPHA, GL_LUMINANCE_ALPHA, GL_FLOAT );
149 InsertES3FormatCombo(&set, GL_LUMINANCE, GL_LUMINANCE, GL_FLOAT );
150 InsertES3FormatCombo(&set, GL_ALPHA, GL_ALPHA, GL_FLOAT );
151
152 // From GL_OES_texture_half_float
153 InsertES3FormatCombo(&set, GL_LUMINANCE_ALPHA, GL_LUMINANCE_ALPHA, GL_HALF_FLOAT );
154 InsertES3FormatCombo(&set, GL_LUMINANCE_ALPHA, GL_LUMINANCE_ALPHA, GL_HALF_FLOAT_OES );
155 InsertES3FormatCombo(&set, GL_LUMINANCE, GL_LUMINANCE, GL_HALF_FLOAT );
156 InsertES3FormatCombo(&set, GL_LUMINANCE, GL_LUMINANCE, GL_HALF_FLOAT_OES );
157 InsertES3FormatCombo(&set, GL_ALPHA, GL_ALPHA, GL_HALF_FLOAT );
158 InsertES3FormatCombo(&set, GL_ALPHA, GL_ALPHA, GL_HALF_FLOAT_OES );
159
160 // From GL_EXT_texture_format_BGRA8888
161 InsertES3FormatCombo(&set, GL_BGRA_EXT, GL_BGRA_EXT, GL_UNSIGNED_BYTE );
162
163 // From GL_EXT_texture_storage
164 // | Internal format | Format | Type |
165 // | | | |
166 InsertES3FormatCombo(&set, GL_ALPHA8_EXT, GL_ALPHA, GL_UNSIGNED_BYTE );
167 InsertES3FormatCombo(&set, GL_LUMINANCE8_EXT, GL_LUMINANCE, GL_UNSIGNED_BYTE );
168 InsertES3FormatCombo(&set, GL_LUMINANCE8_ALPHA8_EXT, GL_LUMINANCE_ALPHA, GL_UNSIGNED_BYTE );
169 InsertES3FormatCombo(&set, GL_ALPHA32F_EXT, GL_ALPHA, GL_FLOAT );
170 InsertES3FormatCombo(&set, GL_LUMINANCE32F_EXT, GL_LUMINANCE, GL_FLOAT );
171 InsertES3FormatCombo(&set, GL_LUMINANCE_ALPHA32F_EXT, GL_LUMINANCE_ALPHA, GL_FLOAT );
172 InsertES3FormatCombo(&set, GL_ALPHA16F_EXT, GL_ALPHA, GL_HALF_FLOAT );
173 InsertES3FormatCombo(&set, GL_ALPHA16F_EXT, GL_ALPHA, GL_HALF_FLOAT_OES );
174 InsertES3FormatCombo(&set, GL_LUMINANCE16F_EXT, GL_LUMINANCE, GL_HALF_FLOAT );
175 InsertES3FormatCombo(&set, GL_LUMINANCE16F_EXT, GL_LUMINANCE, GL_HALF_FLOAT_OES );
176 InsertES3FormatCombo(&set, GL_LUMINANCE_ALPHA16F_EXT, GL_LUMINANCE_ALPHA, GL_HALF_FLOAT );
177 InsertES3FormatCombo(&set, GL_LUMINANCE_ALPHA16F_EXT, GL_LUMINANCE_ALPHA, GL_HALF_FLOAT_OES );
178
179 // From GL_EXT_texture_storage and GL_EXT_texture_format_BGRA8888
180 InsertES3FormatCombo(&set, GL_BGRA8_EXT, GL_BGRA_EXT, GL_UNSIGNED_BYTE );
181 InsertES3FormatCombo(&set, GL_BGRA4_ANGLEX, GL_BGRA_EXT, GL_UNSIGNED_SHORT_4_4_4_4_REV_EXT);
182 InsertES3FormatCombo(&set, GL_BGRA4_ANGLEX, GL_BGRA_EXT, GL_UNSIGNED_BYTE );
183 InsertES3FormatCombo(&set, GL_BGR5_A1_ANGLEX, GL_BGRA_EXT, GL_UNSIGNED_SHORT_1_5_5_5_REV_EXT);
184 InsertES3FormatCombo(&set, GL_BGR5_A1_ANGLEX, GL_BGRA_EXT, GL_UNSIGNED_BYTE );
185
186 // From GL_ANGLE_depth_texture
187 InsertES3FormatCombo(&set, GL_DEPTH_COMPONENT32_OES, GL_DEPTH_COMPONENT, GL_UNSIGNED_INT_24_8_OES );
188
189 // Compressed formats
190 // From ES 3.0.1 spec, table 3.16
191 // | Internal format | Format | Type |
192 // | | | |
193 InsertES3FormatCombo(&set, GL_COMPRESSED_R11_EAC, GL_COMPRESSED_R11_EAC, GL_UNSIGNED_BYTE);
194 InsertES3FormatCombo(&set, GL_COMPRESSED_R11_EAC, GL_COMPRESSED_R11_EAC, GL_UNSIGNED_BYTE);
195 InsertES3FormatCombo(&set, GL_COMPRESSED_SIGNED_R11_EAC, GL_COMPRESSED_SIGNED_R11_EAC, GL_UNSIGNED_BYTE);
196 InsertES3FormatCombo(&set, GL_COMPRESSED_RG11_EAC, GL_COMPRESSED_RG11_EAC, GL_UNSIGNED_BYTE);
197 InsertES3FormatCombo(&set, GL_COMPRESSED_SIGNED_RG11_EAC, GL_COMPRESSED_SIGNED_RG11_EAC, GL_UNSIGNED_BYTE);
198 InsertES3FormatCombo(&set, GL_COMPRESSED_RGB8_ETC2, GL_COMPRESSED_RGB8_ETC2, GL_UNSIGNED_BYTE);
199 InsertES3FormatCombo(&set, GL_COMPRESSED_SRGB8_ETC2, GL_COMPRESSED_SRGB8_ETC2, GL_UNSIGNED_BYTE);
200 InsertES3FormatCombo(&set, GL_COMPRESSED_RGB8_PUNCHTHROUGH_ALPHA1_ETC2, GL_COMPRESSED_RGB8_PUNCHTHROUGH_ALPHA1_ETC2, GL_UNSIGNED_BYTE);
201 InsertES3FormatCombo(&set, GL_COMPRESSED_SRGB8_PUNCHTHROUGH_ALPHA1_ETC2, GL_COMPRESSED_SRGB8_PUNCHTHROUGH_ALPHA1_ETC2, GL_UNSIGNED_BYTE);
202 InsertES3FormatCombo(&set, GL_COMPRESSED_RGBA8_ETC2_EAC, GL_COMPRESSED_RGBA8_ETC2_EAC, GL_UNSIGNED_BYTE);
203 InsertES3FormatCombo(&set, GL_COMPRESSED_SRGB8_ALPHA8_ETC2_EAC, GL_COMPRESSED_SRGB8_ALPHA8_ETC2_EAC, GL_UNSIGNED_BYTE);
204
205
206 // From GL_EXT_texture_compression_dxt1
207 InsertES3FormatCombo(&set, GL_COMPRESSED_RGB_S3TC_DXT1_EXT, GL_COMPRESSED_RGB_S3TC_DXT1_EXT, GL_UNSIGNED_BYTE);
208 InsertES3FormatCombo(&set, GL_COMPRESSED_RGBA_S3TC_DXT1_EXT, GL_COMPRESSED_RGBA_S3TC_DXT1_EXT, GL_UNSIGNED_BYTE);
209
210 // From GL_ANGLE_texture_compression_dxt3
211 InsertES3FormatCombo(&set, GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE, GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE, GL_UNSIGNED_BYTE);
212
213 // From GL_ANGLE_texture_compression_dxt5
214 InsertES3FormatCombo(&set, GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE, GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE, GL_UNSIGNED_BYTE);
215
216 return set;
217}
218
219static bool ValidateTexImageFormatCombination(gl::Context *context, GLenum internalFormat, GLenum format, GLenum type)
220{
221 // Note: dEQP 2013.4 expects an INVALID_VALUE error for TexImage3D with an invalid
222 // internal format. (dEQP-GLES3.functional.negative_api.texture.teximage3d)
Geoff Langbaadf232014-08-04 13:58:02 -0400223 const gl::InternalFormat &formatInfo = gl::GetInternalFormatInfo(internalFormat);
Geoff Lang5d601382014-07-22 15:14:06 -0400224 if (!formatInfo.textureSupport(context->getClientVersion(), context->getExtensions()))
225 {
Geoff Langb1196682014-07-23 13:47:29 -0400226 context->recordError(Error(GL_INVALID_ENUM));
227 return false;
Geoff Lang5d601382014-07-22 15:14:06 -0400228 }
229
230 // The type and format are valid if any supported internal format has that type and format
231 bool formatSupported = false;
232 bool typeSupported = false;
233
234 static const ES3FormatCombinationSet es3FormatSet = BuildES3FormatSet();
235 for (ES3FormatCombinationSet::const_iterator i = es3FormatSet.begin(); i != es3FormatSet.end(); i++)
236 {
237 if (i->format == format || i->type == type)
238 {
239 const gl::InternalFormat &info = gl::GetInternalFormatInfo(i->internalFormat);
240 bool supported = info.textureSupport(context->getClientVersion(), context->getExtensions());
Geoff Langbaadf232014-08-04 13:58:02 -0400241 if (supported && i->type == type)
Geoff Lang5d601382014-07-22 15:14:06 -0400242 {
243 typeSupported = true;
244 }
Geoff Langbaadf232014-08-04 13:58:02 -0400245 if (supported && i->format == format)
Geoff Lang5d601382014-07-22 15:14:06 -0400246 {
247 formatSupported = true;
248 }
Geoff Langbaadf232014-08-04 13:58:02 -0400249
250 // Early-out if both type and format are supported now
251 if (typeSupported && formatSupported)
252 {
253 break;
254 }
Geoff Lang5d601382014-07-22 15:14:06 -0400255 }
256 }
257
258 if (!typeSupported || !formatSupported)
259 {
Geoff Langb1196682014-07-23 13:47:29 -0400260 context->recordError(Error(GL_INVALID_ENUM));
261 return false;
Geoff Lang5d601382014-07-22 15:14:06 -0400262 }
263
264 // Check if this is a valid format combination to load texture data
265 ES3FormatCombination searchFormat;
266 searchFormat.internalFormat = internalFormat;
267 searchFormat.format = format;
268 searchFormat.type = type;
269
270 if (es3FormatSet.find(searchFormat) == es3FormatSet.end())
271 {
Geoff Langb1196682014-07-23 13:47:29 -0400272 context->recordError(Error(GL_INVALID_OPERATION));
273 return false;
Geoff Lang5d601382014-07-22 15:14:06 -0400274 }
275
276 return true;
277}
278
Geoff Langb1196682014-07-23 13:47:29 -0400279bool ValidateES3TexImageParameters(Context *context, GLenum target, GLint level, GLenum internalformat, bool isCompressed, bool isSubImage,
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400280 GLint xoffset, GLint yoffset, GLint zoffset, GLsizei width, GLsizei height, GLsizei depth,
Jamie Madillefb2a6f2013-09-24 10:22:42 -0400281 GLint border, GLenum format, GLenum type, const GLvoid *pixels)
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400282{
Jamie Madill6f38f822014-06-06 17:12:20 -0400283 if (!ValidTexture2DDestinationTarget(context, target))
284 {
Geoff Langb1196682014-07-23 13:47:29 -0400285 context->recordError(Error(GL_INVALID_ENUM));
286 return false;
Jamie Madill6f38f822014-06-06 17:12:20 -0400287 }
288
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400289 // Validate image size
Geoff Langce635692013-09-24 13:56:32 -0400290 if (!ValidImageSize(context, target, level, width, height, depth))
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400291 {
Geoff Langb1196682014-07-23 13:47:29 -0400292 context->recordError(Error(GL_INVALID_VALUE));
293 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400294 }
295
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400296 // Verify zero border
297 if (border != 0)
298 {
Geoff Langb1196682014-07-23 13:47:29 -0400299 context->recordError(Error(GL_INVALID_VALUE));
300 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400301 }
302
Jamie Madill6f38f822014-06-06 17:12:20 -0400303 if (xoffset < 0 || yoffset < 0 || zoffset < 0 ||
304 std::numeric_limits<GLsizei>::max() - xoffset < width ||
305 std::numeric_limits<GLsizei>::max() - yoffset < height ||
306 std::numeric_limits<GLsizei>::max() - zoffset < depth)
307 {
Geoff Langb1196682014-07-23 13:47:29 -0400308 context->recordError(Error(GL_INVALID_VALUE));
309 return false;
Jamie Madill6f38f822014-06-06 17:12:20 -0400310 }
311
Geoff Langaae65a42014-05-26 12:43:44 -0400312 const gl::Caps &caps = context->getCaps();
313
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400314 gl::Texture *texture = NULL;
315 bool textureCompressed = false;
316 GLenum textureInternalFormat = GL_NONE;
317 GLint textureLevelWidth = 0;
318 GLint textureLevelHeight = 0;
319 GLint textureLevelDepth = 0;
320 switch (target)
321 {
322 case GL_TEXTURE_2D:
323 {
Geoff Langaae65a42014-05-26 12:43:44 -0400324 if (static_cast<GLuint>(width) > (caps.max2DTextureSize >> level) ||
325 static_cast<GLuint>(height) > (caps.max2DTextureSize >> level))
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400326 {
Geoff Langb1196682014-07-23 13:47:29 -0400327 context->recordError(Error(GL_INVALID_VALUE));
328 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400329 }
330
331 gl::Texture2D *texture2d = context->getTexture2D();
332 if (texture2d)
333 {
334 textureCompressed = texture2d->isCompressed(level);
335 textureInternalFormat = texture2d->getInternalFormat(level);
336 textureLevelWidth = texture2d->getWidth(level);
337 textureLevelHeight = texture2d->getHeight(level);
338 textureLevelDepth = 1;
339 texture = texture2d;
340 }
341 }
342 break;
343
344 case GL_TEXTURE_CUBE_MAP_POSITIVE_X:
345 case GL_TEXTURE_CUBE_MAP_NEGATIVE_X:
346 case GL_TEXTURE_CUBE_MAP_POSITIVE_Y:
347 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y:
348 case GL_TEXTURE_CUBE_MAP_POSITIVE_Z:
349 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z:
350 {
351 if (!isSubImage && width != height)
352 {
Geoff Langb1196682014-07-23 13:47:29 -0400353 context->recordError(Error(GL_INVALID_VALUE));
354 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400355 }
356
Geoff Langaae65a42014-05-26 12:43:44 -0400357 if (static_cast<GLuint>(width) > (caps.maxCubeMapTextureSize >> level))
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400358 {
Geoff Langb1196682014-07-23 13:47:29 -0400359 context->recordError(Error(GL_INVALID_VALUE));
360 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400361 }
362
363 gl::TextureCubeMap *textureCube = context->getTextureCubeMap();
364 if (textureCube)
365 {
366 textureCompressed = textureCube->isCompressed(target, level);
367 textureInternalFormat = textureCube->getInternalFormat(target, level);
368 textureLevelWidth = textureCube->getWidth(target, level);
369 textureLevelHeight = textureCube->getHeight(target, level);
370 textureLevelDepth = 1;
371 texture = textureCube;
372 }
373 }
374 break;
375
376 case GL_TEXTURE_3D:
377 {
Geoff Langaae65a42014-05-26 12:43:44 -0400378 if (static_cast<GLuint>(width) > (caps.max3DTextureSize >> level) ||
379 static_cast<GLuint>(height) > (caps.max3DTextureSize >> level) ||
380 static_cast<GLuint>(depth) > (caps.max3DTextureSize >> level))
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400381 {
Geoff Langb1196682014-07-23 13:47:29 -0400382 context->recordError(Error(GL_INVALID_VALUE));
383 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400384 }
385
386 gl::Texture3D *texture3d = context->getTexture3D();
387 if (texture3d)
388 {
389 textureCompressed = texture3d->isCompressed(level);
390 textureInternalFormat = texture3d->getInternalFormat(level);
391 textureLevelWidth = texture3d->getWidth(level);
392 textureLevelHeight = texture3d->getHeight(level);
393 textureLevelDepth = texture3d->getDepth(level);
394 texture = texture3d;
395 }
396 }
397 break;
398
399 case GL_TEXTURE_2D_ARRAY:
400 {
Geoff Langaae65a42014-05-26 12:43:44 -0400401 if (static_cast<GLuint>(width) > (caps.max2DTextureSize >> level) ||
402 static_cast<GLuint>(height) > (caps.max2DTextureSize >> level) ||
403 static_cast<GLuint>(depth) > (caps.maxArrayTextureLayers >> level))
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400404 {
Geoff Langb1196682014-07-23 13:47:29 -0400405 context->recordError(Error(GL_INVALID_VALUE));
406 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400407 }
408
409 gl::Texture2DArray *texture2darray = context->getTexture2DArray();
410 if (texture2darray)
411 {
412 textureCompressed = texture2darray->isCompressed(level);
413 textureInternalFormat = texture2darray->getInternalFormat(level);
414 textureLevelWidth = texture2darray->getWidth(level);
415 textureLevelHeight = texture2darray->getHeight(level);
Jamie Madillb8f8b892014-01-07 10:12:50 -0500416 textureLevelDepth = texture2darray->getLayers(level);
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400417 texture = texture2darray;
418 }
419 }
420 break;
421
422 default:
Geoff Langb1196682014-07-23 13:47:29 -0400423 context->recordError(Error(GL_INVALID_ENUM));
424 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400425 }
426
427 if (!texture)
428 {
Geoff Langb1196682014-07-23 13:47:29 -0400429 context->recordError(Error(GL_INVALID_OPERATION));
430 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400431 }
432
433 if (texture->isImmutable() && !isSubImage)
434 {
Geoff Langb1196682014-07-23 13:47:29 -0400435 context->recordError(Error(GL_INVALID_OPERATION));
436 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400437 }
438
439 // Validate texture formats
440 GLenum actualInternalFormat = isSubImage ? textureInternalFormat : internalformat;
Geoff Lang5d601382014-07-22 15:14:06 -0400441 const gl::InternalFormat &actualFormatInfo = gl::GetInternalFormatInfo(actualInternalFormat);
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400442 if (isCompressed)
443 {
Geoff Langd4f180b2013-09-24 13:57:44 -0400444 if (!ValidCompressedImageSize(context, actualInternalFormat, width, height))
445 {
Geoff Langb1196682014-07-23 13:47:29 -0400446 context->recordError(Error(GL_INVALID_OPERATION));
447 return false;
Geoff Langd4f180b2013-09-24 13:57:44 -0400448 }
449
Geoff Lang5d601382014-07-22 15:14:06 -0400450 if (!actualFormatInfo.compressed)
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400451 {
Geoff Langb1196682014-07-23 13:47:29 -0400452 context->recordError(Error(GL_INVALID_ENUM));
453 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400454 }
455
456 if (target == GL_TEXTURE_3D)
457 {
Geoff Langb1196682014-07-23 13:47:29 -0400458 context->recordError(Error(GL_INVALID_OPERATION));
459 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400460 }
461 }
462 else
463 {
Geoff Langbaadf232014-08-04 13:58:02 -0400464 if (!ValidateTexImageFormatCombination(context, actualInternalFormat, format, type))
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400465 {
Geoff Lang5d601382014-07-22 15:14:06 -0400466 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400467 }
468
469 if (target == GL_TEXTURE_3D && (format == GL_DEPTH_COMPONENT || format == GL_DEPTH_STENCIL))
470 {
Geoff Langb1196682014-07-23 13:47:29 -0400471 context->recordError(Error(GL_INVALID_OPERATION));
472 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400473 }
474 }
475
476 // Validate sub image parameters
477 if (isSubImage)
478 {
479 if (isCompressed != textureCompressed)
480 {
Geoff Langb1196682014-07-23 13:47:29 -0400481 context->recordError(Error(GL_INVALID_OPERATION));
482 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400483 }
484
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400485 if (isCompressed)
486 {
487 if ((width % 4 != 0 && width != textureLevelWidth) ||
488 (height % 4 != 0 && height != textureLevelHeight))
489 {
Geoff Langb1196682014-07-23 13:47:29 -0400490 context->recordError(Error(GL_INVALID_OPERATION));
491 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400492 }
493 }
494
495 if (width == 0 || height == 0 || depth == 0)
496 {
497 return false;
498 }
499
500 if (xoffset < 0 || yoffset < 0 || zoffset < 0)
501 {
Geoff Langb1196682014-07-23 13:47:29 -0400502 context->recordError(Error(GL_INVALID_VALUE));
503 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400504 }
505
506 if (std::numeric_limits<GLsizei>::max() - xoffset < width ||
507 std::numeric_limits<GLsizei>::max() - yoffset < height ||
508 std::numeric_limits<GLsizei>::max() - zoffset < depth)
509 {
Geoff Langb1196682014-07-23 13:47:29 -0400510 context->recordError(Error(GL_INVALID_VALUE));
511 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400512 }
513
514 if (xoffset + width > textureLevelWidth ||
515 yoffset + height > textureLevelHeight ||
516 zoffset + depth > textureLevelDepth)
517 {
Geoff Langb1196682014-07-23 13:47:29 -0400518 context->recordError(Error(GL_INVALID_VALUE));
519 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400520 }
521 }
522
Jamie Madillefb2a6f2013-09-24 10:22:42 -0400523 // Check for pixel unpack buffer related API errors
Shannon Woods53a94a82014-06-24 15:20:36 -0400524 gl::Buffer *pixelUnpackBuffer = context->getState().getTargetBuffer(GL_PIXEL_UNPACK_BUFFER);
Jamie Madillefb2a6f2013-09-24 10:22:42 -0400525 if (pixelUnpackBuffer != NULL)
526 {
527 // ...the data would be unpacked from the buffer object such that the memory reads required
528 // would exceed the data store size.
529 size_t widthSize = static_cast<size_t>(width);
530 size_t heightSize = static_cast<size_t>(height);
531 size_t depthSize = static_cast<size_t>(depth);
Geoff Lang5d601382014-07-22 15:14:06 -0400532 GLenum sizedFormat = GetSizedInternalFormat(actualInternalFormat, type);
Jamie Madill6f38f822014-06-06 17:12:20 -0400533
Geoff Lang5d601382014-07-22 15:14:06 -0400534 size_t pixelBytes = static_cast<size_t>(gl::GetInternalFormatInfo(sizedFormat).pixelBytes);
Jamie Madillefb2a6f2013-09-24 10:22:42 -0400535
536 if (!rx::IsUnsignedMultiplicationSafe(widthSize, heightSize) ||
537 !rx::IsUnsignedMultiplicationSafe(widthSize * heightSize, depthSize) ||
538 !rx::IsUnsignedMultiplicationSafe(widthSize * heightSize * depthSize, pixelBytes))
539 {
540 // Overflow past the end of the buffer
Geoff Langb1196682014-07-23 13:47:29 -0400541 context->recordError(Error(GL_INVALID_OPERATION));
542 return false;
Jamie Madillefb2a6f2013-09-24 10:22:42 -0400543 }
544
Jamie Madillc751d1e2014-10-21 17:46:29 -0400545 const gl::InternalFormat &formatInfo = gl::GetInternalFormatInfo(sizedFormat);
546 size_t copyBytes = formatInfo.computeBlockSize(type, width, height);
Jamie Madillefb2a6f2013-09-24 10:22:42 -0400547 size_t offset = reinterpret_cast<size_t>(pixels);
548
Jamie Madill6f38f822014-06-06 17:12:20 -0400549 if (!rx::IsUnsignedAdditionSafe(offset, copyBytes) ||
Brandon Jonesd38f9262014-06-18 16:26:45 -0700550 ((offset + copyBytes) > static_cast<size_t>(pixelUnpackBuffer->getSize())))
Jamie Madillefb2a6f2013-09-24 10:22:42 -0400551 {
552 // Overflow past the end of the buffer
Geoff Langb1196682014-07-23 13:47:29 -0400553 context->recordError(Error(GL_INVALID_OPERATION));
554 return false;
Jamie Madillefb2a6f2013-09-24 10:22:42 -0400555 }
556
557 // ...data is not evenly divisible into the number of bytes needed to store in memory a datum
558 // indicated by type.
Jamie Madillc751d1e2014-10-21 17:46:29 -0400559 if (!isCompressed)
Jamie Madillefb2a6f2013-09-24 10:22:42 -0400560 {
Jamie Madillc751d1e2014-10-21 17:46:29 -0400561 size_t dataBytesPerPixel = static_cast<size_t>(gl::GetTypeInfo(type).bytes);
562
563 if ((offset % dataBytesPerPixel) != 0)
564 {
565 context->recordError(Error(GL_INVALID_OPERATION));
566 return false;
567 }
Jamie Madillefb2a6f2013-09-24 10:22:42 -0400568 }
569
Jamie Madill7a5f7382014-03-05 15:01:24 -0500570 // ...the buffer object's data store is currently mapped.
Brandon Jonesd38f9262014-06-18 16:26:45 -0700571 if (pixelUnpackBuffer->isMapped())
Jamie Madill7a5f7382014-03-05 15:01:24 -0500572 {
Geoff Langb1196682014-07-23 13:47:29 -0400573 context->recordError(Error(GL_INVALID_OPERATION));
574 return false;
Jamie Madill7a5f7382014-03-05 15:01:24 -0500575 }
Jamie Madillefb2a6f2013-09-24 10:22:42 -0400576 }
577
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400578 return true;
579}
580
Geoff Lang5d601382014-07-22 15:14:06 -0400581struct EffectiveInternalFormatInfo
582{
583 GLenum mEffectiveFormat;
584 GLenum mDestFormat;
585 GLuint mMinRedBits;
586 GLuint mMaxRedBits;
587 GLuint mMinGreenBits;
588 GLuint mMaxGreenBits;
589 GLuint mMinBlueBits;
590 GLuint mMaxBlueBits;
591 GLuint mMinAlphaBits;
592 GLuint mMaxAlphaBits;
593
594 EffectiveInternalFormatInfo(GLenum effectiveFormat, GLenum destFormat, GLuint minRedBits, GLuint maxRedBits,
595 GLuint minGreenBits, GLuint maxGreenBits, GLuint minBlueBits, GLuint maxBlueBits,
596 GLuint minAlphaBits, GLuint maxAlphaBits)
597 : mEffectiveFormat(effectiveFormat), mDestFormat(destFormat), mMinRedBits(minRedBits),
598 mMaxRedBits(maxRedBits), mMinGreenBits(minGreenBits), mMaxGreenBits(maxGreenBits),
599 mMinBlueBits(minBlueBits), mMaxBlueBits(maxBlueBits), mMinAlphaBits(minAlphaBits),
600 mMaxAlphaBits(maxAlphaBits) {};
601};
602
603typedef std::vector<EffectiveInternalFormatInfo> EffectiveInternalFormatList;
604
605static EffectiveInternalFormatList BuildSizedEffectiveInternalFormatList()
606{
607 EffectiveInternalFormatList list;
608
609 // OpenGL ES 3.0.3 Specification, Table 3.17, pg 141: Effective internal format coresponding to destination internal format and
610 // linear source buffer component sizes.
611 // | Source channel min/max sizes |
612 // Effective Internal Format | N/A | R | G | B | A |
613 list.push_back(EffectiveInternalFormatInfo(GL_ALPHA8_EXT, GL_NONE, 0, 0, 0, 0, 0, 0, 1, 8));
614 list.push_back(EffectiveInternalFormatInfo(GL_R8, GL_NONE, 1, 8, 0, 0, 0, 0, 0, 0));
615 list.push_back(EffectiveInternalFormatInfo(GL_RG8, GL_NONE, 1, 8, 1, 8, 0, 0, 0, 0));
616 list.push_back(EffectiveInternalFormatInfo(GL_RGB565, GL_NONE, 1, 5, 1, 6, 1, 5, 0, 0));
617 list.push_back(EffectiveInternalFormatInfo(GL_RGB8, GL_NONE, 6, 8, 7, 8, 6, 8, 0, 0));
618 list.push_back(EffectiveInternalFormatInfo(GL_RGBA4, GL_NONE, 1, 4, 1, 4, 1, 4, 1, 4));
619 list.push_back(EffectiveInternalFormatInfo(GL_RGB5_A1, GL_NONE, 5, 5, 5, 5, 5, 5, 1, 1));
620 list.push_back(EffectiveInternalFormatInfo(GL_RGBA8, GL_NONE, 5, 8, 5, 8, 5, 8, 2, 8));
621 list.push_back(EffectiveInternalFormatInfo(GL_RGB10_A2, GL_NONE, 9, 10, 9, 10, 9, 10, 2, 2));
622
623 return list;
624}
625
626static EffectiveInternalFormatList BuildUnsizedEffectiveInternalFormatList()
627{
628 EffectiveInternalFormatList list;
629
630 // OpenGL ES 3.0.3 Specification, Table 3.17, pg 141: Effective internal format coresponding to destination internal format and
631 // linear source buffer component sizes.
632 // | Source channel min/max sizes |
633 // Effective Internal Format | Dest Format | R | G | B | A |
634 list.push_back(EffectiveInternalFormatInfo(GL_ALPHA8_EXT, GL_ALPHA, 0, UINT_MAX, 0, UINT_MAX, 0, UINT_MAX, 1, 8));
635 list.push_back(EffectiveInternalFormatInfo(GL_LUMINANCE8_EXT, GL_LUMINANCE, 1, 8, 0, UINT_MAX, 0, UINT_MAX, 0, UINT_MAX));
636 list.push_back(EffectiveInternalFormatInfo(GL_LUMINANCE8_ALPHA8_EXT, GL_LUMINANCE_ALPHA, 1, 8, 0, UINT_MAX, 0, UINT_MAX, 1, 8));
637 list.push_back(EffectiveInternalFormatInfo(GL_RGB565, GL_RGB, 1, 5, 1, 6, 1, 5, 0, UINT_MAX));
638 list.push_back(EffectiveInternalFormatInfo(GL_RGB8, GL_RGB, 6, 8, 7, 8, 6, 8, 0, UINT_MAX));
639 list.push_back(EffectiveInternalFormatInfo(GL_RGBA4, GL_RGBA, 1, 4, 1, 4, 1, 4, 1, 4));
640 list.push_back(EffectiveInternalFormatInfo(GL_RGB5_A1, GL_RGBA, 5, 5, 5, 5, 5, 5, 1, 1));
641 list.push_back(EffectiveInternalFormatInfo(GL_RGBA8, GL_RGBA, 5, 8, 5, 8, 5, 8, 5, 8));
642
643 return list;
644}
645
646static bool GetEffectiveInternalFormat(const InternalFormat &srcFormat, const InternalFormat &destFormat,
647 GLenum *outEffectiveFormat)
648{
649 const EffectiveInternalFormatList *list = NULL;
650 GLenum targetFormat = GL_NONE;
651
652 if (destFormat.pixelBytes > 0)
653 {
654 static const EffectiveInternalFormatList sizedList = BuildSizedEffectiveInternalFormatList();
655 list = &sizedList;
656 }
657 else
658 {
659 static const EffectiveInternalFormatList unsizedList = BuildUnsizedEffectiveInternalFormatList();
660 list = &unsizedList;
661 targetFormat = destFormat.format;
662 }
663
664 for (size_t curFormat = 0; curFormat < list->size(); ++curFormat)
665 {
666 const EffectiveInternalFormatInfo& formatInfo = list->at(curFormat);
667 if ((formatInfo.mDestFormat == targetFormat) &&
668 (formatInfo.mMinRedBits <= srcFormat.redBits && formatInfo.mMaxRedBits >= srcFormat.redBits) &&
669 (formatInfo.mMinGreenBits <= srcFormat.greenBits && formatInfo.mMaxGreenBits >= srcFormat.greenBits) &&
670 (formatInfo.mMinBlueBits <= srcFormat.blueBits && formatInfo.mMaxBlueBits >= srcFormat.blueBits) &&
671 (formatInfo.mMinAlphaBits <= srcFormat.alphaBits && formatInfo.mMaxAlphaBits >= srcFormat.alphaBits))
672 {
673 *outEffectiveFormat = formatInfo.mEffectiveFormat;
674 return true;
675 }
676 }
677
678 return false;
679}
680
681struct CopyConversion
682{
683 GLenum mTextureFormat;
684 GLenum mFramebufferFormat;
685
686 CopyConversion(GLenum textureFormat, GLenum framebufferFormat)
687 : mTextureFormat(textureFormat), mFramebufferFormat(framebufferFormat) { }
688
689 bool operator<(const CopyConversion& other) const
690 {
691 return memcmp(this, &other, sizeof(CopyConversion)) < 0;
692 }
693};
694
695typedef std::set<CopyConversion> CopyConversionSet;
696
697static CopyConversionSet BuildValidES3CopyTexImageCombinations()
698{
699 CopyConversionSet set;
700
701 // From ES 3.0.1 spec, table 3.15
702 set.insert(CopyConversion(GL_ALPHA, GL_RGBA));
703 set.insert(CopyConversion(GL_LUMINANCE, GL_RED));
704 set.insert(CopyConversion(GL_LUMINANCE, GL_RG));
705 set.insert(CopyConversion(GL_LUMINANCE, GL_RGB));
706 set.insert(CopyConversion(GL_LUMINANCE, GL_RGBA));
707 set.insert(CopyConversion(GL_LUMINANCE_ALPHA, GL_RGBA));
708 set.insert(CopyConversion(GL_RED, GL_RED));
709 set.insert(CopyConversion(GL_RED, GL_RG));
710 set.insert(CopyConversion(GL_RED, GL_RGB));
711 set.insert(CopyConversion(GL_RED, GL_RGBA));
712 set.insert(CopyConversion(GL_RG, GL_RG));
713 set.insert(CopyConversion(GL_RG, GL_RGB));
714 set.insert(CopyConversion(GL_RG, GL_RGBA));
715 set.insert(CopyConversion(GL_RGB, GL_RGB));
716 set.insert(CopyConversion(GL_RGB, GL_RGBA));
717 set.insert(CopyConversion(GL_RGBA, GL_RGBA));
718
719 // Necessary for ANGLE back-buffers
720 set.insert(CopyConversion(GL_ALPHA, GL_BGRA_EXT));
721 set.insert(CopyConversion(GL_LUMINANCE, GL_BGRA_EXT));
722 set.insert(CopyConversion(GL_LUMINANCE_ALPHA, GL_BGRA_EXT));
723 set.insert(CopyConversion(GL_RED, GL_BGRA_EXT));
724 set.insert(CopyConversion(GL_RG, GL_BGRA_EXT));
725 set.insert(CopyConversion(GL_RGB, GL_BGRA_EXT));
726 set.insert(CopyConversion(GL_RGBA, GL_BGRA_EXT));
727
728 set.insert(CopyConversion(GL_RED_INTEGER, GL_RED_INTEGER));
729 set.insert(CopyConversion(GL_RED_INTEGER, GL_RG_INTEGER));
730 set.insert(CopyConversion(GL_RED_INTEGER, GL_RGB_INTEGER));
731 set.insert(CopyConversion(GL_RED_INTEGER, GL_RGBA_INTEGER));
732 set.insert(CopyConversion(GL_RG_INTEGER, GL_RG_INTEGER));
733 set.insert(CopyConversion(GL_RG_INTEGER, GL_RGB_INTEGER));
734 set.insert(CopyConversion(GL_RG_INTEGER, GL_RGBA_INTEGER));
735 set.insert(CopyConversion(GL_RGB_INTEGER, GL_RGB_INTEGER));
736 set.insert(CopyConversion(GL_RGB_INTEGER, GL_RGBA_INTEGER));
737 set.insert(CopyConversion(GL_RGBA_INTEGER, GL_RGBA_INTEGER));
738
739 return set;
740}
741
742static bool IsValidES3CopyTexImageCombination(GLenum textureInternalFormat, GLenum frameBufferInternalFormat, GLuint readBufferHandle)
743{
744 const InternalFormat &textureInternalFormatInfo = GetInternalFormatInfo(textureInternalFormat);
745 const InternalFormat &framebufferInternalFormatInfo = GetInternalFormatInfo(frameBufferInternalFormat);
746
747 static const CopyConversionSet conversionSet = BuildValidES3CopyTexImageCombinations();
748 if (conversionSet.find(CopyConversion(textureInternalFormatInfo.format, framebufferInternalFormatInfo.format)) != conversionSet.end())
749 {
750 // Section 3.8.5 of the GLES 3.0.3 spec states that source and destination formats
751 // must both be signed, unsigned, or fixed point and both source and destinations
752 // must be either both SRGB or both not SRGB. EXT_color_buffer_float adds allowed
753 // conversion between fixed and floating point.
754
755 if ((textureInternalFormatInfo.colorEncoding == GL_SRGB) != (framebufferInternalFormatInfo.colorEncoding == GL_SRGB))
756 {
757 return false;
758 }
759
760 if (((textureInternalFormatInfo.componentType == GL_INT) != (framebufferInternalFormatInfo.componentType == GL_INT )) ||
761 ((textureInternalFormatInfo.componentType == GL_UNSIGNED_INT) != (framebufferInternalFormatInfo.componentType == GL_UNSIGNED_INT)))
762 {
763 return false;
764 }
765
766 if ((textureInternalFormatInfo.componentType == GL_UNSIGNED_NORMALIZED ||
767 textureInternalFormatInfo.componentType == GL_SIGNED_NORMALIZED ||
768 textureInternalFormatInfo.componentType == GL_FLOAT) &&
769 !(framebufferInternalFormatInfo.componentType == GL_UNSIGNED_NORMALIZED ||
770 framebufferInternalFormatInfo.componentType == GL_SIGNED_NORMALIZED ||
771 framebufferInternalFormatInfo.componentType == GL_FLOAT))
772 {
773 return false;
774 }
775
776 // GLES specification 3.0.3, sec 3.8.5, pg 139-140:
777 // The effective internal format of the source buffer is determined with the following rules applied in order:
778 // * If the source buffer is a texture or renderbuffer that was created with a sized internal format then the
779 // effective internal format is the source buffer's sized internal format.
780 // * If the source buffer is a texture that was created with an unsized base internal format, then the
781 // effective internal format is the source image array's effective internal format, as specified by table
782 // 3.12, which is determined from the <format> and <type> that were used when the source image array was
783 // specified by TexImage*.
784 // * Otherwise the effective internal format is determined by the row in table 3.17 or 3.18 where
785 // Destination Internal Format matches internalformat and where the [source channel sizes] are consistent
786 // with the values of the source buffer's [channel sizes]. Table 3.17 is used if the
787 // FRAMEBUFFER_ATTACHMENT_ENCODING is LINEAR and table 3.18 is used if the FRAMEBUFFER_ATTACHMENT_ENCODING
788 // is SRGB.
789 const InternalFormat *sourceEffectiveFormat = NULL;
790 if (readBufferHandle != 0)
791 {
792 // Not the default framebuffer, therefore the read buffer must be a user-created texture or renderbuffer
793 if (framebufferInternalFormatInfo.pixelBytes > 0)
794 {
795 sourceEffectiveFormat = &framebufferInternalFormatInfo;
796 }
797 else
798 {
799 // Renderbuffers cannot be created with an unsized internal format, so this must be an unsized-format
800 // texture. We can use the same table we use when creating textures to get its effective sized format.
801 const FormatType &typeInfo = GetFormatTypeInfo(framebufferInternalFormatInfo.format, framebufferInternalFormatInfo.type);
802 sourceEffectiveFormat = &GetInternalFormatInfo(typeInfo.internalFormat);
803 }
804 }
805 else
806 {
807 // The effective internal format must be derived from the source framebuffer's channel sizes.
808 // This is done in GetEffectiveInternalFormat for linear buffers (table 3.17)
809 if (framebufferInternalFormatInfo.colorEncoding == GL_LINEAR)
810 {
811 GLenum effectiveFormat;
812 if (GetEffectiveInternalFormat(framebufferInternalFormatInfo, textureInternalFormatInfo, &effectiveFormat))
813 {
814 sourceEffectiveFormat = &GetInternalFormatInfo(effectiveFormat);
815 }
816 else
817 {
818 return false;
819 }
820 }
821 else if (framebufferInternalFormatInfo.colorEncoding == GL_SRGB)
822 {
823 // SRGB buffers can only be copied to sized format destinations according to table 3.18
824 if ((textureInternalFormatInfo.pixelBytes > 0) &&
825 (framebufferInternalFormatInfo.redBits >= 1 && framebufferInternalFormatInfo.redBits <= 8) &&
826 (framebufferInternalFormatInfo.greenBits >= 1 && framebufferInternalFormatInfo.greenBits <= 8) &&
827 (framebufferInternalFormatInfo.blueBits >= 1 && framebufferInternalFormatInfo.blueBits <= 8) &&
828 (framebufferInternalFormatInfo.alphaBits >= 1 && framebufferInternalFormatInfo.alphaBits <= 8))
829 {
830 sourceEffectiveFormat = &GetInternalFormatInfo(GL_SRGB8_ALPHA8);
831 }
832 else
833 {
834 return false;
835 }
836 }
837 else
838 {
839 UNREACHABLE();
840 return false;
841 }
842 }
843
844 if (textureInternalFormatInfo.pixelBytes > 0)
845 {
846 // Section 3.8.5 of the GLES 3.0.3 spec, pg 139, requires that, if the destination format is sized,
847 // component sizes of the source and destination formats must exactly match
848 if (textureInternalFormatInfo.redBits != sourceEffectiveFormat->redBits ||
849 textureInternalFormatInfo.greenBits != sourceEffectiveFormat->greenBits ||
850 textureInternalFormatInfo.blueBits != sourceEffectiveFormat->blueBits ||
851 textureInternalFormatInfo.alphaBits != sourceEffectiveFormat->alphaBits)
852 {
853 return false;
854 }
855 }
856
857
858 return true; // A conversion function exists, and no rule in the specification has precluded conversion
859 // between these formats.
860 }
861
862 return false;
863}
864
Geoff Langb1196682014-07-23 13:47:29 -0400865bool ValidateES3CopyTexImageParameters(Context *context, GLenum target, GLint level, GLenum internalformat,
Jamie Madill6f38f822014-06-06 17:12:20 -0400866 bool isSubImage, GLint xoffset, GLint yoffset, GLint zoffset,
867 GLint x, GLint y, GLsizei width, GLsizei height, GLint border)
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400868{
Jamie Madill560a8d82014-05-21 13:06:20 -0400869 GLenum textureInternalFormat;
870 if (!ValidateCopyTexImageParametersBase(context, target, level, internalformat, isSubImage,
Jamie Madill6f38f822014-06-06 17:12:20 -0400871 xoffset, yoffset, zoffset, x, y, width, height,
872 border, &textureInternalFormat))
Shannon Woods4dfed832014-03-17 20:03:39 -0400873 {
Jamie Madill560a8d82014-05-21 13:06:20 -0400874 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400875 }
876
Shannon Woods53a94a82014-06-24 15:20:36 -0400877 gl::Framebuffer *framebuffer = context->getState().getReadFramebuffer();
Jamie Madill3c7fa222014-06-05 13:08:51 -0400878
Jamie Madill48faf802014-11-06 15:27:22 -0500879 if (framebuffer->completeness(context->getData()) != GL_FRAMEBUFFER_COMPLETE)
Jamie Madill3c7fa222014-06-05 13:08:51 -0400880 {
Geoff Langb1196682014-07-23 13:47:29 -0400881 context->recordError(Error(GL_INVALID_FRAMEBUFFER_OPERATION));
882 return false;
Jamie Madill3c7fa222014-06-05 13:08:51 -0400883 }
884
Jamie Madill48faf802014-11-06 15:27:22 -0500885 if (context->getState().getReadFramebuffer()->id() != 0 &&
886 framebuffer->getSamples(context->getData()) != 0)
Jamie Madill3c7fa222014-06-05 13:08:51 -0400887 {
Geoff Langb1196682014-07-23 13:47:29 -0400888 context->recordError(Error(GL_INVALID_OPERATION));
889 return false;
Jamie Madill3c7fa222014-06-05 13:08:51 -0400890 }
891
892 gl::FramebufferAttachment *source = framebuffer->getReadColorbuffer();
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400893 GLenum colorbufferInternalFormat = source->getInternalFormat();
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400894
895 if (isSubImage)
896 {
Geoff Lang5d601382014-07-22 15:14:06 -0400897 if (!IsValidES3CopyTexImageCombination(textureInternalFormat, colorbufferInternalFormat,
898 context->getState().getReadFramebuffer()->id()))
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400899 {
Geoff Langb1196682014-07-23 13:47:29 -0400900 context->recordError(Error(GL_INVALID_OPERATION));
901 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400902 }
903 }
Shannon Woods4d161ba2014-03-17 18:13:30 -0400904 else
905 {
Geoff Lang5d601382014-07-22 15:14:06 -0400906 if (!gl::IsValidES3CopyTexImageCombination(internalformat, colorbufferInternalFormat,
907 context->getState().getReadFramebuffer()->id()))
Shannon Woods4d161ba2014-03-17 18:13:30 -0400908 {
Geoff Langb1196682014-07-23 13:47:29 -0400909 context->recordError(Error(GL_INVALID_OPERATION));
910 return false;
Shannon Woods4d161ba2014-03-17 18:13:30 -0400911 }
912 }
913
Geoff Lang784a8fd2013-09-24 12:33:16 -0400914 // If width or height is zero, it is a no-op. Return false without setting an error.
915 return (width > 0 && height > 0);
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400916}
917
Geoff Langb1196682014-07-23 13:47:29 -0400918bool ValidateES3TexStorageParameters(Context *context, GLenum target, GLsizei levels, GLenum internalformat,
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400919 GLsizei width, GLsizei height, GLsizei depth)
920{
921 if (width < 1 || height < 1 || depth < 1 || levels < 1)
922 {
Geoff Langb1196682014-07-23 13:47:29 -0400923 context->recordError(Error(GL_INVALID_VALUE));
924 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400925 }
926
927 if (levels > gl::log2(std::max(std::max(width, height), depth)) + 1)
928 {
Geoff Langb1196682014-07-23 13:47:29 -0400929 context->recordError(Error(GL_INVALID_OPERATION));
930 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400931 }
932
Geoff Langaae65a42014-05-26 12:43:44 -0400933 const gl::Caps &caps = context->getCaps();
934
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400935 gl::Texture *texture = NULL;
936 switch (target)
937 {
938 case GL_TEXTURE_2D:
939 {
940 texture = context->getTexture2D();
941
Geoff Langaae65a42014-05-26 12:43:44 -0400942 if (static_cast<GLuint>(width) > caps.max2DTextureSize ||
943 static_cast<GLuint>(height) > caps.max2DTextureSize)
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400944 {
Geoff Langb1196682014-07-23 13:47:29 -0400945 context->recordError(Error(GL_INVALID_VALUE));
946 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400947 }
948 }
949 break;
950
Geoff Lang01c21d22013-09-24 11:52:16 -0400951 case GL_TEXTURE_CUBE_MAP:
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400952 {
953 texture = context->getTextureCubeMap();
954
955 if (width != height)
956 {
Geoff Langb1196682014-07-23 13:47:29 -0400957 context->recordError(Error(GL_INVALID_VALUE));
958 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400959 }
960
Geoff Langaae65a42014-05-26 12:43:44 -0400961 if (static_cast<GLuint>(width) > caps.maxCubeMapTextureSize)
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400962 {
Geoff Langb1196682014-07-23 13:47:29 -0400963 context->recordError(Error(GL_INVALID_VALUE));
964 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400965 }
966 }
967 break;
968
969 case GL_TEXTURE_3D:
970 {
971 texture = context->getTexture3D();
972
Geoff Langaae65a42014-05-26 12:43:44 -0400973 if (static_cast<GLuint>(width) > caps.max3DTextureSize ||
974 static_cast<GLuint>(height) > caps.max3DTextureSize ||
975 static_cast<GLuint>(depth) > caps.max3DTextureSize)
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400976 {
Geoff Langb1196682014-07-23 13:47:29 -0400977 context->recordError(Error(GL_INVALID_VALUE));
978 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400979 }
980 }
981 break;
982
983 case GL_TEXTURE_2D_ARRAY:
984 {
985 texture = context->getTexture2DArray();
986
Geoff Langaae65a42014-05-26 12:43:44 -0400987 if (static_cast<GLuint>(width) > caps.max2DTextureSize ||
988 static_cast<GLuint>(height) > caps.max2DTextureSize ||
989 static_cast<GLuint>(depth) > caps.maxArrayTextureLayers)
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400990 {
Geoff Langb1196682014-07-23 13:47:29 -0400991 context->recordError(Error(GL_INVALID_VALUE));
992 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -0400993 }
994 }
995 break;
996
997 default:
Geoff Langb1196682014-07-23 13:47:29 -0400998 context->recordError(Error(GL_INVALID_ENUM));
999 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001000 }
1001
1002 if (!texture || texture->id() == 0)
1003 {
Geoff Langb1196682014-07-23 13:47:29 -04001004 context->recordError(Error(GL_INVALID_OPERATION));
1005 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001006 }
1007
1008 if (texture->isImmutable())
1009 {
Geoff Langb1196682014-07-23 13:47:29 -04001010 context->recordError(Error(GL_INVALID_OPERATION));
1011 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001012 }
1013
Geoff Lang5d601382014-07-22 15:14:06 -04001014 const gl::InternalFormat &formatInfo = gl::GetInternalFormatInfo(internalformat);
1015 if (!formatInfo.textureSupport(context->getClientVersion(), context->getExtensions()))
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001016 {
Geoff Langb1196682014-07-23 13:47:29 -04001017 context->recordError(Error(GL_INVALID_ENUM));
1018 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001019 }
1020
Geoff Lang5d601382014-07-22 15:14:06 -04001021 if (formatInfo.pixelBytes == 0)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001022 {
Geoff Langb1196682014-07-23 13:47:29 -04001023 context->recordError(Error(GL_INVALID_ENUM));
1024 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001025 }
1026
1027 return true;
1028}
1029
Geoff Langb1196682014-07-23 13:47:29 -04001030bool ValidateFramebufferTextureLayer(Context *context, GLenum target, GLenum attachment,
Jamie Madill570f7c82014-07-03 10:38:54 -04001031 GLuint texture, GLint level, GLint layer)
1032{
1033 if (context->getClientVersion() < 3)
1034 {
Geoff Langb1196682014-07-23 13:47:29 -04001035 context->recordError(Error(GL_INVALID_OPERATION));
1036 return false;
Jamie Madill570f7c82014-07-03 10:38:54 -04001037 }
1038
Jamie Madill55ec3b12014-07-03 10:38:57 -04001039 if (layer < 0)
1040 {
Geoff Langb1196682014-07-23 13:47:29 -04001041 context->recordError(Error(GL_INVALID_VALUE));
1042 return false;
Jamie Madill55ec3b12014-07-03 10:38:57 -04001043 }
1044
1045 if (!ValidateFramebufferTextureBase(context, target, attachment, texture, level))
1046 {
1047 return false;
1048 }
1049
1050 const gl::Caps &caps = context->getCaps();
1051 if (texture != 0)
1052 {
1053 gl::Texture *tex = context->getTexture(texture);
1054 ASSERT(tex);
1055
1056 switch (tex->getTarget())
1057 {
1058 case GL_TEXTURE_2D_ARRAY:
1059 {
1060 if (level > gl::log2(caps.max2DTextureSize))
1061 {
Geoff Langb1196682014-07-23 13:47:29 -04001062 context->recordError(Error(GL_INVALID_VALUE));
1063 return false;
Jamie Madill55ec3b12014-07-03 10:38:57 -04001064 }
1065
1066 if (static_cast<GLuint>(layer) >= caps.maxArrayTextureLayers)
1067 {
Geoff Langb1196682014-07-23 13:47:29 -04001068 context->recordError(Error(GL_INVALID_VALUE));
1069 return false;
Jamie Madill55ec3b12014-07-03 10:38:57 -04001070 }
1071
1072 gl::Texture2DArray *texArray = static_cast<gl::Texture2DArray *>(tex);
1073 if (texArray->isCompressed(level))
1074 {
Geoff Langb1196682014-07-23 13:47:29 -04001075 context->recordError(Error(GL_INVALID_OPERATION));
1076 return false;
Jamie Madill55ec3b12014-07-03 10:38:57 -04001077 }
1078 }
1079 break;
1080
1081 case GL_TEXTURE_3D:
1082 {
1083 if (level > gl::log2(caps.max3DTextureSize))
1084 {
Geoff Langb1196682014-07-23 13:47:29 -04001085 context->recordError(Error(GL_INVALID_VALUE));
1086 return false;
Jamie Madill55ec3b12014-07-03 10:38:57 -04001087 }
1088
1089 if (static_cast<GLuint>(layer) >= caps.max3DTextureSize)
1090 {
Geoff Langb1196682014-07-23 13:47:29 -04001091 context->recordError(Error(GL_INVALID_VALUE));
1092 return false;
Jamie Madill55ec3b12014-07-03 10:38:57 -04001093 }
1094
1095 gl::Texture3D *tex3d = static_cast<gl::Texture3D *>(tex);
1096 if (tex3d->isCompressed(level))
1097 {
Geoff Langb1196682014-07-23 13:47:29 -04001098 context->recordError(Error(GL_INVALID_OPERATION));
1099 return false;
Jamie Madill55ec3b12014-07-03 10:38:57 -04001100 }
1101 }
1102 break;
1103
1104 default:
Geoff Langb1196682014-07-23 13:47:29 -04001105 context->recordError(Error(GL_INVALID_OPERATION));
1106 return false;
Jamie Madill55ec3b12014-07-03 10:38:57 -04001107 }
1108 }
1109
1110 return true;
Jamie Madill570f7c82014-07-03 10:38:54 -04001111}
1112
Geoff Langb1196682014-07-23 13:47:29 -04001113bool ValidES3ReadFormatType(Context *context, GLenum internalFormat, GLenum format, GLenum type)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001114{
Geoff Lang5d601382014-07-22 15:14:06 -04001115 const gl::InternalFormat &internalFormatInfo = gl::GetInternalFormatInfo(internalFormat);
1116
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001117 switch (format)
1118 {
1119 case GL_RGBA:
1120 switch (type)
1121 {
1122 case GL_UNSIGNED_BYTE:
1123 break;
1124 case GL_UNSIGNED_INT_2_10_10_10_REV:
1125 if (internalFormat != GL_RGB10_A2)
1126 {
1127 return false;
1128 }
1129 break;
Geoff Lang1ec57f82013-10-16 11:43:23 -04001130 case GL_FLOAT:
Geoff Lang5d601382014-07-22 15:14:06 -04001131 if (internalFormatInfo.componentType != GL_FLOAT)
Geoff Lang1ec57f82013-10-16 11:43:23 -04001132 {
1133 return false;
1134 }
1135 break;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001136 default:
1137 return false;
1138 }
1139 break;
1140 case GL_RGBA_INTEGER:
1141 switch (type)
1142 {
1143 case GL_INT:
Geoff Lang5d601382014-07-22 15:14:06 -04001144 if (internalFormatInfo.componentType != GL_INT)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001145 {
1146 return false;
1147 }
1148 break;
1149 case GL_UNSIGNED_INT:
Geoff Lang5d601382014-07-22 15:14:06 -04001150 if (internalFormatInfo.componentType != GL_UNSIGNED_INT)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001151 {
1152 return false;
1153 }
1154 break;
1155 default:
1156 return false;
1157 }
1158 break;
1159 case GL_BGRA_EXT:
1160 switch (type)
1161 {
1162 case GL_UNSIGNED_BYTE:
1163 case GL_UNSIGNED_SHORT_4_4_4_4_REV_EXT:
1164 case GL_UNSIGNED_SHORT_1_5_5_5_REV_EXT:
1165 break;
1166 default:
1167 return false;
1168 }
1169 break;
Geoff Langbdc9b2f2014-04-16 14:41:54 -04001170 case GL_RG_EXT:
1171 case GL_RED_EXT:
Geoff Langc0b9ef42014-07-02 10:02:37 -04001172 if (!context->getExtensions().textureRG)
Geoff Langbdc9b2f2014-04-16 14:41:54 -04001173 {
1174 return false;
1175 }
1176 switch (type)
1177 {
1178 case GL_UNSIGNED_BYTE:
1179 break;
1180 default:
1181 return false;
1182 }
1183 break;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001184 default:
1185 return false;
1186 }
1187 return true;
1188}
1189
Geoff Langb1196682014-07-23 13:47:29 -04001190bool ValidateInvalidateFramebufferParameters(Context *context, GLenum target, GLsizei numAttachments,
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001191 const GLenum* attachments)
1192{
1193 bool defaultFramebuffer = false;
1194
1195 switch (target)
1196 {
1197 case GL_DRAW_FRAMEBUFFER:
1198 case GL_FRAMEBUFFER:
Shannon Woods53a94a82014-06-24 15:20:36 -04001199 defaultFramebuffer = context->getState().getDrawFramebuffer()->id() == 0;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001200 break;
1201 case GL_READ_FRAMEBUFFER:
Shannon Woods53a94a82014-06-24 15:20:36 -04001202 defaultFramebuffer = context->getState().getReadFramebuffer()->id() == 0;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001203 break;
1204 default:
Geoff Langb1196682014-07-23 13:47:29 -04001205 context->recordError(Error(GL_INVALID_ENUM));
1206 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001207 }
1208
1209 for (int i = 0; i < numAttachments; ++i)
1210 {
1211 if (attachments[i] >= GL_COLOR_ATTACHMENT0 && attachments[i] <= GL_COLOR_ATTACHMENT15)
1212 {
1213 if (defaultFramebuffer)
1214 {
Geoff Langb1196682014-07-23 13:47:29 -04001215 context->recordError(Error(GL_INVALID_ENUM));
1216 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001217 }
1218
Geoff Langaae65a42014-05-26 12:43:44 -04001219 if (attachments[i] >= GL_COLOR_ATTACHMENT0 + context->getCaps().maxColorAttachments)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001220 {
Geoff Langb1196682014-07-23 13:47:29 -04001221 context->recordError(Error(GL_INVALID_OPERATION));
1222 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001223 }
1224 }
1225 else
1226 {
1227 switch (attachments[i])
1228 {
1229 case GL_DEPTH_ATTACHMENT:
1230 case GL_STENCIL_ATTACHMENT:
1231 case GL_DEPTH_STENCIL_ATTACHMENT:
1232 if (defaultFramebuffer)
1233 {
Geoff Langb1196682014-07-23 13:47:29 -04001234 context->recordError(Error(GL_INVALID_ENUM));
1235 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001236 }
1237 break;
1238 case GL_COLOR:
1239 case GL_DEPTH:
1240 case GL_STENCIL:
1241 if (!defaultFramebuffer)
1242 {
Geoff Langb1196682014-07-23 13:47:29 -04001243 context->recordError(Error(GL_INVALID_ENUM));
1244 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001245 }
1246 break;
1247 default:
Geoff Langb1196682014-07-23 13:47:29 -04001248 context->recordError(Error(GL_INVALID_ENUM));
1249 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001250 }
1251 }
1252 }
1253
1254 return true;
1255}
1256
Geoff Langb1196682014-07-23 13:47:29 -04001257bool ValidateClearBuffer(Context *context)
Jamie Madill13f7d7d2014-06-20 13:21:27 -04001258{
1259 if (context->getClientVersion() < 3)
1260 {
Geoff Langb1196682014-07-23 13:47:29 -04001261 context->recordError(Error(GL_INVALID_OPERATION));
1262 return false;
Jamie Madill13f7d7d2014-06-20 13:21:27 -04001263 }
1264
Shannon Woods53a94a82014-06-24 15:20:36 -04001265 const gl::Framebuffer *fbo = context->getState().getDrawFramebuffer();
Jamie Madill48faf802014-11-06 15:27:22 -05001266 if (!fbo || fbo->completeness(context->getData()) != GL_FRAMEBUFFER_COMPLETE)
Jamie Madill13f7d7d2014-06-20 13:21:27 -04001267 {
Geoff Langb1196682014-07-23 13:47:29 -04001268 context->recordError(Error(GL_INVALID_FRAMEBUFFER_OPERATION));
1269 return false;
Jamie Madill13f7d7d2014-06-20 13:21:27 -04001270 }
1271
1272 return true;
1273}
1274
Geoff Langb1196682014-07-23 13:47:29 -04001275bool ValidateGetUniformuiv(Context *context, GLuint program, GLint location, GLuint* params)
Jamie Madill0063c512014-08-25 15:47:53 -04001276{
1277 if (context->getClientVersion() < 3)
1278 {
Geoff Langb1196682014-07-23 13:47:29 -04001279 context->recordError(Error(GL_INVALID_OPERATION));
1280 return false;
Jamie Madill0063c512014-08-25 15:47:53 -04001281 }
1282
Jamie Madill78f41802014-08-25 15:47:55 -04001283 return ValidateGetUniformBase(context, program, location);
Jamie Madill0063c512014-08-25 15:47:53 -04001284}
1285
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001286}