| //=== MallocChecker.cpp - A malloc/free checker -------------------*- C++ -*--// |
| // |
| // The LLVM Compiler Infrastructure |
| // |
| // This file is distributed under the University of Illinois Open Source |
| // License. See LICENSE.TXT for details. |
| // |
| //===----------------------------------------------------------------------===// |
| // |
| // This file defines malloc/free checker, which checks for potential memory |
| // leaks, double free, and use-after-free problems. |
| // |
| //===----------------------------------------------------------------------===// |
| |
| #include "ClangSACheckers.h" |
| #include "clang/StaticAnalyzer/Core/Checker.h" |
| #include "clang/StaticAnalyzer/Core/CheckerManager.h" |
| #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h" |
| #include "clang/StaticAnalyzer/Core/BugReporter/BugType.h" |
| #include "clang/StaticAnalyzer/Core/PathSensitive/ObjCMessage.h" |
| #include "clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h" |
| #include "clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h" |
| #include "clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h" |
| #include "clang/Basic/SourceManager.h" |
| #include "llvm/ADT/ImmutableMap.h" |
| #include "llvm/ADT/SmallString.h" |
| #include "llvm/ADT/STLExtras.h" |
| using namespace clang; |
| using namespace ento; |
| |
| namespace { |
| |
| class RefState { |
| enum Kind { AllocateUnchecked, AllocateFailed, Released, Escaped, |
| Relinquished } K; |
| const Stmt *S; |
| |
| public: |
| RefState(Kind k, const Stmt *s) : K(k), S(s) {} |
| |
| bool isAllocated() const { return K == AllocateUnchecked; } |
| //bool isFailed() const { return K == AllocateFailed; } |
| bool isReleased() const { return K == Released; } |
| //bool isEscaped() const { return K == Escaped; } |
| //bool isRelinquished() const { return K == Relinquished; } |
| const Stmt *getStmt() const { return S; } |
| |
| bool operator==(const RefState &X) const { |
| return K == X.K && S == X.S; |
| } |
| |
| static RefState getAllocateUnchecked(const Stmt *s) { |
| return RefState(AllocateUnchecked, s); |
| } |
| static RefState getAllocateFailed() { |
| return RefState(AllocateFailed, 0); |
| } |
| static RefState getReleased(const Stmt *s) { return RefState(Released, s); } |
| static RefState getEscaped(const Stmt *s) { return RefState(Escaped, s); } |
| static RefState getRelinquished(const Stmt *s) { |
| return RefState(Relinquished, s); |
| } |
| |
| void Profile(llvm::FoldingSetNodeID &ID) const { |
| ID.AddInteger(K); |
| ID.AddPointer(S); |
| } |
| }; |
| |
| struct ReallocPair { |
| SymbolRef ReallocatedSym; |
| bool IsFreeOnFailure; |
| ReallocPair(SymbolRef S, bool F) : ReallocatedSym(S), IsFreeOnFailure(F) {} |
| void Profile(llvm::FoldingSetNodeID &ID) const { |
| ID.AddInteger(IsFreeOnFailure); |
| ID.AddPointer(ReallocatedSym); |
| } |
| bool operator==(const ReallocPair &X) const { |
| return ReallocatedSym == X.ReallocatedSym && |
| IsFreeOnFailure == X.IsFreeOnFailure; |
| } |
| }; |
| |
| class MallocChecker : public Checker<check::DeadSymbols, |
| check::EndPath, |
| check::PreStmt<ReturnStmt>, |
| check::PreStmt<CallExpr>, |
| check::PostStmt<CallExpr>, |
| check::Location, |
| check::Bind, |
| eval::Assume, |
| check::RegionChanges> |
| { |
| mutable OwningPtr<BugType> BT_DoubleFree; |
| mutable OwningPtr<BugType> BT_Leak; |
| mutable OwningPtr<BugType> BT_UseFree; |
| mutable OwningPtr<BugType> BT_BadFree; |
| mutable IdentifierInfo *II_malloc, *II_free, *II_realloc, *II_calloc, |
| *II_valloc, *II_reallocf; |
| |
| public: |
| MallocChecker() : II_malloc(0), II_free(0), II_realloc(0), II_calloc(0), |
| II_valloc(0), II_reallocf(0) {} |
| |
| /// In pessimistic mode, the checker assumes that it does not know which |
| /// functions might free the memory. |
| struct ChecksFilter { |
| DefaultBool CMallocPessimistic; |
| DefaultBool CMallocOptimistic; |
| }; |
| |
| ChecksFilter Filter; |
| |
| void checkPreStmt(const CallExpr *S, CheckerContext &C) const; |
| void checkPostStmt(const CallExpr *CE, CheckerContext &C) const; |
| void checkDeadSymbols(SymbolReaper &SymReaper, CheckerContext &C) const; |
| void checkEndPath(CheckerContext &C) const; |
| void checkPreStmt(const ReturnStmt *S, CheckerContext &C) const; |
| ProgramStateRef evalAssume(ProgramStateRef state, SVal Cond, |
| bool Assumption) const; |
| void checkLocation(SVal l, bool isLoad, const Stmt *S, |
| CheckerContext &C) const; |
| void checkBind(SVal location, SVal val, const Stmt*S, |
| CheckerContext &C) const; |
| ProgramStateRef |
| checkRegionChanges(ProgramStateRef state, |
| const StoreManager::InvalidatedSymbols *invalidated, |
| ArrayRef<const MemRegion *> ExplicitRegions, |
| ArrayRef<const MemRegion *> Regions, |
| const CallOrObjCMessage *Call) const; |
| bool wantsRegionChangeUpdate(ProgramStateRef state) const { |
| return true; |
| } |
| |
| private: |
| void initIdentifierInfo(ASTContext &C) const; |
| |
| /// Check if this is one of the functions which can allocate/reallocate memory |
| /// pointed to by one of its arguments. |
| bool isMemFunction(const FunctionDecl *FD, ASTContext &C) const; |
| |
| static void MallocMem(CheckerContext &C, const CallExpr *CE); |
| static void MallocMemReturnsAttr(CheckerContext &C, const CallExpr *CE, |
| const OwnershipAttr* Att); |
| static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE, |
| const Expr *SizeEx, SVal Init, |
| ProgramStateRef state) { |
| return MallocMemAux(C, CE, |
| state->getSVal(SizeEx, C.getLocationContext()), |
| Init, state); |
| } |
| static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE, |
| SVal SizeEx, SVal Init, |
| ProgramStateRef state); |
| |
| void FreeMem(CheckerContext &C, const CallExpr *CE) const; |
| void FreeMemAttr(CheckerContext &C, const CallExpr *CE, |
| const OwnershipAttr* Att) const; |
| ProgramStateRef FreeMemAux(CheckerContext &C, const CallExpr *CE, |
| ProgramStateRef state, unsigned Num, |
| bool Hold) const; |
| |
| void ReallocMem(CheckerContext &C, const CallExpr *CE, |
| bool FreesMemOnFailure) const; |
| static void CallocMem(CheckerContext &C, const CallExpr *CE); |
| |
| bool checkEscape(SymbolRef Sym, const Stmt *S, CheckerContext &C) const; |
| bool checkUseAfterFree(SymbolRef Sym, CheckerContext &C, |
| const Stmt *S = 0) const; |
| |
| /// Check if the function is not known to us. So, for example, we could |
| /// conservatively assume it can free/reallocate it's pointer arguments. |
| bool hasUnknownBehavior(const FunctionDecl *FD, ProgramStateRef State) const; |
| |
| static bool SummarizeValue(raw_ostream &os, SVal V); |
| static bool SummarizeRegion(raw_ostream &os, const MemRegion *MR); |
| void ReportBadFree(CheckerContext &C, SVal ArgVal, SourceRange range) const; |
| |
| void reportLeak(SymbolRef Sym, ExplodedNode *N, CheckerContext &C) const; |
| |
| /// The bug visitor which allows us to print extra diagnostics along the |
| /// BugReport path. For example, showing the allocation site of the leaked |
| /// region. |
| class MallocBugVisitor : public BugReporterVisitor { |
| protected: |
| enum NotificationMode { |
| Normal, |
| Complete, |
| ReallocationFailed |
| }; |
| |
| // The allocated region symbol tracked by the main analysis. |
| SymbolRef Sym; |
| NotificationMode Mode; |
| |
| public: |
| MallocBugVisitor(SymbolRef S) : Sym(S), Mode(Normal) {} |
| virtual ~MallocBugVisitor() {} |
| |
| void Profile(llvm::FoldingSetNodeID &ID) const { |
| static int X = 0; |
| ID.AddPointer(&X); |
| ID.AddPointer(Sym); |
| } |
| |
| inline bool isAllocated(const RefState *S, const RefState *SPrev, |
| const Stmt *Stmt) { |
| // Did not track -> allocated. Other state (released) -> allocated. |
| return (Stmt && isa<CallExpr>(Stmt) && |
| (S && S->isAllocated()) && (!SPrev || !SPrev->isAllocated())); |
| } |
| |
| inline bool isReleased(const RefState *S, const RefState *SPrev, |
| const Stmt *Stmt) { |
| // Did not track -> released. Other state (allocated) -> released. |
| return (Stmt && isa<CallExpr>(Stmt) && |
| (S && S->isReleased()) && (!SPrev || !SPrev->isReleased())); |
| } |
| |
| inline bool isReallocFailedCheck(const RefState *S, const RefState *SPrev, |
| const Stmt *Stmt) { |
| // If the expression is not a call, and the state change is |
| // released -> allocated, it must be the realloc return value |
| // check. If we have to handle more cases here, it might be cleaner just |
| // to track this extra bit in the state itself. |
| return ((!Stmt || !isa<CallExpr>(Stmt)) && |
| (S && S->isAllocated()) && (SPrev && !SPrev->isAllocated())); |
| } |
| |
| PathDiagnosticPiece *VisitNode(const ExplodedNode *N, |
| const ExplodedNode *PrevN, |
| BugReporterContext &BRC, |
| BugReport &BR); |
| }; |
| }; |
| } // end anonymous namespace |
| |
| typedef llvm::ImmutableMap<SymbolRef, RefState> RegionStateTy; |
| typedef llvm::ImmutableMap<SymbolRef, ReallocPair > ReallocMap; |
| class RegionState {}; |
| class ReallocPairs {}; |
| namespace clang { |
| namespace ento { |
| template <> |
| struct ProgramStateTrait<RegionState> |
| : public ProgramStatePartialTrait<RegionStateTy> { |
| static void *GDMIndex() { static int x; return &x; } |
| }; |
| |
| template <> |
| struct ProgramStateTrait<ReallocPairs> |
| : public ProgramStatePartialTrait<ReallocMap> { |
| static void *GDMIndex() { static int x; return &x; } |
| }; |
| } |
| } |
| |
| namespace { |
| class StopTrackingCallback : public SymbolVisitor { |
| ProgramStateRef state; |
| public: |
| StopTrackingCallback(ProgramStateRef st) : state(st) {} |
| ProgramStateRef getState() const { return state; } |
| |
| bool VisitSymbol(SymbolRef sym) { |
| state = state->remove<RegionState>(sym); |
| return true; |
| } |
| }; |
| } // end anonymous namespace |
| |
| void MallocChecker::initIdentifierInfo(ASTContext &Ctx) const { |
| if (!II_malloc) |
| II_malloc = &Ctx.Idents.get("malloc"); |
| if (!II_free) |
| II_free = &Ctx.Idents.get("free"); |
| if (!II_realloc) |
| II_realloc = &Ctx.Idents.get("realloc"); |
| if (!II_reallocf) |
| II_reallocf = &Ctx.Idents.get("reallocf"); |
| if (!II_calloc) |
| II_calloc = &Ctx.Idents.get("calloc"); |
| if (!II_valloc) |
| II_valloc = &Ctx.Idents.get("valloc"); |
| } |
| |
| bool MallocChecker::isMemFunction(const FunctionDecl *FD, ASTContext &C) const { |
| if (!FD) |
| return false; |
| IdentifierInfo *FunI = FD->getIdentifier(); |
| if (!FunI) |
| return false; |
| |
| initIdentifierInfo(C); |
| |
| // TODO: Add more here : ex: reallocf! |
| if (FunI == II_malloc || FunI == II_free || FunI == II_realloc || |
| FunI == II_reallocf || FunI == II_calloc || FunI == II_valloc) |
| return true; |
| |
| if (Filter.CMallocOptimistic && FD->hasAttrs() && |
| FD->specific_attr_begin<OwnershipAttr>() != |
| FD->specific_attr_end<OwnershipAttr>()) |
| return true; |
| |
| |
| return false; |
| } |
| |
| void MallocChecker::checkPostStmt(const CallExpr *CE, CheckerContext &C) const { |
| const FunctionDecl *FD = C.getCalleeDecl(CE); |
| if (!FD) |
| return; |
| |
| initIdentifierInfo(C.getASTContext()); |
| IdentifierInfo *FunI = FD->getIdentifier(); |
| if (!FunI) |
| return; |
| |
| if (FunI == II_malloc || FunI == II_valloc) { |
| MallocMem(C, CE); |
| return; |
| } else if (FunI == II_realloc) { |
| ReallocMem(C, CE, false); |
| return; |
| } else if (FunI == II_reallocf) { |
| ReallocMem(C, CE, true); |
| return; |
| } else if (FunI == II_calloc) { |
| CallocMem(C, CE); |
| return; |
| }else if (FunI == II_free) { |
| FreeMem(C, CE); |
| return; |
| } |
| |
| if (Filter.CMallocOptimistic) |
| // Check all the attributes, if there are any. |
| // There can be multiple of these attributes. |
| if (FD->hasAttrs()) { |
| for (specific_attr_iterator<OwnershipAttr> |
| i = FD->specific_attr_begin<OwnershipAttr>(), |
| e = FD->specific_attr_end<OwnershipAttr>(); |
| i != e; ++i) { |
| switch ((*i)->getOwnKind()) { |
| case OwnershipAttr::Returns: { |
| MallocMemReturnsAttr(C, CE, *i); |
| return; |
| } |
| case OwnershipAttr::Takes: |
| case OwnershipAttr::Holds: { |
| FreeMemAttr(C, CE, *i); |
| return; |
| } |
| } |
| } |
| } |
| } |
| |
| void MallocChecker::MallocMem(CheckerContext &C, const CallExpr *CE) { |
| ProgramStateRef state = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), |
| C.getState()); |
| C.addTransition(state); |
| } |
| |
| void MallocChecker::MallocMemReturnsAttr(CheckerContext &C, const CallExpr *CE, |
| const OwnershipAttr* Att) { |
| if (Att->getModule() != "malloc") |
| return; |
| |
| OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end(); |
| if (I != E) { |
| ProgramStateRef state = |
| MallocMemAux(C, CE, CE->getArg(*I), UndefinedVal(), C.getState()); |
| C.addTransition(state); |
| return; |
| } |
| ProgramStateRef state = MallocMemAux(C, CE, UnknownVal(), UndefinedVal(), |
| C.getState()); |
| C.addTransition(state); |
| } |
| |
| ProgramStateRef MallocChecker::MallocMemAux(CheckerContext &C, |
| const CallExpr *CE, |
| SVal Size, SVal Init, |
| ProgramStateRef state) { |
| SValBuilder &svalBuilder = C.getSValBuilder(); |
| |
| // Get the return value. |
| SVal retVal = state->getSVal(CE, C.getLocationContext()); |
| |
| // We expect the malloc functions to return a pointer. |
| if (!isa<Loc>(retVal)) |
| return 0; |
| |
| // Fill the region with the initialization value. |
| state = state->bindDefault(retVal, Init); |
| |
| // Set the region's extent equal to the Size parameter. |
| const SymbolicRegion *R = |
| dyn_cast_or_null<SymbolicRegion>(retVal.getAsRegion()); |
| if (!R || !isa<DefinedOrUnknownSVal>(Size)) |
| return 0; |
| |
| DefinedOrUnknownSVal Extent = R->getExtent(svalBuilder); |
| DefinedOrUnknownSVal DefinedSize = cast<DefinedOrUnknownSVal>(Size); |
| DefinedOrUnknownSVal extentMatchesSize = |
| svalBuilder.evalEQ(state, Extent, DefinedSize); |
| |
| state = state->assume(extentMatchesSize, true); |
| assert(state); |
| |
| SymbolRef Sym = retVal.getAsLocSymbol(); |
| assert(Sym); |
| |
| // Set the symbol's state to Allocated. |
| return state->set<RegionState>(Sym, RefState::getAllocateUnchecked(CE)); |
| } |
| |
| void MallocChecker::FreeMem(CheckerContext &C, const CallExpr *CE) const { |
| ProgramStateRef state = FreeMemAux(C, CE, C.getState(), 0, false); |
| |
| if (state) |
| C.addTransition(state); |
| } |
| |
| void MallocChecker::FreeMemAttr(CheckerContext &C, const CallExpr *CE, |
| const OwnershipAttr* Att) const { |
| if (Att->getModule() != "malloc") |
| return; |
| |
| for (OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end(); |
| I != E; ++I) { |
| ProgramStateRef state = |
| FreeMemAux(C, CE, C.getState(), *I, |
| Att->getOwnKind() == OwnershipAttr::Holds); |
| if (state) |
| C.addTransition(state); |
| } |
| } |
| |
| ProgramStateRef MallocChecker::FreeMemAux(CheckerContext &C, |
| const CallExpr *CE, |
| ProgramStateRef state, |
| unsigned Num, |
| bool Hold) const { |
| const Expr *ArgExpr = CE->getArg(Num); |
| SVal ArgVal = state->getSVal(ArgExpr, C.getLocationContext()); |
| if (!isa<DefinedOrUnknownSVal>(ArgVal)) |
| return 0; |
| DefinedOrUnknownSVal location = cast<DefinedOrUnknownSVal>(ArgVal); |
| |
| // Check for null dereferences. |
| if (!isa<Loc>(location)) |
| return 0; |
| |
| // The explicit NULL case, no operation is performed. |
| ProgramStateRef notNullState, nullState; |
| llvm::tie(notNullState, nullState) = state->assume(location); |
| if (nullState && !notNullState) |
| return 0; |
| |
| // Unknown values could easily be okay |
| // Undefined values are handled elsewhere |
| if (ArgVal.isUnknownOrUndef()) |
| return 0; |
| |
| const MemRegion *R = ArgVal.getAsRegion(); |
| |
| // Nonlocs can't be freed, of course. |
| // Non-region locations (labels and fixed addresses) also shouldn't be freed. |
| if (!R) { |
| ReportBadFree(C, ArgVal, ArgExpr->getSourceRange()); |
| return 0; |
| } |
| |
| R = R->StripCasts(); |
| |
| // Blocks might show up as heap data, but should not be free()d |
| if (isa<BlockDataRegion>(R)) { |
| ReportBadFree(C, ArgVal, ArgExpr->getSourceRange()); |
| return 0; |
| } |
| |
| const MemSpaceRegion *MS = R->getMemorySpace(); |
| |
| // Parameters, locals, statics, and globals shouldn't be freed. |
| if (!(isa<UnknownSpaceRegion>(MS) || isa<HeapSpaceRegion>(MS))) { |
| // FIXME: at the time this code was written, malloc() regions were |
| // represented by conjured symbols, which are all in UnknownSpaceRegion. |
| // This means that there isn't actually anything from HeapSpaceRegion |
| // that should be freed, even though we allow it here. |
| // Of course, free() can work on memory allocated outside the current |
| // function, so UnknownSpaceRegion is always a possibility. |
| // False negatives are better than false positives. |
| |
| ReportBadFree(C, ArgVal, ArgExpr->getSourceRange()); |
| return 0; |
| } |
| |
| const SymbolicRegion *SR = dyn_cast<SymbolicRegion>(R); |
| // Various cases could lead to non-symbol values here. |
| // For now, ignore them. |
| if (!SR) |
| return 0; |
| |
| SymbolRef Sym = SR->getSymbol(); |
| const RefState *RS = state->get<RegionState>(Sym); |
| |
| // If the symbol has not been tracked, return. This is possible when free() is |
| // called on a pointer that does not get its pointee directly from malloc(). |
| // Full support of this requires inter-procedural analysis. |
| if (!RS) |
| return 0; |
| |
| // Check double free. |
| if (RS->isReleased()) { |
| if (ExplodedNode *N = C.generateSink()) { |
| if (!BT_DoubleFree) |
| BT_DoubleFree.reset( |
| new BugType("Double free", "Memory Error")); |
| BugReport *R = new BugReport(*BT_DoubleFree, |
| "Attempt to free released memory", N); |
| R->addRange(ArgExpr->getSourceRange()); |
| R->addVisitor(new MallocBugVisitor(Sym)); |
| C.EmitReport(R); |
| } |
| return 0; |
| } |
| |
| // Normal free. |
| if (Hold) |
| return state->set<RegionState>(Sym, RefState::getRelinquished(CE)); |
| return state->set<RegionState>(Sym, RefState::getReleased(CE)); |
| } |
| |
| bool MallocChecker::SummarizeValue(raw_ostream &os, SVal V) { |
| if (nonloc::ConcreteInt *IntVal = dyn_cast<nonloc::ConcreteInt>(&V)) |
| os << "an integer (" << IntVal->getValue() << ")"; |
| else if (loc::ConcreteInt *ConstAddr = dyn_cast<loc::ConcreteInt>(&V)) |
| os << "a constant address (" << ConstAddr->getValue() << ")"; |
| else if (loc::GotoLabel *Label = dyn_cast<loc::GotoLabel>(&V)) |
| os << "the address of the label '" << Label->getLabel()->getName() << "'"; |
| else |
| return false; |
| |
| return true; |
| } |
| |
| bool MallocChecker::SummarizeRegion(raw_ostream &os, |
| const MemRegion *MR) { |
| switch (MR->getKind()) { |
| case MemRegion::FunctionTextRegionKind: { |
| const FunctionDecl *FD = cast<FunctionTextRegion>(MR)->getDecl(); |
| if (FD) |
| os << "the address of the function '" << *FD << '\''; |
| else |
| os << "the address of a function"; |
| return true; |
| } |
| case MemRegion::BlockTextRegionKind: |
| os << "block text"; |
| return true; |
| case MemRegion::BlockDataRegionKind: |
| // FIXME: where the block came from? |
| os << "a block"; |
| return true; |
| default: { |
| const MemSpaceRegion *MS = MR->getMemorySpace(); |
| |
| if (isa<StackLocalsSpaceRegion>(MS)) { |
| const VarRegion *VR = dyn_cast<VarRegion>(MR); |
| const VarDecl *VD; |
| if (VR) |
| VD = VR->getDecl(); |
| else |
| VD = NULL; |
| |
| if (VD) |
| os << "the address of the local variable '" << VD->getName() << "'"; |
| else |
| os << "the address of a local stack variable"; |
| return true; |
| } |
| |
| if (isa<StackArgumentsSpaceRegion>(MS)) { |
| const VarRegion *VR = dyn_cast<VarRegion>(MR); |
| const VarDecl *VD; |
| if (VR) |
| VD = VR->getDecl(); |
| else |
| VD = NULL; |
| |
| if (VD) |
| os << "the address of the parameter '" << VD->getName() << "'"; |
| else |
| os << "the address of a parameter"; |
| return true; |
| } |
| |
| if (isa<GlobalsSpaceRegion>(MS)) { |
| const VarRegion *VR = dyn_cast<VarRegion>(MR); |
| const VarDecl *VD; |
| if (VR) |
| VD = VR->getDecl(); |
| else |
| VD = NULL; |
| |
| if (VD) { |
| if (VD->isStaticLocal()) |
| os << "the address of the static variable '" << VD->getName() << "'"; |
| else |
| os << "the address of the global variable '" << VD->getName() << "'"; |
| } else |
| os << "the address of a global variable"; |
| return true; |
| } |
| |
| return false; |
| } |
| } |
| } |
| |
| void MallocChecker::ReportBadFree(CheckerContext &C, SVal ArgVal, |
| SourceRange range) const { |
| if (ExplodedNode *N = C.generateSink()) { |
| if (!BT_BadFree) |
| BT_BadFree.reset(new BugType("Bad free", "Memory Error")); |
| |
| SmallString<100> buf; |
| llvm::raw_svector_ostream os(buf); |
| |
| const MemRegion *MR = ArgVal.getAsRegion(); |
| if (MR) { |
| while (const ElementRegion *ER = dyn_cast<ElementRegion>(MR)) |
| MR = ER->getSuperRegion(); |
| |
| // Special case for alloca() |
| if (isa<AllocaRegion>(MR)) |
| os << "Argument to free() was allocated by alloca(), not malloc()"; |
| else { |
| os << "Argument to free() is "; |
| if (SummarizeRegion(os, MR)) |
| os << ", which is not memory allocated by malloc()"; |
| else |
| os << "not memory allocated by malloc()"; |
| } |
| } else { |
| os << "Argument to free() is "; |
| if (SummarizeValue(os, ArgVal)) |
| os << ", which is not memory allocated by malloc()"; |
| else |
| os << "not memory allocated by malloc()"; |
| } |
| |
| BugReport *R = new BugReport(*BT_BadFree, os.str(), N); |
| R->addRange(range); |
| C.EmitReport(R); |
| } |
| } |
| |
| void MallocChecker::ReallocMem(CheckerContext &C, const CallExpr *CE, |
| bool FreesOnFail) const { |
| ProgramStateRef state = C.getState(); |
| const Expr *arg0Expr = CE->getArg(0); |
| const LocationContext *LCtx = C.getLocationContext(); |
| SVal Arg0Val = state->getSVal(arg0Expr, LCtx); |
| if (!isa<DefinedOrUnknownSVal>(Arg0Val)) |
| return; |
| DefinedOrUnknownSVal arg0Val = cast<DefinedOrUnknownSVal>(Arg0Val); |
| |
| SValBuilder &svalBuilder = C.getSValBuilder(); |
| |
| DefinedOrUnknownSVal PtrEQ = |
| svalBuilder.evalEQ(state, arg0Val, svalBuilder.makeNull()); |
| |
| // Get the size argument. If there is no size arg then give up. |
| const Expr *Arg1 = CE->getArg(1); |
| if (!Arg1) |
| return; |
| |
| // Get the value of the size argument. |
| SVal Arg1ValG = state->getSVal(Arg1, LCtx); |
| if (!isa<DefinedOrUnknownSVal>(Arg1ValG)) |
| return; |
| DefinedOrUnknownSVal Arg1Val = cast<DefinedOrUnknownSVal>(Arg1ValG); |
| |
| // Compare the size argument to 0. |
| DefinedOrUnknownSVal SizeZero = |
| svalBuilder.evalEQ(state, Arg1Val, |
| svalBuilder.makeIntValWithPtrWidth(0, false)); |
| |
| ProgramStateRef StatePtrIsNull, StatePtrNotNull; |
| llvm::tie(StatePtrIsNull, StatePtrNotNull) = state->assume(PtrEQ); |
| ProgramStateRef StateSizeIsZero, StateSizeNotZero; |
| llvm::tie(StateSizeIsZero, StateSizeNotZero) = state->assume(SizeZero); |
| // We only assume exceptional states if they are definitely true; if the |
| // state is under-constrained, assume regular realloc behavior. |
| bool PrtIsNull = StatePtrIsNull && !StatePtrNotNull; |
| bool SizeIsZero = StateSizeIsZero && !StateSizeNotZero; |
| |
| // If the ptr is NULL and the size is not 0, the call is equivalent to |
| // malloc(size). |
| if ( PrtIsNull && !SizeIsZero) { |
| ProgramStateRef stateMalloc = MallocMemAux(C, CE, CE->getArg(1), |
| UndefinedVal(), StatePtrIsNull); |
| C.addTransition(stateMalloc); |
| return; |
| } |
| |
| if (PrtIsNull && SizeIsZero) |
| return; |
| |
| // Get the from and to pointer symbols as in toPtr = realloc(fromPtr, size). |
| assert(!PrtIsNull); |
| SymbolRef FromPtr = arg0Val.getAsSymbol(); |
| SVal RetVal = state->getSVal(CE, LCtx); |
| SymbolRef ToPtr = RetVal.getAsSymbol(); |
| if (!FromPtr || !ToPtr) |
| return; |
| |
| // If the size is 0, free the memory. |
| if (SizeIsZero) |
| if (ProgramStateRef stateFree = FreeMemAux(C, CE, StateSizeIsZero,0,false)){ |
| // The semantics of the return value are: |
| // If size was equal to 0, either NULL or a pointer suitable to be passed |
| // to free() is returned. |
| stateFree = stateFree->set<ReallocPairs>(ToPtr, |
| ReallocPair(FromPtr, FreesOnFail)); |
| C.getSymbolManager().addSymbolDependency(ToPtr, FromPtr); |
| C.addTransition(stateFree); |
| return; |
| } |
| |
| // Default behavior. |
| if (ProgramStateRef stateFree = FreeMemAux(C, CE, state, 0, false)) { |
| // FIXME: We should copy the content of the original buffer. |
| ProgramStateRef stateRealloc = MallocMemAux(C, CE, CE->getArg(1), |
| UnknownVal(), stateFree); |
| if (!stateRealloc) |
| return; |
| stateRealloc = stateRealloc->set<ReallocPairs>(ToPtr, |
| ReallocPair(FromPtr, FreesOnFail)); |
| C.getSymbolManager().addSymbolDependency(ToPtr, FromPtr); |
| C.addTransition(stateRealloc); |
| return; |
| } |
| } |
| |
| void MallocChecker::CallocMem(CheckerContext &C, const CallExpr *CE) { |
| ProgramStateRef state = C.getState(); |
| SValBuilder &svalBuilder = C.getSValBuilder(); |
| const LocationContext *LCtx = C.getLocationContext(); |
| SVal count = state->getSVal(CE->getArg(0), LCtx); |
| SVal elementSize = state->getSVal(CE->getArg(1), LCtx); |
| SVal TotalSize = svalBuilder.evalBinOp(state, BO_Mul, count, elementSize, |
| svalBuilder.getContext().getSizeType()); |
| SVal zeroVal = svalBuilder.makeZeroVal(svalBuilder.getContext().CharTy); |
| |
| C.addTransition(MallocMemAux(C, CE, TotalSize, zeroVal, state)); |
| } |
| |
| void MallocChecker::reportLeak(SymbolRef Sym, ExplodedNode *N, |
| CheckerContext &C) const { |
| assert(N); |
| if (!BT_Leak) { |
| BT_Leak.reset(new BugType("Memory leak", "Memory Error")); |
| // Leaks should not be reported if they are post-dominated by a sink: |
| // (1) Sinks are higher importance bugs. |
| // (2) NoReturnFunctionChecker uses sink nodes to represent paths ending |
| // with __noreturn functions such as assert() or exit(). We choose not |
| // to report leaks on such paths. |
| BT_Leak->setSuppressOnSink(true); |
| } |
| |
| BugReport *R = new BugReport(*BT_Leak, |
| "Memory is never released; potential memory leak", N); |
| R->addVisitor(new MallocBugVisitor(Sym)); |
| C.EmitReport(R); |
| } |
| |
| void MallocChecker::checkDeadSymbols(SymbolReaper &SymReaper, |
| CheckerContext &C) const |
| { |
| if (!SymReaper.hasDeadSymbols()) |
| return; |
| |
| ProgramStateRef state = C.getState(); |
| RegionStateTy RS = state->get<RegionState>(); |
| RegionStateTy::Factory &F = state->get_context<RegionState>(); |
| |
| bool generateReport = false; |
| llvm::SmallVector<SymbolRef, 2> Errors; |
| for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) { |
| if (SymReaper.isDead(I->first)) { |
| if (I->second.isAllocated()) { |
| generateReport = true; |
| Errors.push_back(I->first); |
| } |
| // Remove the dead symbol from the map. |
| RS = F.remove(RS, I->first); |
| |
| } |
| } |
| |
| // Cleanup the Realloc Pairs Map. |
| ReallocMap RP = state->get<ReallocPairs>(); |
| for (ReallocMap::iterator I = RP.begin(), E = RP.end(); I != E; ++I) { |
| if (SymReaper.isDead(I->first) || |
| SymReaper.isDead(I->second.ReallocatedSym)) { |
| state = state->remove<ReallocPairs>(I->first); |
| } |
| } |
| |
| ExplodedNode *N = C.addTransition(state->set<RegionState>(RS)); |
| |
| if (N && generateReport) { |
| for (llvm::SmallVector<SymbolRef, 2>::iterator |
| I = Errors.begin(), E = Errors.end(); I != E; ++I) { |
| reportLeak(*I, N, C); |
| } |
| } |
| } |
| |
| void MallocChecker::checkEndPath(CheckerContext &C) const { |
| ProgramStateRef state = C.getState(); |
| RegionStateTy M = state->get<RegionState>(); |
| |
| for (RegionStateTy::iterator I = M.begin(), E = M.end(); I != E; ++I) { |
| RefState RS = I->second; |
| if (RS.isAllocated()) { |
| ExplodedNode *N = C.addTransition(state); |
| if (N) |
| reportLeak(I->first, N, C); |
| } |
| } |
| } |
| |
| bool MallocChecker::checkEscape(SymbolRef Sym, const Stmt *S, |
| CheckerContext &C) const { |
| ProgramStateRef state = C.getState(); |
| const RefState *RS = state->get<RegionState>(Sym); |
| if (!RS) |
| return false; |
| |
| if (RS->isAllocated()) { |
| state = state->set<RegionState>(Sym, RefState::getEscaped(S)); |
| C.addTransition(state); |
| return true; |
| } |
| return false; |
| } |
| |
| void MallocChecker::checkPreStmt(const CallExpr *CE, CheckerContext &C) const { |
| if (isMemFunction(C.getCalleeDecl(CE), C.getASTContext())) |
| return; |
| |
| // Check use after free, when a freed pointer is passed to a call. |
| ProgramStateRef State = C.getState(); |
| for (CallExpr::const_arg_iterator I = CE->arg_begin(), |
| E = CE->arg_end(); I != E; ++I) { |
| const Expr *A = *I; |
| if (A->getType().getTypePtr()->isAnyPointerType()) { |
| SymbolRef Sym = State->getSVal(A, C.getLocationContext()).getAsSymbol(); |
| if (!Sym) |
| continue; |
| if (checkUseAfterFree(Sym, C, A)) |
| return; |
| } |
| } |
| } |
| |
| void MallocChecker::checkPreStmt(const ReturnStmt *S, CheckerContext &C) const { |
| const Expr *E = S->getRetValue(); |
| if (!E) |
| return; |
| |
| // Check if we are returning a symbol. |
| SymbolRef Sym = C.getState()->getSVal(E, C.getLocationContext()).getAsSymbol(); |
| if (!Sym) |
| return; |
| |
| // Check if we are returning freed memory. |
| if (checkUseAfterFree(Sym, C, E)) |
| return; |
| |
| // Check if the symbol is escaping. |
| checkEscape(Sym, E, C); |
| } |
| |
| bool MallocChecker::checkUseAfterFree(SymbolRef Sym, CheckerContext &C, |
| const Stmt *S) const { |
| assert(Sym); |
| const RefState *RS = C.getState()->get<RegionState>(Sym); |
| if (RS && RS->isReleased()) { |
| if (ExplodedNode *N = C.generateSink()) { |
| if (!BT_UseFree) |
| BT_UseFree.reset(new BugType("Use-after-free", "Memory Error")); |
| |
| BugReport *R = new BugReport(*BT_UseFree, |
| "Use of memory after it is freed",N); |
| if (S) |
| R->addRange(S->getSourceRange()); |
| R->addVisitor(new MallocBugVisitor(Sym)); |
| C.EmitReport(R); |
| return true; |
| } |
| } |
| return false; |
| } |
| |
| // Check if the location is a freed symbolic region. |
| void MallocChecker::checkLocation(SVal l, bool isLoad, const Stmt *S, |
| CheckerContext &C) const { |
| SymbolRef Sym = l.getLocSymbolInBase(); |
| if (Sym) |
| checkUseAfterFree(Sym, C); |
| } |
| |
| //===----------------------------------------------------------------------===// |
| // Check various ways a symbol can be invalidated. |
| // TODO: This logic (the next 3 functions) is copied/similar to the |
| // RetainRelease checker. We might want to factor this out. |
| //===----------------------------------------------------------------------===// |
| |
| // Stop tracking symbols when a value escapes as a result of checkBind. |
| // A value escapes in three possible cases: |
| // (1) we are binding to something that is not a memory region. |
| // (2) we are binding to a memregion that does not have stack storage |
| // (3) we are binding to a memregion with stack storage that the store |
| // does not understand. |
| void MallocChecker::checkBind(SVal loc, SVal val, const Stmt *S, |
| CheckerContext &C) const { |
| // Are we storing to something that causes the value to "escape"? |
| bool escapes = true; |
| ProgramStateRef state = C.getState(); |
| |
| if (loc::MemRegionVal *regionLoc = dyn_cast<loc::MemRegionVal>(&loc)) { |
| escapes = !regionLoc->getRegion()->hasStackStorage(); |
| |
| if (!escapes) { |
| // To test (3), generate a new state with the binding added. If it is |
| // the same state, then it escapes (since the store cannot represent |
| // the binding). |
| escapes = (state == (state->bindLoc(*regionLoc, val))); |
| } |
| if (!escapes) { |
| // Case 4: We do not currently model what happens when a symbol is |
| // assigned to a struct field, so be conservative here and let the symbol |
| // go. TODO: This could definitely be improved upon. |
| escapes = !isa<VarRegion>(regionLoc->getRegion()); |
| } |
| } |
| |
| // If our store can represent the binding and we aren't storing to something |
| // that doesn't have local storage then just return and have the simulation |
| // state continue as is. |
| if (!escapes) |
| return; |
| |
| // Otherwise, find all symbols referenced by 'val' that we are tracking |
| // and stop tracking them. |
| state = state->scanReachableSymbols<StopTrackingCallback>(val).getState(); |
| C.addTransition(state); |
| } |
| |
| // If a symbolic region is assumed to NULL (or another constant), stop tracking |
| // it - assuming that allocation failed on this path. |
| ProgramStateRef MallocChecker::evalAssume(ProgramStateRef state, |
| SVal Cond, |
| bool Assumption) const { |
| RegionStateTy RS = state->get<RegionState>(); |
| for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) { |
| // If the symbol is assumed to NULL or another constant, this will |
| // return an APSInt*. |
| if (state->getSymVal(I.getKey())) |
| state = state->remove<RegionState>(I.getKey()); |
| } |
| |
| // Realloc returns 0 when reallocation fails, which means that we should |
| // restore the state of the pointer being reallocated. |
| ReallocMap RP = state->get<ReallocPairs>(); |
| for (ReallocMap::iterator I = RP.begin(), E = RP.end(); I != E; ++I) { |
| // If the symbol is assumed to NULL or another constant, this will |
| // return an APSInt*. |
| if (state->getSymVal(I.getKey())) { |
| SymbolRef ReallocSym = I.getData().ReallocatedSym; |
| const RefState *RS = state->get<RegionState>(ReallocSym); |
| if (RS) { |
| if (RS->isReleased() && ! I.getData().IsFreeOnFailure) |
| state = state->set<RegionState>(ReallocSym, |
| RefState::getAllocateUnchecked(RS->getStmt())); |
| } |
| state = state->remove<ReallocPairs>(I.getKey()); |
| } |
| } |
| |
| return state; |
| } |
| |
| // Check if the function is not known to us. So, for example, we could |
| // conservatively assume it can free/reallocate it's pointer arguments. |
| // (We assume that the pointers cannot escape through calls to system |
| // functions not handled by this checker.) |
| bool MallocChecker::hasUnknownBehavior(const FunctionDecl *FD, |
| ProgramStateRef State) const { |
| ASTContext &ASTC = State->getStateManager().getContext(); |
| |
| // If it's one of the allocation functions we can reason about, we model it's |
| // behavior explicitly. |
| if (isMemFunction(FD, ASTC)) { |
| return false; |
| } |
| |
| // If it's a system call, we know it does not free the memory. |
| SourceManager &SM = ASTC.getSourceManager(); |
| if (SM.isInSystemHeader(FD->getLocation())) { |
| return false; |
| } |
| |
| // Otherwise, assume that the function can free memory. |
| return true; |
| } |
| |
| // If the symbol we are tracking is invalidated, but not explicitly (ex: the &p |
| // escapes, when we are tracking p), do not track the symbol as we cannot reason |
| // about it anymore. |
| ProgramStateRef |
| MallocChecker::checkRegionChanges(ProgramStateRef State, |
| const StoreManager::InvalidatedSymbols *invalidated, |
| ArrayRef<const MemRegion *> ExplicitRegions, |
| ArrayRef<const MemRegion *> Regions, |
| const CallOrObjCMessage *Call) const { |
| if (!invalidated) |
| return State; |
| llvm::SmallPtrSet<SymbolRef, 8> WhitelistedSymbols; |
| |
| const FunctionDecl *FD = (Call ? |
| dyn_cast_or_null<FunctionDecl>(Call->getDecl()) :0); |
| |
| // If it's a call which might free or reallocate memory, we assume that all |
| // regions (explicit and implicit) escaped. Otherwise, whitelist explicit |
| // pointers; we still can track them. |
| if (!(FD && hasUnknownBehavior(FD, State))) { |
| for (ArrayRef<const MemRegion *>::iterator I = ExplicitRegions.begin(), |
| E = ExplicitRegions.end(); I != E; ++I) { |
| if (const SymbolicRegion *R = (*I)->StripCasts()->getAs<SymbolicRegion>()) |
| WhitelistedSymbols.insert(R->getSymbol()); |
| } |
| } |
| |
| for (StoreManager::InvalidatedSymbols::const_iterator I=invalidated->begin(), |
| E = invalidated->end(); I!=E; ++I) { |
| SymbolRef sym = *I; |
| if (WhitelistedSymbols.count(sym)) |
| continue; |
| // The symbol escaped. |
| if (const RefState *RS = State->get<RegionState>(sym)) |
| State = State->set<RegionState>(sym, RefState::getEscaped(RS->getStmt())); |
| } |
| return State; |
| } |
| |
| PathDiagnosticPiece * |
| MallocChecker::MallocBugVisitor::VisitNode(const ExplodedNode *N, |
| const ExplodedNode *PrevN, |
| BugReporterContext &BRC, |
| BugReport &BR) { |
| const RefState *RS = N->getState()->get<RegionState>(Sym); |
| const RefState *RSPrev = PrevN->getState()->get<RegionState>(Sym); |
| if (!RS && !RSPrev) |
| return 0; |
| |
| const Stmt *S = 0; |
| const char *Msg = 0; |
| |
| // Retrieve the associated statement. |
| ProgramPoint ProgLoc = N->getLocation(); |
| if (isa<StmtPoint>(ProgLoc)) |
| S = cast<StmtPoint>(ProgLoc).getStmt(); |
| // If an assumption was made on a branch, it should be caught |
| // here by looking at the state transition. |
| if (isa<BlockEdge>(ProgLoc)) { |
| const CFGBlock *srcBlk = cast<BlockEdge>(ProgLoc).getSrc(); |
| S = srcBlk->getTerminator(); |
| } |
| if (!S) |
| return 0; |
| |
| // Find out if this is an interesting point and what is the kind. |
| if (Mode == Normal) { |
| if (isAllocated(RS, RSPrev, S)) |
| Msg = "Memory is allocated"; |
| else if (isReleased(RS, RSPrev, S)) |
| Msg = "Memory is released"; |
| else if (isReallocFailedCheck(RS, RSPrev, S)) { |
| Mode = ReallocationFailed; |
| Msg = "Reallocation failed"; |
| } |
| |
| // We are in a special mode if a reallocation failed later in the path. |
| } else if (Mode == ReallocationFailed) { |
| // Generate a special diagnostic for the first realloc we find. |
| if (!isAllocated(RS, RSPrev, S) && !isReleased(RS, RSPrev, S)) |
| return 0; |
| |
| // Check that the name of the function is realloc. |
| const CallExpr *CE = dyn_cast<CallExpr>(S); |
| if (!CE) |
| return 0; |
| const FunctionDecl *funDecl = CE->getDirectCallee(); |
| if (!funDecl) |
| return 0; |
| StringRef FunName = funDecl->getName(); |
| if (!(FunName.equals("realloc") || FunName.equals("reallocf"))) |
| return 0; |
| Msg = "Attempt to reallocate memory"; |
| Mode = Normal; |
| } |
| |
| if (!Msg) |
| return 0; |
| |
| // Generate the extra diagnostic. |
| PathDiagnosticLocation Pos(S, BRC.getSourceManager(), |
| N->getLocationContext()); |
| return new PathDiagnosticEventPiece(Pos, Msg); |
| } |
| |
| |
| #define REGISTER_CHECKER(name) \ |
| void ento::register##name(CheckerManager &mgr) {\ |
| mgr.registerChecker<MallocChecker>()->Filter.C##name = true;\ |
| } |
| |
| REGISTER_CHECKER(MallocPessimistic) |
| REGISTER_CHECKER(MallocOptimistic) |