Anna Zaks | bfa9ab8 | 2013-01-24 23:15:30 +0000 | [diff] [blame] | 1 | // RUN: %clang_cc1 -analyze -analyzer-checker=core,unix.Malloc,debug.ExprInspection -analyzer-config ipa=inlining -verify %s |
Jordan Rose | c36b30c | 2012-07-12 00:16:25 +0000 | [diff] [blame] | 2 | |
| 3 | void clang_analyzer_eval(bool); |
Jordan Rose | 9584f67 | 2012-08-10 22:26:43 +0000 | [diff] [blame] | 4 | void clang_analyzer_checkInlined(bool); |
Jordan Rose | c36b30c | 2012-07-12 00:16:25 +0000 | [diff] [blame] | 5 | |
Jordan Rose | 6fe4dfb | 2012-08-27 18:39:22 +0000 | [diff] [blame] | 6 | typedef __typeof__(sizeof(int)) size_t; |
| 7 | extern "C" void *malloc(size_t); |
| 8 | |
| 9 | // This is the standard placement new. |
| 10 | inline void* operator new(size_t, void* __p) throw() |
| 11 | { |
| 12 | return __p; |
| 13 | } |
| 14 | |
| 15 | |
Jordan Rose | c36b30c | 2012-07-12 00:16:25 +0000 | [diff] [blame] | 16 | class A { |
| 17 | public: |
| 18 | int getZero() { return 0; } |
| 19 | virtual int getNum() { return 0; } |
| 20 | }; |
| 21 | |
| 22 | void test(A &a) { |
| 23 | clang_analyzer_eval(a.getZero() == 0); // expected-warning{{TRUE}} |
| 24 | clang_analyzer_eval(a.getNum() == 0); // expected-warning{{UNKNOWN}} |
| 25 | |
| 26 | A copy(a); |
| 27 | clang_analyzer_eval(copy.getZero() == 0); // expected-warning{{TRUE}} |
| 28 | clang_analyzer_eval(copy.getNum() == 0); // expected-warning{{TRUE}} |
| 29 | } |
| 30 | |
| 31 | |
| 32 | class One : public A { |
| 33 | public: |
| 34 | virtual int getNum() { return 1; } |
| 35 | }; |
| 36 | |
| 37 | void testPathSensitivity(int x) { |
| 38 | A a; |
| 39 | One b; |
| 40 | |
| 41 | A *ptr; |
| 42 | switch (x) { |
| 43 | case 0: |
| 44 | ptr = &a; |
| 45 | break; |
| 46 | case 1: |
| 47 | ptr = &b; |
| 48 | break; |
| 49 | default: |
| 50 | return; |
| 51 | } |
| 52 | |
| 53 | // This should be true on both branches. |
| 54 | clang_analyzer_eval(ptr->getNum() == x); // expected-warning {{TRUE}} |
| 55 | } |
| 56 | |
Jordan Rose | 9584f67 | 2012-08-10 22:26:43 +0000 | [diff] [blame] | 57 | |
| 58 | namespace PureVirtualParent { |
| 59 | class Parent { |
| 60 | public: |
| 61 | virtual int pureVirtual() const = 0; |
| 62 | int callVirtual() const { |
| 63 | return pureVirtual(); |
| 64 | } |
| 65 | }; |
| 66 | |
| 67 | class Child : public Parent { |
| 68 | public: |
| 69 | virtual int pureVirtual() const { |
| 70 | clang_analyzer_checkInlined(true); // expected-warning{{TRUE}} |
| 71 | return 42; |
| 72 | } |
| 73 | }; |
| 74 | |
| 75 | void testVirtual() { |
| 76 | Child x; |
| 77 | |
| 78 | clang_analyzer_eval(x.pureVirtual() == 42); // expected-warning{{TRUE}} |
| 79 | clang_analyzer_eval(x.callVirtual() == 42); // expected-warning{{TRUE}} |
| 80 | } |
| 81 | } |
| 82 | |
| 83 | |
Jordan Rose | b6d2bea | 2012-08-10 22:26:46 +0000 | [diff] [blame] | 84 | namespace PR13569 { |
| 85 | class Parent { |
| 86 | protected: |
| 87 | int m_parent; |
| 88 | virtual int impl() const = 0; |
| 89 | |
| 90 | Parent() : m_parent(0) {} |
| 91 | |
| 92 | public: |
| 93 | int interface() const { |
| 94 | clang_analyzer_checkInlined(true); // expected-warning{{TRUE}} |
| 95 | return impl(); |
| 96 | } |
| 97 | }; |
| 98 | |
| 99 | class Child : public Parent { |
| 100 | protected: |
| 101 | virtual int impl() const { |
| 102 | clang_analyzer_checkInlined(true); // expected-warning{{TRUE}} |
| 103 | return m_parent + m_child; |
| 104 | } |
| 105 | |
| 106 | public: |
| 107 | Child() : m_child(0) {} |
| 108 | |
| 109 | int m_child; |
| 110 | }; |
| 111 | |
| 112 | void testVirtual() { |
| 113 | Child x; |
| 114 | x.m_child = 42; |
| 115 | |
| 116 | // Don't crash when inlining and devirtualizing. |
| 117 | x.interface(); |
| 118 | } |
Jordan Rose | 8ec104b | 2012-08-13 23:46:01 +0000 | [diff] [blame] | 119 | |
| 120 | |
| 121 | class Grandchild : public Child {}; |
| 122 | |
| 123 | void testDevirtualizeToMiddle() { |
| 124 | Grandchild x; |
| 125 | x.m_child = 42; |
| 126 | |
| 127 | // Don't crash when inlining and devirtualizing. |
| 128 | x.interface(); |
| 129 | } |
Jordan Rose | b6d2bea | 2012-08-10 22:26:46 +0000 | [diff] [blame] | 130 | } |
| 131 | |
Jordan Rose | 8ec104b | 2012-08-13 23:46:01 +0000 | [diff] [blame] | 132 | namespace PR13569_virtual { |
| 133 | class Parent { |
| 134 | protected: |
| 135 | int m_parent; |
| 136 | virtual int impl() const = 0; |
Jordan Rose | b6d2bea | 2012-08-10 22:26:46 +0000 | [diff] [blame] | 137 | |
Jordan Rose | 8ec104b | 2012-08-13 23:46:01 +0000 | [diff] [blame] | 138 | Parent() : m_parent(0) {} |
| 139 | |
| 140 | public: |
| 141 | int interface() const { |
| 142 | clang_analyzer_checkInlined(true); // expected-warning{{TRUE}} |
| 143 | return impl(); |
| 144 | } |
| 145 | }; |
| 146 | |
| 147 | class Child : virtual public Parent { |
| 148 | protected: |
| 149 | virtual int impl() const { |
| 150 | clang_analyzer_checkInlined(true); // expected-warning{{TRUE}} |
| 151 | return m_parent + m_child; |
| 152 | } |
| 153 | |
| 154 | public: |
| 155 | Child() : m_child(0) {} |
| 156 | |
| 157 | int m_child; |
| 158 | }; |
| 159 | |
| 160 | void testVirtual() { |
| 161 | Child x; |
| 162 | x.m_child = 42; |
| 163 | |
| 164 | // Don't crash when inlining and devirtualizing. |
| 165 | x.interface(); |
| 166 | } |
| 167 | |
| 168 | |
| 169 | class Grandchild : virtual public Child {}; |
| 170 | |
| 171 | void testDevirtualizeToMiddle() { |
| 172 | Grandchild x; |
| 173 | x.m_child = 42; |
| 174 | |
| 175 | // Don't crash when inlining and devirtualizing. |
| 176 | x.interface(); |
| 177 | } |
| 178 | } |
Jordan Rose | da29ac5 | 2012-08-15 21:05:15 +0000 | [diff] [blame] | 179 | |
| 180 | namespace Invalidation { |
| 181 | struct X { |
| 182 | void touch(int &x) const { |
| 183 | x = 0; |
| 184 | } |
| 185 | |
| 186 | void touch2(int &x) const; |
| 187 | |
| 188 | virtual void touchV(int &x) const { |
| 189 | x = 0; |
| 190 | } |
| 191 | |
| 192 | virtual void touchV2(int &x) const; |
| 193 | |
| 194 | int test() const { |
Anna Zaks | bfa9ab8 | 2013-01-24 23:15:30 +0000 | [diff] [blame] | 195 | // We were accidentally not invalidating under inlining |
Jordan Rose | da29ac5 | 2012-08-15 21:05:15 +0000 | [diff] [blame] | 196 | // at one point for virtual methods with visible definitions. |
| 197 | int a, b, c, d; |
| 198 | touch(a); |
| 199 | touch2(b); |
| 200 | touchV(c); |
| 201 | touchV2(d); |
| 202 | return a + b + c + d; // no-warning |
| 203 | } |
| 204 | }; |
| 205 | } |
Jordan Rose | b66529d | 2012-08-23 18:10:53 +0000 | [diff] [blame] | 206 | |
| 207 | namespace DefaultArgs { |
| 208 | int takesDefaultArgs(int i = 42) { |
| 209 | return -i; |
| 210 | } |
| 211 | |
| 212 | void testFunction() { |
| 213 | clang_analyzer_eval(takesDefaultArgs(1) == -1); // expected-warning{{TRUE}} |
| 214 | clang_analyzer_eval(takesDefaultArgs() == -42); // expected-warning{{TRUE}} |
| 215 | } |
| 216 | |
| 217 | class Secret { |
| 218 | public: |
Jordan Rose | 38f68ef | 2013-02-13 03:11:06 +0000 | [diff] [blame^] | 219 | static const int value = 40 + 2; |
Jordan Rose | b66529d | 2012-08-23 18:10:53 +0000 | [diff] [blame] | 220 | int get(int i = value) { |
| 221 | return i; |
| 222 | } |
| 223 | }; |
| 224 | |
| 225 | void testMethod() { |
| 226 | Secret obj; |
| 227 | clang_analyzer_eval(obj.get(1) == 1); // expected-warning{{TRUE}} |
Jordan Rose | 38f68ef | 2013-02-13 03:11:06 +0000 | [diff] [blame^] | 228 | clang_analyzer_eval(obj.get() == 42); // expected-warning{{TRUE}} |
Jordan Rose | b66529d | 2012-08-23 18:10:53 +0000 | [diff] [blame] | 229 | clang_analyzer_eval(Secret::value == 42); // expected-warning{{TRUE}} |
Jordan Rose | 38f68ef | 2013-02-13 03:11:06 +0000 | [diff] [blame^] | 230 | } |
| 231 | |
| 232 | enum ABC { |
| 233 | A = 0, |
| 234 | B = 1, |
| 235 | C = 2 |
| 236 | }; |
| 237 | |
| 238 | int enumUser(ABC input = B) { |
| 239 | return static_cast<int>(input); |
| 240 | } |
| 241 | |
| 242 | void testEnum() { |
| 243 | clang_analyzer_eval(enumUser(C) == 2); // expected-warning{{TRUE}} |
| 244 | clang_analyzer_eval(enumUser() == 1); // expected-warning{{TRUE}} |
| 245 | } |
| 246 | |
| 247 | |
| 248 | int exprUser(int input = 2 * 4) { |
| 249 | return input; |
| 250 | } |
| 251 | |
| 252 | int complicatedExprUser(int input = 2 * Secret::value) { |
| 253 | return input; |
| 254 | } |
| 255 | |
| 256 | void testExprs() { |
| 257 | clang_analyzer_eval(exprUser(1) == 1); // expected-warning{{TRUE}} |
| 258 | clang_analyzer_eval(exprUser() == 8); // expected-warning{{TRUE}} |
| 259 | |
| 260 | clang_analyzer_eval(complicatedExprUser(1) == 1); // expected-warning{{TRUE}} |
| 261 | clang_analyzer_eval(complicatedExprUser() == 84); // expected-warning{{TRUE}} |
Jordan Rose | b66529d | 2012-08-23 18:10:53 +0000 | [diff] [blame] | 262 | } |
| 263 | } |
Jordan Rose | 6fe4dfb | 2012-08-27 18:39:22 +0000 | [diff] [blame] | 264 | |
| 265 | namespace OperatorNew { |
| 266 | class IntWrapper { |
| 267 | public: |
| 268 | int value; |
| 269 | |
| 270 | IntWrapper(int input) : value(input) { |
| 271 | // We don't want this constructor to be inlined unless we can actually |
| 272 | // use the proper region for operator new. |
| 273 | // See PR12014 and <rdar://problem/12180598>. |
| 274 | clang_analyzer_checkInlined(false); // no-warning |
| 275 | } |
| 276 | }; |
| 277 | |
| 278 | void test() { |
| 279 | IntWrapper *obj = new IntWrapper(42); |
| 280 | // should be TRUE |
| 281 | clang_analyzer_eval(obj->value == 42); // expected-warning{{UNKNOWN}} |
| 282 | } |
| 283 | |
| 284 | void testPlacement() { |
| 285 | IntWrapper *obj = static_cast<IntWrapper *>(malloc(sizeof(IntWrapper))); |
| 286 | IntWrapper *alias = new (obj) IntWrapper(42); |
| 287 | |
| 288 | clang_analyzer_eval(alias == obj); // expected-warning{{TRUE}} |
| 289 | |
| 290 | // should be TRUE |
| 291 | clang_analyzer_eval(obj->value == 42); // expected-warning{{UNKNOWN}} |
| 292 | } |
| 293 | } |
Jordan Rose | 8f0d0fe | 2012-09-07 01:19:42 +0000 | [diff] [blame] | 294 | |
| 295 | |
| 296 | namespace VirtualWithSisterCasts { |
Jordan Rose | 9874f59 | 2012-09-08 01:24:38 +0000 | [diff] [blame] | 297 | // This entire set of tests exercises casts from sister classes and |
| 298 | // from classes outside the hierarchy, which can very much confuse |
| 299 | // code that uses DynamicTypeInfo or needs to construct CXXBaseObjectRegions. |
| 300 | // These examples used to cause crashes in +Asserts builds. |
Jordan Rose | 8f0d0fe | 2012-09-07 01:19:42 +0000 | [diff] [blame] | 301 | struct Parent { |
| 302 | virtual int foo(); |
Jordan Rose | 9874f59 | 2012-09-08 01:24:38 +0000 | [diff] [blame] | 303 | int x; |
Jordan Rose | 8f0d0fe | 2012-09-07 01:19:42 +0000 | [diff] [blame] | 304 | }; |
| 305 | |
| 306 | struct A : Parent { |
| 307 | virtual int foo() { return 42; } |
| 308 | }; |
| 309 | |
| 310 | struct B : Parent { |
| 311 | virtual int foo(); |
| 312 | }; |
| 313 | |
Jordan Rose | 9874f59 | 2012-09-08 01:24:38 +0000 | [diff] [blame] | 314 | struct Grandchild : public A {}; |
| 315 | |
Jordan Rose | 8f0d0fe | 2012-09-07 01:19:42 +0000 | [diff] [blame] | 316 | struct Unrelated {}; |
| 317 | |
| 318 | void testDowncast(Parent *b) { |
| 319 | A *a = (A *)(void *)b; |
| 320 | clang_analyzer_eval(a->foo() == 42); // expected-warning{{UNKNOWN}} |
Jordan Rose | 9874f59 | 2012-09-08 01:24:38 +0000 | [diff] [blame] | 321 | |
| 322 | a->x = 42; |
| 323 | clang_analyzer_eval(a->x == 42); // expected-warning{{TRUE}} |
Jordan Rose | 8f0d0fe | 2012-09-07 01:19:42 +0000 | [diff] [blame] | 324 | } |
| 325 | |
| 326 | void testRelated(B *b) { |
| 327 | A *a = (A *)(void *)b; |
| 328 | clang_analyzer_eval(a->foo() == 42); // expected-warning{{UNKNOWN}} |
Jordan Rose | 9874f59 | 2012-09-08 01:24:38 +0000 | [diff] [blame] | 329 | |
| 330 | a->x = 42; |
| 331 | clang_analyzer_eval(a->x == 42); // expected-warning{{TRUE}} |
Jordan Rose | 8f0d0fe | 2012-09-07 01:19:42 +0000 | [diff] [blame] | 332 | } |
| 333 | |
| 334 | void testUnrelated(Unrelated *b) { |
| 335 | A *a = (A *)(void *)b; |
| 336 | clang_analyzer_eval(a->foo() == 42); // expected-warning{{UNKNOWN}} |
Jordan Rose | 9874f59 | 2012-09-08 01:24:38 +0000 | [diff] [blame] | 337 | |
| 338 | a->x = 42; |
| 339 | clang_analyzer_eval(a->x == 42); // expected-warning{{TRUE}} |
| 340 | } |
| 341 | |
| 342 | void testCastViaNew(B *b) { |
| 343 | Grandchild *g = new (b) Grandchild(); |
| 344 | // FIXME: We actually now have perfect type info because of 'new'. |
| 345 | // This should be TRUE. |
| 346 | clang_analyzer_eval(g->foo() == 42); // expected-warning{{UNKNOWN}} |
| 347 | |
| 348 | g->x = 42; |
| 349 | clang_analyzer_eval(g->x == 42); // expected-warning{{TRUE}} |
Jordan Rose | 8f0d0fe | 2012-09-07 01:19:42 +0000 | [diff] [blame] | 350 | } |
| 351 | } |
Jordan Rose | 00b4f64 | 2012-09-11 00:31:02 +0000 | [diff] [blame] | 352 | |
| 353 | |
| 354 | namespace QualifiedCalls { |
| 355 | void test(One *object) { |
| 356 | // This uses the One class from the top of the file. |
| 357 | clang_analyzer_eval(object->getNum() == 1); // expected-warning{{UNKNOWN}} |
| 358 | clang_analyzer_eval(object->One::getNum() == 1); // expected-warning{{TRUE}} |
| 359 | clang_analyzer_eval(object->A::getNum() == 0); // expected-warning{{TRUE}} |
| 360 | |
| 361 | // getZero is non-virtual. |
| 362 | clang_analyzer_eval(object->getZero() == 0); // expected-warning{{TRUE}} |
| 363 | clang_analyzer_eval(object->One::getZero() == 0); // expected-warning{{TRUE}} |
| 364 | clang_analyzer_eval(object->A::getZero() == 0); // expected-warning{{TRUE}} |
| 365 | } |
| 366 | } |
Jordan Rose | 48314cf | 2012-10-03 01:08:35 +0000 | [diff] [blame] | 367 | |
| 368 | |
| 369 | namespace rdar12409977 { |
| 370 | struct Base { |
| 371 | int x; |
| 372 | }; |
| 373 | |
| 374 | struct Parent : public Base { |
| 375 | virtual Parent *vGetThis(); |
| 376 | Parent *getThis() { return vGetThis(); } |
| 377 | }; |
| 378 | |
| 379 | struct Child : public Parent { |
| 380 | virtual Child *vGetThis() { return this; } |
| 381 | }; |
| 382 | |
| 383 | void test() { |
| 384 | Child obj; |
| 385 | obj.x = 42; |
| 386 | |
| 387 | // Originally, calling a devirtualized method with a covariant return type |
| 388 | // caused a crash because the return value had the wrong type. When we then |
| 389 | // go to layer a CXXBaseObjectRegion on it, the base isn't a direct base of |
| 390 | // the object region and we get an assertion failure. |
| 391 | clang_analyzer_eval(obj.getThis()->x == 42); // expected-warning{{TRUE}} |
| 392 | } |
| 393 | } |