Jordan Rose | e449edc | 2013-04-05 17:55:07 +0000 | [diff] [blame] | 1 | // RUN: %clang_cc1 -analyze -analyzer-checker=core,cplusplus.NewDelete -std=c++11 -fblocks -verify %s |
Anton Yartsev | 9df151c | 2013-04-12 23:25:40 +0000 | [diff] [blame] | 2 | // RUN: %clang_cc1 -analyze -analyzer-checker=core,alpha.cplusplus.NewDeleteLeaks -DLEAKS -std=c++11 -fblocks -verify %s |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 3 | #include "Inputs/system-header-simulator-cxx.h" |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 4 | |
| 5 | typedef __typeof__(sizeof(int)) size_t; |
| 6 | extern "C" void *malloc(size_t); |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 7 | int *global; |
| 8 | |
| 9 | //------------------ |
| 10 | // check for leaks |
| 11 | //------------------ |
| 12 | |
Anton Yartsev | 6974628 | 2013-03-28 16:10:38 +0000 | [diff] [blame] | 13 | //----- Standard non-placement operators |
| 14 | void testGlobalOpNew() { |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 15 | void *p = operator new(0); |
Jordan Rose | e85deb3 | 2013-04-05 17:55:00 +0000 | [diff] [blame] | 16 | } |
| 17 | #ifdef LEAKS |
Anna Zaks | 68eb4c2 | 2013-04-06 00:41:36 +0000 | [diff] [blame] | 18 | // expected-warning@-2{{Potential leak of memory pointed to by 'p'}} |
Jordan Rose | e85deb3 | 2013-04-05 17:55:00 +0000 | [diff] [blame] | 19 | #endif |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 20 | |
Anton Yartsev | 6974628 | 2013-03-28 16:10:38 +0000 | [diff] [blame] | 21 | void testGlobalOpNewArray() { |
| 22 | void *p = operator new[](0); |
Jordan Rose | e85deb3 | 2013-04-05 17:55:00 +0000 | [diff] [blame] | 23 | } |
| 24 | #ifdef LEAKS |
Anna Zaks | 68eb4c2 | 2013-04-06 00:41:36 +0000 | [diff] [blame] | 25 | // expected-warning@-2{{Potential leak of memory pointed to by 'p'}} |
Jordan Rose | e85deb3 | 2013-04-05 17:55:00 +0000 | [diff] [blame] | 26 | #endif |
Anton Yartsev | 6974628 | 2013-03-28 16:10:38 +0000 | [diff] [blame] | 27 | |
| 28 | void testGlobalNewExpr() { |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 29 | int *p = new int; |
Jordan Rose | e85deb3 | 2013-04-05 17:55:00 +0000 | [diff] [blame] | 30 | } |
| 31 | #ifdef LEAKS |
Anna Zaks | 68eb4c2 | 2013-04-06 00:41:36 +0000 | [diff] [blame] | 32 | // expected-warning@-2{{Potential leak of memory pointed to by 'p'}} |
Jordan Rose | e85deb3 | 2013-04-05 17:55:00 +0000 | [diff] [blame] | 33 | #endif |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 34 | |
Anton Yartsev | 6974628 | 2013-03-28 16:10:38 +0000 | [diff] [blame] | 35 | void testGlobalNewExprArray() { |
| 36 | int *p = new int[0]; |
Jordan Rose | e85deb3 | 2013-04-05 17:55:00 +0000 | [diff] [blame] | 37 | } |
| 38 | #ifdef LEAKS |
Anna Zaks | 68eb4c2 | 2013-04-06 00:41:36 +0000 | [diff] [blame] | 39 | // expected-warning@-2{{Potential leak of memory pointed to by 'p'}} |
Jordan Rose | e85deb3 | 2013-04-05 17:55:00 +0000 | [diff] [blame] | 40 | #endif |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 41 | |
Anton Yartsev | 6974628 | 2013-03-28 16:10:38 +0000 | [diff] [blame] | 42 | //----- Standard nothrow placement operators |
| 43 | void testGlobalNoThrowPlacementOpNewBeforeOverload() { |
| 44 | void *p = operator new(0, std::nothrow); |
Jordan Rose | e85deb3 | 2013-04-05 17:55:00 +0000 | [diff] [blame] | 45 | } |
| 46 | #ifdef LEAKS |
Anna Zaks | 68eb4c2 | 2013-04-06 00:41:36 +0000 | [diff] [blame] | 47 | // expected-warning@-2{{Potential leak of memory pointed to by 'p'}} |
Jordan Rose | e85deb3 | 2013-04-05 17:55:00 +0000 | [diff] [blame] | 48 | #endif |
Anton Yartsev | 6974628 | 2013-03-28 16:10:38 +0000 | [diff] [blame] | 49 | |
| 50 | void testGlobalNoThrowPlacementExprNewBeforeOverload() { |
| 51 | int *p = new(std::nothrow) int; |
Jordan Rose | e85deb3 | 2013-04-05 17:55:00 +0000 | [diff] [blame] | 52 | } |
| 53 | #ifdef LEAKS |
Anna Zaks | 68eb4c2 | 2013-04-06 00:41:36 +0000 | [diff] [blame] | 54 | // expected-warning@-2{{Potential leak of memory pointed to by 'p'}} |
Jordan Rose | e85deb3 | 2013-04-05 17:55:00 +0000 | [diff] [blame] | 55 | #endif |
Anton Yartsev | 6974628 | 2013-03-28 16:10:38 +0000 | [diff] [blame] | 56 | |
Anton Yartsev | 6974628 | 2013-03-28 16:10:38 +0000 | [diff] [blame] | 57 | //----- Standard pointer placement operators |
| 58 | void testGlobalPointerPlacementNew() { |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 59 | int i; |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 60 | |
Anton Yartsev | 6974628 | 2013-03-28 16:10:38 +0000 | [diff] [blame] | 61 | void *p1 = operator new(0, &i); // no warn |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 62 | |
Anton Yartsev | 6974628 | 2013-03-28 16:10:38 +0000 | [diff] [blame] | 63 | void *p2 = operator new[](0, &i); // no warn |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 64 | |
Anton Yartsev | 6974628 | 2013-03-28 16:10:38 +0000 | [diff] [blame] | 65 | int *p3 = new(&i) int; // no warn |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 66 | |
Anton Yartsev | 6974628 | 2013-03-28 16:10:38 +0000 | [diff] [blame] | 67 | int *p4 = new(&i) int[0]; // no warn |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 68 | } |
| 69 | |
Anton Yartsev | 6974628 | 2013-03-28 16:10:38 +0000 | [diff] [blame] | 70 | //----- Other cases |
| 71 | void testNewMemoryIsInHeap() { |
| 72 | int *p = new int; |
| 73 | if (global != p) // condition is always true as 'p' wraps a heap region that |
| 74 | // is different from a region wrapped by 'global' |
| 75 | global = p; // pointer escapes |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 76 | } |
| 77 | |
Anton Yartsev | 6974628 | 2013-03-28 16:10:38 +0000 | [diff] [blame] | 78 | struct PtrWrapper { |
| 79 | int *x; |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 80 | |
Anton Yartsev | 6974628 | 2013-03-28 16:10:38 +0000 | [diff] [blame] | 81 | PtrWrapper(int *input) : x(input) {} |
| 82 | }; |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 83 | |
Anton Yartsev | 6974628 | 2013-03-28 16:10:38 +0000 | [diff] [blame] | 84 | void testNewInvalidationPlacement(PtrWrapper *w) { |
| 85 | // Ensure that we don't consider this a leak. |
| 86 | new (w) PtrWrapper(new int); // no warn |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 87 | } |
| 88 | |
| 89 | //--------------- |
| 90 | // other checks |
| 91 | //--------------- |
| 92 | |
Anton Yartsev | 55e57a5 | 2013-04-10 22:21:41 +0000 | [diff] [blame] | 93 | class SomeClass { |
| 94 | public: |
| 95 | void f(int *p); |
| 96 | }; |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 97 | |
Anton Yartsev | 55e57a5 | 2013-04-10 22:21:41 +0000 | [diff] [blame] | 98 | void f(int *p1, int *p2 = 0, int *p3 = 0); |
| 99 | void g(SomeClass &c, ...); |
| 100 | |
| 101 | void testUseFirstArgAfterDelete() { |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 102 | int *p = new int; |
| 103 | delete p; |
| 104 | f(p); // expected-warning{{Use of memory after it is freed}} |
| 105 | } |
| 106 | |
Anton Yartsev | 55e57a5 | 2013-04-10 22:21:41 +0000 | [diff] [blame] | 107 | void testUseMiddleArgAfterDelete(int *p) { |
| 108 | delete p; |
| 109 | f(0, p); // expected-warning{{Use of memory after it is freed}} |
| 110 | } |
| 111 | |
| 112 | void testUseLastArgAfterDelete(int *p) { |
| 113 | delete p; |
| 114 | f(0, 0, p); // expected-warning{{Use of memory after it is freed}} |
| 115 | } |
| 116 | |
Anton Yartsev | 337ad76 | 2013-04-10 22:36:16 +0000 | [diff] [blame] | 117 | void testUseSeveralArgsAfterDelete(int *p) { |
| 118 | delete p; |
| 119 | f(p, p, p); // expected-warning{{Use of memory after it is freed}} |
| 120 | } |
| 121 | |
Anton Yartsev | 55e57a5 | 2013-04-10 22:21:41 +0000 | [diff] [blame] | 122 | void testUseRefArgAfterDelete(SomeClass &c) { |
| 123 | delete &c; |
| 124 | g(c); // expected-warning{{Use of memory after it is freed}} |
| 125 | } |
| 126 | |
| 127 | void testVariadicArgAfterDelete() { |
| 128 | SomeClass c; |
| 129 | int *p = new int; |
| 130 | delete p; |
| 131 | g(c, 0, p); // expected-warning{{Use of memory after it is freed}} |
| 132 | } |
| 133 | |
| 134 | void testUseMethodArgAfterDelete(int *p) { |
| 135 | SomeClass *c = new SomeClass; |
| 136 | delete p; |
| 137 | c->f(p); // expected-warning{{Use of memory after it is freed}} |
| 138 | } |
| 139 | |
| 140 | void testUseThisAfterDelete() { |
| 141 | SomeClass *c = new SomeClass; |
| 142 | delete c; |
| 143 | c->f(0); // expected-warning{{Use of memory after it is freed}} |
| 144 | } |
| 145 | |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 146 | void testDeleteAlloca() { |
| 147 | int *p = (int *)__builtin_alloca(sizeof(int)); |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 148 | delete p; // expected-warning{{Memory allocated by alloca() should not be deallocated}} |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 149 | } |
| 150 | |
| 151 | void testDoubleDelete() { |
| 152 | int *p = new int; |
| 153 | delete p; |
| 154 | delete p; // expected-warning{{Attempt to free released memory}} |
| 155 | } |
| 156 | |
| 157 | void testExprDeleteArg() { |
| 158 | int i; |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 159 | delete &i; // expected-warning{{Argument to 'delete' is the address of the local variable 'i', which is not memory allocated by 'new'}} |
| 160 | } |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 161 | |
| 162 | void testExprDeleteArrArg() { |
| 163 | int i; |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 164 | delete[] &i; // expected-warning{{Argument to 'delete[]' is the address of the local variable 'i', which is not memory allocated by 'new[]'}} |
| 165 | } |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 166 | |
| 167 | void testAllocDeallocNames() { |
| 168 | int *p = new(std::nothrow) int[1]; |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 169 | delete[] (++p); // expected-warning{{Argument to 'delete[]' is offset by 4 bytes from the start of memory allocated by 'new[]'}} |
| 170 | } |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 171 | |
Anna Zaks | 41988f3 | 2013-03-28 23:15:29 +0000 | [diff] [blame] | 172 | //-------------------------------- |
| 173 | // Test escape of newed const pointer. Note, a const pointer can be deleted. |
| 174 | //-------------------------------- |
| 175 | struct StWithConstPtr { |
| 176 | const int *memp; |
| 177 | }; |
| 178 | void escape(const int &x); |
| 179 | void escapeStruct(const StWithConstPtr &x); |
| 180 | void escapePtr(const StWithConstPtr *x); |
| 181 | void escapeVoidPtr(const void *x); |
| 182 | |
| 183 | void testConstEscape() { |
| 184 | int *p = new int(1); |
| 185 | escape(*p); |
| 186 | } // no-warning |
| 187 | |
| 188 | void testConstEscapeStruct() { |
| 189 | StWithConstPtr *St = new StWithConstPtr(); |
| 190 | escapeStruct(*St); |
| 191 | } // no-warning |
| 192 | |
| 193 | void testConstEscapeStructPtr() { |
| 194 | StWithConstPtr *St = new StWithConstPtr(); |
| 195 | escapePtr(St); |
| 196 | } // no-warning |
| 197 | |
| 198 | void testConstEscapeMember() { |
| 199 | StWithConstPtr St; |
| 200 | St.memp = new int(2); |
| 201 | escapeVoidPtr(St.memp); |
| 202 | } // no-warning |
| 203 | |
| 204 | void testConstEscapePlacementNew() { |
| 205 | int *x = (int *)malloc(sizeof(int)); |
| 206 | void *y = new (x) int; |
| 207 | escapeVoidPtr(y); |
| 208 | } // no-warning |