blob: 8617ba650f381a4978a3513816bd568e426d2d26 [file] [log] [blame]
Zhongxing Xud19e21b2008-08-29 15:09:12 +00001//== BasicConstraintManager.cpp - Manage basic constraints.------*- C++ -*--==//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file defines BasicConstraintManager, a class that tracks simple
11// equality and inequality constraints on symbolic values of GRState.
12//
13//===----------------------------------------------------------------------===//
14
Zhongxing Xu30ad1672008-08-27 14:03:33 +000015#include "clang/Analysis/PathSensitive/ConstraintManager.h"
16#include "clang/Analysis/PathSensitive/GRState.h"
Zhongxing Xu39cfed32008-08-29 14:52:36 +000017#include "clang/Analysis/PathSensitive/GRStateTrait.h"
Zhongxing Xu30ad1672008-08-27 14:03:33 +000018#include "llvm/Support/Compiler.h"
Zhongxing Xu39cfed32008-08-29 14:52:36 +000019#include "llvm/Support/raw_ostream.h"
Zhongxing Xu30ad1672008-08-27 14:03:33 +000020
21using namespace clang;
22
23namespace {
24
Zhongxing Xu39cfed32008-08-29 14:52:36 +000025typedef llvm::ImmutableMap<SymbolID,GRState::IntSetTy> ConstNotEqTy;
26typedef llvm::ImmutableMap<SymbolID,const llvm::APSInt*> ConstEqTy;
27
Zhongxing Xu30ad1672008-08-27 14:03:33 +000028// BasicConstraintManager only tracks equality and inequality constraints of
29// constants and integer variables.
30class VISIBILITY_HIDDEN BasicConstraintManager : public ConstraintManager {
Zhongxing Xu30ad1672008-08-27 14:03:33 +000031 GRStateManager& StateMgr;
32
33public:
34 BasicConstraintManager(GRStateManager& statemgr) : StateMgr(statemgr) {}
35
Zhongxing Xu1c96b242008-10-17 05:57:07 +000036 virtual const GRState* Assume(const GRState* St, SVal Cond,
Zhongxing Xu30ad1672008-08-27 14:03:33 +000037 bool Assumption, bool& isFeasible);
38
Zhongxing Xu1c96b242008-10-17 05:57:07 +000039 const GRState* Assume(const GRState* St, Loc Cond, bool Assumption,
Zhongxing Xu30ad1672008-08-27 14:03:33 +000040 bool& isFeasible);
41
Zhongxing Xu1c96b242008-10-17 05:57:07 +000042 const GRState* AssumeAux(const GRState* St, Loc Cond,bool Assumption,
Zhongxing Xu30ad1672008-08-27 14:03:33 +000043 bool& isFeasible);
44
Zhongxing Xu1c96b242008-10-17 05:57:07 +000045 const GRState* Assume(const GRState* St, NonLoc Cond, bool Assumption,
Zhongxing Xu30ad1672008-08-27 14:03:33 +000046 bool& isFeasible);
47
Zhongxing Xu1c96b242008-10-17 05:57:07 +000048 const GRState* AssumeAux(const GRState* St, NonLoc Cond, bool Assumption,
Zhongxing Xu30ad1672008-08-27 14:03:33 +000049 bool& isFeasible);
50
51 const GRState* AssumeSymInt(const GRState* St, bool Assumption,
52 const SymIntConstraint& C, bool& isFeasible);
53
54 const GRState* AssumeSymNE(const GRState* St, SymbolID sym,
55 const llvm::APSInt& V, bool& isFeasible);
56
57 const GRState* AssumeSymEQ(const GRState* St, SymbolID sym,
58 const llvm::APSInt& V, bool& isFeasible);
59
60 const GRState* AssumeSymLT(const GRState* St, SymbolID sym,
61 const llvm::APSInt& V, bool& isFeasible);
62
63 const GRState* AssumeSymGT(const GRState* St, SymbolID sym,
64 const llvm::APSInt& V, bool& isFeasible);
65
66 const GRState* AssumeSymGE(const GRState* St, SymbolID sym,
67 const llvm::APSInt& V, bool& isFeasible);
68
69 const GRState* AssumeSymLE(const GRState* St, SymbolID sym,
70 const llvm::APSInt& V, bool& isFeasible);
Zhongxing Xu39cfed32008-08-29 14:52:36 +000071
72 const GRState* AddEQ(const GRState* St, SymbolID sym, const llvm::APSInt& V);
73
74 const GRState* AddNE(const GRState* St, SymbolID sym, const llvm::APSInt& V);
75
76 const llvm::APSInt* getSymVal(const GRState* St, SymbolID sym);
77 bool isNotEqual(const GRState* St, SymbolID sym, const llvm::APSInt& V) const;
78 bool isEqual(const GRState* St, SymbolID sym, const llvm::APSInt& V) const;
79
80 const GRState* RemoveDeadBindings(const GRState* St,
81 StoreManager::LiveSymbolsTy& LSymbols,
82 StoreManager::DeadSymbolsTy& DSymbols);
83
84 void print(const GRState* St, std::ostream& Out,
85 const char* nl, const char *sep);
86};
Zhongxing Xu30ad1672008-08-27 14:03:33 +000087
88} // end anonymous namespace
89
90ConstraintManager* clang::CreateBasicConstraintManager(GRStateManager& StateMgr)
91{
92 return new BasicConstraintManager(StateMgr);
93}
94
Zhongxing Xu1c96b242008-10-17 05:57:07 +000095const GRState* BasicConstraintManager::Assume(const GRState* St, SVal Cond,
Zhongxing Xu30ad1672008-08-27 14:03:33 +000096 bool Assumption, bool& isFeasible) {
97 if (Cond.isUnknown()) {
98 isFeasible = true;
99 return St;
100 }
101
Zhongxing Xu1c96b242008-10-17 05:57:07 +0000102 if (isa<NonLoc>(Cond))
103 return Assume(St, cast<NonLoc>(Cond), Assumption, isFeasible);
Zhongxing Xu30ad1672008-08-27 14:03:33 +0000104 else
Zhongxing Xu1c96b242008-10-17 05:57:07 +0000105 return Assume(St, cast<Loc>(Cond), Assumption, isFeasible);
Zhongxing Xu30ad1672008-08-27 14:03:33 +0000106}
107
Zhongxing Xu1c96b242008-10-17 05:57:07 +0000108const GRState* BasicConstraintManager::Assume(const GRState* St, Loc Cond,
Zhongxing Xu30ad1672008-08-27 14:03:33 +0000109 bool Assumption, bool& isFeasible) {
110 St = AssumeAux(St, Cond, Assumption, isFeasible);
111 // TF->EvalAssume(*this, St, Cond, Assumption, isFeasible)
112 return St;
113}
114
Zhongxing Xu1c96b242008-10-17 05:57:07 +0000115const GRState* BasicConstraintManager::AssumeAux(const GRState* St, Loc Cond,
Zhongxing Xu30ad1672008-08-27 14:03:33 +0000116 bool Assumption, bool& isFeasible) {
117 BasicValueFactory& BasicVals = StateMgr.getBasicVals();
118
119 switch (Cond.getSubKind()) {
120 default:
Zhongxing Xu1c96b242008-10-17 05:57:07 +0000121 assert (false && "'Assume' not implemented for this Loc.");
Zhongxing Xu30ad1672008-08-27 14:03:33 +0000122 return St;
123
Zhongxing Xu1c96b242008-10-17 05:57:07 +0000124 case loc::SymbolValKind:
Zhongxing Xu30ad1672008-08-27 14:03:33 +0000125 if (Assumption)
Zhongxing Xu1c96b242008-10-17 05:57:07 +0000126 return AssumeSymNE(St, cast<loc::SymbolVal>(Cond).getSymbol(),
Zhongxing Xu30ad1672008-08-27 14:03:33 +0000127 BasicVals.getZeroWithPtrWidth(), isFeasible);
128 else
Zhongxing Xu1c96b242008-10-17 05:57:07 +0000129 return AssumeSymEQ(St, cast<loc::SymbolVal>(Cond).getSymbol(),
Zhongxing Xu30ad1672008-08-27 14:03:33 +0000130 BasicVals.getZeroWithPtrWidth(), isFeasible);
131
Ted Kremenekc5234712008-10-17 21:22:20 +0000132 case loc::MemRegionKind: {
133 // FIXME: Should this go into the storemanager?
134
135 const MemRegion* R = cast<loc::MemRegionVal>(Cond).getRegion();
136
137 while (R) {
138 if (const SubRegion* SubR = dyn_cast<SubRegion>(R)) {
139 R = SubR->getSuperRegion();
140 continue;
141 }
142 else if (const SymbolicRegion* SymR = dyn_cast<SymbolicRegion>(R))
143 return AssumeAux(St, loc::SymbolVal(SymR->getSymbol()), Assumption,
144 isFeasible);
145
146 break;
147 }
148
149 // FALL-THROUGH.
150 }
151
Zhongxing Xu1c96b242008-10-17 05:57:07 +0000152 case loc::FuncValKind:
153 case loc::GotoLabelKind:
154 case loc::StringLiteralValKind:
Zhongxing Xu30ad1672008-08-27 14:03:33 +0000155 isFeasible = Assumption;
156 return St;
157
Zhongxing Xu1c96b242008-10-17 05:57:07 +0000158 case loc::ConcreteIntKind: {
159 bool b = cast<loc::ConcreteInt>(Cond).getValue() != 0;
Zhongxing Xu30ad1672008-08-27 14:03:33 +0000160 isFeasible = b ? Assumption : !Assumption;
161 return St;
162 }
163 } // end switch
164}
165
166const GRState*
Zhongxing Xu1c96b242008-10-17 05:57:07 +0000167BasicConstraintManager::Assume(const GRState* St, NonLoc Cond, bool Assumption,
Zhongxing Xu30ad1672008-08-27 14:03:33 +0000168 bool& isFeasible) {
169 St = AssumeAux(St, Cond, Assumption, isFeasible);
170 // TF->EvalAssume() does nothing now.
171 return St;
172}
173
174const GRState*
Zhongxing Xu1c96b242008-10-17 05:57:07 +0000175BasicConstraintManager::AssumeAux(const GRState* St,NonLoc Cond,
Zhongxing Xu30ad1672008-08-27 14:03:33 +0000176 bool Assumption, bool& isFeasible) {
177 BasicValueFactory& BasicVals = StateMgr.getBasicVals();
178 SymbolManager& SymMgr = StateMgr.getSymbolManager();
179
180 switch (Cond.getSubKind()) {
181 default:
Zhongxing Xu1c96b242008-10-17 05:57:07 +0000182 assert(false && "'Assume' not implemented for this NonLoc");
Zhongxing Xu30ad1672008-08-27 14:03:33 +0000183
Zhongxing Xu1c96b242008-10-17 05:57:07 +0000184 case nonloc::SymbolValKind: {
185 nonloc::SymbolVal& SV = cast<nonloc::SymbolVal>(Cond);
Zhongxing Xu30ad1672008-08-27 14:03:33 +0000186 SymbolID sym = SV.getSymbol();
187
188 if (Assumption)
189 return AssumeSymNE(St, sym, BasicVals.getValue(0, SymMgr.getType(sym)),
190 isFeasible);
191 else
192 return AssumeSymEQ(St, sym, BasicVals.getValue(0, SymMgr.getType(sym)),
193 isFeasible);
194 }
195
Zhongxing Xu1c96b242008-10-17 05:57:07 +0000196 case nonloc::SymIntConstraintValKind:
Zhongxing Xu30ad1672008-08-27 14:03:33 +0000197 return
198 AssumeSymInt(St, Assumption,
Zhongxing Xu1c96b242008-10-17 05:57:07 +0000199 cast<nonloc::SymIntConstraintVal>(Cond).getConstraint(),
Zhongxing Xu30ad1672008-08-27 14:03:33 +0000200 isFeasible);
201
Zhongxing Xu1c96b242008-10-17 05:57:07 +0000202 case nonloc::ConcreteIntKind: {
203 bool b = cast<nonloc::ConcreteInt>(Cond).getValue() != 0;
Zhongxing Xu30ad1672008-08-27 14:03:33 +0000204 isFeasible = b ? Assumption : !Assumption;
205 return St;
206 }
207
Zhongxing Xu1c96b242008-10-17 05:57:07 +0000208 case nonloc::LocAsIntegerKind:
209 return AssumeAux(St, cast<nonloc::LocAsInteger>(Cond).getLoc(),
Zhongxing Xu30ad1672008-08-27 14:03:33 +0000210 Assumption, isFeasible);
211 } // end switch
212}
213
214const GRState*
215BasicConstraintManager::AssumeSymInt(const GRState* St, bool Assumption,
216 const SymIntConstraint& C, bool& isFeasible) {
217
218 switch (C.getOpcode()) {
219 default:
220 // No logic yet for other operators.
221 isFeasible = true;
222 return St;
223
224 case BinaryOperator::EQ:
225 if (Assumption)
226 return AssumeSymEQ(St, C.getSymbol(), C.getInt(), isFeasible);
227 else
228 return AssumeSymNE(St, C.getSymbol(), C.getInt(), isFeasible);
229
230 case BinaryOperator::NE:
231 if (Assumption)
232 return AssumeSymNE(St, C.getSymbol(), C.getInt(), isFeasible);
233 else
234 return AssumeSymEQ(St, C.getSymbol(), C.getInt(), isFeasible);
235
Zhongxing Xu94b83122008-09-19 06:07:59 +0000236 case BinaryOperator::GT:
237 if (Assumption)
238 return AssumeSymGT(St, C.getSymbol(), C.getInt(), isFeasible);
239 else
240 return AssumeSymLE(St, C.getSymbol(), C.getInt(), isFeasible);
241
Zhongxing Xu30ad1672008-08-27 14:03:33 +0000242 case BinaryOperator::GE:
243 if (Assumption)
244 return AssumeSymGE(St, C.getSymbol(), C.getInt(), isFeasible);
245 else
246 return AssumeSymLT(St, C.getSymbol(), C.getInt(), isFeasible);
247
Ted Kremenek8c3e7fb2008-09-16 23:24:45 +0000248 case BinaryOperator::LT:
249 if (Assumption)
250 return AssumeSymLT(St, C.getSymbol(), C.getInt(), isFeasible);
251 else
252 return AssumeSymGE(St, C.getSymbol(), C.getInt(), isFeasible);
253
Zhongxing Xu30ad1672008-08-27 14:03:33 +0000254 case BinaryOperator::LE:
255 if (Assumption)
256 return AssumeSymLE(St, C.getSymbol(), C.getInt(), isFeasible);
257 else
258 return AssumeSymGT(St, C.getSymbol(), C.getInt(), isFeasible);
259 } // end switch
260}
261
Zhongxing Xu39cfed32008-08-29 14:52:36 +0000262
263
Zhongxing Xu30ad1672008-08-27 14:03:33 +0000264const GRState*
265BasicConstraintManager::AssumeSymNE(const GRState* St, SymbolID sym,
266 const llvm::APSInt& V, bool& isFeasible) {
267 // First, determine if sym == X, where X != V.
Zhongxing Xu39cfed32008-08-29 14:52:36 +0000268 if (const llvm::APSInt* X = getSymVal(St, sym)) {
Zhongxing Xu30ad1672008-08-27 14:03:33 +0000269 isFeasible = (*X != V);
270 return St;
271 }
272
273 // Second, determine if sym != V.
Zhongxing Xu39cfed32008-08-29 14:52:36 +0000274 if (isNotEqual(St, sym, V)) {
Zhongxing Xu30ad1672008-08-27 14:03:33 +0000275 isFeasible = true;
276 return St;
277 }
278
279 // If we reach here, sym is not a constant and we don't know if it is != V.
280 // Make that assumption.
281 isFeasible = true;
Zhongxing Xu39cfed32008-08-29 14:52:36 +0000282 return AddNE(St, sym, V);
Zhongxing Xu30ad1672008-08-27 14:03:33 +0000283}
284
285const GRState*
286BasicConstraintManager::AssumeSymEQ(const GRState* St, SymbolID sym,
287 const llvm::APSInt& V, bool& isFeasible) {
288 // First, determine if sym == X, where X != V.
Zhongxing Xu39cfed32008-08-29 14:52:36 +0000289 if (const llvm::APSInt* X = getSymVal(St, sym)) {
Zhongxing Xu30ad1672008-08-27 14:03:33 +0000290 isFeasible = *X == V;
291 return St;
292 }
293
294 // Second, determine if sym != V.
Zhongxing Xu39cfed32008-08-29 14:52:36 +0000295 if (isNotEqual(St, sym, V)) {
Zhongxing Xu30ad1672008-08-27 14:03:33 +0000296 isFeasible = false;
297 return St;
298 }
299
300 // If we reach here, sym is not a constant and we don't know if it is == V.
301 // Make that assumption.
302
303 isFeasible = true;
Zhongxing Xu39cfed32008-08-29 14:52:36 +0000304 return AddEQ(St, sym, V);
Zhongxing Xu30ad1672008-08-27 14:03:33 +0000305}
306
307// These logic will be handled in another ConstraintManager.
308const GRState*
309BasicConstraintManager::AssumeSymLT(const GRState* St, SymbolID sym,
310 const llvm::APSInt& V, bool& isFeasible) {
311
312 // FIXME: For now have assuming x < y be the same as assuming sym != V;
313 return AssumeSymNE(St, sym, V, isFeasible);
314}
315
316const GRState*
317BasicConstraintManager::AssumeSymGT(const GRState* St, SymbolID sym,
318 const llvm::APSInt& V, bool& isFeasible) {
319
320 // FIXME: For now have assuming x > y be the same as assuming sym != V;
321 return AssumeSymNE(St, sym, V, isFeasible);
322}
323
324const GRState*
325BasicConstraintManager::AssumeSymGE(const GRState* St, SymbolID sym,
326 const llvm::APSInt& V, bool& isFeasible) {
327
Ted Kremenek8c3e7fb2008-09-16 23:24:45 +0000328 // Reject a path if the value of sym is a constant X and !(X >= V).
Zhongxing Xu39cfed32008-08-29 14:52:36 +0000329 if (const llvm::APSInt* X = getSymVal(St, sym)) {
Zhongxing Xu30ad1672008-08-27 14:03:33 +0000330 isFeasible = *X >= V;
331 return St;
332 }
333
Ted Kremenek0a41e5a2008-09-19 18:00:36 +0000334 isFeasible = !isNotEqual(St, sym, V) ||
335 (V != llvm::APSInt::getMaxValue(V.getBitWidth(), V.isSigned()));
336
Zhongxing Xu30ad1672008-08-27 14:03:33 +0000337 return St;
338}
339
340const GRState*
341BasicConstraintManager::AssumeSymLE(const GRState* St, SymbolID sym,
342 const llvm::APSInt& V, bool& isFeasible) {
343
344 // FIXME: Primitive logic for now. Only reject a path if the value of
345 // sym is a constant X and !(X <= V).
346
Zhongxing Xu39cfed32008-08-29 14:52:36 +0000347 if (const llvm::APSInt* X = getSymVal(St, sym)) {
Zhongxing Xu30ad1672008-08-27 14:03:33 +0000348 isFeasible = *X <= V;
349 return St;
350 }
Ted Kremenek0a41e5a2008-09-19 18:00:36 +0000351
352 isFeasible = !isNotEqual(St, sym, V) ||
353 (V != llvm::APSInt::getMinValue(V.getBitWidth(), V.isSigned()));
354
Zhongxing Xu30ad1672008-08-27 14:03:33 +0000355 return St;
356}
Zhongxing Xu39cfed32008-08-29 14:52:36 +0000357
358static int ConstEqTyIndex = 0;
359static int ConstNotEqTyIndex = 0;
360
361namespace clang {
362 template<>
363 struct GRStateTrait<ConstNotEqTy> : public GRStatePartialTrait<ConstNotEqTy> {
364 static inline void* GDMIndex() { return &ConstNotEqTyIndex; }
365 };
366
367 template<>
368 struct GRStateTrait<ConstEqTy> : public GRStatePartialTrait<ConstEqTy> {
369 static inline void* GDMIndex() { return &ConstEqTyIndex; }
370 };
371}
372
373const GRState* BasicConstraintManager::AddEQ(const GRState* St, SymbolID sym,
374 const llvm::APSInt& V) {
375 // Create a new state with the old binding replaced.
376 GRStateRef state(St, StateMgr);
377 return state.set<ConstEqTy>(sym, &V);
378}
379
380const GRState* BasicConstraintManager::AddNE(const GRState* St, SymbolID sym,
381 const llvm::APSInt& V) {
382 GRState::IntSetTy::Factory ISetFactory(StateMgr.getAllocator());
383 GRStateRef state(St, StateMgr);
384
385 // First, retrieve the NE-set associated with the given symbol.
386 ConstNotEqTy::data_type* T = state.get<ConstNotEqTy>(sym);
387 GRState::IntSetTy S = T ? *T : ISetFactory.GetEmptySet();
388
389
390 // Now add V to the NE set.
391 S = ISetFactory.Add(S, &V);
392
393 // Create a new state with the old binding replaced.
394 return state.set<ConstNotEqTy>(sym, S);
395}
396
397const llvm::APSInt* BasicConstraintManager::getSymVal(const GRState* St,
398 SymbolID sym) {
399 const ConstEqTy::data_type* T = St->get<ConstEqTy>(sym);
400 return T ? *T : NULL;
401}
402
403bool BasicConstraintManager::isNotEqual(const GRState* St, SymbolID sym,
404 const llvm::APSInt& V) const {
405
406 // Retrieve the NE-set associated with the given symbol.
407 const ConstNotEqTy::data_type* T = St->get<ConstNotEqTy>(sym);
408
409 // See if V is present in the NE-set.
410 return T ? T->contains(&V) : false;
411}
412
413bool BasicConstraintManager::isEqual(const GRState* St, SymbolID sym,
414 const llvm::APSInt& V) const {
415 // Retrieve the EQ-set associated with the given symbol.
416 const ConstEqTy::data_type* T = St->get<ConstEqTy>(sym);
417 // See if V is present in the EQ-set.
418 return T ? **T == V : false;
419}
420
421const GRState* BasicConstraintManager::RemoveDeadBindings(const GRState* St,
422 StoreManager::LiveSymbolsTy& LSymbols,
423 StoreManager::DeadSymbolsTy& DSymbols) {
424 GRStateRef state(St, StateMgr);
425 ConstEqTy CE = state.get<ConstEqTy>();
426 ConstEqTy::Factory& CEFactory = state.get_context<ConstEqTy>();
427
428 for (ConstEqTy::iterator I = CE.begin(), E = CE.end(); I!=E; ++I) {
429 SymbolID sym = I.getKey();
430 if (!LSymbols.count(sym)) {
431 DSymbols.insert(sym);
432 CE = CEFactory.Remove(CE, sym);
433 }
434 }
435 state = state.set<ConstEqTy>(CE);
436
437 ConstNotEqTy CNE = state.get<ConstNotEqTy>();
438 ConstNotEqTy::Factory& CNEFactory = state.get_context<ConstNotEqTy>();
439
440 for (ConstNotEqTy::iterator I = CNE.begin(), E = CNE.end(); I != E; ++I) {
441 SymbolID sym = I.getKey();
442 if (!LSymbols.count(sym)) {
443 DSymbols.insert(sym);
444 CNE = CNEFactory.Remove(CNE, sym);
445 }
446 }
447
448 return state.set<ConstNotEqTy>(CNE);
449}
450
451void BasicConstraintManager::print(const GRState* St, std::ostream& Out,
452 const char* nl, const char *sep) {
453 // Print equality constraints.
454
455 ConstEqTy CE = St->get<ConstEqTy>();
456
457 if (!CE.isEmpty()) {
458 Out << nl << sep << "'==' constraints:";
459
460 for (ConstEqTy::iterator I = CE.begin(), E = CE.end(); I!=E; ++I) {
461 Out << nl << " $" << I.getKey();
462 llvm::raw_os_ostream OS(Out);
463 OS << " : " << *I.getData();
464 }
465 }
466
467 // Print != constraints.
468
469 ConstNotEqTy CNE = St->get<ConstNotEqTy>();
470
471 if (!CNE.isEmpty()) {
472 Out << nl << sep << "'!=' constraints:";
473
474 for (ConstNotEqTy::iterator I = CNE.begin(), EI = CNE.end(); I!=EI; ++I) {
475 Out << nl << " $" << I.getKey() << " : ";
476 bool isFirst = true;
477
478 GRState::IntSetTy::iterator J = I.getData().begin(),
479 EJ = I.getData().end();
480
481 for ( ; J != EJ; ++J) {
482 if (isFirst) isFirst = false;
483 else Out << ", ";
484
485 Out << *J;
486 }
487 }
488 }
Daniel Dunbar0e194dd2008-08-30 02:06:22 +0000489}