blob: ea7d971fdb809cf0eabb6f93070485b92df33135 [file] [log] [blame]
Zhongxing Xu8958fff2009-11-03 06:46:03 +00001//===--- UndefinedArgChecker.h - Undefined arguments checker ----*- C++ -*--==//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This defines BadCallChecker, a builtin check in GRExprEngine that performs
11// checks for undefined arguments.
12//
13//===----------------------------------------------------------------------===//
14
Ted Kremenekf493f492009-11-11 05:50:44 +000015#include "clang/Analysis/PathSensitive/CheckerVisitor.h"
Zhongxing Xu8958fff2009-11-03 06:46:03 +000016#include "clang/Analysis/PathSensitive/BugReporter.h"
Ted Kremenekf493f492009-11-11 05:50:44 +000017#include "GRExprEngineInternalChecks.h"
Zhongxing Xu8958fff2009-11-03 06:46:03 +000018
19using namespace clang;
20
Ted Kremenekf493f492009-11-11 05:50:44 +000021namespace {
22class VISIBILITY_HIDDEN UndefinedArgChecker
23 : public CheckerVisitor<UndefinedArgChecker> {
Ted Kremenekc79d7d42009-11-21 01:25:37 +000024 BugType *BT_call_null;
25 BugType *BT_call_undef;
26 BugType *BT_call_arg;
27 BugType *BT_msg_undef;
28 BugType *BT_msg_arg;
Ted Kremenekf493f492009-11-11 05:50:44 +000029public:
Ted Kremenekc79d7d42009-11-21 01:25:37 +000030 UndefinedArgChecker() :
31 BT_call_null(0), BT_call_undef(0), BT_call_arg(0),
32 BT_msg_undef(0), BT_msg_arg(0) {}
Ted Kremenekf493f492009-11-11 05:50:44 +000033 static void *getTag() {
34 static int x = 0;
35 return &x;
36 }
37 void PreVisitCallExpr(CheckerContext &C, const CallExpr *CE);
Ted Kremenek64fa8582009-11-21 00:49:41 +000038 void PreVisitObjCMessageExpr(CheckerContext &C, const ObjCMessageExpr *ME);
Ted Kremenekc79d7d42009-11-21 01:25:37 +000039private:
40 void EmitBadCall(BugType *BT, CheckerContext &C, const CallExpr *CE);
Ted Kremenekf493f492009-11-11 05:50:44 +000041};
42} // end anonymous namespace
43
44void clang::RegisterUndefinedArgChecker(GRExprEngine &Eng) {
45 Eng.registerCheck(new UndefinedArgChecker());
Zhongxing Xu8958fff2009-11-03 06:46:03 +000046}
47
Ted Kremenekc79d7d42009-11-21 01:25:37 +000048void UndefinedArgChecker::EmitBadCall(BugType *BT, CheckerContext &C,
49 const CallExpr *CE) {
50 ExplodedNode *N = C.GenerateNode(CE, true);
51 if (!N)
52 return;
53
54 EnhancedBugReport *R = new EnhancedBugReport(*BT, BT->getName(), N);
55 R->addVisitorCreator(bugreporter::registerTrackNullOrUndefValue,
56 bugreporter::GetCalleeExpr(N));
57 C.EmitReport(R);
58}
59
Zhongxing Xu8958fff2009-11-03 06:46:03 +000060void UndefinedArgChecker::PreVisitCallExpr(CheckerContext &C,
61 const CallExpr *CE){
Ted Kremenekc79d7d42009-11-21 01:25:37 +000062
63 const Expr *Callee = CE->getCallee()->IgnoreParens();
64 SVal L = C.getState()->getSVal(Callee);
65
66 if (L.isUndef()) {
67 if (!BT_call_undef)
68 BT_call_undef =
69 new BuiltinBug("Called function pointer is an undefined pointer value");
70 EmitBadCall(BT_call_undef, C, CE);
71 return;
72 }
73
74 if (isa<loc::ConcreteInt>(L)) {
75 if (!BT_call_null)
76 BT_call_null =
77 new BuiltinBug("Called function pointer is null (null dereference)");
78 EmitBadCall(BT_call_null, C, CE);
79 }
80
Zhongxing Xu8958fff2009-11-03 06:46:03 +000081 for (CallExpr::const_arg_iterator I = CE->arg_begin(), E = CE->arg_end();
82 I != E; ++I) {
83 if (C.getState()->getSVal(*I).isUndef()) {
84 if (ExplodedNode *N = C.GenerateNode(CE, true)) {
Ted Kremenekc79d7d42009-11-21 01:25:37 +000085 if (!BT_call_arg)
86 BT_call_arg = new BuiltinBug("Pass-by-value argument in function call"
87 " is undefined");
Zhongxing Xu8958fff2009-11-03 06:46:03 +000088 // Generate a report for this bug.
Ted Kremenekc79d7d42009-11-21 01:25:37 +000089 EnhancedBugReport *R = new EnhancedBugReport(*BT_call_arg,
90 BT_call_arg->getName(), N);
Zhongxing Xu8958fff2009-11-03 06:46:03 +000091 R->addRange((*I)->getSourceRange());
92 R->addVisitorCreator(bugreporter::registerTrackNullOrUndefValue, *I);
93 C.EmitReport(R);
Ted Kremenek64fa8582009-11-21 00:49:41 +000094 return;
95 }
96 }
97 }
98}
99
100void UndefinedArgChecker::PreVisitObjCMessageExpr(CheckerContext &C,
101 const ObjCMessageExpr *ME) {
102
Ted Kremenek64fa8582009-11-21 00:49:41 +0000103 const GRState *state = C.getState();
Ted Kremenekc79d7d42009-11-21 01:25:37 +0000104
105 if (const Expr *receiver = ME->getReceiver())
106 if (state->getSVal(receiver).isUndef()) {
107 if (ExplodedNode *N = C.GenerateNode(ME, true)) {
108 if (!BT_msg_undef)
109 BT_msg_undef =
110 new BuiltinBug("Receiver in message expression is a garbage value");
111 EnhancedBugReport *R =
112 new EnhancedBugReport(*BT_msg_undef, BT_msg_undef->getName(), N);
113 R->addRange(receiver->getSourceRange());
114 R->addVisitorCreator(bugreporter::registerTrackNullOrUndefValue,
115 receiver);
116 C.EmitReport(R);
117 }
118 return;
119 }
120
121 // Check for any arguments that are uninitialized/undefined.
Ted Kremenek64fa8582009-11-21 00:49:41 +0000122 for (ObjCMessageExpr::const_arg_iterator I = ME->arg_begin(), E = ME->arg_end();
123 I != E; ++I) {
124 if (state->getSVal(*I).isUndef()) {
125 if (ExplodedNode *N = C.GenerateNode(ME, true)) {
Ted Kremenekc79d7d42009-11-21 01:25:37 +0000126 if (!BT_msg_arg)
127 BT_msg_arg =
128 new BuiltinBug("Pass-by-value argument in message expression"
129 " is undefined");
Ted Kremenek64fa8582009-11-21 00:49:41 +0000130 // Generate a report for this bug.
Ted Kremenekc79d7d42009-11-21 01:25:37 +0000131 EnhancedBugReport *R = new EnhancedBugReport(*BT_msg_arg,
132 BT_msg_arg->getName(), N);
Ted Kremenek64fa8582009-11-21 00:49:41 +0000133 R->addRange((*I)->getSourceRange());
134 R->addVisitorCreator(bugreporter::registerTrackNullOrUndefValue, *I);
135 C.EmitReport(R);
136 return;
Zhongxing Xu8958fff2009-11-03 06:46:03 +0000137 }
138 }
139 }
140}