Chris Lattner | be1a7a0 | 2008-03-15 23:59:48 +0000 | [diff] [blame] | 1 | // CFRefCount.cpp - Transfer functions for tracking simple values -*- C++ -*--// |
Ted Kremenek | 827f93b | 2008-03-06 00:08:09 +0000 | [diff] [blame] | 2 | // |
| 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
| 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
| 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
| 9 | // |
Gabor Greif | 2224fcb | 2008-03-06 10:40:09 +0000 | [diff] [blame] | 10 | // This file defines the methods for CFRefCount, which implements |
Ted Kremenek | 827f93b | 2008-03-06 00:08:09 +0000 | [diff] [blame] | 11 | // a reference count checker for Core Foundation (Mac OS X). |
| 12 | // |
| 13 | //===----------------------------------------------------------------------===// |
| 14 | |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 15 | #include "GRSimpleVals.h" |
Ted Kremenek | 827f93b | 2008-03-06 00:08:09 +0000 | [diff] [blame] | 16 | #include "clang/Analysis/PathSensitive/ValueState.h" |
Ted Kremenek | dd0126b | 2008-03-31 18:26:32 +0000 | [diff] [blame] | 17 | #include "clang/Analysis/PathDiagnostic.h" |
Ted Kremenek | 827f93b | 2008-03-06 00:08:09 +0000 | [diff] [blame] | 18 | #include "clang/Analysis/LocalCheckers.h" |
Ted Kremenek | 10fe66d | 2008-04-09 01:10:13 +0000 | [diff] [blame] | 19 | #include "clang/Analysis/PathDiagnostic.h" |
| 20 | #include "clang/Analysis/PathSensitive/BugReporter.h" |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 21 | #include "llvm/ADT/DenseMap.h" |
| 22 | #include "llvm/ADT/FoldingSet.h" |
| 23 | #include "llvm/ADT/ImmutableMap.h" |
Ted Kremenek | 10fe66d | 2008-04-09 01:10:13 +0000 | [diff] [blame] | 24 | #include "llvm/Support/Compiler.h" |
Ted Kremenek | 3b11f7a | 2008-03-11 19:44:10 +0000 | [diff] [blame] | 25 | #include <ostream> |
Ted Kremenek | 827f93b | 2008-03-06 00:08:09 +0000 | [diff] [blame] | 26 | |
| 27 | using namespace clang; |
| 28 | |
Ted Kremenek | 7d421f3 | 2008-04-09 23:49:11 +0000 | [diff] [blame] | 29 | //===----------------------------------------------------------------------===// |
Ted Kremenek | d9ccf68 | 2008-04-17 18:12:53 +0000 | [diff] [blame^] | 30 | // Utility functions. |
| 31 | //===----------------------------------------------------------------------===// |
| 32 | |
| 33 | static inline Selector GetUnarySelector(const char* name, ASTContext& Ctx) { |
| 34 | IdentifierInfo* II = &Ctx.Idents.get(name); |
| 35 | return Ctx.Selectors.getSelector(0, &II); |
| 36 | } |
| 37 | |
| 38 | //===----------------------------------------------------------------------===// |
Ted Kremenek | 7d421f3 | 2008-04-09 23:49:11 +0000 | [diff] [blame] | 39 | // Symbolic Evaluation of Reference Counting Logic |
| 40 | //===----------------------------------------------------------------------===// |
| 41 | |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 42 | namespace { |
| 43 | enum ArgEffect { IncRef, DecRef, DoNothing }; |
| 44 | typedef std::vector<ArgEffect> ArgEffects; |
| 45 | } |
Ted Kremenek | 827f93b | 2008-03-06 00:08:09 +0000 | [diff] [blame] | 46 | |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 47 | namespace llvm { |
| 48 | template <> struct FoldingSetTrait<ArgEffects> { |
Ted Kremenek | a4c7429 | 2008-04-10 22:58:08 +0000 | [diff] [blame] | 49 | static void Profile(const ArgEffects& X, FoldingSetNodeID& ID) { |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 50 | for (ArgEffects::const_iterator I = X.begin(), E = X.end(); I!= E; ++I) |
| 51 | ID.AddInteger((unsigned) *I); |
Ted Kremenek | a4c7429 | 2008-04-10 22:58:08 +0000 | [diff] [blame] | 52 | } |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 53 | }; |
| 54 | } // end llvm namespace |
| 55 | |
| 56 | namespace { |
Ted Kremenek | 827f93b | 2008-03-06 00:08:09 +0000 | [diff] [blame] | 57 | |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 58 | class RetEffect { |
| 59 | public: |
Ted Kremenek | ab2fa2a | 2008-04-10 23:44:06 +0000 | [diff] [blame] | 60 | enum Kind { NoRet = 0x0, Alias = 0x1, OwnedSymbol = 0x2, |
| 61 | NotOwnedSymbol = 0x3 }; |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 62 | |
| 63 | private: |
| 64 | unsigned Data; |
Ted Kremenek | a4c7429 | 2008-04-10 22:58:08 +0000 | [diff] [blame] | 65 | RetEffect(Kind k, unsigned D) { Data = (D << 2) | (unsigned) k; } |
Ted Kremenek | 827f93b | 2008-03-06 00:08:09 +0000 | [diff] [blame] | 66 | |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 67 | public: |
| 68 | |
| 69 | Kind getKind() const { return (Kind) (Data & 0x3); } |
| 70 | |
| 71 | unsigned getValue() const { |
| 72 | assert(getKind() == Alias); |
Ted Kremenek | a4c7429 | 2008-04-10 22:58:08 +0000 | [diff] [blame] | 73 | return Data >> 2; |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 74 | } |
Ted Kremenek | ffefc35 | 2008-04-11 22:25:11 +0000 | [diff] [blame] | 75 | |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 76 | static RetEffect MakeAlias(unsigned Idx) { return RetEffect(Alias, Idx); } |
Ted Kremenek | 827f93b | 2008-03-06 00:08:09 +0000 | [diff] [blame] | 77 | |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 78 | static RetEffect MakeOwned() { return RetEffect(OwnedSymbol, 0); } |
Ted Kremenek | 827f93b | 2008-03-06 00:08:09 +0000 | [diff] [blame] | 79 | |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 80 | static RetEffect MakeNotOwned() { return RetEffect(NotOwnedSymbol, 0); } |
| 81 | |
Ted Kremenek | ab2fa2a | 2008-04-10 23:44:06 +0000 | [diff] [blame] | 82 | static RetEffect MakeNoRet() { return RetEffect(NoRet, 0); } |
| 83 | |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 84 | operator Kind() const { return getKind(); } |
| 85 | |
| 86 | void Profile(llvm::FoldingSetNodeID& ID) const { ID.AddInteger(Data); } |
| 87 | }; |
| 88 | |
| 89 | |
| 90 | class CFRefSummary : public llvm::FoldingSetNode { |
| 91 | ArgEffects* Args; |
| 92 | RetEffect Ret; |
| 93 | public: |
| 94 | |
| 95 | CFRefSummary(ArgEffects* A, RetEffect R) : Args(A), Ret(R) {} |
| 96 | |
| 97 | unsigned getNumArgs() const { return Args->size(); } |
| 98 | |
Ted Kremenek | 0d72157 | 2008-03-11 17:48:22 +0000 | [diff] [blame] | 99 | ArgEffect getArg(unsigned idx) const { |
| 100 | assert (idx < getNumArgs()); |
| 101 | return (*Args)[idx]; |
| 102 | } |
| 103 | |
Ted Kremenek | ce3ed1e | 2008-03-12 01:21:45 +0000 | [diff] [blame] | 104 | RetEffect getRet() const { |
| 105 | return Ret; |
| 106 | } |
| 107 | |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 108 | typedef ArgEffects::const_iterator arg_iterator; |
| 109 | |
| 110 | arg_iterator begin_args() const { return Args->begin(); } |
| 111 | arg_iterator end_args() const { return Args->end(); } |
| 112 | |
| 113 | static void Profile(llvm::FoldingSetNodeID& ID, ArgEffects* A, RetEffect R) { |
| 114 | ID.AddPointer(A); |
| 115 | ID.Add(R); |
| 116 | } |
| 117 | |
| 118 | void Profile(llvm::FoldingSetNodeID& ID) const { |
| 119 | Profile(ID, Args, Ret); |
| 120 | } |
| 121 | }; |
| 122 | |
| 123 | |
| 124 | class CFRefSummaryManager { |
| 125 | typedef llvm::FoldingSet<llvm::FoldingSetNodeWrapper<ArgEffects> > AESetTy; |
| 126 | typedef llvm::FoldingSet<CFRefSummary> SummarySetTy; |
| 127 | typedef llvm::DenseMap<FunctionDecl*, CFRefSummary*> SummaryMapTy; |
| 128 | |
Ted Kremenek | a4c7429 | 2008-04-10 22:58:08 +0000 | [diff] [blame] | 129 | ASTContext& Ctx; |
| 130 | SummarySetTy SummarySet; |
| 131 | SummaryMapTy SummaryMap; |
| 132 | AESetTy AESet; |
| 133 | llvm::BumpPtrAllocator BPAlloc; |
| 134 | ArgEffects ScratchArgs; |
Ted Kremenek | ce3ed1e | 2008-03-12 01:21:45 +0000 | [diff] [blame] | 135 | |
| 136 | |
| 137 | ArgEffects* getArgEffects(); |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 138 | |
Ted Kremenek | ce3ed1e | 2008-03-12 01:21:45 +0000 | [diff] [blame] | 139 | CFRefSummary* getCannedCFSummary(FunctionTypeProto* FT, bool isRetain); |
| 140 | |
| 141 | CFRefSummary* getCFSummary(FunctionDecl* FD, const char* FName); |
| 142 | |
| 143 | CFRefSummary* getCFSummaryCreateRule(FunctionTypeProto* FT); |
| 144 | CFRefSummary* getCFSummaryGetRule(FunctionTypeProto* FT); |
| 145 | |
| 146 | CFRefSummary* getPersistentSummary(ArgEffects* AE, RetEffect RE); |
| 147 | |
Ted Kremenek | ab2fa2a | 2008-04-10 23:44:06 +0000 | [diff] [blame] | 148 | void FillDoNothing(unsigned Args); |
| 149 | |
| 150 | |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 151 | public: |
Ted Kremenek | a4c7429 | 2008-04-10 22:58:08 +0000 | [diff] [blame] | 152 | CFRefSummaryManager(ASTContext& ctx) : Ctx(ctx) {} |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 153 | ~CFRefSummaryManager(); |
| 154 | |
Ted Kremenek | ce3ed1e | 2008-03-12 01:21:45 +0000 | [diff] [blame] | 155 | CFRefSummary* getSummary(FunctionDecl* FD, ASTContext& Ctx); |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 156 | }; |
| 157 | |
| 158 | } // end anonymous namespace |
| 159 | |
| 160 | //===----------------------------------------------------------------------===// |
| 161 | // Implementation of checker data structures. |
| 162 | //===----------------------------------------------------------------------===// |
| 163 | |
| 164 | CFRefSummaryManager::~CFRefSummaryManager() { |
| 165 | |
| 166 | // FIXME: The ArgEffects could eventually be allocated from BPAlloc, |
| 167 | // mitigating the need to do explicit cleanup of the |
| 168 | // Argument-Effect summaries. |
| 169 | |
| 170 | for (AESetTy::iterator I = AESet.begin(), E = AESet.end(); I!=E; ++I) |
| 171 | I->getValue().~ArgEffects(); |
Ted Kremenek | 827f93b | 2008-03-06 00:08:09 +0000 | [diff] [blame] | 172 | } |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 173 | |
Ted Kremenek | ce3ed1e | 2008-03-12 01:21:45 +0000 | [diff] [blame] | 174 | ArgEffects* CFRefSummaryManager::getArgEffects() { |
| 175 | |
Ted Kremenek | ce3ed1e | 2008-03-12 01:21:45 +0000 | [diff] [blame] | 176 | llvm::FoldingSetNodeID profile; |
| 177 | profile.Add(ScratchArgs); |
| 178 | void* InsertPos; |
| 179 | |
| 180 | llvm::FoldingSetNodeWrapper<ArgEffects>* E = |
| 181 | AESet.FindNodeOrInsertPos(profile, InsertPos); |
| 182 | |
| 183 | if (E) { |
| 184 | ScratchArgs.clear(); |
| 185 | return &E->getValue(); |
| 186 | } |
| 187 | |
| 188 | E = (llvm::FoldingSetNodeWrapper<ArgEffects>*) |
| 189 | BPAlloc.Allocate<llvm::FoldingSetNodeWrapper<ArgEffects> >(); |
| 190 | |
| 191 | new (E) llvm::FoldingSetNodeWrapper<ArgEffects>(ScratchArgs); |
| 192 | AESet.InsertNode(E, InsertPos); |
| 193 | |
| 194 | ScratchArgs.clear(); |
| 195 | return &E->getValue(); |
| 196 | } |
| 197 | |
| 198 | CFRefSummary* CFRefSummaryManager::getPersistentSummary(ArgEffects* AE, |
| 199 | RetEffect RE) { |
| 200 | |
| 201 | llvm::FoldingSetNodeID profile; |
| 202 | CFRefSummary::Profile(profile, AE, RE); |
| 203 | void* InsertPos; |
| 204 | |
| 205 | CFRefSummary* Summ = SummarySet.FindNodeOrInsertPos(profile, InsertPos); |
| 206 | |
| 207 | if (Summ) |
| 208 | return Summ; |
| 209 | |
| 210 | Summ = (CFRefSummary*) BPAlloc.Allocate<CFRefSummary>(); |
| 211 | new (Summ) CFRefSummary(AE, RE); |
| 212 | SummarySet.InsertNode(Summ, InsertPos); |
| 213 | |
| 214 | return Summ; |
| 215 | } |
| 216 | |
| 217 | |
| 218 | CFRefSummary* CFRefSummaryManager::getSummary(FunctionDecl* FD, |
| 219 | ASTContext& Ctx) { |
| 220 | |
| 221 | SourceLocation Loc = FD->getLocation(); |
| 222 | |
| 223 | if (!Loc.isFileID()) |
| 224 | return NULL; |
Ted Kremenek | 827f93b | 2008-03-06 00:08:09 +0000 | [diff] [blame] | 225 | |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 226 | { // Look into our cache of summaries to see if we have already computed |
| 227 | // a summary for this FunctionDecl. |
| 228 | |
| 229 | SummaryMapTy::iterator I = SummaryMap.find(FD); |
| 230 | |
| 231 | if (I != SummaryMap.end()) |
| 232 | return I->second; |
| 233 | } |
| 234 | |
Ted Kremenek | ce3ed1e | 2008-03-12 01:21:45 +0000 | [diff] [blame] | 235 | #if 0 |
| 236 | SourceManager& SrcMgr = Ctx.getSourceManager(); |
| 237 | unsigned fid = Loc.getFileID(); |
| 238 | const FileEntry* FE = SrcMgr.getFileEntryForID(fid); |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 239 | |
Ted Kremenek | ce3ed1e | 2008-03-12 01:21:45 +0000 | [diff] [blame] | 240 | if (!FE) |
| 241 | return NULL; |
| 242 | |
| 243 | const char* DirName = FE->getDir()->getName(); |
| 244 | assert (DirName); |
| 245 | assert (strlen(DirName) > 0); |
| 246 | |
| 247 | if (!strstr(DirName, "CoreFoundation")) { |
| 248 | SummaryMap[FD] = NULL; |
| 249 | return NULL; |
| 250 | } |
| 251 | #endif |
| 252 | |
| 253 | const char* FName = FD->getIdentifier()->getName(); |
| 254 | |
| 255 | if (FName[0] == 'C' && FName[1] == 'F') { |
| 256 | CFRefSummary* S = getCFSummary(FD, FName); |
| 257 | SummaryMap[FD] = S; |
| 258 | return S; |
| 259 | } |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 260 | |
| 261 | return NULL; |
Ted Kremenek | 827f93b | 2008-03-06 00:08:09 +0000 | [diff] [blame] | 262 | } |
| 263 | |
Ted Kremenek | ce3ed1e | 2008-03-12 01:21:45 +0000 | [diff] [blame] | 264 | CFRefSummary* CFRefSummaryManager::getCFSummary(FunctionDecl* FD, |
| 265 | const char* FName) { |
| 266 | |
| 267 | // For now, only generate summaries for functions that have a prototype. |
| 268 | |
| 269 | FunctionTypeProto* FT = |
| 270 | dyn_cast<FunctionTypeProto>(FD->getType().getTypePtr()); |
| 271 | |
| 272 | if (!FT) |
| 273 | return NULL; |
| 274 | |
| 275 | FName += 2; |
| 276 | |
| 277 | if (strcmp(FName, "Retain") == 0) |
| 278 | return getCannedCFSummary(FT, true); |
| 279 | |
| 280 | if (strcmp(FName, "Release") == 0) |
| 281 | return getCannedCFSummary(FT, false); |
| 282 | |
| 283 | assert (ScratchArgs.empty()); |
| 284 | bool usesCreateRule = false; |
| 285 | |
| 286 | if (strstr(FName, "Create")) |
| 287 | usesCreateRule = true; |
| 288 | |
| 289 | if (!usesCreateRule && strstr(FName, "Copy")) |
| 290 | usesCreateRule = true; |
| 291 | |
| 292 | if (usesCreateRule) |
| 293 | return getCFSummaryCreateRule(FT); |
| 294 | |
| 295 | if (strstr(FName, "Get")) |
| 296 | return getCFSummaryGetRule(FT); |
| 297 | |
| 298 | return NULL; |
| 299 | } |
| 300 | |
| 301 | CFRefSummary* CFRefSummaryManager::getCannedCFSummary(FunctionTypeProto* FT, |
| 302 | bool isRetain) { |
| 303 | |
| 304 | if (FT->getNumArgs() != 1) |
| 305 | return NULL; |
| 306 | |
| 307 | TypedefType* ArgT = dyn_cast<TypedefType>(FT->getArgType(0).getTypePtr()); |
| 308 | |
| 309 | if (!ArgT) |
| 310 | return NULL; |
| 311 | |
| 312 | // For CFRetain/CFRelease, the first (and only) argument is of type |
| 313 | // "CFTypeRef". |
| 314 | |
| 315 | const char* TDName = ArgT->getDecl()->getIdentifier()->getName(); |
| 316 | assert (TDName); |
| 317 | |
Ted Kremenek | a4c7429 | 2008-04-10 22:58:08 +0000 | [diff] [blame] | 318 | if (strcmp("CFTypeRef", TDName) != 0) |
Ted Kremenek | ce3ed1e | 2008-03-12 01:21:45 +0000 | [diff] [blame] | 319 | return NULL; |
| 320 | |
| 321 | if (!ArgT->isPointerType()) |
| 322 | return NULL; |
Ted Kremenek | a4c7429 | 2008-04-10 22:58:08 +0000 | [diff] [blame] | 323 | |
Ted Kremenek | ce3ed1e | 2008-03-12 01:21:45 +0000 | [diff] [blame] | 324 | QualType RetTy = FT->getResultType(); |
| 325 | |
Ted Kremenek | a4c7429 | 2008-04-10 22:58:08 +0000 | [diff] [blame] | 326 | if (isRetain) { |
| 327 | // CFRetain: the return type should also be "CFTypeRef". |
| 328 | if (RetTy.getTypePtr() != ArgT) |
| 329 | return NULL; |
Ted Kremenek | ab2fa2a | 2008-04-10 23:44:06 +0000 | [diff] [blame] | 330 | |
| 331 | // The function's interface checks out. Generate a canned summary. |
| 332 | assert (ScratchArgs.empty()); |
| 333 | ScratchArgs.push_back(IncRef); |
| 334 | return getPersistentSummary(getArgEffects(), RetEffect::MakeAlias(0)); |
Ted Kremenek | a4c7429 | 2008-04-10 22:58:08 +0000 | [diff] [blame] | 335 | } |
| 336 | else { |
| 337 | // CFRelease: the return type should be void. |
| 338 | |
| 339 | if (RetTy != Ctx.VoidTy) |
| 340 | return NULL; |
Ted Kremenek | a4c7429 | 2008-04-10 22:58:08 +0000 | [diff] [blame] | 341 | |
Ted Kremenek | ab2fa2a | 2008-04-10 23:44:06 +0000 | [diff] [blame] | 342 | assert (ScratchArgs.empty()); |
| 343 | ScratchArgs.push_back(DecRef); |
| 344 | return getPersistentSummary(getArgEffects(), RetEffect::MakeNoRet()); |
| 345 | } |
Ted Kremenek | ce3ed1e | 2008-03-12 01:21:45 +0000 | [diff] [blame] | 346 | } |
| 347 | |
| 348 | static bool isCFRefType(QualType T) { |
| 349 | |
| 350 | if (!T->isPointerType()) |
| 351 | return false; |
| 352 | |
| 353 | // Check the typedef for the name "CF" and the substring "Ref". |
| 354 | |
| 355 | TypedefType* TD = dyn_cast<TypedefType>(T.getTypePtr()); |
| 356 | |
| 357 | if (!TD) |
| 358 | return false; |
| 359 | |
| 360 | const char* TDName = TD->getDecl()->getIdentifier()->getName(); |
| 361 | assert (TDName); |
| 362 | |
| 363 | if (TDName[0] != 'C' || TDName[1] != 'F') |
| 364 | return false; |
| 365 | |
| 366 | if (strstr(TDName, "Ref") == 0) |
| 367 | return false; |
| 368 | |
| 369 | return true; |
| 370 | } |
| 371 | |
Ted Kremenek | ab2fa2a | 2008-04-10 23:44:06 +0000 | [diff] [blame] | 372 | void CFRefSummaryManager::FillDoNothing(unsigned Args) { |
| 373 | for (unsigned i = 0; i != Args; ++i) |
| 374 | ScratchArgs.push_back(DoNothing); |
| 375 | } |
| 376 | |
Ted Kremenek | ce3ed1e | 2008-03-12 01:21:45 +0000 | [diff] [blame] | 377 | |
| 378 | CFRefSummary* |
| 379 | CFRefSummaryManager::getCFSummaryCreateRule(FunctionTypeProto* FT) { |
| 380 | |
| 381 | if (!isCFRefType(FT->getResultType())) |
Ted Kremenek | d4244d4 | 2008-04-11 20:11:19 +0000 | [diff] [blame] | 382 | return NULL; |
Ted Kremenek | ce3ed1e | 2008-03-12 01:21:45 +0000 | [diff] [blame] | 383 | |
| 384 | assert (ScratchArgs.empty()); |
| 385 | |
| 386 | // FIXME: Add special-cases for functions that retain/release. For now |
| 387 | // just handle the default case. |
| 388 | |
Ted Kremenek | ab2fa2a | 2008-04-10 23:44:06 +0000 | [diff] [blame] | 389 | FillDoNothing(FT->getNumArgs()); |
Ted Kremenek | ce3ed1e | 2008-03-12 01:21:45 +0000 | [diff] [blame] | 390 | return getPersistentSummary(getArgEffects(), RetEffect::MakeOwned()); |
| 391 | } |
| 392 | |
| 393 | CFRefSummary* |
| 394 | CFRefSummaryManager::getCFSummaryGetRule(FunctionTypeProto* FT) { |
| 395 | |
Ted Kremenek | d4244d4 | 2008-04-11 20:11:19 +0000 | [diff] [blame] | 396 | QualType RetTy = FT->getResultType(); |
| 397 | |
| 398 | // FIXME: For now we assume that all pointer types returned are referenced |
| 399 | // counted. Since this is the "Get" rule, we assume non-ownership, which |
| 400 | // works fine for things that are not reference counted. We do this because |
| 401 | // some generic data structures return "void*". We need something better |
| 402 | // in the future. |
| 403 | |
| 404 | if (!isCFRefType(RetTy) && !RetTy->isPointerType()) |
| 405 | return NULL; |
Ted Kremenek | ce3ed1e | 2008-03-12 01:21:45 +0000 | [diff] [blame] | 406 | |
| 407 | assert (ScratchArgs.empty()); |
| 408 | |
| 409 | // FIXME: Add special-cases for functions that retain/release. For now |
| 410 | // just handle the default case. |
| 411 | |
Ted Kremenek | ab2fa2a | 2008-04-10 23:44:06 +0000 | [diff] [blame] | 412 | FillDoNothing(FT->getNumArgs()); |
Ted Kremenek | ce3ed1e | 2008-03-12 01:21:45 +0000 | [diff] [blame] | 413 | return getPersistentSummary(getArgEffects(), RetEffect::MakeNotOwned()); |
| 414 | } |
| 415 | |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 416 | //===----------------------------------------------------------------------===// |
Ted Kremenek | 7d421f3 | 2008-04-09 23:49:11 +0000 | [diff] [blame] | 417 | // Bug Descriptions. |
| 418 | //===----------------------------------------------------------------------===// |
| 419 | |
| 420 | namespace { |
| 421 | |
| 422 | class CFRefCount; |
| 423 | |
| 424 | class VISIBILITY_HIDDEN CFRefBug : public BugType { |
| 425 | protected: |
| 426 | CFRefCount& TF; |
| 427 | |
| 428 | public: |
| 429 | CFRefBug(CFRefCount& tf) : TF(tf) {} |
| 430 | }; |
| 431 | |
| 432 | class VISIBILITY_HIDDEN UseAfterRelease : public CFRefBug { |
| 433 | public: |
| 434 | UseAfterRelease(CFRefCount& tf) : CFRefBug(tf) {} |
| 435 | |
| 436 | virtual const char* getName() const { |
| 437 | return "(CoreFoundation) use-after-release"; |
| 438 | } |
| 439 | virtual const char* getDescription() const { |
| 440 | return "(CoreFoundation) Reference-counted object is used" |
Ted Kremenek | d9ccf68 | 2008-04-17 18:12:53 +0000 | [diff] [blame^] | 441 | " after it is released."; |
Ted Kremenek | 7d421f3 | 2008-04-09 23:49:11 +0000 | [diff] [blame] | 442 | } |
| 443 | |
| 444 | virtual void EmitWarnings(BugReporter& BR); |
| 445 | |
| 446 | }; |
| 447 | |
| 448 | class VISIBILITY_HIDDEN BadRelease : public CFRefBug { |
| 449 | public: |
| 450 | BadRelease(CFRefCount& tf) : CFRefBug(tf) {} |
| 451 | |
| 452 | virtual const char* getName() const { |
| 453 | return "(CoreFoundation) release of non-owned object"; |
| 454 | } |
| 455 | virtual const char* getDescription() const { |
| 456 | return "Incorrect decrement of the reference count of a " |
Ted Kremenek | d9ccf68 | 2008-04-17 18:12:53 +0000 | [diff] [blame^] | 457 | "CoreFoundation object:\n" |
| 458 | "The object is not owned at this point by the caller."; |
Ted Kremenek | 7d421f3 | 2008-04-09 23:49:11 +0000 | [diff] [blame] | 459 | } |
| 460 | |
| 461 | virtual void EmitWarnings(BugReporter& BR); |
| 462 | }; |
| 463 | |
| 464 | } // end anonymous namespace |
| 465 | |
| 466 | //===----------------------------------------------------------------------===// |
Ted Kremenek | 7aef484 | 2008-04-16 20:40:59 +0000 | [diff] [blame] | 467 | // Reference-counting logic (typestate + counts). |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 468 | //===----------------------------------------------------------------------===// |
| 469 | |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 470 | namespace { |
| 471 | |
Ted Kremenek | 7d421f3 | 2008-04-09 23:49:11 +0000 | [diff] [blame] | 472 | class VISIBILITY_HIDDEN RefVal { |
Ted Kremenek | d9ccf68 | 2008-04-17 18:12:53 +0000 | [diff] [blame^] | 473 | public: |
Ted Kremenek | 0d72157 | 2008-03-11 17:48:22 +0000 | [diff] [blame] | 474 | |
Ted Kremenek | d9ccf68 | 2008-04-17 18:12:53 +0000 | [diff] [blame^] | 475 | enum Kind { |
| 476 | Owned = 0, // Owning reference. |
| 477 | NotOwned, // Reference is not owned by still valid (not freed). |
| 478 | Released, // Object has been released. |
| 479 | ReturnedOwned, // Returned object passes ownership to caller. |
| 480 | ReturnedNotOwned, // Return object does not pass ownership to caller. |
| 481 | ErrorUseAfterRelease, // Object used after released. |
| 482 | ErrorReleaseNotOwned, // Release of an object that was not owned. |
| 483 | ErrorLeak // A memory leak due to excessive reference counts. |
| 484 | }; |
Ted Kremenek | 0d72157 | 2008-03-11 17:48:22 +0000 | [diff] [blame] | 485 | |
Ted Kremenek | d9ccf68 | 2008-04-17 18:12:53 +0000 | [diff] [blame^] | 486 | private: |
| 487 | |
| 488 | Kind kind; |
| 489 | unsigned Cnt; |
| 490 | |
| 491 | RefVal(Kind k, unsigned cnt) : kind(k), Cnt(cnt) {} |
| 492 | |
| 493 | RefVal(Kind k) : kind(k), Cnt(0) {} |
Ted Kremenek | 0d72157 | 2008-03-11 17:48:22 +0000 | [diff] [blame] | 494 | |
| 495 | public: |
Ted Kremenek | 3f3c9c8 | 2008-04-16 22:32:20 +0000 | [diff] [blame] | 496 | |
Ted Kremenek | d9ccf68 | 2008-04-17 18:12:53 +0000 | [diff] [blame^] | 497 | Kind getKind() const { return kind; } |
Ted Kremenek | 0d72157 | 2008-03-11 17:48:22 +0000 | [diff] [blame] | 498 | |
Ted Kremenek | d9ccf68 | 2008-04-17 18:12:53 +0000 | [diff] [blame^] | 499 | unsigned getCount() const { return Cnt; } |
| 500 | |
| 501 | // Useful predicates. |
Ted Kremenek | 0d72157 | 2008-03-11 17:48:22 +0000 | [diff] [blame] | 502 | |
Ted Kremenek | 1daa16c | 2008-03-11 18:14:09 +0000 | [diff] [blame] | 503 | static bool isError(Kind k) { return k >= ErrorUseAfterRelease; } |
| 504 | |
Ted Kremenek | 3f3c9c8 | 2008-04-16 22:32:20 +0000 | [diff] [blame] | 505 | static bool isLeak(Kind k) { return k == ErrorLeak; } |
| 506 | |
Ted Kremenek | ffefc35 | 2008-04-11 22:25:11 +0000 | [diff] [blame] | 507 | bool isOwned() const { |
| 508 | return getKind() == Owned; |
| 509 | } |
| 510 | |
Ted Kremenek | 3f3c9c8 | 2008-04-16 22:32:20 +0000 | [diff] [blame] | 511 | bool isNotOwned() const { |
| 512 | return getKind() == NotOwned; |
| 513 | } |
| 514 | |
Ted Kremenek | d9ccf68 | 2008-04-17 18:12:53 +0000 | [diff] [blame^] | 515 | bool isReturnedOwned() const { |
| 516 | return getKind() == ReturnedOwned; |
| 517 | } |
| 518 | |
| 519 | bool isReturnedNotOwned() const { |
| 520 | return getKind() == ReturnedNotOwned; |
| 521 | } |
| 522 | |
| 523 | bool isNonLeakError() const { |
| 524 | Kind k = getKind(); |
| 525 | return isError(k) && !isLeak(k); |
| 526 | } |
| 527 | |
| 528 | // State creation: normal state. |
| 529 | |
Ted Kremenek | c4f8102 | 2008-04-10 23:09:18 +0000 | [diff] [blame] | 530 | static RefVal makeOwned(unsigned Count = 0) { |
| 531 | return RefVal(Owned, Count); |
| 532 | } |
| 533 | |
| 534 | static RefVal makeNotOwned(unsigned Count = 0) { |
| 535 | return RefVal(NotOwned, Count); |
| 536 | } |
Ted Kremenek | d9ccf68 | 2008-04-17 18:12:53 +0000 | [diff] [blame^] | 537 | |
| 538 | static RefVal makeReturnedOwned(unsigned Count) { |
| 539 | return RefVal(ReturnedOwned, Count); |
| 540 | } |
| 541 | |
| 542 | static RefVal makeReturnedNotOwned() { |
| 543 | return RefVal(ReturnedNotOwned); |
| 544 | } |
| 545 | |
| 546 | // State creation: errors. |
Ted Kremenek | c4f8102 | 2008-04-10 23:09:18 +0000 | [diff] [blame] | 547 | |
Ted Kremenek | 3f3c9c8 | 2008-04-16 22:32:20 +0000 | [diff] [blame] | 548 | static RefVal makeLeak() { return RefVal(ErrorLeak); } |
Ted Kremenek | 0d72157 | 2008-03-11 17:48:22 +0000 | [diff] [blame] | 549 | static RefVal makeReleased() { return RefVal(Released); } |
| 550 | static RefVal makeUseAfterRelease() { return RefVal(ErrorUseAfterRelease); } |
| 551 | static RefVal makeReleaseNotOwned() { return RefVal(ErrorReleaseNotOwned); } |
Ted Kremenek | d9ccf68 | 2008-04-17 18:12:53 +0000 | [diff] [blame^] | 552 | |
| 553 | // Comparison, profiling, and pretty-printing. |
Ted Kremenek | 0d72157 | 2008-03-11 17:48:22 +0000 | [diff] [blame] | 554 | |
Ted Kremenek | d9ccf68 | 2008-04-17 18:12:53 +0000 | [diff] [blame^] | 555 | bool operator==(const RefVal& X) const { |
| 556 | return kind == X.kind && Cnt == X.Cnt; |
| 557 | } |
Ted Kremenek | 3b11f7a | 2008-03-11 19:44:10 +0000 | [diff] [blame] | 558 | |
Ted Kremenek | d9ccf68 | 2008-04-17 18:12:53 +0000 | [diff] [blame^] | 559 | void Profile(llvm::FoldingSetNodeID& ID) const { |
| 560 | ID.AddInteger((unsigned) kind); |
| 561 | ID.AddInteger(Cnt); |
| 562 | } |
| 563 | |
Ted Kremenek | 3b11f7a | 2008-03-11 19:44:10 +0000 | [diff] [blame] | 564 | void print(std::ostream& Out) const; |
Ted Kremenek | 0d72157 | 2008-03-11 17:48:22 +0000 | [diff] [blame] | 565 | }; |
Ted Kremenek | 3b11f7a | 2008-03-11 19:44:10 +0000 | [diff] [blame] | 566 | |
| 567 | void RefVal::print(std::ostream& Out) const { |
| 568 | switch (getKind()) { |
| 569 | default: assert(false); |
Ted Kremenek | c4f8102 | 2008-04-10 23:09:18 +0000 | [diff] [blame] | 570 | case Owned: { |
| 571 | Out << "Owned"; |
| 572 | unsigned cnt = getCount(); |
| 573 | if (cnt) Out << " (+ " << cnt << ")"; |
Ted Kremenek | 3b11f7a | 2008-03-11 19:44:10 +0000 | [diff] [blame] | 574 | break; |
Ted Kremenek | c4f8102 | 2008-04-10 23:09:18 +0000 | [diff] [blame] | 575 | } |
Ted Kremenek | 3b11f7a | 2008-03-11 19:44:10 +0000 | [diff] [blame] | 576 | |
Ted Kremenek | c4f8102 | 2008-04-10 23:09:18 +0000 | [diff] [blame] | 577 | case NotOwned: { |
Ted Kremenek | d9ccf68 | 2008-04-17 18:12:53 +0000 | [diff] [blame^] | 578 | Out << "NotOwned"; |
Ted Kremenek | c4f8102 | 2008-04-10 23:09:18 +0000 | [diff] [blame] | 579 | unsigned cnt = getCount(); |
| 580 | if (cnt) Out << " (+ " << cnt << ")"; |
Ted Kremenek | 3b11f7a | 2008-03-11 19:44:10 +0000 | [diff] [blame] | 581 | break; |
Ted Kremenek | c4f8102 | 2008-04-10 23:09:18 +0000 | [diff] [blame] | 582 | } |
Ted Kremenek | 3b11f7a | 2008-03-11 19:44:10 +0000 | [diff] [blame] | 583 | |
Ted Kremenek | d9ccf68 | 2008-04-17 18:12:53 +0000 | [diff] [blame^] | 584 | case ReturnedOwned: { |
| 585 | Out << "ReturnedOwned"; |
| 586 | unsigned cnt = getCount(); |
| 587 | if (cnt) Out << " (+ " << cnt << ")"; |
| 588 | break; |
| 589 | } |
| 590 | |
| 591 | case ReturnedNotOwned: { |
| 592 | Out << "ReturnedNotOwned"; |
| 593 | unsigned cnt = getCount(); |
| 594 | if (cnt) Out << " (+ " << cnt << ")"; |
| 595 | break; |
| 596 | } |
| 597 | |
Ted Kremenek | 3b11f7a | 2008-03-11 19:44:10 +0000 | [diff] [blame] | 598 | case Released: |
| 599 | Out << "Released"; |
| 600 | break; |
| 601 | |
Ted Kremenek | 3f3c9c8 | 2008-04-16 22:32:20 +0000 | [diff] [blame] | 602 | case ErrorLeak: |
| 603 | Out << "Leaked"; |
| 604 | break; |
| 605 | |
Ted Kremenek | 3b11f7a | 2008-03-11 19:44:10 +0000 | [diff] [blame] | 606 | case ErrorUseAfterRelease: |
| 607 | Out << "Use-After-Release [ERROR]"; |
| 608 | break; |
| 609 | |
| 610 | case ErrorReleaseNotOwned: |
| 611 | Out << "Release of Not-Owned [ERROR]"; |
| 612 | break; |
| 613 | } |
| 614 | } |
Ted Kremenek | 0d72157 | 2008-03-11 17:48:22 +0000 | [diff] [blame] | 615 | |
Ted Kremenek | 7aef484 | 2008-04-16 20:40:59 +0000 | [diff] [blame] | 616 | //===----------------------------------------------------------------------===// |
| 617 | // Transfer functions. |
| 618 | //===----------------------------------------------------------------------===// |
| 619 | |
Ted Kremenek | 7d421f3 | 2008-04-09 23:49:11 +0000 | [diff] [blame] | 620 | class VISIBILITY_HIDDEN CFRefCount : public GRSimpleVals { |
Ted Kremenek | 3b11f7a | 2008-03-11 19:44:10 +0000 | [diff] [blame] | 621 | |
| 622 | // Type definitions. |
| 623 | |
Ted Kremenek | 0d72157 | 2008-03-11 17:48:22 +0000 | [diff] [blame] | 624 | typedef llvm::ImmutableMap<SymbolID, RefVal> RefBindings; |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 625 | typedef RefBindings::Factory RefBFactoryTy; |
Ted Kremenek | 1daa16c | 2008-03-11 18:14:09 +0000 | [diff] [blame] | 626 | |
Ted Kremenek | 99b0ecb | 2008-04-11 18:40:51 +0000 | [diff] [blame] | 627 | typedef llvm::DenseMap<GRExprEngine::NodeTy*,Expr*> UseAfterReleasesTy; |
| 628 | typedef llvm::DenseMap<GRExprEngine::NodeTy*,Expr*> ReleasesNotOwnedTy; |
Ted Kremenek | 3f3c9c8 | 2008-04-16 22:32:20 +0000 | [diff] [blame] | 629 | |
| 630 | typedef llvm::SmallVector<std::pair<SymbolID, ExplodedNode<ValueState>*>, 2> |
| 631 | LeaksTy; |
| 632 | |
Ted Kremenek | 1daa16c | 2008-03-11 18:14:09 +0000 | [diff] [blame] | 633 | |
Ted Kremenek | 3b11f7a | 2008-03-11 19:44:10 +0000 | [diff] [blame] | 634 | class BindingsPrinter : public ValueState::CheckerStatePrinter { |
| 635 | public: |
| 636 | virtual void PrintCheckerState(std::ostream& Out, void* State, |
| 637 | const char* nl, const char* sep); |
| 638 | }; |
| 639 | |
| 640 | // Instance variables. |
| 641 | |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 642 | CFRefSummaryManager Summaries; |
Ted Kremenek | ce3ed1e | 2008-03-12 01:21:45 +0000 | [diff] [blame] | 643 | RefBFactoryTy RefBFactory; |
| 644 | |
Ted Kremenek | 1daa16c | 2008-03-11 18:14:09 +0000 | [diff] [blame] | 645 | UseAfterReleasesTy UseAfterReleases; |
| 646 | ReleasesNotOwnedTy ReleasesNotOwned; |
Ted Kremenek | 3f3c9c8 | 2008-04-16 22:32:20 +0000 | [diff] [blame] | 647 | LeaksTy Leaks; |
Ted Kremenek | 1daa16c | 2008-03-11 18:14:09 +0000 | [diff] [blame] | 648 | |
Ted Kremenek | 3b11f7a | 2008-03-11 19:44:10 +0000 | [diff] [blame] | 649 | BindingsPrinter Printer; |
| 650 | |
Ted Kremenek | 1feab29 | 2008-04-16 04:28:53 +0000 | [diff] [blame] | 651 | Selector RetainSelector; |
| 652 | Selector ReleaseSelector; |
| 653 | |
Ted Kremenek | 3b11f7a | 2008-03-11 19:44:10 +0000 | [diff] [blame] | 654 | // Private methods. |
Ted Kremenek | 1feab29 | 2008-04-16 04:28:53 +0000 | [diff] [blame] | 655 | |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 656 | static RefBindings GetRefBindings(ValueState& StImpl) { |
| 657 | return RefBindings((RefBindings::TreeTy*) StImpl.CheckerState); |
| 658 | } |
Ted Kremenek | 1feab29 | 2008-04-16 04:28:53 +0000 | [diff] [blame] | 659 | |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 660 | static void SetRefBindings(ValueState& StImpl, RefBindings B) { |
| 661 | StImpl.CheckerState = B.getRoot(); |
| 662 | } |
Ted Kremenek | 1feab29 | 2008-04-16 04:28:53 +0000 | [diff] [blame] | 663 | |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 664 | RefBindings Remove(RefBindings B, SymbolID sym) { |
| 665 | return RefBFactory.Remove(B, sym); |
| 666 | } |
| 667 | |
Ted Kremenek | 0d72157 | 2008-03-11 17:48:22 +0000 | [diff] [blame] | 668 | RefBindings Update(RefBindings B, SymbolID sym, RefVal V, ArgEffect E, |
Ted Kremenek | 1feab29 | 2008-04-16 04:28:53 +0000 | [diff] [blame] | 669 | RefVal::Kind& hasErr); |
| 670 | |
Ted Kremenek | 3f3c9c8 | 2008-04-16 22:32:20 +0000 | [diff] [blame] | 671 | void ProcessNonLeakError(ExplodedNodeSet<ValueState>& Dst, |
| 672 | GRStmtNodeBuilder<ValueState>& Builder, |
| 673 | Expr* NodeExpr, Expr* ErrorExpr, |
| 674 | ExplodedNode<ValueState>* Pred, |
| 675 | ValueState* St, |
| 676 | RefVal::Kind hasErr); |
| 677 | |
| 678 | ValueState* HandleSymbolDeath(ValueStateManager& VMgr, ValueState* St, |
| 679 | SymbolID sid, RefVal V, bool& hasLeak); |
| 680 | |
| 681 | ValueState* NukeBinding(ValueStateManager& VMgr, ValueState* St, |
| 682 | SymbolID sid); |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 683 | |
| 684 | public: |
Ted Kremenek | 7aef484 | 2008-04-16 20:40:59 +0000 | [diff] [blame] | 685 | |
Ted Kremenek | 1feab29 | 2008-04-16 04:28:53 +0000 | [diff] [blame] | 686 | CFRefCount(ASTContext& Ctx) |
| 687 | : Summaries(Ctx), |
| 688 | RetainSelector(GetUnarySelector("retain", Ctx)), |
| 689 | ReleaseSelector(GetUnarySelector("release", Ctx)) {} |
| 690 | |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 691 | virtual ~CFRefCount() {} |
Ted Kremenek | 7d421f3 | 2008-04-09 23:49:11 +0000 | [diff] [blame] | 692 | |
| 693 | virtual void RegisterChecks(GRExprEngine& Eng); |
Ted Kremenek | 3b11f7a | 2008-03-11 19:44:10 +0000 | [diff] [blame] | 694 | |
| 695 | virtual ValueState::CheckerStatePrinter* getCheckerStatePrinter() { |
| 696 | return &Printer; |
| 697 | } |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 698 | |
| 699 | // Calls. |
| 700 | |
| 701 | virtual void EvalCall(ExplodedNodeSet<ValueState>& Dst, |
Ted Kremenek | ce0767f | 2008-03-12 21:06:49 +0000 | [diff] [blame] | 702 | GRExprEngine& Eng, |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 703 | GRStmtNodeBuilder<ValueState>& Builder, |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 704 | CallExpr* CE, LVal L, |
| 705 | ExplodedNode<ValueState>* Pred); |
Ted Kremenek | 10fe66d | 2008-04-09 01:10:13 +0000 | [diff] [blame] | 706 | |
Ted Kremenek | 4b4738b | 2008-04-15 23:44:31 +0000 | [diff] [blame] | 707 | virtual void EvalObjCMessageExpr(ExplodedNodeSet<ValueState>& Dst, |
| 708 | GRExprEngine& Engine, |
| 709 | GRStmtNodeBuilder<ValueState>& Builder, |
| 710 | ObjCMessageExpr* ME, |
| 711 | ExplodedNode<ValueState>* Pred); |
| 712 | |
| 713 | bool EvalObjCMessageExprAux(ExplodedNodeSet<ValueState>& Dst, |
| 714 | GRExprEngine& Engine, |
| 715 | GRStmtNodeBuilder<ValueState>& Builder, |
| 716 | ObjCMessageExpr* ME, |
| 717 | ExplodedNode<ValueState>* Pred); |
| 718 | |
Ted Kremenek | 7aef484 | 2008-04-16 20:40:59 +0000 | [diff] [blame] | 719 | // Stores. |
| 720 | |
| 721 | virtual void EvalStore(ExplodedNodeSet<ValueState>& Dst, |
| 722 | GRExprEngine& Engine, |
| 723 | GRStmtNodeBuilder<ValueState>& Builder, |
| 724 | Expr* E, ExplodedNode<ValueState>* Pred, |
| 725 | ValueState* St, RVal TargetLV, RVal Val); |
Ted Kremenek | ffefc35 | 2008-04-11 22:25:11 +0000 | [diff] [blame] | 726 | // End-of-path. |
| 727 | |
| 728 | virtual void EvalEndPath(GRExprEngine& Engine, |
| 729 | GREndPathNodeBuilder<ValueState>& Builder); |
| 730 | |
Ted Kremenek | d9ccf68 | 2008-04-17 18:12:53 +0000 | [diff] [blame^] | 731 | // Return statements. |
| 732 | |
| 733 | virtual void EvalReturn(ExplodedNodeSet<ValueState>& Dst, |
| 734 | GRExprEngine& Engine, |
| 735 | GRStmtNodeBuilder<ValueState>& Builder, |
| 736 | ReturnStmt* S, |
| 737 | ExplodedNode<ValueState>* Pred); |
| 738 | |
Ted Kremenek | 10fe66d | 2008-04-09 01:10:13 +0000 | [diff] [blame] | 739 | // Error iterators. |
| 740 | |
| 741 | typedef UseAfterReleasesTy::iterator use_after_iterator; |
| 742 | typedef ReleasesNotOwnedTy::iterator bad_release_iterator; |
| 743 | |
Ted Kremenek | 7d421f3 | 2008-04-09 23:49:11 +0000 | [diff] [blame] | 744 | use_after_iterator use_after_begin() { return UseAfterReleases.begin(); } |
| 745 | use_after_iterator use_after_end() { return UseAfterReleases.end(); } |
Ted Kremenek | 10fe66d | 2008-04-09 01:10:13 +0000 | [diff] [blame] | 746 | |
Ted Kremenek | 7d421f3 | 2008-04-09 23:49:11 +0000 | [diff] [blame] | 747 | bad_release_iterator bad_release_begin() { return ReleasesNotOwned.begin(); } |
| 748 | bad_release_iterator bad_release_end() { return ReleasesNotOwned.end(); } |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 749 | }; |
| 750 | |
| 751 | } // end anonymous namespace |
| 752 | |
Ted Kremenek | 7d421f3 | 2008-04-09 23:49:11 +0000 | [diff] [blame] | 753 | void CFRefCount::RegisterChecks(GRExprEngine& Eng) { |
| 754 | GRSimpleVals::RegisterChecks(Eng); |
| 755 | Eng.Register(new UseAfterRelease(*this)); |
| 756 | Eng.Register(new BadRelease(*this)); |
| 757 | } |
| 758 | |
| 759 | |
Ted Kremenek | 3b11f7a | 2008-03-11 19:44:10 +0000 | [diff] [blame] | 760 | void CFRefCount::BindingsPrinter::PrintCheckerState(std::ostream& Out, |
| 761 | void* State, const char* nl, |
| 762 | const char* sep) { |
| 763 | RefBindings B((RefBindings::TreeTy*) State); |
| 764 | |
| 765 | if (State) |
| 766 | Out << sep << nl; |
| 767 | |
| 768 | for (RefBindings::iterator I=B.begin(), E=B.end(); I!=E; ++I) { |
| 769 | Out << (*I).first << " : "; |
| 770 | (*I).second.print(Out); |
| 771 | Out << nl; |
| 772 | } |
| 773 | } |
| 774 | |
Ted Kremenek | 455dd86 | 2008-04-11 20:23:24 +0000 | [diff] [blame] | 775 | static inline ArgEffect GetArgE(CFRefSummary* Summ, unsigned idx) { |
| 776 | return Summ ? Summ->getArg(idx) : DoNothing; |
| 777 | } |
| 778 | |
| 779 | static inline RetEffect GetRetE(CFRefSummary* Summ) { |
| 780 | return Summ ? Summ->getRet() : RetEffect::MakeNoRet(); |
| 781 | } |
| 782 | |
Ted Kremenek | 3f3c9c8 | 2008-04-16 22:32:20 +0000 | [diff] [blame] | 783 | void CFRefCount::ProcessNonLeakError(ExplodedNodeSet<ValueState>& Dst, |
| 784 | GRStmtNodeBuilder<ValueState>& Builder, |
| 785 | Expr* NodeExpr, Expr* ErrorExpr, |
| 786 | ExplodedNode<ValueState>* Pred, |
| 787 | ValueState* St, |
| 788 | RefVal::Kind hasErr) { |
Ted Kremenek | 1feab29 | 2008-04-16 04:28:53 +0000 | [diff] [blame] | 789 | Builder.BuildSinks = true; |
| 790 | GRExprEngine::NodeTy* N = Builder.MakeNode(Dst, NodeExpr, Pred, St); |
| 791 | |
| 792 | if (!N) return; |
| 793 | |
| 794 | switch (hasErr) { |
| 795 | default: assert(false); |
| 796 | case RefVal::ErrorUseAfterRelease: |
| 797 | UseAfterReleases[N] = ErrorExpr; |
| 798 | break; |
| 799 | |
| 800 | case RefVal::ErrorReleaseNotOwned: |
| 801 | ReleasesNotOwned[N] = ErrorExpr; |
| 802 | break; |
| 803 | } |
| 804 | } |
| 805 | |
Ted Kremenek | 827f93b | 2008-03-06 00:08:09 +0000 | [diff] [blame] | 806 | void CFRefCount::EvalCall(ExplodedNodeSet<ValueState>& Dst, |
Ted Kremenek | ce0767f | 2008-03-12 21:06:49 +0000 | [diff] [blame] | 807 | GRExprEngine& Eng, |
Ted Kremenek | ce3ed1e | 2008-03-12 01:21:45 +0000 | [diff] [blame] | 808 | GRStmtNodeBuilder<ValueState>& Builder, |
| 809 | CallExpr* CE, LVal L, |
| 810 | ExplodedNode<ValueState>* Pred) { |
| 811 | |
Ted Kremenek | ce0767f | 2008-03-12 21:06:49 +0000 | [diff] [blame] | 812 | ValueStateManager& StateMgr = Eng.getStateManager(); |
Ted Kremenek | 827f93b | 2008-03-06 00:08:09 +0000 | [diff] [blame] | 813 | |
Ted Kremenek | 73ba047 | 2008-04-14 17:45:13 +0000 | [diff] [blame] | 814 | CFRefSummary* Summ = NULL; |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 815 | |
| 816 | // Get the summary. |
Ted Kremenek | 827f93b | 2008-03-06 00:08:09 +0000 | [diff] [blame] | 817 | |
Ted Kremenek | 73ba047 | 2008-04-14 17:45:13 +0000 | [diff] [blame] | 818 | if (isa<lval::FuncVal>(L)) { |
| 819 | lval::FuncVal FV = cast<lval::FuncVal>(L); |
| 820 | FunctionDecl* FD = FV.getDecl(); |
| 821 | Summ = Summaries.getSummary(FD, Eng.getContext()); |
| 822 | } |
Ted Kremenek | 827f93b | 2008-03-06 00:08:09 +0000 | [diff] [blame] | 823 | |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 824 | // Get the state. |
| 825 | |
| 826 | ValueState* St = Builder.GetState(Pred); |
| 827 | |
| 828 | // Evaluate the effects of the call. |
| 829 | |
| 830 | ValueState StVals = *St; |
Ted Kremenek | 1feab29 | 2008-04-16 04:28:53 +0000 | [diff] [blame] | 831 | RefVal::Kind hasErr = (RefVal::Kind) 0; |
Ted Kremenek | 455dd86 | 2008-04-11 20:23:24 +0000 | [diff] [blame] | 832 | |
Ted Kremenek | ce3ed1e | 2008-03-12 01:21:45 +0000 | [diff] [blame] | 833 | // This function has a summary. Evaluate the effect of the arguments. |
| 834 | |
| 835 | unsigned idx = 0; |
| 836 | |
Ted Kremenek | 99b0ecb | 2008-04-11 18:40:51 +0000 | [diff] [blame] | 837 | Expr* ErrorExpr = NULL; |
| 838 | |
| 839 | for (CallExpr::arg_iterator I = CE->arg_begin(), E = CE->arg_end(); |
| 840 | I != E; ++I, ++idx) { |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 841 | |
Ted Kremenek | ce3ed1e | 2008-03-12 01:21:45 +0000 | [diff] [blame] | 842 | RVal V = StateMgr.GetRVal(St, *I); |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 843 | |
Ted Kremenek | ce3ed1e | 2008-03-12 01:21:45 +0000 | [diff] [blame] | 844 | if (isa<lval::SymbolVal>(V)) { |
| 845 | SymbolID Sym = cast<lval::SymbolVal>(V).getSymbol(); |
Ted Kremenek | 455dd86 | 2008-04-11 20:23:24 +0000 | [diff] [blame] | 846 | RefBindings B = GetRefBindings(StVals); |
| 847 | |
Ted Kremenek | ce3ed1e | 2008-03-12 01:21:45 +0000 | [diff] [blame] | 848 | if (RefBindings::TreeTy* T = B.SlimFind(Sym)) { |
Ted Kremenek | 1feab29 | 2008-04-16 04:28:53 +0000 | [diff] [blame] | 849 | B = Update(B, Sym, T->getValue().second, GetArgE(Summ, idx), hasErr); |
Ted Kremenek | ce3ed1e | 2008-03-12 01:21:45 +0000 | [diff] [blame] | 850 | SetRefBindings(StVals, B); |
Ted Kremenek | 99b0ecb | 2008-04-11 18:40:51 +0000 | [diff] [blame] | 851 | |
Ted Kremenek | 1feab29 | 2008-04-16 04:28:53 +0000 | [diff] [blame] | 852 | if (hasErr) { |
Ted Kremenek | 99b0ecb | 2008-04-11 18:40:51 +0000 | [diff] [blame] | 853 | ErrorExpr = *I; |
| 854 | break; |
| 855 | } |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 856 | } |
Ted Kremenek | e492420 | 2008-04-11 20:51:02 +0000 | [diff] [blame] | 857 | } |
| 858 | else if (isa<LVal>(V)) { // Nuke all arguments passed by reference. |
| 859 | |
| 860 | // FIXME: This is basically copy-and-paste from GRSimpleVals. We |
| 861 | // should compose behavior, not copy it. |
Ted Kremenek | 455dd86 | 2008-04-11 20:23:24 +0000 | [diff] [blame] | 862 | StateMgr.Unbind(StVals, cast<LVal>(V)); |
Ted Kremenek | e492420 | 2008-04-11 20:51:02 +0000 | [diff] [blame] | 863 | } |
Ted Kremenek | ce3ed1e | 2008-03-12 01:21:45 +0000 | [diff] [blame] | 864 | } |
Ted Kremenek | 1feab29 | 2008-04-16 04:28:53 +0000 | [diff] [blame] | 865 | |
| 866 | St = StateMgr.getPersistentState(StVals); |
Ted Kremenek | ce3ed1e | 2008-03-12 01:21:45 +0000 | [diff] [blame] | 867 | |
Ted Kremenek | 1feab29 | 2008-04-16 04:28:53 +0000 | [diff] [blame] | 868 | if (hasErr) { |
Ted Kremenek | 3f3c9c8 | 2008-04-16 22:32:20 +0000 | [diff] [blame] | 869 | ProcessNonLeakError(Dst, Builder, CE, ErrorExpr, Pred, St, hasErr); |
Ted Kremenek | ce3ed1e | 2008-03-12 01:21:45 +0000 | [diff] [blame] | 870 | return; |
Ted Kremenek | 0d72157 | 2008-03-11 17:48:22 +0000 | [diff] [blame] | 871 | } |
Ted Kremenek | 1feab29 | 2008-04-16 04:28:53 +0000 | [diff] [blame] | 872 | |
Ted Kremenek | ce3ed1e | 2008-03-12 01:21:45 +0000 | [diff] [blame] | 873 | // Finally, consult the summary for the return value. |
| 874 | |
Ted Kremenek | 455dd86 | 2008-04-11 20:23:24 +0000 | [diff] [blame] | 875 | RetEffect RE = GetRetE(Summ); |
Ted Kremenek | ce3ed1e | 2008-03-12 01:21:45 +0000 | [diff] [blame] | 876 | |
| 877 | switch (RE.getKind()) { |
| 878 | default: |
| 879 | assert (false && "Unhandled RetEffect."); break; |
| 880 | |
Ted Kremenek | ab2fa2a | 2008-04-10 23:44:06 +0000 | [diff] [blame] | 881 | case RetEffect::NoRet: |
Ted Kremenek | 455dd86 | 2008-04-11 20:23:24 +0000 | [diff] [blame] | 882 | |
| 883 | // Make up a symbol for the return value (not reference counted). |
Ted Kremenek | e492420 | 2008-04-11 20:51:02 +0000 | [diff] [blame] | 884 | // FIXME: This is basically copy-and-paste from GRSimpleVals. We |
| 885 | // should compose behavior, not copy it. |
Ted Kremenek | 455dd86 | 2008-04-11 20:23:24 +0000 | [diff] [blame] | 886 | |
| 887 | if (CE->getType() != Eng.getContext().VoidTy) { |
| 888 | unsigned Count = Builder.getCurrentBlockCount(); |
| 889 | SymbolID Sym = Eng.getSymbolManager().getConjuredSymbol(CE, Count); |
| 890 | |
| 891 | RVal X = CE->getType()->isPointerType() |
| 892 | ? cast<RVal>(lval::SymbolVal(Sym)) |
| 893 | : cast<RVal>(nonlval::SymbolVal(Sym)); |
| 894 | |
| 895 | St = StateMgr.SetRVal(St, CE, X, Eng.getCFG().isBlkExpr(CE), false); |
| 896 | } |
| 897 | |
Ted Kremenek | ab2fa2a | 2008-04-10 23:44:06 +0000 | [diff] [blame] | 898 | break; |
| 899 | |
Ted Kremenek | ce3ed1e | 2008-03-12 01:21:45 +0000 | [diff] [blame] | 900 | case RetEffect::Alias: { |
| 901 | unsigned idx = RE.getValue(); |
| 902 | assert (idx < CE->getNumArgs()); |
| 903 | RVal V = StateMgr.GetRVal(St, CE->getArg(idx)); |
Ted Kremenek | ce0767f | 2008-03-12 21:06:49 +0000 | [diff] [blame] | 904 | St = StateMgr.SetRVal(St, CE, V, Eng.getCFG().isBlkExpr(CE), false); |
Ted Kremenek | ce3ed1e | 2008-03-12 01:21:45 +0000 | [diff] [blame] | 905 | break; |
| 906 | } |
| 907 | |
| 908 | case RetEffect::OwnedSymbol: { |
| 909 | unsigned Count = Builder.getCurrentBlockCount(); |
Ted Kremenek | d467651 | 2008-03-12 21:45:47 +0000 | [diff] [blame] | 910 | SymbolID Sym = Eng.getSymbolManager().getConjuredSymbol(CE, Count); |
Ted Kremenek | ce3ed1e | 2008-03-12 01:21:45 +0000 | [diff] [blame] | 911 | |
| 912 | ValueState StImpl = *St; |
| 913 | RefBindings B = GetRefBindings(StImpl); |
Ted Kremenek | c4f8102 | 2008-04-10 23:09:18 +0000 | [diff] [blame] | 914 | SetRefBindings(StImpl, RefBFactory.Add(B, Sym, RefVal::makeOwned())); |
Ted Kremenek | ce3ed1e | 2008-03-12 01:21:45 +0000 | [diff] [blame] | 915 | |
| 916 | St = StateMgr.SetRVal(StateMgr.getPersistentState(StImpl), |
| 917 | CE, lval::SymbolVal(Sym), |
Ted Kremenek | ce0767f | 2008-03-12 21:06:49 +0000 | [diff] [blame] | 918 | Eng.getCFG().isBlkExpr(CE), false); |
Ted Kremenek | ce3ed1e | 2008-03-12 01:21:45 +0000 | [diff] [blame] | 919 | |
| 920 | break; |
| 921 | } |
| 922 | |
| 923 | case RetEffect::NotOwnedSymbol: { |
| 924 | unsigned Count = Builder.getCurrentBlockCount(); |
Ted Kremenek | d467651 | 2008-03-12 21:45:47 +0000 | [diff] [blame] | 925 | SymbolID Sym = Eng.getSymbolManager().getConjuredSymbol(CE, Count); |
Ted Kremenek | ce3ed1e | 2008-03-12 01:21:45 +0000 | [diff] [blame] | 926 | |
| 927 | ValueState StImpl = *St; |
| 928 | RefBindings B = GetRefBindings(StImpl); |
| 929 | SetRefBindings(StImpl, RefBFactory.Add(B, Sym, RefVal::makeNotOwned())); |
| 930 | |
| 931 | St = StateMgr.SetRVal(StateMgr.getPersistentState(StImpl), |
| 932 | CE, lval::SymbolVal(Sym), |
Ted Kremenek | ce0767f | 2008-03-12 21:06:49 +0000 | [diff] [blame] | 933 | Eng.getCFG().isBlkExpr(CE), false); |
Ted Kremenek | ce3ed1e | 2008-03-12 01:21:45 +0000 | [diff] [blame] | 934 | |
| 935 | break; |
| 936 | } |
| 937 | } |
| 938 | |
Ted Kremenek | f10f288 | 2008-03-21 21:30:14 +0000 | [diff] [blame] | 939 | Builder.MakeNode(Dst, CE, Pred, St); |
Ted Kremenek | 827f93b | 2008-03-06 00:08:09 +0000 | [diff] [blame] | 940 | } |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 941 | |
Ted Kremenek | 4b4738b | 2008-04-15 23:44:31 +0000 | [diff] [blame] | 942 | |
| 943 | void CFRefCount::EvalObjCMessageExpr(ExplodedNodeSet<ValueState>& Dst, |
| 944 | GRExprEngine& Eng, |
| 945 | GRStmtNodeBuilder<ValueState>& Builder, |
| 946 | ObjCMessageExpr* ME, |
| 947 | ExplodedNode<ValueState>* Pred) { |
| 948 | |
| 949 | if (EvalObjCMessageExprAux(Dst, Eng, Builder, ME, Pred)) |
| 950 | GRSimpleVals::EvalObjCMessageExpr(Dst, Eng, Builder, ME, Pred); |
| 951 | } |
| 952 | |
| 953 | bool CFRefCount::EvalObjCMessageExprAux(ExplodedNodeSet<ValueState>& Dst, |
| 954 | GRExprEngine& Eng, |
| 955 | GRStmtNodeBuilder<ValueState>& Builder, |
| 956 | ObjCMessageExpr* ME, |
| 957 | ExplodedNode<ValueState>* Pred) { |
| 958 | |
Ted Kremenek | 1feab29 | 2008-04-16 04:28:53 +0000 | [diff] [blame] | 959 | // Handle "toll-free bridging" of calls to "Release" and "Retain". |
| 960 | |
| 961 | // FIXME: track the underlying object type associated so that we can |
| 962 | // flag illegal uses of toll-free bridging (or at least handle it |
| 963 | // at casts). |
Ted Kremenek | 4b4738b | 2008-04-15 23:44:31 +0000 | [diff] [blame] | 964 | |
| 965 | Selector S = ME->getSelector(); |
| 966 | |
| 967 | if (!S.isUnarySelector()) |
| 968 | return true; |
| 969 | |
Ted Kremenek | 1feab29 | 2008-04-16 04:28:53 +0000 | [diff] [blame] | 970 | Expr* Receiver = ME->getReceiver(); |
| 971 | |
| 972 | if (!Receiver) |
| 973 | return true; |
| 974 | |
| 975 | // Check if we are calling "Retain" or "Release". |
| 976 | |
| 977 | bool isRetain = false; |
| 978 | |
| 979 | if (S == RetainSelector) |
| 980 | isRetain = true; |
| 981 | else if (S != ReleaseSelector) |
| 982 | return true; |
| 983 | |
| 984 | // We have "Retain" or "Release". Get the reference binding. |
| 985 | |
| 986 | ValueStateManager& StateMgr = Eng.getStateManager(); |
| 987 | ValueState* St = Builder.GetState(Pred); |
| 988 | RVal V = StateMgr.GetRVal(St, Receiver); |
| 989 | |
| 990 | if (!isa<lval::SymbolVal>(V)) |
| 991 | return true; |
| 992 | |
| 993 | SymbolID Sym = cast<lval::SymbolVal>(V).getSymbol(); |
| 994 | RefBindings B = GetRefBindings(*St); |
| 995 | |
| 996 | RefBindings::TreeTy* T = B.SlimFind(Sym); |
| 997 | |
| 998 | if (!T) |
| 999 | return true; |
| 1000 | |
| 1001 | RefVal::Kind hasErr = (RefVal::Kind) 0; |
| 1002 | B = Update(B, Sym, T->getValue().second, isRetain ? IncRef : DecRef, hasErr); |
| 1003 | |
| 1004 | // Create a new state with the updated bindings. |
| 1005 | |
| 1006 | ValueState StVals = *St; |
| 1007 | SetRefBindings(StVals, B); |
| 1008 | St = StateMgr.getPersistentState(StVals); |
| 1009 | |
| 1010 | // Create an error node if it exists. |
| 1011 | |
| 1012 | if (hasErr) |
Ted Kremenek | 3f3c9c8 | 2008-04-16 22:32:20 +0000 | [diff] [blame] | 1013 | ProcessNonLeakError(Dst, Builder, ME, Receiver, Pred, St, hasErr); |
Ted Kremenek | 1feab29 | 2008-04-16 04:28:53 +0000 | [diff] [blame] | 1014 | else |
| 1015 | Builder.MakeNode(Dst, ME, Pred, St); |
| 1016 | |
| 1017 | return false; |
Ted Kremenek | 4b4738b | 2008-04-15 23:44:31 +0000 | [diff] [blame] | 1018 | } |
| 1019 | |
Ted Kremenek | 7aef484 | 2008-04-16 20:40:59 +0000 | [diff] [blame] | 1020 | // Stores. |
| 1021 | |
| 1022 | void CFRefCount::EvalStore(ExplodedNodeSet<ValueState>& Dst, |
| 1023 | GRExprEngine& Eng, |
| 1024 | GRStmtNodeBuilder<ValueState>& Builder, |
| 1025 | Expr* E, ExplodedNode<ValueState>* Pred, |
| 1026 | ValueState* St, RVal TargetLV, RVal Val) { |
| 1027 | |
| 1028 | // Check if we have a binding for "Val" and if we are storing it to something |
| 1029 | // we don't understand or otherwise the value "escapes" the function. |
| 1030 | |
| 1031 | if (!isa<lval::SymbolVal>(Val)) |
| 1032 | return; |
| 1033 | |
| 1034 | // Are we storing to something that causes the value to "escape"? |
| 1035 | |
| 1036 | bool escapes = false; |
| 1037 | |
| 1038 | if (!isa<lval::DeclVal>(TargetLV)) |
| 1039 | escapes = true; |
| 1040 | else |
| 1041 | escapes = cast<lval::DeclVal>(TargetLV).getDecl()->hasGlobalStorage(); |
| 1042 | |
| 1043 | if (!escapes) |
| 1044 | return; |
| 1045 | |
| 1046 | SymbolID Sym = cast<lval::SymbolVal>(Val).getSymbol(); |
| 1047 | RefBindings B = GetRefBindings(*St); |
| 1048 | RefBindings::TreeTy* T = B.SlimFind(Sym); |
| 1049 | |
| 1050 | if (!T) |
| 1051 | return; |
| 1052 | |
Ted Kremenek | 3f3c9c8 | 2008-04-16 22:32:20 +0000 | [diff] [blame] | 1053 | // Nuke the binding. |
| 1054 | St = NukeBinding(Eng.getStateManager(), St, Sym); |
Ted Kremenek | 7aef484 | 2008-04-16 20:40:59 +0000 | [diff] [blame] | 1055 | |
| 1056 | // Hand of the remaining logic to the parent implementation. |
| 1057 | GRSimpleVals::EvalStore(Dst, Eng, Builder, E, Pred, St, TargetLV, Val); |
| 1058 | } |
| 1059 | |
Ted Kremenek | 3f3c9c8 | 2008-04-16 22:32:20 +0000 | [diff] [blame] | 1060 | |
| 1061 | ValueState* CFRefCount::NukeBinding(ValueStateManager& VMgr, ValueState* St, |
| 1062 | SymbolID sid) { |
| 1063 | ValueState StImpl = *St; |
| 1064 | RefBindings B = GetRefBindings(StImpl); |
| 1065 | StImpl.CheckerState = RefBFactory.Remove(B, sid).getRoot(); |
| 1066 | return VMgr.getPersistentState(StImpl); |
| 1067 | } |
| 1068 | |
Ted Kremenek | ffefc35 | 2008-04-11 22:25:11 +0000 | [diff] [blame] | 1069 | // End-of-path. |
| 1070 | |
Ted Kremenek | 3f3c9c8 | 2008-04-16 22:32:20 +0000 | [diff] [blame] | 1071 | |
| 1072 | |
| 1073 | ValueState* CFRefCount::HandleSymbolDeath(ValueStateManager& VMgr, |
| 1074 | ValueState* St, SymbolID sid, |
| 1075 | RefVal V, bool& hasLeak) { |
| 1076 | |
Ted Kremenek | d9ccf68 | 2008-04-17 18:12:53 +0000 | [diff] [blame^] | 1077 | hasLeak = V.isOwned() || |
| 1078 | ((V.isNotOwned() || V.isReturnedOwned()) && V.getCount() > 0); |
Ted Kremenek | 3f3c9c8 | 2008-04-16 22:32:20 +0000 | [diff] [blame] | 1079 | |
| 1080 | if (!hasLeak) |
| 1081 | return NukeBinding(VMgr, St, sid); |
| 1082 | |
| 1083 | RefBindings B = GetRefBindings(*St); |
| 1084 | ValueState StImpl = *St; |
| 1085 | StImpl.CheckerState = RefBFactory.Add(B, sid, RefVal::makeLeak()).getRoot(); |
| 1086 | return VMgr.getPersistentState(StImpl); |
| 1087 | } |
| 1088 | |
| 1089 | void CFRefCount::EvalEndPath(GRExprEngine& Eng, |
Ted Kremenek | ffefc35 | 2008-04-11 22:25:11 +0000 | [diff] [blame] | 1090 | GREndPathNodeBuilder<ValueState>& Builder) { |
| 1091 | |
Ted Kremenek | 3f3c9c8 | 2008-04-16 22:32:20 +0000 | [diff] [blame] | 1092 | ValueState* St = Builder.getState(); |
| 1093 | RefBindings B = GetRefBindings(*St); |
Ted Kremenek | ffefc35 | 2008-04-11 22:25:11 +0000 | [diff] [blame] | 1094 | |
Ted Kremenek | 3f3c9c8 | 2008-04-16 22:32:20 +0000 | [diff] [blame] | 1095 | llvm::SmallVector<SymbolID, 10> Leaked; |
Ted Kremenek | ffefc35 | 2008-04-11 22:25:11 +0000 | [diff] [blame] | 1096 | |
Ted Kremenek | 3f3c9c8 | 2008-04-16 22:32:20 +0000 | [diff] [blame] | 1097 | for (RefBindings::iterator I = B.begin(), E = B.end(); I != E; ++I) { |
| 1098 | bool hasLeak = false; |
Ted Kremenek | ffefc35 | 2008-04-11 22:25:11 +0000 | [diff] [blame] | 1099 | |
Ted Kremenek | 3f3c9c8 | 2008-04-16 22:32:20 +0000 | [diff] [blame] | 1100 | St = HandleSymbolDeath(Eng.getStateManager(), St, |
| 1101 | (*I).first, (*I).second, hasLeak); |
| 1102 | |
| 1103 | if (hasLeak) Leaked.push_back((*I).first); |
| 1104 | } |
| 1105 | |
| 1106 | ExplodedNode<ValueState>* N = Builder.MakeNode(St); |
| 1107 | |
| 1108 | for (llvm::SmallVector<SymbolID, 10>::iterator I=Leaked.begin(), |
| 1109 | E = Leaked.end(); I != E; ++I) |
| 1110 | Leaks.push_back(std::make_pair(*I, N)); |
Ted Kremenek | ffefc35 | 2008-04-11 22:25:11 +0000 | [diff] [blame] | 1111 | } |
| 1112 | |
Ted Kremenek | d9ccf68 | 2008-04-17 18:12:53 +0000 | [diff] [blame^] | 1113 | // Return statements. |
| 1114 | |
| 1115 | void CFRefCount::EvalReturn(ExplodedNodeSet<ValueState>& Dst, |
| 1116 | GRExprEngine& Eng, |
| 1117 | GRStmtNodeBuilder<ValueState>& Builder, |
| 1118 | ReturnStmt* S, |
| 1119 | ExplodedNode<ValueState>* Pred) { |
| 1120 | |
| 1121 | Expr* RetE = S->getRetValue(); |
| 1122 | if (!RetE) return; |
| 1123 | |
| 1124 | ValueStateManager& StateMgr = Eng.getStateManager(); |
| 1125 | ValueState* St = Builder.GetState(Pred); |
| 1126 | RVal V = StateMgr.GetRVal(St, RetE); |
| 1127 | |
| 1128 | if (!isa<lval::SymbolVal>(V)) |
| 1129 | return; |
| 1130 | |
| 1131 | // Get the reference count binding (if any). |
| 1132 | SymbolID Sym = cast<lval::SymbolVal>(V).getSymbol(); |
| 1133 | RefBindings B = GetRefBindings(*St); |
| 1134 | RefBindings::TreeTy* T = B.SlimFind(Sym); |
| 1135 | |
| 1136 | if (!T) |
| 1137 | return; |
| 1138 | |
| 1139 | // Change the reference count. |
| 1140 | |
| 1141 | RefVal X = T->getValue().second; |
| 1142 | |
| 1143 | switch (X.getKind()) { |
| 1144 | |
| 1145 | case RefVal::Owned: { |
| 1146 | unsigned cnt = X.getCount(); |
| 1147 | X = RefVal::makeReturnedOwned(cnt); |
| 1148 | break; |
| 1149 | } |
| 1150 | |
| 1151 | case RefVal::NotOwned: { |
| 1152 | unsigned cnt = X.getCount(); |
| 1153 | X = cnt ? RefVal::makeReturnedOwned(cnt - 1) |
| 1154 | : RefVal::makeReturnedNotOwned(); |
| 1155 | break; |
| 1156 | } |
| 1157 | |
| 1158 | default: |
| 1159 | // None of the error states should be possible at this point. |
| 1160 | // A symbol could not have been leaked (yet) if we are returning it |
| 1161 | // (and thus it is still live), and the other errors are hard errors. |
| 1162 | assert(false); |
| 1163 | return; |
| 1164 | } |
| 1165 | |
| 1166 | // Update the binding. |
| 1167 | |
| 1168 | ValueState StImpl = *St; |
| 1169 | StImpl.CheckerState = RefBFactory.Add(B, Sym, X).getRoot(); |
| 1170 | Builder.MakeNode(Dst, S, Pred, StateMgr.getPersistentState(StImpl)); |
| 1171 | } |
| 1172 | |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 1173 | |
| 1174 | CFRefCount::RefBindings CFRefCount::Update(RefBindings B, SymbolID sym, |
Ted Kremenek | 0d72157 | 2008-03-11 17:48:22 +0000 | [diff] [blame] | 1175 | RefVal V, ArgEffect E, |
Ted Kremenek | 1feab29 | 2008-04-16 04:28:53 +0000 | [diff] [blame] | 1176 | RefVal::Kind& hasErr) { |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 1177 | |
Ted Kremenek | 0d72157 | 2008-03-11 17:48:22 +0000 | [diff] [blame] | 1178 | // FIXME: This dispatch can potentially be sped up by unifiying it into |
| 1179 | // a single switch statement. Opt for simplicity for now. |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 1180 | |
Ted Kremenek | 0d72157 | 2008-03-11 17:48:22 +0000 | [diff] [blame] | 1181 | switch (E) { |
| 1182 | default: |
| 1183 | assert (false && "Unhandled CFRef transition."); |
| 1184 | |
| 1185 | case DoNothing: |
Ted Kremenek | ce3ed1e | 2008-03-12 01:21:45 +0000 | [diff] [blame] | 1186 | if (V.getKind() == RefVal::Released) { |
| 1187 | V = RefVal::makeUseAfterRelease(); |
Ted Kremenek | 1feab29 | 2008-04-16 04:28:53 +0000 | [diff] [blame] | 1188 | hasErr = V.getKind(); |
Ted Kremenek | ce3ed1e | 2008-03-12 01:21:45 +0000 | [diff] [blame] | 1189 | break; |
| 1190 | } |
| 1191 | |
Ted Kremenek | 0d72157 | 2008-03-11 17:48:22 +0000 | [diff] [blame] | 1192 | return B; |
| 1193 | |
| 1194 | case IncRef: |
| 1195 | switch (V.getKind()) { |
| 1196 | default: |
| 1197 | assert(false); |
| 1198 | |
| 1199 | case RefVal::Owned: |
Ted Kremenek | ab2fa2a | 2008-04-10 23:44:06 +0000 | [diff] [blame] | 1200 | V = RefVal::makeOwned(V.getCount()+1); |
| 1201 | break; |
Ted Kremenek | c4f8102 | 2008-04-10 23:09:18 +0000 | [diff] [blame] | 1202 | |
Ted Kremenek | 0d72157 | 2008-03-11 17:48:22 +0000 | [diff] [blame] | 1203 | case RefVal::NotOwned: |
Ted Kremenek | c4f8102 | 2008-04-10 23:09:18 +0000 | [diff] [blame] | 1204 | V = RefVal::makeNotOwned(V.getCount()+1); |
Ted Kremenek | 0d72157 | 2008-03-11 17:48:22 +0000 | [diff] [blame] | 1205 | break; |
| 1206 | |
| 1207 | case RefVal::Released: |
Ted Kremenek | 0d72157 | 2008-03-11 17:48:22 +0000 | [diff] [blame] | 1208 | V = RefVal::makeUseAfterRelease(); |
Ted Kremenek | 1feab29 | 2008-04-16 04:28:53 +0000 | [diff] [blame] | 1209 | hasErr = V.getKind(); |
Ted Kremenek | 0d72157 | 2008-03-11 17:48:22 +0000 | [diff] [blame] | 1210 | break; |
| 1211 | } |
| 1212 | |
Ted Kremenek | ab2fa2a | 2008-04-10 23:44:06 +0000 | [diff] [blame] | 1213 | break; |
| 1214 | |
Ted Kremenek | 0d72157 | 2008-03-11 17:48:22 +0000 | [diff] [blame] | 1215 | case DecRef: |
| 1216 | switch (V.getKind()) { |
| 1217 | default: |
| 1218 | assert (false); |
| 1219 | |
| 1220 | case RefVal::Owned: { |
Ted Kremenek | d9ccf68 | 2008-04-17 18:12:53 +0000 | [diff] [blame^] | 1221 | unsigned Count = V.getCount(); |
| 1222 | V = Count > 0 ? RefVal::makeOwned(Count - 1) : RefVal::makeReleased(); |
Ted Kremenek | 0d72157 | 2008-03-11 17:48:22 +0000 | [diff] [blame] | 1223 | break; |
| 1224 | } |
| 1225 | |
Ted Kremenek | c4f8102 | 2008-04-10 23:09:18 +0000 | [diff] [blame] | 1226 | case RefVal::NotOwned: { |
Ted Kremenek | d9ccf68 | 2008-04-17 18:12:53 +0000 | [diff] [blame^] | 1227 | unsigned Count = V.getCount(); |
Ted Kremenek | c4f8102 | 2008-04-10 23:09:18 +0000 | [diff] [blame] | 1228 | |
Ted Kremenek | d9ccf68 | 2008-04-17 18:12:53 +0000 | [diff] [blame^] | 1229 | if (Count > 0) |
| 1230 | V = RefVal::makeNotOwned(Count - 1); |
Ted Kremenek | c4f8102 | 2008-04-10 23:09:18 +0000 | [diff] [blame] | 1231 | else { |
| 1232 | V = RefVal::makeReleaseNotOwned(); |
Ted Kremenek | 1feab29 | 2008-04-16 04:28:53 +0000 | [diff] [blame] | 1233 | hasErr = V.getKind(); |
Ted Kremenek | c4f8102 | 2008-04-10 23:09:18 +0000 | [diff] [blame] | 1234 | } |
| 1235 | |
Ted Kremenek | 0d72157 | 2008-03-11 17:48:22 +0000 | [diff] [blame] | 1236 | break; |
| 1237 | } |
Ted Kremenek | 0d72157 | 2008-03-11 17:48:22 +0000 | [diff] [blame] | 1238 | |
| 1239 | case RefVal::Released: |
Ted Kremenek | 0d72157 | 2008-03-11 17:48:22 +0000 | [diff] [blame] | 1240 | V = RefVal::makeUseAfterRelease(); |
Ted Kremenek | 1feab29 | 2008-04-16 04:28:53 +0000 | [diff] [blame] | 1241 | hasErr = V.getKind(); |
Ted Kremenek | 0d72157 | 2008-03-11 17:48:22 +0000 | [diff] [blame] | 1242 | break; |
| 1243 | } |
Ted Kremenek | ab2fa2a | 2008-04-10 23:44:06 +0000 | [diff] [blame] | 1244 | |
| 1245 | break; |
Ted Kremenek | 0d72157 | 2008-03-11 17:48:22 +0000 | [diff] [blame] | 1246 | } |
| 1247 | |
| 1248 | return RefBFactory.Add(B, sym, V); |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 1249 | } |
| 1250 | |
Ted Kremenek | 10fe66d | 2008-04-09 01:10:13 +0000 | [diff] [blame] | 1251 | |
| 1252 | //===----------------------------------------------------------------------===// |
Ted Kremenek | 7d421f3 | 2008-04-09 23:49:11 +0000 | [diff] [blame] | 1253 | // Error reporting. |
Ted Kremenek | 10fe66d | 2008-04-09 01:10:13 +0000 | [diff] [blame] | 1254 | //===----------------------------------------------------------------------===// |
| 1255 | |
Ted Kremenek | 7d421f3 | 2008-04-09 23:49:11 +0000 | [diff] [blame] | 1256 | void UseAfterRelease::EmitWarnings(BugReporter& BR) { |
Ted Kremenek | 10fe66d | 2008-04-09 01:10:13 +0000 | [diff] [blame] | 1257 | |
Ted Kremenek | 7d421f3 | 2008-04-09 23:49:11 +0000 | [diff] [blame] | 1258 | for (CFRefCount::use_after_iterator I = TF.use_after_begin(), |
| 1259 | E = TF.use_after_end(); I != E; ++I) { |
| 1260 | |
Ted Kremenek | e3ef1c7 | 2008-04-14 17:39:48 +0000 | [diff] [blame] | 1261 | RangedBugReport report(*this, I->first); |
Ted Kremenek | 99b0ecb | 2008-04-11 18:40:51 +0000 | [diff] [blame] | 1262 | report.addRange(I->second->getSourceRange()); |
Ted Kremenek | e3ef1c7 | 2008-04-14 17:39:48 +0000 | [diff] [blame] | 1263 | BR.EmitPathWarning(report); |
Ted Kremenek | 10fe66d | 2008-04-09 01:10:13 +0000 | [diff] [blame] | 1264 | } |
Ted Kremenek | 7d421f3 | 2008-04-09 23:49:11 +0000 | [diff] [blame] | 1265 | } |
| 1266 | |
| 1267 | void BadRelease::EmitWarnings(BugReporter& BR) { |
Ted Kremenek | 10fe66d | 2008-04-09 01:10:13 +0000 | [diff] [blame] | 1268 | |
Ted Kremenek | 7d421f3 | 2008-04-09 23:49:11 +0000 | [diff] [blame] | 1269 | for (CFRefCount::bad_release_iterator I = TF.bad_release_begin(), |
| 1270 | E = TF.bad_release_end(); I != E; ++I) { |
| 1271 | |
Ted Kremenek | e3ef1c7 | 2008-04-14 17:39:48 +0000 | [diff] [blame] | 1272 | RangedBugReport report(*this, I->first); |
Ted Kremenek | 99b0ecb | 2008-04-11 18:40:51 +0000 | [diff] [blame] | 1273 | report.addRange(I->second->getSourceRange()); |
Ted Kremenek | e3ef1c7 | 2008-04-14 17:39:48 +0000 | [diff] [blame] | 1274 | BR.EmitPathWarning(report); |
Ted Kremenek | 99b0ecb | 2008-04-11 18:40:51 +0000 | [diff] [blame] | 1275 | |
Ted Kremenek | 7d421f3 | 2008-04-09 23:49:11 +0000 | [diff] [blame] | 1276 | } |
| 1277 | } |
Ted Kremenek | 10fe66d | 2008-04-09 01:10:13 +0000 | [diff] [blame] | 1278 | |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 1279 | //===----------------------------------------------------------------------===// |
Ted Kremenek | b1983ba | 2008-04-10 22:16:52 +0000 | [diff] [blame] | 1280 | // Transfer function creation for external clients. |
Ted Kremenek | a7338b4 | 2008-03-11 06:39:11 +0000 | [diff] [blame] | 1281 | //===----------------------------------------------------------------------===// |
| 1282 | |
Ted Kremenek | a4c7429 | 2008-04-10 22:58:08 +0000 | [diff] [blame] | 1283 | GRTransferFuncs* clang::MakeCFRefCountTF(ASTContext& Ctx) { |
| 1284 | return new CFRefCount(Ctx); |
| 1285 | } |