Damien Neil | c37adef | 2019-04-01 13:49:56 -0700 | [diff] [blame] | 1 | // Copyright 2019 The Go Authors. All rights reserved. |
| 2 | // Use of this source code is governed by a BSD-style |
| 3 | // license that can be found in the LICENSE file. |
| 4 | |
Damien Neil | 99f24c3 | 2019-03-13 17:06:42 -0700 | [diff] [blame] | 5 | package proto_test |
| 6 | |
| 7 | import ( |
| 8 | "bytes" |
| 9 | "fmt" |
Damien Neil | 99f24c3 | 2019-03-13 17:06:42 -0700 | [diff] [blame] | 10 | "testing" |
| 11 | |
Damien Neil | 99f24c3 | 2019-03-13 17:06:42 -0700 | [diff] [blame] | 12 | "github.com/google/go-cmp/cmp" |
Joe Tsai | c51e2e0 | 2019-07-13 00:44:41 -0700 | [diff] [blame] | 13 | "google.golang.org/protobuf/internal/flags" |
Damien Neil | e89e624 | 2019-05-13 23:55:40 -0700 | [diff] [blame] | 14 | "google.golang.org/protobuf/proto" |
Damien Neil | 3016b73 | 2019-04-07 12:43:10 -0700 | [diff] [blame] | 15 | |
Joe Tsai | 9b22b93 | 2019-08-08 19:23:32 -0700 | [diff] [blame] | 16 | testpb "google.golang.org/protobuf/internal/testprotos/test" |
Damien Neil | e89e624 | 2019-05-13 23:55:40 -0700 | [diff] [blame] | 17 | test3pb "google.golang.org/protobuf/internal/testprotos/test3" |
Damien Neil | 99f24c3 | 2019-03-13 17:06:42 -0700 | [diff] [blame] | 18 | ) |
| 19 | |
| 20 | func TestEncode(t *testing.T) { |
| 21 | for _, test := range testProtos { |
| 22 | for _, want := range test.decodeTo { |
| 23 | t.Run(fmt.Sprintf("%s (%T)", test.desc, want), func(t *testing.T) { |
Damien Neil | 96c229a | 2019-04-03 12:17:24 -0700 | [diff] [blame] | 24 | opts := proto.MarshalOptions{ |
| 25 | AllowPartial: test.partial, |
| 26 | } |
| 27 | wire, err := opts.Marshal(want) |
Damien Neil | 99f24c3 | 2019-03-13 17:06:42 -0700 | [diff] [blame] | 28 | if err != nil { |
Damien Neil | 61e93c7 | 2019-03-27 09:23:20 -0700 | [diff] [blame] | 29 | t.Fatalf("Marshal error: %v\nMessage:\n%v", err, marshalText(want)) |
| 30 | } |
| 31 | |
| 32 | size := proto.Size(want) |
| 33 | if size != len(wire) { |
| 34 | t.Errorf("Size and marshal disagree: Size(m)=%v; len(Marshal(m))=%v\nMessage:\n%v", size, len(wire), marshalText(want)) |
Damien Neil | 99f24c3 | 2019-03-13 17:06:42 -0700 | [diff] [blame] | 35 | } |
| 36 | |
Joe Tsai | 378c132 | 2019-04-25 23:48:08 -0700 | [diff] [blame] | 37 | got := want.ProtoReflect().New().Interface() |
Damien Neil | 96c229a | 2019-04-03 12:17:24 -0700 | [diff] [blame] | 38 | uopts := proto.UnmarshalOptions{ |
| 39 | AllowPartial: test.partial, |
| 40 | } |
| 41 | if err := uopts.Unmarshal(wire, got); err != nil { |
Joe Tsai | 8d30bbe | 2019-05-16 15:53:25 -0700 | [diff] [blame] | 42 | t.Errorf("Unmarshal error: %v\nMessage:\n%v", err, marshalText(want)) |
Damien Neil | 99f24c3 | 2019-03-13 17:06:42 -0700 | [diff] [blame] | 43 | return |
| 44 | } |
Damien Neil | e6f060f | 2019-04-23 17:11:02 -0700 | [diff] [blame] | 45 | if !proto.Equal(got, want) { |
Joe Tsai | 8d30bbe | 2019-05-16 15:53:25 -0700 | [diff] [blame] | 46 | t.Errorf("Unmarshal returned unexpected result; got:\n%v\nwant:\n%v", marshalText(got), marshalText(want)) |
Damien Neil | 99f24c3 | 2019-03-13 17:06:42 -0700 | [diff] [blame] | 47 | } |
| 48 | }) |
| 49 | } |
| 50 | } |
| 51 | } |
| 52 | |
| 53 | func TestEncodeDeterministic(t *testing.T) { |
| 54 | for _, test := range testProtos { |
| 55 | for _, want := range test.decodeTo { |
| 56 | t.Run(fmt.Sprintf("%s (%T)", test.desc, want), func(t *testing.T) { |
Damien Neil | 96c229a | 2019-04-03 12:17:24 -0700 | [diff] [blame] | 57 | opts := proto.MarshalOptions{ |
| 58 | Deterministic: true, |
| 59 | AllowPartial: test.partial, |
| 60 | } |
| 61 | wire, err := opts.Marshal(want) |
Damien Neil | 99f24c3 | 2019-03-13 17:06:42 -0700 | [diff] [blame] | 62 | if err != nil { |
Damien Neil | 61e93c7 | 2019-03-27 09:23:20 -0700 | [diff] [blame] | 63 | t.Fatalf("Marshal error: %v\nMessage:\n%v", err, marshalText(want)) |
Damien Neil | 99f24c3 | 2019-03-13 17:06:42 -0700 | [diff] [blame] | 64 | } |
Damien Neil | 96c229a | 2019-04-03 12:17:24 -0700 | [diff] [blame] | 65 | wire2, err := opts.Marshal(want) |
Damien Neil | 99f24c3 | 2019-03-13 17:06:42 -0700 | [diff] [blame] | 66 | if err != nil { |
Damien Neil | 61e93c7 | 2019-03-27 09:23:20 -0700 | [diff] [blame] | 67 | t.Fatalf("Marshal error: %v\nMessage:\n%v", err, marshalText(want)) |
Damien Neil | 99f24c3 | 2019-03-13 17:06:42 -0700 | [diff] [blame] | 68 | } |
Damien Neil | 99f24c3 | 2019-03-13 17:06:42 -0700 | [diff] [blame] | 69 | if !bytes.Equal(wire, wire2) { |
| 70 | t.Fatalf("deterministic marshal returned varying results:\n%v", cmp.Diff(wire, wire2)) |
| 71 | } |
| 72 | |
Joe Tsai | 378c132 | 2019-04-25 23:48:08 -0700 | [diff] [blame] | 73 | got := want.ProtoReflect().New().Interface() |
Damien Neil | 96c229a | 2019-04-03 12:17:24 -0700 | [diff] [blame] | 74 | uopts := proto.UnmarshalOptions{ |
| 75 | AllowPartial: test.partial, |
| 76 | } |
| 77 | if err := uopts.Unmarshal(wire, got); err != nil { |
Damien Neil | 61e93c7 | 2019-03-27 09:23:20 -0700 | [diff] [blame] | 78 | t.Errorf("Unmarshal error: %v\nMessage:\n%v", err, marshalText(want)) |
Damien Neil | 99f24c3 | 2019-03-13 17:06:42 -0700 | [diff] [blame] | 79 | return |
| 80 | } |
Damien Neil | e6f060f | 2019-04-23 17:11:02 -0700 | [diff] [blame] | 81 | if !proto.Equal(got, want) { |
Damien Neil | 61e93c7 | 2019-03-27 09:23:20 -0700 | [diff] [blame] | 82 | t.Errorf("Unmarshal returned unexpected result; got:\n%v\nwant:\n%v", marshalText(got), marshalText(want)) |
Damien Neil | 99f24c3 | 2019-03-13 17:06:42 -0700 | [diff] [blame] | 83 | } |
| 84 | }) |
| 85 | } |
| 86 | } |
| 87 | } |
Damien Neil | 96c229a | 2019-04-03 12:17:24 -0700 | [diff] [blame] | 88 | |
Damien Neil | bc310b5 | 2019-04-11 11:46:55 -0700 | [diff] [blame] | 89 | func TestEncodeInvalidUTF8(t *testing.T) { |
| 90 | for _, test := range invalidUTF8TestProtos { |
| 91 | for _, want := range test.decodeTo { |
| 92 | t.Run(fmt.Sprintf("%s (%T)", test.desc, want), func(t *testing.T) { |
Damien Neil | 8c86fc5 | 2019-06-19 09:28:29 -0700 | [diff] [blame] | 93 | _, err := proto.Marshal(want) |
| 94 | if err == nil { |
Damien Neil | bc310b5 | 2019-04-11 11:46:55 -0700 | [diff] [blame] | 95 | t.Errorf("Marshal did not return expected error for invalid UTF8: %v\nMessage:\n%v", err, marshalText(want)) |
| 96 | } |
Damien Neil | bc310b5 | 2019-04-11 11:46:55 -0700 | [diff] [blame] | 97 | }) |
| 98 | } |
| 99 | } |
| 100 | } |
| 101 | |
Joe Tsai | c51e2e0 | 2019-07-13 00:44:41 -0700 | [diff] [blame] | 102 | func TestEncodeNoEnforceUTF8(t *testing.T) { |
| 103 | for _, test := range noEnforceUTF8TestProtos { |
| 104 | for _, want := range test.decodeTo { |
| 105 | t.Run(fmt.Sprintf("%s (%T)", test.desc, want), func(t *testing.T) { |
| 106 | _, err := proto.Marshal(want) |
| 107 | switch { |
Joe Tsai | 1799d11 | 2019-08-08 13:31:59 -0700 | [diff] [blame] | 108 | case flags.ProtoLegacy && err != nil: |
Joe Tsai | c51e2e0 | 2019-07-13 00:44:41 -0700 | [diff] [blame] | 109 | t.Errorf("Marshal returned unexpected error: %v\nMessage:\n%v", err, marshalText(want)) |
Joe Tsai | 1799d11 | 2019-08-08 13:31:59 -0700 | [diff] [blame] | 110 | case !flags.ProtoLegacy && err == nil: |
Joe Tsai | c51e2e0 | 2019-07-13 00:44:41 -0700 | [diff] [blame] | 111 | t.Errorf("Marshal did not return expected error for invalid UTF8: %v\nMessage:\n%v", err, marshalText(want)) |
| 112 | } |
| 113 | }) |
| 114 | } |
| 115 | } |
| 116 | } |
| 117 | |
Damien Neil | 96c229a | 2019-04-03 12:17:24 -0700 | [diff] [blame] | 118 | func TestEncodeRequiredFieldChecks(t *testing.T) { |
| 119 | for _, test := range testProtos { |
| 120 | if !test.partial { |
| 121 | continue |
| 122 | } |
| 123 | for _, m := range test.decodeTo { |
| 124 | t.Run(fmt.Sprintf("%s (%T)", test.desc, m), func(t *testing.T) { |
| 125 | _, err := proto.Marshal(m) |
| 126 | if err == nil { |
| 127 | t.Fatalf("Marshal succeeded (want error)\nMessage:\n%v", marshalText(m)) |
| 128 | } |
| 129 | }) |
| 130 | } |
| 131 | } |
| 132 | } |
Damien Neil | 3016b73 | 2019-04-07 12:43:10 -0700 | [diff] [blame] | 133 | |
Joe Tsai | 9b22b93 | 2019-08-08 19:23:32 -0700 | [diff] [blame] | 134 | func TestEncodeAppend(t *testing.T) { |
Damien Neil | 3016b73 | 2019-04-07 12:43:10 -0700 | [diff] [blame] | 135 | want := []byte("prefix") |
| 136 | got := append([]byte(nil), want...) |
| 137 | got, err := proto.MarshalOptions{}.MarshalAppend(got, &test3pb.TestAllTypes{ |
| 138 | OptionalString: "value", |
| 139 | }) |
| 140 | if err != nil { |
| 141 | t.Fatal(err) |
| 142 | } |
| 143 | if !bytes.HasPrefix(got, want) { |
| 144 | t.Fatalf("MarshalAppend modified prefix: got %v, want prefix %v", got, want) |
| 145 | } |
| 146 | } |
Joe Tsai | 9b22b93 | 2019-08-08 19:23:32 -0700 | [diff] [blame] | 147 | |
| 148 | func TestEncodeOneofNilWrapper(t *testing.T) { |
| 149 | m := &testpb.TestAllTypes{OneofField: (*testpb.TestAllTypes_OneofUint32)(nil)} |
| 150 | b, err := proto.Marshal(m) |
| 151 | if err != nil { |
| 152 | t.Fatal(err) |
| 153 | } |
| 154 | if len(b) > 0 { |
| 155 | t.Errorf("Marshal return non-empty, want empty") |
| 156 | } |
| 157 | } |
Damien Neil | 1e5516a | 2019-09-27 14:31:10 -0700 | [diff] [blame^] | 158 | |
| 159 | func TestMarshalAppendAllocations(t *testing.T) { |
| 160 | m := &test3pb.TestAllTypes{OptionalInt32: 1} |
| 161 | size := proto.Size(m) |
| 162 | const count = 1000 |
| 163 | b := make([]byte, size) |
| 164 | // AllocsPerRun returns an integral value. |
| 165 | marshalAllocs := testing.AllocsPerRun(count, func() { |
| 166 | _, err := proto.MarshalOptions{}.MarshalAppend(b[:0], m) |
| 167 | if err != nil { |
| 168 | t.Fatal(err) |
| 169 | } |
| 170 | }) |
| 171 | b = nil |
| 172 | marshalAppendAllocs := testing.AllocsPerRun(count, func() { |
| 173 | var err error |
| 174 | b, err = proto.MarshalOptions{}.MarshalAppend(b, m) |
| 175 | if err != nil { |
| 176 | t.Fatal(err) |
| 177 | } |
| 178 | }) |
| 179 | if marshalAllocs != marshalAppendAllocs { |
| 180 | t.Errorf("%v allocs/op when writing to a preallocated buffer", marshalAllocs) |
| 181 | t.Errorf("%v allocs/op when repeatedly appending to a slice", marshalAppendAllocs) |
| 182 | t.Errorf("expect amortized allocs/op to be identical") |
| 183 | } |
| 184 | } |