blob: 94913206f9bf2b3a7ea1147cbc8698bf7343988b [file] [log] [blame]
avakulenko@google.com554223d2014-12-04 22:00:20 +00001#!/usr/bin/env python
erg@google.com4e00b9a2009-01-12 23:05:11 +00002#
erg@google.com8f91ab22011-09-06 21:04:45 +00003# Copyright (c) 2009 Google Inc. All rights reserved.
erg@google.com4e00b9a2009-01-12 23:05:11 +00004#
erg@google.com969161c2009-06-26 22:06:46 +00005# Redistribution and use in source and binary forms, with or without
6# modification, are permitted provided that the following conditions are
7# met:
erg@google.com4e00b9a2009-01-12 23:05:11 +00008#
erg@google.com969161c2009-06-26 22:06:46 +00009# * Redistributions of source code must retain the above copyright
10# notice, this list of conditions and the following disclaimer.
11# * Redistributions in binary form must reproduce the above
12# copyright notice, this list of conditions and the following disclaimer
13# in the documentation and/or other materials provided with the
14# distribution.
15# * Neither the name of Google Inc. nor the names of its
16# contributors may be used to endorse or promote products derived from
17# this software without specific prior written permission.
erg@google.com4e00b9a2009-01-12 23:05:11 +000018#
erg@google.com969161c2009-06-26 22:06:46 +000019# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
20# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
21# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
22# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
23# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
24# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
25# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
26# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
27# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
28# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
29# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
erg@google.com4e00b9a2009-01-12 23:05:11 +000030
erg@google.com4e00b9a2009-01-12 23:05:11 +000031"""Does google-lint on c++ files.
32
33The goal of this script is to identify places in the code that *may*
34be in non-compliance with google style. It does not attempt to fix
35up these problems -- the point is to educate. It does also not
36attempt to find all problems, or to ensure that everything it does
37find is legitimately a problem.
38
39In particular, we can get very confused by /* and // inside strings!
40We do a small hack, which is to ignore //'s with "'s after them on the
41same line, but it is far from perfect (in either direction).
42"""
43
44import codecs
erg@google.comd350fe52013-01-14 17:51:48 +000045import copy
erg@google.com4e00b9a2009-01-12 23:05:11 +000046import getopt
47import math # for log
48import os
49import re
50import sre_compile
51import string
52import sys
53import unicodedata
54
55
56_USAGE = """
57Syntax: cpplint.py [--verbose=#] [--output=vs7] [--filter=-x,+y,...]
erg@google.comab53edf2013-11-05 22:23:37 +000058 [--counting=total|toplevel|detailed] [--root=subdir]
59 [--linelength=digits]
erg@google.com4e00b9a2009-01-12 23:05:11 +000060 <file> [file] ...
61
62 The style guidelines this tries to follow are those in
Ackermann Yuriy79692902016-04-01 21:41:34 +130063 https://google-styleguide.googlecode.com/svn/trunk/cppguide.xml
erg@google.com4e00b9a2009-01-12 23:05:11 +000064
65 Every problem is given a confidence score from 1-5, with 5 meaning we are
66 certain of the problem, and 1 meaning it could be a legitimate construct.
67 This will miss some errors, and is not a substitute for a code review.
68
erg+personal@google.com05189642010-04-30 20:43:03 +000069 To suppress false-positive errors of a certain category, add a
70 'NOLINT(category)' comment to the line. NOLINT or NOLINT(*)
71 suppresses errors of all categories on that line.
erg@google.com4e00b9a2009-01-12 23:05:11 +000072
73 The files passed in will be linted; at least one file must be provided.
erg@google.com19680272013-12-16 22:48:54 +000074 Default linted extensions are .cc, .cpp, .cu, .cuh and .h. Change the
75 extensions with the --extensions flag.
erg@google.com4e00b9a2009-01-12 23:05:11 +000076
77 Flags:
78
79 output=vs7
80 By default, the output is formatted to ease emacs parsing. Visual Studio
81 compatible output (vs7) may also be used. Other formats are unsupported.
82
83 verbose=#
84 Specify a number 0-5 to restrict errors to certain verbosity levels.
85
86 filter=-x,+y,...
87 Specify a comma-separated list of category-filters to apply: only
88 error messages whose category names pass the filters will be printed.
89 (Category names are printed with the message and look like
90 "[whitespace/indent]".) Filters are evaluated left to right.
91 "-FOO" and "FOO" means "do not print categories that start with FOO".
92 "+FOO" means "do print categories that start with FOO".
93
94 Examples: --filter=-whitespace,+whitespace/braces
95 --filter=whitespace,runtime/printf,+runtime/printf_format
96 --filter=-,+build/include_what_you_use
97
98 To see a list of all the categories used in cpplint, pass no arg:
99 --filter=
erg@google.coma868d2d2009-10-09 21:18:45 +0000100
101 counting=total|toplevel|detailed
102 The total number of errors found is always printed. If
103 'toplevel' is provided, then the count of errors in each of
104 the top-level categories like 'build' and 'whitespace' will
105 also be printed. If 'detailed' is provided, then a count
106 is provided for each category like 'build/class'.
erg@google.com4d70a882013-04-16 21:06:32 +0000107
108 root=subdir
109 The root directory used for deriving header guard CPP variable.
110 By default, the header guard CPP variable is calculated as the relative
111 path to the directory that contains .git, .hg, or .svn. When this flag
112 is specified, the relative path is calculated from the specified
113 directory. If the specified directory does not exist, this flag is
114 ignored.
115
116 Examples:
avakulenko@google.com02af6282014-06-04 18:53:25 +0000117 Assuming that src/.git exists, the header guard CPP variables for
erg@google.com4d70a882013-04-16 21:06:32 +0000118 src/chrome/browser/ui/browser.h are:
119
120 No flag => CHROME_BROWSER_UI_BROWSER_H_
121 --root=chrome => BROWSER_UI_BROWSER_H_
122 --root=chrome/browser => UI_BROWSER_H_
erg@google.comab53edf2013-11-05 22:23:37 +0000123
124 linelength=digits
125 This is the allowed line length for the project. The default value is
126 80 characters.
127
128 Examples:
129 --linelength=120
erg@google.com19680272013-12-16 22:48:54 +0000130
131 extensions=extension,extension,...
132 The allowed file extensions that cpplint will check
133
134 Examples:
135 --extensions=hpp,cpp
erg@google.com7430eef2014-07-28 22:33:46 +0000136
137 cpplint.py supports per-directory configurations specified in CPPLINT.cfg
138 files. CPPLINT.cfg file can contain a number of key=value pairs.
139 Currently the following options are supported:
140
141 set noparent
142 filter=+filter1,-filter2,...
143 exclude_files=regex
avakulenko@google.com310681b2014-08-22 19:38:55 +0000144 linelength=80
erg@google.com7430eef2014-07-28 22:33:46 +0000145
146 "set noparent" option prevents cpplint from traversing directory tree
147 upwards looking for more .cfg files in parent directories. This option
148 is usually placed in the top-level project directory.
149
150 The "filter" option is similar in function to --filter flag. It specifies
151 message filters in addition to the |_DEFAULT_FILTERS| and those specified
152 through --filter command-line flag.
153
154 "exclude_files" allows to specify a regular expression to be matched against
155 a file name. If the expression matches, the file is skipped and not run
156 through liner.
157
avakulenko@google.com310681b2014-08-22 19:38:55 +0000158 "linelength" allows to specify the allowed line length for the project.
159
erg@google.com7430eef2014-07-28 22:33:46 +0000160 CPPLINT.cfg has an effect on files in the same directory and all
161 sub-directories, unless overridden by a nested configuration file.
162
163 Example file:
164 filter=-build/include_order,+build/include_alpha
165 exclude_files=.*\.cc
166
167 The above example disables build/include_order warning and enables
168 build/include_alpha as well as excludes all .cc from being
169 processed by linter, in the current directory (where the .cfg
170 file is located) and all sub-directories.
erg@google.com4e00b9a2009-01-12 23:05:11 +0000171"""
172
173# We categorize each error message we print. Here are the categories.
174# We want an explicit list so we can list them all in cpplint --filter=.
175# If you add a new error message with a new category, add it to the list
176# here! cpplint_unittest.py should tell you if you forget to do this.
erg+personal@google.com05189642010-04-30 20:43:03 +0000177_ERROR_CATEGORIES = [
avakulenko@google.com554223d2014-12-04 22:00:20 +0000178 'build/class',
179 'build/c++11',
Alex Vakulenko01e47232016-05-06 13:54:15 -0700180 'build/c++14',
181 'build/c++tr1',
avakulenko@google.com554223d2014-12-04 22:00:20 +0000182 'build/deprecated',
183 'build/endif_comment',
184 'build/explicit_make_pair',
185 'build/forward_decl',
186 'build/header_guard',
187 'build/include',
188 'build/include_alpha',
189 'build/include_order',
190 'build/include_what_you_use',
191 'build/namespaces',
192 'build/printf_format',
193 'build/storage_class',
194 'legal/copyright',
195 'readability/alt_tokens',
196 'readability/braces',
197 'readability/casting',
198 'readability/check',
199 'readability/constructors',
200 'readability/fn_size',
avakulenko@google.com554223d2014-12-04 22:00:20 +0000201 'readability/inheritance',
202 'readability/multiline_comment',
203 'readability/multiline_string',
204 'readability/namespace',
205 'readability/nolint',
206 'readability/nul',
207 'readability/strings',
208 'readability/todo',
209 'readability/utf8',
210 'runtime/arrays',
211 'runtime/casting',
212 'runtime/explicit',
213 'runtime/int',
214 'runtime/init',
215 'runtime/invalid_increment',
216 'runtime/member_string_references',
217 'runtime/memset',
218 'runtime/indentation_namespace',
219 'runtime/operator',
220 'runtime/printf',
221 'runtime/printf_format',
222 'runtime/references',
223 'runtime/string',
224 'runtime/threadsafe_fn',
225 'runtime/vlog',
226 'whitespace/blank_line',
227 'whitespace/braces',
228 'whitespace/comma',
229 'whitespace/comments',
230 'whitespace/empty_conditional_body',
Alex Vakulenko01e47232016-05-06 13:54:15 -0700231 'whitespace/empty_if_body',
avakulenko@google.com554223d2014-12-04 22:00:20 +0000232 'whitespace/empty_loop_body',
233 'whitespace/end_of_line',
234 'whitespace/ending_newline',
235 'whitespace/forcolon',
236 'whitespace/indent',
237 'whitespace/line_length',
238 'whitespace/newline',
239 'whitespace/operators',
240 'whitespace/parens',
241 'whitespace/semicolon',
242 'whitespace/tab',
243 'whitespace/todo',
244 ]
245
246# These error categories are no longer enforced by cpplint, but for backwards-
247# compatibility they may still appear in NOLINT comments.
248_LEGACY_ERROR_CATEGORIES = [
249 'readability/streams',
Alex Vakulenko01e47232016-05-06 13:54:15 -0700250 'readability/function',
avakulenko@google.com554223d2014-12-04 22:00:20 +0000251 ]
erg@google.com4e00b9a2009-01-12 23:05:11 +0000252
avakulenko@google.com02af6282014-06-04 18:53:25 +0000253# The default state of the category filter. This is overridden by the --filter=
erg@google.come35f7652009-06-19 20:52:09 +0000254# flag. By default all errors are on, so only add here categories that should be
255# off by default (i.e., categories that must be enabled by the --filter= flags).
256# All entries here should start with a '-' or '+', as in the --filter= flag.
erg@google.com8a95ecc2011-09-08 00:45:54 +0000257_DEFAULT_FILTERS = ['-build/include_alpha']
erg@google.come35f7652009-06-19 20:52:09 +0000258
Alex Vakulenko01e47232016-05-06 13:54:15 -0700259# The default list of categories suppressed for C (not C++) files.
260_DEFAULT_C_SUPPRESSED_CATEGORIES = [
261 'readability/casting',
262 ]
263
264# The default list of categories suppressed for Linux Kernel files.
265_DEFAULT_KERNEL_SUPPRESSED_CATEGORIES = [
266 'whitespace/tab',
267 ]
268
erg@google.com4e00b9a2009-01-12 23:05:11 +0000269# We used to check for high-bit characters, but after much discussion we
270# decided those were OK, as long as they were in UTF-8 and didn't represent
erg@google.com8a95ecc2011-09-08 00:45:54 +0000271# hard-coded international strings, which belong in a separate i18n file.
erg@google.com4e00b9a2009-01-12 23:05:11 +0000272
erg@google.comfd5da632013-10-25 17:39:45 +0000273# C++ headers
erg@google.com4e00b9a2009-01-12 23:05:11 +0000274_CPP_HEADERS = frozenset([
erg@google.comfd5da632013-10-25 17:39:45 +0000275 # Legacy
276 'algobase.h',
277 'algo.h',
278 'alloc.h',
279 'builtinbuf.h',
280 'bvector.h',
281 'complex.h',
282 'defalloc.h',
283 'deque.h',
284 'editbuf.h',
285 'fstream.h',
286 'function.h',
287 'hash_map',
288 'hash_map.h',
289 'hash_set',
290 'hash_set.h',
291 'hashtable.h',
292 'heap.h',
293 'indstream.h',
294 'iomanip.h',
295 'iostream.h',
296 'istream.h',
297 'iterator.h',
298 'list.h',
299 'map.h',
300 'multimap.h',
301 'multiset.h',
302 'ostream.h',
303 'pair.h',
304 'parsestream.h',
305 'pfstream.h',
306 'procbuf.h',
307 'pthread_alloc',
308 'pthread_alloc.h',
309 'rope',
310 'rope.h',
311 'ropeimpl.h',
312 'set.h',
313 'slist',
314 'slist.h',
315 'stack.h',
316 'stdiostream.h',
317 'stl_alloc.h',
318 'stl_relops.h',
319 'streambuf.h',
320 'stream.h',
321 'strfile.h',
322 'strstream.h',
323 'tempbuf.h',
324 'tree.h',
325 'type_traits.h',
326 'vector.h',
327 # 17.6.1.2 C++ library headers
328 'algorithm',
329 'array',
330 'atomic',
331 'bitset',
332 'chrono',
333 'codecvt',
334 'complex',
335 'condition_variable',
336 'deque',
337 'exception',
338 'forward_list',
339 'fstream',
340 'functional',
341 'future',
342 'initializer_list',
343 'iomanip',
344 'ios',
345 'iosfwd',
346 'iostream',
347 'istream',
348 'iterator',
349 'limits',
350 'list',
351 'locale',
352 'map',
353 'memory',
354 'mutex',
355 'new',
356 'numeric',
357 'ostream',
358 'queue',
359 'random',
360 'ratio',
361 'regex',
Alex Vakulenko01e47232016-05-06 13:54:15 -0700362 'scoped_allocator',
erg@google.comfd5da632013-10-25 17:39:45 +0000363 'set',
364 'sstream',
365 'stack',
366 'stdexcept',
367 'streambuf',
368 'string',
369 'strstream',
370 'system_error',
371 'thread',
372 'tuple',
373 'typeindex',
374 'typeinfo',
375 'type_traits',
376 'unordered_map',
377 'unordered_set',
378 'utility',
erg@google.com5d00c562013-07-12 19:57:05 +0000379 'valarray',
erg@google.comfd5da632013-10-25 17:39:45 +0000380 'vector',
381 # 17.6.1.2 C++ headers for C library facilities
382 'cassert',
383 'ccomplex',
384 'cctype',
385 'cerrno',
386 'cfenv',
387 'cfloat',
388 'cinttypes',
389 'ciso646',
390 'climits',
391 'clocale',
392 'cmath',
393 'csetjmp',
394 'csignal',
395 'cstdalign',
396 'cstdarg',
397 'cstdbool',
398 'cstddef',
399 'cstdint',
400 'cstdio',
401 'cstdlib',
402 'cstring',
403 'ctgmath',
404 'ctime',
405 'cuchar',
406 'cwchar',
407 'cwctype',
erg@google.com4e00b9a2009-01-12 23:05:11 +0000408 ])
409
Alex Vakulenko01e47232016-05-06 13:54:15 -0700410# Type names
411_TYPES = re.compile(
412 r'^(?:'
413 # [dcl.type.simple]
414 r'(char(16_t|32_t)?)|wchar_t|'
415 r'bool|short|int|long|signed|unsigned|float|double|'
416 # [support.types]
417 r'(ptrdiff_t|size_t|max_align_t|nullptr_t)|'
418 # [cstdint.syn]
419 r'(u?int(_fast|_least)?(8|16|32|64)_t)|'
420 r'(u?int(max|ptr)_t)|'
421 r')$')
422
avakulenko@google.com02af6282014-06-04 18:53:25 +0000423
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +0000424# These headers are excluded from [build/include] and [build/include_order]
425# checks:
426# - Anything not following google file name conventions (containing an
427# uppercase character, such as Python.h or nsStringAPI.h, for example).
428# - Lua headers.
429_THIRD_PARTY_HEADERS_PATTERN = re.compile(
430 r'^(?:[^/]*[A-Z][^/]*\.h|lua\.h|lauxlib\.h|lualib\.h)$')
431
Alex Vakulenko01e47232016-05-06 13:54:15 -0700432# Pattern for matching FileInfo.BaseName() against test file name
433_TEST_FILE_SUFFIX = r'(_test|_unittest|_regtest)$'
434
435# Pattern that matches only complete whitespace, possibly across multiple lines.
436_EMPTY_CONDITIONAL_BODY_PATTERN = re.compile(r'^\s*$', re.DOTALL)
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +0000437
erg@google.com4e00b9a2009-01-12 23:05:11 +0000438# Assertion macros. These are defined in base/logging.h and
Alex Vakulenko01e47232016-05-06 13:54:15 -0700439# testing/base/public/gunit.h.
erg@google.com4e00b9a2009-01-12 23:05:11 +0000440_CHECK_MACROS = [
erg@google.come35f7652009-06-19 20:52:09 +0000441 'DCHECK', 'CHECK',
Alex Vakulenko01e47232016-05-06 13:54:15 -0700442 'EXPECT_TRUE', 'ASSERT_TRUE',
443 'EXPECT_FALSE', 'ASSERT_FALSE',
erg@google.com4e00b9a2009-01-12 23:05:11 +0000444 ]
445
erg@google.come35f7652009-06-19 20:52:09 +0000446# Replacement macros for CHECK/DCHECK/EXPECT_TRUE/EXPECT_FALSE
erg@google.com4e00b9a2009-01-12 23:05:11 +0000447_CHECK_REPLACEMENT = dict([(m, {}) for m in _CHECK_MACROS])
448
449for op, replacement in [('==', 'EQ'), ('!=', 'NE'),
450 ('>=', 'GE'), ('>', 'GT'),
451 ('<=', 'LE'), ('<', 'LT')]:
erg@google.come35f7652009-06-19 20:52:09 +0000452 _CHECK_REPLACEMENT['DCHECK'][op] = 'DCHECK_%s' % replacement
erg@google.com4e00b9a2009-01-12 23:05:11 +0000453 _CHECK_REPLACEMENT['CHECK'][op] = 'CHECK_%s' % replacement
454 _CHECK_REPLACEMENT['EXPECT_TRUE'][op] = 'EXPECT_%s' % replacement
455 _CHECK_REPLACEMENT['ASSERT_TRUE'][op] = 'ASSERT_%s' % replacement
erg@google.com4e00b9a2009-01-12 23:05:11 +0000456
457for op, inv_replacement in [('==', 'NE'), ('!=', 'EQ'),
458 ('>=', 'LT'), ('>', 'LE'),
459 ('<=', 'GT'), ('<', 'GE')]:
460 _CHECK_REPLACEMENT['EXPECT_FALSE'][op] = 'EXPECT_%s' % inv_replacement
461 _CHECK_REPLACEMENT['ASSERT_FALSE'][op] = 'ASSERT_%s' % inv_replacement
erg@google.com4e00b9a2009-01-12 23:05:11 +0000462
erg@google.comd350fe52013-01-14 17:51:48 +0000463# Alternative tokens and their replacements. For full list, see section 2.5
464# Alternative tokens [lex.digraph] in the C++ standard.
465#
466# Digraphs (such as '%:') are not included here since it's a mess to
467# match those on a word boundary.
468_ALT_TOKEN_REPLACEMENT = {
469 'and': '&&',
470 'bitor': '|',
471 'or': '||',
472 'xor': '^',
473 'compl': '~',
474 'bitand': '&',
475 'and_eq': '&=',
476 'or_eq': '|=',
477 'xor_eq': '^=',
478 'not': '!',
479 'not_eq': '!='
480 }
481
482# Compile regular expression that matches all the above keywords. The "[ =()]"
483# bit is meant to avoid matching these keywords outside of boolean expressions.
484#
erg@google.comc6671232013-10-25 21:44:03 +0000485# False positives include C-style multi-line comments and multi-line strings
486# but those have always been troublesome for cpplint.
erg@google.comd350fe52013-01-14 17:51:48 +0000487_ALT_TOKEN_REPLACEMENT_PATTERN = re.compile(
488 r'[ =()](' + ('|'.join(_ALT_TOKEN_REPLACEMENT.keys())) + r')(?=[ (]|$)')
489
erg@google.com4e00b9a2009-01-12 23:05:11 +0000490
491# These constants define types of headers for use with
492# _IncludeState.CheckNextIncludeOrder().
493_C_SYS_HEADER = 1
494_CPP_SYS_HEADER = 2
495_LIKELY_MY_HEADER = 3
496_POSSIBLE_MY_HEADER = 4
497_OTHER_HEADER = 5
498
erg@google.comd350fe52013-01-14 17:51:48 +0000499# These constants define the current inline assembly state
500_NO_ASM = 0 # Outside of inline assembly block
501_INSIDE_ASM = 1 # Inside inline assembly block
502_END_ASM = 2 # Last line of inline assembly block
503_BLOCK_ASM = 3 # The whole block is an inline assembly block
504
505# Match start of assembly blocks
506_MATCH_ASM = re.compile(r'^\s*(?:asm|_asm|__asm|__asm__)'
507 r'(?:\s+(volatile|__volatile__))?'
508 r'\s*[{(]')
509
Alex Vakulenko01e47232016-05-06 13:54:15 -0700510# Match strings that indicate we're working on a C (not C++) file.
511_SEARCH_C_FILE = re.compile(r'\b(?:LINT_C_FILE|'
512 r'vim?:\s*.*(\s*|:)filetype=c(\s*|:|$))')
513
514# Match string that indicates we're working on a Linux Kernel file.
515_SEARCH_KERNEL_FILE = re.compile(r'\b(?:LINT_KERNEL_FILE)')
erg@google.com4e00b9a2009-01-12 23:05:11 +0000516
517_regexp_compile_cache = {}
518
erg+personal@google.com05189642010-04-30 20:43:03 +0000519# {str, set(int)}: a map from error categories to sets of linenumbers
520# on which those errors are expected and should be suppressed.
521_error_suppressions = {}
522
erg@google.com4d70a882013-04-16 21:06:32 +0000523# The root directory used for deriving header guard CPP variable.
524# This is set by --root flag.
525_root = None
526
erg@google.comab53edf2013-11-05 22:23:37 +0000527# The allowed line length of files.
528# This is set by --linelength flag.
529_line_length = 80
530
erg@google.com19680272013-12-16 22:48:54 +0000531# The allowed extensions for file names
532# This is set by --extensions flag.
533_valid_extensions = set(['cc', 'h', 'cpp', 'cu', 'cuh'])
534
Alex Vakulenko01e47232016-05-06 13:54:15 -0700535# {str, bool}: a map from error categories to booleans which indicate if the
536# category should be suppressed for every line.
537_global_error_suppressions = {}
538
539
erg+personal@google.com05189642010-04-30 20:43:03 +0000540def ParseNolintSuppressions(filename, raw_line, linenum, error):
Alex Vakulenko01e47232016-05-06 13:54:15 -0700541 """Updates the global list of line error-suppressions.
erg+personal@google.com05189642010-04-30 20:43:03 +0000542
543 Parses any NOLINT comments on the current line, updating the global
544 error_suppressions store. Reports an error if the NOLINT comment
545 was malformed.
546
547 Args:
548 filename: str, the name of the input file.
549 raw_line: str, the line of input text, with comments.
550 linenum: int, the number of the current line.
551 error: function, an error handler.
552 """
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +0000553 matched = Search(r'\bNOLINT(NEXTLINE)?\b(\([^)]+\))?', raw_line)
erg@google.com8a95ecc2011-09-08 00:45:54 +0000554 if matched:
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +0000555 if matched.group(1):
556 suppressed_line = linenum + 1
557 else:
558 suppressed_line = linenum
559 category = matched.group(2)
erg+personal@google.com05189642010-04-30 20:43:03 +0000560 if category in (None, '(*)'): # => "suppress all"
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +0000561 _error_suppressions.setdefault(None, set()).add(suppressed_line)
erg+personal@google.com05189642010-04-30 20:43:03 +0000562 else:
563 if category.startswith('(') and category.endswith(')'):
564 category = category[1:-1]
565 if category in _ERROR_CATEGORIES:
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +0000566 _error_suppressions.setdefault(category, set()).add(suppressed_line)
avakulenko@google.com554223d2014-12-04 22:00:20 +0000567 elif category not in _LEGACY_ERROR_CATEGORIES:
erg+personal@google.com05189642010-04-30 20:43:03 +0000568 error(filename, linenum, 'readability/nolint', 5,
erg@google.com8a95ecc2011-09-08 00:45:54 +0000569 'Unknown NOLINT error category: %s' % category)
erg+personal@google.com05189642010-04-30 20:43:03 +0000570
571
Alex Vakulenko01e47232016-05-06 13:54:15 -0700572def ProcessGlobalSuppresions(lines):
573 """Updates the list of global error suppressions.
574
575 Parses any lint directives in the file that have global effect.
576
577 Args:
578 lines: An array of strings, each representing a line of the file, with the
579 last element being empty if the file is terminated with a newline.
580 """
581 for line in lines:
582 if _SEARCH_C_FILE.search(line):
583 for category in _DEFAULT_C_SUPPRESSED_CATEGORIES:
584 _global_error_suppressions[category] = True
585 if _SEARCH_KERNEL_FILE.search(line):
586 for category in _DEFAULT_KERNEL_SUPPRESSED_CATEGORIES:
587 _global_error_suppressions[category] = True
588
589
erg+personal@google.com05189642010-04-30 20:43:03 +0000590def ResetNolintSuppressions():
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +0000591 """Resets the set of NOLINT suppressions to empty."""
erg+personal@google.com05189642010-04-30 20:43:03 +0000592 _error_suppressions.clear()
Alex Vakulenko01e47232016-05-06 13:54:15 -0700593 _global_error_suppressions.clear()
erg+personal@google.com05189642010-04-30 20:43:03 +0000594
595
596def IsErrorSuppressedByNolint(category, linenum):
597 """Returns true if the specified error category is suppressed on this line.
598
599 Consults the global error_suppressions map populated by
Alex Vakulenko01e47232016-05-06 13:54:15 -0700600 ParseNolintSuppressions/ProcessGlobalSuppresions/ResetNolintSuppressions.
erg+personal@google.com05189642010-04-30 20:43:03 +0000601
602 Args:
603 category: str, the category of the error.
604 linenum: int, the current line number.
605 Returns:
Alex Vakulenko01e47232016-05-06 13:54:15 -0700606 bool, True iff the error should be suppressed due to a NOLINT comment or
607 global suppression.
erg+personal@google.com05189642010-04-30 20:43:03 +0000608 """
Alex Vakulenko01e47232016-05-06 13:54:15 -0700609 return (_global_error_suppressions.get(category, False) or
610 linenum in _error_suppressions.get(category, set()) or
erg+personal@google.com05189642010-04-30 20:43:03 +0000611 linenum in _error_suppressions.get(None, set()))
erg@google.com4e00b9a2009-01-12 23:05:11 +0000612
avakulenko@google.com02af6282014-06-04 18:53:25 +0000613
erg@google.com4e00b9a2009-01-12 23:05:11 +0000614def Match(pattern, s):
615 """Matches the string with the pattern, caching the compiled regexp."""
616 # The regexp compilation caching is inlined in both Match and Search for
617 # performance reasons; factoring it out into a separate function turns out
618 # to be noticeably expensive.
erg@google.comc6671232013-10-25 21:44:03 +0000619 if pattern not in _regexp_compile_cache:
erg@google.com4e00b9a2009-01-12 23:05:11 +0000620 _regexp_compile_cache[pattern] = sre_compile.compile(pattern)
621 return _regexp_compile_cache[pattern].match(s)
622
623
erg@google.comfd5da632013-10-25 17:39:45 +0000624def ReplaceAll(pattern, rep, s):
625 """Replaces instances of pattern in a string with a replacement.
626
627 The compiled regex is kept in a cache shared by Match and Search.
628
629 Args:
630 pattern: regex pattern
631 rep: replacement text
632 s: search string
633
634 Returns:
635 string with replacements made (or original string if no replacements)
636 """
637 if pattern not in _regexp_compile_cache:
638 _regexp_compile_cache[pattern] = sre_compile.compile(pattern)
639 return _regexp_compile_cache[pattern].sub(rep, s)
640
641
erg@google.com4e00b9a2009-01-12 23:05:11 +0000642def Search(pattern, s):
643 """Searches the string for the pattern, caching the compiled regexp."""
erg@google.comc6671232013-10-25 21:44:03 +0000644 if pattern not in _regexp_compile_cache:
erg@google.com4e00b9a2009-01-12 23:05:11 +0000645 _regexp_compile_cache[pattern] = sre_compile.compile(pattern)
646 return _regexp_compile_cache[pattern].search(s)
647
648
Alex Vakulenko01e47232016-05-06 13:54:15 -0700649def _IsSourceExtension(s):
650 """File extension (excluding dot) matches a source file extension."""
651 return s in ('c', 'cc', 'cpp', 'cxx')
652
653
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +0000654class _IncludeState(object):
erg@google.com4e00b9a2009-01-12 23:05:11 +0000655 """Tracks line numbers for includes, and the order in which includes appear.
656
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +0000657 include_list contains list of lists of (header, line number) pairs.
658 It's a lists of lists rather than just one flat list to make it
659 easier to update across preprocessor boundaries.
erg@google.com4e00b9a2009-01-12 23:05:11 +0000660
661 Call CheckNextIncludeOrder() once for each header in the file, passing
662 in the type constants defined above. Calls in an illegal order will
663 raise an _IncludeError with an appropriate error message.
664
665 """
666 # self._section will move monotonically through this set. If it ever
667 # needs to move backwards, CheckNextIncludeOrder will raise an error.
668 _INITIAL_SECTION = 0
669 _MY_H_SECTION = 1
670 _C_SECTION = 2
671 _CPP_SECTION = 3
672 _OTHER_H_SECTION = 4
673
674 _TYPE_NAMES = {
675 _C_SYS_HEADER: 'C system header',
676 _CPP_SYS_HEADER: 'C++ system header',
677 _LIKELY_MY_HEADER: 'header this file implements',
678 _POSSIBLE_MY_HEADER: 'header this file may implement',
679 _OTHER_HEADER: 'other header',
680 }
681 _SECTION_NAMES = {
682 _INITIAL_SECTION: "... nothing. (This can't be an error.)",
683 _MY_H_SECTION: 'a header this file implements',
684 _C_SECTION: 'C system header',
685 _CPP_SECTION: 'C++ system header',
686 _OTHER_H_SECTION: 'other header',
687 }
688
689 def __init__(self):
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +0000690 self.include_list = [[]]
691 self.ResetSection('')
erg@google.com2aa59982013-10-28 19:09:25 +0000692
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +0000693 def FindHeader(self, header):
694 """Check if a header has already been included.
695
696 Args:
697 header: header to check.
698 Returns:
699 Line number of previous occurrence, or -1 if the header has not
700 been seen before.
701 """
702 for section_list in self.include_list:
703 for f in section_list:
704 if f[0] == header:
705 return f[1]
706 return -1
707
708 def ResetSection(self, directive):
709 """Reset section checking for preprocessor directive.
710
711 Args:
712 directive: preprocessor directive (e.g. "if", "else").
713 """
erg@google.coma868d2d2009-10-09 21:18:45 +0000714 # The name of the current section.
erg@google.com4e00b9a2009-01-12 23:05:11 +0000715 self._section = self._INITIAL_SECTION
erg@google.coma868d2d2009-10-09 21:18:45 +0000716 # The path of last found header.
717 self._last_header = ''
718
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +0000719 # Update list of includes. Note that we never pop from the
720 # include list.
721 if directive in ('if', 'ifdef', 'ifndef'):
722 self.include_list.append([])
723 elif directive in ('else', 'elif'):
724 self.include_list[-1] = []
725
erg@google.comfd5da632013-10-25 17:39:45 +0000726 def SetLastHeader(self, header_path):
727 self._last_header = header_path
728
erg@google.coma868d2d2009-10-09 21:18:45 +0000729 def CanonicalizeAlphabeticalOrder(self, header_path):
erg@google.com8a95ecc2011-09-08 00:45:54 +0000730 """Returns a path canonicalized for alphabetical comparison.
erg@google.coma868d2d2009-10-09 21:18:45 +0000731
732 - replaces "-" with "_" so they both cmp the same.
733 - removes '-inl' since we don't require them to be after the main header.
734 - lowercase everything, just in case.
735
736 Args:
737 header_path: Path to be canonicalized.
738
739 Returns:
740 Canonicalized path.
741 """
742 return header_path.replace('-inl.h', '.h').replace('-', '_').lower()
743
erg@google.comfd5da632013-10-25 17:39:45 +0000744 def IsInAlphabeticalOrder(self, clean_lines, linenum, header_path):
erg@google.coma868d2d2009-10-09 21:18:45 +0000745 """Check if a header is in alphabetical order with the previous header.
746
747 Args:
erg@google.comfd5da632013-10-25 17:39:45 +0000748 clean_lines: A CleansedLines instance containing the file.
749 linenum: The number of the line to check.
750 header_path: Canonicalized header to be checked.
erg@google.coma868d2d2009-10-09 21:18:45 +0000751
752 Returns:
753 Returns true if the header is in alphabetical order.
754 """
erg@google.comfd5da632013-10-25 17:39:45 +0000755 # If previous section is different from current section, _last_header will
756 # be reset to empty string, so it's always less than current header.
757 #
758 # If previous line was a blank line, assume that the headers are
759 # intentionally sorted the way they are.
760 if (self._last_header > header_path and
avakulenko@google.com554223d2014-12-04 22:00:20 +0000761 Match(r'^\s*#\s*include\b', clean_lines.elided[linenum - 1])):
erg@google.coma868d2d2009-10-09 21:18:45 +0000762 return False
erg@google.coma868d2d2009-10-09 21:18:45 +0000763 return True
erg@google.com4e00b9a2009-01-12 23:05:11 +0000764
765 def CheckNextIncludeOrder(self, header_type):
766 """Returns a non-empty error message if the next header is out of order.
767
768 This function also updates the internal state to be ready to check
769 the next include.
770
771 Args:
772 header_type: One of the _XXX_HEADER constants defined above.
773
774 Returns:
775 The empty string if the header is in the right order, or an
776 error message describing what's wrong.
777
778 """
779 error_message = ('Found %s after %s' %
780 (self._TYPE_NAMES[header_type],
781 self._SECTION_NAMES[self._section]))
782
erg@google.coma868d2d2009-10-09 21:18:45 +0000783 last_section = self._section
784
erg@google.com4e00b9a2009-01-12 23:05:11 +0000785 if header_type == _C_SYS_HEADER:
786 if self._section <= self._C_SECTION:
787 self._section = self._C_SECTION
788 else:
erg@google.coma868d2d2009-10-09 21:18:45 +0000789 self._last_header = ''
erg@google.com4e00b9a2009-01-12 23:05:11 +0000790 return error_message
791 elif header_type == _CPP_SYS_HEADER:
792 if self._section <= self._CPP_SECTION:
793 self._section = self._CPP_SECTION
794 else:
erg@google.coma868d2d2009-10-09 21:18:45 +0000795 self._last_header = ''
erg@google.com4e00b9a2009-01-12 23:05:11 +0000796 return error_message
797 elif header_type == _LIKELY_MY_HEADER:
798 if self._section <= self._MY_H_SECTION:
799 self._section = self._MY_H_SECTION
800 else:
801 self._section = self._OTHER_H_SECTION
802 elif header_type == _POSSIBLE_MY_HEADER:
803 if self._section <= self._MY_H_SECTION:
804 self._section = self._MY_H_SECTION
805 else:
806 # This will always be the fallback because we're not sure
807 # enough that the header is associated with this file.
808 self._section = self._OTHER_H_SECTION
809 else:
810 assert header_type == _OTHER_HEADER
811 self._section = self._OTHER_H_SECTION
812
erg@google.coma868d2d2009-10-09 21:18:45 +0000813 if last_section != self._section:
814 self._last_header = ''
815
erg@google.com4e00b9a2009-01-12 23:05:11 +0000816 return ''
817
818
819class _CppLintState(object):
820 """Maintains module-wide state.."""
821
822 def __init__(self):
823 self.verbose_level = 1 # global setting.
824 self.error_count = 0 # global count of reported errors
erg@google.come35f7652009-06-19 20:52:09 +0000825 # filters to apply when emitting error messages
826 self.filters = _DEFAULT_FILTERS[:]
erg@google.com7430eef2014-07-28 22:33:46 +0000827 # backup of filter list. Used to restore the state after each file.
828 self._filters_backup = self.filters[:]
erg@google.coma868d2d2009-10-09 21:18:45 +0000829 self.counting = 'total' # In what way are we counting errors?
830 self.errors_by_category = {} # string to int dict storing error counts
erg@google.com4e00b9a2009-01-12 23:05:11 +0000831
832 # output format:
833 # "emacs" - format that emacs can parse (default)
834 # "vs7" - format that Microsoft Visual Studio 7 can parse
835 self.output_format = 'emacs'
836
837 def SetOutputFormat(self, output_format):
838 """Sets the output format for errors."""
839 self.output_format = output_format
840
841 def SetVerboseLevel(self, level):
842 """Sets the module's verbosity, and returns the previous setting."""
843 last_verbose_level = self.verbose_level
844 self.verbose_level = level
845 return last_verbose_level
846
erg@google.coma868d2d2009-10-09 21:18:45 +0000847 def SetCountingStyle(self, counting_style):
848 """Sets the module's counting options."""
849 self.counting = counting_style
850
erg@google.com4e00b9a2009-01-12 23:05:11 +0000851 def SetFilters(self, filters):
852 """Sets the error-message filters.
853
854 These filters are applied when deciding whether to emit a given
855 error message.
856
857 Args:
858 filters: A string of comma-separated filters (eg "+whitespace/indent").
859 Each filter should start with + or -; else we die.
erg@google.coma87abb82009-02-24 01:41:01 +0000860
861 Raises:
862 ValueError: The comma-separated filters did not all start with '+' or '-'.
863 E.g. "-,+whitespace,-whitespace/indent,whitespace/badfilter"
erg@google.com4e00b9a2009-01-12 23:05:11 +0000864 """
erg@google.come35f7652009-06-19 20:52:09 +0000865 # Default filters always have less priority than the flag ones.
866 self.filters = _DEFAULT_FILTERS[:]
erg@google.com7430eef2014-07-28 22:33:46 +0000867 self.AddFilters(filters)
868
869 def AddFilters(self, filters):
870 """ Adds more filters to the existing list of error-message filters. """
erg@google.come35f7652009-06-19 20:52:09 +0000871 for filt in filters.split(','):
872 clean_filt = filt.strip()
873 if clean_filt:
874 self.filters.append(clean_filt)
erg@google.com4e00b9a2009-01-12 23:05:11 +0000875 for filt in self.filters:
876 if not (filt.startswith('+') or filt.startswith('-')):
877 raise ValueError('Every filter in --filters must start with + or -'
878 ' (%s does not)' % filt)
879
erg@google.com7430eef2014-07-28 22:33:46 +0000880 def BackupFilters(self):
881 """ Saves the current filter list to backup storage."""
882 self._filters_backup = self.filters[:]
883
884 def RestoreFilters(self):
885 """ Restores filters previously backed up."""
886 self.filters = self._filters_backup[:]
887
erg@google.coma868d2d2009-10-09 21:18:45 +0000888 def ResetErrorCounts(self):
erg@google.com4e00b9a2009-01-12 23:05:11 +0000889 """Sets the module's error statistic back to zero."""
890 self.error_count = 0
erg@google.coma868d2d2009-10-09 21:18:45 +0000891 self.errors_by_category = {}
erg@google.com4e00b9a2009-01-12 23:05:11 +0000892
erg@google.coma868d2d2009-10-09 21:18:45 +0000893 def IncrementErrorCount(self, category):
erg@google.com4e00b9a2009-01-12 23:05:11 +0000894 """Bumps the module's error statistic."""
895 self.error_count += 1
erg@google.coma868d2d2009-10-09 21:18:45 +0000896 if self.counting in ('toplevel', 'detailed'):
897 if self.counting != 'detailed':
898 category = category.split('/')[0]
899 if category not in self.errors_by_category:
900 self.errors_by_category[category] = 0
901 self.errors_by_category[category] += 1
erg@google.com4e00b9a2009-01-12 23:05:11 +0000902
erg@google.coma868d2d2009-10-09 21:18:45 +0000903 def PrintErrorCounts(self):
904 """Print a summary of errors by category, and the total."""
905 for category, count in self.errors_by_category.iteritems():
906 sys.stderr.write('Category \'%s\' errors found: %d\n' %
907 (category, count))
908 sys.stderr.write('Total errors found: %d\n' % self.error_count)
erg@google.com4e00b9a2009-01-12 23:05:11 +0000909
910_cpplint_state = _CppLintState()
911
912
913def _OutputFormat():
914 """Gets the module's output format."""
915 return _cpplint_state.output_format
916
917
918def _SetOutputFormat(output_format):
919 """Sets the module's output format."""
920 _cpplint_state.SetOutputFormat(output_format)
921
922
923def _VerboseLevel():
924 """Returns the module's verbosity setting."""
925 return _cpplint_state.verbose_level
926
927
928def _SetVerboseLevel(level):
929 """Sets the module's verbosity, and returns the previous setting."""
930 return _cpplint_state.SetVerboseLevel(level)
931
932
erg@google.coma868d2d2009-10-09 21:18:45 +0000933def _SetCountingStyle(level):
934 """Sets the module's counting options."""
935 _cpplint_state.SetCountingStyle(level)
936
937
erg@google.com4e00b9a2009-01-12 23:05:11 +0000938def _Filters():
939 """Returns the module's list of output filters, as a list."""
940 return _cpplint_state.filters
941
942
943def _SetFilters(filters):
944 """Sets the module's error-message filters.
945
946 These filters are applied when deciding whether to emit a given
947 error message.
948
949 Args:
950 filters: A string of comma-separated filters (eg "whitespace/indent").
951 Each filter should start with + or -; else we die.
952 """
953 _cpplint_state.SetFilters(filters)
954
erg@google.com7430eef2014-07-28 22:33:46 +0000955def _AddFilters(filters):
956 """Adds more filter overrides.
957
958 Unlike _SetFilters, this function does not reset the current list of filters
959 available.
960
961 Args:
962 filters: A string of comma-separated filters (eg "whitespace/indent").
963 Each filter should start with + or -; else we die.
964 """
965 _cpplint_state.AddFilters(filters)
966
967def _BackupFilters():
968 """ Saves the current filter list to backup storage."""
969 _cpplint_state.BackupFilters()
970
971def _RestoreFilters():
972 """ Restores filters previously backed up."""
973 _cpplint_state.RestoreFilters()
erg@google.com4e00b9a2009-01-12 23:05:11 +0000974
975class _FunctionState(object):
976 """Tracks current function name and the number of lines in its body."""
977
978 _NORMAL_TRIGGER = 250 # for --v=0, 500 for --v=1, etc.
979 _TEST_TRIGGER = 400 # about 50% more than _NORMAL_TRIGGER.
980
981 def __init__(self):
982 self.in_a_function = False
983 self.lines_in_function = 0
984 self.current_function = ''
985
986 def Begin(self, function_name):
987 """Start analyzing function body.
988
989 Args:
990 function_name: The name of the function being tracked.
991 """
992 self.in_a_function = True
993 self.lines_in_function = 0
994 self.current_function = function_name
995
996 def Count(self):
997 """Count line in current function body."""
998 if self.in_a_function:
999 self.lines_in_function += 1
1000
1001 def Check(self, error, filename, linenum):
1002 """Report if too many lines in function body.
1003
1004 Args:
1005 error: The function to call with any errors found.
1006 filename: The name of the current file.
1007 linenum: The number of the line to check.
1008 """
Alex Vakulenko01e47232016-05-06 13:54:15 -07001009 if not self.in_a_function:
1010 return
1011
erg@google.com4e00b9a2009-01-12 23:05:11 +00001012 if Match(r'T(EST|est)', self.current_function):
1013 base_trigger = self._TEST_TRIGGER
1014 else:
1015 base_trigger = self._NORMAL_TRIGGER
1016 trigger = base_trigger * 2**_VerboseLevel()
1017
1018 if self.lines_in_function > trigger:
1019 error_level = int(math.log(self.lines_in_function / base_trigger, 2))
1020 # 50 => 0, 100 => 1, 200 => 2, 400 => 3, 800 => 4, 1600 => 5, ...
1021 if error_level > 5:
1022 error_level = 5
1023 error(filename, linenum, 'readability/fn_size', error_level,
1024 'Small and focused functions are preferred:'
1025 ' %s has %d non-comment lines'
1026 ' (error triggered by exceeding %d lines).' % (
1027 self.current_function, self.lines_in_function, trigger))
1028
1029 def End(self):
erg@google.com8a95ecc2011-09-08 00:45:54 +00001030 """Stop analyzing function body."""
erg@google.com4e00b9a2009-01-12 23:05:11 +00001031 self.in_a_function = False
1032
1033
1034class _IncludeError(Exception):
1035 """Indicates a problem with the include order in a file."""
1036 pass
1037
1038
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00001039class FileInfo(object):
erg@google.com4e00b9a2009-01-12 23:05:11 +00001040 """Provides utility functions for filenames.
1041
1042 FileInfo provides easy access to the components of a file's path
1043 relative to the project root.
1044 """
1045
1046 def __init__(self, filename):
1047 self._filename = filename
1048
1049 def FullName(self):
1050 """Make Windows paths like Unix."""
1051 return os.path.abspath(self._filename).replace('\\', '/')
1052
1053 def RepositoryName(self):
1054 """FullName after removing the local path to the repository.
1055
1056 If we have a real absolute path name here we can try to do something smart:
1057 detecting the root of the checkout and truncating /path/to/checkout from
1058 the name so that we get header guards that don't include things like
1059 "C:\Documents and Settings\..." or "/home/username/..." in them and thus
1060 people on different computers who have checked the source out to different
1061 locations won't see bogus errors.
1062 """
1063 fullname = self.FullName()
1064
1065 if os.path.exists(fullname):
1066 project_dir = os.path.dirname(fullname)
1067
1068 if os.path.exists(os.path.join(project_dir, ".svn")):
1069 # If there's a .svn file in the current directory, we recursively look
1070 # up the directory tree for the top of the SVN checkout
1071 root_dir = project_dir
1072 one_up_dir = os.path.dirname(root_dir)
1073 while os.path.exists(os.path.join(one_up_dir, ".svn")):
1074 root_dir = os.path.dirname(root_dir)
1075 one_up_dir = os.path.dirname(one_up_dir)
1076
1077 prefix = os.path.commonprefix([root_dir, project_dir])
1078 return fullname[len(prefix) + 1:]
1079
erg@google.com3dc74262011-11-30 01:12:00 +00001080 # Not SVN <= 1.6? Try to find a git, hg, or svn top level directory by
1081 # searching up from the current path.
Alex Vakulenko01e47232016-05-06 13:54:15 -07001082 root_dir = current_dir = os.path.dirname(fullname)
1083 while current_dir != os.path.dirname(current_dir):
1084 if (os.path.exists(os.path.join(current_dir, ".git")) or
1085 os.path.exists(os.path.join(current_dir, ".hg")) or
1086 os.path.exists(os.path.join(current_dir, ".svn"))):
1087 root_dir = current_dir
1088 current_dir = os.path.dirname(current_dir)
erg@google.com42e59b02010-10-04 22:18:07 +00001089
1090 if (os.path.exists(os.path.join(root_dir, ".git")) or
erg@google.com3dc74262011-11-30 01:12:00 +00001091 os.path.exists(os.path.join(root_dir, ".hg")) or
1092 os.path.exists(os.path.join(root_dir, ".svn"))):
erg@google.com42e59b02010-10-04 22:18:07 +00001093 prefix = os.path.commonprefix([root_dir, project_dir])
1094 return fullname[len(prefix) + 1:]
erg@google.com4e00b9a2009-01-12 23:05:11 +00001095
1096 # Don't know what to do; header guard warnings may be wrong...
1097 return fullname
1098
1099 def Split(self):
1100 """Splits the file into the directory, basename, and extension.
1101
1102 For 'chrome/browser/browser.cc', Split() would
1103 return ('chrome/browser', 'browser', '.cc')
1104
1105 Returns:
1106 A tuple of (directory, basename, extension).
1107 """
1108
1109 googlename = self.RepositoryName()
1110 project, rest = os.path.split(googlename)
1111 return (project,) + os.path.splitext(rest)
1112
1113 def BaseName(self):
1114 """File base name - text after the final slash, before the final period."""
1115 return self.Split()[1]
1116
1117 def Extension(self):
1118 """File extension - text following the final period."""
1119 return self.Split()[2]
1120
1121 def NoExtension(self):
1122 """File has no source file extension."""
1123 return '/'.join(self.Split()[0:2])
1124
1125 def IsSource(self):
1126 """File has a source file extension."""
Alex Vakulenko01e47232016-05-06 13:54:15 -07001127 return _IsSourceExtension(self.Extension()[1:])
erg@google.com4e00b9a2009-01-12 23:05:11 +00001128
1129
erg+personal@google.com05189642010-04-30 20:43:03 +00001130def _ShouldPrintError(category, confidence, linenum):
erg@google.com8a95ecc2011-09-08 00:45:54 +00001131 """If confidence >= verbose, category passes filter and is not suppressed."""
erg+personal@google.com05189642010-04-30 20:43:03 +00001132
1133 # There are three ways we might decide not to print an error message:
1134 # a "NOLINT(category)" comment appears in the source,
erg@google.com4e00b9a2009-01-12 23:05:11 +00001135 # the verbosity level isn't high enough, or the filters filter it out.
erg+personal@google.com05189642010-04-30 20:43:03 +00001136 if IsErrorSuppressedByNolint(category, linenum):
1137 return False
avakulenko@google.com02af6282014-06-04 18:53:25 +00001138
erg@google.com4e00b9a2009-01-12 23:05:11 +00001139 if confidence < _cpplint_state.verbose_level:
1140 return False
1141
1142 is_filtered = False
1143 for one_filter in _Filters():
1144 if one_filter.startswith('-'):
1145 if category.startswith(one_filter[1:]):
1146 is_filtered = True
1147 elif one_filter.startswith('+'):
1148 if category.startswith(one_filter[1:]):
1149 is_filtered = False
1150 else:
1151 assert False # should have been checked for in SetFilter.
1152 if is_filtered:
1153 return False
1154
1155 return True
1156
1157
1158def Error(filename, linenum, category, confidence, message):
1159 """Logs the fact we've found a lint error.
1160
1161 We log where the error was found, and also our confidence in the error,
1162 that is, how certain we are this is a legitimate style regression, and
1163 not a misidentification or a use that's sometimes justified.
1164
erg+personal@google.com05189642010-04-30 20:43:03 +00001165 False positives can be suppressed by the use of
1166 "cpplint(category)" comments on the offending line. These are
1167 parsed into _error_suppressions.
1168
erg@google.com4e00b9a2009-01-12 23:05:11 +00001169 Args:
1170 filename: The name of the file containing the error.
1171 linenum: The number of the line containing the error.
1172 category: A string used to describe the "category" this bug
1173 falls under: "whitespace", say, or "runtime". Categories
1174 may have a hierarchy separated by slashes: "whitespace/indent".
1175 confidence: A number from 1-5 representing a confidence score for
1176 the error, with 5 meaning that we are certain of the problem,
1177 and 1 meaning that it could be a legitimate construct.
1178 message: The error message.
1179 """
erg+personal@google.com05189642010-04-30 20:43:03 +00001180 if _ShouldPrintError(category, confidence, linenum):
erg@google.coma868d2d2009-10-09 21:18:45 +00001181 _cpplint_state.IncrementErrorCount(category)
erg@google.com4e00b9a2009-01-12 23:05:11 +00001182 if _cpplint_state.output_format == 'vs7':
1183 sys.stderr.write('%s(%s): %s [%s] [%d]\n' % (
1184 filename, linenum, message, category, confidence))
erg@google.com02c27fd2013-05-28 21:34:34 +00001185 elif _cpplint_state.output_format == 'eclipse':
1186 sys.stderr.write('%s:%s: warning: %s [%s] [%d]\n' % (
1187 filename, linenum, message, category, confidence))
erg@google.com4e00b9a2009-01-12 23:05:11 +00001188 else:
1189 sys.stderr.write('%s:%s: %s [%s] [%d]\n' % (
1190 filename, linenum, message, category, confidence))
1191
1192
erg@google.com2aa59982013-10-28 19:09:25 +00001193# Matches standard C++ escape sequences per 2.13.2.3 of the C++ standard.
erg@google.com4e00b9a2009-01-12 23:05:11 +00001194_RE_PATTERN_CLEANSE_LINE_ESCAPES = re.compile(
1195 r'\\([abfnrtv?"\\\']|\d+|x[0-9a-fA-F]+)')
avakulenko@google.com02af6282014-06-04 18:53:25 +00001196# Match a single C style comment on the same line.
1197_RE_PATTERN_C_COMMENTS = r'/\*(?:[^*]|\*(?!/))*\*/'
1198# Matches multi-line C style comments.
erg@google.com4e00b9a2009-01-12 23:05:11 +00001199# This RE is a little bit more complicated than one might expect, because we
1200# have to take care of space removals tools so we can handle comments inside
1201# statements better.
1202# The current rule is: We only clear spaces from both sides when we're at the
1203# end of the line. Otherwise, we try to remove spaces from the right side,
1204# if this doesn't work we try on left side but only if there's a non-character
1205# on the right.
1206_RE_PATTERN_CLEANSE_LINE_C_COMMENTS = re.compile(
avakulenko@google.com02af6282014-06-04 18:53:25 +00001207 r'(\s*' + _RE_PATTERN_C_COMMENTS + r'\s*$|' +
1208 _RE_PATTERN_C_COMMENTS + r'\s+|' +
1209 r'\s+' + _RE_PATTERN_C_COMMENTS + r'(?=\W)|' +
1210 _RE_PATTERN_C_COMMENTS + r')')
erg@google.com4e00b9a2009-01-12 23:05:11 +00001211
1212
1213def IsCppString(line):
1214 """Does line terminate so, that the next symbol is in string constant.
1215
1216 This function does not consider single-line nor multi-line comments.
1217
1218 Args:
1219 line: is a partial line of code starting from the 0..n.
1220
1221 Returns:
1222 True, if next character appended to 'line' is inside a
1223 string constant.
1224 """
1225
1226 line = line.replace(r'\\', 'XX') # after this, \\" does not match to \"
1227 return ((line.count('"') - line.count(r'\"') - line.count("'\"'")) & 1) == 1
1228
1229
erg@google.com2aa59982013-10-28 19:09:25 +00001230def CleanseRawStrings(raw_lines):
1231 """Removes C++11 raw strings from lines.
1232
1233 Before:
1234 static const char kData[] = R"(
1235 multi-line string
1236 )";
1237
1238 After:
1239 static const char kData[] = ""
1240 (replaced by blank line)
1241 "";
1242
1243 Args:
1244 raw_lines: list of raw lines.
1245
1246 Returns:
1247 list of lines with C++11 raw strings replaced by empty strings.
1248 """
1249
1250 delimiter = None
1251 lines_without_raw_strings = []
1252 for line in raw_lines:
1253 if delimiter:
1254 # Inside a raw string, look for the end
1255 end = line.find(delimiter)
1256 if end >= 0:
1257 # Found the end of the string, match leading space for this
1258 # line and resume copying the original lines, and also insert
1259 # a "" on the last line.
1260 leading_space = Match(r'^(\s*)\S', line)
1261 line = leading_space.group(1) + '""' + line[end + len(delimiter):]
1262 delimiter = None
1263 else:
1264 # Haven't found the end yet, append a blank line.
avakulenko@google.com02af6282014-06-04 18:53:25 +00001265 line = '""'
erg@google.com2aa59982013-10-28 19:09:25 +00001266
avakulenko@google.com02af6282014-06-04 18:53:25 +00001267 # Look for beginning of a raw string, and replace them with
1268 # empty strings. This is done in a loop to handle multiple raw
1269 # strings on the same line.
1270 while delimiter is None:
erg@google.com2aa59982013-10-28 19:09:25 +00001271 # Look for beginning of a raw string.
1272 # See 2.14.15 [lex.string] for syntax.
Alex Vakulenko01e47232016-05-06 13:54:15 -07001273 #
1274 # Once we have matched a raw string, we check the prefix of the
1275 # line to make sure that the line is not part of a single line
1276 # comment. It's done this way because we remove raw strings
1277 # before removing comments as opposed to removing comments
1278 # before removing raw strings. This is because there are some
1279 # cpplint checks that requires the comments to be preserved, but
1280 # we don't want to check comments that are inside raw strings.
1281 matched = Match(r'^(.*?)\b(?:R|u8R|uR|UR|LR)"([^\s\\()]*)\((.*)$', line)
1282 if (matched and
1283 not Match(r'^([^\'"]|\'(\\.|[^\'])*\'|"(\\.|[^"])*")*//',
1284 matched.group(1))):
erg@google.com2aa59982013-10-28 19:09:25 +00001285 delimiter = ')' + matched.group(2) + '"'
1286
1287 end = matched.group(3).find(delimiter)
1288 if end >= 0:
1289 # Raw string ended on same line
1290 line = (matched.group(1) + '""' +
1291 matched.group(3)[end + len(delimiter):])
1292 delimiter = None
1293 else:
1294 # Start of a multi-line raw string
1295 line = matched.group(1) + '""'
avakulenko@google.com02af6282014-06-04 18:53:25 +00001296 else:
1297 break
erg@google.com2aa59982013-10-28 19:09:25 +00001298
1299 lines_without_raw_strings.append(line)
1300
1301 # TODO(unknown): if delimiter is not None here, we might want to
1302 # emit a warning for unterminated string.
1303 return lines_without_raw_strings
1304
1305
erg@google.com4e00b9a2009-01-12 23:05:11 +00001306def FindNextMultiLineCommentStart(lines, lineix):
1307 """Find the beginning marker for a multiline comment."""
1308 while lineix < len(lines):
1309 if lines[lineix].strip().startswith('/*'):
1310 # Only return this marker if the comment goes beyond this line
1311 if lines[lineix].strip().find('*/', 2) < 0:
1312 return lineix
1313 lineix += 1
1314 return len(lines)
1315
1316
1317def FindNextMultiLineCommentEnd(lines, lineix):
1318 """We are inside a comment, find the end marker."""
1319 while lineix < len(lines):
1320 if lines[lineix].strip().endswith('*/'):
1321 return lineix
1322 lineix += 1
1323 return len(lines)
1324
1325
1326def RemoveMultiLineCommentsFromRange(lines, begin, end):
1327 """Clears a range of lines for multi-line comments."""
1328 # Having // dummy comments makes the lines non-empty, so we will not get
1329 # unnecessary blank line warnings later in the code.
1330 for i in range(begin, end):
avakulenko@google.com554223d2014-12-04 22:00:20 +00001331 lines[i] = '/**/'
erg@google.com4e00b9a2009-01-12 23:05:11 +00001332
1333
1334def RemoveMultiLineComments(filename, lines, error):
1335 """Removes multiline (c-style) comments from lines."""
1336 lineix = 0
1337 while lineix < len(lines):
1338 lineix_begin = FindNextMultiLineCommentStart(lines, lineix)
1339 if lineix_begin >= len(lines):
1340 return
1341 lineix_end = FindNextMultiLineCommentEnd(lines, lineix_begin)
1342 if lineix_end >= len(lines):
1343 error(filename, lineix_begin + 1, 'readability/multiline_comment', 5,
1344 'Could not find end of multi-line comment')
1345 return
1346 RemoveMultiLineCommentsFromRange(lines, lineix_begin, lineix_end + 1)
1347 lineix = lineix_end + 1
1348
1349
1350def CleanseComments(line):
1351 """Removes //-comments and single-line C-style /* */ comments.
1352
1353 Args:
1354 line: A line of C++ source.
1355
1356 Returns:
1357 The line with single-line comments removed.
1358 """
1359 commentpos = line.find('//')
1360 if commentpos != -1 and not IsCppString(line[:commentpos]):
erg@google.comd7d27472011-09-07 17:36:35 +00001361 line = line[:commentpos].rstrip()
erg@google.com4e00b9a2009-01-12 23:05:11 +00001362 # get rid of /* ... */
1363 return _RE_PATTERN_CLEANSE_LINE_C_COMMENTS.sub('', line)
1364
1365
erg@google.coma87abb82009-02-24 01:41:01 +00001366class CleansedLines(object):
avakulenko@google.com554223d2014-12-04 22:00:20 +00001367 """Holds 4 copies of all lines with different preprocessing applied to them.
erg@google.com4e00b9a2009-01-12 23:05:11 +00001368
avakulenko@google.com554223d2014-12-04 22:00:20 +00001369 1) elided member contains lines without strings and comments.
1370 2) lines member contains lines without comments.
erg@google.comd350fe52013-01-14 17:51:48 +00001371 3) raw_lines member contains all the lines without processing.
avakulenko@google.com554223d2014-12-04 22:00:20 +00001372 4) lines_without_raw_strings member is same as raw_lines, but with C++11 raw
1373 strings removed.
1374 All these members are of <type 'list'>, and of the same length.
erg@google.com4e00b9a2009-01-12 23:05:11 +00001375 """
1376
1377 def __init__(self, lines):
1378 self.elided = []
1379 self.lines = []
1380 self.raw_lines = lines
1381 self.num_lines = len(lines)
erg@google.com2aa59982013-10-28 19:09:25 +00001382 self.lines_without_raw_strings = CleanseRawStrings(lines)
1383 for linenum in range(len(self.lines_without_raw_strings)):
1384 self.lines.append(CleanseComments(
1385 self.lines_without_raw_strings[linenum]))
1386 elided = self._CollapseStrings(self.lines_without_raw_strings[linenum])
erg@google.com4e00b9a2009-01-12 23:05:11 +00001387 self.elided.append(CleanseComments(elided))
1388
1389 def NumLines(self):
1390 """Returns the number of lines represented."""
1391 return self.num_lines
1392
1393 @staticmethod
1394 def _CollapseStrings(elided):
1395 """Collapses strings and chars on a line to simple "" or '' blocks.
1396
1397 We nix strings first so we're not fooled by text like '"http://"'
1398
1399 Args:
1400 elided: The line being processed.
1401
1402 Returns:
1403 The line with collapsed strings.
1404 """
avakulenko@google.com02af6282014-06-04 18:53:25 +00001405 if _RE_PATTERN_INCLUDE.match(elided):
1406 return elided
1407
1408 # Remove escaped characters first to make quote/single quote collapsing
1409 # basic. Things that look like escaped characters shouldn't occur
1410 # outside of strings and chars.
1411 elided = _RE_PATTERN_CLEANSE_LINE_ESCAPES.sub('', elided)
1412
1413 # Replace quoted strings and digit separators. Both single quotes
1414 # and double quotes are processed in the same loop, otherwise
1415 # nested quotes wouldn't work.
1416 collapsed = ''
1417 while True:
1418 # Find the first quote character
1419 match = Match(r'^([^\'"]*)([\'"])(.*)$', elided)
1420 if not match:
1421 collapsed += elided
1422 break
1423 head, quote, tail = match.groups()
1424
1425 if quote == '"':
1426 # Collapse double quoted strings
1427 second_quote = tail.find('"')
1428 if second_quote >= 0:
1429 collapsed += head + '""'
1430 elided = tail[second_quote + 1:]
1431 else:
1432 # Unmatched double quote, don't bother processing the rest
1433 # of the line since this is probably a multiline string.
1434 collapsed += elided
1435 break
1436 else:
1437 # Found single quote, check nearby text to eliminate digit separators.
1438 #
1439 # There is no special handling for floating point here, because
1440 # the integer/fractional/exponent parts would all be parsed
1441 # correctly as long as there are digits on both sides of the
1442 # separator. So we are fine as long as we don't see something
1443 # like "0.'3" (gcc 4.9.0 will not allow this literal).
1444 if Search(r'\b(?:0[bBxX]?|[1-9])[0-9a-fA-F]*$', head):
1445 match_literal = Match(r'^((?:\'?[0-9a-zA-Z_])*)(.*)$', "'" + tail)
1446 collapsed += head + match_literal.group(1).replace("'", '')
1447 elided = match_literal.group(2)
1448 else:
1449 second_quote = tail.find('\'')
1450 if second_quote >= 0:
1451 collapsed += head + "''"
1452 elided = tail[second_quote + 1:]
1453 else:
1454 # Unmatched single quote
1455 collapsed += elided
1456 break
1457
1458 return collapsed
erg@google.com4e00b9a2009-01-12 23:05:11 +00001459
1460
avakulenko@google.com02af6282014-06-04 18:53:25 +00001461def FindEndOfExpressionInLine(line, startpos, stack):
1462 """Find the position just after the end of current parenthesized expression.
erg@google.comd350fe52013-01-14 17:51:48 +00001463
1464 Args:
1465 line: a CleansedLines line.
1466 startpos: start searching at this position.
avakulenko@google.com02af6282014-06-04 18:53:25 +00001467 stack: nesting stack at startpos.
erg@google.comd350fe52013-01-14 17:51:48 +00001468
1469 Returns:
avakulenko@google.com02af6282014-06-04 18:53:25 +00001470 On finding matching end: (index just after matching end, None)
1471 On finding an unclosed expression: (-1, None)
1472 Otherwise: (-1, new stack at end of this line)
erg@google.comd350fe52013-01-14 17:51:48 +00001473 """
1474 for i in xrange(startpos, len(line)):
avakulenko@google.com02af6282014-06-04 18:53:25 +00001475 char = line[i]
1476 if char in '([{':
1477 # Found start of parenthesized expression, push to expression stack
1478 stack.append(char)
1479 elif char == '<':
1480 # Found potential start of template argument list
1481 if i > 0 and line[i - 1] == '<':
1482 # Left shift operator
1483 if stack and stack[-1] == '<':
1484 stack.pop()
1485 if not stack:
1486 return (-1, None)
1487 elif i > 0 and Search(r'\boperator\s*$', line[0:i]):
1488 # operator<, don't add to stack
1489 continue
1490 else:
1491 # Tentative start of template argument list
1492 stack.append('<')
1493 elif char in ')]}':
1494 # Found end of parenthesized expression.
1495 #
1496 # If we are currently expecting a matching '>', the pending '<'
1497 # must have been an operator. Remove them from expression stack.
1498 while stack and stack[-1] == '<':
1499 stack.pop()
1500 if not stack:
1501 return (-1, None)
1502 if ((stack[-1] == '(' and char == ')') or
1503 (stack[-1] == '[' and char == ']') or
1504 (stack[-1] == '{' and char == '}')):
1505 stack.pop()
1506 if not stack:
1507 return (i + 1, None)
1508 else:
1509 # Mismatched parentheses
1510 return (-1, None)
1511 elif char == '>':
1512 # Found potential end of template argument list.
1513
1514 # Ignore "->" and operator functions
1515 if (i > 0 and
1516 (line[i - 1] == '-' or Search(r'\boperator\s*$', line[0:i - 1]))):
1517 continue
1518
1519 # Pop the stack if there is a matching '<'. Otherwise, ignore
1520 # this '>' since it must be an operator.
1521 if stack:
1522 if stack[-1] == '<':
1523 stack.pop()
1524 if not stack:
1525 return (i + 1, None)
1526 elif char == ';':
1527 # Found something that look like end of statements. If we are currently
1528 # expecting a '>', the matching '<' must have been an operator, since
1529 # template argument list should not contain statements.
1530 while stack and stack[-1] == '<':
1531 stack.pop()
1532 if not stack:
1533 return (-1, None)
1534
1535 # Did not find end of expression or unbalanced parentheses on this line
1536 return (-1, stack)
erg@google.comd350fe52013-01-14 17:51:48 +00001537
1538
erg@google.com4e00b9a2009-01-12 23:05:11 +00001539def CloseExpression(clean_lines, linenum, pos):
erg@google.com2aa59982013-10-28 19:09:25 +00001540 """If input points to ( or { or [ or <, finds the position that closes it.
erg@google.com4e00b9a2009-01-12 23:05:11 +00001541
erg@google.com2aa59982013-10-28 19:09:25 +00001542 If lines[linenum][pos] points to a '(' or '{' or '[' or '<', finds the
erg@google.com4e00b9a2009-01-12 23:05:11 +00001543 linenum/pos that correspond to the closing of the expression.
1544
avakulenko@google.com02af6282014-06-04 18:53:25 +00001545 TODO(unknown): cpplint spends a fair bit of time matching parentheses.
1546 Ideally we would want to index all opening and closing parentheses once
1547 and have CloseExpression be just a simple lookup, but due to preprocessor
1548 tricks, this is not so easy.
1549
erg@google.com4e00b9a2009-01-12 23:05:11 +00001550 Args:
1551 clean_lines: A CleansedLines instance containing the file.
1552 linenum: The number of the line to check.
1553 pos: A position on the line.
1554
1555 Returns:
1556 A tuple (line, linenum, pos) pointer *past* the closing brace, or
1557 (line, len(lines), -1) if we never find a close. Note we ignore
1558 strings and comments when matching; and the line we return is the
1559 'cleansed' line at linenum.
1560 """
1561
1562 line = clean_lines.elided[linenum]
avakulenko@google.com02af6282014-06-04 18:53:25 +00001563 if (line[pos] not in '({[<') or Match(r'<[<=]', line[pos:]):
erg@google.com4e00b9a2009-01-12 23:05:11 +00001564 return (line, clean_lines.NumLines(), -1)
erg@google.com4e00b9a2009-01-12 23:05:11 +00001565
erg@google.comd350fe52013-01-14 17:51:48 +00001566 # Check first line
avakulenko@google.com02af6282014-06-04 18:53:25 +00001567 (end_pos, stack) = FindEndOfExpressionInLine(line, pos, [])
erg@google.comd350fe52013-01-14 17:51:48 +00001568 if end_pos > -1:
1569 return (line, linenum, end_pos)
erg@google.com2aa59982013-10-28 19:09:25 +00001570
1571 # Continue scanning forward
avakulenko@google.com02af6282014-06-04 18:53:25 +00001572 while stack and linenum < clean_lines.NumLines() - 1:
erg@google.com4e00b9a2009-01-12 23:05:11 +00001573 linenum += 1
1574 line = clean_lines.elided[linenum]
avakulenko@google.com02af6282014-06-04 18:53:25 +00001575 (end_pos, stack) = FindEndOfExpressionInLine(line, 0, stack)
erg@google.com2aa59982013-10-28 19:09:25 +00001576 if end_pos > -1:
1577 return (line, linenum, end_pos)
erg@google.com4e00b9a2009-01-12 23:05:11 +00001578
avakulenko@google.com02af6282014-06-04 18:53:25 +00001579 # Did not find end of expression before end of file, give up
erg@google.comd350fe52013-01-14 17:51:48 +00001580 return (line, clean_lines.NumLines(), -1)
erg@google.com4e00b9a2009-01-12 23:05:11 +00001581
erg@google.com2aa59982013-10-28 19:09:25 +00001582
avakulenko@google.com02af6282014-06-04 18:53:25 +00001583def FindStartOfExpressionInLine(line, endpos, stack):
1584 """Find position at the matching start of current expression.
erg@google.com2aa59982013-10-28 19:09:25 +00001585
1586 This is almost the reverse of FindEndOfExpressionInLine, but note
1587 that the input position and returned position differs by 1.
1588
1589 Args:
1590 line: a CleansedLines line.
1591 endpos: start searching at this position.
avakulenko@google.com02af6282014-06-04 18:53:25 +00001592 stack: nesting stack at endpos.
erg@google.com2aa59982013-10-28 19:09:25 +00001593
1594 Returns:
avakulenko@google.com02af6282014-06-04 18:53:25 +00001595 On finding matching start: (index at matching start, None)
1596 On finding an unclosed expression: (-1, None)
1597 Otherwise: (-1, new stack at beginning of this line)
erg@google.com2aa59982013-10-28 19:09:25 +00001598 """
avakulenko@google.com02af6282014-06-04 18:53:25 +00001599 i = endpos
1600 while i >= 0:
1601 char = line[i]
1602 if char in ')]}':
1603 # Found end of expression, push to expression stack
1604 stack.append(char)
1605 elif char == '>':
1606 # Found potential end of template argument list.
1607 #
1608 # Ignore it if it's a "->" or ">=" or "operator>"
1609 if (i > 0 and
1610 (line[i - 1] == '-' or
1611 Match(r'\s>=\s', line[i - 1:]) or
1612 Search(r'\boperator\s*$', line[0:i]))):
1613 i -= 1
1614 else:
1615 stack.append('>')
1616 elif char == '<':
1617 # Found potential start of template argument list
1618 if i > 0 and line[i - 1] == '<':
1619 # Left shift operator
1620 i -= 1
1621 else:
1622 # If there is a matching '>', we can pop the expression stack.
1623 # Otherwise, ignore this '<' since it must be an operator.
1624 if stack and stack[-1] == '>':
1625 stack.pop()
1626 if not stack:
1627 return (i, None)
1628 elif char in '([{':
1629 # Found start of expression.
1630 #
1631 # If there are any unmatched '>' on the stack, they must be
1632 # operators. Remove those.
1633 while stack and stack[-1] == '>':
1634 stack.pop()
1635 if not stack:
1636 return (-1, None)
1637 if ((char == '(' and stack[-1] == ')') or
1638 (char == '[' and stack[-1] == ']') or
1639 (char == '{' and stack[-1] == '}')):
1640 stack.pop()
1641 if not stack:
1642 return (i, None)
1643 else:
1644 # Mismatched parentheses
1645 return (-1, None)
1646 elif char == ';':
1647 # Found something that look like end of statements. If we are currently
1648 # expecting a '<', the matching '>' must have been an operator, since
1649 # template argument list should not contain statements.
1650 while stack and stack[-1] == '>':
1651 stack.pop()
1652 if not stack:
1653 return (-1, None)
1654
1655 i -= 1
1656
1657 return (-1, stack)
erg@google.com2aa59982013-10-28 19:09:25 +00001658
1659
1660def ReverseCloseExpression(clean_lines, linenum, pos):
1661 """If input points to ) or } or ] or >, finds the position that opens it.
1662
1663 If lines[linenum][pos] points to a ')' or '}' or ']' or '>', finds the
1664 linenum/pos that correspond to the opening of the expression.
1665
1666 Args:
1667 clean_lines: A CleansedLines instance containing the file.
1668 linenum: The number of the line to check.
1669 pos: A position on the line.
1670
1671 Returns:
1672 A tuple (line, linenum, pos) pointer *at* the opening brace, or
1673 (line, 0, -1) if we never find the matching opening brace. Note
1674 we ignore strings and comments when matching; and the line we
1675 return is the 'cleansed' line at linenum.
1676 """
1677 line = clean_lines.elided[linenum]
avakulenko@google.com02af6282014-06-04 18:53:25 +00001678 if line[pos] not in ')}]>':
erg@google.com2aa59982013-10-28 19:09:25 +00001679 return (line, 0, -1)
erg@google.com2aa59982013-10-28 19:09:25 +00001680
1681 # Check last line
avakulenko@google.com02af6282014-06-04 18:53:25 +00001682 (start_pos, stack) = FindStartOfExpressionInLine(line, pos, [])
erg@google.com2aa59982013-10-28 19:09:25 +00001683 if start_pos > -1:
1684 return (line, linenum, start_pos)
1685
1686 # Continue scanning backward
avakulenko@google.com02af6282014-06-04 18:53:25 +00001687 while stack and linenum > 0:
erg@google.com2aa59982013-10-28 19:09:25 +00001688 linenum -= 1
1689 line = clean_lines.elided[linenum]
avakulenko@google.com02af6282014-06-04 18:53:25 +00001690 (start_pos, stack) = FindStartOfExpressionInLine(line, len(line) - 1, stack)
erg@google.com2aa59982013-10-28 19:09:25 +00001691 if start_pos > -1:
1692 return (line, linenum, start_pos)
1693
avakulenko@google.com02af6282014-06-04 18:53:25 +00001694 # Did not find start of expression before beginning of file, give up
erg@google.com2aa59982013-10-28 19:09:25 +00001695 return (line, 0, -1)
1696
1697
erg@google.com4e00b9a2009-01-12 23:05:11 +00001698def CheckForCopyright(filename, lines, error):
1699 """Logs an error if no Copyright message appears at the top of the file."""
1700
1701 # We'll say it should occur by line 10. Don't forget there's a
1702 # dummy line at the front.
1703 for line in xrange(1, min(len(lines), 11)):
1704 if re.search(r'Copyright', lines[line], re.I): break
1705 else: # means no copyright line was found
1706 error(filename, 0, 'legal/copyright', 5,
1707 'No copyright message found. '
1708 'You should have a line: "Copyright [year] <Copyright Owner>"')
1709
1710
avakulenko@google.com02af6282014-06-04 18:53:25 +00001711def GetIndentLevel(line):
1712 """Return the number of leading spaces in line.
1713
1714 Args:
1715 line: A string to check.
1716
1717 Returns:
1718 An integer count of leading spaces, possibly zero.
1719 """
1720 indent = Match(r'^( *)\S', line)
1721 if indent:
1722 return len(indent.group(1))
1723 else:
1724 return 0
1725
1726
erg@google.com4e00b9a2009-01-12 23:05:11 +00001727def GetHeaderGuardCPPVariable(filename):
1728 """Returns the CPP variable that should be used as a header guard.
1729
1730 Args:
1731 filename: The name of a C++ header file.
1732
1733 Returns:
1734 The CPP variable that should be used as a header guard in the
1735 named file.
1736
1737 """
1738
erg+personal@google.com05189642010-04-30 20:43:03 +00001739 # Restores original filename in case that cpplint is invoked from Emacs's
1740 # flymake.
1741 filename = re.sub(r'_flymake\.h$', '.h', filename)
erg@google.comd350fe52013-01-14 17:51:48 +00001742 filename = re.sub(r'/\.flymake/([^/]*)$', r'/\1', filename)
avakulenko@google.com554223d2014-12-04 22:00:20 +00001743 # Replace 'c++' with 'cpp'.
1744 filename = filename.replace('C++', 'cpp').replace('c++', 'cpp')
Alex Vakulenko01e47232016-05-06 13:54:15 -07001745
erg@google.com4e00b9a2009-01-12 23:05:11 +00001746 fileinfo = FileInfo(filename)
erg@google.com4d70a882013-04-16 21:06:32 +00001747 file_path_from_root = fileinfo.RepositoryName()
1748 if _root:
1749 file_path_from_root = re.sub('^' + _root + os.sep, '', file_path_from_root)
avakulenko@google.com554223d2014-12-04 22:00:20 +00001750 return re.sub(r'[^a-zA-Z0-9]', '_', file_path_from_root).upper() + '_'
erg@google.com4e00b9a2009-01-12 23:05:11 +00001751
1752
avakulenko@google.com554223d2014-12-04 22:00:20 +00001753def CheckForHeaderGuard(filename, clean_lines, error):
erg@google.com4e00b9a2009-01-12 23:05:11 +00001754 """Checks that the file contains a header guard.
1755
erg@google.coma87abb82009-02-24 01:41:01 +00001756 Logs an error if no #ifndef header guard is present. For other
erg@google.com4e00b9a2009-01-12 23:05:11 +00001757 headers, checks that the full pathname is used.
1758
1759 Args:
1760 filename: The name of the C++ header file.
avakulenko@google.com554223d2014-12-04 22:00:20 +00001761 clean_lines: A CleansedLines instance containing the file.
erg@google.com4e00b9a2009-01-12 23:05:11 +00001762 error: The function to call with any errors found.
1763 """
1764
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00001765 # Don't check for header guards if there are error suppression
1766 # comments somewhere in this file.
1767 #
1768 # Because this is silencing a warning for a nonexistent line, we
1769 # only support the very specific NOLINT(build/header_guard) syntax,
1770 # and not the general NOLINT or NOLINT(*) syntax.
avakulenko@google.com554223d2014-12-04 22:00:20 +00001771 raw_lines = clean_lines.lines_without_raw_strings
1772 for i in raw_lines:
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00001773 if Search(r'//\s*NOLINT\(build/header_guard\)', i):
1774 return
1775
erg@google.com4e00b9a2009-01-12 23:05:11 +00001776 cppvar = GetHeaderGuardCPPVariable(filename)
1777
avakulenko@google.com554223d2014-12-04 22:00:20 +00001778 ifndef = ''
erg@google.com4e00b9a2009-01-12 23:05:11 +00001779 ifndef_linenum = 0
avakulenko@google.com554223d2014-12-04 22:00:20 +00001780 define = ''
1781 endif = ''
erg@google.com4e00b9a2009-01-12 23:05:11 +00001782 endif_linenum = 0
avakulenko@google.com554223d2014-12-04 22:00:20 +00001783 for linenum, line in enumerate(raw_lines):
erg@google.com4e00b9a2009-01-12 23:05:11 +00001784 linesplit = line.split()
1785 if len(linesplit) >= 2:
1786 # find the first occurrence of #ifndef and #define, save arg
1787 if not ifndef and linesplit[0] == '#ifndef':
1788 # set ifndef to the header guard presented on the #ifndef line.
1789 ifndef = linesplit[1]
1790 ifndef_linenum = linenum
1791 if not define and linesplit[0] == '#define':
1792 define = linesplit[1]
1793 # find the last occurrence of #endif, save entire line
1794 if line.startswith('#endif'):
1795 endif = line
1796 endif_linenum = linenum
1797
avakulenko@google.com554223d2014-12-04 22:00:20 +00001798 if not ifndef or not define or ifndef != define:
erg@google.com4e00b9a2009-01-12 23:05:11 +00001799 error(filename, 0, 'build/header_guard', 5,
1800 'No #ifndef header guard found, suggested CPP variable is: %s' %
1801 cppvar)
1802 return
1803
1804 # The guard should be PATH_FILE_H_, but we also allow PATH_FILE_H__
1805 # for backward compatibility.
erg+personal@google.com05189642010-04-30 20:43:03 +00001806 if ifndef != cppvar:
erg@google.com4e00b9a2009-01-12 23:05:11 +00001807 error_level = 0
1808 if ifndef != cppvar + '_':
1809 error_level = 5
1810
avakulenko@google.com554223d2014-12-04 22:00:20 +00001811 ParseNolintSuppressions(filename, raw_lines[ifndef_linenum], ifndef_linenum,
erg+personal@google.com05189642010-04-30 20:43:03 +00001812 error)
erg@google.com4e00b9a2009-01-12 23:05:11 +00001813 error(filename, ifndef_linenum, 'build/header_guard', error_level,
1814 '#ifndef header guard has wrong style, please use: %s' % cppvar)
1815
avakulenko@google.com554223d2014-12-04 22:00:20 +00001816 # Check for "//" comments on endif line.
1817 ParseNolintSuppressions(filename, raw_lines[endif_linenum], endif_linenum,
1818 error)
1819 match = Match(r'#endif\s*//\s*' + cppvar + r'(_)?\b', endif)
1820 if match:
1821 if match.group(1) == '_':
1822 # Issue low severity warning for deprecated double trailing underscore
1823 error(filename, endif_linenum, 'build/header_guard', 0,
1824 '#endif line should be "#endif // %s"' % cppvar)
erg@google.comdc289702012-01-26 20:30:03 +00001825 return
1826
avakulenko@google.com554223d2014-12-04 22:00:20 +00001827 # Didn't find the corresponding "//" comment. If this file does not
1828 # contain any "//" comments at all, it could be that the compiler
1829 # only wants "/**/" comments, look for those instead.
1830 no_single_line_comments = True
1831 for i in xrange(1, len(raw_lines) - 1):
1832 line = raw_lines[i]
1833 if Match(r'^(?:(?:\'(?:\.|[^\'])*\')|(?:"(?:\.|[^"])*")|[^\'"])*//', line):
1834 no_single_line_comments = False
1835 break
erg@google.com4e00b9a2009-01-12 23:05:11 +00001836
avakulenko@google.com554223d2014-12-04 22:00:20 +00001837 if no_single_line_comments:
1838 match = Match(r'#endif\s*/\*\s*' + cppvar + r'(_)?\s*\*/', endif)
1839 if match:
1840 if match.group(1) == '_':
1841 # Low severity warning for double trailing underscore
1842 error(filename, endif_linenum, 'build/header_guard', 0,
1843 '#endif line should be "#endif /* %s */"' % cppvar)
1844 return
1845
1846 # Didn't find anything
1847 error(filename, endif_linenum, 'build/header_guard', 5,
1848 '#endif line should be "#endif // %s"' % cppvar)
1849
1850
1851def CheckHeaderFileIncluded(filename, include_state, error):
1852 """Logs an error if a .cc file does not include its header."""
1853
1854 # Do not check test files
Alex Vakulenko01e47232016-05-06 13:54:15 -07001855 fileinfo = FileInfo(filename)
1856 if Search(_TEST_FILE_SUFFIX, fileinfo.BaseName()):
avakulenko@google.com554223d2014-12-04 22:00:20 +00001857 return
1858
Alex Vakulenko01e47232016-05-06 13:54:15 -07001859 headerfile = filename[0:len(filename) - len(fileinfo.Extension())] + '.h'
avakulenko@google.com554223d2014-12-04 22:00:20 +00001860 if not os.path.exists(headerfile):
1861 return
1862 headername = FileInfo(headerfile).RepositoryName()
1863 first_include = 0
1864 for section_list in include_state.include_list:
1865 for f in section_list:
1866 if headername in f[0] or f[0] in headername:
1867 return
1868 if not first_include:
1869 first_include = f[1]
1870
1871 error(filename, first_include, 'build/include', 5,
1872 '%s should include its header file %s' % (fileinfo.RepositoryName(),
1873 headername))
erg@google.com4e00b9a2009-01-12 23:05:11 +00001874
1875
erg@google.com2aa59982013-10-28 19:09:25 +00001876def CheckForBadCharacters(filename, lines, error):
1877 """Logs an error for each line containing bad characters.
erg@google.com4e00b9a2009-01-12 23:05:11 +00001878
erg@google.com2aa59982013-10-28 19:09:25 +00001879 Two kinds of bad characters:
1880
1881 1. Unicode replacement characters: These indicate that either the file
1882 contained invalid UTF-8 (likely) or Unicode replacement characters (which
1883 it shouldn't). Note that it's possible for this to throw off line
1884 numbering if the invalid UTF-8 occurred adjacent to a newline.
1885
1886 2. NUL bytes. These are problematic for some tools.
erg@google.com4e00b9a2009-01-12 23:05:11 +00001887
1888 Args:
1889 filename: The name of the current file.
1890 lines: An array of strings, each representing a line of the file.
1891 error: The function to call with any errors found.
1892 """
1893 for linenum, line in enumerate(lines):
1894 if u'\ufffd' in line:
1895 error(filename, linenum, 'readability/utf8', 5,
1896 'Line contains invalid UTF-8 (or Unicode replacement character).')
erg@google.com2aa59982013-10-28 19:09:25 +00001897 if '\0' in line:
1898 error(filename, linenum, 'readability/nul', 5, 'Line contains NUL byte.')
erg@google.com4e00b9a2009-01-12 23:05:11 +00001899
1900
1901def CheckForNewlineAtEOF(filename, lines, error):
1902 """Logs an error if there is no newline char at the end of the file.
1903
1904 Args:
1905 filename: The name of the current file.
1906 lines: An array of strings, each representing a line of the file.
1907 error: The function to call with any errors found.
1908 """
1909
1910 # The array lines() was created by adding two newlines to the
1911 # original file (go figure), then splitting on \n.
1912 # To verify that the file ends in \n, we just have to make sure the
1913 # last-but-two element of lines() exists and is empty.
1914 if len(lines) < 3 or lines[-2]:
1915 error(filename, len(lines) - 2, 'whitespace/ending_newline', 5,
1916 'Could not find a newline character at the end of the file.')
1917
1918
1919def CheckForMultilineCommentsAndStrings(filename, clean_lines, linenum, error):
1920 """Logs an error if we see /* ... */ or "..." that extend past one line.
1921
1922 /* ... */ comments are legit inside macros, for one line.
1923 Otherwise, we prefer // comments, so it's ok to warn about the
1924 other. Likewise, it's ok for strings to extend across multiple
1925 lines, as long as a line continuation character (backslash)
1926 terminates each line. Although not currently prohibited by the C++
1927 style guide, it's ugly and unnecessary. We don't do well with either
1928 in this lint program, so we warn about both.
1929
1930 Args:
1931 filename: The name of the current file.
1932 clean_lines: A CleansedLines instance containing the file.
1933 linenum: The number of the line to check.
1934 error: The function to call with any errors found.
1935 """
1936 line = clean_lines.elided[linenum]
1937
1938 # Remove all \\ (escaped backslashes) from the line. They are OK, and the
1939 # second (escaped) slash may trigger later \" detection erroneously.
1940 line = line.replace('\\\\', '')
1941
1942 if line.count('/*') > line.count('*/'):
1943 error(filename, linenum, 'readability/multiline_comment', 5,
1944 'Complex multi-line /*...*/-style comment found. '
1945 'Lint may give bogus warnings. '
1946 'Consider replacing these with //-style comments, '
1947 'with #if 0...#endif, '
1948 'or with more clearly structured multi-line comments.')
1949
1950 if (line.count('"') - line.count('\\"')) % 2:
1951 error(filename, linenum, 'readability/multiline_string', 5,
1952 'Multi-line string ("...") found. This lint script doesn\'t '
erg@google.com2aa59982013-10-28 19:09:25 +00001953 'do well with such strings, and may give bogus warnings. '
1954 'Use C++11 raw strings or concatenation instead.')
erg@google.com4e00b9a2009-01-12 23:05:11 +00001955
1956
avakulenko@google.com02af6282014-06-04 18:53:25 +00001957# (non-threadsafe name, thread-safe alternative, validation pattern)
1958#
1959# The validation pattern is used to eliminate false positives such as:
1960# _rand(); // false positive due to substring match.
1961# ->rand(); // some member function rand().
1962# ACMRandom rand(seed); // some variable named rand.
1963# ISAACRandom rand(); // another variable named rand.
1964#
1965# Basically we require the return value of these functions to be used
1966# in some expression context on the same line by matching on some
1967# operator before the function name. This eliminates constructors and
1968# member function calls.
1969_UNSAFE_FUNC_PREFIX = r'(?:[-+*/=%^&|(<]\s*|>\s+)'
1970_THREADING_LIST = (
1971 ('asctime(', 'asctime_r(', _UNSAFE_FUNC_PREFIX + r'asctime\([^)]+\)'),
1972 ('ctime(', 'ctime_r(', _UNSAFE_FUNC_PREFIX + r'ctime\([^)]+\)'),
1973 ('getgrgid(', 'getgrgid_r(', _UNSAFE_FUNC_PREFIX + r'getgrgid\([^)]+\)'),
1974 ('getgrnam(', 'getgrnam_r(', _UNSAFE_FUNC_PREFIX + r'getgrnam\([^)]+\)'),
1975 ('getlogin(', 'getlogin_r(', _UNSAFE_FUNC_PREFIX + r'getlogin\(\)'),
1976 ('getpwnam(', 'getpwnam_r(', _UNSAFE_FUNC_PREFIX + r'getpwnam\([^)]+\)'),
1977 ('getpwuid(', 'getpwuid_r(', _UNSAFE_FUNC_PREFIX + r'getpwuid\([^)]+\)'),
1978 ('gmtime(', 'gmtime_r(', _UNSAFE_FUNC_PREFIX + r'gmtime\([^)]+\)'),
1979 ('localtime(', 'localtime_r(', _UNSAFE_FUNC_PREFIX + r'localtime\([^)]+\)'),
1980 ('rand(', 'rand_r(', _UNSAFE_FUNC_PREFIX + r'rand\(\)'),
1981 ('strtok(', 'strtok_r(',
1982 _UNSAFE_FUNC_PREFIX + r'strtok\([^)]+\)'),
1983 ('ttyname(', 'ttyname_r(', _UNSAFE_FUNC_PREFIX + r'ttyname\([^)]+\)'),
erg@google.com4e00b9a2009-01-12 23:05:11 +00001984 )
1985
1986
1987def CheckPosixThreading(filename, clean_lines, linenum, error):
1988 """Checks for calls to thread-unsafe functions.
1989
1990 Much code has been originally written without consideration of
1991 multi-threading. Also, engineers are relying on their old experience;
1992 they have learned posix before threading extensions were added. These
1993 tests guide the engineers to use thread-safe functions (when using
1994 posix directly).
1995
1996 Args:
1997 filename: The name of the current file.
1998 clean_lines: A CleansedLines instance containing the file.
1999 linenum: The number of the line to check.
2000 error: The function to call with any errors found.
2001 """
2002 line = clean_lines.elided[linenum]
avakulenko@google.com02af6282014-06-04 18:53:25 +00002003 for single_thread_func, multithread_safe_func, pattern in _THREADING_LIST:
2004 # Additional pattern matching check to confirm that this is the
2005 # function we are looking for
2006 if Search(pattern, line):
erg@google.com4e00b9a2009-01-12 23:05:11 +00002007 error(filename, linenum, 'runtime/threadsafe_fn', 2,
avakulenko@google.com02af6282014-06-04 18:53:25 +00002008 'Consider using ' + multithread_safe_func +
2009 '...) instead of ' + single_thread_func +
erg@google.com4e00b9a2009-01-12 23:05:11 +00002010 '...) for improved thread safety.')
2011
2012
erg@google.com2aa59982013-10-28 19:09:25 +00002013def CheckVlogArguments(filename, clean_lines, linenum, error):
2014 """Checks that VLOG() is only used for defining a logging level.
2015
2016 For example, VLOG(2) is correct. VLOG(INFO), VLOG(WARNING), VLOG(ERROR), and
2017 VLOG(FATAL) are not.
2018
2019 Args:
2020 filename: The name of the current file.
2021 clean_lines: A CleansedLines instance containing the file.
2022 linenum: The number of the line to check.
2023 error: The function to call with any errors found.
2024 """
2025 line = clean_lines.elided[linenum]
2026 if Search(r'\bVLOG\((INFO|ERROR|WARNING|DFATAL|FATAL)\)', line):
2027 error(filename, linenum, 'runtime/vlog', 5,
2028 'VLOG() should be used with numeric verbosity level. '
2029 'Use LOG() if you want symbolic severity levels.')
2030
erg@google.coma868d2d2009-10-09 21:18:45 +00002031# Matches invalid increment: *count++, which moves pointer instead of
erg@google.com36649102009-03-25 21:18:36 +00002032# incrementing a value.
erg@google.coma868d2d2009-10-09 21:18:45 +00002033_RE_PATTERN_INVALID_INCREMENT = re.compile(
erg@google.com36649102009-03-25 21:18:36 +00002034 r'^\s*\*\w+(\+\+|--);')
2035
2036
2037def CheckInvalidIncrement(filename, clean_lines, linenum, error):
erg@google.coma868d2d2009-10-09 21:18:45 +00002038 """Checks for invalid increment *count++.
erg@google.com36649102009-03-25 21:18:36 +00002039
2040 For example following function:
2041 void increment_counter(int* count) {
2042 *count++;
2043 }
2044 is invalid, because it effectively does count++, moving pointer, and should
2045 be replaced with ++*count, (*count)++ or *count += 1.
2046
2047 Args:
2048 filename: The name of the current file.
2049 clean_lines: A CleansedLines instance containing the file.
2050 linenum: The number of the line to check.
2051 error: The function to call with any errors found.
2052 """
2053 line = clean_lines.elided[linenum]
erg@google.coma868d2d2009-10-09 21:18:45 +00002054 if _RE_PATTERN_INVALID_INCREMENT.match(line):
erg@google.com36649102009-03-25 21:18:36 +00002055 error(filename, linenum, 'runtime/invalid_increment', 5,
2056 'Changing pointer instead of value (or unused value of operator*).')
2057
2058
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00002059def IsMacroDefinition(clean_lines, linenum):
2060 if Search(r'^#define', clean_lines[linenum]):
2061 return True
2062
2063 if linenum > 0 and Search(r'\\$', clean_lines[linenum - 1]):
2064 return True
2065
2066 return False
2067
2068
2069def IsForwardClassDeclaration(clean_lines, linenum):
2070 return Match(r'^\s*(\btemplate\b)*.*class\s+\w+;\s*$', clean_lines[linenum])
2071
2072
erg@google.comd350fe52013-01-14 17:51:48 +00002073class _BlockInfo(object):
2074 """Stores information about a generic block of code."""
2075
Alex Vakulenko01e47232016-05-06 13:54:15 -07002076 def __init__(self, linenum, seen_open_brace):
2077 self.starting_linenum = linenum
erg@google.comd350fe52013-01-14 17:51:48 +00002078 self.seen_open_brace = seen_open_brace
2079 self.open_parentheses = 0
2080 self.inline_asm = _NO_ASM
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00002081 self.check_namespace_indentation = False
erg@google.comd350fe52013-01-14 17:51:48 +00002082
2083 def CheckBegin(self, filename, clean_lines, linenum, error):
2084 """Run checks that applies to text up to the opening brace.
2085
2086 This is mostly for checking the text after the class identifier
2087 and the "{", usually where the base class is specified. For other
2088 blocks, there isn't much to check, so we always pass.
2089
2090 Args:
2091 filename: The name of the current file.
2092 clean_lines: A CleansedLines instance containing the file.
2093 linenum: The number of the line to check.
2094 error: The function to call with any errors found.
2095 """
2096 pass
2097
2098 def CheckEnd(self, filename, clean_lines, linenum, error):
2099 """Run checks that applies to text after the closing brace.
2100
2101 This is mostly used for checking end of namespace comments.
2102
2103 Args:
2104 filename: The name of the current file.
2105 clean_lines: A CleansedLines instance containing the file.
2106 linenum: The number of the line to check.
2107 error: The function to call with any errors found.
2108 """
2109 pass
2110
avakulenko@google.com02af6282014-06-04 18:53:25 +00002111 def IsBlockInfo(self):
2112 """Returns true if this block is a _BlockInfo.
2113
2114 This is convenient for verifying that an object is an instance of
2115 a _BlockInfo, but not an instance of any of the derived classes.
2116
2117 Returns:
2118 True for this class, False for derived classes.
2119 """
2120 return self.__class__ == _BlockInfo
2121
2122
2123class _ExternCInfo(_BlockInfo):
2124 """Stores information about an 'extern "C"' block."""
2125
Alex Vakulenko01e47232016-05-06 13:54:15 -07002126 def __init__(self, linenum):
2127 _BlockInfo.__init__(self, linenum, True)
avakulenko@google.com02af6282014-06-04 18:53:25 +00002128
erg@google.comd350fe52013-01-14 17:51:48 +00002129
2130class _ClassInfo(_BlockInfo):
erg@google.com4e00b9a2009-01-12 23:05:11 +00002131 """Stores information about a class."""
2132
erg@google.comd350fe52013-01-14 17:51:48 +00002133 def __init__(self, name, class_or_struct, clean_lines, linenum):
Alex Vakulenko01e47232016-05-06 13:54:15 -07002134 _BlockInfo.__init__(self, linenum, False)
erg@google.com4e00b9a2009-01-12 23:05:11 +00002135 self.name = name
erg@google.com4e00b9a2009-01-12 23:05:11 +00002136 self.is_derived = False
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00002137 self.check_namespace_indentation = True
erg@google.comd350fe52013-01-14 17:51:48 +00002138 if class_or_struct == 'struct':
2139 self.access = 'public'
erg@google.comfd5da632013-10-25 17:39:45 +00002140 self.is_struct = True
erg@google.comd350fe52013-01-14 17:51:48 +00002141 else:
2142 self.access = 'private'
erg@google.comfd5da632013-10-25 17:39:45 +00002143 self.is_struct = False
2144
2145 # Remember initial indentation level for this class. Using raw_lines here
erg@google.comc6671232013-10-25 21:44:03 +00002146 # instead of elided to account for leading comments.
avakulenko@google.com02af6282014-06-04 18:53:25 +00002147 self.class_indent = GetIndentLevel(clean_lines.raw_lines[linenum])
erg@google.com4e00b9a2009-01-12 23:05:11 +00002148
erg@google.com8a95ecc2011-09-08 00:45:54 +00002149 # Try to find the end of the class. This will be confused by things like:
2150 # class A {
2151 # } *x = { ...
2152 #
2153 # But it's still good enough for CheckSectionSpacing.
2154 self.last_line = 0
2155 depth = 0
2156 for i in range(linenum, clean_lines.NumLines()):
erg@google.comd350fe52013-01-14 17:51:48 +00002157 line = clean_lines.elided[i]
erg@google.com8a95ecc2011-09-08 00:45:54 +00002158 depth += line.count('{') - line.count('}')
2159 if not depth:
2160 self.last_line = i
2161 break
2162
erg@google.comd350fe52013-01-14 17:51:48 +00002163 def CheckBegin(self, filename, clean_lines, linenum, error):
2164 # Look for a bare ':'
2165 if Search('(^|[^:]):($|[^:])', clean_lines.elided[linenum]):
2166 self.is_derived = True
erg@google.com4e00b9a2009-01-12 23:05:11 +00002167
erg@google.comfd5da632013-10-25 17:39:45 +00002168 def CheckEnd(self, filename, clean_lines, linenum, error):
avakulenko@google.com554223d2014-12-04 22:00:20 +00002169 # If there is a DISALLOW macro, it should appear near the end of
2170 # the class.
2171 seen_last_thing_in_class = False
2172 for i in xrange(linenum - 1, self.starting_linenum, -1):
2173 match = Search(
2174 r'\b(DISALLOW_COPY_AND_ASSIGN|DISALLOW_IMPLICIT_CONSTRUCTORS)\(' +
2175 self.name + r'\)',
2176 clean_lines.elided[i])
2177 if match:
2178 if seen_last_thing_in_class:
2179 error(filename, i, 'readability/constructors', 3,
2180 match.group(1) + ' should be the last thing in the class')
2181 break
2182
2183 if not Match(r'^\s*$', clean_lines.elided[i]):
2184 seen_last_thing_in_class = True
2185
erg@google.comfd5da632013-10-25 17:39:45 +00002186 # Check that closing brace is aligned with beginning of the class.
2187 # Only do this if the closing brace is indented by only whitespaces.
2188 # This means we will not check single-line class definitions.
2189 indent = Match(r'^( *)\}', clean_lines.elided[linenum])
2190 if indent and len(indent.group(1)) != self.class_indent:
2191 if self.is_struct:
2192 parent = 'struct ' + self.name
2193 else:
2194 parent = 'class ' + self.name
2195 error(filename, linenum, 'whitespace/indent', 3,
2196 'Closing brace should be aligned with beginning of %s' % parent)
2197
erg@google.com4e00b9a2009-01-12 23:05:11 +00002198
erg@google.comd350fe52013-01-14 17:51:48 +00002199class _NamespaceInfo(_BlockInfo):
2200 """Stores information about a namespace."""
2201
2202 def __init__(self, name, linenum):
Alex Vakulenko01e47232016-05-06 13:54:15 -07002203 _BlockInfo.__init__(self, linenum, False)
erg@google.comd350fe52013-01-14 17:51:48 +00002204 self.name = name or ''
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00002205 self.check_namespace_indentation = True
erg@google.comd350fe52013-01-14 17:51:48 +00002206
2207 def CheckEnd(self, filename, clean_lines, linenum, error):
2208 """Check end of namespace comments."""
2209 line = clean_lines.raw_lines[linenum]
2210
2211 # Check how many lines is enclosed in this namespace. Don't issue
2212 # warning for missing namespace comments if there aren't enough
2213 # lines. However, do apply checks if there is already an end of
2214 # namespace comment and it's incorrect.
2215 #
2216 # TODO(unknown): We always want to check end of namespace comments
2217 # if a namespace is large, but sometimes we also want to apply the
2218 # check if a short namespace contained nontrivial things (something
2219 # other than forward declarations). There is currently no logic on
2220 # deciding what these nontrivial things are, so this check is
2221 # triggered by namespace size only, which works most of the time.
2222 if (linenum - self.starting_linenum < 10
Alex Vakulenko01e47232016-05-06 13:54:15 -07002223 and not Match(r'^\s*};*\s*(//|/\*).*\bnamespace\b', line)):
erg@google.comd350fe52013-01-14 17:51:48 +00002224 return
2225
2226 # Look for matching comment at end of namespace.
2227 #
2228 # Note that we accept C style "/* */" comments for terminating
2229 # namespaces, so that code that terminate namespaces inside
erg@google.comc6671232013-10-25 21:44:03 +00002230 # preprocessor macros can be cpplint clean.
erg@google.comd350fe52013-01-14 17:51:48 +00002231 #
2232 # We also accept stuff like "// end of namespace <name>." with the
2233 # period at the end.
2234 #
2235 # Besides these, we don't accept anything else, otherwise we might
2236 # get false negatives when existing comment is a substring of the
erg@google.comc6671232013-10-25 21:44:03 +00002237 # expected namespace.
erg@google.comd350fe52013-01-14 17:51:48 +00002238 if self.name:
2239 # Named namespace
Alex Vakulenko01e47232016-05-06 13:54:15 -07002240 if not Match((r'^\s*};*\s*(//|/\*).*\bnamespace\s+' +
2241 re.escape(self.name) + r'[\*/\.\\\s]*$'),
erg@google.comd350fe52013-01-14 17:51:48 +00002242 line):
2243 error(filename, linenum, 'readability/namespace', 5,
2244 'Namespace should be terminated with "// namespace %s"' %
2245 self.name)
2246 else:
2247 # Anonymous namespace
Alex Vakulenko01e47232016-05-06 13:54:15 -07002248 if not Match(r'^\s*};*\s*(//|/\*).*\bnamespace[\*/\.\\\s]*$', line):
avakulenko@google.com02af6282014-06-04 18:53:25 +00002249 # If "// namespace anonymous" or "// anonymous namespace (more text)",
2250 # mention "// anonymous namespace" as an acceptable form
Alex Vakulenko01e47232016-05-06 13:54:15 -07002251 if Match(r'^\s*}.*\b(namespace anonymous|anonymous namespace)\b', line):
avakulenko@google.com02af6282014-06-04 18:53:25 +00002252 error(filename, linenum, 'readability/namespace', 5,
2253 'Anonymous namespace should be terminated with "// namespace"'
2254 ' or "// anonymous namespace"')
2255 else:
2256 error(filename, linenum, 'readability/namespace', 5,
2257 'Anonymous namespace should be terminated with "// namespace"')
erg@google.comd350fe52013-01-14 17:51:48 +00002258
2259
2260class _PreprocessorInfo(object):
2261 """Stores checkpoints of nesting stacks when #if/#else is seen."""
2262
2263 def __init__(self, stack_before_if):
2264 # The entire nesting stack before #if
2265 self.stack_before_if = stack_before_if
2266
2267 # The entire nesting stack up to #else
2268 self.stack_before_else = []
2269
2270 # Whether we have already seen #else or #elif
2271 self.seen_else = False
2272
2273
avakulenko@google.com02af6282014-06-04 18:53:25 +00002274class NestingState(object):
erg@google.comd350fe52013-01-14 17:51:48 +00002275 """Holds states related to parsing braces."""
erg@google.com4e00b9a2009-01-12 23:05:11 +00002276
2277 def __init__(self):
erg@google.comd350fe52013-01-14 17:51:48 +00002278 # Stack for tracking all braces. An object is pushed whenever we
2279 # see a "{", and popped when we see a "}". Only 3 types of
2280 # objects are possible:
2281 # - _ClassInfo: a class or struct.
2282 # - _NamespaceInfo: a namespace.
2283 # - _BlockInfo: some other type of block.
2284 self.stack = []
erg@google.com4e00b9a2009-01-12 23:05:11 +00002285
avakulenko@google.com02af6282014-06-04 18:53:25 +00002286 # Top of the previous stack before each Update().
2287 #
2288 # Because the nesting_stack is updated at the end of each line, we
2289 # had to do some convoluted checks to find out what is the current
2290 # scope at the beginning of the line. This check is simplified by
2291 # saving the previous top of nesting stack.
2292 #
2293 # We could save the full stack, but we only need the top. Copying
2294 # the full nesting stack would slow down cpplint by ~10%.
2295 self.previous_stack_top = []
2296
erg@google.comd350fe52013-01-14 17:51:48 +00002297 # Stack of _PreprocessorInfo objects.
2298 self.pp_stack = []
2299
2300 def SeenOpenBrace(self):
2301 """Check if we have seen the opening brace for the innermost block.
2302
2303 Returns:
2304 True if we have seen the opening brace, False if the innermost
2305 block is still expecting an opening brace.
2306 """
2307 return (not self.stack) or self.stack[-1].seen_open_brace
2308
2309 def InNamespaceBody(self):
2310 """Check if we are currently one level inside a namespace body.
2311
2312 Returns:
2313 True if top of the stack is a namespace block, False otherwise.
2314 """
2315 return self.stack and isinstance(self.stack[-1], _NamespaceInfo)
2316
avakulenko@google.com02af6282014-06-04 18:53:25 +00002317 def InExternC(self):
2318 """Check if we are currently one level inside an 'extern "C"' block.
2319
2320 Returns:
2321 True if top of the stack is an extern block, False otherwise.
2322 """
2323 return self.stack and isinstance(self.stack[-1], _ExternCInfo)
2324
2325 def InClassDeclaration(self):
2326 """Check if we are currently one level inside a class or struct declaration.
2327
2328 Returns:
2329 True if top of the stack is a class/struct, False otherwise.
2330 """
2331 return self.stack and isinstance(self.stack[-1], _ClassInfo)
2332
2333 def InAsmBlock(self):
2334 """Check if we are currently one level inside an inline ASM block.
2335
2336 Returns:
2337 True if the top of the stack is a block containing inline ASM.
2338 """
2339 return self.stack and self.stack[-1].inline_asm != _NO_ASM
2340
2341 def InTemplateArgumentList(self, clean_lines, linenum, pos):
2342 """Check if current position is inside template argument list.
2343
2344 Args:
2345 clean_lines: A CleansedLines instance containing the file.
2346 linenum: The number of the line to check.
2347 pos: position just after the suspected template argument.
2348 Returns:
2349 True if (linenum, pos) is inside template arguments.
2350 """
2351 while linenum < clean_lines.NumLines():
2352 # Find the earliest character that might indicate a template argument
2353 line = clean_lines.elided[linenum]
2354 match = Match(r'^[^{};=\[\]\.<>]*(.)', line[pos:])
2355 if not match:
2356 linenum += 1
2357 pos = 0
2358 continue
2359 token = match.group(1)
2360 pos += len(match.group(0))
2361
2362 # These things do not look like template argument list:
2363 # class Suspect {
2364 # class Suspect x; }
2365 if token in ('{', '}', ';'): return False
2366
2367 # These things look like template argument list:
2368 # template <class Suspect>
2369 # template <class Suspect = default_value>
2370 # template <class Suspect[]>
2371 # template <class Suspect...>
2372 if token in ('>', '=', '[', ']', '.'): return True
2373
2374 # Check if token is an unmatched '<'.
2375 # If not, move on to the next character.
2376 if token != '<':
2377 pos += 1
2378 if pos >= len(line):
2379 linenum += 1
2380 pos = 0
2381 continue
2382
2383 # We can't be sure if we just find a single '<', and need to
2384 # find the matching '>'.
2385 (_, end_line, end_pos) = CloseExpression(clean_lines, linenum, pos - 1)
2386 if end_pos < 0:
2387 # Not sure if template argument list or syntax error in file
2388 return False
2389 linenum = end_line
2390 pos = end_pos
2391 return False
2392
erg@google.comd350fe52013-01-14 17:51:48 +00002393 def UpdatePreprocessor(self, line):
2394 """Update preprocessor stack.
2395
2396 We need to handle preprocessors due to classes like this:
2397 #ifdef SWIG
2398 struct ResultDetailsPageElementExtensionPoint {
2399 #else
2400 struct ResultDetailsPageElementExtensionPoint : public Extension {
2401 #endif
erg@google.comd350fe52013-01-14 17:51:48 +00002402
2403 We make the following assumptions (good enough for most files):
2404 - Preprocessor condition evaluates to true from #if up to first
2405 #else/#elif/#endif.
2406
2407 - Preprocessor condition evaluates to false from #else/#elif up
2408 to #endif. We still perform lint checks on these lines, but
2409 these do not affect nesting stack.
2410
2411 Args:
2412 line: current line to check.
2413 """
2414 if Match(r'^\s*#\s*(if|ifdef|ifndef)\b', line):
2415 # Beginning of #if block, save the nesting stack here. The saved
2416 # stack will allow us to restore the parsing state in the #else case.
2417 self.pp_stack.append(_PreprocessorInfo(copy.deepcopy(self.stack)))
2418 elif Match(r'^\s*#\s*(else|elif)\b', line):
2419 # Beginning of #else block
2420 if self.pp_stack:
2421 if not self.pp_stack[-1].seen_else:
2422 # This is the first #else or #elif block. Remember the
2423 # whole nesting stack up to this point. This is what we
2424 # keep after the #endif.
2425 self.pp_stack[-1].seen_else = True
2426 self.pp_stack[-1].stack_before_else = copy.deepcopy(self.stack)
2427
2428 # Restore the stack to how it was before the #if
2429 self.stack = copy.deepcopy(self.pp_stack[-1].stack_before_if)
2430 else:
2431 # TODO(unknown): unexpected #else, issue warning?
2432 pass
2433 elif Match(r'^\s*#\s*endif\b', line):
2434 # End of #if or #else blocks.
2435 if self.pp_stack:
2436 # If we saw an #else, we will need to restore the nesting
2437 # stack to its former state before the #else, otherwise we
2438 # will just continue from where we left off.
2439 if self.pp_stack[-1].seen_else:
2440 # Here we can just use a shallow copy since we are the last
2441 # reference to it.
2442 self.stack = self.pp_stack[-1].stack_before_else
2443 # Drop the corresponding #if
2444 self.pp_stack.pop()
2445 else:
2446 # TODO(unknown): unexpected #endif, issue warning?
2447 pass
2448
avakulenko@google.com02af6282014-06-04 18:53:25 +00002449 # TODO(unknown): Update() is too long, but we will refactor later.
erg@google.comd350fe52013-01-14 17:51:48 +00002450 def Update(self, filename, clean_lines, linenum, error):
2451 """Update nesting state with current line.
2452
2453 Args:
2454 filename: The name of the current file.
2455 clean_lines: A CleansedLines instance containing the file.
2456 linenum: The number of the line to check.
2457 error: The function to call with any errors found.
2458 """
2459 line = clean_lines.elided[linenum]
2460
avakulenko@google.com02af6282014-06-04 18:53:25 +00002461 # Remember top of the previous nesting stack.
2462 #
2463 # The stack is always pushed/popped and not modified in place, so
2464 # we can just do a shallow copy instead of copy.deepcopy. Using
2465 # deepcopy would slow down cpplint by ~28%.
2466 if self.stack:
2467 self.previous_stack_top = self.stack[-1]
2468 else:
2469 self.previous_stack_top = None
2470
2471 # Update pp_stack
erg@google.comd350fe52013-01-14 17:51:48 +00002472 self.UpdatePreprocessor(line)
2473
2474 # Count parentheses. This is to avoid adding struct arguments to
2475 # the nesting stack.
2476 if self.stack:
2477 inner_block = self.stack[-1]
2478 depth_change = line.count('(') - line.count(')')
2479 inner_block.open_parentheses += depth_change
2480
2481 # Also check if we are starting or ending an inline assembly block.
2482 if inner_block.inline_asm in (_NO_ASM, _END_ASM):
2483 if (depth_change != 0 and
2484 inner_block.open_parentheses == 1 and
2485 _MATCH_ASM.match(line)):
2486 # Enter assembly block
2487 inner_block.inline_asm = _INSIDE_ASM
2488 else:
2489 # Not entering assembly block. If previous line was _END_ASM,
2490 # we will now shift to _NO_ASM state.
2491 inner_block.inline_asm = _NO_ASM
2492 elif (inner_block.inline_asm == _INSIDE_ASM and
2493 inner_block.open_parentheses == 0):
2494 # Exit assembly block
2495 inner_block.inline_asm = _END_ASM
2496
2497 # Consume namespace declaration at the beginning of the line. Do
2498 # this in a loop so that we catch same line declarations like this:
2499 # namespace proto2 { namespace bridge { class MessageSet; } }
2500 while True:
2501 # Match start of namespace. The "\b\s*" below catches namespace
2502 # declarations even if it weren't followed by a whitespace, this
2503 # is so that we don't confuse our namespace checker. The
2504 # missing spaces will be flagged by CheckSpacing.
2505 namespace_decl_match = Match(r'^\s*namespace\b\s*([:\w]+)?(.*)$', line)
2506 if not namespace_decl_match:
2507 break
2508
2509 new_namespace = _NamespaceInfo(namespace_decl_match.group(1), linenum)
2510 self.stack.append(new_namespace)
2511
2512 line = namespace_decl_match.group(2)
2513 if line.find('{') != -1:
2514 new_namespace.seen_open_brace = True
2515 line = line[line.find('{') + 1:]
2516
2517 # Look for a class declaration in whatever is left of the line
2518 # after parsing namespaces. The regexp accounts for decorated classes
2519 # such as in:
2520 # class LOCKABLE API Object {
2521 # };
erg@google.comd350fe52013-01-14 17:51:48 +00002522 class_decl_match = Match(
avakulenko@google.com02af6282014-06-04 18:53:25 +00002523 r'^(\s*(?:template\s*<[\w\s<>,:]*>\s*)?'
2524 r'(class|struct)\s+(?:[A-Z_]+\s+)*(\w+(?:::\w+)*))'
2525 r'(.*)$', line)
erg@google.comd350fe52013-01-14 17:51:48 +00002526 if (class_decl_match and
2527 (not self.stack or self.stack[-1].open_parentheses == 0)):
avakulenko@google.com02af6282014-06-04 18:53:25 +00002528 # We do not want to accept classes that are actually template arguments:
2529 # template <class Ignore1,
2530 # class Ignore2 = Default<Args>,
2531 # template <Args> class Ignore3>
2532 # void Function() {};
2533 #
2534 # To avoid template argument cases, we scan forward and look for
2535 # an unmatched '>'. If we see one, assume we are inside a
2536 # template argument list.
2537 end_declaration = len(class_decl_match.group(1))
2538 if not self.InTemplateArgumentList(clean_lines, linenum, end_declaration):
2539 self.stack.append(_ClassInfo(
2540 class_decl_match.group(3), class_decl_match.group(2),
2541 clean_lines, linenum))
2542 line = class_decl_match.group(4)
erg@google.comd350fe52013-01-14 17:51:48 +00002543
2544 # If we have not yet seen the opening brace for the innermost block,
2545 # run checks here.
2546 if not self.SeenOpenBrace():
2547 self.stack[-1].CheckBegin(filename, clean_lines, linenum, error)
2548
2549 # Update access control if we are inside a class/struct
2550 if self.stack and isinstance(self.stack[-1], _ClassInfo):
erg@google.comfd5da632013-10-25 17:39:45 +00002551 classinfo = self.stack[-1]
2552 access_match = Match(
2553 r'^(.*)\b(public|private|protected|signals)(\s+(?:slots\s*)?)?'
2554 r':(?:[^:]|$)',
2555 line)
erg@google.comd350fe52013-01-14 17:51:48 +00002556 if access_match:
erg@google.comfd5da632013-10-25 17:39:45 +00002557 classinfo.access = access_match.group(2)
2558
2559 # Check that access keywords are indented +1 space. Skip this
erg@google.comc6671232013-10-25 21:44:03 +00002560 # check if the keywords are not preceded by whitespaces.
erg@google.comfd5da632013-10-25 17:39:45 +00002561 indent = access_match.group(1)
2562 if (len(indent) != classinfo.class_indent + 1 and
2563 Match(r'^\s*$', indent)):
2564 if classinfo.is_struct:
2565 parent = 'struct ' + classinfo.name
2566 else:
2567 parent = 'class ' + classinfo.name
2568 slots = ''
2569 if access_match.group(3):
2570 slots = access_match.group(3)
2571 error(filename, linenum, 'whitespace/indent', 3,
2572 '%s%s: should be indented +1 space inside %s' % (
2573 access_match.group(2), slots, parent))
erg@google.comd350fe52013-01-14 17:51:48 +00002574
2575 # Consume braces or semicolons from what's left of the line
2576 while True:
2577 # Match first brace, semicolon, or closed parenthesis.
2578 matched = Match(r'^[^{;)}]*([{;)}])(.*)$', line)
2579 if not matched:
2580 break
2581
2582 token = matched.group(1)
2583 if token == '{':
2584 # If namespace or class hasn't seen a opening brace yet, mark
2585 # namespace/class head as complete. Push a new block onto the
2586 # stack otherwise.
2587 if not self.SeenOpenBrace():
2588 self.stack[-1].seen_open_brace = True
avakulenko@google.com02af6282014-06-04 18:53:25 +00002589 elif Match(r'^extern\s*"[^"]*"\s*\{', line):
Alex Vakulenko01e47232016-05-06 13:54:15 -07002590 self.stack.append(_ExternCInfo(linenum))
erg@google.comd350fe52013-01-14 17:51:48 +00002591 else:
Alex Vakulenko01e47232016-05-06 13:54:15 -07002592 self.stack.append(_BlockInfo(linenum, True))
erg@google.comd350fe52013-01-14 17:51:48 +00002593 if _MATCH_ASM.match(line):
2594 self.stack[-1].inline_asm = _BLOCK_ASM
avakulenko@google.com02af6282014-06-04 18:53:25 +00002595
erg@google.comd350fe52013-01-14 17:51:48 +00002596 elif token == ';' or token == ')':
2597 # If we haven't seen an opening brace yet, but we already saw
2598 # a semicolon, this is probably a forward declaration. Pop
2599 # the stack for these.
2600 #
2601 # Similarly, if we haven't seen an opening brace yet, but we
2602 # already saw a closing parenthesis, then these are probably
2603 # function arguments with extra "class" or "struct" keywords.
2604 # Also pop these stack for these.
2605 if not self.SeenOpenBrace():
2606 self.stack.pop()
2607 else: # token == '}'
2608 # Perform end of block checks and pop the stack.
2609 if self.stack:
2610 self.stack[-1].CheckEnd(filename, clean_lines, linenum, error)
2611 self.stack.pop()
2612 line = matched.group(2)
2613
2614 def InnermostClass(self):
2615 """Get class info on the top of the stack.
2616
2617 Returns:
2618 A _ClassInfo object if we are inside a class, or None otherwise.
2619 """
2620 for i in range(len(self.stack), 0, -1):
2621 classinfo = self.stack[i - 1]
2622 if isinstance(classinfo, _ClassInfo):
2623 return classinfo
2624 return None
2625
erg@google.com2aa59982013-10-28 19:09:25 +00002626 def CheckCompletedBlocks(self, filename, error):
2627 """Checks that all classes and namespaces have been completely parsed.
erg@google.com4e00b9a2009-01-12 23:05:11 +00002628
2629 Call this when all lines in a file have been processed.
2630 Args:
2631 filename: The name of the current file.
2632 error: The function to call with any errors found.
2633 """
erg@google.comd350fe52013-01-14 17:51:48 +00002634 # Note: This test can result in false positives if #ifdef constructs
2635 # get in the way of brace matching. See the testBuildClass test in
2636 # cpplint_unittest.py for an example of this.
2637 for obj in self.stack:
2638 if isinstance(obj, _ClassInfo):
2639 error(filename, obj.starting_linenum, 'build/class', 5,
2640 'Failed to find complete declaration of class %s' %
2641 obj.name)
erg@google.com2aa59982013-10-28 19:09:25 +00002642 elif isinstance(obj, _NamespaceInfo):
2643 error(filename, obj.starting_linenum, 'build/namespaces', 5,
2644 'Failed to find complete declaration of namespace %s' %
2645 obj.name)
erg@google.com4e00b9a2009-01-12 23:05:11 +00002646
2647
2648def CheckForNonStandardConstructs(filename, clean_lines, linenum,
erg@google.comd350fe52013-01-14 17:51:48 +00002649 nesting_state, error):
erg@google.com2aa59982013-10-28 19:09:25 +00002650 r"""Logs an error if we see certain non-ANSI constructs ignored by gcc-2.
erg@google.com4e00b9a2009-01-12 23:05:11 +00002651
2652 Complain about several constructs which gcc-2 accepts, but which are
2653 not standard C++. Warning about these in lint is one way to ease the
2654 transition to new compilers.
2655 - put storage class first (e.g. "static const" instead of "const static").
2656 - "%lld" instead of %qd" in printf-type functions.
2657 - "%1$d" is non-standard in printf-type functions.
2658 - "\%" is an undefined character escape sequence.
2659 - text after #endif is not allowed.
2660 - invalid inner-style forward declaration.
2661 - >? and <? operators, and their >?= and <?= cousins.
erg@google.com4e00b9a2009-01-12 23:05:11 +00002662
erg@google.coma868d2d2009-10-09 21:18:45 +00002663 Additionally, check for constructor/destructor style violations and reference
2664 members, as it is very convenient to do so while checking for
2665 gcc-2 compliance.
erg@google.com4e00b9a2009-01-12 23:05:11 +00002666
2667 Args:
2668 filename: The name of the current file.
2669 clean_lines: A CleansedLines instance containing the file.
2670 linenum: The number of the line to check.
avakulenko@google.com02af6282014-06-04 18:53:25 +00002671 nesting_state: A NestingState instance which maintains information about
erg@google.comd350fe52013-01-14 17:51:48 +00002672 the current stack of nested blocks being parsed.
erg@google.com4e00b9a2009-01-12 23:05:11 +00002673 error: A callable to which errors are reported, which takes 4 arguments:
2674 filename, line number, error level, and message
2675 """
2676
2677 # Remove comments from the line, but leave in strings for now.
2678 line = clean_lines.lines[linenum]
2679
2680 if Search(r'printf\s*\(.*".*%[-+ ]?\d*q', line):
2681 error(filename, linenum, 'runtime/printf_format', 3,
2682 '%q in format strings is deprecated. Use %ll instead.')
2683
2684 if Search(r'printf\s*\(.*".*%\d+\$', line):
2685 error(filename, linenum, 'runtime/printf_format', 2,
2686 '%N$ formats are unconventional. Try rewriting to avoid them.')
2687
2688 # Remove escaped backslashes before looking for undefined escapes.
2689 line = line.replace('\\\\', '')
2690
2691 if Search(r'("|\').*\\(%|\[|\(|{)', line):
2692 error(filename, linenum, 'build/printf_format', 3,
2693 '%, [, (, and { are undefined character escapes. Unescape them.')
2694
2695 # For the rest, work with both comments and strings removed.
2696 line = clean_lines.elided[linenum]
2697
2698 if Search(r'\b(const|volatile|void|char|short|int|long'
2699 r'|float|double|signed|unsigned'
2700 r'|schar|u?int8|u?int16|u?int32|u?int64)'
erg@google.comd350fe52013-01-14 17:51:48 +00002701 r'\s+(register|static|extern|typedef)\b',
erg@google.com4e00b9a2009-01-12 23:05:11 +00002702 line):
2703 error(filename, linenum, 'build/storage_class', 5,
Alex Vakulenko01e47232016-05-06 13:54:15 -07002704 'Storage-class specifier (static, extern, typedef, etc) should be '
2705 'at the beginning of the declaration.')
erg@google.com4e00b9a2009-01-12 23:05:11 +00002706
2707 if Match(r'\s*#\s*endif\s*[^/\s]+', line):
2708 error(filename, linenum, 'build/endif_comment', 5,
2709 'Uncommented text after #endif is non-standard. Use a comment.')
2710
2711 if Match(r'\s*class\s+(\w+\s*::\s*)+\w+\s*;', line):
2712 error(filename, linenum, 'build/forward_decl', 5,
2713 'Inner-style forward declarations are invalid. Remove this line.')
2714
2715 if Search(r'(\w+|[+-]?\d+(\.\d*)?)\s*(<|>)\?=?\s*(\w+|[+-]?\d+)(\.\d*)?',
2716 line):
2717 error(filename, linenum, 'build/deprecated', 3,
2718 '>? and <? (max and min) operators are non-standard and deprecated.')
2719
erg@google.coma868d2d2009-10-09 21:18:45 +00002720 if Search(r'^\s*const\s*string\s*&\s*\w+\s*;', line):
2721 # TODO(unknown): Could it be expanded safely to arbitrary references,
2722 # without triggering too many false positives? The first
2723 # attempt triggered 5 warnings for mostly benign code in the regtest, hence
2724 # the restriction.
2725 # Here's the original regexp, for the reference:
2726 # type_name = r'\w+((\s*::\s*\w+)|(\s*<\s*\w+?\s*>))?'
2727 # r'\s*const\s*' + type_name + '\s*&\s*\w+\s*;'
2728 error(filename, linenum, 'runtime/member_string_references', 2,
2729 'const string& members are dangerous. It is much better to use '
2730 'alternatives, such as pointers or simple constants.')
2731
erg@google.comd350fe52013-01-14 17:51:48 +00002732 # Everything else in this function operates on class declarations.
2733 # Return early if the top of the nesting stack is not a class, or if
2734 # the class head is not completed yet.
2735 classinfo = nesting_state.InnermostClass()
2736 if not classinfo or not classinfo.seen_open_brace:
erg@google.com4e00b9a2009-01-12 23:05:11 +00002737 return
2738
erg@google.com4e00b9a2009-01-12 23:05:11 +00002739 # The class may have been declared with namespace or classname qualifiers.
2740 # The constructor and destructor will not have those qualifiers.
2741 base_classname = classinfo.name.split('::')[-1]
2742
2743 # Look for single-argument constructors that aren't marked explicit.
Alex Vakulenko01e47232016-05-06 13:54:15 -07002744 # Technically a valid construct, but against style.
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00002745 explicit_constructor_match = Match(
2746 r'\s+(?:inline\s+)?(explicit\s+)?(?:inline\s+)?%s\s*'
2747 r'\(((?:[^()]|\([^()]*\))*)\)'
2748 % re.escape(base_classname),
2749 line)
2750
2751 if explicit_constructor_match:
2752 is_marked_explicit = explicit_constructor_match.group(1)
2753
2754 if not explicit_constructor_match.group(2):
2755 constructor_args = []
2756 else:
2757 constructor_args = explicit_constructor_match.group(2).split(',')
2758
2759 # collapse arguments so that commas in template parameter lists and function
2760 # argument parameter lists don't split arguments in two
2761 i = 0
2762 while i < len(constructor_args):
2763 constructor_arg = constructor_args[i]
2764 while (constructor_arg.count('<') > constructor_arg.count('>') or
2765 constructor_arg.count('(') > constructor_arg.count(')')):
2766 constructor_arg += ',' + constructor_args[i + 1]
2767 del constructor_args[i + 1]
2768 constructor_args[i] = constructor_arg
2769 i += 1
2770
2771 defaulted_args = [arg for arg in constructor_args if '=' in arg]
2772 noarg_constructor = (not constructor_args or # empty arg list
2773 # 'void' arg specifier
2774 (len(constructor_args) == 1 and
2775 constructor_args[0].strip() == 'void'))
2776 onearg_constructor = ((len(constructor_args) == 1 and # exactly one arg
2777 not noarg_constructor) or
2778 # all but at most one arg defaulted
2779 (len(constructor_args) >= 1 and
2780 not noarg_constructor and
2781 len(defaulted_args) >= len(constructor_args) - 1))
2782 initializer_list_constructor = bool(
2783 onearg_constructor and
2784 Search(r'\bstd\s*::\s*initializer_list\b', constructor_args[0]))
2785 copy_constructor = bool(
2786 onearg_constructor and
2787 Match(r'(const\s+)?%s(\s*<[^>]*>)?(\s+const)?\s*(?:<\w+>\s*)?&'
2788 % re.escape(base_classname), constructor_args[0].strip()))
2789
2790 if (not is_marked_explicit and
2791 onearg_constructor and
2792 not initializer_list_constructor and
2793 not copy_constructor):
2794 if defaulted_args:
2795 error(filename, linenum, 'runtime/explicit', 5,
2796 'Constructors callable with one argument '
2797 'should be marked explicit.')
2798 else:
2799 error(filename, linenum, 'runtime/explicit', 5,
2800 'Single-parameter constructors should be marked explicit.')
2801 elif is_marked_explicit and not onearg_constructor:
2802 if noarg_constructor:
2803 error(filename, linenum, 'runtime/explicit', 5,
2804 'Zero-parameter constructors should not be marked explicit.')
erg@google.com4e00b9a2009-01-12 23:05:11 +00002805
erg@google.com4e00b9a2009-01-12 23:05:11 +00002806
avakulenko@google.com02af6282014-06-04 18:53:25 +00002807def CheckSpacingForFunctionCall(filename, clean_lines, linenum, error):
erg@google.com4e00b9a2009-01-12 23:05:11 +00002808 """Checks for the correctness of various spacing around function calls.
2809
2810 Args:
2811 filename: The name of the current file.
avakulenko@google.com02af6282014-06-04 18:53:25 +00002812 clean_lines: A CleansedLines instance containing the file.
erg@google.com4e00b9a2009-01-12 23:05:11 +00002813 linenum: The number of the line to check.
2814 error: The function to call with any errors found.
2815 """
avakulenko@google.com02af6282014-06-04 18:53:25 +00002816 line = clean_lines.elided[linenum]
erg@google.com4e00b9a2009-01-12 23:05:11 +00002817
2818 # Since function calls often occur inside if/for/while/switch
2819 # expressions - which have their own, more liberal conventions - we
2820 # first see if we should be looking inside such an expression for a
2821 # function call, to which we can apply more strict standards.
2822 fncall = line # if there's no control flow construct, look at whole line
2823 for pattern in (r'\bif\s*\((.*)\)\s*{',
2824 r'\bfor\s*\((.*)\)\s*{',
2825 r'\bwhile\s*\((.*)\)\s*[{;]',
2826 r'\bswitch\s*\((.*)\)\s*{'):
2827 match = Search(pattern, line)
2828 if match:
2829 fncall = match.group(1) # look inside the parens for function calls
2830 break
2831
2832 # Except in if/for/while/switch, there should never be space
2833 # immediately inside parens (eg "f( 3, 4 )"). We make an exception
2834 # for nested parens ( (a+b) + c ). Likewise, there should never be
2835 # a space before a ( when it's a function argument. I assume it's a
2836 # function argument when the char before the whitespace is legal in
2837 # a function name (alnum + _) and we're not starting a macro. Also ignore
2838 # pointers and references to arrays and functions coz they're too tricky:
2839 # we use a very simple way to recognize these:
2840 # " (something)(maybe-something)" or
2841 # " (something)(maybe-something," or
2842 # " (something)[something]"
2843 # Note that we assume the contents of [] to be short enough that
2844 # they'll never need to wrap.
2845 if ( # Ignore control structures.
erg@google.com2aa59982013-10-28 19:09:25 +00002846 not Search(r'\b(if|for|while|switch|return|new|delete|catch|sizeof)\b',
erg@google.comc6671232013-10-25 21:44:03 +00002847 fncall) and
erg@google.com4e00b9a2009-01-12 23:05:11 +00002848 # Ignore pointers/references to functions.
2849 not Search(r' \([^)]+\)\([^)]*(\)|,$)', fncall) and
2850 # Ignore pointers/references to arrays.
2851 not Search(r' \([^)]+\)\[[^\]]+\]', fncall)):
erg@google.com36649102009-03-25 21:18:36 +00002852 if Search(r'\w\s*\(\s(?!\s*\\$)', fncall): # a ( used for a fn call
erg@google.com4e00b9a2009-01-12 23:05:11 +00002853 error(filename, linenum, 'whitespace/parens', 4,
2854 'Extra space after ( in function call')
erg@google.com36649102009-03-25 21:18:36 +00002855 elif Search(r'\(\s+(?!(\s*\\)|\()', fncall):
erg@google.com4e00b9a2009-01-12 23:05:11 +00002856 error(filename, linenum, 'whitespace/parens', 2,
2857 'Extra space after (')
2858 if (Search(r'\w\s+\(', fncall) and
Alex Vakulenko01e47232016-05-06 13:54:15 -07002859 not Search(r'_{0,2}asm_{0,2}\s+_{0,2}volatile_{0,2}\s+\(', fncall) and
avakulenko@google.com02af6282014-06-04 18:53:25 +00002860 not Search(r'#\s*define|typedef|using\s+\w+\s*=', fncall) and
avakulenko@google.com554223d2014-12-04 22:00:20 +00002861 not Search(r'\w\s+\((\w+::)*\*\w+\)\(', fncall) and
2862 not Search(r'\bcase\s+\(', fncall)):
avakulenko@google.com02af6282014-06-04 18:53:25 +00002863 # TODO(unknown): Space after an operator function seem to be a common
2864 # error, silence those for now by restricting them to highest verbosity.
2865 if Search(r'\boperator_*\b', line):
2866 error(filename, linenum, 'whitespace/parens', 0,
2867 'Extra space before ( in function call')
2868 else:
2869 error(filename, linenum, 'whitespace/parens', 4,
2870 'Extra space before ( in function call')
erg@google.com4e00b9a2009-01-12 23:05:11 +00002871 # If the ) is followed only by a newline or a { + newline, assume it's
2872 # part of a control statement (if/while/etc), and don't complain
2873 if Search(r'[^)]\s+\)\s*[^{\s]', fncall):
erg@google.com8a95ecc2011-09-08 00:45:54 +00002874 # If the closing parenthesis is preceded by only whitespaces,
2875 # try to give a more descriptive error message.
2876 if Search(r'^\s+\)', fncall):
2877 error(filename, linenum, 'whitespace/parens', 2,
2878 'Closing ) should be moved to the previous line')
2879 else:
2880 error(filename, linenum, 'whitespace/parens', 2,
2881 'Extra space before )')
erg@google.com4e00b9a2009-01-12 23:05:11 +00002882
2883
2884def IsBlankLine(line):
2885 """Returns true if the given line is blank.
2886
2887 We consider a line to be blank if the line is empty or consists of
2888 only white spaces.
2889
2890 Args:
2891 line: A line of a string.
2892
2893 Returns:
2894 True, if the given line is blank.
2895 """
2896 return not line or line.isspace()
2897
2898
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00002899def CheckForNamespaceIndentation(filename, nesting_state, clean_lines, line,
2900 error):
2901 is_namespace_indent_item = (
2902 len(nesting_state.stack) > 1 and
2903 nesting_state.stack[-1].check_namespace_indentation and
2904 isinstance(nesting_state.previous_stack_top, _NamespaceInfo) and
2905 nesting_state.previous_stack_top == nesting_state.stack[-2])
2906
2907 if ShouldCheckNamespaceIndentation(nesting_state, is_namespace_indent_item,
2908 clean_lines.elided, line):
2909 CheckItemIndentationInNamespace(filename, clean_lines.elided,
2910 line, error)
2911
2912
erg@google.com4e00b9a2009-01-12 23:05:11 +00002913def CheckForFunctionLengths(filename, clean_lines, linenum,
2914 function_state, error):
2915 """Reports for long function bodies.
2916
2917 For an overview why this is done, see:
Ackermann Yuriy79692902016-04-01 21:41:34 +13002918 https://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Write_Short_Functions
erg@google.com4e00b9a2009-01-12 23:05:11 +00002919
2920 Uses a simplistic algorithm assuming other style guidelines
2921 (especially spacing) are followed.
2922 Only checks unindented functions, so class members are unchecked.
2923 Trivial bodies are unchecked, so constructors with huge initializer lists
2924 may be missed.
2925 Blank/comment lines are not counted so as to avoid encouraging the removal
erg@google.com8a95ecc2011-09-08 00:45:54 +00002926 of vertical space and comments just to get through a lint check.
erg@google.com4e00b9a2009-01-12 23:05:11 +00002927 NOLINT *on the last line of a function* disables this check.
2928
2929 Args:
2930 filename: The name of the current file.
2931 clean_lines: A CleansedLines instance containing the file.
2932 linenum: The number of the line to check.
2933 function_state: Current function name and lines in body so far.
2934 error: The function to call with any errors found.
2935 """
2936 lines = clean_lines.lines
2937 line = lines[linenum]
erg@google.com4e00b9a2009-01-12 23:05:11 +00002938 joined_line = ''
2939
2940 starting_func = False
erg@google.coma87abb82009-02-24 01:41:01 +00002941 regexp = r'(\w(\w|::|\*|\&|\s)*)\(' # decls * & space::name( ...
erg@google.com4e00b9a2009-01-12 23:05:11 +00002942 match_result = Match(regexp, line)
2943 if match_result:
2944 # If the name is all caps and underscores, figure it's a macro and
2945 # ignore it, unless it's TEST or TEST_F.
2946 function_name = match_result.group(1).split()[-1]
2947 if function_name == 'TEST' or function_name == 'TEST_F' or (
2948 not Match(r'[A-Z_]+$', function_name)):
2949 starting_func = True
2950
2951 if starting_func:
2952 body_found = False
erg@google.coma87abb82009-02-24 01:41:01 +00002953 for start_linenum in xrange(linenum, clean_lines.NumLines()):
erg@google.com4e00b9a2009-01-12 23:05:11 +00002954 start_line = lines[start_linenum]
2955 joined_line += ' ' + start_line.lstrip()
2956 if Search(r'(;|})', start_line): # Declarations and trivial functions
2957 body_found = True
2958 break # ... ignore
2959 elif Search(r'{', start_line):
2960 body_found = True
2961 function = Search(r'((\w|:)*)\(', line).group(1)
2962 if Match(r'TEST', function): # Handle TEST... macros
2963 parameter_regexp = Search(r'(\(.*\))', joined_line)
2964 if parameter_regexp: # Ignore bad syntax
2965 function += parameter_regexp.group(1)
2966 else:
2967 function += '()'
2968 function_state.Begin(function)
2969 break
2970 if not body_found:
erg@google.coma87abb82009-02-24 01:41:01 +00002971 # No body for the function (or evidence of a non-function) was found.
erg@google.com4e00b9a2009-01-12 23:05:11 +00002972 error(filename, linenum, 'readability/fn_size', 5,
2973 'Lint failed to find start of function body.')
2974 elif Match(r'^\}\s*$', line): # function end
erg+personal@google.com05189642010-04-30 20:43:03 +00002975 function_state.Check(error, filename, linenum)
erg@google.com4e00b9a2009-01-12 23:05:11 +00002976 function_state.End()
2977 elif not Match(r'^\s*$', line):
2978 function_state.Count() # Count non-blank/non-comment lines.
2979
2980
2981_RE_PATTERN_TODO = re.compile(r'^//(\s*)TODO(\(.+?\))?:?(\s|$)?')
2982
2983
avakulenko@google.com02af6282014-06-04 18:53:25 +00002984def CheckComment(line, filename, linenum, next_line_start, error):
2985 """Checks for common mistakes in comments.
erg@google.com4e00b9a2009-01-12 23:05:11 +00002986
2987 Args:
avakulenko@google.com02af6282014-06-04 18:53:25 +00002988 line: The line in question.
erg@google.com4e00b9a2009-01-12 23:05:11 +00002989 filename: The name of the current file.
2990 linenum: The number of the line to check.
avakulenko@google.com02af6282014-06-04 18:53:25 +00002991 next_line_start: The first non-whitespace column of the next line.
erg@google.com4e00b9a2009-01-12 23:05:11 +00002992 error: The function to call with any errors found.
2993 """
avakulenko@google.com02af6282014-06-04 18:53:25 +00002994 commentpos = line.find('//')
2995 if commentpos != -1:
2996 # Check if the // may be in quotes. If so, ignore it
Alex Vakulenko01e47232016-05-06 13:54:15 -07002997 if re.sub(r'\\.', '', line[0:commentpos]).count('"') % 2 == 0:
avakulenko@google.com02af6282014-06-04 18:53:25 +00002998 # Allow one space for new scopes, two spaces otherwise:
2999 if (not (Match(r'^.*{ *//', line) and next_line_start == commentpos) and
3000 ((commentpos >= 1 and
3001 line[commentpos-1] not in string.whitespace) or
3002 (commentpos >= 2 and
3003 line[commentpos-2] not in string.whitespace))):
3004 error(filename, linenum, 'whitespace/comments', 2,
3005 'At least two spaces is best between code and comments')
erg@google.com4e00b9a2009-01-12 23:05:11 +00003006
avakulenko@google.com02af6282014-06-04 18:53:25 +00003007 # Checks for common mistakes in TODO comments.
3008 comment = line[commentpos:]
3009 match = _RE_PATTERN_TODO.match(comment)
3010 if match:
3011 # One whitespace is correct; zero whitespace is handled elsewhere.
3012 leading_whitespace = match.group(1)
3013 if len(leading_whitespace) > 1:
3014 error(filename, linenum, 'whitespace/todo', 2,
3015 'Too many spaces before TODO')
erg@google.com4e00b9a2009-01-12 23:05:11 +00003016
avakulenko@google.com02af6282014-06-04 18:53:25 +00003017 username = match.group(2)
3018 if not username:
3019 error(filename, linenum, 'readability/todo', 2,
3020 'Missing username in TODO; it should look like '
3021 '"// TODO(my_username): Stuff."')
3022
3023 middle_whitespace = match.group(3)
3024 # Comparisons made explicit for correctness -- pylint: disable=g-explicit-bool-comparison
3025 if middle_whitespace != ' ' and middle_whitespace != '':
3026 error(filename, linenum, 'whitespace/todo', 2,
3027 'TODO(my_username) should be followed by a space')
3028
3029 # If the comment contains an alphanumeric character, there
avakulenko@google.com554223d2014-12-04 22:00:20 +00003030 # should be a space somewhere between it and the // unless
3031 # it's a /// or //! Doxygen comment.
3032 if (Match(r'//[^ ]*\w', comment) and
3033 not Match(r'(///|//\!)(\s+|$)', comment)):
avakulenko@google.com02af6282014-06-04 18:53:25 +00003034 error(filename, linenum, 'whitespace/comments', 4,
3035 'Should have a space between // and comment')
erg@google.com4e00b9a2009-01-12 23:05:11 +00003036
avakulenko@google.com554223d2014-12-04 22:00:20 +00003037
erg@google.comd350fe52013-01-14 17:51:48 +00003038def CheckAccess(filename, clean_lines, linenum, nesting_state, error):
3039 """Checks for improper use of DISALLOW* macros.
erg@google.com4e00b9a2009-01-12 23:05:11 +00003040
erg@google.comd350fe52013-01-14 17:51:48 +00003041 Args:
3042 filename: The name of the current file.
3043 clean_lines: A CleansedLines instance containing the file.
3044 linenum: The number of the line to check.
avakulenko@google.com02af6282014-06-04 18:53:25 +00003045 nesting_state: A NestingState instance which maintains information about
erg@google.comd350fe52013-01-14 17:51:48 +00003046 the current stack of nested blocks being parsed.
3047 error: The function to call with any errors found.
3048 """
3049 line = clean_lines.elided[linenum] # get rid of comments and strings
3050
3051 matched = Match((r'\s*(DISALLOW_COPY_AND_ASSIGN|'
erg@google.comd350fe52013-01-14 17:51:48 +00003052 r'DISALLOW_IMPLICIT_CONSTRUCTORS)'), line)
3053 if not matched:
3054 return
3055 if nesting_state.stack and isinstance(nesting_state.stack[-1], _ClassInfo):
3056 if nesting_state.stack[-1].access != 'private':
3057 error(filename, linenum, 'readability/constructors', 3,
3058 '%s must be in the private: section' % matched.group(1))
3059
3060 else:
3061 # Found DISALLOW* macro outside a class declaration, or perhaps it
3062 # was used inside a function when it should have been part of the
3063 # class declaration. We could issue a warning here, but it
3064 # probably resulted in a compiler error already.
3065 pass
3066
3067
erg@google.comd350fe52013-01-14 17:51:48 +00003068def CheckSpacing(filename, clean_lines, linenum, nesting_state, error):
erg@google.com4e00b9a2009-01-12 23:05:11 +00003069 """Checks for the correctness of various spacing issues in the code.
3070
3071 Things we check for: spaces around operators, spaces after
3072 if/for/while/switch, no spaces around parens in function calls, two
3073 spaces between code and comment, don't start a block with a blank
erg@google.com8a95ecc2011-09-08 00:45:54 +00003074 line, don't end a function with a blank line, don't add a blank line
3075 after public/protected/private, don't have too many blank lines in a row.
erg@google.com4e00b9a2009-01-12 23:05:11 +00003076
3077 Args:
3078 filename: The name of the current file.
3079 clean_lines: A CleansedLines instance containing the file.
3080 linenum: The number of the line to check.
avakulenko@google.com02af6282014-06-04 18:53:25 +00003081 nesting_state: A NestingState instance which maintains information about
erg@google.comd350fe52013-01-14 17:51:48 +00003082 the current stack of nested blocks being parsed.
erg@google.com4e00b9a2009-01-12 23:05:11 +00003083 error: The function to call with any errors found.
3084 """
3085
erg@google.com2aa59982013-10-28 19:09:25 +00003086 # Don't use "elided" lines here, otherwise we can't check commented lines.
3087 # Don't want to use "raw" either, because we don't want to check inside C++11
3088 # raw strings,
3089 raw = clean_lines.lines_without_raw_strings
erg@google.com4e00b9a2009-01-12 23:05:11 +00003090 line = raw[linenum]
3091
3092 # Before nixing comments, check if the line is blank for no good
3093 # reason. This includes the first line after a block is opened, and
3094 # blank lines at the end of a function (ie, right before a line like '}'
erg@google.comd350fe52013-01-14 17:51:48 +00003095 #
3096 # Skip all the blank line checks if we are immediately inside a
3097 # namespace body. In other words, don't issue blank line warnings
3098 # for this block:
3099 # namespace {
3100 #
3101 # }
3102 #
3103 # A warning about missing end of namespace comments will be issued instead.
avakulenko@google.com02af6282014-06-04 18:53:25 +00003104 #
3105 # Also skip blank line checks for 'extern "C"' blocks, which are formatted
3106 # like namespaces.
3107 if (IsBlankLine(line) and
3108 not nesting_state.InNamespaceBody() and
3109 not nesting_state.InExternC()):
erg@google.com4e00b9a2009-01-12 23:05:11 +00003110 elided = clean_lines.elided
3111 prev_line = elided[linenum - 1]
3112 prevbrace = prev_line.rfind('{')
3113 # TODO(unknown): Don't complain if line before blank line, and line after,
3114 # both start with alnums and are indented the same amount.
3115 # This ignores whitespace at the start of a namespace block
3116 # because those are not usually indented.
erg@google.comd350fe52013-01-14 17:51:48 +00003117 if prevbrace != -1 and prev_line[prevbrace:].find('}') == -1:
erg@google.com4e00b9a2009-01-12 23:05:11 +00003118 # OK, we have a blank line at the start of a code block. Before we
3119 # complain, we check if it is an exception to the rule: The previous
erg@google.com8a95ecc2011-09-08 00:45:54 +00003120 # non-empty line has the parameters of a function header that are indented
erg@google.com4e00b9a2009-01-12 23:05:11 +00003121 # 4 spaces (because they did not fit in a 80 column line when placed on
3122 # the same line as the function name). We also check for the case where
3123 # the previous line is indented 6 spaces, which may happen when the
3124 # initializers of a constructor do not fit into a 80 column line.
3125 exception = False
3126 if Match(r' {6}\w', prev_line): # Initializer list?
3127 # We are looking for the opening column of initializer list, which
3128 # should be indented 4 spaces to cause 6 space indentation afterwards.
3129 search_position = linenum-2
3130 while (search_position >= 0
3131 and Match(r' {6}\w', elided[search_position])):
3132 search_position -= 1
3133 exception = (search_position >= 0
3134 and elided[search_position][:5] == ' :')
3135 else:
3136 # Search for the function arguments or an initializer list. We use a
3137 # simple heuristic here: If the line is indented 4 spaces; and we have a
3138 # closing paren, without the opening paren, followed by an opening brace
3139 # or colon (for initializer lists) we assume that it is the last line of
3140 # a function header. If we have a colon indented 4 spaces, it is an
3141 # initializer list.
3142 exception = (Match(r' {4}\w[^\(]*\)\s*(const\s*)?(\{\s*$|:)',
3143 prev_line)
3144 or Match(r' {4}:', prev_line))
3145
3146 if not exception:
3147 error(filename, linenum, 'whitespace/blank_line', 2,
erg@google.com2aa59982013-10-28 19:09:25 +00003148 'Redundant blank line at the start of a code block '
3149 'should be deleted.')
erg@google.comd350fe52013-01-14 17:51:48 +00003150 # Ignore blank lines at the end of a block in a long if-else
erg@google.com4e00b9a2009-01-12 23:05:11 +00003151 # chain, like this:
3152 # if (condition1) {
3153 # // Something followed by a blank line
3154 #
3155 # } else if (condition2) {
3156 # // Something else
3157 # }
3158 if linenum + 1 < clean_lines.NumLines():
3159 next_line = raw[linenum + 1]
3160 if (next_line
3161 and Match(r'\s*}', next_line)
erg@google.com4e00b9a2009-01-12 23:05:11 +00003162 and next_line.find('} else ') == -1):
3163 error(filename, linenum, 'whitespace/blank_line', 3,
erg@google.com2aa59982013-10-28 19:09:25 +00003164 'Redundant blank line at the end of a code block '
3165 'should be deleted.')
erg@google.com4e00b9a2009-01-12 23:05:11 +00003166
erg@google.com8a95ecc2011-09-08 00:45:54 +00003167 matched = Match(r'\s*(public|protected|private):', prev_line)
3168 if matched:
3169 error(filename, linenum, 'whitespace/blank_line', 3,
3170 'Do not leave a blank line after "%s:"' % matched.group(1))
3171
avakulenko@google.com02af6282014-06-04 18:53:25 +00003172 # Next, check comments
3173 next_line_start = 0
3174 if linenum + 1 < clean_lines.NumLines():
3175 next_line = raw[linenum + 1]
3176 next_line_start = len(next_line) - len(next_line.lstrip())
3177 CheckComment(line, filename, linenum, next_line_start, error)
erg@google.com4e00b9a2009-01-12 23:05:11 +00003178
avakulenko@google.com02af6282014-06-04 18:53:25 +00003179 # get rid of comments and strings
3180 line = clean_lines.elided[linenum]
erg@google.com4e00b9a2009-01-12 23:05:11 +00003181
avakulenko@google.com02af6282014-06-04 18:53:25 +00003182 # You shouldn't have spaces before your brackets, except maybe after
3183 # 'delete []' or 'return []() {};'
3184 if Search(r'\w\s+\[', line) and not Search(r'(?:delete|return)\s+\[', line):
3185 error(filename, linenum, 'whitespace/braces', 5,
3186 'Extra space before [')
3187
3188 # In range-based for, we wanted spaces before and after the colon, but
3189 # not around "::" tokens that might appear.
3190 if (Search(r'for *\(.*[^:]:[^: ]', line) or
3191 Search(r'for *\(.*[^: ]:[^:]', line)):
3192 error(filename, linenum, 'whitespace/forcolon', 2,
3193 'Missing space around colon in range-based for loop')
3194
3195
3196def CheckOperatorSpacing(filename, clean_lines, linenum, error):
3197 """Checks for horizontal spacing around operators.
3198
3199 Args:
3200 filename: The name of the current file.
3201 clean_lines: A CleansedLines instance containing the file.
3202 linenum: The number of the line to check.
3203 error: The function to call with any errors found.
3204 """
3205 line = clean_lines.elided[linenum]
3206
3207 # Don't try to do spacing checks for operator methods. Do this by
3208 # replacing the troublesome characters with something else,
3209 # preserving column position for all other characters.
3210 #
3211 # The replacement is done repeatedly to avoid false positives from
3212 # operators that call operators.
3213 while True:
3214 match = Match(r'^(.*\boperator\b)(\S+)(\s*\(.*)$', line)
3215 if match:
3216 line = match.group(1) + ('_' * len(match.group(2))) + match.group(3)
3217 else:
3218 break
erg@google.com4e00b9a2009-01-12 23:05:11 +00003219
3220 # We allow no-spaces around = within an if: "if ( (a=Foo()) == 0 )".
3221 # Otherwise not. Note we only check for non-spaces on *both* sides;
3222 # sometimes people put non-spaces on one side when aligning ='s among
3223 # many lines (not that this is behavior that I approve of...)
avakulenko@google.com554223d2014-12-04 22:00:20 +00003224 if ((Search(r'[\w.]=', line) or
3225 Search(r'=[\w.]', line))
3226 and not Search(r'\b(if|while|for) ', line)
3227 # Operators taken from [lex.operators] in C++11 standard.
3228 and not Search(r'(>=|<=|==|!=|&=|\^=|\|=|\+=|\*=|\/=|\%=)', line)
3229 and not Search(r'operator=', line)):
erg@google.com4e00b9a2009-01-12 23:05:11 +00003230 error(filename, linenum, 'whitespace/operators', 4,
3231 'Missing spaces around =')
3232
3233 # It's ok not to have spaces around binary operators like + - * /, but if
3234 # there's too little whitespace, we get concerned. It's hard to tell,
3235 # though, so we punt on this one for now. TODO.
3236
3237 # You should always have whitespace around binary operators.
erg@google.comd350fe52013-01-14 17:51:48 +00003238 #
3239 # Check <= and >= first to avoid false positives with < and >, then
3240 # check non-include lines for spacing around < and >.
avakulenko@google.com02af6282014-06-04 18:53:25 +00003241 #
3242 # If the operator is followed by a comma, assume it's be used in a
3243 # macro context and don't do any checks. This avoids false
3244 # positives.
3245 #
Alex Vakulenko01e47232016-05-06 13:54:15 -07003246 # Note that && is not included here. This is because there are too
3247 # many false positives due to RValue references.
avakulenko@google.com02af6282014-06-04 18:53:25 +00003248 match = Search(r'[^<>=!\s](==|!=|<=|>=|\|\|)[^<>=!\s,;\)]', line)
erg@google.com4e00b9a2009-01-12 23:05:11 +00003249 if match:
3250 error(filename, linenum, 'whitespace/operators', 3,
3251 'Missing spaces around %s' % match.group(1))
erg@google.comd350fe52013-01-14 17:51:48 +00003252 elif not Match(r'#.*include', line):
erg@google.comd350fe52013-01-14 17:51:48 +00003253 # Look for < that is not surrounded by spaces. This is only
3254 # triggered if both sides are missing spaces, even though
3255 # technically should should flag if at least one side is missing a
3256 # space. This is done to avoid some false positives with shifts.
avakulenko@google.com02af6282014-06-04 18:53:25 +00003257 match = Match(r'^(.*[^\s<])<[^\s=<,]', line)
3258 if match:
3259 (_, _, end_pos) = CloseExpression(
3260 clean_lines, linenum, len(match.group(1)))
3261 if end_pos <= -1:
3262 error(filename, linenum, 'whitespace/operators', 3,
3263 'Missing spaces around <')
erg@google.comd350fe52013-01-14 17:51:48 +00003264
3265 # Look for > that is not surrounded by spaces. Similar to the
3266 # above, we only trigger if both sides are missing spaces to avoid
3267 # false positives with shifts.
avakulenko@google.com02af6282014-06-04 18:53:25 +00003268 match = Match(r'^(.*[^-\s>])>[^\s=>,]', line)
3269 if match:
3270 (_, _, start_pos) = ReverseCloseExpression(
3271 clean_lines, linenum, len(match.group(1)))
3272 if start_pos <= -1:
3273 error(filename, linenum, 'whitespace/operators', 3,
3274 'Missing spaces around >')
3275
3276 # We allow no-spaces around << when used like this: 10<<20, but
3277 # not otherwise (particularly, not when used as streams)
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00003278 #
avakulenko@google.com02af6282014-06-04 18:53:25 +00003279 # We also allow operators following an opening parenthesis, since
3280 # those tend to be macros that deal with operators.
Alex Vakulenko01e47232016-05-06 13:54:15 -07003281 match = Search(r'(operator|[^\s(<])(?:L|UL|LL|ULL|l|ul|ll|ull)?<<([^\s,=<])', line)
avakulenko@google.com554223d2014-12-04 22:00:20 +00003282 if (match and not (match.group(1).isdigit() and match.group(2).isdigit()) and
avakulenko@google.com02af6282014-06-04 18:53:25 +00003283 not (match.group(1) == 'operator' and match.group(2) == ';')):
3284 error(filename, linenum, 'whitespace/operators', 3,
3285 'Missing spaces around <<')
erg@google.comd350fe52013-01-14 17:51:48 +00003286
3287 # We allow no-spaces around >> for almost anything. This is because
3288 # C++11 allows ">>" to close nested templates, which accounts for
3289 # most cases when ">>" is not followed by a space.
3290 #
3291 # We still warn on ">>" followed by alpha character, because that is
3292 # likely due to ">>" being used for right shifts, e.g.:
3293 # value >> alpha
3294 #
3295 # When ">>" is used to close templates, the alphanumeric letter that
3296 # follows would be part of an identifier, and there should still be
3297 # a space separating the template type and the identifier.
3298 # type<type<type>> alpha
3299 match = Search(r'>>[a-zA-Z_]', line)
erg@google.com4e00b9a2009-01-12 23:05:11 +00003300 if match:
3301 error(filename, linenum, 'whitespace/operators', 3,
erg@google.comd350fe52013-01-14 17:51:48 +00003302 'Missing spaces around >>')
erg@google.com4e00b9a2009-01-12 23:05:11 +00003303
3304 # There shouldn't be space around unary operators
3305 match = Search(r'(!\s|~\s|[\s]--[\s;]|[\s]\+\+[\s;])', line)
3306 if match:
3307 error(filename, linenum, 'whitespace/operators', 4,
3308 'Extra space for operator %s' % match.group(1))
3309
avakulenko@google.com02af6282014-06-04 18:53:25 +00003310
3311def CheckParenthesisSpacing(filename, clean_lines, linenum, error):
3312 """Checks for horizontal spacing around parentheses.
3313
3314 Args:
3315 filename: The name of the current file.
3316 clean_lines: A CleansedLines instance containing the file.
3317 linenum: The number of the line to check.
3318 error: The function to call with any errors found.
3319 """
3320 line = clean_lines.elided[linenum]
3321
3322 # No spaces after an if, while, switch, or for
erg@google.com4e00b9a2009-01-12 23:05:11 +00003323 match = Search(r' (if\(|for\(|while\(|switch\()', line)
3324 if match:
3325 error(filename, linenum, 'whitespace/parens', 5,
3326 'Missing space before ( in %s' % match.group(1))
3327
3328 # For if/for/while/switch, the left and right parens should be
3329 # consistent about how many spaces are inside the parens, and
3330 # there should either be zero or one spaces inside the parens.
3331 # We don't want: "if ( foo)" or "if ( foo )".
erg@google.come35f7652009-06-19 20:52:09 +00003332 # Exception: "for ( ; foo; bar)" and "for (foo; bar; )" are allowed.
erg@google.com4e00b9a2009-01-12 23:05:11 +00003333 match = Search(r'\b(if|for|while|switch)\s*'
3334 r'\(([ ]*)(.).*[^ ]+([ ]*)\)\s*{\s*$',
3335 line)
3336 if match:
3337 if len(match.group(2)) != len(match.group(4)):
3338 if not (match.group(3) == ';' and
erg@google.come35f7652009-06-19 20:52:09 +00003339 len(match.group(2)) == 1 + len(match.group(4)) or
3340 not match.group(2) and Search(r'\bfor\s*\(.*; \)', line)):
erg@google.com4e00b9a2009-01-12 23:05:11 +00003341 error(filename, linenum, 'whitespace/parens', 5,
3342 'Mismatching spaces inside () in %s' % match.group(1))
erg@google.comc6671232013-10-25 21:44:03 +00003343 if len(match.group(2)) not in [0, 1]:
erg@google.com4e00b9a2009-01-12 23:05:11 +00003344 error(filename, linenum, 'whitespace/parens', 5,
3345 'Should have zero or one spaces inside ( and ) in %s' %
3346 match.group(1))
3347
avakulenko@google.com02af6282014-06-04 18:53:25 +00003348
3349def CheckCommaSpacing(filename, clean_lines, linenum, error):
3350 """Checks for horizontal spacing near commas and semicolons.
3351
3352 Args:
3353 filename: The name of the current file.
3354 clean_lines: A CleansedLines instance containing the file.
3355 linenum: The number of the line to check.
3356 error: The function to call with any errors found.
3357 """
3358 raw = clean_lines.lines_without_raw_strings
3359 line = clean_lines.elided[linenum]
3360
erg@google.com4e00b9a2009-01-12 23:05:11 +00003361 # You should always have a space after a comma (either as fn arg or operator)
erg@google.comc6671232013-10-25 21:44:03 +00003362 #
3363 # This does not apply when the non-space character following the
3364 # comma is another comma, since the only time when that happens is
3365 # for empty macro arguments.
erg@google.com2aa59982013-10-28 19:09:25 +00003366 #
3367 # We run this check in two passes: first pass on elided lines to
3368 # verify that lines contain missing whitespaces, second pass on raw
3369 # lines to confirm that those missing whitespaces are not due to
3370 # elided comments.
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00003371 if (Search(r',[^,\s]', ReplaceAll(r'\boperator\s*,\s*\(', 'F(', line)) and
3372 Search(r',[^,\s]', raw[linenum])):
erg@google.com4e00b9a2009-01-12 23:05:11 +00003373 error(filename, linenum, 'whitespace/comma', 3,
3374 'Missing space after ,')
3375
erg@google.comd7d27472011-09-07 17:36:35 +00003376 # You should always have a space after a semicolon
3377 # except for few corner cases
3378 # TODO(unknown): clarify if 'if (1) { return 1;}' is requires one more
3379 # space after ;
3380 if Search(r';[^\s};\\)/]', line):
3381 error(filename, linenum, 'whitespace/semicolon', 3,
3382 'Missing space after ;')
3383
avakulenko@google.com02af6282014-06-04 18:53:25 +00003384
Alex Vakulenko01e47232016-05-06 13:54:15 -07003385def _IsType(clean_lines, nesting_state, expr):
3386 """Check if expression looks like a type name, returns true if so.
3387
3388 Args:
3389 clean_lines: A CleansedLines instance containing the file.
3390 nesting_state: A NestingState instance which maintains information about
3391 the current stack of nested blocks being parsed.
3392 expr: The expression to check.
3393 Returns:
3394 True, if token looks like a type.
3395 """
3396 # Keep only the last token in the expression
3397 last_word = Match(r'^.*(\b\S+)$', expr)
3398 if last_word:
3399 token = last_word.group(1)
3400 else:
3401 token = expr
3402
3403 # Match native types and stdint types
3404 if _TYPES.match(token):
3405 return True
3406
3407 # Try a bit harder to match templated types. Walk up the nesting
3408 # stack until we find something that resembles a typename
3409 # declaration for what we are looking for.
3410 typename_pattern = (r'\b(?:typename|class|struct)\s+' + re.escape(token) +
3411 r'\b')
3412 block_index = len(nesting_state.stack) - 1
3413 while block_index >= 0:
3414 if isinstance(nesting_state.stack[block_index], _NamespaceInfo):
3415 return False
3416
3417 # Found where the opening brace is. We want to scan from this
3418 # line up to the beginning of the function, minus a few lines.
3419 # template <typename Type1, // stop scanning here
3420 # ...>
3421 # class C
3422 # : public ... { // start scanning here
3423 last_line = nesting_state.stack[block_index].starting_linenum
3424
3425 next_block_start = 0
3426 if block_index > 0:
3427 next_block_start = nesting_state.stack[block_index - 1].starting_linenum
3428 first_line = last_line
3429 while first_line >= next_block_start:
3430 if clean_lines.elided[first_line].find('template') >= 0:
3431 break
3432 first_line -= 1
3433 if first_line < next_block_start:
3434 # Didn't find any "template" keyword before reaching the next block,
3435 # there are probably no template things to check for this block
3436 block_index -= 1
3437 continue
3438
3439 # Look for typename in the specified range
3440 for i in xrange(first_line, last_line + 1, 1):
3441 if Search(typename_pattern, clean_lines.elided[i]):
3442 return True
3443 block_index -= 1
3444
3445 return False
3446
3447
3448def CheckBracesSpacing(filename, clean_lines, linenum, nesting_state, error):
avakulenko@google.com02af6282014-06-04 18:53:25 +00003449 """Checks for horizontal spacing near commas.
3450
3451 Args:
3452 filename: The name of the current file.
3453 clean_lines: A CleansedLines instance containing the file.
3454 linenum: The number of the line to check.
Alex Vakulenko01e47232016-05-06 13:54:15 -07003455 nesting_state: A NestingState instance which maintains information about
3456 the current stack of nested blocks being parsed.
avakulenko@google.com02af6282014-06-04 18:53:25 +00003457 error: The function to call with any errors found.
3458 """
3459 line = clean_lines.elided[linenum]
erg@google.com4e00b9a2009-01-12 23:05:11 +00003460
erg@google.com8a95ecc2011-09-08 00:45:54 +00003461 # Except after an opening paren, or after another opening brace (in case of
3462 # an initializer list, for instance), you should have spaces before your
Alex Vakulenko01e47232016-05-06 13:54:15 -07003463 # braces when they are delimiting blocks, classes, namespaces etc.
3464 # And since you should never have braces at the beginning of a line,
3465 # this is an easy test. Except that braces used for initialization don't
3466 # follow the same rule; we often don't want spaces before those.
avakulenko@google.com554223d2014-12-04 22:00:20 +00003467 match = Match(r'^(.*[^ ({>]){', line)
Alex Vakulenko01e47232016-05-06 13:54:15 -07003468
erg@google.com2aa59982013-10-28 19:09:25 +00003469 if match:
3470 # Try a bit harder to check for brace initialization. This
3471 # happens in one of the following forms:
3472 # Constructor() : initializer_list_{} { ... }
3473 # Constructor{}.MemberFunction()
3474 # Type variable{};
3475 # FunctionCall(type{}, ...);
3476 # LastArgument(..., type{});
3477 # LOG(INFO) << type{} << " ...";
3478 # map_of_type[{...}] = ...;
avakulenko@google.com02af6282014-06-04 18:53:25 +00003479 # ternary = expr ? new type{} : nullptr;
3480 # OuterTemplate<InnerTemplateConstructor<Type>{}>
erg@google.com2aa59982013-10-28 19:09:25 +00003481 #
3482 # We check for the character following the closing brace, and
3483 # silence the warning if it's one of those listed above, i.e.
avakulenko@google.com02af6282014-06-04 18:53:25 +00003484 # "{.;,)<>]:".
erg@google.com2aa59982013-10-28 19:09:25 +00003485 #
3486 # To account for nested initializer list, we allow any number of
3487 # closing braces up to "{;,)<". We can't simply silence the
3488 # warning on first sight of closing brace, because that would
3489 # cause false negatives for things that are not initializer lists.
3490 # Silence this: But not this:
3491 # Outer{ if (...) {
3492 # Inner{...} if (...){ // Missing space before {
3493 # }; }
3494 #
3495 # There is a false negative with this approach if people inserted
3496 # spurious semicolons, e.g. "if (cond){};", but we will catch the
3497 # spurious semicolon with a separate check.
Alex Vakulenko01e47232016-05-06 13:54:15 -07003498 leading_text = match.group(1)
erg@google.com2aa59982013-10-28 19:09:25 +00003499 (endline, endlinenum, endpos) = CloseExpression(
3500 clean_lines, linenum, len(match.group(1)))
3501 trailing_text = ''
3502 if endpos > -1:
3503 trailing_text = endline[endpos:]
3504 for offset in xrange(endlinenum + 1,
3505 min(endlinenum + 3, clean_lines.NumLines() - 1)):
3506 trailing_text += clean_lines.elided[offset]
Alex Vakulenko01e47232016-05-06 13:54:15 -07003507 # We also suppress warnings for `uint64_t{expression}` etc., as the style
3508 # guide recommends brace initialization for integral types to avoid
3509 # overflow/truncation.
3510 if (not Match(r'^[\s}]*[{.;,)<>\]:]', trailing_text)
3511 and not _IsType(clean_lines, nesting_state, leading_text)):
erg@google.com2aa59982013-10-28 19:09:25 +00003512 error(filename, linenum, 'whitespace/braces', 5,
3513 'Missing space before {')
erg@google.com4e00b9a2009-01-12 23:05:11 +00003514
3515 # Make sure '} else {' has spaces.
3516 if Search(r'}else', line):
3517 error(filename, linenum, 'whitespace/braces', 5,
3518 'Missing space before else')
3519
erg@google.com4e00b9a2009-01-12 23:05:11 +00003520 # You shouldn't have a space before a semicolon at the end of the line.
3521 # There's a special case for "for" since the style guide allows space before
3522 # the semicolon there.
3523 if Search(r':\s*;\s*$', line):
3524 error(filename, linenum, 'whitespace/semicolon', 5,
erg@google.comd350fe52013-01-14 17:51:48 +00003525 'Semicolon defining empty statement. Use {} instead.')
erg@google.com4e00b9a2009-01-12 23:05:11 +00003526 elif Search(r'^\s*;\s*$', line):
3527 error(filename, linenum, 'whitespace/semicolon', 5,
3528 'Line contains only semicolon. If this should be an empty statement, '
erg@google.comd350fe52013-01-14 17:51:48 +00003529 'use {} instead.')
erg@google.com4e00b9a2009-01-12 23:05:11 +00003530 elif (Search(r'\s+;\s*$', line) and
3531 not Search(r'\bfor\b', line)):
3532 error(filename, linenum, 'whitespace/semicolon', 5,
3533 'Extra space before last semicolon. If this should be an empty '
erg@google.comd350fe52013-01-14 17:51:48 +00003534 'statement, use {} instead.')
3535
avakulenko@google.com02af6282014-06-04 18:53:25 +00003536
3537def IsDecltype(clean_lines, linenum, column):
3538 """Check if the token ending on (linenum, column) is decltype().
3539
3540 Args:
3541 clean_lines: A CleansedLines instance containing the file.
3542 linenum: the number of the line to check.
3543 column: end column of the token to check.
3544 Returns:
3545 True if this token is decltype() expression, False otherwise.
3546 """
3547 (text, _, start_col) = ReverseCloseExpression(clean_lines, linenum, column)
3548 if start_col < 0:
3549 return False
3550 if Search(r'\bdecltype\s*$', text[0:start_col]):
3551 return True
3552 return False
3553
3554
erg@google.com8a95ecc2011-09-08 00:45:54 +00003555def CheckSectionSpacing(filename, clean_lines, class_info, linenum, error):
3556 """Checks for additional blank line issues related to sections.
3557
3558 Currently the only thing checked here is blank line before protected/private.
3559
3560 Args:
3561 filename: The name of the current file.
3562 clean_lines: A CleansedLines instance containing the file.
3563 class_info: A _ClassInfo objects.
3564 linenum: The number of the line to check.
3565 error: The function to call with any errors found.
3566 """
3567 # Skip checks if the class is small, where small means 25 lines or less.
3568 # 25 lines seems like a good cutoff since that's the usual height of
3569 # terminals, and any class that can't fit in one screen can't really
3570 # be considered "small".
3571 #
3572 # Also skip checks if we are on the first line. This accounts for
3573 # classes that look like
3574 # class Foo { public: ... };
3575 #
3576 # If we didn't find the end of the class, last_line would be zero,
3577 # and the check will be skipped by the first condition.
erg@google.comd350fe52013-01-14 17:51:48 +00003578 if (class_info.last_line - class_info.starting_linenum <= 24 or
3579 linenum <= class_info.starting_linenum):
erg@google.com8a95ecc2011-09-08 00:45:54 +00003580 return
3581
3582 matched = Match(r'\s*(public|protected|private):', clean_lines.lines[linenum])
3583 if matched:
3584 # Issue warning if the line before public/protected/private was
3585 # not a blank line, but don't do this if the previous line contains
3586 # "class" or "struct". This can happen two ways:
3587 # - We are at the beginning of the class.
3588 # - We are forward-declaring an inner class that is semantically
3589 # private, but needed to be public for implementation reasons.
erg@google.comd350fe52013-01-14 17:51:48 +00003590 # Also ignores cases where the previous line ends with a backslash as can be
3591 # common when defining classes in C macros.
erg@google.com8a95ecc2011-09-08 00:45:54 +00003592 prev_line = clean_lines.lines[linenum - 1]
3593 if (not IsBlankLine(prev_line) and
erg@google.comd350fe52013-01-14 17:51:48 +00003594 not Search(r'\b(class|struct)\b', prev_line) and
3595 not Search(r'\\$', prev_line)):
erg@google.com8a95ecc2011-09-08 00:45:54 +00003596 # Try a bit harder to find the beginning of the class. This is to
3597 # account for multi-line base-specifier lists, e.g.:
3598 # class Derived
3599 # : public Base {
erg@google.comd350fe52013-01-14 17:51:48 +00003600 end_class_head = class_info.starting_linenum
3601 for i in range(class_info.starting_linenum, linenum):
erg@google.com8a95ecc2011-09-08 00:45:54 +00003602 if Search(r'\{\s*$', clean_lines.lines[i]):
3603 end_class_head = i
3604 break
3605 if end_class_head < linenum - 1:
3606 error(filename, linenum, 'whitespace/blank_line', 3,
3607 '"%s:" should be preceded by a blank line' % matched.group(1))
3608
3609
erg@google.com4e00b9a2009-01-12 23:05:11 +00003610def GetPreviousNonBlankLine(clean_lines, linenum):
3611 """Return the most recent non-blank line and its line number.
3612
3613 Args:
3614 clean_lines: A CleansedLines instance containing the file contents.
3615 linenum: The number of the line to check.
3616
3617 Returns:
3618 A tuple with two elements. The first element is the contents of the last
3619 non-blank line before the current line, or the empty string if this is the
3620 first non-blank line. The second is the line number of that line, or -1
3621 if this is the first non-blank line.
3622 """
3623
3624 prevlinenum = linenum - 1
3625 while prevlinenum >= 0:
3626 prevline = clean_lines.elided[prevlinenum]
3627 if not IsBlankLine(prevline): # if not a blank line...
3628 return (prevline, prevlinenum)
3629 prevlinenum -= 1
3630 return ('', -1)
3631
3632
3633def CheckBraces(filename, clean_lines, linenum, error):
3634 """Looks for misplaced braces (e.g. at the end of line).
3635
3636 Args:
3637 filename: The name of the current file.
3638 clean_lines: A CleansedLines instance containing the file.
3639 linenum: The number of the line to check.
3640 error: The function to call with any errors found.
3641 """
3642
3643 line = clean_lines.elided[linenum] # get rid of comments and strings
3644
3645 if Match(r'\s*{\s*$', line):
erg@google.com2aa59982013-10-28 19:09:25 +00003646 # We allow an open brace to start a line in the case where someone is using
3647 # braces in a block to explicitly create a new scope, which is commonly used
3648 # to control the lifetime of stack-allocated variables. Braces are also
3649 # used for brace initializers inside function calls. We don't detect this
3650 # perfectly: we just don't complain if the last non-whitespace character on
3651 # the previous non-blank line is ',', ';', ':', '(', '{', or '}', or if the
Alex Vakulenko01e47232016-05-06 13:54:15 -07003652 # previous line starts a preprocessor block. We also allow a brace on the
3653 # following line if it is part of an array initialization and would not fit
3654 # within the 80 character limit of the preceding line.
erg@google.com4e00b9a2009-01-12 23:05:11 +00003655 prevline = GetPreviousNonBlankLine(clean_lines, linenum)[0]
erg@google.com2aa59982013-10-28 19:09:25 +00003656 if (not Search(r'[,;:}{(]\s*$', prevline) and
Alex Vakulenko01e47232016-05-06 13:54:15 -07003657 not Match(r'\s*#', prevline) and
3658 not (GetLineWidth(prevline) > _line_length - 2 and '[]' in prevline)):
erg@google.com4e00b9a2009-01-12 23:05:11 +00003659 error(filename, linenum, 'whitespace/braces', 4,
3660 '{ should almost always be at the end of the previous line')
3661
3662 # An else clause should be on the same line as the preceding closing brace.
avakulenko@google.com02af6282014-06-04 18:53:25 +00003663 if Match(r'\s*else\b\s*(?:if\b|\{|$)', line):
erg@google.com4e00b9a2009-01-12 23:05:11 +00003664 prevline = GetPreviousNonBlankLine(clean_lines, linenum)[0]
3665 if Match(r'\s*}\s*$', prevline):
3666 error(filename, linenum, 'whitespace/newline', 4,
3667 'An else should appear on the same line as the preceding }')
3668
3669 # If braces come on one side of an else, they should be on both.
3670 # However, we have to worry about "else if" that spans multiple lines!
avakulenko@google.com02af6282014-06-04 18:53:25 +00003671 if Search(r'else if\s*\(', line): # could be multi-line if
3672 brace_on_left = bool(Search(r'}\s*else if\s*\(', line))
3673 # find the ( after the if
3674 pos = line.find('else if')
3675 pos = line.find('(', pos)
3676 if pos > 0:
3677 (endline, _, endpos) = CloseExpression(clean_lines, linenum, pos)
3678 brace_on_right = endline[endpos:].find('{') != -1
3679 if brace_on_left != brace_on_right: # must be brace after if
3680 error(filename, linenum, 'readability/braces', 5,
3681 'If an else has a brace on one side, it should have it on both')
3682 elif Search(r'}\s*else[^{]*$', line) or Match(r'[^}]*else\s*{', line):
3683 error(filename, linenum, 'readability/braces', 5,
3684 'If an else has a brace on one side, it should have it on both')
erg@google.com4e00b9a2009-01-12 23:05:11 +00003685
3686 # Likewise, an else should never have the else clause on the same line
3687 if Search(r'\belse [^\s{]', line) and not Search(r'\belse if\b', line):
3688 error(filename, linenum, 'whitespace/newline', 4,
3689 'Else clause should never be on same line as else (use 2 lines)')
3690
3691 # In the same way, a do/while should never be on one line
3692 if Match(r'\s*do [^\s{]', line):
3693 error(filename, linenum, 'whitespace/newline', 4,
3694 'do/while clauses should not be on a single line')
3695
avakulenko@google.com02af6282014-06-04 18:53:25 +00003696 # Check single-line if/else bodies. The style guide says 'curly braces are not
3697 # required for single-line statements'. We additionally allow multi-line,
3698 # single statements, but we reject anything with more than one semicolon in
3699 # it. This means that the first semicolon after the if should be at the end of
3700 # its line, and the line after that should have an indent level equal to or
3701 # lower than the if. We also check for ambiguous if/else nesting without
3702 # braces.
3703 if_else_match = Search(r'\b(if\s*\(|else\b)', line)
3704 if if_else_match and not Match(r'\s*#', line):
3705 if_indent = GetIndentLevel(line)
3706 endline, endlinenum, endpos = line, linenum, if_else_match.end()
3707 if_match = Search(r'\bif\s*\(', line)
3708 if if_match:
3709 # This could be a multiline if condition, so find the end first.
3710 pos = if_match.end() - 1
3711 (endline, endlinenum, endpos) = CloseExpression(clean_lines, linenum, pos)
3712 # Check for an opening brace, either directly after the if or on the next
3713 # line. If found, this isn't a single-statement conditional.
3714 if (not Match(r'\s*{', endline[endpos:])
3715 and not (Match(r'\s*$', endline[endpos:])
3716 and endlinenum < (len(clean_lines.elided) - 1)
3717 and Match(r'\s*{', clean_lines.elided[endlinenum + 1]))):
3718 while (endlinenum < len(clean_lines.elided)
3719 and ';' not in clean_lines.elided[endlinenum][endpos:]):
3720 endlinenum += 1
3721 endpos = 0
3722 if endlinenum < len(clean_lines.elided):
3723 endline = clean_lines.elided[endlinenum]
3724 # We allow a mix of whitespace and closing braces (e.g. for one-liner
3725 # methods) and a single \ after the semicolon (for macros)
3726 endpos = endline.find(';')
3727 if not Match(r';[\s}]*(\\?)$', endline[endpos:]):
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00003728 # Semicolon isn't the last character, there's something trailing.
3729 # Output a warning if the semicolon is not contained inside
3730 # a lambda expression.
3731 if not Match(r'^[^{};]*\[[^\[\]]*\][^{}]*\{[^{}]*\}\s*\)*[;,]\s*$',
3732 endline):
3733 error(filename, linenum, 'readability/braces', 4,
3734 'If/else bodies with multiple statements require braces')
avakulenko@google.com02af6282014-06-04 18:53:25 +00003735 elif endlinenum < len(clean_lines.elided) - 1:
3736 # Make sure the next line is dedented
3737 next_line = clean_lines.elided[endlinenum + 1]
3738 next_indent = GetIndentLevel(next_line)
3739 # With ambiguous nested if statements, this will error out on the
3740 # if that *doesn't* match the else, regardless of whether it's the
3741 # inner one or outer one.
3742 if (if_match and Match(r'\s*else\b', next_line)
3743 and next_indent != if_indent):
3744 error(filename, linenum, 'readability/braces', 4,
3745 'Else clause should be indented at the same level as if. '
3746 'Ambiguous nested if/else chains require braces.')
3747 elif next_indent > if_indent:
3748 error(filename, linenum, 'readability/braces', 4,
3749 'If/else bodies with multiple statements require braces')
3750
3751
3752def CheckTrailingSemicolon(filename, clean_lines, linenum, error):
3753 """Looks for redundant trailing semicolon.
3754
3755 Args:
3756 filename: The name of the current file.
3757 clean_lines: A CleansedLines instance containing the file.
3758 linenum: The number of the line to check.
3759 error: The function to call with any errors found.
3760 """
3761
3762 line = clean_lines.elided[linenum]
3763
erg@google.com2aa59982013-10-28 19:09:25 +00003764 # Block bodies should not be followed by a semicolon. Due to C++11
3765 # brace initialization, there are more places where semicolons are
3766 # required than not, so we use a whitelist approach to check these
3767 # rather than a blacklist. These are the places where "};" should
3768 # be replaced by just "}":
3769 # 1. Some flavor of block following closing parenthesis:
3770 # for (;;) {};
3771 # while (...) {};
3772 # switch (...) {};
3773 # Function(...) {};
3774 # if (...) {};
3775 # if (...) else if (...) {};
3776 #
3777 # 2. else block:
3778 # if (...) else {};
3779 #
3780 # 3. const member function:
3781 # Function(...) const {};
3782 #
3783 # 4. Block following some statement:
3784 # x = 42;
3785 # {};
3786 #
3787 # 5. Block at the beginning of a function:
3788 # Function(...) {
3789 # {};
3790 # }
3791 #
3792 # Note that naively checking for the preceding "{" will also match
3793 # braces inside multi-dimensional arrays, but this is fine since
3794 # that expression will not contain semicolons.
3795 #
3796 # 6. Block following another block:
3797 # while (true) {}
3798 # {};
3799 #
3800 # 7. End of namespaces:
3801 # namespace {};
3802 #
3803 # These semicolons seems far more common than other kinds of
3804 # redundant semicolons, possibly due to people converting classes
3805 # to namespaces. For now we do not warn for this case.
3806 #
3807 # Try matching case 1 first.
3808 match = Match(r'^(.*\)\s*)\{', line)
3809 if match:
3810 # Matched closing parenthesis (case 1). Check the token before the
3811 # matching opening parenthesis, and don't warn if it looks like a
3812 # macro. This avoids these false positives:
3813 # - macro that defines a base class
3814 # - multi-line macro that defines a base class
3815 # - macro that defines the whole class-head
3816 #
3817 # But we still issue warnings for macros that we know are safe to
3818 # warn, specifically:
3819 # - TEST, TEST_F, TEST_P, MATCHER, MATCHER_P
3820 # - TYPED_TEST
3821 # - INTERFACE_DEF
3822 # - EXCLUSIVE_LOCKS_REQUIRED, SHARED_LOCKS_REQUIRED, LOCKS_EXCLUDED:
3823 #
3824 # We implement a whitelist of safe macros instead of a blacklist of
3825 # unsafe macros, even though the latter appears less frequently in
3826 # google code and would have been easier to implement. This is because
3827 # the downside for getting the whitelist wrong means some extra
3828 # semicolons, while the downside for getting the blacklist wrong
3829 # would result in compile errors.
3830 #
avakulenko@google.com554223d2014-12-04 22:00:20 +00003831 # In addition to macros, we also don't want to warn on
3832 # - Compound literals
3833 # - Lambdas
Alex Vakulenko01e47232016-05-06 13:54:15 -07003834 # - alignas specifier with anonymous structs
3835 # - decltype
erg@google.com2aa59982013-10-28 19:09:25 +00003836 closing_brace_pos = match.group(1).rfind(')')
3837 opening_parenthesis = ReverseCloseExpression(
3838 clean_lines, linenum, closing_brace_pos)
3839 if opening_parenthesis[2] > -1:
3840 line_prefix = opening_parenthesis[0][0:opening_parenthesis[2]]
Alex Vakulenko01e47232016-05-06 13:54:15 -07003841 macro = Search(r'\b([A-Z_][A-Z0-9_]*)\s*$', line_prefix)
avakulenko@google.com02af6282014-06-04 18:53:25 +00003842 func = Match(r'^(.*\])\s*$', line_prefix)
erg@google.com2aa59982013-10-28 19:09:25 +00003843 if ((macro and
3844 macro.group(1) not in (
3845 'TEST', 'TEST_F', 'MATCHER', 'MATCHER_P', 'TYPED_TEST',
3846 'EXCLUSIVE_LOCKS_REQUIRED', 'SHARED_LOCKS_REQUIRED',
3847 'LOCKS_EXCLUDED', 'INTERFACE_DEF')) or
avakulenko@google.com02af6282014-06-04 18:53:25 +00003848 (func and not Search(r'\boperator\s*\[\s*\]', func.group(1))) or
avakulenko@google.com554223d2014-12-04 22:00:20 +00003849 Search(r'\b(?:struct|union)\s+alignas\s*$', line_prefix) or
Alex Vakulenko01e47232016-05-06 13:54:15 -07003850 Search(r'\bdecltype$', line_prefix) or
erg@google.com2aa59982013-10-28 19:09:25 +00003851 Search(r'\s+=\s*$', line_prefix)):
3852 match = None
avakulenko@google.com02af6282014-06-04 18:53:25 +00003853 if (match and
3854 opening_parenthesis[1] > 1 and
3855 Search(r'\]\s*$', clean_lines.elided[opening_parenthesis[1] - 1])):
3856 # Multi-line lambda-expression
3857 match = None
erg@google.com2aa59982013-10-28 19:09:25 +00003858
3859 else:
3860 # Try matching cases 2-3.
3861 match = Match(r'^(.*(?:else|\)\s*const)\s*)\{', line)
3862 if not match:
3863 # Try matching cases 4-6. These are always matched on separate lines.
3864 #
3865 # Note that we can't simply concatenate the previous line to the
3866 # current line and do a single match, otherwise we may output
3867 # duplicate warnings for the blank line case:
3868 # if (cond) {
3869 # // blank line
3870 # }
3871 prevline = GetPreviousNonBlankLine(clean_lines, linenum)[0]
3872 if prevline and Search(r'[;{}]\s*$', prevline):
3873 match = Match(r'^(\s*)\{', line)
3874
3875 # Check matching closing brace
3876 if match:
3877 (endline, endlinenum, endpos) = CloseExpression(
3878 clean_lines, linenum, len(match.group(1)))
3879 if endpos > -1 and Match(r'^\s*;', endline[endpos:]):
3880 # Current {} pair is eligible for semicolon check, and we have found
3881 # the redundant semicolon, output warning here.
3882 #
3883 # Note: because we are scanning forward for opening braces, and
3884 # outputting warnings for the matching closing brace, if there are
3885 # nested blocks with trailing semicolons, we will get the error
3886 # messages in reversed order.
3887 error(filename, endlinenum, 'readability/braces', 4,
3888 "You don't need a ; after a }")
erg@google.com4e00b9a2009-01-12 23:05:11 +00003889
3890
erg@google.comc6671232013-10-25 21:44:03 +00003891def CheckEmptyBlockBody(filename, clean_lines, linenum, error):
3892 """Look for empty loop/conditional body with only a single semicolon.
erg@google.comd350fe52013-01-14 17:51:48 +00003893
3894 Args:
3895 filename: The name of the current file.
3896 clean_lines: A CleansedLines instance containing the file.
3897 linenum: The number of the line to check.
3898 error: The function to call with any errors found.
3899 """
3900
3901 # Search for loop keywords at the beginning of the line. Because only
3902 # whitespaces are allowed before the keywords, this will also ignore most
3903 # do-while-loops, since those lines should start with closing brace.
erg@google.comc6671232013-10-25 21:44:03 +00003904 #
3905 # We also check "if" blocks here, since an empty conditional block
3906 # is likely an error.
erg@google.comd350fe52013-01-14 17:51:48 +00003907 line = clean_lines.elided[linenum]
erg@google.comc6671232013-10-25 21:44:03 +00003908 matched = Match(r'\s*(for|while|if)\s*\(', line)
3909 if matched:
Alex Vakulenko01e47232016-05-06 13:54:15 -07003910 # Find the end of the conditional expression.
erg@google.comd350fe52013-01-14 17:51:48 +00003911 (end_line, end_linenum, end_pos) = CloseExpression(
3912 clean_lines, linenum, line.find('('))
3913
3914 # Output warning if what follows the condition expression is a semicolon.
3915 # No warning for all other cases, including whitespace or newline, since we
3916 # have a separate check for semicolons preceded by whitespace.
3917 if end_pos >= 0 and Match(r';', end_line[end_pos:]):
erg@google.comc6671232013-10-25 21:44:03 +00003918 if matched.group(1) == 'if':
3919 error(filename, end_linenum, 'whitespace/empty_conditional_body', 5,
3920 'Empty conditional bodies should use {}')
3921 else:
3922 error(filename, end_linenum, 'whitespace/empty_loop_body', 5,
3923 'Empty loop bodies should use {} or continue')
erg@google.com4e00b9a2009-01-12 23:05:11 +00003924
Alex Vakulenko01e47232016-05-06 13:54:15 -07003925 # Check for if statements that have completely empty bodies (no comments)
3926 # and no else clauses.
3927 if end_pos >= 0 and matched.group(1) == 'if':
3928 # Find the position of the opening { for the if statement.
3929 # Return without logging an error if it has no brackets.
3930 opening_linenum = end_linenum
3931 opening_line_fragment = end_line[end_pos:]
3932 # Loop until EOF or find anything that's not whitespace or opening {.
3933 while not Search(r'^\s*\{', opening_line_fragment):
3934 if Search(r'^(?!\s*$)', opening_line_fragment):
3935 # Conditional has no brackets.
3936 return
3937 opening_linenum += 1
3938 if opening_linenum == len(clean_lines.elided):
3939 # Couldn't find conditional's opening { or any code before EOF.
3940 return
3941 opening_line_fragment = clean_lines.elided[opening_linenum]
3942 # Set opening_line (opening_line_fragment may not be entire opening line).
3943 opening_line = clean_lines.elided[opening_linenum]
3944
3945 # Find the position of the closing }.
3946 opening_pos = opening_line_fragment.find('{')
3947 if opening_linenum == end_linenum:
3948 # We need to make opening_pos relative to the start of the entire line.
3949 opening_pos += end_pos
3950 (closing_line, closing_linenum, closing_pos) = CloseExpression(
3951 clean_lines, opening_linenum, opening_pos)
3952 if closing_pos < 0:
3953 return
3954
3955 # Now construct the body of the conditional. This consists of the portion
3956 # of the opening line after the {, all lines until the closing line,
3957 # and the portion of the closing line before the }.
3958 if (clean_lines.raw_lines[opening_linenum] !=
3959 CleanseComments(clean_lines.raw_lines[opening_linenum])):
3960 # Opening line ends with a comment, so conditional isn't empty.
3961 return
3962 if closing_linenum > opening_linenum:
3963 # Opening line after the {. Ignore comments here since we checked above.
3964 body = list(opening_line[opening_pos+1:])
3965 # All lines until closing line, excluding closing line, with comments.
3966 body.extend(clean_lines.raw_lines[opening_linenum+1:closing_linenum])
3967 # Closing line before the }. Won't (and can't) have comments.
3968 body.append(clean_lines.elided[closing_linenum][:closing_pos-1])
3969 body = '\n'.join(body)
3970 else:
3971 # If statement has brackets and fits on a single line.
3972 body = opening_line[opening_pos+1:closing_pos-1]
3973
3974 # Check if the body is empty
3975 if not _EMPTY_CONDITIONAL_BODY_PATTERN.search(body):
3976 return
3977 # The body is empty. Now make sure there's not an else clause.
3978 current_linenum = closing_linenum
3979 current_line_fragment = closing_line[closing_pos:]
3980 # Loop until EOF or find anything that's not whitespace or else clause.
3981 while Search(r'^\s*$|^(?=\s*else)', current_line_fragment):
3982 if Search(r'^(?=\s*else)', current_line_fragment):
3983 # Found an else clause, so don't log an error.
3984 return
3985 current_linenum += 1
3986 if current_linenum == len(clean_lines.elided):
3987 break
3988 current_line_fragment = clean_lines.elided[current_linenum]
3989
3990 # The body is empty and there's no else clause until EOF or other code.
3991 error(filename, end_linenum, 'whitespace/empty_if_body', 4,
3992 ('If statement had no body and no else clause'))
3993
erg@google.com4e00b9a2009-01-12 23:05:11 +00003994
avakulenko@google.com02af6282014-06-04 18:53:25 +00003995def FindCheckMacro(line):
3996 """Find a replaceable CHECK-like macro.
3997
3998 Args:
3999 line: line to search on.
4000 Returns:
4001 (macro name, start position), or (None, -1) if no replaceable
4002 macro is found.
4003 """
4004 for macro in _CHECK_MACROS:
4005 i = line.find(macro)
4006 if i >= 0:
4007 # Find opening parenthesis. Do a regular expression match here
4008 # to make sure that we are matching the expected CHECK macro, as
4009 # opposed to some other macro that happens to contain the CHECK
4010 # substring.
4011 matched = Match(r'^(.*\b' + macro + r'\s*)\(', line)
4012 if not matched:
4013 continue
4014 return (macro, len(matched.group(1)))
4015 return (None, -1)
4016
4017
erg@google.com4e00b9a2009-01-12 23:05:11 +00004018def CheckCheck(filename, clean_lines, linenum, error):
4019 """Checks the use of CHECK and EXPECT macros.
4020
4021 Args:
4022 filename: The name of the current file.
4023 clean_lines: A CleansedLines instance containing the file.
4024 linenum: The number of the line to check.
4025 error: The function to call with any errors found.
4026 """
4027
4028 # Decide the set of replacement macros that should be suggested
erg@google.comc6671232013-10-25 21:44:03 +00004029 lines = clean_lines.elided
avakulenko@google.com02af6282014-06-04 18:53:25 +00004030 (check_macro, start_pos) = FindCheckMacro(lines[linenum])
4031 if not check_macro:
erg@google.com4e00b9a2009-01-12 23:05:11 +00004032 return
4033
erg@google.comc6671232013-10-25 21:44:03 +00004034 # Find end of the boolean expression by matching parentheses
4035 (last_line, end_line, end_pos) = CloseExpression(
4036 clean_lines, linenum, start_pos)
4037 if end_pos < 0:
4038 return
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00004039
4040 # If the check macro is followed by something other than a
4041 # semicolon, assume users will log their own custom error messages
4042 # and don't suggest any replacements.
4043 if not Match(r'\s*;', last_line[end_pos:]):
4044 return
4045
erg@google.comc6671232013-10-25 21:44:03 +00004046 if linenum == end_line:
4047 expression = lines[linenum][start_pos + 1:end_pos - 1]
4048 else:
4049 expression = lines[linenum][start_pos + 1:]
4050 for i in xrange(linenum + 1, end_line):
4051 expression += lines[i]
4052 expression += last_line[0:end_pos - 1]
erg@google.com4e00b9a2009-01-12 23:05:11 +00004053
erg@google.comc6671232013-10-25 21:44:03 +00004054 # Parse expression so that we can take parentheses into account.
4055 # This avoids false positives for inputs like "CHECK((a < 4) == b)",
4056 # which is not replaceable by CHECK_LE.
4057 lhs = ''
4058 rhs = ''
4059 operator = None
4060 while expression:
4061 matched = Match(r'^\s*(<<|<<=|>>|>>=|->\*|->|&&|\|\||'
4062 r'==|!=|>=|>|<=|<|\()(.*)$', expression)
4063 if matched:
4064 token = matched.group(1)
4065 if token == '(':
4066 # Parenthesized operand
4067 expression = matched.group(2)
avakulenko@google.com02af6282014-06-04 18:53:25 +00004068 (end, _) = FindEndOfExpressionInLine(expression, 0, ['('])
erg@google.comc6671232013-10-25 21:44:03 +00004069 if end < 0:
4070 return # Unmatched parenthesis
4071 lhs += '(' + expression[0:end]
4072 expression = expression[end:]
4073 elif token in ('&&', '||'):
4074 # Logical and/or operators. This means the expression
4075 # contains more than one term, for example:
4076 # CHECK(42 < a && a < b);
4077 #
4078 # These are not replaceable with CHECK_LE, so bail out early.
4079 return
4080 elif token in ('<<', '<<=', '>>', '>>=', '->*', '->'):
4081 # Non-relational operator
4082 lhs += token
4083 expression = matched.group(2)
4084 else:
4085 # Relational operator
4086 operator = token
4087 rhs = matched.group(2)
4088 break
4089 else:
4090 # Unparenthesized operand. Instead of appending to lhs one character
4091 # at a time, we do another regular expression match to consume several
4092 # characters at once if possible. Trivial benchmark shows that this
4093 # is more efficient when the operands are longer than a single
4094 # character, which is generally the case.
4095 matched = Match(r'^([^-=!<>()&|]+)(.*)$', expression)
4096 if not matched:
4097 matched = Match(r'^(\s*\S)(.*)$', expression)
4098 if not matched:
4099 break
4100 lhs += matched.group(1)
4101 expression = matched.group(2)
4102
4103 # Only apply checks if we got all parts of the boolean expression
4104 if not (lhs and operator and rhs):
4105 return
4106
4107 # Check that rhs do not contain logical operators. We already know
4108 # that lhs is fine since the loop above parses out && and ||.
4109 if rhs.find('&&') > -1 or rhs.find('||') > -1:
4110 return
4111
4112 # At least one of the operands must be a constant literal. This is
4113 # to avoid suggesting replacements for unprintable things like
4114 # CHECK(variable != iterator)
4115 #
4116 # The following pattern matches decimal, hex integers, strings, and
4117 # characters (in that order).
4118 lhs = lhs.strip()
4119 rhs = rhs.strip()
4120 match_constant = r'^([-+]?(\d+|0[xX][0-9a-fA-F]+)[lLuU]{0,3}|".*"|\'.*\')$'
4121 if Match(match_constant, lhs) or Match(match_constant, rhs):
4122 # Note: since we know both lhs and rhs, we can provide a more
4123 # descriptive error message like:
4124 # Consider using CHECK_EQ(x, 42) instead of CHECK(x == 42)
4125 # Instead of:
4126 # Consider using CHECK_EQ instead of CHECK(a == b)
4127 #
4128 # We are still keeping the less descriptive message because if lhs
4129 # or rhs gets long, the error message might become unreadable.
4130 error(filename, linenum, 'readability/check', 2,
4131 'Consider using %s instead of %s(a %s b)' % (
4132 _CHECK_REPLACEMENT[check_macro][operator],
4133 check_macro, operator))
erg@google.com4e00b9a2009-01-12 23:05:11 +00004134
4135
erg@google.comd350fe52013-01-14 17:51:48 +00004136def CheckAltTokens(filename, clean_lines, linenum, error):
4137 """Check alternative keywords being used in boolean expressions.
4138
4139 Args:
4140 filename: The name of the current file.
4141 clean_lines: A CleansedLines instance containing the file.
4142 linenum: The number of the line to check.
4143 error: The function to call with any errors found.
4144 """
4145 line = clean_lines.elided[linenum]
4146
4147 # Avoid preprocessor lines
4148 if Match(r'^\s*#', line):
4149 return
4150
4151 # Last ditch effort to avoid multi-line comments. This will not help
4152 # if the comment started before the current line or ended after the
4153 # current line, but it catches most of the false positives. At least,
4154 # it provides a way to workaround this warning for people who use
4155 # multi-line comments in preprocessor macros.
4156 #
4157 # TODO(unknown): remove this once cpplint has better support for
4158 # multi-line comments.
4159 if line.find('/*') >= 0 or line.find('*/') >= 0:
4160 return
4161
4162 for match in _ALT_TOKEN_REPLACEMENT_PATTERN.finditer(line):
4163 error(filename, linenum, 'readability/alt_tokens', 2,
4164 'Use operator %s instead of %s' % (
4165 _ALT_TOKEN_REPLACEMENT[match.group(1)], match.group(1)))
4166
4167
erg@google.com4e00b9a2009-01-12 23:05:11 +00004168def GetLineWidth(line):
4169 """Determines the width of the line in column positions.
4170
4171 Args:
4172 line: A string, which may be a Unicode string.
4173
4174 Returns:
4175 The width of the line in column positions, accounting for Unicode
4176 combining characters and wide characters.
4177 """
4178 if isinstance(line, unicode):
4179 width = 0
erg@google.com8a95ecc2011-09-08 00:45:54 +00004180 for uc in unicodedata.normalize('NFC', line):
4181 if unicodedata.east_asian_width(uc) in ('W', 'F'):
erg@google.com4e00b9a2009-01-12 23:05:11 +00004182 width += 2
erg@google.com8a95ecc2011-09-08 00:45:54 +00004183 elif not unicodedata.combining(uc):
erg@google.com4e00b9a2009-01-12 23:05:11 +00004184 width += 1
4185 return width
4186 else:
4187 return len(line)
4188
4189
erg@google.comd350fe52013-01-14 17:51:48 +00004190def CheckStyle(filename, clean_lines, linenum, file_extension, nesting_state,
erg@google.com8a95ecc2011-09-08 00:45:54 +00004191 error):
erg@google.com4e00b9a2009-01-12 23:05:11 +00004192 """Checks rules from the 'C++ style rules' section of cppguide.html.
4193
4194 Most of these rules are hard to test (naming, comment style), but we
4195 do what we can. In particular we check for 2-space indents, line lengths,
4196 tab usage, spaces inside code, etc.
4197
4198 Args:
4199 filename: The name of the current file.
4200 clean_lines: A CleansedLines instance containing the file.
4201 linenum: The number of the line to check.
4202 file_extension: The extension (without the dot) of the filename.
avakulenko@google.com02af6282014-06-04 18:53:25 +00004203 nesting_state: A NestingState instance which maintains information about
erg@google.comd350fe52013-01-14 17:51:48 +00004204 the current stack of nested blocks being parsed.
erg@google.com4e00b9a2009-01-12 23:05:11 +00004205 error: The function to call with any errors found.
4206 """
4207
erg@google.com2aa59982013-10-28 19:09:25 +00004208 # Don't use "elided" lines here, otherwise we can't check commented lines.
4209 # Don't want to use "raw" either, because we don't want to check inside C++11
4210 # raw strings,
4211 raw_lines = clean_lines.lines_without_raw_strings
erg@google.com4e00b9a2009-01-12 23:05:11 +00004212 line = raw_lines[linenum]
Alex Vakulenko01e47232016-05-06 13:54:15 -07004213 prev = raw_lines[linenum - 1] if linenum > 0 else ''
erg@google.com4e00b9a2009-01-12 23:05:11 +00004214
4215 if line.find('\t') != -1:
4216 error(filename, linenum, 'whitespace/tab', 1,
4217 'Tab found; better to use spaces')
4218
4219 # One or three blank spaces at the beginning of the line is weird; it's
4220 # hard to reconcile that with 2-space indents.
4221 # NOTE: here are the conditions rob pike used for his tests. Mine aren't
4222 # as sophisticated, but it may be worth becoming so: RLENGTH==initial_spaces
4223 # if(RLENGTH > 20) complain = 0;
4224 # if(match($0, " +(error|private|public|protected):")) complain = 0;
4225 # if(match(prev, "&& *$")) complain = 0;
4226 # if(match(prev, "\\|\\| *$")) complain = 0;
4227 # if(match(prev, "[\",=><] *$")) complain = 0;
4228 # if(match($0, " <<")) complain = 0;
4229 # if(match(prev, " +for \\(")) complain = 0;
4230 # if(prevodd && match(prevprev, " +for \\(")) complain = 0;
avakulenko@google.com02af6282014-06-04 18:53:25 +00004231 scope_or_label_pattern = r'\s*\w+\s*:\s*\\?$'
4232 classinfo = nesting_state.InnermostClass()
erg@google.com4e00b9a2009-01-12 23:05:11 +00004233 initial_spaces = 0
4234 cleansed_line = clean_lines.elided[linenum]
4235 while initial_spaces < len(line) and line[initial_spaces] == ' ':
4236 initial_spaces += 1
avakulenko@google.com02af6282014-06-04 18:53:25 +00004237 # There are certain situations we allow one space, notably for
4238 # section labels, and also lines containing multi-line raw strings.
Alex Vakulenko01e47232016-05-06 13:54:15 -07004239 # We also don't check for lines that look like continuation lines
4240 # (of lines ending in double quotes, commas, equals, or angle brackets)
4241 # because the rules for how to indent those are non-trivial.
4242 if (not Search(r'[",=><] *$', prev) and
4243 (initial_spaces == 1 or initial_spaces == 3) and
4244 not Match(scope_or_label_pattern, cleansed_line) and
4245 not (clean_lines.raw_lines[linenum] != line and
4246 Match(r'^\s*""', line))):
erg@google.com4e00b9a2009-01-12 23:05:11 +00004247 error(filename, linenum, 'whitespace/indent', 3,
4248 'Weird number of spaces at line-start. '
4249 'Are you using a 2-space indent?')
erg@google.com4e00b9a2009-01-12 23:05:11 +00004250
Alex Vakulenko01e47232016-05-06 13:54:15 -07004251 if line and line[-1].isspace():
4252 error(filename, linenum, 'whitespace/end_of_line', 4,
4253 'Line ends in whitespace. Consider deleting these extra spaces.')
4254
erg@google.com4e00b9a2009-01-12 23:05:11 +00004255 # Check if the line is a header guard.
4256 is_header_guard = False
4257 if file_extension == 'h':
4258 cppvar = GetHeaderGuardCPPVariable(filename)
4259 if (line.startswith('#ifndef %s' % cppvar) or
4260 line.startswith('#define %s' % cppvar) or
4261 line.startswith('#endif // %s' % cppvar)):
4262 is_header_guard = True
4263 # #include lines and header guards can be long, since there's no clean way to
4264 # split them.
erg@google.coma87abb82009-02-24 01:41:01 +00004265 #
4266 # URLs can be long too. It's possible to split these, but it makes them
4267 # harder to cut&paste.
erg@google.comd7d27472011-09-07 17:36:35 +00004268 #
4269 # The "$Id:...$" comment may also get very long without it being the
4270 # developers fault.
erg@google.coma87abb82009-02-24 01:41:01 +00004271 if (not line.startswith('#include') and not is_header_guard and
erg@google.comd7d27472011-09-07 17:36:35 +00004272 not Match(r'^\s*//.*http(s?)://\S*$', line) and
Alex Vakulenko01e47232016-05-06 13:54:15 -07004273 not Match(r'^\s*//\s*[^\s]*$', line) and
erg@google.comd7d27472011-09-07 17:36:35 +00004274 not Match(r'^// \$Id:.*#[0-9]+ \$$', line)):
erg@google.com4e00b9a2009-01-12 23:05:11 +00004275 line_width = GetLineWidth(line)
Alex Vakulenko01e47232016-05-06 13:54:15 -07004276 if line_width > _line_length:
erg@google.com4e00b9a2009-01-12 23:05:11 +00004277 error(filename, linenum, 'whitespace/line_length', 2,
erg@google.comab53edf2013-11-05 22:23:37 +00004278 'Lines should be <= %i characters long' % _line_length)
erg@google.com4e00b9a2009-01-12 23:05:11 +00004279
4280 if (cleansed_line.count(';') > 1 and
4281 # for loops are allowed two ;'s (and may run over two lines).
4282 cleansed_line.find('for') == -1 and
4283 (GetPreviousNonBlankLine(clean_lines, linenum)[0].find('for') == -1 or
4284 GetPreviousNonBlankLine(clean_lines, linenum)[0].find(';') != -1) and
4285 # It's ok to have many commands in a switch case that fits in 1 line
4286 not ((cleansed_line.find('case ') != -1 or
4287 cleansed_line.find('default:') != -1) and
4288 cleansed_line.find('break;') != -1)):
erg@google.comd350fe52013-01-14 17:51:48 +00004289 error(filename, linenum, 'whitespace/newline', 0,
erg@google.com4e00b9a2009-01-12 23:05:11 +00004290 'More than one command on the same line')
4291
4292 # Some more style checks
4293 CheckBraces(filename, clean_lines, linenum, error)
avakulenko@google.com02af6282014-06-04 18:53:25 +00004294 CheckTrailingSemicolon(filename, clean_lines, linenum, error)
erg@google.comc6671232013-10-25 21:44:03 +00004295 CheckEmptyBlockBody(filename, clean_lines, linenum, error)
erg@google.comd350fe52013-01-14 17:51:48 +00004296 CheckAccess(filename, clean_lines, linenum, nesting_state, error)
4297 CheckSpacing(filename, clean_lines, linenum, nesting_state, error)
avakulenko@google.com02af6282014-06-04 18:53:25 +00004298 CheckOperatorSpacing(filename, clean_lines, linenum, error)
4299 CheckParenthesisSpacing(filename, clean_lines, linenum, error)
4300 CheckCommaSpacing(filename, clean_lines, linenum, error)
Alex Vakulenko01e47232016-05-06 13:54:15 -07004301 CheckBracesSpacing(filename, clean_lines, linenum, nesting_state, error)
avakulenko@google.com02af6282014-06-04 18:53:25 +00004302 CheckSpacingForFunctionCall(filename, clean_lines, linenum, error)
erg@google.com4e00b9a2009-01-12 23:05:11 +00004303 CheckCheck(filename, clean_lines, linenum, error)
erg@google.comd350fe52013-01-14 17:51:48 +00004304 CheckAltTokens(filename, clean_lines, linenum, error)
4305 classinfo = nesting_state.InnermostClass()
4306 if classinfo:
4307 CheckSectionSpacing(filename, clean_lines, classinfo, linenum, error)
erg@google.com4e00b9a2009-01-12 23:05:11 +00004308
4309
erg@google.com4e00b9a2009-01-12 23:05:11 +00004310_RE_PATTERN_INCLUDE = re.compile(r'^\s*#\s*include\s*([<"])([^>"]*)[>"].*$')
4311# Matches the first component of a filename delimited by -s and _s. That is:
4312# _RE_FIRST_COMPONENT.match('foo').group(0) == 'foo'
4313# _RE_FIRST_COMPONENT.match('foo.cc').group(0) == 'foo'
4314# _RE_FIRST_COMPONENT.match('foo-bar_baz.cc').group(0) == 'foo'
4315# _RE_FIRST_COMPONENT.match('foo_bar-baz.cc').group(0) == 'foo'
4316_RE_FIRST_COMPONENT = re.compile(r'^[^-_.]+')
4317
4318
4319def _DropCommonSuffixes(filename):
4320 """Drops common suffixes like _test.cc or -inl.h from filename.
4321
4322 For example:
4323 >>> _DropCommonSuffixes('foo/foo-inl.h')
4324 'foo/foo'
4325 >>> _DropCommonSuffixes('foo/bar/foo.cc')
4326 'foo/bar/foo'
4327 >>> _DropCommonSuffixes('foo/foo_internal.h')
4328 'foo/foo'
4329 >>> _DropCommonSuffixes('foo/foo_unusualinternal.h')
4330 'foo/foo_unusualinternal'
4331
4332 Args:
4333 filename: The input filename.
4334
4335 Returns:
4336 The filename with the common suffix removed.
4337 """
4338 for suffix in ('test.cc', 'regtest.cc', 'unittest.cc',
4339 'inl.h', 'impl.h', 'internal.h'):
4340 if (filename.endswith(suffix) and len(filename) > len(suffix) and
4341 filename[-len(suffix) - 1] in ('-', '_')):
4342 return filename[:-len(suffix) - 1]
4343 return os.path.splitext(filename)[0]
4344
4345
erg@google.com4e00b9a2009-01-12 23:05:11 +00004346def _ClassifyInclude(fileinfo, include, is_system):
4347 """Figures out what kind of header 'include' is.
4348
4349 Args:
4350 fileinfo: The current file cpplint is running over. A FileInfo instance.
4351 include: The path to a #included file.
4352 is_system: True if the #include used <> rather than "".
4353
4354 Returns:
4355 One of the _XXX_HEADER constants.
4356
4357 For example:
4358 >>> _ClassifyInclude(FileInfo('foo/foo.cc'), 'stdio.h', True)
4359 _C_SYS_HEADER
4360 >>> _ClassifyInclude(FileInfo('foo/foo.cc'), 'string', True)
4361 _CPP_SYS_HEADER
4362 >>> _ClassifyInclude(FileInfo('foo/foo.cc'), 'foo/foo.h', False)
4363 _LIKELY_MY_HEADER
4364 >>> _ClassifyInclude(FileInfo('foo/foo_unknown_extension.cc'),
4365 ... 'bar/foo_other_ext.h', False)
4366 _POSSIBLE_MY_HEADER
4367 >>> _ClassifyInclude(FileInfo('foo/foo.cc'), 'foo/bar.h', False)
4368 _OTHER_HEADER
4369 """
4370 # This is a list of all standard c++ header files, except
4371 # those already checked for above.
erg@google.comfd5da632013-10-25 17:39:45 +00004372 is_cpp_h = include in _CPP_HEADERS
erg@google.com4e00b9a2009-01-12 23:05:11 +00004373
4374 if is_system:
4375 if is_cpp_h:
4376 return _CPP_SYS_HEADER
4377 else:
4378 return _C_SYS_HEADER
4379
4380 # If the target file and the include we're checking share a
4381 # basename when we drop common extensions, and the include
4382 # lives in . , then it's likely to be owned by the target file.
4383 target_dir, target_base = (
4384 os.path.split(_DropCommonSuffixes(fileinfo.RepositoryName())))
4385 include_dir, include_base = os.path.split(_DropCommonSuffixes(include))
4386 if target_base == include_base and (
4387 include_dir == target_dir or
4388 include_dir == os.path.normpath(target_dir + '/../public')):
4389 return _LIKELY_MY_HEADER
4390
4391 # If the target and include share some initial basename
4392 # component, it's possible the target is implementing the
4393 # include, so it's allowed to be first, but we'll never
4394 # complain if it's not there.
4395 target_first_component = _RE_FIRST_COMPONENT.match(target_base)
4396 include_first_component = _RE_FIRST_COMPONENT.match(include_base)
4397 if (target_first_component and include_first_component and
4398 target_first_component.group(0) ==
4399 include_first_component.group(0)):
4400 return _POSSIBLE_MY_HEADER
4401
4402 return _OTHER_HEADER
4403
4404
erg@google.coma87abb82009-02-24 01:41:01 +00004405
erg@google.come35f7652009-06-19 20:52:09 +00004406def CheckIncludeLine(filename, clean_lines, linenum, include_state, error):
4407 """Check rules that are applicable to #include lines.
erg@google.com4e00b9a2009-01-12 23:05:11 +00004408
erg@google.come35f7652009-06-19 20:52:09 +00004409 Strings on #include lines are NOT removed from elided line, to make
4410 certain tasks easier. However, to prevent false positives, checks
4411 applicable to #include lines in CheckLanguage must be put here.
erg@google.com4e00b9a2009-01-12 23:05:11 +00004412
4413 Args:
4414 filename: The name of the current file.
4415 clean_lines: A CleansedLines instance containing the file.
4416 linenum: The number of the line to check.
erg@google.com4e00b9a2009-01-12 23:05:11 +00004417 include_state: An _IncludeState instance in which the headers are inserted.
4418 error: The function to call with any errors found.
4419 """
4420 fileinfo = FileInfo(filename)
erg@google.come35f7652009-06-19 20:52:09 +00004421 line = clean_lines.lines[linenum]
erg@google.com4e00b9a2009-01-12 23:05:11 +00004422
4423 # "include" should use the new style "foo/bar.h" instead of just "bar.h"
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00004424 # Only do this check if the included header follows google naming
4425 # conventions. If not, assume that it's a 3rd party API that
4426 # requires special include conventions.
4427 #
4428 # We also make an exception for Lua headers, which follow google
4429 # naming convention but not the include convention.
4430 match = Match(r'#include\s*"([^/]+\.h)"', line)
4431 if match and not _THIRD_PARTY_HEADERS_PATTERN.match(match.group(1)):
erg@google.com4e00b9a2009-01-12 23:05:11 +00004432 error(filename, linenum, 'build/include', 4,
4433 'Include the directory when naming .h files')
4434
4435 # we shouldn't include a file more than once. actually, there are a
4436 # handful of instances where doing so is okay, but in general it's
4437 # not.
erg@google.come35f7652009-06-19 20:52:09 +00004438 match = _RE_PATTERN_INCLUDE.search(line)
erg@google.com4e00b9a2009-01-12 23:05:11 +00004439 if match:
4440 include = match.group(2)
4441 is_system = (match.group(1) == '<')
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00004442 duplicate_line = include_state.FindHeader(include)
4443 if duplicate_line >= 0:
erg@google.com4e00b9a2009-01-12 23:05:11 +00004444 error(filename, linenum, 'build/include', 4,
4445 '"%s" already included at %s:%s' %
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00004446 (include, filename, duplicate_line))
avakulenko@google.com554223d2014-12-04 22:00:20 +00004447 elif (include.endswith('.cc') and
4448 os.path.dirname(fileinfo.RepositoryName()) != os.path.dirname(include)):
4449 error(filename, linenum, 'build/include', 4,
4450 'Do not include .cc files from other packages')
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00004451 elif not _THIRD_PARTY_HEADERS_PATTERN.match(include):
4452 include_state.include_list[-1].append((include, linenum))
erg@google.com4e00b9a2009-01-12 23:05:11 +00004453
4454 # We want to ensure that headers appear in the right order:
4455 # 1) for foo.cc, foo.h (preferred location)
4456 # 2) c system files
4457 # 3) cpp system files
4458 # 4) for foo.cc, foo.h (deprecated location)
4459 # 5) other google headers
4460 #
4461 # We classify each include statement as one of those 5 types
4462 # using a number of techniques. The include_state object keeps
4463 # track of the highest type seen, and complains if we see a
4464 # lower type after that.
4465 error_message = include_state.CheckNextIncludeOrder(
4466 _ClassifyInclude(fileinfo, include, is_system))
4467 if error_message:
4468 error(filename, linenum, 'build/include_order', 4,
4469 '%s. Should be: %s.h, c system, c++ system, other.' %
4470 (error_message, fileinfo.BaseName()))
erg@google.comfd5da632013-10-25 17:39:45 +00004471 canonical_include = include_state.CanonicalizeAlphabeticalOrder(include)
4472 if not include_state.IsInAlphabeticalOrder(
4473 clean_lines, linenum, canonical_include):
erg@google.coma868d2d2009-10-09 21:18:45 +00004474 error(filename, linenum, 'build/include_alpha', 4,
4475 'Include "%s" not in alphabetical order' % include)
erg@google.comfd5da632013-10-25 17:39:45 +00004476 include_state.SetLastHeader(canonical_include)
erg@google.com4e00b9a2009-01-12 23:05:11 +00004477
erg@google.come35f7652009-06-19 20:52:09 +00004478
erg@google.com8a95ecc2011-09-08 00:45:54 +00004479
4480def _GetTextInside(text, start_pattern):
erg@google.com2aa59982013-10-28 19:09:25 +00004481 r"""Retrieves all the text between matching open and close parentheses.
erg@google.com8a95ecc2011-09-08 00:45:54 +00004482
4483 Given a string of lines and a regular expression string, retrieve all the text
4484 following the expression and between opening punctuation symbols like
4485 (, [, or {, and the matching close-punctuation symbol. This properly nested
4486 occurrences of the punctuations, so for the text like
4487 printf(a(), b(c()));
4488 a call to _GetTextInside(text, r'printf\(') will return 'a(), b(c())'.
4489 start_pattern must match string having an open punctuation symbol at the end.
4490
4491 Args:
4492 text: The lines to extract text. Its comments and strings must be elided.
4493 It can be single line and can span multiple lines.
4494 start_pattern: The regexp string indicating where to start extracting
4495 the text.
4496 Returns:
4497 The extracted text.
4498 None if either the opening string or ending punctuation could not be found.
4499 """
avakulenko@google.com02af6282014-06-04 18:53:25 +00004500 # TODO(unknown): Audit cpplint.py to see what places could be profitably
erg@google.com8a95ecc2011-09-08 00:45:54 +00004501 # rewritten to use _GetTextInside (and use inferior regexp matching today).
4502
4503 # Give opening punctuations to get the matching close-punctuations.
4504 matching_punctuation = {'(': ')', '{': '}', '[': ']'}
4505 closing_punctuation = set(matching_punctuation.itervalues())
4506
4507 # Find the position to start extracting text.
4508 match = re.search(start_pattern, text, re.M)
4509 if not match: # start_pattern not found in text.
4510 return None
4511 start_position = match.end(0)
4512
4513 assert start_position > 0, (
4514 'start_pattern must ends with an opening punctuation.')
4515 assert text[start_position - 1] in matching_punctuation, (
4516 'start_pattern must ends with an opening punctuation.')
4517 # Stack of closing punctuations we expect to have in text after position.
4518 punctuation_stack = [matching_punctuation[text[start_position - 1]]]
4519 position = start_position
4520 while punctuation_stack and position < len(text):
4521 if text[position] == punctuation_stack[-1]:
4522 punctuation_stack.pop()
4523 elif text[position] in closing_punctuation:
4524 # A closing punctuation without matching opening punctuations.
4525 return None
4526 elif text[position] in matching_punctuation:
4527 punctuation_stack.append(matching_punctuation[text[position]])
4528 position += 1
4529 if punctuation_stack:
4530 # Opening punctuations left without matching close-punctuations.
4531 return None
4532 # punctuations match.
4533 return text[start_position:position - 1]
4534
4535
erg@google.comfd5da632013-10-25 17:39:45 +00004536# Patterns for matching call-by-reference parameters.
erg@google.com2aa59982013-10-28 19:09:25 +00004537#
4538# Supports nested templates up to 2 levels deep using this messy pattern:
4539# < (?: < (?: < [^<>]*
4540# >
4541# | [^<>] )*
4542# >
4543# | [^<>] )*
4544# >
erg@google.comfd5da632013-10-25 17:39:45 +00004545_RE_PATTERN_IDENT = r'[_a-zA-Z]\w*' # =~ [[:alpha:]][[:alnum:]]*
4546_RE_PATTERN_TYPE = (
4547 r'(?:const\s+)?(?:typename\s+|class\s+|struct\s+|union\s+|enum\s+)?'
erg@google.com2aa59982013-10-28 19:09:25 +00004548 r'(?:\w|'
4549 r'\s*<(?:<(?:<[^<>]*>|[^<>])*>|[^<>])*>|'
4550 r'::)+')
erg@google.comfd5da632013-10-25 17:39:45 +00004551# A call-by-reference parameter ends with '& identifier'.
4552_RE_PATTERN_REF_PARAM = re.compile(
4553 r'(' + _RE_PATTERN_TYPE + r'(?:\s*(?:\bconst\b|[*]))*\s*'
4554 r'&\s*' + _RE_PATTERN_IDENT + r')\s*(?:=[^,()]+)?[,)]')
4555# A call-by-const-reference parameter either ends with 'const& identifier'
4556# or looks like 'const type& identifier' when 'type' is atomic.
4557_RE_PATTERN_CONST_REF_PARAM = (
4558 r'(?:.*\s*\bconst\s*&\s*' + _RE_PATTERN_IDENT +
4559 r'|const\s+' + _RE_PATTERN_TYPE + r'\s*&\s*' + _RE_PATTERN_IDENT + r')')
Alex Vakulenko01e47232016-05-06 13:54:15 -07004560# Stream types.
4561_RE_PATTERN_REF_STREAM_PARAM = (
4562 r'(?:.*stream\s*&\s*' + _RE_PATTERN_IDENT + r')')
erg@google.comfd5da632013-10-25 17:39:45 +00004563
4564
4565def CheckLanguage(filename, clean_lines, linenum, file_extension,
4566 include_state, nesting_state, error):
erg@google.come35f7652009-06-19 20:52:09 +00004567 """Checks rules from the 'C++ language rules' section of cppguide.html.
4568
4569 Some of these rules are hard to test (function overloading, using
4570 uint32 inappropriately), but we do the best we can.
4571
4572 Args:
4573 filename: The name of the current file.
4574 clean_lines: A CleansedLines instance containing the file.
4575 linenum: The number of the line to check.
4576 file_extension: The extension (without the dot) of the filename.
4577 include_state: An _IncludeState instance in which the headers are inserted.
avakulenko@google.com02af6282014-06-04 18:53:25 +00004578 nesting_state: A NestingState instance which maintains information about
erg@google.comfd5da632013-10-25 17:39:45 +00004579 the current stack of nested blocks being parsed.
erg@google.come35f7652009-06-19 20:52:09 +00004580 error: The function to call with any errors found.
4581 """
erg@google.com4e00b9a2009-01-12 23:05:11 +00004582 # If the line is empty or consists of entirely a comment, no need to
4583 # check it.
4584 line = clean_lines.elided[linenum]
4585 if not line:
4586 return
4587
erg@google.come35f7652009-06-19 20:52:09 +00004588 match = _RE_PATTERN_INCLUDE.search(line)
4589 if match:
4590 CheckIncludeLine(filename, clean_lines, linenum, include_state, error)
4591 return
4592
erg@google.com2aa59982013-10-28 19:09:25 +00004593 # Reset include state across preprocessor directives. This is meant
4594 # to silence warnings for conditional includes.
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00004595 match = Match(r'^\s*#\s*(if|ifdef|ifndef|elif|else|endif)\b', line)
4596 if match:
4597 include_state.ResetSection(match.group(1))
erg@google.com2aa59982013-10-28 19:09:25 +00004598
erg@google.com4e00b9a2009-01-12 23:05:11 +00004599 # Make Windows paths like Unix.
4600 fullname = os.path.abspath(filename).replace('\\', '/')
Alex Vakulenko01e47232016-05-06 13:54:15 -07004601
avakulenko@google.com02af6282014-06-04 18:53:25 +00004602 # Perform other checks now that we are sure that this is not an include line
4603 CheckCasts(filename, clean_lines, linenum, error)
4604 CheckGlobalStatic(filename, clean_lines, linenum, error)
4605 CheckPrintf(filename, clean_lines, linenum, error)
erg@google.com4e00b9a2009-01-12 23:05:11 +00004606
4607 if file_extension == 'h':
4608 # TODO(unknown): check that 1-arg constructors are explicit.
4609 # How to tell it's a constructor?
4610 # (handled in CheckForNonStandardConstructs for now)
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00004611 # TODO(unknown): check that classes declare or disable copy/assign
erg@google.com4e00b9a2009-01-12 23:05:11 +00004612 # (level 1 error)
4613 pass
4614
4615 # Check if people are using the verboten C basic types. The only exception
4616 # we regularly allow is "unsigned short port" for port.
4617 if Search(r'\bshort port\b', line):
4618 if not Search(r'\bunsigned short port\b', line):
4619 error(filename, linenum, 'runtime/int', 4,
4620 'Use "unsigned short" for ports, not "short"')
4621 else:
4622 match = Search(r'\b(short|long(?! +double)|long long)\b', line)
4623 if match:
4624 error(filename, linenum, 'runtime/int', 4,
4625 'Use int16/int64/etc, rather than the C type %s' % match.group(1))
4626
erg@google.coma868d2d2009-10-09 21:18:45 +00004627 # Check if some verboten operator overloading is going on
4628 # TODO(unknown): catch out-of-line unary operator&:
4629 # class X {};
4630 # int operator&(const X& x) { return 42; } // unary operator&
4631 # The trick is it's hard to tell apart from binary operator&:
4632 # class Y { int operator&(const Y& x) { return 23; } }; // binary operator&
4633 if Search(r'\boperator\s*&\s*\(\s*\)', line):
4634 error(filename, linenum, 'runtime/operator', 4,
4635 'Unary operator& is dangerous. Do not use it.')
4636
erg@google.com4e00b9a2009-01-12 23:05:11 +00004637 # Check for suspicious usage of "if" like
4638 # } if (a == b) {
4639 if Search(r'\}\s*if\s*\(', line):
4640 error(filename, linenum, 'readability/braces', 4,
4641 'Did you mean "else if"? If not, start a new line for "if".')
4642
4643 # Check for potential format string bugs like printf(foo).
4644 # We constrain the pattern not to pick things like DocidForPrintf(foo).
4645 # Not perfect but it can catch printf(foo.c_str()) and printf(foo->c_str())
avakulenko@google.com02af6282014-06-04 18:53:25 +00004646 # TODO(unknown): Catch the following case. Need to change the calling
erg@google.com8a95ecc2011-09-08 00:45:54 +00004647 # convention of the whole function to process multiple line to handle it.
4648 # printf(
4649 # boy_this_is_a_really_long_variable_that_cannot_fit_on_the_prev_line);
4650 printf_args = _GetTextInside(line, r'(?i)\b(string)?printf\s*\(')
4651 if printf_args:
4652 match = Match(r'([\w.\->()]+)$', printf_args)
erg@google.comd350fe52013-01-14 17:51:48 +00004653 if match and match.group(1) != '__VA_ARGS__':
erg@google.com8a95ecc2011-09-08 00:45:54 +00004654 function_name = re.search(r'\b((?:string)?printf)\s*\(',
4655 line, re.I).group(1)
4656 error(filename, linenum, 'runtime/printf', 4,
4657 'Potential format string bug. Do %s("%%s", %s) instead.'
4658 % (function_name, match.group(1)))
erg@google.com4e00b9a2009-01-12 23:05:11 +00004659
4660 # Check for potential memset bugs like memset(buf, sizeof(buf), 0).
4661 match = Search(r'memset\s*\(([^,]*),\s*([^,]*),\s*0\s*\)', line)
4662 if match and not Match(r"^''|-?[0-9]+|0x[0-9A-Fa-f]$", match.group(2)):
4663 error(filename, linenum, 'runtime/memset', 4,
4664 'Did you mean "memset(%s, 0, %s)"?'
4665 % (match.group(1), match.group(2)))
4666
4667 if Search(r'\busing namespace\b', line):
4668 error(filename, linenum, 'build/namespaces', 5,
4669 'Do not use namespace using-directives. '
4670 'Use using-declarations instead.')
4671
4672 # Detect variable-length arrays.
4673 match = Match(r'\s*(.+::)?(\w+) [a-z]\w*\[(.+)];', line)
4674 if (match and match.group(2) != 'return' and match.group(2) != 'delete' and
4675 match.group(3).find(']') == -1):
4676 # Split the size using space and arithmetic operators as delimiters.
4677 # If any of the resulting tokens are not compile time constants then
4678 # report the error.
4679 tokens = re.split(r'\s|\+|\-|\*|\/|<<|>>]', match.group(3))
4680 is_const = True
4681 skip_next = False
4682 for tok in tokens:
4683 if skip_next:
4684 skip_next = False
4685 continue
4686
4687 if Search(r'sizeof\(.+\)', tok): continue
4688 if Search(r'arraysize\(\w+\)', tok): continue
4689
4690 tok = tok.lstrip('(')
4691 tok = tok.rstrip(')')
4692 if not tok: continue
4693 if Match(r'\d+', tok): continue
4694 if Match(r'0[xX][0-9a-fA-F]+', tok): continue
4695 if Match(r'k[A-Z0-9]\w*', tok): continue
4696 if Match(r'(.+::)?k[A-Z0-9]\w*', tok): continue
4697 if Match(r'(.+::)?[A-Z][A-Z0-9_]*', tok): continue
4698 # A catch all for tricky sizeof cases, including 'sizeof expression',
4699 # 'sizeof(*type)', 'sizeof(const type)', 'sizeof(struct StructName)'
erg@google.com8a95ecc2011-09-08 00:45:54 +00004700 # requires skipping the next token because we split on ' ' and '*'.
erg@google.com4e00b9a2009-01-12 23:05:11 +00004701 if tok.startswith('sizeof'):
4702 skip_next = True
4703 continue
4704 is_const = False
4705 break
4706 if not is_const:
4707 error(filename, linenum, 'runtime/arrays', 1,
4708 'Do not use variable-length arrays. Use an appropriately named '
4709 "('k' followed by CamelCase) compile-time constant for the size.")
4710
erg@google.com4e00b9a2009-01-12 23:05:11 +00004711 # Check for use of unnamed namespaces in header files. Registration
4712 # macros are typically OK, so we allow use of "namespace {" on lines
4713 # that end with backslashes.
4714 if (file_extension == 'h'
4715 and Search(r'\bnamespace\s*{', line)
4716 and line[-1] != '\\'):
4717 error(filename, linenum, 'build/namespaces', 4,
4718 'Do not use unnamed namespaces in header files. See '
Ackermann Yuriy79692902016-04-01 21:41:34 +13004719 'https://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Namespaces'
erg@google.com4e00b9a2009-01-12 23:05:11 +00004720 ' for more information.')
4721
avakulenko@google.com02af6282014-06-04 18:53:25 +00004722
4723def CheckGlobalStatic(filename, clean_lines, linenum, error):
4724 """Check for unsafe global or static objects.
4725
4726 Args:
4727 filename: The name of the current file.
4728 clean_lines: A CleansedLines instance containing the file.
4729 linenum: The number of the line to check.
4730 error: The function to call with any errors found.
4731 """
4732 line = clean_lines.elided[linenum]
4733
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00004734 # Match two lines at a time to support multiline declarations
4735 if linenum + 1 < clean_lines.NumLines() and not Search(r'[;({]', line):
4736 line += clean_lines.elided[linenum + 1].strip()
4737
avakulenko@google.com02af6282014-06-04 18:53:25 +00004738 # Check for people declaring static/global STL strings at the top level.
4739 # This is dangerous because the C++ language does not guarantee that
Alex Vakulenko01e47232016-05-06 13:54:15 -07004740 # globals with constructors are initialized before the first access, and
4741 # also because globals can be destroyed when some threads are still running.
4742 # TODO(unknown): Generalize this to also find static unique_ptr instances.
4743 # TODO(unknown): File bugs for clang-tidy to find these.
avakulenko@google.com02af6282014-06-04 18:53:25 +00004744 match = Match(
Alex Vakulenko01e47232016-05-06 13:54:15 -07004745 r'((?:|static +)(?:|const +))(?::*std::)?string( +const)? +'
4746 r'([a-zA-Z0-9_:]+)\b(.*)',
avakulenko@google.com02af6282014-06-04 18:53:25 +00004747 line)
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00004748
avakulenko@google.com02af6282014-06-04 18:53:25 +00004749 # Remove false positives:
4750 # - String pointers (as opposed to values).
4751 # string *pointer
4752 # const string *pointer
4753 # string const *pointer
4754 # string *const pointer
4755 #
4756 # - Functions and template specializations.
4757 # string Function<Type>(...
4758 # string Class<Type>::Method(...
4759 #
4760 # - Operators. These are matched separately because operator names
4761 # cross non-word boundaries, and trying to match both operators
4762 # and functions at the same time would decrease accuracy of
4763 # matching identifiers.
4764 # string Class::operator*()
4765 if (match and
Alex Vakulenko01e47232016-05-06 13:54:15 -07004766 not Search(r'\bstring\b(\s+const)?\s*[\*\&]\s*(const\s+)?\w', line) and
avakulenko@google.com02af6282014-06-04 18:53:25 +00004767 not Search(r'\boperator\W', line) and
Alex Vakulenko01e47232016-05-06 13:54:15 -07004768 not Match(r'\s*(<.*>)?(::[a-zA-Z0-9_]+)*\s*\(([^"]|$)', match.group(4))):
4769 if Search(r'\bconst\b', line):
4770 error(filename, linenum, 'runtime/string', 4,
4771 'For a static/global string constant, use a C style string '
4772 'instead: "%schar%s %s[]".' %
4773 (match.group(1), match.group(2) or '', match.group(3)))
4774 else:
4775 error(filename, linenum, 'runtime/string', 4,
4776 'Static/global string variables are not permitted.')
avakulenko@google.com02af6282014-06-04 18:53:25 +00004777
Alex Vakulenko01e47232016-05-06 13:54:15 -07004778 if (Search(r'\b([A-Za-z0-9_]*_)\(\1\)', line) or
4779 Search(r'\b([A-Za-z0-9_]*_)\(CHECK_NOTNULL\(\1\)\)', line)):
avakulenko@google.com02af6282014-06-04 18:53:25 +00004780 error(filename, linenum, 'runtime/init', 4,
4781 'You seem to be initializing a member variable with itself.')
4782
4783
4784def CheckPrintf(filename, clean_lines, linenum, error):
4785 """Check for printf related issues.
4786
4787 Args:
4788 filename: The name of the current file.
4789 clean_lines: A CleansedLines instance containing the file.
4790 linenum: The number of the line to check.
4791 error: The function to call with any errors found.
4792 """
4793 line = clean_lines.elided[linenum]
4794
4795 # When snprintf is used, the second argument shouldn't be a literal.
4796 match = Search(r'snprintf\s*\(([^,]*),\s*([0-9]*)\s*,', line)
4797 if match and match.group(2) != '0':
4798 # If 2nd arg is zero, snprintf is used to calculate size.
4799 error(filename, linenum, 'runtime/printf', 3,
4800 'If you can, use sizeof(%s) instead of %s as the 2nd arg '
4801 'to snprintf.' % (match.group(1), match.group(2)))
4802
4803 # Check if some verboten C functions are being used.
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00004804 if Search(r'\bsprintf\s*\(', line):
avakulenko@google.com02af6282014-06-04 18:53:25 +00004805 error(filename, linenum, 'runtime/printf', 5,
4806 'Never use sprintf. Use snprintf instead.')
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00004807 match = Search(r'\b(strcpy|strcat)\s*\(', line)
avakulenko@google.com02af6282014-06-04 18:53:25 +00004808 if match:
4809 error(filename, linenum, 'runtime/printf', 4,
4810 'Almost always, snprintf is better than %s' % match.group(1))
4811
4812
4813def IsDerivedFunction(clean_lines, linenum):
4814 """Check if current line contains an inherited function.
4815
4816 Args:
4817 clean_lines: A CleansedLines instance containing the file.
4818 linenum: The number of the line to check.
4819 Returns:
4820 True if current line contains a function with "override"
4821 virt-specifier.
4822 """
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00004823 # Scan back a few lines for start of current function
4824 for i in xrange(linenum, max(-1, linenum - 10), -1):
4825 match = Match(r'^([^()]*\w+)\(', clean_lines.elided[i])
4826 if match:
4827 # Look for "override" after the matching closing parenthesis
4828 line, _, closing_paren = CloseExpression(
4829 clean_lines, i, len(match.group(1)))
4830 return (closing_paren >= 0 and
4831 Search(r'\boverride\b', line[closing_paren:]))
4832 return False
avakulenko@google.com02af6282014-06-04 18:53:25 +00004833
4834
avakulenko@google.com554223d2014-12-04 22:00:20 +00004835def IsOutOfLineMethodDefinition(clean_lines, linenum):
4836 """Check if current line contains an out-of-line method definition.
4837
4838 Args:
4839 clean_lines: A CleansedLines instance containing the file.
4840 linenum: The number of the line to check.
4841 Returns:
4842 True if current line contains an out-of-line method definition.
4843 """
4844 # Scan back a few lines for start of current function
4845 for i in xrange(linenum, max(-1, linenum - 10), -1):
4846 if Match(r'^([^()]*\w+)\(', clean_lines.elided[i]):
4847 return Match(r'^[^()]*\w+::\w+\(', clean_lines.elided[i]) is not None
4848 return False
4849
4850
avakulenko@google.com02af6282014-06-04 18:53:25 +00004851def IsInitializerList(clean_lines, linenum):
4852 """Check if current line is inside constructor initializer list.
4853
4854 Args:
4855 clean_lines: A CleansedLines instance containing the file.
4856 linenum: The number of the line to check.
4857 Returns:
4858 True if current line appears to be inside constructor initializer
4859 list, False otherwise.
4860 """
4861 for i in xrange(linenum, 1, -1):
4862 line = clean_lines.elided[i]
4863 if i == linenum:
4864 remove_function_body = Match(r'^(.*)\{\s*$', line)
4865 if remove_function_body:
4866 line = remove_function_body.group(1)
4867
4868 if Search(r'\s:\s*\w+[({]', line):
4869 # A lone colon tend to indicate the start of a constructor
4870 # initializer list. It could also be a ternary operator, which
4871 # also tend to appear in constructor initializer lists as
4872 # opposed to parameter lists.
4873 return True
4874 if Search(r'\}\s*,\s*$', line):
4875 # A closing brace followed by a comma is probably the end of a
4876 # brace-initialized member in constructor initializer list.
4877 return True
4878 if Search(r'[{};]\s*$', line):
4879 # Found one of the following:
4880 # - A closing brace or semicolon, probably the end of the previous
4881 # function.
4882 # - An opening brace, probably the start of current class or namespace.
4883 #
4884 # Current line is probably not inside an initializer list since
4885 # we saw one of those things without seeing the starting colon.
4886 return False
4887
4888 # Got to the beginning of the file without seeing the start of
4889 # constructor initializer list.
4890 return False
4891
4892
erg@google.comc6671232013-10-25 21:44:03 +00004893def CheckForNonConstReference(filename, clean_lines, linenum,
4894 nesting_state, error):
4895 """Check for non-const references.
4896
4897 Separate from CheckLanguage since it scans backwards from current
4898 line, instead of scanning forward.
4899
4900 Args:
4901 filename: The name of the current file.
4902 clean_lines: A CleansedLines instance containing the file.
4903 linenum: The number of the line to check.
avakulenko@google.com02af6282014-06-04 18:53:25 +00004904 nesting_state: A NestingState instance which maintains information about
erg@google.comc6671232013-10-25 21:44:03 +00004905 the current stack of nested blocks being parsed.
4906 error: The function to call with any errors found.
4907 """
4908 # Do nothing if there is no '&' on current line.
4909 line = clean_lines.elided[linenum]
4910 if '&' not in line:
4911 return
4912
avakulenko@google.com02af6282014-06-04 18:53:25 +00004913 # If a function is inherited, current function doesn't have much of
4914 # a choice, so any non-const references should not be blamed on
4915 # derived function.
4916 if IsDerivedFunction(clean_lines, linenum):
4917 return
4918
avakulenko@google.com554223d2014-12-04 22:00:20 +00004919 # Don't warn on out-of-line method definitions, as we would warn on the
4920 # in-line declaration, if it isn't marked with 'override'.
4921 if IsOutOfLineMethodDefinition(clean_lines, linenum):
4922 return
4923
erg@google.com2aa59982013-10-28 19:09:25 +00004924 # Long type names may be broken across multiple lines, usually in one
4925 # of these forms:
4926 # LongType
4927 # ::LongTypeContinued &identifier
4928 # LongType::
4929 # LongTypeContinued &identifier
4930 # LongType<
4931 # ...>::LongTypeContinued &identifier
4932 #
4933 # If we detected a type split across two lines, join the previous
4934 # line to current line so that we can match const references
4935 # accordingly.
erg@google.comc6671232013-10-25 21:44:03 +00004936 #
4937 # Note that this only scans back one line, since scanning back
4938 # arbitrary number of lines would be expensive. If you have a type
4939 # that spans more than 2 lines, please use a typedef.
4940 if linenum > 1:
4941 previous = None
erg@google.com2aa59982013-10-28 19:09:25 +00004942 if Match(r'\s*::(?:[\w<>]|::)+\s*&\s*\S', line):
erg@google.comc6671232013-10-25 21:44:03 +00004943 # previous_line\n + ::current_line
erg@google.com2aa59982013-10-28 19:09:25 +00004944 previous = Search(r'\b((?:const\s*)?(?:[\w<>]|::)+[\w<>])\s*$',
erg@google.comc6671232013-10-25 21:44:03 +00004945 clean_lines.elided[linenum - 1])
erg@google.com2aa59982013-10-28 19:09:25 +00004946 elif Match(r'\s*[a-zA-Z_]([\w<>]|::)+\s*&\s*\S', line):
erg@google.comc6671232013-10-25 21:44:03 +00004947 # previous_line::\n + current_line
erg@google.com2aa59982013-10-28 19:09:25 +00004948 previous = Search(r'\b((?:const\s*)?(?:[\w<>]|::)+::)\s*$',
erg@google.comc6671232013-10-25 21:44:03 +00004949 clean_lines.elided[linenum - 1])
4950 if previous:
4951 line = previous.group(1) + line.lstrip()
erg@google.com2aa59982013-10-28 19:09:25 +00004952 else:
4953 # Check for templated parameter that is split across multiple lines
4954 endpos = line.rfind('>')
4955 if endpos > -1:
4956 (_, startline, startpos) = ReverseCloseExpression(
4957 clean_lines, linenum, endpos)
4958 if startpos > -1 and startline < linenum:
4959 # Found the matching < on an earlier line, collect all
4960 # pieces up to current line.
4961 line = ''
4962 for i in xrange(startline, linenum + 1):
4963 line += clean_lines.elided[i].strip()
erg@google.comc6671232013-10-25 21:44:03 +00004964
4965 # Check for non-const references in function parameters. A single '&' may
4966 # found in the following places:
4967 # inside expression: binary & for bitwise AND
4968 # inside expression: unary & for taking the address of something
4969 # inside declarators: reference parameter
4970 # We will exclude the first two cases by checking that we are not inside a
4971 # function body, including one that was just introduced by a trailing '{'.
erg@google.comc6671232013-10-25 21:44:03 +00004972 # TODO(unknown): Doesn't account for 'catch(Exception& e)' [rare].
avakulenko@google.com02af6282014-06-04 18:53:25 +00004973 if (nesting_state.previous_stack_top and
4974 not (isinstance(nesting_state.previous_stack_top, _ClassInfo) or
4975 isinstance(nesting_state.previous_stack_top, _NamespaceInfo))):
4976 # Not at toplevel, not within a class, and not within a namespace
4977 return
4978
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00004979 # Avoid initializer lists. We only need to scan back from the
4980 # current line for something that starts with ':'.
4981 #
4982 # We don't need to check the current line, since the '&' would
4983 # appear inside the second set of parentheses on the current line as
4984 # opposed to the first set.
4985 if linenum > 0:
4986 for i in xrange(linenum - 1, max(0, linenum - 10), -1):
4987 previous_line = clean_lines.elided[i]
4988 if not Search(r'[),]\s*$', previous_line):
4989 break
4990 if Match(r'^\s*:\s+\S', previous_line):
4991 return
4992
avakulenko@google.com02af6282014-06-04 18:53:25 +00004993 # Avoid preprocessors
4994 if Search(r'\\\s*$', line):
4995 return
4996
4997 # Avoid constructor initializer lists
4998 if IsInitializerList(clean_lines, linenum):
4999 return
5000
erg@google.comc6671232013-10-25 21:44:03 +00005001 # We allow non-const references in a few standard places, like functions
5002 # called "swap()" or iostream operators like "<<" or ">>". Do not check
5003 # those function parameters.
5004 #
5005 # We also accept & in static_assert, which looks like a function but
5006 # it's actually a declaration expression.
5007 whitelisted_functions = (r'(?:[sS]wap(?:<\w:+>)?|'
5008 r'operator\s*[<>][<>]|'
5009 r'static_assert|COMPILE_ASSERT'
5010 r')\s*\(')
5011 if Search(whitelisted_functions, line):
avakulenko@google.com02af6282014-06-04 18:53:25 +00005012 return
erg@google.comc6671232013-10-25 21:44:03 +00005013 elif not Search(r'\S+\([^)]*$', line):
5014 # Don't see a whitelisted function on this line. Actually we
5015 # didn't see any function name on this line, so this is likely a
5016 # multi-line parameter list. Try a bit harder to catch this case.
5017 for i in xrange(2):
5018 if (linenum > i and
5019 Search(whitelisted_functions, clean_lines.elided[linenum - i - 1])):
avakulenko@google.com02af6282014-06-04 18:53:25 +00005020 return
erg@google.comc6671232013-10-25 21:44:03 +00005021
avakulenko@google.com02af6282014-06-04 18:53:25 +00005022 decls = ReplaceAll(r'{[^}]*}', ' ', line) # exclude function body
5023 for parameter in re.findall(_RE_PATTERN_REF_PARAM, decls):
Alex Vakulenko01e47232016-05-06 13:54:15 -07005024 if (not Match(_RE_PATTERN_CONST_REF_PARAM, parameter) and
5025 not Match(_RE_PATTERN_REF_STREAM_PARAM, parameter)):
avakulenko@google.com02af6282014-06-04 18:53:25 +00005026 error(filename, linenum, 'runtime/references', 2,
5027 'Is this a non-const reference? '
5028 'If so, make const or use a pointer: ' +
5029 ReplaceAll(' *<', '<', parameter))
5030
5031
5032def CheckCasts(filename, clean_lines, linenum, error):
5033 """Various cast related checks.
5034
5035 Args:
5036 filename: The name of the current file.
5037 clean_lines: A CleansedLines instance containing the file.
5038 linenum: The number of the line to check.
5039 error: The function to call with any errors found.
5040 """
5041 line = clean_lines.elided[linenum]
5042
5043 # Check to see if they're using an conversion function cast.
5044 # I just try to capture the most common basic types, though there are more.
5045 # Parameterless conversion functions, such as bool(), are allowed as they are
5046 # probably a member operator declaration or default constructor.
5047 match = Search(
Alex Vakulenko01e47232016-05-06 13:54:15 -07005048 r'(\bnew\s+(?:const\s+)?|\S<\s*(?:const\s+)?)?\b'
avakulenko@google.com02af6282014-06-04 18:53:25 +00005049 r'(int|float|double|bool|char|int32|uint32|int64|uint64)'
5050 r'(\([^)].*)', line)
5051 expecting_function = ExpectingFunctionArgs(clean_lines, linenum)
5052 if match and not expecting_function:
5053 matched_type = match.group(2)
5054
5055 # matched_new_or_template is used to silence two false positives:
5056 # - New operators
5057 # - Template arguments with function types
5058 #
5059 # For template arguments, we match on types immediately following
5060 # an opening bracket without any spaces. This is a fast way to
5061 # silence the common case where the function type is the first
5062 # template argument. False negative with less-than comparison is
5063 # avoided because those operators are usually followed by a space.
5064 #
5065 # function<double(double)> // bracket + no space = false positive
5066 # value < double(42) // bracket + space = true positive
5067 matched_new_or_template = match.group(1)
5068
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005069 # Avoid arrays by looking for brackets that come after the closing
5070 # parenthesis.
5071 if Match(r'\([^()]+\)\s*\[', match.group(3)):
5072 return
5073
avakulenko@google.com02af6282014-06-04 18:53:25 +00005074 # Other things to ignore:
5075 # - Function pointers
5076 # - Casts to pointer types
5077 # - Placement new
5078 # - Alias declarations
5079 matched_funcptr = match.group(3)
5080 if (matched_new_or_template is None and
5081 not (matched_funcptr and
5082 (Match(r'\((?:[^() ]+::\s*\*\s*)?[^() ]+\)\s*\(',
5083 matched_funcptr) or
5084 matched_funcptr.startswith('(*)'))) and
5085 not Match(r'\s*using\s+\S+\s*=\s*' + matched_type, line) and
5086 not Search(r'new\(\S+\)\s*' + matched_type, line)):
5087 error(filename, linenum, 'readability/casting', 4,
5088 'Using deprecated casting style. '
5089 'Use static_cast<%s>(...) instead' %
5090 matched_type)
5091
5092 if not expecting_function:
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005093 CheckCStyleCast(filename, clean_lines, linenum, 'static_cast',
avakulenko@google.com02af6282014-06-04 18:53:25 +00005094 r'\((int|float|double|bool|char|u?int(16|32|64))\)', error)
5095
5096 # This doesn't catch all cases. Consider (const char * const)"hello".
5097 #
5098 # (char *) "foo" should always be a const_cast (reinterpret_cast won't
5099 # compile).
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005100 if CheckCStyleCast(filename, clean_lines, linenum, 'const_cast',
5101 r'\((char\s?\*+\s?)\)\s*"', error):
avakulenko@google.com02af6282014-06-04 18:53:25 +00005102 pass
5103 else:
5104 # Check pointer casts for other than string constants
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005105 CheckCStyleCast(filename, clean_lines, linenum, 'reinterpret_cast',
5106 r'\((\w+\s?\*+\s?)\)', error)
avakulenko@google.com02af6282014-06-04 18:53:25 +00005107
5108 # In addition, we look for people taking the address of a cast. This
5109 # is dangerous -- casts can assign to temporaries, so the pointer doesn't
5110 # point where you think.
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005111 #
5112 # Some non-identifier character is required before the '&' for the
5113 # expression to be recognized as a cast. These are casts:
5114 # expression = &static_cast<int*>(temporary());
5115 # function(&(int*)(temporary()));
5116 #
5117 # This is not a cast:
5118 # reference_type&(int* function_param);
avakulenko@google.com02af6282014-06-04 18:53:25 +00005119 match = Search(
avakulenko@google.com554223d2014-12-04 22:00:20 +00005120 r'(?:[^\w]&\(([^)*][^)]*)\)[\w(])|'
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005121 r'(?:[^\w]&(static|dynamic|down|reinterpret)_cast\b)', line)
avakulenko@google.com554223d2014-12-04 22:00:20 +00005122 if match:
avakulenko@google.com02af6282014-06-04 18:53:25 +00005123 # Try a better error message when the & is bound to something
5124 # dereferenced by the casted pointer, as opposed to the casted
5125 # pointer itself.
5126 parenthesis_error = False
5127 match = Match(r'^(.*&(?:static|dynamic|down|reinterpret)_cast\b)<', line)
5128 if match:
5129 _, y1, x1 = CloseExpression(clean_lines, linenum, len(match.group(1)))
5130 if x1 >= 0 and clean_lines.elided[y1][x1] == '(':
5131 _, y2, x2 = CloseExpression(clean_lines, y1, x1)
5132 if x2 >= 0:
5133 extended_line = clean_lines.elided[y2][x2:]
5134 if y2 < clean_lines.NumLines() - 1:
5135 extended_line += clean_lines.elided[y2 + 1]
5136 if Match(r'\s*(?:->|\[)', extended_line):
5137 parenthesis_error = True
5138
5139 if parenthesis_error:
5140 error(filename, linenum, 'readability/casting', 4,
5141 ('Are you taking an address of something dereferenced '
5142 'from a cast? Wrapping the dereferenced expression in '
5143 'parentheses will make the binding more obvious'))
5144 else:
5145 error(filename, linenum, 'runtime/casting', 4,
5146 ('Are you taking an address of a cast? '
5147 'This is dangerous: could be a temp var. '
5148 'Take the address before doing the cast, rather than after'))
erg@google.comc6671232013-10-25 21:44:03 +00005149
erg@google.com4e00b9a2009-01-12 23:05:11 +00005150
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005151def CheckCStyleCast(filename, clean_lines, linenum, cast_type, pattern, error):
erg@google.com4e00b9a2009-01-12 23:05:11 +00005152 """Checks for a C-style cast by looking for the pattern.
5153
erg@google.com4e00b9a2009-01-12 23:05:11 +00005154 Args:
5155 filename: The name of the current file.
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005156 clean_lines: A CleansedLines instance containing the file.
erg@google.com4e00b9a2009-01-12 23:05:11 +00005157 linenum: The number of the line to check.
erg@google.com4e00b9a2009-01-12 23:05:11 +00005158 cast_type: The string for the C++ cast to recommend. This is either
erg@google.com8a95ecc2011-09-08 00:45:54 +00005159 reinterpret_cast, static_cast, or const_cast, depending.
erg@google.com4e00b9a2009-01-12 23:05:11 +00005160 pattern: The regular expression used to find C-style casts.
5161 error: The function to call with any errors found.
erg@google.com8a95ecc2011-09-08 00:45:54 +00005162
5163 Returns:
5164 True if an error was emitted.
5165 False otherwise.
erg@google.com4e00b9a2009-01-12 23:05:11 +00005166 """
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005167 line = clean_lines.elided[linenum]
erg@google.com4e00b9a2009-01-12 23:05:11 +00005168 match = Search(pattern, line)
5169 if not match:
erg@google.com8a95ecc2011-09-08 00:45:54 +00005170 return False
erg@google.com4e00b9a2009-01-12 23:05:11 +00005171
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005172 # Exclude lines with keywords that tend to look like casts
5173 context = line[0:match.start(1) - 1]
5174 if Match(r'.*\b(?:sizeof|alignof|alignas|[_A-Z][_A-Z0-9]*)\s*$', context):
5175 return False
5176
5177 # Try expanding current context to see if we one level of
5178 # parentheses inside a macro.
5179 if linenum > 0:
5180 for i in xrange(linenum - 1, max(0, linenum - 5), -1):
5181 context = clean_lines.elided[i] + context
5182 if Match(r'.*\b[_A-Z][_A-Z0-9]*\s*\((?:\([^()]*\)|[^()])*$', context):
erg@google.comfd5da632013-10-25 17:39:45 +00005183 return False
erg@google.com4e00b9a2009-01-12 23:05:11 +00005184
erg@google.comd350fe52013-01-14 17:51:48 +00005185 # operator++(int) and operator--(int)
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005186 if context.endswith(' operator++') or context.endswith(' operator--'):
erg@google.comd350fe52013-01-14 17:51:48 +00005187 return False
5188
Alex Vakulenko01e47232016-05-06 13:54:15 -07005189 # A single unnamed argument for a function tends to look like old style cast.
5190 # If we see those, don't issue warnings for deprecated casts.
erg@google.comc6671232013-10-25 21:44:03 +00005191 remainder = line[match.end(0):]
avakulenko@google.com554223d2014-12-04 22:00:20 +00005192 if Match(r'^\s*(?:;|const\b|throw\b|final\b|override\b|[=>{),]|->)',
avakulenko@google.com02af6282014-06-04 18:53:25 +00005193 remainder):
Alex Vakulenko01e47232016-05-06 13:54:15 -07005194 return False
erg@google.com4e00b9a2009-01-12 23:05:11 +00005195
5196 # At this point, all that should be left is actual casts.
5197 error(filename, linenum, 'readability/casting', 4,
5198 'Using C-style cast. Use %s<%s>(...) instead' %
5199 (cast_type, match.group(1)))
5200
erg@google.com8a95ecc2011-09-08 00:45:54 +00005201 return True
5202
erg@google.com4e00b9a2009-01-12 23:05:11 +00005203
avakulenko@google.com02af6282014-06-04 18:53:25 +00005204def ExpectingFunctionArgs(clean_lines, linenum):
5205 """Checks whether where function type arguments are expected.
5206
5207 Args:
5208 clean_lines: A CleansedLines instance containing the file.
5209 linenum: The number of the line to check.
5210
5211 Returns:
5212 True if the line at 'linenum' is inside something that expects arguments
5213 of function types.
5214 """
5215 line = clean_lines.elided[linenum]
5216 return (Match(r'^\s*MOCK_(CONST_)?METHOD\d+(_T)?\(', line) or
5217 (linenum >= 2 and
5218 (Match(r'^\s*MOCK_(?:CONST_)?METHOD\d+(?:_T)?\((?:\S+,)?\s*$',
5219 clean_lines.elided[linenum - 1]) or
5220 Match(r'^\s*MOCK_(?:CONST_)?METHOD\d+(?:_T)?\(\s*$',
5221 clean_lines.elided[linenum - 2]) or
5222 Search(r'\bstd::m?function\s*\<\s*$',
5223 clean_lines.elided[linenum - 1]))))
5224
5225
erg@google.com4e00b9a2009-01-12 23:05:11 +00005226_HEADERS_CONTAINING_TEMPLATES = (
5227 ('<deque>', ('deque',)),
5228 ('<functional>', ('unary_function', 'binary_function',
5229 'plus', 'minus', 'multiplies', 'divides', 'modulus',
5230 'negate',
5231 'equal_to', 'not_equal_to', 'greater', 'less',
5232 'greater_equal', 'less_equal',
5233 'logical_and', 'logical_or', 'logical_not',
5234 'unary_negate', 'not1', 'binary_negate', 'not2',
5235 'bind1st', 'bind2nd',
5236 'pointer_to_unary_function',
5237 'pointer_to_binary_function',
5238 'ptr_fun',
5239 'mem_fun_t', 'mem_fun', 'mem_fun1_t', 'mem_fun1_ref_t',
5240 'mem_fun_ref_t',
5241 'const_mem_fun_t', 'const_mem_fun1_t',
5242 'const_mem_fun_ref_t', 'const_mem_fun1_ref_t',
5243 'mem_fun_ref',
5244 )),
5245 ('<limits>', ('numeric_limits',)),
5246 ('<list>', ('list',)),
5247 ('<map>', ('map', 'multimap',)),
5248 ('<memory>', ('allocator',)),
5249 ('<queue>', ('queue', 'priority_queue',)),
5250 ('<set>', ('set', 'multiset',)),
5251 ('<stack>', ('stack',)),
5252 ('<string>', ('char_traits', 'basic_string',)),
avakulenko@google.com554223d2014-12-04 22:00:20 +00005253 ('<tuple>', ('tuple',)),
erg@google.com4e00b9a2009-01-12 23:05:11 +00005254 ('<utility>', ('pair',)),
5255 ('<vector>', ('vector',)),
5256
5257 # gcc extensions.
5258 # Note: std::hash is their hash, ::hash is our hash
5259 ('<hash_map>', ('hash_map', 'hash_multimap',)),
5260 ('<hash_set>', ('hash_set', 'hash_multiset',)),
5261 ('<slist>', ('slist',)),
5262 )
5263
Alex Vakulenko01e47232016-05-06 13:54:15 -07005264_HEADERS_MAYBE_TEMPLATES = (
5265 ('<algorithm>', ('copy', 'max', 'min', 'min_element', 'sort',
5266 'transform',
5267 )),
5268 ('<utility>', ('swap',)),
5269 )
5270
erg@google.com4e00b9a2009-01-12 23:05:11 +00005271_RE_PATTERN_STRING = re.compile(r'\bstring\b')
5272
Alex Vakulenko01e47232016-05-06 13:54:15 -07005273_re_pattern_headers_maybe_templates = []
5274for _header, _templates in _HEADERS_MAYBE_TEMPLATES:
5275 for _template in _templates:
5276 # Match max<type>(..., ...), max(..., ...), but not foo->max, foo.max or
5277 # type::max().
5278 _re_pattern_headers_maybe_templates.append(
5279 (re.compile(r'[^>.]\b' + _template + r'(<.*?>)?\([^\)]'),
5280 _template,
5281 _header))
erg@google.com4e00b9a2009-01-12 23:05:11 +00005282
Alex Vakulenko01e47232016-05-06 13:54:15 -07005283# Other scripts may reach in and modify this pattern.
erg@google.com4e00b9a2009-01-12 23:05:11 +00005284_re_pattern_templates = []
5285for _header, _templates in _HEADERS_CONTAINING_TEMPLATES:
5286 for _template in _templates:
5287 _re_pattern_templates.append(
5288 (re.compile(r'(\<|\b)' + _template + r'\s*\<'),
5289 _template + '<>',
5290 _header))
5291
5292
erg@google.come35f7652009-06-19 20:52:09 +00005293def FilesBelongToSameModule(filename_cc, filename_h):
5294 """Check if these two filenames belong to the same module.
5295
5296 The concept of a 'module' here is a as follows:
5297 foo.h, foo-inl.h, foo.cc, foo_test.cc and foo_unittest.cc belong to the
5298 same 'module' if they are in the same directory.
5299 some/path/public/xyzzy and some/path/internal/xyzzy are also considered
5300 to belong to the same module here.
5301
5302 If the filename_cc contains a longer path than the filename_h, for example,
5303 '/absolute/path/to/base/sysinfo.cc', and this file would include
5304 'base/sysinfo.h', this function also produces the prefix needed to open the
5305 header. This is used by the caller of this function to more robustly open the
5306 header file. We don't have access to the real include paths in this context,
5307 so we need this guesswork here.
5308
5309 Known bugs: tools/base/bar.cc and base/bar.h belong to the same module
5310 according to this implementation. Because of this, this function gives
5311 some false positives. This should be sufficiently rare in practice.
5312
5313 Args:
5314 filename_cc: is the path for the .cc file
5315 filename_h: is the path for the header path
5316
5317 Returns:
5318 Tuple with a bool and a string:
5319 bool: True if filename_cc and filename_h belong to the same module.
5320 string: the additional prefix needed to open the header file.
5321 """
5322
Alex Vakulenko01e47232016-05-06 13:54:15 -07005323 fileinfo = FileInfo(filename_cc)
5324 if not fileinfo.IsSource():
erg@google.come35f7652009-06-19 20:52:09 +00005325 return (False, '')
Alex Vakulenko01e47232016-05-06 13:54:15 -07005326 filename_cc = filename_cc[:-len(fileinfo.Extension())]
5327 matched_test_suffix = Search(_TEST_FILE_SUFFIX, fileinfo.BaseName())
5328 if matched_test_suffix:
5329 filename_cc = filename_cc[:-len(matched_test_suffix.group(1))]
erg@google.come35f7652009-06-19 20:52:09 +00005330 filename_cc = filename_cc.replace('/public/', '/')
5331 filename_cc = filename_cc.replace('/internal/', '/')
5332
5333 if not filename_h.endswith('.h'):
5334 return (False, '')
5335 filename_h = filename_h[:-len('.h')]
5336 if filename_h.endswith('-inl'):
5337 filename_h = filename_h[:-len('-inl')]
5338 filename_h = filename_h.replace('/public/', '/')
5339 filename_h = filename_h.replace('/internal/', '/')
5340
5341 files_belong_to_same_module = filename_cc.endswith(filename_h)
5342 common_path = ''
5343 if files_belong_to_same_module:
5344 common_path = filename_cc[:-len(filename_h)]
5345 return files_belong_to_same_module, common_path
5346
5347
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005348def UpdateIncludeState(filename, include_dict, io=codecs):
5349 """Fill up the include_dict with new includes found from the file.
erg@google.come35f7652009-06-19 20:52:09 +00005350
5351 Args:
5352 filename: the name of the header to read.
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005353 include_dict: a dictionary in which the headers are inserted.
erg@google.come35f7652009-06-19 20:52:09 +00005354 io: The io factory to use to read the file. Provided for testability.
5355
5356 Returns:
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005357 True if a header was successfully added. False otherwise.
erg@google.come35f7652009-06-19 20:52:09 +00005358 """
5359 headerfile = None
5360 try:
5361 headerfile = io.open(filename, 'r', 'utf8', 'replace')
5362 except IOError:
5363 return False
5364 linenum = 0
5365 for line in headerfile:
5366 linenum += 1
5367 clean_line = CleanseComments(line)
5368 match = _RE_PATTERN_INCLUDE.search(clean_line)
5369 if match:
5370 include = match.group(2)
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005371 include_dict.setdefault(include, linenum)
erg@google.come35f7652009-06-19 20:52:09 +00005372 return True
5373
5374
5375def CheckForIncludeWhatYouUse(filename, clean_lines, include_state, error,
5376 io=codecs):
erg@google.com4e00b9a2009-01-12 23:05:11 +00005377 """Reports for missing stl includes.
5378
5379 This function will output warnings to make sure you are including the headers
5380 necessary for the stl containers and functions that you use. We only give one
5381 reason to include a header. For example, if you use both equal_to<> and
5382 less<> in a .h file, only one (the latter in the file) of these will be
5383 reported as a reason to include the <functional>.
5384
erg@google.com4e00b9a2009-01-12 23:05:11 +00005385 Args:
5386 filename: The name of the current file.
5387 clean_lines: A CleansedLines instance containing the file.
5388 include_state: An _IncludeState instance.
5389 error: The function to call with any errors found.
erg@google.come35f7652009-06-19 20:52:09 +00005390 io: The IO factory to use to read the header file. Provided for unittest
5391 injection.
erg@google.com4e00b9a2009-01-12 23:05:11 +00005392 """
erg@google.com4e00b9a2009-01-12 23:05:11 +00005393 required = {} # A map of header name to linenumber and the template entity.
5394 # Example of required: { '<functional>': (1219, 'less<>') }
5395
5396 for linenum in xrange(clean_lines.NumLines()):
5397 line = clean_lines.elided[linenum]
5398 if not line or line[0] == '#':
5399 continue
5400
5401 # String is special -- it is a non-templatized type in STL.
erg@google.com8a95ecc2011-09-08 00:45:54 +00005402 matched = _RE_PATTERN_STRING.search(line)
5403 if matched:
erg+personal@google.com05189642010-04-30 20:43:03 +00005404 # Don't warn about strings in non-STL namespaces:
5405 # (We check only the first match per line; good enough.)
erg@google.com8a95ecc2011-09-08 00:45:54 +00005406 prefix = line[:matched.start()]
erg+personal@google.com05189642010-04-30 20:43:03 +00005407 if prefix.endswith('std::') or not prefix.endswith('::'):
5408 required['<string>'] = (linenum, 'string')
erg@google.com4e00b9a2009-01-12 23:05:11 +00005409
Alex Vakulenko01e47232016-05-06 13:54:15 -07005410 for pattern, template, header in _re_pattern_headers_maybe_templates:
erg@google.com4e00b9a2009-01-12 23:05:11 +00005411 if pattern.search(line):
5412 required[header] = (linenum, template)
5413
5414 # The following function is just a speed up, no semantics are changed.
5415 if not '<' in line: # Reduces the cpu time usage by skipping lines.
5416 continue
5417
5418 for pattern, template, header in _re_pattern_templates:
5419 if pattern.search(line):
5420 required[header] = (linenum, template)
5421
erg@google.come35f7652009-06-19 20:52:09 +00005422 # The policy is that if you #include something in foo.h you don't need to
5423 # include it again in foo.cc. Here, we will look at possible includes.
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005424 # Let's flatten the include_state include_list and copy it into a dictionary.
5425 include_dict = dict([item for sublist in include_state.include_list
5426 for item in sublist])
erg@google.come35f7652009-06-19 20:52:09 +00005427
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005428 # Did we find the header for this file (if any) and successfully load it?
erg@google.come35f7652009-06-19 20:52:09 +00005429 header_found = False
5430
5431 # Use the absolute path so that matching works properly.
erg@google.com90ecb622012-01-30 19:34:23 +00005432 abs_filename = FileInfo(filename).FullName()
erg@google.come35f7652009-06-19 20:52:09 +00005433
5434 # For Emacs's flymake.
5435 # If cpplint is invoked from Emacs's flymake, a temporary file is generated
5436 # by flymake and that file name might end with '_flymake.cc'. In that case,
5437 # restore original file name here so that the corresponding header file can be
5438 # found.
5439 # e.g. If the file name is 'foo_flymake.cc', we should search for 'foo.h'
5440 # instead of 'foo_flymake.h'
erg+personal@google.com05189642010-04-30 20:43:03 +00005441 abs_filename = re.sub(r'_flymake\.cc$', '.cc', abs_filename)
erg@google.come35f7652009-06-19 20:52:09 +00005442
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005443 # include_dict is modified during iteration, so we iterate over a copy of
erg@google.come35f7652009-06-19 20:52:09 +00005444 # the keys.
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005445 header_keys = include_dict.keys()
erg@google.com8a95ecc2011-09-08 00:45:54 +00005446 for header in header_keys:
erg@google.come35f7652009-06-19 20:52:09 +00005447 (same_module, common_path) = FilesBelongToSameModule(abs_filename, header)
5448 fullpath = common_path + header
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005449 if same_module and UpdateIncludeState(fullpath, include_dict, io):
erg@google.come35f7652009-06-19 20:52:09 +00005450 header_found = True
5451
5452 # If we can't find the header file for a .cc, assume it's because we don't
5453 # know where to look. In that case we'll give up as we're not sure they
5454 # didn't include it in the .h file.
5455 # TODO(unknown): Do a better job of finding .h files so we are confident that
5456 # not having the .h file means there isn't one.
5457 if filename.endswith('.cc') and not header_found:
5458 return
5459
erg@google.com4e00b9a2009-01-12 23:05:11 +00005460 # All the lines have been processed, report the errors found.
5461 for required_header_unstripped in required:
5462 template = required[required_header_unstripped][1]
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005463 if required_header_unstripped.strip('<>"') not in include_dict:
erg@google.com4e00b9a2009-01-12 23:05:11 +00005464 error(filename, required[required_header_unstripped][0],
5465 'build/include_what_you_use', 4,
5466 'Add #include ' + required_header_unstripped + ' for ' + template)
5467
5468
erg@google.com8a95ecc2011-09-08 00:45:54 +00005469_RE_PATTERN_EXPLICIT_MAKEPAIR = re.compile(r'\bmake_pair\s*<')
5470
5471
5472def CheckMakePairUsesDeduction(filename, clean_lines, linenum, error):
5473 """Check that make_pair's template arguments are deduced.
5474
avakulenko@google.com02af6282014-06-04 18:53:25 +00005475 G++ 4.6 in C++11 mode fails badly if make_pair's template arguments are
erg@google.com8a95ecc2011-09-08 00:45:54 +00005476 specified explicitly, and such use isn't intended in any case.
5477
5478 Args:
5479 filename: The name of the current file.
5480 clean_lines: A CleansedLines instance containing the file.
5481 linenum: The number of the line to check.
5482 error: The function to call with any errors found.
5483 """
erg@google.com2aa59982013-10-28 19:09:25 +00005484 line = clean_lines.elided[linenum]
erg@google.com8a95ecc2011-09-08 00:45:54 +00005485 match = _RE_PATTERN_EXPLICIT_MAKEPAIR.search(line)
5486 if match:
5487 error(filename, linenum, 'build/explicit_make_pair',
5488 4, # 4 = high confidence
erg@google.comd350fe52013-01-14 17:51:48 +00005489 'For C++11-compatibility, omit template arguments from make_pair'
5490 ' OR use pair directly OR if appropriate, construct a pair directly')
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005491
5492
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005493def CheckRedundantVirtual(filename, clean_lines, linenum, error):
5494 """Check if line contains a redundant "virtual" function-specifier.
5495
5496 Args:
5497 filename: The name of the current file.
5498 clean_lines: A CleansedLines instance containing the file.
5499 linenum: The number of the line to check.
5500 error: The function to call with any errors found.
5501 """
5502 # Look for "virtual" on current line.
5503 line = clean_lines.elided[linenum]
avakulenko@google.com554223d2014-12-04 22:00:20 +00005504 virtual = Match(r'^(.*)(\bvirtual\b)(.*)$', line)
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005505 if not virtual: return
5506
avakulenko@google.com554223d2014-12-04 22:00:20 +00005507 # Ignore "virtual" keywords that are near access-specifiers. These
5508 # are only used in class base-specifier and do not apply to member
5509 # functions.
5510 if (Search(r'\b(public|protected|private)\s+$', virtual.group(1)) or
5511 Match(r'^\s+(public|protected|private)\b', virtual.group(3))):
5512 return
5513
5514 # Ignore the "virtual" keyword from virtual base classes. Usually
5515 # there is a column on the same line in these cases (virtual base
5516 # classes are rare in google3 because multiple inheritance is rare).
5517 if Match(r'^.*[^:]:[^:].*$', line): return
5518
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005519 # Look for the next opening parenthesis. This is the start of the
5520 # parameter list (possibly on the next line shortly after virtual).
5521 # TODO(unknown): doesn't work if there are virtual functions with
5522 # decltype() or other things that use parentheses, but csearch suggests
5523 # that this is rare.
5524 end_col = -1
5525 end_line = -1
avakulenko@google.com554223d2014-12-04 22:00:20 +00005526 start_col = len(virtual.group(2))
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005527 for start_line in xrange(linenum, min(linenum + 3, clean_lines.NumLines())):
5528 line = clean_lines.elided[start_line][start_col:]
5529 parameter_list = Match(r'^([^(]*)\(', line)
5530 if parameter_list:
5531 # Match parentheses to find the end of the parameter list
5532 (_, end_line, end_col) = CloseExpression(
5533 clean_lines, start_line, start_col + len(parameter_list.group(1)))
5534 break
5535 start_col = 0
5536
5537 if end_col < 0:
5538 return # Couldn't find end of parameter list, give up
5539
5540 # Look for "override" or "final" after the parameter list
5541 # (possibly on the next few lines).
5542 for i in xrange(end_line, min(end_line + 3, clean_lines.NumLines())):
5543 line = clean_lines.elided[i][end_col:]
5544 match = Search(r'\b(override|final)\b', line)
5545 if match:
5546 error(filename, linenum, 'readability/inheritance', 4,
5547 ('"virtual" is redundant since function is '
5548 'already declared as "%s"' % match.group(1)))
5549
5550 # Set end_col to check whole lines after we are done with the
5551 # first line.
5552 end_col = 0
5553 if Search(r'[^\w]\s*$', line):
5554 break
5555
5556
5557def CheckRedundantOverrideOrFinal(filename, clean_lines, linenum, error):
5558 """Check if line contains a redundant "override" or "final" virt-specifier.
5559
5560 Args:
5561 filename: The name of the current file.
5562 clean_lines: A CleansedLines instance containing the file.
5563 linenum: The number of the line to check.
5564 error: The function to call with any errors found.
5565 """
avakulenko@google.com554223d2014-12-04 22:00:20 +00005566 # Look for closing parenthesis nearby. We need one to confirm where
5567 # the declarator ends and where the virt-specifier starts to avoid
5568 # false positives.
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005569 line = clean_lines.elided[linenum]
avakulenko@google.com554223d2014-12-04 22:00:20 +00005570 declarator_end = line.rfind(')')
5571 if declarator_end >= 0:
5572 fragment = line[declarator_end:]
5573 else:
5574 if linenum > 1 and clean_lines.elided[linenum - 1].rfind(')') >= 0:
5575 fragment = line
5576 else:
5577 return
5578
5579 # Check that at most one of "override" or "final" is present, not both
5580 if Search(r'\boverride\b', fragment) and Search(r'\bfinal\b', fragment):
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005581 error(filename, linenum, 'readability/inheritance', 4,
5582 ('"override" is redundant since function is '
5583 'already declared as "final"'))
5584
5585
5586
5587
5588# Returns true if we are at a new block, and it is directly
5589# inside of a namespace.
5590def IsBlockInNameSpace(nesting_state, is_forward_declaration):
5591 """Checks that the new block is directly in a namespace.
5592
5593 Args:
5594 nesting_state: The _NestingState object that contains info about our state.
5595 is_forward_declaration: If the class is a forward declared class.
5596 Returns:
5597 Whether or not the new block is directly in a namespace.
5598 """
5599 if is_forward_declaration:
5600 if len(nesting_state.stack) >= 1 and (
5601 isinstance(nesting_state.stack[-1], _NamespaceInfo)):
5602 return True
5603 else:
5604 return False
5605
5606 return (len(nesting_state.stack) > 1 and
5607 nesting_state.stack[-1].check_namespace_indentation and
5608 isinstance(nesting_state.stack[-2], _NamespaceInfo))
5609
5610
5611def ShouldCheckNamespaceIndentation(nesting_state, is_namespace_indent_item,
5612 raw_lines_no_comments, linenum):
5613 """This method determines if we should apply our namespace indentation check.
5614
5615 Args:
5616 nesting_state: The current nesting state.
5617 is_namespace_indent_item: If we just put a new class on the stack, True.
5618 If the top of the stack is not a class, or we did not recently
5619 add the class, False.
5620 raw_lines_no_comments: The lines without the comments.
5621 linenum: The current line number we are processing.
5622
5623 Returns:
5624 True if we should apply our namespace indentation check. Currently, it
5625 only works for classes and namespaces inside of a namespace.
5626 """
5627
5628 is_forward_declaration = IsForwardClassDeclaration(raw_lines_no_comments,
5629 linenum)
5630
5631 if not (is_namespace_indent_item or is_forward_declaration):
5632 return False
5633
5634 # If we are in a macro, we do not want to check the namespace indentation.
5635 if IsMacroDefinition(raw_lines_no_comments, linenum):
5636 return False
5637
5638 return IsBlockInNameSpace(nesting_state, is_forward_declaration)
5639
5640
5641# Call this method if the line is directly inside of a namespace.
5642# If the line above is blank (excluding comments) or the start of
5643# an inner namespace, it cannot be indented.
5644def CheckItemIndentationInNamespace(filename, raw_lines_no_comments, linenum,
5645 error):
5646 line = raw_lines_no_comments[linenum]
5647 if Match(r'^\s+', line):
5648 error(filename, linenum, 'runtime/indentation_namespace', 4,
5649 'Do not indent within a namespace')
erg@google.com8a95ecc2011-09-08 00:45:54 +00005650
5651
erg@google.comd350fe52013-01-14 17:51:48 +00005652def ProcessLine(filename, file_extension, clean_lines, line,
avakulenko@google.com4b957b22014-06-04 22:48:14 +00005653 include_state, function_state, nesting_state, error,
5654 extra_check_functions=[]):
erg@google.com4e00b9a2009-01-12 23:05:11 +00005655 """Processes a single line in the file.
5656
5657 Args:
5658 filename: Filename of the file that is being processed.
5659 file_extension: The extension (dot not included) of the file.
5660 clean_lines: An array of strings, each representing a line of the file,
5661 with comments stripped.
5662 line: Number of line being processed.
5663 include_state: An _IncludeState instance in which the headers are inserted.
5664 function_state: A _FunctionState instance which counts function lines, etc.
avakulenko@google.com02af6282014-06-04 18:53:25 +00005665 nesting_state: A NestingState instance which maintains information about
erg@google.comd350fe52013-01-14 17:51:48 +00005666 the current stack of nested blocks being parsed.
erg@google.com4e00b9a2009-01-12 23:05:11 +00005667 error: A callable to which errors are reported, which takes 4 arguments:
5668 filename, line number, error level, and message
avakulenko@google.com4b957b22014-06-04 22:48:14 +00005669 extra_check_functions: An array of additional check functions that will be
5670 run on each source line. Each function takes 4
5671 arguments: filename, clean_lines, line, error
erg@google.com4e00b9a2009-01-12 23:05:11 +00005672 """
5673 raw_lines = clean_lines.raw_lines
erg+personal@google.com05189642010-04-30 20:43:03 +00005674 ParseNolintSuppressions(filename, raw_lines[line], line, error)
erg@google.comd350fe52013-01-14 17:51:48 +00005675 nesting_state.Update(filename, clean_lines, line, error)
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005676 CheckForNamespaceIndentation(filename, nesting_state, clean_lines, line,
5677 error)
avakulenko@google.com02af6282014-06-04 18:53:25 +00005678 if nesting_state.InAsmBlock(): return
erg@google.com4e00b9a2009-01-12 23:05:11 +00005679 CheckForFunctionLengths(filename, clean_lines, line, function_state, error)
erg@google.com4e00b9a2009-01-12 23:05:11 +00005680 CheckForMultilineCommentsAndStrings(filename, clean_lines, line, error)
erg@google.comd350fe52013-01-14 17:51:48 +00005681 CheckStyle(filename, clean_lines, line, file_extension, nesting_state, error)
erg@google.com4e00b9a2009-01-12 23:05:11 +00005682 CheckLanguage(filename, clean_lines, line, file_extension, include_state,
erg@google.comfd5da632013-10-25 17:39:45 +00005683 nesting_state, error)
erg@google.comc6671232013-10-25 21:44:03 +00005684 CheckForNonConstReference(filename, clean_lines, line, nesting_state, error)
erg@google.com4e00b9a2009-01-12 23:05:11 +00005685 CheckForNonStandardConstructs(filename, clean_lines, line,
erg@google.comd350fe52013-01-14 17:51:48 +00005686 nesting_state, error)
erg@google.com2aa59982013-10-28 19:09:25 +00005687 CheckVlogArguments(filename, clean_lines, line, error)
erg@google.com4e00b9a2009-01-12 23:05:11 +00005688 CheckPosixThreading(filename, clean_lines, line, error)
erg@google.com36649102009-03-25 21:18:36 +00005689 CheckInvalidIncrement(filename, clean_lines, line, error)
erg@google.com8a95ecc2011-09-08 00:45:54 +00005690 CheckMakePairUsesDeduction(filename, clean_lines, line, error)
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005691 CheckRedundantVirtual(filename, clean_lines, line, error)
5692 CheckRedundantOverrideOrFinal(filename, clean_lines, line, error)
avakulenko@google.com4b957b22014-06-04 22:48:14 +00005693 for check_fn in extra_check_functions:
5694 check_fn(filename, clean_lines, line, error)
erg@google.com7430eef2014-07-28 22:33:46 +00005695
avakulenko@google.com02af6282014-06-04 18:53:25 +00005696def FlagCxx11Features(filename, clean_lines, linenum, error):
5697 """Flag those c++11 features that we only allow in certain places.
5698
5699 Args:
5700 filename: The name of the current file.
5701 clean_lines: A CleansedLines instance containing the file.
5702 linenum: The number of the line to check.
5703 error: The function to call with any errors found.
5704 """
5705 line = clean_lines.elided[linenum]
5706
avakulenko@google.com02af6282014-06-04 18:53:25 +00005707 include = Match(r'\s*#\s*include\s+[<"]([^<"]+)[">]', line)
Alex Vakulenko01e47232016-05-06 13:54:15 -07005708
5709 # Flag unapproved C++ TR1 headers.
5710 if include and include.group(1).startswith('tr1/'):
5711 error(filename, linenum, 'build/c++tr1', 5,
5712 ('C++ TR1 headers such as <%s> are unapproved.') % include.group(1))
5713
5714 # Flag unapproved C++11 headers.
avakulenko@google.com02af6282014-06-04 18:53:25 +00005715 if include and include.group(1) in ('cfenv',
5716 'condition_variable',
5717 'fenv.h',
5718 'future',
5719 'mutex',
5720 'thread',
5721 'chrono',
5722 'ratio',
5723 'regex',
5724 'system_error',
5725 ):
5726 error(filename, linenum, 'build/c++11', 5,
5727 ('<%s> is an unapproved C++11 header.') % include.group(1))
5728
5729 # The only place where we need to worry about C++11 keywords and library
5730 # features in preprocessor directives is in macro definitions.
5731 if Match(r'\s*#', line) and not Match(r'\s*#\s*define\b', line): return
5732
5733 # These are classes and free functions. The classes are always
5734 # mentioned as std::*, but we only catch the free functions if
5735 # they're not found by ADL. They're alphabetical by header.
5736 for top_name in (
5737 # type_traits
5738 'alignment_of',
5739 'aligned_union',
avakulenko@google.com02af6282014-06-04 18:53:25 +00005740 ):
5741 if Search(r'\bstd::%s\b' % top_name, line):
5742 error(filename, linenum, 'build/c++11', 5,
5743 ('std::%s is an unapproved C++11 class or function. Send c-style '
5744 'an example of where it would make your code more readable, and '
5745 'they may let you use it.') % top_name)
5746
5747
Alex Vakulenko01e47232016-05-06 13:54:15 -07005748def FlagCxx14Features(filename, clean_lines, linenum, error):
5749 """Flag those C++14 features that we restrict.
5750
5751 Args:
5752 filename: The name of the current file.
5753 clean_lines: A CleansedLines instance containing the file.
5754 linenum: The number of the line to check.
5755 error: The function to call with any errors found.
5756 """
5757 line = clean_lines.elided[linenum]
5758
5759 include = Match(r'\s*#\s*include\s+[<"]([^<"]+)[">]', line)
5760
5761 # Flag unapproved C++14 headers.
5762 if include and include.group(1) in ('scoped_allocator', 'shared_mutex'):
5763 error(filename, linenum, 'build/c++14', 5,
5764 ('<%s> is an unapproved C++14 header.') % include.group(1))
5765
5766
avakulenko@google.com4b957b22014-06-04 22:48:14 +00005767def ProcessFileData(filename, file_extension, lines, error,
5768 extra_check_functions=[]):
erg@google.com4e00b9a2009-01-12 23:05:11 +00005769 """Performs lint checks and reports any errors to the given error function.
5770
5771 Args:
5772 filename: Filename of the file that is being processed.
5773 file_extension: The extension (dot not included) of the file.
5774 lines: An array of strings, each representing a line of the file, with the
erg@google.com8a95ecc2011-09-08 00:45:54 +00005775 last element being empty if the file is terminated with a newline.
erg@google.com4e00b9a2009-01-12 23:05:11 +00005776 error: A callable to which errors are reported, which takes 4 arguments:
avakulenko@google.com4b957b22014-06-04 22:48:14 +00005777 filename, line number, error level, and message
5778 extra_check_functions: An array of additional check functions that will be
5779 run on each source line. Each function takes 4
5780 arguments: filename, clean_lines, line, error
erg@google.com4e00b9a2009-01-12 23:05:11 +00005781 """
5782 lines = (['// marker so line numbers and indices both start at 1'] + lines +
5783 ['// marker so line numbers end in a known way'])
5784
5785 include_state = _IncludeState()
5786 function_state = _FunctionState()
avakulenko@google.com02af6282014-06-04 18:53:25 +00005787 nesting_state = NestingState()
erg@google.com4e00b9a2009-01-12 23:05:11 +00005788
erg+personal@google.com05189642010-04-30 20:43:03 +00005789 ResetNolintSuppressions()
5790
erg@google.com4e00b9a2009-01-12 23:05:11 +00005791 CheckForCopyright(filename, lines, error)
Alex Vakulenko01e47232016-05-06 13:54:15 -07005792 ProcessGlobalSuppresions(lines)
erg@google.com4e00b9a2009-01-12 23:05:11 +00005793 RemoveMultiLineComments(filename, lines, error)
5794 clean_lines = CleansedLines(lines)
avakulenko@google.com554223d2014-12-04 22:00:20 +00005795
5796 if file_extension == 'h':
5797 CheckForHeaderGuard(filename, clean_lines, error)
5798
erg@google.com4e00b9a2009-01-12 23:05:11 +00005799 for line in xrange(clean_lines.NumLines()):
5800 ProcessLine(filename, file_extension, clean_lines, line,
avakulenko@google.com4b957b22014-06-04 22:48:14 +00005801 include_state, function_state, nesting_state, error,
5802 extra_check_functions)
avakulenko@google.com02af6282014-06-04 18:53:25 +00005803 FlagCxx11Features(filename, clean_lines, line, error)
erg@google.com2aa59982013-10-28 19:09:25 +00005804 nesting_state.CheckCompletedBlocks(filename, error)
erg@google.com4e00b9a2009-01-12 23:05:11 +00005805
5806 CheckForIncludeWhatYouUse(filename, clean_lines, include_state, error)
Alex Vakulenko01e47232016-05-06 13:54:15 -07005807
avakulenko@google.com554223d2014-12-04 22:00:20 +00005808 # Check that the .cc file has included its header if it exists.
Alex Vakulenko01e47232016-05-06 13:54:15 -07005809 if _IsSourceExtension(file_extension):
avakulenko@google.com554223d2014-12-04 22:00:20 +00005810 CheckHeaderFileIncluded(filename, include_state, error)
erg@google.com4e00b9a2009-01-12 23:05:11 +00005811
5812 # We check here rather than inside ProcessLine so that we see raw
5813 # lines rather than "cleaned" lines.
erg@google.com2aa59982013-10-28 19:09:25 +00005814 CheckForBadCharacters(filename, lines, error)
erg@google.com4e00b9a2009-01-12 23:05:11 +00005815
5816 CheckForNewlineAtEOF(filename, lines, error)
5817
erg@google.com7430eef2014-07-28 22:33:46 +00005818def ProcessConfigOverrides(filename):
5819 """ Loads the configuration files and processes the config overrides.
5820
5821 Args:
5822 filename: The name of the file being processed by the linter.
5823
5824 Returns:
5825 False if the current |filename| should not be processed further.
5826 """
5827
5828 abs_filename = os.path.abspath(filename)
5829 cfg_filters = []
5830 keep_looking = True
5831 while keep_looking:
5832 abs_path, base_name = os.path.split(abs_filename)
5833 if not base_name:
5834 break # Reached the root directory.
5835
5836 cfg_file = os.path.join(abs_path, "CPPLINT.cfg")
5837 abs_filename = abs_path
5838 if not os.path.isfile(cfg_file):
5839 continue
5840
5841 try:
5842 with open(cfg_file) as file_handle:
5843 for line in file_handle:
5844 line, _, _ = line.partition('#') # Remove comments.
5845 if not line.strip():
5846 continue
5847
5848 name, _, val = line.partition('=')
5849 name = name.strip()
5850 val = val.strip()
5851 if name == 'set noparent':
5852 keep_looking = False
5853 elif name == 'filter':
5854 cfg_filters.append(val)
5855 elif name == 'exclude_files':
5856 # When matching exclude_files pattern, use the base_name of
5857 # the current file name or the directory name we are processing.
5858 # For example, if we are checking for lint errors in /foo/bar/baz.cc
5859 # and we found the .cfg file at /foo/CPPLINT.cfg, then the config
5860 # file's "exclude_files" filter is meant to be checked against "bar"
5861 # and not "baz" nor "bar/baz.cc".
5862 if base_name:
5863 pattern = re.compile(val)
5864 if pattern.match(base_name):
5865 sys.stderr.write('Ignoring "%s": file excluded by "%s". '
5866 'File path component "%s" matches '
5867 'pattern "%s"\n' %
5868 (filename, cfg_file, base_name, val))
5869 return False
avakulenko@google.com310681b2014-08-22 19:38:55 +00005870 elif name == 'linelength':
5871 global _line_length
5872 try:
5873 _line_length = int(val)
5874 except ValueError:
5875 sys.stderr.write('Line length must be numeric.')
erg@google.com7430eef2014-07-28 22:33:46 +00005876 else:
5877 sys.stderr.write(
5878 'Invalid configuration option (%s) in file %s\n' %
5879 (name, cfg_file))
5880
5881 except IOError:
5882 sys.stderr.write(
5883 "Skipping config file '%s': Can't open for reading\n" % cfg_file)
5884 keep_looking = False
5885
5886 # Apply all the accumulated filters in reverse order (top-level directory
5887 # config options having the least priority).
5888 for filter in reversed(cfg_filters):
5889 _AddFilters(filter)
5890
5891 return True
5892
avakulenko@google.com02af6282014-06-04 18:53:25 +00005893
avakulenko@google.com4b957b22014-06-04 22:48:14 +00005894def ProcessFile(filename, vlevel, extra_check_functions=[]):
erg@google.com4e00b9a2009-01-12 23:05:11 +00005895 """Does google-lint on a single file.
5896
5897 Args:
5898 filename: The name of the file to parse.
5899
5900 vlevel: The level of errors to report. Every error of confidence
5901 >= verbose_level will be reported. 0 is a good default.
avakulenko@google.com4b957b22014-06-04 22:48:14 +00005902
5903 extra_check_functions: An array of additional check functions that will be
5904 run on each source line. Each function takes 4
5905 arguments: filename, clean_lines, line, error
erg@google.com4e00b9a2009-01-12 23:05:11 +00005906 """
5907
5908 _SetVerboseLevel(vlevel)
erg@google.com7430eef2014-07-28 22:33:46 +00005909 _BackupFilters()
5910
5911 if not ProcessConfigOverrides(filename):
5912 _RestoreFilters()
5913 return
erg@google.com4e00b9a2009-01-12 23:05:11 +00005914
avakulenko@google.com02af6282014-06-04 18:53:25 +00005915 lf_lines = []
5916 crlf_lines = []
erg@google.com4e00b9a2009-01-12 23:05:11 +00005917 try:
5918 # Support the UNIX convention of using "-" for stdin. Note that
5919 # we are not opening the file with universal newline support
5920 # (which codecs doesn't support anyway), so the resulting lines do
5921 # contain trailing '\r' characters if we are reading a file that
5922 # has CRLF endings.
5923 # If after the split a trailing '\r' is present, it is removed
avakulenko@google.com02af6282014-06-04 18:53:25 +00005924 # below.
erg@google.com4e00b9a2009-01-12 23:05:11 +00005925 if filename == '-':
5926 lines = codecs.StreamReaderWriter(sys.stdin,
5927 codecs.getreader('utf8'),
5928 codecs.getwriter('utf8'),
5929 'replace').read().split('\n')
5930 else:
5931 lines = codecs.open(filename, 'r', 'utf8', 'replace').read().split('\n')
5932
erg@google.com4e00b9a2009-01-12 23:05:11 +00005933 # Remove trailing '\r'.
avakulenko@google.com02af6282014-06-04 18:53:25 +00005934 # The -1 accounts for the extra trailing blank line we get from split()
5935 for linenum in range(len(lines) - 1):
erg@google.com4e00b9a2009-01-12 23:05:11 +00005936 if lines[linenum].endswith('\r'):
5937 lines[linenum] = lines[linenum].rstrip('\r')
avakulenko@google.com02af6282014-06-04 18:53:25 +00005938 crlf_lines.append(linenum + 1)
5939 else:
5940 lf_lines.append(linenum + 1)
erg@google.com4e00b9a2009-01-12 23:05:11 +00005941
5942 except IOError:
5943 sys.stderr.write(
5944 "Skipping input '%s': Can't open for reading\n" % filename)
erg@google.com7430eef2014-07-28 22:33:46 +00005945 _RestoreFilters()
erg@google.com4e00b9a2009-01-12 23:05:11 +00005946 return
5947
5948 # Note, if no dot is found, this will give the entire filename as the ext.
5949 file_extension = filename[filename.rfind('.') + 1:]
5950
5951 # When reading from stdin, the extension is unknown, so no cpplint tests
5952 # should rely on the extension.
erg@google.com19680272013-12-16 22:48:54 +00005953 if filename != '-' and file_extension not in _valid_extensions:
erg@google.com2aa59982013-10-28 19:09:25 +00005954 sys.stderr.write('Ignoring %s; not a valid file name '
erg@google.com19680272013-12-16 22:48:54 +00005955 '(%s)\n' % (filename, ', '.join(_valid_extensions)))
erg@google.com4e00b9a2009-01-12 23:05:11 +00005956 else:
avakulenko@google.com4b957b22014-06-04 22:48:14 +00005957 ProcessFileData(filename, file_extension, lines, Error,
5958 extra_check_functions)
avakulenko@google.com02af6282014-06-04 18:53:25 +00005959
5960 # If end-of-line sequences are a mix of LF and CR-LF, issue
5961 # warnings on the lines with CR.
5962 #
5963 # Don't issue any warnings if all lines are uniformly LF or CR-LF,
5964 # since critique can handle these just fine, and the style guide
5965 # doesn't dictate a particular end of line sequence.
5966 #
5967 # We can't depend on os.linesep to determine what the desired
5968 # end-of-line sequence should be, since that will return the
5969 # server-side end-of-line sequence.
5970 if lf_lines and crlf_lines:
5971 # Warn on every line with CR. An alternative approach might be to
5972 # check whether the file is mostly CRLF or just LF, and warn on the
5973 # minority, we bias toward LF here since most tools prefer LF.
5974 for linenum in crlf_lines:
5975 Error(filename, linenum, 'whitespace/newline', 1,
5976 'Unexpected \\r (^M) found; better to use only \\n')
erg@google.com4e00b9a2009-01-12 23:05:11 +00005977
5978 sys.stderr.write('Done processing %s\n' % filename)
erg@google.com7430eef2014-07-28 22:33:46 +00005979 _RestoreFilters()
erg@google.com4e00b9a2009-01-12 23:05:11 +00005980
5981
5982def PrintUsage(message):
5983 """Prints a brief usage string and exits, optionally with an error message.
5984
5985 Args:
5986 message: The optional error message.
5987 """
5988 sys.stderr.write(_USAGE)
5989 if message:
5990 sys.exit('\nFATAL ERROR: ' + message)
5991 else:
5992 sys.exit(1)
5993
5994
5995def PrintCategories():
5996 """Prints a list of all the error-categories used by error messages.
5997
5998 These are the categories used to filter messages via --filter.
5999 """
erg+personal@google.com05189642010-04-30 20:43:03 +00006000 sys.stderr.write(''.join(' %s\n' % cat for cat in _ERROR_CATEGORIES))
erg@google.com4e00b9a2009-01-12 23:05:11 +00006001 sys.exit(0)
6002
6003
6004def ParseArguments(args):
6005 """Parses the command line arguments.
6006
6007 This may set the output format and verbosity level as side-effects.
6008
6009 Args:
6010 args: The command line arguments:
6011
6012 Returns:
6013 The list of filenames to lint.
6014 """
6015 try:
6016 (opts, filenames) = getopt.getopt(args, '', ['help', 'output=', 'verbose=',
erg@google.coma868d2d2009-10-09 21:18:45 +00006017 'counting=',
erg@google.com4d70a882013-04-16 21:06:32 +00006018 'filter=',
erg@google.comab53edf2013-11-05 22:23:37 +00006019 'root=',
erg@google.com19680272013-12-16 22:48:54 +00006020 'linelength=',
6021 'extensions='])
erg@google.com4e00b9a2009-01-12 23:05:11 +00006022 except getopt.GetoptError:
6023 PrintUsage('Invalid arguments.')
6024
6025 verbosity = _VerboseLevel()
6026 output_format = _OutputFormat()
6027 filters = ''
erg@google.coma868d2d2009-10-09 21:18:45 +00006028 counting_style = ''
erg@google.com4e00b9a2009-01-12 23:05:11 +00006029
6030 for (opt, val) in opts:
6031 if opt == '--help':
6032 PrintUsage(None)
6033 elif opt == '--output':
erg@google.comc6671232013-10-25 21:44:03 +00006034 if val not in ('emacs', 'vs7', 'eclipse'):
erg@google.com02c27fd2013-05-28 21:34:34 +00006035 PrintUsage('The only allowed output formats are emacs, vs7 and eclipse.')
erg@google.com4e00b9a2009-01-12 23:05:11 +00006036 output_format = val
6037 elif opt == '--verbose':
6038 verbosity = int(val)
6039 elif opt == '--filter':
6040 filters = val
erg@google.coma87abb82009-02-24 01:41:01 +00006041 if not filters:
erg@google.com4e00b9a2009-01-12 23:05:11 +00006042 PrintCategories()
erg@google.coma868d2d2009-10-09 21:18:45 +00006043 elif opt == '--counting':
6044 if val not in ('total', 'toplevel', 'detailed'):
6045 PrintUsage('Valid counting options are total, toplevel, and detailed')
6046 counting_style = val
erg@google.com4d70a882013-04-16 21:06:32 +00006047 elif opt == '--root':
6048 global _root
6049 _root = val
erg@google.comab53edf2013-11-05 22:23:37 +00006050 elif opt == '--linelength':
6051 global _line_length
6052 try:
6053 _line_length = int(val)
6054 except ValueError:
6055 PrintUsage('Line length must be digits.')
erg@google.com19680272013-12-16 22:48:54 +00006056 elif opt == '--extensions':
6057 global _valid_extensions
6058 try:
6059 _valid_extensions = set(val.split(','))
6060 except ValueError:
6061 PrintUsage('Extensions must be comma seperated list.')
erg@google.com4e00b9a2009-01-12 23:05:11 +00006062
6063 if not filenames:
6064 PrintUsage('No files were specified.')
6065
6066 _SetOutputFormat(output_format)
6067 _SetVerboseLevel(verbosity)
6068 _SetFilters(filters)
erg@google.coma868d2d2009-10-09 21:18:45 +00006069 _SetCountingStyle(counting_style)
erg@google.com4e00b9a2009-01-12 23:05:11 +00006070
6071 return filenames
6072
6073
6074def main():
6075 filenames = ParseArguments(sys.argv[1:])
6076
6077 # Change stderr to write with replacement characters so we don't die
6078 # if we try to print something containing non-ASCII characters.
6079 sys.stderr = codecs.StreamReaderWriter(sys.stderr,
6080 codecs.getreader('utf8'),
6081 codecs.getwriter('utf8'),
6082 'replace')
6083
erg@google.coma868d2d2009-10-09 21:18:45 +00006084 _cpplint_state.ResetErrorCounts()
erg@google.com4e00b9a2009-01-12 23:05:11 +00006085 for filename in filenames:
6086 ProcessFile(filename, _cpplint_state.verbose_level)
erg@google.coma868d2d2009-10-09 21:18:45 +00006087 _cpplint_state.PrintErrorCounts()
6088
erg@google.com4e00b9a2009-01-12 23:05:11 +00006089 sys.exit(_cpplint_state.error_count > 0)
6090
6091
6092if __name__ == '__main__':
6093 main()