| commit | 10f305d9d4328edd2819396dcbf039e86e8e24b1 | [log] [tgz] |
|---|---|---|
| author | Sam Berlin <sameb@google.com> | Mon Mar 10 12:51:17 2014 -0400 |
| committer | Sam Berlin <sameb@google.com> | Mon Mar 10 14:01:52 2014 -0400 |
| tree | 9ff64e5f25c70668d42a2d40737949984ba8d35c | |
| parent | c33e73ccd3ca611c26ba823b8fa73fe116dcc926 [diff] |
This change removes final from fields annotated with @Inject. In addition to being discouraged due to weak semantics [1], it is incompatible with the standard javax.inject.Inject annotation [2]. Refactoring: https://code.google.com/p/error-prone/wiki/GuiceInjectOnFinalField [1] https://code.google.com/p/google-guice/wiki/Injections#Field_Injection [2] https://code.google.com/p/google-guice/wiki/JSR330 ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=62760764
diff --git a/extensions/persist/src/com/google/inject/persist/jpa/JpaLocalTxnInterceptor.java b/extensions/persist/src/com/google/inject/persist/jpa/JpaLocalTxnInterceptor.java index 942835f..1f59a6d 100644 --- a/extensions/persist/src/com/google/inject/persist/jpa/JpaLocalTxnInterceptor.java +++ b/extensions/persist/src/com/google/inject/persist/jpa/JpaLocalTxnInterceptor.java
@@ -33,11 +33,12 @@ */ class JpaLocalTxnInterceptor implements MethodInterceptor { + // TODO(gak): Move these args to the cxtor & make these final. @Inject - private final JpaPersistService emProvider = null; + private JpaPersistService emProvider = null; @Inject - private final UnitOfWork unitOfWork = null; + private UnitOfWork unitOfWork = null; @Transactional private static class Internal {}