joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 1 | // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
tfarina@chromium.org | fe046b5 | 2012-11-28 04:09:17 +0900 | [diff] [blame] | 5 | #include "base/prefs/json_pref_store.h" |
| 6 | |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 7 | #include "base/file_util.h" |
brettw@chromium.org | 091db52 | 2012-11-17 05:34:23 +0900 | [diff] [blame] | 8 | #include "base/files/scoped_temp_dir.h" |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 9 | #include "base/memory/ref_counted.h" |
| 10 | #include "base/memory/scoped_ptr.h" |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 11 | #include "base/path_service.h" |
tfarina@chromium.org | e9e11f5 | 2013-02-05 17:14:15 +0900 | [diff] [blame] | 12 | #include "base/run_loop.h" |
brettw@chromium.org | abcde5c | 2013-02-07 11:57:22 +0900 | [diff] [blame] | 13 | #include "base/strings/string_number_conversions.h" |
avi@chromium.org | 67d593d | 2013-06-11 04:06:57 +0900 | [diff] [blame] | 14 | #include "base/strings/string_util.h" |
avi@chromium.org | 17f6062 | 2013-06-08 03:37:07 +0900 | [diff] [blame] | 15 | #include "base/strings/utf_string_conversions.h" |
zelidrag@chromium.org | 011ad40 | 2012-11-08 13:40:59 +0900 | [diff] [blame] | 16 | #include "base/threading/sequenced_worker_pool.h" |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 17 | #include "base/threading/thread.h" |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 18 | #include "base/values.h" |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 19 | #include "testing/gmock/include/gmock/gmock.h" |
| 20 | #include "testing/gtest/include/gtest/gtest.h" |
| 21 | |
tfarina@chromium.org | 50be576 | 2012-12-16 14:13:21 +0900 | [diff] [blame] | 22 | namespace base { |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 23 | namespace { |
| 24 | |
tfarina@chromium.org | ad1d8ce | 2012-11-23 07:08:24 +0900 | [diff] [blame] | 25 | const char kHomePage[] = "homepage"; |
| 26 | |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 27 | class MockPrefStoreObserver : public PrefStore::Observer { |
| 28 | public: |
| 29 | MOCK_METHOD1(OnPrefValueChanged, void (const std::string&)); |
| 30 | MOCK_METHOD1(OnInitializationCompleted, void (bool)); |
| 31 | }; |
| 32 | |
| 33 | class MockReadErrorDelegate : public PersistentPrefStore::ReadErrorDelegate { |
| 34 | public: |
| 35 | MOCK_METHOD1(OnError, void(PersistentPrefStore::PrefReadError)); |
| 36 | }; |
| 37 | |
| 38 | } // namespace |
| 39 | |
| 40 | class JsonPrefStoreTest : public testing::Test { |
| 41 | protected: |
zelidrag@chromium.org | 011ad40 | 2012-11-08 13:40:59 +0900 | [diff] [blame] | 42 | virtual void SetUp() OVERRIDE { |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 43 | ASSERT_TRUE(temp_dir_.CreateUniqueTempDir()); |
| 44 | |
tfarina@chromium.org | d05540d | 2013-04-08 01:27:46 +0900 | [diff] [blame] | 45 | ASSERT_TRUE(PathService::Get(base::DIR_TEST_DATA, &data_dir_)); |
tfarina@chromium.org | fe046b5 | 2012-11-28 04:09:17 +0900 | [diff] [blame] | 46 | data_dir_ = data_dir_.AppendASCII("prefs"); |
brettw@chromium.org | 10b6412 | 2013-07-12 02:36:07 +0900 | [diff] [blame^] | 47 | ASSERT_TRUE(PathExists(data_dir_)); |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 48 | } |
| 49 | |
| 50 | // The path to temporary directory used to contain the test operations. |
brettw@chromium.org | 091db52 | 2012-11-17 05:34:23 +0900 | [diff] [blame] | 51 | base::ScopedTempDir temp_dir_; |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 52 | // The path to the directory where the test data is stored. |
brettw@chromium.org | 82bcf51 | 2013-02-17 14:07:23 +0900 | [diff] [blame] | 53 | base::FilePath data_dir_; |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 54 | // A message loop that we can use as the file thread message loop. |
| 55 | MessageLoop message_loop_; |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 56 | }; |
| 57 | |
| 58 | // Test fallback behavior for a nonexistent file. |
| 59 | TEST_F(JsonPrefStoreTest, NonExistentFile) { |
brettw@chromium.org | 82bcf51 | 2013-02-17 14:07:23 +0900 | [diff] [blame] | 60 | base::FilePath bogus_input_file = data_dir_.AppendASCII("read.txt"); |
brettw@chromium.org | 10b6412 | 2013-07-12 02:36:07 +0900 | [diff] [blame^] | 61 | ASSERT_FALSE(PathExists(bogus_input_file)); |
rsleevi@chromium.org | 64293f1 | 2013-06-12 01:46:36 +0900 | [diff] [blame] | 62 | scoped_refptr<JsonPrefStore> pref_store = new JsonPrefStore( |
| 63 | bogus_input_file, message_loop_.message_loop_proxy().get()); |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 64 | EXPECT_EQ(PersistentPrefStore::PREF_READ_ERROR_NO_FILE, |
| 65 | pref_store->ReadPrefs()); |
| 66 | EXPECT_FALSE(pref_store->ReadOnly()); |
| 67 | } |
| 68 | |
| 69 | // Test fallback behavior for an invalid file. |
| 70 | TEST_F(JsonPrefStoreTest, InvalidFile) { |
brettw@chromium.org | 82bcf51 | 2013-02-17 14:07:23 +0900 | [diff] [blame] | 71 | base::FilePath invalid_file_original = data_dir_.AppendASCII("invalid.json"); |
| 72 | base::FilePath invalid_file = temp_dir_.path().AppendASCII("invalid.json"); |
brettw@chromium.org | aecf7a3 | 2013-07-10 02:42:26 +0900 | [diff] [blame] | 73 | ASSERT_TRUE(base::CopyFile(invalid_file_original, invalid_file)); |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 74 | scoped_refptr<JsonPrefStore> pref_store = |
rsleevi@chromium.org | 64293f1 | 2013-06-12 01:46:36 +0900 | [diff] [blame] | 75 | new JsonPrefStore(invalid_file, message_loop_.message_loop_proxy().get()); |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 76 | EXPECT_EQ(PersistentPrefStore::PREF_READ_ERROR_JSON_PARSE, |
| 77 | pref_store->ReadPrefs()); |
| 78 | EXPECT_FALSE(pref_store->ReadOnly()); |
| 79 | |
| 80 | // The file should have been moved aside. |
brettw@chromium.org | 10b6412 | 2013-07-12 02:36:07 +0900 | [diff] [blame^] | 81 | EXPECT_FALSE(PathExists(invalid_file)); |
brettw@chromium.org | 82bcf51 | 2013-02-17 14:07:23 +0900 | [diff] [blame] | 82 | base::FilePath moved_aside = temp_dir_.path().AppendASCII("invalid.bad"); |
brettw@chromium.org | 10b6412 | 2013-07-12 02:36:07 +0900 | [diff] [blame^] | 83 | EXPECT_TRUE(PathExists(moved_aside)); |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 84 | EXPECT_TRUE(file_util::TextContentsEqual(invalid_file_original, |
| 85 | moved_aside)); |
| 86 | } |
| 87 | |
| 88 | // This function is used to avoid code duplication while testing synchronous and |
| 89 | // asynchronous version of the JsonPrefStore loading. |
zelidrag@chromium.org | 011ad40 | 2012-11-08 13:40:59 +0900 | [diff] [blame] | 90 | void RunBasicJsonPrefStoreTest(JsonPrefStore* pref_store, |
brettw@chromium.org | 82bcf51 | 2013-02-17 14:07:23 +0900 | [diff] [blame] | 91 | const base::FilePath& output_file, |
| 92 | const base::FilePath& golden_output_file) { |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 93 | const char kNewWindowsInTabs[] = "tabs.new_windows_in_tabs"; |
| 94 | const char kMaxTabs[] = "tabs.max_tabs"; |
| 95 | const char kLongIntPref[] = "long_int.pref"; |
| 96 | |
| 97 | std::string cnn("http://www.cnn.com"); |
| 98 | |
| 99 | const Value* actual; |
tfarina@chromium.org | ad1d8ce | 2012-11-23 07:08:24 +0900 | [diff] [blame] | 100 | EXPECT_TRUE(pref_store->GetValue(kHomePage, &actual)); |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 101 | std::string string_value; |
| 102 | EXPECT_TRUE(actual->GetAsString(&string_value)); |
| 103 | EXPECT_EQ(cnn, string_value); |
| 104 | |
| 105 | const char kSomeDirectory[] = "some_directory"; |
| 106 | |
bauerb@chromium.org | 17fcbc8 | 2012-11-09 03:24:34 +0900 | [diff] [blame] | 107 | EXPECT_TRUE(pref_store->GetValue(kSomeDirectory, &actual)); |
brettw@chromium.org | 82bcf51 | 2013-02-17 14:07:23 +0900 | [diff] [blame] | 108 | base::FilePath::StringType path; |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 109 | EXPECT_TRUE(actual->GetAsString(&path)); |
brettw@chromium.org | 82bcf51 | 2013-02-17 14:07:23 +0900 | [diff] [blame] | 110 | EXPECT_EQ(base::FilePath::StringType(FILE_PATH_LITERAL("/usr/local/")), path); |
| 111 | base::FilePath some_path(FILE_PATH_LITERAL("/usr/sbin/")); |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 112 | |
tfarina@chromium.org | 50be576 | 2012-12-16 14:13:21 +0900 | [diff] [blame] | 113 | pref_store->SetValue(kSomeDirectory, new StringValue(some_path.value())); |
bauerb@chromium.org | 17fcbc8 | 2012-11-09 03:24:34 +0900 | [diff] [blame] | 114 | EXPECT_TRUE(pref_store->GetValue(kSomeDirectory, &actual)); |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 115 | EXPECT_TRUE(actual->GetAsString(&path)); |
| 116 | EXPECT_EQ(some_path.value(), path); |
| 117 | |
| 118 | // Test reading some other data types from sub-dictionaries. |
bauerb@chromium.org | 17fcbc8 | 2012-11-09 03:24:34 +0900 | [diff] [blame] | 119 | EXPECT_TRUE(pref_store->GetValue(kNewWindowsInTabs, &actual)); |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 120 | bool boolean = false; |
| 121 | EXPECT_TRUE(actual->GetAsBoolean(&boolean)); |
| 122 | EXPECT_TRUE(boolean); |
| 123 | |
tfarina@chromium.org | 50be576 | 2012-12-16 14:13:21 +0900 | [diff] [blame] | 124 | pref_store->SetValue(kNewWindowsInTabs, new FundamentalValue(false)); |
bauerb@chromium.org | 17fcbc8 | 2012-11-09 03:24:34 +0900 | [diff] [blame] | 125 | EXPECT_TRUE(pref_store->GetValue(kNewWindowsInTabs, &actual)); |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 126 | EXPECT_TRUE(actual->GetAsBoolean(&boolean)); |
| 127 | EXPECT_FALSE(boolean); |
| 128 | |
bauerb@chromium.org | 17fcbc8 | 2012-11-09 03:24:34 +0900 | [diff] [blame] | 129 | EXPECT_TRUE(pref_store->GetValue(kMaxTabs, &actual)); |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 130 | int integer = 0; |
| 131 | EXPECT_TRUE(actual->GetAsInteger(&integer)); |
| 132 | EXPECT_EQ(20, integer); |
tfarina@chromium.org | 50be576 | 2012-12-16 14:13:21 +0900 | [diff] [blame] | 133 | pref_store->SetValue(kMaxTabs, new FundamentalValue(10)); |
bauerb@chromium.org | 17fcbc8 | 2012-11-09 03:24:34 +0900 | [diff] [blame] | 134 | EXPECT_TRUE(pref_store->GetValue(kMaxTabs, &actual)); |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 135 | EXPECT_TRUE(actual->GetAsInteger(&integer)); |
| 136 | EXPECT_EQ(10, integer); |
| 137 | |
| 138 | pref_store->SetValue(kLongIntPref, |
tfarina@chromium.org | 50be576 | 2012-12-16 14:13:21 +0900 | [diff] [blame] | 139 | new StringValue(base::Int64ToString(214748364842LL))); |
bauerb@chromium.org | 17fcbc8 | 2012-11-09 03:24:34 +0900 | [diff] [blame] | 140 | EXPECT_TRUE(pref_store->GetValue(kLongIntPref, &actual)); |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 141 | EXPECT_TRUE(actual->GetAsString(&string_value)); |
| 142 | int64 value; |
| 143 | base::StringToInt64(string_value, &value); |
| 144 | EXPECT_EQ(214748364842LL, value); |
| 145 | |
| 146 | // Serialize and compare to expected output. |
brettw@chromium.org | 10b6412 | 2013-07-12 02:36:07 +0900 | [diff] [blame^] | 147 | ASSERT_TRUE(PathExists(golden_output_file)); |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 148 | pref_store->CommitPendingWrite(); |
tfarina@chromium.org | e9e11f5 | 2013-02-05 17:14:15 +0900 | [diff] [blame] | 149 | RunLoop().RunUntilIdle(); |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 150 | EXPECT_TRUE(file_util::TextContentsEqual(golden_output_file, output_file)); |
brettw@chromium.org | e9f9948 | 2013-07-02 04:41:02 +0900 | [diff] [blame] | 151 | ASSERT_TRUE(base::Delete(output_file, false)); |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 152 | } |
| 153 | |
| 154 | TEST_F(JsonPrefStoreTest, Basic) { |
brettw@chromium.org | aecf7a3 | 2013-07-10 02:42:26 +0900 | [diff] [blame] | 155 | ASSERT_TRUE(base::CopyFile(data_dir_.AppendASCII("read.json"), |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 156 | temp_dir_.path().AppendASCII("write.json"))); |
| 157 | |
| 158 | // Test that the persistent value can be loaded. |
brettw@chromium.org | 82bcf51 | 2013-02-17 14:07:23 +0900 | [diff] [blame] | 159 | base::FilePath input_file = temp_dir_.path().AppendASCII("write.json"); |
brettw@chromium.org | 10b6412 | 2013-07-12 02:36:07 +0900 | [diff] [blame^] | 160 | ASSERT_TRUE(PathExists(input_file)); |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 161 | scoped_refptr<JsonPrefStore> pref_store = |
rsleevi@chromium.org | 64293f1 | 2013-06-12 01:46:36 +0900 | [diff] [blame] | 162 | new JsonPrefStore(input_file, message_loop_.message_loop_proxy().get()); |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 163 | ASSERT_EQ(PersistentPrefStore::PREF_READ_ERROR_NONE, pref_store->ReadPrefs()); |
| 164 | ASSERT_FALSE(pref_store->ReadOnly()); |
| 165 | |
| 166 | // The JSON file looks like this: |
| 167 | // { |
| 168 | // "homepage": "http://www.cnn.com", |
| 169 | // "some_directory": "/usr/local/", |
| 170 | // "tabs": { |
| 171 | // "new_windows_in_tabs": true, |
| 172 | // "max_tabs": 20 |
| 173 | // } |
| 174 | // } |
| 175 | |
rsleevi@chromium.org | 7501b03 | 2013-06-01 06:37:53 +0900 | [diff] [blame] | 176 | RunBasicJsonPrefStoreTest( |
| 177 | pref_store.get(), input_file, data_dir_.AppendASCII("write.golden.json")); |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 178 | } |
| 179 | |
| 180 | TEST_F(JsonPrefStoreTest, BasicAsync) { |
brettw@chromium.org | aecf7a3 | 2013-07-10 02:42:26 +0900 | [diff] [blame] | 181 | ASSERT_TRUE(base::CopyFile(data_dir_.AppendASCII("read.json"), |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 182 | temp_dir_.path().AppendASCII("write.json"))); |
| 183 | |
| 184 | // Test that the persistent value can be loaded. |
brettw@chromium.org | 82bcf51 | 2013-02-17 14:07:23 +0900 | [diff] [blame] | 185 | base::FilePath input_file = temp_dir_.path().AppendASCII("write.json"); |
brettw@chromium.org | 10b6412 | 2013-07-12 02:36:07 +0900 | [diff] [blame^] | 186 | ASSERT_TRUE(PathExists(input_file)); |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 187 | scoped_refptr<JsonPrefStore> pref_store = |
rsleevi@chromium.org | 64293f1 | 2013-06-12 01:46:36 +0900 | [diff] [blame] | 188 | new JsonPrefStore(input_file, message_loop_.message_loop_proxy().get()); |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 189 | |
zelidrag@chromium.org | 011ad40 | 2012-11-08 13:40:59 +0900 | [diff] [blame] | 190 | { |
| 191 | MockPrefStoreObserver mock_observer; |
| 192 | pref_store->AddObserver(&mock_observer); |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 193 | |
zelidrag@chromium.org | 011ad40 | 2012-11-08 13:40:59 +0900 | [diff] [blame] | 194 | MockReadErrorDelegate* mock_error_delegate = new MockReadErrorDelegate; |
| 195 | pref_store->ReadPrefsAsync(mock_error_delegate); |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 196 | |
zelidrag@chromium.org | 011ad40 | 2012-11-08 13:40:59 +0900 | [diff] [blame] | 197 | EXPECT_CALL(mock_observer, OnInitializationCompleted(true)).Times(1); |
| 198 | EXPECT_CALL(*mock_error_delegate, |
| 199 | OnError(PersistentPrefStore::PREF_READ_ERROR_NONE)).Times(0); |
tfarina@chromium.org | 7d4a0ec | 2013-02-07 01:56:19 +0900 | [diff] [blame] | 200 | RunLoop().RunUntilIdle(); |
zelidrag@chromium.org | 011ad40 | 2012-11-08 13:40:59 +0900 | [diff] [blame] | 201 | pref_store->RemoveObserver(&mock_observer); |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 202 | |
zelidrag@chromium.org | 011ad40 | 2012-11-08 13:40:59 +0900 | [diff] [blame] | 203 | ASSERT_FALSE(pref_store->ReadOnly()); |
| 204 | } |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 205 | |
| 206 | // The JSON file looks like this: |
| 207 | // { |
| 208 | // "homepage": "http://www.cnn.com", |
| 209 | // "some_directory": "/usr/local/", |
| 210 | // "tabs": { |
| 211 | // "new_windows_in_tabs": true, |
| 212 | // "max_tabs": 20 |
| 213 | // } |
| 214 | // } |
| 215 | |
rsleevi@chromium.org | 7501b03 | 2013-06-01 06:37:53 +0900 | [diff] [blame] | 216 | RunBasicJsonPrefStoreTest( |
| 217 | pref_store.get(), input_file, data_dir_.AppendASCII("write.golden.json")); |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 218 | } |
| 219 | |
| 220 | // Tests asynchronous reading of the file when there is no file. |
| 221 | TEST_F(JsonPrefStoreTest, AsyncNonExistingFile) { |
brettw@chromium.org | 82bcf51 | 2013-02-17 14:07:23 +0900 | [diff] [blame] | 222 | base::FilePath bogus_input_file = data_dir_.AppendASCII("read.txt"); |
brettw@chromium.org | 10b6412 | 2013-07-12 02:36:07 +0900 | [diff] [blame^] | 223 | ASSERT_FALSE(PathExists(bogus_input_file)); |
rsleevi@chromium.org | 64293f1 | 2013-06-12 01:46:36 +0900 | [diff] [blame] | 224 | scoped_refptr<JsonPrefStore> pref_store = new JsonPrefStore( |
| 225 | bogus_input_file, message_loop_.message_loop_proxy().get()); |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 226 | MockPrefStoreObserver mock_observer; |
| 227 | pref_store->AddObserver(&mock_observer); |
| 228 | |
| 229 | MockReadErrorDelegate *mock_error_delegate = new MockReadErrorDelegate; |
| 230 | pref_store->ReadPrefsAsync(mock_error_delegate); |
| 231 | |
| 232 | EXPECT_CALL(mock_observer, OnInitializationCompleted(true)).Times(1); |
| 233 | EXPECT_CALL(*mock_error_delegate, |
| 234 | OnError(PersistentPrefStore::PREF_READ_ERROR_NO_FILE)).Times(1); |
tfarina@chromium.org | 7d4a0ec | 2013-02-07 01:56:19 +0900 | [diff] [blame] | 235 | RunLoop().RunUntilIdle(); |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 236 | pref_store->RemoveObserver(&mock_observer); |
| 237 | |
| 238 | EXPECT_FALSE(pref_store->ReadOnly()); |
| 239 | } |
| 240 | |
| 241 | TEST_F(JsonPrefStoreTest, NeedsEmptyValue) { |
brettw@chromium.org | 82bcf51 | 2013-02-17 14:07:23 +0900 | [diff] [blame] | 242 | base::FilePath pref_file = temp_dir_.path().AppendASCII("write.json"); |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 243 | |
brettw@chromium.org | aecf7a3 | 2013-07-10 02:42:26 +0900 | [diff] [blame] | 244 | ASSERT_TRUE(base::CopyFile( |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 245 | data_dir_.AppendASCII("read.need_empty_value.json"), |
| 246 | pref_file)); |
| 247 | |
| 248 | // Test that the persistent value can be loaded. |
brettw@chromium.org | 10b6412 | 2013-07-12 02:36:07 +0900 | [diff] [blame^] | 249 | ASSERT_TRUE(PathExists(pref_file)); |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 250 | scoped_refptr<JsonPrefStore> pref_store = |
rsleevi@chromium.org | 64293f1 | 2013-06-12 01:46:36 +0900 | [diff] [blame] | 251 | new JsonPrefStore(pref_file, message_loop_.message_loop_proxy().get()); |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 252 | ASSERT_EQ(PersistentPrefStore::PREF_READ_ERROR_NONE, pref_store->ReadPrefs()); |
| 253 | ASSERT_FALSE(pref_store->ReadOnly()); |
| 254 | |
| 255 | // The JSON file looks like this: |
| 256 | // { |
| 257 | // "list": [ 1 ], |
| 258 | // "list_needs_empty_value": [ 2 ], |
| 259 | // "dict": { |
| 260 | // "dummy": true, |
| 261 | // }, |
| 262 | // "dict_needs_empty_value": { |
| 263 | // "dummy": true, |
| 264 | // }, |
| 265 | // } |
| 266 | |
| 267 | // Set flag to preserve empty values for the following keys. |
| 268 | pref_store->MarkNeedsEmptyValue("list_needs_empty_value"); |
| 269 | pref_store->MarkNeedsEmptyValue("dict_needs_empty_value"); |
| 270 | |
| 271 | // Set all keys to empty values. |
| 272 | pref_store->SetValue("list", new base::ListValue); |
| 273 | pref_store->SetValue("list_needs_empty_value", new base::ListValue); |
| 274 | pref_store->SetValue("dict", new base::DictionaryValue); |
| 275 | pref_store->SetValue("dict_needs_empty_value", new base::DictionaryValue); |
| 276 | |
| 277 | // Write to file. |
| 278 | pref_store->CommitPendingWrite(); |
tfarina@chromium.org | e9e11f5 | 2013-02-05 17:14:15 +0900 | [diff] [blame] | 279 | RunLoop().RunUntilIdle(); |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 280 | |
| 281 | // Compare to expected output. |
brettw@chromium.org | 82bcf51 | 2013-02-17 14:07:23 +0900 | [diff] [blame] | 282 | base::FilePath golden_output_file = |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 283 | data_dir_.AppendASCII("write.golden.need_empty_value.json"); |
brettw@chromium.org | 10b6412 | 2013-07-12 02:36:07 +0900 | [diff] [blame^] | 284 | ASSERT_TRUE(PathExists(golden_output_file)); |
joi@chromium.org | 026cee4 | 2012-10-23 05:01:52 +0900 | [diff] [blame] | 285 | EXPECT_TRUE(file_util::TextContentsEqual(golden_output_file, pref_file)); |
| 286 | } |
tfarina@chromium.org | 50be576 | 2012-12-16 14:13:21 +0900 | [diff] [blame] | 287 | |
| 288 | } // namespace base |