robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 1 | // Copyright 2017 The Chromium Authors. All rights reserved. |
| 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
| 5 | #include "base/task_scheduler/scheduler_single_thread_task_runner_manager.h" |
| 6 | |
| 7 | #include "base/bind.h" |
Peter Kasting | 88430fa | 2018-02-13 15:22:40 +0900 | [diff] [blame] | 8 | #include "base/bind_helpers.h" |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 9 | #include "base/memory/ptr_util.h" |
fdoray | d952d8e | 2017-04-19 09:37:26 +0900 | [diff] [blame] | 10 | #include "base/synchronization/atomic_flag.h" |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 11 | #include "base/synchronization/lock.h" |
| 12 | #include "base/synchronization/waitable_event.h" |
| 13 | #include "base/task_scheduler/delayed_task_manager.h" |
| 14 | #include "base/task_scheduler/post_task.h" |
| 15 | #include "base/task_scheduler/scheduler_worker_pool_params.h" |
| 16 | #include "base/task_scheduler/task_tracker.h" |
| 17 | #include "base/task_scheduler/task_traits.h" |
robliao | 7d2bb1e | 2017-05-26 06:33:43 +0900 | [diff] [blame] | 18 | #include "base/test/gtest_util.h" |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 19 | #include "base/test/test_timeouts.h" |
fdoray | d952d8e | 2017-04-19 09:37:26 +0900 | [diff] [blame] | 20 | #include "base/threading/platform_thread.h" |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 21 | #include "base/threading/simple_thread.h" |
| 22 | #include "base/threading/thread.h" |
| 23 | #include "testing/gtest/include/gtest/gtest.h" |
| 24 | |
robliao | f81c000 | 2017-03-23 07:30:15 +0900 | [diff] [blame] | 25 | #if defined(OS_WIN) |
| 26 | #include <windows.h> |
robliao | f81c000 | 2017-03-23 07:30:15 +0900 | [diff] [blame] | 27 | |
Robert Liao | b01a997 | 2017-07-07 09:54:14 +0900 | [diff] [blame] | 28 | #include "base/win/com_init_util.h" |
robliao | f81c000 | 2017-03-23 07:30:15 +0900 | [diff] [blame] | 29 | #include "base/win/current_module.h" |
| 30 | #endif // defined(OS_WIN) |
| 31 | |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 32 | namespace base { |
| 33 | namespace internal { |
| 34 | |
| 35 | namespace { |
| 36 | |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 37 | class TaskSchedulerSingleThreadTaskRunnerManagerTest : public testing::Test { |
| 38 | public: |
| 39 | TaskSchedulerSingleThreadTaskRunnerManagerTest() |
| 40 | : service_thread_("TaskSchedulerServiceThread") {} |
| 41 | |
| 42 | void SetUp() override { |
| 43 | service_thread_.Start(); |
fdoray | 4a475d6 | 2017-04-20 22:13:11 +0900 | [diff] [blame] | 44 | delayed_task_manager_.Start(service_thread_.task_runner()); |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 45 | single_thread_task_runner_manager_ = |
Jeremy Roman | cd0c467 | 2017-08-17 08:27:24 +0900 | [diff] [blame] | 46 | std::make_unique<SchedulerSingleThreadTaskRunnerManager>( |
fdoray | 4a475d6 | 2017-04-20 22:13:11 +0900 | [diff] [blame] | 47 | &task_tracker_, &delayed_task_manager_); |
fdoray | d952d8e | 2017-04-19 09:37:26 +0900 | [diff] [blame] | 48 | StartSingleThreadTaskRunnerManagerFromSetUp(); |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 49 | } |
| 50 | |
| 51 | void TearDown() override { |
Gabriel Charette | c37bf44 | 2017-09-21 11:26:13 +0900 | [diff] [blame] | 52 | if (single_thread_task_runner_manager_) |
| 53 | TearDownSingleThreadTaskRunnerManager(); |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 54 | service_thread_.Stop(); |
| 55 | } |
| 56 | |
| 57 | protected: |
fdoray | d952d8e | 2017-04-19 09:37:26 +0900 | [diff] [blame] | 58 | virtual void StartSingleThreadTaskRunnerManagerFromSetUp() { |
| 59 | single_thread_task_runner_manager_->Start(); |
| 60 | } |
| 61 | |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 62 | virtual void TearDownSingleThreadTaskRunnerManager() { |
| 63 | single_thread_task_runner_manager_->JoinForTesting(); |
| 64 | single_thread_task_runner_manager_.reset(); |
| 65 | } |
| 66 | |
| 67 | std::unique_ptr<SchedulerSingleThreadTaskRunnerManager> |
| 68 | single_thread_task_runner_manager_; |
Gabriel Charette | 1907539 | 2018-01-19 20:00:53 +0900 | [diff] [blame] | 69 | TaskTracker task_tracker_ = {"Test"}; |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 70 | |
| 71 | private: |
| 72 | Thread service_thread_; |
fdoray | 4a475d6 | 2017-04-20 22:13:11 +0900 | [diff] [blame] | 73 | DelayedTaskManager delayed_task_manager_; |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 74 | |
| 75 | DISALLOW_COPY_AND_ASSIGN(TaskSchedulerSingleThreadTaskRunnerManagerTest); |
| 76 | }; |
| 77 | |
| 78 | void CaptureThreadRef(PlatformThreadRef* thread_ref) { |
| 79 | ASSERT_TRUE(thread_ref); |
| 80 | *thread_ref = PlatformThread::CurrentRef(); |
| 81 | } |
| 82 | |
| 83 | void CaptureThreadPriority(ThreadPriority* thread_priority) { |
| 84 | ASSERT_TRUE(thread_priority); |
| 85 | *thread_priority = PlatformThread::GetCurrentThreadPriority(); |
| 86 | } |
| 87 | |
robliao | 7d2bb1e | 2017-05-26 06:33:43 +0900 | [diff] [blame] | 88 | void CaptureThreadName(std::string* thread_name) { |
| 89 | *thread_name = PlatformThread::GetName(); |
| 90 | } |
| 91 | |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 92 | void ShouldNotRun() { |
| 93 | ADD_FAILURE() << "Ran a task that shouldn't run."; |
| 94 | } |
| 95 | |
| 96 | } // namespace |
| 97 | |
| 98 | TEST_F(TaskSchedulerSingleThreadTaskRunnerManagerTest, DifferentThreadsUsed) { |
| 99 | scoped_refptr<SingleThreadTaskRunner> task_runner_1 = |
| 100 | single_thread_task_runner_manager_ |
| 101 | ->CreateSingleThreadTaskRunnerWithTraits( |
Gabriel Charette | e164063 | 2018-01-19 01:56:31 +0900 | [diff] [blame] | 102 | {TaskShutdownBehavior::BLOCK_SHUTDOWN}, |
robliao | 7d2bb1e | 2017-05-26 06:33:43 +0900 | [diff] [blame] | 103 | SingleThreadTaskRunnerThreadMode::DEDICATED); |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 104 | scoped_refptr<SingleThreadTaskRunner> task_runner_2 = |
| 105 | single_thread_task_runner_manager_ |
| 106 | ->CreateSingleThreadTaskRunnerWithTraits( |
Gabriel Charette | e164063 | 2018-01-19 01:56:31 +0900 | [diff] [blame] | 107 | {TaskShutdownBehavior::BLOCK_SHUTDOWN}, |
robliao | 7d2bb1e | 2017-05-26 06:33:43 +0900 | [diff] [blame] | 108 | SingleThreadTaskRunnerThreadMode::DEDICATED); |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 109 | |
| 110 | PlatformThreadRef thread_ref_1; |
tzik | 6bdbeb2 | 2017-04-12 00:00:44 +0900 | [diff] [blame] | 111 | task_runner_1->PostTask(FROM_HERE, |
| 112 | BindOnce(&CaptureThreadRef, &thread_ref_1)); |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 113 | PlatformThreadRef thread_ref_2; |
tzik | 6bdbeb2 | 2017-04-12 00:00:44 +0900 | [diff] [blame] | 114 | task_runner_2->PostTask(FROM_HERE, |
| 115 | BindOnce(&CaptureThreadRef, &thread_ref_2)); |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 116 | |
| 117 | task_tracker_.Shutdown(); |
| 118 | |
| 119 | ASSERT_FALSE(thread_ref_1.is_null()); |
| 120 | ASSERT_FALSE(thread_ref_2.is_null()); |
| 121 | EXPECT_NE(thread_ref_1, thread_ref_2); |
| 122 | } |
| 123 | |
robliao | 7d2bb1e | 2017-05-26 06:33:43 +0900 | [diff] [blame] | 124 | TEST_F(TaskSchedulerSingleThreadTaskRunnerManagerTest, SameThreadUsed) { |
| 125 | scoped_refptr<SingleThreadTaskRunner> task_runner_1 = |
| 126 | single_thread_task_runner_manager_ |
| 127 | ->CreateSingleThreadTaskRunnerWithTraits( |
Gabriel Charette | e164063 | 2018-01-19 01:56:31 +0900 | [diff] [blame] | 128 | {TaskShutdownBehavior::BLOCK_SHUTDOWN}, |
robliao | 7d2bb1e | 2017-05-26 06:33:43 +0900 | [diff] [blame] | 129 | SingleThreadTaskRunnerThreadMode::SHARED); |
| 130 | scoped_refptr<SingleThreadTaskRunner> task_runner_2 = |
| 131 | single_thread_task_runner_manager_ |
| 132 | ->CreateSingleThreadTaskRunnerWithTraits( |
Gabriel Charette | e164063 | 2018-01-19 01:56:31 +0900 | [diff] [blame] | 133 | {TaskShutdownBehavior::BLOCK_SHUTDOWN}, |
robliao | 7d2bb1e | 2017-05-26 06:33:43 +0900 | [diff] [blame] | 134 | SingleThreadTaskRunnerThreadMode::SHARED); |
| 135 | |
| 136 | PlatformThreadRef thread_ref_1; |
| 137 | task_runner_1->PostTask(FROM_HERE, |
| 138 | BindOnce(&CaptureThreadRef, &thread_ref_1)); |
| 139 | PlatformThreadRef thread_ref_2; |
| 140 | task_runner_2->PostTask(FROM_HERE, |
| 141 | BindOnce(&CaptureThreadRef, &thread_ref_2)); |
| 142 | |
| 143 | task_tracker_.Shutdown(); |
| 144 | |
| 145 | ASSERT_FALSE(thread_ref_1.is_null()); |
| 146 | ASSERT_FALSE(thread_ref_2.is_null()); |
| 147 | EXPECT_EQ(thread_ref_1, thread_ref_2); |
| 148 | } |
| 149 | |
| 150 | TEST_F(TaskSchedulerSingleThreadTaskRunnerManagerTest, |
Yeol | 0d4f3eb | 2017-07-26 02:09:10 +0900 | [diff] [blame] | 151 | RunsTasksInCurrentSequence) { |
robliao | 7d2bb1e | 2017-05-26 06:33:43 +0900 | [diff] [blame] | 152 | scoped_refptr<SingleThreadTaskRunner> task_runner_1 = |
| 153 | single_thread_task_runner_manager_ |
| 154 | ->CreateSingleThreadTaskRunnerWithTraits( |
Gabriel Charette | e164063 | 2018-01-19 01:56:31 +0900 | [diff] [blame] | 155 | {TaskShutdownBehavior::BLOCK_SHUTDOWN}, |
robliao | 7d2bb1e | 2017-05-26 06:33:43 +0900 | [diff] [blame] | 156 | SingleThreadTaskRunnerThreadMode::DEDICATED); |
| 157 | scoped_refptr<SingleThreadTaskRunner> task_runner_2 = |
| 158 | single_thread_task_runner_manager_ |
| 159 | ->CreateSingleThreadTaskRunnerWithTraits( |
Gabriel Charette | e164063 | 2018-01-19 01:56:31 +0900 | [diff] [blame] | 160 | {TaskShutdownBehavior::BLOCK_SHUTDOWN}, |
robliao | 7d2bb1e | 2017-05-26 06:33:43 +0900 | [diff] [blame] | 161 | SingleThreadTaskRunnerThreadMode::DEDICATED); |
| 162 | |
Yeol | 0d4f3eb | 2017-07-26 02:09:10 +0900 | [diff] [blame] | 163 | EXPECT_FALSE(task_runner_1->RunsTasksInCurrentSequence()); |
| 164 | EXPECT_FALSE(task_runner_2->RunsTasksInCurrentSequence()); |
robliao | 7d2bb1e | 2017-05-26 06:33:43 +0900 | [diff] [blame] | 165 | |
| 166 | task_runner_1->PostTask( |
Yeol | 0d4f3eb | 2017-07-26 02:09:10 +0900 | [diff] [blame] | 167 | FROM_HERE, |
| 168 | BindOnce( |
| 169 | [](scoped_refptr<SingleThreadTaskRunner> task_runner_1, |
| 170 | scoped_refptr<SingleThreadTaskRunner> task_runner_2) { |
| 171 | EXPECT_TRUE(task_runner_1->RunsTasksInCurrentSequence()); |
| 172 | EXPECT_FALSE(task_runner_2->RunsTasksInCurrentSequence()); |
| 173 | }, |
| 174 | task_runner_1, task_runner_2)); |
robliao | 7d2bb1e | 2017-05-26 06:33:43 +0900 | [diff] [blame] | 175 | |
| 176 | task_runner_2->PostTask( |
Yeol | 0d4f3eb | 2017-07-26 02:09:10 +0900 | [diff] [blame] | 177 | FROM_HERE, |
| 178 | BindOnce( |
| 179 | [](scoped_refptr<SingleThreadTaskRunner> task_runner_1, |
| 180 | scoped_refptr<SingleThreadTaskRunner> task_runner_2) { |
| 181 | EXPECT_FALSE(task_runner_1->RunsTasksInCurrentSequence()); |
| 182 | EXPECT_TRUE(task_runner_2->RunsTasksInCurrentSequence()); |
| 183 | }, |
| 184 | task_runner_1, task_runner_2)); |
robliao | 7d2bb1e | 2017-05-26 06:33:43 +0900 | [diff] [blame] | 185 | |
| 186 | task_tracker_.Shutdown(); |
| 187 | } |
| 188 | |
| 189 | TEST_F(TaskSchedulerSingleThreadTaskRunnerManagerTest, |
| 190 | SharedWithBaseSyncPrimitivesDCHECKs) { |
| 191 | EXPECT_DCHECK_DEATH({ |
| 192 | single_thread_task_runner_manager_->CreateSingleThreadTaskRunnerWithTraits( |
Gabriel Charette | e164063 | 2018-01-19 01:56:31 +0900 | [diff] [blame] | 193 | {WithBaseSyncPrimitives()}, SingleThreadTaskRunnerThreadMode::SHARED); |
robliao | 7d2bb1e | 2017-05-26 06:33:43 +0900 | [diff] [blame] | 194 | }); |
| 195 | } |
| 196 | |
| 197 | namespace { |
| 198 | |
| 199 | class TaskSchedulerSingleThreadTaskRunnerManagerCommonTest |
| 200 | : public TaskSchedulerSingleThreadTaskRunnerManagerTest, |
| 201 | public ::testing::WithParamInterface<SingleThreadTaskRunnerThreadMode> { |
| 202 | public: |
| 203 | TaskSchedulerSingleThreadTaskRunnerManagerCommonTest() = default; |
| 204 | |
| 205 | private: |
| 206 | DISALLOW_COPY_AND_ASSIGN( |
| 207 | TaskSchedulerSingleThreadTaskRunnerManagerCommonTest); |
| 208 | }; |
| 209 | |
| 210 | } // namespace |
| 211 | |
| 212 | TEST_P(TaskSchedulerSingleThreadTaskRunnerManagerCommonTest, |
| 213 | PrioritySetCorrectly) { |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 214 | // Why are events used here instead of the task tracker? |
| 215 | // Shutting down can cause priorities to get raised. This means we have to use |
| 216 | // events to determine when a task is run. |
| 217 | scoped_refptr<SingleThreadTaskRunner> task_runner_background = |
| 218 | single_thread_task_runner_manager_ |
Gabriel Charette | e164063 | 2018-01-19 01:56:31 +0900 | [diff] [blame] | 219 | ->CreateSingleThreadTaskRunnerWithTraits({TaskPriority::BACKGROUND}, |
| 220 | GetParam()); |
fdoray | 066b38f | 2017-04-19 22:42:24 +0900 | [diff] [blame] | 221 | scoped_refptr<SingleThreadTaskRunner> task_runner_normal = |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 222 | single_thread_task_runner_manager_ |
Gabriel Charette | e164063 | 2018-01-19 01:56:31 +0900 | [diff] [blame] | 223 | ->CreateSingleThreadTaskRunnerWithTraits({TaskPriority::USER_VISIBLE}, |
| 224 | GetParam()); |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 225 | |
| 226 | ThreadPriority thread_priority_background; |
| 227 | task_runner_background->PostTask( |
tzik | 6bdbeb2 | 2017-04-12 00:00:44 +0900 | [diff] [blame] | 228 | FROM_HERE, BindOnce(&CaptureThreadPriority, &thread_priority_background)); |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 229 | WaitableEvent waitable_event_background( |
| 230 | WaitableEvent::ResetPolicy::MANUAL, |
| 231 | WaitableEvent::InitialState::NOT_SIGNALED); |
| 232 | task_runner_background->PostTask( |
| 233 | FROM_HERE, |
tzik | 6bdbeb2 | 2017-04-12 00:00:44 +0900 | [diff] [blame] | 234 | BindOnce(&WaitableEvent::Signal, Unretained(&waitable_event_background))); |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 235 | |
fdoray | 066b38f | 2017-04-19 22:42:24 +0900 | [diff] [blame] | 236 | ThreadPriority thread_priority_normal; |
| 237 | task_runner_normal->PostTask( |
| 238 | FROM_HERE, BindOnce(&CaptureThreadPriority, &thread_priority_normal)); |
| 239 | WaitableEvent waitable_event_normal( |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 240 | WaitableEvent::ResetPolicy::MANUAL, |
| 241 | WaitableEvent::InitialState::NOT_SIGNALED); |
fdoray | 066b38f | 2017-04-19 22:42:24 +0900 | [diff] [blame] | 242 | task_runner_normal->PostTask( |
tzik | 6bdbeb2 | 2017-04-12 00:00:44 +0900 | [diff] [blame] | 243 | FROM_HERE, |
fdoray | 066b38f | 2017-04-19 22:42:24 +0900 | [diff] [blame] | 244 | BindOnce(&WaitableEvent::Signal, Unretained(&waitable_event_normal))); |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 245 | |
| 246 | waitable_event_background.Wait(); |
fdoray | 066b38f | 2017-04-19 22:42:24 +0900 | [diff] [blame] | 247 | waitable_event_normal.Wait(); |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 248 | |
Ken MacKay | 9948fde | 2018-01-04 08:14:15 +0900 | [diff] [blame] | 249 | if (Lock::HandlesMultipleThreadPriorities() && |
| 250 | PlatformThread::CanIncreaseCurrentThreadPriority()) { |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 251 | EXPECT_EQ(ThreadPriority::BACKGROUND, thread_priority_background); |
Ken MacKay | 9948fde | 2018-01-04 08:14:15 +0900 | [diff] [blame] | 252 | } else { |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 253 | EXPECT_EQ(ThreadPriority::NORMAL, thread_priority_background); |
Ken MacKay | 9948fde | 2018-01-04 08:14:15 +0900 | [diff] [blame] | 254 | } |
fdoray | 066b38f | 2017-04-19 22:42:24 +0900 | [diff] [blame] | 255 | EXPECT_EQ(ThreadPriority::NORMAL, thread_priority_normal); |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 256 | } |
| 257 | |
robliao | 7d2bb1e | 2017-05-26 06:33:43 +0900 | [diff] [blame] | 258 | TEST_P(TaskSchedulerSingleThreadTaskRunnerManagerCommonTest, ThreadNamesSet) { |
| 259 | constexpr TaskTraits foo_traits = {TaskPriority::BACKGROUND, |
| 260 | TaskShutdownBehavior::BLOCK_SHUTDOWN}; |
| 261 | scoped_refptr<SingleThreadTaskRunner> foo_task_runner = |
| 262 | single_thread_task_runner_manager_ |
Gabriel Charette | e164063 | 2018-01-19 01:56:31 +0900 | [diff] [blame] | 263 | ->CreateSingleThreadTaskRunnerWithTraits(foo_traits, GetParam()); |
robliao | 7d2bb1e | 2017-05-26 06:33:43 +0900 | [diff] [blame] | 264 | std::string foo_captured_name; |
| 265 | foo_task_runner->PostTask(FROM_HERE, |
| 266 | BindOnce(&CaptureThreadName, &foo_captured_name)); |
| 267 | |
| 268 | constexpr TaskTraits user_blocking_traits = { |
| 269 | TaskPriority::USER_BLOCKING, MayBlock(), |
| 270 | TaskShutdownBehavior::BLOCK_SHUTDOWN}; |
| 271 | scoped_refptr<SingleThreadTaskRunner> user_blocking_task_runner = |
| 272 | single_thread_task_runner_manager_ |
Gabriel Charette | e164063 | 2018-01-19 01:56:31 +0900 | [diff] [blame] | 273 | ->CreateSingleThreadTaskRunnerWithTraits(user_blocking_traits, |
robliao | 7d2bb1e | 2017-05-26 06:33:43 +0900 | [diff] [blame] | 274 | GetParam()); |
| 275 | |
| 276 | std::string user_blocking_captured_name; |
| 277 | user_blocking_task_runner->PostTask( |
| 278 | FROM_HERE, BindOnce(&CaptureThreadName, &user_blocking_captured_name)); |
| 279 | |
| 280 | task_tracker_.Shutdown(); |
| 281 | |
robliao | 7d2bb1e | 2017-05-26 06:33:43 +0900 | [diff] [blame] | 282 | EXPECT_NE(std::string::npos, |
| 283 | foo_captured_name.find( |
| 284 | kEnvironmentParams[GetEnvironmentIndexForTraits(foo_traits)] |
| 285 | .name_suffix)); |
| 286 | EXPECT_NE( |
| 287 | std::string::npos, |
| 288 | user_blocking_captured_name.find( |
| 289 | kEnvironmentParams[GetEnvironmentIndexForTraits(user_blocking_traits)] |
| 290 | .name_suffix)); |
| 291 | |
| 292 | if (GetParam() == SingleThreadTaskRunnerThreadMode::DEDICATED) { |
| 293 | EXPECT_EQ(std::string::npos, foo_captured_name.find("Shared")); |
| 294 | EXPECT_EQ(std::string::npos, user_blocking_captured_name.find("Shared")); |
| 295 | } else { |
| 296 | EXPECT_NE(std::string::npos, foo_captured_name.find("Shared")); |
| 297 | EXPECT_NE(std::string::npos, user_blocking_captured_name.find("Shared")); |
| 298 | } |
| 299 | } |
| 300 | |
| 301 | TEST_P(TaskSchedulerSingleThreadTaskRunnerManagerCommonTest, |
| 302 | PostTaskAfterShutdown) { |
Gabriel Charette | e164063 | 2018-01-19 01:56:31 +0900 | [diff] [blame] | 303 | auto task_runner = |
| 304 | single_thread_task_runner_manager_ |
| 305 | ->CreateSingleThreadTaskRunnerWithTraits(TaskTraits(), GetParam()); |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 306 | task_tracker_.Shutdown(); |
tzik | 6bdbeb2 | 2017-04-12 00:00:44 +0900 | [diff] [blame] | 307 | EXPECT_FALSE(task_runner->PostTask(FROM_HERE, BindOnce(&ShouldNotRun))); |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 308 | } |
| 309 | |
| 310 | // Verify that a Task runs shortly after its delay expires. |
robliao | 7d2bb1e | 2017-05-26 06:33:43 +0900 | [diff] [blame] | 311 | TEST_P(TaskSchedulerSingleThreadTaskRunnerManagerCommonTest, PostDelayedTask) { |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 312 | TimeTicks start_time = TimeTicks::Now(); |
| 313 | |
| 314 | // Post a task with a short delay. |
| 315 | WaitableEvent task_ran(WaitableEvent::ResetPolicy::MANUAL, |
| 316 | WaitableEvent::InitialState::NOT_SIGNALED); |
Gabriel Charette | e164063 | 2018-01-19 01:56:31 +0900 | [diff] [blame] | 317 | auto task_runner = |
| 318 | single_thread_task_runner_manager_ |
| 319 | ->CreateSingleThreadTaskRunnerWithTraits(TaskTraits(), GetParam()); |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 320 | EXPECT_TRUE(task_runner->PostDelayedTask( |
tzik | 6bdbeb2 | 2017-04-12 00:00:44 +0900 | [diff] [blame] | 321 | FROM_HERE, BindOnce(&WaitableEvent::Signal, Unretained(&task_ran)), |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 322 | TestTimeouts::tiny_timeout())); |
| 323 | |
| 324 | // Wait until the task runs. |
| 325 | task_ran.Wait(); |
| 326 | |
| 327 | // Expect the task to run after its delay expires, but not more than 250 ms |
| 328 | // after that. |
| 329 | const TimeDelta actual_delay = TimeTicks::Now() - start_time; |
| 330 | EXPECT_GE(actual_delay, TestTimeouts::tiny_timeout()); |
| 331 | EXPECT_LT(actual_delay, |
| 332 | TimeDelta::FromMilliseconds(250) + TestTimeouts::tiny_timeout()); |
| 333 | } |
| 334 | |
Gabriel Charette | c37bf44 | 2017-09-21 11:26:13 +0900 | [diff] [blame] | 335 | // Verify that posting tasks after the single-thread manager is destroyed fails |
| 336 | // but doesn't crash. |
| 337 | TEST_P(TaskSchedulerSingleThreadTaskRunnerManagerCommonTest, |
| 338 | PostTaskAfterDestroy) { |
Gabriel Charette | e164063 | 2018-01-19 01:56:31 +0900 | [diff] [blame] | 339 | auto task_runner = |
| 340 | single_thread_task_runner_manager_ |
| 341 | ->CreateSingleThreadTaskRunnerWithTraits(TaskTraits(), GetParam()); |
Peter Kasting | 24efe5e | 2018-02-24 09:03:01 +0900 | [diff] [blame^] | 342 | EXPECT_TRUE(task_runner->PostTask(FROM_HERE, DoNothing())); |
Gabriel Charette | c37bf44 | 2017-09-21 11:26:13 +0900 | [diff] [blame] | 343 | task_tracker_.Shutdown(); |
| 344 | TearDownSingleThreadTaskRunnerManager(); |
| 345 | EXPECT_FALSE(task_runner->PostTask(FROM_HERE, BindOnce(&ShouldNotRun))); |
| 346 | } |
| 347 | |
robliao | 7d2bb1e | 2017-05-26 06:33:43 +0900 | [diff] [blame] | 348 | INSTANTIATE_TEST_CASE_P( |
| 349 | AllModes, |
| 350 | TaskSchedulerSingleThreadTaskRunnerManagerCommonTest, |
| 351 | ::testing::Values(SingleThreadTaskRunnerThreadMode::SHARED, |
| 352 | SingleThreadTaskRunnerThreadMode::DEDICATED)); |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 353 | |
| 354 | namespace { |
| 355 | |
| 356 | class CallJoinFromDifferentThread : public SimpleThread { |
| 357 | public: |
| 358 | CallJoinFromDifferentThread( |
| 359 | SchedulerSingleThreadTaskRunnerManager* manager_to_join) |
| 360 | : SimpleThread("SchedulerSingleThreadTaskRunnerManagerJoinThread"), |
| 361 | manager_to_join_(manager_to_join), |
| 362 | run_started_event_(WaitableEvent::ResetPolicy::MANUAL, |
| 363 | WaitableEvent::InitialState::NOT_SIGNALED) {} |
| 364 | |
| 365 | ~CallJoinFromDifferentThread() override = default; |
| 366 | |
| 367 | void Run() override { |
| 368 | run_started_event_.Signal(); |
| 369 | manager_to_join_->JoinForTesting(); |
| 370 | } |
| 371 | |
| 372 | void WaitForRunToStart() { run_started_event_.Wait(); } |
| 373 | |
| 374 | private: |
| 375 | SchedulerSingleThreadTaskRunnerManager* const manager_to_join_; |
| 376 | WaitableEvent run_started_event_; |
robliao | e6d9a48 | 2017-03-17 02:54:30 +0900 | [diff] [blame] | 377 | |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 378 | DISALLOW_COPY_AND_ASSIGN(CallJoinFromDifferentThread); |
| 379 | }; |
| 380 | |
| 381 | class TaskSchedulerSingleThreadTaskRunnerManagerJoinTest |
| 382 | : public TaskSchedulerSingleThreadTaskRunnerManagerTest { |
| 383 | public: |
| 384 | TaskSchedulerSingleThreadTaskRunnerManagerJoinTest() = default; |
| 385 | ~TaskSchedulerSingleThreadTaskRunnerManagerJoinTest() override = default; |
| 386 | |
| 387 | protected: |
| 388 | void TearDownSingleThreadTaskRunnerManager() override { |
| 389 | // The tests themselves are responsible for calling JoinForTesting(). |
| 390 | single_thread_task_runner_manager_.reset(); |
| 391 | } |
| 392 | |
| 393 | private: |
| 394 | DISALLOW_COPY_AND_ASSIGN(TaskSchedulerSingleThreadTaskRunnerManagerJoinTest); |
| 395 | }; |
| 396 | |
| 397 | } // namespace |
| 398 | |
| 399 | TEST_F(TaskSchedulerSingleThreadTaskRunnerManagerJoinTest, ConcurrentJoin) { |
robliao | e6d9a48 | 2017-03-17 02:54:30 +0900 | [diff] [blame] | 400 | // Exercises the codepath where the workers are unavailable for unregistration |
| 401 | // because of a Join call. |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 402 | WaitableEvent task_running(WaitableEvent::ResetPolicy::MANUAL, |
| 403 | WaitableEvent::InitialState::NOT_SIGNALED); |
| 404 | WaitableEvent task_blocking(WaitableEvent::ResetPolicy::MANUAL, |
| 405 | WaitableEvent::InitialState::NOT_SIGNALED); |
| 406 | |
| 407 | { |
robliao | 7d2bb1e | 2017-05-26 06:33:43 +0900 | [diff] [blame] | 408 | auto task_runner = single_thread_task_runner_manager_ |
| 409 | ->CreateSingleThreadTaskRunnerWithTraits( |
Gabriel Charette | e164063 | 2018-01-19 01:56:31 +0900 | [diff] [blame] | 410 | {WithBaseSyncPrimitives()}, |
robliao | 7d2bb1e | 2017-05-26 06:33:43 +0900 | [diff] [blame] | 411 | SingleThreadTaskRunnerThreadMode::DEDICATED); |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 412 | EXPECT_TRUE(task_runner->PostTask( |
tzik | 6bdbeb2 | 2017-04-12 00:00:44 +0900 | [diff] [blame] | 413 | FROM_HERE, |
| 414 | BindOnce(&WaitableEvent::Signal, Unretained(&task_running)))); |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 415 | EXPECT_TRUE(task_runner->PostTask( |
tzik | 6bdbeb2 | 2017-04-12 00:00:44 +0900 | [diff] [blame] | 416 | FROM_HERE, BindOnce(&WaitableEvent::Wait, Unretained(&task_blocking)))); |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 417 | } |
| 418 | |
| 419 | task_running.Wait(); |
| 420 | CallJoinFromDifferentThread join_from_different_thread( |
| 421 | single_thread_task_runner_manager_.get()); |
| 422 | join_from_different_thread.Start(); |
| 423 | join_from_different_thread.WaitForRunToStart(); |
| 424 | task_blocking.Signal(); |
| 425 | join_from_different_thread.Join(); |
| 426 | } |
| 427 | |
| 428 | TEST_F(TaskSchedulerSingleThreadTaskRunnerManagerJoinTest, |
| 429 | ConcurrentJoinExtraSkippedTask) { |
robliao | e6d9a48 | 2017-03-17 02:54:30 +0900 | [diff] [blame] | 430 | // Tests to make sure that tasks are properly cleaned up at Join, allowing |
| 431 | // SingleThreadTaskRunners to unregister themselves. |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 432 | WaitableEvent task_running(WaitableEvent::ResetPolicy::MANUAL, |
| 433 | WaitableEvent::InitialState::NOT_SIGNALED); |
| 434 | WaitableEvent task_blocking(WaitableEvent::ResetPolicy::MANUAL, |
| 435 | WaitableEvent::InitialState::NOT_SIGNALED); |
| 436 | |
| 437 | { |
robliao | 7d2bb1e | 2017-05-26 06:33:43 +0900 | [diff] [blame] | 438 | auto task_runner = single_thread_task_runner_manager_ |
| 439 | ->CreateSingleThreadTaskRunnerWithTraits( |
Gabriel Charette | e164063 | 2018-01-19 01:56:31 +0900 | [diff] [blame] | 440 | {WithBaseSyncPrimitives()}, |
robliao | 7d2bb1e | 2017-05-26 06:33:43 +0900 | [diff] [blame] | 441 | SingleThreadTaskRunnerThreadMode::DEDICATED); |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 442 | EXPECT_TRUE(task_runner->PostTask( |
tzik | 6bdbeb2 | 2017-04-12 00:00:44 +0900 | [diff] [blame] | 443 | FROM_HERE, |
| 444 | BindOnce(&WaitableEvent::Signal, Unretained(&task_running)))); |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 445 | EXPECT_TRUE(task_runner->PostTask( |
tzik | 6bdbeb2 | 2017-04-12 00:00:44 +0900 | [diff] [blame] | 446 | FROM_HERE, BindOnce(&WaitableEvent::Wait, Unretained(&task_blocking)))); |
Peter Kasting | 24efe5e | 2018-02-24 09:03:01 +0900 | [diff] [blame^] | 447 | EXPECT_TRUE(task_runner->PostTask(FROM_HERE, DoNothing())); |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 448 | } |
| 449 | |
| 450 | task_running.Wait(); |
| 451 | CallJoinFromDifferentThread join_from_different_thread( |
| 452 | single_thread_task_runner_manager_.get()); |
| 453 | join_from_different_thread.Start(); |
| 454 | join_from_different_thread.WaitForRunToStart(); |
| 455 | task_blocking.Signal(); |
| 456 | join_from_different_thread.Join(); |
| 457 | } |
| 458 | |
robliao | f81c000 | 2017-03-23 07:30:15 +0900 | [diff] [blame] | 459 | #if defined(OS_WIN) |
| 460 | |
robliao | 7d2bb1e | 2017-05-26 06:33:43 +0900 | [diff] [blame] | 461 | TEST_P(TaskSchedulerSingleThreadTaskRunnerManagerCommonTest, |
| 462 | COMSTAInitialized) { |
robliao | f81c000 | 2017-03-23 07:30:15 +0900 | [diff] [blame] | 463 | scoped_refptr<SingleThreadTaskRunner> com_task_runner = |
| 464 | single_thread_task_runner_manager_->CreateCOMSTATaskRunnerWithTraits( |
Gabriel Charette | e164063 | 2018-01-19 01:56:31 +0900 | [diff] [blame] | 465 | {TaskShutdownBehavior::BLOCK_SHUTDOWN}, GetParam()); |
robliao | f81c000 | 2017-03-23 07:30:15 +0900 | [diff] [blame] | 466 | |
Robert Liao | b01a997 | 2017-07-07 09:54:14 +0900 | [diff] [blame] | 467 | com_task_runner->PostTask(FROM_HERE, BindOnce(&win::AssertComApartmentType, |
| 468 | win::ComApartmentType::STA)); |
robliao | f81c000 | 2017-03-23 07:30:15 +0900 | [diff] [blame] | 469 | |
| 470 | task_tracker_.Shutdown(); |
| 471 | } |
| 472 | |
robliao | 7d2bb1e | 2017-05-26 06:33:43 +0900 | [diff] [blame] | 473 | TEST_F(TaskSchedulerSingleThreadTaskRunnerManagerTest, COMSTASameThreadUsed) { |
| 474 | scoped_refptr<SingleThreadTaskRunner> task_runner_1 = |
| 475 | single_thread_task_runner_manager_->CreateCOMSTATaskRunnerWithTraits( |
Gabriel Charette | e164063 | 2018-01-19 01:56:31 +0900 | [diff] [blame] | 476 | {TaskShutdownBehavior::BLOCK_SHUTDOWN}, |
robliao | 7d2bb1e | 2017-05-26 06:33:43 +0900 | [diff] [blame] | 477 | SingleThreadTaskRunnerThreadMode::SHARED); |
| 478 | scoped_refptr<SingleThreadTaskRunner> task_runner_2 = |
| 479 | single_thread_task_runner_manager_->CreateCOMSTATaskRunnerWithTraits( |
Gabriel Charette | e164063 | 2018-01-19 01:56:31 +0900 | [diff] [blame] | 480 | {TaskShutdownBehavior::BLOCK_SHUTDOWN}, |
robliao | 7d2bb1e | 2017-05-26 06:33:43 +0900 | [diff] [blame] | 481 | SingleThreadTaskRunnerThreadMode::SHARED); |
| 482 | |
| 483 | PlatformThreadRef thread_ref_1; |
| 484 | task_runner_1->PostTask(FROM_HERE, |
| 485 | BindOnce(&CaptureThreadRef, &thread_ref_1)); |
| 486 | PlatformThreadRef thread_ref_2; |
| 487 | task_runner_2->PostTask(FROM_HERE, |
| 488 | BindOnce(&CaptureThreadRef, &thread_ref_2)); |
| 489 | |
| 490 | task_tracker_.Shutdown(); |
| 491 | |
| 492 | ASSERT_FALSE(thread_ref_1.is_null()); |
| 493 | ASSERT_FALSE(thread_ref_2.is_null()); |
| 494 | EXPECT_EQ(thread_ref_1, thread_ref_2); |
| 495 | } |
| 496 | |
robliao | f81c000 | 2017-03-23 07:30:15 +0900 | [diff] [blame] | 497 | namespace { |
| 498 | |
| 499 | const wchar_t* const kTestWindowClassName = |
| 500 | L"TaskSchedulerSingleThreadTaskRunnerManagerTestWinMessageWindow"; |
| 501 | |
| 502 | class TaskSchedulerSingleThreadTaskRunnerManagerTestWin |
| 503 | : public TaskSchedulerSingleThreadTaskRunnerManagerTest { |
| 504 | public: |
| 505 | TaskSchedulerSingleThreadTaskRunnerManagerTestWin() = default; |
| 506 | |
| 507 | void SetUp() override { |
| 508 | TaskSchedulerSingleThreadTaskRunnerManagerTest::SetUp(); |
| 509 | register_class_succeeded_ = RegisterTestWindowClass(); |
| 510 | ASSERT_TRUE(register_class_succeeded_); |
| 511 | } |
| 512 | |
| 513 | void TearDown() override { |
| 514 | if (register_class_succeeded_) |
| 515 | ::UnregisterClass(kTestWindowClassName, CURRENT_MODULE()); |
| 516 | |
| 517 | TaskSchedulerSingleThreadTaskRunnerManagerTest::TearDown(); |
| 518 | } |
| 519 | |
| 520 | HWND CreateTestWindow() { |
| 521 | return CreateWindow(kTestWindowClassName, kTestWindowClassName, 0, 0, 0, 0, |
| 522 | 0, HWND_MESSAGE, nullptr, CURRENT_MODULE(), nullptr); |
| 523 | } |
| 524 | |
| 525 | private: |
| 526 | bool RegisterTestWindowClass() { |
| 527 | WNDCLASSEX window_class = {}; |
| 528 | window_class.cbSize = sizeof(window_class); |
| 529 | window_class.lpfnWndProc = &::DefWindowProc; |
| 530 | window_class.hInstance = CURRENT_MODULE(); |
| 531 | window_class.lpszClassName = kTestWindowClassName; |
| 532 | return !!::RegisterClassEx(&window_class); |
| 533 | } |
| 534 | |
| 535 | bool register_class_succeeded_ = false; |
| 536 | |
| 537 | DISALLOW_COPY_AND_ASSIGN(TaskSchedulerSingleThreadTaskRunnerManagerTestWin); |
| 538 | }; |
| 539 | |
| 540 | } // namespace |
| 541 | |
| 542 | TEST_F(TaskSchedulerSingleThreadTaskRunnerManagerTestWin, PumpsMessages) { |
| 543 | scoped_refptr<SingleThreadTaskRunner> com_task_runner = |
| 544 | single_thread_task_runner_manager_->CreateCOMSTATaskRunnerWithTraits( |
Gabriel Charette | e164063 | 2018-01-19 01:56:31 +0900 | [diff] [blame] | 545 | {TaskShutdownBehavior::BLOCK_SHUTDOWN}, |
robliao | 7d2bb1e | 2017-05-26 06:33:43 +0900 | [diff] [blame] | 546 | SingleThreadTaskRunnerThreadMode::DEDICATED); |
robliao | f81c000 | 2017-03-23 07:30:15 +0900 | [diff] [blame] | 547 | HWND hwnd = nullptr; |
| 548 | // HWNDs process messages on the thread that created them, so we have to |
| 549 | // create them within the context of the task runner to properly simulate a |
| 550 | // COM callback. |
| 551 | com_task_runner->PostTask( |
| 552 | FROM_HERE, |
fdoray | 066b38f | 2017-04-19 22:42:24 +0900 | [diff] [blame] | 553 | BindOnce( |
| 554 | [](TaskSchedulerSingleThreadTaskRunnerManagerTestWin* test_harness, |
| 555 | HWND* hwnd) { *hwnd = test_harness->CreateTestWindow(); }, |
| 556 | Unretained(this), &hwnd)); |
robliao | f81c000 | 2017-03-23 07:30:15 +0900 | [diff] [blame] | 557 | |
Robert Liao | e25acff | 2018-01-25 07:39:17 +0900 | [diff] [blame] | 558 | task_tracker_.FlushForTesting(); |
robliao | f81c000 | 2017-03-23 07:30:15 +0900 | [diff] [blame] | 559 | |
| 560 | ASSERT_NE(hwnd, nullptr); |
| 561 | // If the message pump isn't running, we will hang here. This simulates how |
| 562 | // COM would receive a callback with its own message HWND. |
| 563 | SendMessage(hwnd, WM_USER, 0, 0); |
| 564 | |
| 565 | com_task_runner->PostTask( |
fdoray | 066b38f | 2017-04-19 22:42:24 +0900 | [diff] [blame] | 566 | FROM_HERE, BindOnce([](HWND hwnd) { ::DestroyWindow(hwnd); }, hwnd)); |
robliao | f81c000 | 2017-03-23 07:30:15 +0900 | [diff] [blame] | 567 | |
| 568 | task_tracker_.Shutdown(); |
| 569 | } |
| 570 | |
| 571 | #endif // defined(OS_WIN) |
| 572 | |
fdoray | d952d8e | 2017-04-19 09:37:26 +0900 | [diff] [blame] | 573 | namespace { |
| 574 | |
| 575 | class TaskSchedulerSingleThreadTaskRunnerManagerStartTest |
| 576 | : public TaskSchedulerSingleThreadTaskRunnerManagerTest { |
| 577 | public: |
| 578 | TaskSchedulerSingleThreadTaskRunnerManagerStartTest() = default; |
| 579 | |
| 580 | private: |
| 581 | void StartSingleThreadTaskRunnerManagerFromSetUp() override { |
| 582 | // Start() is called in the test body rather than in SetUp(). |
| 583 | } |
| 584 | |
| 585 | DISALLOW_COPY_AND_ASSIGN(TaskSchedulerSingleThreadTaskRunnerManagerStartTest); |
| 586 | }; |
| 587 | |
| 588 | } // namespace |
| 589 | |
| 590 | // Verify that a task posted before Start() doesn't run until Start() is called. |
| 591 | TEST_F(TaskSchedulerSingleThreadTaskRunnerManagerStartTest, |
Robert Liao | b029d53 | 2017-11-17 04:00:28 +0900 | [diff] [blame] | 592 | PostTaskBeforeStart) { |
fdoray | d952d8e | 2017-04-19 09:37:26 +0900 | [diff] [blame] | 593 | AtomicFlag manager_started; |
Robert Liao | b029d53 | 2017-11-17 04:00:28 +0900 | [diff] [blame] | 594 | WaitableEvent task_finished(WaitableEvent::ResetPolicy::MANUAL, |
| 595 | WaitableEvent::InitialState::NOT_SIGNALED); |
fdoray | d952d8e | 2017-04-19 09:37:26 +0900 | [diff] [blame] | 596 | single_thread_task_runner_manager_ |
robliao | 7d2bb1e | 2017-05-26 06:33:43 +0900 | [diff] [blame] | 597 | ->CreateSingleThreadTaskRunnerWithTraits( |
Gabriel Charette | e164063 | 2018-01-19 01:56:31 +0900 | [diff] [blame] | 598 | TaskTraits(), SingleThreadTaskRunnerThreadMode::DEDICATED) |
fdoray | d952d8e | 2017-04-19 09:37:26 +0900 | [diff] [blame] | 599 | ->PostTask( |
| 600 | FROM_HERE, |
fdoray | 066b38f | 2017-04-19 22:42:24 +0900 | [diff] [blame] | 601 | BindOnce( |
Robert Liao | b029d53 | 2017-11-17 04:00:28 +0900 | [diff] [blame] | 602 | [](WaitableEvent* task_finished, AtomicFlag* manager_started) { |
fdoray | d952d8e | 2017-04-19 09:37:26 +0900 | [diff] [blame] | 603 | // The task should not run before Start(). |
| 604 | EXPECT_TRUE(manager_started->IsSet()); |
Robert Liao | b029d53 | 2017-11-17 04:00:28 +0900 | [diff] [blame] | 605 | task_finished->Signal(); |
fdoray | d952d8e | 2017-04-19 09:37:26 +0900 | [diff] [blame] | 606 | }, |
Robert Liao | b029d53 | 2017-11-17 04:00:28 +0900 | [diff] [blame] | 607 | Unretained(&task_finished), Unretained(&manager_started))); |
fdoray | d952d8e | 2017-04-19 09:37:26 +0900 | [diff] [blame] | 608 | |
Francois Doray | 5f64343 | 2017-10-12 01:27:12 +0900 | [diff] [blame] | 609 | // Wait a little bit to make sure that the task doesn't run before start. |
| 610 | // Note: This test won't catch a case where the task runs between setting |
| 611 | // |manager_started| and calling Start(). However, we expect the test to be |
| 612 | // flaky if the tested code allows that to happen. |
fdoray | d952d8e | 2017-04-19 09:37:26 +0900 | [diff] [blame] | 613 | PlatformThread::Sleep(TestTimeouts::tiny_timeout()); |
| 614 | manager_started.Set(); |
| 615 | single_thread_task_runner_manager_->Start(); |
| 616 | |
Robert Liao | b029d53 | 2017-11-17 04:00:28 +0900 | [diff] [blame] | 617 | // Wait for the task to complete to keep |manager_started| alive. |
| 618 | task_finished.Wait(); |
fdoray | d952d8e | 2017-04-19 09:37:26 +0900 | [diff] [blame] | 619 | } |
| 620 | |
robliao | 19e3ad7 | 2017-03-11 05:21:29 +0900 | [diff] [blame] | 621 | } // namespace internal |
| 622 | } // namespace base |