blob: a82bc912a7931ca0735db76b1a99307e965fd89c [file] [log] [blame]
jln@chromium.org4faaf212013-01-16 05:16:33 +09001// Copyright (c) 2013 The Chromium Authors. All rights reserved.
2// Use of this source code is governed by a BSD-style license that can be
3// found in the LICENSE file.
4
jln@chromium.orgc71a4da2013-01-31 11:23:43 +09005#include <fcntl.h>
avia6a6a682015-12-27 07:15:14 +09006#include <stddef.h>
jln@chromium.org4faaf212013-01-16 05:16:33 +09007#include <stdio.h>
8#include <stdlib.h>
9#include <string.h>
jln@chromium.orgc71a4da2013-01-31 11:23:43 +090010#include <sys/stat.h>
11#include <sys/types.h>
jln@chromium.org4faaf212013-01-16 05:16:33 +090012
13#include <algorithm>
14#include <limits>
15
brettw@chromium.org01f3da42014-08-14 05:22:14 +090016#include "base/files/file_util.h"
jln@chromium.org4faaf212013-01-16 05:16:33 +090017#include "base/logging.h"
18#include "base/memory/scoped_ptr.h"
jln@chromium.orga55baa62013-02-05 08:39:48 +090019#include "build/build_config.h"
jln@chromium.org4faaf212013-01-16 05:16:33 +090020#include "testing/gtest/include/gtest/gtest.h"
21
jln@chromium.orga55baa62013-02-05 08:39:48 +090022#if defined(OS_POSIX)
23#include <sys/mman.h>
24#include <unistd.h>
25#endif
26
jln@chromium.org4faaf212013-01-16 05:16:33 +090027using std::nothrow;
jln@chromium.orgd06052c2013-01-26 13:41:15 +090028using std::numeric_limits;
jln@chromium.org4faaf212013-01-16 05:16:33 +090029
30namespace {
31
jln@chromium.orgc6d44222013-02-06 12:23:49 +090032// This function acts as a compiler optimization barrier. We use it to
33// prevent the compiler from making an expression a compile-time constant.
34// We also use it so that the compiler doesn't discard certain return values
35// as something we don't need (see the comment with calloc below).
36template <typename Type>
thakis497632e2015-04-23 11:58:29 +090037NOINLINE Type HideValueFromCompiler(volatile Type value) {
jln@chromium.org59755862013-04-04 21:02:35 +090038#if defined(__GNUC__)
39 // In a GCC compatible compiler (GCC or Clang), make this compiler barrier
40 // more robust than merely using "volatile".
41 __asm__ volatile ("" : "+r" (value));
42#endif // __GNUC__
jln@chromium.orgc6d44222013-02-06 12:23:49 +090043 return value;
44}
45
wfhf2a57fa2015-01-13 12:11:40 +090046// Tcmalloc and Windows allocator shim support setting malloc limits.
dmikurube@chromium.org1df36512014-03-06 05:07:26 +090047// - NO_TCMALLOC (should be defined if compiled with use_allocator!="tcmalloc")
chrisha@google.com87839ab2014-03-28 00:08:04 +090048// - ADDRESS_SANITIZER and SYZYASAN because they have their own memory allocator
jln@chromium.orgfe78d552013-02-15 15:10:40 +090049// - IOS does not use tcmalloc
jln@chromium.org4faaf212013-01-16 05:16:33 +090050// - OS_MACOSX does not use tcmalloc
wfhf2a57fa2015-01-13 12:11:40 +090051// - Windows allocator shim defines ALLOCATOR_SHIM
52#if (!defined(NO_TCMALLOC) || defined(ALLOCATOR_SHIM)) && \
53 !defined(ADDRESS_SANITIZER) && !defined(OS_IOS) && !defined(OS_MACOSX) && \
54 !defined(SYZYASAN)
55#define MALLOC_OVERFLOW_TEST(function) function
jln@chromium.org4faaf212013-01-16 05:16:33 +090056#else
wfhf2a57fa2015-01-13 12:11:40 +090057#define MALLOC_OVERFLOW_TEST(function) DISABLED_##function
jln@chromium.org4faaf212013-01-16 05:16:33 +090058#endif
59
wfh26bb6442015-09-21 11:21:14 +090060#if defined(OS_LINUX) && defined(__x86_64__)
jln@chromium.org4faaf212013-01-16 05:16:33 +090061// Detect runtime TCMalloc bypasses.
62bool IsTcMallocBypassed() {
jln@chromium.org4faaf212013-01-16 05:16:33 +090063 // This should detect a TCMalloc bypass from Valgrind.
64 char* g_slice = getenv("G_SLICE");
65 if (g_slice && !strcmp(g_slice, "always-malloc"))
66 return true;
jln@chromium.org4faaf212013-01-16 05:16:33 +090067 return false;
68}
jln@chromium.orgfe78d552013-02-15 15:10:40 +090069#endif
jln@chromium.orgd06052c2013-01-26 13:41:15 +090070
jln@chromium.orgd06052c2013-01-26 13:41:15 +090071// There are platforms where these tests are known to fail. We would like to
72// be able to easily check the status on the bots, but marking tests as
73// FAILS_ is too clunky.
74void OverflowTestsSoftExpectTrue(bool overflow_detected) {
75 if (!overflow_detected) {
76#if defined(OS_LINUX) || defined(OS_ANDROID) || defined(OS_MACOSX)
77 // Sadly, on Linux, Android, and OSX we don't have a good story yet. Don't
78 // fail the test, but report.
79 printf("Platform has overflow: %s\n",
80 !overflow_detected ? "yes." : "no.");
81#else
82 // Otherwise, fail the test. (Note: EXPECT are ok in subfunctions, ASSERT
83 // aren't).
84 EXPECT_TRUE(overflow_detected);
85#endif
86 }
87}
88
tommycli153da342016-02-10 07:42:58 +090089#if defined(OS_IOS) || defined(OS_WIN) || defined(OS_MACOSX) || defined(OS_LINUX)
John Abd-El-Malekccd3dd32014-10-03 07:55:15 +090090#define MAYBE_NewOverflow DISABLED_NewOverflow
91#else
92#define MAYBE_NewOverflow NewOverflow
93#endif
jln@chromium.orgd06052c2013-01-26 13:41:15 +090094// Test array[TooBig][X] and array[X][TooBig] allocations for int overflows.
95// IOS doesn't honor nothrow, so disable the test there.
jln@chromium.org59755862013-04-04 21:02:35 +090096// Crashes on Windows Dbg builds, disable there as well.
John Abd-El-Malekccd3dd32014-10-03 07:55:15 +090097// Fails on Mac 10.8 http://crbug.com/227092
tommycli153da342016-02-10 07:42:58 +090098// Disabled on Linux because failing Linux Valgrind bot, and Valgrind exclusions
99// are not currently read. See http://crbug.com/582398
John Abd-El-Malekccd3dd32014-10-03 07:55:15 +0900100TEST(SecurityTest, MAYBE_NewOverflow) {
jln@chromium.orgd06052c2013-01-26 13:41:15 +0900101 const size_t kArraySize = 4096;
102 // We want something "dynamic" here, so that the compiler doesn't
103 // immediately reject crazy arrays.
104 const size_t kDynamicArraySize = HideValueFromCompiler(kArraySize);
105 // numeric_limits are still not constexpr until we switch to C++11, so we
106 // use an ugly cast.
107 const size_t kMaxSizeT = ~static_cast<size_t>(0);
108 ASSERT_EQ(numeric_limits<size_t>::max(), kMaxSizeT);
109 const size_t kArraySize2 = kMaxSizeT / kArraySize + 10;
110 const size_t kDynamicArraySize2 = HideValueFromCompiler(kArraySize2);
111 {
112 scoped_ptr<char[][kArraySize]> array_pointer(new (nothrow)
113 char[kDynamicArraySize2][kArraySize]);
jln@chromium.orgc6d44222013-02-06 12:23:49 +0900114 OverflowTestsSoftExpectTrue(!array_pointer);
jln@chromium.orgd06052c2013-01-26 13:41:15 +0900115 }
jln@chromium.org59755862013-04-04 21:02:35 +0900116 // On windows, the compiler prevents static array sizes of more than
117 // 0x7fffffff (error C2148).
Peter Kasting618317c2014-11-21 08:14:08 +0900118#if defined(OS_WIN) && defined(ARCH_CPU_64_BITS)
119 ALLOW_UNUSED_LOCAL(kDynamicArraySize);
120#else
jln@chromium.orgd06052c2013-01-26 13:41:15 +0900121 {
122 scoped_ptr<char[][kArraySize2]> array_pointer(new (nothrow)
123 char[kDynamicArraySize][kArraySize2]);
jln@chromium.orgc6d44222013-02-06 12:23:49 +0900124 OverflowTestsSoftExpectTrue(!array_pointer);
jln@chromium.orgd06052c2013-01-26 13:41:15 +0900125 }
jln@chromium.org59755862013-04-04 21:02:35 +0900126#endif // !defined(OS_WIN) || !defined(ARCH_CPU_64_BITS)
jln@chromium.orgd06052c2013-01-26 13:41:15 +0900127}
128
estade@chromium.orgd841d6d2014-04-16 05:58:09 +0900129#if defined(OS_LINUX) && defined(__x86_64__)
jln@chromium.orga55baa62013-02-05 08:39:48 +0900130// Check if ptr1 and ptr2 are separated by less than size chars.
131bool ArePointersToSameArea(void* ptr1, void* ptr2, size_t size) {
132 ptrdiff_t ptr_diff = reinterpret_cast<char*>(std::max(ptr1, ptr2)) -
133 reinterpret_cast<char*>(std::min(ptr1, ptr2));
134 return static_cast<size_t>(ptr_diff) <= size;
135}
136
jln@chromium.orgc71a4da2013-01-31 11:23:43 +0900137// Check if TCMalloc uses an underlying random memory allocator.
wfhf2a57fa2015-01-13 12:11:40 +0900138TEST(SecurityTest, MALLOC_OVERFLOW_TEST(RandomMemoryAllocations)) {
jln@chromium.orgc71a4da2013-01-31 11:23:43 +0900139 if (IsTcMallocBypassed())
140 return;
jln@chromium.orga55baa62013-02-05 08:39:48 +0900141 size_t kPageSize = 4096; // We support x86_64 only.
142 // Check that malloc() returns an address that is neither the kernel's
143 // un-hinted mmap area, nor the current brk() area. The first malloc() may
144 // not be at a random address because TCMalloc will first exhaust any memory
145 // that it has allocated early on, before starting the sophisticated
146 // allocators.
147 void* default_mmap_heap_address =
148 mmap(0, kPageSize, PROT_READ|PROT_WRITE,
149 MAP_PRIVATE|MAP_ANONYMOUS, -1, 0);
150 ASSERT_NE(default_mmap_heap_address,
151 static_cast<void*>(MAP_FAILED));
152 ASSERT_EQ(munmap(default_mmap_heap_address, kPageSize), 0);
153 void* brk_heap_address = sbrk(0);
154 ASSERT_NE(brk_heap_address, reinterpret_cast<void*>(-1));
155 ASSERT_TRUE(brk_heap_address != NULL);
156 // 1 MB should get us past what TCMalloc pre-allocated before initializing
157 // the sophisticated allocators.
158 size_t kAllocSize = 1<<20;
159 scoped_ptr<char, base::FreeDeleter> ptr(
160 static_cast<char*>(malloc(kAllocSize)));
161 ASSERT_TRUE(ptr != NULL);
162 // If two pointers are separated by less than 512MB, they are considered
163 // to be in the same area.
164 // Our random pointer could be anywhere within 0x3fffffffffff (46bits),
165 // and we are checking that it's not withing 1GB (30 bits) from two
166 // addresses (brk and mmap heap). We have roughly one chance out of
167 // 2^15 to flake.
168 const size_t kAreaRadius = 1<<29;
169 bool in_default_mmap_heap = ArePointersToSameArea(
170 ptr.get(), default_mmap_heap_address, kAreaRadius);
171 EXPECT_FALSE(in_default_mmap_heap);
172
173 bool in_default_brk_heap = ArePointersToSameArea(
174 ptr.get(), brk_heap_address, kAreaRadius);
175 EXPECT_FALSE(in_default_brk_heap);
176
177 // In the implementation, we always mask our random addresses with
178 // kRandomMask, so we use it as an additional detection mechanism.
179 const uintptr_t kRandomMask = 0x3fffffffffffULL;
180 bool impossible_random_address =
181 reinterpret_cast<uintptr_t>(ptr.get()) & ~kRandomMask;
182 EXPECT_FALSE(impossible_random_address);
jln@chromium.orgc71a4da2013-01-31 11:23:43 +0900183}
184
estade@chromium.orgd841d6d2014-04-16 05:58:09 +0900185#endif // defined(OS_LINUX) && defined(__x86_64__)
jln@chromium.orgc71a4da2013-01-31 11:23:43 +0900186
jln@chromium.org4faaf212013-01-16 05:16:33 +0900187} // namespace