Dan Gohman | f17a25c | 2007-07-18 16:29:46 +0000 | [diff] [blame] | 1 | //===- BreakCriticalEdges.cpp - Critical Edge Elimination Pass ------------===// |
| 2 | // |
| 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
Chris Lattner | 081ce94 | 2007-12-29 20:36:04 +0000 | [diff] [blame] | 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
Dan Gohman | f17a25c | 2007-07-18 16:29:46 +0000 | [diff] [blame] | 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
| 9 | // |
| 10 | // BreakCriticalEdges pass - Break all of the critical edges in the CFG by |
| 11 | // inserting a dummy basic block. This pass may be "required" by passes that |
| 12 | // cannot deal with critical edges. For this usage, the structure type is |
| 13 | // forward declared. This pass obviously invalidates the CFG, but can update |
| 14 | // forward dominator (set, immediate dominators, tree, and frontier) |
| 15 | // information. |
| 16 | // |
| 17 | //===----------------------------------------------------------------------===// |
| 18 | |
| 19 | #define DEBUG_TYPE "break-crit-edges" |
| 20 | #include "llvm/Transforms/Scalar.h" |
| 21 | #include "llvm/Transforms/Utils/BasicBlockUtils.h" |
| 22 | #include "llvm/Analysis/Dominators.h" |
| 23 | #include "llvm/Analysis/LoopInfo.h" |
| 24 | #include "llvm/Function.h" |
| 25 | #include "llvm/Instructions.h" |
| 26 | #include "llvm/Type.h" |
| 27 | #include "llvm/Support/CFG.h" |
| 28 | #include "llvm/Support/Compiler.h" |
| 29 | #include "llvm/ADT/SmallVector.h" |
| 30 | #include "llvm/ADT/Statistic.h" |
| 31 | using namespace llvm; |
| 32 | |
| 33 | STATISTIC(NumBroken, "Number of blocks inserted"); |
| 34 | |
| 35 | namespace { |
| 36 | struct VISIBILITY_HIDDEN BreakCriticalEdges : public FunctionPass { |
| 37 | static char ID; // Pass identification, replacement for typeid |
| 38 | BreakCriticalEdges() : FunctionPass((intptr_t)&ID) {} |
| 39 | |
| 40 | virtual bool runOnFunction(Function &F); |
| 41 | |
| 42 | virtual void getAnalysisUsage(AnalysisUsage &AU) const { |
| 43 | AU.addPreserved<DominatorTree>(); |
| 44 | AU.addPreserved<DominanceFrontier>(); |
| 45 | AU.addPreserved<LoopInfo>(); |
| 46 | |
| 47 | // No loop canonicalization guarantees are broken by this pass. |
| 48 | AU.addPreservedID(LoopSimplifyID); |
| 49 | } |
| 50 | }; |
| 51 | |
| 52 | char BreakCriticalEdges::ID = 0; |
| 53 | RegisterPass<BreakCriticalEdges> X("break-crit-edges", |
| 54 | "Break critical edges in CFG"); |
| 55 | } |
| 56 | |
| 57 | // Publically exposed interface to pass... |
| 58 | const PassInfo *llvm::BreakCriticalEdgesID = X.getPassInfo(); |
| 59 | FunctionPass *llvm::createBreakCriticalEdgesPass() { |
| 60 | return new BreakCriticalEdges(); |
| 61 | } |
| 62 | |
| 63 | // runOnFunction - Loop over all of the edges in the CFG, breaking critical |
| 64 | // edges as they are found. |
| 65 | // |
| 66 | bool BreakCriticalEdges::runOnFunction(Function &F) { |
| 67 | bool Changed = false; |
| 68 | for (Function::iterator I = F.begin(), E = F.end(); I != E; ++I) { |
| 69 | TerminatorInst *TI = I->getTerminator(); |
| 70 | if (TI->getNumSuccessors() > 1) |
| 71 | for (unsigned i = 0, e = TI->getNumSuccessors(); i != e; ++i) |
| 72 | if (SplitCriticalEdge(TI, i, this)) { |
| 73 | ++NumBroken; |
| 74 | Changed = true; |
| 75 | } |
| 76 | } |
| 77 | |
| 78 | return Changed; |
| 79 | } |
| 80 | |
| 81 | //===----------------------------------------------------------------------===// |
| 82 | // Implementation of the external critical edge manipulation functions |
| 83 | //===----------------------------------------------------------------------===// |
| 84 | |
| 85 | // isCriticalEdge - Return true if the specified edge is a critical edge. |
| 86 | // Critical edges are edges from a block with multiple successors to a block |
| 87 | // with multiple predecessors. |
| 88 | // |
| 89 | bool llvm::isCriticalEdge(const TerminatorInst *TI, unsigned SuccNum, |
| 90 | bool AllowIdenticalEdges) { |
| 91 | assert(SuccNum < TI->getNumSuccessors() && "Illegal edge specification!"); |
| 92 | if (TI->getNumSuccessors() == 1) return false; |
| 93 | |
| 94 | const BasicBlock *Dest = TI->getSuccessor(SuccNum); |
| 95 | pred_const_iterator I = pred_begin(Dest), E = pred_end(Dest); |
| 96 | |
| 97 | // If there is more than one predecessor, this is a critical edge... |
| 98 | assert(I != E && "No preds, but we have an edge to the block?"); |
| 99 | const BasicBlock *FirstPred = *I; |
| 100 | ++I; // Skip one edge due to the incoming arc from TI. |
| 101 | if (!AllowIdenticalEdges) |
| 102 | return I != E; |
| 103 | |
| 104 | // If AllowIdenticalEdges is true, then we allow this edge to be considered |
| 105 | // non-critical iff all preds come from TI's block. |
Scott Michel | aad62cc | 2008-04-16 23:46:39 +0000 | [diff] [blame^] | 106 | while (I != E) { |
| 107 | pred_const_iterator E1 = E; |
| 108 | if (*I != FirstPred) |
| 109 | return true; |
| 110 | // Note: leave this as is until no one ever compiles with either gcc 4.0.1 |
| 111 | // or Xcode 2. This seems to work around the pred_iterator assert in PR 2207 |
| 112 | E = pred_end(*I); |
| 113 | ++I; |
| 114 | } |
Dan Gohman | f17a25c | 2007-07-18 16:29:46 +0000 | [diff] [blame] | 115 | return false; |
| 116 | } |
| 117 | |
| 118 | // SplitCriticalEdge - If this edge is a critical edge, insert a new node to |
| 119 | // split the critical edge. This will update DominatorTree, and DominatorFrontier |
| 120 | // information if it is available, thus calling this pass will not invalidate |
| 121 | // any of them. This returns true if the edge was split, false otherwise. |
| 122 | // This ensures that all edges to that dest go to one block instead of each |
| 123 | // going to a different block. |
| 124 | // |
| 125 | bool llvm::SplitCriticalEdge(TerminatorInst *TI, unsigned SuccNum, Pass *P, |
| 126 | bool MergeIdenticalEdges) { |
| 127 | if (!isCriticalEdge(TI, SuccNum, MergeIdenticalEdges)) return false; |
| 128 | BasicBlock *TIBB = TI->getParent(); |
| 129 | BasicBlock *DestBB = TI->getSuccessor(SuccNum); |
| 130 | |
| 131 | // Create a new basic block, linking it into the CFG. |
Gabor Greif | d6da1d0 | 2008-04-06 20:25:17 +0000 | [diff] [blame] | 132 | BasicBlock *NewBB = BasicBlock::Create(TIBB->getName() + "." + |
| 133 | DestBB->getName() + "_crit_edge"); |
Dan Gohman | f17a25c | 2007-07-18 16:29:46 +0000 | [diff] [blame] | 134 | // Create our unconditional branch... |
Gabor Greif | d6da1d0 | 2008-04-06 20:25:17 +0000 | [diff] [blame] | 135 | BranchInst::Create(DestBB, NewBB); |
Dan Gohman | f17a25c | 2007-07-18 16:29:46 +0000 | [diff] [blame] | 136 | |
| 137 | // Branch to the new block, breaking the edge. |
| 138 | TI->setSuccessor(SuccNum, NewBB); |
| 139 | |
| 140 | // Insert the block into the function... right after the block TI lives in. |
| 141 | Function &F = *TIBB->getParent(); |
| 142 | Function::iterator FBBI = TIBB; |
| 143 | F.getBasicBlockList().insert(++FBBI, NewBB); |
| 144 | |
| 145 | // If there are any PHI nodes in DestBB, we need to update them so that they |
| 146 | // merge incoming values from NewBB instead of from TIBB. |
| 147 | // |
| 148 | for (BasicBlock::iterator I = DestBB->begin(); isa<PHINode>(I); ++I) { |
| 149 | PHINode *PN = cast<PHINode>(I); |
| 150 | // We no longer enter through TIBB, now we come in through NewBB. Revector |
| 151 | // exactly one entry in the PHI node that used to come from TIBB to come |
| 152 | // from NewBB. |
| 153 | int BBIdx = PN->getBasicBlockIndex(TIBB); |
| 154 | PN->setIncomingBlock(BBIdx, NewBB); |
| 155 | } |
| 156 | |
| 157 | // If there are any other edges from TIBB to DestBB, update those to go |
| 158 | // through the split block, making those edges non-critical as well (and |
| 159 | // reducing the number of phi entries in the DestBB if relevant). |
| 160 | if (MergeIdenticalEdges) { |
| 161 | for (unsigned i = SuccNum+1, e = TI->getNumSuccessors(); i != e; ++i) { |
| 162 | if (TI->getSuccessor(i) != DestBB) continue; |
| 163 | |
| 164 | // Remove an entry for TIBB from DestBB phi nodes. |
| 165 | DestBB->removePredecessor(TIBB); |
| 166 | |
| 167 | // We found another edge to DestBB, go to NewBB instead. |
| 168 | TI->setSuccessor(i, NewBB); |
| 169 | } |
| 170 | } |
| 171 | |
| 172 | |
| 173 | |
| 174 | // If we don't have a pass object, we can't update anything... |
| 175 | if (P == 0) return true; |
| 176 | |
| 177 | // Now update analysis information. Since the only predecessor of NewBB is |
| 178 | // the TIBB, TIBB clearly dominates NewBB. TIBB usually doesn't dominate |
| 179 | // anything, as there are other successors of DestBB. However, if all other |
| 180 | // predecessors of DestBB are already dominated by DestBB (e.g. DestBB is a |
| 181 | // loop header) then NewBB dominates DestBB. |
| 182 | SmallVector<BasicBlock*, 8> OtherPreds; |
| 183 | |
| 184 | for (pred_iterator I = pred_begin(DestBB), E = pred_end(DestBB); I != E; ++I) |
| 185 | if (*I != NewBB) |
| 186 | OtherPreds.push_back(*I); |
| 187 | |
| 188 | bool NewBBDominatesDestBB = true; |
| 189 | |
| 190 | // Should we update DominatorTree information? |
| 191 | if (DominatorTree *DT = P->getAnalysisToUpdate<DominatorTree>()) { |
| 192 | DomTreeNode *TINode = DT->getNode(TIBB); |
| 193 | |
| 194 | // The new block is not the immediate dominator for any other nodes, but |
| 195 | // TINode is the immediate dominator for the new node. |
| 196 | // |
| 197 | if (TINode) { // Don't break unreachable code! |
| 198 | DomTreeNode *NewBBNode = DT->addNewBlock(NewBB, TIBB); |
| 199 | DomTreeNode *DestBBNode = 0; |
| 200 | |
| 201 | // If NewBBDominatesDestBB hasn't been computed yet, do so with DT. |
| 202 | if (!OtherPreds.empty()) { |
| 203 | DestBBNode = DT->getNode(DestBB); |
| 204 | while (!OtherPreds.empty() && NewBBDominatesDestBB) { |
| 205 | if (DomTreeNode *OPNode = DT->getNode(OtherPreds.back())) |
| 206 | NewBBDominatesDestBB = DT->dominates(DestBBNode, OPNode); |
| 207 | OtherPreds.pop_back(); |
| 208 | } |
| 209 | OtherPreds.clear(); |
| 210 | } |
| 211 | |
| 212 | // If NewBBDominatesDestBB, then NewBB dominates DestBB, otherwise it |
| 213 | // doesn't dominate anything. |
| 214 | if (NewBBDominatesDestBB) { |
| 215 | if (!DestBBNode) DestBBNode = DT->getNode(DestBB); |
| 216 | DT->changeImmediateDominator(DestBBNode, NewBBNode); |
| 217 | } |
| 218 | } |
| 219 | } |
| 220 | |
| 221 | // Should we update DominanceFrontier information? |
| 222 | if (DominanceFrontier *DF = P->getAnalysisToUpdate<DominanceFrontier>()) { |
| 223 | // If NewBBDominatesDestBB hasn't been computed yet, do so with DF. |
| 224 | if (!OtherPreds.empty()) { |
| 225 | // FIXME: IMPLEMENT THIS! |
| 226 | assert(0 && "Requiring domfrontiers but not idom/domtree/domset." |
| 227 | " not implemented yet!"); |
| 228 | } |
| 229 | |
| 230 | // Since the new block is dominated by its only predecessor TIBB, |
| 231 | // it cannot be in any block's dominance frontier. If NewBB dominates |
| 232 | // DestBB, its dominance frontier is the same as DestBB's, otherwise it is |
| 233 | // just {DestBB}. |
| 234 | DominanceFrontier::DomSetType NewDFSet; |
| 235 | if (NewBBDominatesDestBB) { |
| 236 | DominanceFrontier::iterator I = DF->find(DestBB); |
Devang Patel | 112468c | 2007-08-13 21:59:17 +0000 | [diff] [blame] | 237 | if (I != DF->end()) { |
Dan Gohman | f17a25c | 2007-07-18 16:29:46 +0000 | [diff] [blame] | 238 | DF->addBasicBlock(NewBB, I->second); |
Devang Patel | 112468c | 2007-08-13 21:59:17 +0000 | [diff] [blame] | 239 | // However NewBB's frontier does not include DestBB. |
| 240 | DominanceFrontier::iterator NF = DF->find(NewBB); |
| 241 | DF->removeFromFrontier(NF, DestBB); |
| 242 | } |
Dan Gohman | f17a25c | 2007-07-18 16:29:46 +0000 | [diff] [blame] | 243 | else |
| 244 | DF->addBasicBlock(NewBB, DominanceFrontier::DomSetType()); |
| 245 | } else { |
| 246 | DominanceFrontier::DomSetType NewDFSet; |
| 247 | NewDFSet.insert(DestBB); |
| 248 | DF->addBasicBlock(NewBB, NewDFSet); |
| 249 | } |
| 250 | } |
| 251 | |
| 252 | // Update LoopInfo if it is around. |
| 253 | if (LoopInfo *LI = P->getAnalysisToUpdate<LoopInfo>()) { |
| 254 | // If one or the other blocks were not in a loop, the new block is not |
| 255 | // either, and thus LI doesn't need to be updated. |
| 256 | if (Loop *TIL = LI->getLoopFor(TIBB)) |
| 257 | if (Loop *DestLoop = LI->getLoopFor(DestBB)) { |
| 258 | if (TIL == DestLoop) { |
| 259 | // Both in the same loop, the NewBB joins loop. |
Owen Anderson | ca0b9d4 | 2007-11-27 03:43:35 +0000 | [diff] [blame] | 260 | DestLoop->addBasicBlockToLoop(NewBB, LI->getBase()); |
Dan Gohman | f17a25c | 2007-07-18 16:29:46 +0000 | [diff] [blame] | 261 | } else if (TIL->contains(DestLoop->getHeader())) { |
| 262 | // Edge from an outer loop to an inner loop. Add to the outer loop. |
Owen Anderson | ca0b9d4 | 2007-11-27 03:43:35 +0000 | [diff] [blame] | 263 | TIL->addBasicBlockToLoop(NewBB, LI->getBase()); |
Dan Gohman | f17a25c | 2007-07-18 16:29:46 +0000 | [diff] [blame] | 264 | } else if (DestLoop->contains(TIL->getHeader())) { |
| 265 | // Edge from an inner loop to an outer loop. Add to the outer loop. |
Owen Anderson | ca0b9d4 | 2007-11-27 03:43:35 +0000 | [diff] [blame] | 266 | DestLoop->addBasicBlockToLoop(NewBB, LI->getBase()); |
Dan Gohman | f17a25c | 2007-07-18 16:29:46 +0000 | [diff] [blame] | 267 | } else { |
| 268 | // Edge from two loops with no containment relation. Because these |
| 269 | // are natural loops, we know that the destination block must be the |
| 270 | // header of its loop (adding a branch into a loop elsewhere would |
| 271 | // create an irreducible loop). |
| 272 | assert(DestLoop->getHeader() == DestBB && |
| 273 | "Should not create irreducible loops!"); |
| 274 | if (Loop *P = DestLoop->getParentLoop()) |
Owen Anderson | ca0b9d4 | 2007-11-27 03:43:35 +0000 | [diff] [blame] | 275 | P->addBasicBlockToLoop(NewBB, LI->getBase()); |
Dan Gohman | f17a25c | 2007-07-18 16:29:46 +0000 | [diff] [blame] | 276 | } |
| 277 | } |
| 278 | } |
| 279 | return true; |
| 280 | } |