blob: 26755c88e7d61eb8c9c1cca2dec41fe79bca7b60 [file] [log] [blame]
Jorge Lucangeli Obesa6b034d2012-08-07 15:29:20 -07001/* Copyright (c) 2012 The Chromium OS Authors. All rights reserved.
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -07002 * Use of this source code is governed by a BSD-style license that can be
3 * found in the LICENSE file.
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -07004 */
5
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -07006#include <stdio.h>
7#include <stdlib.h>
8#include <string.h>
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -07009
10#include "syscall_filter.h"
11
Jorge Lucangeli Obesa6b034d2012-08-07 15:29:20 -070012#include "util.h"
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -070013
Jorge Lucangeli Obes565e9782016-08-05 11:03:19 -040014#define MAX_LINE_LENGTH 1024
Jorge Lucangeli Obesbda833c2012-07-31 16:25:56 -070015#define MAX_POLICY_LINE_LENGTH 1024
16
Jorge Lucangeli Obesa6b034d2012-08-07 15:29:20 -070017#define ONE_INSTR 1
18#define TWO_INSTRS 2
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -070019
Jorge Lucangeli Obes7b2e29c2016-08-04 12:21:03 -040020int seccomp_can_softfail()
21{
Jorge Lucangeli Obes565e9782016-08-05 11:03:19 -040022#if defined(USE_SECCOMP_SOFTFAIL)
Jeff Vander Stoep1022fc32016-08-28 12:24:55 -070023 return 1;
Jorge Lucangeli Obes7b2e29c2016-08-04 12:21:03 -040024#endif
25 return 0;
26}
27
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -070028int str_to_op(const char *op_str)
29{
30 if (!strcmp(op_str, "==")) {
31 return EQ;
32 } else if (!strcmp(op_str, "!=")) {
33 return NE;
Jorge Lucangeli Obes66cfc142012-11-30 15:42:52 -080034 } else if (!strcmp(op_str, "&")) {
35 return SET;
Jorge Lucangeli Obesfd6f8e32016-10-12 11:19:28 -040036 } else if (!strcmp(op_str, "in")) {
37 return IN;
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -070038 } else {
39 return 0;
40 }
41}
42
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -070043struct sock_filter *new_instr_buf(size_t count)
44{
45 struct sock_filter *buf = calloc(count, sizeof(struct sock_filter));
46 if (!buf)
Jorge Lucangeli Obes224e4272012-08-02 14:31:39 -070047 die("could not allocate BPF instruction buffer");
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -070048
49 return buf;
50}
51
Jorge Lucangeli Obesd96baf42013-03-26 15:11:30 -070052struct filter_block *new_filter_block()
53{
54 struct filter_block *block = calloc(1, sizeof(struct filter_block));
55 if (!block)
56 die("could not allocate BPF filter block");
57
58 block->instrs = NULL;
59 block->last = block->next = NULL;
60
61 return block;
62}
63
Jorge Lucangeli Obes565e9782016-08-05 11:03:19 -040064void append_filter_block(struct filter_block *head, struct sock_filter *instrs,
65 size_t len)
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -070066{
67 struct filter_block *new_last;
68
69 /*
70 * If |head| has no filter assigned yet,
71 * we don't create a new node.
72 */
73 if (head->instrs == NULL) {
74 new_last = head;
75 } else {
Jorge Lucangeli Obesd96baf42013-03-26 15:11:30 -070076 new_last = new_filter_block();
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -070077 if (head->next != NULL) {
78 head->last->next = new_last;
79 head->last = new_last;
80 } else {
81 head->last = head->next = new_last;
82 }
83 head->total_len += len;
84 }
85
86 new_last->instrs = instrs;
87 new_last->total_len = new_last->len = len;
88 new_last->last = new_last->next = NULL;
89}
90
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -070091void extend_filter_block_list(struct filter_block *list,
Jorge Lucangeli Obes565e9782016-08-05 11:03:19 -040092 struct filter_block *another)
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -070093{
94 if (list->last != NULL) {
95 list->last->next = another;
96 list->last = another->last;
97 } else {
98 list->next = another;
99 list->last = another->last;
100 }
101 list->total_len += another->total_len;
102}
103
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700104void append_ret_kill(struct filter_block *head)
105{
106 struct sock_filter *filter = new_instr_buf(ONE_INSTR);
107 set_bpf_ret_kill(filter);
108 append_filter_block(head, filter, ONE_INSTR);
109}
110
Jorge Lucangeli Obesbda833c2012-07-31 16:25:56 -0700111void append_ret_trap(struct filter_block *head)
112{
113 struct sock_filter *filter = new_instr_buf(ONE_INSTR);
114 set_bpf_ret_trap(filter);
115 append_filter_block(head, filter, ONE_INSTR);
116}
117
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700118void append_ret_errno(struct filter_block *head, int errno_val)
119{
120 struct sock_filter *filter = new_instr_buf(ONE_INSTR);
121 set_bpf_ret_errno(filter, errno_val);
122 append_filter_block(head, filter, ONE_INSTR);
123}
124
Jorge Lucangeli Obesc8b21e12014-06-13 14:26:16 -0700125void append_allow_syscall(struct filter_block *head, int nr)
126{
Jorge Lucangeli Obesbda833c2012-07-31 16:25:56 -0700127 struct sock_filter *filter = new_instr_buf(ALLOW_SYSCALL_LEN);
128 size_t len = bpf_allow_syscall(filter, nr);
129 if (len != ALLOW_SYSCALL_LEN)
130 die("error building syscall number comparison");
131
132 append_filter_block(head, filter, len);
133}
134
Jorge Lucangeli Obes713f6fb2016-10-03 13:03:25 -0400135void allow_logging_syscalls(struct filter_block *head)
Jorge Lucangeli Obesbda833c2012-07-31 16:25:56 -0700136{
137 unsigned int i;
Kees Cook03b2af22014-12-18 17:11:13 -0800138 for (i = 0; i < log_syscalls_len; i++) {
139 warn("allowing syscall: %s", log_syscalls[i]);
Jorge Lucangeli Obesbda833c2012-07-31 16:25:56 -0700140 append_allow_syscall(head, lookup_syscall(log_syscalls[i]));
Kees Cook03b2af22014-12-18 17:11:13 -0800141 }
Jorge Lucangeli Obesbda833c2012-07-31 16:25:56 -0700142}
143
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700144unsigned int get_label_id(struct bpf_labels *labels, const char *label_str)
145{
146 int label_id = bpf_label_id(labels, label_str);
147 if (label_id < 0)
Jorge Lucangeli Obes224e4272012-08-02 14:31:39 -0700148 die("could not allocate BPF label string");
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700149 return label_id;
150}
151
152unsigned int group_end_lbl(struct bpf_labels *labels, int nr, int idx)
153{
154 char lbl_str[MAX_BPF_LABEL_LEN];
155 snprintf(lbl_str, MAX_BPF_LABEL_LEN, "%d_%d_end", nr, idx);
156 return get_label_id(labels, lbl_str);
157}
158
159unsigned int success_lbl(struct bpf_labels *labels, int nr)
160{
161 char lbl_str[MAX_BPF_LABEL_LEN];
162 snprintf(lbl_str, MAX_BPF_LABEL_LEN, "%d_success", nr);
163 return get_label_id(labels, lbl_str);
164}
165
Jorge Lucangeli Obes66cfc142012-11-30 15:42:52 -0800166int compile_atom(struct filter_block *head, char *atom,
Jorge Lucangeli Obes565e9782016-08-05 11:03:19 -0400167 struct bpf_labels *labels, int nr, int group_idx)
Jorge Lucangeli Obes66cfc142012-11-30 15:42:52 -0800168{
169 /* Splits the atom. */
170 char *atom_ptr;
171 char *argidx_str = strtok_r(atom, " ", &atom_ptr);
172 char *operator_str = strtok_r(NULL, " ", &atom_ptr);
173 char *constant_str = strtok_r(NULL, " ", &atom_ptr);
174
175 if (argidx_str == NULL || operator_str == NULL || constant_str == NULL)
176 return -1;
177
178 int op = str_to_op(operator_str);
179 if (op < MIN_OPERATOR)
180 return -1;
181
182 if (strncmp(argidx_str, "arg", 3)) {
183 return -1;
184 }
185
186 char *argidx_ptr;
187 long int argidx = strtol(argidx_str + 3, &argidx_ptr, 10);
188 /*
189 * Checks to see if an actual argument index
190 * was parsed.
191 */
Jorge Lucangeli Obes53895402016-10-18 12:02:58 -0400192 if (argidx_ptr == argidx_str + 3) {
193 warn("invalid argument index '%s'", argidx_ptr);
Jorge Lucangeli Obes66cfc142012-11-30 15:42:52 -0800194 return -1;
Jorge Lucangeli Obes53895402016-10-18 12:02:58 -0400195 }
Jorge Lucangeli Obes66cfc142012-11-30 15:42:52 -0800196
Luis Hector Chavez40b25742013-09-22 19:44:06 -0700197 char *constant_str_ptr;
198 long int c = parse_constant(constant_str, &constant_str_ptr);
Jorge Lucangeli Obes53895402016-10-18 12:02:58 -0400199 if (constant_str_ptr == constant_str) {
200 warn("invalid constant '%s'", constant_str);
Luis Hector Chavez40b25742013-09-22 19:44:06 -0700201 return -1;
Jorge Lucangeli Obes53895402016-10-18 12:02:58 -0400202 }
Luis Hector Chavez40b25742013-09-22 19:44:06 -0700203
Jorge Lucangeli Obes66cfc142012-11-30 15:42:52 -0800204 /*
205 * Looks up the label for the end of the AND statement
206 * this atom belongs to.
207 */
208 unsigned int id = group_end_lbl(labels, nr, group_idx);
209
210 /*
211 * Builds a BPF comparison between a syscall argument
212 * and a constant.
213 * The comparison lives inside an AND statement.
214 * If the comparison succeeds, we continue
215 * to the next comparison.
216 * If this comparison fails, the whole AND statement
217 * will fail, so we jump to the end of this AND statement.
218 */
219 struct sock_filter *comp_block;
220 size_t len = bpf_arg_comp(&comp_block, op, argidx, c, id);
221 if (len == 0)
222 return -1;
223
224 append_filter_block(head, comp_block, len);
225 return 0;
226}
227
Jorge Lucangeli Obes713f6fb2016-10-03 13:03:25 -0400228int compile_errno(struct filter_block *head, char *ret_errno, int use_ret_trap)
Jorge Lucangeli Obesc8b21e12014-06-13 14:26:16 -0700229{
Jorge Lucangeli Obes66cfc142012-11-30 15:42:52 -0800230 char *errno_ptr;
231
232 /* Splits the 'return' keyword and the actual errno value. */
233 char *ret_str = strtok_r(ret_errno, " ", &errno_ptr);
234 if (strncmp(ret_str, "return", strlen("return")))
235 return -1;
236
237 char *errno_val_str = strtok_r(NULL, " ", &errno_ptr);
238
239 if (errno_val_str) {
240 char *errno_val_ptr;
Luis Hector Chavez40b25742013-09-22 19:44:06 -0700241 int errno_val = parse_constant(errno_val_str, &errno_val_ptr);
Jorge Lucangeli Obes66cfc142012-11-30 15:42:52 -0800242 /* Checks to see if we parsed an actual errno. */
Jorge Lucangeli Obes53895402016-10-18 12:02:58 -0400243 if (errno_val_ptr == errno_val_str || errno_val == -1) {
244 warn("invalid errno value '%s'", errno_val_ptr);
Jorge Lucangeli Obes66cfc142012-11-30 15:42:52 -0800245 return -1;
Jorge Lucangeli Obes53895402016-10-18 12:02:58 -0400246 }
Jorge Lucangeli Obes66cfc142012-11-30 15:42:52 -0800247
248 append_ret_errno(head, errno_val);
249 } else {
Jorge Lucangeli Obes713f6fb2016-10-03 13:03:25 -0400250 if (!use_ret_trap)
Jennifer Pullmanc0bfae02016-05-26 17:00:36 -0700251 append_ret_kill(head);
252 else
253 append_ret_trap(head);
Jorge Lucangeli Obes66cfc142012-11-30 15:42:52 -0800254 }
255 return 0;
256}
257
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700258struct filter_block *compile_section(int nr, const char *policy_line,
Jorge Lucangeli Obes565e9782016-08-05 11:03:19 -0400259 unsigned int entry_lbl_id,
Jennifer Pullmanc0bfae02016-05-26 17:00:36 -0700260 struct bpf_labels *labels,
Jorge Lucangeli Obes713f6fb2016-10-03 13:03:25 -0400261 int use_ret_trap)
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700262{
263 /*
264 * |policy_line| should be an expression of the form:
265 * "arg0 == 3 && arg1 == 5 || arg0 == 0x8"
266 *
267 * This is, an expression in DNF (disjunctive normal form);
268 * a disjunction ('||') of one or more conjunctions ('&&')
269 * of one or more atoms.
270 *
Jorge Lucangeli Obesd96baf42013-03-26 15:11:30 -0700271 * Atoms are of the form "arg{DNUM} {OP} {NUM}"
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700272 * where:
273 * - DNUM is a decimal number.
Jorge Lucangeli Obes21c3ab12016-10-12 18:37:37 -0400274 * - OP is an operator: ==, !=, & (flags set), or 'in' (inclusion).
Jorge Lucangeli Obes66cfc142012-11-30 15:42:52 -0800275 * - NUM is an octal, decimal, or hexadecimal number.
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700276 *
277 * When the syscall arguments make the expression true,
278 * the syscall is allowed. If not, the process is killed.
279 *
Jorge Lucangeli Obesd96baf42013-03-26 15:11:30 -0700280 * To block a syscall without killing the process,
281 * |policy_line| can be of the form:
282 * "return <errno>"
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700283 *
Jorge Lucangeli Obesd96baf42013-03-26 15:11:30 -0700284 * This "return {NUM}" policy line will block the syscall,
285 * make it return -1 and set |errno| to NUM.
286 *
287 * A regular policy line can also include a "return <errno>" clause,
288 * separated by a semicolon (';'):
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700289 * "arg0 == 3 && arg1 == 5 || arg0 == 0x8; return {NUM}"
290 *
Jorge Lucangeli Obesd96baf42013-03-26 15:11:30 -0700291 * If the syscall arguments don't make the expression true,
292 * the syscall will be blocked as above instead of killing the process.
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700293 */
294
295 size_t len = 0;
296 int group_idx = 0;
297
298 /* Checks for overly long policy lines. */
Jorge Lucangeli Obesbda833c2012-07-31 16:25:56 -0700299 if (strlen(policy_line) >= MAX_POLICY_LINE_LENGTH)
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700300 return NULL;
301
Jorge Lucangeli Obesd96baf42013-03-26 15:11:30 -0700302 /* We will modify |policy_line|, so let's make a copy. */
Jorge Lucangeli Obesbda833c2012-07-31 16:25:56 -0700303 char *line = strndup(policy_line, MAX_POLICY_LINE_LENGTH);
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700304 if (!line)
305 return NULL;
306
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700307 /*
Jorge Lucangeli Obesd96baf42013-03-26 15:11:30 -0700308 * We build the filter section as a collection of smaller
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700309 * "filter blocks" linked together in a singly-linked list.
310 */
Jorge Lucangeli Obesd96baf42013-03-26 15:11:30 -0700311 struct filter_block *head = new_filter_block();
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700312
313 /*
Jorge Lucangeli Obesd96baf42013-03-26 15:11:30 -0700314 * Filter sections begin with a label where the main filter
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700315 * will jump after checking the syscall number.
316 */
317 struct sock_filter *entry_label = new_instr_buf(ONE_INSTR);
318 set_bpf_lbl(entry_label, entry_lbl_id);
319 append_filter_block(head, entry_label, ONE_INSTR);
320
Jorge Lucangeli Obesd96baf42013-03-26 15:11:30 -0700321 /* Checks whether we're unconditionally blocking this syscall. */
322 if (strncmp(line, "return", strlen("return")) == 0) {
Jorge Lucangeli Obes713f6fb2016-10-03 13:03:25 -0400323 if (compile_errno(head, line, use_ret_trap) < 0)
Jorge Lucangeli Obesd96baf42013-03-26 15:11:30 -0700324 return NULL;
325 free(line);
326 return head;
327 }
328
329 /* Splits the optional "return <errno>" part. */
330 char *line_ptr;
331 char *arg_filter = strtok_r(line, ";", &line_ptr);
332 char *ret_errno = strtok_r(NULL, ";", &line_ptr);
333
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700334 /*
335 * Splits the policy line by '||' into conjunctions and each conjunction
336 * by '&&' into atoms.
337 */
Jorge Lucangeli Obes66cfc142012-11-30 15:42:52 -0800338 char *arg_filter_str = arg_filter;
339 char *group;
340 while ((group = tokenize(&arg_filter_str, "||")) != NULL) {
341 char *group_str = group;
342 char *comp;
343 while ((comp = tokenize(&group_str, "&&")) != NULL) {
344 /* Compiles each atom into a BPF block. */
345 if (compile_atom(head, comp, labels, nr, group_idx) < 0)
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700346 return NULL;
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700347 }
348 /*
349 * If the AND statement succeeds, we're done,
350 * so jump to SUCCESS line.
351 */
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700352 unsigned int id = success_lbl(labels, nr);
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700353 struct sock_filter *group_end_block = new_instr_buf(TWO_INSTRS);
354 len = set_bpf_jump_lbl(group_end_block, id);
355 /*
356 * The end of each AND statement falls after the
357 * jump to SUCCESS.
358 */
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700359 id = group_end_lbl(labels, nr, group_idx++);
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700360 len += set_bpf_lbl(group_end_block + len, id);
361 append_filter_block(head, group_end_block, len);
362 }
363
364 /*
365 * If no AND statements succeed, we end up here,
366 * because we never jumped to SUCCESS.
367 * If we have to return an errno, do it,
368 * otherwise just kill the task.
369 */
370 if (ret_errno) {
Jorge Lucangeli Obes713f6fb2016-10-03 13:03:25 -0400371 if (compile_errno(head, ret_errno, use_ret_trap) < 0)
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700372 return NULL;
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700373 } else {
Jorge Lucangeli Obes713f6fb2016-10-03 13:03:25 -0400374 if (!use_ret_trap)
Jennifer Pullmanc0bfae02016-05-26 17:00:36 -0700375 append_ret_kill(head);
376 else
377 append_ret_trap(head);
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700378 }
379
380 /*
381 * Every time the filter succeeds we jump to a predefined SUCCESS
382 * label. Add that label and BPF RET_ALLOW code now.
383 */
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700384 unsigned int id = success_lbl(labels, nr);
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700385 struct sock_filter *success_block = new_instr_buf(TWO_INSTRS);
386 len = set_bpf_lbl(success_block, id);
387 len += set_bpf_ret_allow(success_block + len);
388 append_filter_block(head, success_block, len);
389
390 free(line);
391 return head;
392}
393
Jorge Lucangeli Obes713f6fb2016-10-03 13:03:25 -0400394int compile_filter(FILE *policy_file, struct sock_fprog *prog, int use_ret_trap,
395 int allow_logging)
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700396{
397 char line[MAX_LINE_LENGTH];
398 int line_count = 0;
399
400 struct bpf_labels labels;
401 labels.count = 0;
402
Jorge Lucangeli Obesb0cea432013-02-04 11:55:30 -0800403 if (!policy_file)
Jorge Lucangeli Obes6135db92012-07-27 13:37:30 -0700404 return -1;
405
Jorge Lucangeli Obesd96baf42013-03-26 15:11:30 -0700406 struct filter_block *head = new_filter_block();
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700407 struct filter_block *arg_blocks = NULL;
408
409 /* Start filter by validating arch. */
410 struct sock_filter *valid_arch = new_instr_buf(ARCH_VALIDATION_LEN);
411 size_t len = bpf_validate_arch(valid_arch);
412 append_filter_block(head, valid_arch, len);
413
Jorge Lucangeli Obesbda833c2012-07-31 16:25:56 -0700414 /* Load syscall number. */
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700415 struct sock_filter *load_nr = new_instr_buf(ONE_INSTR);
416 len = bpf_load_syscall_nr(load_nr);
417 append_filter_block(head, load_nr, len);
418
Jorge Lucangeli Obes713f6fb2016-10-03 13:03:25 -0400419 /* If logging failures, allow the necessary syscalls first. */
420 if (allow_logging)
421 allow_logging_syscalls(head);
Jorge Lucangeli Obesbda833c2012-07-31 16:25:56 -0700422
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700423 /*
424 * Loop through all the lines in the policy file.
425 * Build a jump table for the syscall number.
426 * If the policy line has an arg filter, build the arg filter
427 * as well.
428 * Chain the filter sections together and dump them into
429 * the final buffer at the end.
430 */
Jorge Lucangeli Obesb0cea432013-02-04 11:55:30 -0800431 while (fgets(line, sizeof(line), policy_file)) {
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700432 ++line_count;
Jorge Lucangeli Obesb0cea432013-02-04 11:55:30 -0800433 char *policy_line = line;
434 char *syscall_name = strsep(&policy_line, ":");
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700435 int nr = -1;
436
437 syscall_name = strip(syscall_name);
438
439 /* Allow comments and empty lines. */
440 if (*syscall_name == '#' || *syscall_name == '\0')
441 continue;
442
Jorge Lucangeli Obesb0cea432013-02-04 11:55:30 -0800443 if (!policy_line)
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700444 return -1;
445
446 nr = lookup_syscall(syscall_name);
Jorge Lucangeli Obes275b07f2012-08-28 11:50:29 -0700447 if (nr < 0) {
448 warn("compile_filter: nonexistent syscall '%s'",
449 syscall_name);
Jorge Lucangeli Obes713f6fb2016-10-03 13:03:25 -0400450 if (allow_logging) {
Jorge Lucangeli Obesbe351a22016-01-22 17:18:51 -0800451 /*
452 * If we're logging failures, assume we're in a
453 * debugging case and continue.
454 * This is not super risky because an invalid
455 * syscall name is likely caused by a typo or by
456 * leftover lines from a different architecture.
457 * In either case, not including a policy line
458 * is equivalent to killing the process if the
459 * syscall is made, so there's no added attack
460 * surface.
461 */
462 continue;
463 }
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700464 return -1;
Jorge Lucangeli Obes275b07f2012-08-28 11:50:29 -0700465 }
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700466
Jorge Lucangeli Obesb0cea432013-02-04 11:55:30 -0800467 policy_line = strip(policy_line);
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700468
469 /*
470 * For each syscall, add either a simple ALLOW,
471 * or an arg filter block.
472 */
Jorge Lucangeli Obesb0cea432013-02-04 11:55:30 -0800473 if (strcmp(policy_line, "1") == 0) {
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700474 /* Add simple ALLOW. */
Jorge Lucangeli Obesbda833c2012-07-31 16:25:56 -0700475 append_allow_syscall(head, nr);
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700476 } else {
477 /*
478 * Create and jump to the label that will hold
479 * the arg filter block.
480 */
481 unsigned int id = bpf_label_id(&labels, syscall_name);
482 struct sock_filter *nr_comp =
Jorge Lucangeli Obes565e9782016-08-05 11:03:19 -0400483 new_instr_buf(ALLOW_SYSCALL_LEN);
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700484 bpf_allow_syscall_args(nr_comp, nr, id);
485 append_filter_block(head, nr_comp, ALLOW_SYSCALL_LEN);
486
487 /* Build the arg filter block. */
488 struct filter_block *block =
Jennifer Pullmanc0bfae02016-05-26 17:00:36 -0700489 compile_section(nr, policy_line, id, &labels,
Jorge Lucangeli Obes713f6fb2016-10-03 13:03:25 -0400490 use_ret_trap);
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700491
492 if (!block)
493 return -1;
494
495 if (arg_blocks) {
496 extend_filter_block_list(arg_blocks, block);
497 } else {
498 arg_blocks = block;
499 }
500 }
501 }
502
Jorge Lucangeli Obesbda833c2012-07-31 16:25:56 -0700503 /*
Jorge Lucangeli Obes713f6fb2016-10-03 13:03:25 -0400504 * If none of the syscalls match, either fall through to KILL,
Jorge Lucangeli Obesbda833c2012-07-31 16:25:56 -0700505 * or return TRAP.
506 */
Jorge Lucangeli Obes713f6fb2016-10-03 13:03:25 -0400507 if (!use_ret_trap)
Jorge Lucangeli Obesbda833c2012-07-31 16:25:56 -0700508 append_ret_kill(head);
509 else
510 append_ret_trap(head);
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700511
512 /* Allocate the final buffer, now that we know its size. */
Jorge Lucangeli Obes565e9782016-08-05 11:03:19 -0400513 size_t final_filter_len =
514 head->total_len + (arg_blocks ? arg_blocks->total_len : 0);
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700515 if (final_filter_len > BPF_MAXINSNS)
516 return -1;
517
518 struct sock_filter *final_filter =
Jorge Lucangeli Obes565e9782016-08-05 11:03:19 -0400519 calloc(final_filter_len, sizeof(struct sock_filter));
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700520
521 if (flatten_block_list(head, final_filter, 0, final_filter_len) < 0)
522 return -1;
523
Jorge Lucangeli Obes565e9782016-08-05 11:03:19 -0400524 if (flatten_block_list(arg_blocks, final_filter, head->total_len,
525 final_filter_len) < 0)
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700526 return -1;
527
528 free_block_list(head);
529 free_block_list(arg_blocks);
530
Jorge Lucangeli Obes8cc9d4a2016-10-03 10:00:57 -0400531 if (bpf_resolve_jumps(&labels, final_filter, final_filter_len) < 0)
532 return -1;
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700533
534 free_label_strings(&labels);
535
536 prog->filter = final_filter;
537 prog->len = final_filter_len;
538 return 0;
539}
540
541int flatten_block_list(struct filter_block *head, struct sock_filter *filter,
Jorge Lucangeli Obes565e9782016-08-05 11:03:19 -0400542 size_t index, size_t cap)
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700543{
544 size_t _index = index;
545
546 struct filter_block *curr;
547 size_t i;
548
549 for (curr = head; curr; curr = curr->next) {
550 for (i = 0; i < curr->len; i++) {
551 if (_index >= cap)
552 return -1;
553 filter[_index++] = curr->instrs[i];
554 }
555 }
556 return 0;
557}
558
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700559void free_block_list(struct filter_block *head)
560{
561 struct filter_block *current, *prev;
562
563 current = head;
564 while (current) {
565 free(current->instrs);
566 prev = current;
567 current = current->next;
568 free(prev);
569 }
570}