Jorge Lucangeli Obes | d613ab2 | 2015-03-03 14:22:50 -0800 | [diff] [blame] | 1 | /* Copyright (c) 2012 The Chromium OS Authors. All rights reserved. |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 2 | * Use of this source code is governed by a BSD-style license that can be |
Will Drewry | 32ac9f5 | 2011-08-18 21:36:27 -0500 | [diff] [blame] | 3 | * found in the LICENSE file. |
| 4 | */ |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 5 | |
| 6 | #define _BSD_SOURCE |
| 7 | #define _GNU_SOURCE |
Jorge Lucangeli Obes | c2c9bcc | 2012-05-01 09:30:24 -0700 | [diff] [blame] | 8 | |
Jorge Lucangeli Obes | 524c040 | 2012-01-17 11:30:23 -0800 | [diff] [blame] | 9 | #include <asm/unistd.h> |
Will Drewry | 32ac9f5 | 2011-08-18 21:36:27 -0500 | [diff] [blame] | 10 | #include <ctype.h> |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 11 | #include <errno.h> |
Jorge Lucangeli Obes | 1563b5b | 2014-07-10 07:01:53 -0700 | [diff] [blame] | 12 | #include <fcntl.h> |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 13 | #include <grp.h> |
| 14 | #include <inttypes.h> |
Will Drewry | fe4a372 | 2011-09-16 14:50:50 -0500 | [diff] [blame] | 15 | #include <limits.h> |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 16 | #include <linux/capability.h> |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 17 | #include <pwd.h> |
| 18 | #include <sched.h> |
| 19 | #include <signal.h> |
Will Drewry | 2f54b6a | 2011-09-16 13:45:31 -0500 | [diff] [blame] | 20 | #include <stdarg.h> |
Jorge Lucangeli Obes | 5471450 | 2015-09-30 10:08:45 -0700 | [diff] [blame] | 21 | #include <stdbool.h> |
Jorge Lucangeli Obes | 524c040 | 2012-01-17 11:30:23 -0800 | [diff] [blame] | 22 | #include <stddef.h> |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 23 | #include <stdio.h> |
| 24 | #include <stdlib.h> |
| 25 | #include <string.h> |
| 26 | #include <syscall.h> |
| 27 | #include <sys/capability.h> |
| 28 | #include <sys/mount.h> |
Will Drewry | f89aef5 | 2011-09-16 16:48:57 -0500 | [diff] [blame] | 29 | #include <sys/param.h> |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 30 | #include <sys/prctl.h> |
Jorge Lucangeli Obes | 1563b5b | 2014-07-10 07:01:53 -0700 | [diff] [blame] | 31 | #include <sys/stat.h> |
| 32 | #include <sys/types.h> |
Jorge Lucangeli Obes | 524c040 | 2012-01-17 11:30:23 -0800 | [diff] [blame] | 33 | #include <sys/user.h> |
Jeff Vander Stoep | 2885bef | 2016-01-11 15:22:42 -0800 | [diff] [blame] | 34 | #include <sys/utsname.h> |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 35 | #include <sys/wait.h> |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 36 | #include <unistd.h> |
| 37 | |
| 38 | #include "libminijail.h" |
| 39 | #include "libminijail-private.h" |
| 40 | |
Jorge Lucangeli Obes | a21c8fc | 2015-07-15 16:22:34 -0700 | [diff] [blame] | 41 | #include "signal_handler.h" |
Jorge Lucangeli Obes | 524c040 | 2012-01-17 11:30:23 -0800 | [diff] [blame] | 42 | #include "syscall_filter.h" |
Jorge Lucangeli Obes | a6b034d | 2012-08-07 15:29:20 -0700 | [diff] [blame] | 43 | #include "util.h" |
Jorge Lucangeli Obes | 524c040 | 2012-01-17 11:30:23 -0800 | [diff] [blame] | 44 | |
Lei Zhang | eee3155 | 2012-10-17 21:27:10 -0700 | [diff] [blame] | 45 | #ifdef HAVE_SECUREBITS_H |
| 46 | #include <linux/securebits.h> |
| 47 | #else |
| 48 | #define SECURE_ALL_BITS 0x15 |
| 49 | #define SECURE_ALL_LOCKS (SECURE_ALL_BITS << 1) |
| 50 | #endif |
| 51 | |
Will Drewry | 32ac9f5 | 2011-08-18 21:36:27 -0500 | [diff] [blame] | 52 | /* Until these are reliably available in linux/prctl.h */ |
Jorge Lucangeli Obes | 524c040 | 2012-01-17 11:30:23 -0800 | [diff] [blame] | 53 | #ifndef PR_SET_SECCOMP |
Jorge Lucangeli Obes | c2c9bcc | 2012-05-01 09:30:24 -0700 | [diff] [blame] | 54 | # define PR_SET_SECCOMP 22 |
Jorge Lucangeli Obes | 524c040 | 2012-01-17 11:30:23 -0800 | [diff] [blame] | 55 | #endif |
| 56 | |
Andrew Bresticker | eac2894 | 2015-11-11 16:04:46 -0800 | [diff] [blame] | 57 | #ifndef PR_ALT_SYSCALL |
| 58 | # define PR_ALT_SYSCALL 0x43724f53 |
| 59 | #endif |
| 60 | |
Jorge Lucangeli Obes | 524c040 | 2012-01-17 11:30:23 -0800 | [diff] [blame] | 61 | /* For seccomp_filter using BPF. */ |
| 62 | #ifndef PR_SET_NO_NEW_PRIVS |
| 63 | # define PR_SET_NO_NEW_PRIVS 38 |
| 64 | #endif |
| 65 | #ifndef SECCOMP_MODE_FILTER |
| 66 | # define SECCOMP_MODE_FILTER 2 /* uses user-supplied filter. */ |
Will Drewry | 32ac9f5 | 2011-08-18 21:36:27 -0500 | [diff] [blame] | 67 | #endif |
| 68 | |
Utkarsh Sanghi | 0ef8a66 | 2014-08-18 15:50:11 -0700 | [diff] [blame] | 69 | #ifdef USE_SECCOMP_SOFTFAIL |
| 70 | # define SECCOMP_SOFTFAIL 1 |
| 71 | #else |
| 72 | # define SECCOMP_SOFTFAIL 0 |
| 73 | #endif |
| 74 | |
Dylan Reid | 605ce7f | 2016-01-19 19:21:00 -0800 | [diff] [blame] | 75 | #define MAX_CGROUPS 10 /* 10 different controllers supported by Linux. */ |
| 76 | |
Dylan Reid | 648b220 | 2015-10-23 00:50:00 -0700 | [diff] [blame] | 77 | struct mountpoint { |
Elly Jones | 51a5b6c | 2011-10-12 19:09:26 -0400 | [diff] [blame] | 78 | char *src; |
| 79 | char *dest; |
Dylan Reid | 648b220 | 2015-10-23 00:50:00 -0700 | [diff] [blame] | 80 | char *type; |
| 81 | unsigned long flags; |
| 82 | struct mountpoint *next; |
Elly Jones | 51a5b6c | 2011-10-12 19:09:26 -0400 | [diff] [blame] | 83 | }; |
| 84 | |
Will Drewry | f89aef5 | 2011-09-16 16:48:57 -0500 | [diff] [blame] | 85 | struct minijail { |
Jorge Lucangeli Obes | 4ae30cc | 2014-04-10 15:35:33 -0700 | [diff] [blame] | 86 | /* |
Jorge Lucangeli Obes | c8b21e1 | 2014-06-13 14:26:16 -0700 | [diff] [blame] | 87 | * WARNING: if you add a flag here you need to make sure it's |
| 88 | * accounted for in minijail_pre{enter|exec}() below. |
Jorge Lucangeli Obes | 4ae30cc | 2014-04-10 15:35:33 -0700 | [diff] [blame] | 89 | */ |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 90 | struct { |
| 91 | int uid:1; |
| 92 | int gid:1; |
Jorge Lucangeli Obes | d16ac49 | 2015-12-03 14:44:35 -0800 | [diff] [blame] | 93 | int usergroups:1; |
| 94 | int suppl_gids:1; |
Jorge Lucangeli Obes | f9fcdbe | 2016-02-19 15:04:09 -0800 | [diff] [blame] | 95 | int use_caps:1; |
| 96 | int capbset_drop:1; |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 97 | int vfs:1; |
Jorge Lucangeli Obes | 1563b5b | 2014-07-10 07:01:53 -0700 | [diff] [blame] | 98 | int enter_vfs:1; |
Jorge Lucangeli Obes | a521bee | 2016-03-03 13:47:57 -0800 | [diff] [blame] | 99 | int skip_remount_private:1; |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 100 | int pids:1; |
Dylan Reid | f794247 | 2015-11-18 17:55:26 -0800 | [diff] [blame] | 101 | int ipc:1; |
Elly Fong-Jones | 6c08630 | 2013-03-20 17:15:28 -0400 | [diff] [blame] | 102 | int net:1; |
Dylan Reid | 1102f5a | 2015-09-15 11:52:20 -0700 | [diff] [blame] | 103 | int enter_net:1; |
Yu-Hsi Chiang | 10e9123 | 2015-08-05 14:40:45 +0800 | [diff] [blame] | 104 | int userns:1; |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 105 | int seccomp:1; |
Dylan Reid | 791f577 | 2015-09-14 20:02:42 -0700 | [diff] [blame] | 106 | int remount_proc_ro:1; |
Jorge Lucangeli Obes | c2c9bcc | 2012-05-01 09:30:24 -0700 | [diff] [blame] | 107 | int no_new_privs:1; |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 108 | int seccomp_filter:1; |
Jorge Lucangeli Obes | bda833c | 2012-07-31 16:25:56 -0700 | [diff] [blame] | 109 | int log_seccomp_filter:1; |
Elly Jones | 51a5b6c | 2011-10-12 19:09:26 -0400 | [diff] [blame] | 110 | int chroot:1; |
Yu-Hsi Chiang | 64d65a7 | 2015-08-13 17:43:27 +0800 | [diff] [blame] | 111 | int pivot_root:1; |
Lee Campbell | 11af062 | 2014-05-22 12:36:04 -0700 | [diff] [blame] | 112 | int mount_tmp:1; |
Yu-Hsi Chiang | 3e954ec | 2015-07-28 16:48:14 +0800 | [diff] [blame] | 113 | int do_init:1; |
Yu-Hsi Chiang | 3cc05ea | 2015-08-11 11:23:17 +0800 | [diff] [blame] | 114 | int pid_file:1; |
Jorge Lucangeli Obes | b8a5138 | 2016-01-25 20:08:22 -0800 | [diff] [blame] | 115 | int cgroups:1; |
Andrew Bresticker | eac2894 | 2015-11-11 16:04:46 -0800 | [diff] [blame] | 116 | int alt_syscall:1; |
Peter Qiu | 2860c46 | 2015-12-16 15:13:06 -0800 | [diff] [blame] | 117 | int reset_signal_mask:1; |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 118 | } flags; |
| 119 | uid_t uid; |
| 120 | gid_t gid; |
| 121 | gid_t usergid; |
| 122 | char *user; |
Jorge Lucangeli Obes | d16ac49 | 2015-12-03 14:44:35 -0800 | [diff] [blame] | 123 | size_t suppl_gid_count; |
| 124 | gid_t *suppl_gid_list; |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 125 | uint64_t caps; |
Jorge Lucangeli Obes | f9fcdbe | 2016-02-19 15:04:09 -0800 | [diff] [blame] | 126 | uint64_t cap_bset; |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 127 | pid_t initpid; |
Jorge Lucangeli Obes | 1563b5b | 2014-07-10 07:01:53 -0700 | [diff] [blame] | 128 | int mountns_fd; |
Dylan Reid | 1102f5a | 2015-09-15 11:52:20 -0700 | [diff] [blame] | 129 | int netns_fd; |
Elly Jones | 51a5b6c | 2011-10-12 19:09:26 -0400 | [diff] [blame] | 130 | char *chrootdir; |
Yu-Hsi Chiang | 3cc05ea | 2015-08-11 11:23:17 +0800 | [diff] [blame] | 131 | char *pid_file_path; |
Yu-Hsi Chiang | 10e9123 | 2015-08-05 14:40:45 +0800 | [diff] [blame] | 132 | char *uidmap; |
| 133 | char *gidmap; |
Jorge Lucangeli Obes | c2ba9f5 | 2015-12-01 07:58:10 -0800 | [diff] [blame] | 134 | size_t filter_len; |
Jorge Lucangeli Obes | 524c040 | 2012-01-17 11:30:23 -0800 | [diff] [blame] | 135 | struct sock_fprog *filter_prog; |
Jorge Lucangeli Obes | c2ba9f5 | 2015-12-01 07:58:10 -0800 | [diff] [blame] | 136 | char *alt_syscall_table; |
Dylan Reid | 648b220 | 2015-10-23 00:50:00 -0700 | [diff] [blame] | 137 | struct mountpoint *mounts_head; |
| 138 | struct mountpoint *mounts_tail; |
Jorge Lucangeli Obes | c2ba9f5 | 2015-12-01 07:58:10 -0800 | [diff] [blame] | 139 | size_t mounts_count; |
Dylan Reid | 605ce7f | 2016-01-19 19:21:00 -0800 | [diff] [blame] | 140 | char *cgroups[MAX_CGROUPS]; |
| 141 | size_t cgroup_count; |
Will Drewry | f89aef5 | 2011-09-16 16:48:57 -0500 | [diff] [blame] | 142 | }; |
| 143 | |
Jorge Lucangeli Obes | 4ae30cc | 2014-04-10 15:35:33 -0700 | [diff] [blame] | 144 | /* |
| 145 | * Strip out flags meant for the parent. |
| 146 | * We keep things that are not inherited across execve(2) (e.g. capabilities), |
| 147 | * or are easier to set after execve(2) (e.g. seccomp filters). |
| 148 | */ |
| 149 | void minijail_preenter(struct minijail *j) |
| 150 | { |
| 151 | j->flags.vfs = 0; |
Jorge Lucangeli Obes | 1563b5b | 2014-07-10 07:01:53 -0700 | [diff] [blame] | 152 | j->flags.enter_vfs = 0; |
Shuhei Takahashi | 3da4031 | 2016-03-07 17:37:49 +0900 | [diff] [blame] | 153 | j->flags.skip_remount_private = 0; |
Dylan Reid | 791f577 | 2015-09-14 20:02:42 -0700 | [diff] [blame] | 154 | j->flags.remount_proc_ro = 0; |
Jorge Lucangeli Obes | 4ae30cc | 2014-04-10 15:35:33 -0700 | [diff] [blame] | 155 | j->flags.pids = 0; |
Yu-Hsi Chiang | 3e954ec | 2015-07-28 16:48:14 +0800 | [diff] [blame] | 156 | j->flags.do_init = 0; |
Yu-Hsi Chiang | 3cc05ea | 2015-08-11 11:23:17 +0800 | [diff] [blame] | 157 | j->flags.pid_file = 0; |
Jorge Lucangeli Obes | b8a5138 | 2016-01-25 20:08:22 -0800 | [diff] [blame] | 158 | j->flags.cgroups = 0; |
Jorge Lucangeli Obes | 4ae30cc | 2014-04-10 15:35:33 -0700 | [diff] [blame] | 159 | } |
| 160 | |
| 161 | /* |
| 162 | * Strip out flags meant for the child. |
| 163 | * We keep things that are inherited across execve(2). |
| 164 | */ |
| 165 | void minijail_preexec(struct minijail *j) |
| 166 | { |
| 167 | int vfs = j->flags.vfs; |
Jorge Lucangeli Obes | 1563b5b | 2014-07-10 07:01:53 -0700 | [diff] [blame] | 168 | int enter_vfs = j->flags.enter_vfs; |
Jorge Lucangeli Obes | 87bf01d | 2016-03-08 11:20:03 -0800 | [diff] [blame] | 169 | int skip_remount_private = j->flags.skip_remount_private; |
Dylan Reid | 791f577 | 2015-09-14 20:02:42 -0700 | [diff] [blame] | 170 | int remount_proc_ro = j->flags.remount_proc_ro; |
Yu-Hsi Chiang | 10e9123 | 2015-08-05 14:40:45 +0800 | [diff] [blame] | 171 | int userns = j->flags.userns; |
Jorge Lucangeli Obes | 4ae30cc | 2014-04-10 15:35:33 -0700 | [diff] [blame] | 172 | if (j->user) |
| 173 | free(j->user); |
| 174 | j->user = NULL; |
Jorge Lucangeli Obes | e81a52f | 2015-12-04 16:05:23 -0800 | [diff] [blame] | 175 | if (j->suppl_gid_list) |
| 176 | free(j->suppl_gid_list); |
| 177 | j->suppl_gid_list = NULL; |
Jorge Lucangeli Obes | 4ae30cc | 2014-04-10 15:35:33 -0700 | [diff] [blame] | 178 | memset(&j->flags, 0, sizeof(j->flags)); |
| 179 | /* Now restore anything we meant to keep. */ |
| 180 | j->flags.vfs = vfs; |
Jorge Lucangeli Obes | 1563b5b | 2014-07-10 07:01:53 -0700 | [diff] [blame] | 181 | j->flags.enter_vfs = enter_vfs; |
Jorge Lucangeli Obes | 87bf01d | 2016-03-08 11:20:03 -0800 | [diff] [blame] | 182 | j->flags.skip_remount_private = skip_remount_private; |
Dylan Reid | 791f577 | 2015-09-14 20:02:42 -0700 | [diff] [blame] | 183 | j->flags.remount_proc_ro = remount_proc_ro; |
Yu-Hsi Chiang | 10e9123 | 2015-08-05 14:40:45 +0800 | [diff] [blame] | 184 | j->flags.userns = userns; |
Jorge Lucangeli Obes | 4ae30cc | 2014-04-10 15:35:33 -0700 | [diff] [blame] | 185 | /* Note, |pids| will already have been used before this call. */ |
| 186 | } |
| 187 | |
Jorge Lucangeli Obes | 272e3ab | 2016-01-12 21:18:59 -0800 | [diff] [blame] | 188 | /* Returns true if the kernel version is less than 3.8. */ |
| 189 | int seccomp_kernel_support_not_required() |
Jeff Vander Stoep | 2885bef | 2016-01-11 15:22:42 -0800 | [diff] [blame] | 190 | { |
| 191 | int major, minor; |
| 192 | struct utsname uts; |
| 193 | return (uname(&uts) != -1 && |
| 194 | sscanf(uts.release, "%d.%d", &major, &minor) == 2 && |
| 195 | ((major < 3) || ((major == 3) && (minor < 8)))); |
| 196 | } |
| 197 | |
Jorge Lucangeli Obes | 272e3ab | 2016-01-12 21:18:59 -0800 | [diff] [blame] | 198 | /* Allow seccomp soft-fail on Android devices with kernel version < 3.8. */ |
| 199 | int can_softfail() |
Jeff Vander Stoep | 2885bef | 2016-01-11 15:22:42 -0800 | [diff] [blame] | 200 | { |
| 201 | #if SECCOMP_SOFTFAIL |
| 202 | if (is_android()) { |
| 203 | if (seccomp_kernel_support_not_required()) |
| 204 | return 1; |
| 205 | else |
| 206 | return 0; |
| 207 | } else { |
| 208 | return 1; |
| 209 | } |
| 210 | #endif |
| 211 | return 0; |
| 212 | } |
| 213 | |
Jorge Lucangeli Obes | 4ae30cc | 2014-04-10 15:35:33 -0700 | [diff] [blame] | 214 | /* Minijail API. */ |
| 215 | |
Will Drewry | 6ac9112 | 2011-10-21 16:38:58 -0500 | [diff] [blame] | 216 | struct minijail API *minijail_new(void) |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 217 | { |
Elly Jones | 51a5b6c | 2011-10-12 19:09:26 -0400 | [diff] [blame] | 218 | return calloc(1, sizeof(struct minijail)); |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 219 | } |
| 220 | |
Will Drewry | 6ac9112 | 2011-10-21 16:38:58 -0500 | [diff] [blame] | 221 | void API minijail_change_uid(struct minijail *j, uid_t uid) |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 222 | { |
| 223 | if (uid == 0) |
| 224 | die("useless change to uid 0"); |
| 225 | j->uid = uid; |
| 226 | j->flags.uid = 1; |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 227 | } |
| 228 | |
Will Drewry | 6ac9112 | 2011-10-21 16:38:58 -0500 | [diff] [blame] | 229 | void API minijail_change_gid(struct minijail *j, gid_t gid) |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 230 | { |
| 231 | if (gid == 0) |
| 232 | die("useless change to gid 0"); |
| 233 | j->gid = gid; |
| 234 | j->flags.gid = 1; |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 235 | } |
| 236 | |
Jorge Lucangeli Obes | bc67f44 | 2016-01-08 14:43:45 -0800 | [diff] [blame] | 237 | void API minijail_set_supplementary_gids(struct minijail *j, size_t size, |
| 238 | const gid_t *list) |
Jorge Lucangeli Obes | d16ac49 | 2015-12-03 14:44:35 -0800 | [diff] [blame] | 239 | { |
Jorge Lucangeli Obes | 06940be | 2015-12-04 18:09:21 -0800 | [diff] [blame] | 240 | size_t i; |
| 241 | |
Jorge Lucangeli Obes | d16ac49 | 2015-12-03 14:44:35 -0800 | [diff] [blame] | 242 | if (j->flags.usergroups) |
| 243 | die("cannot inherit *and* set supplementary groups"); |
| 244 | |
Jorge Lucangeli Obes | fd5fc56 | 2016-01-08 10:29:27 -0800 | [diff] [blame] | 245 | if (size == 0) { |
| 246 | /* Clear supplementary groups. */ |
| 247 | j->suppl_gid_list = NULL; |
| 248 | j->suppl_gid_count = 0; |
| 249 | j->flags.suppl_gids = 1; |
Jorge Lucangeli Obes | bc67f44 | 2016-01-08 14:43:45 -0800 | [diff] [blame] | 250 | return; |
Jorge Lucangeli Obes | fd5fc56 | 2016-01-08 10:29:27 -0800 | [diff] [blame] | 251 | } |
Jorge Lucangeli Obes | d16ac49 | 2015-12-03 14:44:35 -0800 | [diff] [blame] | 252 | |
| 253 | /* Copy the gid_t array. */ |
| 254 | j->suppl_gid_list = calloc(size, sizeof(gid_t)); |
| 255 | if (!j->suppl_gid_list) { |
Jorge Lucangeli Obes | fd5fc56 | 2016-01-08 10:29:27 -0800 | [diff] [blame] | 256 | die("failed to allocate internal supplementary group array"); |
Jorge Lucangeli Obes | d16ac49 | 2015-12-03 14:44:35 -0800 | [diff] [blame] | 257 | } |
Jorge Lucangeli Obes | 06940be | 2015-12-04 18:09:21 -0800 | [diff] [blame] | 258 | for (i = 0; i < size; i++) { |
Jorge Lucangeli Obes | d16ac49 | 2015-12-03 14:44:35 -0800 | [diff] [blame] | 259 | j->suppl_gid_list[i] = list[i]; |
| 260 | } |
| 261 | j->suppl_gid_count = size; |
| 262 | j->flags.suppl_gids = 1; |
Jorge Lucangeli Obes | d16ac49 | 2015-12-03 14:44:35 -0800 | [diff] [blame] | 263 | } |
| 264 | |
Will Drewry | 6ac9112 | 2011-10-21 16:38:58 -0500 | [diff] [blame] | 265 | int API minijail_change_user(struct minijail *j, const char *user) |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 266 | { |
| 267 | char *buf = NULL; |
| 268 | struct passwd pw; |
| 269 | struct passwd *ppw = NULL; |
| 270 | ssize_t sz = sysconf(_SC_GETPW_R_SIZE_MAX); |
| 271 | if (sz == -1) |
| 272 | sz = 65536; /* your guess is as good as mine... */ |
Elly Jones | eb300c5 | 2011-09-22 14:35:43 -0400 | [diff] [blame] | 273 | |
Elly Jones | dd3e851 | 2012-01-23 15:13:38 -0500 | [diff] [blame] | 274 | /* |
| 275 | * sysconf(_SC_GETPW_R_SIZE_MAX), under glibc, is documented to return |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 276 | * the maximum needed size of the buffer, so we don't have to search. |
| 277 | */ |
| 278 | buf = malloc(sz); |
| 279 | if (!buf) |
| 280 | return -ENOMEM; |
| 281 | getpwnam_r(user, &pw, buf, sz, &ppw); |
Elly Jones | dd3e851 | 2012-01-23 15:13:38 -0500 | [diff] [blame] | 282 | /* |
Jorge Lucangeli Obes | b8a5138 | 2016-01-25 20:08:22 -0800 | [diff] [blame] | 283 | * We're safe to free the buffer here. The strings inside |pw| point |
| 284 | * inside |buf|, but we don't use any of them; this leaves the pointers |
Jorge Lucangeli Obes | 87bf01d | 2016-03-08 11:20:03 -0800 | [diff] [blame] | 285 | * dangling but it's safe. |ppw| points at |pw| if getpwnam_r(3) |
| 286 | * succeeded. |
Elly Jones | dd3e851 | 2012-01-23 15:13:38 -0500 | [diff] [blame] | 287 | */ |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 288 | free(buf); |
Jorge Lucangeli Obes | 4e48065 | 2014-03-26 10:56:42 -0700 | [diff] [blame] | 289 | /* getpwnam_r(3) does *not* set errno when |ppw| is NULL. */ |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 290 | if (!ppw) |
Jorge Lucangeli Obes | 4e48065 | 2014-03-26 10:56:42 -0700 | [diff] [blame] | 291 | return -1; |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 292 | minijail_change_uid(j, ppw->pw_uid); |
| 293 | j->user = strdup(user); |
| 294 | if (!j->user) |
| 295 | return -ENOMEM; |
| 296 | j->usergid = ppw->pw_gid; |
| 297 | return 0; |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 298 | } |
| 299 | |
Will Drewry | 6ac9112 | 2011-10-21 16:38:58 -0500 | [diff] [blame] | 300 | int API minijail_change_group(struct minijail *j, const char *group) |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 301 | { |
Jorge Lucangeli Obes | a21c8fc | 2015-07-15 16:22:34 -0700 | [diff] [blame] | 302 | char *buf = NULL; |
Yabin Cui | 1b21c8f | 2015-07-22 10:34:45 -0700 | [diff] [blame] | 303 | struct group gr; |
| 304 | struct group *pgr = NULL; |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 305 | ssize_t sz = sysconf(_SC_GETGR_R_SIZE_MAX); |
| 306 | if (sz == -1) |
| 307 | sz = 65536; /* and mine is as good as yours, really */ |
Elly Jones | eb300c5 | 2011-09-22 14:35:43 -0400 | [diff] [blame] | 308 | |
Elly Jones | dd3e851 | 2012-01-23 15:13:38 -0500 | [diff] [blame] | 309 | /* |
| 310 | * sysconf(_SC_GETGR_R_SIZE_MAX), under glibc, is documented to return |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 311 | * the maximum needed size of the buffer, so we don't have to search. |
| 312 | */ |
| 313 | buf = malloc(sz); |
| 314 | if (!buf) |
| 315 | return -ENOMEM; |
| 316 | getgrnam_r(group, &gr, buf, sz, &pgr); |
Elly Jones | dd3e851 | 2012-01-23 15:13:38 -0500 | [diff] [blame] | 317 | /* |
| 318 | * We're safe to free the buffer here. The strings inside gr point |
| 319 | * inside buf, but we don't use any of them; this leaves the pointers |
| 320 | * dangling but it's safe. pgr points at gr if getgrnam_r succeeded. |
| 321 | */ |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 322 | free(buf); |
Jorge Lucangeli Obes | 4e48065 | 2014-03-26 10:56:42 -0700 | [diff] [blame] | 323 | /* getgrnam_r(3) does *not* set errno when |pgr| is NULL. */ |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 324 | if (!pgr) |
Jorge Lucangeli Obes | 4e48065 | 2014-03-26 10:56:42 -0700 | [diff] [blame] | 325 | return -1; |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 326 | minijail_change_gid(j, pgr->gr_gid); |
| 327 | return 0; |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 328 | } |
| 329 | |
Will Drewry | 6ac9112 | 2011-10-21 16:38:58 -0500 | [diff] [blame] | 330 | void API minijail_use_seccomp(struct minijail *j) |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 331 | { |
| 332 | j->flags.seccomp = 1; |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 333 | } |
| 334 | |
Jorge Lucangeli Obes | c2c9bcc | 2012-05-01 09:30:24 -0700 | [diff] [blame] | 335 | void API minijail_no_new_privs(struct minijail *j) |
| 336 | { |
| 337 | j->flags.no_new_privs = 1; |
| 338 | } |
| 339 | |
Will Drewry | 6ac9112 | 2011-10-21 16:38:58 -0500 | [diff] [blame] | 340 | void API minijail_use_seccomp_filter(struct minijail *j) |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 341 | { |
| 342 | j->flags.seccomp_filter = 1; |
Will Drewry | 32ac9f5 | 2011-08-18 21:36:27 -0500 | [diff] [blame] | 343 | } |
| 344 | |
Jorge Lucangeli Obes | bda833c | 2012-07-31 16:25:56 -0700 | [diff] [blame] | 345 | void API minijail_log_seccomp_filter_failures(struct minijail *j) |
| 346 | { |
| 347 | j->flags.log_seccomp_filter = 1; |
| 348 | } |
| 349 | |
Will Drewry | 6ac9112 | 2011-10-21 16:38:58 -0500 | [diff] [blame] | 350 | void API minijail_use_caps(struct minijail *j, uint64_t capmask) |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 351 | { |
Jorge Lucangeli Obes | f9fcdbe | 2016-02-19 15:04:09 -0800 | [diff] [blame] | 352 | /* |
| 353 | * 'minijail_use_caps' configures a runtime-capabilities-only |
| 354 | * environment, including a bounding set matching the thread's runtime |
| 355 | * (permitted|inheritable|effective) sets. |
| 356 | * Therefore, it will override any existing bounding set configurations |
| 357 | * since the latter would allow gaining extra runtime capabilities from |
| 358 | * file capabilities. |
| 359 | */ |
| 360 | if (j->flags.capbset_drop) { |
| 361 | warn("overriding bounding set configuration"); |
| 362 | j->cap_bset = 0; |
| 363 | j->flags.capbset_drop = 0; |
| 364 | } |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 365 | j->caps = capmask; |
Jorge Lucangeli Obes | f9fcdbe | 2016-02-19 15:04:09 -0800 | [diff] [blame] | 366 | j->flags.use_caps = 1; |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 367 | } |
| 368 | |
Jorge Lucangeli Obes | f9fcdbe | 2016-02-19 15:04:09 -0800 | [diff] [blame] | 369 | void API minijail_capbset_drop(struct minijail *j, uint64_t capmask) |
| 370 | { |
| 371 | if (j->flags.use_caps) { |
| 372 | /* |
| 373 | * 'minijail_use_caps' will have already configured a capability |
| 374 | * bounding set matching the (permitted|inheritable|effective) |
| 375 | * sets. Abort if the user tries to configure a separate |
| 376 | * bounding set. 'minijail_capbset_drop' and 'minijail_use_caps' |
| 377 | * are mutually exclusive. |
| 378 | */ |
| 379 | die("runtime capabilities already configured, can't drop " |
| 380 | "bounding set separately"); |
| 381 | } |
| 382 | j->cap_bset = capmask; |
| 383 | j->flags.capbset_drop = 1; |
| 384 | } |
| 385 | |
| 386 | void API minijail_reset_signal_mask(struct minijail *j) |
| 387 | { |
Peter Qiu | 2860c46 | 2015-12-16 15:13:06 -0800 | [diff] [blame] | 388 | j->flags.reset_signal_mask = 1; |
| 389 | } |
| 390 | |
Will Drewry | 6ac9112 | 2011-10-21 16:38:58 -0500 | [diff] [blame] | 391 | void API minijail_namespace_vfs(struct minijail *j) |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 392 | { |
| 393 | j->flags.vfs = 1; |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 394 | } |
| 395 | |
Jorge Lucangeli Obes | 1563b5b | 2014-07-10 07:01:53 -0700 | [diff] [blame] | 396 | void API minijail_namespace_enter_vfs(struct minijail *j, const char *ns_path) |
| 397 | { |
Ricky Zhou | bce609d | 2016-03-02 21:47:56 -0800 | [diff] [blame] | 398 | int ns_fd = open(ns_path, O_RDONLY | O_CLOEXEC); |
Jorge Lucangeli Obes | 1563b5b | 2014-07-10 07:01:53 -0700 | [diff] [blame] | 399 | if (ns_fd < 0) { |
| 400 | pdie("failed to open namespace '%s'", ns_path); |
| 401 | } |
| 402 | j->mountns_fd = ns_fd; |
| 403 | j->flags.enter_vfs = 1; |
| 404 | } |
| 405 | |
Jorge Lucangeli Obes | a521bee | 2016-03-03 13:47:57 -0800 | [diff] [blame] | 406 | void API minijail_skip_remount_private(struct minijail *j) |
| 407 | { |
| 408 | j->flags.skip_remount_private = 1; |
| 409 | } |
| 410 | |
Will Drewry | 6ac9112 | 2011-10-21 16:38:58 -0500 | [diff] [blame] | 411 | void API minijail_namespace_pids(struct minijail *j) |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 412 | { |
Elly Jones | e58176c | 2012-01-23 11:46:17 -0500 | [diff] [blame] | 413 | j->flags.vfs = 1; |
Dylan Reid | 791f577 | 2015-09-14 20:02:42 -0700 | [diff] [blame] | 414 | j->flags.remount_proc_ro = 1; |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 415 | j->flags.pids = 1; |
Yu-Hsi Chiang | 3e954ec | 2015-07-28 16:48:14 +0800 | [diff] [blame] | 416 | j->flags.do_init = 1; |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 417 | } |
| 418 | |
Dylan Reid | f794247 | 2015-11-18 17:55:26 -0800 | [diff] [blame] | 419 | void API minijail_namespace_ipc(struct minijail *j) |
| 420 | { |
| 421 | j->flags.ipc = 1; |
| 422 | } |
| 423 | |
Elly Fong-Jones | 6c08630 | 2013-03-20 17:15:28 -0400 | [diff] [blame] | 424 | void API minijail_namespace_net(struct minijail *j) |
| 425 | { |
| 426 | j->flags.net = 1; |
| 427 | } |
| 428 | |
Dylan Reid | 1102f5a | 2015-09-15 11:52:20 -0700 | [diff] [blame] | 429 | void API minijail_namespace_enter_net(struct minijail *j, const char *ns_path) |
| 430 | { |
Ricky Zhou | bce609d | 2016-03-02 21:47:56 -0800 | [diff] [blame] | 431 | int ns_fd = open(ns_path, O_RDONLY | O_CLOEXEC); |
Dylan Reid | 1102f5a | 2015-09-15 11:52:20 -0700 | [diff] [blame] | 432 | if (ns_fd < 0) { |
| 433 | pdie("failed to open namespace '%s'", ns_path); |
| 434 | } |
| 435 | j->netns_fd = ns_fd; |
| 436 | j->flags.enter_net = 1; |
| 437 | } |
| 438 | |
Dylan Reid | 791f577 | 2015-09-14 20:02:42 -0700 | [diff] [blame] | 439 | void API minijail_remount_proc_readonly(struct minijail *j) |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 440 | { |
| 441 | j->flags.vfs = 1; |
Dylan Reid | 791f577 | 2015-09-14 20:02:42 -0700 | [diff] [blame] | 442 | j->flags.remount_proc_ro = 1; |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 443 | } |
| 444 | |
Yu-Hsi Chiang | 10e9123 | 2015-08-05 14:40:45 +0800 | [diff] [blame] | 445 | void API minijail_namespace_user(struct minijail *j) |
| 446 | { |
| 447 | j->flags.userns = 1; |
| 448 | } |
| 449 | |
| 450 | int API minijail_uidmap(struct minijail *j, const char *uidmap) |
| 451 | { |
| 452 | j->uidmap = strdup(uidmap); |
| 453 | if (!j->uidmap) |
| 454 | return -ENOMEM; |
Yu-Hsi Chiang | 1912c5b | 2015-08-31 18:59:49 +0800 | [diff] [blame] | 455 | char *ch; |
| 456 | for (ch = j->uidmap; *ch; ch++) { |
| 457 | if (*ch == ',') |
| 458 | *ch = '\n'; |
| 459 | } |
Yu-Hsi Chiang | 10e9123 | 2015-08-05 14:40:45 +0800 | [diff] [blame] | 460 | return 0; |
| 461 | } |
| 462 | |
| 463 | int API minijail_gidmap(struct minijail *j, const char *gidmap) |
| 464 | { |
| 465 | j->gidmap = strdup(gidmap); |
| 466 | if (!j->gidmap) |
| 467 | return -ENOMEM; |
Yu-Hsi Chiang | 1912c5b | 2015-08-31 18:59:49 +0800 | [diff] [blame] | 468 | char *ch; |
| 469 | for (ch = j->gidmap; *ch; ch++) { |
| 470 | if (*ch == ',') |
| 471 | *ch = '\n'; |
| 472 | } |
Yu-Hsi Chiang | 10e9123 | 2015-08-05 14:40:45 +0800 | [diff] [blame] | 473 | return 0; |
| 474 | } |
| 475 | |
Will Drewry | 6ac9112 | 2011-10-21 16:38:58 -0500 | [diff] [blame] | 476 | void API minijail_inherit_usergroups(struct minijail *j) |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 477 | { |
| 478 | j->flags.usergroups = 1; |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 479 | } |
| 480 | |
Yu-Hsi Chiang | 3e954ec | 2015-07-28 16:48:14 +0800 | [diff] [blame] | 481 | void API minijail_run_as_init(struct minijail *j) |
| 482 | { |
| 483 | /* |
| 484 | * Since the jailed program will become 'init' in the new PID namespace, |
| 485 | * Minijail does not need to fork an 'init' process. |
| 486 | */ |
| 487 | j->flags.do_init = 0; |
| 488 | } |
| 489 | |
Jorge Lucangeli Obes | c8b21e1 | 2014-06-13 14:26:16 -0700 | [diff] [blame] | 490 | int API minijail_enter_chroot(struct minijail *j, const char *dir) |
| 491 | { |
Elly Jones | 51a5b6c | 2011-10-12 19:09:26 -0400 | [diff] [blame] | 492 | if (j->chrootdir) |
| 493 | return -EINVAL; |
| 494 | j->chrootdir = strdup(dir); |
| 495 | if (!j->chrootdir) |
| 496 | return -ENOMEM; |
| 497 | j->flags.chroot = 1; |
| 498 | return 0; |
| 499 | } |
| 500 | |
Yu-Hsi Chiang | 64d65a7 | 2015-08-13 17:43:27 +0800 | [diff] [blame] | 501 | int API minijail_enter_pivot_root(struct minijail *j, const char *dir) |
| 502 | { |
| 503 | if (j->chrootdir) |
| 504 | return -EINVAL; |
| 505 | j->chrootdir = strdup(dir); |
| 506 | if (!j->chrootdir) |
| 507 | return -ENOMEM; |
| 508 | j->flags.pivot_root = 1; |
| 509 | return 0; |
| 510 | } |
| 511 | |
Dylan Reid | a14e08d | 2015-10-22 21:05:29 -0700 | [diff] [blame] | 512 | static char *append_external_path(const char *external_path, |
| 513 | const char *path_inside_chroot) |
Dylan Reid | 08946cc | 2015-09-16 19:10:57 -0700 | [diff] [blame] | 514 | { |
Dylan Reid | a14e08d | 2015-10-22 21:05:29 -0700 | [diff] [blame] | 515 | char *path; |
Dylan Reid | 08946cc | 2015-09-16 19:10:57 -0700 | [diff] [blame] | 516 | size_t pathlen; |
| 517 | |
Dylan Reid | 08946cc | 2015-09-16 19:10:57 -0700 | [diff] [blame] | 518 | /* One extra char for '/' and one for '\0', hence + 2. */ |
Dylan Reid | a14e08d | 2015-10-22 21:05:29 -0700 | [diff] [blame] | 519 | pathlen = strlen(path_inside_chroot) + strlen(external_path) + 2; |
| 520 | path = malloc(pathlen); |
| 521 | snprintf(path, pathlen, "%s/%s", external_path, path_inside_chroot); |
Dylan Reid | 08946cc | 2015-09-16 19:10:57 -0700 | [diff] [blame] | 522 | |
Dylan Reid | a14e08d | 2015-10-22 21:05:29 -0700 | [diff] [blame] | 523 | return path; |
| 524 | } |
| 525 | |
| 526 | char API *minijail_get_original_path(struct minijail *j, |
| 527 | const char *path_inside_chroot) |
| 528 | { |
Dylan Reid | 648b220 | 2015-10-23 00:50:00 -0700 | [diff] [blame] | 529 | struct mountpoint *b; |
Dylan Reid | a14e08d | 2015-10-22 21:05:29 -0700 | [diff] [blame] | 530 | |
Dylan Reid | 648b220 | 2015-10-23 00:50:00 -0700 | [diff] [blame] | 531 | b = j->mounts_head; |
Dylan Reid | a14e08d | 2015-10-22 21:05:29 -0700 | [diff] [blame] | 532 | while (b) { |
| 533 | /* |
| 534 | * If |path_inside_chroot| is the exact destination of a |
Dylan Reid | 648b220 | 2015-10-23 00:50:00 -0700 | [diff] [blame] | 535 | * mount, then the original path is exactly the source of |
| 536 | * the mount. |
Dylan Reid | a14e08d | 2015-10-22 21:05:29 -0700 | [diff] [blame] | 537 | * for example: "-b /some/path/exe,/chroot/path/exe" |
Dylan Reid | 648b220 | 2015-10-23 00:50:00 -0700 | [diff] [blame] | 538 | * mount source = /some/path/exe, mount dest = |
| 539 | * /chroot/path/exe Then when getting the original path of |
| 540 | * "/chroot/path/exe", the source of that mount, |
| 541 | * "/some/path/exe" is what should be returned. |
Dylan Reid | a14e08d | 2015-10-22 21:05:29 -0700 | [diff] [blame] | 542 | */ |
| 543 | if (!strcmp(b->dest, path_inside_chroot)) |
| 544 | return strdup(b->src); |
| 545 | |
| 546 | /* |
| 547 | * If |path_inside_chroot| is within the destination path of a |
Dylan Reid | 648b220 | 2015-10-23 00:50:00 -0700 | [diff] [blame] | 548 | * mount, take the suffix of the chroot path relative to the |
| 549 | * mount destination path, and append it to the mount source |
| 550 | * path. |
Dylan Reid | a14e08d | 2015-10-22 21:05:29 -0700 | [diff] [blame] | 551 | */ |
| 552 | if (!strncmp(b->dest, path_inside_chroot, strlen(b->dest))) { |
| 553 | const char *relative_path = |
| 554 | path_inside_chroot + strlen(b->dest); |
| 555 | return append_external_path(b->src, relative_path); |
| 556 | } |
| 557 | b = b->next; |
| 558 | } |
| 559 | |
| 560 | /* If there is a chroot path, append |path_inside_chroot| to that. */ |
| 561 | if (j->chrootdir) |
| 562 | return append_external_path(j->chrootdir, path_inside_chroot); |
| 563 | |
| 564 | /* No chroot, so the path outside is the same as it is inside. */ |
| 565 | return strdup(path_inside_chroot); |
Dylan Reid | 08946cc | 2015-09-16 19:10:57 -0700 | [diff] [blame] | 566 | } |
| 567 | |
Lee Campbell | 11af062 | 2014-05-22 12:36:04 -0700 | [diff] [blame] | 568 | void API minijail_mount_tmp(struct minijail *j) |
| 569 | { |
| 570 | j->flags.mount_tmp = 1; |
| 571 | } |
| 572 | |
Yu-Hsi Chiang | 3cc05ea | 2015-08-11 11:23:17 +0800 | [diff] [blame] | 573 | int API minijail_write_pid_file(struct minijail *j, const char *path) |
| 574 | { |
| 575 | j->pid_file_path = strdup(path); |
| 576 | if (!j->pid_file_path) |
| 577 | return -ENOMEM; |
| 578 | j->flags.pid_file = 1; |
| 579 | return 0; |
| 580 | } |
| 581 | |
Dylan Reid | 605ce7f | 2016-01-19 19:21:00 -0800 | [diff] [blame] | 582 | int API minijail_add_to_cgroup(struct minijail *j, const char *path) |
| 583 | { |
| 584 | if (j->cgroup_count >= MAX_CGROUPS) |
| 585 | return -ENOMEM; |
| 586 | j->cgroups[j->cgroup_count] = strdup(path); |
| 587 | if (!j->cgroups[j->cgroup_count]) |
| 588 | return -ENOMEM; |
| 589 | j->cgroup_count++; |
Jorge Lucangeli Obes | b8a5138 | 2016-01-25 20:08:22 -0800 | [diff] [blame] | 590 | j->flags.cgroups = 1; |
Dylan Reid | 605ce7f | 2016-01-19 19:21:00 -0800 | [diff] [blame] | 591 | return 0; |
| 592 | } |
| 593 | |
Dylan Reid | 648b220 | 2015-10-23 00:50:00 -0700 | [diff] [blame] | 594 | int API minijail_mount(struct minijail *j, const char *src, const char *dest, |
| 595 | const char *type, unsigned long flags) |
Jorge Lucangeli Obes | c8b21e1 | 2014-06-13 14:26:16 -0700 | [diff] [blame] | 596 | { |
Dylan Reid | 648b220 | 2015-10-23 00:50:00 -0700 | [diff] [blame] | 597 | struct mountpoint *m; |
Elly Jones | 51a5b6c | 2011-10-12 19:09:26 -0400 | [diff] [blame] | 598 | |
| 599 | if (*dest != '/') |
| 600 | return -EINVAL; |
Dylan Reid | 648b220 | 2015-10-23 00:50:00 -0700 | [diff] [blame] | 601 | m = calloc(1, sizeof(*m)); |
| 602 | if (!m) |
Elly Jones | 51a5b6c | 2011-10-12 19:09:26 -0400 | [diff] [blame] | 603 | return -ENOMEM; |
Dylan Reid | 648b220 | 2015-10-23 00:50:00 -0700 | [diff] [blame] | 604 | m->dest = strdup(dest); |
| 605 | if (!m->dest) |
Elly Jones | 51a5b6c | 2011-10-12 19:09:26 -0400 | [diff] [blame] | 606 | goto error; |
Dylan Reid | 648b220 | 2015-10-23 00:50:00 -0700 | [diff] [blame] | 607 | m->src = strdup(src); |
| 608 | if (!m->src) |
Elly Jones | 51a5b6c | 2011-10-12 19:09:26 -0400 | [diff] [blame] | 609 | goto error; |
Dylan Reid | 648b220 | 2015-10-23 00:50:00 -0700 | [diff] [blame] | 610 | m->type = strdup(type); |
| 611 | if (!m->type) |
| 612 | goto error; |
| 613 | m->flags = flags; |
Elly Jones | 51a5b6c | 2011-10-12 19:09:26 -0400 | [diff] [blame] | 614 | |
Jorge Lucangeli Obes | 6c755d2 | 2016-01-28 15:24:40 -0800 | [diff] [blame] | 615 | info("mount %s -> %s type '%s'", src, dest, type); |
Elly Jones | 51a5b6c | 2011-10-12 19:09:26 -0400 | [diff] [blame] | 616 | |
Elly Jones | dd3e851 | 2012-01-23 15:13:38 -0500 | [diff] [blame] | 617 | /* |
Dylan Reid | 648b220 | 2015-10-23 00:50:00 -0700 | [diff] [blame] | 618 | * Force vfs namespacing so the mounts don't leak out into the |
Elly Jones | 51a5b6c | 2011-10-12 19:09:26 -0400 | [diff] [blame] | 619 | * containing vfs namespace. |
| 620 | */ |
| 621 | minijail_namespace_vfs(j); |
| 622 | |
Dylan Reid | 648b220 | 2015-10-23 00:50:00 -0700 | [diff] [blame] | 623 | if (j->mounts_tail) |
| 624 | j->mounts_tail->next = m; |
Elly Jones | 51a5b6c | 2011-10-12 19:09:26 -0400 | [diff] [blame] | 625 | else |
Dylan Reid | 648b220 | 2015-10-23 00:50:00 -0700 | [diff] [blame] | 626 | j->mounts_head = m; |
| 627 | j->mounts_tail = m; |
| 628 | j->mounts_count++; |
Elly Jones | 51a5b6c | 2011-10-12 19:09:26 -0400 | [diff] [blame] | 629 | |
| 630 | return 0; |
| 631 | |
| 632 | error: |
Dylan Reid | 648b220 | 2015-10-23 00:50:00 -0700 | [diff] [blame] | 633 | free(m->src); |
| 634 | free(m->dest); |
| 635 | free(m); |
Elly Jones | 51a5b6c | 2011-10-12 19:09:26 -0400 | [diff] [blame] | 636 | return -ENOMEM; |
| 637 | } |
| 638 | |
Dylan Reid | 648b220 | 2015-10-23 00:50:00 -0700 | [diff] [blame] | 639 | int API minijail_bind(struct minijail *j, const char *src, const char *dest, |
| 640 | int writeable) |
| 641 | { |
| 642 | unsigned long flags = MS_BIND; |
| 643 | |
| 644 | if (!writeable) |
| 645 | flags |= MS_RDONLY; |
| 646 | |
| 647 | return minijail_mount(j, src, dest, "", flags); |
| 648 | } |
| 649 | |
Will Drewry | 6ac9112 | 2011-10-21 16:38:58 -0500 | [diff] [blame] | 650 | void API minijail_parse_seccomp_filters(struct minijail *j, const char *path) |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 651 | { |
Utkarsh Sanghi | 0ef8a66 | 2014-08-18 15:50:11 -0700 | [diff] [blame] | 652 | if (prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, NULL)) { |
Jeff Vander Stoep | 2885bef | 2016-01-11 15:22:42 -0800 | [diff] [blame] | 653 | if ((errno == EINVAL) && can_softfail()) { |
Jorge Lucangeli Obes | 43a6a86 | 2015-12-04 14:53:36 -0800 | [diff] [blame] | 654 | warn("not loading seccomp filter," |
| 655 | " seccomp not supported"); |
Jeff Vander Stoep | 2885bef | 2016-01-11 15:22:42 -0800 | [diff] [blame] | 656 | j->flags.seccomp_filter = 0; |
| 657 | j->flags.log_seccomp_filter = 0; |
| 658 | j->filter_len = 0; |
| 659 | j->filter_prog = NULL; |
| 660 | j->flags.no_new_privs = 0; |
Utkarsh Sanghi | 0ef8a66 | 2014-08-18 15:50:11 -0700 | [diff] [blame] | 661 | } |
| 662 | } |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 663 | FILE *file = fopen(path, "r"); |
Jorge Lucangeli Obes | 524c040 | 2012-01-17 11:30:23 -0800 | [diff] [blame] | 664 | if (!file) { |
Jorge Lucangeli Obes | 224e427 | 2012-08-02 14:31:39 -0700 | [diff] [blame] | 665 | pdie("failed to open seccomp filter file '%s'", path); |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 666 | } |
Jorge Lucangeli Obes | 524c040 | 2012-01-17 11:30:23 -0800 | [diff] [blame] | 667 | |
| 668 | struct sock_fprog *fprog = malloc(sizeof(struct sock_fprog)); |
Jorge Lucangeli Obes | bda833c | 2012-07-31 16:25:56 -0700 | [diff] [blame] | 669 | if (compile_filter(file, fprog, j->flags.log_seccomp_filter)) { |
| 670 | die("failed to compile seccomp filter BPF program in '%s'", |
| 671 | path); |
Jorge Lucangeli Obes | 524c040 | 2012-01-17 11:30:23 -0800 | [diff] [blame] | 672 | } |
| 673 | |
| 674 | j->filter_len = fprog->len; |
| 675 | j->filter_prog = fprog; |
| 676 | |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 677 | fclose(file); |
Will Drewry | 32ac9f5 | 2011-08-18 21:36:27 -0500 | [diff] [blame] | 678 | } |
| 679 | |
Andrew Bresticker | eac2894 | 2015-11-11 16:04:46 -0800 | [diff] [blame] | 680 | int API minijail_use_alt_syscall(struct minijail *j, const char *table) |
| 681 | { |
| 682 | j->alt_syscall_table = strdup(table); |
| 683 | if (!j->alt_syscall_table) |
| 684 | return -ENOMEM; |
| 685 | j->flags.alt_syscall = 1; |
| 686 | return 0; |
| 687 | } |
| 688 | |
Will Drewry | f89aef5 | 2011-09-16 16:48:57 -0500 | [diff] [blame] | 689 | struct marshal_state { |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 690 | size_t available; |
| 691 | size_t total; |
| 692 | char *buf; |
Will Drewry | f89aef5 | 2011-09-16 16:48:57 -0500 | [diff] [blame] | 693 | }; |
| 694 | |
Jorge Lucangeli Obes | a521bee | 2016-03-03 13:47:57 -0800 | [diff] [blame] | 695 | void marshal_state_init(struct marshal_state *state, char *buf, |
| 696 | size_t available) |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 697 | { |
| 698 | state->available = available; |
| 699 | state->buf = buf; |
| 700 | state->total = 0; |
Will Drewry | f89aef5 | 2011-09-16 16:48:57 -0500 | [diff] [blame] | 701 | } |
| 702 | |
Jorge Lucangeli Obes | a521bee | 2016-03-03 13:47:57 -0800 | [diff] [blame] | 703 | void marshal_append(struct marshal_state *state, void *src, size_t length) |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 704 | { |
| 705 | size_t copy_len = MIN(state->available, length); |
Will Drewry | f89aef5 | 2011-09-16 16:48:57 -0500 | [diff] [blame] | 706 | |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 707 | /* Up to |available| will be written. */ |
| 708 | if (copy_len) { |
| 709 | memcpy(state->buf, src, copy_len); |
| 710 | state->buf += copy_len; |
| 711 | state->available -= copy_len; |
| 712 | } |
| 713 | /* |total| will contain the expected length. */ |
| 714 | state->total += length; |
Will Drewry | f89aef5 | 2011-09-16 16:48:57 -0500 | [diff] [blame] | 715 | } |
| 716 | |
Will Drewry | 6ac9112 | 2011-10-21 16:38:58 -0500 | [diff] [blame] | 717 | void minijail_marshal_helper(struct marshal_state *state, |
| 718 | const struct minijail *j) |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 719 | { |
Dylan Reid | 648b220 | 2015-10-23 00:50:00 -0700 | [diff] [blame] | 720 | struct mountpoint *m = NULL; |
Dylan Reid | 605ce7f | 2016-01-19 19:21:00 -0800 | [diff] [blame] | 721 | size_t i; |
| 722 | |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 723 | marshal_append(state, (char *)j, sizeof(*j)); |
| 724 | if (j->user) |
| 725 | marshal_append(state, j->user, strlen(j->user) + 1); |
Jorge Lucangeli Obes | de02a5b | 2015-12-11 15:28:52 -0800 | [diff] [blame] | 726 | if (j->suppl_gid_list) { |
| 727 | marshal_append(state, j->suppl_gid_list, |
| 728 | j->suppl_gid_count * sizeof(gid_t)); |
| 729 | } |
Elly Jones | 51a5b6c | 2011-10-12 19:09:26 -0400 | [diff] [blame] | 730 | if (j->chrootdir) |
| 731 | marshal_append(state, j->chrootdir, strlen(j->chrootdir) + 1); |
Andrew Bresticker | eac2894 | 2015-11-11 16:04:46 -0800 | [diff] [blame] | 732 | if (j->alt_syscall_table) { |
| 733 | marshal_append(state, j->alt_syscall_table, |
| 734 | strlen(j->alt_syscall_table) + 1); |
| 735 | } |
Jorge Lucangeli Obes | 524c040 | 2012-01-17 11:30:23 -0800 | [diff] [blame] | 736 | if (j->flags.seccomp_filter && j->filter_prog) { |
| 737 | struct sock_fprog *fp = j->filter_prog; |
| 738 | marshal_append(state, (char *)fp->filter, |
Jorge Lucangeli Obes | a521bee | 2016-03-03 13:47:57 -0800 | [diff] [blame] | 739 | fp->len * sizeof(struct sock_filter)); |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 740 | } |
Dylan Reid | 648b220 | 2015-10-23 00:50:00 -0700 | [diff] [blame] | 741 | for (m = j->mounts_head; m; m = m->next) { |
| 742 | marshal_append(state, m->src, strlen(m->src) + 1); |
| 743 | marshal_append(state, m->dest, strlen(m->dest) + 1); |
| 744 | marshal_append(state, m->type, strlen(m->type) + 1); |
| 745 | marshal_append(state, (char *)&m->flags, sizeof(m->flags)); |
Elly Jones | 51a5b6c | 2011-10-12 19:09:26 -0400 | [diff] [blame] | 746 | } |
Dylan Reid | 605ce7f | 2016-01-19 19:21:00 -0800 | [diff] [blame] | 747 | for (i = 0; i < j->cgroup_count; ++i) |
| 748 | marshal_append(state, j->cgroups[i], strlen(j->cgroups[i]) + 1); |
Will Drewry | f89aef5 | 2011-09-16 16:48:57 -0500 | [diff] [blame] | 749 | } |
| 750 | |
Will Drewry | 6ac9112 | 2011-10-21 16:38:58 -0500 | [diff] [blame] | 751 | size_t API minijail_size(const struct minijail *j) |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 752 | { |
| 753 | struct marshal_state state; |
| 754 | marshal_state_init(&state, NULL, 0); |
| 755 | minijail_marshal_helper(&state, j); |
| 756 | return state.total; |
Will Drewry | 2ddaad0 | 2011-09-16 11:36:08 -0500 | [diff] [blame] | 757 | } |
| 758 | |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 759 | int minijail_marshal(const struct minijail *j, char *buf, size_t available) |
| 760 | { |
| 761 | struct marshal_state state; |
| 762 | marshal_state_init(&state, buf, available); |
| 763 | minijail_marshal_helper(&state, j); |
| 764 | return (state.total > available); |
Will Drewry | 2ddaad0 | 2011-09-16 11:36:08 -0500 | [diff] [blame] | 765 | } |
| 766 | |
Jorge Lucangeli Obes | d0a6e2f | 2015-11-24 14:21:21 -0800 | [diff] [blame] | 767 | /* |
| 768 | * consumebytes: consumes @length bytes from a buffer @buf of length @buflength |
Elly Jones | 51a5b6c | 2011-10-12 19:09:26 -0400 | [diff] [blame] | 769 | * @length Number of bytes to consume |
| 770 | * @buf Buffer to consume from |
| 771 | * @buflength Size of @buf |
| 772 | * |
| 773 | * Returns a pointer to the base of the bytes, or NULL for errors. |
| 774 | */ |
Jorge Lucangeli Obes | c8b21e1 | 2014-06-13 14:26:16 -0700 | [diff] [blame] | 775 | void *consumebytes(size_t length, char **buf, size_t *buflength) |
| 776 | { |
Elly Jones | 51a5b6c | 2011-10-12 19:09:26 -0400 | [diff] [blame] | 777 | char *p = *buf; |
| 778 | if (length > *buflength) |
| 779 | return NULL; |
| 780 | *buf += length; |
| 781 | *buflength -= length; |
| 782 | return p; |
| 783 | } |
| 784 | |
Jorge Lucangeli Obes | d0a6e2f | 2015-11-24 14:21:21 -0800 | [diff] [blame] | 785 | /* |
| 786 | * consumestr: consumes a C string from a buffer @buf of length @length |
Elly Jones | 51a5b6c | 2011-10-12 19:09:26 -0400 | [diff] [blame] | 787 | * @buf Buffer to consume |
| 788 | * @length Length of buffer |
| 789 | * |
| 790 | * Returns a pointer to the base of the string, or NULL for errors. |
| 791 | */ |
Jorge Lucangeli Obes | c8b21e1 | 2014-06-13 14:26:16 -0700 | [diff] [blame] | 792 | char *consumestr(char **buf, size_t *buflength) |
| 793 | { |
Elly Jones | 51a5b6c | 2011-10-12 19:09:26 -0400 | [diff] [blame] | 794 | size_t len = strnlen(*buf, *buflength); |
| 795 | if (len == *buflength) |
Jorge Lucangeli Obes | 5471450 | 2015-09-30 10:08:45 -0700 | [diff] [blame] | 796 | /* There's no null-terminator. */ |
Elly Jones | 51a5b6c | 2011-10-12 19:09:26 -0400 | [diff] [blame] | 797 | return NULL; |
| 798 | return consumebytes(len + 1, buf, buflength); |
| 799 | } |
| 800 | |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 801 | int minijail_unmarshal(struct minijail *j, char *serialized, size_t length) |
| 802 | { |
Jorge Lucangeli Obes | c2ba9f5 | 2015-12-01 07:58:10 -0800 | [diff] [blame] | 803 | size_t i; |
| 804 | size_t count; |
Will Drewry | bee7ba7 | 2011-10-21 20:47:01 -0500 | [diff] [blame] | 805 | int ret = -EINVAL; |
| 806 | |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 807 | if (length < sizeof(*j)) |
Will Drewry | bee7ba7 | 2011-10-21 20:47:01 -0500 | [diff] [blame] | 808 | goto out; |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 809 | memcpy((void *)j, serialized, sizeof(*j)); |
| 810 | serialized += sizeof(*j); |
| 811 | length -= sizeof(*j); |
Will Drewry | f89aef5 | 2011-09-16 16:48:57 -0500 | [diff] [blame] | 812 | |
Will Drewry | bee7ba7 | 2011-10-21 20:47:01 -0500 | [diff] [blame] | 813 | /* Potentially stale pointers not used as signals. */ |
Dylan Reid | 648b220 | 2015-10-23 00:50:00 -0700 | [diff] [blame] | 814 | j->mounts_head = NULL; |
| 815 | j->mounts_tail = NULL; |
Jorge Lucangeli Obes | 524c040 | 2012-01-17 11:30:23 -0800 | [diff] [blame] | 816 | j->filter_prog = NULL; |
Will Drewry | bee7ba7 | 2011-10-21 20:47:01 -0500 | [diff] [blame] | 817 | |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 818 | if (j->user) { /* stale pointer */ |
Elly Jones | 51a5b6c | 2011-10-12 19:09:26 -0400 | [diff] [blame] | 819 | char *user = consumestr(&serialized, &length); |
| 820 | if (!user) |
Will Drewry | bee7ba7 | 2011-10-21 20:47:01 -0500 | [diff] [blame] | 821 | goto clear_pointers; |
Elly Jones | 51a5b6c | 2011-10-12 19:09:26 -0400 | [diff] [blame] | 822 | j->user = strdup(user); |
Will Drewry | bee7ba7 | 2011-10-21 20:47:01 -0500 | [diff] [blame] | 823 | if (!j->user) |
| 824 | goto clear_pointers; |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 825 | } |
Will Drewry | f89aef5 | 2011-09-16 16:48:57 -0500 | [diff] [blame] | 826 | |
Jorge Lucangeli Obes | de02a5b | 2015-12-11 15:28:52 -0800 | [diff] [blame] | 827 | if (j->suppl_gid_list) { /* stale pointer */ |
| 828 | if (j->suppl_gid_count > NGROUPS_MAX) { |
| 829 | goto bad_gid_list; |
| 830 | } |
| 831 | size_t gid_list_size = j->suppl_gid_count * sizeof(gid_t); |
| 832 | void *gid_list_bytes = |
| 833 | consumebytes(gid_list_size, &serialized, &length); |
| 834 | if (!gid_list_bytes) |
| 835 | goto bad_gid_list; |
| 836 | |
| 837 | j->suppl_gid_list = calloc(j->suppl_gid_count, sizeof(gid_t)); |
| 838 | if (!j->suppl_gid_list) |
| 839 | goto bad_gid_list; |
| 840 | |
| 841 | memcpy(j->suppl_gid_list, gid_list_bytes, gid_list_size); |
| 842 | } |
| 843 | |
Elly Jones | a8d1e1b | 2011-10-21 15:38:00 -0400 | [diff] [blame] | 844 | if (j->chrootdir) { /* stale pointer */ |
| 845 | char *chrootdir = consumestr(&serialized, &length); |
| 846 | if (!chrootdir) |
Will Drewry | bee7ba7 | 2011-10-21 20:47:01 -0500 | [diff] [blame] | 847 | goto bad_chrootdir; |
Elly Jones | a8d1e1b | 2011-10-21 15:38:00 -0400 | [diff] [blame] | 848 | j->chrootdir = strdup(chrootdir); |
Will Drewry | bee7ba7 | 2011-10-21 20:47:01 -0500 | [diff] [blame] | 849 | if (!j->chrootdir) |
| 850 | goto bad_chrootdir; |
Elly Jones | a8d1e1b | 2011-10-21 15:38:00 -0400 | [diff] [blame] | 851 | } |
| 852 | |
Andrew Bresticker | eac2894 | 2015-11-11 16:04:46 -0800 | [diff] [blame] | 853 | if (j->alt_syscall_table) { /* stale pointer */ |
| 854 | char *alt_syscall_table = consumestr(&serialized, &length); |
| 855 | if (!alt_syscall_table) |
| 856 | goto bad_syscall_table; |
| 857 | j->alt_syscall_table = strdup(alt_syscall_table); |
| 858 | if (!j->alt_syscall_table) |
| 859 | goto bad_syscall_table; |
| 860 | } |
| 861 | |
Jorge Lucangeli Obes | 524c040 | 2012-01-17 11:30:23 -0800 | [diff] [blame] | 862 | if (j->flags.seccomp_filter && j->filter_len > 0) { |
| 863 | size_t ninstrs = j->filter_len; |
| 864 | if (ninstrs > (SIZE_MAX / sizeof(struct sock_filter)) || |
| 865 | ninstrs > USHRT_MAX) |
| 866 | goto bad_filters; |
| 867 | |
| 868 | size_t program_len = ninstrs * sizeof(struct sock_filter); |
| 869 | void *program = consumebytes(program_len, &serialized, &length); |
| 870 | if (!program) |
| 871 | goto bad_filters; |
| 872 | |
| 873 | j->filter_prog = malloc(sizeof(struct sock_fprog)); |
Jorge Lucangeli Obes | de02a5b | 2015-12-11 15:28:52 -0800 | [diff] [blame] | 874 | if (!j->filter_prog) |
| 875 | goto bad_filters; |
| 876 | |
Jorge Lucangeli Obes | 524c040 | 2012-01-17 11:30:23 -0800 | [diff] [blame] | 877 | j->filter_prog->len = ninstrs; |
| 878 | j->filter_prog->filter = malloc(program_len); |
Jorge Lucangeli Obes | de02a5b | 2015-12-11 15:28:52 -0800 | [diff] [blame] | 879 | if (!j->filter_prog->filter) |
| 880 | goto bad_filter_prog_instrs; |
| 881 | |
Jorge Lucangeli Obes | 524c040 | 2012-01-17 11:30:23 -0800 | [diff] [blame] | 882 | memcpy(j->filter_prog->filter, program, program_len); |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 883 | } |
Elly Jones | 51a5b6c | 2011-10-12 19:09:26 -0400 | [diff] [blame] | 884 | |
Dylan Reid | 648b220 | 2015-10-23 00:50:00 -0700 | [diff] [blame] | 885 | count = j->mounts_count; |
| 886 | j->mounts_count = 0; |
Elly Jones | 51a5b6c | 2011-10-12 19:09:26 -0400 | [diff] [blame] | 887 | for (i = 0; i < count; ++i) { |
Dylan Reid | 648b220 | 2015-10-23 00:50:00 -0700 | [diff] [blame] | 888 | unsigned long *flags; |
Elly Jones | 51a5b6c | 2011-10-12 19:09:26 -0400 | [diff] [blame] | 889 | const char *dest; |
Dylan Reid | 648b220 | 2015-10-23 00:50:00 -0700 | [diff] [blame] | 890 | const char *type; |
Elly Jones | 51a5b6c | 2011-10-12 19:09:26 -0400 | [diff] [blame] | 891 | const char *src = consumestr(&serialized, &length); |
| 892 | if (!src) |
Dylan Reid | 648b220 | 2015-10-23 00:50:00 -0700 | [diff] [blame] | 893 | goto bad_mounts; |
Elly Jones | 51a5b6c | 2011-10-12 19:09:26 -0400 | [diff] [blame] | 894 | dest = consumestr(&serialized, &length); |
| 895 | if (!dest) |
Dylan Reid | 648b220 | 2015-10-23 00:50:00 -0700 | [diff] [blame] | 896 | goto bad_mounts; |
| 897 | type = consumestr(&serialized, &length); |
| 898 | if (!type) |
| 899 | goto bad_mounts; |
| 900 | flags = consumebytes(sizeof(*flags), &serialized, &length); |
| 901 | if (!flags) |
| 902 | goto bad_mounts; |
| 903 | if (minijail_mount(j, src, dest, type, *flags)) |
| 904 | goto bad_mounts; |
Elly Jones | 51a5b6c | 2011-10-12 19:09:26 -0400 | [diff] [blame] | 905 | } |
| 906 | |
Dylan Reid | 605ce7f | 2016-01-19 19:21:00 -0800 | [diff] [blame] | 907 | count = j->cgroup_count; |
| 908 | j->cgroup_count = 0; |
| 909 | for (i = 0; i < count; ++i) { |
| 910 | char *cgroup = consumestr(&serialized, &length); |
| 911 | if (!cgroup) |
| 912 | goto bad_cgroups; |
| 913 | j->cgroups[i] = strdup(cgroup); |
| 914 | if (!j->cgroups[i]) |
| 915 | goto bad_cgroups; |
| 916 | ++j->cgroup_count; |
| 917 | } |
| 918 | |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 919 | return 0; |
Will Drewry | bee7ba7 | 2011-10-21 20:47:01 -0500 | [diff] [blame] | 920 | |
Dylan Reid | 605ce7f | 2016-01-19 19:21:00 -0800 | [diff] [blame] | 921 | bad_cgroups: |
| 922 | while (j->mounts_head) { |
| 923 | struct mountpoint *m = j->mounts_head; |
| 924 | j->mounts_head = j->mounts_head->next; |
| 925 | free(m->type); |
| 926 | free(m->dest); |
| 927 | free(m->src); |
| 928 | free(m); |
| 929 | } |
| 930 | for (i = 0; i < j->cgroup_count; ++i) |
| 931 | free(j->cgroups[i]); |
Dylan Reid | 648b220 | 2015-10-23 00:50:00 -0700 | [diff] [blame] | 932 | bad_mounts: |
Jorge Lucangeli Obes | 524c040 | 2012-01-17 11:30:23 -0800 | [diff] [blame] | 933 | if (j->flags.seccomp_filter && j->filter_len > 0) { |
| 934 | free(j->filter_prog->filter); |
| 935 | free(j->filter_prog); |
| 936 | } |
Jorge Lucangeli Obes | de02a5b | 2015-12-11 15:28:52 -0800 | [diff] [blame] | 937 | bad_filter_prog_instrs: |
| 938 | if (j->filter_prog) |
| 939 | free(j->filter_prog); |
Will Drewry | bee7ba7 | 2011-10-21 20:47:01 -0500 | [diff] [blame] | 940 | bad_filters: |
Andrew Bresticker | eac2894 | 2015-11-11 16:04:46 -0800 | [diff] [blame] | 941 | if (j->alt_syscall_table) |
| 942 | free(j->alt_syscall_table); |
| 943 | bad_syscall_table: |
Will Drewry | bee7ba7 | 2011-10-21 20:47:01 -0500 | [diff] [blame] | 944 | if (j->chrootdir) |
| 945 | free(j->chrootdir); |
| 946 | bad_chrootdir: |
Jorge Lucangeli Obes | de02a5b | 2015-12-11 15:28:52 -0800 | [diff] [blame] | 947 | if (j->suppl_gid_list) |
| 948 | free(j->suppl_gid_list); |
| 949 | bad_gid_list: |
Will Drewry | bee7ba7 | 2011-10-21 20:47:01 -0500 | [diff] [blame] | 950 | if (j->user) |
| 951 | free(j->user); |
| 952 | clear_pointers: |
| 953 | j->user = NULL; |
Jorge Lucangeli Obes | de02a5b | 2015-12-11 15:28:52 -0800 | [diff] [blame] | 954 | j->suppl_gid_list = NULL; |
Will Drewry | bee7ba7 | 2011-10-21 20:47:01 -0500 | [diff] [blame] | 955 | j->chrootdir = NULL; |
Andrew Bresticker | eac2894 | 2015-11-11 16:04:46 -0800 | [diff] [blame] | 956 | j->alt_syscall_table = NULL; |
Dylan Reid | 605ce7f | 2016-01-19 19:21:00 -0800 | [diff] [blame] | 957 | j->cgroup_count = 0; |
Will Drewry | bee7ba7 | 2011-10-21 20:47:01 -0500 | [diff] [blame] | 958 | out: |
| 959 | return ret; |
Will Drewry | 2ddaad0 | 2011-09-16 11:36:08 -0500 | [diff] [blame] | 960 | } |
| 961 | |
Dylan Reid | ce5b55e | 2016-01-13 11:04:16 -0800 | [diff] [blame] | 962 | static void write_ugid_mappings(const struct minijail *j) |
Yu-Hsi Chiang | 10e9123 | 2015-08-05 14:40:45 +0800 | [diff] [blame] | 963 | { |
| 964 | int fd, ret, len; |
| 965 | size_t sz; |
| 966 | char fname[32]; |
Yu-Hsi Chiang | 10e9123 | 2015-08-05 14:40:45 +0800 | [diff] [blame] | 967 | |
| 968 | sz = sizeof(fname); |
| 969 | if (j->uidmap) { |
| 970 | ret = snprintf(fname, sz, "/proc/%d/uid_map", j->initpid); |
Jorge Lucangeli Obes | 2034274 | 2015-10-27 11:39:59 -0700 | [diff] [blame] | 971 | if (ret < 0 || (size_t)ret >= sz) |
Yu-Hsi Chiang | 10e9123 | 2015-08-05 14:40:45 +0800 | [diff] [blame] | 972 | die("failed to write file name of uid_map"); |
Ricky Zhou | bce609d | 2016-03-02 21:47:56 -0800 | [diff] [blame] | 973 | fd = open(fname, O_WRONLY | O_CLOEXEC); |
Yu-Hsi Chiang | 10e9123 | 2015-08-05 14:40:45 +0800 | [diff] [blame] | 974 | if (fd < 0) |
| 975 | pdie("failed to open '%s'", fname); |
| 976 | len = strlen(j->uidmap); |
| 977 | if (write(fd, j->uidmap, len) < len) |
| 978 | die("failed to set uid_map"); |
| 979 | close(fd); |
| 980 | } |
| 981 | if (j->gidmap) { |
| 982 | ret = snprintf(fname, sz, "/proc/%d/gid_map", j->initpid); |
Jorge Lucangeli Obes | 2034274 | 2015-10-27 11:39:59 -0700 | [diff] [blame] | 983 | if (ret < 0 || (size_t)ret >= sz) |
Yu-Hsi Chiang | 10e9123 | 2015-08-05 14:40:45 +0800 | [diff] [blame] | 984 | die("failed to write file name of gid_map"); |
Ricky Zhou | bce609d | 2016-03-02 21:47:56 -0800 | [diff] [blame] | 985 | fd = open(fname, O_WRONLY | O_CLOEXEC); |
Yu-Hsi Chiang | 10e9123 | 2015-08-05 14:40:45 +0800 | [diff] [blame] | 986 | if (fd < 0) |
| 987 | pdie("failed to open '%s'", fname); |
| 988 | len = strlen(j->gidmap); |
| 989 | if (write(fd, j->gidmap, len) < len) |
| 990 | die("failed to set gid_map"); |
| 991 | close(fd); |
| 992 | } |
Dylan Reid | ce5b55e | 2016-01-13 11:04:16 -0800 | [diff] [blame] | 993 | } |
Yu-Hsi Chiang | 10e9123 | 2015-08-05 14:40:45 +0800 | [diff] [blame] | 994 | |
Dylan Reid | ce5b55e | 2016-01-13 11:04:16 -0800 | [diff] [blame] | 995 | static void parent_setup_complete(int *pipe_fds) |
| 996 | { |
| 997 | close(pipe_fds[0]); |
Yu-Hsi Chiang | 10e9123 | 2015-08-05 14:40:45 +0800 | [diff] [blame] | 998 | close(pipe_fds[1]); |
| 999 | } |
| 1000 | |
Dylan Reid | ce5b55e | 2016-01-13 11:04:16 -0800 | [diff] [blame] | 1001 | /* |
| 1002 | * wait_for_parent_setup: Called by the child process to wait for any |
| 1003 | * further parent-side setup to complete before continuing. |
| 1004 | */ |
| 1005 | static void wait_for_parent_setup(int *pipe_fds) |
Yu-Hsi Chiang | 10e9123 | 2015-08-05 14:40:45 +0800 | [diff] [blame] | 1006 | { |
| 1007 | char buf; |
| 1008 | |
| 1009 | close(pipe_fds[1]); |
| 1010 | |
Dylan Reid | ce5b55e | 2016-01-13 11:04:16 -0800 | [diff] [blame] | 1011 | /* Wait for parent to complete setup and close the pipe. */ |
Yu-Hsi Chiang | 10e9123 | 2015-08-05 14:40:45 +0800 | [diff] [blame] | 1012 | if (read(pipe_fds[0], &buf, 1) != 0) |
| 1013 | die("failed to sync with parent"); |
| 1014 | close(pipe_fds[0]); |
Dylan Reid | ce5b55e | 2016-01-13 11:04:16 -0800 | [diff] [blame] | 1015 | } |
Yu-Hsi Chiang | 10e9123 | 2015-08-05 14:40:45 +0800 | [diff] [blame] | 1016 | |
Dylan Reid | ce5b55e | 2016-01-13 11:04:16 -0800 | [diff] [blame] | 1017 | static void enter_user_namespace(const struct minijail *j) |
| 1018 | { |
Yu-Hsi Chiang | 10e9123 | 2015-08-05 14:40:45 +0800 | [diff] [blame] | 1019 | if (j->uidmap && setresuid(0, 0, 0)) |
| 1020 | pdie("setresuid"); |
| 1021 | if (j->gidmap && setresgid(0, 0, 0)) |
| 1022 | pdie("setresgid"); |
| 1023 | } |
| 1024 | |
Jorge Lucangeli Obes | d0a6e2f | 2015-11-24 14:21:21 -0800 | [diff] [blame] | 1025 | /* |
| 1026 | * mount_one: Applies mounts from @m for @j, recursing as needed. |
Dylan Reid | 648b220 | 2015-10-23 00:50:00 -0700 | [diff] [blame] | 1027 | * @j Minijail these mounts are for |
| 1028 | * @m Head of list of mounts |
Elly Jones | 51a5b6c | 2011-10-12 19:09:26 -0400 | [diff] [blame] | 1029 | * |
| 1030 | * Returns 0 for success. |
| 1031 | */ |
Dylan Reid | 648b220 | 2015-10-23 00:50:00 -0700 | [diff] [blame] | 1032 | static int mount_one(const struct minijail *j, struct mountpoint *m) |
Jorge Lucangeli Obes | c8b21e1 | 2014-06-13 14:26:16 -0700 | [diff] [blame] | 1033 | { |
Dylan Reid | 648b220 | 2015-10-23 00:50:00 -0700 | [diff] [blame] | 1034 | int ret; |
| 1035 | char *dest; |
| 1036 | int remount_ro = 0; |
| 1037 | |
Jorge Lucangeli Obes | 2b12ba4 | 2016-01-26 10:37:51 -0800 | [diff] [blame] | 1038 | /* |dest| has a leading "/". */ |
Dylan Reid | 648b220 | 2015-10-23 00:50:00 -0700 | [diff] [blame] | 1039 | if (asprintf(&dest, "%s%s", j->chrootdir, m->dest) < 0) |
Elly Jones | 51a5b6c | 2011-10-12 19:09:26 -0400 | [diff] [blame] | 1040 | return -ENOMEM; |
Dylan Reid | 648b220 | 2015-10-23 00:50:00 -0700 | [diff] [blame] | 1041 | |
| 1042 | /* |
Jorge Lucangeli Obes | 2b12ba4 | 2016-01-26 10:37:51 -0800 | [diff] [blame] | 1043 | * R/O bind mounts have to be remounted since 'bind' and 'ro' |
| 1044 | * can't both be specified in the original bind mount. |
| 1045 | * Remount R/O after the initial mount. |
Dylan Reid | 648b220 | 2015-10-23 00:50:00 -0700 | [diff] [blame] | 1046 | */ |
| 1047 | if ((m->flags & MS_BIND) && (m->flags & MS_RDONLY)) { |
| 1048 | remount_ro = 1; |
| 1049 | m->flags &= ~MS_RDONLY; |
Elly Jones | a105963 | 2011-12-15 15:17:07 -0500 | [diff] [blame] | 1050 | } |
Dylan Reid | 648b220 | 2015-10-23 00:50:00 -0700 | [diff] [blame] | 1051 | |
| 1052 | ret = mount(m->src, dest, m->type, m->flags, NULL); |
| 1053 | if (ret) |
| 1054 | pdie("mount: %s -> %s", m->src, dest); |
| 1055 | |
| 1056 | if (remount_ro) { |
| 1057 | m->flags |= MS_RDONLY; |
| 1058 | ret = mount(m->src, dest, NULL, |
| 1059 | m->flags | MS_REMOUNT, NULL); |
| 1060 | if (ret) |
| 1061 | pdie("bind ro: %s -> %s", m->src, dest); |
| 1062 | } |
| 1063 | |
Elly Jones | 51a5b6c | 2011-10-12 19:09:26 -0400 | [diff] [blame] | 1064 | free(dest); |
Dylan Reid | 648b220 | 2015-10-23 00:50:00 -0700 | [diff] [blame] | 1065 | if (m->next) |
| 1066 | return mount_one(j, m->next); |
Elly Jones | 51a5b6c | 2011-10-12 19:09:26 -0400 | [diff] [blame] | 1067 | return ret; |
| 1068 | } |
| 1069 | |
Jorge Lucangeli Obes | c8b21e1 | 2014-06-13 14:26:16 -0700 | [diff] [blame] | 1070 | int enter_chroot(const struct minijail *j) |
| 1071 | { |
Elly Jones | 51a5b6c | 2011-10-12 19:09:26 -0400 | [diff] [blame] | 1072 | int ret; |
Dylan Reid | 648b220 | 2015-10-23 00:50:00 -0700 | [diff] [blame] | 1073 | |
| 1074 | if (j->mounts_head && (ret = mount_one(j, j->mounts_head))) |
Elly Jones | 51a5b6c | 2011-10-12 19:09:26 -0400 | [diff] [blame] | 1075 | return ret; |
| 1076 | |
| 1077 | if (chroot(j->chrootdir)) |
| 1078 | return -errno; |
| 1079 | |
| 1080 | if (chdir("/")) |
| 1081 | return -errno; |
| 1082 | |
| 1083 | return 0; |
| 1084 | } |
| 1085 | |
Yu-Hsi Chiang | 64d65a7 | 2015-08-13 17:43:27 +0800 | [diff] [blame] | 1086 | int enter_pivot_root(const struct minijail *j) |
| 1087 | { |
Yu-Hsi Chiang | e0a530e | 2015-09-08 18:49:49 +0800 | [diff] [blame] | 1088 | int ret, oldroot, newroot; |
Dylan Reid | 648b220 | 2015-10-23 00:50:00 -0700 | [diff] [blame] | 1089 | |
| 1090 | if (j->mounts_head && (ret = mount_one(j, j->mounts_head))) |
Yu-Hsi Chiang | 64d65a7 | 2015-08-13 17:43:27 +0800 | [diff] [blame] | 1091 | return ret; |
| 1092 | |
Jorge Lucangeli Obes | 43a6a86 | 2015-12-04 14:53:36 -0800 | [diff] [blame] | 1093 | /* |
| 1094 | * Keep the fd for both old and new root. |
Jorge Lucangeli Obes | 6b0de9b | 2016-03-16 22:41:34 -0700 | [diff] [blame^] | 1095 | * It will be used in fchdir(2) later. |
Jorge Lucangeli Obes | 43a6a86 | 2015-12-04 14:53:36 -0800 | [diff] [blame] | 1096 | */ |
Ricky Zhou | bce609d | 2016-03-02 21:47:56 -0800 | [diff] [blame] | 1097 | oldroot = open("/", O_DIRECTORY | O_RDONLY | O_CLOEXEC); |
Yu-Hsi Chiang | e0a530e | 2015-09-08 18:49:49 +0800 | [diff] [blame] | 1098 | if (oldroot < 0) |
| 1099 | pdie("failed to open / for fchdir"); |
Ricky Zhou | bce609d | 2016-03-02 21:47:56 -0800 | [diff] [blame] | 1100 | newroot = open(j->chrootdir, O_DIRECTORY | O_RDONLY | O_CLOEXEC); |
Yu-Hsi Chiang | e0a530e | 2015-09-08 18:49:49 +0800 | [diff] [blame] | 1101 | if (newroot < 0) |
| 1102 | pdie("failed to open %s for fchdir", j->chrootdir); |
| 1103 | |
Jorge Lucangeli Obes | 43a6a86 | 2015-12-04 14:53:36 -0800 | [diff] [blame] | 1104 | /* |
Jorge Lucangeli Obes | 6b0de9b | 2016-03-16 22:41:34 -0700 | [diff] [blame^] | 1105 | * To ensure j->chrootdir is the root of a filesystem, |
Jorge Lucangeli Obes | 43a6a86 | 2015-12-04 14:53:36 -0800 | [diff] [blame] | 1106 | * do a self bind mount. |
| 1107 | */ |
Yu-Hsi Chiang | 64d65a7 | 2015-08-13 17:43:27 +0800 | [diff] [blame] | 1108 | if (mount(j->chrootdir, j->chrootdir, "bind", MS_BIND | MS_REC, "")) |
| 1109 | pdie("failed to bind mount '%s'", j->chrootdir); |
| 1110 | if (chdir(j->chrootdir)) |
| 1111 | return -errno; |
Yu-Hsi Chiang | e0a530e | 2015-09-08 18:49:49 +0800 | [diff] [blame] | 1112 | if (syscall(SYS_pivot_root, ".", ".")) |
Yu-Hsi Chiang | 64d65a7 | 2015-08-13 17:43:27 +0800 | [diff] [blame] | 1113 | pdie("pivot_root"); |
Yu-Hsi Chiang | e0a530e | 2015-09-08 18:49:49 +0800 | [diff] [blame] | 1114 | |
| 1115 | /* |
Jorge Lucangeli Obes | 6b0de9b | 2016-03-16 22:41:34 -0700 | [diff] [blame^] | 1116 | * Now the old root is mounted on top of the new root. Use fchdir(2) to |
Yu-Hsi Chiang | e0a530e | 2015-09-08 18:49:49 +0800 | [diff] [blame] | 1117 | * change to the old root and unmount it. |
| 1118 | */ |
| 1119 | if (fchdir(oldroot)) |
| 1120 | pdie("failed to fchdir to old /"); |
Hidehiko Abe | 097b719 | 2016-03-16 18:00:36 +0900 | [diff] [blame] | 1121 | |
| 1122 | /* |
Jorge Lucangeli Obes | 6b0de9b | 2016-03-16 22:41:34 -0700 | [diff] [blame^] | 1123 | * If j->flags.skip_remount_private was enabled for minijail_enter(), there |
| 1124 | * could be a shared mount point under |oldroot|. In that case, mounts |
| 1125 | * under this shared mount point will be unmounted below, and this |
| 1126 | * unmounting will propagate to the original mount namespace (because the |
| 1127 | * mount point is shared). To prevent this unexpected unmounting, remove |
| 1128 | * these mounts from their peer groups by recursively remounting them as |
| 1129 | * MS_PRIVATE. |
Hidehiko Abe | 097b719 | 2016-03-16 18:00:36 +0900 | [diff] [blame] | 1130 | */ |
| 1131 | if (mount(NULL, ".", NULL, MS_REC | MS_PRIVATE, NULL)) |
Jorge Lucangeli Obes | 6b0de9b | 2016-03-16 22:41:34 -0700 | [diff] [blame^] | 1132 | pdie("failed to mount(/, private) before umount(/)"); |
Yu-Hsi Chiang | 64d65a7 | 2015-08-13 17:43:27 +0800 | [diff] [blame] | 1133 | /* The old root might be busy, so use lazy unmount. */ |
Yu-Hsi Chiang | e0a530e | 2015-09-08 18:49:49 +0800 | [diff] [blame] | 1134 | if (umount2(".", MNT_DETACH)) |
| 1135 | pdie("umount(/)"); |
| 1136 | /* Change back to the new root. */ |
| 1137 | if (fchdir(newroot)) |
Yu-Hsi Chiang | 64d65a7 | 2015-08-13 17:43:27 +0800 | [diff] [blame] | 1138 | return -errno; |
Ricky Zhou | bce609d | 2016-03-02 21:47:56 -0800 | [diff] [blame] | 1139 | if (close(oldroot)) |
| 1140 | return -errno; |
| 1141 | if (close(newroot)) |
| 1142 | return -errno; |
Yu-Hsi Chiang | 64d65a7 | 2015-08-13 17:43:27 +0800 | [diff] [blame] | 1143 | if (chroot("/")) |
| 1144 | return -errno; |
Jorge Lucangeli Obes | 46a5509 | 2015-10-12 15:31:59 -0700 | [diff] [blame] | 1145 | /* Set correct CWD for getcwd(3). */ |
| 1146 | if (chdir("/")) |
| 1147 | return -errno; |
Yu-Hsi Chiang | 64d65a7 | 2015-08-13 17:43:27 +0800 | [diff] [blame] | 1148 | |
| 1149 | return 0; |
| 1150 | } |
| 1151 | |
Lee Campbell | 11af062 | 2014-05-22 12:36:04 -0700 | [diff] [blame] | 1152 | int mount_tmp(void) |
| 1153 | { |
Jorge Lucangeli Obes | 3901da6 | 2015-03-03 13:55:11 -0800 | [diff] [blame] | 1154 | return mount("none", "/tmp", "tmpfs", 0, "size=64M,mode=777"); |
Lee Campbell | 11af062 | 2014-05-22 12:36:04 -0700 | [diff] [blame] | 1155 | } |
| 1156 | |
Dylan Reid | 791f577 | 2015-09-14 20:02:42 -0700 | [diff] [blame] | 1157 | int remount_proc_readonly(const struct minijail *j) |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1158 | { |
| 1159 | const char *kProcPath = "/proc"; |
| 1160 | const unsigned int kSafeFlags = MS_NODEV | MS_NOEXEC | MS_NOSUID; |
Elly Jones | dd3e851 | 2012-01-23 15:13:38 -0500 | [diff] [blame] | 1161 | /* |
| 1162 | * Right now, we're holding a reference to our parent's old mount of |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1163 | * /proc in our namespace, which means using MS_REMOUNT here would |
| 1164 | * mutate our parent's mount as well, even though we're in a VFS |
| 1165 | * namespace (!). Instead, remove their mount from our namespace |
Yu-Hsi Chiang | 10e9123 | 2015-08-05 14:40:45 +0800 | [diff] [blame] | 1166 | * and make our own. However, if we are in a new user namespace, /proc |
| 1167 | * is not seen as mounted, so don't return error if umount() fails. |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1168 | */ |
Jorge Lucangeli Obes | 805be39 | 2015-10-12 15:55:59 -0700 | [diff] [blame] | 1169 | if (umount2(kProcPath, MNT_DETACH) && !j->flags.userns) |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1170 | return -errno; |
| 1171 | if (mount("", kProcPath, "proc", kSafeFlags | MS_RDONLY, "")) |
| 1172 | return -errno; |
| 1173 | return 0; |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 1174 | } |
| 1175 | |
Dylan Reid | 605ce7f | 2016-01-19 19:21:00 -0800 | [diff] [blame] | 1176 | static void write_pid_to_path(pid_t pid, const char *path) |
Yu-Hsi Chiang | 3cc05ea | 2015-08-11 11:23:17 +0800 | [diff] [blame] | 1177 | { |
Dylan Reid | 605ce7f | 2016-01-19 19:21:00 -0800 | [diff] [blame] | 1178 | FILE *fp = fopen(path, "w"); |
Yu-Hsi Chiang | 3cc05ea | 2015-08-11 11:23:17 +0800 | [diff] [blame] | 1179 | |
| 1180 | if (!fp) |
Dylan Reid | 605ce7f | 2016-01-19 19:21:00 -0800 | [diff] [blame] | 1181 | pdie("failed to open '%s'", path); |
| 1182 | if (fprintf(fp, "%d\n", (int)pid) < 0) |
| 1183 | pdie("fprintf(%s)", path); |
Yu-Hsi Chiang | 3cc05ea | 2015-08-11 11:23:17 +0800 | [diff] [blame] | 1184 | if (fclose(fp)) |
Dylan Reid | 605ce7f | 2016-01-19 19:21:00 -0800 | [diff] [blame] | 1185 | pdie("fclose(%s)", path); |
| 1186 | } |
| 1187 | |
| 1188 | static void write_pid_file(const struct minijail *j) |
| 1189 | { |
| 1190 | write_pid_to_path(j->initpid, j->pid_file_path); |
| 1191 | } |
| 1192 | |
Jorge Lucangeli Obes | b8a5138 | 2016-01-25 20:08:22 -0800 | [diff] [blame] | 1193 | static void add_to_cgroups(const struct minijail *j) |
Dylan Reid | 605ce7f | 2016-01-19 19:21:00 -0800 | [diff] [blame] | 1194 | { |
| 1195 | size_t i; |
| 1196 | |
| 1197 | for (i = 0; i < j->cgroup_count; ++i) |
| 1198 | write_pid_to_path(j->initpid, j->cgroups[i]); |
Yu-Hsi Chiang | 3cc05ea | 2015-08-11 11:23:17 +0800 | [diff] [blame] | 1199 | } |
| 1200 | |
Jorge Lucangeli Obes | 6201cf5 | 2012-08-23 11:42:27 -0700 | [diff] [blame] | 1201 | void drop_ugid(const struct minijail *j) |
| 1202 | { |
Jorge Lucangeli Obes | d16ac49 | 2015-12-03 14:44:35 -0800 | [diff] [blame] | 1203 | if (j->flags.usergroups && j->flags.suppl_gids) { |
| 1204 | die("tried to inherit *and* set supplementary groups;" |
| 1205 | " can only do one"); |
| 1206 | } |
| 1207 | |
Jorge Lucangeli Obes | 6201cf5 | 2012-08-23 11:42:27 -0700 | [diff] [blame] | 1208 | if (j->flags.usergroups) { |
| 1209 | if (initgroups(j->user, j->usergid)) |
| 1210 | pdie("initgroups"); |
Jorge Lucangeli Obes | d16ac49 | 2015-12-03 14:44:35 -0800 | [diff] [blame] | 1211 | } else if (j->flags.suppl_gids) { |
| 1212 | if (setgroups(j->suppl_gid_count, j->suppl_gid_list)) { |
| 1213 | pdie("setgroups"); |
| 1214 | } |
Jorge Lucangeli Obes | 6201cf5 | 2012-08-23 11:42:27 -0700 | [diff] [blame] | 1215 | } else { |
Jorge Lucangeli Obes | d0a6e2f | 2015-11-24 14:21:21 -0800 | [diff] [blame] | 1216 | /* |
Jorge Lucangeli Obes | d16ac49 | 2015-12-03 14:44:35 -0800 | [diff] [blame] | 1217 | * Only attempt to clear supplementary groups if we are changing |
Jorge Lucangeli Obes | d0a6e2f | 2015-11-24 14:21:21 -0800 | [diff] [blame] | 1218 | * users. |
| 1219 | */ |
Jorge Lucangeli Obes | 6201cf5 | 2012-08-23 11:42:27 -0700 | [diff] [blame] | 1220 | if ((j->uid || j->gid) && setgroups(0, NULL)) |
| 1221 | pdie("setgroups"); |
| 1222 | } |
| 1223 | |
| 1224 | if (j->flags.gid && setresgid(j->gid, j->gid, j->gid)) |
| 1225 | pdie("setresgid"); |
| 1226 | |
| 1227 | if (j->flags.uid && setresuid(j->uid, j->uid, j->uid)) |
| 1228 | pdie("setresuid"); |
| 1229 | } |
| 1230 | |
Mike Frysinger | 3adfef7 | 2013-05-09 17:19:08 -0400 | [diff] [blame] | 1231 | /* |
| 1232 | * We specifically do not use cap_valid() as that only tells us the last |
| 1233 | * valid cap we were *compiled* against (i.e. what the version of kernel |
Jorge Lucangeli Obes | 4b276a6 | 2016-01-07 14:31:33 -0800 | [diff] [blame] | 1234 | * headers says). If we run on a different kernel version, then it's not |
Mike Frysinger | 3adfef7 | 2013-05-09 17:19:08 -0400 | [diff] [blame] | 1235 | * uncommon for that to be less (if an older kernel) or more (if a newer |
Jorge Lucangeli Obes | 4b276a6 | 2016-01-07 14:31:33 -0800 | [diff] [blame] | 1236 | * kernel). |
| 1237 | * Normally, we suck up the answer via /proc. On Android, not all processes are |
| 1238 | * guaranteed to be able to access '/proc/sys/kernel/cap_last_cap' so we |
| 1239 | * programmatically find the value by calling prctl(PR_CAPBSET_READ). |
Mike Frysinger | 3adfef7 | 2013-05-09 17:19:08 -0400 | [diff] [blame] | 1240 | */ |
Jorge Lucangeli Obes | 2034274 | 2015-10-27 11:39:59 -0700 | [diff] [blame] | 1241 | static unsigned int get_last_valid_cap() |
Mike Frysinger | 3adfef7 | 2013-05-09 17:19:08 -0400 | [diff] [blame] | 1242 | { |
Jorge Lucangeli Obes | 4b276a6 | 2016-01-07 14:31:33 -0800 | [diff] [blame] | 1243 | unsigned int last_valid_cap = 0; |
| 1244 | if (is_android()) { |
| 1245 | for (; prctl(PR_CAPBSET_READ, last_valid_cap, 0, 0, 0) >= 0; |
| 1246 | ++last_valid_cap); |
Mike Frysinger | 3adfef7 | 2013-05-09 17:19:08 -0400 | [diff] [blame] | 1247 | |
Jorge Lucangeli Obes | 4b276a6 | 2016-01-07 14:31:33 -0800 | [diff] [blame] | 1248 | /* |last_valid_cap| will be the first failing value. */ |
| 1249 | if (last_valid_cap > 0) { |
| 1250 | last_valid_cap--; |
| 1251 | } |
| 1252 | } else { |
| 1253 | const char cap_file[] = "/proc/sys/kernel/cap_last_cap"; |
| 1254 | FILE *fp = fopen(cap_file, "re"); |
| 1255 | if (fscanf(fp, "%u", &last_valid_cap) != 1) |
| 1256 | pdie("fscanf(%s)", cap_file); |
| 1257 | fclose(fp); |
| 1258 | } |
Dylan Reid | f682d47 | 2015-09-17 21:39:07 -0700 | [diff] [blame] | 1259 | return last_valid_cap; |
Mike Frysinger | 3adfef7 | 2013-05-09 17:19:08 -0400 | [diff] [blame] | 1260 | } |
| 1261 | |
Jorge Lucangeli Obes | f9fcdbe | 2016-02-19 15:04:09 -0800 | [diff] [blame] | 1262 | static void drop_capbset(uint64_t keep_mask, unsigned int last_valid_cap) |
| 1263 | { |
| 1264 | const uint64_t one = 1; |
| 1265 | unsigned int i; |
| 1266 | for (i = 0; i < sizeof(keep_mask) * 8 && i <= last_valid_cap; ++i) { |
| 1267 | if (keep_mask & (one << i)) |
| 1268 | continue; |
| 1269 | if (prctl(PR_CAPBSET_DROP, i)) |
| 1270 | pdie("could not drop capability from bounding set"); |
| 1271 | } |
| 1272 | } |
| 1273 | |
Jorge Lucangeli Obes | 2034274 | 2015-10-27 11:39:59 -0700 | [diff] [blame] | 1274 | void drop_caps(const struct minijail *j, unsigned int last_valid_cap) |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1275 | { |
Jorge Lucangeli Obes | 7ea269e | 2016-02-26 22:07:09 -0800 | [diff] [blame] | 1276 | if (!j->flags.use_caps) |
| 1277 | return; |
| 1278 | |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1279 | cap_t caps = cap_get_proc(); |
Kees Cook | 323878a | 2013-02-05 15:35:24 -0800 | [diff] [blame] | 1280 | cap_value_t flag[1]; |
Kees Cook | e5609ac | 2013-02-06 14:12:41 -0800 | [diff] [blame] | 1281 | const uint64_t one = 1; |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1282 | unsigned int i; |
| 1283 | if (!caps) |
| 1284 | die("can't get process caps"); |
| 1285 | if (cap_clear_flag(caps, CAP_INHERITABLE)) |
| 1286 | die("can't clear inheritable caps"); |
| 1287 | if (cap_clear_flag(caps, CAP_EFFECTIVE)) |
| 1288 | die("can't clear effective caps"); |
| 1289 | if (cap_clear_flag(caps, CAP_PERMITTED)) |
| 1290 | die("can't clear permitted caps"); |
Dylan Reid | f682d47 | 2015-09-17 21:39:07 -0700 | [diff] [blame] | 1291 | for (i = 0; i < sizeof(j->caps) * 8 && i <= last_valid_cap; ++i) { |
Kees Cook | 323878a | 2013-02-05 15:35:24 -0800 | [diff] [blame] | 1292 | /* Keep CAP_SETPCAP for dropping bounding set bits. */ |
Kees Cook | e5609ac | 2013-02-06 14:12:41 -0800 | [diff] [blame] | 1293 | if (i != CAP_SETPCAP && !(j->caps & (one << i))) |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1294 | continue; |
Kees Cook | 323878a | 2013-02-05 15:35:24 -0800 | [diff] [blame] | 1295 | flag[0] = i; |
| 1296 | if (cap_set_flag(caps, CAP_EFFECTIVE, 1, flag, CAP_SET)) |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1297 | die("can't add effective cap"); |
Kees Cook | 323878a | 2013-02-05 15:35:24 -0800 | [diff] [blame] | 1298 | if (cap_set_flag(caps, CAP_PERMITTED, 1, flag, CAP_SET)) |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1299 | die("can't add permitted cap"); |
Kees Cook | 323878a | 2013-02-05 15:35:24 -0800 | [diff] [blame] | 1300 | if (cap_set_flag(caps, CAP_INHERITABLE, 1, flag, CAP_SET)) |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1301 | die("can't add inheritable cap"); |
| 1302 | } |
| 1303 | if (cap_set_proc(caps)) |
Kees Cook | 323878a | 2013-02-05 15:35:24 -0800 | [diff] [blame] | 1304 | die("can't apply initial cleaned capset"); |
| 1305 | |
| 1306 | /* |
| 1307 | * Instead of dropping bounding set first, do it here in case |
| 1308 | * the caller had a more permissive bounding set which could |
| 1309 | * have been used above to raise a capability that wasn't already |
| 1310 | * present. This requires CAP_SETPCAP, so we raised/kept it above. |
| 1311 | */ |
Jorge Lucangeli Obes | f9fcdbe | 2016-02-19 15:04:09 -0800 | [diff] [blame] | 1312 | drop_capbset(j->caps, last_valid_cap); |
Kees Cook | 323878a | 2013-02-05 15:35:24 -0800 | [diff] [blame] | 1313 | |
| 1314 | /* If CAP_SETPCAP wasn't specifically requested, now we remove it. */ |
Kees Cook | e5609ac | 2013-02-06 14:12:41 -0800 | [diff] [blame] | 1315 | if ((j->caps & (one << CAP_SETPCAP)) == 0) { |
Kees Cook | 323878a | 2013-02-05 15:35:24 -0800 | [diff] [blame] | 1316 | flag[0] = CAP_SETPCAP; |
| 1317 | if (cap_set_flag(caps, CAP_EFFECTIVE, 1, flag, CAP_CLEAR)) |
| 1318 | die("can't clear effective cap"); |
| 1319 | if (cap_set_flag(caps, CAP_PERMITTED, 1, flag, CAP_CLEAR)) |
| 1320 | die("can't clear permitted cap"); |
| 1321 | if (cap_set_flag(caps, CAP_INHERITABLE, 1, flag, CAP_CLEAR)) |
| 1322 | die("can't clear inheritable cap"); |
| 1323 | } |
| 1324 | |
| 1325 | if (cap_set_proc(caps)) |
| 1326 | die("can't apply final cleaned capset"); |
| 1327 | |
| 1328 | cap_free(caps); |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 1329 | } |
| 1330 | |
Jorge Lucangeli Obes | 6201cf5 | 2012-08-23 11:42:27 -0700 | [diff] [blame] | 1331 | void set_seccomp_filter(const struct minijail *j) |
| 1332 | { |
| 1333 | /* |
| 1334 | * Set no_new_privs. See </kernel/seccomp.c> and </kernel/sys.c> |
| 1335 | * in the kernel source tree for an explanation of the parameters. |
| 1336 | */ |
| 1337 | if (j->flags.no_new_privs) { |
| 1338 | if (prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0)) |
| 1339 | pdie("prctl(PR_SET_NO_NEW_PRIVS)"); |
| 1340 | } |
| 1341 | |
| 1342 | /* |
| 1343 | * If we're logging seccomp filter failures, |
| 1344 | * install the SIGSYS handler first. |
| 1345 | */ |
| 1346 | if (j->flags.seccomp_filter && j->flags.log_seccomp_filter) { |
| 1347 | if (install_sigsys_handler()) |
| 1348 | pdie("install SIGSYS handler"); |
| 1349 | warn("logging seccomp filter failures"); |
| 1350 | } |
| 1351 | |
| 1352 | /* |
| 1353 | * Install the syscall filter. |
| 1354 | */ |
| 1355 | if (j->flags.seccomp_filter) { |
Jorge Lucangeli Obes | 43a6a86 | 2015-12-04 14:53:36 -0800 | [diff] [blame] | 1356 | if (prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, |
| 1357 | j->filter_prog)) { |
Jeff Vander Stoep | 2885bef | 2016-01-11 15:22:42 -0800 | [diff] [blame] | 1358 | if ((errno == EINVAL) && can_softfail()) { |
Utkarsh Sanghi | 0ef8a66 | 2014-08-18 15:50:11 -0700 | [diff] [blame] | 1359 | warn("seccomp not supported"); |
| 1360 | return; |
| 1361 | } |
Jorge Lucangeli Obes | 6201cf5 | 2012-08-23 11:42:27 -0700 | [diff] [blame] | 1362 | pdie("prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER)"); |
Utkarsh Sanghi | 0ef8a66 | 2014-08-18 15:50:11 -0700 | [diff] [blame] | 1363 | } |
Jorge Lucangeli Obes | 6201cf5 | 2012-08-23 11:42:27 -0700 | [diff] [blame] | 1364 | } |
| 1365 | } |
| 1366 | |
Will Drewry | 6ac9112 | 2011-10-21 16:38:58 -0500 | [diff] [blame] | 1367 | void API minijail_enter(const struct minijail *j) |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1368 | { |
Dylan Reid | f682d47 | 2015-09-17 21:39:07 -0700 | [diff] [blame] | 1369 | /* |
Jorge Lucangeli Obes | 43e29b3 | 2015-12-08 21:07:14 -0800 | [diff] [blame] | 1370 | * If we're dropping caps, get the last valid cap from /proc now, |
| 1371 | * since /proc can be unmounted before drop_caps() is called. |
Dylan Reid | f682d47 | 2015-09-17 21:39:07 -0700 | [diff] [blame] | 1372 | */ |
Jorge Lucangeli Obes | 43e29b3 | 2015-12-08 21:07:14 -0800 | [diff] [blame] | 1373 | unsigned int last_valid_cap = 0; |
Jorge Lucangeli Obes | f9fcdbe | 2016-02-19 15:04:09 -0800 | [diff] [blame] | 1374 | if (j->flags.capbset_drop || j->flags.use_caps) |
Jorge Lucangeli Obes | 43e29b3 | 2015-12-08 21:07:14 -0800 | [diff] [blame] | 1375 | last_valid_cap = get_last_valid_cap(); |
Dylan Reid | f682d47 | 2015-09-17 21:39:07 -0700 | [diff] [blame] | 1376 | |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1377 | if (j->flags.pids) |
| 1378 | die("tried to enter a pid-namespaced jail;" |
Jorge Lucangeli Obes | 1563b5b | 2014-07-10 07:01:53 -0700 | [diff] [blame] | 1379 | " try minijail_run()?"); |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 1380 | |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1381 | if (j->flags.usergroups && !j->user) |
| 1382 | die("usergroup inheritance without username"); |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 1383 | |
Elly Jones | dd3e851 | 2012-01-23 15:13:38 -0500 | [diff] [blame] | 1384 | /* |
| 1385 | * We can't recover from failures if we've dropped privileges partially, |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1386 | * so we don't even try. If any of our operations fail, we abort() the |
| 1387 | * entire process. |
| 1388 | */ |
Jorge Lucangeli Obes | 1563b5b | 2014-07-10 07:01:53 -0700 | [diff] [blame] | 1389 | if (j->flags.enter_vfs && setns(j->mountns_fd, CLONE_NEWNS)) |
| 1390 | pdie("setns(CLONE_NEWNS)"); |
| 1391 | |
Jorge Lucangeli Obes | 805be39 | 2015-10-12 15:55:59 -0700 | [diff] [blame] | 1392 | if (j->flags.vfs) { |
Jorge Lucangeli Obes | f7a3868 | 2015-12-04 15:43:30 -0800 | [diff] [blame] | 1393 | if (unshare(CLONE_NEWNS)) |
| 1394 | pdie("unshare(vfs)"); |
| 1395 | /* |
Jorge Lucangeli Obes | a521bee | 2016-03-03 13:47:57 -0800 | [diff] [blame] | 1396 | * Unless asked not to, remount all filesystems as private. |
| 1397 | * If they are shared, new bind mounts will creep out of our |
| 1398 | * namespace. |
Jorge Lucangeli Obes | f7a3868 | 2015-12-04 15:43:30 -0800 | [diff] [blame] | 1399 | * https://www.kernel.org/doc/Documentation/filesystems/sharedsubtree.txt |
| 1400 | */ |
Jorge Lucangeli Obes | a521bee | 2016-03-03 13:47:57 -0800 | [diff] [blame] | 1401 | if (!j->flags.skip_remount_private) { |
| 1402 | if (mount(NULL, "/", NULL, MS_REC | MS_PRIVATE, NULL)) |
| 1403 | pdie("mount(/, private)"); |
| 1404 | } |
Jorge Lucangeli Obes | f7a3868 | 2015-12-04 15:43:30 -0800 | [diff] [blame] | 1405 | } |
Elly Fong-Jones | 6c08630 | 2013-03-20 17:15:28 -0400 | [diff] [blame] | 1406 | |
Dylan Reid | f794247 | 2015-11-18 17:55:26 -0800 | [diff] [blame] | 1407 | if (j->flags.ipc && unshare(CLONE_NEWIPC)) { |
| 1408 | pdie("unshare(ipc)"); |
| 1409 | } |
| 1410 | |
Dylan Reid | 1102f5a | 2015-09-15 11:52:20 -0700 | [diff] [blame] | 1411 | if (j->flags.enter_net) { |
| 1412 | if (setns(j->netns_fd, CLONE_NEWNET)) |
| 1413 | pdie("setns(CLONE_NEWNET)"); |
| 1414 | } else if (j->flags.net && unshare(CLONE_NEWNET)) { |
Elly Fong-Jones | 6c08630 | 2013-03-20 17:15:28 -0400 | [diff] [blame] | 1415 | pdie("unshare(net)"); |
Dylan Reid | 1102f5a | 2015-09-15 11:52:20 -0700 | [diff] [blame] | 1416 | } |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 1417 | |
Elly Jones | 51a5b6c | 2011-10-12 19:09:26 -0400 | [diff] [blame] | 1418 | if (j->flags.chroot && enter_chroot(j)) |
| 1419 | pdie("chroot"); |
| 1420 | |
Yu-Hsi Chiang | 64d65a7 | 2015-08-13 17:43:27 +0800 | [diff] [blame] | 1421 | if (j->flags.pivot_root && enter_pivot_root(j)) |
| 1422 | pdie("pivot_root"); |
| 1423 | |
Jorge Lucangeli Obes | 3901da6 | 2015-03-03 13:55:11 -0800 | [diff] [blame] | 1424 | if (j->flags.mount_tmp && mount_tmp()) |
Lee Campbell | 11af062 | 2014-05-22 12:36:04 -0700 | [diff] [blame] | 1425 | pdie("mount_tmp"); |
| 1426 | |
Dylan Reid | 791f577 | 2015-09-14 20:02:42 -0700 | [diff] [blame] | 1427 | if (j->flags.remount_proc_ro && remount_proc_readonly(j)) |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1428 | pdie("remount"); |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 1429 | |
Jorge Lucangeli Obes | f9fcdbe | 2016-02-19 15:04:09 -0800 | [diff] [blame] | 1430 | /* |
| 1431 | * If we're only dropping capabilities from the bounding set, but not |
| 1432 | * from the thread's (permitted|inheritable|effective) sets, do it now. |
| 1433 | */ |
| 1434 | if (j->flags.capbset_drop) { |
| 1435 | drop_capbset(j->cap_bset, last_valid_cap); |
| 1436 | } |
| 1437 | |
| 1438 | if (j->flags.use_caps) { |
Elly Jones | dd3e851 | 2012-01-23 15:13:38 -0500 | [diff] [blame] | 1439 | /* |
| 1440 | * POSIX capabilities are a bit tricky. If we drop our |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1441 | * capability to change uids, our attempt to use setuid() |
| 1442 | * below will fail. Hang on to root caps across setuid(), then |
| 1443 | * lock securebits. |
| 1444 | */ |
| 1445 | if (prctl(PR_SET_KEEPCAPS, 1)) |
| 1446 | pdie("prctl(PR_SET_KEEPCAPS)"); |
| 1447 | if (prctl |
| 1448 | (PR_SET_SECUREBITS, SECURE_ALL_BITS | SECURE_ALL_LOCKS)) |
| 1449 | pdie("prctl(PR_SET_SECUREBITS)"); |
| 1450 | } |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 1451 | |
Jorge Lucangeli Obes | c2c9bcc | 2012-05-01 09:30:24 -0700 | [diff] [blame] | 1452 | if (j->flags.no_new_privs) { |
Jorge Lucangeli Obes | d8c8205 | 2016-02-25 16:00:32 -0800 | [diff] [blame] | 1453 | /* |
| 1454 | * If we're setting no_new_privs, we can drop privileges |
| 1455 | * before setting seccomp filter. This way filter policies |
| 1456 | * don't need to allow privilege-dropping syscalls. |
| 1457 | */ |
Jorge Lucangeli Obes | 6201cf5 | 2012-08-23 11:42:27 -0700 | [diff] [blame] | 1458 | drop_ugid(j); |
Jorge Lucangeli Obes | d8c8205 | 2016-02-25 16:00:32 -0800 | [diff] [blame] | 1459 | drop_caps(j, last_valid_cap); |
Jorge Lucangeli Obes | 6201cf5 | 2012-08-23 11:42:27 -0700 | [diff] [blame] | 1460 | set_seccomp_filter(j); |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1461 | } else { |
Jorge Lucangeli Obes | 6201cf5 | 2012-08-23 11:42:27 -0700 | [diff] [blame] | 1462 | /* |
| 1463 | * If we're not setting no_new_privs, |
| 1464 | * we need to set seccomp filter *before* dropping privileges. |
| 1465 | * WARNING: this means that filter policies *must* allow |
| 1466 | * setgroups()/setresgid()/setresuid() for dropping root and |
| 1467 | * capget()/capset()/prctl() for dropping caps. |
| 1468 | */ |
| 1469 | set_seccomp_filter(j); |
Jorge Lucangeli Obes | 6201cf5 | 2012-08-23 11:42:27 -0700 | [diff] [blame] | 1470 | drop_ugid(j); |
Jorge Lucangeli Obes | d8c8205 | 2016-02-25 16:00:32 -0800 | [diff] [blame] | 1471 | drop_caps(j, last_valid_cap); |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1472 | } |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 1473 | |
Elly Jones | dd3e851 | 2012-01-23 15:13:38 -0500 | [diff] [blame] | 1474 | /* |
Andrew Bresticker | eac2894 | 2015-11-11 16:04:46 -0800 | [diff] [blame] | 1475 | * Select the specified alternate syscall table. The table must not |
| 1476 | * block prctl(2) if we're using seccomp as well. |
| 1477 | */ |
| 1478 | if (j->flags.alt_syscall) { |
| 1479 | if (prctl(PR_ALT_SYSCALL, 1, j->alt_syscall_table)) |
| 1480 | pdie("prctl(PR_ALT_SYSCALL)"); |
| 1481 | } |
| 1482 | |
| 1483 | /* |
Elly Jones | dd3e851 | 2012-01-23 15:13:38 -0500 | [diff] [blame] | 1484 | * seccomp has to come last since it cuts off all the other |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1485 | * privilege-dropping syscalls :) |
| 1486 | */ |
Utkarsh Sanghi | 0ef8a66 | 2014-08-18 15:50:11 -0700 | [diff] [blame] | 1487 | if (j->flags.seccomp && prctl(PR_SET_SECCOMP, 1)) { |
Jeff Vander Stoep | 2885bef | 2016-01-11 15:22:42 -0800 | [diff] [blame] | 1488 | if ((errno == EINVAL) && can_softfail()) { |
Utkarsh Sanghi | 0ef8a66 | 2014-08-18 15:50:11 -0700 | [diff] [blame] | 1489 | warn("seccomp not supported"); |
| 1490 | return; |
| 1491 | } |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1492 | pdie("prctl(PR_SET_SECCOMP)"); |
Utkarsh Sanghi | 0ef8a66 | 2014-08-18 15:50:11 -0700 | [diff] [blame] | 1493 | } |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 1494 | } |
| 1495 | |
Will Drewry | 6ac9112 | 2011-10-21 16:38:58 -0500 | [diff] [blame] | 1496 | /* TODO(wad) will visibility affect this variable? */ |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 1497 | static int init_exitstatus = 0; |
| 1498 | |
Will Drewry | 6ac9112 | 2011-10-21 16:38:58 -0500 | [diff] [blame] | 1499 | void init_term(int __attribute__ ((unused)) sig) |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1500 | { |
| 1501 | _exit(init_exitstatus); |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 1502 | } |
| 1503 | |
Will Drewry | 6ac9112 | 2011-10-21 16:38:58 -0500 | [diff] [blame] | 1504 | int init(pid_t rootpid) |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1505 | { |
| 1506 | pid_t pid; |
| 1507 | int status; |
| 1508 | /* so that we exit with the right status */ |
| 1509 | signal(SIGTERM, init_term); |
| 1510 | /* TODO(wad) self jail with seccomp_filters here. */ |
| 1511 | while ((pid = wait(&status)) > 0) { |
Elly Jones | dd3e851 | 2012-01-23 15:13:38 -0500 | [diff] [blame] | 1512 | /* |
| 1513 | * This loop will only end when either there are no processes |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1514 | * left inside our pid namespace or we get a signal. |
| 1515 | */ |
| 1516 | if (pid == rootpid) |
| 1517 | init_exitstatus = status; |
| 1518 | } |
| 1519 | if (!WIFEXITED(init_exitstatus)) |
| 1520 | _exit(MINIJAIL_ERR_INIT); |
| 1521 | _exit(WEXITSTATUS(init_exitstatus)); |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 1522 | } |
| 1523 | |
Will Drewry | 6ac9112 | 2011-10-21 16:38:58 -0500 | [diff] [blame] | 1524 | int API minijail_from_fd(int fd, struct minijail *j) |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1525 | { |
| 1526 | size_t sz = 0; |
| 1527 | size_t bytes = read(fd, &sz, sizeof(sz)); |
| 1528 | char *buf; |
| 1529 | int r; |
| 1530 | if (sizeof(sz) != bytes) |
| 1531 | return -EINVAL; |
Jorge Lucangeli Obes | 5471450 | 2015-09-30 10:08:45 -0700 | [diff] [blame] | 1532 | if (sz > USHRT_MAX) /* arbitrary sanity check */ |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1533 | return -E2BIG; |
| 1534 | buf = malloc(sz); |
| 1535 | if (!buf) |
| 1536 | return -ENOMEM; |
| 1537 | bytes = read(fd, buf, sz); |
| 1538 | if (bytes != sz) { |
| 1539 | free(buf); |
| 1540 | return -EINVAL; |
| 1541 | } |
| 1542 | r = minijail_unmarshal(j, buf, sz); |
| 1543 | free(buf); |
| 1544 | return r; |
Will Drewry | 2f54b6a | 2011-09-16 13:45:31 -0500 | [diff] [blame] | 1545 | } |
| 1546 | |
Will Drewry | 6ac9112 | 2011-10-21 16:38:58 -0500 | [diff] [blame] | 1547 | int API minijail_to_fd(struct minijail *j, int fd) |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1548 | { |
| 1549 | char *buf; |
| 1550 | size_t sz = minijail_size(j); |
| 1551 | ssize_t written; |
| 1552 | int r; |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 1553 | |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1554 | if (!sz) |
| 1555 | return -EINVAL; |
| 1556 | buf = malloc(sz); |
| 1557 | r = minijail_marshal(j, buf, sz); |
| 1558 | if (r) { |
| 1559 | free(buf); |
| 1560 | return r; |
| 1561 | } |
| 1562 | /* Sends [size][minijail]. */ |
| 1563 | written = write(fd, &sz, sizeof(sz)); |
| 1564 | if (written != sizeof(sz)) { |
| 1565 | free(buf); |
| 1566 | return -EFAULT; |
| 1567 | } |
| 1568 | written = write(fd, buf, sz); |
| 1569 | if (written < 0 || (size_t) written != sz) { |
| 1570 | free(buf); |
| 1571 | return -EFAULT; |
| 1572 | } |
| 1573 | free(buf); |
| 1574 | return 0; |
Will Drewry | 2f54b6a | 2011-09-16 13:45:31 -0500 | [diff] [blame] | 1575 | } |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 1576 | |
Will Drewry | 6ac9112 | 2011-10-21 16:38:58 -0500 | [diff] [blame] | 1577 | int setup_preload(void) |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1578 | { |
Daniel Erat | 5b7a318 | 2015-08-19 16:06:22 -0600 | [diff] [blame] | 1579 | #if defined(__ANDROID__) |
Jorge Lucangeli Obes | a21c8fc | 2015-07-15 16:22:34 -0700 | [diff] [blame] | 1580 | /* Don't use LDPRELOAD on Brillo. */ |
| 1581 | return 0; |
| 1582 | #else |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1583 | char *oldenv = getenv(kLdPreloadEnvVar) ? : ""; |
| 1584 | char *newenv = malloc(strlen(oldenv) + 2 + strlen(PRELOADPATH)); |
| 1585 | if (!newenv) |
| 1586 | return -ENOMEM; |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 1587 | |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1588 | /* Only insert a separating space if we have something to separate... */ |
| 1589 | sprintf(newenv, "%s%s%s", oldenv, strlen(oldenv) ? " " : "", |
| 1590 | PRELOADPATH); |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 1591 | |
Jorge Lucangeli Obes | 5471450 | 2015-09-30 10:08:45 -0700 | [diff] [blame] | 1592 | /* setenv() makes a copy of the string we give it. */ |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1593 | setenv(kLdPreloadEnvVar, newenv, 1); |
| 1594 | free(newenv); |
| 1595 | return 0; |
Jorge Lucangeli Obes | a21c8fc | 2015-07-15 16:22:34 -0700 | [diff] [blame] | 1596 | #endif |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 1597 | } |
| 1598 | |
Will Drewry | 6ac9112 | 2011-10-21 16:38:58 -0500 | [diff] [blame] | 1599 | int setup_pipe(int fds[2]) |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1600 | { |
| 1601 | int r = pipe(fds); |
| 1602 | char fd_buf[11]; |
| 1603 | if (r) |
| 1604 | return r; |
| 1605 | r = snprintf(fd_buf, sizeof(fd_buf), "%d", fds[0]); |
| 1606 | if (r <= 0) |
| 1607 | return -EINVAL; |
| 1608 | setenv(kFdEnvVar, fd_buf, 1); |
| 1609 | return 0; |
Will Drewry | f89aef5 | 2011-09-16 16:48:57 -0500 | [diff] [blame] | 1610 | } |
| 1611 | |
Jorge Lucangeli Obes | 339a113 | 2013-02-15 16:53:47 -0800 | [diff] [blame] | 1612 | int setup_pipe_end(int fds[2], size_t index) |
| 1613 | { |
| 1614 | if (index > 1) |
| 1615 | return -1; |
| 1616 | |
| 1617 | close(fds[1 - index]); |
| 1618 | return fds[index]; |
| 1619 | } |
| 1620 | |
| 1621 | int setup_and_dupe_pipe_end(int fds[2], size_t index, int fd) |
| 1622 | { |
| 1623 | if (index > 1) |
| 1624 | return -1; |
| 1625 | |
| 1626 | close(fds[1 - index]); |
| 1627 | /* dup2(2) the corresponding end of the pipe into |fd|. */ |
| 1628 | return dup2(fds[index], fd); |
| 1629 | } |
| 1630 | |
Jorge Lucangeli Obes | 5471450 | 2015-09-30 10:08:45 -0700 | [diff] [blame] | 1631 | int minijail_run_internal(struct minijail *j, const char *filename, |
| 1632 | char *const argv[], pid_t *pchild_pid, |
| 1633 | int *pstdin_fd, int *pstdout_fd, int *pstderr_fd, |
| 1634 | int use_preload); |
| 1635 | |
Will Drewry | 6ac9112 | 2011-10-21 16:38:58 -0500 | [diff] [blame] | 1636 | int API minijail_run(struct minijail *j, const char *filename, |
| 1637 | char *const argv[]) |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1638 | { |
Jorge Lucangeli Obes | 5471450 | 2015-09-30 10:08:45 -0700 | [diff] [blame] | 1639 | return minijail_run_internal(j, filename, argv, NULL, NULL, NULL, NULL, |
| 1640 | true); |
Jorge Lucangeli Obes | 9807d03 | 2012-04-17 13:36:00 -0700 | [diff] [blame] | 1641 | } |
| 1642 | |
| 1643 | int API minijail_run_pid(struct minijail *j, const char *filename, |
| 1644 | char *const argv[], pid_t *pchild_pid) |
| 1645 | { |
Jorge Lucangeli Obes | 5471450 | 2015-09-30 10:08:45 -0700 | [diff] [blame] | 1646 | return minijail_run_internal(j, filename, argv, pchild_pid, |
| 1647 | NULL, NULL, NULL, true); |
Jorge Lucangeli Obes | df4bd35 | 2012-08-29 19:12:28 -0700 | [diff] [blame] | 1648 | } |
| 1649 | |
| 1650 | int API minijail_run_pipe(struct minijail *j, const char *filename, |
Jorge Lucangeli Obes | 6537a56 | 2012-09-05 10:39:40 -0700 | [diff] [blame] | 1651 | char *const argv[], int *pstdin_fd) |
Jorge Lucangeli Obes | df4bd35 | 2012-08-29 19:12:28 -0700 | [diff] [blame] | 1652 | { |
Jorge Lucangeli Obes | 5471450 | 2015-09-30 10:08:45 -0700 | [diff] [blame] | 1653 | return minijail_run_internal(j, filename, argv, NULL, pstdin_fd, |
| 1654 | NULL, NULL, true); |
Jorge Lucangeli Obes | df4bd35 | 2012-08-29 19:12:28 -0700 | [diff] [blame] | 1655 | } |
| 1656 | |
Jorge Lucangeli Obes | 339a113 | 2013-02-15 16:53:47 -0800 | [diff] [blame] | 1657 | int API minijail_run_pid_pipes(struct minijail *j, const char *filename, |
Jorge Lucangeli Obes | 4ae30cc | 2014-04-10 15:35:33 -0700 | [diff] [blame] | 1658 | char *const argv[], pid_t *pchild_pid, |
| 1659 | int *pstdin_fd, int *pstdout_fd, int *pstderr_fd) |
Jorge Lucangeli Obes | 339a113 | 2013-02-15 16:53:47 -0800 | [diff] [blame] | 1660 | { |
Jorge Lucangeli Obes | 5471450 | 2015-09-30 10:08:45 -0700 | [diff] [blame] | 1661 | return minijail_run_internal(j, filename, argv, pchild_pid, |
| 1662 | pstdin_fd, pstdout_fd, pstderr_fd, true); |
| 1663 | } |
| 1664 | |
| 1665 | int API minijail_run_no_preload(struct minijail *j, const char *filename, |
| 1666 | char *const argv[]) |
| 1667 | { |
| 1668 | return minijail_run_internal(j, filename, argv, NULL, NULL, NULL, NULL, |
| 1669 | false); |
| 1670 | } |
| 1671 | |
Samuel Tan | 63187f4 | 2015-10-16 13:01:53 -0700 | [diff] [blame] | 1672 | int API minijail_run_pid_pipes_no_preload(struct minijail *j, |
Jorge Lucangeli Obes | 43a6a86 | 2015-12-04 14:53:36 -0800 | [diff] [blame] | 1673 | const char *filename, |
| 1674 | char *const argv[], |
Samuel Tan | 63187f4 | 2015-10-16 13:01:53 -0700 | [diff] [blame] | 1675 | pid_t *pchild_pid, |
Jorge Lucangeli Obes | 43a6a86 | 2015-12-04 14:53:36 -0800 | [diff] [blame] | 1676 | int *pstdin_fd, int *pstdout_fd, |
Jorge Lucangeli Obes | a521bee | 2016-03-03 13:47:57 -0800 | [diff] [blame] | 1677 | int *pstderr_fd) |
| 1678 | { |
Samuel Tan | 63187f4 | 2015-10-16 13:01:53 -0700 | [diff] [blame] | 1679 | return minijail_run_internal(j, filename, argv, pchild_pid, |
| 1680 | pstdin_fd, pstdout_fd, pstderr_fd, false); |
| 1681 | } |
| 1682 | |
Jorge Lucangeli Obes | 5471450 | 2015-09-30 10:08:45 -0700 | [diff] [blame] | 1683 | int minijail_run_internal(struct minijail *j, const char *filename, |
| 1684 | char *const argv[], pid_t *pchild_pid, |
| 1685 | int *pstdin_fd, int *pstdout_fd, int *pstderr_fd, |
| 1686 | int use_preload) |
| 1687 | { |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1688 | char *oldenv, *oldenv_copy = NULL; |
| 1689 | pid_t child_pid; |
| 1690 | int pipe_fds[2]; |
Jorge Lucangeli Obes | df4bd35 | 2012-08-29 19:12:28 -0700 | [diff] [blame] | 1691 | int stdin_fds[2]; |
Jorge Lucangeli Obes | 339a113 | 2013-02-15 16:53:47 -0800 | [diff] [blame] | 1692 | int stdout_fds[2]; |
| 1693 | int stderr_fds[2]; |
Dylan Reid | ce5b55e | 2016-01-13 11:04:16 -0800 | [diff] [blame] | 1694 | int child_sync_pipe_fds[2]; |
| 1695 | int sync_child = 0; |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1696 | int ret; |
Elly Jones | a05d7bb | 2012-06-14 14:09:27 -0400 | [diff] [blame] | 1697 | /* We need to remember this across the minijail_preexec() call. */ |
| 1698 | int pid_namespace = j->flags.pids; |
Yu-Hsi Chiang | 3e954ec | 2015-07-28 16:48:14 +0800 | [diff] [blame] | 1699 | int do_init = j->flags.do_init; |
Ben Chan | 541c7e5 | 2011-08-26 14:55:53 -0700 | [diff] [blame] | 1700 | |
Jorge Lucangeli Obes | 5471450 | 2015-09-30 10:08:45 -0700 | [diff] [blame] | 1701 | if (use_preload) { |
| 1702 | oldenv = getenv(kLdPreloadEnvVar); |
| 1703 | if (oldenv) { |
| 1704 | oldenv_copy = strdup(oldenv); |
| 1705 | if (!oldenv_copy) |
| 1706 | return -ENOMEM; |
| 1707 | } |
| 1708 | |
| 1709 | if (setup_preload()) |
| 1710 | return -EFAULT; |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1711 | } |
Will Drewry | f89aef5 | 2011-09-16 16:48:57 -0500 | [diff] [blame] | 1712 | |
Jorge Lucangeli Obes | 5471450 | 2015-09-30 10:08:45 -0700 | [diff] [blame] | 1713 | if (!use_preload) { |
Jorge Lucangeli Obes | f9fcdbe | 2016-02-19 15:04:09 -0800 | [diff] [blame] | 1714 | if (j->flags.use_caps) |
Jorge Lucangeli Obes | 2b12ba4 | 2016-01-26 10:37:51 -0800 | [diff] [blame] | 1715 | die("capabilities are not supported without " |
Jorge Lucangeli Obes | 5471450 | 2015-09-30 10:08:45 -0700 | [diff] [blame] | 1716 | "LD_PRELOAD"); |
| 1717 | } |
Will Drewry | 2f54b6a | 2011-09-16 13:45:31 -0500 | [diff] [blame] | 1718 | |
Elly Jones | dd3e851 | 2012-01-23 15:13:38 -0500 | [diff] [blame] | 1719 | /* |
Jorge Lucangeli Obes | 3c84df1 | 2015-05-14 17:37:58 -0700 | [diff] [blame] | 1720 | * Make the process group ID of this process equal to its PID, so that |
| 1721 | * both the Minijail process and the jailed process can be killed |
| 1722 | * together. |
| 1723 | * Don't fail on EPERM, since setpgid(0, 0) can only EPERM when |
| 1724 | * the process is already a process group leader. |
| 1725 | */ |
| 1726 | if (setpgid(0 /* use calling PID */, 0 /* make PGID = PID */)) { |
| 1727 | if (errno != EPERM) { |
| 1728 | pdie("setpgid(0, 0)"); |
| 1729 | } |
| 1730 | } |
| 1731 | |
Jorge Lucangeli Obes | 5471450 | 2015-09-30 10:08:45 -0700 | [diff] [blame] | 1732 | if (use_preload) { |
| 1733 | /* |
| 1734 | * Before we fork(2) and execve(2) the child process, we need |
| 1735 | * to open a pipe(2) to send the minijail configuration over. |
| 1736 | */ |
| 1737 | if (setup_pipe(pipe_fds)) |
| 1738 | return -EFAULT; |
| 1739 | } |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 1740 | |
Jorge Lucangeli Obes | df4bd35 | 2012-08-29 19:12:28 -0700 | [diff] [blame] | 1741 | /* |
| 1742 | * If we want to write to the child process' standard input, |
| 1743 | * create the pipe(2) now. |
| 1744 | */ |
| 1745 | if (pstdin_fd) { |
| 1746 | if (pipe(stdin_fds)) |
| 1747 | return -EFAULT; |
| 1748 | } |
| 1749 | |
Jorge Lucangeli Obes | 339a113 | 2013-02-15 16:53:47 -0800 | [diff] [blame] | 1750 | /* |
| 1751 | * If we want to read from the child process' standard output, |
| 1752 | * create the pipe(2) now. |
| 1753 | */ |
| 1754 | if (pstdout_fd) { |
| 1755 | if (pipe(stdout_fds)) |
| 1756 | return -EFAULT; |
| 1757 | } |
| 1758 | |
| 1759 | /* |
| 1760 | * If we want to read from the child process' standard error, |
| 1761 | * create the pipe(2) now. |
| 1762 | */ |
| 1763 | if (pstderr_fd) { |
| 1764 | if (pipe(stderr_fds)) |
| 1765 | return -EFAULT; |
| 1766 | } |
| 1767 | |
Yu-Hsi Chiang | 10e9123 | 2015-08-05 14:40:45 +0800 | [diff] [blame] | 1768 | /* |
| 1769 | * If we want to set up a new uid/gid mapping in the user namespace, |
Jorge Lucangeli Obes | b8a5138 | 2016-01-25 20:08:22 -0800 | [diff] [blame] | 1770 | * or if we need to add the child process to cgroups, create the pipe(2) |
| 1771 | * to sync between parent and child. |
Yu-Hsi Chiang | 10e9123 | 2015-08-05 14:40:45 +0800 | [diff] [blame] | 1772 | */ |
Jorge Lucangeli Obes | b8a5138 | 2016-01-25 20:08:22 -0800 | [diff] [blame] | 1773 | if (j->flags.userns || j->flags.cgroups) { |
Dylan Reid | ce5b55e | 2016-01-13 11:04:16 -0800 | [diff] [blame] | 1774 | sync_child = 1; |
| 1775 | if (pipe(child_sync_pipe_fds)) |
Yu-Hsi Chiang | 10e9123 | 2015-08-05 14:40:45 +0800 | [diff] [blame] | 1776 | return -EFAULT; |
| 1777 | } |
| 1778 | |
Jorge Lucangeli Obes | d0a6e2f | 2015-11-24 14:21:21 -0800 | [diff] [blame] | 1779 | /* |
| 1780 | * Use sys_clone() if and only if we're creating a pid namespace. |
Elly Jones | 761b741 | 2012-06-13 15:49:52 -0400 | [diff] [blame] | 1781 | * |
| 1782 | * tl;dr: WARNING: do not mix pid namespaces and multithreading. |
| 1783 | * |
| 1784 | * In multithreaded programs, there are a bunch of locks inside libc, |
| 1785 | * some of which may be held by other threads at the time that we call |
| 1786 | * minijail_run_pid(). If we call fork(), glibc does its level best to |
| 1787 | * ensure that we hold all of these locks before it calls clone() |
| 1788 | * internally and drop them after clone() returns, but when we call |
| 1789 | * sys_clone(2) directly, all that gets bypassed and we end up with a |
| 1790 | * child address space where some of libc's important locks are held by |
| 1791 | * other threads (which did not get cloned, and hence will never release |
| 1792 | * those locks). This is okay so long as we call exec() immediately |
| 1793 | * after, but a bunch of seemingly-innocent libc functions like setenv() |
| 1794 | * take locks. |
| 1795 | * |
| 1796 | * Hence, only call sys_clone() if we need to, in order to get at pid |
| 1797 | * namespacing. If we follow this path, the child's address space might |
| 1798 | * have broken locks; you may only call functions that do not acquire |
| 1799 | * any locks. |
| 1800 | * |
| 1801 | * Unfortunately, fork() acquires every lock it can get its hands on, as |
| 1802 | * previously detailed, so this function is highly likely to deadlock |
| 1803 | * later on (see "deadlock here") if we're multithreaded. |
| 1804 | * |
| 1805 | * We might hack around this by having the clone()d child (init of the |
| 1806 | * pid namespace) return directly, rather than leaving the clone()d |
| 1807 | * process hanging around to be init for the new namespace (and having |
Jorge Lucangeli Obes | a521bee | 2016-03-03 13:47:57 -0800 | [diff] [blame] | 1808 | * its fork()ed child return in turn), but that process would be |
| 1809 | * crippled with its libc locks potentially broken. We might try |
| 1810 | * fork()ing in the parent before we clone() to ensure that we own all |
| 1811 | * the locks, but then we have to have the forked child hanging around |
| 1812 | * consuming resources (and possibly having file descriptors / shared |
| 1813 | * memory regions / etc attached). We'd need to keep the child around to |
| 1814 | * avoid having its children get reparented to init. |
Elly Jones | 761b741 | 2012-06-13 15:49:52 -0400 | [diff] [blame] | 1815 | * |
| 1816 | * TODO(ellyjones): figure out if the "forked child hanging around" |
| 1817 | * problem is fixable or not. It would be nice if we worked in this |
| 1818 | * case. |
| 1819 | */ |
Yu-Hsi Chiang | 10e9123 | 2015-08-05 14:40:45 +0800 | [diff] [blame] | 1820 | if (pid_namespace) { |
| 1821 | int clone_flags = CLONE_NEWPID | SIGCHLD; |
| 1822 | if (j->flags.userns) |
| 1823 | clone_flags |= CLONE_NEWUSER; |
| 1824 | child_pid = syscall(SYS_clone, clone_flags, NULL); |
Jorge Lucangeli Obes | 5471450 | 2015-09-30 10:08:45 -0700 | [diff] [blame] | 1825 | } else { |
Elly Jones | 761b741 | 2012-06-13 15:49:52 -0400 | [diff] [blame] | 1826 | child_pid = fork(); |
Jorge Lucangeli Obes | 5471450 | 2015-09-30 10:08:45 -0700 | [diff] [blame] | 1827 | } |
Elly Jones | 761b741 | 2012-06-13 15:49:52 -0400 | [diff] [blame] | 1828 | |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1829 | if (child_pid < 0) { |
Jorge Lucangeli Obes | 5471450 | 2015-09-30 10:08:45 -0700 | [diff] [blame] | 1830 | if (use_preload) { |
| 1831 | free(oldenv_copy); |
| 1832 | } |
Lee Campbell | 1e4fc6a | 2014-06-06 17:40:02 -0700 | [diff] [blame] | 1833 | die("failed to fork child"); |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1834 | } |
Will Drewry | f89aef5 | 2011-09-16 16:48:57 -0500 | [diff] [blame] | 1835 | |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1836 | if (child_pid) { |
Jorge Lucangeli Obes | 5471450 | 2015-09-30 10:08:45 -0700 | [diff] [blame] | 1837 | if (use_preload) { |
| 1838 | /* Restore parent's LD_PRELOAD. */ |
| 1839 | if (oldenv_copy) { |
| 1840 | setenv(kLdPreloadEnvVar, oldenv_copy, 1); |
| 1841 | free(oldenv_copy); |
| 1842 | } else { |
| 1843 | unsetenv(kLdPreloadEnvVar); |
| 1844 | } |
| 1845 | unsetenv(kFdEnvVar); |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1846 | } |
Jorge Lucangeli Obes | df4bd35 | 2012-08-29 19:12:28 -0700 | [diff] [blame] | 1847 | |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1848 | j->initpid = child_pid; |
Jorge Lucangeli Obes | df4bd35 | 2012-08-29 19:12:28 -0700 | [diff] [blame] | 1849 | |
Yu-Hsi Chiang | 3cc05ea | 2015-08-11 11:23:17 +0800 | [diff] [blame] | 1850 | if (j->flags.pid_file) |
| 1851 | write_pid_file(j); |
| 1852 | |
Jorge Lucangeli Obes | b8a5138 | 2016-01-25 20:08:22 -0800 | [diff] [blame] | 1853 | if (j->flags.cgroups) |
| 1854 | add_to_cgroups(j); |
Dylan Reid | 605ce7f | 2016-01-19 19:21:00 -0800 | [diff] [blame] | 1855 | |
Yu-Hsi Chiang | 10e9123 | 2015-08-05 14:40:45 +0800 | [diff] [blame] | 1856 | if (j->flags.userns) |
Dylan Reid | ce5b55e | 2016-01-13 11:04:16 -0800 | [diff] [blame] | 1857 | write_ugid_mappings(j); |
| 1858 | |
| 1859 | if (sync_child) |
| 1860 | parent_setup_complete(child_sync_pipe_fds); |
Yu-Hsi Chiang | 10e9123 | 2015-08-05 14:40:45 +0800 | [diff] [blame] | 1861 | |
Jorge Lucangeli Obes | 5471450 | 2015-09-30 10:08:45 -0700 | [diff] [blame] | 1862 | if (use_preload) { |
| 1863 | /* Send marshalled minijail. */ |
| 1864 | close(pipe_fds[0]); /* read endpoint */ |
| 1865 | ret = minijail_to_fd(j, pipe_fds[1]); |
| 1866 | close(pipe_fds[1]); /* write endpoint */ |
| 1867 | if (ret) { |
| 1868 | kill(j->initpid, SIGKILL); |
| 1869 | die("failed to send marshalled minijail"); |
| 1870 | } |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1871 | } |
Jorge Lucangeli Obes | df4bd35 | 2012-08-29 19:12:28 -0700 | [diff] [blame] | 1872 | |
Jorge Lucangeli Obes | 9807d03 | 2012-04-17 13:36:00 -0700 | [diff] [blame] | 1873 | if (pchild_pid) |
| 1874 | *pchild_pid = child_pid; |
Jorge Lucangeli Obes | df4bd35 | 2012-08-29 19:12:28 -0700 | [diff] [blame] | 1875 | |
| 1876 | /* |
| 1877 | * If we want to write to the child process' standard input, |
| 1878 | * set up the write end of the pipe. |
| 1879 | */ |
Jorge Lucangeli Obes | 339a113 | 2013-02-15 16:53:47 -0800 | [diff] [blame] | 1880 | if (pstdin_fd) |
| 1881 | *pstdin_fd = setup_pipe_end(stdin_fds, |
Jorge Lucangeli Obes | 5471450 | 2015-09-30 10:08:45 -0700 | [diff] [blame] | 1882 | 1 /* write end */); |
Jorge Lucangeli Obes | 339a113 | 2013-02-15 16:53:47 -0800 | [diff] [blame] | 1883 | |
| 1884 | /* |
| 1885 | * If we want to read from the child process' standard output, |
| 1886 | * set up the read end of the pipe. |
| 1887 | */ |
| 1888 | if (pstdout_fd) |
| 1889 | *pstdout_fd = setup_pipe_end(stdout_fds, |
Jorge Lucangeli Obes | 5471450 | 2015-09-30 10:08:45 -0700 | [diff] [blame] | 1890 | 0 /* read end */); |
Jorge Lucangeli Obes | 339a113 | 2013-02-15 16:53:47 -0800 | [diff] [blame] | 1891 | |
| 1892 | /* |
| 1893 | * If we want to read from the child process' standard error, |
| 1894 | * set up the read end of the pipe. |
| 1895 | */ |
| 1896 | if (pstderr_fd) |
| 1897 | *pstderr_fd = setup_pipe_end(stderr_fds, |
Jorge Lucangeli Obes | 5471450 | 2015-09-30 10:08:45 -0700 | [diff] [blame] | 1898 | 0 /* read end */); |
Jorge Lucangeli Obes | df4bd35 | 2012-08-29 19:12:28 -0700 | [diff] [blame] | 1899 | |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1900 | return 0; |
| 1901 | } |
| 1902 | free(oldenv_copy); |
Ben Chan | 541c7e5 | 2011-08-26 14:55:53 -0700 | [diff] [blame] | 1903 | |
Peter Qiu | 2860c46 | 2015-12-16 15:13:06 -0800 | [diff] [blame] | 1904 | if (j->flags.reset_signal_mask) { |
| 1905 | sigset_t signal_mask; |
| 1906 | if (sigemptyset(&signal_mask) != 0) |
| 1907 | pdie("sigemptyset failed"); |
| 1908 | if (sigprocmask(SIG_SETMASK, &signal_mask, NULL) != 0) |
| 1909 | pdie("sigprocmask failed"); |
| 1910 | } |
| 1911 | |
Dylan Reid | ce5b55e | 2016-01-13 11:04:16 -0800 | [diff] [blame] | 1912 | if (sync_child) |
| 1913 | wait_for_parent_setup(child_sync_pipe_fds); |
| 1914 | |
Yu-Hsi Chiang | 10e9123 | 2015-08-05 14:40:45 +0800 | [diff] [blame] | 1915 | if (j->flags.userns) |
Dylan Reid | ce5b55e | 2016-01-13 11:04:16 -0800 | [diff] [blame] | 1916 | enter_user_namespace(j); |
Yu-Hsi Chiang | 10e9123 | 2015-08-05 14:40:45 +0800 | [diff] [blame] | 1917 | |
Jorge Lucangeli Obes | df4bd35 | 2012-08-29 19:12:28 -0700 | [diff] [blame] | 1918 | /* |
| 1919 | * If we want to write to the jailed process' standard input, |
| 1920 | * set up the read end of the pipe. |
| 1921 | */ |
| 1922 | if (pstdin_fd) { |
Jorge Lucangeli Obes | 339a113 | 2013-02-15 16:53:47 -0800 | [diff] [blame] | 1923 | if (setup_and_dupe_pipe_end(stdin_fds, 0 /* read end */, |
| 1924 | STDIN_FILENO) < 0) |
Jorge Lucangeli Obes | df4bd35 | 2012-08-29 19:12:28 -0700 | [diff] [blame] | 1925 | die("failed to set up stdin pipe"); |
| 1926 | } |
| 1927 | |
Jorge Lucangeli Obes | 339a113 | 2013-02-15 16:53:47 -0800 | [diff] [blame] | 1928 | /* |
| 1929 | * If we want to read from the jailed process' standard output, |
| 1930 | * set up the write end of the pipe. |
| 1931 | */ |
| 1932 | if (pstdout_fd) { |
| 1933 | if (setup_and_dupe_pipe_end(stdout_fds, 1 /* write end */, |
| 1934 | STDOUT_FILENO) < 0) |
| 1935 | die("failed to set up stdout pipe"); |
| 1936 | } |
| 1937 | |
| 1938 | /* |
| 1939 | * If we want to read from the jailed process' standard error, |
| 1940 | * set up the write end of the pipe. |
| 1941 | */ |
| 1942 | if (pstderr_fd) { |
| 1943 | if (setup_and_dupe_pipe_end(stderr_fds, 1 /* write end */, |
| 1944 | STDERR_FILENO) < 0) |
| 1945 | die("failed to set up stderr pipe"); |
| 1946 | } |
| 1947 | |
Dylan Reid | 791f577 | 2015-09-14 20:02:42 -0700 | [diff] [blame] | 1948 | /* If running an init program, let it decide when/how to mount /proc. */ |
| 1949 | if (pid_namespace && !do_init) |
| 1950 | j->flags.remount_proc_ro = 0; |
| 1951 | |
Jorge Lucangeli Obes | 5471450 | 2015-09-30 10:08:45 -0700 | [diff] [blame] | 1952 | if (use_preload) { |
| 1953 | /* Strip out flags that cannot be inherited across execve(2). */ |
| 1954 | minijail_preexec(j); |
| 1955 | } else { |
| 1956 | j->flags.pids = 0; |
| 1957 | } |
| 1958 | /* Jail this process, then execve() the target. */ |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1959 | minijail_enter(j); |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 1960 | |
Yu-Hsi Chiang | 3e954ec | 2015-07-28 16:48:14 +0800 | [diff] [blame] | 1961 | if (pid_namespace && do_init) { |
Elly Jones | dd3e851 | 2012-01-23 15:13:38 -0500 | [diff] [blame] | 1962 | /* |
| 1963 | * pid namespace: this process will become init inside the new |
Yu-Hsi Chiang | 3e954ec | 2015-07-28 16:48:14 +0800 | [diff] [blame] | 1964 | * namespace. We don't want all programs we might exec to have |
Jorge Lucangeli Obes | 5471450 | 2015-09-30 10:08:45 -0700 | [diff] [blame] | 1965 | * to know how to be init. Normally (do_init == 1) we fork off |
Yu-Hsi Chiang | 3e954ec | 2015-07-28 16:48:14 +0800 | [diff] [blame] | 1966 | * a child to actually run the program. If |do_init == 0|, we |
| 1967 | * let the program keep pid 1 and be init. |
Elly Jones | 761b741 | 2012-06-13 15:49:52 -0400 | [diff] [blame] | 1968 | * |
| 1969 | * If we're multithreaded, we'll probably deadlock here. See |
| 1970 | * WARNING above. |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1971 | */ |
| 1972 | child_pid = fork(); |
| 1973 | if (child_pid < 0) |
| 1974 | _exit(child_pid); |
| 1975 | else if (child_pid > 0) |
| 1976 | init(child_pid); /* never returns */ |
| 1977 | } |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 1978 | |
Elly Jones | dd3e851 | 2012-01-23 15:13:38 -0500 | [diff] [blame] | 1979 | /* |
Jorge Lucangeli Obes | 5471450 | 2015-09-30 10:08:45 -0700 | [diff] [blame] | 1980 | * If we aren't pid-namespaced, or the jailed program asked to be init: |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1981 | * calling process |
| 1982 | * -> execve()-ing process |
| 1983 | * If we are: |
| 1984 | * calling process |
| 1985 | * -> init()-ing process |
| 1986 | * -> execve()-ing process |
| 1987 | */ |
| 1988 | _exit(execve(filename, argv, environ)); |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 1989 | } |
| 1990 | |
Will Drewry | 6ac9112 | 2011-10-21 16:38:58 -0500 | [diff] [blame] | 1991 | int API minijail_kill(struct minijail *j) |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 1992 | { |
| 1993 | int st; |
| 1994 | if (kill(j->initpid, SIGTERM)) |
| 1995 | return -errno; |
| 1996 | if (waitpid(j->initpid, &st, 0) < 0) |
| 1997 | return -errno; |
| 1998 | return st; |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 1999 | } |
| 2000 | |
Will Drewry | 6ac9112 | 2011-10-21 16:38:58 -0500 | [diff] [blame] | 2001 | int API minijail_wait(struct minijail *j) |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 2002 | { |
| 2003 | int st; |
| 2004 | if (waitpid(j->initpid, &st, 0) < 0) |
| 2005 | return -errno; |
Jorge Lucangeli Obes | 1530b74 | 2012-12-11 14:08:09 -0800 | [diff] [blame] | 2006 | |
Jorge Lucangeli Obes | c2c9bcc | 2012-05-01 09:30:24 -0700 | [diff] [blame] | 2007 | if (!WIFEXITED(st)) { |
Jorge Lucangeli Obes | 18d1eba | 2014-04-18 13:58:20 -0700 | [diff] [blame] | 2008 | int error_status = st; |
| 2009 | if (WIFSIGNALED(st)) { |
| 2010 | int signum = WTERMSIG(st); |
mukesh agrawal | c420a26 | 2013-06-11 17:22:42 -0700 | [diff] [blame] | 2011 | warn("child process %d received signal %d", |
Jorge Lucangeli Obes | 18d1eba | 2014-04-18 13:58:20 -0700 | [diff] [blame] | 2012 | j->initpid, signum); |
| 2013 | /* |
| 2014 | * We return MINIJAIL_ERR_JAIL if the process received |
| 2015 | * SIGSYS, which happens when a syscall is blocked by |
| 2016 | * seccomp filters. |
| 2017 | * If not, we do what bash(1) does: |
| 2018 | * $? = 128 + signum |
| 2019 | */ |
| 2020 | if (signum == SIGSYS) { |
| 2021 | error_status = MINIJAIL_ERR_JAIL; |
| 2022 | } else { |
| 2023 | error_status = 128 + signum; |
| 2024 | } |
| 2025 | } |
| 2026 | return error_status; |
Jorge Lucangeli Obes | c2c9bcc | 2012-05-01 09:30:24 -0700 | [diff] [blame] | 2027 | } |
Jorge Lucangeli Obes | 1530b74 | 2012-12-11 14:08:09 -0800 | [diff] [blame] | 2028 | |
| 2029 | int exit_status = WEXITSTATUS(st); |
| 2030 | if (exit_status != 0) |
mukesh agrawal | c420a26 | 2013-06-11 17:22:42 -0700 | [diff] [blame] | 2031 | info("child process %d exited with status %d", |
| 2032 | j->initpid, exit_status); |
Jorge Lucangeli Obes | 1530b74 | 2012-12-11 14:08:09 -0800 | [diff] [blame] | 2033 | |
| 2034 | return exit_status; |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 2035 | } |
| 2036 | |
Will Drewry | 6ac9112 | 2011-10-21 16:38:58 -0500 | [diff] [blame] | 2037 | void API minijail_destroy(struct minijail *j) |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 2038 | { |
Dylan Reid | 605ce7f | 2016-01-19 19:21:00 -0800 | [diff] [blame] | 2039 | size_t i; |
| 2040 | |
Jorge Lucangeli Obes | 524c040 | 2012-01-17 11:30:23 -0800 | [diff] [blame] | 2041 | if (j->flags.seccomp_filter && j->filter_prog) { |
| 2042 | free(j->filter_prog->filter); |
| 2043 | free(j->filter_prog); |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 2044 | } |
Dylan Reid | 648b220 | 2015-10-23 00:50:00 -0700 | [diff] [blame] | 2045 | while (j->mounts_head) { |
| 2046 | struct mountpoint *m = j->mounts_head; |
| 2047 | j->mounts_head = j->mounts_head->next; |
| 2048 | free(m->type); |
| 2049 | free(m->dest); |
| 2050 | free(m->src); |
| 2051 | free(m); |
Elly Jones | 51a5b6c | 2011-10-12 19:09:26 -0400 | [diff] [blame] | 2052 | } |
Dylan Reid | 648b220 | 2015-10-23 00:50:00 -0700 | [diff] [blame] | 2053 | j->mounts_tail = NULL; |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 2054 | if (j->user) |
| 2055 | free(j->user); |
Jorge Lucangeli Obes | e81a52f | 2015-12-04 16:05:23 -0800 | [diff] [blame] | 2056 | if (j->suppl_gid_list) |
| 2057 | free(j->suppl_gid_list); |
Will Drewry | bee7ba7 | 2011-10-21 20:47:01 -0500 | [diff] [blame] | 2058 | if (j->chrootdir) |
| 2059 | free(j->chrootdir); |
Andrew Bresticker | eac2894 | 2015-11-11 16:04:46 -0800 | [diff] [blame] | 2060 | if (j->alt_syscall_table) |
| 2061 | free(j->alt_syscall_table); |
Dylan Reid | 605ce7f | 2016-01-19 19:21:00 -0800 | [diff] [blame] | 2062 | for (i = 0; i < j->cgroup_count; ++i) |
| 2063 | free(j->cgroups[i]); |
Elly Jones | e1749eb | 2011-10-07 13:54:59 -0400 | [diff] [blame] | 2064 | free(j); |
Elly Jones | cd7a904 | 2011-07-22 13:56:51 -0400 | [diff] [blame] | 2065 | } |