Kristen Kozak | b27b1c7 | 2017-04-12 16:38:04 -0700 | [diff] [blame] | 1 | <FindBugsFilter> |
| 2 | <Match> |
| 3 | <!-- Reason: Null has a different meaning than a zero-length array in this case. --> |
| 4 | <Bug pattern="PZLA_PREFER_ZERO_LENGTH_ARRAYS"/> |
Bogdan Drutu | 709d97a | 2018-05-30 16:32:34 -0700 | [diff] [blame] | 5 | <Class name="io.opencensus.stats.MutableDistribution"/> |
| 6 | <Method name="getInternalBucketCountsArray"/> |
Kristen Kozak | b27b1c7 | 2017-04-12 16:38:04 -0700 | [diff] [blame] | 7 | </Match> |
Bogdan Drutu | 286ab5a | 2017-06-28 13:33:44 +0200 | [diff] [blame] | 8 | <Match> |
| 9 | <!-- Reason: Equal is implemented in the AutoValue generated class. --> |
| 10 | <Bug pattern="EQ_COMPARETO_USE_OBJECT_EQUALS"/> |
Bogdan Drutu | 709d97a | 2018-05-30 16:32:34 -0700 | [diff] [blame] | 11 | <Class name="io.opencensus.common.Timestamp"/> |
| 12 | <Method name="compareTo"/> |
Bogdan Drutu | 286ab5a | 2017-06-28 13:33:44 +0200 | [diff] [blame] | 13 | </Match> |
Yang Song | 36a87b8 | 2017-09-05 16:11:21 -0700 | [diff] [blame] | 14 | <Match> |
| 15 | <!-- Reason: Equal is implemented in the AutoValue generated class. --> |
| 16 | <Bug pattern="EQ_COMPARETO_USE_OBJECT_EQUALS"/> |
Bogdan Drutu | 709d97a | 2018-05-30 16:32:34 -0700 | [diff] [blame] | 17 | <Class name="io.opencensus.common.Duration"/> |
| 18 | <Method name="compareTo"/> |
Yang Song | 36a87b8 | 2017-09-05 16:11:21 -0700 | [diff] [blame] | 19 | </Match> |
Kristen Kozak | dc0ed0b | 2017-12-18 22:21:10 -0800 | [diff] [blame] | 20 | <Match> |
Hailong Wen | 131b6f0 | 2018-02-16 15:09:17 +0800 | [diff] [blame] | 21 | <!-- Reason: BaseMessageEvent only has two visible subclasses. --> |
| 22 | <Bug pattern="BC_UNCONFIRMED_CAST"/> |
Bogdan Drutu | 709d97a | 2018-05-30 16:32:34 -0700 | [diff] [blame] | 23 | <Class name="io.opencensus.trace.internal.BaseMessageEventUtils"/> |
Hailong Wen | 131b6f0 | 2018-02-16 15:09:17 +0800 | [diff] [blame] | 24 | </Match> |
Kristen Kozak | ba8aea8 | 2018-04-03 16:37:22 -0700 | [diff] [blame] | 25 | <Match> |
| 26 | <!-- Reason: This test is testing for a NPE. --> |
| 27 | <Bug pattern="NP_NONNULL_PARAM_VIOLATION"/> |
Bogdan Drutu | 709d97a | 2018-05-30 16:32:34 -0700 | [diff] [blame] | 28 | <Class name="io.opencensus.internal.UtilsTest"/> |
| 29 | <Method name="checkNotNull"/> |
Kristen Kozak | ba8aea8 | 2018-04-03 16:37:22 -0700 | [diff] [blame] | 30 | </Match> |
Kristen Kozak | 5d5b0f5 | 2018-04-03 16:37:22 -0700 | [diff] [blame] | 31 | <Match> |
Bogdan Drutu | eabc800 | 2018-08-28 14:40:27 -0700 | [diff] [blame] | 32 | <!-- Reason: This test is testing for a NPE. --> |
| 33 | <Bug pattern="NP_NONNULL_PARAM_VIOLATION"/> |
| 34 | <Class name="io.opencensus.internal.UtilsTest"/> |
| 35 | <Method name="checkNotNull_NullErrorMessage"/> |
| 36 | </Match> |
| 37 | <Match> |
Kristen Kozak | 5d5b0f5 | 2018-04-03 16:37:22 -0700 | [diff] [blame] | 38 | <!-- Reason: It seems like FindBugs incorrectly assumes that all --> |
| 39 | <!-- Throwables are subclasses of Error or Exception. --> |
| 40 | <Bug pattern="BC_VACUOUS_INSTANCEOF"/> |
Bogdan Drutu | 709d97a | 2018-05-30 16:32:34 -0700 | [diff] [blame] | 41 | <Class name="io.opencensus.trace.CurrentSpanUtils$CallableInSpan"/> |
| 42 | <Method name="call"/> |
| 43 | </Match> |
| 44 | <Match> |
| 45 | <!-- Reason: Protobuf auto-generated code. --> |
| 46 | <Bug pattern="UCF_USELESS_CONTROL_FLOW"/> |
| 47 | <Class name="io.opencensus.contrib.appengine.standard.util.TraceIdProto$Builder"/> |
| 48 | <Method name="maybeForceBuilderInitialization"/> |
Kristen Kozak | 5d5b0f5 | 2018-04-03 16:37:22 -0700 | [diff] [blame] | 49 | </Match> |
Bogdan Drutu | 847bdcb | 2018-08-20 16:38:36 -0700 | [diff] [blame] | 50 | <Match> |
| 51 | <!-- Reason: The synchronization in the setState is for the side effects not for the state. --> |
| 52 | <Bug pattern="UG_SYNC_SET_UNSYNC_GET"/> |
| 53 | <Class name="io.opencensus.implcore.stats.StatsComponentImplBase"/> |
| 54 | </Match> |
Kristen Kozak | 60b5926 | 2018-02-26 19:07:49 -0800 | [diff] [blame] | 55 | |
Kristen Kozak | cc7c7e1 | 2018-03-23 15:14:29 -0700 | [diff] [blame] | 56 | <!-- Suppress some FindBugs warnings related to performance or robustness --> |
| 57 | <!-- in test classes, where those issues are less important. --> |
| 58 | <Match> |
| 59 | <!-- Reason: Only needed for performance. --> |
| 60 | <Bug pattern="SIC_INNER_SHOULD_BE_STATIC_ANON"/> |
Bogdan Drutu | 709d97a | 2018-05-30 16:32:34 -0700 | [diff] [blame] | 61 | <Source name="~.*Test\.java"/> |
Kristen Kozak | cc7c7e1 | 2018-03-23 15:14:29 -0700 | [diff] [blame] | 62 | </Match> |
| 63 | <Match> |
| 64 | <!-- Reason: Only needed for performance. --> |
| 65 | <Bug pattern="WMI_WRONG_MAP_ITERATOR"/> |
Bogdan Drutu | 709d97a | 2018-05-30 16:32:34 -0700 | [diff] [blame] | 66 | <Source name="~.*Test\.java"/> |
Kristen Kozak | cc7c7e1 | 2018-03-23 15:14:29 -0700 | [diff] [blame] | 67 | </Match> |
| 68 | <Match> |
| 69 | <!-- Reason: Only needed for performance. --> |
| 70 | <Bug pattern="UM_UNNECESSARY_MATH"/> |
Bogdan Drutu | 709d97a | 2018-05-30 16:32:34 -0700 | [diff] [blame] | 71 | <Source name="~.*Test\.java"/> |
Kristen Kozak | cc7c7e1 | 2018-03-23 15:14:29 -0700 | [diff] [blame] | 72 | </Match> |
| 73 | <Match> |
| 74 | <!-- Reason: This is less important in a test environment. --> |
| 75 | <Bug pattern="DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED"/> |
Bogdan Drutu | 709d97a | 2018-05-30 16:32:34 -0700 | [diff] [blame] | 76 | <Source name="~.*Test\.java"/> |
Kristen Kozak | cc7c7e1 | 2018-03-23 15:14:29 -0700 | [diff] [blame] | 77 | </Match> |
| 78 | <Match> |
| 79 | <!-- Reason: Many classes initialize fields in @Before methods. --> |
| 80 | <Bug pattern="UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR"/> |
Bogdan Drutu | 709d97a | 2018-05-30 16:32:34 -0700 | [diff] [blame] | 81 | <Source name="~.*Test\.java"/> |
Kristen Kozak | cc7c7e1 | 2018-03-23 15:14:29 -0700 | [diff] [blame] | 82 | </Match> |
| 83 | |
| 84 | <!-- Suppress all FindBugs warnings about NullPointerExceptions in --> |
| 85 | <!-- non-test code. They are redundant with the Checker Framework's --> |
| 86 | <!-- warnings, and they sometimes conflict. These warnings are still --> |
| 87 | <!-- useful in test code, where we don't use the Checker Framework. --> |
Kristen Kozak | 60b5926 | 2018-02-26 19:07:49 -0800 | [diff] [blame] | 88 | <Match> |
| 89 | <Bug code="NP"/> |
Kristen Kozak | cc7c7e1 | 2018-03-23 15:14:29 -0700 | [diff] [blame] | 90 | <Not> |
Bogdan Drutu | 709d97a | 2018-05-30 16:32:34 -0700 | [diff] [blame] | 91 | <Source name="~.*Test\.java"/> |
Kristen Kozak | cc7c7e1 | 2018-03-23 15:14:29 -0700 | [diff] [blame] | 92 | </Not> |
Kristen Kozak | 60b5926 | 2018-02-26 19:07:49 -0800 | [diff] [blame] | 93 | </Match> |
| 94 | <Match> |
| 95 | <Bug pattern="UR_UNINIT_READ"/> |
Kristen Kozak | cc7c7e1 | 2018-03-23 15:14:29 -0700 | [diff] [blame] | 96 | <Not> |
Bogdan Drutu | 709d97a | 2018-05-30 16:32:34 -0700 | [diff] [blame] | 97 | <Source name="~.*Test\.java"/> |
Kristen Kozak | cc7c7e1 | 2018-03-23 15:14:29 -0700 | [diff] [blame] | 98 | </Not> |
Kristen Kozak | 60b5926 | 2018-02-26 19:07:49 -0800 | [diff] [blame] | 99 | </Match> |
| 100 | <Match> |
| 101 | <Bug pattern="UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR"/> |
Kristen Kozak | cc7c7e1 | 2018-03-23 15:14:29 -0700 | [diff] [blame] | 102 | <Not> |
Bogdan Drutu | 709d97a | 2018-05-30 16:32:34 -0700 | [diff] [blame] | 103 | <Source name="~.*Test\.java"/> |
Kristen Kozak | cc7c7e1 | 2018-03-23 15:14:29 -0700 | [diff] [blame] | 104 | </Not> |
Kristen Kozak | 60b5926 | 2018-02-26 19:07:49 -0800 | [diff] [blame] | 105 | </Match> |
Kristen Kozak | b27b1c7 | 2017-04-12 16:38:04 -0700 | [diff] [blame] | 106 | </FindBugsFilter> |