blob: 41fa164b71b96079ac102ce5c56325f3c794a368 [file] [log] [blame]
djm@openbsd.orgfccff332019-11-12 22:38:19 +00001/* $OpenBSD: ssh-sk.c,v 1.10 2019/11/12 22:38:19 djm Exp $ */
djm@openbsd.orged3467c2019-10-31 21:16:20 +00002/*
3 * Copyright (c) 2019 Google LLC
4 *
5 * Permission to use, copy, modify, and distribute this software for any
6 * purpose with or without fee is hereby granted, provided that the above
7 * copyright notice and this permission notice appear in all copies.
8 *
9 * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
10 * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
11 * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
12 * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
13 * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
14 * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
15 * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
16 */
17
18/* #define DEBUG_SK 1 */
19
20#include "includes.h"
21
Damien Miller764d51e2019-11-01 13:34:49 +110022#ifdef ENABLE_SK
23
djm@openbsd.orged3467c2019-10-31 21:16:20 +000024#include <dlfcn.h>
25#include <stddef.h>
26#include <stdint.h>
27#include <string.h>
28#include <stdio.h>
29
30#include <openssl/objects.h>
31#include <openssl/ec.h>
32
33#include "log.h"
34#include "misc.h"
35#include "sshbuf.h"
36#include "sshkey.h"
37#include "ssherr.h"
38#include "digest.h"
39
40#include "ssh-sk.h"
41#include "sk-api.h"
markus@openbsd.org7c32b512019-11-12 19:31:45 +000042#include "crypto_api.h"
djm@openbsd.orged3467c2019-10-31 21:16:20 +000043
44struct sshsk_provider {
45 char *path;
46 void *dlhandle;
47
48 /* Return the version of the middleware API */
49 uint32_t (*sk_api_version)(void);
50
51 /* Enroll a U2F key (private key generation) */
markus@openbsd.orgfd1a3b52019-11-12 19:32:30 +000052 int (*sk_enroll)(int alg, const uint8_t *challenge,
53 size_t challenge_len, const char *application, uint8_t flags,
djm@openbsd.orged3467c2019-10-31 21:16:20 +000054 struct sk_enroll_response **enroll_response);
55
56 /* Sign a challenge */
markus@openbsd.orgfd1a3b52019-11-12 19:32:30 +000057 int (*sk_sign)(int alg, const uint8_t *message, size_t message_len,
djm@openbsd.orged3467c2019-10-31 21:16:20 +000058 const char *application,
59 const uint8_t *key_handle, size_t key_handle_len,
60 uint8_t flags, struct sk_sign_response **sign_response);
61};
62
63static void
64sshsk_free(struct sshsk_provider *p)
65{
66 if (p == NULL)
67 return;
68 free(p->path);
69 if (p->dlhandle != NULL)
70 dlclose(p->dlhandle);
71 free(p);
72}
73
74static struct sshsk_provider *
75sshsk_open(const char *path)
76{
77 struct sshsk_provider *ret = NULL;
78 uint32_t version;
79
80 if ((ret = calloc(1, sizeof(*ret))) == NULL) {
81 error("%s: calloc failed", __func__);
82 return NULL;
83 }
84 if ((ret->path = strdup(path)) == NULL) {
85 error("%s: strdup failed", __func__);
86 goto fail;
87 }
88 if ((ret->dlhandle = dlopen(path, RTLD_NOW)) == NULL) {
89 error("Security key provider %s dlopen failed: %s",
90 path, dlerror());
91 goto fail;
92 }
93 if ((ret->sk_api_version = dlsym(ret->dlhandle,
94 "sk_api_version")) == NULL) {
95 error("Security key provider %s dlsym(sk_api_version) "
96 "failed: %s", path, dlerror());
97 goto fail;
98 }
99 version = ret->sk_api_version();
100 debug("%s: provider %s implements version 0x%08lx", __func__,
101 ret->path, (u_long)version);
102 if ((version & SSH_SK_VERSION_MAJOR_MASK) != SSH_SK_VERSION_MAJOR) {
103 error("Security key provider %s implements unsupported version "
104 "0x%08lx (supported: 0x%08lx)", path, (u_long)version,
105 (u_long)SSH_SK_VERSION_MAJOR);
106 goto fail;
107 }
108 if ((ret->sk_enroll = dlsym(ret->dlhandle, "sk_enroll")) == NULL) {
109 error("Security key provider %s dlsym(sk_enroll) "
110 "failed: %s", path, dlerror());
111 goto fail;
112 }
113 if ((ret->sk_sign = dlsym(ret->dlhandle, "sk_sign")) == NULL) {
114 error("Security key provider %s dlsym(sk_sign) failed: %s",
115 path, dlerror());
116 goto fail;
117 }
118 /* success */
119 return ret;
120fail:
121 sshsk_free(ret);
122 return NULL;
123}
124
125static void
126sshsk_free_enroll_response(struct sk_enroll_response *r)
127{
128 if (r == NULL)
129 return;
130 freezero(r->key_handle, r->key_handle_len);
131 freezero(r->public_key, r->public_key_len);
132 freezero(r->signature, r->signature_len);
133 freezero(r->attestation_cert, r->attestation_cert_len);
134 freezero(r, sizeof(*r));
135};
136
137static void
138sshsk_free_sign_response(struct sk_sign_response *r)
139{
140 if (r == NULL)
141 return;
142 freezero(r->sig_r, r->sig_r_len);
143 freezero(r->sig_s, r->sig_s_len);
144 freezero(r, sizeof(*r));
145};
146
markus@openbsd.orgcef84a02019-11-12 19:29:54 +0000147/* Assemble key from response */
148static int
149sshsk_ecdsa_assemble(struct sk_enroll_response *resp, struct sshkey **keyp)
150{
151 struct sshkey *key = NULL;
152 struct sshbuf *b = NULL;
153 EC_POINT *q = NULL;
154 int r;
155
156 *keyp = NULL;
157 if ((key = sshkey_new(KEY_ECDSA_SK)) == NULL) {
158 error("%s: sshkey_new failed", __func__);
159 r = SSH_ERR_ALLOC_FAIL;
160 goto out;
161 }
162 key->ecdsa_nid = NID_X9_62_prime256v1;
163 if ((key->ecdsa = EC_KEY_new_by_curve_name(key->ecdsa_nid)) == NULL ||
164 (q = EC_POINT_new(EC_KEY_get0_group(key->ecdsa))) == NULL ||
165 (b = sshbuf_new()) == NULL) {
166 error("%s: allocation failed", __func__);
167 r = SSH_ERR_ALLOC_FAIL;
168 goto out;
169 }
170 if ((r = sshbuf_put_string(b,
171 resp->public_key, resp->public_key_len)) != 0) {
172 error("%s: buffer error: %s", __func__, ssh_err(r));
173 goto out;
174 }
175 if ((r = sshbuf_get_ec(b, q, EC_KEY_get0_group(key->ecdsa))) != 0) {
176 error("%s: parse key: %s", __func__, ssh_err(r));
177 r = SSH_ERR_INVALID_FORMAT;
178 goto out;
179 }
180 if (sshkey_ec_validate_public(EC_KEY_get0_group(key->ecdsa), q) != 0) {
181 error("Security key returned invalid ECDSA key");
182 r = SSH_ERR_KEY_INVALID_EC_VALUE;
183 goto out;
184 }
185 if (EC_KEY_set_public_key(key->ecdsa, q) != 1) {
186 /* XXX assume it is a allocation error */
187 error("%s: allocation failed", __func__);
188 r = SSH_ERR_ALLOC_FAIL;
189 goto out;
190 }
191 /* success */
192 *keyp = key;
193 key = NULL; /* transferred */
194 r = 0;
195 out:
196 EC_POINT_free(q);
197 sshkey_free(key);
198 sshbuf_free(b);
199 return r;
200}
201
markus@openbsd.org7c32b512019-11-12 19:31:45 +0000202static int
203sshsk_ed25519_assemble(struct sk_enroll_response *resp, struct sshkey **keyp)
204{
205 struct sshkey *key = NULL;
206 int r;
207
208 *keyp = NULL;
209 if (resp->public_key_len != ED25519_PK_SZ) {
210 error("%s: invalid size: %zu", __func__, resp->public_key_len);
211 r = SSH_ERR_INVALID_FORMAT;
212 goto out;
213 }
214 if ((key = sshkey_new(KEY_ED25519_SK)) == NULL) {
215 error("%s: sshkey_new failed", __func__);
216 r = SSH_ERR_ALLOC_FAIL;
217 goto out;
218 }
219 if ((key->ed25519_pk = malloc(ED25519_PK_SZ)) == NULL) {
220 error("%s: malloc failed", __func__);
221 r = SSH_ERR_ALLOC_FAIL;
222 goto out;
223 }
224 memcpy(key->ed25519_pk, resp->public_key, ED25519_PK_SZ);
225 /* success */
226 *keyp = key;
227 key = NULL; /* transferred */
228 r = 0;
229 out:
230 sshkey_free(key);
231 return r;
232}
233
djm@openbsd.orged3467c2019-10-31 21:16:20 +0000234int
markus@openbsd.org7c32b512019-11-12 19:31:45 +0000235sshsk_enroll(int type, const char *provider_path, const char *application,
djm@openbsd.orged3467c2019-10-31 21:16:20 +0000236 uint8_t flags, struct sshbuf *challenge_buf, struct sshkey **keyp,
237 struct sshbuf *attest)
238{
239 struct sshsk_provider *skp = NULL;
240 struct sshkey *key = NULL;
241 u_char randchall[32];
242 const u_char *challenge;
243 size_t challenge_len;
244 struct sk_enroll_response *resp = NULL;
245 int r = SSH_ERR_INTERNAL_ERROR;
markus@openbsd.orgfd1a3b52019-11-12 19:32:30 +0000246 int alg;
djm@openbsd.orged3467c2019-10-31 21:16:20 +0000247
248 *keyp = NULL;
249 if (attest)
250 sshbuf_reset(attest);
markus@openbsd.org7c32b512019-11-12 19:31:45 +0000251 switch (type) {
252 case KEY_ECDSA_SK:
markus@openbsd.orgfd1a3b52019-11-12 19:32:30 +0000253 alg = SSH_SK_ECDSA;
254 break;
markus@openbsd.org7c32b512019-11-12 19:31:45 +0000255 case KEY_ED25519_SK:
markus@openbsd.orgfd1a3b52019-11-12 19:32:30 +0000256 alg = SSH_SK_ED25519;
markus@openbsd.org7c32b512019-11-12 19:31:45 +0000257 break;
258 default:
259 error("%s: unsupported key type", __func__);
260 r = SSH_ERR_INVALID_ARGUMENT;
261 goto out;
262 }
djm@openbsd.orged3467c2019-10-31 21:16:20 +0000263 if (provider_path == NULL) {
264 error("%s: missing provider", __func__);
265 r = SSH_ERR_INVALID_ARGUMENT;
266 goto out;
267 }
268 if (application == NULL || *application == '\0') {
269 error("%s: missing application", __func__);
270 r = SSH_ERR_INVALID_ARGUMENT;
271 goto out;
272 }
273 if (challenge_buf == NULL) {
274 debug("%s: using random challenge", __func__);
275 arc4random_buf(randchall, sizeof(randchall));
276 challenge = randchall;
277 challenge_len = sizeof(randchall);
278 } else if (sshbuf_len(challenge_buf) == 0) {
279 error("Missing enrollment challenge");
280 r = SSH_ERR_INVALID_ARGUMENT;
281 goto out;
282 } else {
283 challenge = sshbuf_ptr(challenge_buf);
284 challenge_len = sshbuf_len(challenge_buf);
285 debug3("%s: using explicit challenge len=%zd",
286 __func__, challenge_len);
287 }
288 if ((skp = sshsk_open(provider_path)) == NULL) {
289 r = SSH_ERR_INVALID_FORMAT; /* XXX sshsk_open return code? */
290 goto out;
291 }
292 /* XXX validate flags? */
293 /* enroll key */
markus@openbsd.orgfd1a3b52019-11-12 19:32:30 +0000294 if ((r = skp->sk_enroll(alg, challenge, challenge_len, application,
djm@openbsd.orged3467c2019-10-31 21:16:20 +0000295 flags, &resp)) != 0) {
296 error("Security key provider %s returned failure %d",
297 provider_path, r);
298 r = SSH_ERR_INVALID_FORMAT; /* XXX error codes in API? */
299 goto out;
300 }
301 /* Check response validity */
302 if (resp->public_key == NULL || resp->key_handle == NULL ||
djm@openbsd.orgfccff332019-11-12 22:38:19 +0000303 resp->signature == NULL ||
304 (resp->attestation_cert == NULL && resp->attestation_cert_len != 0)) {
djm@openbsd.orged3467c2019-10-31 21:16:20 +0000305 error("%s: sk_enroll response invalid", __func__);
306 r = SSH_ERR_INVALID_FORMAT;
307 goto out;
308 }
markus@openbsd.org7c32b512019-11-12 19:31:45 +0000309 switch (type) {
310 case KEY_ECDSA_SK:
311 if ((r = sshsk_ecdsa_assemble(resp, &key)) != 0)
312 goto out;
313 break;
314 case KEY_ED25519_SK:
315 if ((r = sshsk_ed25519_assemble(resp, &key)) != 0)
316 goto out;
317 break;
318 }
djm@openbsd.orged3467c2019-10-31 21:16:20 +0000319 key->sk_flags = flags;
markus@openbsd.orgcef84a02019-11-12 19:29:54 +0000320 if ((key->sk_key_handle = sshbuf_new()) == NULL ||
321 (key->sk_reserved = sshbuf_new()) == NULL) {
djm@openbsd.orged3467c2019-10-31 21:16:20 +0000322 error("%s: allocation failed", __func__);
323 r = SSH_ERR_ALLOC_FAIL;
324 goto out;
325 }
djm@openbsd.orged3467c2019-10-31 21:16:20 +0000326 if ((key->sk_application = strdup(application)) == NULL) {
327 error("%s: strdup application failed", __func__);
328 r = SSH_ERR_ALLOC_FAIL;
329 goto out;
330 }
djm@openbsd.orged3467c2019-10-31 21:16:20 +0000331 if ((r = sshbuf_put(key->sk_key_handle, resp->key_handle,
332 resp->key_handle_len)) != 0) {
333 error("%s: buffer error: %s", __func__, ssh_err(r));
334 goto out;
335 }
336 /* Optionally fill in the attestation information */
337 if (attest != NULL) {
338 if ((r = sshbuf_put_cstring(attest, "sk-attest-v00")) != 0 ||
339 (r = sshbuf_put_u32(attest, 1)) != 0 || /* XXX U2F ver */
340 (r = sshbuf_put_string(attest,
341 resp->attestation_cert, resp->attestation_cert_len)) != 0 ||
342 (r = sshbuf_put_string(attest,
343 resp->signature, resp->signature_len)) != 0 ||
344 (r = sshbuf_put_u32(attest, flags)) != 0 || /* XXX right? */
345 (r = sshbuf_put_string(attest, NULL, 0)) != 0) {
346 error("%s: buffer error: %s", __func__, ssh_err(r));
347 goto out;
348 }
349 }
350 /* success */
351 *keyp = key;
352 key = NULL; /* transferred */
353 r = 0;
354 out:
djm@openbsd.orged3467c2019-10-31 21:16:20 +0000355 sshsk_free(skp);
djm@openbsd.orged3467c2019-10-31 21:16:20 +0000356 sshkey_free(key);
357 sshsk_free_enroll_response(resp);
358 explicit_bzero(randchall, sizeof(randchall));
359 return r;
360}
361
markus@openbsd.orgbc7b5d62019-11-12 19:30:21 +0000362static int
markus@openbsd.orgb556cc32019-11-12 19:34:40 +0000363sshsk_ecdsa_sig(struct sk_sign_response *resp, struct sshbuf *sig)
markus@openbsd.orgbc7b5d62019-11-12 19:30:21 +0000364{
365 struct sshbuf *inner_sig = NULL;
366 int r = SSH_ERR_INTERNAL_ERROR;
367
markus@openbsd.org3fcf69a2019-11-12 19:34:00 +0000368 /* Check response validity */
369 if (resp->sig_r == NULL || resp->sig_r == NULL) {
370 error("%s: sk_sign response invalid", __func__);
371 r = SSH_ERR_INVALID_FORMAT;
372 goto out;
373 }
markus@openbsd.orgbc7b5d62019-11-12 19:30:21 +0000374 if ((inner_sig = sshbuf_new()) == NULL) {
375 r = SSH_ERR_ALLOC_FAIL;
376 goto out;
377 }
markus@openbsd.orgb556cc32019-11-12 19:34:40 +0000378 /* Prepare and append inner signature object */
markus@openbsd.orgbc7b5d62019-11-12 19:30:21 +0000379 if ((r = sshbuf_put_bignum2_bytes(inner_sig,
380 resp->sig_r, resp->sig_r_len)) != 0 ||
381 (r = sshbuf_put_bignum2_bytes(inner_sig,
382 resp->sig_s, resp->sig_s_len)) != 0 ||
383 (r = sshbuf_put_u8(inner_sig, resp->flags)) != 0 ||
384 (r = sshbuf_put_u32(inner_sig, resp->counter)) != 0) {
385 debug("%s: buffer error: %s", __func__, ssh_err(r));
386 goto out;
387 }
markus@openbsd.orgb556cc32019-11-12 19:34:40 +0000388 if ((r = sshbuf_put_stringb(sig, inner_sig)) != 0) {
389 debug("%s: buffer error: %s", __func__, ssh_err(r));
390 goto out;
391 }
markus@openbsd.orgbc7b5d62019-11-12 19:30:21 +0000392#ifdef DEBUG_SK
393 fprintf(stderr, "%s: sig_r:\n", __func__);
394 sshbuf_dump_data(resp->sig_r, resp->sig_r_len, stderr);
395 fprintf(stderr, "%s: sig_s:\n", __func__);
396 sshbuf_dump_data(resp->sig_s, resp->sig_s_len, stderr);
markus@openbsd.orgb556cc32019-11-12 19:34:40 +0000397 fprintf(stderr, "%s: inner:\n", __func__);
398 sshbuf_dump(inner_sig, stderr);
markus@openbsd.orgfe05a362019-11-12 19:31:18 +0000399#endif
markus@openbsd.orgfe05a362019-11-12 19:31:18 +0000400 r = 0;
markus@openbsd.orgb556cc32019-11-12 19:34:40 +0000401 out:
markus@openbsd.orgfe05a362019-11-12 19:31:18 +0000402 sshbuf_free(inner_sig);
403 return r;
404}
405
406static int
markus@openbsd.orgb556cc32019-11-12 19:34:40 +0000407sshsk_ed25519_sig(struct sk_sign_response *resp, struct sshbuf *sig)
markus@openbsd.orgfe05a362019-11-12 19:31:18 +0000408{
markus@openbsd.orgfe05a362019-11-12 19:31:18 +0000409 int r = SSH_ERR_INTERNAL_ERROR;
410
markus@openbsd.org3fcf69a2019-11-12 19:34:00 +0000411 /* Check response validity */
412 if (resp->sig_r == NULL) {
413 error("%s: sk_sign response invalid", __func__);
414 r = SSH_ERR_INVALID_FORMAT;
415 goto out;
416 }
markus@openbsd.orgb556cc32019-11-12 19:34:40 +0000417 if ((r = sshbuf_put_string(sig,
markus@openbsd.orgfe05a362019-11-12 19:31:18 +0000418 resp->sig_r, resp->sig_r_len)) != 0 ||
markus@openbsd.orgb556cc32019-11-12 19:34:40 +0000419 (r = sshbuf_put_u8(sig, resp->flags)) != 0 ||
420 (r = sshbuf_put_u32(sig, resp->counter)) != 0) {
markus@openbsd.orgfe05a362019-11-12 19:31:18 +0000421 debug("%s: buffer error: %s", __func__, ssh_err(r));
422 goto out;
423 }
424#ifdef DEBUG_SK
425 fprintf(stderr, "%s: sig_r:\n", __func__);
426 sshbuf_dump_data(resp->sig_r, resp->sig_r_len, stderr);
markus@openbsd.orgbc7b5d62019-11-12 19:30:21 +0000427#endif
markus@openbsd.orgbc7b5d62019-11-12 19:30:21 +0000428 r = 0;
markus@openbsd.orgb556cc32019-11-12 19:34:40 +0000429 out:
430 return 0;
markus@openbsd.orgbc7b5d62019-11-12 19:30:21 +0000431}
432
djm@openbsd.orged3467c2019-10-31 21:16:20 +0000433int
markus@openbsd.orge03a29e2019-11-12 19:30:50 +0000434sshsk_sign(const char *provider_path, const struct sshkey *key,
djm@openbsd.orged3467c2019-10-31 21:16:20 +0000435 u_char **sigp, size_t *lenp, const u_char *data, size_t datalen,
436 u_int compat)
437{
438 struct sshsk_provider *skp = NULL;
439 int r = SSH_ERR_INTERNAL_ERROR;
markus@openbsd.orgfd1a3b52019-11-12 19:32:30 +0000440 int type, alg;
djm@openbsd.orged3467c2019-10-31 21:16:20 +0000441 struct sk_sign_response *resp = NULL;
442 struct sshbuf *inner_sig = NULL, *sig = NULL;
443 uint8_t message[32];
444
445 if (sigp != NULL)
446 *sigp = NULL;
447 if (lenp != NULL)
448 *lenp = 0;
markus@openbsd.orgfe05a362019-11-12 19:31:18 +0000449 type = sshkey_type_plain(key->type);
450 switch (type) {
451 case KEY_ECDSA_SK:
markus@openbsd.orgfd1a3b52019-11-12 19:32:30 +0000452 alg = SSH_SK_ECDSA;
453 break;
markus@openbsd.orgfe05a362019-11-12 19:31:18 +0000454 case KEY_ED25519_SK:
markus@openbsd.orgfd1a3b52019-11-12 19:32:30 +0000455 alg = SSH_SK_ED25519;
markus@openbsd.orgfe05a362019-11-12 19:31:18 +0000456 break;
457 default:
458 return SSH_ERR_INVALID_ARGUMENT;
459 }
djm@openbsd.orged3467c2019-10-31 21:16:20 +0000460 if (provider_path == NULL ||
djm@openbsd.orged3467c2019-10-31 21:16:20 +0000461 key->sk_key_handle == NULL ||
462 key->sk_application == NULL || *key->sk_application == '\0') {
463 r = SSH_ERR_INVALID_ARGUMENT;
464 goto out;
465 }
466 if ((skp = sshsk_open(provider_path)) == NULL) {
467 r = SSH_ERR_INVALID_FORMAT; /* XXX sshsk_open return code? */
468 goto out;
469 }
470
471 /* hash data to be signed before it goes to the security key */
472 if ((r = ssh_digest_memory(SSH_DIGEST_SHA256, data, datalen,
473 message, sizeof(message))) != 0) {
474 error("%s: hash application failed: %s", __func__, ssh_err(r));
475 r = SSH_ERR_INTERNAL_ERROR;
476 goto out;
477 }
markus@openbsd.orgfd1a3b52019-11-12 19:32:30 +0000478 if ((r = skp->sk_sign(alg, message, sizeof(message),
djm@openbsd.orged3467c2019-10-31 21:16:20 +0000479 key->sk_application,
480 sshbuf_ptr(key->sk_key_handle), sshbuf_len(key->sk_key_handle),
481 key->sk_flags, &resp)) != 0) {
482 debug("%s: sk_sign failed with code %d", __func__, r);
483 goto out;
484 }
markus@openbsd.orgb556cc32019-11-12 19:34:40 +0000485 /* Assemble signature */
markus@openbsd.orgbc7b5d62019-11-12 19:30:21 +0000486 if ((sig = sshbuf_new()) == NULL) {
djm@openbsd.orged3467c2019-10-31 21:16:20 +0000487 r = SSH_ERR_ALLOC_FAIL;
488 goto out;
489 }
markus@openbsd.orgb556cc32019-11-12 19:34:40 +0000490 if ((r = sshbuf_put_cstring(sig, sshkey_ssh_name_plain(key))) != 0) {
djm@openbsd.orged3467c2019-10-31 21:16:20 +0000491 debug("%s: buffer error (outer): %s", __func__, ssh_err(r));
492 goto out;
493 }
markus@openbsd.orgb556cc32019-11-12 19:34:40 +0000494 switch (type) {
495 case KEY_ECDSA_SK:
496 if ((r = sshsk_ecdsa_sig(resp, sig)) != 0)
497 goto out;
498 break;
499 case KEY_ED25519_SK:
500 if ((r = sshsk_ed25519_sig(resp, sig)) != 0)
501 goto out;
502 break;
503 }
djm@openbsd.orged3467c2019-10-31 21:16:20 +0000504#ifdef DEBUG_SK
markus@openbsd.orgfe05a362019-11-12 19:31:18 +0000505 fprintf(stderr, "%s: sig_flags = 0x%02x, sig_counter = %u\n",
506 __func__, resp->flags, resp->counter);
djm@openbsd.orged3467c2019-10-31 21:16:20 +0000507 fprintf(stderr, "%s: hashed message:\n", __func__);
508 sshbuf_dump_data(message, sizeof(message), stderr);
djm@openbsd.orged3467c2019-10-31 21:16:20 +0000509 fprintf(stderr, "%s: sigbuf:\n", __func__);
510 sshbuf_dump(sig, stderr);
511#endif
512 if (sigp != NULL) {
513 if ((*sigp = malloc(sshbuf_len(sig))) == NULL) {
514 r = SSH_ERR_ALLOC_FAIL;
515 goto out;
516 }
517 memcpy(*sigp, sshbuf_ptr(sig), sshbuf_len(sig));
518 }
519 if (lenp != NULL)
520 *lenp = sshbuf_len(sig);
521 /* success */
522 r = 0;
523 out:
524 explicit_bzero(message, sizeof(message));
525 sshsk_free(skp);
526 sshsk_free_sign_response(resp);
527 sshbuf_free(sig);
528 sshbuf_free(inner_sig);
529 return r;
530}
Damien Miller764d51e2019-11-01 13:34:49 +1100531#endif /* ENABLE_SK */