Hector Dearman | 534765e | 2017-11-01 11:17:38 +0000 | [diff] [blame] | 1 | # Copyright (C) 2017 The Android Open Source Project |
| 2 | # |
| 3 | # Licensed under the Apache License, Version 2.0 (the "License"); |
| 4 | # you may not use this file except in compliance with the License. |
| 5 | # You may obtain a copy of the License at |
| 6 | # |
| 7 | # http://www.apache.org/licenses/LICENSE-2.0 |
| 8 | # |
| 9 | # Unless required by applicable law or agreed to in writing, software |
| 10 | # distributed under the License is distributed on an "AS IS" BASIS, |
| 11 | # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 12 | # See the License for the specific language governing permissions and |
| 13 | # limitations under the License. |
| 14 | |
Sami Kyostila | b27619f | 2017-12-13 19:22:16 +0000 | [diff] [blame] | 15 | import subprocess |
| 16 | |
| 17 | |
Hector Dearman | 534765e | 2017-11-01 11:17:38 +0000 | [diff] [blame] | 18 | def CheckChange(input, output): |
Sami Kyostila | b27619f | 2017-12-13 19:22:16 +0000 | [diff] [blame] | 19 | # There apparently is no way to wrap strings in blueprints, so ignore long |
| 20 | # lines in them. |
| 21 | long_line_sources = lambda x: input.FilterSourceFile( |
| 22 | x, white_list=".*", black_list=['Android[.]bp']) |
Hector Dearman | 534765e | 2017-11-01 11:17:38 +0000 | [diff] [blame] | 23 | results = [] |
| 24 | results += input.canned_checks.CheckDoNotSubmit(input, output) |
| 25 | results += input.canned_checks.CheckChangeHasNoTabs(input, output) |
Sami Kyostila | b27619f | 2017-12-13 19:22:16 +0000 | [diff] [blame] | 26 | results += input.canned_checks.CheckLongLines( |
| 27 | input, output, 80, source_file_filter=long_line_sources) |
Hector Dearman | 534765e | 2017-11-01 11:17:38 +0000 | [diff] [blame] | 28 | results += input.canned_checks.CheckPatchFormatted(input, output) |
| 29 | results += input.canned_checks.CheckGNFormatted(input, output) |
Primiano Tucci | 40e9872 | 2018-02-16 11:50:17 +0000 | [diff] [blame] | 30 | results += CheckIncludeGuards(input, output) |
Sami Kyostila | b27619f | 2017-12-13 19:22:16 +0000 | [diff] [blame] | 31 | results += CheckAndroidBlueprint(input, output) |
Primiano Tucci | c501080 | 2018-01-19 17:13:21 +0000 | [diff] [blame] | 32 | results += CheckMergedTraceConfigProto(input, output) |
Hector Dearman | 534765e | 2017-11-01 11:17:38 +0000 | [diff] [blame] | 33 | return results |
| 34 | |
Sami Kyostila | b27619f | 2017-12-13 19:22:16 +0000 | [diff] [blame] | 35 | |
Hector Dearman | 534765e | 2017-11-01 11:17:38 +0000 | [diff] [blame] | 36 | def CheckChangeOnUpload(input_api, output_api): |
| 37 | return CheckChange(input_api, output_api) |
| 38 | |
Sami Kyostila | b27619f | 2017-12-13 19:22:16 +0000 | [diff] [blame] | 39 | |
Hector Dearman | 534765e | 2017-11-01 11:17:38 +0000 | [diff] [blame] | 40 | def CheckChangeOnCommit(input_api, output_api): |
| 41 | return CheckChange(input_api, output_api) |
| 42 | |
Sami Kyostila | b27619f | 2017-12-13 19:22:16 +0000 | [diff] [blame] | 43 | |
| 44 | def CheckAndroidBlueprint(input_api, output_api): |
| 45 | # If no GN files were modified, bail out. |
| 46 | build_file_filter = lambda x: input_api.FilterSourceFile( |
| 47 | x, |
| 48 | white_list=('.*BUILD[.]gn$', '.*[.]gni$', 'tools/gen_android_bp')) |
| 49 | if not input_api.AffectedSourceFiles(build_file_filter): |
| 50 | return [] |
| 51 | |
| 52 | with open('Android.bp') as f: |
| 53 | current_blueprint = f.read() |
Primiano Tucci | 40e9872 | 2018-02-16 11:50:17 +0000 | [diff] [blame] | 54 | |
Sami Kyostila | b27619f | 2017-12-13 19:22:16 +0000 | [diff] [blame] | 55 | new_blueprint = subprocess.check_output( |
| 56 | ['tools/gen_android_bp', '--output', '/dev/stdout']) |
| 57 | |
| 58 | if current_blueprint != new_blueprint: |
| 59 | return [ |
| 60 | output_api.PresubmitError( |
| 61 | 'Android.bp is out of date. Please run tools/gen_android_bp ' |
| 62 | 'to update it.') |
| 63 | ] |
| 64 | return [] |
Primiano Tucci | c501080 | 2018-01-19 17:13:21 +0000 | [diff] [blame] | 65 | |
| 66 | |
Primiano Tucci | 40e9872 | 2018-02-16 11:50:17 +0000 | [diff] [blame] | 67 | def CheckIncludeGuards(input_api, output_api): |
| 68 | tool = 'tools/fix_include_guards' |
| 69 | file_filter = lambda x: input_api.FilterSourceFile( |
| 70 | x, |
| 71 | white_list=('.*[.]cc$', '.*[.]h$', tool)) |
| 72 | if not input_api.AffectedSourceFiles(file_filter): |
| 73 | return [] |
| 74 | if subprocess.call([tool, '--check-only']): |
| 75 | return [ |
| 76 | output_api.PresubmitError( |
| 77 | 'Please run ' + tool + ' to fix include guards.') |
| 78 | ] |
| 79 | return [] |
| 80 | |
| 81 | |
Primiano Tucci | c501080 | 2018-01-19 17:13:21 +0000 | [diff] [blame] | 82 | def CheckMergedTraceConfigProto(input_api, output_api): |
| 83 | tool = 'tools/gen_merged_trace_config' |
| 84 | build_file_filter = lambda x: input_api.FilterSourceFile( |
| 85 | x, |
| 86 | white_list=('protos/perfetto/config/.*[.]proto$', tool)) |
| 87 | if not input_api.AffectedSourceFiles(build_file_filter): |
| 88 | return [] |
| 89 | if subprocess.call([tool, '--check-only']): |
| 90 | return [ |
| 91 | output_api.PresubmitError( |
Primiano Tucci | 08882a4 | 2018-01-19 22:09:01 +0000 | [diff] [blame] | 92 | 'perfetto_config.proto is out of date. Please run ' + |
Primiano Tucci | c501080 | 2018-01-19 17:13:21 +0000 | [diff] [blame] | 93 | tool + ' to update it.') |
| 94 | ] |
| 95 | return [] |