Wyatt Hepler | b760954 | 2020-01-24 10:29:54 -0800 | [diff] [blame] | 1 | // Copyright 2020 The Pigweed Authors |
| 2 | // |
| 3 | // Licensed under the Apache License, Version 2.0 (the "License"); you may not |
| 4 | // use this file except in compliance with the License. You may obtain a copy of |
| 5 | // the License at |
| 6 | // |
| 7 | // https://www.apache.org/licenses/LICENSE-2.0 |
| 8 | // |
| 9 | // Unless required by applicable law or agreed to in writing, software |
| 10 | // distributed under the License is distributed on an "AS IS" BASIS, WITHOUT |
| 11 | // WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the |
| 12 | // License for the specific language governing permissions and limitations under |
| 13 | // the License. |
| 14 | |
Wyatt Hepler | b760954 | 2020-01-24 10:29:54 -0800 | [diff] [blame] | 15 | #include "pw_kvs/key_value_store.h" |
| 16 | |
Wyatt Hepler | bab0e20 | 2020-02-04 07:40:08 -0800 | [diff] [blame] | 17 | #include <algorithm> |
Wyatt Hepler | 5a33d8c | 2020-02-06 09:32:58 -0800 | [diff] [blame] | 18 | #include <cinttypes> |
Wyatt Hepler | b760954 | 2020-01-24 10:29:54 -0800 | [diff] [blame] | 19 | #include <cstring> |
Wyatt Hepler | 4da1fcb | 2020-01-30 17:32:18 -0800 | [diff] [blame] | 20 | #include <type_traits> |
Wyatt Hepler | b760954 | 2020-01-24 10:29:54 -0800 | [diff] [blame] | 21 | |
Keir Mierle | 8c352dc | 2020-02-02 13:58:19 -0800 | [diff] [blame] | 22 | #define PW_LOG_USE_ULTRA_SHORT_NAMES 1 |
Wyatt Hepler | 4da1fcb | 2020-01-30 17:32:18 -0800 | [diff] [blame] | 23 | #include "pw_kvs_private/macros.h" |
Keir Mierle | 8c352dc | 2020-02-02 13:58:19 -0800 | [diff] [blame] | 24 | #include "pw_log/log.h" |
Wyatt Hepler | b760954 | 2020-01-24 10:29:54 -0800 | [diff] [blame] | 25 | |
Wyatt Hepler | 2ad6067 | 2020-01-21 08:00:16 -0800 | [diff] [blame] | 26 | namespace pw::kvs { |
Wyatt Hepler | a00d1ef | 2020-02-14 14:31:26 -0800 | [diff] [blame] | 27 | namespace { |
Wyatt Hepler | b760954 | 2020-01-24 10:29:54 -0800 | [diff] [blame] | 28 | |
Wyatt Hepler | acaacf9 | 2020-01-24 10:58:30 -0800 | [diff] [blame] | 29 | using std::byte; |
Wyatt Hepler | 4da1fcb | 2020-01-30 17:32:18 -0800 | [diff] [blame] | 30 | using std::string_view; |
Wyatt Hepler | acaacf9 | 2020-01-24 10:58:30 -0800 | [diff] [blame] | 31 | |
Wyatt Hepler | a00d1ef | 2020-02-14 14:31:26 -0800 | [diff] [blame] | 32 | constexpr bool InvalidKey(std::string_view key) { |
Wyatt Hepler | bdd8e5a | 2020-02-20 19:27:26 -0800 | [diff] [blame] | 33 | return key.empty() || (key.size() > internal::Entry::kMaxKeyLength); |
Wyatt Hepler | a00d1ef | 2020-02-14 14:31:26 -0800 | [diff] [blame] | 34 | } |
| 35 | |
Wyatt Hepler | ab3b249 | 2020-03-11 16:15:16 -0700 | [diff] [blame] | 36 | // Returns true if the container conatins the value. |
| 37 | // TODO: At some point move this to pw_containers, along with adding tests. |
| 38 | template <typename Container, typename T> |
| 39 | bool Contains(const Container& container, const T& value) { |
| 40 | return std::find(std::begin(container), std::end(container), value) != |
| 41 | std::end(container); |
| 42 | } |
| 43 | |
Wyatt Hepler | a00d1ef | 2020-02-14 14:31:26 -0800 | [diff] [blame] | 44 | } // namespace |
| 45 | |
Wyatt Hepler | ad0a793 | 2020-02-06 08:20:38 -0800 | [diff] [blame] | 46 | KeyValueStore::KeyValueStore(FlashPartition* partition, |
Wyatt Hepler | 22d0d9f | 2020-03-05 14:57:11 -0800 | [diff] [blame] | 47 | span<const EntryFormat> formats, |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 48 | const Options& options, |
| 49 | size_t redundancy, |
| 50 | Vector<SectorDescriptor>& sector_descriptor_list, |
| 51 | const SectorDescriptor** temp_sectors_to_skip, |
| 52 | Vector<KeyDescriptor>& key_descriptor_list, |
| 53 | Address* addresses) |
Wyatt Hepler | ad0a793 | 2020-02-06 08:20:38 -0800 | [diff] [blame] | 54 | : partition_(*partition), |
Wyatt Hepler | 22d0d9f | 2020-03-05 14:57:11 -0800 | [diff] [blame] | 55 | formats_(formats), |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 56 | entry_cache_(key_descriptor_list, addresses, redundancy), |
Wyatt Hepler | d229828 | 2020-02-20 17:12:45 -0800 | [diff] [blame] | 57 | sectors_(sector_descriptor_list), |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 58 | temp_sectors_to_skip_(temp_sectors_to_skip), |
Wyatt Hepler | d229828 | 2020-02-20 17:12:45 -0800 | [diff] [blame] | 59 | options_(options) { |
Keir Mierle | bf90481 | 2020-03-11 17:28:22 -0700 | [diff] [blame] | 60 | initialized_ = false; |
| 61 | last_new_sector_ = nullptr; |
| 62 | last_transaction_id_ = 0; |
Wyatt Hepler | d229828 | 2020-02-20 17:12:45 -0800 | [diff] [blame] | 63 | } |
Wyatt Hepler | ad0a793 | 2020-02-06 08:20:38 -0800 | [diff] [blame] | 64 | |
Wyatt Hepler | 4da1fcb | 2020-01-30 17:32:18 -0800 | [diff] [blame] | 65 | Status KeyValueStore::Init() { |
Keir Mierle | bf90481 | 2020-03-11 17:28:22 -0700 | [diff] [blame] | 66 | initialized_ = false; |
| 67 | last_new_sector_ = nullptr; |
| 68 | last_transaction_id_ = 0; |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 69 | entry_cache_.Reset(); |
Wyatt Hepler | d229828 | 2020-02-20 17:12:45 -0800 | [diff] [blame] | 70 | |
David Rogers | 2e9e0c8 | 2020-02-13 15:06:06 -0800 | [diff] [blame] | 71 | INF("Initializing key value store"); |
Wyatt Hepler | 38ce30f | 2020-02-19 11:48:31 -0800 | [diff] [blame] | 72 | if (partition_.sector_count() > sectors_.max_size()) { |
David Rogers | 2e9e0c8 | 2020-02-13 15:06:06 -0800 | [diff] [blame] | 73 | ERR("KVS init failed: kMaxUsableSectors (=%zu) must be at least as " |
| 74 | "large as the number of sectors in the flash partition (=%zu)", |
Wyatt Hepler | 38ce30f | 2020-02-19 11:48:31 -0800 | [diff] [blame] | 75 | sectors_.max_size(), |
David Rogers | 2e9e0c8 | 2020-02-13 15:06:06 -0800 | [diff] [blame] | 76 | partition_.sector_count()); |
Wyatt Hepler | ad0a793 | 2020-02-06 08:20:38 -0800 | [diff] [blame] | 77 | return Status::FAILED_PRECONDITION; |
| 78 | } |
| 79 | |
Keir Mierle | 8c352dc | 2020-02-02 13:58:19 -0800 | [diff] [blame] | 80 | const size_t sector_size_bytes = partition_.sector_size_bytes(); |
Keir Mierle | 8c352dc | 2020-02-02 13:58:19 -0800 | [diff] [blame] | 81 | |
| 82 | DBG("First pass: Read all entries from all sectors"); |
Wyatt Hepler | 2c7eca0 | 2020-02-18 16:01:42 -0800 | [diff] [blame] | 83 | Address sector_address = 0; |
Keir Mierle | 8c352dc | 2020-02-02 13:58:19 -0800 | [diff] [blame] | 84 | |
Wyatt Hepler | d229828 | 2020-02-20 17:12:45 -0800 | [diff] [blame] | 85 | sectors_.assign(partition_.sector_count(), |
| 86 | SectorDescriptor(sector_size_bytes)); |
| 87 | |
Alexei Frolov | d4adf91 | 2020-02-21 13:29:15 -0800 | [diff] [blame] | 88 | size_t total_corrupt_bytes = 0; |
| 89 | int corrupt_entries = 0; |
David Rogers | 9162748 | 2020-02-27 17:38:12 -0800 | [diff] [blame] | 90 | bool empty_sector_found = false; |
Alexei Frolov | d4adf91 | 2020-02-21 13:29:15 -0800 | [diff] [blame] | 91 | |
Wyatt Hepler | 2c7eca0 | 2020-02-18 16:01:42 -0800 | [diff] [blame] | 92 | for (SectorDescriptor& sector : sectors_) { |
Keir Mierle | 8c352dc | 2020-02-02 13:58:19 -0800 | [diff] [blame] | 93 | Address entry_address = sector_address; |
| 94 | |
Alexei Frolov | d4adf91 | 2020-02-21 13:29:15 -0800 | [diff] [blame] | 95 | size_t sector_corrupt_bytes = 0; |
| 96 | |
Wyatt Hepler | 2c7eca0 | 2020-02-18 16:01:42 -0800 | [diff] [blame] | 97 | for (int num_entries_in_sector = 0; true; num_entries_in_sector++) { |
| 98 | DBG("Load entry: sector=%" PRIx32 ", entry#=%d, address=%" PRIx32, |
| 99 | sector_address, |
Keir Mierle | 8c352dc | 2020-02-02 13:58:19 -0800 | [diff] [blame] | 100 | num_entries_in_sector, |
Wyatt Hepler | 2c7eca0 | 2020-02-18 16:01:42 -0800 | [diff] [blame] | 101 | entry_address); |
Keir Mierle | 8c352dc | 2020-02-02 13:58:19 -0800 | [diff] [blame] | 102 | |
Wyatt Hepler | 2c7eca0 | 2020-02-18 16:01:42 -0800 | [diff] [blame] | 103 | if (!AddressInSector(sector, entry_address)) { |
Keir Mierle | 8c352dc | 2020-02-02 13:58:19 -0800 | [diff] [blame] | 104 | DBG("Fell off end of sector; moving to the next sector"); |
| 105 | break; |
| 106 | } |
| 107 | |
| 108 | Address next_entry_address; |
| 109 | Status status = LoadEntry(entry_address, &next_entry_address); |
| 110 | if (status == Status::NOT_FOUND) { |
| 111 | DBG("Hit un-written data in sector; moving to the next sector"); |
| 112 | break; |
| 113 | } |
| 114 | if (status == Status::DATA_LOSS) { |
Alexei Frolov | d4adf91 | 2020-02-21 13:29:15 -0800 | [diff] [blame] | 115 | // The entry could not be read, indicating data corruption within the |
| 116 | // sector. Try to scan the remainder of the sector for other entries. |
David Rogers | a2562b5 | 2020-03-05 15:30:05 -0800 | [diff] [blame] | 117 | WRN("KVS init: data loss detected in sector %u at address %zu", |
Wyatt Hepler | 2c7eca0 | 2020-02-18 16:01:42 -0800 | [diff] [blame] | 118 | SectorIndex(§or), |
| 119 | size_t(entry_address)); |
Alexei Frolov | d4adf91 | 2020-02-21 13:29:15 -0800 | [diff] [blame] | 120 | |
| 121 | corrupt_entries++; |
| 122 | |
| 123 | status = ScanForEntry(sector, |
| 124 | entry_address + Entry::kMinAlignmentBytes, |
| 125 | &next_entry_address); |
| 126 | if (status == Status::NOT_FOUND) { |
| 127 | // No further entries in this sector. Mark the remaining bytes in the |
| 128 | // sector as corrupt (since we can't reliably know the size of the |
| 129 | // corrupt entry). |
| 130 | sector_corrupt_bytes += |
| 131 | sector_size_bytes - (entry_address - sector_address); |
| 132 | break; |
| 133 | } |
| 134 | |
| 135 | if (!status.ok()) { |
| 136 | ERR("Unexpected error in KVS initialization: %s", status.str()); |
| 137 | return Status::UNKNOWN; |
| 138 | } |
| 139 | |
| 140 | sector_corrupt_bytes += next_entry_address - entry_address; |
| 141 | } else if (!status.ok()) { |
| 142 | ERR("Unexpected error in KVS initialization: %s", status.str()); |
| 143 | return Status::UNKNOWN; |
Keir Mierle | 8c352dc | 2020-02-02 13:58:19 -0800 | [diff] [blame] | 144 | } |
Keir Mierle | 8c352dc | 2020-02-02 13:58:19 -0800 | [diff] [blame] | 145 | |
| 146 | // Entry loaded successfully; so get ready to load the next one. |
| 147 | entry_address = next_entry_address; |
| 148 | |
| 149 | // Update of the number of writable bytes in this sector. |
Wyatt Hepler | 2c7eca0 | 2020-02-18 16:01:42 -0800 | [diff] [blame] | 150 | sector.set_writable_bytes(sector_size_bytes - |
| 151 | (entry_address - sector_address)); |
Keir Mierle | 8c352dc | 2020-02-02 13:58:19 -0800 | [diff] [blame] | 152 | } |
Wyatt Hepler | 2c7eca0 | 2020-02-18 16:01:42 -0800 | [diff] [blame] | 153 | |
Alexei Frolov | d4adf91 | 2020-02-21 13:29:15 -0800 | [diff] [blame] | 154 | if (sector_corrupt_bytes > 0) { |
| 155 | // If the sector contains corrupt data, prevent any further entries from |
| 156 | // being written to it by indicating that it has no space. This should |
| 157 | // also make it a decent GC candidate. Valid keys in the sector are still |
| 158 | // readable as normal. |
| 159 | sector.set_writable_bytes(0); |
| 160 | |
| 161 | WRN("Sector %u contains %zuB of corrupt data", |
| 162 | SectorIndex(§or), |
| 163 | sector_corrupt_bytes); |
| 164 | } |
| 165 | |
David Rogers | 9162748 | 2020-02-27 17:38:12 -0800 | [diff] [blame] | 166 | if (sector.Empty(sector_size_bytes)) { |
| 167 | empty_sector_found = true; |
| 168 | } |
Wyatt Hepler | 2c7eca0 | 2020-02-18 16:01:42 -0800 | [diff] [blame] | 169 | sector_address += sector_size_bytes; |
Alexei Frolov | d4adf91 | 2020-02-21 13:29:15 -0800 | [diff] [blame] | 170 | total_corrupt_bytes += sector_corrupt_bytes; |
Keir Mierle | 8c352dc | 2020-02-02 13:58:19 -0800 | [diff] [blame] | 171 | } |
| 172 | |
| 173 | DBG("Second pass: Count valid bytes in each sector"); |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 174 | Address newest_key = 0; |
Wyatt Hepler | 1fc1104 | 2020-02-19 17:17:51 -0800 | [diff] [blame] | 175 | |
Wyatt Hepler | 0294627 | 2020-03-18 10:36:22 -0700 | [diff] [blame^] | 176 | // For every valid entry, count the valid bytes in that sector. Track which |
| 177 | // entry has the newest transaction ID for initializing last_new_sector_. |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 178 | for (const EntryMetadata& metadata : entry_cache_) { |
| 179 | for (Address address : metadata.addresses()) { |
David Rogers | f56131c | 2020-03-04 10:19:22 -0800 | [diff] [blame] | 180 | Entry entry; |
David Rogers | a2562b5 | 2020-03-05 15:30:05 -0800 | [diff] [blame] | 181 | TRY(Entry::Read(partition_, address, formats_, &entry)); |
David Rogers | f56131c | 2020-03-04 10:19:22 -0800 | [diff] [blame] | 182 | SectorFromAddress(address)->AddValidBytes(entry.size()); |
| 183 | } |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 184 | if (metadata.IsNewerThan(last_transaction_id_)) { |
| 185 | last_transaction_id_ = metadata.transaction_id(); |
| 186 | newest_key = metadata.addresses().back(); |
Wyatt Hepler | 1fc1104 | 2020-02-19 17:17:51 -0800 | [diff] [blame] | 187 | } |
Keir Mierle | 8c352dc | 2020-02-02 13:58:19 -0800 | [diff] [blame] | 188 | } |
Wyatt Hepler | 1fc1104 | 2020-02-19 17:17:51 -0800 | [diff] [blame] | 189 | |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 190 | last_new_sector_ = SectorFromAddress(newest_key); |
Wyatt Hepler | 1fc1104 | 2020-02-19 17:17:51 -0800 | [diff] [blame] | 191 | |
David Rogers | 9162748 | 2020-02-27 17:38:12 -0800 | [diff] [blame] | 192 | if (!empty_sector_found) { |
| 193 | // TODO: Record/report the error condition and recovery result. |
| 194 | Status gc_result = GarbageCollectPartial(); |
| 195 | |
| 196 | if (!gc_result.ok()) { |
| 197 | ERR("KVS init failed: Unable to maintain required free sector"); |
| 198 | return Status::INTERNAL; |
| 199 | } |
| 200 | } |
| 201 | |
Wyatt Hepler | 729f28c | 2020-02-05 09:46:00 -0800 | [diff] [blame] | 202 | initialized_ = true; |
David Rogers | 2e9e0c8 | 2020-02-13 15:06:06 -0800 | [diff] [blame] | 203 | |
Armando Montanez | 5464d5f | 2020-02-20 10:12:20 -0800 | [diff] [blame] | 204 | INF("KeyValueStore init complete: active keys %zu, deleted keys %zu, sectors " |
David Rogers | 2e9e0c8 | 2020-02-13 15:06:06 -0800 | [diff] [blame] | 205 | "%zu, logical sector size %zu bytes", |
| 206 | size(), |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 207 | (entry_cache_.total_entries() - size()), |
David Rogers | 2e9e0c8 | 2020-02-13 15:06:06 -0800 | [diff] [blame] | 208 | sectors_.size(), |
| 209 | partition_.sector_size_bytes()); |
| 210 | |
Alexei Frolov | d4adf91 | 2020-02-21 13:29:15 -0800 | [diff] [blame] | 211 | if (total_corrupt_bytes > 0) { |
| 212 | WRN("Found %zu corrupt bytes and %d corrupt entries during init process; " |
| 213 | "some keys may be missing", |
| 214 | total_corrupt_bytes, |
| 215 | corrupt_entries); |
| 216 | return Status::DATA_LOSS; |
| 217 | } |
| 218 | |
Keir Mierle | 8c352dc | 2020-02-02 13:58:19 -0800 | [diff] [blame] | 219 | return Status::OK; |
| 220 | } |
| 221 | |
Alexei Frolov | 9e23583 | 2020-02-24 12:44:45 -0800 | [diff] [blame] | 222 | KeyValueStore::StorageStats KeyValueStore::GetStorageStats() const { |
| 223 | StorageStats stats{0, 0, 0}; |
| 224 | const size_t sector_size = partition_.sector_size_bytes(); |
| 225 | bool found_empty_sector = false; |
| 226 | |
| 227 | for (const SectorDescriptor& sector : sectors_) { |
| 228 | stats.in_use_bytes += sector.valid_bytes(); |
| 229 | stats.reclaimable_bytes += sector.RecoverableBytes(sector_size); |
| 230 | |
| 231 | if (!found_empty_sector && sector.Empty(sector_size)) { |
| 232 | // The KVS tries to always keep an empty sector for GC, so don't count |
| 233 | // the first empty sector seen as writable space. However, a free sector |
| 234 | // cannot always be assumed to exist; if a GC operation fails, all sectors |
| 235 | // may be partially written, in which case the space reported might be |
| 236 | // inaccurate. |
| 237 | found_empty_sector = true; |
| 238 | continue; |
| 239 | } |
| 240 | |
| 241 | stats.writable_bytes += sector.writable_bytes(); |
| 242 | } |
| 243 | |
| 244 | return stats; |
| 245 | } |
| 246 | |
Keir Mierle | 8c352dc | 2020-02-02 13:58:19 -0800 | [diff] [blame] | 247 | Status KeyValueStore::LoadEntry(Address entry_address, |
| 248 | Address* next_entry_address) { |
Wyatt Hepler | e541e07 | 2020-02-14 09:10:53 -0800 | [diff] [blame] | 249 | Entry entry; |
Wyatt Hepler | 22d0d9f | 2020-03-05 14:57:11 -0800 | [diff] [blame] | 250 | TRY(Entry::Read(partition_, entry_address, formats_, &entry)); |
Keir Mierle | 8c352dc | 2020-02-02 13:58:19 -0800 | [diff] [blame] | 251 | |
| 252 | // Read the key from flash & validate the entry (which reads the value). |
Wyatt Hepler | a00d1ef | 2020-02-14 14:31:26 -0800 | [diff] [blame] | 253 | Entry::KeyBuffer key_buffer; |
Wyatt Hepler | e541e07 | 2020-02-14 09:10:53 -0800 | [diff] [blame] | 254 | TRY_ASSIGN(size_t key_length, entry.ReadKey(key_buffer)); |
| 255 | const string_view key(key_buffer.data(), key_length); |
Wyatt Hepler | bab0e20 | 2020-02-04 07:40:08 -0800 | [diff] [blame] | 256 | |
Wyatt Hepler | 22d0d9f | 2020-03-05 14:57:11 -0800 | [diff] [blame] | 257 | TRY(entry.VerifyChecksumInFlash()); |
David Rogers | f56131c | 2020-03-04 10:19:22 -0800 | [diff] [blame] | 258 | |
| 259 | // A valid entry was found, so update the next entry address before doing any |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 260 | // of the checks that happen in AddNewOrUpdateExisting. |
David Rogers | f56131c | 2020-03-04 10:19:22 -0800 | [diff] [blame] | 261 | *next_entry_address = entry.next_address(); |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 262 | return entry_cache_.AddNewOrUpdateExisting( |
| 263 | entry.descriptor(key), entry.address(), partition_.sector_size_bytes()); |
Keir Mierle | 8c352dc | 2020-02-02 13:58:19 -0800 | [diff] [blame] | 264 | } |
| 265 | |
Alexei Frolov | d4adf91 | 2020-02-21 13:29:15 -0800 | [diff] [blame] | 266 | // Scans flash memory within a sector to find a KVS entry magic. |
Alexei Frolov | d4adf91 | 2020-02-21 13:29:15 -0800 | [diff] [blame] | 267 | Status KeyValueStore::ScanForEntry(const SectorDescriptor& sector, |
| 268 | Address start_address, |
| 269 | Address* next_entry_address) { |
| 270 | DBG("Scanning sector %u for entries starting from address %zx", |
| 271 | SectorIndex(§or), |
| 272 | size_t(start_address)); |
| 273 | |
| 274 | // Entries must start at addresses which are aligned on a multiple of |
| 275 | // Entry::kMinAlignmentBytes. However, that multiple can vary between entries. |
| 276 | // When scanning, we don't have an entry to tell us what the current alignment |
| 277 | // is, so the minimum alignment is used to be exhaustive. |
| 278 | for (Address address = AlignUp(start_address, Entry::kMinAlignmentBytes); |
| 279 | AddressInSector(sector, address); |
| 280 | address += Entry::kMinAlignmentBytes) { |
Alexei Frolov | d4adf91 | 2020-02-21 13:29:15 -0800 | [diff] [blame] | 281 | uint32_t magic; |
| 282 | TRY(partition_.Read(address, as_writable_bytes(span(&magic, 1)))); |
Wyatt Hepler | 22d0d9f | 2020-03-05 14:57:11 -0800 | [diff] [blame] | 283 | if (formats_.KnownMagic(magic)) { |
Alexei Frolov | d4adf91 | 2020-02-21 13:29:15 -0800 | [diff] [blame] | 284 | DBG("Found entry magic at address %zx", size_t(address)); |
| 285 | *next_entry_address = address; |
| 286 | return Status::OK; |
| 287 | } |
| 288 | } |
| 289 | |
| 290 | return Status::NOT_FOUND; |
| 291 | } |
| 292 | |
Wyatt Hepler | 4da1fcb | 2020-01-30 17:32:18 -0800 | [diff] [blame] | 293 | StatusWithSize KeyValueStore::Get(string_view key, |
Wyatt Hepler | 5f6efc0 | 2020-02-18 16:54:31 -0800 | [diff] [blame] | 294 | span<byte> value_buffer, |
| 295 | size_t offset_bytes) const { |
Wyatt Hepler | 50f7077 | 2020-02-13 11:25:10 -0800 | [diff] [blame] | 296 | TRY_WITH_SIZE(CheckOperation(key)); |
Wyatt Hepler | 4da1fcb | 2020-01-30 17:32:18 -0800 | [diff] [blame] | 297 | |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 298 | EntryMetadata metadata; |
| 299 | TRY_WITH_SIZE(entry_cache_.FindExisting(partition_, key, &metadata)); |
Wyatt Hepler | 6c24c06 | 2020-02-05 15:30:49 -0800 | [diff] [blame] | 300 | |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 301 | return Get(key, metadata, value_buffer, offset_bytes); |
Wyatt Hepler | 4da1fcb | 2020-01-30 17:32:18 -0800 | [diff] [blame] | 302 | } |
| 303 | |
Wyatt Hepler | fac8113 | 2020-02-27 17:26:33 -0800 | [diff] [blame] | 304 | Status KeyValueStore::PutBytes(string_view key, span<const byte> value) { |
Keir Mierle | 8c352dc | 2020-02-02 13:58:19 -0800 | [diff] [blame] | 305 | DBG("Writing key/value; key length=%zu, value length=%zu", |
| 306 | key.size(), |
| 307 | value.size()); |
Wyatt Hepler | 729f28c | 2020-02-05 09:46:00 -0800 | [diff] [blame] | 308 | |
| 309 | TRY(CheckOperation(key)); |
Wyatt Hepler | 4da1fcb | 2020-01-30 17:32:18 -0800 | [diff] [blame] | 310 | |
Wyatt Hepler | 5406a67 | 2020-02-18 15:42:38 -0800 | [diff] [blame] | 311 | if (Entry::size(partition_, key, value) > partition_.sector_size_bytes()) { |
| 312 | DBG("%zu B value with %zu B key cannot fit in one sector", |
| 313 | value.size(), |
| 314 | key.size()); |
| 315 | return Status::INVALID_ARGUMENT; |
Wyatt Hepler | 4da1fcb | 2020-01-30 17:32:18 -0800 | [diff] [blame] | 316 | } |
| 317 | |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 318 | EntryMetadata metadata; |
| 319 | Status status = entry_cache_.Find(partition_, key, &metadata); |
Wyatt Hepler | 2d40169 | 2020-02-13 16:01:23 -0800 | [diff] [blame] | 320 | |
| 321 | if (status.ok()) { |
David Rogers | f56131c | 2020-03-04 10:19:22 -0800 | [diff] [blame] | 322 | // TODO: figure out logging how to support multiple addresses. |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 323 | DBG("Overwriting entry for key 0x%08" PRIx32 " in %zu sectors including %u", |
| 324 | metadata.hash(), |
| 325 | metadata.addresses().size(), |
| 326 | SectorIndex(SectorFromAddress(metadata.first_address()))); |
| 327 | return WriteEntryForExistingKey(metadata, EntryState::kValid, key, value); |
Wyatt Hepler | 4da1fcb | 2020-01-30 17:32:18 -0800 | [diff] [blame] | 328 | } |
David Rogers | 2761aeb | 2020-01-31 17:09:00 -0800 | [diff] [blame] | 329 | |
Wyatt Hepler | 2d40169 | 2020-02-13 16:01:23 -0800 | [diff] [blame] | 330 | if (status == Status::NOT_FOUND) { |
| 331 | return WriteEntryForNewKey(key, value); |
| 332 | } |
| 333 | |
| 334 | return status; |
Wyatt Hepler | 4da1fcb | 2020-01-30 17:32:18 -0800 | [diff] [blame] | 335 | } |
| 336 | |
| 337 | Status KeyValueStore::Delete(string_view key) { |
Wyatt Hepler | 729f28c | 2020-02-05 09:46:00 -0800 | [diff] [blame] | 338 | TRY(CheckOperation(key)); |
| 339 | |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 340 | EntryMetadata metadata; |
| 341 | TRY(entry_cache_.FindExisting(partition_, key, &metadata)); |
Wyatt Hepler | 4da1fcb | 2020-01-30 17:32:18 -0800 | [diff] [blame] | 342 | |
David Rogers | f56131c | 2020-03-04 10:19:22 -0800 | [diff] [blame] | 343 | // TODO: figure out logging how to support multiple addresses. |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 344 | DBG("Writing tombstone for key 0x%08" PRIx32 " in %zu sectors including %u", |
| 345 | metadata.hash(), |
| 346 | metadata.addresses().size(), |
| 347 | SectorIndex(SectorFromAddress(metadata.first_address()))); |
| 348 | return WriteEntryForExistingKey(metadata, EntryState::kDeleted, key, {}); |
Wyatt Hepler | 6c24c06 | 2020-02-05 15:30:49 -0800 | [diff] [blame] | 349 | } |
| 350 | |
Wyatt Hepler | 08d37d8 | 2020-02-27 15:45:37 -0800 | [diff] [blame] | 351 | void KeyValueStore::Item::ReadKey() { |
| 352 | key_buffer_.fill('\0'); |
| 353 | |
| 354 | Entry entry; |
David Rogers | f3884eb | 2020-03-08 19:21:40 -0700 | [diff] [blame] | 355 | // TODO: add support for using one of the redundant entries if reading the |
| 356 | // first copy fails. |
Wyatt Hepler | 22d0d9f | 2020-03-05 14:57:11 -0800 | [diff] [blame] | 357 | if (Entry::Read( |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 358 | kvs_.partition_, iterator_->first_address(), kvs_.formats_, &entry) |
Wyatt Hepler | 22d0d9f | 2020-03-05 14:57:11 -0800 | [diff] [blame] | 359 | .ok()) { |
Wyatt Hepler | 08d37d8 | 2020-02-27 15:45:37 -0800 | [diff] [blame] | 360 | entry.ReadKey(key_buffer_); |
| 361 | } |
| 362 | } |
| 363 | |
Wyatt Hepler | 6c24c06 | 2020-02-05 15:30:49 -0800 | [diff] [blame] | 364 | KeyValueStore::iterator& KeyValueStore::iterator::operator++() { |
| 365 | // Skip to the next entry that is valid (not deleted). |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 366 | while (++item_.iterator_ != item_.kvs_.entry_cache_.end() && |
Wyatt Hepler | 0294627 | 2020-03-18 10:36:22 -0700 | [diff] [blame^] | 367 | item_.iterator_->state() != EntryState::kValid) { |
Wyatt Hepler | 6c24c06 | 2020-02-05 15:30:49 -0800 | [diff] [blame] | 368 | } |
| 369 | return *this; |
| 370 | } |
| 371 | |
Wyatt Hepler | 6c24c06 | 2020-02-05 15:30:49 -0800 | [diff] [blame] | 372 | KeyValueStore::iterator KeyValueStore::begin() const { |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 373 | internal::EntryCache::iterator cache_iterator = entry_cache_.begin(); |
Wyatt Hepler | 6c24c06 | 2020-02-05 15:30:49 -0800 | [diff] [blame] | 374 | // Skip over any deleted entries at the start of the descriptor list. |
Wyatt Hepler | 0294627 | 2020-03-18 10:36:22 -0700 | [diff] [blame^] | 375 | while (cache_iterator != entry_cache_.end() && |
| 376 | cache_iterator->state() != EntryState::kValid) { |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 377 | ++cache_iterator; |
Wyatt Hepler | 6c24c06 | 2020-02-05 15:30:49 -0800 | [diff] [blame] | 378 | } |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 379 | return iterator(*this, cache_iterator); |
Wyatt Hepler | 4da1fcb | 2020-01-30 17:32:18 -0800 | [diff] [blame] | 380 | } |
| 381 | |
Wyatt Hepler | ab3b249 | 2020-03-11 16:15:16 -0700 | [diff] [blame] | 382 | StatusWithSize KeyValueStore::ValueSize(string_view key) const { |
Wyatt Hepler | 50f7077 | 2020-02-13 11:25:10 -0800 | [diff] [blame] | 383 | TRY_WITH_SIZE(CheckOperation(key)); |
Wyatt Hepler | ed163b0 | 2020-02-03 17:49:32 -0800 | [diff] [blame] | 384 | |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 385 | EntryMetadata metadata; |
| 386 | TRY_WITH_SIZE(entry_cache_.FindExisting(partition_, key, &metadata)); |
Wyatt Hepler | 6c24c06 | 2020-02-05 15:30:49 -0800 | [diff] [blame] | 387 | |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 388 | return ValueSize(metadata); |
Wyatt Hepler | fac8113 | 2020-02-27 17:26:33 -0800 | [diff] [blame] | 389 | } |
Wyatt Hepler | ed163b0 | 2020-02-03 17:49:32 -0800 | [diff] [blame] | 390 | |
Wyatt Hepler | fac8113 | 2020-02-27 17:26:33 -0800 | [diff] [blame] | 391 | StatusWithSize KeyValueStore::Get(string_view key, |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 392 | const EntryMetadata& metadata, |
Wyatt Hepler | fac8113 | 2020-02-27 17:26:33 -0800 | [diff] [blame] | 393 | span<std::byte> value_buffer, |
| 394 | size_t offset_bytes) const { |
| 395 | Entry entry; |
David Rogers | a2562b5 | 2020-03-05 15:30:05 -0800 | [diff] [blame] | 396 | // TODO: add support for using one of the redundant entries if reading the |
| 397 | // first copy fails. |
Wyatt Hepler | 22d0d9f | 2020-03-05 14:57:11 -0800 | [diff] [blame] | 398 | TRY_WITH_SIZE( |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 399 | Entry::Read(partition_, metadata.first_address(), formats_, &entry)); |
Wyatt Hepler | fac8113 | 2020-02-27 17:26:33 -0800 | [diff] [blame] | 400 | |
| 401 | StatusWithSize result = entry.ReadValue(value_buffer, offset_bytes); |
| 402 | if (result.ok() && options_.verify_on_read && offset_bytes == 0u) { |
Wyatt Hepler | 22d0d9f | 2020-03-05 14:57:11 -0800 | [diff] [blame] | 403 | Status verify_result = |
| 404 | entry.VerifyChecksum(key, value_buffer.first(result.size())); |
Wyatt Hepler | fac8113 | 2020-02-27 17:26:33 -0800 | [diff] [blame] | 405 | if (!verify_result.ok()) { |
| 406 | std::memset(value_buffer.data(), 0, result.size()); |
| 407 | return StatusWithSize(verify_result, 0); |
| 408 | } |
| 409 | |
| 410 | return StatusWithSize(verify_result, result.size()); |
| 411 | } |
| 412 | return result; |
Wyatt Hepler | ed163b0 | 2020-02-03 17:49:32 -0800 | [diff] [blame] | 413 | } |
| 414 | |
Wyatt Hepler | 6e3a83b | 2020-02-04 07:36:45 -0800 | [diff] [blame] | 415 | Status KeyValueStore::FixedSizeGet(std::string_view key, |
Wyatt Hepler | fac8113 | 2020-02-27 17:26:33 -0800 | [diff] [blame] | 416 | void* value, |
| 417 | size_t size_bytes) const { |
| 418 | TRY(CheckOperation(key)); |
| 419 | |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 420 | EntryMetadata metadata; |
| 421 | TRY(entry_cache_.FindExisting(partition_, key, &metadata)); |
Wyatt Hepler | fac8113 | 2020-02-27 17:26:33 -0800 | [diff] [blame] | 422 | |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 423 | return FixedSizeGet(key, metadata, value, size_bytes); |
Wyatt Hepler | fac8113 | 2020-02-27 17:26:33 -0800 | [diff] [blame] | 424 | } |
| 425 | |
| 426 | Status KeyValueStore::FixedSizeGet(std::string_view key, |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 427 | const EntryMetadata& metadata, |
Wyatt Hepler | fac8113 | 2020-02-27 17:26:33 -0800 | [diff] [blame] | 428 | void* value, |
Wyatt Hepler | 6e3a83b | 2020-02-04 07:36:45 -0800 | [diff] [blame] | 429 | size_t size_bytes) const { |
| 430 | // Ensure that the size of the stored value matches the size of the type. |
| 431 | // Otherwise, report error. This check avoids potential memory corruption. |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 432 | TRY_ASSIGN(const size_t actual_size, ValueSize(metadata)); |
Wyatt Hepler | fac8113 | 2020-02-27 17:26:33 -0800 | [diff] [blame] | 433 | |
| 434 | if (actual_size != size_bytes) { |
| 435 | DBG("Requested %zu B read, but value is %zu B", size_bytes, actual_size); |
Wyatt Hepler | 6e3a83b | 2020-02-04 07:36:45 -0800 | [diff] [blame] | 436 | return Status::INVALID_ARGUMENT; |
Wyatt Hepler | bab0e20 | 2020-02-04 07:40:08 -0800 | [diff] [blame] | 437 | } |
Wyatt Hepler | fac8113 | 2020-02-27 17:26:33 -0800 | [diff] [blame] | 438 | |
| 439 | StatusWithSize result = |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 440 | Get(key, metadata, span(static_cast<byte*>(value), size_bytes), 0); |
Wyatt Hepler | fac8113 | 2020-02-27 17:26:33 -0800 | [diff] [blame] | 441 | |
| 442 | return result.status(); |
| 443 | } |
| 444 | |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 445 | StatusWithSize KeyValueStore::ValueSize(const EntryMetadata& metadata) const { |
Wyatt Hepler | fac8113 | 2020-02-27 17:26:33 -0800 | [diff] [blame] | 446 | Entry entry; |
David Rogers | f3884eb | 2020-03-08 19:21:40 -0700 | [diff] [blame] | 447 | // TODO: add support for using one of the redundant entries if reading the |
| 448 | // first copy fails. |
Wyatt Hepler | 22d0d9f | 2020-03-05 14:57:11 -0800 | [diff] [blame] | 449 | TRY_WITH_SIZE( |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 450 | Entry::Read(partition_, metadata.first_address(), formats_, &entry)); |
Wyatt Hepler | fac8113 | 2020-02-27 17:26:33 -0800 | [diff] [blame] | 451 | |
| 452 | return StatusWithSize(entry.value_size()); |
Keir Mierle | 8c352dc | 2020-02-02 13:58:19 -0800 | [diff] [blame] | 453 | } |
| 454 | |
Wyatt Hepler | 729f28c | 2020-02-05 09:46:00 -0800 | [diff] [blame] | 455 | Status KeyValueStore::CheckOperation(string_view key) const { |
Wyatt Hepler | acaacf9 | 2020-01-24 10:58:30 -0800 | [diff] [blame] | 456 | if (InvalidKey(key)) { |
Wyatt Hepler | b760954 | 2020-01-24 10:29:54 -0800 | [diff] [blame] | 457 | return Status::INVALID_ARGUMENT; |
| 458 | } |
Wyatt Hepler | d229828 | 2020-02-20 17:12:45 -0800 | [diff] [blame] | 459 | if (!initialized()) { |
Wyatt Hepler | b760954 | 2020-01-24 10:29:54 -0800 | [diff] [blame] | 460 | return Status::FAILED_PRECONDITION; |
| 461 | } |
Wyatt Hepler | b760954 | 2020-01-24 10:29:54 -0800 | [diff] [blame] | 462 | return Status::OK; |
| 463 | } |
| 464 | |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 465 | Status KeyValueStore::WriteEntryForExistingKey(EntryMetadata& metadata, |
| 466 | EntryState new_state, |
Wyatt Hepler | 4da1fcb | 2020-01-30 17:32:18 -0800 | [diff] [blame] | 467 | string_view key, |
| 468 | span<const byte> value) { |
Wyatt Hepler | ab3b249 | 2020-03-11 16:15:16 -0700 | [diff] [blame] | 469 | // Read the original entry to get the size for sector accounting purposes. |
| 470 | Entry entry; |
David Rogers | a2562b5 | 2020-03-05 15:30:05 -0800 | [diff] [blame] | 471 | // TODO: add support for using one of the redundant entries if reading the |
| 472 | // first copy fails. |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 473 | TRY(Entry::Read(partition_, metadata.first_address(), formats_, &entry)); |
Wyatt Hepler | 6c24c06 | 2020-02-05 15:30:49 -0800 | [diff] [blame] | 474 | |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 475 | return WriteEntry(key, value, new_state, &metadata, entry.size()); |
Wyatt Hepler | 4da1fcb | 2020-01-30 17:32:18 -0800 | [diff] [blame] | 476 | } |
| 477 | |
| 478 | Status KeyValueStore::WriteEntryForNewKey(string_view key, |
| 479 | span<const byte> value) { |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 480 | if (entry_cache_.full()) { |
Keir Mierle | 8c352dc | 2020-02-02 13:58:19 -0800 | [diff] [blame] | 481 | WRN("KVS full: trying to store a new entry, but can't. Have %zu entries", |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 482 | entry_cache_.total_entries()); |
Wyatt Hepler | 4da1fcb | 2020-01-30 17:32:18 -0800 | [diff] [blame] | 483 | return Status::RESOURCE_EXHAUSTED; |
| 484 | } |
| 485 | |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 486 | return WriteEntry(key, value, EntryState::kValid); |
Wyatt Hepler | ab3b249 | 2020-03-11 16:15:16 -0700 | [diff] [blame] | 487 | } |
Wyatt Hepler | 4da1fcb | 2020-01-30 17:32:18 -0800 | [diff] [blame] | 488 | |
Wyatt Hepler | ab3b249 | 2020-03-11 16:15:16 -0700 | [diff] [blame] | 489 | Status KeyValueStore::WriteEntry(string_view key, |
| 490 | span<const byte> value, |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 491 | EntryState new_state, |
| 492 | EntryMetadata* prior_metadata, |
Wyatt Hepler | ab3b249 | 2020-03-11 16:15:16 -0700 | [diff] [blame] | 493 | size_t prior_size) { |
| 494 | const size_t entry_size = Entry::size(partition_, key, value); |
| 495 | |
| 496 | // List of addresses for sectors with space for this entry. |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 497 | Address* reserved_addresses = entry_cache_.TempReservedAddressesForWrite(); |
Wyatt Hepler | ab3b249 | 2020-03-11 16:15:16 -0700 | [diff] [blame] | 498 | |
| 499 | // Find sectors to write the entry to. This may involve garbage collecting one |
| 500 | // or more sectors. |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 501 | for (size_t i = 0; i < redundancy(); i++) { |
Wyatt Hepler | ab3b249 | 2020-03-11 16:15:16 -0700 | [diff] [blame] | 502 | SectorDescriptor* sector; |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 503 | TRY(GetSectorForWrite(§or, entry_size, span(reserved_addresses, i))); |
Wyatt Hepler | ab3b249 | 2020-03-11 16:15:16 -0700 | [diff] [blame] | 504 | |
| 505 | DBG("Found space for entry in sector %u", SectorIndex(sector)); |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 506 | reserved_addresses[i] = NextWritableAddress(sector); |
Wyatt Hepler | ab3b249 | 2020-03-11 16:15:16 -0700 | [diff] [blame] | 507 | } |
| 508 | |
| 509 | // Write the entry at the first address that was found. |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 510 | Entry entry = CreateEntry(reserved_addresses[0], key, value, new_state); |
Wyatt Hepler | ab3b249 | 2020-03-11 16:15:16 -0700 | [diff] [blame] | 511 | TRY(AppendEntry(entry, key, value)); |
| 512 | |
| 513 | // After writing the first entry successfully, update the key descriptors. |
| 514 | // Once a single new the entry is written, the old entries are invalidated. |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 515 | EntryMetadata new_metadata = |
| 516 | UpdateKeyDescriptor(entry, key, prior_metadata, prior_size); |
Wyatt Hepler | ab3b249 | 2020-03-11 16:15:16 -0700 | [diff] [blame] | 517 | |
| 518 | // Write the additional copies of the entry, if redundancy is greater than 1. |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 519 | for (size_t i = 1; i < redundancy(); ++i) { |
| 520 | entry.set_address(reserved_addresses[i]); |
Wyatt Hepler | ab3b249 | 2020-03-11 16:15:16 -0700 | [diff] [blame] | 521 | TRY(AppendEntry(entry, key, value)); |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 522 | new_metadata.AddNewAddress(reserved_addresses[i]); |
Wyatt Hepler | ab3b249 | 2020-03-11 16:15:16 -0700 | [diff] [blame] | 523 | } |
Wyatt Hepler | b760954 | 2020-01-24 10:29:54 -0800 | [diff] [blame] | 524 | return Status::OK; |
| 525 | } |
| 526 | |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 527 | KeyValueStore::EntryMetadata KeyValueStore::UpdateKeyDescriptor( |
Wyatt Hepler | ab3b249 | 2020-03-11 16:15:16 -0700 | [diff] [blame] | 528 | const Entry& entry, |
| 529 | string_view key, |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 530 | EntryMetadata* prior_metadata, |
Wyatt Hepler | ab3b249 | 2020-03-11 16:15:16 -0700 | [diff] [blame] | 531 | size_t prior_size) { |
| 532 | // If there is no prior descriptor, create a new one. |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 533 | if (prior_metadata == nullptr) { |
| 534 | return entry_cache_.AddNew(entry.descriptor(key), entry.address()); |
David Rogers | a2562b5 | 2020-03-05 15:30:05 -0800 | [diff] [blame] | 535 | } |
| 536 | |
Wyatt Hepler | ab3b249 | 2020-03-11 16:15:16 -0700 | [diff] [blame] | 537 | // Remove valid bytes for the old entry and its copies, which are now stale. |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 538 | for (Address address : prior_metadata->addresses()) { |
Wyatt Hepler | ab3b249 | 2020-03-11 16:15:16 -0700 | [diff] [blame] | 539 | SectorFromAddress(address)->RemoveValidBytes(prior_size); |
David Rogers | a2562b5 | 2020-03-05 15:30:05 -0800 | [diff] [blame] | 540 | } |
| 541 | |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 542 | prior_metadata->Reset(entry.descriptor(key), entry.address()); |
| 543 | return *prior_metadata; |
David Rogers | a2562b5 | 2020-03-05 15:30:05 -0800 | [diff] [blame] | 544 | } |
| 545 | |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 546 | // Finds a sector to use for writing a new entry to. Does automatic garbage |
David Rogers | a2562b5 | 2020-03-05 15:30:05 -0800 | [diff] [blame] | 547 | // collection if needed and allowed. |
| 548 | // |
| 549 | // OK: Sector found with needed space. |
| 550 | // RESOURCE_EXHAUSTED: No sector available with the needed space. |
| 551 | Status KeyValueStore::GetSectorForWrite(SectorDescriptor** sector, |
| 552 | size_t entry_size, |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 553 | span<const Address> reserved) { |
David Rogers | c9d545e | 2020-03-11 17:47:43 -0700 | [diff] [blame] | 554 | Status result = |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 555 | FindSectorWithSpace(sector, entry_size, kAppendEntry, {}, reserved); |
David Rogers | a2562b5 | 2020-03-05 15:30:05 -0800 | [diff] [blame] | 556 | |
David Rogers | f3884eb | 2020-03-08 19:21:40 -0700 | [diff] [blame] | 557 | size_t gc_sector_count = 0; |
David Rogers | a2562b5 | 2020-03-05 15:30:05 -0800 | [diff] [blame] | 558 | bool do_auto_gc = options_.gc_on_write != GargbageCollectOnWrite::kDisabled; |
| 559 | |
| 560 | // Do garbage collection as needed, so long as policy allows. |
| 561 | while (result == Status::RESOURCE_EXHAUSTED && do_auto_gc) { |
| 562 | if (options_.gc_on_write == GargbageCollectOnWrite::kOneSector) { |
| 563 | // If GC config option is kOneSector clear the flag to not do any more |
| 564 | // GC after this try. |
| 565 | do_auto_gc = false; |
| 566 | } |
| 567 | // Garbage collect and then try again to find the best sector. |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 568 | Status gc_status = GarbageCollectPartial(reserved); |
David Rogers | a2562b5 | 2020-03-05 15:30:05 -0800 | [diff] [blame] | 569 | if (!gc_status.ok()) { |
| 570 | if (gc_status == Status::NOT_FOUND) { |
| 571 | // Not enough space, and no reclaimable bytes, this KVS is full! |
| 572 | return Status::RESOURCE_EXHAUSTED; |
| 573 | } |
| 574 | return gc_status; |
| 575 | } |
| 576 | |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 577 | result = |
| 578 | FindSectorWithSpace(sector, entry_size, kAppendEntry, {}, reserved); |
David Rogers | f3884eb | 2020-03-08 19:21:40 -0700 | [diff] [blame] | 579 | |
| 580 | gc_sector_count++; |
| 581 | // Allow total sectors + 2 number of GC cycles so that once reclaimable |
| 582 | // bytes in all the sectors have been reclaimed can try and free up space by |
| 583 | // moving entries for keys other than the one being worked on in to sectors |
| 584 | // that have copies of the key trying to be written. |
| 585 | if (gc_sector_count > (partition_.sector_count() + 2)) { |
| 586 | ERR("Did more GC sectors than total sectors!!!!"); |
| 587 | return Status::RESOURCE_EXHAUSTED; |
| 588 | } |
David Rogers | a2562b5 | 2020-03-05 15:30:05 -0800 | [diff] [blame] | 589 | } |
| 590 | |
| 591 | if (!result.ok()) { |
| 592 | WRN("Unable to find sector to write %zu B", entry_size); |
| 593 | } |
| 594 | return result; |
| 595 | } |
| 596 | |
Wyatt Hepler | ab3b249 | 2020-03-11 16:15:16 -0700 | [diff] [blame] | 597 | Status KeyValueStore::AppendEntry(const Entry& entry, |
David Rogers | a2562b5 | 2020-03-05 15:30:05 -0800 | [diff] [blame] | 598 | string_view key, |
| 599 | span<const byte> value) { |
Wyatt Hepler | ab3b249 | 2020-03-11 16:15:16 -0700 | [diff] [blame] | 600 | const StatusWithSize result = entry.Write(key, value); |
David Rogers | a2562b5 | 2020-03-05 15:30:05 -0800 | [diff] [blame] | 601 | |
David Rogers | a2562b5 | 2020-03-05 15:30:05 -0800 | [diff] [blame] | 602 | // Remove any bytes that were written, even if the write was not successful. |
| 603 | // This is important to retain the writable space invariant on the sectors. |
Wyatt Hepler | ab3b249 | 2020-03-11 16:15:16 -0700 | [diff] [blame] | 604 | SectorDescriptor* const sector = SectorFromAddress(entry.address()); |
| 605 | sector->RemoveWritableBytes(result.size()); |
David Rogers | a2562b5 | 2020-03-05 15:30:05 -0800 | [diff] [blame] | 606 | |
| 607 | if (!result.ok()) { |
| 608 | ERR("Failed to write %zu bytes at %#zx. %zu actually written", |
| 609 | entry.size(), |
Wyatt Hepler | ab3b249 | 2020-03-11 16:15:16 -0700 | [diff] [blame] | 610 | size_t(entry.address()), |
David Rogers | a2562b5 | 2020-03-05 15:30:05 -0800 | [diff] [blame] | 611 | result.size()); |
| 612 | return result.status(); |
| 613 | } |
| 614 | |
| 615 | if (options_.verify_on_write) { |
| 616 | TRY(entry.VerifyChecksumInFlash()); |
| 617 | } |
| 618 | |
Wyatt Hepler | ab3b249 | 2020-03-11 16:15:16 -0700 | [diff] [blame] | 619 | sector->AddValidBytes(result.size()); |
David Rogers | a2562b5 | 2020-03-05 15:30:05 -0800 | [diff] [blame] | 620 | return Status::OK; |
| 621 | } |
| 622 | |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 623 | Status KeyValueStore::RelocateEntry(const EntryMetadata& metadata, |
Wyatt Hepler | ab3b249 | 2020-03-11 16:15:16 -0700 | [diff] [blame] | 624 | KeyValueStore::Address& address, |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 625 | span<const Address> reserved_addresses) { |
David Rogers | a2562b5 | 2020-03-05 15:30:05 -0800 | [diff] [blame] | 626 | Entry entry; |
Wyatt Hepler | ab3b249 | 2020-03-11 16:15:16 -0700 | [diff] [blame] | 627 | TRY(Entry::Read(partition_, address, formats_, &entry)); |
David Rogers | a2562b5 | 2020-03-05 15:30:05 -0800 | [diff] [blame] | 628 | |
| 629 | // Find a new sector for the entry and write it to the new location. For |
| 630 | // relocation the find should not not be a sector already containing the key |
| 631 | // but can be the always empty sector, since this is part of the GC process |
| 632 | // that will result in a new empty sector. Also find a sector that does not |
| 633 | // have reclaimable space (mostly for the full GC, where that would result in |
| 634 | // an immediate extra relocation). |
| 635 | SectorDescriptor* new_sector; |
| 636 | |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 637 | TRY(FindSectorWithSpace(&new_sector, |
| 638 | entry.size(), |
| 639 | kGarbageCollect, |
| 640 | metadata.addresses(), |
| 641 | reserved_addresses)); |
Wyatt Hepler | ab3b249 | 2020-03-11 16:15:16 -0700 | [diff] [blame] | 642 | |
| 643 | const Address new_address = NextWritableAddress(new_sector); |
| 644 | const StatusWithSize result = entry.Copy(new_address); |
| 645 | new_sector->RemoveWritableBytes(result.size()); |
| 646 | TRY(result); |
David Rogers | a2562b5 | 2020-03-05 15:30:05 -0800 | [diff] [blame] | 647 | |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 648 | // Entry was written successfully; update descriptor's address and the sector |
David Rogers | a2562b5 | 2020-03-05 15:30:05 -0800 | [diff] [blame] | 649 | // descriptors to reflect the new entry. |
Wyatt Hepler | ab3b249 | 2020-03-11 16:15:16 -0700 | [diff] [blame] | 650 | SectorFromAddress(address)->RemoveValidBytes(result.size()); |
| 651 | new_sector->AddValidBytes(result.size()); |
| 652 | address = new_address; |
David Rogers | a2562b5 | 2020-03-05 15:30:05 -0800 | [diff] [blame] | 653 | |
| 654 | return Status::OK; |
| 655 | } |
| 656 | |
David Rogers | 8db5a72 | 2020-02-03 18:28:34 -0800 | [diff] [blame] | 657 | // Find either an existing sector with enough space that is not the sector to |
| 658 | // skip, or an empty sector. Maintains the invariant that there is always at |
David Rogers | c8fe1f5 | 2020-02-27 14:04:08 -0800 | [diff] [blame] | 659 | // least 1 empty sector except during GC. On GC, skip sectors that have |
| 660 | // reclaimable bytes. |
Wyatt Hepler | 5a33d8c | 2020-02-06 09:32:58 -0800 | [diff] [blame] | 661 | Status KeyValueStore::FindSectorWithSpace( |
| 662 | SectorDescriptor** found_sector, |
| 663 | size_t size, |
David Rogers | c8fe1f5 | 2020-02-27 14:04:08 -0800 | [diff] [blame] | 664 | FindSectorMode find_mode, |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 665 | span<const Address> addresses_to_skip, |
| 666 | span<const Address> reserved_addresses) { |
Wyatt Hepler | 2c7eca0 | 2020-02-18 16:01:42 -0800 | [diff] [blame] | 667 | SectorDescriptor* first_empty_sector = nullptr; |
David Rogers | c8fe1f5 | 2020-02-27 14:04:08 -0800 | [diff] [blame] | 668 | bool at_least_two_empty_sectors = (find_mode == kGarbageCollect); |
Wyatt Hepler | 2c7eca0 | 2020-02-18 16:01:42 -0800 | [diff] [blame] | 669 | |
David Rogers | f3884eb | 2020-03-08 19:21:40 -0700 | [diff] [blame] | 670 | // Used for the GC reclaimable bytes check |
| 671 | SectorDescriptor* non_empty_least_reclaimable_sector = nullptr; |
| 672 | const size_t sector_size_bytes = partition_.sector_size_bytes(); |
| 673 | |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 674 | // Build a list of sectors to avoid. |
| 675 | // |
| 676 | // This is overly strict. reserved_addresses is populated when there are |
| 677 | // sectors reserved for a new entry. It is safe to garbage collect into |
| 678 | // these sectors, as long as there remains room for the pending entry. These |
| 679 | // reserved sectors could also be garbage collected if they have recoverable |
| 680 | // space. For simplicitly, avoid both the relocating key's redundant entries |
| 681 | // (addresses_to_skip) and the sectors reserved for pending writes |
| 682 | // (reserved_addresses). |
| 683 | // TODO(hepler): Look into improving garbage collection. |
| 684 | size_t sectors_to_skip = 0; |
Wyatt Hepler | ab3b249 | 2020-03-11 16:15:16 -0700 | [diff] [blame] | 685 | for (Address address : addresses_to_skip) { |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 686 | temp_sectors_to_skip_[sectors_to_skip++] = SectorFromAddress(address); |
| 687 | } |
| 688 | for (Address address : reserved_addresses) { |
| 689 | temp_sectors_to_skip_[sectors_to_skip++] = SectorFromAddress(address); |
David Rogers | a2562b5 | 2020-03-05 15:30:05 -0800 | [diff] [blame] | 690 | } |
| 691 | |
David Rogers | f3884eb | 2020-03-08 19:21:40 -0700 | [diff] [blame] | 692 | DBG("Find sector with %zu bytes available, starting with sector %u, %s", |
Wyatt Hepler | 2c7eca0 | 2020-02-18 16:01:42 -0800 | [diff] [blame] | 693 | size, |
David Rogers | f3884eb | 2020-03-08 19:21:40 -0700 | [diff] [blame] | 694 | SectorIndex(last_new_sector_), |
| 695 | (find_mode == kAppendEntry) ? "Append" : "GC"); |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 696 | for (size_t i = 0; i < sectors_to_skip; ++i) { |
| 697 | DBG(" Skip sector %u", SectorIndex(temp_sectors_to_skip_[i])); |
Wyatt Hepler | 2c7eca0 | 2020-02-18 16:01:42 -0800 | [diff] [blame] | 698 | } |
Wyatt Hepler | 2c7eca0 | 2020-02-18 16:01:42 -0800 | [diff] [blame] | 699 | |
David Rogers | 8ce55cd | 2020-02-04 19:41:48 -0800 | [diff] [blame] | 700 | // The last_new_sector_ is the sector that was last selected as the "new empty |
| 701 | // sector" to write to. This last new sector is used as the starting point for |
| 702 | // the next "find a new empty sector to write to" operation. By using the last |
| 703 | // new sector as the start point we will cycle which empty sector is selected |
| 704 | // next, spreading the wear across all the empty sectors and get a wear |
| 705 | // leveling benefit, rather than putting more wear on the lower number |
| 706 | // sectors. |
Wyatt Hepler | 2c7eca0 | 2020-02-18 16:01:42 -0800 | [diff] [blame] | 707 | SectorDescriptor* sector = last_new_sector_; |
David Rogers | 67f4b6c | 2020-02-06 16:17:09 -0800 | [diff] [blame] | 708 | |
David Rogers | f3884eb | 2020-03-08 19:21:40 -0700 | [diff] [blame] | 709 | // Look for a sector to use with enough space. The search uses a 3 priority |
David Rogers | cd87c32 | 2020-02-27 14:04:08 -0800 | [diff] [blame] | 710 | // tier process. |
| 711 | // |
David Rogers | c8fe1f5 | 2020-02-27 14:04:08 -0800 | [diff] [blame] | 712 | // Tier 1 is sector that already has valid data. During GC only select a |
| 713 | // sector that has no reclaimable bytes. Immediately use the first matching |
| 714 | // sector that is found. |
David Rogers | cd87c32 | 2020-02-27 14:04:08 -0800 | [diff] [blame] | 715 | // |
David Rogers | c8fe1f5 | 2020-02-27 14:04:08 -0800 | [diff] [blame] | 716 | // Tier 2 is find sectors that are empty/erased. While scanning for a partial |
| 717 | // sector, keep track of the first empty sector and if a second empty sector |
| 718 | // was seen. If during GC then count the second empty sector as always seen. |
David Rogers | f3884eb | 2020-03-08 19:21:40 -0700 | [diff] [blame] | 719 | // |
| 720 | // Tier 3 is during garbage collection, find sectors with enough space that |
| 721 | // are not empty but have recoverable bytes. Pick the sector with the least |
| 722 | // recoverable bytes to minimize the likelyhood of this sector needing to be |
| 723 | // garbage collected soon. |
Wyatt Hepler | 1c329ca | 2020-02-07 18:07:23 -0800 | [diff] [blame] | 724 | for (size_t j = 0; j < sectors_.size(); j++) { |
Wyatt Hepler | 2c7eca0 | 2020-02-18 16:01:42 -0800 | [diff] [blame] | 725 | sector += 1; |
| 726 | if (sector == sectors_.end()) { |
| 727 | sector = sectors_.begin(); |
| 728 | } |
Keir Mierle | 8c352dc | 2020-02-02 13:58:19 -0800 | [diff] [blame] | 729 | |
David Rogers | f3884eb | 2020-03-08 19:21:40 -0700 | [diff] [blame] | 730 | // Skip sectors in the skip list. |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 731 | if (Contains(span(temp_sectors_to_skip_, sectors_to_skip), sector)) { |
David Rogers | 8db5a72 | 2020-02-03 18:28:34 -0800 | [diff] [blame] | 732 | continue; |
| 733 | } |
| 734 | |
David Rogers | f3884eb | 2020-03-08 19:21:40 -0700 | [diff] [blame] | 735 | if (!sector->Empty(sector_size_bytes) && sector->HasSpace(size)) { |
| 736 | if ((find_mode == kAppendEntry) || |
| 737 | (sector->RecoverableBytes(sector_size_bytes) == 0)) { |
| 738 | *found_sector = sector; |
| 739 | return Status::OK; |
| 740 | } else { |
| 741 | if ((non_empty_least_reclaimable_sector == nullptr) || |
| 742 | (non_empty_least_reclaimable_sector->RecoverableBytes( |
| 743 | sector_size_bytes) < |
| 744 | sector->RecoverableBytes(sector_size_bytes))) { |
| 745 | non_empty_least_reclaimable_sector = sector; |
| 746 | } |
| 747 | } |
Wyatt Hepler | 4da1fcb | 2020-01-30 17:32:18 -0800 | [diff] [blame] | 748 | } |
| 749 | |
Wyatt Hepler | 2c7eca0 | 2020-02-18 16:01:42 -0800 | [diff] [blame] | 750 | if (sector->Empty(sector_size_bytes)) { |
Wyatt Hepler | 4da1fcb | 2020-01-30 17:32:18 -0800 | [diff] [blame] | 751 | if (first_empty_sector == nullptr) { |
Wyatt Hepler | 2c7eca0 | 2020-02-18 16:01:42 -0800 | [diff] [blame] | 752 | first_empty_sector = sector; |
Wyatt Hepler | 4da1fcb | 2020-01-30 17:32:18 -0800 | [diff] [blame] | 753 | } else { |
| 754 | at_least_two_empty_sectors = true; |
Wyatt Hepler | 2ad6067 | 2020-01-21 08:00:16 -0800 | [diff] [blame] | 755 | } |
Wyatt Hepler | b760954 | 2020-01-24 10:29:54 -0800 | [diff] [blame] | 756 | } |
| 757 | } |
Wyatt Hepler | 4da1fcb | 2020-01-30 17:32:18 -0800 | [diff] [blame] | 758 | |
David Rogers | f3884eb | 2020-03-08 19:21:40 -0700 | [diff] [blame] | 759 | // Tier 2 check: If the scan for a partial sector does not find a suitable |
| 760 | // sector, use the first empty sector that was found. Normally it is required |
| 761 | // to keep 1 empty sector after the sector found here, but that rule does not |
| 762 | // apply during GC. |
| 763 | if (first_empty_sector != nullptr && at_least_two_empty_sectors) { |
Wyatt Hepler | 2c7eca0 | 2020-02-18 16:01:42 -0800 | [diff] [blame] | 764 | DBG(" Found a usable empty sector; returning the first found (%u)", |
David Rogers | 8ce55cd | 2020-02-04 19:41:48 -0800 | [diff] [blame] | 765 | SectorIndex(first_empty_sector)); |
| 766 | last_new_sector_ = first_empty_sector; |
| 767 | *found_sector = first_empty_sector; |
| 768 | return Status::OK; |
Wyatt Hepler | 4da1fcb | 2020-01-30 17:32:18 -0800 | [diff] [blame] | 769 | } |
David Rogers | 8ce55cd | 2020-02-04 19:41:48 -0800 | [diff] [blame] | 770 | |
David Rogers | f3884eb | 2020-03-08 19:21:40 -0700 | [diff] [blame] | 771 | // Tier 3 check: If we got this far, use the sector with least recoverable |
| 772 | // bytes |
| 773 | if (non_empty_least_reclaimable_sector != nullptr) { |
| 774 | *found_sector = non_empty_least_reclaimable_sector; |
| 775 | DBG(" Found a usable sector %u, with %zu B recoverable, in GC", |
| 776 | SectorIndex(*found_sector), |
| 777 | (*found_sector)->RecoverableBytes(sector_size_bytes)); |
| 778 | return Status::OK; |
| 779 | } |
| 780 | |
David Rogers | 8ce55cd | 2020-02-04 19:41:48 -0800 | [diff] [blame] | 781 | // No sector was found. |
David Rogers | 67f4b6c | 2020-02-06 16:17:09 -0800 | [diff] [blame] | 782 | DBG(" Unable to find a usable sector"); |
David Rogers | 8ce55cd | 2020-02-04 19:41:48 -0800 | [diff] [blame] | 783 | *found_sector = nullptr; |
| 784 | return Status::RESOURCE_EXHAUSTED; |
Wyatt Hepler | b760954 | 2020-01-24 10:29:54 -0800 | [diff] [blame] | 785 | } |
| 786 | |
David Rogers | f3884eb | 2020-03-08 19:21:40 -0700 | [diff] [blame] | 787 | // TODO: Break up this function in to smaller sub-chunks including create an |
| 788 | // abstraction for the sector list. Look in to being able to unit test this as |
| 789 | // its own thing |
| 790 | KeyValueStore::SectorDescriptor* KeyValueStore::FindSectorToGarbageCollect( |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 791 | span<const Address> reserved_addresses) { |
Wyatt Hepler | 2c7eca0 | 2020-02-18 16:01:42 -0800 | [diff] [blame] | 792 | const size_t sector_size_bytes = partition_.sector_size_bytes(); |
David Rogers | 2761aeb | 2020-01-31 17:09:00 -0800 | [diff] [blame] | 793 | SectorDescriptor* sector_candidate = nullptr; |
David Rogers | a12786b | 2020-01-31 16:02:33 -0800 | [diff] [blame] | 794 | size_t candidate_bytes = 0; |
| 795 | |
David Rogers | f3884eb | 2020-03-08 19:21:40 -0700 | [diff] [blame] | 796 | // Build a vector of sectors to avoid. |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 797 | for (size_t i = 0; i < reserved_addresses.size(); ++i) { |
| 798 | temp_sectors_to_skip_[i] = SectorFromAddress(reserved_addresses[i]); |
| 799 | DBG(" Skip sector %u", |
| 800 | SectorIndex(SectorFromAddress(reserved_addresses[i]))); |
David Rogers | f3884eb | 2020-03-08 19:21:40 -0700 | [diff] [blame] | 801 | } |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 802 | const span sectors_to_skip(temp_sectors_to_skip_, reserved_addresses.size()); |
David Rogers | f3884eb | 2020-03-08 19:21:40 -0700 | [diff] [blame] | 803 | |
David Rogers | a12786b | 2020-01-31 16:02:33 -0800 | [diff] [blame] | 804 | // Step 1: Try to find a sectors with stale keys and no valid keys (no |
| 805 | // relocation needed). If any such sectors are found, use the sector with the |
| 806 | // most reclaimable bytes. |
Wyatt Hepler | 1c329ca | 2020-02-07 18:07:23 -0800 | [diff] [blame] | 807 | for (auto& sector : sectors_) { |
Wyatt Hepler | 2c7eca0 | 2020-02-18 16:01:42 -0800 | [diff] [blame] | 808 | if ((sector.valid_bytes() == 0) && |
David Rogers | f3884eb | 2020-03-08 19:21:40 -0700 | [diff] [blame] | 809 | (sector.RecoverableBytes(sector_size_bytes) > candidate_bytes) && |
| 810 | !Contains(sectors_to_skip, §or)) { |
David Rogers | a12786b | 2020-01-31 16:02:33 -0800 | [diff] [blame] | 811 | sector_candidate = §or; |
Wyatt Hepler | 2c7eca0 | 2020-02-18 16:01:42 -0800 | [diff] [blame] | 812 | candidate_bytes = sector.RecoverableBytes(sector_size_bytes); |
David Rogers | a12786b | 2020-01-31 16:02:33 -0800 | [diff] [blame] | 813 | } |
| 814 | } |
| 815 | |
David Rogers | c9d545e | 2020-03-11 17:47:43 -0700 | [diff] [blame] | 816 | // Step 2: If step 1 yields no sectors, just find the sector with the most |
David Rogers | f3884eb | 2020-03-08 19:21:40 -0700 | [diff] [blame] | 817 | // reclaimable bytes but no addresses to avoid. |
| 818 | if (sector_candidate == nullptr) { |
| 819 | for (auto& sector : sectors_) { |
| 820 | if ((sector.RecoverableBytes(sector_size_bytes) > candidate_bytes) && |
| 821 | !Contains(sectors_to_skip, §or)) { |
| 822 | sector_candidate = §or; |
| 823 | candidate_bytes = sector.RecoverableBytes(sector_size_bytes); |
| 824 | } |
| 825 | } |
| 826 | } |
| 827 | |
David Rogers | f3884eb | 2020-03-08 19:21:40 -0700 | [diff] [blame] | 828 | // Step 3: If no sectors with reclaimable bytes, select the sector with the |
| 829 | // most free bytes. This at least will allow entries of existing keys to get |
| 830 | // spread to other sectors, including sectors that already have copies of the |
| 831 | // current key being written. |
| 832 | if (sector_candidate == nullptr) { |
| 833 | for (auto& sector : sectors_) { |
| 834 | if ((sector.valid_bytes() > candidate_bytes) && |
| 835 | !Contains(sectors_to_skip, §or)) { |
| 836 | sector_candidate = §or; |
| 837 | candidate_bytes = sector.valid_bytes(); |
| 838 | DBG(" Doing GC on sector with no reclaimable bytes!"); |
| 839 | } |
| 840 | } |
| 841 | } |
| 842 | |
David Rogers | 5981f31 | 2020-02-13 13:33:56 -0800 | [diff] [blame] | 843 | if (sector_candidate != nullptr) { |
Wyatt Hepler | 2c7eca0 | 2020-02-18 16:01:42 -0800 | [diff] [blame] | 844 | DBG("Found sector %u to Garbage Collect, %zu recoverable bytes", |
David Rogers | 5981f31 | 2020-02-13 13:33:56 -0800 | [diff] [blame] | 845 | SectorIndex(sector_candidate), |
Wyatt Hepler | 2c7eca0 | 2020-02-18 16:01:42 -0800 | [diff] [blame] | 846 | sector_candidate->RecoverableBytes(sector_size_bytes)); |
David Rogers | 5981f31 | 2020-02-13 13:33:56 -0800 | [diff] [blame] | 847 | } else { |
| 848 | DBG("Unable to find sector to garbage collect!"); |
| 849 | } |
David Rogers | a12786b | 2020-01-31 16:02:33 -0800 | [diff] [blame] | 850 | return sector_candidate; |
| 851 | } |
| 852 | |
David Rogers | cd87c32 | 2020-02-27 14:04:08 -0800 | [diff] [blame] | 853 | Status KeyValueStore::GarbageCollectFull() { |
| 854 | DBG("Garbage Collect all sectors"); |
David Rogers | cd87c32 | 2020-02-27 14:04:08 -0800 | [diff] [blame] | 855 | SectorDescriptor* sector = last_new_sector_; |
| 856 | |
| 857 | // TODO: look in to making an iterator method for cycling through sectors |
| 858 | // starting from last_new_sector_. |
| 859 | for (size_t j = 0; j < sectors_.size(); j++) { |
| 860 | sector += 1; |
| 861 | if (sector == sectors_.end()) { |
| 862 | sector = sectors_.begin(); |
| 863 | } |
| 864 | |
| 865 | if (sector->RecoverableBytes(partition_.sector_size_bytes()) > 0) { |
Wyatt Hepler | ab3b249 | 2020-03-11 16:15:16 -0700 | [diff] [blame] | 866 | TRY(GarbageCollectSector(sector, {})); |
David Rogers | cd87c32 | 2020-02-27 14:04:08 -0800 | [diff] [blame] | 867 | } |
| 868 | } |
| 869 | |
| 870 | DBG("Garbage Collect all complete"); |
David Rogers | cd87c32 | 2020-02-27 14:04:08 -0800 | [diff] [blame] | 871 | return Status::OK; |
| 872 | } |
| 873 | |
David Rogers | c9d545e | 2020-03-11 17:47:43 -0700 | [diff] [blame] | 874 | Status KeyValueStore::GarbageCollectPartial( |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 875 | span<const Address> reserved_addresses) { |
David Rogers | c9d545e | 2020-03-11 17:47:43 -0700 | [diff] [blame] | 876 | DBG("Garbage Collect a single sector"); |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 877 | for (Address address : reserved_addresses) { |
David Rogers | c9d545e | 2020-03-11 17:47:43 -0700 | [diff] [blame] | 878 | DBG(" Avoid address %u", unsigned(address)); |
| 879 | } |
David Rogers | 67f4b6c | 2020-02-06 16:17:09 -0800 | [diff] [blame] | 880 | |
David Rogers | a12786b | 2020-01-31 16:02:33 -0800 | [diff] [blame] | 881 | // Step 1: Find the sector to garbage collect |
David Rogers | c9d545e | 2020-03-11 17:47:43 -0700 | [diff] [blame] | 882 | SectorDescriptor* sector_to_gc = |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 883 | FindSectorToGarbageCollect(reserved_addresses); |
Wyatt Hepler | 4da1fcb | 2020-01-30 17:32:18 -0800 | [diff] [blame] | 884 | |
David Rogers | a12786b | 2020-01-31 16:02:33 -0800 | [diff] [blame] | 885 | if (sector_to_gc == nullptr) { |
David Rogers | a2562b5 | 2020-03-05 15:30:05 -0800 | [diff] [blame] | 886 | // Nothing to GC. |
| 887 | return Status::NOT_FOUND; |
David Rogers | a12786b | 2020-01-31 16:02:33 -0800 | [diff] [blame] | 888 | } |
Wyatt Hepler | 4da1fcb | 2020-01-30 17:32:18 -0800 | [diff] [blame] | 889 | |
David Rogers | c9d545e | 2020-03-11 17:47:43 -0700 | [diff] [blame] | 890 | // Step 2: Garbage collect the selected sector. |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 891 | return GarbageCollectSector(sector_to_gc, reserved_addresses); |
David Rogers | cd87c32 | 2020-02-27 14:04:08 -0800 | [diff] [blame] | 892 | } |
| 893 | |
David Rogers | f3884eb | 2020-03-08 19:21:40 -0700 | [diff] [blame] | 894 | Status KeyValueStore::RelocateKeyAddressesInSector( |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 895 | SectorDescriptor& sector_to_gc, |
| 896 | const EntryMetadata& metadata, |
| 897 | span<const Address> reserved_addresses) { |
| 898 | for (FlashPartition::Address& address : metadata.addresses()) { |
Wyatt Hepler | ab3b249 | 2020-03-11 16:15:16 -0700 | [diff] [blame] | 899 | if (AddressInSector(sector_to_gc, address)) { |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 900 | DBG(" Relocate entry for Key 0x%08" PRIx32 ", sector %u", |
| 901 | metadata.hash(), |
Wyatt Hepler | ab3b249 | 2020-03-11 16:15:16 -0700 | [diff] [blame] | 902 | SectorIndex(SectorFromAddress(address))); |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 903 | TRY(RelocateEntry(metadata, address, reserved_addresses)); |
David Rogers | f3884eb | 2020-03-08 19:21:40 -0700 | [diff] [blame] | 904 | } |
| 905 | } |
Wyatt Hepler | ab3b249 | 2020-03-11 16:15:16 -0700 | [diff] [blame] | 906 | |
David Rogers | f3884eb | 2020-03-08 19:21:40 -0700 | [diff] [blame] | 907 | return Status::OK; |
| 908 | }; |
| 909 | |
Wyatt Hepler | ab3b249 | 2020-03-11 16:15:16 -0700 | [diff] [blame] | 910 | Status KeyValueStore::GarbageCollectSector( |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 911 | SectorDescriptor* sector_to_gc, span<const Address> reserved_addresses) { |
David Rogers | f3884eb | 2020-03-08 19:21:40 -0700 | [diff] [blame] | 912 | // Step 1: Move any valid entries in the GC sector to other sectors |
Wyatt Hepler | ab3b249 | 2020-03-11 16:15:16 -0700 | [diff] [blame] | 913 | if (sector_to_gc->valid_bytes() != 0) { |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 914 | for (const EntryMetadata& metadata : entry_cache_) { |
Wyatt Hepler | ab3b249 | 2020-03-11 16:15:16 -0700 | [diff] [blame] | 915 | TRY(RelocateKeyAddressesInSector( |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 916 | *sector_to_gc, metadata, reserved_addresses)); |
David Rogers | f3884eb | 2020-03-08 19:21:40 -0700 | [diff] [blame] | 917 | } |
| 918 | } |
| 919 | |
Wyatt Hepler | 2c7eca0 | 2020-02-18 16:01:42 -0800 | [diff] [blame] | 920 | if (sector_to_gc->valid_bytes() != 0) { |
David Rogers | 67f4b6c | 2020-02-06 16:17:09 -0800 | [diff] [blame] | 921 | ERR(" Failed to relocate valid entries from sector being garbage " |
Wyatt Hepler | 2c7eca0 | 2020-02-18 16:01:42 -0800 | [diff] [blame] | 922 | "collected, %zu valid bytes remain", |
| 923 | sector_to_gc->valid_bytes()); |
Wyatt Hepler | b760954 | 2020-01-24 10:29:54 -0800 | [diff] [blame] | 924 | return Status::INTERNAL; |
| 925 | } |
| 926 | |
David Rogers | cd87c32 | 2020-02-27 14:04:08 -0800 | [diff] [blame] | 927 | // Step 2: Reinitialize the sector |
Wyatt Hepler | 2c7eca0 | 2020-02-18 16:01:42 -0800 | [diff] [blame] | 928 | sector_to_gc->set_writable_bytes(0); |
David Rogers | a12786b | 2020-01-31 16:02:33 -0800 | [diff] [blame] | 929 | TRY(partition_.Erase(SectorBaseAddress(sector_to_gc), 1)); |
Wyatt Hepler | 2c7eca0 | 2020-02-18 16:01:42 -0800 | [diff] [blame] | 930 | sector_to_gc->set_writable_bytes(partition_.sector_size_bytes()); |
Wyatt Hepler | b760954 | 2020-01-24 10:29:54 -0800 | [diff] [blame] | 931 | |
David Rogers | cd87c32 | 2020-02-27 14:04:08 -0800 | [diff] [blame] | 932 | DBG(" Garbage Collect sector %u complete", SectorIndex(sector_to_gc)); |
David Rogers | a12786b | 2020-01-31 16:02:33 -0800 | [diff] [blame] | 933 | return Status::OK; |
Wyatt Hepler | 4da1fcb | 2020-01-30 17:32:18 -0800 | [diff] [blame] | 934 | } |
| 935 | |
Wyatt Hepler | bdd8e5a | 2020-02-20 19:27:26 -0800 | [diff] [blame] | 936 | KeyValueStore::Entry KeyValueStore::CreateEntry(Address address, |
Wyatt Hepler | ab3b249 | 2020-03-11 16:15:16 -0700 | [diff] [blame] | 937 | string_view key, |
Wyatt Hepler | bdd8e5a | 2020-02-20 19:27:26 -0800 | [diff] [blame] | 938 | span<const byte> value, |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 939 | EntryState state) { |
Keir Mierle | 9e38b40 | 2020-02-21 13:06:21 -0800 | [diff] [blame] | 940 | // Always bump the transaction ID when creating a new entry. |
| 941 | // |
| 942 | // Burning transaction IDs prevents inconsistencies between flash and memory |
| 943 | // that which could happen if a write succeeds, but for some reason the read |
| 944 | // and verify step fails. Here's how this would happen: |
| 945 | // |
| 946 | // 1. The entry is written but for some reason the flash reports failure OR |
| 947 | // The write succeeds, but the read / verify operation fails. |
| 948 | // 2. The transaction ID is NOT incremented, because of the failure |
| 949 | // 3. (later) A new entry is written, re-using the transaction ID (oops) |
| 950 | // |
| 951 | // By always burning transaction IDs, the above problem can't happen. |
| 952 | last_transaction_id_ += 1; |
| 953 | |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 954 | if (state == EntryState::kDeleted) { |
Wyatt Hepler | 7465be3 | 2020-02-21 15:30:53 -0800 | [diff] [blame] | 955 | return Entry::Tombstone( |
Wyatt Hepler | 22d0d9f | 2020-03-05 14:57:11 -0800 | [diff] [blame] | 956 | partition_, address, formats_.primary(), key, last_transaction_id_); |
Wyatt Hepler | 1fc1104 | 2020-02-19 17:17:51 -0800 | [diff] [blame] | 957 | } |
| 958 | return Entry::Valid(partition_, |
| 959 | address, |
Wyatt Hepler | 22d0d9f | 2020-03-05 14:57:11 -0800 | [diff] [blame] | 960 | formats_.primary(), |
Wyatt Hepler | 1fc1104 | 2020-02-19 17:17:51 -0800 | [diff] [blame] | 961 | key, |
| 962 | value, |
Keir Mierle | 9e38b40 | 2020-02-21 13:06:21 -0800 | [diff] [blame] | 963 | last_transaction_id_); |
Wyatt Hepler | d229828 | 2020-02-20 17:12:45 -0800 | [diff] [blame] | 964 | } |
| 965 | |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 966 | void KeyValueStore::LogDebugInfo() const { |
Keir Mierle | 8c352dc | 2020-02-02 13:58:19 -0800 | [diff] [blame] | 967 | const size_t sector_size_bytes = partition_.sector_size_bytes(); |
| 968 | DBG("====================== KEY VALUE STORE DUMP ========================="); |
| 969 | DBG(" "); |
| 970 | DBG("Flash partition:"); |
Wyatt Hepler | ad0a793 | 2020-02-06 08:20:38 -0800 | [diff] [blame] | 971 | DBG(" Sector count = %zu", partition_.sector_count()); |
Wyatt Hepler | 38ce30f | 2020-02-19 11:48:31 -0800 | [diff] [blame] | 972 | DBG(" Sector max count = %zu", sectors_.max_size()); |
Wyatt Hepler | 1c329ca | 2020-02-07 18:07:23 -0800 | [diff] [blame] | 973 | DBG(" Sectors in use = %zu", sectors_.size()); |
Keir Mierle | 8c352dc | 2020-02-02 13:58:19 -0800 | [diff] [blame] | 974 | DBG(" Sector size = %zu", sector_size_bytes); |
| 975 | DBG(" Total size = %zu", partition_.size_bytes()); |
| 976 | DBG(" Alignment = %zu", partition_.alignment_bytes()); |
| 977 | DBG(" "); |
| 978 | DBG("Key descriptors:"); |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 979 | DBG(" Entry count = %zu", entry_cache_.total_entries()); |
| 980 | DBG(" Max entry count = %zu", entry_cache_.max_entries()); |
Keir Mierle | 8c352dc | 2020-02-02 13:58:19 -0800 | [diff] [blame] | 981 | DBG(" "); |
| 982 | DBG(" # hash version address address (hex)"); |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 983 | size_t i = 0; |
| 984 | for (const EntryMetadata& metadata : entry_cache_) { |
Keir Mierle | 8c352dc | 2020-02-02 13:58:19 -0800 | [diff] [blame] | 985 | DBG(" |%3zu: | %8zx |%8zu | %8zu | %8zx", |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 986 | i++, |
| 987 | size_t(metadata.hash()), |
| 988 | size_t(metadata.transaction_id()), |
| 989 | size_t(metadata.first_address()), |
| 990 | size_t(metadata.first_address())); |
Keir Mierle | 8c352dc | 2020-02-02 13:58:19 -0800 | [diff] [blame] | 991 | } |
| 992 | DBG(" "); |
| 993 | |
| 994 | DBG("Sector descriptors:"); |
| 995 | DBG(" # tail free valid has_space"); |
Wyatt Hepler | 1c329ca | 2020-02-07 18:07:23 -0800 | [diff] [blame] | 996 | for (size_t sector_id = 0; sector_id < sectors_.size(); ++sector_id) { |
| 997 | const SectorDescriptor& sd = sectors_[sector_id]; |
Keir Mierle | 8c352dc | 2020-02-02 13:58:19 -0800 | [diff] [blame] | 998 | DBG(" |%3zu: | %8zu |%8zu | %s", |
| 999 | sector_id, |
Wyatt Hepler | 2c7eca0 | 2020-02-18 16:01:42 -0800 | [diff] [blame] | 1000 | size_t(sd.writable_bytes()), |
| 1001 | sd.valid_bytes(), |
| 1002 | sd.writable_bytes() ? "YES" : ""); |
Keir Mierle | 8c352dc | 2020-02-02 13:58:19 -0800 | [diff] [blame] | 1003 | } |
| 1004 | DBG(" "); |
| 1005 | |
| 1006 | // TODO: This should stop logging after some threshold. |
| 1007 | // size_t dumped_bytes = 0; |
| 1008 | DBG("Sector raw data:"); |
Wyatt Hepler | 1c329ca | 2020-02-07 18:07:23 -0800 | [diff] [blame] | 1009 | for (size_t sector_id = 0; sector_id < sectors_.size(); ++sector_id) { |
Keir Mierle | 8c352dc | 2020-02-02 13:58:19 -0800 | [diff] [blame] | 1010 | // Read sector data. Yes, this will blow the stack on embedded. |
Wyatt Hepler | 1c329ca | 2020-02-07 18:07:23 -0800 | [diff] [blame] | 1011 | std::array<byte, 500> raw_sector_data; // TODO!!! |
Keir Mierle | 8c352dc | 2020-02-02 13:58:19 -0800 | [diff] [blame] | 1012 | StatusWithSize sws = |
| 1013 | partition_.Read(sector_id * sector_size_bytes, raw_sector_data); |
| 1014 | DBG("Read: %zu bytes", sws.size()); |
| 1015 | |
| 1016 | DBG(" base addr offs 0 1 2 3 4 5 6 7"); |
| 1017 | for (size_t i = 0; i < sector_size_bytes; i += 8) { |
| 1018 | DBG(" %3zu %8zx %5zu | %02x %02x %02x %02x %02x %02x %02x %02x", |
| 1019 | sector_id, |
| 1020 | (sector_id * sector_size_bytes) + i, |
| 1021 | i, |
| 1022 | static_cast<unsigned int>(raw_sector_data[i + 0]), |
| 1023 | static_cast<unsigned int>(raw_sector_data[i + 1]), |
| 1024 | static_cast<unsigned int>(raw_sector_data[i + 2]), |
| 1025 | static_cast<unsigned int>(raw_sector_data[i + 3]), |
| 1026 | static_cast<unsigned int>(raw_sector_data[i + 4]), |
| 1027 | static_cast<unsigned int>(raw_sector_data[i + 5]), |
| 1028 | static_cast<unsigned int>(raw_sector_data[i + 6]), |
| 1029 | static_cast<unsigned int>(raw_sector_data[i + 7])); |
| 1030 | |
| 1031 | // TODO: Fix exit condition. |
| 1032 | if (i > 128) { |
| 1033 | break; |
| 1034 | } |
| 1035 | } |
| 1036 | DBG(" "); |
| 1037 | } |
| 1038 | |
| 1039 | DBG("////////////////////// KEY VALUE STORE DUMP END /////////////////////"); |
| 1040 | } |
| 1041 | |
David Rogers | cf680ab | 2020-02-12 23:28:32 -0800 | [diff] [blame] | 1042 | void KeyValueStore::LogSectors() const { |
| 1043 | DBG("Sector descriptors: count %zu", sectors_.size()); |
Wyatt Hepler | 1c329ca | 2020-02-07 18:07:23 -0800 | [diff] [blame] | 1044 | for (auto& sector : sectors_) { |
Wyatt Hepler | 2c7eca0 | 2020-02-18 16:01:42 -0800 | [diff] [blame] | 1045 | DBG(" - Sector %u: valid %zu, recoverable %zu, free %zu", |
David Rogers | 50185ad | 2020-02-07 00:02:46 -0800 | [diff] [blame] | 1046 | SectorIndex(§or), |
Wyatt Hepler | 2c7eca0 | 2020-02-18 16:01:42 -0800 | [diff] [blame] | 1047 | sector.valid_bytes(), |
| 1048 | sector.RecoverableBytes(partition_.sector_size_bytes()), |
| 1049 | sector.writable_bytes()); |
David Rogers | 50185ad | 2020-02-07 00:02:46 -0800 | [diff] [blame] | 1050 | } |
| 1051 | } |
| 1052 | |
David Rogers | cf680ab | 2020-02-12 23:28:32 -0800 | [diff] [blame] | 1053 | void KeyValueStore::LogKeyDescriptor() const { |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 1054 | DBG("Key descriptors: count %zu", entry_cache_.total_entries()); |
| 1055 | for (auto& metadata : entry_cache_) { |
| 1056 | DBG(" - Key: %s, hash %#zx, transaction ID %zu, first address %#zx", |
Wyatt Hepler | 0294627 | 2020-03-18 10:36:22 -0700 | [diff] [blame^] | 1057 | metadata.state() == EntryState::kDeleted ? "Deleted" : "Valid", |
Wyatt Hepler | 7ded6da | 2020-03-11 18:24:43 -0700 | [diff] [blame] | 1058 | static_cast<size_t>(metadata.hash()), |
| 1059 | static_cast<size_t>(metadata.transaction_id()), |
| 1060 | static_cast<size_t>(metadata.first_address())); |
David Rogers | cf680ab | 2020-02-12 23:28:32 -0800 | [diff] [blame] | 1061 | } |
| 1062 | } |
| 1063 | |
Wyatt Hepler | 2ad6067 | 2020-01-21 08:00:16 -0800 | [diff] [blame] | 1064 | } // namespace pw::kvs |