blob: d2257545875304d9367431873e61b68ca951e512 [file] [log] [blame]
Tarek Ziadéf14c7fc2010-01-24 00:33:32 +00001# -*- encoding: utf8 -*-
Éric Araujo54274ad2011-02-03 00:12:18 +00002"""Tests for distutils.command.upload."""
Andrew M. Kuchlingaac5c862008-05-11 14:00:00 +00003import os
4import unittest
Éric Araujo54274ad2011-02-03 00:12:18 +00005from test.test_support import run_unittest
Andrew M. Kuchlingaac5c862008-05-11 14:00:00 +00006
Tarek Ziadéa1cc0402009-06-15 23:30:13 +00007from distutils.command import upload as upload_mod
Andrew M. Kuchlingaac5c862008-05-11 14:00:00 +00008from distutils.command.upload import upload
9from distutils.core import Distribution
Antoine Pitrou077c9562014-06-18 23:07:46 -040010from distutils.errors import DistutilsError
Andrew M. Kuchlingaac5c862008-05-11 14:00:00 +000011
Andrew M. Kuchlingaac5c862008-05-11 14:00:00 +000012from distutils.tests.test_config import PYPIRC, PyPIRCCommandTestCase
13
Tarek Ziadé2421d562009-12-20 23:23:34 +000014PYPIRC_LONG_PASSWORD = """\
15[distutils]
16
17index-servers =
18 server1
19 server2
20
21[server1]
22username:me
23password:aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
24
25[server2]
26username:meagain
27password: secret
28realm:acme
29repository:http://another.pypi/
30"""
31
32
Tarek Ziadé1a240fb2009-01-08 23:56:31 +000033PYPIRC_NOPASSWORD = """\
34[distutils]
35
36index-servers =
37 server1
38
39[server1]
40username:me
41"""
42
Tarek Ziadéa1cc0402009-06-15 23:30:13 +000043class FakeOpen(object):
Tarek Ziadée899b712009-03-31 20:53:55 +000044
Antoine Pitrou077c9562014-06-18 23:07:46 -040045 def __init__(self, url, msg=None, code=None):
Tarek Ziadéa1cc0402009-06-15 23:30:13 +000046 self.url = url
47 if not isinstance(url, str):
48 self.req = url
49 else:
50 self.req = None
Antoine Pitrou077c9562014-06-18 23:07:46 -040051 self.msg = msg or 'OK'
52 self.code = code or 200
Tarek Ziadée899b712009-03-31 20:53:55 +000053
Tarek Ziadéa1cc0402009-06-15 23:30:13 +000054 def getcode(self):
Antoine Pitrou077c9562014-06-18 23:07:46 -040055 return self.code
Tarek Ziadée899b712009-03-31 20:53:55 +000056
Tarek Ziadé1a240fb2009-01-08 23:56:31 +000057
Andrew M. Kuchlingaac5c862008-05-11 14:00:00 +000058class uploadTestCase(PyPIRCCommandTestCase):
59
Tarek Ziadée899b712009-03-31 20:53:55 +000060 def setUp(self):
61 super(uploadTestCase, self).setUp()
Tarek Ziadéa1cc0402009-06-15 23:30:13 +000062 self.old_open = upload_mod.urlopen
63 upload_mod.urlopen = self._urlopen
64 self.last_open = None
Antoine Pitrou077c9562014-06-18 23:07:46 -040065 self.next_msg = None
66 self.next_code = None
Tarek Ziadée899b712009-03-31 20:53:55 +000067
68 def tearDown(self):
Tarek Ziadéa1cc0402009-06-15 23:30:13 +000069 upload_mod.urlopen = self.old_open
Tarek Ziadée899b712009-03-31 20:53:55 +000070 super(uploadTestCase, self).tearDown()
71
Tarek Ziadéa1cc0402009-06-15 23:30:13 +000072 def _urlopen(self, url):
Antoine Pitrou077c9562014-06-18 23:07:46 -040073 self.last_open = FakeOpen(url, msg=self.next_msg, code=self.next_code)
Tarek Ziadéa1cc0402009-06-15 23:30:13 +000074 return self.last_open
75
Andrew M. Kuchlingaac5c862008-05-11 14:00:00 +000076 def test_finalize_options(self):
77
78 # new format
Tarek Ziadée899b712009-03-31 20:53:55 +000079 self.write_file(self.rc, PYPIRC)
Andrew M. Kuchlingaac5c862008-05-11 14:00:00 +000080 dist = Distribution()
81 cmd = upload(dist)
82 cmd.finalize_options()
83 for attr, waited in (('username', 'me'), ('password', 'secret'),
84 ('realm', 'pypi'),
Donald Stufft692497a2016-08-03 18:58:12 -040085 ('repository', 'https://upload.pypi.org/legacy/')):
Ezio Melotti2623a372010-11-21 13:34:58 +000086 self.assertEqual(getattr(cmd, attr), waited)
Andrew M. Kuchlingaac5c862008-05-11 14:00:00 +000087
Tarek Ziadé1a240fb2009-01-08 23:56:31 +000088 def test_saved_password(self):
89 # file with no password
Tarek Ziadée899b712009-03-31 20:53:55 +000090 self.write_file(self.rc, PYPIRC_NOPASSWORD)
Tarek Ziadé1a240fb2009-01-08 23:56:31 +000091
92 # make sure it passes
93 dist = Distribution()
94 cmd = upload(dist)
95 cmd.finalize_options()
Ezio Melotti2623a372010-11-21 13:34:58 +000096 self.assertEqual(cmd.password, None)
Tarek Ziadé1a240fb2009-01-08 23:56:31 +000097
98 # make sure we get it as well, if another command
99 # initialized it at the dist level
100 dist.password = 'xxx'
101 cmd = upload(dist)
102 cmd.finalize_options()
Ezio Melotti2623a372010-11-21 13:34:58 +0000103 self.assertEqual(cmd.password, 'xxx')
Andrew M. Kuchlingaac5c862008-05-11 14:00:00 +0000104
Tarek Ziadée899b712009-03-31 20:53:55 +0000105 def test_upload(self):
106 tmp = self.mkdtemp()
107 path = os.path.join(tmp, 'xxx')
108 self.write_file(path)
109 command, pyversion, filename = 'xxx', '2.6', path
110 dist_files = [(command, pyversion, filename)]
Tarek Ziadé2421d562009-12-20 23:23:34 +0000111 self.write_file(self.rc, PYPIRC_LONG_PASSWORD)
Tarek Ziadée899b712009-03-31 20:53:55 +0000112
113 # lets run it
Tarek Ziadéf14c7fc2010-01-24 00:33:32 +0000114 pkg_dir, dist = self.create_dist(dist_files=dist_files, author=u'dédé')
Tarek Ziadée899b712009-03-31 20:53:55 +0000115 cmd = upload(dist)
116 cmd.ensure_finalized()
117 cmd.run()
118
119 # what did we send ?
Tarek Ziadéf14c7fc2010-01-24 00:33:32 +0000120 self.assertIn('dédé', self.last_open.req.data)
Tarek Ziadéa1cc0402009-06-15 23:30:13 +0000121 headers = dict(self.last_open.req.headers)
R David Murray9ad23c62014-09-27 16:59:04 -0400122 self.assertEqual(headers['Content-length'], '2159')
Benjamin Peterson5c8da862009-06-30 22:57:08 +0000123 self.assertTrue(headers['Content-type'].startswith('multipart/form-data'))
Ezio Melotti2623a372010-11-21 13:34:58 +0000124 self.assertEqual(self.last_open.req.get_method(), 'POST')
125 self.assertEqual(self.last_open.req.get_full_url(),
Donald Stufft692497a2016-08-03 18:58:12 -0400126 'https://upload.pypi.org/legacy/')
Serhiy Storchaka25a23ef2013-11-17 00:29:27 +0200127 self.assertIn('xxx', self.last_open.req.data)
Tarek Ziadé2421d562009-12-20 23:23:34 +0000128 auth = self.last_open.req.headers['Authorization']
Serhiy Storchaka25a23ef2013-11-17 00:29:27 +0200129 self.assertNotIn('\n', auth)
Tarek Ziadée899b712009-03-31 20:53:55 +0000130
Bo Baylesf5a79352018-01-29 08:31:32 -0600131 # bpo-32304: archives whose last byte was b'\r' were corrupted due to
132 # normalization intended for Mac OS 9.
133 def test_upload_correct_cr(self):
134 # content that ends with \r should not be modified.
135 tmp = self.mkdtemp()
136 path = os.path.join(tmp, 'xxx')
137 self.write_file(path, content='yy\r')
138 command, pyversion, filename = 'xxx', '2.6', path
139 dist_files = [(command, pyversion, filename)]
140 self.write_file(self.rc, PYPIRC_LONG_PASSWORD)
141
142 # other fields that ended with \r used to be modified, now are
143 # preserved.
144 pkg_dir, dist = self.create_dist(
145 dist_files=dist_files,
146 description='long description\r'
147 )
148 cmd = upload(dist)
149 cmd.ensure_finalized()
150 cmd.run()
151
152 headers = dict(self.last_open.req.headers)
153 self.assertEqual(headers['Content-length'], '2170')
154 self.assertIn(b'long description\r', self.last_open.req.data)
155 self.assertNotIn(b'long description\r\n', self.last_open.req.data)
156
Antoine Pitrou077c9562014-06-18 23:07:46 -0400157 def test_upload_fails(self):
158 self.next_msg = "Not Found"
159 self.next_code = 404
160 self.assertRaises(DistutilsError, self.test_upload)
161
Andrew M. Kuchlingaac5c862008-05-11 14:00:00 +0000162def test_suite():
163 return unittest.makeSuite(uploadTestCase)
164
165if __name__ == "__main__":
Éric Araujo54274ad2011-02-03 00:12:18 +0000166 run_unittest(test_suite())