Tarek Ziadé | f14c7fc | 2010-01-24 00:33:32 +0000 | [diff] [blame] | 1 | # -*- encoding: utf8 -*- |
Éric Araujo | 54274ad | 2011-02-03 00:12:18 +0000 | [diff] [blame] | 2 | """Tests for distutils.command.upload.""" |
Andrew M. Kuchling | aac5c86 | 2008-05-11 14:00:00 +0000 | [diff] [blame] | 3 | import os |
| 4 | import unittest |
Éric Araujo | 54274ad | 2011-02-03 00:12:18 +0000 | [diff] [blame] | 5 | from test.test_support import run_unittest |
Andrew M. Kuchling | aac5c86 | 2008-05-11 14:00:00 +0000 | [diff] [blame] | 6 | |
Tarek Ziadé | a1cc040 | 2009-06-15 23:30:13 +0000 | [diff] [blame] | 7 | from distutils.command import upload as upload_mod |
Andrew M. Kuchling | aac5c86 | 2008-05-11 14:00:00 +0000 | [diff] [blame] | 8 | from distutils.command.upload import upload |
| 9 | from distutils.core import Distribution |
Antoine Pitrou | 077c956 | 2014-06-18 23:07:46 -0400 | [diff] [blame] | 10 | from distutils.errors import DistutilsError |
Andrew M. Kuchling | aac5c86 | 2008-05-11 14:00:00 +0000 | [diff] [blame] | 11 | |
Andrew M. Kuchling | aac5c86 | 2008-05-11 14:00:00 +0000 | [diff] [blame] | 12 | from distutils.tests.test_config import PYPIRC, PyPIRCCommandTestCase |
| 13 | |
Tarek Ziadé | 2421d56 | 2009-12-20 23:23:34 +0000 | [diff] [blame] | 14 | PYPIRC_LONG_PASSWORD = """\ |
| 15 | [distutils] |
| 16 | |
| 17 | index-servers = |
| 18 | server1 |
| 19 | server2 |
| 20 | |
| 21 | [server1] |
| 22 | username:me |
| 23 | password:aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa |
| 24 | |
| 25 | [server2] |
| 26 | username:meagain |
| 27 | password: secret |
| 28 | realm:acme |
| 29 | repository:http://another.pypi/ |
| 30 | """ |
| 31 | |
| 32 | |
Tarek Ziadé | 1a240fb | 2009-01-08 23:56:31 +0000 | [diff] [blame] | 33 | PYPIRC_NOPASSWORD = """\ |
| 34 | [distutils] |
| 35 | |
| 36 | index-servers = |
| 37 | server1 |
| 38 | |
| 39 | [server1] |
| 40 | username:me |
| 41 | """ |
| 42 | |
Tarek Ziadé | a1cc040 | 2009-06-15 23:30:13 +0000 | [diff] [blame] | 43 | class FakeOpen(object): |
Tarek Ziadé | e899b71 | 2009-03-31 20:53:55 +0000 | [diff] [blame] | 44 | |
Antoine Pitrou | 077c956 | 2014-06-18 23:07:46 -0400 | [diff] [blame] | 45 | def __init__(self, url, msg=None, code=None): |
Tarek Ziadé | a1cc040 | 2009-06-15 23:30:13 +0000 | [diff] [blame] | 46 | self.url = url |
| 47 | if not isinstance(url, str): |
| 48 | self.req = url |
| 49 | else: |
| 50 | self.req = None |
Antoine Pitrou | 077c956 | 2014-06-18 23:07:46 -0400 | [diff] [blame] | 51 | self.msg = msg or 'OK' |
| 52 | self.code = code or 200 |
Tarek Ziadé | e899b71 | 2009-03-31 20:53:55 +0000 | [diff] [blame] | 53 | |
Tarek Ziadé | a1cc040 | 2009-06-15 23:30:13 +0000 | [diff] [blame] | 54 | def getcode(self): |
Antoine Pitrou | 077c956 | 2014-06-18 23:07:46 -0400 | [diff] [blame] | 55 | return self.code |
Tarek Ziadé | e899b71 | 2009-03-31 20:53:55 +0000 | [diff] [blame] | 56 | |
Tarek Ziadé | 1a240fb | 2009-01-08 23:56:31 +0000 | [diff] [blame] | 57 | |
Andrew M. Kuchling | aac5c86 | 2008-05-11 14:00:00 +0000 | [diff] [blame] | 58 | class uploadTestCase(PyPIRCCommandTestCase): |
| 59 | |
Tarek Ziadé | e899b71 | 2009-03-31 20:53:55 +0000 | [diff] [blame] | 60 | def setUp(self): |
| 61 | super(uploadTestCase, self).setUp() |
Tarek Ziadé | a1cc040 | 2009-06-15 23:30:13 +0000 | [diff] [blame] | 62 | self.old_open = upload_mod.urlopen |
| 63 | upload_mod.urlopen = self._urlopen |
| 64 | self.last_open = None |
Antoine Pitrou | 077c956 | 2014-06-18 23:07:46 -0400 | [diff] [blame] | 65 | self.next_msg = None |
| 66 | self.next_code = None |
Tarek Ziadé | e899b71 | 2009-03-31 20:53:55 +0000 | [diff] [blame] | 67 | |
| 68 | def tearDown(self): |
Tarek Ziadé | a1cc040 | 2009-06-15 23:30:13 +0000 | [diff] [blame] | 69 | upload_mod.urlopen = self.old_open |
Tarek Ziadé | e899b71 | 2009-03-31 20:53:55 +0000 | [diff] [blame] | 70 | super(uploadTestCase, self).tearDown() |
| 71 | |
Tarek Ziadé | a1cc040 | 2009-06-15 23:30:13 +0000 | [diff] [blame] | 72 | def _urlopen(self, url): |
Antoine Pitrou | 077c956 | 2014-06-18 23:07:46 -0400 | [diff] [blame] | 73 | self.last_open = FakeOpen(url, msg=self.next_msg, code=self.next_code) |
Tarek Ziadé | a1cc040 | 2009-06-15 23:30:13 +0000 | [diff] [blame] | 74 | return self.last_open |
| 75 | |
Andrew M. Kuchling | aac5c86 | 2008-05-11 14:00:00 +0000 | [diff] [blame] | 76 | def test_finalize_options(self): |
| 77 | |
| 78 | # new format |
Tarek Ziadé | e899b71 | 2009-03-31 20:53:55 +0000 | [diff] [blame] | 79 | self.write_file(self.rc, PYPIRC) |
Andrew M. Kuchling | aac5c86 | 2008-05-11 14:00:00 +0000 | [diff] [blame] | 80 | dist = Distribution() |
| 81 | cmd = upload(dist) |
| 82 | cmd.finalize_options() |
| 83 | for attr, waited in (('username', 'me'), ('password', 'secret'), |
| 84 | ('realm', 'pypi'), |
Donald Stufft | 692497a | 2016-08-03 18:58:12 -0400 | [diff] [blame] | 85 | ('repository', 'https://upload.pypi.org/legacy/')): |
Ezio Melotti | 2623a37 | 2010-11-21 13:34:58 +0000 | [diff] [blame] | 86 | self.assertEqual(getattr(cmd, attr), waited) |
Andrew M. Kuchling | aac5c86 | 2008-05-11 14:00:00 +0000 | [diff] [blame] | 87 | |
Tarek Ziadé | 1a240fb | 2009-01-08 23:56:31 +0000 | [diff] [blame] | 88 | def test_saved_password(self): |
| 89 | # file with no password |
Tarek Ziadé | e899b71 | 2009-03-31 20:53:55 +0000 | [diff] [blame] | 90 | self.write_file(self.rc, PYPIRC_NOPASSWORD) |
Tarek Ziadé | 1a240fb | 2009-01-08 23:56:31 +0000 | [diff] [blame] | 91 | |
| 92 | # make sure it passes |
| 93 | dist = Distribution() |
| 94 | cmd = upload(dist) |
| 95 | cmd.finalize_options() |
Ezio Melotti | 2623a37 | 2010-11-21 13:34:58 +0000 | [diff] [blame] | 96 | self.assertEqual(cmd.password, None) |
Tarek Ziadé | 1a240fb | 2009-01-08 23:56:31 +0000 | [diff] [blame] | 97 | |
| 98 | # make sure we get it as well, if another command |
| 99 | # initialized it at the dist level |
| 100 | dist.password = 'xxx' |
| 101 | cmd = upload(dist) |
| 102 | cmd.finalize_options() |
Ezio Melotti | 2623a37 | 2010-11-21 13:34:58 +0000 | [diff] [blame] | 103 | self.assertEqual(cmd.password, 'xxx') |
Andrew M. Kuchling | aac5c86 | 2008-05-11 14:00:00 +0000 | [diff] [blame] | 104 | |
Tarek Ziadé | e899b71 | 2009-03-31 20:53:55 +0000 | [diff] [blame] | 105 | def test_upload(self): |
| 106 | tmp = self.mkdtemp() |
| 107 | path = os.path.join(tmp, 'xxx') |
| 108 | self.write_file(path) |
| 109 | command, pyversion, filename = 'xxx', '2.6', path |
| 110 | dist_files = [(command, pyversion, filename)] |
Tarek Ziadé | 2421d56 | 2009-12-20 23:23:34 +0000 | [diff] [blame] | 111 | self.write_file(self.rc, PYPIRC_LONG_PASSWORD) |
Tarek Ziadé | e899b71 | 2009-03-31 20:53:55 +0000 | [diff] [blame] | 112 | |
| 113 | # lets run it |
Tarek Ziadé | f14c7fc | 2010-01-24 00:33:32 +0000 | [diff] [blame] | 114 | pkg_dir, dist = self.create_dist(dist_files=dist_files, author=u'dédé') |
Tarek Ziadé | e899b71 | 2009-03-31 20:53:55 +0000 | [diff] [blame] | 115 | cmd = upload(dist) |
| 116 | cmd.ensure_finalized() |
| 117 | cmd.run() |
| 118 | |
| 119 | # what did we send ? |
Tarek Ziadé | f14c7fc | 2010-01-24 00:33:32 +0000 | [diff] [blame] | 120 | self.assertIn('dédé', self.last_open.req.data) |
Tarek Ziadé | a1cc040 | 2009-06-15 23:30:13 +0000 | [diff] [blame] | 121 | headers = dict(self.last_open.req.headers) |
R David Murray | 9ad23c6 | 2014-09-27 16:59:04 -0400 | [diff] [blame] | 122 | self.assertEqual(headers['Content-length'], '2159') |
Benjamin Peterson | 5c8da86 | 2009-06-30 22:57:08 +0000 | [diff] [blame] | 123 | self.assertTrue(headers['Content-type'].startswith('multipart/form-data')) |
Ezio Melotti | 2623a37 | 2010-11-21 13:34:58 +0000 | [diff] [blame] | 124 | self.assertEqual(self.last_open.req.get_method(), 'POST') |
| 125 | self.assertEqual(self.last_open.req.get_full_url(), |
Donald Stufft | 692497a | 2016-08-03 18:58:12 -0400 | [diff] [blame] | 126 | 'https://upload.pypi.org/legacy/') |
Serhiy Storchaka | 25a23ef | 2013-11-17 00:29:27 +0200 | [diff] [blame] | 127 | self.assertIn('xxx', self.last_open.req.data) |
Tarek Ziadé | 2421d56 | 2009-12-20 23:23:34 +0000 | [diff] [blame] | 128 | auth = self.last_open.req.headers['Authorization'] |
Serhiy Storchaka | 25a23ef | 2013-11-17 00:29:27 +0200 | [diff] [blame] | 129 | self.assertNotIn('\n', auth) |
Tarek Ziadé | e899b71 | 2009-03-31 20:53:55 +0000 | [diff] [blame] | 130 | |
Bo Bayles | f5a7935 | 2018-01-29 08:31:32 -0600 | [diff] [blame] | 131 | # bpo-32304: archives whose last byte was b'\r' were corrupted due to |
| 132 | # normalization intended for Mac OS 9. |
| 133 | def test_upload_correct_cr(self): |
| 134 | # content that ends with \r should not be modified. |
| 135 | tmp = self.mkdtemp() |
| 136 | path = os.path.join(tmp, 'xxx') |
| 137 | self.write_file(path, content='yy\r') |
| 138 | command, pyversion, filename = 'xxx', '2.6', path |
| 139 | dist_files = [(command, pyversion, filename)] |
| 140 | self.write_file(self.rc, PYPIRC_LONG_PASSWORD) |
| 141 | |
| 142 | # other fields that ended with \r used to be modified, now are |
| 143 | # preserved. |
| 144 | pkg_dir, dist = self.create_dist( |
| 145 | dist_files=dist_files, |
| 146 | description='long description\r' |
| 147 | ) |
| 148 | cmd = upload(dist) |
| 149 | cmd.ensure_finalized() |
| 150 | cmd.run() |
| 151 | |
| 152 | headers = dict(self.last_open.req.headers) |
| 153 | self.assertEqual(headers['Content-length'], '2170') |
| 154 | self.assertIn(b'long description\r', self.last_open.req.data) |
| 155 | self.assertNotIn(b'long description\r\n', self.last_open.req.data) |
| 156 | |
Antoine Pitrou | 077c956 | 2014-06-18 23:07:46 -0400 | [diff] [blame] | 157 | def test_upload_fails(self): |
| 158 | self.next_msg = "Not Found" |
| 159 | self.next_code = 404 |
| 160 | self.assertRaises(DistutilsError, self.test_upload) |
| 161 | |
Andrew M. Kuchling | aac5c86 | 2008-05-11 14:00:00 +0000 | [diff] [blame] | 162 | def test_suite(): |
| 163 | return unittest.makeSuite(uploadTestCase) |
| 164 | |
| 165 | if __name__ == "__main__": |
Éric Araujo | 54274ad | 2011-02-03 00:12:18 +0000 | [diff] [blame] | 166 | run_unittest(test_suite()) |