Issue #29327: Fixed a crash when pass the iterable keyword argument to sorted().
diff --git a/Lib/test/test_builtin.py b/Lib/test/test_builtin.py
index a792099..416316c 100644
--- a/Lib/test/test_builtin.py
+++ b/Lib/test/test_builtin.py
@@ -1627,6 +1627,16 @@
self.assertEqual(data, sorted(copy, reverse=1))
self.assertNotEqual(data, copy)
+ def test_bad_arguments(self):
+ # Issue #29327: The first argument is positional-only.
+ sorted([])
+ with self.assertRaises(TypeError):
+ sorted(iterable=[])
+ # Other arguments are keyword-only
+ sorted([], key=None)
+ with self.assertRaises(TypeError):
+ sorted([], None)
+
def test_inputtypes(self):
s = 'abracadabra'
types = [list, tuple, str]
diff --git a/Misc/NEWS b/Misc/NEWS
index dfb42b6..138539b 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -10,6 +10,9 @@
Core and Builtins
-----------------
+- Issue #29327: Fixed a crash when pass the iterable keyword argument to
+ sorted().
+
- Issue #29034: Fix memory leak and use-after-free in os module (path_converter).
- Issue #29159: Fix regression in bytes(x) when x.__index__() raises Exception.
diff --git a/Python/bltinmodule.c b/Python/bltinmodule.c
index 69e5f08..8acdfc3 100644
--- a/Python/bltinmodule.c
+++ b/Python/bltinmodule.c
@@ -2123,7 +2123,7 @@
{
PyObject *newlist, *v, *seq, *keyfunc=NULL, **newargs;
PyObject *callable;
- static char *kwlist[] = {"iterable", "key", "reverse", 0};
+ static char *kwlist[] = {"", "key", "reverse", 0};
int reverse;
Py_ssize_t nargs;
@@ -2142,6 +2142,7 @@
return NULL;
}
+ assert(PyTuple_GET_SIZE(args) >= 1);
newargs = &PyTuple_GET_ITEM(args, 1);
nargs = PyTuple_GET_SIZE(args) - 1;
v = _PyObject_FastCallDict(callable, newargs, nargs, kwds);