Issue #29337: Fixed possible BytesWarning when compare the code objects.
Warnings could be emitted at compile time.
diff --git a/Lib/test/test_compile.py b/Lib/test/test_compile.py
index 409ec86..da1db15 100644
--- a/Lib/test/test_compile.py
+++ b/Lib/test/test_compile.py
@@ -637,6 +637,7 @@
f1 = ns['f1']
f2 = ns['f2']
self.assertIsNot(f1.__code__, f2.__code__)
+ self.assertNotEqual(f1.__code__, f2.__code__)
self.check_constant(f1, const1)
self.check_constant(f2, const2)
self.assertEqual(repr(f1()), repr(const1))
@@ -645,6 +646,8 @@
check_different_constants(0, 0.0)
check_different_constants(+0.0, -0.0)
check_different_constants((0,), (0.0,))
+ check_different_constants('a', b'a')
+ check_different_constants(('a',), (b'a',))
# check_different_constants() cannot be used because repr(-0j) is
# '(-0-0j)', but when '(-0-0j)' is evaluated to 0j: we loose the sign.
diff --git a/Misc/NEWS b/Misc/NEWS
index 414369c..2b319ec 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -10,6 +10,9 @@
Core and Builtins
-----------------
+- Issue #29337: Fixed possible BytesWarning when compare the code objects.
+ Warnings could be emitted at compile time.
+
- Issue #29327: Fixed a crash when pass the iterable keyword argument to
sorted().
diff --git a/Objects/codeobject.c b/Objects/codeobject.c
index f7f91a8..0d8a675 100644
--- a/Objects/codeobject.c
+++ b/Objects/codeobject.c
@@ -545,7 +545,7 @@
PyTuple_SET_ITEM(tuple, i, item_key);
}
- key = PyTuple_Pack(3, Py_TYPE(op), op, tuple);
+ key = PyTuple_Pack(2, tuple, op);
Py_DECREF(tuple);
}
else if (PyFrozenSet_CheckExact(op)) {
@@ -579,7 +579,7 @@
if (set == NULL)
return NULL;
- key = PyTuple_Pack(3, Py_TYPE(op), op, set);
+ key = PyTuple_Pack(2, set, op);
Py_DECREF(set);
return key;
}
@@ -590,7 +590,7 @@
if (obj_id == NULL)
return NULL;
- key = PyTuple_Pack(3, Py_TYPE(op), op, obj_id);
+ key = PyTuple_Pack(2, obj_id, op);
Py_DECREF(obj_id);
}
return key;