blob: 76a0edbcc2bcacf32723d97cbadd8bc726516c07 [file] [log] [blame]
Guido van Rossumd8faa362007-04-27 19:54:29 +00001/* Peephole optimizations for bytecode compiler. */
Thomas Wouters00ee7ba2006-08-21 19:07:27 +00002
3#include "Python.h"
4
5#include "Python-ast.h"
6#include "node.h"
Thomas Wouters00ee7ba2006-08-21 19:07:27 +00007#include "ast.h"
8#include "code.h"
Thomas Wouters00ee7ba2006-08-21 19:07:27 +00009#include "symtable.h"
10#include "opcode.h"
Serhiy Storchakab0f80b02016-05-24 09:15:14 +030011#include "wordcode_helpers.h"
Thomas Wouters00ee7ba2006-08-21 19:07:27 +000012
Antoine Pitrouf95a1b32010-05-09 15:52:27 +000013#define UNCONDITIONAL_JUMP(op) (op==JUMP_ABSOLUTE || op==JUMP_FORWARD)
Jeffrey Yasskin9de7ec72009-02-25 02:25:04 +000014#define CONDITIONAL_JUMP(op) (op==POP_JUMP_IF_FALSE || op==POP_JUMP_IF_TRUE \
Antoine Pitrouf95a1b32010-05-09 15:52:27 +000015 || op==JUMP_IF_FALSE_OR_POP || op==JUMP_IF_TRUE_OR_POP)
Jeffrey Yasskin9de7ec72009-02-25 02:25:04 +000016#define ABSOLUTE_JUMP(op) (op==JUMP_ABSOLUTE || op==CONTINUE_LOOP \
Antoine Pitrouf95a1b32010-05-09 15:52:27 +000017 || op==POP_JUMP_IF_FALSE || op==POP_JUMP_IF_TRUE \
18 || op==JUMP_IF_FALSE_OR_POP || op==JUMP_IF_TRUE_OR_POP)
Jeffrey Yasskin9de7ec72009-02-25 02:25:04 +000019#define JUMPS_ON_TRUE(op) (op==POP_JUMP_IF_TRUE || op==JUMP_IF_TRUE_OR_POP)
Serhiy Storchakaab874002016-09-11 13:48:15 +030020#define GETJUMPTGT(arr, i) (get_arg(arr, i) / sizeof(_Py_CODEUNIT) + \
21 (ABSOLUTE_JUMP(_Py_OPCODE(arr[i])) ? 0 : i+1))
Serhiy Storchakab0f80b02016-05-24 09:15:14 +030022#define ISBASICBLOCK(blocks, start, end) \
23 (blocks[start]==blocks[end])
Thomas Wouters00ee7ba2006-08-21 19:07:27 +000024
Antoine Pitrou17b880a2011-03-11 17:27:02 +010025
Serhiy Storchakab0f80b02016-05-24 09:15:14 +030026/* Scans back N consecutive LOAD_CONST instructions, skipping NOPs,
27 returns index of the Nth last's LOAD_CONST's EXTENDED_ARG prefix.
28 Callers are responsible to check CONST_STACK_LEN beforehand.
29*/
30static Py_ssize_t
Serhiy Storchakaab874002016-09-11 13:48:15 +030031lastn_const_start(const _Py_CODEUNIT *codestr, Py_ssize_t i, Py_ssize_t n)
Serhiy Storchakab0f80b02016-05-24 09:15:14 +030032{
Serhiy Storchakaab874002016-09-11 13:48:15 +030033 assert(n > 0);
Serhiy Storchakab0f80b02016-05-24 09:15:14 +030034 for (;;) {
Serhiy Storchakaab874002016-09-11 13:48:15 +030035 i--;
Serhiy Storchakab0f80b02016-05-24 09:15:14 +030036 assert(i >= 0);
Serhiy Storchakaab874002016-09-11 13:48:15 +030037 if (_Py_OPCODE(codestr[i]) == LOAD_CONST) {
Serhiy Storchakab0f80b02016-05-24 09:15:14 +030038 if (!--n) {
Serhiy Storchakaab874002016-09-11 13:48:15 +030039 while (i > 0 && _Py_OPCODE(codestr[i-1]) == EXTENDED_ARG) {
40 i--;
Serhiy Storchakab0f80b02016-05-24 09:15:14 +030041 }
42 return i;
43 }
44 }
45 else {
INADA Naoki87010e82017-12-18 15:52:54 +090046 assert(_Py_OPCODE(codestr[i]) == EXTENDED_ARG);
Serhiy Storchakab0f80b02016-05-24 09:15:14 +030047 }
48 }
49}
Antoine Pitrou17b880a2011-03-11 17:27:02 +010050
Serhiy Storchakab0f80b02016-05-24 09:15:14 +030051/* Scans through EXTENDED ARGs, seeking the index of the effective opcode */
52static Py_ssize_t
Serhiy Storchakaab874002016-09-11 13:48:15 +030053find_op(const _Py_CODEUNIT *codestr, Py_ssize_t i)
Serhiy Storchakab0f80b02016-05-24 09:15:14 +030054{
Serhiy Storchakaab874002016-09-11 13:48:15 +030055 while (_Py_OPCODE(codestr[i]) == EXTENDED_ARG) {
56 i++;
Serhiy Storchakab0f80b02016-05-24 09:15:14 +030057 }
58 return i;
59}
Antoine Pitrou17b880a2011-03-11 17:27:02 +010060
Serhiy Storchakab0f80b02016-05-24 09:15:14 +030061/* Given the index of the effective opcode,
62 scan back to construct the oparg with EXTENDED_ARG */
63static unsigned int
Serhiy Storchakaab874002016-09-11 13:48:15 +030064get_arg(const _Py_CODEUNIT *codestr, Py_ssize_t i)
Serhiy Storchakab0f80b02016-05-24 09:15:14 +030065{
Serhiy Storchakaab874002016-09-11 13:48:15 +030066 _Py_CODEUNIT word;
67 unsigned int oparg = _Py_OPARG(codestr[i]);
68 if (i >= 1 && _Py_OPCODE(word = codestr[i-1]) == EXTENDED_ARG) {
69 oparg |= _Py_OPARG(word) << 8;
70 if (i >= 2 && _Py_OPCODE(word = codestr[i-2]) == EXTENDED_ARG) {
71 oparg |= _Py_OPARG(word) << 16;
72 if (i >= 3 && _Py_OPCODE(word = codestr[i-3]) == EXTENDED_ARG) {
73 oparg |= _Py_OPARG(word) << 24;
Serhiy Storchakab0f80b02016-05-24 09:15:14 +030074 }
75 }
76 }
77 return oparg;
78}
79
Serhiy Storchakaab874002016-09-11 13:48:15 +030080/* Fill the region with NOPs. */
81static void
82fill_nops(_Py_CODEUNIT *codestr, Py_ssize_t start, Py_ssize_t end)
83{
84 memset(codestr + start, NOP, (end - start) * sizeof(_Py_CODEUNIT));
85}
86
Serhiy Storchakab0f80b02016-05-24 09:15:14 +030087/* Given the index of the effective opcode,
88 attempt to replace the argument, taking into account EXTENDED_ARG.
89 Returns -1 on failure, or the new op index on success */
90static Py_ssize_t
Serhiy Storchakaab874002016-09-11 13:48:15 +030091set_arg(_Py_CODEUNIT *codestr, Py_ssize_t i, unsigned int oparg)
Serhiy Storchakab0f80b02016-05-24 09:15:14 +030092{
93 unsigned int curarg = get_arg(codestr, i);
94 int curilen, newilen;
95 if (curarg == oparg)
96 return i;
97 curilen = instrsize(curarg);
98 newilen = instrsize(oparg);
99 if (curilen < newilen) {
100 return -1;
101 }
102
Serhiy Storchakaab874002016-09-11 13:48:15 +0300103 write_op_arg(codestr + i + 1 - curilen, _Py_OPCODE(codestr[i]), oparg, newilen);
104 fill_nops(codestr, i + 1 - curilen + newilen, i + 1);
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300105 return i-curilen+newilen;
106}
107
108/* Attempt to write op/arg at end of specified region of memory.
109 Preceding memory in the region is overwritten with NOPs.
110 Returns -1 on failure, op index on success */
111static Py_ssize_t
Serhiy Storchakaab874002016-09-11 13:48:15 +0300112copy_op_arg(_Py_CODEUNIT *codestr, Py_ssize_t i, unsigned char op,
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300113 unsigned int oparg, Py_ssize_t maxi)
114{
115 int ilen = instrsize(oparg);
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300116 if (i + ilen > maxi) {
117 return -1;
118 }
119 write_op_arg(codestr + maxi - ilen, op, oparg, ilen);
Serhiy Storchakaab874002016-09-11 13:48:15 +0300120 fill_nops(codestr, i, maxi - ilen);
121 return maxi - 1;
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300122}
123
124/* Replace LOAD_CONST c1, LOAD_CONST c2 ... LOAD_CONST cn, BUILD_TUPLE n
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000125 with LOAD_CONST (c1, c2, ... cn).
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000126 The consts table must still be in list form so that the
127 new constant (c1, c2, ... cn) can be appended.
128 Called with codestr pointing to the first LOAD_CONST.
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000129*/
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300130static Py_ssize_t
Serhiy Storchakaab874002016-09-11 13:48:15 +0300131fold_tuple_on_constants(_Py_CODEUNIT *codestr, Py_ssize_t c_start,
INADA Naoki87010e82017-12-18 15:52:54 +0900132 Py_ssize_t opcode_end, PyObject *consts, int n)
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000133{
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000134 /* Pre-conditions */
135 assert(PyList_CheckExact(consts));
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000136
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000137 /* Buildup new tuple of constants */
INADA Naoki87010e82017-12-18 15:52:54 +0900138 PyObject *newconst = PyTuple_New(n);
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300139 if (newconst == NULL) {
140 return -1;
141 }
INADA Naoki87010e82017-12-18 15:52:54 +0900142
143 for (Py_ssize_t i = 0, pos = c_start; i < n; i++, pos++) {
144 assert(pos < opcode_end);
145 pos = find_op(codestr, pos);
146 assert(_Py_OPCODE(codestr[pos]) == LOAD_CONST);
147
148 unsigned int arg = get_arg(codestr, pos);
149 PyObject *constant = PyList_GET_ITEM(consts, arg);
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000150 Py_INCREF(constant);
151 PyTuple_SET_ITEM(newconst, i, constant);
152 }
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000153
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000154 /* Append folded constant onto consts */
155 if (PyList_Append(consts, newconst)) {
156 Py_DECREF(newconst);
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300157 return -1;
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000158 }
159 Py_DECREF(newconst);
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000160
INADA Naoki87010e82017-12-18 15:52:54 +0900161 return copy_op_arg(codestr, c_start, LOAD_CONST,
162 PyList_GET_SIZE(consts)-1, opcode_end);
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000163}
164
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000165static unsigned int *
Serhiy Storchakaab874002016-09-11 13:48:15 +0300166markblocks(_Py_CODEUNIT *code, Py_ssize_t len)
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000167{
Serhiy Storchaka1a1ff292015-02-16 13:28:22 +0200168 unsigned int *blocks = PyMem_New(unsigned int, len);
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300169 int i, j, opcode, blockcnt = 0;
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000170
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000171 if (blocks == NULL) {
172 PyErr_NoMemory();
173 return NULL;
174 }
175 memset(blocks, 0, len*sizeof(int));
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000176
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000177 /* Mark labels in the first pass */
Serhiy Storchakaab874002016-09-11 13:48:15 +0300178 for (i = 0; i < len; i++) {
179 opcode = _Py_OPCODE(code[i]);
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000180 switch (opcode) {
181 case FOR_ITER:
182 case JUMP_FORWARD:
183 case JUMP_IF_FALSE_OR_POP:
184 case JUMP_IF_TRUE_OR_POP:
185 case POP_JUMP_IF_FALSE:
186 case POP_JUMP_IF_TRUE:
187 case JUMP_ABSOLUTE:
188 case CONTINUE_LOOP:
189 case SETUP_LOOP:
190 case SETUP_EXCEPT:
191 case SETUP_FINALLY:
192 case SETUP_WITH:
Yury Selivanov75445082015-05-11 22:57:16 -0400193 case SETUP_ASYNC_WITH:
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000194 j = GETJUMPTGT(code, i);
Serhiy Storchakaab874002016-09-11 13:48:15 +0300195 assert(j < len);
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000196 blocks[j] = 1;
197 break;
198 }
199 }
200 /* Build block numbers in the second pass */
Serhiy Storchakaab874002016-09-11 13:48:15 +0300201 for (i = 0; i < len; i++) {
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000202 blockcnt += blocks[i]; /* increment blockcnt over labels */
203 blocks[i] = blockcnt;
204 }
205 return blocks;
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000206}
207
208/* Perform basic peephole optimizations to components of a code object.
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000209 The consts object should still be in list form to allow new constants
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000210 to be appended.
211
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300212 To keep the optimizer simple, it bails when the lineno table has complex
213 encoding for gaps >= 255.
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000214
Martin Panter46f50722016-05-26 05:35:26 +0000215 Optimizations are restricted to simple transformations occurring within a
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000216 single basic block. All transformations keep the code size the same or
217 smaller. For those that reduce size, the gaps are initially filled with
218 NOPs. Later those NOPs are removed and the jump addresses retargeted in
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300219 a single pass. */
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000220
221PyObject *
222PyCode_Optimize(PyObject *code, PyObject* consts, PyObject *names,
Victor Stinnerf3914eb2016-01-20 12:16:21 +0100223 PyObject *lnotab_obj)
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000224{
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300225 Py_ssize_t h, i, nexti, op_start, codelen, tgt;
226 unsigned int j, nops;
227 unsigned char opcode, nextop;
Serhiy Storchakaab874002016-09-11 13:48:15 +0300228 _Py_CODEUNIT *codestr = NULL;
Victor Stinnerf3914eb2016-01-20 12:16:21 +0100229 unsigned char *lnotab;
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300230 unsigned int cum_orig_offset, last_offset;
Serhiy Storchaka67559bf2015-02-16 21:13:24 +0200231 Py_ssize_t tabsiz;
INADA Naoki87010e82017-12-18 15:52:54 +0900232 // Count runs of consecutive LOAD_CONSTs
233 unsigned int cumlc = 0, lastlc = 0;
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000234 unsigned int *blocks = NULL;
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000235
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000236 /* Bail out if an exception is set */
237 if (PyErr_Occurred())
238 goto exitError;
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000239
Victor Stinnerf3914eb2016-01-20 12:16:21 +0100240 /* Bypass optimization when the lnotab table is too complex */
241 assert(PyBytes_Check(lnotab_obj));
242 lnotab = (unsigned char*)PyBytes_AS_STRING(lnotab_obj);
243 tabsiz = PyBytes_GET_SIZE(lnotab_obj);
244 assert(tabsiz == 0 || Py_REFCNT(lnotab_obj) == 1);
245 if (memchr(lnotab, 255, tabsiz) != NULL) {
246 /* 255 value are used for multibyte bytecode instructions */
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000247 goto exitUnchanged;
Victor Stinnerf3914eb2016-01-20 12:16:21 +0100248 }
249 /* Note: -128 and 127 special values for line number delta are ok,
250 the peephole optimizer doesn't modify line numbers. */
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000251
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000252 assert(PyBytes_Check(code));
253 codelen = PyBytes_GET_SIZE(code);
Serhiy Storchakaab874002016-09-11 13:48:15 +0300254 assert(codelen % sizeof(_Py_CODEUNIT) == 0);
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000255
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000256 /* Make a modifiable copy of the code string */
Serhiy Storchakaab874002016-09-11 13:48:15 +0300257 codestr = (_Py_CODEUNIT *)PyMem_Malloc(codelen);
Victor Stinnere0af3a82013-07-09 00:32:04 +0200258 if (codestr == NULL) {
259 PyErr_NoMemory();
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000260 goto exitError;
Victor Stinnere0af3a82013-07-09 00:32:04 +0200261 }
Serhiy Storchakaab874002016-09-11 13:48:15 +0300262 memcpy(codestr, PyBytes_AS_STRING(code), codelen);
263 codelen /= sizeof(_Py_CODEUNIT);
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000264
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000265 blocks = markblocks(codestr, codelen);
266 if (blocks == NULL)
267 goto exitError;
268 assert(PyList_Check(consts));
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000269
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300270 for (i=find_op(codestr, 0) ; i<codelen ; i=nexti) {
Serhiy Storchakaa1e9ab32016-09-11 15:19:12 +0300271 opcode = _Py_OPCODE(codestr[i]);
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300272 op_start = i;
Serhiy Storchakaab874002016-09-11 13:48:15 +0300273 while (op_start >= 1 && _Py_OPCODE(codestr[op_start-1]) == EXTENDED_ARG) {
274 op_start--;
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300275 }
276
Serhiy Storchakaab874002016-09-11 13:48:15 +0300277 nexti = i + 1;
278 while (nexti < codelen && _Py_OPCODE(codestr[nexti]) == EXTENDED_ARG)
279 nexti++;
280 nextop = nexti < codelen ? _Py_OPCODE(codestr[nexti]) : 0;
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000281
INADA Naoki87010e82017-12-18 15:52:54 +0900282 lastlc = cumlc;
283 cumlc = 0;
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000284
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000285 switch (opcode) {
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000286 /* Skip over LOAD_CONST trueconst
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300287 POP_JUMP_IF_FALSE xx. This improves
288 "while 1" performance. */
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000289 case LOAD_CONST:
INADA Naoki87010e82017-12-18 15:52:54 +0900290 cumlc = lastlc + 1;
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300291 if (nextop != POP_JUMP_IF_FALSE ||
Serhiy Storchakaab874002016-09-11 13:48:15 +0300292 !ISBASICBLOCK(blocks, op_start, i + 1) ||
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300293 !PyObject_IsTrue(PyList_GET_ITEM(consts, get_arg(codestr, i))))
294 break;
Serhiy Storchakaab874002016-09-11 13:48:15 +0300295 fill_nops(codestr, op_start, nexti + 1);
INADA Naoki87010e82017-12-18 15:52:54 +0900296 cumlc = 0;
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000297 break;
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000298
Serhiy Storchaka15a87282017-12-14 20:24:31 +0200299 /* Try to fold tuples of constants.
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000300 Skip over BUILD_SEQN 1 UNPACK_SEQN 1.
301 Replace BUILD_SEQN 2 UNPACK_SEQN 2 with ROT2.
302 Replace BUILD_SEQN 3 UNPACK_SEQN 3 with ROT3 ROT2. */
303 case BUILD_TUPLE:
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300304 j = get_arg(codestr, i);
INADA Naoki87010e82017-12-18 15:52:54 +0900305 if (j > 0 && lastlc >= j) {
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300306 h = lastn_const_start(codestr, op_start, j);
Serhiy Storchaka15a87282017-12-14 20:24:31 +0200307 if (ISBASICBLOCK(blocks, h, op_start)) {
INADA Naoki87010e82017-12-18 15:52:54 +0900308 h = fold_tuple_on_constants(codestr, h, i+1, consts, j);
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300309 break;
310 }
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000311 }
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300312 if (nextop != UNPACK_SEQUENCE ||
Serhiy Storchakaab874002016-09-11 13:48:15 +0300313 !ISBASICBLOCK(blocks, op_start, i + 1) ||
Serhiy Storchaka15a87282017-12-14 20:24:31 +0200314 j != get_arg(codestr, nexti))
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300315 break;
316 if (j < 2) {
Serhiy Storchakaab874002016-09-11 13:48:15 +0300317 fill_nops(codestr, op_start, nexti + 1);
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000318 } else if (j == 2) {
Serhiy Storchakaab874002016-09-11 13:48:15 +0300319 codestr[op_start] = PACKOPARG(ROT_TWO, 0);
320 fill_nops(codestr, op_start + 1, nexti + 1);
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000321 } else if (j == 3) {
Serhiy Storchakaab874002016-09-11 13:48:15 +0300322 codestr[op_start] = PACKOPARG(ROT_THREE, 0);
323 codestr[op_start + 1] = PACKOPARG(ROT_TWO, 0);
324 fill_nops(codestr, op_start + 2, nexti + 1);
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000325 }
326 break;
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000327
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000328 /* Simplify conditional jump to conditional jump where the
329 result of the first test implies the success of a similar
330 test or the failure of the opposite test.
331 Arises in code like:
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000332 "a and b or c"
333 "(a and b) and c"
Serhiy Storchaka36ff4512017-06-11 14:50:22 +0300334 "(a or b) or c"
335 "(a or b) and c"
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000336 x:JUMP_IF_FALSE_OR_POP y y:JUMP_IF_FALSE_OR_POP z
337 --> x:JUMP_IF_FALSE_OR_POP z
338 x:JUMP_IF_FALSE_OR_POP y y:JUMP_IF_TRUE_OR_POP z
Serhiy Storchakaab874002016-09-11 13:48:15 +0300339 --> x:POP_JUMP_IF_FALSE y+1
340 where y+1 is the instruction following the second test.
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000341 */
342 case JUMP_IF_FALSE_OR_POP:
343 case JUMP_IF_TRUE_OR_POP:
Serhiy Storchakaab874002016-09-11 13:48:15 +0300344 h = get_arg(codestr, i) / sizeof(_Py_CODEUNIT);
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300345 tgt = find_op(codestr, h);
346
Serhiy Storchakaab874002016-09-11 13:48:15 +0300347 j = _Py_OPCODE(codestr[tgt]);
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000348 if (CONDITIONAL_JUMP(j)) {
Raymond Hettinger08eef3f2016-08-07 20:20:33 -0700349 /* NOTE: all possible jumps here are absolute. */
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000350 if (JUMPS_ON_TRUE(j) == JUMPS_ON_TRUE(opcode)) {
Raymond Hettinger08eef3f2016-08-07 20:20:33 -0700351 /* The second jump will be taken iff the first is.
352 The current opcode inherits its target's
353 stack effect */
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300354 h = set_arg(codestr, i, get_arg(codestr, tgt));
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000355 } else {
Raymond Hettinger08eef3f2016-08-07 20:20:33 -0700356 /* The second jump is not taken if the first is (so
357 jump past it), and all conditional jumps pop their
358 argument when they're not taken (so change the
359 first jump to pop its argument when it's taken). */
Serhiy Storchakaab874002016-09-11 13:48:15 +0300360 h = set_arg(codestr, i, (tgt + 1) * sizeof(_Py_CODEUNIT));
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300361 j = opcode == JUMP_IF_TRUE_OR_POP ?
362 POP_JUMP_IF_TRUE : POP_JUMP_IF_FALSE;
363 }
364
365 if (h >= 0) {
366 nexti = h;
Serhiy Storchakaab874002016-09-11 13:48:15 +0300367 codestr[nexti] = PACKOPARG(j, _Py_OPARG(codestr[nexti]));
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300368 break;
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000369 }
370 }
371 /* Intentional fallthrough */
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000372
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000373 /* Replace jumps to unconditional jumps */
374 case POP_JUMP_IF_FALSE:
375 case POP_JUMP_IF_TRUE:
376 case FOR_ITER:
377 case JUMP_FORWARD:
378 case JUMP_ABSOLUTE:
379 case CONTINUE_LOOP:
380 case SETUP_LOOP:
381 case SETUP_EXCEPT:
382 case SETUP_FINALLY:
383 case SETUP_WITH:
Yury Selivanov75445082015-05-11 22:57:16 -0400384 case SETUP_ASYNC_WITH:
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300385 h = GETJUMPTGT(codestr, i);
386 tgt = find_op(codestr, h);
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000387 /* Replace JUMP_* to a RETURN into just a RETURN */
388 if (UNCONDITIONAL_JUMP(opcode) &&
Serhiy Storchakaab874002016-09-11 13:48:15 +0300389 _Py_OPCODE(codestr[tgt]) == RETURN_VALUE) {
390 codestr[op_start] = PACKOPARG(RETURN_VALUE, 0);
391 fill_nops(codestr, op_start + 1, i + 1);
392 } else if (UNCONDITIONAL_JUMP(_Py_OPCODE(codestr[tgt]))) {
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300393 j = GETJUMPTGT(codestr, tgt);
394 if (opcode == JUMP_FORWARD) { /* JMP_ABS can go backwards */
395 opcode = JUMP_ABSOLUTE;
396 } else if (!ABSOLUTE_JUMP(opcode)) {
Serhiy Storchakaab874002016-09-11 13:48:15 +0300397 if ((Py_ssize_t)j < i + 1) {
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300398 break; /* No backward relative jumps */
399 }
Serhiy Storchakaab874002016-09-11 13:48:15 +0300400 j -= i + 1; /* Calc relative jump addr */
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300401 }
Serhiy Storchakaab874002016-09-11 13:48:15 +0300402 j *= sizeof(_Py_CODEUNIT);
403 copy_op_arg(codestr, op_start, opcode, j, i + 1);
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000404 }
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000405 break;
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000406
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300407 /* Remove unreachable ops after RETURN */
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000408 case RETURN_VALUE:
Serhiy Storchakaab874002016-09-11 13:48:15 +0300409 h = i + 1;
Serhiy Storchaka7db3c482016-10-25 09:30:43 +0300410 while (h < codelen && ISBASICBLOCK(blocks, i, h)) {
Serhiy Storchakaab874002016-09-11 13:48:15 +0300411 h++;
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300412 }
Serhiy Storchakaab874002016-09-11 13:48:15 +0300413 if (h > i + 1) {
Serhiy Storchaka7db3c482016-10-25 09:30:43 +0300414 fill_nops(codestr, i + 1, h);
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300415 nexti = find_op(codestr, h);
416 }
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000417 break;
418 }
419 }
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000420
Victor Stinnerf3914eb2016-01-20 12:16:21 +0100421 /* Fixup lnotab */
Serhiy Storchakaab874002016-09-11 13:48:15 +0300422 for (i = 0, nops = 0; i < codelen; i++) {
Serhiy Storchaka67559bf2015-02-16 21:13:24 +0200423 assert(i - nops <= INT_MAX);
Victor Stinnerf3914eb2016-01-20 12:16:21 +0100424 /* original code offset => new code offset */
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300425 blocks[i] = i - nops;
Serhiy Storchakaab874002016-09-11 13:48:15 +0300426 if (_Py_OPCODE(codestr[i]) == NOP)
427 nops++;
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000428 }
Victor Stinnerf3914eb2016-01-20 12:16:21 +0100429 cum_orig_offset = 0;
430 last_offset = 0;
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000431 for (i=0 ; i < tabsiz ; i+=2) {
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300432 unsigned int offset_delta, new_offset;
Victor Stinnerf3914eb2016-01-20 12:16:21 +0100433 cum_orig_offset += lnotab[i];
Serhiy Storchakaab874002016-09-11 13:48:15 +0300434 assert(cum_orig_offset % sizeof(_Py_CODEUNIT) == 0);
435 new_offset = blocks[cum_orig_offset / sizeof(_Py_CODEUNIT)] *
436 sizeof(_Py_CODEUNIT);
Victor Stinnerf3914eb2016-01-20 12:16:21 +0100437 offset_delta = new_offset - last_offset;
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300438 assert(offset_delta <= 255);
Victor Stinnerf3914eb2016-01-20 12:16:21 +0100439 lnotab[i] = (unsigned char)offset_delta;
440 last_offset = new_offset;
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000441 }
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000442
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000443 /* Remove NOPs and fixup jump targets */
Serhiy Storchakaab874002016-09-11 13:48:15 +0300444 for (op_start = i = h = 0; i < codelen; i++, op_start = i) {
445 j = _Py_OPARG(codestr[i]);
446 while (_Py_OPCODE(codestr[i]) == EXTENDED_ARG) {
447 i++;
448 j = j<<8 | _Py_OPARG(codestr[i]);
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300449 }
Serhiy Storchakaab874002016-09-11 13:48:15 +0300450 opcode = _Py_OPCODE(codestr[i]);
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000451 switch (opcode) {
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300452 case NOP:continue;
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000453
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000454 case JUMP_ABSOLUTE:
455 case CONTINUE_LOOP:
456 case POP_JUMP_IF_FALSE:
457 case POP_JUMP_IF_TRUE:
458 case JUMP_IF_FALSE_OR_POP:
459 case JUMP_IF_TRUE_OR_POP:
Serhiy Storchakaab874002016-09-11 13:48:15 +0300460 j = blocks[j / sizeof(_Py_CODEUNIT)] * sizeof(_Py_CODEUNIT);
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000461 break;
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000462
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000463 case FOR_ITER:
464 case JUMP_FORWARD:
465 case SETUP_LOOP:
466 case SETUP_EXCEPT:
467 case SETUP_FINALLY:
468 case SETUP_WITH:
Yury Selivanov75445082015-05-11 22:57:16 -0400469 case SETUP_ASYNC_WITH:
Serhiy Storchakaab874002016-09-11 13:48:15 +0300470 j = blocks[j / sizeof(_Py_CODEUNIT) + i + 1] - blocks[i] - 1;
471 j *= sizeof(_Py_CODEUNIT);
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000472 break;
473 }
Serhiy Storchakaab874002016-09-11 13:48:15 +0300474 nexti = i - op_start + 1;
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300475 if (instrsize(j) > nexti)
476 goto exitUnchanged;
477 /* If instrsize(j) < nexti, we'll emit EXTENDED_ARG 0 */
478 write_op_arg(codestr + h, opcode, j, nexti);
479 h += nexti;
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000480 }
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300481 assert(h + (Py_ssize_t)nops == codelen);
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000482
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000483 PyMem_Free(blocks);
Serhiy Storchakaab874002016-09-11 13:48:15 +0300484 code = PyBytes_FromStringAndSize((char *)codestr, h * sizeof(_Py_CODEUNIT));
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300485 PyMem_Free(codestr);
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000486 return code;
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000487
Alexandre Vassalotti6f828182009-07-21 02:51:58 +0000488 exitError:
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000489 code = NULL;
Alexandre Vassalotti6f828182009-07-21 02:51:58 +0000490
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000491 exitUnchanged:
Serhiy Storchakab0f80b02016-05-24 09:15:14 +0300492 Py_XINCREF(code);
Victor Stinnerf3914eb2016-01-20 12:16:21 +0100493 PyMem_Free(blocks);
Victor Stinnerf3914eb2016-01-20 12:16:21 +0100494 PyMem_Free(codestr);
Antoine Pitrouf95a1b32010-05-09 15:52:27 +0000495 return code;
Thomas Wouters00ee7ba2006-08-21 19:07:27 +0000496}