Guido van Rossum | d8faa36 | 2007-04-27 19:54:29 +0000 | [diff] [blame] | 1 | /* Peephole optimizations for bytecode compiler. */ |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 2 | |
| 3 | #include "Python.h" |
| 4 | |
| 5 | #include "Python-ast.h" |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 6 | #include "ast.h" |
| 7 | #include "code.h" |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 8 | #include "symtable.h" |
| 9 | #include "opcode.h" |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 10 | #include "wordcode_helpers.h" |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 11 | |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 12 | #define UNCONDITIONAL_JUMP(op) (op==JUMP_ABSOLUTE || op==JUMP_FORWARD) |
Jeffrey Yasskin | 9de7ec7 | 2009-02-25 02:25:04 +0000 | [diff] [blame] | 13 | #define CONDITIONAL_JUMP(op) (op==POP_JUMP_IF_FALSE || op==POP_JUMP_IF_TRUE \ |
Mark Shannon | 9af0e47 | 2020-01-14 10:12:45 +0000 | [diff] [blame] | 14 | || op==JUMP_IF_FALSE_OR_POP || op==JUMP_IF_TRUE_OR_POP || op==JUMP_IF_NOT_EXC_MATCH) |
Serhiy Storchaka | 520b7ae | 2018-02-22 23:33:30 +0200 | [diff] [blame] | 15 | #define ABSOLUTE_JUMP(op) (op==JUMP_ABSOLUTE \ |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 16 | || op==POP_JUMP_IF_FALSE || op==POP_JUMP_IF_TRUE \ |
Mark Shannon | 9af0e47 | 2020-01-14 10:12:45 +0000 | [diff] [blame] | 17 | || op==JUMP_IF_FALSE_OR_POP || op==JUMP_IF_TRUE_OR_POP || op==JUMP_IF_NOT_EXC_MATCH) |
Jeffrey Yasskin | 9de7ec7 | 2009-02-25 02:25:04 +0000 | [diff] [blame] | 18 | #define JUMPS_ON_TRUE(op) (op==POP_JUMP_IF_TRUE || op==JUMP_IF_TRUE_OR_POP) |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 19 | #define GETJUMPTGT(arr, i) (get_arg(arr, i) / sizeof(_Py_CODEUNIT) + \ |
| 20 | (ABSOLUTE_JUMP(_Py_OPCODE(arr[i])) ? 0 : i+1)) |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 21 | #define ISBASICBLOCK(blocks, start, end) \ |
| 22 | (blocks[start]==blocks[end]) |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 23 | |
Antoine Pitrou | 17b880a | 2011-03-11 17:27:02 +0100 | [diff] [blame] | 24 | |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 25 | /* Scans back N consecutive LOAD_CONST instructions, skipping NOPs, |
| 26 | returns index of the Nth last's LOAD_CONST's EXTENDED_ARG prefix. |
| 27 | Callers are responsible to check CONST_STACK_LEN beforehand. |
| 28 | */ |
| 29 | static Py_ssize_t |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 30 | lastn_const_start(const _Py_CODEUNIT *codestr, Py_ssize_t i, Py_ssize_t n) |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 31 | { |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 32 | assert(n > 0); |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 33 | for (;;) { |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 34 | i--; |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 35 | assert(i >= 0); |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 36 | if (_Py_OPCODE(codestr[i]) == LOAD_CONST) { |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 37 | if (!--n) { |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 38 | while (i > 0 && _Py_OPCODE(codestr[i-1]) == EXTENDED_ARG) { |
| 39 | i--; |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 40 | } |
| 41 | return i; |
| 42 | } |
| 43 | } |
| 44 | else { |
INADA Naoki | 87010e8 | 2017-12-18 15:52:54 +0900 | [diff] [blame] | 45 | assert(_Py_OPCODE(codestr[i]) == EXTENDED_ARG); |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 46 | } |
| 47 | } |
| 48 | } |
Antoine Pitrou | 17b880a | 2011-03-11 17:27:02 +0100 | [diff] [blame] | 49 | |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 50 | /* Scans through EXTENDED ARGs, seeking the index of the effective opcode */ |
| 51 | static Py_ssize_t |
Gregory P. Smith | 49fa4a9 | 2018-11-08 17:55:07 -0800 | [diff] [blame] | 52 | find_op(const _Py_CODEUNIT *codestr, Py_ssize_t codelen, Py_ssize_t i) |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 53 | { |
Gregory P. Smith | 49fa4a9 | 2018-11-08 17:55:07 -0800 | [diff] [blame] | 54 | while (i < codelen && _Py_OPCODE(codestr[i]) == EXTENDED_ARG) { |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 55 | i++; |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 56 | } |
| 57 | return i; |
| 58 | } |
Antoine Pitrou | 17b880a | 2011-03-11 17:27:02 +0100 | [diff] [blame] | 59 | |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 60 | /* Given the index of the effective opcode, |
| 61 | scan back to construct the oparg with EXTENDED_ARG */ |
| 62 | static unsigned int |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 63 | get_arg(const _Py_CODEUNIT *codestr, Py_ssize_t i) |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 64 | { |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 65 | _Py_CODEUNIT word; |
| 66 | unsigned int oparg = _Py_OPARG(codestr[i]); |
| 67 | if (i >= 1 && _Py_OPCODE(word = codestr[i-1]) == EXTENDED_ARG) { |
| 68 | oparg |= _Py_OPARG(word) << 8; |
| 69 | if (i >= 2 && _Py_OPCODE(word = codestr[i-2]) == EXTENDED_ARG) { |
| 70 | oparg |= _Py_OPARG(word) << 16; |
| 71 | if (i >= 3 && _Py_OPCODE(word = codestr[i-3]) == EXTENDED_ARG) { |
| 72 | oparg |= _Py_OPARG(word) << 24; |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 73 | } |
| 74 | } |
| 75 | } |
| 76 | return oparg; |
| 77 | } |
| 78 | |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 79 | /* Fill the region with NOPs. */ |
| 80 | static void |
| 81 | fill_nops(_Py_CODEUNIT *codestr, Py_ssize_t start, Py_ssize_t end) |
| 82 | { |
| 83 | memset(codestr + start, NOP, (end - start) * sizeof(_Py_CODEUNIT)); |
| 84 | } |
| 85 | |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 86 | /* Given the index of the effective opcode, |
| 87 | attempt to replace the argument, taking into account EXTENDED_ARG. |
| 88 | Returns -1 on failure, or the new op index on success */ |
| 89 | static Py_ssize_t |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 90 | set_arg(_Py_CODEUNIT *codestr, Py_ssize_t i, unsigned int oparg) |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 91 | { |
| 92 | unsigned int curarg = get_arg(codestr, i); |
| 93 | int curilen, newilen; |
| 94 | if (curarg == oparg) |
| 95 | return i; |
| 96 | curilen = instrsize(curarg); |
| 97 | newilen = instrsize(oparg); |
| 98 | if (curilen < newilen) { |
| 99 | return -1; |
| 100 | } |
| 101 | |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 102 | write_op_arg(codestr + i + 1 - curilen, _Py_OPCODE(codestr[i]), oparg, newilen); |
| 103 | fill_nops(codestr, i + 1 - curilen + newilen, i + 1); |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 104 | return i-curilen+newilen; |
| 105 | } |
| 106 | |
| 107 | /* Attempt to write op/arg at end of specified region of memory. |
| 108 | Preceding memory in the region is overwritten with NOPs. |
| 109 | Returns -1 on failure, op index on success */ |
| 110 | static Py_ssize_t |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 111 | copy_op_arg(_Py_CODEUNIT *codestr, Py_ssize_t i, unsigned char op, |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 112 | unsigned int oparg, Py_ssize_t maxi) |
| 113 | { |
| 114 | int ilen = instrsize(oparg); |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 115 | if (i + ilen > maxi) { |
| 116 | return -1; |
| 117 | } |
| 118 | write_op_arg(codestr + maxi - ilen, op, oparg, ilen); |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 119 | fill_nops(codestr, i, maxi - ilen); |
| 120 | return maxi - 1; |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 121 | } |
| 122 | |
| 123 | /* Replace LOAD_CONST c1, LOAD_CONST c2 ... LOAD_CONST cn, BUILD_TUPLE n |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 124 | with LOAD_CONST (c1, c2, ... cn). |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 125 | The consts table must still be in list form so that the |
| 126 | new constant (c1, c2, ... cn) can be appended. |
| 127 | Called with codestr pointing to the first LOAD_CONST. |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 128 | */ |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 129 | static Py_ssize_t |
Gregory P. Smith | 49fa4a9 | 2018-11-08 17:55:07 -0800 | [diff] [blame] | 130 | fold_tuple_on_constants(_Py_CODEUNIT *codestr, Py_ssize_t codelen, |
| 131 | Py_ssize_t c_start, Py_ssize_t opcode_end, |
| 132 | PyObject *consts, int n) |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 133 | { |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 134 | /* Pre-conditions */ |
| 135 | assert(PyList_CheckExact(consts)); |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 136 | |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 137 | /* Buildup new tuple of constants */ |
INADA Naoki | 87010e8 | 2017-12-18 15:52:54 +0900 | [diff] [blame] | 138 | PyObject *newconst = PyTuple_New(n); |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 139 | if (newconst == NULL) { |
| 140 | return -1; |
| 141 | } |
INADA Naoki | 87010e8 | 2017-12-18 15:52:54 +0900 | [diff] [blame] | 142 | |
| 143 | for (Py_ssize_t i = 0, pos = c_start; i < n; i++, pos++) { |
| 144 | assert(pos < opcode_end); |
Gregory P. Smith | 49fa4a9 | 2018-11-08 17:55:07 -0800 | [diff] [blame] | 145 | pos = find_op(codestr, codelen, pos); |
INADA Naoki | 87010e8 | 2017-12-18 15:52:54 +0900 | [diff] [blame] | 146 | assert(_Py_OPCODE(codestr[pos]) == LOAD_CONST); |
| 147 | |
| 148 | unsigned int arg = get_arg(codestr, pos); |
| 149 | PyObject *constant = PyList_GET_ITEM(consts, arg); |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 150 | Py_INCREF(constant); |
| 151 | PyTuple_SET_ITEM(newconst, i, constant); |
| 152 | } |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 153 | |
Victor Stinner | 028f0ef | 2018-12-07 17:54:18 +0100 | [diff] [blame] | 154 | Py_ssize_t index = PyList_GET_SIZE(consts); |
| 155 | #if SIZEOF_SIZE_T > SIZEOF_INT |
| 156 | if ((size_t)index >= UINT_MAX - 1) { |
| 157 | Py_DECREF(newconst); |
| 158 | PyErr_SetString(PyExc_OverflowError, "too many constants"); |
| 159 | return -1; |
| 160 | } |
| 161 | #endif |
| 162 | |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 163 | /* Append folded constant onto consts */ |
| 164 | if (PyList_Append(consts, newconst)) { |
| 165 | Py_DECREF(newconst); |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 166 | return -1; |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 167 | } |
| 168 | Py_DECREF(newconst); |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 169 | |
INADA Naoki | 87010e8 | 2017-12-18 15:52:54 +0900 | [diff] [blame] | 170 | return copy_op_arg(codestr, c_start, LOAD_CONST, |
Victor Stinner | 028f0ef | 2018-12-07 17:54:18 +0100 | [diff] [blame] | 171 | (unsigned int)index, opcode_end); |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 172 | } |
| 173 | |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 174 | static unsigned int * |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 175 | markblocks(_Py_CODEUNIT *code, Py_ssize_t len) |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 176 | { |
Serhiy Storchaka | 1a1ff29 | 2015-02-16 13:28:22 +0200 | [diff] [blame] | 177 | unsigned int *blocks = PyMem_New(unsigned int, len); |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 178 | int i, j, opcode, blockcnt = 0; |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 179 | |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 180 | if (blocks == NULL) { |
| 181 | PyErr_NoMemory(); |
| 182 | return NULL; |
| 183 | } |
| 184 | memset(blocks, 0, len*sizeof(int)); |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 185 | |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 186 | /* Mark labels in the first pass */ |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 187 | for (i = 0; i < len; i++) { |
| 188 | opcode = _Py_OPCODE(code[i]); |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 189 | switch (opcode) { |
| 190 | case FOR_ITER: |
| 191 | case JUMP_FORWARD: |
| 192 | case JUMP_IF_FALSE_OR_POP: |
| 193 | case JUMP_IF_TRUE_OR_POP: |
| 194 | case POP_JUMP_IF_FALSE: |
| 195 | case POP_JUMP_IF_TRUE: |
Mark Shannon | 9af0e47 | 2020-01-14 10:12:45 +0000 | [diff] [blame] | 196 | case JUMP_IF_NOT_EXC_MATCH: |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 197 | case JUMP_ABSOLUTE: |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 198 | case SETUP_FINALLY: |
| 199 | case SETUP_WITH: |
Yury Selivanov | 7544508 | 2015-05-11 22:57:16 -0400 | [diff] [blame] | 200 | case SETUP_ASYNC_WITH: |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 201 | j = GETJUMPTGT(code, i); |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 202 | assert(j < len); |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 203 | blocks[j] = 1; |
| 204 | break; |
| 205 | } |
| 206 | } |
| 207 | /* Build block numbers in the second pass */ |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 208 | for (i = 0; i < len; i++) { |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 209 | blockcnt += blocks[i]; /* increment blockcnt over labels */ |
| 210 | blocks[i] = blockcnt; |
| 211 | } |
| 212 | return blocks; |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 213 | } |
| 214 | |
| 215 | /* Perform basic peephole optimizations to components of a code object. |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 216 | The consts object should still be in list form to allow new constants |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 217 | to be appended. |
| 218 | |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 219 | To keep the optimizer simple, it bails when the lineno table has complex |
| 220 | encoding for gaps >= 255. |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 221 | |
Martin Panter | 46f5072 | 2016-05-26 05:35:26 +0000 | [diff] [blame] | 222 | Optimizations are restricted to simple transformations occurring within a |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 223 | single basic block. All transformations keep the code size the same or |
| 224 | smaller. For those that reduce size, the gaps are initially filled with |
| 225 | NOPs. Later those NOPs are removed and the jump addresses retargeted in |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 226 | a single pass. */ |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 227 | |
| 228 | PyObject * |
| 229 | PyCode_Optimize(PyObject *code, PyObject* consts, PyObject *names, |
Victor Stinner | f3914eb | 2016-01-20 12:16:21 +0100 | [diff] [blame] | 230 | PyObject *lnotab_obj) |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 231 | { |
Victor Stinner | 028f0ef | 2018-12-07 17:54:18 +0100 | [diff] [blame] | 232 | Py_ssize_t h, i, nexti, op_start, tgt; |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 233 | unsigned int j, nops; |
| 234 | unsigned char opcode, nextop; |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 235 | _Py_CODEUNIT *codestr = NULL; |
Victor Stinner | f3914eb | 2016-01-20 12:16:21 +0100 | [diff] [blame] | 236 | unsigned char *lnotab; |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 237 | unsigned int cum_orig_offset, last_offset; |
Serhiy Storchaka | 67559bf | 2015-02-16 21:13:24 +0200 | [diff] [blame] | 238 | Py_ssize_t tabsiz; |
INADA Naoki | 87010e8 | 2017-12-18 15:52:54 +0900 | [diff] [blame] | 239 | // Count runs of consecutive LOAD_CONSTs |
| 240 | unsigned int cumlc = 0, lastlc = 0; |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 241 | unsigned int *blocks = NULL; |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 242 | |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 243 | /* Bail out if an exception is set */ |
| 244 | if (PyErr_Occurred()) |
| 245 | goto exitError; |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 246 | |
Victor Stinner | f3914eb | 2016-01-20 12:16:21 +0100 | [diff] [blame] | 247 | /* Bypass optimization when the lnotab table is too complex */ |
| 248 | assert(PyBytes_Check(lnotab_obj)); |
| 249 | lnotab = (unsigned char*)PyBytes_AS_STRING(lnotab_obj); |
| 250 | tabsiz = PyBytes_GET_SIZE(lnotab_obj); |
| 251 | assert(tabsiz == 0 || Py_REFCNT(lnotab_obj) == 1); |
Pablo Galindo | 3498c64 | 2019-06-13 19:16:22 +0100 | [diff] [blame] | 252 | |
| 253 | /* Don't optimize if lnotab contains instruction pointer delta larger |
| 254 | than +255 (encoded as multiple bytes), just to keep the peephole optimizer |
| 255 | simple. The optimizer leaves line number deltas unchanged. */ |
| 256 | |
Raymond Hettinger | 0138c4c | 2019-08-27 09:55:13 -0700 | [diff] [blame] | 257 | for (i = 0; i < tabsiz; i += 2) { |
| 258 | if (lnotab[i] == 255) { |
Pablo Galindo | 3498c64 | 2019-06-13 19:16:22 +0100 | [diff] [blame] | 259 | goto exitUnchanged; |
| 260 | } |
Victor Stinner | f3914eb | 2016-01-20 12:16:21 +0100 | [diff] [blame] | 261 | } |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 262 | |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 263 | assert(PyBytes_Check(code)); |
Victor Stinner | 028f0ef | 2018-12-07 17:54:18 +0100 | [diff] [blame] | 264 | Py_ssize_t codesize = PyBytes_GET_SIZE(code); |
| 265 | assert(codesize % sizeof(_Py_CODEUNIT) == 0); |
| 266 | Py_ssize_t codelen = codesize / sizeof(_Py_CODEUNIT); |
| 267 | if (codelen > INT_MAX) { |
| 268 | /* Python assembler is limited to INT_MAX: see assembler.a_offset in |
| 269 | compile.c. */ |
| 270 | goto exitUnchanged; |
| 271 | } |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 272 | |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 273 | /* Make a modifiable copy of the code string */ |
Victor Stinner | 028f0ef | 2018-12-07 17:54:18 +0100 | [diff] [blame] | 274 | codestr = (_Py_CODEUNIT *)PyMem_Malloc(codesize); |
Victor Stinner | e0af3a8 | 2013-07-09 00:32:04 +0200 | [diff] [blame] | 275 | if (codestr == NULL) { |
| 276 | PyErr_NoMemory(); |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 277 | goto exitError; |
Victor Stinner | e0af3a8 | 2013-07-09 00:32:04 +0200 | [diff] [blame] | 278 | } |
Victor Stinner | 028f0ef | 2018-12-07 17:54:18 +0100 | [diff] [blame] | 279 | memcpy(codestr, PyBytes_AS_STRING(code), codesize); |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 280 | |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 281 | blocks = markblocks(codestr, codelen); |
| 282 | if (blocks == NULL) |
| 283 | goto exitError; |
| 284 | assert(PyList_Check(consts)); |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 285 | |
Gregory P. Smith | 49fa4a9 | 2018-11-08 17:55:07 -0800 | [diff] [blame] | 286 | for (i=find_op(codestr, codelen, 0) ; i<codelen ; i=nexti) { |
Serhiy Storchaka | a1e9ab3 | 2016-09-11 15:19:12 +0300 | [diff] [blame] | 287 | opcode = _Py_OPCODE(codestr[i]); |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 288 | op_start = i; |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 289 | while (op_start >= 1 && _Py_OPCODE(codestr[op_start-1]) == EXTENDED_ARG) { |
| 290 | op_start--; |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 291 | } |
| 292 | |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 293 | nexti = i + 1; |
| 294 | while (nexti < codelen && _Py_OPCODE(codestr[nexti]) == EXTENDED_ARG) |
| 295 | nexti++; |
| 296 | nextop = nexti < codelen ? _Py_OPCODE(codestr[nexti]) : 0; |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 297 | |
INADA Naoki | 87010e8 | 2017-12-18 15:52:54 +0900 | [diff] [blame] | 298 | lastlc = cumlc; |
| 299 | cumlc = 0; |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 300 | |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 301 | switch (opcode) { |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 302 | /* Skip over LOAD_CONST trueconst |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 303 | POP_JUMP_IF_FALSE xx. This improves |
| 304 | "while 1" performance. */ |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 305 | case LOAD_CONST: |
INADA Naoki | 87010e8 | 2017-12-18 15:52:54 +0900 | [diff] [blame] | 306 | cumlc = lastlc + 1; |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 307 | if (nextop != POP_JUMP_IF_FALSE || |
Pablo Galindo | af8646c | 2019-05-17 11:37:08 +0100 | [diff] [blame] | 308 | !ISBASICBLOCK(blocks, op_start, i + 1)) { |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 309 | break; |
Pablo Galindo | af8646c | 2019-05-17 11:37:08 +0100 | [diff] [blame] | 310 | } |
| 311 | PyObject* cnt = PyList_GET_ITEM(consts, get_arg(codestr, i)); |
| 312 | int is_true = PyObject_IsTrue(cnt); |
Pablo Galindo | 7a68f8c | 2019-06-15 15:58:00 +0100 | [diff] [blame] | 313 | if (is_true == -1) { |
| 314 | goto exitError; |
| 315 | } |
Pablo Galindo | af8646c | 2019-05-17 11:37:08 +0100 | [diff] [blame] | 316 | if (is_true == 1) { |
| 317 | fill_nops(codestr, op_start, nexti + 1); |
| 318 | cumlc = 0; |
Pablo Galindo | af8646c | 2019-05-17 11:37:08 +0100 | [diff] [blame] | 319 | } |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 320 | break; |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 321 | |
Serhiy Storchaka | 15a8728 | 2017-12-14 20:24:31 +0200 | [diff] [blame] | 322 | /* Try to fold tuples of constants. |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 323 | Skip over BUILD_SEQN 1 UNPACK_SEQN 1. |
| 324 | Replace BUILD_SEQN 2 UNPACK_SEQN 2 with ROT2. |
| 325 | Replace BUILD_SEQN 3 UNPACK_SEQN 3 with ROT3 ROT2. */ |
| 326 | case BUILD_TUPLE: |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 327 | j = get_arg(codestr, i); |
INADA Naoki | 87010e8 | 2017-12-18 15:52:54 +0900 | [diff] [blame] | 328 | if (j > 0 && lastlc >= j) { |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 329 | h = lastn_const_start(codestr, op_start, j); |
Serhiy Storchaka | 15a8728 | 2017-12-14 20:24:31 +0200 | [diff] [blame] | 330 | if (ISBASICBLOCK(blocks, h, op_start)) { |
Gregory P. Smith | 49fa4a9 | 2018-11-08 17:55:07 -0800 | [diff] [blame] | 331 | h = fold_tuple_on_constants(codestr, codelen, |
| 332 | h, i+1, consts, j); |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 333 | break; |
| 334 | } |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 335 | } |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 336 | if (nextop != UNPACK_SEQUENCE || |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 337 | !ISBASICBLOCK(blocks, op_start, i + 1) || |
Serhiy Storchaka | 15a8728 | 2017-12-14 20:24:31 +0200 | [diff] [blame] | 338 | j != get_arg(codestr, nexti)) |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 339 | break; |
| 340 | if (j < 2) { |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 341 | fill_nops(codestr, op_start, nexti + 1); |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 342 | } else if (j == 2) { |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 343 | codestr[op_start] = PACKOPARG(ROT_TWO, 0); |
| 344 | fill_nops(codestr, op_start + 1, nexti + 1); |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 345 | } else if (j == 3) { |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 346 | codestr[op_start] = PACKOPARG(ROT_THREE, 0); |
| 347 | codestr[op_start + 1] = PACKOPARG(ROT_TWO, 0); |
| 348 | fill_nops(codestr, op_start + 2, nexti + 1); |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 349 | } |
| 350 | break; |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 351 | |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 352 | /* Simplify conditional jump to conditional jump where the |
| 353 | result of the first test implies the success of a similar |
| 354 | test or the failure of the opposite test. |
| 355 | Arises in code like: |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 356 | "a and b or c" |
| 357 | "(a and b) and c" |
Serhiy Storchaka | 36ff451 | 2017-06-11 14:50:22 +0300 | [diff] [blame] | 358 | "(a or b) or c" |
| 359 | "(a or b) and c" |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 360 | x:JUMP_IF_FALSE_OR_POP y y:JUMP_IF_FALSE_OR_POP z |
| 361 | --> x:JUMP_IF_FALSE_OR_POP z |
| 362 | x:JUMP_IF_FALSE_OR_POP y y:JUMP_IF_TRUE_OR_POP z |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 363 | --> x:POP_JUMP_IF_FALSE y+1 |
| 364 | where y+1 is the instruction following the second test. |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 365 | */ |
| 366 | case JUMP_IF_FALSE_OR_POP: |
| 367 | case JUMP_IF_TRUE_OR_POP: |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 368 | h = get_arg(codestr, i) / sizeof(_Py_CODEUNIT); |
Gregory P. Smith | 49fa4a9 | 2018-11-08 17:55:07 -0800 | [diff] [blame] | 369 | tgt = find_op(codestr, codelen, h); |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 370 | |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 371 | j = _Py_OPCODE(codestr[tgt]); |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 372 | if (CONDITIONAL_JUMP(j)) { |
Raymond Hettinger | 08eef3f | 2016-08-07 20:20:33 -0700 | [diff] [blame] | 373 | /* NOTE: all possible jumps here are absolute. */ |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 374 | if (JUMPS_ON_TRUE(j) == JUMPS_ON_TRUE(opcode)) { |
Raymond Hettinger | 08eef3f | 2016-08-07 20:20:33 -0700 | [diff] [blame] | 375 | /* The second jump will be taken iff the first is. |
| 376 | The current opcode inherits its target's |
| 377 | stack effect */ |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 378 | h = set_arg(codestr, i, get_arg(codestr, tgt)); |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 379 | } else { |
Raymond Hettinger | 08eef3f | 2016-08-07 20:20:33 -0700 | [diff] [blame] | 380 | /* The second jump is not taken if the first is (so |
| 381 | jump past it), and all conditional jumps pop their |
| 382 | argument when they're not taken (so change the |
| 383 | first jump to pop its argument when it's taken). */ |
Victor Stinner | 028f0ef | 2018-12-07 17:54:18 +0100 | [diff] [blame] | 384 | Py_ssize_t arg = (tgt + 1); |
| 385 | /* cannot overflow: codelen <= INT_MAX */ |
| 386 | assert((size_t)arg <= UINT_MAX / sizeof(_Py_CODEUNIT)); |
| 387 | arg *= sizeof(_Py_CODEUNIT); |
| 388 | h = set_arg(codestr, i, (unsigned int)arg); |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 389 | j = opcode == JUMP_IF_TRUE_OR_POP ? |
| 390 | POP_JUMP_IF_TRUE : POP_JUMP_IF_FALSE; |
| 391 | } |
| 392 | |
| 393 | if (h >= 0) { |
| 394 | nexti = h; |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 395 | codestr[nexti] = PACKOPARG(j, _Py_OPARG(codestr[nexti])); |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 396 | break; |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 397 | } |
| 398 | } |
| 399 | /* Intentional fallthrough */ |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 400 | |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 401 | /* Replace jumps to unconditional jumps */ |
| 402 | case POP_JUMP_IF_FALSE: |
| 403 | case POP_JUMP_IF_TRUE: |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 404 | case JUMP_FORWARD: |
| 405 | case JUMP_ABSOLUTE: |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 406 | h = GETJUMPTGT(codestr, i); |
Gregory P. Smith | 49fa4a9 | 2018-11-08 17:55:07 -0800 | [diff] [blame] | 407 | tgt = find_op(codestr, codelen, h); |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 408 | /* Replace JUMP_* to a RETURN into just a RETURN */ |
| 409 | if (UNCONDITIONAL_JUMP(opcode) && |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 410 | _Py_OPCODE(codestr[tgt]) == RETURN_VALUE) { |
| 411 | codestr[op_start] = PACKOPARG(RETURN_VALUE, 0); |
| 412 | fill_nops(codestr, op_start + 1, i + 1); |
| 413 | } else if (UNCONDITIONAL_JUMP(_Py_OPCODE(codestr[tgt]))) { |
Victor Stinner | 028f0ef | 2018-12-07 17:54:18 +0100 | [diff] [blame] | 414 | size_t arg = GETJUMPTGT(codestr, tgt); |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 415 | if (opcode == JUMP_FORWARD) { /* JMP_ABS can go backwards */ |
| 416 | opcode = JUMP_ABSOLUTE; |
| 417 | } else if (!ABSOLUTE_JUMP(opcode)) { |
Victor Stinner | 028f0ef | 2018-12-07 17:54:18 +0100 | [diff] [blame] | 418 | if (arg < (size_t)(i + 1)) { |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 419 | break; /* No backward relative jumps */ |
| 420 | } |
Victor Stinner | 028f0ef | 2018-12-07 17:54:18 +0100 | [diff] [blame] | 421 | arg -= i + 1; /* Calc relative jump addr */ |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 422 | } |
Victor Stinner | 028f0ef | 2018-12-07 17:54:18 +0100 | [diff] [blame] | 423 | /* cannot overflow: codelen <= INT_MAX */ |
| 424 | assert(arg <= (UINT_MAX / sizeof(_Py_CODEUNIT))); |
| 425 | arg *= sizeof(_Py_CODEUNIT); |
| 426 | copy_op_arg(codestr, op_start, opcode, |
| 427 | (unsigned int)arg, i + 1); |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 428 | } |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 429 | break; |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 430 | |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 431 | /* Remove unreachable ops after RETURN */ |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 432 | case RETURN_VALUE: |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 433 | h = i + 1; |
Mark Shannon | fee5526 | 2019-11-21 09:11:43 +0000 | [diff] [blame] | 434 | while (h < codelen && ISBASICBLOCK(blocks, i, h)) |
Serhiy Storchaka | 520b7ae | 2018-02-22 23:33:30 +0200 | [diff] [blame] | 435 | { |
Mark Shannon | fee5526 | 2019-11-21 09:11:43 +0000 | [diff] [blame] | 436 | /* Leave SETUP_FINALLY and RERAISE in place to help find block limits. */ |
| 437 | if (_Py_OPCODE(codestr[h]) == SETUP_FINALLY || _Py_OPCODE(codestr[h]) == RERAISE) { |
Serhiy Storchaka | 520b7ae | 2018-02-22 23:33:30 +0200 | [diff] [blame] | 438 | while (h > i + 1 && |
| 439 | _Py_OPCODE(codestr[h - 1]) == EXTENDED_ARG) |
| 440 | { |
| 441 | h--; |
| 442 | } |
| 443 | break; |
| 444 | } |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 445 | h++; |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 446 | } |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 447 | if (h > i + 1) { |
Serhiy Storchaka | 7db3c48 | 2016-10-25 09:30:43 +0300 | [diff] [blame] | 448 | fill_nops(codestr, i + 1, h); |
Gregory P. Smith | 49fa4a9 | 2018-11-08 17:55:07 -0800 | [diff] [blame] | 449 | nexti = find_op(codestr, codelen, h); |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 450 | } |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 451 | break; |
| 452 | } |
| 453 | } |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 454 | |
Victor Stinner | f3914eb | 2016-01-20 12:16:21 +0100 | [diff] [blame] | 455 | /* Fixup lnotab */ |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 456 | for (i = 0, nops = 0; i < codelen; i++) { |
Victor Stinner | 028f0ef | 2018-12-07 17:54:18 +0100 | [diff] [blame] | 457 | size_t block = (size_t)i - nops; |
| 458 | /* cannot overflow: codelen <= INT_MAX */ |
| 459 | assert(block <= UINT_MAX); |
Victor Stinner | f3914eb | 2016-01-20 12:16:21 +0100 | [diff] [blame] | 460 | /* original code offset => new code offset */ |
Victor Stinner | 028f0ef | 2018-12-07 17:54:18 +0100 | [diff] [blame] | 461 | blocks[i] = (unsigned int)block; |
| 462 | if (_Py_OPCODE(codestr[i]) == NOP) { |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 463 | nops++; |
Victor Stinner | 028f0ef | 2018-12-07 17:54:18 +0100 | [diff] [blame] | 464 | } |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 465 | } |
Victor Stinner | f3914eb | 2016-01-20 12:16:21 +0100 | [diff] [blame] | 466 | cum_orig_offset = 0; |
| 467 | last_offset = 0; |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 468 | for (i=0 ; i < tabsiz ; i+=2) { |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 469 | unsigned int offset_delta, new_offset; |
Victor Stinner | f3914eb | 2016-01-20 12:16:21 +0100 | [diff] [blame] | 470 | cum_orig_offset += lnotab[i]; |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 471 | assert(cum_orig_offset % sizeof(_Py_CODEUNIT) == 0); |
| 472 | new_offset = blocks[cum_orig_offset / sizeof(_Py_CODEUNIT)] * |
| 473 | sizeof(_Py_CODEUNIT); |
Victor Stinner | f3914eb | 2016-01-20 12:16:21 +0100 | [diff] [blame] | 474 | offset_delta = new_offset - last_offset; |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 475 | assert(offset_delta <= 255); |
Victor Stinner | f3914eb | 2016-01-20 12:16:21 +0100 | [diff] [blame] | 476 | lnotab[i] = (unsigned char)offset_delta; |
| 477 | last_offset = new_offset; |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 478 | } |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 479 | |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 480 | /* Remove NOPs and fixup jump targets */ |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 481 | for (op_start = i = h = 0; i < codelen; i++, op_start = i) { |
| 482 | j = _Py_OPARG(codestr[i]); |
| 483 | while (_Py_OPCODE(codestr[i]) == EXTENDED_ARG) { |
| 484 | i++; |
| 485 | j = j<<8 | _Py_OPARG(codestr[i]); |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 486 | } |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 487 | opcode = _Py_OPCODE(codestr[i]); |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 488 | switch (opcode) { |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 489 | case NOP:continue; |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 490 | |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 491 | case JUMP_ABSOLUTE: |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 492 | case POP_JUMP_IF_FALSE: |
| 493 | case POP_JUMP_IF_TRUE: |
| 494 | case JUMP_IF_FALSE_OR_POP: |
| 495 | case JUMP_IF_TRUE_OR_POP: |
Mark Shannon | 9af0e47 | 2020-01-14 10:12:45 +0000 | [diff] [blame] | 496 | case JUMP_IF_NOT_EXC_MATCH: |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 497 | j = blocks[j / sizeof(_Py_CODEUNIT)] * sizeof(_Py_CODEUNIT); |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 498 | break; |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 499 | |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 500 | case FOR_ITER: |
| 501 | case JUMP_FORWARD: |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 502 | case SETUP_FINALLY: |
| 503 | case SETUP_WITH: |
Yury Selivanov | 7544508 | 2015-05-11 22:57:16 -0400 | [diff] [blame] | 504 | case SETUP_ASYNC_WITH: |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 505 | j = blocks[j / sizeof(_Py_CODEUNIT) + i + 1] - blocks[i] - 1; |
| 506 | j *= sizeof(_Py_CODEUNIT); |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 507 | break; |
| 508 | } |
Victor Stinner | 028f0ef | 2018-12-07 17:54:18 +0100 | [diff] [blame] | 509 | Py_ssize_t ilen = i - op_start + 1; |
| 510 | if (instrsize(j) > ilen) { |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 511 | goto exitUnchanged; |
Victor Stinner | 028f0ef | 2018-12-07 17:54:18 +0100 | [diff] [blame] | 512 | } |
Victor Stinner | 028f0ef | 2018-12-07 17:54:18 +0100 | [diff] [blame] | 513 | /* If instrsize(j) < ilen, we'll emit EXTENDED_ARG 0 */ |
Serhiy Storchaka | eebaa9b | 2020-03-09 20:49:52 +0200 | [diff] [blame] | 514 | if (ilen > 4) { |
| 515 | /* Can only happen when PyCode_Optimize() is called with |
| 516 | malformed bytecode. */ |
| 517 | goto exitUnchanged; |
| 518 | } |
Victor Stinner | 028f0ef | 2018-12-07 17:54:18 +0100 | [diff] [blame] | 519 | write_op_arg(codestr + h, opcode, j, (int)ilen); |
| 520 | h += ilen; |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 521 | } |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 522 | assert(h + (Py_ssize_t)nops == codelen); |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 523 | |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 524 | PyMem_Free(blocks); |
Serhiy Storchaka | ab87400 | 2016-09-11 13:48:15 +0300 | [diff] [blame] | 525 | code = PyBytes_FromStringAndSize((char *)codestr, h * sizeof(_Py_CODEUNIT)); |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 526 | PyMem_Free(codestr); |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 527 | return code; |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 528 | |
Alexandre Vassalotti | 6f82818 | 2009-07-21 02:51:58 +0000 | [diff] [blame] | 529 | exitError: |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 530 | code = NULL; |
Alexandre Vassalotti | 6f82818 | 2009-07-21 02:51:58 +0000 | [diff] [blame] | 531 | |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 532 | exitUnchanged: |
Serhiy Storchaka | b0f80b0 | 2016-05-24 09:15:14 +0300 | [diff] [blame] | 533 | Py_XINCREF(code); |
Victor Stinner | f3914eb | 2016-01-20 12:16:21 +0100 | [diff] [blame] | 534 | PyMem_Free(blocks); |
Victor Stinner | f3914eb | 2016-01-20 12:16:21 +0100 | [diff] [blame] | 535 | PyMem_Free(codestr); |
Antoine Pitrou | f95a1b3 | 2010-05-09 15:52:27 +0000 | [diff] [blame] | 536 | return code; |
Thomas Wouters | 00ee7ba | 2006-08-21 19:07:27 +0000 | [diff] [blame] | 537 | } |