| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 1 | use crate::syntax::atom::Atom::{self, *}; |
| David Tolnay | 9dcb833 | 2020-04-30 20:37:33 -0700 | [diff] [blame^] | 2 | use crate::syntax::namespace::Namespace; |
| David Tolnay | d763f4c | 2020-04-22 16:09:19 -0700 | [diff] [blame] | 3 | use crate::syntax::{ |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 4 | error, ident, Api, Enum, ExternFn, ExternType, Lang, Receiver, Ref, Slice, Struct, Ty1, Type, |
| 5 | Types, |
| David Tolnay | d763f4c | 2020-04-22 16:09:19 -0700 | [diff] [blame] | 6 | }; |
| David Tolnay | 09462ac | 2020-03-20 14:58:41 -0700 | [diff] [blame] | 7 | use proc_macro2::{Delimiter, Group, Ident, TokenStream}; |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 8 | use quote::{quote, ToTokens}; |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 9 | use std::collections::HashSet; |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 10 | use std::fmt::Display; |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 11 | use syn::{Error, Result}; |
| 12 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 13 | struct Check<'a> { |
| David Tolnay | 9dcb833 | 2020-04-30 20:37:33 -0700 | [diff] [blame^] | 14 | namespace: &'a Namespace, |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 15 | apis: &'a [Api], |
| 16 | types: &'a Types<'a>, |
| 17 | errors: &'a mut Vec<Error>, |
| 18 | } |
| 19 | |
| David Tolnay | 9dcb833 | 2020-04-30 20:37:33 -0700 | [diff] [blame^] | 20 | pub(crate) fn typecheck(namespace: &Namespace, apis: &[Api], types: &Types) -> Result<()> { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 21 | let mut errors = Vec::new(); |
| 22 | let mut cx = Check { |
| David Tolnay | 9dcb833 | 2020-04-30 20:37:33 -0700 | [diff] [blame^] | 23 | namespace, |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 24 | apis, |
| 25 | types, |
| 26 | errors: &mut errors, |
| 27 | }; |
| 28 | do_typecheck(&mut cx); |
| 29 | combine_errors(errors) |
| 30 | } |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 31 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 32 | fn do_typecheck(cx: &mut Check) { |
| David Tolnay | 9dcb833 | 2020-04-30 20:37:33 -0700 | [diff] [blame^] | 33 | for segment in cx.namespace { |
| 34 | cx.errors.extend(ident::check(segment).err()); |
| 35 | } |
| 36 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 37 | for ty in cx.types { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 38 | match ty { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 39 | Type::Ident(ident) => check_type_ident(cx, ident), |
| 40 | Type::RustBox(ptr) => check_type_box(cx, ptr), |
| David Tolnay | c6d891e | 2020-04-25 12:06:34 -0700 | [diff] [blame] | 41 | Type::RustVec(ty) => check_type_rust_vec(cx, ty), |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 42 | Type::UniquePtr(ptr) => check_type_unique_ptr(cx, ptr), |
| David Tolnay | fff4c8a | 2020-04-25 11:45:20 -0700 | [diff] [blame] | 43 | Type::CxxVector(ptr) => check_type_cxx_vector(cx, ptr), |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 44 | Type::Ref(ty) => check_type_ref(cx, ty), |
| David Tolnay | eebe9b7 | 2020-04-14 16:32:18 -0700 | [diff] [blame] | 45 | Type::Slice(ty) => check_type_slice(cx, ty), |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 46 | _ => {} |
| 47 | } |
| 48 | } |
| 49 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 50 | for api in cx.apis { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 51 | match api { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 52 | Api::Struct(strct) => check_api_struct(cx, strct), |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 53 | Api::Enum(enm) => check_api_enum(cx, enm), |
| David Tolnay | 0b368ae | 2020-04-22 17:55:02 -0700 | [diff] [blame] | 54 | Api::CxxType(ty) | Api::RustType(ty) => check_api_type(cx, ty), |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 55 | Api::CxxFunction(efn) | Api::RustFunction(efn) => check_api_fn(cx, efn), |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 56 | _ => {} |
| 57 | } |
| 58 | } |
| 59 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 60 | for api in cx.apis { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 61 | if let Api::CxxFunction(efn) = api { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 62 | check_mut_return_restriction(cx, efn); |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 63 | } |
| 64 | if let Api::CxxFunction(efn) | Api::RustFunction(efn) = api { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 65 | check_multiple_arg_lifetimes(cx, efn); |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 66 | } |
| 67 | } |
| 68 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 69 | ident::check_all(cx.apis, cx.errors); |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 70 | } |
| 71 | |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 72 | impl Check<'_> { |
| 73 | fn error(&mut self, sp: impl ToTokens, msg: impl Display) { |
| 74 | self.errors.push(Error::new_spanned(sp, msg)); |
| 75 | } |
| 76 | } |
| 77 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 78 | fn check_type_ident(cx: &mut Check, ident: &Ident) { |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 79 | if Atom::from(ident).is_none() |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 80 | && !cx.types.structs.contains_key(ident) |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 81 | && !cx.types.enums.contains_key(ident) |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 82 | && !cx.types.cxx.contains(ident) |
| 83 | && !cx.types.rust.contains(ident) |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 84 | { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 85 | cx.error(ident, "unsupported type"); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 86 | } |
| 87 | } |
| 88 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 89 | fn check_type_box(cx: &mut Check, ptr: &Ty1) { |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 90 | if let Type::Ident(ident) = &ptr.inner { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 91 | if cx.types.cxx.contains(ident) { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 92 | cx.error(ptr, error::BOX_CXX_TYPE.msg); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 93 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 94 | |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 95 | if Atom::from(ident).is_none() { |
| 96 | return; |
| 97 | } |
| 98 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 99 | |
| 100 | cx.error(ptr, "unsupported target type of Box"); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 101 | } |
| 102 | |
| David Tolnay | c6d891e | 2020-04-25 12:06:34 -0700 | [diff] [blame] | 103 | fn check_type_rust_vec(cx: &mut Check, ty: &Ty1) { |
| 104 | if let Type::Ident(ident) = &ty.inner { |
| 105 | if cx.types.cxx.contains(ident) { |
| 106 | cx.error(ty, "Rust Vec containing C++ type is not supported yet"); |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 107 | return; |
| David Tolnay | c6d891e | 2020-04-25 12:06:34 -0700 | [diff] [blame] | 108 | } |
| 109 | |
| 110 | match Atom::from(ident) { |
| David Tolnay | 6bd63de | 2020-04-25 12:20:09 -0700 | [diff] [blame] | 111 | None | Some(U8) | Some(U16) | Some(U32) | Some(U64) | Some(Usize) | Some(I8) |
| 112 | | Some(I16) | Some(I32) | Some(I64) | Some(Isize) | Some(F32) | Some(F64) => return, |
| 113 | Some(Bool) | Some(RustString) => { /* todo */ } |
| 114 | Some(CxxString) => {} |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 115 | } |
| 116 | } |
| 117 | |
| David Tolnay | c6d891e | 2020-04-25 12:06:34 -0700 | [diff] [blame] | 118 | cx.error(ty, "unsupported element type of Vec"); |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 119 | } |
| 120 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 121 | fn check_type_unique_ptr(cx: &mut Check, ptr: &Ty1) { |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 122 | if let Type::Ident(ident) = &ptr.inner { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 123 | if cx.types.rust.contains(ident) { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 124 | cx.error(ptr, "unique_ptr of a Rust type is not supported yet"); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 125 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 126 | |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 127 | match Atom::from(ident) { |
| 128 | None | Some(CxxString) => return, |
| 129 | _ => {} |
| 130 | } |
| David Tolnay | 4377a9e | 2020-04-24 15:20:26 -0700 | [diff] [blame] | 131 | } else if let Type::CxxVector(_) = &ptr.inner { |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 132 | return; |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 133 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 134 | |
| 135 | cx.error(ptr, "unsupported unique_ptr target type"); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 136 | } |
| 137 | |
| David Tolnay | fff4c8a | 2020-04-25 11:45:20 -0700 | [diff] [blame] | 138 | fn check_type_cxx_vector(cx: &mut Check, ptr: &Ty1) { |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 139 | if let Type::Ident(ident) = &ptr.inner { |
| 140 | if cx.types.rust.contains(ident) { |
| David Tolnay | c0faaf6 | 2020-04-25 12:18:38 -0700 | [diff] [blame] | 141 | cx.error( |
| 142 | ptr, |
| 143 | "C++ vector containing a Rust type is not supported yet", |
| 144 | ); |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 145 | } |
| 146 | |
| 147 | match Atom::from(ident) { |
| David Tolnay | 6bd63de | 2020-04-25 12:20:09 -0700 | [diff] [blame] | 148 | None | Some(U8) | Some(U16) | Some(U32) | Some(U64) | Some(Usize) | Some(I8) |
| 149 | | Some(I16) | Some(I32) | Some(I64) | Some(Isize) | Some(F32) | Some(F64) => return, |
| 150 | Some(CxxString) => { /* todo */ } |
| 151 | Some(Bool) | Some(RustString) => {} |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 152 | } |
| 153 | } |
| David Tolnay | c0faaf6 | 2020-04-25 12:18:38 -0700 | [diff] [blame] | 154 | |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 155 | cx.error(ptr, "unsupported vector target type"); |
| 156 | } |
| 157 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 158 | fn check_type_ref(cx: &mut Check, ty: &Ref) { |
| David Tolnay | d763f4c | 2020-04-22 16:09:19 -0700 | [diff] [blame] | 159 | if ty.lifetime.is_some() { |
| 160 | cx.error(ty, "references with explicit lifetimes are not supported"); |
| 161 | } |
| 162 | |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 163 | match ty.inner { |
| 164 | Type::Fn(_) | Type::Void(_) => {} |
| David Tolnay | 776fd89 | 2020-04-28 13:38:21 -0700 | [diff] [blame] | 165 | Type::Ref(_) => { |
| 166 | cx.error(ty, "C++ does not allow references to references"); |
| 167 | return; |
| 168 | } |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 169 | _ => return, |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 170 | } |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 171 | |
| 172 | cx.error(ty, "unsupported reference type"); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 173 | } |
| 174 | |
| David Tolnay | eebe9b7 | 2020-04-14 16:32:18 -0700 | [diff] [blame] | 175 | fn check_type_slice(cx: &mut Check, ty: &Slice) { |
| 176 | cx.error(ty, "only &[u8] is supported so far, not other slice types"); |
| 177 | } |
| 178 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 179 | fn check_api_struct(cx: &mut Check, strct: &Struct) { |
| David Tolnay | 0b368ae | 2020-04-22 17:55:02 -0700 | [diff] [blame] | 180 | check_reserved_name(cx, &strct.ident); |
| 181 | |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 182 | if strct.fields.is_empty() { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 183 | let span = span_for_struct_error(strct); |
| 184 | cx.error(span, "structs without any fields are not supported"); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 185 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 186 | |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 187 | for field in &strct.fields { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 188 | if is_unsized(cx, &field.ty) { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 189 | let desc = describe(cx, &field.ty); |
| 190 | let msg = format!("using {} by value is not supported", desc); |
| 191 | cx.error(field, msg); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 192 | } |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 193 | if let Type::Fn(_) = field.ty { |
| 194 | cx.error( |
| 195 | field, |
| 196 | "function pointers in a struct field are not implemented yet", |
| 197 | ); |
| 198 | } |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 199 | } |
| 200 | } |
| 201 | |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 202 | fn check_api_enum(cx: &mut Check, enm: &Enum) { |
| 203 | check_reserved_name(cx, &enm.ident); |
| 204 | |
| 205 | if enm.variants.is_empty() { |
| 206 | let span = span_for_enum_error(enm); |
| 207 | cx.error(span, "enums without any variants are not supported"); |
| 208 | } |
| 209 | |
| 210 | let mut discriminants = HashSet::new(); |
| 211 | enm.variants.iter().fold(0, |next_discriminant, variant| { |
| David Tolnay | d7984c2 | 2020-04-30 20:09:31 -0700 | [diff] [blame] | 212 | let discriminant = variant.discriminant.unwrap_or(next_discriminant); |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 213 | if !discriminants.insert(discriminant) { |
| 214 | let msg = format!("discriminant value `{}` already exists", discriminant); |
| 215 | cx.error(span_for_enum_error(enm), msg); |
| 216 | } |
| 217 | discriminant + 1 |
| 218 | }); |
| 219 | } |
| 220 | |
| David Tolnay | 0b368ae | 2020-04-22 17:55:02 -0700 | [diff] [blame] | 221 | fn check_api_type(cx: &mut Check, ty: &ExternType) { |
| 222 | check_reserved_name(cx, &ty.ident); |
| 223 | } |
| 224 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 225 | fn check_api_fn(cx: &mut Check, efn: &ExternFn) { |
| David Tolnay | d763f4c | 2020-04-22 16:09:19 -0700 | [diff] [blame] | 226 | if let Some(receiver) = &efn.receiver { |
| David Tolnay | a1f29c4 | 2020-04-22 18:01:38 -0700 | [diff] [blame] | 227 | let ref span = span_for_receiver_error(receiver); |
| 228 | |
| 229 | if receiver.ty == "Self" { |
| 230 | let mutability = match receiver.mutability { |
| 231 | Some(_) => "mut ", |
| 232 | None => "", |
| 233 | }; |
| 234 | let msg = format!( |
| 235 | "unnamed receiver type is only allowed if the surrounding \ |
| 236 | extern block contains exactly one extern type; \ |
| 237 | use `self: &{mutability}TheType`", |
| 238 | mutability = mutability, |
| 239 | ); |
| 240 | cx.error(span, msg); |
| 241 | } else if !cx.types.structs.contains_key(&receiver.ty) |
| David Tolnay | 8b60bf1 | 2020-04-22 16:52:19 -0700 | [diff] [blame] | 242 | && !cx.types.cxx.contains(&receiver.ty) |
| 243 | && !cx.types.rust.contains(&receiver.ty) |
| 244 | { |
| David Tolnay | 8b60bf1 | 2020-04-22 16:52:19 -0700 | [diff] [blame] | 245 | cx.error(span, "unrecognized receiver type"); |
| 246 | } |
| 247 | |
| David Tolnay | d763f4c | 2020-04-22 16:09:19 -0700 | [diff] [blame] | 248 | if receiver.lifetime.is_some() { |
| David Tolnay | d763f4c | 2020-04-22 16:09:19 -0700 | [diff] [blame] | 249 | cx.error(span, "references with explicit lifetimes are not supported"); |
| 250 | } |
| 251 | } |
| 252 | |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 253 | for arg in &efn.args { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 254 | if is_unsized(cx, &arg.ty) { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 255 | let desc = describe(cx, &arg.ty); |
| 256 | let msg = format!("passing {} by value is not supported", desc); |
| 257 | cx.error(arg, msg); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 258 | } |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 259 | if let Type::Fn(_) = arg.ty { |
| David Tolnay | 75dca2e | 2020-03-25 20:17:52 -0700 | [diff] [blame] | 260 | if efn.lang == Lang::Rust { |
| 261 | cx.error( |
| 262 | arg, |
| 263 | "passing a function pointer from C++ to Rust is not implemented yet", |
| 264 | ); |
| 265 | } |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 266 | } |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 267 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 268 | |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 269 | if let Some(ty) = &efn.ret { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 270 | if is_unsized(cx, ty) { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 271 | let desc = describe(cx, ty); |
| 272 | let msg = format!("returning {} by value is not supported", desc); |
| 273 | cx.error(ty, msg); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 274 | } |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 275 | if let Type::Fn(_) = ty { |
| 276 | cx.error(ty, "returning a function pointer is not implemented yet"); |
| 277 | } |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 278 | } |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 279 | } |
| 280 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 281 | fn check_mut_return_restriction(cx: &mut Check, efn: &ExternFn) { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 282 | match &efn.ret { |
| 283 | Some(Type::Ref(ty)) if ty.mutability.is_some() => {} |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 284 | _ => return, |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 285 | } |
| 286 | |
| 287 | for arg in &efn.args { |
| 288 | if let Type::Ref(ty) = &arg.ty { |
| 289 | if ty.mutability.is_some() { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 290 | return; |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 291 | } |
| 292 | } |
| 293 | } |
| 294 | |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 295 | cx.error( |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 296 | efn, |
| 297 | "&mut return type is not allowed unless there is a &mut argument", |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 298 | ); |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 299 | } |
| 300 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 301 | fn check_multiple_arg_lifetimes(cx: &mut Check, efn: &ExternFn) { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 302 | match &efn.ret { |
| 303 | Some(Type::Ref(_)) => {} |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 304 | _ => return, |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 305 | } |
| 306 | |
| 307 | let mut reference_args = 0; |
| 308 | for arg in &efn.args { |
| 309 | if let Type::Ref(_) = &arg.ty { |
| 310 | reference_args += 1; |
| 311 | } |
| 312 | } |
| 313 | |
| Joel Galenson | 3d4f612 | 2020-04-07 15:54:05 -0700 | [diff] [blame] | 314 | if efn.receiver.is_some() { |
| 315 | reference_args += 1; |
| 316 | } |
| 317 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 318 | if reference_args != 1 { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 319 | cx.error( |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 320 | efn, |
| 321 | "functions that return a reference must take exactly one input reference", |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 322 | ); |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 323 | } |
| 324 | } |
| 325 | |
| David Tolnay | 0b368ae | 2020-04-22 17:55:02 -0700 | [diff] [blame] | 326 | fn check_reserved_name(cx: &mut Check, ident: &Ident) { |
| David Tolnay | 99c93d8 | 2020-04-25 14:07:44 -0700 | [diff] [blame] | 327 | if ident == "Box" |
| 328 | || ident == "UniquePtr" |
| 329 | || ident == "Vec" |
| 330 | || ident == "CxxVector" |
| 331 | || Atom::from(ident).is_some() |
| 332 | { |
| David Tolnay | 0b368ae | 2020-04-22 17:55:02 -0700 | [diff] [blame] | 333 | cx.error(ident, "reserved name"); |
| 334 | } |
| 335 | } |
| 336 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 337 | fn is_unsized(cx: &mut Check, ty: &Type) -> bool { |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 338 | let ident = match ty { |
| 339 | Type::Ident(ident) => ident, |
| David Tolnay | e70303c | 2020-04-25 15:02:37 -0700 | [diff] [blame] | 340 | Type::CxxVector(_) | Type::Slice(_) | Type::Void(_) => return true, |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 341 | _ => return false, |
| 342 | }; |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 343 | ident == CxxString || cx.types.cxx.contains(ident) || cx.types.rust.contains(ident) |
| 344 | } |
| 345 | |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 346 | fn span_for_struct_error(strct: &Struct) -> TokenStream { |
| 347 | let struct_token = strct.struct_token; |
| 348 | let mut brace_token = Group::new(Delimiter::Brace, TokenStream::new()); |
| 349 | brace_token.set_span(strct.brace_token.span); |
| 350 | quote!(#struct_token #brace_token) |
| 351 | } |
| 352 | |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 353 | fn span_for_enum_error(enm: &Enum) -> TokenStream { |
| 354 | let enum_token = enm.enum_token; |
| 355 | let mut brace_token = Group::new(Delimiter::Brace, TokenStream::new()); |
| 356 | brace_token.set_span(enm.brace_token.span); |
| 357 | quote!(#enum_token #brace_token) |
| 358 | } |
| 359 | |
| David Tolnay | d763f4c | 2020-04-22 16:09:19 -0700 | [diff] [blame] | 360 | fn span_for_receiver_error(receiver: &Receiver) -> TokenStream { |
| 361 | let ampersand = receiver.ampersand; |
| 362 | let lifetime = &receiver.lifetime; |
| 363 | let mutability = receiver.mutability; |
| 364 | if receiver.shorthand { |
| 365 | let var = receiver.var; |
| 366 | quote!(#ampersand #lifetime #mutability #var) |
| 367 | } else { |
| 368 | let ty = &receiver.ty; |
| 369 | quote!(#ampersand #lifetime #mutability #ty) |
| 370 | } |
| 371 | } |
| 372 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 373 | fn combine_errors(errors: Vec<Error>) -> Result<()> { |
| 374 | let mut iter = errors.into_iter(); |
| 375 | let mut all_errors = match iter.next() { |
| 376 | Some(err) => err, |
| 377 | None => return Ok(()), |
| 378 | }; |
| 379 | for err in iter { |
| 380 | all_errors.combine(err); |
| 381 | } |
| 382 | Err(all_errors) |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 383 | } |
| 384 | |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 385 | fn describe(cx: &mut Check, ty: &Type) -> String { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 386 | match ty { |
| 387 | Type::Ident(ident) => { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 388 | if cx.types.structs.contains_key(ident) { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 389 | "struct".to_owned() |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 390 | } else if cx.types.cxx.contains(ident) { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 391 | "C++ type".to_owned() |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 392 | } else if cx.types.rust.contains(ident) { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 393 | "opaque Rust type".to_owned() |
| 394 | } else if Atom::from(ident) == Some(CxxString) { |
| 395 | "C++ string".to_owned() |
| 396 | } else { |
| 397 | ident.to_string() |
| 398 | } |
| 399 | } |
| 400 | Type::RustBox(_) => "Box".to_owned(), |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 401 | Type::RustVec(_) => "Vec".to_owned(), |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 402 | Type::UniquePtr(_) => "unique_ptr".to_owned(), |
| 403 | Type::Ref(_) => "reference".to_owned(), |
| 404 | Type::Str(_) => "&str".to_owned(), |
| David Tolnay | fa85fce | 2020-04-25 15:03:25 -0700 | [diff] [blame] | 405 | Type::CxxVector(_) => "C++ vector".to_owned(), |
| Adrian Taylor | f5dd552 | 2020-04-13 16:50:14 -0700 | [diff] [blame] | 406 | Type::Slice(_) => "slice".to_owned(), |
| 407 | Type::SliceRefU8(_) => "&[u8]".to_owned(), |
| David Tolnay | 417305a | 2020-03-18 13:54:00 -0700 | [diff] [blame] | 408 | Type::Fn(_) => "function pointer".to_owned(), |
| David Tolnay | 2fb14e9 | 2020-03-15 23:11:38 -0700 | [diff] [blame] | 409 | Type::Void(_) => "()".to_owned(), |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 410 | } |
| 411 | } |