blob: 9683224ffd36d1b3be8e15a2ad5aa4cea2f0d13c [file] [log] [blame]
David Tolnay7db73692019-10-20 14:51:12 -04001use crate::syntax::atom::Atom::{self, *};
David Tolnayd763f4c2020-04-22 16:09:19 -07002use crate::syntax::{
David Tolnay0b368ae2020-04-22 17:55:02 -07003 error, ident, Api, ExternFn, ExternType, Lang, Receiver, Ref, Slice, Struct, Ty1, Type, Types,
David Tolnayd763f4c2020-04-22 16:09:19 -07004};
David Tolnay09462ac2020-03-20 14:58:41 -07005use proc_macro2::{Delimiter, Group, Ident, TokenStream};
David Tolnaya420f012020-03-25 17:55:56 -07006use quote::{quote, ToTokens};
7use std::fmt::Display;
David Tolnay7db73692019-10-20 14:51:12 -04008use syn::{Error, Result};
9
David Tolnay26a2a1d2020-03-25 17:26:43 -070010struct Check<'a> {
11 apis: &'a [Api],
12 types: &'a Types<'a>,
13 errors: &'a mut Vec<Error>,
14}
15
David Tolnay7db73692019-10-20 14:51:12 -040016pub(crate) fn typecheck(apis: &[Api], types: &Types) -> Result<()> {
David Tolnay26a2a1d2020-03-25 17:26:43 -070017 let mut errors = Vec::new();
18 let mut cx = Check {
19 apis,
20 types,
21 errors: &mut errors,
22 };
23 do_typecheck(&mut cx);
24 combine_errors(errors)
25}
David Tolnay7db73692019-10-20 14:51:12 -040026
David Tolnay26a2a1d2020-03-25 17:26:43 -070027fn do_typecheck(cx: &mut Check) {
28 for ty in cx.types {
David Tolnay7db73692019-10-20 14:51:12 -040029 match ty {
David Tolnay26a2a1d2020-03-25 17:26:43 -070030 Type::Ident(ident) => check_type_ident(cx, ident),
31 Type::RustBox(ptr) => check_type_box(cx, ptr),
David Tolnayc6d891e2020-04-25 12:06:34 -070032 Type::RustVec(ty) => check_type_rust_vec(cx, ty),
David Tolnay26a2a1d2020-03-25 17:26:43 -070033 Type::UniquePtr(ptr) => check_type_unique_ptr(cx, ptr),
David Tolnayfff4c8a2020-04-25 11:45:20 -070034 Type::CxxVector(ptr) => check_type_cxx_vector(cx, ptr),
David Tolnay26a2a1d2020-03-25 17:26:43 -070035 Type::Ref(ty) => check_type_ref(cx, ty),
David Tolnayeebe9b72020-04-14 16:32:18 -070036 Type::Slice(ty) => check_type_slice(cx, ty),
David Tolnay7db73692019-10-20 14:51:12 -040037 _ => {}
38 }
39 }
40
David Tolnay26a2a1d2020-03-25 17:26:43 -070041 for api in cx.apis {
David Tolnay7db73692019-10-20 14:51:12 -040042 match api {
David Tolnay26a2a1d2020-03-25 17:26:43 -070043 Api::Struct(strct) => check_api_struct(cx, strct),
David Tolnay0b368ae2020-04-22 17:55:02 -070044 Api::CxxType(ty) | Api::RustType(ty) => check_api_type(cx, ty),
David Tolnay26a2a1d2020-03-25 17:26:43 -070045 Api::CxxFunction(efn) | Api::RustFunction(efn) => check_api_fn(cx, efn),
David Tolnay7db73692019-10-20 14:51:12 -040046 _ => {}
47 }
48 }
49
David Tolnay26a2a1d2020-03-25 17:26:43 -070050 for api in cx.apis {
David Tolnay7db73692019-10-20 14:51:12 -040051 if let Api::CxxFunction(efn) = api {
David Tolnay26a2a1d2020-03-25 17:26:43 -070052 check_mut_return_restriction(cx, efn);
David Tolnay7db73692019-10-20 14:51:12 -040053 }
54 if let Api::CxxFunction(efn) | Api::RustFunction(efn) = api {
David Tolnay26a2a1d2020-03-25 17:26:43 -070055 check_multiple_arg_lifetimes(cx, efn);
David Tolnay7db73692019-10-20 14:51:12 -040056 }
57 }
58
David Tolnay26a2a1d2020-03-25 17:26:43 -070059 ident::check_all(cx.apis, cx.errors);
David Tolnay7db73692019-10-20 14:51:12 -040060}
61
David Tolnaya420f012020-03-25 17:55:56 -070062impl Check<'_> {
63 fn error(&mut self, sp: impl ToTokens, msg: impl Display) {
64 self.errors.push(Error::new_spanned(sp, msg));
65 }
66}
67
David Tolnay26a2a1d2020-03-25 17:26:43 -070068fn check_type_ident(cx: &mut Check, ident: &Ident) {
David Tolnayd4e68302020-03-25 12:04:17 -070069 if Atom::from(ident).is_none()
David Tolnay26a2a1d2020-03-25 17:26:43 -070070 && !cx.types.structs.contains_key(ident)
71 && !cx.types.cxx.contains(ident)
72 && !cx.types.rust.contains(ident)
David Tolnayd4e68302020-03-25 12:04:17 -070073 {
David Tolnaya420f012020-03-25 17:55:56 -070074 cx.error(ident, "unsupported type");
David Tolnayd4e68302020-03-25 12:04:17 -070075 }
76}
77
David Tolnay26a2a1d2020-03-25 17:26:43 -070078fn check_type_box(cx: &mut Check, ptr: &Ty1) {
David Tolnayd4e68302020-03-25 12:04:17 -070079 if let Type::Ident(ident) = &ptr.inner {
David Tolnay26a2a1d2020-03-25 17:26:43 -070080 if cx.types.cxx.contains(ident) {
David Tolnaya420f012020-03-25 17:55:56 -070081 cx.error(ptr, error::BOX_CXX_TYPE.msg);
David Tolnayd4e68302020-03-25 12:04:17 -070082 }
David Tolnaya420f012020-03-25 17:55:56 -070083
David Tolnayd4e68302020-03-25 12:04:17 -070084 if Atom::from(ident).is_none() {
85 return;
86 }
87 }
David Tolnaya420f012020-03-25 17:55:56 -070088
89 cx.error(ptr, "unsupported target type of Box");
David Tolnayd4e68302020-03-25 12:04:17 -070090}
91
David Tolnayc6d891e2020-04-25 12:06:34 -070092fn check_type_rust_vec(cx: &mut Check, ty: &Ty1) {
93 if let Type::Ident(ident) = &ty.inner {
94 if cx.types.cxx.contains(ident) {
95 cx.error(ty, "Rust Vec containing C++ type is not supported yet");
Myron Ahneba35cf2020-02-05 19:41:51 +070096 return;
David Tolnayc6d891e2020-04-25 12:06:34 -070097 }
98
99 match Atom::from(ident) {
100 Some(atom) if is_valid_vector_element(atom) => return,
101 None => return,
102 _ => {}
Myron Ahneba35cf2020-02-05 19:41:51 +0700103 }
104 }
105
David Tolnayc6d891e2020-04-25 12:06:34 -0700106 cx.error(ty, "unsupported element type of Vec");
Myron Ahneba35cf2020-02-05 19:41:51 +0700107}
108
David Tolnay26a2a1d2020-03-25 17:26:43 -0700109fn check_type_unique_ptr(cx: &mut Check, ptr: &Ty1) {
David Tolnayd4e68302020-03-25 12:04:17 -0700110 if let Type::Ident(ident) = &ptr.inner {
David Tolnay26a2a1d2020-03-25 17:26:43 -0700111 if cx.types.rust.contains(ident) {
David Tolnaya420f012020-03-25 17:55:56 -0700112 cx.error(ptr, "unique_ptr of a Rust type is not supported yet");
David Tolnayd4e68302020-03-25 12:04:17 -0700113 }
David Tolnaya420f012020-03-25 17:55:56 -0700114
David Tolnayd4e68302020-03-25 12:04:17 -0700115 match Atom::from(ident) {
116 None | Some(CxxString) => return,
117 _ => {}
118 }
David Tolnay4377a9e2020-04-24 15:20:26 -0700119 } else if let Type::CxxVector(_) = &ptr.inner {
Myron Ahneba35cf2020-02-05 19:41:51 +0700120 return;
David Tolnayd4e68302020-03-25 12:04:17 -0700121 }
David Tolnaya420f012020-03-25 17:55:56 -0700122
123 cx.error(ptr, "unsupported unique_ptr target type");
David Tolnayd4e68302020-03-25 12:04:17 -0700124}
125
David Tolnayfff4c8a2020-04-25 11:45:20 -0700126fn check_type_cxx_vector(cx: &mut Check, ptr: &Ty1) {
Myron Ahneba35cf2020-02-05 19:41:51 +0700127 if let Type::Ident(ident) = &ptr.inner {
128 if cx.types.rust.contains(ident) {
129 cx.error(ptr, "vector of a Rust type is not supported yet");
130 }
131
132 match Atom::from(ident) {
133 None => return,
134 Some(atom) => {
David Tolnay2410aff2020-04-25 12:05:57 -0700135 if is_valid_vector_element(atom) {
Myron Ahneba35cf2020-02-05 19:41:51 +0700136 return;
137 }
138 }
139 }
140 }
141 cx.error(ptr, "unsupported vector target type");
142}
143
David Tolnay26a2a1d2020-03-25 17:26:43 -0700144fn check_type_ref(cx: &mut Check, ty: &Ref) {
David Tolnayd763f4c2020-04-22 16:09:19 -0700145 if ty.lifetime.is_some() {
146 cx.error(ty, "references with explicit lifetimes are not supported");
147 }
148
David Tolnayd7e1f1e2020-03-18 21:06:37 -0700149 match ty.inner {
150 Type::Fn(_) | Type::Void(_) => {}
151 _ => return,
David Tolnayd4e68302020-03-25 12:04:17 -0700152 }
David Tolnayd7e1f1e2020-03-18 21:06:37 -0700153
154 cx.error(ty, "unsupported reference type");
David Tolnayd4e68302020-03-25 12:04:17 -0700155}
156
David Tolnayeebe9b72020-04-14 16:32:18 -0700157fn check_type_slice(cx: &mut Check, ty: &Slice) {
158 cx.error(ty, "only &[u8] is supported so far, not other slice types");
159}
160
David Tolnay26a2a1d2020-03-25 17:26:43 -0700161fn check_api_struct(cx: &mut Check, strct: &Struct) {
David Tolnay0b368ae2020-04-22 17:55:02 -0700162 check_reserved_name(cx, &strct.ident);
163
David Tolnayd4e68302020-03-25 12:04:17 -0700164 if strct.fields.is_empty() {
David Tolnaya420f012020-03-25 17:55:56 -0700165 let span = span_for_struct_error(strct);
166 cx.error(span, "structs without any fields are not supported");
David Tolnayd4e68302020-03-25 12:04:17 -0700167 }
David Tolnaya420f012020-03-25 17:55:56 -0700168
David Tolnayd4e68302020-03-25 12:04:17 -0700169 for field in &strct.fields {
David Tolnay26a2a1d2020-03-25 17:26:43 -0700170 if is_unsized(cx, &field.ty) {
David Tolnaya420f012020-03-25 17:55:56 -0700171 let desc = describe(cx, &field.ty);
172 let msg = format!("using {} by value is not supported", desc);
173 cx.error(field, msg);
David Tolnayd4e68302020-03-25 12:04:17 -0700174 }
David Tolnayd7e1f1e2020-03-18 21:06:37 -0700175 if let Type::Fn(_) = field.ty {
176 cx.error(
177 field,
178 "function pointers in a struct field are not implemented yet",
179 );
180 }
David Tolnayd4e68302020-03-25 12:04:17 -0700181 }
182}
183
David Tolnay0b368ae2020-04-22 17:55:02 -0700184fn check_api_type(cx: &mut Check, ty: &ExternType) {
185 check_reserved_name(cx, &ty.ident);
186}
187
David Tolnay26a2a1d2020-03-25 17:26:43 -0700188fn check_api_fn(cx: &mut Check, efn: &ExternFn) {
David Tolnayd763f4c2020-04-22 16:09:19 -0700189 if let Some(receiver) = &efn.receiver {
David Tolnaya1f29c42020-04-22 18:01:38 -0700190 let ref span = span_for_receiver_error(receiver);
191
192 if receiver.ty == "Self" {
193 let mutability = match receiver.mutability {
194 Some(_) => "mut ",
195 None => "",
196 };
197 let msg = format!(
198 "unnamed receiver type is only allowed if the surrounding \
199 extern block contains exactly one extern type; \
200 use `self: &{mutability}TheType`",
201 mutability = mutability,
202 );
203 cx.error(span, msg);
204 } else if !cx.types.structs.contains_key(&receiver.ty)
David Tolnay8b60bf12020-04-22 16:52:19 -0700205 && !cx.types.cxx.contains(&receiver.ty)
206 && !cx.types.rust.contains(&receiver.ty)
207 {
David Tolnay8b60bf12020-04-22 16:52:19 -0700208 cx.error(span, "unrecognized receiver type");
209 }
210
David Tolnayd763f4c2020-04-22 16:09:19 -0700211 if receiver.lifetime.is_some() {
David Tolnayd763f4c2020-04-22 16:09:19 -0700212 cx.error(span, "references with explicit lifetimes are not supported");
213 }
214 }
215
David Tolnayd4e68302020-03-25 12:04:17 -0700216 for arg in &efn.args {
David Tolnay26a2a1d2020-03-25 17:26:43 -0700217 if is_unsized(cx, &arg.ty) {
David Tolnaya420f012020-03-25 17:55:56 -0700218 let desc = describe(cx, &arg.ty);
219 let msg = format!("passing {} by value is not supported", desc);
220 cx.error(arg, msg);
David Tolnayd4e68302020-03-25 12:04:17 -0700221 }
David Tolnayd7e1f1e2020-03-18 21:06:37 -0700222 if let Type::Fn(_) = arg.ty {
David Tolnay75dca2e2020-03-25 20:17:52 -0700223 if efn.lang == Lang::Rust {
224 cx.error(
225 arg,
226 "passing a function pointer from C++ to Rust is not implemented yet",
227 );
228 }
David Tolnayd7e1f1e2020-03-18 21:06:37 -0700229 }
David Tolnayd4e68302020-03-25 12:04:17 -0700230 }
David Tolnaya420f012020-03-25 17:55:56 -0700231
David Tolnayd4e68302020-03-25 12:04:17 -0700232 if let Some(ty) = &efn.ret {
David Tolnay26a2a1d2020-03-25 17:26:43 -0700233 if is_unsized(cx, ty) {
David Tolnaya420f012020-03-25 17:55:56 -0700234 let desc = describe(cx, ty);
235 let msg = format!("returning {} by value is not supported", desc);
236 cx.error(ty, msg);
David Tolnayd4e68302020-03-25 12:04:17 -0700237 }
David Tolnayd7e1f1e2020-03-18 21:06:37 -0700238 if let Type::Fn(_) = ty {
239 cx.error(ty, "returning a function pointer is not implemented yet");
240 }
David Tolnayd4e68302020-03-25 12:04:17 -0700241 }
David Tolnay7db73692019-10-20 14:51:12 -0400242}
243
David Tolnay26a2a1d2020-03-25 17:26:43 -0700244fn check_mut_return_restriction(cx: &mut Check, efn: &ExternFn) {
David Tolnay7db73692019-10-20 14:51:12 -0400245 match &efn.ret {
246 Some(Type::Ref(ty)) if ty.mutability.is_some() => {}
David Tolnay26a2a1d2020-03-25 17:26:43 -0700247 _ => return,
David Tolnay7db73692019-10-20 14:51:12 -0400248 }
249
250 for arg in &efn.args {
251 if let Type::Ref(ty) = &arg.ty {
252 if ty.mutability.is_some() {
David Tolnay26a2a1d2020-03-25 17:26:43 -0700253 return;
David Tolnay7db73692019-10-20 14:51:12 -0400254 }
255 }
256 }
257
David Tolnaya420f012020-03-25 17:55:56 -0700258 cx.error(
David Tolnay7db73692019-10-20 14:51:12 -0400259 efn,
260 "&mut return type is not allowed unless there is a &mut argument",
David Tolnaya420f012020-03-25 17:55:56 -0700261 );
David Tolnay7db73692019-10-20 14:51:12 -0400262}
263
David Tolnay26a2a1d2020-03-25 17:26:43 -0700264fn check_multiple_arg_lifetimes(cx: &mut Check, efn: &ExternFn) {
David Tolnay7db73692019-10-20 14:51:12 -0400265 match &efn.ret {
266 Some(Type::Ref(_)) => {}
David Tolnay26a2a1d2020-03-25 17:26:43 -0700267 _ => return,
David Tolnay7db73692019-10-20 14:51:12 -0400268 }
269
270 let mut reference_args = 0;
271 for arg in &efn.args {
272 if let Type::Ref(_) = &arg.ty {
273 reference_args += 1;
274 }
275 }
276
Joel Galenson3d4f6122020-04-07 15:54:05 -0700277 if efn.receiver.is_some() {
278 reference_args += 1;
279 }
280
David Tolnay26a2a1d2020-03-25 17:26:43 -0700281 if reference_args != 1 {
David Tolnaya420f012020-03-25 17:55:56 -0700282 cx.error(
David Tolnay7db73692019-10-20 14:51:12 -0400283 efn,
284 "functions that return a reference must take exactly one input reference",
David Tolnaya420f012020-03-25 17:55:56 -0700285 );
David Tolnay7db73692019-10-20 14:51:12 -0400286 }
287}
288
David Tolnay0b368ae2020-04-22 17:55:02 -0700289fn check_reserved_name(cx: &mut Check, ident: &Ident) {
290 if ident == "Box" || ident == "UniquePtr" || Atom::from(ident).is_some() {
291 cx.error(ident, "reserved name");
292 }
293}
294
David Tolnay26a2a1d2020-03-25 17:26:43 -0700295fn is_unsized(cx: &mut Check, ty: &Type) -> bool {
David Tolnayd4e68302020-03-25 12:04:17 -0700296 let ident = match ty {
297 Type::Ident(ident) => ident,
David Tolnayeebe9b72020-04-14 16:32:18 -0700298 Type::Slice(_) | Type::Void(_) => return true,
David Tolnayd4e68302020-03-25 12:04:17 -0700299 _ => return false,
300 };
David Tolnay26a2a1d2020-03-25 17:26:43 -0700301 ident == CxxString || cx.types.cxx.contains(ident) || cx.types.rust.contains(ident)
302}
303
David Tolnay2410aff2020-04-25 12:05:57 -0700304fn is_valid_vector_element(atom: Atom) -> bool {
David Tolnay76a84242020-04-25 11:58:30 -0700305 match atom {
306 U8 | U16 | U32 | U64 | Usize | I8 | I16 | I32 | I64 | Isize | F32 | F64 => true,
307 Bool | CxxString | RustString => false,
308 }
David Tolnay7ff1b8c2020-04-25 11:44:26 -0700309}
310
David Tolnaya420f012020-03-25 17:55:56 -0700311fn span_for_struct_error(strct: &Struct) -> TokenStream {
312 let struct_token = strct.struct_token;
313 let mut brace_token = Group::new(Delimiter::Brace, TokenStream::new());
314 brace_token.set_span(strct.brace_token.span);
315 quote!(#struct_token #brace_token)
316}
317
David Tolnayd763f4c2020-04-22 16:09:19 -0700318fn span_for_receiver_error(receiver: &Receiver) -> TokenStream {
319 let ampersand = receiver.ampersand;
320 let lifetime = &receiver.lifetime;
321 let mutability = receiver.mutability;
322 if receiver.shorthand {
323 let var = receiver.var;
324 quote!(#ampersand #lifetime #mutability #var)
325 } else {
326 let ty = &receiver.ty;
327 quote!(#ampersand #lifetime #mutability #ty)
328 }
329}
330
David Tolnay26a2a1d2020-03-25 17:26:43 -0700331fn combine_errors(errors: Vec<Error>) -> Result<()> {
332 let mut iter = errors.into_iter();
333 let mut all_errors = match iter.next() {
334 Some(err) => err,
335 None => return Ok(()),
336 };
337 for err in iter {
338 all_errors.combine(err);
339 }
340 Err(all_errors)
David Tolnayd4e68302020-03-25 12:04:17 -0700341}
342
David Tolnaya420f012020-03-25 17:55:56 -0700343fn describe(cx: &mut Check, ty: &Type) -> String {
David Tolnay7db73692019-10-20 14:51:12 -0400344 match ty {
345 Type::Ident(ident) => {
David Tolnaya420f012020-03-25 17:55:56 -0700346 if cx.types.structs.contains_key(ident) {
David Tolnay7db73692019-10-20 14:51:12 -0400347 "struct".to_owned()
David Tolnaya420f012020-03-25 17:55:56 -0700348 } else if cx.types.cxx.contains(ident) {
David Tolnay7db73692019-10-20 14:51:12 -0400349 "C++ type".to_owned()
David Tolnaya420f012020-03-25 17:55:56 -0700350 } else if cx.types.rust.contains(ident) {
David Tolnay7db73692019-10-20 14:51:12 -0400351 "opaque Rust type".to_owned()
352 } else if Atom::from(ident) == Some(CxxString) {
353 "C++ string".to_owned()
354 } else {
355 ident.to_string()
356 }
357 }
358 Type::RustBox(_) => "Box".to_owned(),
Myron Ahneba35cf2020-02-05 19:41:51 +0700359 Type::RustVec(_) => "Vec".to_owned(),
David Tolnay7db73692019-10-20 14:51:12 -0400360 Type::UniquePtr(_) => "unique_ptr".to_owned(),
361 Type::Ref(_) => "reference".to_owned(),
362 Type::Str(_) => "&str".to_owned(),
David Tolnay4377a9e2020-04-24 15:20:26 -0700363 Type::CxxVector(_) => "vector".to_owned(),
Adrian Taylorf5dd5522020-04-13 16:50:14 -0700364 Type::Slice(_) => "slice".to_owned(),
365 Type::SliceRefU8(_) => "&[u8]".to_owned(),
David Tolnay417305a2020-03-18 13:54:00 -0700366 Type::Fn(_) => "function pointer".to_owned(),
David Tolnay2fb14e92020-03-15 23:11:38 -0700367 Type::Void(_) => "()".to_owned(),
David Tolnay7db73692019-10-20 14:51:12 -0400368 }
369}