| Adrian Taylor | 121cca4 | 2020-10-10 15:32:00 -0700 | [diff] [blame] | 1 | use cxx_test_suite::extra::ffi2; |
| David Tolnay | 362c9f9 | 2020-10-10 16:29:58 -0700 | [diff] [blame] | 2 | use cxx_test_suite::ffi; |
| David Tolnay | 3fd7f56 | 2020-01-26 17:47:11 -0800 | [diff] [blame] | 3 | use std::cell::Cell; |
| David Tolnay | f306da4 | 2020-02-22 19:55:43 -0800 | [diff] [blame] | 4 | use std::ffi::CStr; |
| David Tolnay | 3fd7f56 | 2020-01-26 17:47:11 -0800 | [diff] [blame] | 5 | |
| 6 | thread_local! { |
| 7 | static CORRECT: Cell<bool> = Cell::new(false); |
| 8 | } |
| 9 | |
| 10 | #[no_mangle] |
| 11 | extern "C" fn cxx_test_suite_set_correct() { |
| 12 | CORRECT.with(|correct| correct.set(true)); |
| 13 | } |
| 14 | |
| David Tolnay | f306da4 | 2020-02-22 19:55:43 -0800 | [diff] [blame] | 15 | macro_rules! check { |
| 16 | ($run:expr) => {{ |
| 17 | CORRECT.with(|correct| correct.set(false)); |
| 18 | $run; |
| 19 | assert!(CORRECT.with(|correct| correct.get()), stringify!($run)); |
| 20 | }}; |
| 21 | } |
| 22 | |
| David Tolnay | 3fd7f56 | 2020-01-26 17:47:11 -0800 | [diff] [blame] | 23 | #[test] |
| 24 | fn test_c_return() { |
| 25 | let shared = ffi::Shared { z: 2020 }; |
| Adrian Taylor | 9a158e4 | 2020-10-24 20:51:25 -0700 | [diff] [blame] | 26 | let ns_shared = ffi::AShared { z: 2020 }; |
| 27 | let nested_ns_shared = ffi::ABShared { z: 2020 }; |
| David Tolnay | 3fd7f56 | 2020-01-26 17:47:11 -0800 | [diff] [blame] | 28 | |
| 29 | assert_eq!(2020, ffi::c_return_primitive()); |
| 30 | assert_eq!(2020, ffi::c_return_shared().z); |
| David Tolnay | be13d8a | 2020-03-06 15:45:39 -0800 | [diff] [blame] | 31 | assert_eq!(2020, *ffi::c_return_box()); |
| David Tolnay | 3fd7f56 | 2020-01-26 17:47:11 -0800 | [diff] [blame] | 32 | ffi::c_return_unique_ptr(); |
| Adrian Taylor | d47af7a | 2020-10-26 13:18:48 -0700 | [diff] [blame] | 33 | ffi2::c_return_ns_unique_ptr(); |
| David Tolnay | 3fd7f56 | 2020-01-26 17:47:11 -0800 | [diff] [blame] | 34 | assert_eq!(2020, *ffi::c_return_ref(&shared)); |
| Adrian Taylor | 9a158e4 | 2020-10-24 20:51:25 -0700 | [diff] [blame] | 35 | assert_eq!(2020, *ffi::c_return_ns_ref(&ns_shared)); |
| 36 | assert_eq!(2020, *ffi::c_return_nested_ns_ref(&nested_ns_shared)); |
| David Tolnay | 3fd7f56 | 2020-01-26 17:47:11 -0800 | [diff] [blame] | 37 | assert_eq!("2020", ffi::c_return_str(&shared)); |
| Adrian Taylor | ec9430e | 2020-04-14 16:09:58 -0700 | [diff] [blame] | 38 | assert_eq!(b"2020\0", ffi::c_return_sliceu8(&shared)); |
| David Tolnay | 3fd7f56 | 2020-01-26 17:47:11 -0800 | [diff] [blame] | 39 | assert_eq!("2020", ffi::c_return_rust_string()); |
| David Tolnay | 5e29b21 | 2020-04-17 15:02:16 -0700 | [diff] [blame] | 40 | assert_eq!("2020", ffi::c_return_unique_ptr_string().to_str().unwrap()); |
| David Tolnay | c01d0a0 | 2020-04-24 13:30:44 -0700 | [diff] [blame] | 41 | assert_eq!(4, ffi::c_return_unique_ptr_vector_u8().len()); |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 42 | assert_eq!( |
| 43 | 200_u8, |
| David Tolnay | 4f6dd4e | 2020-04-25 13:08:38 -0700 | [diff] [blame] | 44 | ffi::c_return_unique_ptr_vector_u8().into_iter().sum(), |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 45 | ); |
| 46 | assert_eq!( |
| 47 | 200.5_f64, |
| David Tolnay | 4f6dd4e | 2020-04-25 13:08:38 -0700 | [diff] [blame] | 48 | ffi::c_return_unique_ptr_vector_f64().into_iter().sum(), |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 49 | ); |
| David Tolnay | c01d0a0 | 2020-04-24 13:30:44 -0700 | [diff] [blame] | 50 | assert_eq!(2, ffi::c_return_unique_ptr_vector_shared().len()); |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 51 | assert_eq!( |
| 52 | 2021_usize, |
| 53 | ffi::c_return_unique_ptr_vector_shared() |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 54 | .into_iter() |
| 55 | .map(|o| o.z) |
| David Tolnay | 4f6dd4e | 2020-04-25 13:08:38 -0700 | [diff] [blame] | 56 | .sum(), |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 57 | ); |
| Joel Galenson | ba67607 | 2020-04-27 15:55:45 -0700 | [diff] [blame] | 58 | assert_eq!(2020, ffi::c_return_identity(2020)); |
| 59 | assert_eq!(2021, ffi::c_return_sum(2020, 1)); |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 60 | match ffi::c_return_enum(0) { |
| Joel Galenson | db1ec31 | 2020-05-01 13:57:32 -0700 | [diff] [blame] | 61 | enm @ ffi::Enum::AVal => assert_eq!(0, enm.repr), |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 62 | _ => assert!(false), |
| 63 | } |
| 64 | match ffi::c_return_enum(1) { |
| Joel Galenson | db1ec31 | 2020-05-01 13:57:32 -0700 | [diff] [blame] | 65 | enm @ ffi::Enum::BVal => assert_eq!(2020, enm.repr), |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 66 | _ => assert!(false), |
| 67 | } |
| 68 | match ffi::c_return_enum(2021) { |
| Joel Galenson | db1ec31 | 2020-05-01 13:57:32 -0700 | [diff] [blame] | 69 | enm @ ffi::Enum::CVal => assert_eq!(2021, enm.repr), |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 70 | _ => assert!(false), |
| 71 | } |
| Adrian Taylor | 9a158e4 | 2020-10-24 20:51:25 -0700 | [diff] [blame] | 72 | match ffi::c_return_ns_enum(0) { |
| 73 | enm @ ffi::AEnum::AAVal => assert_eq!(0, enm.repr), |
| 74 | _ => assert!(false), |
| 75 | } |
| 76 | match ffi::c_return_nested_ns_enum(0) { |
| 77 | enm @ ffi::ABEnum::ABAVal => assert_eq!(0, enm.repr), |
| 78 | _ => assert!(false), |
| 79 | } |
| David Tolnay | 9964262 | 2020-03-25 13:07:35 -0700 | [diff] [blame] | 80 | } |
| David Tolnay | ebef4a2 | 2020-03-17 15:33:47 -0700 | [diff] [blame] | 81 | |
| David Tolnay | 9964262 | 2020-03-25 13:07:35 -0700 | [diff] [blame] | 82 | #[test] |
| 83 | fn test_c_try_return() { |
| David Tolnay | ebef4a2 | 2020-03-17 15:33:47 -0700 | [diff] [blame] | 84 | assert_eq!((), ffi::c_try_return_void().unwrap()); |
| 85 | assert_eq!(2020, ffi::c_try_return_primitive().unwrap()); |
| 86 | assert_eq!( |
| 87 | "logic error", |
| 88 | ffi::c_fail_return_primitive().unwrap_err().what(), |
| 89 | ); |
| David Tolnay | 9964262 | 2020-03-25 13:07:35 -0700 | [diff] [blame] | 90 | assert_eq!(2020, *ffi::c_try_return_box().unwrap()); |
| 91 | assert_eq!("2020", *ffi::c_try_return_ref(&"2020".to_owned()).unwrap()); |
| 92 | assert_eq!("2020", ffi::c_try_return_str("2020").unwrap()); |
| Adrian Taylor | ec9430e | 2020-04-14 16:09:58 -0700 | [diff] [blame] | 93 | assert_eq!(b"2020", ffi::c_try_return_sliceu8(b"2020").unwrap()); |
| David Tolnay | 9964262 | 2020-03-25 13:07:35 -0700 | [diff] [blame] | 94 | assert_eq!("2020", ffi::c_try_return_rust_string().unwrap()); |
| David Tolnay | 5e29b21 | 2020-04-17 15:02:16 -0700 | [diff] [blame] | 95 | assert_eq!("2020", &*ffi::c_try_return_unique_ptr_string().unwrap()); |
| David Tolnay | 3fd7f56 | 2020-01-26 17:47:11 -0800 | [diff] [blame] | 96 | } |
| 97 | |
| 98 | #[test] |
| 99 | fn test_c_take() { |
| David Tolnay | 3fd7f56 | 2020-01-26 17:47:11 -0800 | [diff] [blame] | 100 | let unique_ptr = ffi::c_return_unique_ptr(); |
| Adrian Taylor | d47af7a | 2020-10-26 13:18:48 -0700 | [diff] [blame] | 101 | let unique_ptr_ns = ffi2::c_return_ns_unique_ptr(); |
| David Tolnay | 3fd7f56 | 2020-01-26 17:47:11 -0800 | [diff] [blame] | 102 | |
| 103 | check!(ffi::c_take_primitive(2020)); |
| 104 | check!(ffi::c_take_shared(ffi::Shared { z: 2020 })); |
| Adrian Taylor | 9a158e4 | 2020-10-24 20:51:25 -0700 | [diff] [blame] | 105 | check!(ffi::c_take_ns_shared(ffi::AShared { z: 2020 })); |
| Adrian Taylor | ddc146e | 2020-10-25 21:40:17 -0700 | [diff] [blame^] | 106 | check!(ffi::ns_c_take_ns_shared(ffi::AShared { z: 2020 })); |
| Adrian Taylor | 9a158e4 | 2020-10-24 20:51:25 -0700 | [diff] [blame] | 107 | check!(ffi::c_take_nested_ns_shared(ffi::ABShared { z: 2020 })); |
| David Tolnay | be13d8a | 2020-03-06 15:45:39 -0800 | [diff] [blame] | 108 | check!(ffi::c_take_box(Box::new(2020))); |
| David Tolnay | 5e29b21 | 2020-04-17 15:02:16 -0700 | [diff] [blame] | 109 | check!(ffi::c_take_ref_c(&unique_ptr)); |
| Adrian Taylor | d47af7a | 2020-10-26 13:18:48 -0700 | [diff] [blame] | 110 | check!(ffi2::c_take_ref_ns_c(&unique_ptr_ns)); |
| David Tolnay | a62cca2 | 2020-05-07 21:52:16 -0700 | [diff] [blame] | 111 | check!(cxx_test_suite::module::ffi::c_take_unique_ptr(unique_ptr)); |
| David Tolnay | 3fd7f56 | 2020-01-26 17:47:11 -0800 | [diff] [blame] | 112 | check!(ffi::c_take_str("2020")); |
| Adrian Taylor | f5dd552 | 2020-04-13 16:50:14 -0700 | [diff] [blame] | 113 | check!(ffi::c_take_sliceu8(b"2020")); |
| David Tolnay | 3fd7f56 | 2020-01-26 17:47:11 -0800 | [diff] [blame] | 114 | check!(ffi::c_take_rust_string("2020".to_owned())); |
| 115 | check!(ffi::c_take_unique_ptr_string( |
| 116 | ffi::c_return_unique_ptr_string() |
| 117 | )); |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 118 | check!(ffi::c_take_unique_ptr_vector_u8( |
| 119 | ffi::c_return_unique_ptr_vector_u8() |
| 120 | )); |
| 121 | check!(ffi::c_take_unique_ptr_vector_f64( |
| 122 | ffi::c_return_unique_ptr_vector_f64() |
| 123 | )); |
| 124 | check!(ffi::c_take_unique_ptr_vector_shared( |
| 125 | ffi::c_return_unique_ptr_vector_shared() |
| 126 | )); |
| David Tolnay | 2244d1f | 2020-04-25 13:58:18 -0700 | [diff] [blame] | 127 | check!(ffi::c_take_ref_vector(&ffi::c_return_unique_ptr_vector_u8())); |
| myronahn | da9be50 | 2020-04-29 05:47:23 +0700 | [diff] [blame] | 128 | let test_vec = [86_u8, 75_u8, 30_u8, 9_u8].to_vec(); |
| 129 | check!(ffi::c_take_rust_vec(test_vec.clone())); |
| Stephen Crane | 9e48d5b | 2020-08-21 12:17:02 -0700 | [diff] [blame] | 130 | check!(ffi::c_take_rust_vec_index(test_vec.clone())); |
| David Tolnay | a7ba6a6 | 2020-08-26 22:33:17 -0700 | [diff] [blame] | 131 | let shared_test_vec = vec![ffi::Shared { z: 1010 }, ffi::Shared { z: 1011 }]; |
| Stephen Crane | 9e48d5b | 2020-08-21 12:17:02 -0700 | [diff] [blame] | 132 | check!(ffi::c_take_rust_vec_shared(shared_test_vec.clone())); |
| 133 | check!(ffi::c_take_rust_vec_shared_index(shared_test_vec.clone())); |
| David Tolnay | a7ba6a6 | 2020-08-26 22:33:17 -0700 | [diff] [blame] | 134 | check!(ffi::c_take_rust_vec_shared_forward_iterator( |
| 135 | shared_test_vec, |
| 136 | )); |
| myronahn | da9be50 | 2020-04-29 05:47:23 +0700 | [diff] [blame] | 137 | check!(ffi::c_take_ref_rust_vec(&test_vec)); |
| Stephen Crane | 9e48d5b | 2020-08-21 12:17:02 -0700 | [diff] [blame] | 138 | check!(ffi::c_take_ref_rust_vec_index(&test_vec)); |
| myronahn | da9be50 | 2020-04-29 05:47:23 +0700 | [diff] [blame] | 139 | check!(ffi::c_take_ref_rust_vec_copy(&test_vec)); |
| Adrian Taylor | 9a158e4 | 2020-10-24 20:51:25 -0700 | [diff] [blame] | 140 | let ns_shared_test_vec = vec![ffi::AShared { z: 1010 }, ffi::AShared { z: 1011 }]; |
| 141 | check!(ffi::c_take_rust_vec_ns_shared(ns_shared_test_vec)); |
| 142 | let nested_ns_shared_test_vec = vec![ffi::ABShared { z: 1010 }, ffi::ABShared { z: 1011 }]; |
| 143 | check!(ffi::c_take_rust_vec_nested_ns_shared( |
| 144 | nested_ns_shared_test_vec |
| 145 | )); |
| 146 | |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 147 | check!(ffi::c_take_enum(ffi::Enum::AVal)); |
| Adrian Taylor | 9a158e4 | 2020-10-24 20:51:25 -0700 | [diff] [blame] | 148 | check!(ffi::c_take_ns_enum(ffi::AEnum::AAVal)); |
| 149 | check!(ffi::c_take_nested_ns_enum(ffi::ABEnum::ABAVal)); |
| David Tolnay | 3fd7f56 | 2020-01-26 17:47:11 -0800 | [diff] [blame] | 150 | } |
| David Tolnay | f306da4 | 2020-02-22 19:55:43 -0800 | [diff] [blame] | 151 | |
| David Tolnay | 0c8c0f2 | 2020-07-21 17:57:46 -0700 | [diff] [blame] | 152 | /* |
| 153 | // https://github.com/dtolnay/cxx/issues/232 |
| David Tolnay | f306da4 | 2020-02-22 19:55:43 -0800 | [diff] [blame] | 154 | #[test] |
| David Tolnay | 75dca2e | 2020-03-25 20:17:52 -0700 | [diff] [blame] | 155 | fn test_c_callback() { |
| 156 | fn callback(s: String) -> usize { |
| 157 | if s == "2020" { |
| 158 | cxx_test_suite_set_correct(); |
| 159 | } |
| 160 | 0 |
| 161 | } |
| 162 | |
| 163 | check!(ffi::c_take_callback(callback)); |
| 164 | } |
| David Tolnay | 0c8c0f2 | 2020-07-21 17:57:46 -0700 | [diff] [blame] | 165 | */ |
| David Tolnay | 75dca2e | 2020-03-25 20:17:52 -0700 | [diff] [blame] | 166 | |
| 167 | #[test] |
| David Tolnay | f306da4 | 2020-02-22 19:55:43 -0800 | [diff] [blame] | 168 | fn test_c_call_r() { |
| 169 | fn cxx_run_test() { |
| 170 | extern "C" { |
| 171 | fn cxx_run_test() -> *const i8; |
| 172 | } |
| 173 | let failure = unsafe { cxx_run_test() }; |
| 174 | if !failure.is_null() { |
| Myron Ahn | d963bf9 | 2020-05-17 12:32:42 +0700 | [diff] [blame] | 175 | let msg = unsafe { CStr::from_ptr(failure as *mut std::os::raw::c_char) }; |
| David Tolnay | f306da4 | 2020-02-22 19:55:43 -0800 | [diff] [blame] | 176 | eprintln!("{}", msg.to_string_lossy()); |
| 177 | } |
| 178 | } |
| 179 | check!(cxx_run_test()); |
| 180 | } |
| David Tolnay | be13d8a | 2020-03-06 15:45:39 -0800 | [diff] [blame] | 181 | |
| Joel Galenson | 3d4f612 | 2020-04-07 15:54:05 -0700 | [diff] [blame] | 182 | #[test] |
| 183 | fn test_c_method_calls() { |
| 184 | let mut unique_ptr = ffi::c_return_unique_ptr(); |
| 185 | |
| David Tolnay | 5e29b21 | 2020-04-17 15:02:16 -0700 | [diff] [blame] | 186 | let old_value = unique_ptr.get(); |
| Joel Galenson | 3d4f612 | 2020-04-07 15:54:05 -0700 | [diff] [blame] | 187 | assert_eq!(2020, old_value); |
| David Tolnay | 5e29b21 | 2020-04-17 15:02:16 -0700 | [diff] [blame] | 188 | assert_eq!(2021, unique_ptr.set(2021)); |
| 189 | assert_eq!(2021, unique_ptr.get()); |
| Joel Galenson | e1e969d | 2020-04-21 12:50:20 -0700 | [diff] [blame] | 190 | assert_eq!(old_value, unique_ptr.set2(old_value)); |
| myronahn | e3b78ea | 2020-05-23 01:08:13 +0700 | [diff] [blame] | 191 | assert_eq!(old_value, unique_ptr.get2()); |
| David Tolnay | ae71436 | 2020-05-22 11:12:26 -0700 | [diff] [blame] | 192 | assert_eq!(2022, unique_ptr.set_succeed(2022).unwrap()); |
| myronahn | e3b78ea | 2020-05-23 01:08:13 +0700 | [diff] [blame] | 193 | assert!(unique_ptr.get_fail().is_err()); |
| Joel Galenson | 3d4f612 | 2020-04-07 15:54:05 -0700 | [diff] [blame] | 194 | } |
| 195 | |
| Joel Galenson | db1ec31 | 2020-05-01 13:57:32 -0700 | [diff] [blame] | 196 | #[test] |
| 197 | fn test_enum_representations() { |
| 198 | assert_eq!(0, ffi::Enum::AVal.repr); |
| 199 | assert_eq!(2020, ffi::Enum::BVal.repr); |
| 200 | assert_eq!(2021, ffi::Enum::CVal.repr); |
| 201 | } |
| 202 | |
| David Tolnay | be13d8a | 2020-03-06 15:45:39 -0800 | [diff] [blame] | 203 | #[no_mangle] |
| 204 | extern "C" fn cxx_test_suite_get_box() -> *mut cxx_test_suite::R { |
| 205 | Box::into_raw(Box::new(2020usize)) |
| 206 | } |
| David Tolnay | a7d00e8 | 2020-03-06 15:50:14 -0800 | [diff] [blame] | 207 | |
| 208 | #[no_mangle] |
| 209 | unsafe extern "C" fn cxx_test_suite_r_is_correct(r: *const cxx_test_suite::R) -> bool { |
| 210 | *r == 2020 |
| 211 | } |
| David Tolnay | 3bbcdbb | 2020-10-09 19:29:44 -0700 | [diff] [blame] | 212 | |
| 213 | #[test] |
| 214 | fn test_rust_name_attribute() { |
| 215 | assert_eq!("2020", ffi::i32_overloaded_function(2020)); |
| 216 | assert_eq!("2020", ffi::str_overloaded_function("2020")); |
| 217 | let unique_ptr = ffi::c_return_unique_ptr(); |
| 218 | assert_eq!("2020", unique_ptr.i32_overloaded_method(2020)); |
| 219 | assert_eq!("2020", unique_ptr.str_overloaded_method("2020")); |
| 220 | } |
| Adrian Taylor | 121cca4 | 2020-10-10 15:32:00 -0700 | [diff] [blame] | 221 | |
| 222 | #[test] |
| 223 | fn test_extern_trivial() { |
| 224 | let d = ffi2::c_return_trivial(); |
| 225 | check!(ffi2::c_take_trivial_ref(&d)); |
| 226 | check!(ffi2::c_take_trivial(d)); |
| 227 | let d = ffi2::c_return_trivial_ptr(); |
| 228 | check!(ffi2::c_take_trivial_ptr(d)); |
| Adrian Taylor | d75f7e2 | 2020-10-12 15:54:54 -0700 | [diff] [blame] | 229 | cxx::UniquePtr::new(ffi2::D { d: 42 }); |
| Adrian Taylor | ddc146e | 2020-10-25 21:40:17 -0700 | [diff] [blame^] | 230 | let d = ffi2::ns_c_return_trivial(); |
| 231 | check!(ffi2::ns_c_take_trivial(d)); |
| Adrian Taylor | 585bb0b | 2020-10-26 13:17:17 -0700 | [diff] [blame] | 232 | |
| 233 | let g = ffi2::c_return_trivial_ns(); |
| 234 | check!(ffi2::c_take_trivial_ns_ref(&g)); |
| 235 | check!(ffi2::c_take_trivial_ns(g)); |
| 236 | let g = ffi2::c_return_trivial_ns_ptr(); |
| 237 | check!(ffi2::c_take_trivial_ns_ptr(g)); |
| 238 | cxx::UniquePtr::new(ffi2::G { g: 42 }); |
| Adrian Taylor | 121cca4 | 2020-10-10 15:32:00 -0700 | [diff] [blame] | 239 | } |
| 240 | |
| 241 | #[test] |
| 242 | fn test_extern_opaque() { |
| 243 | let e = ffi2::c_return_opaque_ptr(); |
| 244 | check!(ffi2::c_take_opaque_ref(e.as_ref().unwrap())); |
| 245 | check!(ffi2::c_take_opaque_ptr(e)); |
| Adrian Taylor | 5e79c64 | 2020-10-24 21:09:42 -0700 | [diff] [blame] | 246 | |
| 247 | let f = ffi2::c_return_ns_opaque_ptr(); |
| 248 | check!(ffi2::c_take_opaque_ns_ref(f.as_ref().unwrap())); |
| 249 | check!(ffi2::c_take_opaque_ns_ptr(f)); |
| Adrian Taylor | 121cca4 | 2020-10-10 15:32:00 -0700 | [diff] [blame] | 250 | } |