rmistry@google.com | 8e3ff8c | 2013-01-17 12:55:34 +0000 | [diff] [blame] | 1 | # Copyright (c) 2013 The Chromium Authors. All rights reserved. |
| 2 | # Use of this source code is governed by a BSD-style license that can be |
| 3 | # found in the LICENSE file. |
| 4 | |
| 5 | |
| 6 | """Top-level presubmit script for Skia. |
| 7 | |
| 8 | See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
| 9 | for more details about the presubmit API built into gcl. |
| 10 | """ |
| 11 | |
rmistry | 5827653 | 2015-10-01 08:24:03 -0700 | [diff] [blame] | 12 | import collections |
rmistry | 3cfd1ad | 2015-03-25 12:53:35 -0700 | [diff] [blame] | 13 | import csv |
commit-bot@chromium.org | 745e08c | 2014-02-03 14:18:32 +0000 | [diff] [blame] | 14 | import fnmatch |
rmistry@google.com | f6c5f75 | 2013-03-29 17:26:00 +0000 | [diff] [blame] | 15 | import os |
commit-bot@chromium.org | cfdc596 | 2014-01-31 17:33:04 +0000 | [diff] [blame] | 16 | import re |
rmistry | d223fb2 | 2015-02-26 10:16:13 -0800 | [diff] [blame] | 17 | import subprocess |
rmistry@google.com | f6c5f75 | 2013-03-29 17:26:00 +0000 | [diff] [blame] | 18 | import sys |
commit-bot@chromium.org | 745e08c | 2014-02-03 14:18:32 +0000 | [diff] [blame] | 19 | import traceback |
rmistry@google.com | f6c5f75 | 2013-03-29 17:26:00 +0000 | [diff] [blame] | 20 | |
rmistry@google.com | c299344 | 2013-01-23 14:35:58 +0000 | [diff] [blame] | 21 | |
commit-bot@chromium.org | cfdc596 | 2014-01-31 17:33:04 +0000 | [diff] [blame] | 22 | REVERT_CL_SUBJECT_PREFIX = 'Revert ' |
| 23 | |
rmistry | f2d83ca | 2014-08-26 10:30:29 -0700 | [diff] [blame] | 24 | # Please add the complete email address here (and not just 'xyz@' or 'xyz'). |
rmistry@google.com | fb4a68d | 2013-08-12 14:51:20 +0000 | [diff] [blame] | 25 | PUBLIC_API_OWNERS = ( |
Mike Klein | 3f041f8 | 2021-02-03 09:36:14 -0600 | [diff] [blame] | 26 | 'brianosman@google.com', |
rmistry@google.com | fb4a68d | 2013-08-12 14:51:20 +0000 | [diff] [blame] | 27 | 'bsalomon@google.com', |
rmistry | 83fab47 | 2014-07-18 05:25:56 -0700 | [diff] [blame] | 28 | 'djsollen@chromium.org', |
| 29 | 'djsollen@google.com', |
Ravi Mistry | fbff329 | 2017-01-19 12:00:08 -0500 | [diff] [blame] | 30 | 'hcm@chromium.org', |
| 31 | 'hcm@google.com', |
Mike Klein | 3f041f8 | 2021-02-03 09:36:14 -0600 | [diff] [blame] | 32 | 'reed@chromium.org', |
| 33 | 'reed@google.com', |
rmistry@google.com | fb4a68d | 2013-08-12 14:51:20 +0000 | [diff] [blame] | 34 | ) |
| 35 | |
commit-bot@chromium.org | 745e08c | 2014-02-03 14:18:32 +0000 | [diff] [blame] | 36 | AUTHORS_FILE_NAME = 'AUTHORS' |
Ravi Mistry | 5773516 | 2019-07-25 13:45:15 -0400 | [diff] [blame] | 37 | RELEASE_NOTES_FILE_NAME = 'RELEASE_NOTES.txt' |
commit-bot@chromium.org | 745e08c | 2014-02-03 14:18:32 +0000 | [diff] [blame] | 38 | |
Ravi Mistry | 27095f2 | 2021-04-22 12:51:49 +0000 | [diff] [blame] | 39 | DOCS_PREVIEW_URL = 'https://skia.org/?cl={issue}' |
rmistry | d88b0be | 2016-05-20 03:50:01 -0700 | [diff] [blame] | 40 | GOLD_TRYBOT_URL = 'https://gold.skia.org/search?issue=' |
rmistry | d223fb2 | 2015-02-26 10:16:13 -0800 | [diff] [blame] | 41 | |
Eric Boren | 1eec99c | 2018-04-26 13:09:48 -0400 | [diff] [blame] | 42 | SERVICE_ACCOUNT_SUFFIX = [ |
Eric Boren | 47ed6f1 | 2018-04-26 14:02:43 -0400 | [diff] [blame] | 43 | '@%s.iam.gserviceaccount.com' % project for project in [ |
Eric Boren | 6ad3ca4 | 2018-09-07 14:22:16 -0400 | [diff] [blame] | 44 | 'skia-buildbots.google.com', 'skia-swarming-bots', 'skia-public', |
Ravi Mistry | 53c4423 | 2019-03-12 08:51:42 -0400 | [diff] [blame] | 45 | 'skia-corp.google.com', 'chops-service-accounts']] |
Eric Boren | dd98829 | 2018-01-02 13:29:21 -0500 | [diff] [blame] | 46 | |
rmistry@google.com | 547012d | 2013-04-12 19:45:46 +0000 | [diff] [blame] | 47 | |
rmistry@google.com | 713276b | 2013-01-25 18:27:34 +0000 | [diff] [blame] | 48 | def _CheckChangeHasEol(input_api, output_api, source_file_filter=None): |
Edward Lemur | 2b7876c | 2020-01-17 18:48:13 -0500 | [diff] [blame] | 49 | """Checks that files end with at least one \n (LF).""" |
rmistry@google.com | 713276b | 2013-01-25 18:27:34 +0000 | [diff] [blame] | 50 | eof_files = [] |
| 51 | for f in input_api.AffectedSourceFiles(source_file_filter): |
| 52 | contents = input_api.ReadFile(f, 'rb') |
Edward Lemur | 2b7876c | 2020-01-17 18:48:13 -0500 | [diff] [blame] | 53 | # Check that the file ends in at least one newline character. |
rmistry@google.com | 713276b | 2013-01-25 18:27:34 +0000 | [diff] [blame] | 54 | if len(contents) > 1 and contents[-1:] != '\n': |
| 55 | eof_files.append(f.LocalPath()) |
| 56 | |
| 57 | if eof_files: |
| 58 | return [output_api.PresubmitPromptWarning( |
| 59 | 'These files should end in a newline character:', |
| 60 | items=eof_files)] |
| 61 | return [] |
| 62 | |
| 63 | |
Ben Wagner | cf42e98 | 2018-02-09 17:41:20 -0500 | [diff] [blame] | 64 | def _JsonChecks(input_api, output_api): |
| 65 | """Run checks on any modified json files.""" |
| 66 | failing_files = [] |
| 67 | for affected_file in input_api.AffectedFiles(None): |
| 68 | affected_file_path = affected_file.LocalPath() |
| 69 | is_json = affected_file_path.endswith('.json') |
| 70 | is_metadata = (affected_file_path.startswith('site/') and |
| 71 | affected_file_path.endswith('/METADATA')) |
| 72 | if is_json or is_metadata: |
| 73 | try: |
| 74 | input_api.json.load(open(affected_file_path, 'r')) |
| 75 | except ValueError: |
| 76 | failing_files.append(affected_file_path) |
| 77 | |
| 78 | results = [] |
| 79 | if failing_files: |
| 80 | results.append( |
| 81 | output_api.PresubmitError( |
| 82 | 'The following files contain invalid json:\n%s\n\n' % |
| 83 | '\n'.join(failing_files))) |
| 84 | return results |
| 85 | |
| 86 | |
rmistry | 01cbf6c | 2015-03-12 07:48:40 -0700 | [diff] [blame] | 87 | def _IfDefChecks(input_api, output_api): |
| 88 | """Ensures if/ifdef are not before includes. See skbug/3362 for details.""" |
| 89 | comment_block_start_pattern = re.compile('^\s*\/\*.*$') |
| 90 | comment_block_middle_pattern = re.compile('^\s+\*.*') |
| 91 | comment_block_end_pattern = re.compile('^\s+\*\/.*$') |
| 92 | single_line_comment_pattern = re.compile('^\s*//.*$') |
| 93 | def is_comment(line): |
| 94 | return (comment_block_start_pattern.match(line) or |
| 95 | comment_block_middle_pattern.match(line) or |
| 96 | comment_block_end_pattern.match(line) or |
| 97 | single_line_comment_pattern.match(line)) |
| 98 | |
| 99 | empty_line_pattern = re.compile('^\s*$') |
| 100 | def is_empty_line(line): |
| 101 | return empty_line_pattern.match(line) |
| 102 | |
| 103 | failing_files = [] |
| 104 | for affected_file in input_api.AffectedSourceFiles(None): |
| 105 | affected_file_path = affected_file.LocalPath() |
| 106 | if affected_file_path.endswith('.cpp') or affected_file_path.endswith('.h'): |
| 107 | f = open(affected_file_path) |
| 108 | for line in f.xreadlines(): |
| 109 | if is_comment(line) or is_empty_line(line): |
| 110 | continue |
| 111 | # The below will be the first real line after comments and newlines. |
| 112 | if line.startswith('#if 0 '): |
| 113 | pass |
| 114 | elif line.startswith('#if ') or line.startswith('#ifdef '): |
| 115 | failing_files.append(affected_file_path) |
| 116 | break |
| 117 | |
| 118 | results = [] |
| 119 | if failing_files: |
| 120 | results.append( |
| 121 | output_api.PresubmitError( |
| 122 | 'The following files have #if or #ifdef before includes:\n%s\n\n' |
halcanary | 6950de6 | 2015-11-07 05:29:00 -0800 | [diff] [blame] | 123 | 'See https://bug.skia.org/3362 for why this should be fixed.' % |
rmistry | 01cbf6c | 2015-03-12 07:48:40 -0700 | [diff] [blame] | 124 | '\n'.join(failing_files))) |
| 125 | return results |
| 126 | |
| 127 | |
borenet | c7c9180 | 2015-03-25 04:47:02 -0700 | [diff] [blame] | 128 | def _CopyrightChecks(input_api, output_api, source_file_filter=None): |
| 129 | results = [] |
| 130 | year_pattern = r'\d{4}' |
| 131 | year_range_pattern = r'%s(-%s)?' % (year_pattern, year_pattern) |
| 132 | years_pattern = r'%s(,%s)*,?' % (year_range_pattern, year_range_pattern) |
| 133 | copyright_pattern = ( |
| 134 | r'Copyright (\([cC]\) )?%s \w+' % years_pattern) |
| 135 | |
| 136 | for affected_file in input_api.AffectedSourceFiles(source_file_filter): |
John Stiles | d836f84 | 2020-09-14 10:21:44 -0400 | [diff] [blame] | 137 | if ('third_party/' in affected_file.LocalPath() or |
| 138 | 'tests/sksl/' in affected_file.LocalPath()): |
borenet | c7c9180 | 2015-03-25 04:47:02 -0700 | [diff] [blame] | 139 | continue |
| 140 | contents = input_api.ReadFile(affected_file, 'rb') |
| 141 | if not re.search(copyright_pattern, contents): |
| 142 | results.append(output_api.PresubmitError( |
| 143 | '%s is missing a correct copyright header.' % affected_file)) |
| 144 | return results |
| 145 | |
| 146 | |
borenet | 2dbbfa5 | 2016-10-14 06:32:09 -0700 | [diff] [blame] | 147 | def _InfraTests(input_api, output_api): |
| 148 | """Run the infra tests.""" |
borenet | 1ed2ae4 | 2016-07-26 11:52:17 -0700 | [diff] [blame] | 149 | results = [] |
mtklein | 3da80f5 | 2016-07-27 04:14:07 -0700 | [diff] [blame] | 150 | if not any(f.LocalPath().startswith('infra') |
| 151 | for f in input_api.AffectedFiles()): |
| 152 | return results |
| 153 | |
borenet | 2dbbfa5 | 2016-10-14 06:32:09 -0700 | [diff] [blame] | 154 | cmd = ['python', os.path.join('infra', 'bots', 'infra_tests.py')] |
borenet | 60b0a2d | 2016-10-04 12:45:41 -0700 | [diff] [blame] | 155 | try: |
| 156 | subprocess.check_output(cmd) |
| 157 | except subprocess.CalledProcessError as e: |
| 158 | results.append(output_api.PresubmitError( |
| 159 | '`%s` failed:\n%s' % (' '.join(cmd), e.output))) |
| 160 | return results |
| 161 | |
| 162 | |
mtklein | 4db3b79 | 2016-08-03 14:18:22 -0700 | [diff] [blame] | 163 | def _CheckGNFormatted(input_api, output_api): |
| 164 | """Make sure any .gn files we're changing have been formatted.""" |
Ben Wagner | 3c4a9d3 | 2020-02-14 14:28:33 -0500 | [diff] [blame] | 165 | files = [] |
Corentin Wallez | 6a5187a | 2020-04-08 10:24:04 +0200 | [diff] [blame] | 166 | for f in input_api.AffectedFiles(include_deletes=False): |
Ben Wagner | 3c4a9d3 | 2020-02-14 14:28:33 -0500 | [diff] [blame] | 167 | if (f.LocalPath().endswith('.gn') or |
| 168 | f.LocalPath().endswith('.gni')): |
| 169 | files.append(f) |
| 170 | if not files: |
| 171 | return [] |
mtklein | 4db3b79 | 2016-08-03 14:18:22 -0700 | [diff] [blame] | 172 | |
Ben Wagner | 3c4a9d3 | 2020-02-14 14:28:33 -0500 | [diff] [blame] | 173 | cmd = ['python', os.path.join('bin', 'fetch-gn')] |
| 174 | try: |
| 175 | subprocess.check_output(cmd) |
| 176 | except subprocess.CalledProcessError as e: |
| 177 | return [output_api.PresubmitError( |
| 178 | '`%s` failed:\n%s' % (' '.join(cmd), e.output))] |
| 179 | |
| 180 | results = [] |
| 181 | for f in files: |
Brian Osman | 70f24af | 2020-02-18 15:08:27 -0500 | [diff] [blame] | 182 | gn = 'gn.exe' if 'win32' in sys.platform else 'gn' |
Ben Wagner | 06265e0 | 2020-02-13 19:02:46 -0500 | [diff] [blame] | 183 | gn = os.path.join(input_api.PresubmitLocalPath(), 'bin', gn) |
Mike Klein | 7a1c53d | 2016-10-11 14:03:06 -0400 | [diff] [blame] | 184 | cmd = [gn, 'format', '--dry-run', f.LocalPath()] |
mtklein | 4db3b79 | 2016-08-03 14:18:22 -0700 | [diff] [blame] | 185 | try: |
| 186 | subprocess.check_output(cmd) |
| 187 | except subprocess.CalledProcessError: |
Ben Wagner | 06265e0 | 2020-02-13 19:02:46 -0500 | [diff] [blame] | 188 | fix = 'bin/gn format ' + f.LocalPath() |
mtklein | 4db3b79 | 2016-08-03 14:18:22 -0700 | [diff] [blame] | 189 | results.append(output_api.PresubmitError( |
mtklein | d434b01 | 2016-08-10 07:30:58 -0700 | [diff] [blame] | 190 | '`%s` failed, try\n\t%s' % (' '.join(cmd), fix))) |
mtklein | 4db3b79 | 2016-08-03 14:18:22 -0700 | [diff] [blame] | 191 | return results |
| 192 | |
Ravi Mistry | 6eca579 | 2020-12-16 11:42:29 -0500 | [diff] [blame] | 193 | |
| 194 | def _CheckGitConflictMarkers(input_api, output_api): |
| 195 | pattern = input_api.re.compile('^(?:<<<<<<<|>>>>>>>) |^=======$') |
| 196 | results = [] |
| 197 | for f in input_api.AffectedFiles(): |
| 198 | for line_num, line in f.ChangedContents(): |
| 199 | if f.LocalPath().endswith('.md'): |
| 200 | # First-level headers in markdown look a lot like version control |
| 201 | # conflict markers. http://daringfireball.net/projects/markdown/basics |
| 202 | continue |
| 203 | if pattern.match(line): |
| 204 | results.append( |
| 205 | output_api.PresubmitError( |
| 206 | 'Git conflict markers found in %s:%d %s' % ( |
| 207 | f.LocalPath(), line_num, line))) |
| 208 | return results |
| 209 | |
| 210 | |
Mike Klein | bb41343 | 2019-07-26 11:55:40 -0500 | [diff] [blame] | 211 | def _CheckIncludesFormatted(input_api, output_api): |
| 212 | """Make sure #includes in files we're changing have been formatted.""" |
Mike Klein | f9ad5ba | 2019-07-29 12:34:39 -0500 | [diff] [blame] | 213 | files = [str(f) for f in input_api.AffectedFiles() if f.Action() != 'D'] |
Mike Klein | bb41343 | 2019-07-26 11:55:40 -0500 | [diff] [blame] | 214 | cmd = ['python', |
| 215 | 'tools/rewrite_includes.py', |
Mike Klein | f9ad5ba | 2019-07-29 12:34:39 -0500 | [diff] [blame] | 216 | '--dry-run'] + files |
Hal Canary | 4df3d53 | 2019-07-30 13:49:45 -0400 | [diff] [blame] | 217 | if 0 != subprocess.call(cmd): |
Mike Klein | bb41343 | 2019-07-26 11:55:40 -0500 | [diff] [blame] | 218 | return [output_api.PresubmitError('`%s` failed' % ' '.join(cmd))] |
| 219 | return [] |
borenet | 1ed2ae4 | 2016-07-26 11:52:17 -0700 | [diff] [blame] | 220 | |
Eric Boren | 58d1f76 | 2019-07-19 08:07:44 -0400 | [diff] [blame] | 221 | |
Ben Wagner | 8885550 | 2017-10-12 17:55:19 -0400 | [diff] [blame] | 222 | class _WarningsAsErrors(): |
| 223 | def __init__(self, output_api): |
| 224 | self.output_api = output_api |
| 225 | self.old_warning = None |
| 226 | def __enter__(self): |
| 227 | self.old_warning = self.output_api.PresubmitPromptWarning |
| 228 | self.output_api.PresubmitPromptWarning = self.output_api.PresubmitError |
| 229 | return self.output_api |
| 230 | def __exit__(self, ex_type, ex_value, ex_traceback): |
| 231 | self.output_api.PresubmitPromptWarning = self.old_warning |
| 232 | |
| 233 | |
Eric Boren | 6dc0021 | 2019-07-24 15:15:43 -0400 | [diff] [blame] | 234 | def _CheckDEPSValid(input_api, output_api): |
| 235 | """Ensure that DEPS contains valid entries.""" |
| 236 | results = [] |
| 237 | script = os.path.join('infra', 'bots', 'check_deps.py') |
| 238 | relevant_files = ('DEPS', script) |
| 239 | for f in input_api.AffectedFiles(): |
| 240 | if f.LocalPath() in relevant_files: |
| 241 | break |
| 242 | else: |
| 243 | return results |
| 244 | cmd = ['python', script] |
| 245 | try: |
| 246 | subprocess.check_output(cmd, stderr=subprocess.STDOUT) |
| 247 | except subprocess.CalledProcessError as e: |
| 248 | results.append(output_api.PresubmitError(e.output)) |
| 249 | return results |
| 250 | |
| 251 | |
Kevin Lubick | 2cd8067 | 2021-07-01 11:03:36 -0400 | [diff] [blame^] | 252 | def _RegenerateAllExamplesCPP(input_api, output_api): |
| 253 | """Regenerates all_examples.cpp if an example was added or deleted.""" |
| 254 | if not any(f.LocalPath().startswith('docs/examples/') |
| 255 | for f in input_api.AffectedFiles()): |
| 256 | return [] |
| 257 | command_str = 'tools/fiddle/make_all_examples_cpp.py' |
| 258 | cmd = ['python', command_str] |
| 259 | if 0 != subprocess.call(cmd): |
| 260 | return [output_api.PresubmitError('`%s` failed' % ' '.join(cmd))] |
| 261 | |
| 262 | results = [] |
| 263 | git_diff_output = input_api.subprocess.check_output( |
| 264 | ['git', 'diff', '--no-ext-diff']) |
| 265 | if git_diff_output: |
| 266 | results += [output_api.PresubmitError( |
| 267 | 'Diffs found after running "%s":\n\n%s\n' |
| 268 | 'Please commit or discard the above changes.' % ( |
| 269 | command_str, |
| 270 | git_diff_output, |
| 271 | ) |
| 272 | )] |
| 273 | return results |
| 274 | |
rmistry@google.com | 6be0b4c | 2013-01-17 14:50:59 +0000 | [diff] [blame] | 275 | def _CommonChecks(input_api, output_api): |
| 276 | """Presubmit checks common to upload and commit.""" |
| 277 | results = [] |
| 278 | sources = lambda x: (x.LocalPath().endswith('.h') or |
rmistry@google.com | 6be0b4c | 2013-01-17 14:50:59 +0000 | [diff] [blame] | 279 | x.LocalPath().endswith('.py') or |
| 280 | x.LocalPath().endswith('.sh') or |
mtklein | 18e5580 | 2015-03-25 07:21:20 -0700 | [diff] [blame] | 281 | x.LocalPath().endswith('.m') or |
| 282 | x.LocalPath().endswith('.mm') or |
| 283 | x.LocalPath().endswith('.go') or |
| 284 | x.LocalPath().endswith('.c') or |
| 285 | x.LocalPath().endswith('.cc') or |
rmistry@google.com | 6be0b4c | 2013-01-17 14:50:59 +0000 | [diff] [blame] | 286 | x.LocalPath().endswith('.cpp')) |
Ben Wagner | 8885550 | 2017-10-12 17:55:19 -0400 | [diff] [blame] | 287 | results.extend(_CheckChangeHasEol( |
| 288 | input_api, output_api, source_file_filter=sources)) |
| 289 | with _WarningsAsErrors(output_api): |
| 290 | results.extend(input_api.canned_checks.CheckChangeHasNoCR( |
| 291 | input_api, output_api, source_file_filter=sources)) |
| 292 | results.extend(input_api.canned_checks.CheckChangeHasNoStrayWhitespace( |
| 293 | input_api, output_api, source_file_filter=sources)) |
Ben Wagner | cf42e98 | 2018-02-09 17:41:20 -0500 | [diff] [blame] | 294 | results.extend(_JsonChecks(input_api, output_api)) |
rmistry | 01cbf6c | 2015-03-12 07:48:40 -0700 | [diff] [blame] | 295 | results.extend(_IfDefChecks(input_api, output_api)) |
borenet | c7c9180 | 2015-03-25 04:47:02 -0700 | [diff] [blame] | 296 | results.extend(_CopyrightChecks(input_api, output_api, |
| 297 | source_file_filter=sources)) |
Eric Boren | 6dc0021 | 2019-07-24 15:15:43 -0400 | [diff] [blame] | 298 | results.extend(_CheckDEPSValid(input_api, output_api)) |
Mike Klein | bb41343 | 2019-07-26 11:55:40 -0500 | [diff] [blame] | 299 | results.extend(_CheckIncludesFormatted(input_api, output_api)) |
Mike Klein | 96f6401 | 2020-04-03 10:59:37 -0500 | [diff] [blame] | 300 | results.extend(_CheckGNFormatted(input_api, output_api)) |
Ravi Mistry | 6eca579 | 2020-12-16 11:42:29 -0500 | [diff] [blame] | 301 | results.extend(_CheckGitConflictMarkers(input_api, output_api)) |
Kevin Lubick | 2cd8067 | 2021-07-01 11:03:36 -0400 | [diff] [blame^] | 302 | results.extend(_RegenerateAllExamplesCPP(input_api, output_api)) |
rmistry@google.com | 6be0b4c | 2013-01-17 14:50:59 +0000 | [diff] [blame] | 303 | return results |
| 304 | |
rmistry@google.com | 8e3ff8c | 2013-01-17 12:55:34 +0000 | [diff] [blame] | 305 | |
| 306 | def CheckChangeOnUpload(input_api, output_api): |
Ravi Mistry | 4c0ffe7 | 2020-03-02 13:19:02 -0500 | [diff] [blame] | 307 | """Presubmit checks for the change on upload.""" |
rmistry@google.com | 6be0b4c | 2013-01-17 14:50:59 +0000 | [diff] [blame] | 308 | results = [] |
| 309 | results.extend(_CommonChecks(input_api, output_api)) |
borenet | 1ed2ae4 | 2016-07-26 11:52:17 -0700 | [diff] [blame] | 310 | # Run on upload, not commit, since the presubmit bot apparently doesn't have |
borenet | 60b0a2d | 2016-10-04 12:45:41 -0700 | [diff] [blame] | 311 | # coverage or Go installed. |
borenet | 2dbbfa5 | 2016-10-14 06:32:09 -0700 | [diff] [blame] | 312 | results.extend(_InfraTests(input_api, output_api)) |
Ravi Mistry | 5773516 | 2019-07-25 13:45:15 -0400 | [diff] [blame] | 313 | results.extend(_CheckReleaseNotesForPublicAPI(input_api, output_api)) |
rmistry@google.com | 6be0b4c | 2013-01-17 14:50:59 +0000 | [diff] [blame] | 314 | return results |
rmistry@google.com | 8e3ff8c | 2013-01-17 12:55:34 +0000 | [diff] [blame] | 315 | |
| 316 | |
rmistry | b398ecc | 2016-08-29 08:13:29 -0700 | [diff] [blame] | 317 | class CodeReview(object): |
| 318 | """Abstracts which codereview tool is used for the specified issue.""" |
| 319 | |
| 320 | def __init__(self, input_api): |
| 321 | self._issue = input_api.change.issue |
| 322 | self._gerrit = input_api.gerrit |
rmistry | b398ecc | 2016-08-29 08:13:29 -0700 | [diff] [blame] | 323 | |
| 324 | def GetOwnerEmail(self): |
Aaron Gable | a49909a | 2017-10-09 12:50:52 -0700 | [diff] [blame] | 325 | return self._gerrit.GetChangeOwner(self._issue) |
rmistry | b398ecc | 2016-08-29 08:13:29 -0700 | [diff] [blame] | 326 | |
| 327 | def GetSubject(self): |
Aaron Gable | a49909a | 2017-10-09 12:50:52 -0700 | [diff] [blame] | 328 | return self._gerrit.GetChangeInfo(self._issue)['subject'] |
rmistry | b398ecc | 2016-08-29 08:13:29 -0700 | [diff] [blame] | 329 | |
| 330 | def GetDescription(self): |
Aaron Gable | a49909a | 2017-10-09 12:50:52 -0700 | [diff] [blame] | 331 | return self._gerrit.GetChangeDescription(self._issue) |
rmistry | b398ecc | 2016-08-29 08:13:29 -0700 | [diff] [blame] | 332 | |
Ravi Mistry | 39eabb6 | 2016-10-05 08:41:12 -0400 | [diff] [blame] | 333 | def GetReviewers(self): |
Aaron Gable | a49909a | 2017-10-09 12:50:52 -0700 | [diff] [blame] | 334 | code_review_label = ( |
| 335 | self._gerrit.GetChangeInfo(self._issue)['labels']['Code-Review']) |
| 336 | return [r['email'] for r in code_review_label.get('all', [])] |
Ravi Mistry | 39eabb6 | 2016-10-05 08:41:12 -0400 | [diff] [blame] | 337 | |
rmistry | b398ecc | 2016-08-29 08:13:29 -0700 | [diff] [blame] | 338 | def GetApprovers(self): |
| 339 | approvers = [] |
Aaron Gable | a49909a | 2017-10-09 12:50:52 -0700 | [diff] [blame] | 340 | code_review_label = ( |
| 341 | self._gerrit.GetChangeInfo(self._issue)['labels']['Code-Review']) |
| 342 | for m in code_review_label.get('all', []): |
| 343 | if m.get("value") == 1: |
| 344 | approvers.append(m["email"]) |
rmistry | b398ecc | 2016-08-29 08:13:29 -0700 | [diff] [blame] | 345 | return approvers |
| 346 | |
| 347 | |
commit-bot@chromium.org | 745e08c | 2014-02-03 14:18:32 +0000 | [diff] [blame] | 348 | def _CheckOwnerIsInAuthorsFile(input_api, output_api): |
| 349 | results = [] |
rmistry | b398ecc | 2016-08-29 08:13:29 -0700 | [diff] [blame] | 350 | if input_api.change.issue: |
| 351 | cr = CodeReview(input_api) |
commit-bot@chromium.org | 745e08c | 2014-02-03 14:18:32 +0000 | [diff] [blame] | 352 | |
rmistry | b398ecc | 2016-08-29 08:13:29 -0700 | [diff] [blame] | 353 | owner_email = cr.GetOwnerEmail() |
Eric Boren | dd98829 | 2018-01-02 13:29:21 -0500 | [diff] [blame] | 354 | |
| 355 | # Service accounts don't need to be in AUTHORS. |
Eric Boren | 1eec99c | 2018-04-26 13:09:48 -0400 | [diff] [blame] | 356 | for suffix in SERVICE_ACCOUNT_SUFFIX: |
| 357 | if owner_email.endswith(suffix): |
| 358 | return results |
Eric Boren | dd98829 | 2018-01-02 13:29:21 -0500 | [diff] [blame] | 359 | |
commit-bot@chromium.org | 745e08c | 2014-02-03 14:18:32 +0000 | [diff] [blame] | 360 | try: |
| 361 | authors_content = '' |
| 362 | for line in open(AUTHORS_FILE_NAME): |
| 363 | if not line.startswith('#'): |
| 364 | authors_content += line |
| 365 | email_fnmatches = re.findall('<(.*)>', authors_content) |
| 366 | for email_fnmatch in email_fnmatches: |
| 367 | if fnmatch.fnmatch(owner_email, email_fnmatch): |
| 368 | # Found a match, the user is in the AUTHORS file break out of the loop |
| 369 | break |
| 370 | else: |
commit-bot@chromium.org | 745e08c | 2014-02-03 14:18:32 +0000 | [diff] [blame] | 371 | results.append( |
| 372 | output_api.PresubmitError( |
| 373 | 'The email %s is not in Skia\'s AUTHORS file.\n' |
| 374 | 'Issue owner, this CL must include an addition to the Skia AUTHORS ' |
rmistry | 9806d4d | 2015-10-01 08:10:54 -0700 | [diff] [blame] | 375 | 'file.' |
rmistry | 83fab47 | 2014-07-18 05:25:56 -0700 | [diff] [blame] | 376 | % owner_email)) |
commit-bot@chromium.org | 745e08c | 2014-02-03 14:18:32 +0000 | [diff] [blame] | 377 | except IOError: |
| 378 | # Do not fail if authors file cannot be found. |
| 379 | traceback.print_exc() |
| 380 | input_api.logging.error('AUTHORS file not found!') |
| 381 | |
| 382 | return results |
| 383 | |
| 384 | |
Ravi Mistry | 5773516 | 2019-07-25 13:45:15 -0400 | [diff] [blame] | 385 | def _CheckReleaseNotesForPublicAPI(input_api, output_api): |
| 386 | """Checks to see if release notes file is updated with public API changes.""" |
| 387 | results = [] |
| 388 | public_api_changed = False |
| 389 | release_file_changed = False |
| 390 | for affected_file in input_api.AffectedFiles(): |
| 391 | affected_file_path = affected_file.LocalPath() |
| 392 | file_path, file_ext = os.path.splitext(affected_file_path) |
| 393 | # We only care about files that end in .h and are under the top-level |
| 394 | # include dir, but not include/private. |
| 395 | if (file_ext == '.h' and |
| 396 | file_path.split(os.path.sep)[0] == 'include' and |
| 397 | 'private' not in file_path): |
| 398 | public_api_changed = True |
| 399 | elif affected_file_path == RELEASE_NOTES_FILE_NAME: |
| 400 | release_file_changed = True |
| 401 | |
| 402 | if public_api_changed and not release_file_changed: |
| 403 | results.append(output_api.PresubmitPromptWarning( |
| 404 | 'If this change affects a client API, please add a summary line ' |
| 405 | 'to the %s file.' % RELEASE_NOTES_FILE_NAME)) |
| 406 | return results |
| 407 | |
| 408 | |
| 409 | |
rmistry@google.com | fb4a68d | 2013-08-12 14:51:20 +0000 | [diff] [blame] | 410 | def _CheckLGTMsForPublicAPI(input_api, output_api): |
| 411 | """Check LGTMs for public API changes. |
| 412 | |
| 413 | For public API files make sure there is an LGTM from the list of owners in |
| 414 | PUBLIC_API_OWNERS. |
| 415 | """ |
| 416 | results = [] |
| 417 | requires_owner_check = False |
rmistry | 9407ece | 2014-08-26 14:00:54 -0700 | [diff] [blame] | 418 | for affected_file in input_api.AffectedFiles(): |
| 419 | affected_file_path = affected_file.LocalPath() |
rmistry@google.com | fb4a68d | 2013-08-12 14:51:20 +0000 | [diff] [blame] | 420 | file_path, file_ext = os.path.splitext(affected_file_path) |
rmistry | 9407ece | 2014-08-26 14:00:54 -0700 | [diff] [blame] | 421 | # We only care about files that end in .h and are under the top-level |
mtklein | bda1267 | 2015-07-28 08:54:12 -0700 | [diff] [blame] | 422 | # include dir, but not include/private. |
| 423 | if (file_ext == '.h' and |
| 424 | 'include' == file_path.split(os.path.sep)[0] and |
| 425 | 'private' not in file_path): |
rmistry@google.com | fb4a68d | 2013-08-12 14:51:20 +0000 | [diff] [blame] | 426 | requires_owner_check = True |
| 427 | |
| 428 | if not requires_owner_check: |
| 429 | return results |
| 430 | |
| 431 | lgtm_from_owner = False |
rmistry | b398ecc | 2016-08-29 08:13:29 -0700 | [diff] [blame] | 432 | if input_api.change.issue: |
| 433 | cr = CodeReview(input_api) |
| 434 | |
| 435 | if re.match(REVERT_CL_SUBJECT_PREFIX, cr.GetSubject(), re.I): |
commit-bot@chromium.org | cfdc596 | 2014-01-31 17:33:04 +0000 | [diff] [blame] | 436 | # It is a revert CL, ignore the public api owners check. |
| 437 | return results |
rmistry | f2d83ca | 2014-08-26 10:30:29 -0700 | [diff] [blame] | 438 | |
Ravi Mistry | 39eabb6 | 2016-10-05 08:41:12 -0400 | [diff] [blame] | 439 | if input_api.gerrit: |
| 440 | for reviewer in cr.GetReviewers(): |
| 441 | if reviewer in PUBLIC_API_OWNERS: |
| 442 | # If an owner is specified as an reviewer in Gerrit then ignore the |
| 443 | # public api owners check. |
rmistry | f2d83ca | 2014-08-26 10:30:29 -0700 | [diff] [blame] | 444 | return results |
Ravi Mistry | 39eabb6 | 2016-10-05 08:41:12 -0400 | [diff] [blame] | 445 | else: |
| 446 | match = re.search(r'^TBR=(.*)$', cr.GetDescription(), re.M) |
| 447 | if match: |
| 448 | tbr_section = match.group(1).strip().split(' ')[0] |
| 449 | tbr_entries = tbr_section.split(',') |
| 450 | for owner in PUBLIC_API_OWNERS: |
| 451 | if owner in tbr_entries or owner.split('@')[0] in tbr_entries: |
| 452 | # If an owner is specified in the TBR= line then ignore the public |
| 453 | # api owners check. |
| 454 | return results |
rmistry | f2d83ca | 2014-08-26 10:30:29 -0700 | [diff] [blame] | 455 | |
rmistry | b398ecc | 2016-08-29 08:13:29 -0700 | [diff] [blame] | 456 | if cr.GetOwnerEmail() in PUBLIC_API_OWNERS: |
rmistry@google.com | fb4a68d | 2013-08-12 14:51:20 +0000 | [diff] [blame] | 457 | # An owner created the CL that is an automatic LGTM. |
| 458 | lgtm_from_owner = True |
| 459 | |
rmistry | b398ecc | 2016-08-29 08:13:29 -0700 | [diff] [blame] | 460 | for approver in cr.GetApprovers(): |
| 461 | if approver in PUBLIC_API_OWNERS: |
| 462 | # Found an lgtm in a message from an owner. |
| 463 | lgtm_from_owner = True |
| 464 | break |
commit-bot@chromium.org | cfdc596 | 2014-01-31 17:33:04 +0000 | [diff] [blame] | 465 | |
rmistry@google.com | fb4a68d | 2013-08-12 14:51:20 +0000 | [diff] [blame] | 466 | if not lgtm_from_owner: |
| 467 | results.append( |
| 468 | output_api.PresubmitError( |
mtklein | bda1267 | 2015-07-28 08:54:12 -0700 | [diff] [blame] | 469 | "If this CL adds to or changes Skia's public API, you need an LGTM " |
| 470 | "from any of %s. If this CL only removes from or doesn't change " |
Ravi Mistry | dbb84c2 | 2016-10-05 12:47:44 -0400 | [diff] [blame] | 471 | "Skia's public API, please add a short note to the CL saying so. " |
Aaron Gable | a49909a | 2017-10-09 12:50:52 -0700 | [diff] [blame] | 472 | "Add one of the owners as a reviewer to your CL as well as to the " |
| 473 | "TBR= line. If you don't know if this CL affects Skia's public " |
| 474 | "API, treat it like it does." % str(PUBLIC_API_OWNERS))) |
rmistry@google.com | fb4a68d | 2013-08-12 14:51:20 +0000 | [diff] [blame] | 475 | return results |
| 476 | |
| 477 | |
Edward Lemur | 2b7876c | 2020-01-17 18:48:13 -0500 | [diff] [blame] | 478 | def PostUploadHook(gerrit, change, output_api): |
rmistry | d223fb2 | 2015-02-26 10:16:13 -0800 | [diff] [blame] | 479 | """git cl upload will call this hook after the issue is created/modified. |
| 480 | |
| 481 | This hook does the following: |
| 482 | * Adds a link to preview docs changes if there are any docs changes in the CL. |
Ravi Mistry | 355feab | 2017-05-23 14:24:08 -0400 | [diff] [blame] | 483 | * Adds 'No-Try: true' if the CL contains only docs changes. |
rmistry | d223fb2 | 2015-02-26 10:16:13 -0800 | [diff] [blame] | 484 | """ |
Edward Lemur | 2b7876c | 2020-01-17 18:48:13 -0500 | [diff] [blame] | 485 | if not change.issue: |
| 486 | return [] |
| 487 | |
| 488 | # Skip PostUploadHooks for all auto-commit service account bots. New |
| 489 | # patchsets (caused due to PostUploadHooks) invalidates the CQ+2 vote from |
| 490 | # the "--use-commit-queue" flag to "git cl upload". |
| 491 | for suffix in SERVICE_ACCOUNT_SUFFIX: |
| 492 | if change.author_email.endswith(suffix): |
| 493 | return [] |
rmistry | d223fb2 | 2015-02-26 10:16:13 -0800 | [diff] [blame] | 494 | |
| 495 | results = [] |
Ravi Mistry | 27095f2 | 2021-04-22 12:51:49 +0000 | [diff] [blame] | 496 | at_least_one_docs_change = False |
rmistry | d223fb2 | 2015-02-26 10:16:13 -0800 | [diff] [blame] | 497 | all_docs_changes = True |
| 498 | for affected_file in change.AffectedFiles(): |
| 499 | affected_file_path = affected_file.LocalPath() |
| 500 | file_path, _ = os.path.splitext(affected_file_path) |
Ravi Mistry | 27095f2 | 2021-04-22 12:51:49 +0000 | [diff] [blame] | 501 | if 'site' == file_path.split(os.path.sep)[0]: |
| 502 | at_least_one_docs_change = True |
rmistry | d223fb2 | 2015-02-26 10:16:13 -0800 | [diff] [blame] | 503 | else: |
| 504 | all_docs_changes = False |
Ravi Mistry | 27095f2 | 2021-04-22 12:51:49 +0000 | [diff] [blame] | 505 | if at_least_one_docs_change and not all_docs_changes: |
| 506 | break |
rmistry | d223fb2 | 2015-02-26 10:16:13 -0800 | [diff] [blame] | 507 | |
Edward Lemur | 2b7876c | 2020-01-17 18:48:13 -0500 | [diff] [blame] | 508 | footers = change.GitFootersFromDescription() |
| 509 | description_changed = False |
Ravi Mistry | b5e2acc | 2017-12-07 11:10:11 -0500 | [diff] [blame] | 510 | |
Edward Lemur | 2b7876c | 2020-01-17 18:48:13 -0500 | [diff] [blame] | 511 | # If the change includes only doc changes then add No-Try: true in the |
| 512 | # CL's description if it does not exist yet. |
| 513 | if all_docs_changes and 'true' not in footers.get('No-Try', []): |
| 514 | description_changed = True |
Edward Lemur | c631b7c | 2020-02-04 15:30:18 -0500 | [diff] [blame] | 515 | change.AddDescriptionFooter('No-Try', 'true') |
Edward Lemur | 2b7876c | 2020-01-17 18:48:13 -0500 | [diff] [blame] | 516 | results.append( |
| 517 | output_api.PresubmitNotifyResult( |
| 518 | 'This change has only doc changes. Automatically added ' |
| 519 | '\'No-Try: true\' to the CL\'s description')) |
rmistry | d223fb2 | 2015-02-26 10:16:13 -0800 | [diff] [blame] | 520 | |
Ravi Mistry | 27095f2 | 2021-04-22 12:51:49 +0000 | [diff] [blame] | 521 | # If there is at least one docs change then add preview link in the CL's |
| 522 | # description if it does not already exist there. |
| 523 | docs_preview_link = DOCS_PREVIEW_URL.format(issue=change.issue) |
| 524 | if (at_least_one_docs_change |
| 525 | and docs_preview_link not in footers.get('Docs-Preview', [])): |
| 526 | # Automatically add a link to where the docs can be previewed. |
| 527 | description_changed = True |
| 528 | change.AddDescriptionFooter('Docs-Preview', docs_preview_link) |
| 529 | results.append( |
| 530 | output_api.PresubmitNotifyResult( |
| 531 | 'Automatically added a link to preview the docs changes to the ' |
| 532 | 'CL\'s description')) |
rmistry | d223fb2 | 2015-02-26 10:16:13 -0800 | [diff] [blame] | 533 | |
Edward Lemur | 2b7876c | 2020-01-17 18:48:13 -0500 | [diff] [blame] | 534 | # If the description has changed update it. |
| 535 | if description_changed: |
| 536 | gerrit.UpdateDescription( |
| 537 | change.FullDescriptionText(), change.issue) |
rmistry | d223fb2 | 2015-02-26 10:16:13 -0800 | [diff] [blame] | 538 | |
Edward Lemur | 2b7876c | 2020-01-17 18:48:13 -0500 | [diff] [blame] | 539 | return results |
rmistry | d223fb2 | 2015-02-26 10:16:13 -0800 | [diff] [blame] | 540 | |
| 541 | |
rmistry@google.com | 8e3ff8c | 2013-01-17 12:55:34 +0000 | [diff] [blame] | 542 | def CheckChangeOnCommit(input_api, output_api): |
Ravi Mistry | 4c0ffe7 | 2020-03-02 13:19:02 -0500 | [diff] [blame] | 543 | """Presubmit checks for the change on commit.""" |
rmistry@google.com | 8e3ff8c | 2013-01-17 12:55:34 +0000 | [diff] [blame] | 544 | results = [] |
rmistry@google.com | 6be0b4c | 2013-01-17 14:50:59 +0000 | [diff] [blame] | 545 | results.extend(_CommonChecks(input_api, output_api)) |
rmistry@google.com | fb4a68d | 2013-08-12 14:51:20 +0000 | [diff] [blame] | 546 | results.extend(_CheckLGTMsForPublicAPI(input_api, output_api)) |
commit-bot@chromium.org | 745e08c | 2014-02-03 14:18:32 +0000 | [diff] [blame] | 547 | results.extend(_CheckOwnerIsInAuthorsFile(input_api, output_api)) |
Ravi Mistry | a70cb8a | 2017-09-12 13:52:05 -0400 | [diff] [blame] | 548 | # Checks for the presence of 'DO NOT''SUBMIT' in CL description and in |
| 549 | # content of files. |
| 550 | results.extend( |
| 551 | input_api.canned_checks.CheckDoNotSubmit(input_api, output_api)) |
rmistry@google.com | 8e3ff8c | 2013-01-17 12:55:34 +0000 | [diff] [blame] | 552 | return results |