blob: 4ff50c0fad57a3f21ad16437df87e35374e42e80 [file] [log] [blame]
borenet1ed2ae42016-07-26 11:52:17 -07001# Copyright 2016 The Chromium Authors. All rights reserved.
2# Use of this source code is governed by a BSD-style license that can be
3# found in the LICENSE file.
4
5
6# Recipe module for Skia Swarming test.
7
8
9DEPS = [
Eric Boren4c7754c2017-04-10 08:19:10 -040010 'build/file',
11 'core',
Eric Boren896af752017-04-24 13:22:56 -040012 'env',
13 'flavor',
Eric Boren4c7754c2017-04-10 08:19:10 -040014 'recipe_engine/json',
borenet1ed2ae42016-07-26 11:52:17 -070015 'recipe_engine/path',
16 'recipe_engine/platform',
17 'recipe_engine/properties',
Eric Boren4c7754c2017-04-10 08:19:10 -040018 'recipe_engine/python',
borenet1ed2ae42016-07-26 11:52:17 -070019 'recipe_engine/raw_io',
Eric Boren4c7754c2017-04-10 08:19:10 -040020 'recipe_engine/step',
Eric Boren4c7754c2017-04-10 08:19:10 -040021 'run',
22 'vars',
borenet1ed2ae42016-07-26 11:52:17 -070023]
24
25
Eric Boren4c7754c2017-04-10 08:19:10 -040026def dm_flags(bot):
27 args = []
28
29 # This enables non-deterministic random seeding of the GPU FP optimization
Brian Osman7a34dca2017-04-13 13:40:29 -040030 # test.
31 args.append('--randomProcessorTest')
Eric Boren4c7754c2017-04-10 08:19:10 -040032
33 # 32-bit desktop bots tend to run out of memory, because they have relatively
34 # far more cores than RAM (e.g. 32 cores, 3G RAM). Hold them back a bit.
35 if '-x86-' in bot and not 'NexusPlayer' in bot:
36 args.extend('--threads 4'.split(' '))
37
38 # Avoid issues with dynamically exceeding resource cache limits.
39 if 'Test' in bot and 'DISCARDABLE' in bot:
40 args.extend('--threads 0'.split(' '))
41
42 # These are the canonical configs that we would ideally run on all bots. We
43 # may opt out or substitute some below for specific bots
44 configs = ['8888', 'srgb', 'pdf']
45 # Add in either gles or gl configs to the canonical set based on OS
46 sample_count = '8'
47 gl_prefix = 'gl'
48 if 'Android' in bot or 'iOS' in bot:
49 sample_count = '4'
50 # We want to test the OpenGL config not the GLES config on the Shield
51 if 'NVIDIA_Shield' not in bot:
52 gl_prefix = 'gles'
53 elif 'Intel' in bot:
54 sample_count = ''
55 elif 'ChromeOS' in bot:
56 gl_prefix = 'gles'
57
58 configs.extend([gl_prefix, gl_prefix + 'dft', gl_prefix + 'srgb'])
59 if sample_count is not '':
60 configs.append(gl_prefix + 'msaa' + sample_count)
61
62 # The NP produces a long error stream when we run with MSAA. The Tegra3 just
63 # doesn't support it.
64 if ('NexusPlayer' in bot or
65 'Tegra3' in bot or
Stephan Altmueller93787322017-04-25 14:40:10 -040066 # We aren't interested in fixing msaa bugs on current iOS devices.
Eric Boren4c7754c2017-04-10 08:19:10 -040067 'iPad4' in bot or
Stephan Altmueller93787322017-04-25 14:40:10 -040068 'iPadPro' in bot or
69 'iPhone6' in bot or
70 'iPhone7' in bot or
Eric Boren4c7754c2017-04-10 08:19:10 -040071 # skia:5792
72 'iHD530' in bot or
73 'IntelIris540' in bot):
74 configs = [x for x in configs if 'msaa' not in x]
75
76 # The NP produces different images for dft on every run.
77 if 'NexusPlayer' in bot:
78 configs = [x for x in configs if 'dft' not in x]
79
80 # Runs out of memory on Android bots. Everyone else seems fine.
81 if 'Android' in bot:
82 configs.remove('pdf')
83
84 if '-GCE-' in bot:
85 configs.extend(['565'])
86 configs.extend(['f16'])
87 configs.extend(['sp-8888', '2ndpic-8888']) # Test niche uses of SkPicture.
88 configs.extend(['lite-8888']) # Experimental display list.
89 configs.extend(['gbr-8888'])
90
91 if '-TSAN' not in bot and sample_count is not '':
92 if ('TegraK1' in bot or
93 'TegraX1' in bot or
94 'GTX550Ti' in bot or
95 'GTX660' in bot or
96 'GT610' in bot):
97 configs.append(gl_prefix + 'nvprdit' + sample_count)
98
99 # We want to test both the OpenGL config and the GLES config on Linux Intel:
100 # GL is used by Chrome, GLES is used by ChromeOS.
101 if 'Intel' in bot and 'Ubuntu' in bot:
102 configs.extend(['gles', 'glesdft', 'glessrgb'])
103
104 # NP is running out of RAM when we run all these modes. skia:3255
105 if 'NexusPlayer' not in bot:
106 configs.extend(mode + '-8888' for mode in
107 ['serialize', 'tiles_rt', 'pic'])
108
109 # Test instanced rendering on a limited number of platforms
110 if 'Nexus6' in bot:
111 configs.append(gl_prefix + 'inst') # inst msaa isn't working yet on Adreno.
112 elif 'NVIDIA_Shield' in bot or 'PixelC' in bot:
113 # Multisampled instanced configs use nvpr so we substitute inst msaa
114 # configs for nvpr msaa configs.
115 old = gl_prefix + 'nvpr'
116 new = gl_prefix + 'inst'
117 configs = [x.replace(old, new) for x in configs]
118 # We also test non-msaa instanced.
119 configs.append(new)
120 elif 'MacMini6.2' in bot and sample_count is not '':
121 configs.extend([gl_prefix + 'inst', gl_prefix + 'inst' + sample_count])
122
123 # CommandBuffer bot *only* runs the command_buffer config.
124 if 'CommandBuffer' in bot:
125 configs = ['commandbuffer']
126
127 # ANGLE bot *only* runs the angle configs
128 if 'ANGLE' in bot:
129 configs = ['angle_d3d11_es2',
130 'angle_d3d9_es2',
131 'angle_gl_es2']
132 if sample_count is not '':
133 configs.append('angle_d3d11_es2_msaa' + sample_count)
134
135 # Vulkan bot *only* runs the vk config.
136 if 'Vulkan' in bot:
137 configs = ['vk']
138
139 if 'ChromeOS' in bot:
140 # Just run GLES for now - maybe add gles_msaa4 in the future
141 configs = ['gles']
142
Kevin Lubickae95db42017-04-10 13:05:49 -0400143 if 'Ci20' in bot:
144 # This bot is really slow, cut it down to just 8888.
145 configs = ['8888']
146
Eric Boren4c7754c2017-04-10 08:19:10 -0400147 args.append('--config')
148 args.extend(configs)
149
150 # Run tests, gms, and image decoding tests everywhere.
151 args.extend('--src tests gm image colorImage svg'.split(' '))
152 if 'Vulkan' in bot and 'NexusPlayer' in bot:
153 args.remove('svg')
154 args.remove('image')
155
156 blacklisted = []
157 def blacklist(quad):
158 config, src, options, name = quad.split(' ') if type(quad) is str else quad
159 if config == '_' or config in configs:
160 blacklisted.extend([config, src, options, name])
161
162 # TODO: ???
163 blacklist('f16 _ _ dstreadshuffle')
164 blacklist('glsrgb image _ _')
165 blacklist('glessrgb image _ _')
166
167 # Decoder tests are now performing gamma correct decodes. This means
168 # that, when viewing the results, we need to perform a gamma correct
169 # encode to PNG. Therefore, we run the image tests in srgb mode instead
170 # of 8888.
171 blacklist('8888 image _ _')
172
173 # Not any point to running these.
174 blacklist('gbr-8888 image _ _')
175 blacklist('gbr-8888 colorImage _ _')
176
177 if 'Valgrind' in bot:
178 # These take 18+ hours to run.
179 blacklist('pdf gm _ fontmgr_iter')
180 blacklist('pdf _ _ PANO_20121023_214540.jpg')
181 blacklist('pdf skp _ worldjournal')
182 blacklist('pdf skp _ desk_baidu.skp')
183 blacklist('pdf skp _ desk_wikipedia.skp')
184 blacklist('_ svg _ _')
185
186 if 'iOS' in bot:
187 blacklist(gl_prefix + ' skp _ _')
188
189 if 'Mac' in bot or 'iOS' in bot:
190 # CG fails on questionable bmps
191 blacklist('_ image gen_platf rgba32abf.bmp')
192 blacklist('_ image gen_platf rgb24prof.bmp')
193 blacklist('_ image gen_platf rgb24lprof.bmp')
194 blacklist('_ image gen_platf 8bpp-pixeldata-cropped.bmp')
195 blacklist('_ image gen_platf 4bpp-pixeldata-cropped.bmp')
196 blacklist('_ image gen_platf 32bpp-pixeldata-cropped.bmp')
197 blacklist('_ image gen_platf 24bpp-pixeldata-cropped.bmp')
198
199 # CG has unpredictable behavior on this questionable gif
200 # It's probably using uninitialized memory
201 blacklist('_ image gen_platf frame_larger_than_image.gif')
202
203 # CG has unpredictable behavior on incomplete pngs
204 # skbug.com/5774
205 blacklist('_ image gen_platf inc0.png')
206 blacklist('_ image gen_platf inc1.png')
207 blacklist('_ image gen_platf inc2.png')
208 blacklist('_ image gen_platf inc3.png')
209 blacklist('_ image gen_platf inc4.png')
210 blacklist('_ image gen_platf inc5.png')
211 blacklist('_ image gen_platf inc6.png')
212 blacklist('_ image gen_platf inc7.png')
213 blacklist('_ image gen_platf inc8.png')
214 blacklist('_ image gen_platf inc9.png')
215 blacklist('_ image gen_platf inc10.png')
216 blacklist('_ image gen_platf inc11.png')
217 blacklist('_ image gen_platf inc12.png')
218 blacklist('_ image gen_platf inc13.png')
219 blacklist('_ image gen_platf inc14.png')
220
Matt Sarett6c50a2e2017-05-01 09:13:05 -0400221 # WIC fails on questionable bmps
Eric Boren4c7754c2017-04-10 08:19:10 -0400222 if 'Win' in bot:
223 blacklist('_ image gen_platf rle8-height-negative.bmp')
224 blacklist('_ image gen_platf rle4-height-negative.bmp')
225 blacklist('_ image gen_platf pal8os2v2.bmp')
226 blacklist('_ image gen_platf pal8os2v2-16.bmp')
227 blacklist('_ image gen_platf rgba32abf.bmp')
228 blacklist('_ image gen_platf rgb24prof.bmp')
229 blacklist('_ image gen_platf rgb24lprof.bmp')
230 blacklist('_ image gen_platf 8bpp-pixeldata-cropped.bmp')
231 blacklist('_ image gen_platf 4bpp-pixeldata-cropped.bmp')
232 blacklist('_ image gen_platf 32bpp-pixeldata-cropped.bmp')
233 blacklist('_ image gen_platf 24bpp-pixeldata-cropped.bmp')
Eric Boren4c7754c2017-04-10 08:19:10 -0400234 if 'x86_64' in bot and 'CPU' in bot:
235 # This GM triggers a SkSmallAllocator assert.
236 blacklist('_ gm _ composeshader_bitmap')
237
Matt Sarett6c50a2e2017-05-01 09:13:05 -0400238 # WIC and CG fail on arithmetic jpegs
239 if 'Win' in bot or 'Mac' in bot:
240 blacklist('_ image gen_platf testimgari.jpg')
241
Eric Boren4c7754c2017-04-10 08:19:10 -0400242 if 'Android' in bot or 'iOS' in bot:
243 # This test crashes the N9 (perhaps because of large malloc/frees). It also
244 # is fairly slow and not platform-specific. So we just disable it on all of
245 # Android and iOS. skia:5438
246 blacklist('_ test _ GrShape')
247
Eric Boren4c7754c2017-04-10 08:19:10 -0400248 # skia:4095
249 bad_serialize_gms = ['bleed_image',
250 'c_gms',
251 'colortype',
252 'colortype_xfermodes',
253 'drawfilter',
254 'fontmgr_bounds_0.75_0',
255 'fontmgr_bounds_1_-0.25',
256 'fontmgr_bounds',
257 'fontmgr_match',
258 'fontmgr_iter',
259 'imagemasksubset']
260
261 # skia:5589
262 bad_serialize_gms.extend(['bitmapfilters',
263 'bitmapshaders',
264 'bleed',
265 'bleed_alpha_bmp',
266 'bleed_alpha_bmp_shader',
267 'convex_poly_clip',
268 'extractalpha',
269 'filterbitmap_checkerboard_32_32_g8',
270 'filterbitmap_image_mandrill_64',
271 'shadows',
272 'simpleaaclip_aaclip'])
273 # skia:5595
274 bad_serialize_gms.extend(['composeshader_bitmap',
275 'scaled_tilemodes_npot',
276 'scaled_tilemodes'])
277
278 # skia:5778
279 bad_serialize_gms.append('typefacerendering_pfaMac')
280 # skia:5942
281 bad_serialize_gms.append('parsedpaths')
282
283 # these use a custom image generator which doesn't serialize
284 bad_serialize_gms.append('ImageGeneratorExternal_rect')
285 bad_serialize_gms.append('ImageGeneratorExternal_shader')
286
287 # skia:6189
288 bad_serialize_gms.append('shadow_utils')
289
290 for test in bad_serialize_gms:
291 blacklist(['serialize-8888', 'gm', '_', test])
292
293 if 'Mac' not in bot:
294 for test in ['bleed_alpha_image', 'bleed_alpha_image_shader']:
295 blacklist(['serialize-8888', 'gm', '_', test])
296 # It looks like we skip these only for out-of-memory concerns.
297 if 'Win' in bot or 'Android' in bot:
298 for test in ['verylargebitmap', 'verylarge_picture_image']:
299 blacklist(['serialize-8888', 'gm', '_', test])
300
301 # skia:4769
302 for test in ['drawfilter']:
303 blacklist([ 'sp-8888', 'gm', '_', test])
304 blacklist([ 'pic-8888', 'gm', '_', test])
305 blacklist(['2ndpic-8888', 'gm', '_', test])
306 blacklist([ 'lite-8888', 'gm', '_', test])
307 # skia:4703
308 for test in ['image-cacherator-from-picture',
309 'image-cacherator-from-raster',
310 'image-cacherator-from-ctable']:
311 blacklist([ 'sp-8888', 'gm', '_', test])
312 blacklist([ 'pic-8888', 'gm', '_', test])
313 blacklist([ '2ndpic-8888', 'gm', '_', test])
314 blacklist(['serialize-8888', 'gm', '_', test])
315
316 # GM that requires raster-backed canvas
317 for test in ['gamut', 'complexclip4_bw', 'complexclip4_aa']:
318 blacklist([ 'sp-8888', 'gm', '_', test])
319 blacklist([ 'pic-8888', 'gm', '_', test])
320 blacklist([ 'lite-8888', 'gm', '_', test])
321 blacklist([ '2ndpic-8888', 'gm', '_', test])
322 blacklist(['serialize-8888', 'gm', '_', test])
323
324 # GM that not support tiles_rt
325 for test in ['complexclip4_bw', 'complexclip4_aa']:
326 blacklist([ 'tiles_rt-8888', 'gm', '_', test])
327
328 # Extensions for RAW images
329 r = ["arw", "cr2", "dng", "nef", "nrw", "orf", "raf", "rw2", "pef", "srw",
330 "ARW", "CR2", "DNG", "NEF", "NRW", "ORF", "RAF", "RW2", "PEF", "SRW"]
331
332 # skbug.com/4888
333 # Blacklist RAW images (and a few large PNGs) on GPU bots
334 # until we can resolve failures.
335 # Also blacklisted on 32-bit Win2k8 for F16 OOM errors.
336 if 'GPU' in bot or ('Win2k8' in bot and 'x86-' in bot):
337 blacklist('_ image _ interlaced1.png')
338 blacklist('_ image _ interlaced2.png')
339 blacklist('_ image _ interlaced3.png')
340 for raw_ext in r:
341 blacklist('_ image _ .%s' % raw_ext)
342
Eric Boren4c7754c2017-04-10 08:19:10 -0400343 if 'IntelHD405' in bot and 'Ubuntu16' in bot:
344 # skia:6331
345 blacklist(['glmsaa8', 'image', 'gen_codec_gpu', 'abnormal.wbmp'])
346 blacklist(['glesmsaa4', 'image', 'gen_codec_gpu', 'abnormal.wbmp'])
347
348 if 'Nexus5' in bot:
349 # skia:5876
350 blacklist(['_', 'gm', '_', 'encode-platform'])
351
352 if 'AndroidOne-GPU' in bot: # skia:4697, skia:4704, skia:4694, skia:4705
353 blacklist(['_', 'gm', '_', 'bigblurs'])
354 blacklist(['_', 'gm', '_', 'bleed'])
355 blacklist(['_', 'gm', '_', 'bleed_alpha_bmp'])
356 blacklist(['_', 'gm', '_', 'bleed_alpha_bmp_shader'])
357 blacklist(['_', 'gm', '_', 'bleed_alpha_image'])
358 blacklist(['_', 'gm', '_', 'bleed_alpha_image_shader'])
359 blacklist(['_', 'gm', '_', 'bleed_image'])
360 blacklist(['_', 'gm', '_', 'dropshadowimagefilter'])
361 blacklist(['_', 'gm', '_', 'filterfastbounds'])
362 blacklist([gl_prefix, 'gm', '_', 'imageblurtiled'])
363 blacklist(['_', 'gm', '_', 'imagefiltersclipped'])
364 blacklist(['_', 'gm', '_', 'imagefiltersscaled'])
365 blacklist(['_', 'gm', '_', 'imageresizetiled'])
366 blacklist(['_', 'gm', '_', 'matrixconvolution'])
367 blacklist(['_', 'gm', '_', 'strokedlines'])
368 if sample_count is not '':
369 gl_msaa_config = gl_prefix + 'msaa' + sample_count
370 blacklist([gl_msaa_config, 'gm', '_', 'imageblurtiled'])
371 blacklist([gl_msaa_config, 'gm', '_', 'imagefiltersbase'])
372
373 match = []
374 if 'Valgrind' in bot: # skia:3021
375 match.append('~Threaded')
376
Ben Wagnerbb3e7ff2017-04-28 15:28:32 -0400377 if 'CommandBuffer' in bot:
378 # https://crbug.com/697030
379 match.append('~HalfFloatAlphaTextureTest')
380
Eric Boren4c7754c2017-04-10 08:19:10 -0400381 if 'AndroidOne' in bot: # skia:4711
382 match.append('~WritePixels')
383
384 if 'NexusPlayer' in bot:
385 match.append('~ResourceCache')
386
387 if 'Nexus10' in bot:
388 match.append('~CopySurface') # skia:5509
389 match.append('~SRGBReadWritePixels') # skia:6097
390
Eric Boren4c7754c2017-04-10 08:19:10 -0400391 if 'GalaxyS6' in bot:
392 match.append('~SpecialImage') # skia:6338
393
394 if 'GalaxyS7_G930A' in bot:
395 match.append('~WritePixels') # skia:6427
396
397 if 'ANGLE' in bot and 'Debug' in bot:
398 match.append('~GLPrograms') # skia:4717
399
400 if 'MSAN' in bot:
401 match.extend(['~Once', '~Shared']) # Not sure what's up with these tests.
402
403 if 'TSAN' in bot:
404 match.extend(['~ReadWriteAlpha']) # Flaky on TSAN-covered on nvidia bots.
405 match.extend(['~RGBA4444TextureTest', # Flakier than they are important.
406 '~RGB565TextureTest'])
407
408 if 'Vulkan' in bot and 'Adreno' in bot:
409 # skia:5777
410 match.extend(['~XfermodeImageFilterCroppedInput',
411 '~GrTextureStripAtlasFlush',
412 '~CopySurface'])
413
414 if 'Vulkan' in bot and 'NexusPlayer' in bot:
415 match.extend(['~hardstop_gradient', # skia:6037
416 '~gradients_dup_color_stops', # skia:6037
417 '~gradients_no_texture$', # skia:6132
418 '~tilemodes', # skia:6132
419 '~shadertext$', # skia:6132
420 '~bitmapfilters', # skia:6132
421 '~GrContextFactory_abandon']) #skia:6209
422
423 if 'Vulkan' in bot and 'IntelIris540' in bot and 'Ubuntu' in bot:
424 match.extend(['~VkHeapTests']) # skia:6245
425
426 if 'Vulkan' in bot and 'IntelIris540' in bot and 'Win' in bot:
427 # skia:6398
428 blacklist(['vk', 'gm', '_', 'aarectmodes'])
429 blacklist(['vk', 'gm', '_', 'aaxfermodes'])
430 blacklist(['vk', 'gm', '_', 'arithmode'])
431 blacklist(['vk', 'gm', '_', 'composeshader_bitmap'])
432 blacklist(['vk', 'gm', '_', 'composeshader_bitmap2'])
433 blacklist(['vk', 'gm', '_', 'dftextCOLR'])
434 blacklist(['vk', 'gm', '_', 'drawregionmodes'])
435 blacklist(['vk', 'gm', '_', 'filterfastbounds'])
436 blacklist(['vk', 'gm', '_', 'fontcache'])
437 blacklist(['vk', 'gm', '_', 'fontmgr_iterWin10'])
438 blacklist(['vk', 'gm', '_', 'fontmgr_iter_factoryWin10'])
439 blacklist(['vk', 'gm', '_', 'fontmgr_matchWin10'])
440 blacklist(['vk', 'gm', '_', 'fontscalerWin'])
441 blacklist(['vk', 'gm', '_', 'fontscalerdistortable'])
442 blacklist(['vk', 'gm', '_', 'gammagradienttext'])
443 blacklist(['vk', 'gm', '_', 'gammatextWin'])
444 blacklist(['vk', 'gm', '_', 'gradtext'])
445 blacklist(['vk', 'gm', '_', 'hairmodes'])
446 blacklist(['vk', 'gm', '_', 'imagefilters_xfermodes'])
447 blacklist(['vk', 'gm', '_', 'imagefiltersclipped'])
448 blacklist(['vk', 'gm', '_', 'imagefiltersgraph'])
449 blacklist(['vk', 'gm', '_', 'imagefiltersscaled'])
450 blacklist(['vk', 'gm', '_', 'imagefiltersstroked'])
451 blacklist(['vk', 'gm', '_', 'imagefilterstransformed'])
452 blacklist(['vk', 'gm', '_', 'imageresizetiled'])
453 blacklist(['vk', 'gm', '_', 'lcdblendmodes'])
454 blacklist(['vk', 'gm', '_', 'lcdoverlap'])
455 blacklist(['vk', 'gm', '_', 'lcdtextWin'])
456 blacklist(['vk', 'gm', '_', 'lcdtextsize'])
457 blacklist(['vk', 'gm', '_', 'matriximagefilter'])
458 blacklist(['vk', 'gm', '_', 'mixedtextblobsCOLR'])
459 blacklist(['vk', 'gm', '_', 'pictureimagefilter'])
460 blacklist(['vk', 'gm', '_', 'resizeimagefilter'])
461 blacklist(['vk', 'gm', '_', 'rotate_imagefilter'])
462 blacklist(['vk', 'gm', '_', 'savelayer_lcdtext'])
463 blacklist(['vk', 'gm', '_', 'srcmode'])
464 blacklist(['vk', 'gm', '_', 'surfaceprops'])
465 blacklist(['vk', 'gm', '_', 'textblobgeometrychange'])
466 blacklist(['vk', 'gm', '_', 'textbloblooper'])
467 blacklist(['vk', 'gm', '_', 'textblobmixedsizes'])
468 blacklist(['vk', 'gm', '_', 'textblobmixedsizes_df'])
469 blacklist(['vk', 'gm', '_', 'textblobrandomfont'])
470 blacklist(['vk', 'gm', '_', 'textfilter_color'])
471 blacklist(['vk', 'gm', '_', 'textfilter_image'])
472 blacklist(['vk', 'gm', '_', 'typefacerenderingWin'])
473 blacklist(['vk', 'gm', '_', 'varied_text_clipped_lcd'])
474 blacklist(['vk', 'gm', '_', 'varied_text_ignorable_clip_lcd'])
475 blacklist(['vk', 'gm', '_', 'xfermodeimagefilter'])
476 match.append('~ApplyGamma')
477 match.append('~ComposedImageFilterBounds_Gpu')
Matt Sarett77443972017-04-11 11:25:37 -0400478 match.append('~DeferredTextureImage')
Eric Boren4c7754c2017-04-10 08:19:10 -0400479 match.append('~ImageFilterFailAffectsTransparentBlack_Gpu')
480 match.append('~ImageFilterZeroBlurSigma_Gpu')
481 match.append('~ImageNewShader_GPU')
482 match.append('~NewTextureFromPixmap')
483 match.append('~ReadPixels_Gpu')
484 match.append('~ReadPixels_Texture')
485 match.append('~ReadWriteAlpha')
486 match.append('~SRGBReadWritePixels')
487 match.append('~SpecialImage_DeferredGpu')
488 match.append('~SpecialImage_Gpu')
489 match.append('~WritePixels_Gpu')
Brian Osman33ea1362017-04-19 10:51:39 -0400490 match.append('~WritePixelsNonTexture_Gpu')
Eric Boren4c7754c2017-04-10 08:19:10 -0400491 match.append('~XfermodeImageFilterCroppedInput_Gpu')
492
493 if 'IntelIris540' in bot and 'ANGLE' in bot:
494 match.append('~IntTexture') # skia:6086
495 blacklist(['_', 'gm', '_', 'discard']) # skia:6141
496 # skia:6103
497 for config in ['angle_d3d9_es2', 'angle_d3d11_es2', 'angle_gl_es2']:
498 blacklist([config, 'gm', '_', 'multipicturedraw_invpathclip_simple'])
499 blacklist([config, 'gm', '_', 'multipicturedraw_noclip_simple'])
500 blacklist([config, 'gm', '_', 'multipicturedraw_pathclip_simple'])
501 blacklist([config, 'gm', '_', 'multipicturedraw_rectclip_simple'])
502 blacklist([config, 'gm', '_', 'multipicturedraw_rrectclip_simple'])
503
504 if 'IntelBayTrail' in bot and 'Ubuntu' in bot:
505 match.append('~ImageStorageLoad') # skia:6358
506
Kevin Lubickae95db42017-04-10 13:05:49 -0400507 if 'Ci20' in bot:
508 match.append('~Codec_Dimensions') # skia:6477
509 match.append('~FontMgrAndroidParser') # skia:6478
510 match.append('~PathOpsSimplify') # skia:6479
511 blacklist(['_', 'gm', '_', 'fast_slow_blurimagefilter']) # skia:6480
512
513
Eric Boren4c7754c2017-04-10 08:19:10 -0400514 if blacklisted:
515 args.append('--blacklist')
516 args.extend(blacklisted)
517
518 if match:
519 args.append('--match')
520 args.extend(match)
521
522 # These bots run out of memory running RAW codec tests. Do not run them in
523 # parallel
524 if ('NexusPlayer' in bot or 'Nexus5' in bot or 'Nexus9' in bot
525 or 'Win8-MSVC-ShuttleB' in bot):
526 args.append('--noRAW_threading')
527
528 return args
529
530
531def key_params(api):
532 """Build a unique key from the builder name (as a list).
533
534 E.g. arch x86 gpu GeForce320M mode MacMini4.1 os Mac10.6
535 """
536 # Don't bother to include role, which is always Test.
537 # TryBots are uploaded elsewhere so they can use the same key.
538 blacklist = ['role', 'is_trybot']
539
540 flat = []
541 for k in sorted(api.vars.builder_cfg.keys()):
542 if k not in blacklist:
543 flat.append(k)
544 flat.append(api.vars.builder_cfg[k])
545 return flat
546
547
548def test_steps(api):
549 """Run the DM test."""
550 use_hash_file = False
551 if api.vars.upload_dm_results:
552 # This must run before we write anything into
553 # api.flavor.device_dirs.dm_dir or we may end up deleting our
554 # output on machines where they're the same.
555 api.flavor.create_clean_host_dir(api.vars.dm_dir)
556 host_dm_dir = str(api.vars.dm_dir)
557 device_dm_dir = str(api.flavor.device_dirs.dm_dir)
558 if host_dm_dir != device_dm_dir:
559 api.flavor.create_clean_device_dir(device_dm_dir)
560
561 # Obtain the list of already-generated hashes.
562 hash_filename = 'uninteresting_hashes.txt'
563
564 # Ensure that the tmp_dir exists.
565 api.run.run_once(api.file.makedirs,
566 'tmp_dir',
567 api.vars.tmp_dir,
568 infra_step=True)
569
570 host_hashes_file = api.vars.tmp_dir.join(hash_filename)
571 hashes_file = api.flavor.device_path_join(
572 api.flavor.device_dirs.tmp_dir, hash_filename)
573 api.run(
574 api.python.inline,
575 'get uninteresting hashes',
576 program="""
577 import contextlib
578 import math
579 import socket
580 import sys
581 import time
582 import urllib2
583
584 HASHES_URL = 'https://gold.skia.org/_/hashes'
585 RETRIES = 5
586 TIMEOUT = 60
587 WAIT_BASE = 15
588
589 socket.setdefaulttimeout(TIMEOUT)
590 for retry in range(RETRIES):
591 try:
592 with contextlib.closing(
593 urllib2.urlopen(HASHES_URL, timeout=TIMEOUT)) as w:
594 hashes = w.read()
595 with open(sys.argv[1], 'w') as f:
596 f.write(hashes)
597 break
598 except Exception as e:
599 print 'Failed to get uninteresting hashes from %s:' % HASHES_URL
600 print e
601 if retry == RETRIES:
602 raise
603 waittime = WAIT_BASE * math.pow(2, retry)
604 print 'Retry in %d seconds.' % waittime
605 time.sleep(waittime)
606 """,
607 args=[host_hashes_file],
608 abort_on_failure=False,
609 fail_build_on_failure=False,
610 infra_step=True)
611
612 if api.path.exists(host_hashes_file):
613 api.flavor.copy_file_to_device(host_hashes_file, hashes_file)
614 use_hash_file = True
615
616 # Run DM.
617 properties = [
618 'gitHash', api.vars.got_revision,
Eric Boren4c7754c2017-04-10 08:19:10 -0400619 'builder', api.vars.builder_name,
Eric Boren4c7754c2017-04-10 08:19:10 -0400620 ]
621 if api.vars.is_trybot:
622 properties.extend([
623 'issue', api.vars.issue,
624 'patchset', api.vars.patchset,
625 'patch_storage', api.vars.patch_storage,
626 ])
Eric Borenf9aa9e52017-04-10 09:56:10 -0400627 properties.extend(['swarming_bot_id', api.vars.swarming_bot_id])
628 properties.extend(['swarming_task_id', api.vars.swarming_task_id])
Eric Boren4c7754c2017-04-10 08:19:10 -0400629
630 args = [
631 'dm',
632 '--undefok', # This helps branches that may not know new flags.
633 '--resourcePath', api.flavor.device_dirs.resource_dir,
634 '--skps', api.flavor.device_dirs.skp_dir,
635 '--images', api.flavor.device_path_join(
636 api.flavor.device_dirs.images_dir, 'dm'),
637 '--colorImages', api.flavor.device_path_join(
638 api.flavor.device_dirs.images_dir, 'colorspace'),
639 '--nameByHash',
640 '--properties'
641 ] + properties
642
643 args.extend(['--svgs', api.flavor.device_dirs.svg_dir])
644
645 args.append('--key')
646 args.extend(key_params(api))
647 if use_hash_file:
648 args.extend(['--uninterestingHashesFile', hashes_file])
649 if api.vars.upload_dm_results:
650 args.extend(['--writePath', api.flavor.device_dirs.dm_dir])
651
652 skip_flag = None
653 if api.vars.builder_cfg.get('cpu_or_gpu') == 'CPU':
654 skip_flag = '--nogpu'
655 elif api.vars.builder_cfg.get('cpu_or_gpu') == 'GPU':
656 skip_flag = '--nocpu'
657 if skip_flag:
658 args.append(skip_flag)
659 args.extend(dm_flags(api.vars.builder_name))
660
Eric Boren896af752017-04-24 13:22:56 -0400661 env = {}
Eric Boren4c7754c2017-04-10 08:19:10 -0400662 if 'Ubuntu16' in api.vars.builder_name:
663 # The vulkan in this asset name simply means that the graphics driver
664 # supports Vulkan. It is also the driver used for GL code.
665 dri_path = api.vars.slave_dir.join('linux_vulkan_intel_driver_release')
666 if 'Debug' in api.vars.builder_name:
667 dri_path = api.vars.slave_dir.join('linux_vulkan_intel_driver_debug')
668
669 if 'Vulkan' in api.vars.builder_name:
670 sdk_path = api.vars.slave_dir.join('linux_vulkan_sdk', 'bin')
671 lib_path = api.vars.slave_dir.join('linux_vulkan_sdk', 'lib')
672 env.update({
673 'PATH':'%%(PATH)s:%s' % sdk_path,
674 'LD_LIBRARY_PATH': '%s:%s' % (lib_path, dri_path),
675 'LIBGL_DRIVERS_PATH': dri_path,
676 'VK_ICD_FILENAMES':'%s' % dri_path.join('intel_icd.x86_64.json'),
677 })
678 else:
679 # Even the non-vulkan NUC jobs could benefit from the newer drivers.
680 env.update({
681 'LD_LIBRARY_PATH': dri_path,
682 'LIBGL_DRIVERS_PATH': dri_path,
683 })
684
685 # See skia:2789.
Ben Wagner988d15e2017-04-27 13:08:50 -0400686 extra_config_parts = api.vars.builder_cfg.get('extra_config', '').split('_')
687 if 'AbandonGpuContext' in extra_config_parts:
Eric Boren4c7754c2017-04-10 08:19:10 -0400688 args.append('--abandonGpuContext')
Ben Wagner988d15e2017-04-27 13:08:50 -0400689 if 'PreAbandonGpuContext' in extra_config_parts:
Eric Boren4c7754c2017-04-10 08:19:10 -0400690 args.append('--preAbandonGpuContext')
Ben Wagner988d15e2017-04-27 13:08:50 -0400691 if 'ReleaseAndAbandonGpuContext' in extra_config_parts:
Eric Boren6ec17e32017-04-26 14:25:29 -0400692 args.append('--releaseAndAbandonGpuContext')
Eric Boren4c7754c2017-04-10 08:19:10 -0400693
Eric Boren896af752017-04-24 13:22:56 -0400694 with api.env(env):
Eric Boren4c7754c2017-04-10 08:19:10 -0400695 api.run(api.flavor.step, 'dm', cmd=args, abort_on_failure=False)
696
697 if api.vars.upload_dm_results:
698 # Copy images and JSON to host machine if needed.
699 api.flavor.copy_directory_contents_to_host(
700 api.flavor.device_dirs.dm_dir, api.vars.dm_dir)
701
702
borenet1ed2ae42016-07-26 11:52:17 -0700703def RunSteps(api):
Eric Boren4c7754c2017-04-10 08:19:10 -0400704 api.core.setup()
705 env = api.step.get_from_context('env', {})
706 if 'iOS' in api.vars.builder_name:
707 env['IOS_BUNDLE_ID'] = 'com.google.dm'
Stephan Altmueller63e843d2017-04-25 11:38:38 -0400708 env['IOS_MOUNT_POINT'] = api.vars.slave_dir.join('mnt_iosdevice')
Eric Boren4c7754c2017-04-10 08:19:10 -0400709 with api.step.context({'env': env}):
710 try:
711 api.flavor.install_everything()
712 test_steps(api)
713 finally:
714 api.flavor.cleanup_steps()
715 api.run.check_failure()
716
717
Eric Borenf9aa9e52017-04-10 09:56:10 -0400718TEST_BUILDERS = [
Kevin Lubickfe079d42017-04-12 08:31:48 -0400719 'Test-Android-Clang-AndroidOne-GPU-Mali400MP2-arm-Release-Android',
Kevin Lubickae95db42017-04-10 13:05:49 -0400720 'Test-Android-Clang-Ci20-CPU-IngenicJZ4780-mipsel-Release-Android',
Eric Borenf9aa9e52017-04-10 09:56:10 -0400721 'Test-Android-Clang-GalaxyS6-GPU-MaliT760-arm64-Debug-Android',
722 'Test-Android-Clang-GalaxyS7_G930A-GPU-Adreno530-arm64-Debug-Android',
Kevin Lubickfe079d42017-04-12 08:31:48 -0400723 'Test-Android-Clang-NVIDIA_Shield-GPU-TegraX1-arm64-Debug-Android',
724 'Test-Android-Clang-Nexus10-GPU-MaliT604-arm-Release-Android',
Eric Borenf9aa9e52017-04-10 09:56:10 -0400725 'Test-Android-Clang-Nexus5-GPU-Adreno330-arm-Release-Android',
Kevin Lubickfe079d42017-04-12 08:31:48 -0400726 'Test-Android-Clang-Nexus6p-GPU-Adreno430-arm64-Debug-Android_Vulkan',
727 'Test-Android-Clang-Nexus7-GPU-Tegra3-arm-Debug-Android',
728 'Test-Android-Clang-NexusPlayer-CPU-SSE4-x86-Release-Android',
729 'Test-Android-Clang-NexusPlayer-GPU-PowerVR-x86-Release-Android_Vulkan',
730 'Test-Android-Clang-PixelC-CPU-TegraX1-arm64-Debug-Android',
Eric Borenf9aa9e52017-04-10 09:56:10 -0400731 'Test-ChromeOS-Clang-Chromebook_C100p-GPU-MaliT764-arm-Debug',
Eric Borenf9aa9e52017-04-10 09:56:10 -0400732 'Test-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Debug',
733 'Test-Mac-Clang-MacMini6.2-GPU-HD4000-x86_64-Debug-CommandBuffer',
Kevin Lubickfe079d42017-04-12 08:31:48 -0400734 'Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Debug-ASAN',
735 'Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Debug-MSAN',
736 'Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Release-TSAN',
Eric Borenf9aa9e52017-04-10 09:56:10 -0400737 'Test-Ubuntu-GCC-GCE-CPU-AVX2-x86-Debug',
738 'Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug',
Eric Borenf9aa9e52017-04-10 09:56:10 -0400739 'Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind',
740 ('Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind' +
741 '_AbandonGpuContext'),
742 ('Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind' +
743 '_PreAbandonGpuContext'),
Eric Borenf9aa9e52017-04-10 09:56:10 -0400744 ('Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_' +
745 'SCALEDIMAGECACHE'),
Kevin Lubickfe079d42017-04-12 08:31:48 -0400746 'Test-Ubuntu16-Clang-NUC5PPYH-GPU-IntelHD405-x86_64-Debug',
747 'Test-Ubuntu16-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-Vulkan',
748 'Test-Ubuntu16-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Release',
749 'Test-Ubuntu16-Clang-NUCDE3815TYKHE-GPU-IntelBayTrail-x86_64-Debug',
750 'Test-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-Vulkan',
Eric Boren6ec17e32017-04-26 14:25:29 -0400751 ('Test-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Release-'
752 'ReleaseAndAbandonGpuContext'),
Kevin Lubickfe079d42017-04-12 08:31:48 -0400753 'Test-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE',
754 'Test-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-Vulkan',
755 'Test-Win10-MSVC-ShuttleA-GPU-GTX660-x86_64-Debug-Vulkan',
756 'Test-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE',
757 'Test-Win10-MSVC-ZBOX-GPU-GTX1070-x86_64-Debug-Vulkan',
758 'Test-iOS-Clang-iPadMini4-GPU-GX6450-arm-Release',
Eric Borenf9aa9e52017-04-10 09:56:10 -0400759]
borenet1ed2ae42016-07-26 11:52:17 -0700760
761
762def GenTests(api):
Eric Borenf9aa9e52017-04-10 09:56:10 -0400763 for builder in TEST_BUILDERS:
764 test = (
765 api.test(builder) +
766 api.properties(buildername=builder,
767 revision='abc123',
768 path_config='kitchen',
769 swarm_out_dir='[SWARM_OUT_DIR]') +
770 api.path.exists(
771 api.path['start_dir'].join('skia'),
772 api.path['start_dir'].join('skia', 'infra', 'bots', 'assets',
773 'skimage', 'VERSION'),
774 api.path['start_dir'].join('skia', 'infra', 'bots', 'assets',
775 'skp', 'VERSION'),
776 api.path['start_dir'].join('skia', 'infra', 'bots', 'assets',
777 'svg', 'VERSION'),
778 api.path['start_dir'].join('tmp', 'uninteresting_hashes.txt')
Ben Wagnerf835c222017-04-30 11:14:51 -0400779 ) +
780 api.step_data('get swarming bot id',
781 stdout=api.raw_io.output('skia-bot-123')) +
782 api.step_data('get swarming task id',
783 stdout=api.raw_io.output('123456'))
Eric Borenf9aa9e52017-04-10 09:56:10 -0400784 )
Eric Borenf9aa9e52017-04-10 09:56:10 -0400785 if 'Win' in builder:
786 test += api.platform('win', 64)
Eric Boren4c7754c2017-04-10 08:19:10 -0400787
Eric Borenf9aa9e52017-04-10 09:56:10 -0400788 if 'ChromeOS' in builder:
789 test += api.step_data(
790 'read chromeos ip',
791 stdout=api.raw_io.output('{"user_ip":"foo@127.0.0.1"}'))
Eric Boren4c7754c2017-04-10 08:19:10 -0400792
793
Eric Borenf9aa9e52017-04-10 09:56:10 -0400794 yield test
Eric Boren4c7754c2017-04-10 08:19:10 -0400795
Kevin Lubickfe079d42017-04-12 08:31:48 -0400796 builder = 'Test-Win2k8-MSVC-GCE-CPU-AVX2-x86_64-Release'
797 yield (
798 api.test('trybot') +
799 api.properties(buildername=builder,
800 revision='abc123',
801 path_config='kitchen',
802 swarm_out_dir='[SWARM_OUT_DIR]') +
803 api.properties(patch_storage='gerrit') +
804 api.properties.tryserver(
805 buildername=builder,
806 gerrit_project='skia',
807 gerrit_url='https://skia-review.googlesource.com/',
808 )+
809 api.path.exists(
810 api.path['start_dir'].join('skia'),
811 api.path['start_dir'].join('skia', 'infra', 'bots', 'assets',
812 'skimage', 'VERSION'),
813 api.path['start_dir'].join('skia', 'infra', 'bots', 'assets',
814 'skp', 'VERSION'),
815 api.path['start_dir'].join('skia', 'infra', 'bots', 'assets',
816 'svg', 'VERSION'),
817 api.path['start_dir'].join('tmp', 'uninteresting_hashes.txt')
818 )
819 )
820
Eric Boren4c7754c2017-04-10 08:19:10 -0400821 builder = 'Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug'
borenet1ed2ae42016-07-26 11:52:17 -0700822 yield (
Eric Boren4c7754c2017-04-10 08:19:10 -0400823 api.test('failed_dm') +
824 api.properties(buildername=builder,
borenet1ed2ae42016-07-26 11:52:17 -0700825 revision='abc123',
826 path_config='kitchen',
827 swarm_out_dir='[SWARM_OUT_DIR]') +
828 api.path.exists(
Ravi Mistry9bcca6a2016-11-21 16:06:19 -0500829 api.path['start_dir'].join('skia'),
830 api.path['start_dir'].join('skia', 'infra', 'bots', 'assets',
Eric Boren4c7754c2017-04-10 08:19:10 -0400831 'skimage', 'VERSION'),
Ravi Mistry9bcca6a2016-11-21 16:06:19 -0500832 api.path['start_dir'].join('skia', 'infra', 'bots', 'assets',
Eric Boren4c7754c2017-04-10 08:19:10 -0400833 'skp', 'VERSION'),
Ravi Mistry9bcca6a2016-11-21 16:06:19 -0500834 api.path['start_dir'].join('skia', 'infra', 'bots', 'assets',
Eric Boren4c7754c2017-04-10 08:19:10 -0400835 'svg', 'VERSION'),
Ravi Mistry9bcca6a2016-11-21 16:06:19 -0500836 api.path['start_dir'].join('tmp', 'uninteresting_hashes.txt')
Eric Boren4c7754c2017-04-10 08:19:10 -0400837 ) +
838 api.step_data('symbolized dm', retcode=1)
839 )
840
Kevin Lubickfe079d42017-04-12 08:31:48 -0400841 builder = 'Test-Android-Clang-Nexus7-GPU-Tegra3-arm-Debug-Android'
Eric Boren4c7754c2017-04-10 08:19:10 -0400842 yield (
843 api.test('failed_get_hashes') +
844 api.properties(buildername=builder,
Eric Boren4c7754c2017-04-10 08:19:10 -0400845 revision='abc123',
846 path_config='kitchen',
847 swarm_out_dir='[SWARM_OUT_DIR]') +
848 api.path.exists(
849 api.path['start_dir'].join('skia'),
850 api.path['start_dir'].join('skia', 'infra', 'bots', 'assets',
851 'skimage', 'VERSION'),
852 api.path['start_dir'].join('skia', 'infra', 'bots', 'assets',
853 'skp', 'VERSION'),
854 api.path['start_dir'].join('skia', 'infra', 'bots', 'assets',
855 'svg', 'VERSION'),
856 api.path['start_dir'].join('tmp', 'uninteresting_hashes.txt')
857 ) +
858 api.step_data('get uninteresting hashes', retcode=1)
859 )
860
Kevin Lubickfe079d42017-04-12 08:31:48 -0400861 builder = 'Test-Android-Clang-NexusPlayer-CPU-SSE4-x86-Debug-Android'
Eric Boren4c7754c2017-04-10 08:19:10 -0400862 yield (
863 api.test('failed_push') +
864 api.properties(buildername=builder,
Eric Boren4c7754c2017-04-10 08:19:10 -0400865 revision='abc123',
866 path_config='kitchen',
867 swarm_out_dir='[SWARM_OUT_DIR]') +
868 api.path.exists(
869 api.path['start_dir'].join('skia'),
870 api.path['start_dir'].join('skia', 'infra', 'bots', 'assets',
871 'skimage', 'VERSION'),
872 api.path['start_dir'].join('skia', 'infra', 'bots', 'assets',
873 'skp', 'VERSION'),
874 api.path['start_dir'].join('skia', 'infra', 'bots', 'assets',
875 'svg', 'VERSION'),
876 api.path['start_dir'].join('tmp', 'uninteresting_hashes.txt')
877 ) +
878 api.step_data('push [START_DIR]/skia/resources/* '+
879 '/sdcard/revenge_of_the_skiabot/resources', retcode=1)
880 )
881
882 builder = 'Test-Android-Clang-Nexus10-GPU-MaliT604-arm-Debug-Android'
883 yield (
884 api.test('failed_pull') +
885 api.properties(buildername=builder,
Eric Boren4c7754c2017-04-10 08:19:10 -0400886 revision='abc123',
887 path_config='kitchen',
888 swarm_out_dir='[SWARM_OUT_DIR]') +
889 api.path.exists(
890 api.path['start_dir'].join('skia'),
891 api.path['start_dir'].join('skia', 'infra', 'bots', 'assets',
892 'skimage', 'VERSION'),
893 api.path['start_dir'].join('skia', 'infra', 'bots', 'assets',
894 'skp', 'VERSION'),
895 api.path['start_dir'].join('skia', 'infra', 'bots', 'assets',
896 'svg', 'VERSION'),
897 api.path['start_dir'].join('tmp', 'uninteresting_hashes.txt')
898 ) +
899 api.step_data('dm', retcode=1) +
900 api.step_data('pull /sdcard/revenge_of_the_skiabot/dm_out '+
901 '[CUSTOM_[SWARM_OUT_DIR]]/dm', retcode=1)
borenetbfa5b452016-10-19 10:13:32 -0700902 )