rmistry@google.com | 8e3ff8c | 2013-01-17 12:55:34 +0000 | [diff] [blame] | 1 | # Copyright (c) 2013 The Chromium Authors. All rights reserved. |
| 2 | # Use of this source code is governed by a BSD-style license that can be |
| 3 | # found in the LICENSE file. |
| 4 | |
| 5 | |
| 6 | """Top-level presubmit script for Skia. |
| 7 | |
| 8 | See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
| 9 | for more details about the presubmit API built into gcl. |
| 10 | """ |
| 11 | |
commit-bot@chromium.org | 745e08c | 2014-02-03 14:18:32 +0000 | [diff] [blame] | 12 | import fnmatch |
rmistry@google.com | f6c5f75 | 2013-03-29 17:26:00 +0000 | [diff] [blame] | 13 | import os |
commit-bot@chromium.org | cfdc596 | 2014-01-31 17:33:04 +0000 | [diff] [blame] | 14 | import re |
rmistry | d223fb2 | 2015-02-26 10:16:13 -0800 | [diff] [blame] | 15 | import subprocess |
rmistry@google.com | f6c5f75 | 2013-03-29 17:26:00 +0000 | [diff] [blame] | 16 | import sys |
commit-bot@chromium.org | 745e08c | 2014-02-03 14:18:32 +0000 | [diff] [blame] | 17 | import traceback |
rmistry@google.com | f6c5f75 | 2013-03-29 17:26:00 +0000 | [diff] [blame] | 18 | |
rmistry@google.com | c299344 | 2013-01-23 14:35:58 +0000 | [diff] [blame] | 19 | |
commit-bot@chromium.org | cfdc596 | 2014-01-31 17:33:04 +0000 | [diff] [blame] | 20 | REVERT_CL_SUBJECT_PREFIX = 'Revert ' |
| 21 | |
rmistry@google.com | 547012d | 2013-04-12 19:45:46 +0000 | [diff] [blame] | 22 | SKIA_TREE_STATUS_URL = 'http://skia-tree-status.appspot.com' |
| 23 | |
rmistry | f2d83ca | 2014-08-26 10:30:29 -0700 | [diff] [blame] | 24 | # Please add the complete email address here (and not just 'xyz@' or 'xyz'). |
rmistry@google.com | fb4a68d | 2013-08-12 14:51:20 +0000 | [diff] [blame] | 25 | PUBLIC_API_OWNERS = ( |
| 26 | 'reed@chromium.org', |
| 27 | 'reed@google.com', |
| 28 | 'bsalomon@chromium.org', |
| 29 | 'bsalomon@google.com', |
rmistry | 83fab47 | 2014-07-18 05:25:56 -0700 | [diff] [blame] | 30 | 'djsollen@chromium.org', |
| 31 | 'djsollen@google.com', |
rmistry@google.com | fb4a68d | 2013-08-12 14:51:20 +0000 | [diff] [blame] | 32 | ) |
| 33 | |
commit-bot@chromium.org | 745e08c | 2014-02-03 14:18:32 +0000 | [diff] [blame] | 34 | AUTHORS_FILE_NAME = 'AUTHORS' |
| 35 | |
rmistry | d223fb2 | 2015-02-26 10:16:13 -0800 | [diff] [blame] | 36 | DOCS_PREVIEW_URL = 'https://skia.org/?cl=' |
| 37 | |
rmistry@google.com | 547012d | 2013-04-12 19:45:46 +0000 | [diff] [blame] | 38 | |
rmistry@google.com | 713276b | 2013-01-25 18:27:34 +0000 | [diff] [blame] | 39 | def _CheckChangeHasEol(input_api, output_api, source_file_filter=None): |
| 40 | """Checks that files end with atleast one \n (LF).""" |
| 41 | eof_files = [] |
| 42 | for f in input_api.AffectedSourceFiles(source_file_filter): |
| 43 | contents = input_api.ReadFile(f, 'rb') |
| 44 | # Check that the file ends in atleast one newline character. |
| 45 | if len(contents) > 1 and contents[-1:] != '\n': |
| 46 | eof_files.append(f.LocalPath()) |
| 47 | |
| 48 | if eof_files: |
| 49 | return [output_api.PresubmitPromptWarning( |
| 50 | 'These files should end in a newline character:', |
| 51 | items=eof_files)] |
| 52 | return [] |
| 53 | |
| 54 | |
Eric Boren | bb0ef0a | 2014-06-25 11:13:27 -0400 | [diff] [blame] | 55 | def _PythonChecks(input_api, output_api): |
| 56 | """Run checks on any modified Python files.""" |
| 57 | pylint_disabled_warnings = ( |
| 58 | 'F0401', # Unable to import. |
| 59 | 'E0611', # No name in module. |
| 60 | 'W0232', # Class has no __init__ method. |
| 61 | 'E1002', # Use of super on an old style class. |
| 62 | 'W0403', # Relative import used. |
| 63 | 'R0201', # Method could be a function. |
| 64 | 'E1003', # Using class name in super. |
| 65 | 'W0613', # Unused argument. |
| 66 | ) |
| 67 | # Run Pylint on only the modified python files. Unfortunately it still runs |
| 68 | # Pylint on the whole file instead of just the modified lines. |
| 69 | affected_python_files = [] |
| 70 | for affected_file in input_api.AffectedSourceFiles(None): |
| 71 | affected_file_path = affected_file.LocalPath() |
| 72 | if affected_file_path.endswith('.py'): |
| 73 | affected_python_files.append(affected_file_path) |
| 74 | return input_api.canned_checks.RunPylint( |
| 75 | input_api, output_api, |
| 76 | disabled_warnings=pylint_disabled_warnings, |
| 77 | white_list=affected_python_files) |
| 78 | |
| 79 | |
rmistry | 01cbf6c | 2015-03-12 07:48:40 -0700 | [diff] [blame] | 80 | def _IfDefChecks(input_api, output_api): |
| 81 | """Ensures if/ifdef are not before includes. See skbug/3362 for details.""" |
| 82 | comment_block_start_pattern = re.compile('^\s*\/\*.*$') |
| 83 | comment_block_middle_pattern = re.compile('^\s+\*.*') |
| 84 | comment_block_end_pattern = re.compile('^\s+\*\/.*$') |
| 85 | single_line_comment_pattern = re.compile('^\s*//.*$') |
| 86 | def is_comment(line): |
| 87 | return (comment_block_start_pattern.match(line) or |
| 88 | comment_block_middle_pattern.match(line) or |
| 89 | comment_block_end_pattern.match(line) or |
| 90 | single_line_comment_pattern.match(line)) |
| 91 | |
| 92 | empty_line_pattern = re.compile('^\s*$') |
| 93 | def is_empty_line(line): |
| 94 | return empty_line_pattern.match(line) |
| 95 | |
| 96 | failing_files = [] |
| 97 | for affected_file in input_api.AffectedSourceFiles(None): |
| 98 | affected_file_path = affected_file.LocalPath() |
| 99 | if affected_file_path.endswith('.cpp') or affected_file_path.endswith('.h'): |
| 100 | f = open(affected_file_path) |
| 101 | for line in f.xreadlines(): |
| 102 | if is_comment(line) or is_empty_line(line): |
| 103 | continue |
| 104 | # The below will be the first real line after comments and newlines. |
| 105 | if line.startswith('#if 0 '): |
| 106 | pass |
| 107 | elif line.startswith('#if ') or line.startswith('#ifdef '): |
| 108 | failing_files.append(affected_file_path) |
| 109 | break |
| 110 | |
| 111 | results = [] |
| 112 | if failing_files: |
| 113 | results.append( |
| 114 | output_api.PresubmitError( |
| 115 | 'The following files have #if or #ifdef before includes:\n%s\n\n' |
| 116 | 'See skbug.com/3362 for why this should be fixed.' % |
| 117 | '\n'.join(failing_files))) |
| 118 | return results |
| 119 | |
| 120 | |
rmistry@google.com | 6be0b4c | 2013-01-17 14:50:59 +0000 | [diff] [blame] | 121 | def _CommonChecks(input_api, output_api): |
| 122 | """Presubmit checks common to upload and commit.""" |
| 123 | results = [] |
| 124 | sources = lambda x: (x.LocalPath().endswith('.h') or |
| 125 | x.LocalPath().endswith('.gypi') or |
| 126 | x.LocalPath().endswith('.gyp') or |
| 127 | x.LocalPath().endswith('.py') or |
| 128 | x.LocalPath().endswith('.sh') or |
| 129 | x.LocalPath().endswith('.cpp')) |
| 130 | results.extend( |
rmistry@google.com | 713276b | 2013-01-25 18:27:34 +0000 | [diff] [blame] | 131 | _CheckChangeHasEol( |
rmistry@google.com | 6be0b4c | 2013-01-17 14:50:59 +0000 | [diff] [blame] | 132 | input_api, output_api, source_file_filter=sources)) |
Eric Boren | bb0ef0a | 2014-06-25 11:13:27 -0400 | [diff] [blame] | 133 | results.extend(_PythonChecks(input_api, output_api)) |
rmistry | 01cbf6c | 2015-03-12 07:48:40 -0700 | [diff] [blame] | 134 | results.extend(_IfDefChecks(input_api, output_api)) |
rmistry@google.com | 6be0b4c | 2013-01-17 14:50:59 +0000 | [diff] [blame] | 135 | return results |
| 136 | |
rmistry@google.com | 8e3ff8c | 2013-01-17 12:55:34 +0000 | [diff] [blame] | 137 | |
| 138 | def CheckChangeOnUpload(input_api, output_api): |
rmistry@google.com | 6be0b4c | 2013-01-17 14:50:59 +0000 | [diff] [blame] | 139 | """Presubmit checks for the change on upload. |
| 140 | |
| 141 | The following are the presubmit checks: |
| 142 | * Check change has one and only one EOL. |
| 143 | """ |
| 144 | results = [] |
| 145 | results.extend(_CommonChecks(input_api, output_api)) |
| 146 | return results |
rmistry@google.com | 8e3ff8c | 2013-01-17 12:55:34 +0000 | [diff] [blame] | 147 | |
| 148 | |
rmistry@google.com | c299344 | 2013-01-23 14:35:58 +0000 | [diff] [blame] | 149 | def _CheckTreeStatus(input_api, output_api, json_url): |
| 150 | """Check whether to allow commit. |
| 151 | |
| 152 | Args: |
| 153 | input_api: input related apis. |
| 154 | output_api: output related apis. |
| 155 | json_url: url to download json style status. |
| 156 | """ |
| 157 | tree_status_results = input_api.canned_checks.CheckTreeIsOpen( |
| 158 | input_api, output_api, json_url=json_url) |
| 159 | if not tree_status_results: |
| 160 | # Check for caution state only if tree is not closed. |
| 161 | connection = input_api.urllib2.urlopen(json_url) |
| 162 | status = input_api.json.loads(connection.read()) |
| 163 | connection.close() |
rmistry@google.com | f6c5f75 | 2013-03-29 17:26:00 +0000 | [diff] [blame] | 164 | if ('caution' in status['message'].lower() and |
| 165 | os.isatty(sys.stdout.fileno())): |
| 166 | # Display a prompt only if we are in an interactive shell. Without this |
| 167 | # check the commit queue behaves incorrectly because it considers |
| 168 | # prompts to be failures. |
rmistry@google.com | c299344 | 2013-01-23 14:35:58 +0000 | [diff] [blame] | 169 | short_text = 'Tree state is: ' + status['general_state'] |
| 170 | long_text = status['message'] + '\n' + json_url |
| 171 | tree_status_results.append( |
| 172 | output_api.PresubmitPromptWarning( |
| 173 | message=short_text, long_text=long_text)) |
rmistry@google.com | 547012d | 2013-04-12 19:45:46 +0000 | [diff] [blame] | 174 | else: |
| 175 | # Tree status is closed. Put in message about contacting sheriff. |
| 176 | connection = input_api.urllib2.urlopen( |
| 177 | SKIA_TREE_STATUS_URL + '/current-sheriff') |
| 178 | sheriff_details = input_api.json.loads(connection.read()) |
| 179 | if sheriff_details: |
| 180 | tree_status_results[0]._message += ( |
| 181 | '\n\nPlease contact the current Skia sheriff (%s) if you are trying ' |
| 182 | 'to submit a build fix\nand do not know how to submit because the ' |
| 183 | 'tree is closed') % sheriff_details['username'] |
rmistry@google.com | c299344 | 2013-01-23 14:35:58 +0000 | [diff] [blame] | 184 | return tree_status_results |
| 185 | |
| 186 | |
commit-bot@chromium.org | 745e08c | 2014-02-03 14:18:32 +0000 | [diff] [blame] | 187 | def _CheckOwnerIsInAuthorsFile(input_api, output_api): |
| 188 | results = [] |
| 189 | issue = input_api.change.issue |
| 190 | if issue and input_api.rietveld: |
rmistry | 83fab47 | 2014-07-18 05:25:56 -0700 | [diff] [blame] | 191 | issue_properties = input_api.rietveld.get_issue_properties( |
commit-bot@chromium.org | 745e08c | 2014-02-03 14:18:32 +0000 | [diff] [blame] | 192 | issue=int(issue), messages=False) |
| 193 | owner_email = issue_properties['owner_email'] |
| 194 | |
| 195 | try: |
| 196 | authors_content = '' |
| 197 | for line in open(AUTHORS_FILE_NAME): |
| 198 | if not line.startswith('#'): |
| 199 | authors_content += line |
| 200 | email_fnmatches = re.findall('<(.*)>', authors_content) |
| 201 | for email_fnmatch in email_fnmatches: |
| 202 | if fnmatch.fnmatch(owner_email, email_fnmatch): |
| 203 | # Found a match, the user is in the AUTHORS file break out of the loop |
| 204 | break |
| 205 | else: |
| 206 | # TODO(rmistry): Remove the below CLA messaging once a CLA checker has |
| 207 | # been added to the CQ. |
| 208 | results.append( |
| 209 | output_api.PresubmitError( |
| 210 | 'The email %s is not in Skia\'s AUTHORS file.\n' |
| 211 | 'Issue owner, this CL must include an addition to the Skia AUTHORS ' |
| 212 | 'file.\n' |
| 213 | 'Googler reviewers, please check that the AUTHORS entry ' |
| 214 | 'corresponds to an email address in http://goto/cla-signers. If it ' |
| 215 | 'does not then ask the issue owner to sign the CLA at ' |
| 216 | 'https://developers.google.com/open-source/cla/individual ' |
| 217 | '(individual) or ' |
| 218 | 'https://developers.google.com/open-source/cla/corporate ' |
| 219 | '(corporate).' |
rmistry | 83fab47 | 2014-07-18 05:25:56 -0700 | [diff] [blame] | 220 | % owner_email)) |
commit-bot@chromium.org | 745e08c | 2014-02-03 14:18:32 +0000 | [diff] [blame] | 221 | except IOError: |
| 222 | # Do not fail if authors file cannot be found. |
| 223 | traceback.print_exc() |
| 224 | input_api.logging.error('AUTHORS file not found!') |
| 225 | |
| 226 | return results |
| 227 | |
| 228 | |
rmistry@google.com | fb4a68d | 2013-08-12 14:51:20 +0000 | [diff] [blame] | 229 | def _CheckLGTMsForPublicAPI(input_api, output_api): |
| 230 | """Check LGTMs for public API changes. |
| 231 | |
| 232 | For public API files make sure there is an LGTM from the list of owners in |
| 233 | PUBLIC_API_OWNERS. |
| 234 | """ |
| 235 | results = [] |
| 236 | requires_owner_check = False |
rmistry | 9407ece | 2014-08-26 14:00:54 -0700 | [diff] [blame] | 237 | for affected_file in input_api.AffectedFiles(): |
| 238 | affected_file_path = affected_file.LocalPath() |
rmistry@google.com | fb4a68d | 2013-08-12 14:51:20 +0000 | [diff] [blame] | 239 | file_path, file_ext = os.path.splitext(affected_file_path) |
rmistry | 9407ece | 2014-08-26 14:00:54 -0700 | [diff] [blame] | 240 | # We only care about files that end in .h and are under the top-level |
| 241 | # include dir. |
| 242 | if file_ext == '.h' and 'include' == file_path.split(os.path.sep)[0]: |
rmistry@google.com | fb4a68d | 2013-08-12 14:51:20 +0000 | [diff] [blame] | 243 | requires_owner_check = True |
| 244 | |
| 245 | if not requires_owner_check: |
| 246 | return results |
| 247 | |
| 248 | lgtm_from_owner = False |
| 249 | issue = input_api.change.issue |
| 250 | if issue and input_api.rietveld: |
| 251 | issue_properties = input_api.rietveld.get_issue_properties( |
| 252 | issue=int(issue), messages=True) |
commit-bot@chromium.org | cfdc596 | 2014-01-31 17:33:04 +0000 | [diff] [blame] | 253 | if re.match(REVERT_CL_SUBJECT_PREFIX, issue_properties['subject'], re.I): |
| 254 | # It is a revert CL, ignore the public api owners check. |
| 255 | return results |
rmistry | f2d83ca | 2014-08-26 10:30:29 -0700 | [diff] [blame] | 256 | |
| 257 | match = re.search(r'^TBR=(.*)$', issue_properties['description'], re.M) |
| 258 | if match: |
| 259 | tbr_entries = match.group(1).strip().split(',') |
| 260 | for owner in PUBLIC_API_OWNERS: |
| 261 | if owner in tbr_entries or owner.split('@')[0] in tbr_entries: |
| 262 | # If an owner is specified in the TBR= line then ignore the public |
| 263 | # api owners check. |
| 264 | return results |
| 265 | |
rmistry@google.com | fb4a68d | 2013-08-12 14:51:20 +0000 | [diff] [blame] | 266 | if issue_properties['owner_email'] in PUBLIC_API_OWNERS: |
| 267 | # An owner created the CL that is an automatic LGTM. |
| 268 | lgtm_from_owner = True |
| 269 | |
| 270 | messages = issue_properties.get('messages') |
| 271 | if messages: |
| 272 | for message in messages: |
| 273 | if (message['sender'] in PUBLIC_API_OWNERS and |
| 274 | 'lgtm' in message['text'].lower()): |
| 275 | # Found an lgtm in a message from an owner. |
| 276 | lgtm_from_owner = True |
Eric Boren | bb0ef0a | 2014-06-25 11:13:27 -0400 | [diff] [blame] | 277 | break |
commit-bot@chromium.org | cfdc596 | 2014-01-31 17:33:04 +0000 | [diff] [blame] | 278 | |
rmistry@google.com | fb4a68d | 2013-08-12 14:51:20 +0000 | [diff] [blame] | 279 | if not lgtm_from_owner: |
| 280 | results.append( |
| 281 | output_api.PresubmitError( |
| 282 | 'Since the CL is editing public API, you must have an LGTM from ' |
| 283 | 'one of: %s' % str(PUBLIC_API_OWNERS))) |
| 284 | return results |
| 285 | |
| 286 | |
rmistry | d223fb2 | 2015-02-26 10:16:13 -0800 | [diff] [blame] | 287 | def PostUploadHook(cl, change, output_api): |
| 288 | """git cl upload will call this hook after the issue is created/modified. |
| 289 | |
| 290 | This hook does the following: |
| 291 | * Adds a link to preview docs changes if there are any docs changes in the CL. |
| 292 | * Adds 'NOTRY=true' if the CL contains only docs changes. |
rmistry | 896f393 | 2015-02-26 11:52:05 -0800 | [diff] [blame] | 293 | * Adds 'NOTREECHECKS=true' for non master branch changes since they do not |
| 294 | need to be gated on the master branch's tree. |
| 295 | * Adds 'NOTRY=true' for non master branch changes since trybots do not yet |
| 296 | work on them. |
rmistry | d223fb2 | 2015-02-26 10:16:13 -0800 | [diff] [blame] | 297 | """ |
| 298 | |
| 299 | results = [] |
| 300 | atleast_one_docs_change = False |
| 301 | all_docs_changes = True |
| 302 | for affected_file in change.AffectedFiles(): |
| 303 | affected_file_path = affected_file.LocalPath() |
| 304 | file_path, _ = os.path.splitext(affected_file_path) |
| 305 | if 'site' == file_path.split(os.path.sep)[0]: |
| 306 | atleast_one_docs_change = True |
| 307 | else: |
| 308 | all_docs_changes = False |
| 309 | if atleast_one_docs_change and not all_docs_changes: |
| 310 | break |
| 311 | |
| 312 | issue = cl.issue |
| 313 | rietveld_obj = cl.RpcServer() |
| 314 | if issue and rietveld_obj: |
| 315 | original_description = rietveld_obj.get_description(issue) |
| 316 | new_description = original_description |
| 317 | |
| 318 | # If the change includes only doc changes then add NOTRY=true in the |
| 319 | # CL's description if it does not exist yet. |
| 320 | if all_docs_changes and not re.search( |
rmistry | 896f393 | 2015-02-26 11:52:05 -0800 | [diff] [blame] | 321 | r'^NOTRY=true$', new_description, re.M | re.I): |
rmistry | d223fb2 | 2015-02-26 10:16:13 -0800 | [diff] [blame] | 322 | new_description += '\nNOTRY=true' |
| 323 | results.append( |
| 324 | output_api.PresubmitNotifyResult( |
| 325 | 'This change has only doc changes. Automatically added ' |
| 326 | '\'NOTRY=true\' to the CL\'s description')) |
| 327 | |
| 328 | # If there is atleast one docs change then add preview link in the CL's |
| 329 | # description if it does not already exist there. |
| 330 | if atleast_one_docs_change and not re.search( |
rmistry | 896f393 | 2015-02-26 11:52:05 -0800 | [diff] [blame] | 331 | r'^DOCS_PREVIEW=.*', new_description, re.M | re.I): |
rmistry | d223fb2 | 2015-02-26 10:16:13 -0800 | [diff] [blame] | 332 | # Automatically add a link to where the docs can be previewed. |
| 333 | new_description += '\nDOCS_PREVIEW= %s%s' % (DOCS_PREVIEW_URL, issue) |
| 334 | results.append( |
| 335 | output_api.PresubmitNotifyResult( |
| 336 | 'Automatically added a link to preview the docs changes to the ' |
| 337 | 'CL\'s description')) |
| 338 | |
rmistry | 896f393 | 2015-02-26 11:52:05 -0800 | [diff] [blame] | 339 | # If the target ref is not master then add NOTREECHECKS=true and NOTRY=true |
| 340 | # to the CL's description if it does not already exist there. |
| 341 | target_ref = rietveld_obj.get_issue_properties(issue, False).get( |
| 342 | 'target_ref', '') |
| 343 | if target_ref != 'refs/heads/master': |
| 344 | if not re.search( |
| 345 | r'^NOTREECHECKS=true$', new_description, re.M | re.I): |
| 346 | new_description += "\nNOTREECHECKS=true" |
| 347 | results.append( |
| 348 | output_api.PresubmitNotifyResult( |
| 349 | 'Branch changes do not need to rely on the master branch\'s ' |
| 350 | 'tree status. Automatically added \'NOTREECHECKS=true\' to the ' |
| 351 | 'CL\'s description')) |
| 352 | if not re.search( |
| 353 | r'^NOTRY=true$', new_description, re.M | re.I): |
| 354 | new_description += "\nNOTRY=true" |
| 355 | results.append( |
| 356 | output_api.PresubmitNotifyResult( |
| 357 | 'Trybots do not yet work for non-master branches. ' |
| 358 | 'Automatically added \'NOTRY=true\' to the CL\'s description')) |
| 359 | |
| 360 | |
rmistry | d223fb2 | 2015-02-26 10:16:13 -0800 | [diff] [blame] | 361 | # If the description has changed update it. |
| 362 | if new_description != original_description: |
| 363 | rietveld_obj.update_description(issue, new_description) |
| 364 | |
| 365 | return results |
| 366 | |
| 367 | |
rmistry@google.com | 8e3ff8c | 2013-01-17 12:55:34 +0000 | [diff] [blame] | 368 | def CheckChangeOnCommit(input_api, output_api): |
| 369 | """Presubmit checks for the change on commit. |
| 370 | |
| 371 | The following are the presubmit checks: |
rmistry@google.com | 6be0b4c | 2013-01-17 14:50:59 +0000 | [diff] [blame] | 372 | * Check change has one and only one EOL. |
rmistry@google.com | c299344 | 2013-01-23 14:35:58 +0000 | [diff] [blame] | 373 | * Ensures that the Skia tree is open in |
| 374 | http://skia-tree-status.appspot.com/. Shows a warning if it is in 'Caution' |
| 375 | state and an error if it is in 'Closed' state. |
rmistry@google.com | 8e3ff8c | 2013-01-17 12:55:34 +0000 | [diff] [blame] | 376 | """ |
| 377 | results = [] |
rmistry@google.com | 6be0b4c | 2013-01-17 14:50:59 +0000 | [diff] [blame] | 378 | results.extend(_CommonChecks(input_api, output_api)) |
rmistry@google.com | 8e3ff8c | 2013-01-17 12:55:34 +0000 | [diff] [blame] | 379 | results.extend( |
rmistry@google.com | c299344 | 2013-01-23 14:35:58 +0000 | [diff] [blame] | 380 | _CheckTreeStatus(input_api, output_api, json_url=( |
rmistry@google.com | 547012d | 2013-04-12 19:45:46 +0000 | [diff] [blame] | 381 | SKIA_TREE_STATUS_URL + '/banner-status?format=json'))) |
rmistry@google.com | fb4a68d | 2013-08-12 14:51:20 +0000 | [diff] [blame] | 382 | results.extend(_CheckLGTMsForPublicAPI(input_api, output_api)) |
commit-bot@chromium.org | 745e08c | 2014-02-03 14:18:32 +0000 | [diff] [blame] | 383 | results.extend(_CheckOwnerIsInAuthorsFile(input_api, output_api)) |
rmistry@google.com | 8e3ff8c | 2013-01-17 12:55:34 +0000 | [diff] [blame] | 384 | return results |