blob: 013dbfde158aebfe95159b934d48f279ca75aef1 [file] [log] [blame]
borenetdb182c72016-09-30 12:53:12 -07001// Copyright 2016 The Chromium Authors. All rights reserved.
2// Use of this source code is governed by a BSD-style license that can be
3// found in the LICENSE file.
4
5package main
6
7/*
8 Generate the tasks.json file.
9*/
10
11import (
borenetdb182c72016-09-30 12:53:12 -070012 "encoding/json"
Eric Boren27225492017-02-01 15:56:55 -050013 "flag"
borenetdb182c72016-09-30 12:53:12 -070014 "fmt"
Eric Boren27225492017-02-01 15:56:55 -050015 "io/ioutil"
borenetdb182c72016-09-30 12:53:12 -070016 "os"
17 "path"
Eric Boren7e3a3642017-06-14 15:25:31 -040018 "path/filepath"
Eric Boren27225492017-02-01 15:56:55 -050019 "regexp"
Eric Boren7e3a3642017-06-14 15:25:31 -040020 "runtime"
borenetdb182c72016-09-30 12:53:12 -070021 "sort"
22 "strings"
Eric Boren4b254b92016-11-08 12:55:32 -050023 "time"
borenetdb182c72016-09-30 12:53:12 -070024
25 "github.com/skia-dev/glog"
Eric Boren7e3a3642017-06-14 15:25:31 -040026 "go.skia.org/infra/go/sklog"
borenetdb182c72016-09-30 12:53:12 -070027 "go.skia.org/infra/go/util"
28 "go.skia.org/infra/task_scheduler/go/specs"
29)
30
31const (
Kevin Lubick07072942017-05-11 13:35:23 -040032 BUNDLE_RECIPES_NAME = "Housekeeper-PerCommit-BundleRecipes"
33 ISOLATE_SKIMAGE_NAME = "Housekeeper-PerCommit-IsolateSkImage"
34 ISOLATE_SKP_NAME = "Housekeeper-PerCommit-IsolateSKP"
35 ISOLATE_SVG_NAME = "Housekeeper-PerCommit-IsolateSVG"
Eric Boren8b3f9e62017-04-04 09:06:16 -040036
Eric Borenbb198fb2017-06-28 11:45:54 -040037 DEFAULT_OS_DEBIAN = "Debian-9.0"
38 DEFAULT_OS_UBUNTU = "Ubuntu-14.04"
borenetdb182c72016-09-30 12:53:12 -070039
borenetdb182c72016-09-30 12:53:12 -070040 // Name prefix for upload jobs.
41 PREFIX_UPLOAD = "Upload"
42)
43
44var (
45 // "Constants"
46
Eric Boren27225492017-02-01 15:56:55 -050047 // Top-level list of all jobs to run at each commit; loaded from
48 // jobs.json.
49 JOBS []string
50
Eric Boren27225492017-02-01 15:56:55 -050051 // General configuration information.
52 CONFIG struct {
Eric Boren965861b2017-02-06 15:38:41 -050053 GsBucketGm string `json:"gs_bucket_gm"`
54 GsBucketNano string `json:"gs_bucket_nano"`
55 NoUpload []string `json:"no_upload"`
56 Pool string `json:"pool"`
borenetdb182c72016-09-30 12:53:12 -070057 }
58
Ben Wagner3d2a2f72017-06-13 17:01:16 -040059 // alternateSwarmDimensions can be set in an init function to override the default swarming bot
60 // dimensions for the given task.
61 alternateSwarmDimensions func(parts map[string]string) []string
62
borenetdb182c72016-09-30 12:53:12 -070063 // Defines the structure of job names.
64 jobNameSchema *JobNameSchema
Eric Boren27225492017-02-01 15:56:55 -050065
Eric Borenf4a5fc72017-06-06 08:27:09 -040066 // Git 2.13.
67 cipdGit1 = &specs.CipdPackage{
68 Name: fmt.Sprintf("infra/git/${platform}"),
69 Path: "git",
70 Version: fmt.Sprintf("version:2.13.0.chromium9"),
71 }
72 cipdGit2 = &specs.CipdPackage{
73 Name: fmt.Sprintf("infra/tools/git/${platform}"),
74 Path: "git",
75 Version: fmt.Sprintf("git_revision:a78b5f3658c0578a017db48df97d20ac09822bcd"),
76 }
77
Eric Boren27225492017-02-01 15:56:55 -050078 // Flags.
Eric Boren1f8be682017-02-07 09:16:30 -050079 builderNameSchemaFile = flag.String("builder_name_schema", "", "Path to the builder_name_schema.json file. If not specified, uses infra/bots/recipe_modules/builder_name_schema/builder_name_schema.json from this repo.")
80 assetsDir = flag.String("assets_dir", "", "Directory containing assets.")
81 cfgFile = flag.String("cfg_file", "", "JSON file containing general configuration information.")
Eric Boren1f8be682017-02-07 09:16:30 -050082 jobsFile = flag.String("jobs", "", "JSON file containing jobs to run.")
borenetdb182c72016-09-30 12:53:12 -070083)
84
Eric Boren27225492017-02-01 15:56:55 -050085// linuxGceDimensions are the Swarming dimensions for Linux GCE
86// instances.
87func linuxGceDimensions() []string {
88 return []string{
89 "cpu:x86-64-avx2",
90 "gpu:none",
Eric Borenbb198fb2017-06-28 11:45:54 -040091 fmt.Sprintf("os:%s", DEFAULT_OS_DEBIAN),
Eric Boren27225492017-02-01 15:56:55 -050092 fmt.Sprintf("pool:%s", CONFIG.Pool),
93 }
94}
95
borenetdb182c72016-09-30 12:53:12 -070096// deriveCompileTaskName returns the name of a compile task based on the given
97// job name.
98func deriveCompileTaskName(jobName string, parts map[string]string) string {
99 if parts["role"] == "Housekeeper" {
Eric Borenbb198fb2017-06-28 11:45:54 -0400100 return "Build-Debian9-GCC-x86_64-Release-Shared"
borenetdb182c72016-09-30 12:53:12 -0700101 } else if parts["role"] == "Test" || parts["role"] == "Perf" {
102 task_os := parts["os"]
Ben Wagner988d15e2017-04-27 13:08:50 -0400103 ec := []string{}
104 if val := parts["extra_config"]; val != "" {
105 ec = strings.Split(val, "_")
Stephan Altmuellerddad85b2017-05-19 13:08:19 -0400106 ignore := []string{"Skpbench", "AbandonGpuContext", "PreAbandonGpuContext", "Valgrind", "ReleaseAndAbandonGpuContext"}
Ben Wagner988d15e2017-04-27 13:08:50 -0400107 keep := make([]string, 0, len(ec))
108 for _, part := range ec {
109 if !util.In(part, ignore) {
110 keep = append(keep, part)
111 }
112 }
113 ec = keep
Eric Boren6ec17e32017-04-26 14:25:29 -0400114 }
borenetdb182c72016-09-30 12:53:12 -0700115 if task_os == "Android" {
Ben Wagner988d15e2017-04-27 13:08:50 -0400116 if !util.In("Android", ec) {
117 ec = append([]string{"Android"}, ec...)
borenetdb182c72016-09-30 12:53:12 -0700118 }
Eric Borenbb198fb2017-06-28 11:45:54 -0400119 task_os = "Debian9"
Kevin Lubickdcd2a902017-03-08 14:01:01 -0500120 } else if task_os == "Chromecast" {
Eric Borenbb198fb2017-06-28 11:45:54 -0400121 task_os = "Debian9"
Ben Wagner988d15e2017-04-27 13:08:50 -0400122 ec = append([]string{"Chromecast"}, ec...)
Kevin Lubickcb6f3982017-04-07 10:04:08 -0400123 } else if strings.Contains(task_os, "ChromeOS") {
Ben Wagner988d15e2017-04-27 13:08:50 -0400124 ec = append([]string{"Chromebook", "ARM", "GLES"}, ec...)
Eric Borenbb198fb2017-06-28 11:45:54 -0400125 task_os = "Debian9"
borenetdb182c72016-09-30 12:53:12 -0700126 } else if task_os == "iOS" {
Ben Wagner988d15e2017-04-27 13:08:50 -0400127 ec = append([]string{task_os}, ec...)
borenetdb182c72016-09-30 12:53:12 -0700128 task_os = "Mac"
129 } else if strings.Contains(task_os, "Win") {
130 task_os = "Win"
Eric Borenbb198fb2017-06-28 11:45:54 -0400131 } else if strings.Contains(task_os, "Ubuntu") || strings.Contains(task_os, "Debian") {
132 task_os = "Debian9"
borenetdb182c72016-09-30 12:53:12 -0700133 }
Eric Boren50831302016-11-18 13:10:51 -0500134 jobNameMap := map[string]string{
borenetdb182c72016-09-30 12:53:12 -0700135 "role": "Build",
136 "os": task_os,
137 "compiler": parts["compiler"],
138 "target_arch": parts["arch"],
139 "configuration": parts["configuration"],
Eric Boren50831302016-11-18 13:10:51 -0500140 }
Ben Wagner988d15e2017-04-27 13:08:50 -0400141 if len(ec) > 0 {
142 jobNameMap["extra_config"] = strings.Join(ec, "_")
Eric Boren50831302016-11-18 13:10:51 -0500143 }
144 name, err := jobNameSchema.MakeJobName(jobNameMap)
borenetdb182c72016-09-30 12:53:12 -0700145 if err != nil {
146 glog.Fatal(err)
147 }
148 return name
149 } else {
150 return jobName
151 }
152}
153
154// swarmDimensions generates swarming bot dimensions for the given task.
155func swarmDimensions(parts map[string]string) []string {
Ben Wagner3d2a2f72017-06-13 17:01:16 -0400156 if alternateSwarmDimensions != nil {
157 return alternateSwarmDimensions(parts)
158 }
159 return defaultSwarmDimensions(parts)
160}
161
162// defaultSwarmDimensions generates default swarming bot dimensions for the given task.
163func defaultSwarmDimensions(parts map[string]string) []string {
borenetdb182c72016-09-30 12:53:12 -0700164 d := map[string]string{
Eric Boren27225492017-02-01 15:56:55 -0500165 "pool": CONFIG.Pool,
borenetdb182c72016-09-30 12:53:12 -0700166 }
167 if os, ok := parts["os"]; ok {
Ben Wagner3d2a2f72017-06-13 17:01:16 -0400168 d["os"], ok = map[string]string{
Kevin Lubick291547d2017-03-21 09:25:34 -0400169 "Android": "Android",
170 "Chromecast": "Android",
Kevin Lubickcb6f3982017-04-07 10:04:08 -0400171 "ChromeOS": "ChromeOS",
Eric Borenbb198fb2017-06-28 11:45:54 -0400172 "Debian9": DEFAULT_OS_DEBIAN,
Kevin Lubick291547d2017-03-21 09:25:34 -0400173 "Mac": "Mac-10.11",
Eric Borenbb198fb2017-06-28 11:45:54 -0400174 "Ubuntu14": DEFAULT_OS_UBUNTU,
Kevin Lubick291547d2017-03-21 09:25:34 -0400175 "Ubuntu16": "Ubuntu-16.10",
Eric Boren810c2b62017-07-11 08:11:15 -0400176 "Ubuntu17": "Ubuntu-17.04",
Kevin Lubick291547d2017-03-21 09:25:34 -0400177 "Win": "Windows-2008ServerR2-SP1",
Ben Wagner40226b42017-05-02 13:13:13 -0400178 "Win10": "Windows-10-15063",
Kevin Lubick291547d2017-03-21 09:25:34 -0400179 "Win2k8": "Windows-2008ServerR2-SP1",
Ben Wagner56738d82017-04-18 15:38:15 -0400180 "Win7": "Windows-7-SP1",
Kevin Lubick291547d2017-03-21 09:25:34 -0400181 "Win8": "Windows-8.1-SP0",
Stephan Altmuellerddad85b2017-05-19 13:08:19 -0400182 "iOS": "iOS-10.3.1",
Eric Boren54ff2fc2016-12-02 12:09:10 -0500183 }[os]
Ben Wagner3d2a2f72017-06-13 17:01:16 -0400184 if !ok {
185 glog.Fatalf("Entry %q not found in OS mapping.", os)
186 }
Ben Wagner73557372016-12-29 16:27:03 -0500187 // Chrome Golo has a different Windows image.
188 if parts["model"] == "Golo" && os == "Win10" {
189 d["os"] = "Windows-10-10586"
Ben Wagner17f811b2016-12-22 08:40:14 -0500190 }
borenetdb182c72016-09-30 12:53:12 -0700191 } else {
Eric Borenbb198fb2017-06-28 11:45:54 -0400192 d["os"] = DEFAULT_OS_DEBIAN
borenetdb182c72016-09-30 12:53:12 -0700193 }
borenetdb182c72016-09-30 12:53:12 -0700194 if parts["role"] == "Test" || parts["role"] == "Perf" {
Kevin Lubick291547d2017-03-21 09:25:34 -0400195 if strings.Contains(parts["os"], "Android") || strings.Contains(parts["os"], "Chromecast") {
borenetdb182c72016-09-30 12:53:12 -0700196 // For Android, the device type is a better dimension
197 // than CPU or GPU.
Ben Wagner36682782017-06-14 10:01:45 -0400198 deviceInfo, ok := map[string][]string{
Ben Wagner3d2a2f72017-06-13 17:01:16 -0400199 "AndroidOne": {"sprout", "MOB30Q"},
200 "Chorizo": {"chorizo", "1.24_82923"},
201 "Ci20": {"ci20", "NRD90M"},
202 "GalaxyJ5": {"j5xnlte", "MMB29M"},
203 "GalaxyS6": {"zerofltetmo", "MMB29K"},
204 "GalaxyS7_G930A": {"heroqlteatt", "NRD90M_G930AUCS4BQC2"},
205 "GalaxyS7_G930FD": {"herolte", "NRD90M_G930FXXU1DQAS"},
206 "GalaxyTab3": {"goyawifi", "JDQ39"},
207 "MotoG4": {"athene", "NPJ25.93-14"},
208 "NVIDIA_Shield": {"foster", "NRD90M"},
209 "Nexus10": {"manta", "LMY49J"},
210 "Nexus5": {"hammerhead", "M4B30Z"},
211 "Nexus6": {"shamu", "M"},
212 "Nexus6p": {"angler", "OPP1.170223.012"},
213 "Nexus7": {"grouper", "LMY47V"},
214 "Nexus7v2": {"flo", "M"},
215 "NexusPlayer": {"fugu", "OPP2.170420.017"},
216 "Pixel": {"sailfish", "NMF26Q"},
217 "PixelC": {"dragon", "N2G47D"},
Greg Danielc34aeb72017-06-14 11:09:19 -0400218 "PixelXL": {"marlin", "OPP3.170518.006"},
Ben Wagner36682782017-06-14 10:01:45 -0400219 }[parts["model"]]
Eric Boren27225492017-02-01 15:56:55 -0500220 if !ok {
Ben Wagner36682782017-06-14 10:01:45 -0400221 glog.Fatalf("Entry %q not found in Android mapping.", parts["model"])
Eric Boren27225492017-02-01 15:56:55 -0500222 }
Eric Boren4b254b92016-11-08 12:55:32 -0500223 d["device_type"] = deviceInfo[0]
224 d["device_os"] = deviceInfo[1]
borenetdb182c72016-09-30 12:53:12 -0700225 } else if strings.Contains(parts["os"], "iOS") {
Ben Wagner3d2a2f72017-06-13 17:01:16 -0400226 device, ok := map[string]string{
Eric Boren792079cf2016-11-09 14:03:20 -0500227 "iPadMini4": "iPad5,1",
Stephan Altmueller63e843d2017-04-25 11:38:38 -0400228 "iPhone6": "iPhone7,2",
229 "iPhone7": "iPhone9,1",
230 "iPadPro": "iPad6,3",
borenetdb182c72016-09-30 12:53:12 -0700231 }[parts["model"]]
Ben Wagner3d2a2f72017-06-13 17:01:16 -0400232 if !ok {
233 glog.Fatalf("Entry %q not found in iOS mapping.", parts["model"])
234 }
235 d["device"] = device
borenetdb182c72016-09-30 12:53:12 -0700236 } else if parts["cpu_or_gpu"] == "CPU" {
237 d["gpu"] = "none"
Ben Wagner3d2a2f72017-06-13 17:01:16 -0400238 cpu, ok := map[string]string{
borenetdb182c72016-09-30 12:53:12 -0700239 "AVX": "x86-64",
240 "AVX2": "x86-64-avx2",
241 "SSE4": "x86-64",
242 }[parts["cpu_or_gpu_value"]]
Ben Wagner3d2a2f72017-06-13 17:01:16 -0400243 if !ok {
244 glog.Fatalf("Entry %q not found in CPU mapping.", parts["cpu_or_gpu_value"])
245 }
246 d["cpu"] = cpu
borenetdb182c72016-09-30 12:53:12 -0700247 if strings.Contains(parts["os"], "Win") && parts["cpu_or_gpu_value"] == "AVX2" {
248 // AVX2 is not correctly detected on Windows. Fall back on other
249 // dimensions to ensure that we correctly target machines which we know
250 // have AVX2 support.
Eric Boren085bf7c2017-04-06 17:32:44 +0000251 d["cpu"] = "x86-64"
Ben Wagner56738d82017-04-18 15:38:15 -0400252 if parts["model"] != "GCE" {
253 glog.Fatalf("Please double-check that %q supports AVX2 and update this assertion.", parts["model"])
254 }
borenetdb182c72016-09-30 12:53:12 -0700255 }
256 } else {
Ben Wagner1d060782017-06-14 10:34:18 -0400257 if strings.Contains(parts["os"], "Win") {
258 gpu, ok := map[string]string{
259 "AMDHD7770": "1002:683d-22.19.165.512",
260 "GT610": "10de:104a-21.21.13.7619",
261 "GTX1070": "10de:1ba1-22.21.13.8205",
262 "GTX660": "10de:11c0-22.21.13.8205",
263 "GTX960": "10de:1401-22.21.13.8205",
264 "IntelHD530": "8086:1912-21.20.16.4590",
Ben Wagnerc16d0d52017-06-23 14:42:30 -0400265 "IntelHD4400": "8086:0a16-20.19.15.4624",
266 "IntelHD4600": "8086:0412-20.19.15.4624",
Ben Wagner1d060782017-06-14 10:34:18 -0400267 "IntelIris540": "8086:1926-21.20.16.4590",
Ben Wagnerc16d0d52017-06-23 14:42:30 -0400268 "IntelIris6100": "8086:162b-20.19.15.4624",
Ben Wagner1d060782017-06-14 10:34:18 -0400269 "RadeonR9M470X": "1002:6646-22.19.165.512",
270 }[parts["cpu_or_gpu_value"]]
271 if !ok {
272 glog.Fatalf("Entry %q not found in Win GPU mapping.", parts["cpu_or_gpu_value"])
273 }
274 d["gpu"] = gpu
Ben Wagner08435892017-02-18 23:28:26 -0500275
Ben Wagner4b1df022017-06-15 12:28:04 -0400276 // Specify cpu dimension for NUCs and ShuttleCs. We temporarily have two
277 // types of machines with a GTX960.
278 cpu, ok := map[string]string{
279 "NUC6i7KYK": "x86-64-i7-6770HQ",
280 "ShuttleC": "x86-64-i7-6700K",
Ben Wagner1d060782017-06-14 10:34:18 -0400281 }[parts["model"]]
282 if ok {
Ben Wagner4b1df022017-06-15 12:28:04 -0400283 d["cpu"] = cpu
Ben Wagner1d060782017-06-14 10:34:18 -0400284 }
Eric Borenbb198fb2017-06-28 11:45:54 -0400285 } else if strings.Contains(parts["os"], "Ubuntu") || strings.Contains(parts["os"], "Debian") {
Ben Wagner1d060782017-06-14 10:34:18 -0400286 gpu, ok := map[string]string{
Eric Boren810c2b62017-07-11 08:11:15 -0400287 "GT610": "10de:104a-340.102",
Eric Borenfb2050f2017-06-29 14:40:11 -0400288 "GTX550Ti": "10de:1244-375.66",
289 "GTX660": "10de:11c0-375.66",
290 "GTX960": "10de:1401-375.66",
Ben Wagner1d060782017-06-14 10:34:18 -0400291 // Intel drivers come from CIPD, so no need to specify the version here.
292 "IntelBayTrail": "8086:0f31",
293 "IntelHD2000": "8086:0102",
294 "IntelHD405": "8086:22b1",
295 "IntelIris540": "8086:1926",
296 }[parts["cpu_or_gpu_value"]]
297 if !ok {
298 glog.Fatalf("Entry %q not found in Ubuntu GPU mapping.", parts["cpu_or_gpu_value"])
299 }
300 d["gpu"] = gpu
301 } else if strings.Contains(parts["os"], "Mac") {
302 gpu, ok := map[string]string{
303 // TODO(benjaminwagner): GPU name doesn't match device ID.
304 "IntelHD4000": "8086:0a2e",
305 }[parts["cpu_or_gpu_value"]]
306 if !ok {
307 glog.Fatalf("Entry %q not found in Mac GPU mapping.", parts["cpu_or_gpu_value"])
308 }
309 d["gpu"] = gpu
310 } else if strings.Contains(parts["os"], "ChromeOS") {
311 gpu, ok := map[string]string{
312 "MaliT604": "MaliT604",
313 "MaliT764": "MaliT764",
314 "MaliT860": "MaliT860",
315 "TegraK1": "TegraK1",
316 }[parts["cpu_or_gpu_value"]]
317 if !ok {
318 glog.Fatalf("Entry %q not found in ChromeOS GPU mapping.", parts["cpu_or_gpu_value"])
319 }
320 d["gpu"] = gpu
321 } else {
322 glog.Fatalf("Unknown GPU mapping for OS %q.", parts["os"])
Ben Wagner08435892017-02-18 23:28:26 -0500323 }
borenetdb182c72016-09-30 12:53:12 -0700324 }
325 } else {
326 d["gpu"] = "none"
Eric Borenbb198fb2017-06-28 11:45:54 -0400327 if d["os"] == DEFAULT_OS_DEBIAN {
Kevin Lubick4610a9b2017-03-22 15:54:54 -0400328 return linuxGceDimensions()
329 }
borenetdb182c72016-09-30 12:53:12 -0700330 }
Kevin Lubick4610a9b2017-03-22 15:54:54 -0400331
borenetdb182c72016-09-30 12:53:12 -0700332 rv := make([]string, 0, len(d))
333 for k, v := range d {
334 rv = append(rv, fmt.Sprintf("%s:%s", k, v))
335 }
336 sort.Strings(rv)
337 return rv
338}
339
Eric Boren7e3a3642017-06-14 15:25:31 -0400340// relpath returns the relative path to the given file from the config file.
341func relpath(f string) string {
342 _, filename, _, _ := runtime.Caller(0)
343 dir := path.Dir(filename)
344 rel := dir
345 if *cfgFile != "" {
346 rel = path.Dir(*cfgFile)
347 }
348 rv, err := filepath.Rel(rel, path.Join(dir, f))
349 if err != nil {
350 sklog.Fatal(err)
351 }
352 return rv
353}
354
Eric Boren8b3f9e62017-04-04 09:06:16 -0400355// bundleRecipes generates the task to bundle and isolate the recipes.
356func bundleRecipes(b *specs.TasksCfgBuilder) string {
357 b.MustAddTask(BUNDLE_RECIPES_NAME, &specs.TaskSpec{
Eric Borenf4a5fc72017-06-06 08:27:09 -0400358 CipdPackages: []*specs.CipdPackage{cipdGit1, cipdGit2},
Eric Boren8b3f9e62017-04-04 09:06:16 -0400359 Dimensions: linuxGceDimensions(),
360 ExtraArgs: []string{
361 "--workdir", "../../..", "bundle_recipes",
Eric Boren8b3f9e62017-04-04 09:06:16 -0400362 fmt.Sprintf("buildername=%s", BUNDLE_RECIPES_NAME),
Eric Boren8b3f9e62017-04-04 09:06:16 -0400363 fmt.Sprintf("swarm_out_dir=%s", specs.PLACEHOLDER_ISOLATED_OUTDIR),
Eric Boren8b3f9e62017-04-04 09:06:16 -0400364 },
Eric Boren7e3a3642017-06-14 15:25:31 -0400365 Isolate: relpath("bundle_recipes.isolate"),
Kevin Lubick07072942017-05-11 13:35:23 -0400366 Priority: 0.7,
Eric Boren8b3f9e62017-04-04 09:06:16 -0400367 })
368 return BUNDLE_RECIPES_NAME
369}
370
Eric Boren23a6ec62017-04-07 08:31:22 -0400371// useBundledRecipes returns true iff the given bot should use bundled recipes
372// instead of syncing recipe DEPS itself.
373func useBundledRecipes(parts map[string]string) bool {
374 // Use bundled recipes for all test/perf tasks.
375 return true
376}
377
Kevin Lubick07072942017-05-11 13:35:23 -0400378type isolateAssetCfg struct {
379 isolateFile string
380 cipdPkg string
381}
382
383var ISOLATE_ASSET_MAPPING = map[string]isolateAssetCfg{
384 ISOLATE_SKIMAGE_NAME: {
385 isolateFile: "isolate_skimage.isolate",
386 cipdPkg: "skimage",
387 },
388 ISOLATE_SKP_NAME: {
389 isolateFile: "isolate_skp.isolate",
390 cipdPkg: "skp",
391 },
392 ISOLATE_SVG_NAME: {
393 isolateFile: "isolate_svg.isolate",
394 cipdPkg: "svg",
395 },
396}
397
398// bundleRecipes generates the task to bundle and isolate the recipes.
399func isolateCIPDAsset(b *specs.TasksCfgBuilder, name string) string {
400 b.MustAddTask(name, &specs.TaskSpec{
401 CipdPackages: []*specs.CipdPackage{
402 b.MustGetCipdPackageFromAsset(ISOLATE_ASSET_MAPPING[name].cipdPkg),
403 },
404 Dimensions: linuxGceDimensions(),
Eric Boren7e3a3642017-06-14 15:25:31 -0400405 Isolate: relpath(ISOLATE_ASSET_MAPPING[name].isolateFile),
Kevin Lubick07072942017-05-11 13:35:23 -0400406 Priority: 0.7,
407 })
408 return name
409}
410
Kevin Lubick90189522017-05-15 08:30:27 -0400411// getIsolatedCIPDDeps returns the slice of Isolate_* tasks a given task needs.
412// This allows us to save time on I/O bound bots, like the RPIs.
413func getIsolatedCIPDDeps(parts map[string]string) []string {
414 deps := []string{}
Kevin Lubick07072942017-05-11 13:35:23 -0400415 // Only do this on the RPIs for now. Other, faster machines shouldn't see much
416 // benefit and we don't need the extra complexity, for now
Kevin Lubick90189522017-05-15 08:30:27 -0400417 rpiOS := []string{"Android", "ChromeOS", "iOS"}
418
419 if o := parts["os"]; strings.Contains(o, "Chromecast") {
420 // Chromecasts don't have enough disk space to fit all of the content,
421 // so we do a subset of the skps.
422 deps = append(deps, ISOLATE_SKP_NAME)
423 } else if e := parts["extra_config"]; strings.Contains(e, "Skpbench") {
424 // Skpbench only needs skps
425 deps = append(deps, ISOLATE_SKP_NAME)
426 } else if util.In(o, rpiOS) {
427 deps = append(deps, ISOLATE_SKP_NAME)
428 deps = append(deps, ISOLATE_SVG_NAME)
429 deps = append(deps, ISOLATE_SKIMAGE_NAME)
430 }
431
432 return deps
Kevin Lubick07072942017-05-11 13:35:23 -0400433}
434
borenetdb182c72016-09-30 12:53:12 -0700435// compile generates a compile task. Returns the name of the last task in the
436// generated chain of tasks, which the Job should add as a dependency.
boreneted20a702016-10-20 11:04:31 -0700437func compile(b *specs.TasksCfgBuilder, name string, parts map[string]string) string {
borenetdb182c72016-09-30 12:53:12 -0700438 // Collect the necessary CIPD packages.
439 pkgs := []*specs.CipdPackage{}
440
441 // Android bots require a toolchain.
442 if strings.Contains(name, "Android") {
borenetdb182c72016-09-30 12:53:12 -0700443 if strings.Contains(name, "Mac") {
boreneted20a702016-10-20 11:04:31 -0700444 pkgs = append(pkgs, b.MustGetCipdPackageFromAsset("android_ndk_darwin"))
Mike Klein86c2c0f2016-11-02 13:13:16 -0400445 } else if strings.Contains(name, "Win") {
Mike Kleine9215f02016-11-02 15:44:26 -0400446 pkg := b.MustGetCipdPackageFromAsset("android_ndk_windows")
447 pkg.Path = "n"
448 pkgs = append(pkgs, pkg)
borenetdb182c72016-09-30 12:53:12 -0700449 } else {
boreneted20a702016-10-20 11:04:31 -0700450 pkgs = append(pkgs, b.MustGetCipdPackageFromAsset("android_ndk_linux"))
borenetdb182c72016-09-30 12:53:12 -0700451 }
Kevin Lubickdcd2a902017-03-08 14:01:01 -0500452 } else if strings.Contains(name, "Chromecast") {
453 pkgs = append(pkgs, b.MustGetCipdPackageFromAsset("cast_toolchain"))
Kevin Lubickffce0792017-05-24 15:30:35 -0400454 pkgs = append(pkgs, b.MustGetCipdPackageFromAsset("chromebook_arm_gles"))
Kevin Lubick261ea192017-04-05 07:32:45 -0400455 } else if strings.Contains(name, "Chromebook") {
456 pkgs = append(pkgs, b.MustGetCipdPackageFromAsset("clang_linux"))
457 pkgs = append(pkgs, b.MustGetCipdPackageFromAsset("armhf_sysroot"))
Kevin Lubick671cd722017-04-12 10:50:18 -0400458 pkgs = append(pkgs, b.MustGetCipdPackageFromAsset("chromebook_arm_gles"))
Eric Borenbb198fb2017-06-28 11:45:54 -0400459 } else if strings.Contains(name, "Debian") {
Kevin Lubick9c7dcac2017-01-18 09:24:56 -0500460 if strings.Contains(name, "Clang") {
461 pkgs = append(pkgs, b.MustGetCipdPackageFromAsset("clang_linux"))
462 }
463 if strings.Contains(name, "Vulkan") {
464 pkgs = append(pkgs, b.MustGetCipdPackageFromAsset("linux_vulkan_sdk"))
465 }
Mike Klein27dcee12016-11-09 16:31:42 -0500466 } else if strings.Contains(name, "Win") {
boreneted20a702016-10-20 11:04:31 -0700467 pkgs = append(pkgs, b.MustGetCipdPackageFromAsset("win_toolchain"))
borenetdb182c72016-09-30 12:53:12 -0700468 if strings.Contains(name, "Vulkan") {
boreneted20a702016-10-20 11:04:31 -0700469 pkgs = append(pkgs, b.MustGetCipdPackageFromAsset("win_vulkan_sdk"))
borenetdb182c72016-09-30 12:53:12 -0700470 }
471 }
472
Stephan Altmueller5f3b9402017-03-20 13:38:45 -0400473 // TODO(stephana): Remove this once all Mac machines are on the same
474 // OS version again. Move the call to swarmDimensions back to the
475 // creation of the TaskSpec struct below.
476 dimensions := swarmDimensions(parts)
477 if strings.Contains(name, "Mac") {
478 for idx, dim := range dimensions {
479 if strings.HasPrefix(dim, "os") {
480 dimensions[idx] = "os:Mac-10.12"
481 break
482 }
483 }
484 }
485
borenetdb182c72016-09-30 12:53:12 -0700486 // Add the task.
boreneted20a702016-10-20 11:04:31 -0700487 b.MustAddTask(name, &specs.TaskSpec{
borenetdb182c72016-09-30 12:53:12 -0700488 CipdPackages: pkgs,
Stephan Altmueller5f3b9402017-03-20 13:38:45 -0400489 Dimensions: dimensions,
borenetdb182c72016-09-30 12:53:12 -0700490 ExtraArgs: []string{
Eric Boren768f52f2017-04-10 08:14:33 -0400491 "--workdir", "../../..", "compile",
skia.buildbots2478c732016-11-04 14:37:26 -0400492 fmt.Sprintf("repository=%s", specs.PLACEHOLDER_REPO),
borenetdb182c72016-09-30 12:53:12 -0700493 fmt.Sprintf("buildername=%s", name),
borenetdb182c72016-09-30 12:53:12 -0700494 fmt.Sprintf("swarm_out_dir=%s", specs.PLACEHOLDER_ISOLATED_OUTDIR),
495 fmt.Sprintf("revision=%s", specs.PLACEHOLDER_REVISION),
Eric Boren09419502017-04-21 09:37:37 -0400496 fmt.Sprintf("patch_repo=%s", specs.PLACEHOLDER_PATCH_REPO),
borenet98b2e7a2016-10-13 06:23:45 -0700497 fmt.Sprintf("patch_storage=%s", specs.PLACEHOLDER_PATCH_STORAGE),
skia.buildbots2478c732016-11-04 14:37:26 -0400498 fmt.Sprintf("patch_issue=%s", specs.PLACEHOLDER_ISSUE),
499 fmt.Sprintf("patch_set=%s", specs.PLACEHOLDER_PATCHSET),
borenetdb182c72016-09-30 12:53:12 -0700500 },
Eric Boren7e3a3642017-06-14 15:25:31 -0400501 Isolate: relpath("compile_skia.isolate"),
borenetdb182c72016-09-30 12:53:12 -0700502 Priority: 0.8,
boreneted20a702016-10-20 11:04:31 -0700503 })
Eric Boren8615fe52016-12-12 14:30:12 -0500504 // All compile tasks are runnable as their own Job. Assert that the Job
505 // is listed in JOBS.
506 if !util.In(name, JOBS) {
507 glog.Fatalf("Job %q is missing from the JOBS list!", name)
508 }
borenetdb182c72016-09-30 12:53:12 -0700509 return name
510}
511
512// recreateSKPs generates a RecreateSKPs task. Returns the name of the last
513// task in the generated chain of tasks, which the Job should add as a
514// dependency.
boreneted20a702016-10-20 11:04:31 -0700515func recreateSKPs(b *specs.TasksCfgBuilder, name string) string {
Eric Boren4b254b92016-11-08 12:55:32 -0500516 b.MustAddTask(name, &specs.TaskSpec{
Eric Borenf9c09042017-04-17 07:50:20 -0400517 CipdPackages: []*specs.CipdPackage{b.MustGetCipdPackageFromAsset("go")},
Eric Boren27225492017-02-01 15:56:55 -0500518 Dimensions: linuxGceDimensions(),
Eric Borenf5a90e82016-11-15 15:18:20 -0500519 ExecutionTimeout: 4 * time.Hour,
Eric Boren4b254b92016-11-08 12:55:32 -0500520 ExtraArgs: []string{
Eric Boren768f52f2017-04-10 08:14:33 -0400521 "--workdir", "../../..", "recreate_skps",
Eric Boren4b254b92016-11-08 12:55:32 -0500522 fmt.Sprintf("repository=%s", specs.PLACEHOLDER_REPO),
523 fmt.Sprintf("buildername=%s", name),
Eric Boren4b254b92016-11-08 12:55:32 -0500524 fmt.Sprintf("swarm_out_dir=%s", specs.PLACEHOLDER_ISOLATED_OUTDIR),
525 fmt.Sprintf("revision=%s", specs.PLACEHOLDER_REVISION),
Eric Boren09419502017-04-21 09:37:37 -0400526 fmt.Sprintf("patch_repo=%s", specs.PLACEHOLDER_PATCH_REPO),
Eric Boren4b254b92016-11-08 12:55:32 -0500527 fmt.Sprintf("patch_storage=%s", specs.PLACEHOLDER_PATCH_STORAGE),
528 fmt.Sprintf("patch_issue=%s", specs.PLACEHOLDER_ISSUE),
529 fmt.Sprintf("patch_set=%s", specs.PLACEHOLDER_PATCHSET),
530 },
Eric Borenf5a90e82016-11-15 15:18:20 -0500531 IoTimeout: 40 * time.Minute,
Eric Boren7e3a3642017-06-14 15:25:31 -0400532 Isolate: relpath("compile_skia.isolate"),
Eric Borenf5a90e82016-11-15 15:18:20 -0500533 Priority: 0.8,
Eric Boren4b254b92016-11-08 12:55:32 -0500534 })
borenetdb182c72016-09-30 12:53:12 -0700535 return name
536}
537
Ravi Mistry01b48e72017-05-17 14:28:06 -0400538// updateMetaConfig generates a UpdateMetaConfig task. Returns the name of the
539// last task in the generated chain of tasks, which the Job should add as a
540// dependency.
541func updateMetaConfig(b *specs.TasksCfgBuilder, name string) string {
542 b.MustAddTask(name, &specs.TaskSpec{
Stephan Altmuellerddad85b2017-05-19 13:08:19 -0400543 CipdPackages: []*specs.CipdPackage{},
544 Dimensions: linuxGceDimensions(),
Ravi Mistry01b48e72017-05-17 14:28:06 -0400545 ExtraArgs: []string{
546 "--workdir", "../../..", "update_meta_config",
547 fmt.Sprintf("repository=%s", specs.PLACEHOLDER_REPO),
548 fmt.Sprintf("buildername=%s", name),
549 fmt.Sprintf("swarm_out_dir=%s", specs.PLACEHOLDER_ISOLATED_OUTDIR),
550 fmt.Sprintf("revision=%s", specs.PLACEHOLDER_REVISION),
551 fmt.Sprintf("patch_repo=%s", specs.PLACEHOLDER_PATCH_REPO),
552 fmt.Sprintf("patch_storage=%s", specs.PLACEHOLDER_PATCH_STORAGE),
553 fmt.Sprintf("patch_issue=%s", specs.PLACEHOLDER_ISSUE),
554 fmt.Sprintf("patch_set=%s", specs.PLACEHOLDER_PATCHSET),
555 },
Eric Boren7e3a3642017-06-14 15:25:31 -0400556 Isolate: relpath("meta_config.isolate"),
Stephan Altmuellerddad85b2017-05-19 13:08:19 -0400557 Priority: 0.8,
Ravi Mistry01b48e72017-05-17 14:28:06 -0400558 })
559 return name
560}
561
borenetdb182c72016-09-30 12:53:12 -0700562// ctSKPs generates a CT SKPs task. Returns the name of the last task in the
563// generated chain of tasks, which the Job should add as a dependency.
boreneted20a702016-10-20 11:04:31 -0700564func ctSKPs(b *specs.TasksCfgBuilder, name string) string {
Eric Boren4b254b92016-11-08 12:55:32 -0500565 b.MustAddTask(name, &specs.TaskSpec{
566 CipdPackages: []*specs.CipdPackage{},
567 Dimensions: []string{"pool:SkiaCT"},
568 ExecutionTimeout: 24 * time.Hour,
569 ExtraArgs: []string{
Eric Boren768f52f2017-04-10 08:14:33 -0400570 "--workdir", "../../..", "ct_skps",
Eric Boren4b254b92016-11-08 12:55:32 -0500571 fmt.Sprintf("repository=%s", specs.PLACEHOLDER_REPO),
572 fmt.Sprintf("buildername=%s", name),
Eric Boren4b254b92016-11-08 12:55:32 -0500573 fmt.Sprintf("swarm_out_dir=%s", specs.PLACEHOLDER_ISOLATED_OUTDIR),
574 fmt.Sprintf("revision=%s", specs.PLACEHOLDER_REVISION),
Eric Boren09419502017-04-21 09:37:37 -0400575 fmt.Sprintf("patch_repo=%s", specs.PLACEHOLDER_PATCH_REPO),
Eric Boren4b254b92016-11-08 12:55:32 -0500576 fmt.Sprintf("patch_storage=%s", specs.PLACEHOLDER_PATCH_STORAGE),
577 fmt.Sprintf("patch_issue=%s", specs.PLACEHOLDER_ISSUE),
578 fmt.Sprintf("patch_set=%s", specs.PLACEHOLDER_PATCHSET),
579 },
580 IoTimeout: time.Hour,
Eric Boren7e3a3642017-06-14 15:25:31 -0400581 Isolate: relpath("ct_skps_skia.isolate"),
Eric Boren4b254b92016-11-08 12:55:32 -0500582 Priority: 0.8,
583 })
borenetdb182c72016-09-30 12:53:12 -0700584 return name
585}
586
587// housekeeper generates a Housekeeper task. Returns the name of the last task
588// in the generated chain of tasks, which the Job should add as a dependency.
boreneted20a702016-10-20 11:04:31 -0700589func housekeeper(b *specs.TasksCfgBuilder, name, compileTaskName string) string {
Eric Boren4b254b92016-11-08 12:55:32 -0500590 b.MustAddTask(name, &specs.TaskSpec{
Eric Boren22f5ef72016-12-02 11:01:33 -0500591 CipdPackages: []*specs.CipdPackage{b.MustGetCipdPackageFromAsset("go")},
Eric Boren4b254b92016-11-08 12:55:32 -0500592 Dependencies: []string{compileTaskName},
Eric Boren27225492017-02-01 15:56:55 -0500593 Dimensions: linuxGceDimensions(),
Eric Boren4b254b92016-11-08 12:55:32 -0500594 ExtraArgs: []string{
Eric Boren768f52f2017-04-10 08:14:33 -0400595 "--workdir", "../../..", "housekeeper",
Eric Boren4b254b92016-11-08 12:55:32 -0500596 fmt.Sprintf("repository=%s", specs.PLACEHOLDER_REPO),
597 fmt.Sprintf("buildername=%s", name),
Eric Boren4b254b92016-11-08 12:55:32 -0500598 fmt.Sprintf("swarm_out_dir=%s", specs.PLACEHOLDER_ISOLATED_OUTDIR),
599 fmt.Sprintf("revision=%s", specs.PLACEHOLDER_REVISION),
Eric Boren09419502017-04-21 09:37:37 -0400600 fmt.Sprintf("patch_repo=%s", specs.PLACEHOLDER_PATCH_REPO),
Eric Boren4b254b92016-11-08 12:55:32 -0500601 fmt.Sprintf("patch_storage=%s", specs.PLACEHOLDER_PATCH_STORAGE),
602 fmt.Sprintf("patch_issue=%s", specs.PLACEHOLDER_ISSUE),
603 fmt.Sprintf("patch_set=%s", specs.PLACEHOLDER_PATCHSET),
604 },
Eric Boren7e3a3642017-06-14 15:25:31 -0400605 Isolate: relpath("housekeeper_skia.isolate"),
Eric Boren4b254b92016-11-08 12:55:32 -0500606 Priority: 0.8,
607 })
borenetdb182c72016-09-30 12:53:12 -0700608 return name
609}
610
borenet2dbbfa52016-10-14 06:32:09 -0700611// infra generates an infra_tests task. Returns the name of the last task in the
612// generated chain of tasks, which the Job should add as a dependency.
boreneted20a702016-10-20 11:04:31 -0700613func infra(b *specs.TasksCfgBuilder, name string) string {
614 b.MustAddTask(name, &specs.TaskSpec{
Eric Borenade69202017-04-13 10:00:43 -0400615 CipdPackages: []*specs.CipdPackage{b.MustGetCipdPackageFromAsset("go")},
Eric Boren27225492017-02-01 15:56:55 -0500616 Dimensions: linuxGceDimensions(),
borenet2dbbfa52016-10-14 06:32:09 -0700617 ExtraArgs: []string{
Eric Boren768f52f2017-04-10 08:14:33 -0400618 "--workdir", "../../..", "infra",
skia.buildbots2478c732016-11-04 14:37:26 -0400619 fmt.Sprintf("repository=%s", specs.PLACEHOLDER_REPO),
borenet2dbbfa52016-10-14 06:32:09 -0700620 fmt.Sprintf("buildername=%s", name),
borenet2dbbfa52016-10-14 06:32:09 -0700621 fmt.Sprintf("swarm_out_dir=%s", specs.PLACEHOLDER_ISOLATED_OUTDIR),
622 fmt.Sprintf("revision=%s", specs.PLACEHOLDER_REVISION),
Eric Boren09419502017-04-21 09:37:37 -0400623 fmt.Sprintf("patch_repo=%s", specs.PLACEHOLDER_PATCH_REPO),
borenet2dbbfa52016-10-14 06:32:09 -0700624 fmt.Sprintf("patch_storage=%s", specs.PLACEHOLDER_PATCH_STORAGE),
skia.buildbots2478c732016-11-04 14:37:26 -0400625 fmt.Sprintf("patch_issue=%s", specs.PLACEHOLDER_ISSUE),
626 fmt.Sprintf("patch_set=%s", specs.PLACEHOLDER_PATCHSET),
borenet2dbbfa52016-10-14 06:32:09 -0700627 },
Eric Boren7e3a3642017-06-14 15:25:31 -0400628 Isolate: relpath("infra_skia.isolate"),
borenet2dbbfa52016-10-14 06:32:09 -0700629 Priority: 0.8,
boreneted20a702016-10-20 11:04:31 -0700630 })
borenet2dbbfa52016-10-14 06:32:09 -0700631 return name
632}
633
borenetdb182c72016-09-30 12:53:12 -0700634// doUpload indicates whether the given Job should upload its results.
635func doUpload(name string) bool {
Eric Boren27225492017-02-01 15:56:55 -0500636 for _, s := range CONFIG.NoUpload {
637 m, err := regexp.MatchString(s, name)
638 if err != nil {
639 glog.Fatal(err)
640 }
641 if m {
borenetdb182c72016-09-30 12:53:12 -0700642 return false
643 }
644 }
645 return true
646}
647
648// test generates a Test task. Returns the name of the last task in the
649// generated chain of tasks, which the Job should add as a dependency.
boreneted20a702016-10-20 11:04:31 -0700650func test(b *specs.TasksCfgBuilder, name string, parts map[string]string, compileTaskName string, pkgs []*specs.CipdPackage) string {
Eric Boren4b254b92016-11-08 12:55:32 -0500651 s := &specs.TaskSpec{
Eric Boren1f2f64b2016-11-09 18:35:15 -0500652 CipdPackages: pkgs,
653 Dependencies: []string{compileTaskName},
654 Dimensions: swarmDimensions(parts),
655 ExecutionTimeout: 4 * time.Hour,
656 Expiration: 20 * time.Hour,
borenetdb182c72016-09-30 12:53:12 -0700657 ExtraArgs: []string{
Eric Boren768f52f2017-04-10 08:14:33 -0400658 "--workdir", "../../..", "test",
skia.buildbots2478c732016-11-04 14:37:26 -0400659 fmt.Sprintf("repository=%s", specs.PLACEHOLDER_REPO),
borenetdb182c72016-09-30 12:53:12 -0700660 fmt.Sprintf("buildername=%s", name),
borenetdb182c72016-09-30 12:53:12 -0700661 fmt.Sprintf("swarm_out_dir=%s", specs.PLACEHOLDER_ISOLATED_OUTDIR),
662 fmt.Sprintf("revision=%s", specs.PLACEHOLDER_REVISION),
Eric Boren09419502017-04-21 09:37:37 -0400663 fmt.Sprintf("patch_repo=%s", specs.PLACEHOLDER_PATCH_REPO),
borenet98b2e7a2016-10-13 06:23:45 -0700664 fmt.Sprintf("patch_storage=%s", specs.PLACEHOLDER_PATCH_STORAGE),
skia.buildbots2478c732016-11-04 14:37:26 -0400665 fmt.Sprintf("patch_issue=%s", specs.PLACEHOLDER_ISSUE),
666 fmt.Sprintf("patch_set=%s", specs.PLACEHOLDER_PATCHSET),
borenetdb182c72016-09-30 12:53:12 -0700667 },
Eric Boren5d9f3bf2017-02-22 08:36:03 -0500668 IoTimeout: 40 * time.Minute,
Eric Boren7e3a3642017-06-14 15:25:31 -0400669 Isolate: relpath("test_skia.isolate"),
Eric Boren5d9f3bf2017-02-22 08:36:03 -0500670 MaxAttempts: 1,
671 Priority: 0.8,
Eric Boren4b254b92016-11-08 12:55:32 -0500672 }
Eric Boren23a6ec62017-04-07 08:31:22 -0400673 if useBundledRecipes(parts) {
Eric Boren8b3f9e62017-04-04 09:06:16 -0400674 s.Dependencies = append(s.Dependencies, BUNDLE_RECIPES_NAME)
Eric Boren23a6ec62017-04-07 08:31:22 -0400675 if strings.Contains(parts["os"], "Win") {
Eric Boren7e3a3642017-06-14 15:25:31 -0400676 s.Isolate = relpath("test_skia_bundled_win.isolate")
Eric Boren23a6ec62017-04-07 08:31:22 -0400677 } else {
Eric Boren7e3a3642017-06-14 15:25:31 -0400678 s.Isolate = relpath("test_skia_bundled_unix.isolate")
Eric Boren23a6ec62017-04-07 08:31:22 -0400679 }
Eric Boren8b3f9e62017-04-04 09:06:16 -0400680 }
Kevin Lubick90189522017-05-15 08:30:27 -0400681 if deps := getIsolatedCIPDDeps(parts); len(deps) > 0 {
682 s.Dependencies = append(s.Dependencies, deps...)
Kevin Lubick07072942017-05-11 13:35:23 -0400683 }
Eric Boren4b254b92016-11-08 12:55:32 -0500684 if strings.Contains(parts["extra_config"], "Valgrind") {
685 s.ExecutionTimeout = 9 * time.Hour
686 s.Expiration = 48 * time.Hour
687 s.IoTimeout = time.Hour
Eric Borend696df72017-05-31 15:09:10 -0400688 s.CipdPackages = append(s.CipdPackages, b.MustGetCipdPackageFromAsset("valgrind"))
Eric Boren4b254b92016-11-08 12:55:32 -0500689 } else if strings.Contains(parts["extra_config"], "MSAN") {
690 s.ExecutionTimeout = 9 * time.Hour
Ben Wagnera6b2ba22017-06-08 10:34:17 -0400691 } else if parts["arch"] == "x86" && parts["configuration"] == "Debug" {
692 // skia:6737
693 s.ExecutionTimeout = 6 * time.Hour
Eric Boren4b254b92016-11-08 12:55:32 -0500694 }
695 b.MustAddTask(name, s)
696
borenetdb182c72016-09-30 12:53:12 -0700697 // Upload results if necessary.
698 if doUpload(name) {
699 uploadName := fmt.Sprintf("%s%s%s", PREFIX_UPLOAD, jobNameSchema.Sep, name)
boreneted20a702016-10-20 11:04:31 -0700700 b.MustAddTask(uploadName, &specs.TaskSpec{
borenetdb182c72016-09-30 12:53:12 -0700701 Dependencies: []string{name},
Eric Boren27225492017-02-01 15:56:55 -0500702 Dimensions: linuxGceDimensions(),
borenetdb182c72016-09-30 12:53:12 -0700703 ExtraArgs: []string{
704 "--workdir", "../../..", "upload_dm_results",
skia.buildbots2478c732016-11-04 14:37:26 -0400705 fmt.Sprintf("repository=%s", specs.PLACEHOLDER_REPO),
borenetdb182c72016-09-30 12:53:12 -0700706 fmt.Sprintf("buildername=%s", name),
borenetdb182c72016-09-30 12:53:12 -0700707 fmt.Sprintf("swarm_out_dir=%s", specs.PLACEHOLDER_ISOLATED_OUTDIR),
708 fmt.Sprintf("revision=%s", specs.PLACEHOLDER_REVISION),
Eric Boren09419502017-04-21 09:37:37 -0400709 fmt.Sprintf("patch_repo=%s", specs.PLACEHOLDER_PATCH_REPO),
borenet98b2e7a2016-10-13 06:23:45 -0700710 fmt.Sprintf("patch_storage=%s", specs.PLACEHOLDER_PATCH_STORAGE),
skia.buildbots2478c732016-11-04 14:37:26 -0400711 fmt.Sprintf("patch_issue=%s", specs.PLACEHOLDER_ISSUE),
712 fmt.Sprintf("patch_set=%s", specs.PLACEHOLDER_PATCHSET),
Eric Boren965861b2017-02-06 15:38:41 -0500713 fmt.Sprintf("gs_bucket=%s", CONFIG.GsBucketGm),
borenetdb182c72016-09-30 12:53:12 -0700714 },
Eric Boren7e3a3642017-06-14 15:25:31 -0400715 Isolate: relpath("upload_dm_results.isolate"),
borenetdb182c72016-09-30 12:53:12 -0700716 Priority: 0.8,
boreneted20a702016-10-20 11:04:31 -0700717 })
borenetdb182c72016-09-30 12:53:12 -0700718 return uploadName
719 }
720 return name
721}
722
723// perf generates a Perf task. Returns the name of the last task in the
724// generated chain of tasks, which the Job should add as a dependency.
boreneted20a702016-10-20 11:04:31 -0700725func perf(b *specs.TasksCfgBuilder, name string, parts map[string]string, compileTaskName string, pkgs []*specs.CipdPackage) string {
Eric Boren768f52f2017-04-10 08:14:33 -0400726 recipe := "perf"
Eric Boren7e3a3642017-06-14 15:25:31 -0400727 isolate := relpath("perf_skia.isolate")
Kevin Lubickb03b5ac2016-11-14 13:42:27 -0500728 if strings.Contains(parts["extra_config"], "Skpbench") {
Eric Boren768f52f2017-04-10 08:14:33 -0400729 recipe = "skpbench"
Eric Boren7e3a3642017-06-14 15:25:31 -0400730 isolate = relpath("skpbench_skia.isolate")
Eric Boren23a6ec62017-04-07 08:31:22 -0400731 if useBundledRecipes(parts) {
732 if strings.Contains(parts["os"], "Win") {
Eric Boren7e3a3642017-06-14 15:25:31 -0400733 isolate = relpath("skpbench_skia_bundled_win.isolate")
Eric Boren23a6ec62017-04-07 08:31:22 -0400734 } else {
Eric Boren7e3a3642017-06-14 15:25:31 -0400735 isolate = relpath("skpbench_skia_bundled_unix.isolate")
Eric Boren23a6ec62017-04-07 08:31:22 -0400736 }
Eric Boren8b3f9e62017-04-04 09:06:16 -0400737 }
Eric Boren23a6ec62017-04-07 08:31:22 -0400738 } else if useBundledRecipes(parts) {
739 if strings.Contains(parts["os"], "Win") {
Eric Boren7e3a3642017-06-14 15:25:31 -0400740 isolate = relpath("perf_skia_bundled_win.isolate")
Eric Boren23a6ec62017-04-07 08:31:22 -0400741 } else {
Eric Boren7e3a3642017-06-14 15:25:31 -0400742 isolate = relpath("perf_skia_bundled_unix.isolate")
Eric Boren23a6ec62017-04-07 08:31:22 -0400743 }
Kevin Lubickb03b5ac2016-11-14 13:42:27 -0500744 }
Eric Boren4b254b92016-11-08 12:55:32 -0500745 s := &specs.TaskSpec{
Eric Boren1f2f64b2016-11-09 18:35:15 -0500746 CipdPackages: pkgs,
747 Dependencies: []string{compileTaskName},
748 Dimensions: swarmDimensions(parts),
749 ExecutionTimeout: 4 * time.Hour,
750 Expiration: 20 * time.Hour,
borenetdb182c72016-09-30 12:53:12 -0700751 ExtraArgs: []string{
Kevin Lubickb03b5ac2016-11-14 13:42:27 -0500752 "--workdir", "../../..", recipe,
skia.buildbots2478c732016-11-04 14:37:26 -0400753 fmt.Sprintf("repository=%s", specs.PLACEHOLDER_REPO),
borenetdb182c72016-09-30 12:53:12 -0700754 fmt.Sprintf("buildername=%s", name),
borenetdb182c72016-09-30 12:53:12 -0700755 fmt.Sprintf("swarm_out_dir=%s", specs.PLACEHOLDER_ISOLATED_OUTDIR),
756 fmt.Sprintf("revision=%s", specs.PLACEHOLDER_REVISION),
Eric Boren09419502017-04-21 09:37:37 -0400757 fmt.Sprintf("patch_repo=%s", specs.PLACEHOLDER_PATCH_REPO),
borenet98b2e7a2016-10-13 06:23:45 -0700758 fmt.Sprintf("patch_storage=%s", specs.PLACEHOLDER_PATCH_STORAGE),
skia.buildbots2478c732016-11-04 14:37:26 -0400759 fmt.Sprintf("patch_issue=%s", specs.PLACEHOLDER_ISSUE),
760 fmt.Sprintf("patch_set=%s", specs.PLACEHOLDER_PATCHSET),
borenetdb182c72016-09-30 12:53:12 -0700761 },
Eric Boren5d9f3bf2017-02-22 08:36:03 -0500762 IoTimeout: 40 * time.Minute,
763 Isolate: isolate,
764 MaxAttempts: 1,
765 Priority: 0.8,
Eric Boren4b254b92016-11-08 12:55:32 -0500766 }
Eric Boren23a6ec62017-04-07 08:31:22 -0400767 if useBundledRecipes(parts) {
Eric Boren8b3f9e62017-04-04 09:06:16 -0400768 s.Dependencies = append(s.Dependencies, BUNDLE_RECIPES_NAME)
769 }
Kevin Lubick90189522017-05-15 08:30:27 -0400770 if deps := getIsolatedCIPDDeps(parts); len(deps) > 0 {
771 s.Dependencies = append(s.Dependencies, deps...)
772 }
773
Eric Boren4b254b92016-11-08 12:55:32 -0500774 if strings.Contains(parts["extra_config"], "Valgrind") {
775 s.ExecutionTimeout = 9 * time.Hour
776 s.Expiration = 48 * time.Hour
777 s.IoTimeout = time.Hour
Eric Borenc5a073d2017-06-01 07:13:33 -0400778 s.CipdPackages = append(s.CipdPackages, b.MustGetCipdPackageFromAsset("valgrind"))
Eric Boren4b254b92016-11-08 12:55:32 -0500779 } else if strings.Contains(parts["extra_config"], "MSAN") {
780 s.ExecutionTimeout = 9 * time.Hour
Ben Wagnera6b2ba22017-06-08 10:34:17 -0400781 } else if parts["arch"] == "x86" && parts["configuration"] == "Debug" {
782 // skia:6737
783 s.ExecutionTimeout = 6 * time.Hour
Eric Boren4b254b92016-11-08 12:55:32 -0500784 }
785 b.MustAddTask(name, s)
786
borenetdb182c72016-09-30 12:53:12 -0700787 // Upload results if necessary.
788 if strings.Contains(name, "Release") && doUpload(name) {
789 uploadName := fmt.Sprintf("%s%s%s", PREFIX_UPLOAD, jobNameSchema.Sep, name)
boreneted20a702016-10-20 11:04:31 -0700790 b.MustAddTask(uploadName, &specs.TaskSpec{
borenetdb182c72016-09-30 12:53:12 -0700791 Dependencies: []string{name},
Eric Boren27225492017-02-01 15:56:55 -0500792 Dimensions: linuxGceDimensions(),
borenetdb182c72016-09-30 12:53:12 -0700793 ExtraArgs: []string{
794 "--workdir", "../../..", "upload_nano_results",
skia.buildbots2478c732016-11-04 14:37:26 -0400795 fmt.Sprintf("repository=%s", specs.PLACEHOLDER_REPO),
borenetdb182c72016-09-30 12:53:12 -0700796 fmt.Sprintf("buildername=%s", name),
borenetdb182c72016-09-30 12:53:12 -0700797 fmt.Sprintf("swarm_out_dir=%s", specs.PLACEHOLDER_ISOLATED_OUTDIR),
798 fmt.Sprintf("revision=%s", specs.PLACEHOLDER_REVISION),
Eric Boren09419502017-04-21 09:37:37 -0400799 fmt.Sprintf("patch_repo=%s", specs.PLACEHOLDER_PATCH_REPO),
borenet98b2e7a2016-10-13 06:23:45 -0700800 fmt.Sprintf("patch_storage=%s", specs.PLACEHOLDER_PATCH_STORAGE),
skia.buildbots2478c732016-11-04 14:37:26 -0400801 fmt.Sprintf("patch_issue=%s", specs.PLACEHOLDER_ISSUE),
802 fmt.Sprintf("patch_set=%s", specs.PLACEHOLDER_PATCHSET),
Eric Boren965861b2017-02-06 15:38:41 -0500803 fmt.Sprintf("gs_bucket=%s", CONFIG.GsBucketNano),
borenetdb182c72016-09-30 12:53:12 -0700804 },
Eric Boren7e3a3642017-06-14 15:25:31 -0400805 Isolate: relpath("upload_nano_results.isolate"),
borenetdb182c72016-09-30 12:53:12 -0700806 Priority: 0.8,
boreneted20a702016-10-20 11:04:31 -0700807 })
borenetdb182c72016-09-30 12:53:12 -0700808 return uploadName
809 }
810 return name
811}
812
813// process generates tasks and jobs for the given job name.
boreneted20a702016-10-20 11:04:31 -0700814func process(b *specs.TasksCfgBuilder, name string) {
borenetdb182c72016-09-30 12:53:12 -0700815 deps := []string{}
816
Eric Boren8b3f9e62017-04-04 09:06:16 -0400817 // Bundle Recipes.
818 if name == BUNDLE_RECIPES_NAME {
819 deps = append(deps, bundleRecipes(b))
820 }
821
Kevin Lubick07072942017-05-11 13:35:23 -0400822 // Isolate CIPD assets.
Kevin Lubick07072942017-05-11 13:35:23 -0400823 if _, ok := ISOLATE_ASSET_MAPPING[name]; ok {
824 deps = append(deps, isolateCIPDAsset(b, name))
825 }
826
borenetdb182c72016-09-30 12:53:12 -0700827 parts, err := jobNameSchema.ParseJobName(name)
828 if err != nil {
829 glog.Fatal(err)
830 }
831
832 // RecreateSKPs.
833 if strings.Contains(name, "RecreateSKPs") {
boreneted20a702016-10-20 11:04:31 -0700834 deps = append(deps, recreateSKPs(b, name))
borenetdb182c72016-09-30 12:53:12 -0700835 }
836
Ravi Mistry01b48e72017-05-17 14:28:06 -0400837 // UpdateMetaConfig bot.
838 if strings.Contains(name, "UpdateMetaConfig") {
839 deps = append(deps, updateMetaConfig(b, name))
840 }
841
borenetdb182c72016-09-30 12:53:12 -0700842 // CT bots.
843 if strings.Contains(name, "-CT_") {
boreneted20a702016-10-20 11:04:31 -0700844 deps = append(deps, ctSKPs(b, name))
borenetdb182c72016-09-30 12:53:12 -0700845 }
846
borenet2dbbfa52016-10-14 06:32:09 -0700847 // Infra tests.
848 if name == "Housekeeper-PerCommit-InfraTests" {
boreneted20a702016-10-20 11:04:31 -0700849 deps = append(deps, infra(b, name))
borenet2dbbfa52016-10-14 06:32:09 -0700850 }
851
borenetdb182c72016-09-30 12:53:12 -0700852 // Compile bots.
853 if parts["role"] == "Build" {
boreneted20a702016-10-20 11:04:31 -0700854 deps = append(deps, compile(b, name, parts))
borenetdb182c72016-09-30 12:53:12 -0700855 }
856
Eric Borenf5a90e82016-11-15 15:18:20 -0500857 // Most remaining bots need a compile task.
borenetdb182c72016-09-30 12:53:12 -0700858 compileTaskName := deriveCompileTaskName(name, parts)
borenet52383432016-10-17 10:17:53 -0700859 compileTaskParts, err := jobNameSchema.ParseJobName(compileTaskName)
860 if err != nil {
861 glog.Fatal(err)
862 }
Eric Boren628e78b2016-11-17 11:33:27 -0500863 // These bots do not need a compile task.
Eric Borenf5a90e82016-11-15 15:18:20 -0500864 if parts["role"] != "Build" &&
Eric Borenb8ab7f72017-04-10 11:00:09 -0400865 name != "Housekeeper-PerCommit-BundleRecipes" &&
Eric Borenf5a90e82016-11-15 15:18:20 -0500866 name != "Housekeeper-PerCommit-InfraTests" &&
Eric Boren71b762f2016-11-30 14:05:16 -0500867 !strings.Contains(name, "RecreateSKPs") &&
Ravi Mistry01b48e72017-05-17 14:28:06 -0400868 !strings.Contains(name, "UpdateMetaConfig") &&
Ben Wagner50b84682017-06-12 13:03:29 -0400869 !strings.Contains(name, "-CT_") &&
870 !strings.Contains(name, "Housekeeper-PerCommit-Isolate") {
boreneted20a702016-10-20 11:04:31 -0700871 compile(b, compileTaskName, compileTaskParts)
borenet52383432016-10-17 10:17:53 -0700872 }
borenetdb182c72016-09-30 12:53:12 -0700873
874 // Housekeeper.
Eric Boren22f5ef72016-12-02 11:01:33 -0500875 if name == "Housekeeper-PerCommit" {
boreneted20a702016-10-20 11:04:31 -0700876 deps = append(deps, housekeeper(b, name, compileTaskName))
borenetdb182c72016-09-30 12:53:12 -0700877 }
878
879 // Common assets needed by the remaining bots.
Kevin Lubick07072942017-05-11 13:35:23 -0400880
881 pkgs := []*specs.CipdPackage{}
882
Kevin Lubick90189522017-05-15 08:30:27 -0400883 if deps := getIsolatedCIPDDeps(parts); len(deps) == 0 {
Kevin Lubick07072942017-05-11 13:35:23 -0400884 pkgs = []*specs.CipdPackage{
885 b.MustGetCipdPackageFromAsset("skimage"),
886 b.MustGetCipdPackageFromAsset("skp"),
887 b.MustGetCipdPackageFromAsset("svg"),
888 }
borenetdb182c72016-09-30 12:53:12 -0700889 }
Kevin Lubick90189522017-05-15 08:30:27 -0400890
Eric Boren25062cf2017-06-29 15:22:46 -0400891 if (strings.Contains(name, "Ubuntu") || strings.Contains(name, "Debian")) && strings.Contains(name, "SAN") {
Eric Boren4b254b92016-11-08 12:55:32 -0500892 pkgs = append(pkgs, b.MustGetCipdPackageFromAsset("clang_linux"))
893 }
Kevin Lubick35115eb2017-02-17 10:25:34 -0500894 if strings.Contains(name, "Ubuntu16") {
895 if strings.Contains(name, "Vulkan") {
896 pkgs = append(pkgs, b.MustGetCipdPackageFromAsset("linux_vulkan_sdk"))
897 }
Kevin Lubick0a51b482017-02-06 12:45:29 -0500898 if strings.Contains(name, "Release") {
899 pkgs = append(pkgs, b.MustGetCipdPackageFromAsset("linux_vulkan_intel_driver_release"))
900 } else {
901 pkgs = append(pkgs, b.MustGetCipdPackageFromAsset("linux_vulkan_intel_driver_debug"))
902 }
903 }
borenetdb182c72016-09-30 12:53:12 -0700904
905 // Test bots.
Eric Boren71b762f2016-11-30 14:05:16 -0500906 if parts["role"] == "Test" && !strings.Contains(name, "-CT_") {
boreneted20a702016-10-20 11:04:31 -0700907 deps = append(deps, test(b, name, parts, compileTaskName, pkgs))
borenetdb182c72016-09-30 12:53:12 -0700908 }
909
910 // Perf bots.
Eric Boren71b762f2016-11-30 14:05:16 -0500911 if parts["role"] == "Perf" && !strings.Contains(name, "-CT_") {
boreneted20a702016-10-20 11:04:31 -0700912 deps = append(deps, perf(b, name, parts, compileTaskName, pkgs))
borenetdb182c72016-09-30 12:53:12 -0700913 }
914
915 // Add the Job spec.
Eric Borenf5a90e82016-11-15 15:18:20 -0500916 j := &specs.JobSpec{
borenetdb182c72016-09-30 12:53:12 -0700917 Priority: 0.8,
918 TaskSpecs: deps,
Eric Borenf5a90e82016-11-15 15:18:20 -0500919 }
920 if name == "Housekeeper-Nightly-RecreateSKPs_Canary" {
921 j.Trigger = "nightly"
922 }
Ravi Mistry01b48e72017-05-17 14:28:06 -0400923 if name == "Housekeeper-Nightly-UpdateMetaConfig" {
924 j.Trigger = "nightly"
925 }
Eric Borenf5a90e82016-11-15 15:18:20 -0500926 if name == "Housekeeper-Weekly-RecreateSKPs" {
927 j.Trigger = "weekly"
928 }
Eric Borenbb198fb2017-06-28 11:45:54 -0400929 if name == "Test-Ubuntu14-GCC-GCE-CPU-AVX2-x86_64-Debug-CT_DM_1m_SKPs" {
Eric Boren71b762f2016-11-30 14:05:16 -0500930 j.Trigger = "weekly"
931 }
Eric Boren8615fe52016-12-12 14:30:12 -0500932 b.MustAddJob(name, j)
borenetdb182c72016-09-30 12:53:12 -0700933}
934
Eric Boren27225492017-02-01 15:56:55 -0500935func loadJson(flag *string, defaultFlag string, val interface{}) {
936 if *flag == "" {
937 *flag = defaultFlag
938 }
939 b, err := ioutil.ReadFile(*flag)
940 if err != nil {
941 glog.Fatal(err)
942 }
943 if err := json.Unmarshal(b, val); err != nil {
944 glog.Fatal(err)
945 }
946}
947
borenetdb182c72016-09-30 12:53:12 -0700948// Regenerate the tasks.json file.
949func main() {
boreneted20a702016-10-20 11:04:31 -0700950 b := specs.MustNewTasksCfgBuilder()
Eric Boren27225492017-02-01 15:56:55 -0500951 b.SetAssetsDir(*assetsDir)
952 infraBots := path.Join(b.CheckoutRoot(), "infra", "bots")
953
954 // Load the jobs from a JSON file.
955 loadJson(jobsFile, path.Join(infraBots, "jobs.json"), &JOBS)
956
Eric Boren27225492017-02-01 15:56:55 -0500957 // Load general config information from a JSON file.
958 loadJson(cfgFile, path.Join(infraBots, "cfg.json"), &CONFIG)
959
borenetdb182c72016-09-30 12:53:12 -0700960 // Create the JobNameSchema.
Eric Boren1f8be682017-02-07 09:16:30 -0500961 if *builderNameSchemaFile == "" {
962 *builderNameSchemaFile = path.Join(b.CheckoutRoot(), "infra", "bots", "recipe_modules", "builder_name_schema", "builder_name_schema.json")
963 }
964 schema, err := NewJobNameSchema(*builderNameSchemaFile)
borenetdb182c72016-09-30 12:53:12 -0700965 if err != nil {
966 glog.Fatal(err)
967 }
968 jobNameSchema = schema
969
borenetdb182c72016-09-30 12:53:12 -0700970 // Create Tasks and Jobs.
boreneted20a702016-10-20 11:04:31 -0700971 for _, name := range JOBS {
972 process(b, name)
borenetdb182c72016-09-30 12:53:12 -0700973 }
974
boreneted20a702016-10-20 11:04:31 -0700975 b.MustFinish()
borenetdb182c72016-09-30 12:53:12 -0700976}
977
978// TODO(borenet): The below really belongs in its own file, probably next to the
979// builder_name_schema.json file.
980
981// JobNameSchema is a struct used for (de)constructing Job names in a
982// predictable format.
983type JobNameSchema struct {
984 Schema map[string][]string `json:"builder_name_schema"`
985 Sep string `json:"builder_name_sep"`
986}
987
988// NewJobNameSchema returns a JobNameSchema instance based on the given JSON
989// file.
990func NewJobNameSchema(jsonFile string) (*JobNameSchema, error) {
991 var rv JobNameSchema
992 f, err := os.Open(jsonFile)
993 if err != nil {
994 return nil, err
995 }
996 defer util.Close(f)
997 if err := json.NewDecoder(f).Decode(&rv); err != nil {
998 return nil, err
999 }
1000 return &rv, nil
1001}
1002
1003// ParseJobName splits the given Job name into its component parts, according
1004// to the schema.
1005func (s *JobNameSchema) ParseJobName(n string) (map[string]string, error) {
1006 split := strings.Split(n, s.Sep)
1007 if len(split) < 2 {
1008 return nil, fmt.Errorf("Invalid job name: %q", n)
1009 }
1010 role := split[0]
1011 split = split[1:]
1012 keys, ok := s.Schema[role]
1013 if !ok {
1014 return nil, fmt.Errorf("Invalid job name; %q is not a valid role.", role)
1015 }
1016 extraConfig := ""
1017 if len(split) == len(keys)+1 {
1018 extraConfig = split[len(split)-1]
1019 split = split[:len(split)-1]
1020 }
1021 if len(split) != len(keys) {
1022 return nil, fmt.Errorf("Invalid job name; %q has incorrect number of parts.", n)
1023 }
1024 rv := make(map[string]string, len(keys)+2)
1025 rv["role"] = role
1026 if extraConfig != "" {
1027 rv["extra_config"] = extraConfig
1028 }
1029 for i, k := range keys {
1030 rv[k] = split[i]
1031 }
1032 return rv, nil
1033}
1034
1035// MakeJobName assembles the given parts of a Job name, according to the schema.
1036func (s *JobNameSchema) MakeJobName(parts map[string]string) (string, error) {
1037 role, ok := parts["role"]
1038 if !ok {
1039 return "", fmt.Errorf("Invalid job parts; jobs must have a role.")
1040 }
1041 keys, ok := s.Schema[role]
1042 if !ok {
1043 return "", fmt.Errorf("Invalid job parts; unknown role %q", role)
1044 }
1045 rvParts := make([]string, 0, len(parts))
1046 rvParts = append(rvParts, role)
1047 for _, k := range keys {
1048 v, ok := parts[k]
1049 if !ok {
1050 return "", fmt.Errorf("Invalid job parts; missing %q", k)
1051 }
1052 rvParts = append(rvParts, v)
1053 }
1054 if _, ok := parts["extra_config"]; ok {
1055 rvParts = append(rvParts, parts["extra_config"])
1056 }
1057 return strings.Join(rvParts, s.Sep), nil
1058}